⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 5, 2019:

10:18 PM Changeset in webkit [244958] by bshafiei@apple.com
  • 7 edits in tags/Safari-608.1.20.0.2/Source

Versioning.

10:16 PM Changeset in webkit [244957] by bshafiei@apple.com
  • 1 copy in tags/Safari-608.1.20.0.2

New tag.

3:45 AM Changeset in webkit [244956] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

fast/attachment/attachment-folder-icon.html is an Image Only failure on recent macOS builds
​https://bugs.webkit.org/show_bug.cgi?id=197593
<rdar://problem/50379267>

Reviewed by Tim Horton.

On recent versions of macOS, -[NSWorkspace iconForFileType:] returns the generic document icon for
"public.directory". Instead of using this UTI to generate attachment icons for "multipart/x-folder" and
"application/vnd.apple.folder", we should instead be using "public.folder", which has a folder icon. This fixes
the existing test fast/attachment/attachment-folder-icon.html, which currently results in an image diff on these
builds of macOS.

  • rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):

May 4, 2019:

9:31 PM Changeset in webkit [244955] by achristensen@apple.com
  • 101 edits
    2 adds in trunk

Revert r244953 and r244954 because they broke internal builds.
​https://bugs.webkit.org/show_bug.cgi?id=197534

Source/WebCore:

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::changeCount const):
(WebCore::PlatformPasteboard::write):

Source/WebCore/PAL:

  • pal/spi/ios/UIKitSPI.h:

(currentUserInterfaceIdiomIsPad): Deleted.

Source/WebKit:

  • Platform/spi/ios/PDFKitSPI.h:
  • Platform/spi/ios/UIKitSPI.h: Added.

(currentUserInterfaceIdiomIsPad):

  • Shared/DocumentEditingContext.mm:
  • Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
  • Shared/ios/NativeWebKeyboardEventIOS.mm:
  • Shared/ios/NativeWebTouchEventIOS.mm:
  • Shared/ios/WebIconUtilities.mm:
  • UIProcess/API/Cocoa/NSAttributedString.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/ApplicationStateTracker.mm:
  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
  • UIProcess/Cocoa/WKShareSheet.mm:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:
  • UIProcess/Gamepad/ios/UIGamepadProviderIOS.mm:
  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
  • UIProcess/WKImagePreviewViewController.mm:
  • UIProcess/_WKTouchEventGenerator.mm:
  • UIProcess/ios/DragDropInteractionState.h:
  • UIProcess/ios/InputViewUpdateDeferrer.mm:
  • UIProcess/ios/PageClientImplIOS.mm:
  • UIProcess/ios/SmartMagnificationController.mm:
  • UIProcess/ios/TextCheckerIOS.mm:
  • UIProcess/ios/ViewGestureControllerIOS.mm:
  • UIProcess/ios/WKActionSheet.mm:
  • UIProcess/ios/WKActionSheetAssistant.mm:
  • UIProcess/ios/WKContentView.mm:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:
  • UIProcess/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm:
  • UIProcess/ios/WKKeyboardScrollingAnimator.mm:
  • UIProcess/ios/WKPDFPageNumberIndicator.mm:
  • UIProcess/ios/WKPDFView.mm:
  • UIProcess/ios/WKPasswordView.mm:
  • UIProcess/ios/WKScrollView.h:
  • UIProcess/ios/WKScrollView.mm:
  • UIProcess/ios/WKSyntheticTapGestureRecognizer.h:
  • UIProcess/ios/WKWebEvent.mm:
  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.h:
  • UIProcess/ios/WebPageProxyIOS.mm:
  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
  • UIProcess/ios/forms/WKFileUploadPanel.mm:
  • UIProcess/ios/forms/WKFocusedFormControlView.h:
  • UIProcess/ios/forms/WKFormColorControl.mm:
  • UIProcess/ios/forms/WKFormColorPicker.mm:
  • UIProcess/ios/forms/WKFormInputControl.mm:
  • UIProcess/ios/forms/WKFormPopover.mm:
  • UIProcess/ios/forms/WKFormSelectControl.h:
  • UIProcess/ios/forms/WKFormSelectControl.mm:
  • UIProcess/ios/forms/WKFormSelectPicker.mm:
  • UIProcess/ios/forms/WKFormSelectPopover.mm:
  • UIProcess/ios/forms/WKNumberPadViewController.mm:
  • UIProcess/ios/forms/WKQuickboardListViewController.h:
  • UIProcess/ios/forms/WKSelectMenuListViewController.mm:
  • UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
  • UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
  • UIProcess/ios/fullscreen/WKFullscreenStackView.mm:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
  • WebProcess/WebPage/ios/WebPageIOS.mm:
  • WebProcess/cocoa/WebProcessCocoa.mm:

Tools:

  • DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeWindow.h:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
  • TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
  • TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
  • TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
  • TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
  • TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
  • TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
  • TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
  • TestWebKitAPI/cocoa/DragAndDropSimulator.h:
  • TestWebKitAPI/cocoa/TestWKWebView.mm:
  • TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
  • TestWebKitAPI/ios/UIKitSPI.h: Added.
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
  • WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
  • WebKitTestRunner/ios/HIDEventGenerator.h:
  • WebKitTestRunner/ios/HIDEventGenerator.mm:
  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:
  • WebKitTestRunner/ios/TestControllerIOS.mm:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:
  • WebKitTestRunner/ios/mainIOS.mm:
8:29 PM Changeset in webkit [244954] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore/PAL

Fix internal build.
​https://bugs.webkit.org/show_bug.cgi?id=197534

  • pal/spi/ios/UIKitSPI.h:
8:01 PM Changeset in webkit [244953] by achristensen@apple.com
  • 102 edits
    2 deletes in trunk

Merge the three UIKitSPI.h files into a single one in PAL
​https://bugs.webkit.org/show_bug.cgi?id=197534

Reviewed by Darin Adler.

Source/WebCore:

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::changeCount const):
(WebCore::PlatformPasteboard::write):

Source/WebCore/PAL:

  • pal/spi/ios/UIKitSPI.h:

(currentUserInterfaceIdiomIsPad):

Source/WebKit:

  • Platform/spi/ios/PDFKitSPI.h:
  • Platform/spi/ios/UIKitSPI.h: Removed.
  • Shared/DocumentEditingContext.mm:
  • Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
  • Shared/ios/NativeWebKeyboardEventIOS.mm:
  • Shared/ios/NativeWebTouchEventIOS.mm:
  • Shared/ios/WebIconUtilities.mm:
  • UIProcess/API/Cocoa/NSAttributedString.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/ApplicationStateTracker.mm:
  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
  • UIProcess/Cocoa/WKShareSheet.mm:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:
  • UIProcess/Gamepad/ios/UIGamepadProviderIOS.mm:
  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
  • UIProcess/WKImagePreviewViewController.mm:
  • UIProcess/_WKTouchEventGenerator.mm:
  • UIProcess/ios/DragDropInteractionState.h:
  • UIProcess/ios/InputViewUpdateDeferrer.mm:
  • UIProcess/ios/PageClientImplIOS.mm:
  • UIProcess/ios/SmartMagnificationController.mm:
  • UIProcess/ios/TextCheckerIOS.mm:
  • UIProcess/ios/ViewGestureControllerIOS.mm:
  • UIProcess/ios/WKActionSheet.mm:
  • UIProcess/ios/WKActionSheetAssistant.mm:
  • UIProcess/ios/WKContentView.mm:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:
  • UIProcess/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm:
  • UIProcess/ios/WKKeyboardScrollingAnimator.mm:
  • UIProcess/ios/WKPDFPageNumberIndicator.mm:
  • UIProcess/ios/WKPDFView.mm:
  • UIProcess/ios/WKPasswordView.mm:
  • UIProcess/ios/WKScrollView.h:
  • UIProcess/ios/WKScrollView.mm:
  • UIProcess/ios/WKSyntheticTapGestureRecognizer.h:
  • UIProcess/ios/WKWebEvent.mm:
  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.h:
  • UIProcess/ios/WebPageProxyIOS.mm:
  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
  • UIProcess/ios/forms/WKFileUploadPanel.mm:
  • UIProcess/ios/forms/WKFocusedFormControlView.h:
  • UIProcess/ios/forms/WKFormColorControl.mm:
  • UIProcess/ios/forms/WKFormColorPicker.mm:
  • UIProcess/ios/forms/WKFormInputControl.mm:
  • UIProcess/ios/forms/WKFormPopover.mm:
  • UIProcess/ios/forms/WKFormSelectControl.h:
  • UIProcess/ios/forms/WKFormSelectControl.mm:
  • UIProcess/ios/forms/WKFormSelectPicker.mm:
  • UIProcess/ios/forms/WKFormSelectPopover.mm:
  • UIProcess/ios/forms/WKNumberPadViewController.mm:
  • UIProcess/ios/forms/WKQuickboardListViewController.h:
  • UIProcess/ios/forms/WKSelectMenuListViewController.mm:
  • UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
  • UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
  • UIProcess/ios/fullscreen/WKFullscreenStackView.mm:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
  • WebProcess/WebPage/ios/WebPageIOS.mm:
  • WebProcess/cocoa/WebProcessCocoa.mm:

Tools:

  • DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeWindow.h:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
  • TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
  • TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
  • TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
  • TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
  • TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
  • TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
  • TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
  • TestWebKitAPI/cocoa/DragAndDropSimulator.h:
  • TestWebKitAPI/cocoa/TestWKWebView.mm:
  • TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
  • TestWebKitAPI/ios/UIKitSPI.h: Removed.
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
  • WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
  • WebKitTestRunner/ios/HIDEventGenerator.h:
  • WebKitTestRunner/ios/HIDEventGenerator.mm:
  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:
  • WebKitTestRunner/ios/TestControllerIOS.mm:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:
  • WebKitTestRunner/ios/mainIOS.mm:
6:31 PM Changeset in webkit [244952] by Nikita Vasilyev
  • 20 edits in trunk

Web Inspector: Provide UIString descriptions to improve localizations
​https://bugs.webkit.org/show_bug.cgi?id=195132
<rdar://problem/48457817>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/LoadLocalizedStrings.js:

(WI.UIString):
(WI.repeatedUIString.timelineRecordLayout):
(WI.repeatedUIString.timelineRecordPaint):
(WI.repeatedUIString.timelineRecordComposite):
(WI.repeatedUIString.allExceptions):
(WI.repeatedUIString.uncaughtExceptions):
(WI.repeatedUIString.assertionFailures):
(WI.repeatedUIString.allRequests):
(WI.repeatedUIString.fetch):
(WI.repeatedUIString.revealInDOMTree):

  • UserInterface/Models/LayoutTimelineRecord.js:

(WI.LayoutTimelineRecord.displayNameForEventType):

  • UserInterface/Models/RenderingFrameTimelineRecord.js:

(WI.RenderingFrameTimelineRecord.displayNameForTaskType):

  • UserInterface/Models/Resource.js:

(WI.Resource.displayNameForType):

  • UserInterface/Views/AuditTestGroupContentView.js:

(WI.AuditTestGroupContentView.prototype.layout):

  • UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.displayNameForSampleType):

  • UserInterface/Views/ContextMenuUtilities.js:
  • UserInterface/Views/DOMBreakpointTreeElement.js:

(WI.DOMBreakpointTreeElement.displayNameForType):

  • UserInterface/Views/DOMNodeTreeElement.js:

(WI.DOMNodeTreeElement.prototype.populateContextMenu):
(WI.DOMNodeTreeElement):

  • UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._populateTagContextMenu):
(WI.DOMTreeElement.prototype._populateNodeContextMenu):

  • UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel.prototype._addBreakpoint):
(WI.DebuggerSidebarPanel.prototype._handleCreateBreakpointMouseDown):
(WI.DebuggerSidebarPanel):

  • UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WI.LayerTreeDetailsSidebarPanel.prototype._buildDataGridSection):

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.shortDisplayNameForResourceType):
(WI.NetworkTableContentView.prototype.initialLayout):

  • UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._handleCreateBreakpointMouseDown):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype._renderSelector):

  • UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel.prototype.layout):

Tools:

Allow WI.UIString to take:

  • WI.UIString(string, key, comment)
  • WI.UIString(string, comment)
  • WI.UIString(string)
  • Scripts/extract-localizable-js-strings:
6:01 PM Changeset in webkit [244951] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: use the same green color for modified properties as in Changes panel
​https://bugs.webkit.org/show_bug.cgi?id=197538

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ChangesDetailsSidebarPanel.css:

(.changes-panel .css-property-line.added):
(.changes-panel .css-property-line.removed):
(.changes-panel .css-property-line.added::before):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .property.modified):
(.spreadsheet-style-declaration-editor .property.modified:not(.selected)):
(@media (prefers-color-scheme: dark)):

  • UserInterface/Views/Variables.css:

(:root):
(@media (prefers-color-scheme: dark)):

12:12 PM Changeset in webkit [244950] by Tadeu Zagallo
  • 15 edits
    1 add in trunk

TypedArrays should not store properties that are canonical numeric indices
​https://bugs.webkit.org/show_bug.cgi?id=197228
<rdar://problem/49557381>

Reviewed by Saam Barati.

JSTests:

  • stress/array-species-config-array-constructor.js:

(test):

  • stress/put-direct-index-broken-2.js:
  • stress/typed-array-canonical-numeric-index-string.js: Added.

(makeTest.assert):
(makeTest):
(const.testInvalidIndices.makeTest.set assert):
(const.testInvalidIndices.makeTest):
(const.makeTestValidIndex.configurable.set assert):
(const.makeTestValidIndex.configurable):

  • stress/typedarray-access-monomorphic-neutered.js:

(checkNoException):
(testNoException):
(testFTLNoException):

  • stress/typedarray-access-neutered.js:

(testNoException):

  • stress/typedarray-getownproperty-not-configurable.js:

(foo):

  • test262/expectations.yaml:

Source/JavaScriptCore:

According to the spec[1]:

  • TypedArrays should not perform an ordinary GetOwnProperty/SetOwnProperty if the index is a

CanonicalNumericIndexString, but invalid according to IntegerIndexedElementGet and similar
functions. I.e., there are a few properties that should not be set in a TypedArray, like NaN,
Infinity and -0.

  • On DefineOwnProperty, the out-of-bounds check should be performed before validating the property

descriptor.

  • On GetOwnProperty, the returned descriptor for numeric properties should have writable set to true.

[1]: ​https://www.ecma-international.org/ecma-262/9.0/index.html#sec-integer-indexed-exotic-objects-defineownproperty-p-desc

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlotByIndex):
(JSC::JSGenericTypedArrayView<Adaptor>::putByIndex):

  • runtime/PropertyName.h:

(JSC::isCanonicalNumericIndexString):

LayoutTests:

  • fast/canvas/canvas-ImageData-behaviour-expected.txt:
  • fast/canvas/canvas-ImageData-behaviour.js:
10:51 AM Changeset in webkit [244949] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Convert some RealtimeOutgoingVideoSourceCocoa logging to ERROR_LOG
​https://bugs.webkit.org/show_bug.cgi?id=197549

Reviewed by Eric Carlson.

No change of behavior.

  • platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:

(WebCore::RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer):

8:11 AM Changeset in webkit [244948] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win10] Some tests are failing only on specific machines
​https://bugs.webkit.org/show_bug.cgi?id=197509

Unreviewed test gardening.

  • platform/win/TestExpectations:
Note: See TracTimeline for information about the timeline view.