Timeline

May 18, 2019:

5:42 PM Changeset in webkit [245500] by jiewen_tan@apple.com

• 19 edits in trunk

[WebAuthN] Allow authenticators that support both CTAP and U2F to try U2F if CTAP fails in authenticatorGetAssertion
​https://bugs.webkit.org/show_bug.cgi?id=197974
<rdar://problem/50879746>

Reviewed by Brent Fulgham.

Source/WebKit:

Authenticators that support both CTAP and U2F protocols can be used in a U2F enabled browser to create a credential in
U2F format. When such authenticator is used to login in WebKit, it will be treated as a CTAP authenticator. Since the
previous credential is in U2F format, the authenticator will not consider that as a valid credential when CTAP requests
come along for that U2F credential. Therefore the previous created U2F credential will not be asked at all, and users
will not be able to login. This situation is not well documented in the CTAP/WebAuthN spec yet.

To workaround the above issue, an authenticator that supports both protocols will be downgraded to a U2F authenticator
to ask a potential U2F credential once a valid error is returned regarding to the first CTAP request.

• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):

• UIProcess/WebAuthentication/Authenticator.h:
• UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::downgrade):

• UIProcess/WebAuthentication/AuthenticatorManager.h:
• UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:

(WebKit::MockHidConnection::parseRequest):
(WebKit::MockHidConnection::feedReports):

• UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h:
• UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp:

(WebKit::CtapHidAuthenticator::makeCredential):
(WebKit::CtapHidAuthenticator::getAssertion):
(WebKit::CtapHidAuthenticator::continueGetAssertionAfterResponseReceived):
(WebKit::CtapHidAuthenticator::tryDowngrade):
(WebKit::CtapHidAuthenticator::continueGetAssertionAfterResponseReceived const): Deleted.

• UIProcess/WebAuthentication/fido/CtapHidAuthenticator.h:

Tools:

Add a canDowngrade option for mock hid devices to simulate the situation.

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebAuthenticationMockConfiguration):

LayoutTests:

• http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https-expected.txt:
• http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html:
• http/wpt/webauthn/public-key-credential-get-failure-hid.https-expected.txt:
• http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:
• http/wpt/webauthn/public-key-credential-get-success-u2f.https-expected.txt:
• http/wpt/webauthn/public-key-credential-get-success-u2f.https.html:
• http/wpt/webauthn/resources/util.js:

12:12 AM Changeset in webkit [245499] by Tadeu Zagallo

• 7 edits in trunk

Add extra information to dumpJITMemory
​https://bugs.webkit.org/show_bug.cgi?id=197998

Reviewed by Saam Barati.

Source/JavaScriptCore:

Add ktrace events around the memory dump and mach_absolute_time to link the
events with the entries in the dump. Additionally, add a background queue
to flush on a configurable interval, since the atexit callback does not work
in every situation.

• jit/ExecutableAllocator.cpp:

(JSC::dumpJITMemory):

• runtime/Options.h:

Source/WTF:

Add a new trace point code for JSC::dumpJITMemory

• wtf/SystemTracing.h:

Tools:

Add description for the new dumpJITMemory trace point code.

• Tracing/SystemTracePoints.plist:

May 17, 2019:

10:27 PM Changeset in webkit [245498] by Devin Rousso

• 12 edits
  1 copy in trunk/Source/WebInspectorUI

Web Inspector: Timelines: CPU/memory timeline bars sometimes don't draw correctly and jump around on scrolling
​https://bugs.webkit.org/show_bug.cgi?id=197440
<rdar://problem/46886315>

Reviewed by Joseph Pecoraro.

When drawing the Memory/CPU graphs, we need to know about the record immediately before/after
what's overlapping the visible range so that the graph correctly slopes off the screen.

• UserInterface/Models/Timeline.js:

(WI.Timeline.prototype.recordsInTimeRange):
(WI.Timeline.prototype.recordsOverlappingTimeRange): Deleted.
Merge recordsOverlappingTimeRange into recordsInTimeRange by accepting an options object
that determines whether to include the record before/after the first/last record that are
at all overlapping the range.

• UserInterface/Models/CPUTimelineRecord.js:

(WI.CPUTimelineRecord):
(WI.CPUTimelineRecord.get samplingRatePerSecond): Added.
(WI.CPUTimelineRecord.prototype.adjustStartTimeToLastRecord): Added.

• UserInterface/Models/MemoryTimelineRecord.js:

(WI.MemoryTimelineRecord):
(WI.MemoryTimelineRecord.get samplingRatePerSecond): Added.
(WI.MemoryTimelineRecord.prototype.adjustStartTimeToLastRecord): Added.
Adjust the startTime of the record by the sampling rate (which is 500ms).

• UserInterface/Models/CPUTimeline.js: Added.

(WI.CPUTimeline.prototype.addRecord):

• UserInterface/Models/MemoryTimeline.js:

(WI.MemoryTimeline.prototype.addRecord): Added.
Adjust the startTime of the new record to be equal to the endTime of the last record.

• UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview.prototype._recordSelected):

• UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.prototype.layout):
(WI.CPUTimelineView.prototype._computeStatisticsData):
(WI.CPUTimelineView.prototype._attemptSelectIndicatatorTimelineRecord):

• UserInterface/Views/CPUTimelineOverviewGraph.js:

(WI.CPUTimelineOverviewGraph.prototype.layout):
(WI.CPUTimelineOverviewGraph.prototype._handleChartClick):
(WI.CPUTimelineOverviewGraph.prototype.get samplingRatePerSecond): Deleted.
(WI.CPUTimelineOverviewGraph.prototype.layout.yScaleForRecord): Deleted.

• UserInterface/Views/MemoryTimelineView.js:

(WI.MemoryTimelineView.prototype.layout):

• UserInterface/Views/MemoryTimelineOverviewGraph.js:

(WI.MemoryTimelineOverviewGraph.prototype.layout):

• UserInterface/Main.html:
• UserInterface/Test.html:

10:10 PM Changeset in webkit [245497] by Devin Rousso

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: make it easier to jump to any returned DOM node in the Elements tab
​https://bugs.webkit.org/show_bug.cgi?id=197470
<rdar://problem/50466774>

Reviewed by Joseph Pecoraro.

Right now, the only way to jump to the Elements tab for any DOM nodes returned by an audit
is to context menu and "Reveal in DOM Tree". Providing a more visible/discoverable way to
jump to the Elements tab will help developers diagnose issues easier.

• UserInterface/Views/AuditTestCaseContentView.js:

(WI.AuditTestCaseContentView.prototype.layout):

• UserInterface/Views/AuditTestCaseContentView.css:

(.content-view.audit-test-case > section table):

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement):
(WI.DOMTreeElement.prototype.set showGoToArrow): Added.
(WI.DOMTreeElement.prototype._buildTagDOM):
(WI.DOMTreeElement.prototype._nodeTitleInfo):
Provide a way to insert a go-to arrow right after the:

• open tag, if the close tag is rendered on a separate line
• close tag, if the close tag is rendered on the same line

• UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline):
Allow DOMTreeOutline to be non-selectable.

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom:not(.non-selectable):focus li:matches(.selected, .hovered) .selection-area): Added.
(.tree-outline.dom:not(.non-selectable) li.hovered:not(.selected) .selection-area): Added.
(.tree-outline.dom li .html-tag ~ .go-to-arrow): Added.
(.tree-outline.dom li:not(.hovered) .html-tag ~ .go-to-arrow): Added.
(.tree-outline.dom:focus li:matches(.selected, .hovered) .selection-area): Deleted.
(.tree-outline.dom li.hovered:not(.selected) .selection-area): Deleted.
Ensure that hovering a non-selectable node doesn't change the background color.

9:58 PM Changeset in webkit [245496] by Justin Michaud

• 20 edits
  4 adds in trunk

[WASM-References] Add support for Anyref in parameters and return types, Ref.null and Ref.is_null for Anyref values.
​https://bugs.webkit.org/show_bug.cgi?id=197969

JSTests:

Reviewed by Keith Miller.

Support the anyref type in Builder.js, plus add some extra error logging.
Add new folder for wasm references tests.

• wasm.yaml:
• wasm/Builder.js:

(const._isValidValue):

• wasm/references/anyref_modules.js: Added.

(Call.3.RefIsNull.End.End.WebAssembly.js.ident):
(Call.3.RefIsNull.End.End.WebAssembly.js.make_null):
(Call.3.RefIsNull.End.End.WebAssembly):
(undefined):

• wasm/references/is_null.js: Added.
• wasm/references/is_null_error.js: Added.
• wasm/spec-harness/index.js:
• wasm/wasm.json:

Source/JavaScriptCore:

Reviewed by Keith Miller.

Add a new runtime option for wasm references.
Add support for Anyref as a value type.
Add support for Anyref in parameters and return types of Wasm functions. JSValues are marshalled into/out of wasm Anyrefs

as a black box, except null which becomes a Nullref value. Nullref is not expressible in the bytecode or in the js API.

Add Ref.null and Ref.is_null for Anyref values. Support for these functions with funcrefs is out of scope.

• runtime/Options.h:
• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::tmpForType):
(JSC::Wasm::AirIRGenerator::AirIRGenerator):
(JSC::Wasm::AirIRGenerator::addConstant):
(JSC::Wasm::AirIRGenerator::addRefIsNull):
(JSC::Wasm::AirIRGenerator::addReturn):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addRefIsNull):

• wasm/WasmCallingConvention.h:

(JSC::Wasm::CallingConventionAir::marshallArgument const):
(JSC::Wasm::CallingConventionAir::setupCall const):

• wasm/WasmFormat.h:

(JSC::Wasm::isValueType):

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::FunctionParser):
(JSC::Wasm::FunctionParser<Context>::parseExpression):
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

• wasm/WasmValidate.cpp:

(JSC::Wasm::Validate::addRefIsNull):

• wasm/generateWasmOpsHeader.py:

(bitSet):

• wasm/js/JSToWasm.cpp:

(JSC::Wasm::createJSToWasmWrapper):

• wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

• wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

• wasm/wasm.json:

Tools:

Run wasm tests additionally with wasmBBQUsesAir=0.

Reviewed by Keith Miller.

• Scripts/run-jsc-stress-tests:

9:44 PM Changeset in webkit [245495] by Devin Rousso

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: context menu items in DOM tree should work when not clicking directly on the node representation
​https://bugs.webkit.org/show_bug.cgi?id=197541

Reviewed by Timothy Hatcher.

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype.populateDOMNodeContextMenu): Added.
(WI.DOMTreeElement.prototype._populateTagContextMenu): Deleted.
(WI.DOMTreeElement.prototype._populateTextContextMenu): Deleted.
(WI.DOMTreeElement.prototype._populateNodeContextMenu): Deleted.

• UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype.populateContextMenu):

• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForDOMNode):

9:29 PM Changeset in webkit [245494] by commit-queue@webkit.org

• 12 edits in trunk

Implement CSS display: flow-root (modern clearfix)
​https://bugs.webkit.org/show_bug.cgi?id=165603

Patch by Joonghun Park <​pjh0718@gmail.com> on 2019-05-17
Reviewed by Zalan Bujtas.

This change follows ​https://drafts.csswg.org/css-display-3/#valdef-display-flow-root as below.

'display: flow-root' generates a block container box, and lays out its contents using flow layout.
It always establishes a new block formatting context for its contents.

Source/WebCore:

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

• css/CSSValueKeywords.in:
• css/StyleResolver.cpp:

(WebCore::equivalentBlockDisplay):

• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::createsNewFormattingContext const):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

• rendering/style/RenderStyleConstants.h:

Source/WebInspectorUI:

• UserInterface/External/CodeMirror/css.js:

LayoutTests:

• TestExpectations:

8:49 PM Changeset in webkit [245493] by Alan Coon

• 7 edits in branches/safari-608.1.24-branch/Source

Versioning.

7:38 PM Changeset in webkit [245492] by don.olmstead@sony.com

• 34 edits
  2 adds
  1 delete in trunk

[CMake] Use builtin FindICU
​https://bugs.webkit.org/show_bug.cgi?id=197934

Reviewed by Michael Catanzaro.

.:

Update CMake minimum required to 3.7. 3.7 has a FindICU module so the WebKit one
is removed. For non-Apple ports this just requires adding individual components of
ICU to find_package(ICU). For Apple ports the module does not work so the targets
created in FindICU are mirrored in target/icu.cmake.

• CMakeLists.txt:
• Source/cmake/FindICU.cmake: Removed.
• Source/cmake/OptionsAppleWin.cmake:
• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsJSCOnly.cmake:
• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsPlayStation.cmake:
• Source/cmake/OptionsWPE.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/OptionsWinCairo.cmake:
• Source/cmake/target/icu.cmake: Added.

Source/JavaScriptCore:

Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.

• CMakeLists.txt:
• PlatformWin.cmake:

Source/WebCore:

Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.

• CMakeLists.txt:
• PlatformPlayStation.cmake:
• PlatformWPE.cmake:

Source/WebCore/PAL:

Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.

• pal/CMakeLists.txt:

Source/WebDriver:

Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.

• PlatformWPE.cmake:

Source/WebKit:

Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.

• CMakeLists.txt:

Source/WebKitLegacy:

Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.

• CMakeLists.txt:
• PlatformWin.cmake:

Source/WTF:

Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES. Use ICU:: targets which end
up propagating to all consumers of WTF.

• wtf/CMakeLists.txt:
• wtf/PlatformPlayStation.cmake:

Tools:

Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.

• TestWebKitAPI/PlatformMac.cmake:
• TestWebKitAPI/PlatformPlayStation.cmake:
• TestWebKitAPI/PlatformWin.cmake:
• WebKitTestRunner/CMakeLists.txt:

7:12 PM Changeset in webkit [245491] by commit-queue@webkit.org

• 6 edits in trunk

Enable legacy EME for iOS WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=197964
<rdar://problem/50625666>

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-05-17
Reviewed by Wenson Hsieh.

Source/WebCore:

This was attempted unsuccessfully in r230169.
Verified manually that it works as desired.

• page/RuntimeEnabledFeatures.h:

Source/WebKit:

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:

(TEST):

6:32 PM Changeset in webkit [245490] by Simon Fraser

• 6 edits
  2 adds in trunk

REGRESSION (r245170): gmail.com inbox table header flickers
​https://bugs.webkit.org/show_bug.cgi?id=198005
<rdar://problem/50907718>

Reviewed by Antti Koivisto.

Source/WebCore:

When a layer started as painting into shared backing, but then became independently
composited (e.g. by having to clip composited children), it wouldn't have the "overlap"
indirect compositing reason. This allowed requiresOwnBackingStore() to say that it
could paint into some ancestor, but this breaks overlap. So in this code path,
put IndirectCompositingReason::Overlap back on the layer which restores the previous
behavior.

Make some logging changes to help diagnose things like this.

Test: compositing/shared-backing/overlap-after-end-sharing.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):
(WebCore::outputPaintOrderTreeLegend):
(WebCore::outputPaintOrderTreeRecursive):

• rendering/RenderLayer.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason const):

• rendering/RenderLayerCompositor.h:

LayoutTests:

• compositing/shared-backing/overlap-after-end-sharing-expected.html: Added.
• compositing/shared-backing/overlap-after-end-sharing.html: Added.

4:45 PM Changeset in webkit [245489] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews-build] Add clickable url in UI for uploaded S3 archive
​https://bugs.webkit.org/show_bug.cgi?id=197996

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

4:44 PM Changeset in webkit [245488] by sihui_liu@apple.com

• 2 edits in trunk/Source/WebCore

ASSERTION FAILED: !m_backingStore in WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore(uint64_t)
​https://bugs.webkit.org/show_bug.cgi?id=197741
<rdar://problem/50625006>

Reviewed by Youenn Fablet.

If an open request is made before a delete request, open task should be performed before delete task on the
database thread. After r242911, open request needs to wait decision of StorageQuotaManager before posting task
to database thread, while delete request needs not. This makes deletion happen before open.

We need to make sure tasks are in correct order by not starting next open or delete request when database is in
the middle of open or deletion.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
(WebCore::IDBServer::UniqueIDBDatabase::handleDatabaseOperations):

4:41 PM Changeset in webkit [245487] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews-app] Status bubble should not turn orange when any build step has warnings
​https://bugs.webkit.org/show_bug.cgi?id=198000

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._does_build_contains_any_failed_step):

4:11 PM Changeset in webkit [245486] by Ross Kirsling

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r244350): Web Inspector: Storage tab data grids aren't editable.
​https://bugs.webkit.org/show_bug.cgi?id=198003

Reviewed by Devin Rousso.

• UserInterface/Views/DOMStorageContentView.js:

(WI.DOMStorageContentView):
Fix typo.

4:09 PM Changeset in webkit [245485] by Alan Coon

• 1 copy in tags/Safari-608.1.24.5

Tag Safari-608.1.24.5.

4:07 PM Changeset in webkit [245484] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Fix colors in network table waterfall container
​https://bugs.webkit.org/show_bug.cgi?id=197955

Patch by Jamal Nasser <​jamaln@mail.com> on 2019-05-17
Reviewed by Devin Rousso.

• UserInterface/Views/NetworkTableContentView.css:

(.network-table :not(.header) .cell.waterfall .waterfall-container > .dom-event):
(.network-table :not(.header) .cell.waterfall .waterfall-container > .dom-activity):
(.network-table :not(.header) .cell.waterfall .waterfall-container > .area.dom-fullscreen):

3:05 PM Changeset in webkit [245483] by graouts@webkit.org

• 11 edits
  7 adds in trunk

Add a website policy to disable the legacy -webkit-overflow-scrolling:touch behavior
​https://bugs.webkit.org/show_bug.cgi?id=197943
<rdar://problem/49078202>

Reviewed by Brent Fulgham.

Source/WebCore:

Tests: fast/scrolling/ipad/overflow-scrolling-touch-enabled-stacking-modern-compatibility-mode.html

platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html

• css/parser/CSSParserContext.cpp:

(WebCore::CSSParserContext::CSSParserContext):

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::legacyOverflowScrollingTouchPolicy const):
(WebCore::DocumentLoader::setLegacyOverflowScrollingTouchPolicy):

Source/WebKit:

• Shared/WebsiteLegacyOverflowScrollingTouchPolicy.h: Added.
• Shared/WebsitePoliciesData.cpp:

(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
(WebKit::WebsitePoliciesData::applyToDocumentLoader):

• Shared/WebsitePoliciesData.h:
• UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::copy const):
(API::WebsitePolicies::data):

• UIProcess/API/APIWebsitePolicies.h:
• WebKit.xcodeproj/project.pbxproj:

LayoutTests:

• fast/scrolling/ipad/overflow-scrolling-touch-enabled-stacking-modern-compatibility-mode-expected.html: Added.
• fast/scrolling/ipad/overflow-scrolling-touch-enabled-stacking-modern-compatibility-mode.html: Added.
• platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode-expected.txt: Added.
• platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html: Added.
• platform/ios/TestExpectations: Skip the new tests since they depend on code in WebKitAdditions.

2:55 PM Changeset in webkit [245482] by Ryan Haddad

• 1 edit in trunk/LayoutTests/platform/mac/TestExpectations

Unreviewed test gardening for macOS.

• platform/mac/TestExpectations: Land test expectations for rdar://problem/46000736.

2:50 PM Changeset in webkit [245481] by achristensen@apple.com

• 22 edits
  6 adds in trunk

Add SPI to set a list of hosts to which to send custom header fields cross-origin
​https://bugs.webkit.org/show_bug.cgi?id=197397

Reviewed by Geoff Garen.

Source/WebCore:

In r223001 I added the ability to send custom headers, but with a restriction that they will not be sent except to the origin of the main document.
We need the ability to specify what origins to send these headers to even if they are not first party requests.
We get this information in a list of strings which are the hosts to send the headers to. Some of the strings have an asterisk at the beginning,
indicating that the headers are to be sent to all subdomains.

I repurposed some ObjC SPI that was never adopted, but I keep testing the C API that was to verify no regression.
I also added some new API tests for the new behavior.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• loader/CustomHeaderFields.cpp: Added.

(WebCore::CustomHeaderFields::thirdPartyDomainsMatch const):

• loader/CustomHeaderFields.h: Added.

(WebCore::CustomHeaderFields::encode const):
(WebCore::CustomHeaderFields::decode):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setCustomHeaderFields): Deleted.

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::setCustomHeaderFields):
(WebCore::DocumentLoader::customHeaderFields const):
(WebCore::DocumentLoader::customHeaderFields): Deleted.

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

Source/WebKit:

• Shared/API/APIObject.h:
• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

• Shared/WebsitePoliciesData.cpp:

(WebKit::WebsitePoliciesData::decode):

• Shared/WebsitePoliciesData.h:
• SourcesCocoa.txt:
• UIProcess/API/APICustomHeaderFields.h: Added.
• UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::WebsitePolicies):
(API::WebsitePolicies::copy const):
(API::WebsitePolicies::data):

• UIProcess/API/APIWebsitePolicies.h:
• UIProcess/API/C/WKWebsitePolicies.cpp:

(WKWebsitePoliciesCopyCustomHeaderFields):
(WKWebsitePoliciesSetCustomHeaderFields):

• UIProcess/API/Cocoa/WKWebpagePreferences.mm:

(-[WKWebpagePreferences _customHeaderFields]):
(-[WKWebpagePreferences _setCustomHeaderFields:]):

• UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
• UIProcess/API/Cocoa/_WKCustomHeaderFields.h: Added.
• UIProcess/API/Cocoa/_WKCustomHeaderFields.mm: Added.

(-[_WKCustomHeaderFields init]):
(-[_WKCustomHeaderFields dealloc]):
(-[_WKCustomHeaderFields fields]):
(-[_WKCustomHeaderFields setFields:]):
(-[_WKCustomHeaderFields thirdPartyDomains]):
(-[_WKCustomHeaderFields setThirdPartyDomains:]):
(-[_WKCustomHeaderFields _apiObject]):

• UIProcess/API/Cocoa/_WKCustomHeaderFieldsInternal.h: Added.
• UIProcess/API/Cocoa/_WKWebsitePolicies.h:
• UIProcess/API/Cocoa/_WKWebsitePolicies.mm:

(-[_WKWebsitePolicies customHeaderFields]): Deleted.
(-[_WKWebsitePolicies setCustomHeaderFields:]): Deleted.

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::takeFocus):
(WebKit::WebViewImpl::accessibilityAttributeValue):

• WebKit.xcodeproj/project.pbxproj:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(TEST):
(expectLegacyHeaders):
(expectHeaders):
(-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
(-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.

2:37 PM Changeset in webkit [245480] by beidson@apple.com

• 5 edits in trunk/Source/WebKit

Avoid races in taking networking assertions for downloads by having both Networking and UIProcess do it.
<rdar://problem/50564630> and ​https://bugs.webkit.org/show_bug.cgi?id=197995

Reviewed by Chris Dumez.

There's a fairly indeterminant time gap between when the UIProcess decides a load becomes a download
and when the NetworkProcess Download object is created, and therefore the download assertion to be taken.

The time gap can be long enough for the Networking process to suspend before the download actually starts.

There's the reverse race when the UIProcess tells a download to stop, as well.

By having both the UIProcess and NetworkProcess take an assertion on behalf of the NetworkProcess we
avoid the race.

• NetworkProcess/Downloads/DownloadMap.cpp:

(WebKit::DownloadMap::add):
(WebKit::DownloadMap::remove):

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::convertToDownload):

• UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::createDownloadProxy):
(WebKit::DownloadProxyMap::downloadFinished):
(WebKit::DownloadProxyMap::invalidate):

• UIProcess/Downloads/DownloadProxyMap.h:

2:31 PM Changeset in webkit [245479] by Kocsen Chung

• 7 edits in branches/safari-607-branch/Source

Versioning.

2:29 PM Changeset in webkit [245478] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Make AVVideoCaptureSource more robust to configuration failures
​https://bugs.webkit.org/show_bug.cgi?id=197997
rdar://problem/50875662

Reviewed by Eric Carlson.

Covered by manual testing.

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setSessionSizeAndFrameRate):
Make sure to commit configuration once calling beginConfiguration.
In case of error in setting frame rate, log the error but continue capturing.

2:23 PM Changeset in webkit [245477] by Kocsen Chung

• 1 copy in tags/Safari-607.3.2

Tag Safari-607.3.2.

1:36 PM Changeset in webkit [245476] by Keith Rollin

• 2 edits in trunk/Tools

Unreviewed build fix.

Teach generate-xcfilelists about iphonesimulator.

• Scripts/webkitpy/generate_xcfilelists_lib/generators.py:

(JavaScriptCoreGenerator):
(WebCoreGenerator):
(WebKitGenerator):

1:34 PM Changeset in webkit [245475] by commit-queue@webkit.org

• 15 edits
  35 adds in trunk

Implement imagesrcset and imagesizes attributes on link rel=preload
​https://bugs.webkit.org/show_bug.cgi?id=192950

Patch by Rob Buis <​rbuis@igalia.com> on 2019-05-17
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Import relevant tests for this feature.

• web-platform-tests/preload/dynamic-adding-preload-imagesrcset-expected.txt: Added.
• web-platform-tests/preload/dynamic-adding-preload-imagesrcset.html: Added.
• web-platform-tests/preload/link-header-preload-delay-onload-expected.txt: Added.
• web-platform-tests/preload/link-header-preload-delay-onload.html: Added.
• web-platform-tests/preload/link-header-preload-delay-onload.html.headers: Added.
• web-platform-tests/preload/link-header-preload-expected.txt: Added.
• web-platform-tests/preload/link-header-preload-imagesrcset-expected.txt: Added.
• web-platform-tests/preload/link-header-preload-imagesrcset.html: Added.
• web-platform-tests/preload/link-header-preload-imagesrcset.html.headers: Added.
• web-platform-tests/preload/link-header-preload-nonce-expected.txt: Added.
• web-platform-tests/preload/link-header-preload-nonce.html: Added.
• web-platform-tests/preload/link-header-preload-nonce.html.headers: Added.
• web-platform-tests/preload/link-header-preload.html: Added.
• web-platform-tests/preload/link-header-preload.html.headers: Added.
• web-platform-tests/preload/onload-event-expected.txt: Added.
• web-platform-tests/preload/onload-event.html: Added.
• web-platform-tests/preload/preload-csp.sub-expected.txt:
• web-platform-tests/preload/preload-csp.sub.html:
• web-platform-tests/preload/preload-default-csp.sub-expected.txt:
• web-platform-tests/preload/preload-default-csp.sub.html:
• web-platform-tests/preload/preload-with-type-expected.txt: Added.
• web-platform-tests/preload/preload-with-type.html: Added.
• web-platform-tests/preload/resources/A4.ogv: Added.
• web-platform-tests/preload/resources/A4.ogv.sub.headers: Added.
• web-platform-tests/preload/resources/cross-origin-module.py: Added.

(main):

• web-platform-tests/preload/resources/dummy-preloads-subresource.css: Added.
• web-platform-tests/preload/resources/dummy-preloads-subresource.css.sub.headers: Added.
• web-platform-tests/preload/resources/empty.html: Added.
• web-platform-tests/preload/resources/empty.html.sub.headers: Added.
• web-platform-tests/preload/resources/foo.vtt.sub.headers: Added.
• web-platform-tests/preload/resources/module1.js: Added.
• web-platform-tests/preload/resources/module2.js: Added.
• web-platform-tests/preload/resources/preload_helper.js:

(verifyNumberOfResourceTimingEntries):
(numberOfResourceTimingEntries):
(verifyLoadedAndNoDoubleDownload):

• web-platform-tests/preload/single-download-preload-expected.txt:
• web-platform-tests/preload/single-download-preload.html:

Source/WebCore:

Implement imagesrcset and imagesizes attributes for both Link header
and link element.

Tests: imported/w3c/web-platform-tests/preload/dynamic-adding-preload-imagesrcset.html

imported/w3c/web-platform-tests/preload/link-header-preload-delay-onload.html
imported/w3c/web-platform-tests/preload/link-header-preload-imagesrcset.html
imported/w3c/web-platform-tests/preload/link-header-preload-nonce.html
imported/w3c/web-platform-tests/preload/link-header-preload.html
imported/w3c/web-platform-tests/preload/onload-event.html
imported/w3c/web-platform-tests/preload/preload-with-type.html

• html/HTMLAttributeNames.in:
• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

• html/HTMLLinkElement.idl:
• loader/LinkHeader.cpp:

(WebCore::paramterNameFromString):
(WebCore::LinkHeader::setValue):
(WebCore::LinkHeader::LinkHeader):

• loader/LinkHeader.h:

(WebCore::LinkHeader::imageSrcSet const):
(WebCore::LinkHeader::imageSizes const):
(WebCore::LinkHeader::isViewportDependent const):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLinksFromHeader):
(WebCore::LinkLoader::preloadIfNeeded):
(WebCore::LinkLoader::loadLink):

• loader/LinkLoader.h:

LayoutTests:

Write special expectation for link-header-preload-imagesrcset.html because test runner
uses different dimensions on iOS.

• platform/ios-simulator-12-wk2/imported/w3c/web-platform-tests/preload/dynamic-adding-preload-imagesrcset-expected.txt: Added.
• platform/ios-simulator-12-wk2/imported/w3c/web-platform-tests/preload/link-header-preload-imagesrcset-expected.txt: Added.

12:29 PM Changeset in webkit [245474] by Keith Rollin

• 9 edits in trunk

Re-enable generate-xcfilelists
​https://bugs.webkit.org/show_bug.cgi?id=197933
<rdar://problem/50831677>

Reviewed by Jonathan Bedard.

The following two tasks have been completed, and we can re-enable
generate-xcfilelists:

Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)

Source/JavaScriptCore:

• Scripts/check-xcfilelists.sh:

Source/WebCore:

No new tests -- no change in user-visible functionality.

• Scripts/check-xcfilelists.sh:

Source/WebKit:

• Scripts/check-xcfilelists.sh:

Tools:

• DumpRenderTree/Scripts/check-xcfilelists.sh:
• WebKitTestRunner/Scripts/check-xcfilelists.sh:

12:05 PM Changeset in webkit [245473] by Shawn Roberts

• 2 edits in trunk/LayoutTests

media/controls-after-reload.html failing on iOS after unskip

Unreviewed test gardening.

• platform/ios/TestExpectations: Skipping in iOS

11:56 AM Changeset in webkit [245472] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Fix a typo in some user agent string logic
​https://bugs.webkit.org/show_bug.cgi?id=197992
<rdar://problem/50895962>

Reviewed by Brent Fulgham.

Adjust the major version number for the desktop user agent string.

• platform/ios/UserAgentIOS.mm:

(WebCore::standardUserAgentWithApplicationName):

11:28 AM Changeset in webkit [245471] by Simon Fraser

• 3 edits
  2 adds in trunk

REGRESSION (r245170): gmail.com header flickers when hovering over the animating buttons
​https://bugs.webkit.org/show_bug.cgi?id=197975
<rdar://problem/50865946>

Reviewed by Antti Koivisto.

Source/WebCore:

When computeCompositingRequirements() determined that a layer could paint into shared backing, it
pushed an overlap container. If that layer then converted to normal composting, we'd push a second
overlap container, which left the overlap map in a bad state for the rest of the compositing
traversal, causing layers to not get composited when necessary.

Test: compositing/shared-backing/overlap-after-shared-to-composited.html

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

LayoutTests:

• compositing/shared-backing/overlap-after-shared-to-composited-expected.html: Added.
• compositing/shared-backing/overlap-after-shared-to-composited.html: Added.

10:30 AM Changeset in webkit [245470] by commit-queue@webkit.org

• 22 edits
  6 deletes in trunk

Unreviewed, rolling out r245401.
​https://bugs.webkit.org/show_bug.cgi?id=197990

Causing internal build failures (Requested by ShawnRoberts on
#webkit).

Reverted changeset:

"Add SPI to set a list of hosts to which to send custom header
fields cross-origin"
​https://bugs.webkit.org/show_bug.cgi?id=197397
​https://trac.webkit.org/changeset/245401

10:26 AM Changeset in webkit [245469] by Said Abou-Hallawa

• 4 edits
  2 adds in trunk

SVGElement should detach itself from all its properties before it is deleted
​https://bugs.webkit.org/show_bug.cgi?id=197954

Reviewed by Simon Fraser.

Source/WebCore:

Before deleting the SVGElement node, SVGElement::detachAllProperties()
needs to be called. This will make the properties be detached objects
which means no change will be committed unless these properties are
attached to another owner.

Test: svg/dom/svg-properties-detach-change.html

• dom/Node.cpp:

(WebCore::Node::removedLastRef):

• svg/SVGElement.h:

(WebCore::SVGElement::detachAllProperties):

LayoutTests:

• svg/dom/svg-properties-detach-change-expected.txt: Added.
• svg/dom/svg-properties-detach-change.html : Added.

10:22 AM Changeset in webkit [245468] by commit-queue@webkit.org

• 12 edits in trunk

Unreviewed, rolling out r245418.
​https://bugs.webkit.org/show_bug.cgi?id=197989

New API test causing crashes on Mojave testers (Requested by
ShawnRoberts on #webkit).

Reverted changeset:

"Add a unit test for client certificate authentication"
​https://bugs.webkit.org/show_bug.cgi?id=197800
​https://trac.webkit.org/changeset/245418

9:39 AM Changeset in webkit [245467] by eric.carlson@apple.com

• 9 edits
  2 adds in trunk

Allow sequential playback of media files when initial playback started with a user gesture
​https://bugs.webkit.org/show_bug.cgi?id=197959
<rdar://problem/50655207>

Reviewed by Youenn Fablet.

Source/WebCore:

Test: media/playlist-inherits-user-gesture.html

• dom/Document.cpp:

(WebCore::Document::processingUserGestureForMedia const): Return true if it is within
one second of the last HTMLMediaElement 'ended' event.

• dom/Document.h:

(WebCore::Document::mediaFinishedPlaying):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): removeBehaviorsRestrictionsAfterFirstUserGesture ->
removeBehaviorRestrictionsAfterFirstUserGesture.
(WebCore::HTMLMediaElement::load): Ditto. Don't call removeBehaviorsRestrictionsAfterFirstUserGesture,
it will be done in prepareForLoad.
(WebCore::HTMLMediaElement::prepareForLoad): removeBehaviorsRestrictionsAfterFirstUserGesture ->
removeBehaviorRestrictionsAfterFirstUserGesture.
(WebCore::HTMLMediaElement::audioTrackEnabledChanged): Ditto.
(WebCore::HTMLMediaElement::play): Ditto.
(WebCore::HTMLMediaElement::pause): Ditto.
(WebCore::HTMLMediaElement::setVolume): Ditto.
(WebCore::HTMLMediaElement::setMuted): Ditto.
(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker): Ditto.
(WebCore::HTMLMediaElement::dispatchEvent): Call document().mediaFinishedPlaying()
when dispatching the 'ended' event.
(WebCore::HTMLMediaElement::removeBehaviorRestrictionsAfterFirstUserGesture): Rename. Set
m_removedBehaviorRestrictionsAfterFirstUserGesture.
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture): Deleted.

• html/HTMLMediaElement.h:

• html/HTMLVideoElement.cpp:

(WebCore:HTMLVideoElement::nativeImageForCurrentTime): Convert to runtime logging.
(WebCore:HTMLVideoElement::webkitEnterFullscreen): Ditto.
(WebCore:HTMLVideoElement::webkitSetPresentationMode): Ditto.
(WebCore:HTMLVideoElement::fullscreenModeChanged): Ditto.

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::removeBehaviorRestriction): Update log message.

LayoutTests:

• media/media-fullscreen.js: Insert a pause between tests to clear the user gesture

used in the first test.

• media/playlist-inherits-user-gesture-expected.txt: Added.
• media/playlist-inherits-user-gesture.html: Added.

9:27 AM Changeset in webkit [245466] by Truitt Savell

• 2 edits in trunk/LayoutTests

Unmark several skipped tests in wk2
​https://bugs.webkit.org/show_bug.cgi?id=197987

Unreviewed test gardening

• platform/wk2/TestExpectations:

9:14 AM Changeset in webkit [245465] by Antti Koivisto

• 6 edits
  2 copies in trunk

[iOS] Respect scrolling="no" on composited frames
​https://bugs.webkit.org/show_bug.cgi?id=197972
<rdar://problem/50252398>

Reviewed by Simon Fraser.

Source/WebKit:

• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateAfterChildren):

Disallow scrolling based on canHaveScrollbars, similar to main frame.

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::repositionScrollingLayers):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollView const):

Factor into a function.

LayoutTests:

• fast/scrolling/ios/body-overflow-hidden-frame-expected.html:
• fast/scrolling/ios/body-overflow-hidden-frame.html:

Also fix overflow:hidden test so that the frame content forces composition.

• fast/scrolling/ios/frame-scrolling-no-expected.html: Added.
• fast/scrolling/ios/frame-scrolling-no.html: Added.

9:03 AM Changeset in webkit [245464] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

Hardening: Prevent FrameLoader crash due to SetForScope
​https://bugs.webkit.org/show_bug.cgi?id=197458
<rdar://problem/50368338>

Reviewed by Chris Dumez.

Since SetForScope takes action during a function returns, it might cause
a crash if its scope is broader than the value it is resetting.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadDifferentDocumentItem):

8:20 AM Changeset in webkit [245463] by Kocsen Chung

• 3 edits in branches/safari-607-branch/Source/WebCore

Apply patch. rdar://problem/50352476

8:07 AM Changeset in webkit [245462] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

Unreviewed. Fix variations shown in GTK emoji chooser after r245460.

We are tno showing the variations in the sub-popover because of a missing parameter in
webkitEmojiChooserAddEmoji() call.

• UIProcess/API/gtk/WebKitEmojiChooser.cpp:

(webkitEmojiChooserShowVariations): Pass prepend parameter to webkitEmojiChooserAddEmoji().

7:32 AM Changeset in webkit [245461] by aakash_jain@apple.com

• 3 edits in trunk/Tools

[ews-build] Add build step to Transfer archive to S3
​https://bugs.webkit.org/show_bug.cgi?id=197922

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(TransferToS3):
(TransferToS3.finished): Invoke triggers after transfer is successful.
(TransferToS3.getResultSummary): Create more readable failure string.
(UploadBuiltProduct.finished): Deleted. Moved the trigger invocation after TransferToS3.

• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.

5:39 AM Changeset in webkit [245460] by Carlos Garcia Campos

• 27 edits
  2 adds in trunk

[GTK] Need WebKitContextMenuItemType to open emoji picker
​https://bugs.webkit.org/show_bug.cgi?id=176760

Reviewed by Michael Catanzaro.

Source/WebCore:

Add a new context menu item to insert an emoji.

• loader/EmptyClients.cpp: Empty implementation of ContextMenuClient::insertEmoji().
• page/ContextMenuClient.h: Add insertEmoji for GTK port.
• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected): Handle insert emoji action.
(WebCore::ContextMenuController::populate): Add insert emoji item after select all.
(WebCore::ContextMenuController::checkOrEnableIfNeeded const): Handle insert emoji action.

• platform/ContextMenuItem.h: Add insert emoji action.
• platform/LocalizedStrings.h:
• platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::contextMenuItemTagInsertEmoji):

Source/WebCore/platform/gtk/po:

• POTFILES.in: Add WebKitEmojiChooser.cpp.

Source/WebKit:

Add a default implementation to show the emoji chooser when requested by the application, either using the
context menu or keyboard shortcuts. GtkEmojiChooser is private in GTK, so we include our own copy, adapted to
the WebKit coding style. The emoji chooser is always shown by default when using GTK >= 3.24 for any editable
content. I'm going to add public API in a follow up patch to be able to use your own chooser, or even prevent
the default chooser from being shown, similar to what we do for other UI elements like file chooser, color
chooser, print dialog, etc.

• Shared/API/glib/WebKitContextMenuActions.cpp:

(webkitContextMenuActionGetActionTag): Handle insert emoji action.
(webkitContextMenuActionGetForContextMenuItem): Ditto.
(webkitContextMenuActionGetLabel): Ditto.

• SourcesGTK.txt:
• UIProcess/API/gtk/WebKitContextMenuActions.h:
• UIProcess/API/gtk/WebKitEmojiChooser.cpp: Added.

(webkitEmojiChooserAddEmoji):
(webkitEmojiChooserAddRecentItem):
(emojiActivated):
(emojiDataHasVariations):
(webkitEmojiChooserShowVariations):
(emojiLongPressed):
(emojiPressed):
(emojiPopupMenu):
(verticalAdjustmentChanged):
(webkitEmojiChooserSetupSectionBox):
(scrollToSection):
(webkitEmojiChooserSetupSectionButton):
(webkitEmojiChooserSetupRecent):
(webkitEmojiChooserEnsureEmptyResult):
(webkitEmojiChooserSearchChanged):
(webkitEmojiChooserSetupFilters):
(webkitEmojiChooserInitializeEmojiMaxWidth):
(webkitEmojiChooserConstructed):
(webkitEmojiChooserShow):
(webkit_emoji_chooser_class_init):
(webkitEmojiChooserNew):

• UIProcess/API/gtk/WebKitEmojiChooser.h: Added.
• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate): Add a timer to release the emoji chooser if not used
after 2 minutes.
(_WebKitWebViewBasePrivate::releaseEmojiChooserTimerFired): Destroy the emoji chooser.
(emojiChooserEmojiPicked): Complete the operation using the given emoji text.
(emojiChooserClosed): Complete the operation if needed using an empty string.
(webkitWebViewBaseShowEmojiChooser): Create the emoji chooser if needed and show it.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/WebPageProxy.h: Add showEmojiPicker().
• UIProcess/WebPageProxy.messages.in: Add ShowEmojiPicker message.
• UIProcess/gtk/KeyBindingTranslator.cpp:

(WebKit::insertEmojiCallback): Add GtkInsertEmoji command.
(WebKit::KeyBindingTranslator::KeyBindingTranslator): Connect to insert-emoji signal.

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::showEmojiPicker): Call webkitWebViewBaseShowEmojiChooser().

• WebProcess/WebCoreSupport/WebContextMenuClient.h: Override insertEmoji() for GTK port.
• WebProcess/WebCoreSupport/WebEditorClient.h: Add insertEmoji() for GTK port.
• WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:

(WebKit::WebContextMenuClient::insertEmoji): Call WebPage::showEmojiPicker().

• WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::handleGtkEditorCommand): Call WebPage::showEmojiPicker() if command is GtkInsertEmoji.
(WebKit::WebEditorClient::executePendingEditorCommands): Handle Gtk specific commands.
(WebKit::WebEditorClient::handleKeyboardEvent): Use a reference instead of a pointer for Frame.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::showEmojiPicker): Send ShowEmojiPicker message to the UI process.

Tools:

Update context menu test to check insert emoji action is included in default context menu for editable content.

• TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:

4:53 AM Changeset in webkit [245459] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.24.2

WebKitGTK 2.24.2

4:53 AM Changeset in webkit [245458] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.24

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.24.2 release

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.24.2.

4:25 AM Changeset in webkit [245457] by Carlos Garcia Campos

• 7 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r245393 - [FreeType] Some character sequences with a variation selector are not rendered
​https://bugs.webkit.org/show_bug.cgi?id=197838

Reviewed by Michael Catanzaro.

We get the invalid glyph instead. See ​http://mts.io/2015/04/21/unicode-symbol-render-text-emoji/. In the table at
the end the Emoji and Text columns are not correctly rendered. It happens also when copying an emoji from
GtkEmojiChooser and pasting in WebKit text field, because GTK appends U+FE0F to all emojis to force the emoji
style. We need to take into account the variation selector when checking if a font can render a combining
sequence, using FT_Face_GetCharVariantIndex to get the right glyph in case of variation character present.

• platform/graphics/Font.cpp:

(WebCore::Font::platformSupportsCodePoint const): Add optional variation parameter.
(WebCore::Font::canRenderCombiningCharacterSequence const): Take into account variation selector characters

• platform/graphics/Font.h:
• platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::FontCascade::fontForCombiningCharacterSequence const): Check variation selectors 0xFE0E and 0xFE0F to
decide whether to use the emoji or text style.

• platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformSupportsCodePoint const): Return false when a variation character is passed so that
characters are checked individually.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformSupportsCodePoint const): Use FT_Face_GetCharVariantIndex when a variation character is
passed.

• platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::harfBuzzFontFunctions): Do not return true when FT_Face_GetCharVariantIndex returns 0.

4:25 AM Changeset in webkit [245456] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

Merge r243052 - Fix WPE and GTK Debug builds after r243049
​https://bugs.webkit.org/show_bug.cgi?id=195860

Unreviewed, build fix after r243049.

• runtime/StringPrototype.cpp:

(JSC::normalizationAffects8Bit):

4:25 AM Changeset in webkit [245455] by Carlos Garcia Campos

• 13 edits in releases/WebKitGTK/webkit-2.24/Source

Merge r243049 - Improve normalization code, including moving from unorm.h to unorm2.h
​https://bugs.webkit.org/show_bug.cgi?id=195330

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

• runtime/JSString.h: Move StringViewWithUnderlyingString to StringView.h.

• runtime/StringPrototype.cpp: Include unorm2.h instead of unorm.h.

(JSC::normalizer): Added. Function to create normalizer object given
enumeration value indicating which is selected. Simplified because we
know the function will not fail and so we don't need error handling code.
(JSC::normalize): Changed this function to take a JSString* so we can
optimize the case where no normalization is needed. Added an early exit
if the string is stored as 8-bit and another if the string is already
normalized, using unorm2_isNormalized. Changed error handling to only
check cases that can actually fail in practice. Also did other small
optimizations like passing VM rather than ExecState.
(JSC::stringProtoFuncNormalize): Used smaller enumeration names that are
identical to the names used in the API and normalization parlance rather
than longer ones that expand the acronyms. Updated to pass JSString* to
the normalize function, so we can optimize 8-bit and already-normalized
cases, rather than callling the expensive String::upconvertedCharacters
function. Use throwVMRangeError.

Source/WebCore:

• editing/TextIterator.cpp: Include unorm2.h.

(WebCore::normalizeCharacters): Rewrote to use unorm2_normalize rather than
unorm_normalize, but left the logic otherwise the same.

• platform/graphics/SurrogatePairAwareTextIterator.cpp: Include unorm2.h.

(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks):
Use unorm2_composePair instead of unorm_normalize.

• platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(characterSequenceIsEmoji): Changed to use existing SurrogatePairAwareTextIterator.
(FontCascade::fontForCombiningCharacterSequence): Use normalizedNFC instead of
calling unorm2_normalize directly.

• WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:

Removed unneeded include of <unicode/normlzr.h>.

• platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode const): Use normalizedNFC instead of the
code that was here. The normalizedNFC function is better in multiple ways,
but primarily it handles 8-bit strings and other already-normalized
strings much more efficiently.

Source/WTF:

• wtf/URLHelpers.cpp: Removed unneeded include of unorm.h since the

normalization code is now in StringView.cpp.
(WTF::URLHelpers::escapeUnsafeCharacters): Renamed from
createStringWithEscapedUnsafeCharacters since it now only creates
a new string if one is needed. Use unsigned for string lengths, since
that's what WTF::String uses, not size_t. Added a first loop so that
we can return the string unmodified if no lookalike characters are
found. Removed unnecessary round trip from UTF-16 and then back in
the case where the character is not a lookalike.
(WTF::URLHelpers::toNormalizationFormC): Deleted. Moved this logic
into the WTF::normalizedNFC function in StringView.cpp.
(WTF::URLHelpers::userVisibleURL): Call escapeUnsafeCharacters and
normalizedNFC. The normalizedNFC function is better in multiple ways,
but primarily it handles 8-bit strings and other already-normalized
strings much more efficiently.

• wtf/text/StringView.cpp:

(WTF::normalizedNFC): Added. This has two overloads. One is for when
we already have a String, and want to re-use it if no normalization
is needed, and another is when we only have a StringView, and may need
to allocate a String to hold the result. Includes a fast special case
for 8-bit and already-normalized strings, and uses the same strategy
that JSC::normalize was already using: calls unorm2_normalize twice,
first just to determine the length.

• wtf/text/StringView.h: Added normalizedNFC, which can be called with

either a StringView or a String. Also moved StringViewWithUnderlyingString
here from JSString.h, here for use as the return value of normalizedNFC;
it is used for a similar purpose in the JavaScriptCore rope implementation.
Also removed an inaccurate comment.

4:25 AM Changeset in webkit [245454] by Carlos Garcia Campos

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merge r245361 - Do not create a shape object outside of the layout context
​https://bugs.webkit.org/show_bug.cgi?id=197926
<rdar://problem/50627858>

Reviewed by Simon Fraser.

Source/WebCore:

ShapeOutside objects are used to compute line constrains during layout (in a strict sense, they are part of the layout context and should only be mutated during layout).
If we don't create one during layout, we probably don't need to know its geometry during paint (or any other non-layout activity) either.

Test: fast/block/float/float-with-shape-outside-crash.html

• rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):

• rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computeDeltasForContainingBlockLine):

LayoutTests:

• fast/block/float/float-with-shape-outside-crash-expected.txt: Added.
• fast/block/float/float-with-shape-outside-crash.html: Added.

4:25 AM Changeset in webkit [245453] by Carlos Garcia Campos

• 3 edits
  3 adds in releases/WebKitGTK/webkit-2.24

Merge r245300 - Do not try to issue repaint while the render tree is being destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=197461
<rdar://problem/50368992>

Reviewed by Simon Fraser.

Source/WebCore:

Test: http/tests/svg/crash-on-reload-with-filter.html

We don't need to compute repaint rects when the render tree is getting torn down. We'll issue a full repaint at some point.
Also during full render tree destruction the inline tree state is undefined. We should avoid accessing it.

• rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::markAllClientLayersForInvalidation):

LayoutTests:

• http/tests/svg/crash-on-reload-with-filter-expected.txt: Added.
• http/tests/svg/crash-on-reload-with-filter.html: Added.
• http/tests/svg/resources/finishTest.html: Added.

4:25 AM Changeset in webkit [245452] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r245284 - Protect current WebFrame during form submission
​https://bugs.webkit.org/show_bug.cgi?id=197459
<rdar://problem/50368618>

Reviewed by Alex Christensen.

The 'continueWillSubmitForm' method calls a completion handler that
might affect the state of the current frame. Ensure the frame is valid
for the scope of the function.

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::continueWillSubmitForm):

4:25 AM Changeset in webkit [245451] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r245196 - Streamline test-and-clear operation for ContextMenu
​https://bugs.webkit.org/show_bug.cgi?id=197795
<rdar://problem/50473746>

Reviewed by Wenson Hsieh.

Rather than performing a check when entering the function, doing work,
then clearing the member variable, perform the check and clear in
a single operation. Only perform the selection if the menu exists.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didSelectItemFromActiveContextMenu):

4:25 AM Changeset in webkit [245450] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Tools

Merge r245182 - [WPE] Forward libepoxy cflags
​https://bugs.webkit.org/show_bug.cgi?id=197784

Reviewed by Žan Doberšek.

• wpe/backends/CMakeLists.txt: This is required to keep

-DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
up trying to include X11 headers even when they're not present in the
environment.

4:25 AM Changeset in webkit [245449] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r245142 - Correct delayed load event handling
​https://bugs.webkit.org/show_bug.cgi?id=197679
<rdar://problem/50423334>

Reviewed by Alex Christensen.

We need to properly account for the fact that JavaScript might run
while performing loads.

• dom/Document.cpp:

(WebCore::Document::loadEventDelayTimerFired):

4:24 AM Changeset in webkit [245448] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r245056 - Correct delayed load event handling
​https://bugs.webkit.org/show_bug.cgi?id=197679
<rdar://problem/50423334>

Reviewed by Alex Christensen.

We need to properly account for the fact that JavaScript might run
while performing loads.

• dom/Document.cpp:

(WebCore::Document::loadEventDelayTimerFired):

4:24 AM Changeset in webkit [245447] by Carlos Garcia Campos

• 3 edits
  1 add in releases/WebKitGTK/webkit-2.24

Merge r245051 - [JSC] DFG_ASSERT failed in lowInt52
​https://bugs.webkit.org/show_bug.cgi?id=197569

Reviewed by Saam Barati.

JSTests:

• stress/getstack-int52.js: Added.

(opt):
(main):

Source/JavaScriptCore:

GetStack with FlushedInt52 should load the flushed value in Int52 form and put the result in m_int52Values / m_strictInt52Values. Previously,
we load it in JSValue / Int32 form and lowInt52 fails to get appropriate one since GetStack does not put the result in m_int52Values / m_strictInt52Values.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetStack):

4:24 AM Changeset in webkit [245446] by Carlos Garcia Campos

• 8 edits
  1 add in releases/WebKitGTK/webkit-2.24

Merge r244996 - [JSC] We should check OOM for description string of Symbol
​https://bugs.webkit.org/show_bug.cgi?id=197634

Reviewed by Keith Miller.

JSTests:

• stress/check-symbol-description-oom.js: Added.

(shouldThrow):

Source/JavaScriptCore:

When resoling JSString for description of Symbol, we should check OOM error.
We also change JSValueMakeSymbol(..., nullptr) to returning a symbol value
without description, (1) to simplify the code and (2) give a way for JSC API
to create a symbol value without description.

• API/JSValueRef.cpp:

(JSValueMakeSymbol):

• API/tests/testapi.cpp:

(TestAPI::symbolsTypeof):
(TestAPI::symbolsDescription):
(testCAPIViaCpp):

• dfg/DFGOperations.cpp:
• runtime/Symbol.cpp:

(JSC::Symbol::createWithDescription):

• runtime/Symbol.h:
• runtime/SymbolConstructor.cpp:

(JSC::callSymbol):

4:24 AM Changeset in webkit [245445] by Carlos Garcia Campos

• 15 edits
  1 add in releases/WebKitGTK/webkit-2.24

Merge r244950 - TypedArrays should not store properties that are canonical numeric indices
​https://bugs.webkit.org/show_bug.cgi?id=197228
<rdar://problem/49557381>

Reviewed by Saam Barati.

JSTests:

• stress/array-species-config-array-constructor.js:

(test):

• stress/put-direct-index-broken-2.js:
• stress/typed-array-canonical-numeric-index-string.js: Added.

(makeTest.assert):
(makeTest):
(const.testInvalidIndices.makeTest.set assert):
(const.testInvalidIndices.makeTest):
(const.makeTestValidIndex.configurable.set assert):
(const.makeTestValidIndex.configurable):

• stress/typedarray-access-monomorphic-neutered.js:

(checkNoException):
(testNoException):
(testFTLNoException):

• stress/typedarray-access-neutered.js:

(testNoException):

• stress/typedarray-getownproperty-not-configurable.js:

(foo):

• test262/expectations.yaml:

Source/JavaScriptCore:

According to the spec[1]:

• TypedArrays should not perform an ordinary GetOwnProperty/SetOwnProperty if the index is a

CanonicalNumericIndexString, but invalid according to IntegerIndexedElementGet and similar
functions. I.e., there are a few properties that should not be set in a TypedArray, like NaN,
Infinity and -0.

• On DefineOwnProperty, the out-of-bounds check should be performed before validating the property

descriptor.

• On GetOwnProperty, the returned descriptor for numeric properties should have writable set to true.

[1]: ​https://www.ecma-international.org/ecma-262/9.0/index.html#sec-integer-indexed-exotic-objects-defineownproperty-p-desc

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlotByIndex):
(JSC::JSGenericTypedArrayView<Adaptor>::putByIndex):

• runtime/PropertyName.h:

(JSC::isCanonicalNumericIndexString):

LayoutTests:

• fast/canvas/canvas-ImageData-behaviour-expected.txt:
• fast/canvas/canvas-ImageData-behaviour.js:

3:54 AM WebKitGTK/2.24.x edited by Carlos Garcia Campos

(diff)

3:15 AM Changeset in webkit [245444] by Carlos Garcia Campos

• 31 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merge r244892 - Setting a frame's src to a javascript URL should not run it synchronously
​https://bugs.webkit.org/show_bug.cgi?id=197466

Reviewed by Darin Adler.

Source/WebCore:

When an iframe's src attribute is set to a javascript URL, whether when parsing
or later on via JS, we now execute the URL's JavaScript asynchronously. We used
to execute it synchronously, which was a source of bugs and also did not match
other browsers.

I have verified that our new behavior is aligned with both Firefox and Chrome.

Note that for backward-compatibility and interoperability with Blink
(​https://bugs.chromium.org/p/chromium/issues/detail?id=923585), the
"javascript:" URL will still run synchronously. We should consider dropping
this quirk at some point.

Test: fast/dom/frame-src-javascript-url-async.html

• loader/NavigationScheduler.cpp:

(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledLocationChange::~ScheduledLocationChange):
(WebCore::NavigationScheduler::scheduleLocationChange):

• loader/NavigationScheduler.h:

(WebCore::NavigationScheduler::scheduleLocationChange):

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestFrame):

LayoutTests:

• fast/dom/frame-src-javascript-url-async-expected.txt: Added.
• fast/dom/frame-src-javascript-url-async.html: Added.

Add layout test coverage for the fact that the javascript URL is executed asynchronously
whether set during parsing or later via JS. Also makes sure that executing the javascript
URL asynchronously does not replace the frame's window. This test passes in both Chrome
and Firefox.

• imported/blink/fast/frames/navigation-in-pagehide.html:

Re-sync this test from the Blink repository.

• fast/dom/Element/id-in-frameset-expected.txt:
• fast/dom/Element/id-in-frameset.html:
• fast/dom/insertedIntoDocument-iframe-expected.txt:
• fast/dom/javascript-url-exception-isolation-expected.txt:
• fast/dom/javascript-url-exception-isolation.html:
• fast/dom/no-assert-for-malformed-js-url-attribute-expected.txt:
• fast/dom/resources/javascript-url-crash-function-iframe.html:
• fast/frames/adopt-from-created-document.html:
• fast/frames/out-of-document-iframe-has-child-frame.html:
• fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html:
• fast/loader/javascript-url-iframe-remove-on-navigate.html:
• fast/loader/unload-mutation-crash.html:
• fast/parser/resources/set-parent-to-javascript-url.html:
• fast/parser/xml-error-adopted.xml:
• http/tests/navigation/lockedhistory-iframe-expected.txt:
• http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-javascript-url-iframe-in-iframe-expected.txt:
• http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
• http/tests/security/contentSecurityPolicy/javascript-url-blocked-by-default-src-star-expected.txt:
• http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
• http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level.html:
• http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame.html:
• http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url.html:
• imported/blink/loader/iframe-sync-loads-expected.txt:
• js/dom/call-base-resolution.html:
• platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-javascript-url-iframe-in-iframe-expected.txt:

Update / Rebaseline existing tests to reflect behavior change. I ran those tests in Firefox and Chrome to confirm that our behavior
is indeed aligned.

3:14 AM Changeset in webkit [245443] by Carlos Garcia Campos

• 3 edits
  1 add in releases/WebKitGTK/webkit-2.24

Merge r244314 - SafeToExecute for GetByOffset/GetGetterByOffset/PutByOffset is using the wrong child for the base
​https://bugs.webkit.org/show_bug.cgi?id=196945
<rdar://problem/49802750>

Reviewed by Filip Pizlo.

JSTests:

• stress/get-by-offset-should-use-correct-child.js: Added.

(foo.bar):
(foo):

Source/JavaScriptCore:

• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

3:14 AM Changeset in webkit [245442] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.24/LayoutTests

Merge r241931 - Fix the test failure following r241918
(​https://bugs.webkit.org/show_bug.cgi?id=194906)

For some reason strict cookies are sent via HTTP in WK1 and not in WK2. Will investigate in <​https://bugs.webkit.org/show_bug.cgi?id=194933>.
This sub-test failure occurs with and without the patch. As the primary purpose of this test
was to ensure correctness for Same Site lax cookies, I've amended the test and test result
for now.

• http/tests/cookies/same-site/user-load-cross-site-redirect-expected.txt:
• http/tests/cookies/same-site/user-load-cross-site-redirect.php:

3:14 AM WebKitGTK/2.24.x edited by Carlos Garcia Campos

(diff)

3:14 AM Changeset in webkit [245441] by Carlos Garcia Campos

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merge r241918 - Same Site Lax cookies are not sent with cross-site redirect from client-initiated load
​https://bugs.webkit.org/show_bug.cgi?id=194906
<rdar://problem/44305947>

Reviewed by Brent Fulgham.

Source/WebCore:

Ensure that a request for a top-level navigation is annotated as such regardless of whether
the request has a computed Same Site policy.

"New loads" initiated by a the client (Safari) either by API or a human either explicitly
typing a URL in the address bar or Command + clicking a hyperlink to open it in a new window/tab
are always considered Same Site. This is by definition from the spec. [1] as we aren't navigating
from an existing page. (Command + click should be thought of as a convenience to the user from
having to copy the hyperlink's URL, create a new window, and paste the URL into the address bar).
Currently the frame loader marks a request as a top-level navigation if and only if the request
does not have a pre-computed Same Site policy. However, "New loads" have a pre-computed Same Site
policy. So, these loads would never be marked as a top-level navigation by the frame loading code.
Therefore, if the "new load" turned out to be a cross-site redirect then WebKit would incorrectly
tell the networking stack that the load was a cross-site, non-top-level navigation, and per the
Same Site spec [2], the networking stack would not send Same Site Lax cookies. Instead,
WebKit should unconditionally ensure that requests are marked as a top-level navigation, if applicable.

[1] See Note for (1) in <​https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-5.2>
[2] <​https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-5.3.7.1>

Test: http/tests/cookies/same-site/user-load-cross-site-redirect.php

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest): Unconditionally update the request's top-
level navigation bit.

• platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::setAsIsolatedCopy): Unconditionally copy a request's top-
level navigation bit.

LayoutTests:

Add a test that is representative of a user loading a cross-site page that redirects
to a page that expects Same Site Lax cookies.

• http/tests/cookies/same-site/user-load-cross-site-redirect-expected.txt: Added.
• http/tests/cookies/same-site/user-load-cross-site-redirect.php: Added.

3:14 AM Changeset in webkit [245440] by Carlos Garcia Campos

• 18 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merge r243841 - -apple-trailing-word is needed for browser detection
​https://bugs.webkit.org/show_bug.cgi?id=196575

Unreviewed.

PerformanceTests:

• MotionMark/resources/debug-runner/motionmark.css:

(#intro .start-benchmark p):

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This is an unreviewed partial revert of r243819. Turns out there are some websites
which use this property to do browser detection. So, we need to continue to parse
the property, but we don't need the property to do anything.

Test: fast/text/trailing-word-detection.html

• Configurations/FeatureDefines.xcconfig:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TrailingWord const):

• css/CSSProperties.json:
• css/CSSValueKeywords.in:
• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::trailingWord const):
(WebCore::RenderStyle::setTrailingWord):
(WebCore::RenderStyle::initialTrailingWord):

• rendering/style/RenderStyleConstants.h:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

• fast/text/trailing-word-detection-expected.txt: Added.
• fast/text/trailing-word-detection.html: Added.
• platform/gtk/TestExpectations:
• platform/win/TestExpectations:

3:14 AM Changeset in webkit [245439] by Carlos Garcia Campos

• 27 edits
  4 deletes in releases/WebKitGTK/webkit-2.24

Merge r243819 - Remove support for -apple-trailing-word
​https://bugs.webkit.org/show_bug.cgi?id=196525

Reviewed by Zalan Bujtas.

This CSS property is nonstandard and not used.

.:

• Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator TrailingWord const): Deleted.

• css/CSSProperties.json:
• css/CSSValueKeywords.in:
• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForStyle):

• rendering/SimpleLineLayoutCoverage.cpp:

(WebCore::SimpleLineLayout::printReason):

• rendering/SimpleLineLayoutCoverage.h:
• rendering/line/BreakingContext.h:

(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::lineBreak):
(WebCore::BreakingContext::clearLineBreakIfFitsOnLine):
(WebCore::BreakingContext::commitLineBreakClear):
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::handleEndOfLine):
(WebCore::BreakingContext::InlineIteratorHistory::InlineIteratorHistory): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::push): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::update): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::renderer const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::offset const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::nextBreakablePosition const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::atTextParagraphSeparator const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::previousInSameNode const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::get const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::current const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::historyLength const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::moveTo): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::increment): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::clear): Deleted.
(WebCore::BreakingContext::optimalLineBreakLocationForTrailingWord): Deleted.

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::trailingWord const): Deleted.
(WebCore::RenderStyle::setTrailingWord): Deleted.
(WebCore::RenderStyle::initialTrailingWord): Deleted.

• rendering/style/RenderStyleConstants.h:
• rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

• rendering/style/StyleRareInheritedData.h:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebInspectorUI:

• UserInterface/Models/CSSKeywordCompletions.js:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Tools:

• Scripts/webkitperl/FeatureList.pm:
• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

• fast/text/trailing-word-expected.html: Removed.
• fast/text/trailing-word.html: Removed.
• platform/gtk/TestExpectations:
• platform/mac/fast/text/trailing-word-parse-expected.txt: Removed.
• platform/mac/fast/text/trailing-word-parse.html: Removed.
• platform/win/TestExpectations:

3:14 AM Changeset in webkit [245438] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merge r243786 - REGRESSION (r238266): Exchange 2013 Outlook Web Access displays partially blank page when creating new e-mail
​https://bugs.webkit.org/show_bug.cgi?id=196522
Source/WebCore:

rdar://problem/49472941

Reviewed by Zalan Bujtas.

In this content a layer is composited to clip descendants, and has negative z-order children,
so we compute that it "paints into ancestor", and has a foreground layer. This combination doesn't
make sense, and when the layer becomes scrollable, we end up with bad paint phases on layers, and
fail to paint the contents.

Fix by ensuring that a layer has its own backing store if it requires a foreground layer
by virtue of having negative z-order children.

Test: compositing/backing/foreground-layer-no-paints-into-ancestor.html

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):

LayoutTests:

Reviewed by Zalan Bujtas.

• compositing/backing/foreground-layer-no-paints-into-ancestor-expected.html: Added.
• compositing/backing/foreground-layer-no-paints-into-ancestor.html: Added.

3:14 AM Changeset in webkit [245437] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merge r243605 - [SimpleLineLayout] Disable SLL when text-underline-position is not auto.
​https://bugs.webkit.org/show_bug.cgi?id=196338
<rdar://problem/47975167>

Reviewed by Daniel Bates.

Source/WebCore:

Disable simple line layout unconditionally on non-auto text-underline-position content. We don't support it yet.

Test: fast/text/simple-line-layout-with-text-underline-position.html

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForStyle):

LayoutTests:

• fast/text/simple-line-layout-with-text-underline-position-expected.html: Added.
• fast/text/simple-line-layout-with-text-underline-position.html: Added.

3:14 AM Changeset in webkit [245436] by Carlos Garcia Campos

• 3 edits
  1 add in releases/WebKitGTK/webkit-2.24

Merge r242838 - REGRESSION (iOS 12.2): Webpage using CoffeeScript crashes
​https://bugs.webkit.org/show_bug.cgi?id=195613

Reviewed by Mark Lam.

JSTests:

New regression test.

• stress/regexp-backref-inbounds.js: Added.

(testRegExp):

Source/JavaScriptCore:

The bug here is in Yarr JIT backreference matching code. We are incorrectly
using a checkedOffset / inputPosition correction when checking for the available
length left in a string. It is improper to do these corrections as a backreference's
match length is based on what was matched in the referenced capture group and not
part of the checkedOffset and inputPosition computed when we compiled the RegExp.
In some cases, the resulting incorrect calculation would allow us to go past
the subject string's length. Removed these adjustments.

After writing tests for the first bug, found another bug where the non-greedy
backreference backtracking code didn't do an "are we at the end of the input?" check.
This caused an infinite loop as we'd jump from the backtracking code back to
try matching one more backreference, fail and then backtrack.

• yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateBackReference):
(JSC::Yarr::YarrGenerator::backtrackBackReference):

3:13 AM Changeset in webkit [245435] by Carlos Garcia Campos

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merge r242749 - [macOS] Dispatching reentrant "contextmenu" events may cause crashes
​https://bugs.webkit.org/show_bug.cgi?id=195571
<rdar://problem/48086046>

Reviewed by Andy Estes.

Source/WebCore:

Make ContextMenuController::handleContextMenuEvent robust against reentrancy by guarding it with a boolean flag.
As demonstrated in the test case, it is currently possible to force WebKit into a bad state by dispatching a
synthetic "contextmenu" event from within the scope of one of the "before(copy|cut|paste)" events triggered as
a result of handling a context menu event.

Test: fast/events/contextmenu-reentrancy-crash.html

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::handleContextMenuEvent):

• page/ContextMenuController.h:

LayoutTests:

Add a test to verify that triggering reentrant "contextmenu" events from script does not cause a crash.

• fast/events/contextmenu-reentrancy-crash-expected.txt: Added.
• fast/events/contextmenu-reentrancy-crash.html: Added.

2:57 AM WebKitGTK/2.24.x edited by Carlos Garcia Campos

(diff)