Timeline

Jun 10, 2019:

10:05 PM Changeset in webkit [246303] by Dewei Zhu

• 6 edits in trunk/Tools

Extend run-benchmark to allow diagnosing before closing browser on test failure.
​https://bugs.webkit.org/show_bug.cgi?id=198729

Reviewed by Ryosuke Niwa.

Add '--diagnose-directory' option to store diagnose information when test failed.

• Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner.init):

• Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:

(BrowserDriver.diagnose_test_failure): Add default no-op function to base class.

• Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.

(parse_args):
(run_benchmark_plan):

• Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:

(WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.

• Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:

(WebServerBenchmarkRunner.init):
(WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.

6:14 PM Changeset in webkit [246302] by Fujii Hironori

• 3 edits in trunk/Source/WebCore

[WinCairo][MediaFoundation] Remove the unused video window
​https://bugs.webkit.org/show_bug.cgi?id=198523

Reviewed by Don Olmstead.

Remove the video window which had been unused since Bug 150941.

No behavior change.

• platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::MediaPlayerPrivateMediaFoundation):
(WebCore::MediaPlayerPrivateMediaFoundation::~MediaPlayerPrivateMediaFoundation):
(WebCore::MediaPlayerPrivateMediaFoundation::setSize):
(WebCore::MediaPlayerPrivateMediaFoundation::paint):
(WebCore::MediaPlayerPrivateMediaFoundation::hostWindow):
(WebCore::MediaPlayerPrivateMediaFoundation::createOutputNode):
(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::setVideoWindow):
(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::setDestinationRect):
(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::createVideoSamples):
(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::presentSample):
(WebCore::MediaPlayerPrivateMediaFoundation::VideoViewWndProc): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::registerVideoWindowClass): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::createVideoWindow): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::destroyVideoWindow): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::presentSwapChain): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::updateDestRect): Deleted.

• platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:

5:54 PM Changeset in webkit [246301] by Simon Fraser

• 6 edits in trunk/Source/WebCore

Add visualization of touch action regions
​https://bugs.webkit.org/show_bug.cgi?id=198718

Reviewed by Antoine Quint.

Add a way to show which elements of the page have touch-action set on them by
painting an overlay with small text that shows the type of action(s).

The event regions are painted into GraphicsLayers at paint time in
RenderLayerBacking by making a pattern image and filling the region rects
with the pattern.

• page/DebugPageOverlays.cpp:

(WebCore::touchEventRegionColors):

• rendering/EventRegion.cpp:

(WebCore::EventRegion::regionForTouchAction const):

• rendering/EventRegion.h:

(WebCore::EventRegion::region const):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateEventRegion):
(WebCore::patternForTouchAction):
(WebCore::RenderLayerBacking::paintContents):

5:45 PM Changeset in webkit [246300] by aestes@apple.com

• 9 edits in trunk/Source

[iOS] Use PDFKit SPI for taking snapshots when the hosting app is not entitled for global capture
​https://bugs.webkit.org/show_bug.cgi?id=198731
<rdar://problem/46215174>

Reviewed by Tim Horton.

Source/WebKit:

PDFHostViewController renders PDF contents in a view service, and apps are unable to
snapshot views rendered out-of-process without an entitlement.

When an app is missing this entitlement and calls WKWebView's
takeSnapshotWithConfiguration: API when a PDF is displayed, fall back to calling
PDFHostViewController's snapshotting SPI.

Testing is blocked by <​https://webkit.org/b/175204>.

• Platform/spi/ios/PDFKitSPI.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

• UIProcess/Cocoa/WKWebViewContentProvider.h:
• UIProcess/ios/WKPDFView.mm:

(+[WKPDFView web_requiresCustomSnapshotting]):
(-[WKPDFView web_snapshotRectInContentViewCoordinates:snapshotWidth:completionHandler:]):

• UIProcess/ios/WKSystemPreviewView.mm:

(+[WKSystemPreviewView web_requiresCustomSnapshotting]):

Source/WTF:

• wtf/FeatureDefines.h:

5:38 PM Changeset in webkit [246299] by Basuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

[WinCairo] Remove build warning from RemoteInspector.
​https://bugs.webkit.org/show_bug.cgi?id=198724

Reviewed by Joseph Pecoraro.

In RemoteInspectorConnectionClient.h, an interface was defined with empty implementation.
This method is to be overwritten by sub classes so that parameter name is important
so they are commented out rather than just removing from the definition.

• inspector/remote/RemoteInspector.h:

4:53 PM Changeset in webkit [246298] by Kocsen Chung

• 1 copy in tags/Safari-608.1.27.40.1

Tag Safari-608.1.27.40.1.

4:53 PM Changeset in webkit [246297] by Kocsen Chung

• 1 delete in tags/Safari-608.1.27.40.1

Delete tag.

4:51 PM Changeset in webkit [246296] by Kocsen Chung

• 2 edits in branches/safari-608.1.27.40-branch/Source/WebKit

Cherry-pick r246248. rdar://problem/51538088

[iOS] ResourceLoadStatistics state is not properly relayed to the NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=198692
<rdar://problem/51538088>

Reviewed by Maciej Stachowiak.

• UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::setResourceLoadStatisticsEnabled): Message the NetworkProcess on state change.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:47 PM Changeset in webkit [246295] by Kocsen Chung

• 1 copy in tags/Safari-608.1.27.40.1

Tag Safari-608.1.27.40.1.

4:46 PM Changeset in webkit [246294] by Kocsen Chung

• 1 copy in tags/Safari-608.1.27.20.1

Tag Safari-608.1.27.20.1.

4:34 PM Changeset in webkit [246293] by Kocsen Chung

• 7 edits in branches/safari-608.1.27.40-branch/Source

Versioning.

4:15 PM Changeset in webkit [246292] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: imported recordings do not have JavaScript call trees
​https://bugs.webkit.org/show_bug.cgi?id=197490
<rdar://problem/50589158>

Reviewed by Joseph Pecoraro.

• UserInterface/Models/TimelineRecording.js:

(WI.TimelineRecording.prototype.initializeCallingContextTrees):
Make sure to actually save the provided stack traces and samples in the export data.

• UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.fromJSON):
(WI.ScriptTimelineRecord.prototype.toJSON):
Drive-by: include extraDetails, which contains useful information like "default prevented".

4:10 PM Changeset in webkit [246291] by Kocsen Chung

• 1 copy in branches/safari-608.1.27.40-branch

New branch.

4:08 PM Changeset in webkit [246290] by Kocsen Chung

• 7 edits in branches/safari-608.1.27.30-branch/Source

Versioning.

4:03 PM Changeset in webkit [246289] by Kocsen Chung

• 1 copy in branches/safari-608.1.27.30-branch

New branch.

3:47 PM Changeset in webkit [246288] by Basuke Suzuki

• 2 edits in trunk/Source/WebCore

Web Inspector: DNS names in SymmaryInfo was wrong.
​https://bugs.webkit.org/show_bug.cgi?id=198732

Reviewed by Devin Rousso.

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):

3:36 PM Changeset in webkit [246287] by dbates@webkit.org

• 1 edit
  4 adds in trunk/LayoutTests

[CSP] Blob URLs should inherit their CSP policy
​https://bugs.webkit.org/show_bug.cgi?id=198579
<rdar://problem/51366878>

Reviewed by Brent Fulgham.

Actually add the tests that I inadvertently omitted from r246277.

• http/tests/security/contentSecurityPolicy/navigate-self-to-blob-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html: Added.
• http/tests/security/contentSecurityPolicy/navigate-self-to-data-url-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/navigate-self-to-data-url.html: Added.

3:18 PM Changeset in webkit [246286] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

[GTK] 2.25.1 does not build on 32-bit ARM due to bit-packing assertion, requires -DENABLE_DARK_MODE_CSS=OFF
​https://bugs.webkit.org/show_bug.cgi?id=198274

Reviewed by Timothy Hatcher.

Rather than reorder everything in StyleRareInheritedData, let's slightly increase the size
of GreaterThanOrSameSizeAsStyleRareInheritedData to allow the static assert to pass.

At the same time, remove an obsolote iOS-specific member that is probably no longer needed.

• rendering/style/StyleRareInheritedData.cpp:

3:16 PM Changeset in webkit [246285] by weinig@apple.com

• 110 edits
  34 deletes in trunk

Remove Dashboard support
​https://bugs.webkit.org/show_bug.cgi?id=198615

Reviewed by Ryosuke Niwa.

.:

• Source/cmake/OptionsMac.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSCalculationValue.cpp:

(WebCore::hasDoubleValue):

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

• css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::isStringType):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const):
(WebCore::CSSPrimitiveValue::equals const):

• css/CSSPrimitiveValue.h:
• css/CSSProperties.json:
• css/CSSValueKeywords.in:
• css/DashboardRegion.h: Removed.
• css/StyleBuilderCustom.h:

(WebCore::convertToIntLength): Deleted.
(WebCore::StyleBuilderCustom::applyValueWebkitDashboardRegion): Deleted.

• css/StyleResolver.cpp:
• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeWebkitDashboardRegion): Deleted.

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::createForUpdatingDropTarget):

• dom/Document.cpp:

(WebCore::Document::invalidateRenderingDependentRegions):
(WebCore::Document::annotatedRegions const): Deleted.
(WebCore::Document::setAnnotatedRegions): Deleted.
(WebCore::Document::updateAnnotatedRegions): Deleted.
(WebCore::Document::invalidateScrollbarDependentRegions): Deleted.
(WebCore::Document::updateZOrderDependentRegions): Deleted.

• dom/Document.h:

(WebCore::Document::setHasAnnotatedRegions): Deleted.
(WebCore::Document::setAnnotatedRegionsDirty): Deleted.
(WebCore::Document::annotatedRegionsDirty const): Deleted.
(WebCore::Document::hasAnnotatedRegions const): Deleted.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createContext2d):

• html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

• html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::sourceURI const):

• html/canvas/CanvasGradient.cpp:

(WebCore::CanvasGradient::addColorStop):

• html/canvas/CanvasGradient.h:

(WebCore::CanvasGradient::setDashboardCompatibilityMode): Deleted.
(): Deleted.

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::create):
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):

• html/canvas/CanvasRenderingContext2D.h:
• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::CanvasRenderingContext2DBase):
(WebCore::CanvasRenderingContext2DBase::fill):
(WebCore::CanvasRenderingContext2DBase::stroke):
(WebCore::CanvasRenderingContext2DBase::clip):
(WebCore::CanvasRenderingContext2DBase::createLinearGradient):
(WebCore::CanvasRenderingContext2DBase::createRadialGradient):
(WebCore::CanvasRenderingContext2DBase::prepareGradientForDashboard const): Deleted.
(WebCore::CanvasRenderingContext2DBase::clearPathForDashboardBackwardCompatibilityMode): Deleted.

• html/canvas/CanvasRenderingContext2DBase.h:
• html/canvas/OffscreenCanvasRenderingContext2D.cpp:

(WebCore::OffscreenCanvasRenderingContext2D::OffscreenCanvasRenderingContext2D):

• html/canvas/PaintRenderingContext2D.cpp:

(WebCore::PaintRenderingContext2D::PaintRenderingContext2D):

• page/Chrome.cpp:

(WebCore::ChromeClient::annotatedRegionsChanged): Deleted.

• page/ChromeClient.h:
• page/FrameView.cpp:

(WebCore::FrameView::didLayout):
(WebCore::FrameView::didPaintContents):

• page/Settings.yaml:
• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks const):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::addAnnotatedRegions): Deleted.

• rendering/RenderInline.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::setHasVerticalScrollbar):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::addAnnotatedRegions): Deleted.
(WebCore::RenderObject::collectAnnotatedRegions): Deleted.

• rendering/RenderObject.h:

(WebCore::AnnotatedRegionValue::operator== const): Deleted.
(WebCore::AnnotatedRegionValue::operator!= const): Deleted.

• rendering/style/RenderStyle.cpp:

(WebCore::rareNonInheritedDataChangeRequiresLayout):
(WebCore::RenderStyle::initialDashboardRegions): Deleted.
(WebCore::RenderStyle::noneDashboardRegions): Deleted.
(WebCore::RenderStyle::setDashboardRegion): Deleted.

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::dashboardRegions const): Deleted.
(WebCore::RenderStyle::setDashboardRegions): Deleted.

• rendering/style/StyleDashboardRegion.h: Removed.
• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::operator== const):

• rendering/style/StyleRareNonInheritedData.h:
• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::setRequestHeader):
(WebCore::XMLHttpRequest::usesDashboardBackwardCompatibilityMode const): Deleted.

• xml/XMLHttpRequest.h:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetUseDashboardCompatibilityMode): Deleted.

• WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setUseDashboardCompatibilityMode): Deleted.

• WebProcess/InjectedBundle/InjectedBundle.h:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::annotatedRegionsChanged): Deleted.

• WebProcess/WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/mac:

Removes implementation, but keeps privatly exported interfaces and enums
around until we can confirm there are no more users of them.

• Configurations/FeatureDefines.xcconfig:
• Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::annotatedRegionsChanged): Deleted.

• WebView/WebClipView.mm:

(-[WebClipView _focusRingVisibleRect]):
(-[WebClipView scrollWheel:]):

• WebView/WebDashboardRegion.h:
• WebView/WebDashboardRegion.mm:
• WebView/WebHTMLView.mm:

(-[WebHTMLView _updateMouseoverWithEvent:]):
(-[WebHTMLView acceptsFirstMouse:]):
(-[WebHTMLView setDataSource:]):

• WebView/WebPreferences.mm:

(cacheModelForMainBundle):

• WebView/WebUIDelegatePrivate.h:
• WebView/WebView.mm:

(-[WebView _needsPreHTML5ParserQuirks]):
(-[WebView _preferencesChanged:]):
(-[WebView _addScrollerDashboardRegions:]):
(-[WebView _dashboardRegions]):
(-[WebView _setDashboardBehavior:to:]):
(-[WebView _dashboardBehavior:]):
(-[WebView _addControlRect:clip:fromView:toDashboardRegions:]): Deleted.
(-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): Deleted.
(-[WebView _addScrollerDashboardRegions:from:]): Deleted.

• WebView/WebViewData.h:
• WebView/WebViewData.mm:

(-[WebViewPrivate init]):

• WebView/WebViewPrivate.h:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):
(setUseDashboardCompatibilityModeCallback): Deleted.

• DumpRenderTree/TestRunner.h:
• DumpRenderTree/mac/Configurations/Base.xcconfig:
• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setUseDashboardCompatibilityMode): Deleted.

• ImageDiff/cg/Configurations/Base.xcconfig:
• Scripts/webkitperl/FeatureList.pm:
• TestWebKitAPI/Configurations/Base.xcconfig:
• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
• WebKitTestRunner/Configurations/Base.xcconfig:
• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.

• WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

• TestExpectations:
• cssom/cssvalue-comparison-expected.txt:
• cssom/cssvalue-comparison.html:
• fast/canvas/canvas-gradient-addStop-error-expected.txt:
• fast/canvas/canvas-gradient-addStop-error.html:
• fast/canvas/fill-stroke-clip-reset-path-expected.txt:
• fast/canvas/fill-stroke-clip-reset-path.html:
• fast/css/dashboard-regions-attr-crash-expected.txt: Removed.
• fast/css/dashboard-regions-attr-crash.html: Removed.
• fast/css/dashboard-regions-undefined-length-assertion-expected.txt: Removed.
• fast/css/dashboard-regions-undefined-length-assertion.html: Removed.
• fast/xmlhttprequest/set-dangerous-headers-in-dashboard-expected.txt: Removed.
• fast/xmlhttprequest/set-dangerous-headers-in-dashboard.html: Removed.
• http/tests/xmlhttprequest/default-content-type-dashboard-expected.txt: Removed.
• http/tests/xmlhttprequest/default-content-type-dashboard.html: Removed.
• http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard-expected.txt: Removed.
• http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html: Removed.
• legacy-animation-engine/cssom/cssvalue-comparison-expected.txt:
• legacy-animation-engine/cssom/cssvalue-comparison.html:
• mathml/mathml-in-dashboard-expected.txt: Removed.
• mathml/mathml-in-dashboard.html: Removed.
• platform/gtk/TestExpectations:
• platform/ios-simulator-wk2/TestExpectations:
• platform/ios-wk1/TestExpectations:
• platform/ios/TestExpectations:
• platform/ios/mathml/mathml-in-dashboard-expected.txt: Removed.
• platform/mac/TestExpectations:
• platform/mac/fast/css/dashboard-region-parser-expected.txt: Removed.
• platform/mac/fast/css/dashboard-region-parser.html: Removed.
• platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk-expected.txt: Removed.
• platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk.html: Removed.
• platform/mac/mathml/mathml-in-dashboard-expected.png: Removed.
• platform/mac/mathml/mathml-in-dashboard-expected.txt: Removed.
• platform/mac/svg/custom/embedded-svg-disallowed-in-dashboard-expected.png: Removed.
• platform/mac/svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.png: Removed.
• platform/mac/svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.png: Removed.
• platform/mac/svg/custom/svg-disallowed-in-dashboard-object-expected.png: Removed.
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:
• svg/custom/embedded-svg-allowed-in-dashboard-expected.txt: Removed.
• svg/custom/embedded-svg-allowed-in-dashboard.xml: Removed.
• svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard-expected.txt: Removed.
• svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html: Removed.
• svg/custom/manually-parsed-svg-allowed-in-dashboard-expected.txt: Removed.
• svg/custom/manually-parsed-svg-allowed-in-dashboard.html: Removed.
• svg/custom/svg-allowed-in-dashboard-object-expected.txt: Removed.
• svg/custom/svg-allowed-in-dashboard-object.html: Removed.

2:53 PM Changeset in webkit [246284] by Kocsen Chung

• 7 edits in branches/safari-608.1.27.20-branch/Source

Versioning.

2:48 PM Changeset in webkit [246283] by Kocsen Chung

• 1 copy in branches/safari-608.1.27.20-branch

New branch.

2:35 PM Changeset in webkit [246282] by Ryan Haddad

• 11 edits in trunk/Tools

Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
​https://bugs.webkit.org/show_bug.cgi?id=198616
rdar://problem/36386573

Patch by Alexey Proskuryakov <​ap@apple.com> on 2019-06-10
Reviewed by David Kilzer.

Adding an explicit STRIP_STYLE to appropriate xcconfigs.

• DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
• DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
• DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
• ImageDiff/cg/Configurations/ImageDiff.xcconfig:
• MiniBrowser/Configurations/MiniBrowser.xcconfig:
• MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
• TestWebKitAPI/Configurations/TestWTF.xcconfig:
• TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
• WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
• WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:

2:29 PM Changeset in webkit [246281] by Ryan Haddad

• 5 edits in trunk/LayoutTests

[ iOS Sim WK2 ] Layout Test editing/deleting/delete-emoji* is failing

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations: Remove failure expectation.
• platform/ios/editing/deleting/delete-emoji-1-expected.txt: Rebaseline test.
• platform/ios/editing/deleting/delete-emoji-9-expected.txt: Ditto.
• platform/ios/editing/deleting/delete-emoji-expected.txt: Ditto.

2:18 PM Changeset in webkit [246280] by Devin Rousso

• 2 edits in trunk/Source/JavaScriptCore

Web Automation: add notifications for when remote automation is enabled/disabled
​https://bugs.webkit.org/show_bug.cgi?id=198703
<rdar://problem/50588975>

Reviewed by Timothy Hatcher.

• inspector/remote/RemoteInspectorConstants.h:

2:13 PM Changeset in webkit [246279] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

REGRESSION(r244268): Web Inspector: Styles: navigating from Computed to Styles doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=198508
<rdar://problem/51375503>

Reviewed by Matt Baker.

It didn't work because the detached sidebar panel tried to access its parent view (this.parentSidebar).

• UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:

(WI.ComputedStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty): Added.
(WI.ComputedStyleDetailsSidebarPanel):

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:

(WI.GeneralStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty): Deleted.
Move computedStyleDetailsPanelShowProperty to ComputedStyleDetailsSidebarPanel since it's the only
panel where it's needed.

1:43 PM Changeset in webkit [246278] by Antti Koivisto

• 6 edits
  2 adds in trunk

Event region should be set on scrolledContentsLayer if it exists
​https://bugs.webkit.org/show_bug.cgi?id=198717
<rdar://problem/51572169>

Reviewed by Simon Fraser.

Source/WebCore:

Test: pointerevents/ios/touch-action-region-overflow.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):

Move to updateBackingAndHierarchy.

(WebCore::RenderLayerBacking::updateEventRegion):

• Set event region on scrolledContentsLayer if it exists
• Translate away the scroll offset
• Get the offset from renderer from the GraphicsLayer so scrolling and non-scrolling case can be handled uniformly.

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):

Invoke updateEventRegion after geometry update so offsets are already available on GraphicsLayer.

LayoutTests:

• pointerevents/ios/touch-action-region-backing-sharing-expected.txt:
• pointerevents/ios/touch-action-region-overflow-expected.txt: Added.
• pointerevents/ios/touch-action-region-overflow.html: Added.

1:30 PM Changeset in webkit [246277] by dbates@webkit.org

• 7 edits in trunk

[CSP] Blob URLs should inherit their CSP policy
​https://bugs.webkit.org/show_bug.cgi?id=198579
<rdar://problem/51366878>

Reviewed by Brent Fulgham.

Source/WebCore:

As per <​https://w3c.github.io/webappsec-csp/#security-inherit-csp> (Editor's Draft, 28 February 2019) blob
URLs should inherit their CSP policy from their parent (if they have one).

Test: http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html

http/tests/security/contentSecurityPolicy/navigate-self-to-data-url.html

• dom/Document.cpp:

(WebCore::Document::shouldInheritContentSecurityPolicyFromOwner const): Return true if the document's URL
is a Blob URL.
(WebCore::Document::initContentSecurityPolicy): Take a pointer to a ContentSecurityPolicy object that
represents the previous document's CSP. We only make us of this if the current URL is a Blob URL or a data
URL. Otherwise, do what we do now and take the policy from the owner frame.

• dom/Document.h:
• loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin): Extend the lifetime of the previous document temporarily so that we can
pass its CSP to FrameLoader::didBeginDocument(). We need to do this extension because this function calls
FrameLoader::clear(), which can destroy the previous document and its ContentSecurityPolicy object. This
extension is also no different than if this function was called with a non-null ownerDocument except that
in that case it is the caller that extends the previous document's lifetime. Although it is tempting to
make use of ownerDocument to fix this bug by having the caller of begin() pass the previous document as
the ownerDocument when the new document's url (the one we are begin()ing) is a Blob URL. The ownerDocument
concept would privilege the Blob URL more than necessary; we only need to inherit the CSP policy from the
previous document for a Blob URL, not inherit the cookie URL or strict mixed content checking bit, etc.
We could make ContentSecurityPolicy ref-counted or even steal the ContentSecurityPolicy object from the
previous document. The latter is not of the question as a future enhancement, but the former seemed excessive
as a way to avoid extending the lifetime of the previous document because this would be the *only* call site
that actaully takes out a second ref of a ContentSecurityPolicy object. In general, shared ownership of
a ContentSecurityPolicy object does not make sense.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument): Pass the specified content security policy through to
Document::initContentSecurityPolicy().

• loader/FrameLoader.h:

LayoutTests:

Add tests to ensure that a self navigation to a Blob or Data URL inherits its CSP policy from
its parent document.

• http/tests/security/contentSecurityPolicy/navigate-self-to-blob-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html: Added.
• http/tests/security/contentSecurityPolicy/navigate-self-to-data-url-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/navigate-self-to-data-url.html: Added.

1:11 PM Changeset in webkit [246276] by Wenson Hsieh

• 5 edits in trunk

[iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
​https://bugs.webkit.org/show_bug.cgi?id=198699
<rdar://problem/50501718>

Reviewed by Simon Fraser.

Source/WebKit:

Lift logic that sets the "IsKnownToLayOutWiderThanViewport" flag out of resetViewportDefaultConfiguration, and
into didCommitLoad instead (along with other logic for resetting viewport arguments). The previous method,
resetViewportDefaultConfiguration, was being triggered very frequently undo didReceiveMobileDocType, causing the
shrink-to-fit heuristic to sometimes take no effect. The original intention here was simply to reset the flag
upon page load.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::resetViewportDefaultConfiguration):

Tools:

Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
viewport parameters are used.

• WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetPreferencesToConsistentValues):
(WTR::TestController::platformConfigureViewForTest):

1:10 PM Changeset in webkit [246275] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for non-DFG configurations, part 2
​https://bugs.webkit.org/show_bug.cgi?id=198023

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

1:02 PM Changeset in webkit [246274] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for non-DFG configurations
​https://bugs.webkit.org/show_bug.cgi?id=198023

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

12:58 PM Changeset in webkit [246273] by sbarati@apple.com

• 14 edits
  1 copy
  5 adds in trunk

[WHLSL] Auto initialize local variables
​https://bugs.webkit.org/show_bug.cgi?id=198426

Reviewed by Myles Maxfield.

Source/WebCore:

This patch implements zero-filling for local variables in two parts:

1. We add a new pass, autoInitializeVariables, which makes any variable declaration

without an initializer call the default constructor for the variable's type.
Since we auto generate the default constructor, it's a native function whose
implementation we control.

2. Each native constructor is implemented as a memset(&value, sizeof(value), 0).

This memset is an inlined loop in each constructor. The reason this turns
everything into zero is that for every primitive type, the "zero" value is
represented as all zeroes in memory: float, int, pointers, etc.

Since our ability to test some of this is limited, I opened a follow-up bug to
test this more:
​https://bugs.webkit.org/show_bug.cgi?id=198413

Tests: webgpu/whlsl-zero-initialize-values-2.html

webgpu/whlsl-zero-initialize-values.html

• Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h:

(WebCore::WHLSL::AST::VariableDeclaration::setInitializer):

• Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:

(WebCore::WHLSL::Metal::FunctionDefinitionWriter::visit):

• Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.cpp:

(WebCore::WHLSL::Metal::writeNativeFunction):

• Modules/webgpu/WHLSL/WHLSLASTDumper.h:
• Modules/webgpu/WHLSL/WHLSLAutoInitializeVariables.cpp: Added.

(WebCore::WHLSL::AutoInitialize::AutoInitialize):
(WebCore::WHLSL::AutoInitialize::visit):
(WebCore::WHLSL::autoInitializeVariables):

• Modules/webgpu/WHLSL/WHLSLAutoInitializeVariables.h: Added.
• Modules/webgpu/WHLSL/WHLSLChecker.cpp:

(WebCore::WHLSL::checkOperatorOverload):
(WebCore::WHLSL::Checker::visit):

• Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:

(WebCore::WHLSL::inferTypesForCallImpl):
(WebCore::WHLSL::inferTypesForCall):

• Modules/webgpu/WHLSL/WHLSLInferTypes.h:
• Modules/webgpu/WHLSL/WHLSLPrepare.cpp:

(WebCore::WHLSL::prepareShared):

• Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:

(WebCore::WHLSL::resolveFunctionOverloadImpl):
(WebCore::WHLSL::resolveFunctionOverload):

• Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.h:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

• webgpu/whlsl-zero-initialize-values-2-expected.html: Added.
• webgpu/whlsl-zero-initialize-values-2.html: Added.
• webgpu/whlsl-zero-initialize-values-expected.html: Added.
• webgpu/whlsl-zero-initialize-values.html: Added.

12:49 PM Changeset in webkit [246272] by ysuzuki@apple.com

• 16 edits
  1 add in trunk

[JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
​https://bugs.webkit.org/show_bug.cgi?id=198023

Reviewed by Saam Barati.

JSTests:

• stress/reparsing-unlinked-codeblock.js: Added.

(shouldBe):
(hello):

Source/JavaScriptCore:

While CodeBlock is periodically jettisoned, UnlinkedCodeBlock and UnlinkedFunctionExecutable can be retained almost forever in certain type of applications.
When we execute a program, which has UnlinkedProgramCodeBlock retained in CodeCache. And UnlinkedProgramCodeBlock holds array of UnlinkedFunctionExecutable.
And UnlinkedFunctionExecutables hold UnlinkedFunctionCodeBlocks once it is generated. So eventually, this tree gets larger and larger until we purge
UnlinkedProgramCodeBlock from CodeCache. This is OK in the browser case. We navigate to various other pages, and UnlinkedProgramCodeBlocks should eventually
be pruned from CodeCache with the new ones. So this tree won't be retained forever. But the behavior is different in the other applications that do not have
navigations. If they only have one program which holds all, we basically retain this tree during executing this application. The same thing can happen in
web applications which does not have navigation and keeps alive for a long time. Once we hit CodeCache limit by periodically executing a new script, we will
hit the uppermost of memory footprint. But until that, we increase our memory footprint.

However, destroying these UnlinkedCodeBlocks and UnlinkedFunctionExecutables causes a tricky problem. In the browser environment, navigation can happen at any
time. So even if the given UnlinkedCodeBlock seems unused in the current page, it can be used when navigating to a new page which is under the same domain.
One example is initializing function in a script. It is only executed once per page. So once it is executed, it seems that this UnlinkedCodeBlock is unused.
But this will be used when we navigate to a new page. Pruning code blocks based on usage could cause performance regression.

But if our VM is mini VM mode, the story is different. In mini VM mode, we focus on memory footprint rather than performance e.g. daemons. The daemon never
reuse these CodeCache since we do not have the navigation.

This patch logically makes UnlinkedFunctionExecutable -> UnlinkedCodeBlock reference weak when VM is mini mode. If UnlinkedCodeBlock is used in previous GC
cycle, we retain it. But if it is not used, and if UnlinkedFunctionExecutable is only the cell keeping UnlinkedCodeBlock alive, we destroy it. It is a
heuristic. In a super pathological case, it could increase memory footprint. Consider the following example.

UnlinkedFunctionExecutable(A1) -> UnlinkedCodeBlock(B1) -> UnlinkedFunctionExecutable(C1) -> UnlinkedCodeBlock(D1)

CodeBlock(E1)

We could delete A1, B1, and C1 while keeping D1. But if we eventually re-execute the same code corresponding to A1, B1, C1, they will be newly created, and
we will create duplicate UnlinkedCodeBlock and instructions stream for D1.

UnlinkedCodeBlock(D1)

CodeBlock(E1)

UnlinkedFunctionExecutable(A2) -> UnlinkedCodeBlock(B2) -> UnlinkedFunctionExecutable(C2) -> UnlinkedCodeBlock(D2)

But this does not happen in practice and even it happens, we eventually discard D1 and D2 since CodeBlock E1 will be jettisoned anyway. So in practice, we do
not see memory footprint increase. We tested it in Gmail and the target application, but both said memory footprint reduction (30 MB / 400 MB and 1 MB /6 MB).
While this affects on performance much on tests which has navigation (1-3 % regression in Speedometer2, note that JetStream2 does not show regression in x64,
while it is not enabling mini mode), we do not apply this to non mini mode VM until we come up with a good strategy to fasten performance of re-generation.
Personally I think flushing destroyed UnlinkedCodeBlock to the disk sounds promising.

If UnlinkedCodeBlock is generated from bytecode cache, we do not make UnlinkedFunctionExecutable -> UnlinkedCodeBlock link weak because the decoder of the bytecode
cache assumes that generated JSCells won't be destroyed while the parent cells of that cell are live. This is true in the current implementation, and this assumption
will be broken with this patch. So, for now, we do not make this link weak. Currently, our target application does not use bytecode cache so it is OK.

This patch also introduce simple heuristic. We are counting UnlinkedCodeBlock's age. And once the age becomes maximum size, we make UnlinkedFunctionExecutable ->
UnlinkedCodeBlock link weak. We also use execution counter information to reset this age: CodeBlock will reset undelying UnlinkedCodeBlock's age if it has executed
While this heuristic is quite simple, it has some effect in practice. Basically what happens with this heuristic is that UnlinkedFunctionExecutable ->
UnlinkedCodeBlock link strong. When GC happens, we are executing some CodeBlocks, which become live. And ScriptExecutables -> UnlinkedFunctionExecutables held
by this CodeBlock become also live. Then UnlinkedFunctionExecutables can mark the child UnlinkedCodeBlocks if it is not so old.
If some of parent UnlinkedFunctionExecutable becomes dead, child UnlinkedCodeBlocks tends to be dead unless some live CodeBlock holds it. But it is OK for a first
heuristics since this means that parent code block is now considered old, reachable UnlinkedCodeBlock will be used when the parent is executed again. So destroying
the tree is OK even if the tree may include some new UnlinkedCodeBlock. While we could make more sophisticated mechanism to manage these lifetime, I think this is a
good starting point.

Based on measurement, we pick 7 as a maximum age. If we pick 0, we can get more memory reduction (1 - 1.5 MB!), while we ends up reparsing codes so many times.
It seems that 7 can reduce fair amount of memory while doing small # of reparsing on average (usually, 1, 2. Sometimes, 100. But not 300, which is the case in 0).
If we want to get more memory reduction for the sake of performance, we could decrease this age limit.

Since we do not have an automated script right now so it is a bit difficult to measure memory footprint precisely. But manual testing shows that this patch improves
memory footprint of our target application from about 6.5 MB to about 5.9 MB.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

• bytecode/CodeBlock.h:
• bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::UnlinkedCodeBlock::visitChildren):

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::age const):
(JSC::UnlinkedCodeBlock::resetAge):

• bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedFunctionExecutable::visitChildren):
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
(JSC::UnlinkedFunctionExecutable::decodeCachedCodeBlocks):
(JSC::UnlinkedFunctionExecutable::finalizeUnconditionally):

• bytecode/UnlinkedFunctionExecutable.h:
• heap/Heap.cpp:

(JSC::Heap::finalizeUnconditionalFinalizers):

• runtime/CachedTypes.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

• runtime/CodeSpecializationKind.h:
• runtime/Options.h:
• runtime/VM.cpp:

(JSC::VM::isInMiniMode): Deleted.

• runtime/VM.h:

(JSC::VM::isInMiniMode):
(JSC::VM::useUnlinkedCodeBlockJettisoning):

Tools:

• Scripts/run-jsc-stress-tests:

12:32 PM Changeset in webkit [246271] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: "Copy Path to Property" doesn't work with multiline keys
​https://bugs.webkit.org/show_bug.cgi?id=198691

Patch by Alexey Shvayka <Alexey Shvayka> on 2019-06-10
Reviewed by Matt Baker.

Correctly escape line terminators to prevent doubleQuotedString from returning malformed strings.

• UserInterface/Base/Utilities.js: Use JSON.stringify.

12:19 PM Changeset in webkit [246270] by timothy@apple.com

• 28 edits
  2 adds in trunk

Integrate dark mode support for iOS.
​https://bugs.webkit.org/show_bug.cgi?id=198687
rdar://problem/51545643

Reviewed by Tim Horton.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Tests: css-dark-mode

• Configurations/FeatureDefines.xcconfig:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::showLetterpressedGlyphsWithAdvances):

• platform/ios/LocalCurrentTraitCollection.h: Added.
• platform/ios/LocalCurrentTraitCollection.mm: Added.
• platform/ios/PasteboardIOS.mm:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::systemColor const):

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor const):

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:
• pal/spi/ios/UIKitSPI.h:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _effectiveAppearanceIsDark]):
(-[WKWebView _effectiveAppearanceIsInactive]):
(-[WKWebView _dynamicUserInterfaceTraitDidChange]):

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::effectiveAppearanceIsDark const):
(WebKit::PageClientImpl::effectiveAppearanceIsInactive const):

• UIProcess/ios/WKPasswordView.mm:

(-[WKPasswordView showInScrollView:]):
(configureScrollView): Deleted.

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/Platform.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

• platform/ios/TestExpectations:

11:01 AM Changeset in webkit [246269] by Jonathan Bedard

• 2 edits in trunk/Tools

webkitpy: xcrun simctl spawn * launchctl print system output is not utf-8
​https://bugs.webkit.org/show_bug.cgi?id=198723

Reviewed by Aakash Jain.

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.

10:59 AM Changeset in webkit [246268] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r246025): prototypes in object previews are visible even when setting showOnlyJSON
​https://bugs.webkit.org/show_bug.cgi?id=198721

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ObjectTreeView.css:

(.object-tree.properties-only.json-only .object-tree-property.prototype-property): Added.
(.object-tree.properties-only.json-only .object-tree-property .prototype-property): Deleted.

10:41 AM Changeset in webkit [246267] by ajuma@chromium.org

• 2 edits in trunk/Source/WebCore

REGRESSION (r245396): Page load time performance regression
​https://bugs.webkit.org/show_bug.cgi?id=198382

Reviewed by Per Arne Vollan.

Use a delay of 2000ms instead of 500ms when scheduling rendering updates
for IntersectionObserver targets added during page load. This is a
speculative fix for a page load time regression caused by r245396 and
still not fixed after r245958.

• dom/Document.cpp:

(WebCore::Document::scheduleTimedRenderingUpdate):

10:16 AM Changeset in webkit [246266] by Adrian Perez de Castro

• 16 edits in trunk/Source/JavaScriptCore

[JSC] Linker fails when unified sources are not in use
​https://bugs.webkit.org/show_bug.cgi?id=198722

Reviewed by Keith Miller.

Added missing inclusions of headers in several files which make use of inline functions.

• b3/B3AtomicValue.cpp:
• b3/B3BlockInsertionSet.cpp:
• b3/B3FenceValue.cpp:
• b3/B3LowerMacrosAfterOptimizations.cpp:
• b3/B3PureCSE.cpp:
• b3/B3StackmapValue.cpp:
• b3/B3SwitchValue.cpp:
• b3/B3UseCounts.cpp:
• b3/B3VariableValue.cpp:
• b3/B3WasmAddressValue.cpp:
• b3/B3WasmBoundsCheckValue.cpp:
• ftl/FTLCompile.cpp:
• wasm/WasmSectionParser.cpp:
• wasm/WasmTable.cpp:
• wasm/WasmValidate.cpp:

9:35 AM Changeset in webkit [246265] by keith_miller@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Make new Symbol/Promise API public
​https://bugs.webkit.org/show_bug.cgi?id=198709

Reviewed by Saam Barati.

We also need to #ifdef some tests when building for older
platforms because the signatures for some methods are outdated on
those platforms.

• API/JSObjectRef.h:
• API/JSObjectRefPrivate.h:
• API/JSValue.h:
• API/JSValuePrivate.h:
• API/JSValueRef.h:
• API/tests/testapi.mm:

(testObjectiveCAPIMain):

9:16 AM Changeset in webkit [246264] by sihui_liu@apple.com

• 6 edits in trunk

[WKHTTPCookieStore getAllCookies:] may return duplicate cookies
​https://bugs.webkit.org/show_bug.cgi?id=198635
<rdar://problem/46010232>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: WebKit.WKHTTPCookieStoreWithoutProcessPoolDuplicates

• platform/Cookie.h:

(WebCore::Cookie::isKeyEqual const):
(WTF::HashTraits<WebCore::Cookie>::isEmptyValue):

Source/WebKit:

When there is no process pool, we store cookies set in memory with HashSet m_pendingCookies of WebsiteDataStore.

HashSet does not contain duplicate Cookies that are completely identical, but it may contain Cookies that have
all the other properties identical other than value. This is not correct because Cookies with same name, domain
and path should be treated as the same cookie. When a cookie is set via API, we should either insert the
cookie into m_pendingCookies if the cookie does not exist, or update the cookie value if it already exists.

Note that we still use HashSet with CookieHash for m_pendingCookies because in cookie deletion, we only delete
cookie when there is a complete match. If some cookie from m_pendingCookies has all other properties the same as
the cookie specified in the deletion function, but the value is different, it will not be removed.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::addPendingCookie):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:

(areCookiesEqual):
(TEST):

8:59 AM Changeset in webkit [246263] by youenn@apple.com

• 6 edits
  2 adds
  1 delete in trunk

Call was negotiated with H264 Base Profile 42e01f but encoded in High Profile
​https://bugs.webkit.org/show_bug.cgi?id=195124
<rdar://problem/48453085>

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Use VTB directly instead of VCP when baseline is requested.
For platforms supporting the VCP-in-VTB API, use VCP for high profile, VTB for baseline.
For platforms not supporting the VCP-in-VTB API, use regular VTB for both baseline and high profile.
On MacOS, if VTB session creation fails, use VCP as a fallback.
Keep VTB-only code path for non internal builds.

• Source/webrtc/sdk/WebKit/EncoderUtilities.h: Removed.
• Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

(-[RTCSingleVideoEncoderH264 initWithCodecInfo:simulcastIndex:]):
(-[RTCSingleVideoEncoderH264 hasCompressionSession]):
(-[RTCSingleVideoEncoderH264 encode:codecSpecificInfo:frameTypes:]):
(-[RTCSingleVideoEncoderH264 resetCompressionSessionIfNeededWithFrame:]):
(-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
(-[RTCSingleVideoEncoderH264 configureCompressionSession]):
(-[RTCSingleVideoEncoderH264 destroyCompressionSession]):
(-[RTCSingleVideoEncoderH264 setEncoderBitrateBps:]):

• Source/webrtc/sdk/objc/components/video_codec/helpers.cc:
• Source/webrtc/sdk/objc/components/video_codec/helpers.h:

LayoutTests:

• webrtc/video-h264-expected.txt: Added.
• webrtc/video-h264.html: Added.

7:42 AM Changeset in webkit [246262] by Adrian Perez de Castro

• 2 edits
  2 deletes in trunk/Tools

[JHBuild] Bump shared-mime-info to version ≥ 1.6
​https://bugs.webkit.org/show_bug.cgi?id=198714

Reviewed by Carlos Garcia Campos.

• gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
• gtk/patches/shared-mime-info-xht-glob.patch: Removed.
• gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.

7:39 AM WebKitGTK/2.24.x edited by Adrian Perez de Castro

(diff)

7:39 AM Changeset in webkit [246261] by Adrian Perez de Castro

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merged r245848 - [MSE][GStreamer] update the readyState correctly in MediaPlayerPrivateGStreamerMSE
​https://bugs.webkit.org/show_bug.cgi?id=197834

Patch by Yacine Bandou <​yacine.bandou@softathome.com> on 2019-05-28
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The buffering state and the m_downloadFinished boolean aren't supported in the MSE case.
When the readyState is already "HaveEnoughData", we don't want to revert it to "HaveFutureData",
or else the MediaPlayer would send a "canplay" event instead of a "canplaythrough".

Test: media/media-source/media-source-canplaythrough-event.html

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):

LayoutTests:

Add a new test that checks if the MediaElement receives the "canplaythrough"
event when the media content is entirely injected to MSE sourceBuffer.

• media/media-source/media-source-canplaythrough-event-expected.txt: Added.
• media/media-source/media-source-canplaythrough-event.html: Added.

7:39 AM Changeset in webkit [246260] by Adrian Perez de Castro

• 9 edits in releases/WebKitGTK/webkit-2.24

Merged r245514 - [GLIB] Crash when instantiating a js object registered with jsc_context_register_class on window object cleared
​https://bugs.webkit.org/show_bug.cgi?id=198037

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

This happens because JSCClass is keeping a pointer to the JSCContext used when the class is registered, and the
context can be destroyed before the class. We can't a reference to the context, because we don't really want to
keep it alive. The life of the JSCClass is not attached to the JSCContext, but to its wrapped global context, so
we can keep a pointer to the JSGlobalContextRef instead and create a new JSCContext wrapping it when
needed. This patch is also making the context property of JSCClass non-readable, which was always the intention,
that's why there isn't a public getter in the API.

• API/glib/JSCCallbackFunction.cpp:

(JSC::JSCCallbackFunction::construct): Pass the context to jscClassGetOrCreateJSWrapper().

• API/glib/JSCClass.cpp:

(jscClassGetProperty): Remove the getter for context property.
(jscClassSetProperty): Get the JSGlobalContextRef from the given JSCContext.
(jsc_class_class_init): Make context writable only.
(jscClassCreate): Use the passed in context instead of the member.
(jscClassGetOrCreateJSWrapper): It receives now the context as parameter.
(jscClassCreateContextWithJSWrapper): Ditto.
(jscClassCreateConstructor): Get or create a JSCContext for our JSGlobalContextRef.
(jscClassAddMethod): Ditto.
(jsc_class_add_property): Ditto.

• API/glib/JSCClassPrivate.h:
• API/glib/JSCContext.cpp:

(jsc_context_evaluate_in_object): Pass the context to jscClassCreateContextWithJSWrapper().

• API/glib/JSCValue.cpp:

(jsc_value_new_object): Pass the context to jscClassGetOrCreateJSWrapper().

Tools:

Add a test case to check the crash is fixed.

• TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebExtensionWindowObjectCleared):

• TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:

(windowObjectCleared):

7:39 AM Changeset in webkit [246259] by Adrian Perez de Castro

• 6 edits in releases/WebKitGTK/webkit-2.24/Source

Merged r245681 - Fix a few missing header inclusions often masked by by unified sources
​https://bugs.webkit.org/show_bug.cgi?id=198180

Reviewed by Eric Carlson.

Source/JavaScriptCore:

• assembler/PerfLog.cpp: Add missing <array> header inclusion.
• wasm/WasmBinding.cpp: Add missing "WasmCallingConvention.h" inclusion.

Source/WebCore:

• editing/markup.h: Add missing "FloatSize.h" inclusion.
• html/FeaturePolicy.cpp: Add missing "HTMLParserIdioms.h" inclusion.
• platform/text/TextCodec.cpp: Add missing <cstdio> inclusion.

7:38 AM Changeset in webkit [246258] by Adrian Perez de Castro

• 3 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merged r245676 - [WPE] Build fails with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF
​https://bugs.webkit.org/show_bug.cgi?id=198125

Reviewed by Philippe Normand.

• UIProcess/glib/WebProcessPoolGLib.cpp: Guard the inclusion of GStreamerCommon.h with USE(GSTREAMER).
• WebProcess/glib/WebProcessGLib.cpp: Ditto.

7:04 AM Changeset in webkit [246257] by Philippe Normand

• 8 edits in trunk

[WPE][Qt] Port to new wpe_fdo_egl_exported_image API
​https://bugs.webkit.org/show_bug.cgi?id=198713

Reviewed by Carlos Garcia Campos.

.:

• Source/cmake/OptionsWPE.cmake:

Source/WebKit:

• UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:

(WPEQtViewBackend::WPEQtViewBackend):
(WPEQtViewBackend::texture):
(WPEQtViewBackend::displayImage):

• UIProcess/API/wpe/qt/WPEQtViewBackend.h:

Tools:

• flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo

patches currently used in JHBuild.

6:17 AM Changeset in webkit [246256] by Adrian Perez de Castro

• 2 edits in trunk/Tools

[GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
​https://bugs.webkit.org/show_bug.cgi?id=198711

Reviewed by Philippe Normand.

• flatpak/org.webkit.GTK.yaml: Also include modules from

org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo

3:03 AM EnvironmentVariables edited by Philippe Normand

(diff)

3:02 AM EnvironmentVariables edited by Philippe Normand

(diff)

3:01 AM EnvironmentVariables edited by Philippe Normand

(diff)

12:19 AM Changeset in webkit [246255] by zandobersek@gmail.com

• 3 edits
  2 adds in trunk/Tools

Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
avoids double-free condition that's causing bots to exit early.

• gtk/jhbuild.modules:
• gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
• wpe/jhbuild.modules:
• wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.

Jun 9, 2019:

11:25 PM Changeset in webkit [246254] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.27-branch/Source/WebKit

Cherry-pick r246248. rdar://problem/51538088

[iOS] ResourceLoadStatistics state is not properly relayed to the NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=198692
<rdar://problem/51538088>

Reviewed by Maciej Stachowiak.

• UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::setResourceLoadStatisticsEnabled): Message the NetworkProcess on state change.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:25 PM Changeset in webkit [246253] by bshafiei@apple.com

• 3 edits in branches/safari-608.1.27-branch/Source/WebKit

Cherry-pick r246239. rdar://problem/51462498

Drag starting state can get stuck even though the drag has ended
​https://bugs.webkit.org/show_bug.cgi?id=198696
<rdar://problem/51556045>

Reviewed by Wenson Hsieh.

In iOS 13, we're seeing cases of the DragSession not
correctly ending, and thus leaving m_isStartingDrag in
an incorrect state. Temporarily force this to be reset
in ::dragEnded while investigating

• UIProcess/ios/WKContentViewInteraction.mm: Add some more release logging while here. (-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]): (-[WKContentView dragInteraction:item:willAnimateCancelWithAnimator:]):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::dragEnded):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:25 PM Changeset in webkit [246252] by bshafiei@apple.com

• 17 edits
  6 copies in branches/safari-608.1.27-branch/Source/WebKit

Cherry-pick r246224. rdar://problem/51462498

Introduce new SPI for context menus on iOS
​https://bugs.webkit.org/show_bug.cgi?id=198590

Reviewed by Tim Horton.

Also introduce WKContextMenuElementInfo which is API.
This is part of <rdar://problem/51003503>

• Shared/API/APIObject.h:
• Shared/API/Cocoa/WebKit.h:
• Shared/Cocoa/APIObject.mm: (API::Object::newObject):
• Sources.txt:
• SourcesCocoa.txt:
• UIProcess/API/APIContextMenuElementInfo.cpp: Added. (API::ContextMenuElementInfo::ContextMenuElementInfo):
• UIProcess/API/APIContextMenuElementInfo.h: Added.
• UIProcess/API/Cocoa/WKContextMenuElementInfo.h: Added.
• UIProcess/API/Cocoa/WKContextMenuElementInfo.mm: Added. (-[WKContextMenuElementInfo linkURL]): (-[WKContextMenuElementInfo _apiObject]): (-[WKContextMenuElementInfo _activatedElementInfo]):
• UIProcess/API/Cocoa/WKContextMenuElementInfoInternal.h: Added.
• UIProcess/API/Cocoa/WKContextMenuElementInfoPrivate.h: Added.
• UIProcess/API/Cocoa/WKPreviewElementInfo.h:
• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/API/Cocoa/_WKActivatedElementInfo.h:
• UIProcess/API/Cocoa/_WKActivatedElementInfo.mm: (-[_WKActivatedElementInfo _initWithInteractionInformationAtPosition:]): (-[_WKActivatedElementInfo isAnimatedImage]):
• UIProcess/ios/WKActionSheetAssistant.h:
• UIProcess/ios/WKActionSheetAssistant.mm: (-[WKActionSheetAssistant defaultActionsForLinkSheet:]): (-[WKActionSheetAssistant defaultActionsForImageSheet:]):
• UIProcess/ios/WKContentView.h:
• UIProcess/ios/WKContentViewInteraction.mm:
• WebKit.xcodeproj/project.pbxproj:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:25 PM Changeset in webkit [246251] by bshafiei@apple.com

• 7 edits
  2 adds in branches/safari-608.1.27-branch

Cherry-pick r246213. rdar://problem/50114230

Restrict fast clicks everywhere to desktop content mode
​https://bugs.webkit.org/show_bug.cgi?id=198610
<rdar://problem/50114230>

Reviewed by Dean Jackson.

Source/WebKit:

We now set a new allowsFastClicksEverywhere property on the WebPageProxy when the content mode changes, set to true
when we're in desktop browsing mode. We now check on this property to opt into the fast clicks everywhere behavior.

This patch had been reverted once because it yielded some regressions in existing tests, notably under
fast/events/touch/ios/content-observation. This updated patch addresses this by ensuring the gesture recognizers
used for double-tap-to-zoom are disabled in -[WKContentViewInteraction _didStartProvisionalLoadForMainFrame]
to ensure that two tests dispatching a tap at the same location don't yield the recognition of a double-tap
rathern than the recognition of two single taps.

• UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::allowsFastClicksEverywhere const):
• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:]): (_didStartProvisionalLoadForMainFrame):
• UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):

LayoutTests:

Add a new test that enables fast clicks but also sets a mobile content mode.

We also mark fast/visual-viewport/ios/min-scale-greater-than-one.html as non-flaky
since the flakiness was due to the fast clicks everywhere behavior being enabled on iPhone.

Finally, we can now remove the hack where ui.tap() in the Pointer Events utility returned
a promise with a one-second delay since the issue of double-taps being recognized instead of
two consecutive single taps across two tests has been resolved.

• fast/events/ios/ipad/fast-click-always-mobile-content-mode-expected.txt: Added.
• fast/events/ios/ipad/fast-click-always-mobile-content-mode.html: Added.
• platform/ios-simulator-wk2/TestExpectations:
• pointerevents/utils.js:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:25 PM Changeset in webkit [246250] by bshafiei@apple.com

• 40 edits
  1 move
  1 add
  1 delete in branches/safari-608.1.27-branch

Cherry-pick r246118. rdar://problem/50114230

Upstream content mode support into open source from WebKitAdditions
​https://bugs.webkit.org/show_bug.cgi?id=198484
<rdar://problem/51355671>

Reviewed by Andy Estes.

Source/WebCore:

• Modules/modern-media-controls/media/media-controller.js: (MediaController.prototype.get layoutTraits):

Adjust modern media controls code to use iOS-style controls on PLATFORM(IOS_FAMILY), instead of depending on the
navigator's platform name or the presence of touch events.

• page/Quirks.cpp: (WebCore::shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreasForHost): (WebCore::shouldEmulateUndoRedoInHiddenEditableAreasForHost):
• page/SettingsBase.h:
• rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::mediaControlsScript):

Source/WebCore/PAL:

Add some new constants to MobileGestaltSPI.h.

• pal/spi/ios/MobileGestaltSPI.h:

Source/WebKit:

Move code for handling WKContentMode into open source. No change in behavior, for internal builds.

• Shared/API/Cocoa/WebKit.apinotes:
• Shared/WebContentMode.h: Renamed from Source/WebKit/Shared/WebCompatibilityMode.h.
• Shared/WebPreferences.yaml:
• UIProcess/API/APINavigation.h: (API::Navigation::setEffectiveContentMode): (API::Navigation::effectiveContentMode const): (API::Navigation::setEffectiveCompatibilityMode): Deleted. (API::Navigation::effectiveCompatibilityMode const): Deleted.
• UIProcess/API/APINavigationClient.h: (API::NavigationClient::shouldBypassContentModeSafeguards const): (API::NavigationClient::shouldBypassCompatibilityModeSafeguards const): Deleted.
• UIProcess/API/APIWebsitePolicies.cpp: (API::WebsitePolicies::copy const):
• UIProcess/API/APIWebsitePolicies.h:
• UIProcess/API/Cocoa/WKNavigation.h:
• UIProcess/API/Cocoa/WKNavigation.mm: (-[WKNavigation effectiveContentMode]):
• UIProcess/API/Cocoa/WKWebpagePreferences.h:
• UIProcess/API/Cocoa/WKWebpagePreferences.mm: (WebKit::contentMode): (WebKit::webContentMode): (-[WKWebpagePreferences _allowSiteSpecificQuirksToOverrideCompatibilityMode]): (-[WKWebpagePreferences _setAllowSiteSpecificQuirksToOverrideCompatibilityMode:]): (-[WKWebpagePreferences setPreferredContentMode:]): (-[WKWebpagePreferences preferredContentMode]):
• UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h:
• UIProcess/Cocoa/NavigationState.h:
• UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::NavigationClient::shouldBypassContentModeSafeguards const): (WebKit::NavigationState::NavigationClient::shouldBypassCompatibilityModeSafeguards const): Deleted.
• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies): (WebKit::WebPageProxy::effectiveCompatibilityModeAfterAdjustingPolicies): Deleted.
• UIProcess/WebPageProxy.h:
• UIProcess/ios/WebPageProxyIOS.mm: (WebKit::desktopClassBrowsingSupported): (WebKit::webViewSizeIsNarrow): (WebKit::desktopClassBrowsingRecommendedForRequest): (WebKit::desktopClassBrowsingRecommended): (WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
• WebKit.xcodeproj/project.pbxproj:

Tools:

Change the "useModernCompatibilityMode" layout test option to instead be "contentMode", with values of either
"mobile" or "desktop".

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Removed.
• TestWebKitAPI/ios/PreferredContentMode.mm: Added. (-[ContentModeNavigationDelegate setDecidePolicyForNavigationActionWithPreferences:]): (-[ContentModeNavigationDelegate decidePolicyForNavigationActionWithPreferences]): (-[ContentModeNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]): (+[WKWebpagePreferences preferencesWithContentMode:]): (-[WKWebView navigatorUserAgent]): (-[WKWebView navigatorPlatform]): (-[WKWebView loadTestPageNamed:withPolicyDecisionHandler:]): (-[WKWebView loadHTMLString:withPolicyDecisionHandler:]): (-[WKWebView loadTestPageNamed:andExpectEffectiveContentMode:withPolicyDecisionHandler:]): (-[NSString shouldContainStrings:]): (IPhoneUserInterfaceSwizzler::IPhoneUserInterfaceSwizzler): (IPhoneUserInterfaceSwizzler::phoneUserInterfaceIdiom): (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate): (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting): (TestWebKitAPI::makeContentModeDecisionHandler): (TestWebKitAPI::TEST):
• WebKitTestRunner/TestController.cpp: (WTR::updateTestOptionsFromTestHeader):
• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestOptions.h: (WTR::TestOptions::hasSameInitializationOptions const):
• WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): (WTR::TestController::configureContentMode): (WTR::TestController::enableModernCompatibilityMode): Deleted.

LayoutTests:

Explicitly opt a few tests into desktop or mobile content mode.

• fast/media/ios/ipad/enable-MediaSource-API-in-modern-compatibility-mode.html:
• fast/scrolling/ipad/overflow-scrolling-touch-enabled-stacking-modern-compatibility-mode-expected.html:
• fast/scrolling/ipad/overflow-scrolling-touch-enabled-stacking-modern-compatibility-mode.html:
• media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode.html:
• platform/ipad/fast/css/webkit-overflow-scrolling-parsing-modern-compatibility-mode.html:
• platform/ipad/fast/viewport/empty-meta.html:
• platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html:
• platform/ipad/media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:22 PM Changeset in webkit [246249] by Fujii Hironori

• 2 edits in trunk/Tools

[WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
​https://bugs.webkit.org/show_bug.cgi?id=198655

Reviewed by Ross Kirsling.

MediaCapabilities is enabled by default for WK2, but WinCairo
doesn't implemented yet. Disable it in MiniBrowser.

• MiniBrowser/win/WebKitBrowserWindow.cpp:

(WebKitBrowserWindow::create):

5:25 PM Changeset in webkit [246248] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[iOS] ResourceLoadStatistics state is not properly relayed to the NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=198692
<rdar://problem/51538088>

Reviewed by Maciej Stachowiak.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setResourceLoadStatisticsEnabled): Message the NetworkProcess
on state change.

2:47 PM Changeset in webkit [246247] by bshafiei@apple.com

• 3 edits in tags/Safari-608.1.28.1/Source/WebCore

Cherry-pick r246216. rdar://problem/51345064

Fix non-iOS build after r246205
​https://bugs.webkit.org/show_bug.cgi?id=198657

Reviewed by Brent Fulgham.
<rdar://problem/51345064>

• page/Quirks.cpp:
• page/Quirks.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:16 PM Changeset in webkit [246246] by bshafiei@apple.com

• 8 edits in tags/Safari-608.1.28.1/Source/WebCore

Cherry-pick r246207. rdar://problem/51185518

Images are not resizing correctly when dragged to a message in 1/3 view
​https://bugs.webkit.org/show_bug.cgi?id=198623
<rdar://problem/51185518>

Reviewed by Wenson Hsieh.

Mail's max-width: 100%; default style is in conflict with the preferred presentation size. This patch preserves the existing behaviour for Mail by
not setting the height (and rely on the width + aspect ratio).

• editing/WebContentReader.h:
• editing/cocoa/WebContentReaderCocoa.mm: (WebCore::createFragmentForImageAttachment): (WebCore::WebContentReader::readImage): (WebCore::attachmentForFilePath): (WebCore::attachmentForData): (WebCore::WebContentReader::readFilePath): (WebCore::WebContentReader::readDataBuffer):
• editing/gtk/EditorGtk.cpp: (WebCore::createFragmentFromPasteboardData):
• editing/markup.cpp: (WebCore::createFragmentForImageAndURL):
• editing/markup.h:
• platform/Pasteboard.h: (WebCore::PasteboardWebContentReader::readFilePath): (WebCore::PasteboardWebContentReader::readImage): (WebCore::PasteboardWebContentReader::readDataBuffer):
• platform/PasteboardItemInfo.h: (WebCore::PasteboardItemInfo::encode const): (WebCore::PasteboardItemInfo::decode):
• platform/ios/PasteboardIOS.mm: (WebCore::Pasteboard::readPasteboardWebContentDataForType): (WebCore::Pasteboard::read): (WebCore::Pasteboard::readRespectingUTIFidelities):
• platform/ios/PlatformPasteboardIOS.mm: (WebCore::PlatformPasteboard::informationForItemAtIndex):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:15 PM Changeset in webkit [246245] by bshafiei@apple.com

• 3 edits in tags/Safari-608.1.28.1/Source/WebCore

Cherry-pick r246205. rdar://problem/51345064

Limit simulated mouse events on Google Maps to entering Street View
​https://bugs.webkit.org/show_bug.cgi?id=198657
<rdar://problem/51345064>

Reviewed by Brent Fulgham.

• page/Quirks.cpp: (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const): (WebCore::Quirks::shouldDispatchSimulatedMouseEventsOnTarget const):
• page/Quirks.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:15 PM Changeset in webkit [246244] by bshafiei@apple.com

• 2 edits in tags/Safari-608.1.28.1/Source/WebCore

Cherry-pick r246099. rdar://problem/48006291

iPadOS: Google calendars new event picker moves and flickers in landscape with software keyboard
​https://bugs.webkit.org/show_bug.cgi?id=198556

Reviewed by Wenson Hsieh.

Fix the issuse that it's really hard to create a new event using Google calendar on iPadOS with
a software keyboard enabled because tapping on date brings up software keyboard and erratically
shifts up/down the new event dialog/pane.

Add a site specific quirk to pretend these input elements have inputmode=none for now.

No new tests since this is a site specific quirk.

• page/Quirks.cpp: (WebCore::Quirks::needsInputModeNoneImplicitly const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:15 PM Changeset in webkit [246243] by bshafiei@apple.com

• 4 edits
  2 adds in tags/Safari-608.1.28.1

Cherry-pick r246096. rdar://problem/51375055

[ContentChangeObserver] Gmail text editing controls require two taps
​https://bugs.webkit.org/show_bug.cgi?id=198541
<rdar://problem/51375055>

Reviewed by Simon Fraser.

Source/WebCore:

When the animation completes we should also check if the newly visible content is also clickable and report it accordingly.
When the animated content is not clickable, we need to proceed with click instead of stopping at hover.

Test: fast/events/touch/ios/content-observation/100ms-delay-10ms-transition-on-mousemove-no-clickable.html

• page/ios/ContentChangeObserver.cpp: (WebCore::isConsideredClickable): (WebCore::ContentChangeObserver::didFinishTransition): (WebCore::ContentChangeObserver::adjustObservedState): (WebCore::ContentChangeObserver::StyleChangeScope::~StyleChangeScope): (WebCore::ContentChangeObserver::StyleChangeScope::isConsideredClickable const): Deleted. -> Turn it into a static function so that didFinishTransition could call it as well.
• page/ios/ContentChangeObserver.h:

LayoutTests:

• fast/events/touch/ios/content-observation/100ms-delay-10ms-transition-on-mousemove-no-clickable.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:06 PM Changeset in webkit [246242] by bshafiei@apple.com

• 7 edits in tags/Safari-608.1.28.1/Source

Versioning.

1:56 PM Changeset in webkit [246241] by bshafiei@apple.com

• 1 copy in tags/Safari-608.1.28.1

New tag.

1:28 PM Changeset in webkit [246240] by commit-queue@webkit.org

• 20 edits in trunk/Source

Unreviewed, rolling out r246150, r246160, and r246166.
​https://bugs.webkit.org/show_bug.cgi?id=198698

Regresses page loading time on iOS 13 (Requested by keith_m
on #webkit).

Reverted changesets:

"Reenable Gigacage on ARM64."
​https://bugs.webkit.org/show_bug.cgi?id=198453
​https://trac.webkit.org/changeset/246150

"Unrevied build fix for FTL without Gigacage."
​https://trac.webkit.org/changeset/246160

"Fix typo in cageWithoutUntagging"
​https://bugs.webkit.org/show_bug.cgi?id=198617
​https://trac.webkit.org/changeset/246166

1:03 PM Changeset in webkit [246239] by dino@apple.com

• 3 edits in trunk/Source/WebKit

Drag starting state can get stuck even though the drag has ended
​https://bugs.webkit.org/show_bug.cgi?id=198696
<rdar://problem/51556045>

Reviewed by Wenson Hsieh.

In iOS 13, we're seeing cases of the DragSession not
correctly ending, and thus leaving m_isStartingDrag in
an incorrect state. Temporarily force this to be reset
in ::dragEnded while investigating

• UIProcess/ios/WKContentViewInteraction.mm: Add some more release logging

while here.
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
(-[WKContentView dragInteraction:item:willAnimateCancelWithAnimator:]):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dragEnded):

4:55 AM Changeset in webkit [246238] by commit-queue@webkit.org

• 7 edits in trunk

Add wildcard to Access-Control-Allow-Methods and Access-Control-Allow-Headers
​https://bugs.webkit.org/show_bug.cgi?id=165508

Patch by Rob Buis <​rbuis@igalia.com> on 2019-06-09
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt:

Source/WebCore:

According to the spec [1] step 6.5, a wildcard for method
and request's credentials mode should be taken into account, so
add this to the check. Same for Access-Control-Allow-Headers (step 6.7).

[1] ​https://fetch.spec.whatwg.org/#cors-preflight-fetch

Tests: web-platform-tests/fetch/api/cors/cors-preflight-star.any.html

web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker.html

• loader/CrossOriginAccessControl.cpp:

(WebCore::validatePreflightResponse):

• loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod const):
(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders const):
(WebCore::CrossOriginPreflightResultCacheItem::allowsRequest const):

• loader/CrossOriginPreflightResultCache.h:

12:09 AM Changeset in webkit [246237] by ysuzuki@apple.com

• 3 edits
  1 add in trunk

[JSC] Use mergePrediction in ValuePow prediction propagation
​https://bugs.webkit.org/show_bug.cgi?id=198648

Reviewed by Saam Barati.

JSTests:

• stress/prediction-propagation-should-use-merge-prediction-for-value-pow.js: Added.

Source/JavaScriptCore:

We are accidentally using setPrediction. This is wrong since prediction propagation (not processInvariant)
must extend the speculation types to ensure we eventually reach to the fixed point. setPrediction can discard
previously configured predictions, can lead to oscillation potentially. Use mergePrediction instead.

• dfg/DFGPredictionPropagationPhase.cpp: