Timeline

Jun 16, 2019:

10:04 PM Changeset in webkit [246492] by Alan Bujtas

• 2 edits in trunk/Tools

[LFC] Expand tests coverage (325 new tests -> 1198).

• LayoutReloaded/misc/LFC-passing-tests.txt:

6:59 PM Changeset in webkit [246491] by Darin Adler

• 10 edits in trunk

Convert some uses of fixed width and fixed precision floating point formatting to use shortest instead
​https://bugs.webkit.org/show_bug.cgi?id=198896

Reviewed by Sam Weinig.

Source/WebCore:

• Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::loggingString const): Removed unneeded use of
FormattedNumber::fixedWidth to override the default shortest-form formatting.

• page/History.cpp:

(WebCore::History::stateObjectAdded): Ditto.

• page/PrintContext.cpp:

(WebCore::PrintContext::pageProperty): Use String::number instead of
String::numberToStringFixedPrecision. Also removed some uses of
FormattedNumber::fixedPrecision.

• platform/graphics/FloatPolygon.cpp:

(WebCore::FloatPolygonEdge::debugString const): Ditto.

LayoutTests:

• fast/loader/stateobjects/pushstate-frequency-expected.txt:
• fast/loader/stateobjects/pushstate-frequency-iframe-expected.txt:
• fast/loader/stateobjects/replacestate-frequency-expected.txt:
• fast/loader/stateobjects/replacestate-frequency-iframe-expected.txt:

Updated to expect cleaner output without ".000000".

6:48 PM Changeset in webkit [246490] by Darin Adler

• 1248 edits
  6 moves
  3 adds
  3 deletes in trunk

Rename AtomicString to AtomString
​https://bugs.webkit.org/show_bug.cgi?id=195276

Reviewed by Michael Catanzaro.

• many files: Let do-webcore-rename do the renaming.

Source/WTF:

• wtf/text/AtomString.h: After renaming, added AtomicString as a synonym for

now; helps smooth things over with a tiny bit of Apple internal software so
we don't have to do this all at once. Can remove it soon.

Tools:

• Scripts/do-webcore-rename: Updated with a list of all the identifiers

that mention "atomic string" and changed them to instead say "atom string".

6:38 PM Changeset in webkit [246489] by eric.carlson@apple.com

• 5 edits in trunk/Source

[MediaStream] Avoid roundoff error when setting AVCapture min/max frame rate
​https://bugs.webkit.org/show_bug.cgi?id=198875
<rdar://problem/51768374>

Reviewed by Youenn Fablet.

Source/WebCore:

• platform/graphics/MediaPlayer.h:

(WTF::LogArgument<MediaTime>::toString): Deleted, moved to MediaTime.h.
(WTF::LogArgument<MediaTimeRange>::toString): Deleted, moved to MediaTime.h.

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setSessionSizeAndFrameRate): Avoid roundoff error.

Source/WTF:

• wtf/MediaTime.h:

(WTF::LogArgument<MediaTime>::toString):
(WTF::LogArgument<MediaTimeRange>::toString):

5:33 PM Changeset in webkit [246488] by Simon Fraser

• 20 edits in trunk/Source

Implement ScrollableArea::scrollOffset()
​https://bugs.webkit.org/show_bug.cgi?id=198895

Reviewed by Antti Koivisto.

Source/WebCore:

Remove from ScrollableArea the following:

virtual int scrollSize(ScrollbarOrientation) const = 0;
virtual int scrollOffset(ScrollbarOrientation) const = 0;

and instead implement ScrollOffset scrollOffset() const.

Also make scrollPosition() pure virtual, avoiding the reverse dependency where
this base class implementation got values from scrollbars.

scrollSize(ScrollbarOrientation) was only used by ScrollAnimatorIOS and we can
do the same computation via min/max scroll positions.

RenderListBox and PopupMenuWin need implementations of scrollPosition().

Remove some PLATFORM(IOS_FAMILY) #ifdefs from ScrollableArea for code that compiles
on all platforms.

• page/FrameView.h:
• platform/ScrollView.cpp:

(WebCore::ScrollView::overhangAmount const):
(WebCore::ScrollView::scrollSize const): Deleted.
(WebCore::ScrollView::scrollOffset const): Deleted.

• platform/ScrollView.h:
• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::isPinnedVerticallyInDirection const):
(WebCore::ScrollableArea::scrollOffset const):
(WebCore::ScrollableArea::scrollPosition const): Deleted.

• platform/ScrollableArea.h:

(WebCore::offsetForOrientation):
(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition const):
(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition const):
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMinimumPosition const):
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMaximumPosition const):
(WebCore::ScrollableArea::tiledBacking const): Deleted.

• platform/Scrollbar.cpp:

(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::offsetDidChange):

• platform/ios/ScrollAnimatorIOS.mm:

(WebCore::ScrollAnimatorIOS::handleTouchEvent):

• platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::scrollPosition const):
(WebCore::PopupMenuWin::wndProc):
(WebCore::PopupMenuWin::scrollSize const): Deleted.
(WebCore::PopupMenuWin::scrollOffset const): Deleted.

• platform/win/PopupMenuWin.h:

(WebCore::PopupMenuWin::scrollOffset const): Deleted.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollSize const): Deleted.
(WebCore::RenderLayer::scrollOffset const): Deleted.

• rendering/RenderLayer.h:
• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollPosition const):
(WebCore::RenderListBox::scrollSize const): Deleted.
(WebCore::RenderListBox::scrollOffset const): Deleted.

• rendering/RenderListBox.h:

Source/WebKit:

• UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::PopupMenuWin::scrollPosition const):
(WebKit::WebPopupMenuProxyWin::onKeyDown): Just use m_scrollOffset.
(WebKit::WebPopupMenuProxyWin::scrollSize const): Deleted.

• UIProcess/win/WebPopupMenuProxyWin.h: Remove the one-axis scrollOffset()
• WebProcess/Plugins/PDF/PDFPlugin.h:
• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::scrollSize const): Deleted.
(WebKit::PDFPlugin::scrollOffset const): Deleted.

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):

3:06 PM Changeset in webkit [246487] by ysuzuki@apple.com

• 5 edits
  1 add in trunk

[JSC] Grown region of WasmTable should be initialized with null
​https://bugs.webkit.org/show_bug.cgi?id=198903

Reviewed by Saam Barati.

JSTests:

• wasm/stress/wasm-table-grow-initialize.js: Added.

(shouldBe):

Source/JavaScriptCore:

Grown region of Wasmtable is now empty. We should initialize it with null.
We also rename Wasm::Table::visitChildren to Wasm::Table::visitAggregate to
align to the naming convention.

• wasm/WasmTable.cpp:

(JSC::Wasm::Table::grow):
(JSC::Wasm::Table::visitAggregate):
(JSC::Wasm::Table::visitChildren): Deleted.

• wasm/WasmTable.h:
• wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::visitChildren):

2:04 PM Changeset in webkit [246486] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

Address Sam's post-landing review of r246234.

• layout/inlineformatting/InlineFormattingContextLineLayout.cpp:

(WebCore::Layout::InlineFormattingContext::LineLayout::createDisplayRuns const):

1:51 PM Changeset in webkit [246485] by Alan Bujtas

• 2 edits in trunk/Tools

[LFC] Unreviewed test gardening.

Unsupported alignments.

fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
fast/borders/empty-outline-border-assert.html -vertical-align: super
css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle

• LayoutReloaded/misc/LFC-passing-tests.txt:

1:41 PM Changeset in webkit [246484] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][IFC] Decouple baseline ascent/descent and baseline offset.
​https://bugs.webkit.org/show_bug.cgi?id=198901
<rdar://problem/51782393>

Reviewed by Antti Koivisto.

Baseline offset is the baseline's distance from the line's logical top -and it is not necessarily the same as the baseline's ascent.
It's easier to track the baseline and its top separately since certain properties only change one or the other.

• layout/inlineformatting/InlineFormattingContextLineLayout.cpp:

(WebCore::Layout::InlineFormattingContext::LineLayout::placeInlineItems const):
(WebCore::Layout::InlineFormattingContext::LineLayout::createDisplayRuns const):

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::Line):
(WebCore::Layout::Line::close):
(WebCore::Layout::Line::adjustBaselineAndLineHeight):
(WebCore::Layout::Line::halfLeadingMetrics):

• layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Content::baselineOffset const):
(WebCore::Layout::Line::Content::setBaselineOffset):
(WebCore::Layout::Line::baselineOffset const):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::baselineOffset const):
(WebCore::Layout::LineBox::LineBox):

1:19 PM Changeset in webkit [246483] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

[LFC][IFC] Intruding float may prevent adding any inline box
​https://bugs.webkit.org/show_bug.cgi?id=198891
<rdar://problem/51779956>

Reviewed by Antti Koivisto.

Take the intruding left/right float pair and find the vertical position where the next line might go
if these floats prevent us from adding even one inline box to the current line.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::mapPointToAncestor):
(WebCore::Layout::FormattingContext::mapPointToDescendent):

• layout/FormattingContext.h:
• layout/LayoutUnits.h:

(WebCore::Layout::Point::max):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextLineLayout.cpp:

(WebCore::Layout::InlineFormattingContext::LineLayout::placeInlineItems const):
(WebCore::Layout::InlineFormattingContext::LineLayout::layout const):

1:15 PM Changeset in webkit [246482] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

[LFC][Floats] Add bottom value to FloatingState::Constraints
​https://bugs.webkit.org/show_bug.cgi?id=198889
<rdar://problem/51776730>

Reviewed by Antti Koivisto.

Constraints::left/right->y indicates where this particular constrain ends. This is going to be used by inline layout to figure where
the next line should go (vertical position).

• layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::constraints const):

• layout/floats/FloatingState.h:

1:04 PM Changeset in webkit [246481] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Ignore descent when in limited/full quirks mode
​https://bugs.webkit.org/show_bug.cgi?id=198893
<rdar://problem/51780634>

Reviewed by Antti Koivisto.

In limited/full quirks mode, line's descent should be ignored when computing the final line height when

1. the line has baseline aligned content only and
2. these baseline aligned boxes don't have descent.

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::isVisuallyEmpty const):
(WebCore::Layout::Line::close):

1:02 PM Changeset in webkit [246480] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Line::isVisuallyEmpty should check inline-block boxes.
​https://bugs.webkit.org/show_bug.cgi?id=198894
<rdar://problem/51780886>

Reviewed by Antti Koivisto.

Non-zero width/height inline-block boxes make the line visually non-empty.

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::isVisuallyEmpty const):

12:33 PM Changeset in webkit [246479] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC] Add Layout::Box::isContainingBlockDescendantOf
​https://bugs.webkit.org/show_bug.cgi?id=198888
<rdar://problem/51776466>

Reviewed by Antti Koivisto.

Box::isDescendantOf indicates simple ancestor - descendant relationship, while
isContainingBlockDescendantOf checks the containing block chain.

• layout/FormattingContext.cpp:

(WebCore::Layout::mapHorizontalPositionToAncestor):
(WebCore::Layout::FormattingContext::mapBoxToAncestor):
(WebCore::Layout::FormattingContext::mapTopToAncestor):
(WebCore::Layout::FormattingContext::mapPointToAncestor):

• layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::FloatItem::isDescendantOfFormattingRoot const):

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isDescendantOf const):
(WebCore::Layout::Box::isContainingBlockDescendantOf const):

• layout/layouttree/LayoutBox.h:

12:32 PM Changeset in webkit [246478] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Remove Line::Content::isVisuallyEmpty
​https://bugs.webkit.org/show_bug.cgi?id=198892
<rdar://problem/51780345>

Reviewed by Antti Koivisto.

Instead of setting the isVisuallyEmpty flag, reset the line height to 0.

• layout/inlineformatting/InlineFormattingContextLineLayout.cpp:

(WebCore::Layout::InlineFormattingContext::LineLayout::createDisplayRuns const):

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::close):

• layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Content::isEmpty const):
(WebCore::Layout::Line::Content::setBaseline):
(WebCore::Layout::Line::Content::isVisuallyEmpty const): Deleted.
(WebCore::Layout::Line::Content::setIsVisuallyEmpty): Deleted.

12:30 PM Changeset in webkit [246477] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC] Add limited quirks mode to LayoutState.
​https://bugs.webkit.org/show_bug.cgi?id=198881
<rdar://problem/51773229>

Reviewed by Antti Koivisto.

This is in preparation for introducing limited quirks mode to inline layout.

• layout/LayoutState.h:

(WebCore::Layout::LayoutState::setQuirksMode):
(WebCore::Layout::LayoutState::inQuirksMode const):
(WebCore::Layout::LayoutState::inLimitedQuirksMode const):
(WebCore::Layout::LayoutState::inNoQuirksMode const):
(WebCore::Layout::LayoutState::setInQuirksMode): Deleted.

• page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

12:30 PM Changeset in webkit [246476] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Completely collapsed runs should not go to the trimmable run list.
​https://bugs.webkit.org/show_bug.cgi?id=198900
<rdar://problem/51782156>

Reviewed by Antti Koivisto.

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::trailingTrimmableWidth const):
(WebCore::Layout::Line::appendTextContent):

12:28 PM Changeset in webkit [246475] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Use the borderBox rect consistently to size the inline box.
​https://bugs.webkit.org/show_bug.cgi?id=198899

Reviewed by Antti Koivisto.
<rdar://problem/51781969>

Use the margin box height (when applicable) to adjust the line height and use the borderBox rect (or font size) height to size the inline box.

• layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::borderBoxHeight const):
(WebCore::Display::Box::marginBoxHeight const):

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::appendInlineContainerStart):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendNonReplacedInlineBox):
(WebCore::Layout::Line::inlineItemContentHeight const):
(WebCore::Layout::Line::inlineItemHeight const): Deleted.

• layout/inlineformatting/InlineLine.h:

11:23 AM Changeset in webkit [246474] by bshafiei@apple.com

• 1 copy in tags/Safari-607.3.1.2.3

Tag Safari-607.3.1.2.3.

10:58 AM Changeset in webkit [246473] by bshafiei@apple.com

• 1 copy in tags/Safari-607.3.4

Tag Safari-607.3.4.

Jun 15, 2019:

11:38 PM Changeset in webkit [246472] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

WebProcessPool::clearWebProcessHasUploads cannot assume its given processIdentifier is valid
​https://bugs.webkit.org/show_bug.cgi?id=198865

Unreviewed.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::clearWebProcessHasUploads):
Remove wrong debug assertion in case of WebProcessProxy destruction.

10:33 PM Changeset in webkit [246471] by Simon Fraser

• 9 edits
  1 delete in trunk

Make layerTreeAsText() output a bit less verbose
​https://bugs.webkit.org/show_bug.cgi?id=198870

Reviewed by Tim Horton.

Source/WebCore:

"accelerates drawing" was getting dumped twice for debug dumps.
Only dump the non-default state for "uses display-list drawing".
Use the new OptionSet<> dumping for GraphicsLayerPaintingPhases.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties const):
(WebCore::operator<<):

• platform/graphics/GraphicsLayer.h:
• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

LayoutTests:

• compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt:
• platform/gtk/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
• platform/ios-wk2/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt:
• platform/mac-wk1/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt:
• platform/mac/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Removed.

9:47 PM Changeset in webkit [246470] by youenn@apple.com

• 10 edits in trunk/Source/WebCore

Make MediaStream constructor take a Document instead of a ScriptExecutionContext
​https://bugs.webkit.org/show_bug.cgi?id=198873

Reviewed by Darin Adler.

Update MediaStream constructors and call site to take a Document&.
Make the same for creation of CanvasCaptureMediaStreamTrack.
No observable change of behavior.

• Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::create):
(WebCore::CanvasCaptureMediaStreamTrack::CanvasCaptureMediaStreamTrack):
(WebCore::loggerFromContext): Deleted.

• Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::clone):
(WebCore::loggerFromContext): Deleted.

• Modules/mediastream/MediaStream.h:
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::captureStream):

• html/HTMLCanvasElement.h:
• html/HTMLCanvasElement.idl:

9:46 PM Changeset in webkit [246469] by youenn@apple.com

• 2 edits in trunk/Tools

WPT test importer WTR option reader should not throw if the file is not proper UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=198780

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/w3c/test_importer.py:

(TestImporter._webkit_test_runner_options):
In case the test file cannot be read as text, consider that there is no WTR option.

12:30 PM Changeset in webkit [246468] by Alan Bujtas

• 11 edits in trunk/Source/WebCore

[LFC][BFC] Fix available width for non-floating positioned float avoiders.
​https://bugs.webkit.org/show_bug.cgi?id=198886
<rdar://problem/51773643>

Reviewed by Antti Koivisto.

Normally the available width for an in-flow block level box is the width of the containing block's content box.
However a non-floating positioned float avoider box might be constrained by existing floats.
The idea here is that we pre-compute(estimate) the vertical position and check the current floating context for
left and right floats. These floats contrain the available width and this computed value should be used instead of the containing block's
content box's width whe calculating the used width for width: auto.

• layout/FormattingContext.cpp:

(WebCore::Layout::mapHorizontalPositionToAncestor):
(WebCore::Layout::FormattingContext::mapLeftToAncestor):
(WebCore::Layout::FormattingContext::mapRightToAncestor):
(WebCore::Layout::FormattingContext::mapPointToAncestor):
(WebCore::Layout::FormattingContext::mapCoordinateToAncestor): Deleted.

• layout/FormattingContext.h:
• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition const):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition const):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFormattingRoot const):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):

• layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::staticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::staticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):

• layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::constraints const):

• layout/layouttree/LayoutBlockContainer.cpp:

(WebCore::Layout::BlockContainer::establishesInlineFormattingContextOnly const):

• layout/layouttree/LayoutBlockContainer.h:
• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isFloatAvoider const):

• layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::establishesInlineFormattingContextOnly const):

11:33 AM Changeset in webkit [246467] by commit-queue@webkit.org

• 14 edits in trunk/Source

[GTK] Stop accessing GdkEvent fields when possible
​https://bugs.webkit.org/show_bug.cgi?id=198829

Patch by Ludovico de Nittis <​ludovico.denittis@collabora.com> on 2019-06-15
Reviewed by Michael Catanzaro.

Direct access to GdkEvent structs is no longer possible in GTK 4.

Source/WebCore:

No behaviour changes.

• platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::eventTypeForGdkKeyEvent):
(WebCore::modifiersForGdkKeyEvent):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

• platform/gtk/PlatformMouseEventGtk.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

• platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

Source/WebKit:

• Shared/gtk/WebEventFactory.cpp:

(WebKit::buttonForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

• UIProcess/API/gtk/WebKitEmojiChooser.cpp:
• UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:

(webkitScriptDialogImplKeyPressEvent):

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(ClickCounter::currentClickCountForGdkButtonEvent):
(webkitWebViewBaseKeyPressEvent):
(webkitWebViewBaseHandleMouseEvent):
(webkitWebViewBaseCrossingNotifyEvent):
(webkitWebViewBaseGetTouchPointsForEvent):
(webkitWebViewBaseTouchEvent):
(webkitWebViewBaseEvent):

• UIProcess/gtk/GestureController.cpp:

(WebKit::GestureController::handleEvent):

• UIProcess/gtk/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::filterKeyEvent):
(WebKit::InputMethodFilter::logHandleKeyboardEventForTesting):
(WebKit::InputMethodFilter::logHandleKeyboardEventWithCompositionResultsForTesting):

• UIProcess/gtk/KeyBindingTranslator.cpp:

(WebKit::KeyBindingTranslator::commandsForKeyEvent):

• UIProcess/gtk/ViewGestureControllerGtk.cpp:

(WebKit::isEventStop):
(WebKit::ViewGestureController::PendingSwipeTracker::scrollEventCanInfluenceSwipe):
(WebKit::ViewGestureController::PendingSwipeTracker::scrollEventGetScrollingDeltas):
(WebKit::ViewGestureController::SwipeProgressTracker::handleEvent):

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::treeViewButtonReleaseEventCallback):
(WebKit::WebPopupMenuProxyGtk::keyPressEventCallback):

11:20 AM Changeset in webkit [246466] by commit-queue@webkit.org

• 11 edits
  7 adds in trunk

Source/WebCore:
Add tests for prefetch redirects
​https://bugs.webkit.org/show_bug.cgi?id=197371

Patch by Rob Buis <​rbuis@igalia.com> on 2019-06-15
Reviewed by Youenn Fablet.

Test: http/wpt/prefetch/link-prefetch-main-resource-redirect.html

Allow clearing of the Purpose request header field.

• platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::clearPurpose):

• platform/network/ResourceRequestBase.h:

Source/WebKit:
Store prefetch redirects in the prefetch cache
​https://bugs.webkit.org/show_bug.cgi?id=197371

Patch by Rob Buis <​rbuis@igalia.com> on 2019-06-15
Reviewed by Youenn Fablet.

Store prefetch redirects in the prefetch cache and use them when
navigating.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::didFinishWithRedirectResponse):

• NetworkProcess/NetworkResourceLoader.h:
• NetworkProcess/cache/PrefetchCache.cpp:

(WebKit::PrefetchCache::Entry::Entry):
(WebKit::PrefetchCache::storeRedirect):

• NetworkProcess/cache/PrefetchCache.h:

LayoutTests:
Add tests for prefetch redirects
​https://bugs.webkit.org/show_bug.cgi?id=197371

Patch by Rob Buis <​rbuis@igalia.com> on 2019-06-15
Reviewed by Youenn Fablet.

Add a test to verify prefetch redirections are cached in the prefetch
cache and reused when navigating.

• http/wpt/prefetch/link-prefetch-main-resource-redirect-expected.txt: Added.
• http/wpt/prefetch/link-prefetch-main-resource-redirect.html: Added.
• http/wpt/prefetch/resources/main-resource-redirect-no-prefetch.py: Added.

(main):

• http/wpt/prefetch/resources/navigate.html: Added.
• http/wpt/prefetch/resources/prefetched-main-resource-redirect.py: Added.

(main):

• platform/mac-wk1/TestExpectations:
• platform/win/TestExpectations:

10:42 AM Changeset in webkit [246465] by sbarati@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. Temporarily mark webgpu/whlsl-oob-access.html as flaky.

• TestExpectations:

7:36 AM Changeset in webkit [246464] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][MarginCollapsing] Remove redundant checks in MarginCollapse::marginBefore/AfterCollapsesWith*
​https://bugs.webkit.org/show_bug.cgi?id=198882
<rdar://problem/51773334>

Reviewed by Antti Koivisto.

In-flow child can neither be floating nor out-of-flow positioned.

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter):

7:16 AM Changeset in webkit [246463] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][MarginCollapsing] Collapsed through margin values preserve quirk state.
​https://bugs.webkit.org/show_bug.cgi?id=198885
<rdar://problem/51773568>

Reviewed by Antti Koivisto.

The collapsed through margin becomes a quirk margin if either of the vertical(before/after) margins have quirk value.

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::computedPositiveAndNegativeMargin):

7:13 AM Changeset in webkit [246462] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC[MarginCollapsing] Anonymous boxes never collapse their margins with siblings.
​https://bugs.webkit.org/show_bug.cgi?id=198884
<rdar://problem/51773509>

Reviewed by Antti Koivisto.

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):

7:11 AM Changeset in webkit [246461] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][MarginCollapsing] Add check for computed height value in MarginCollapse::marginsCollapseThrough
​https://bugs.webkit.org/show_bug.cgi?id=198883
<rdar://problem/51773395>

Reviewed by Antti Koivisto.

"A box's own margins collapse if... ...and it has a 'height' of either 0 or 'auto"
​https://www.w3.org/TR/CSS22/box.html#collapsing-margins

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):

7:09 AM Changeset in webkit [246460] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC] Fix available width for shrink-to-fit (for out-of-flow non-replaced box)
​https://bugs.webkit.org/show_bug.cgi?id=198880
<rdar://problem/51773118>

Reviewed by Antti Koivisto.

This patch fixes the cases when the available width for the out-of-flow positioned box is not the same as the containing block's (padding)width.

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):

7:06 AM Changeset in webkit [246459] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC] Fix over-constrained logic for out-of-flow non-replaced horizontal geometry.
​https://bugs.webkit.org/show_bug.cgi?id=198879
<rdar://problem/51772995>

Reviewed by Antti Koivisto.

The over-constrained logic applies to the case when all the horizontal properties are set.

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):

7:05 AM Changeset in webkit [246458] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC] Convert both the absolutely and statically positioned out-of-flow block level boxes positions relative to the containing block's padding box
​https://bugs.webkit.org/show_bug.cgi?id=198878
<rdar://problem/51772882>

Reviewed by Antti Koivisto.

This patch ensures that while we compute the vertical/horizontal geometry for an out-of-flow block level box,
the static and the absolute positioned values are in the same coordinate system (relative to the containing block's padding box).

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
(WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):

7:03 AM Changeset in webkit [246457] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][IFC] Add support for vertical-align: top and bottom
​https://bugs.webkit.org/show_bug.cgi?id=198697
<rdar://problem/51556188>

Reviewed by Antti Koivisto.

Use the layout box's vertical alignment to adjust line baseline and height and set the run's logical top when the line is being closed.

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::isVisuallyEmpty const):
(WebCore::Layout::Line::close):
(WebCore::Layout::Line::appendInlineContainerStart):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendNonReplacedInlineBox):
(WebCore::Layout::Line::appendHardLineBreak):
(WebCore::Layout::Line::adjustBaselineAndLineHeight):
(WebCore::Layout::Line::inlineItemHeight const):
(WebCore::Layout::Line::Content::isVisuallyEmpty const): Deleted.

• layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Content::isVisuallyEmpty const):
(WebCore::Layout::Line::Content::setIsVisuallyEmpty):
(WebCore::Layout::Line::hasContent const):