Context Navigation

← Previous Period
Next Period →

Timeline

Jun 17, 2019:

9:32 PM Changeset in webkit [246532] by Matt Baker

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: remove ellipses from "Break on" context menu item title
https://bugs.webkit.org/show_bug.cgi?id=198944

Reviewed by Devin Rousso.

Update context menu title to comply with Apple HI guidelines.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Views/ContextMenuUtilities.js:

7:33 PM Changeset in webkit [246531] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit

Expose DataDetectors context generation on WKContentViewInteraction
https://bugs.webkit.org/show_bug.cgi?id=198950
<rdar://problem/51116021>

Reviewed by Andy Estes.

UIProcess/ios/WKActionSheetAssistant.h:
UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant currentPositionInformation]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView dataDetectionContextForPositionInformation:]):
(-[WKContentView dataDetectionContextForActionSheetAssistant:]):
For use by other clients, add -dataDetectionContextForPositionInformation:
and make -dataDetectionContextForActionSheetAssistant: use it.
Also, pull the code to augment the context with surrounding text out of
from WKActionSheetAssistant.

6:43 PM Changeset in webkit [246530] by sihui_liu@apple.com

12 edits in trunk

-[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
https://bugs.webkit.org/show_bug.cgi?id=198854
<rdar://problem/51386058>

Reviewed by Geoffrey Garen.

Source/WebCore:

Add option NSURLCredentialStorageRemoveSynchronizableCredentials when removing persistent credential so
credentials from same account will be removed from all devices.

Test: WKWebsiteDataStore.RemoveAllPersistentCredentials

platform/network/CredentialStorage.cpp:

(WebCore::CredentialStorage::originsWithPersistentCredentials):
(WebCore::CredentialStorage::removePersistentCredentialsWithOrigins):
(WebCore::CredentialStorage::clearPersistentCredentials):

platform/network/CredentialStorage.h:
platform/network/mac/CredentialStorageMac.mm:

(WebCore::CredentialStorage::originsWithPersistentCredentials):
(WebCore::CredentialStorage::removePersistentCredentialsWithOrigins):
(WebCore::CredentialStorage::clearPersistentCredentials):

Source/WebKit:

Clear persistent credentials in deleteWebsiteData of network process.

Also, merge originsWithPersistentCredentials and removeCredentialsWithOrigins into fetchWebsiteData and
deleteWebsiteData, and move credentials handling to WebCore.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::originsWithPersistentCredentials): Deleted.
(WebKit::NetworkProcess::removeCredentialsWithOrigins): Deleted.

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::originsWithPersistentCredentials): Deleted.
(WebKit::NetworkProcess::removeCredentialsWithOrigins): Deleted.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::computeWebProcessAccessTypeForDataRemoval):
(WebKit::WebsiteDataStore::removeData):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(TestWebKitAPI::TEST):

6:41 PM Changeset in webkit [246529] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

m_disconnectedFrame can be null in DOMWindowExtension::willDestroyGlobalObjectInCachedFrame()
https://bugs.webkit.org/show_bug.cgi?id=198943

Reviewed by Brady Eidson.

Apparently it's possible for m_disconnectedFrame to be null in this function even though this should never happen.

We've been trying to diagnose a class of issues in this area (e.g. r246187, r244971, r242797, r242677, r242676, r241848)
but at some point, we need to stop crashing for the sake of user.

Worked around the bug by adding a null pointer check here.

page/DOMWindowExtension.cpp:

(WebCore::DOMWindowExtension::willDestroyGlobalObjectInCachedFrame):

5:29 PM Changeset in webkit [246528] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Fix the build with case-sensitive includes
<rdar://problem/51828273>

UIProcess/API/Cocoa/WKContentRuleListStore.mm:

FileSystem, not Filesystem.

5:26 PM Changeset in webkit [246527] by jiewen_tan@apple.com

4 edits in trunk/Source/WebKit

Unreviewed, build fix after r246514

UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.h:
UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm:

(+[NSURL _web_canPerformAuthorizationWithURL:]):
Expose the above method as a SPI for Safari.

WebKit.xcodeproj/project.pbxproj:

5:17 PM Changeset in webkit [246526] by achristensen@apple.com

3 edits in trunk/Source/WebKit

Protect StorageManager::m_localStorageNamespaces with a Lock
https://bugs.webkit.org/show_bug.cgi?id=198939
<rdar://problem/51784225>

Reviewed by Geoff Garen.

StorageManager::LocalStorageNamespace::didDestroyStorageArea is called from StorageArea::~StorageArea which is called on the main thread.
All other access of m_localStorageNamespaces is from the non-main thread. Sometimes this causes hash table corruption, so wait for a mutex
before accessing this member variable.

NetworkProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::LocalStorageNamespace::didDestroyStorageArea):
(WebKit::StorageManager::cloneSessionStorageNamespace):
(WebKit::StorageManager::getLocalStorageOrigins):
(WebKit::StorageManager::deleteLocalStorageEntriesForOrigin):
(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):
(WebKit::StorageManager::deleteLocalStorageEntriesForOrigins):
(WebKit::StorageManager::getOrCreateLocalStorageNamespace):

NetworkProcess/WebStorage/StorageManager.h:

5:14 PM Changeset in webkit [246525] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix iOS crash when starting loads with no active DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=187360
<rdar://problem/29389084>

Reviewed by Geoff Garen.

When FrameLoader::activeDocumentLoader returns null in the ResourceLoader constructor,
on iOS we will dereference it to ask if it has a frame in an early return in init.
Let's not. If we don't have a DocumentLoader, we don't have a frame and should fail.

Crash reports indicate this crash is related to Beacon and other uses of LoaderStrategy::startPingLoad,
but attempts to make a unit test to reproduce the crash were unsuccessful.

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):

5:06 PM Changeset in webkit [246524] by rmorisset@apple.com

4 edits in trunk/Source/WebCore

[WHLSL] The name resolver does not deal with nativeFunctionDeclaration
https://bugs.webkit.org/show_bug.cgi?id=198306

Reviewed by Saam Barati.

We currently have a crash in the nameResolver when trying to use the full standard library.
What is happening is that because we don't specify anything to do to nativeFunctionDeclarations, names in their parameters
are added to the global environment. And so as soon as we have two such parameters with the same name, the name resolver fails.

Tested by adding two native functions that share a parameter name to the standard library.

Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:

(WebCore::WHLSL::NameResolver::visit):

Modules/webgpu/WHLSL/WHLSLNameResolver.h:

4:42 PM Changeset in webkit [246523] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger: adding a DOM/Event/URL breakpoint should enable breakpoints
https://bugs.webkit.org/show_bug.cgi?id=198932

Reviewed by Matt Baker.

Match the behavior of JavaScript breakpoints, which enable breakpoints globally when a new
breakpoint is set or an existing breakpoint is enabled.

This avoids the situation where setting a DOM breakpoint or a specific event listener
breakpoint appears to not "work" because breakpoints are globally disabled. There is no
"breakpoints disabled" banner in the Elements tab, so the user could be completely unaware
of this, and therefore be confused as to why these breakpoints aren't being hit.

UserInterface/Controllers/DOMManager.js:

(WI.DOMManager.prototype._updateEventBreakpoint):

UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager.prototype._updateDOMBreakpoint):
(WI.DOMDebuggerManager.prototype._updateEventBreakpoint):
(WI.DOMDebuggerManager.prototype._updateURLBreakpoint):

4:11 PM Changeset in webkit [246522] by Dewei Zhu

8 edits in trunk/Websites/perf.webkit.org

Custom analysis task configurator should allow supplying commit prefix and revision starts 'r'.
https://bugs.webkit.org/show_bug.cgi?id=198847

Reviewed by Ryosuke Niwa.

Custom analysis task configurator should not require full SHA to start an A/B test.
Custom analysis task configurator should accept svn revision starts with 'r'.

browser-tests/custom-analysis-task-configurator-tests.js: Added a unit test for this change.
public/api/commits.php: Extend this API to allow prefix matching when fethcing a single commit.
public/include/commit-log-fetcher.php: Added a function to fetch a commit with prefix.
public/v3/components/custom-analysis-task-configurator.js: Add UI support for accepting partial revision.

(CustomAnalysisTaskConfigurator.prototype._computeCommitSet):
(CustomAnalysisTaskConfigurator.prototype.async._resolveRevision):
(CustomAnalysisTaskConfigurator.prototype._buildTestabilityList):

public/v3/models/commit-log.js:

(CommitLog.async.fetchForSingleRevision): Added third argument to specify prefix matching which defaults to false.

server-tests/api-commits-tests.js: Added unit tests.
unit-tests/commit-log-tests.js: Added a unit test.

4:11 PM Changeset in webkit [246521] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Add null check in WebFrameLoaderClient::assignIdentifierToInitialRequest
https://bugs.webkit.org/show_bug.cgi?id=198926
<rdar://problem/50079713>

Patch by Alex Christensen <achristensen@webkit.org> on 2019-06-17
Reviewed by Brady Eidson.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest):
WebKitLegacy's version already checks null for the corresponding call.

4:07 PM Changeset in webkit [246520] by rmorisset@apple.com

2 edits in trunk/Source/WebCore

[WHLSL] Remove backtracking from parseAttributeBlock
https://bugs.webkit.org/show_bug.cgi?id=198934

Reviewed by Myles C. Maxfield.

No functional change intended.

Tested by running LayoutTests/webgpu/whlsl-compute.html

Modules/webgpu/WHLSL/WHLSLParser.cpp:

(WebCore::WHLSL::Parser::parseAttributeBlock):

3:27 PM Changeset in webkit [246519] by achristensen@apple.com

2 edits in trunk/Source/WebKit

Fix internal build after r246514
https://bugs.webkit.org/show_bug.cgi?id=198874

UIProcess/API/APINavigationAction.h:

A problematic reference to APINavigationActionAdditions.h was left.
Its contents had been sprinkled into the correct places, though.

3:24 PM Changeset in webkit [246518] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Sources: remove extra space above Breakpoints section when breakpoints are disabled
https://bugs.webkit.org/show_bug.cgi?id=198933

Reviewed by Matt Baker.

UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger .warning-banner):

UserInterface/Views/SourcesNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.sources > .content > .warning-banner):

3:18 PM Changeset in webkit [246517] by Adrian Perez de Castro

4 edits
2 deletes in trunk/Tools

[Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
https://bugs.webkit.org/show_bug.cgi?id=198831

Reviewed by Žan Doberšek.

flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
wpe/jhbuild.modules: Ditto.
wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.

3:00 PM Changeset in webkit [246516] by Justin Michaud

4 edits in trunk

Validate that table element type is funcref if using an element section
https://bugs.webkit.org/show_bug.cgi?id=198910

Reviewed by Yusuke Suzuki.

JSTests:

wasm/references/anyref_table.js:

Source/JavaScriptCore:

Add missing validation when attempting to add an element section to an anyref table.

wasm/WasmSectionParser.cpp:

(JSC::Wasm::SectionParser::parseElement):

2:44 PM Changeset in webkit [246515] by sbarati@apple.com

10 edits
2 adds in trunk

[WHLSL] Make .length work
https://bugs.webkit.org/show_bug.cgi?id=198890

Reviewed by Myles Maxfield.

Source/WebCore:

This patch makes accessing .length on buffers work. To make this work as
expected, I've fixed a handful of small bugs:

The checker was not calling resolveByInstantiation for getters. This patch modifies the checker to do that, so we can now resolve a getter to "operator.length". I also refactored the checker to have a helper method that both does overload resolution and resolveByInstantiation to make it difficult to forget to call resolveByInstantiation.
The property resolver had a bug where it would return a non-null value in anderCallArgument for array references even when there was no ander and no thread ander function. This patch makes it now return null if there is neither an ander nor a thread ander.
The metal codegen incorrectly unpacked the length of buffers. It swapped the bottom four bytes and the top four bytes of the size_t value. This patch corrects that. This was also a cause of flakiness in various tests since we ended up with a length much larger than expected, leading to bounds checks always passing in our tests.
This patch also fixes our tests to specify the output buffer length properly for various programs.

Test: webgpu/whlsl-buffer-length.html

Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp:

(WebCore::WHLSL::Metal::EntryPointScaffolding::unpackResourcesAndNamedBuiltIns):

Modules/webgpu/WHLSL/WHLSLChecker.cpp:

(WebCore::WHLSL::resolveFunction):
(WebCore::WHLSL::Checker::finishVisiting):
(WebCore::WHLSL::Checker::visit):

Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:

(WebCore::WHLSL::anderCallArgument):

LayoutTests:

TestExpectations:
webgpu/whlsl-buffer-length-expected.txt: Added.
webgpu/whlsl-buffer-length.html: Added.
webgpu/whlsl-buffer-vertex.html:
webgpu/whlsl-compute.html:
webgpu/whlsl-null-dereference.html:
webgpu/whlsl-oob-access.html:

1:40 PM Changeset in webkit [246514] by jiewen_tan@apple.com

21 edits
10 copies
1 move
10 adds in trunk

Move SOAuthorization from WebKitAdditions to WebKit
https://bugs.webkit.org/show_bug.cgi?id=198874
<rdar://problem/47573431>

Reviewed by Brent Fulgham.

Source/WebCore/PAL:

This patch moves AppSSOSoftLink from WebKitAdditions to WebKit, and introduces
AuthKitSPI.h.

PAL.xcodeproj/project.pbxproj:
pal/cocoa/AppSSOSoftLink.h: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm.
pal/cocoa/AppSSOSoftLink.mm: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm.
pal/spi/cf/CFNetworkSPI.h:
pal/spi/cocoa/AuthKitSPI.h: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm.

Source/WebKit:

This patch basically moves everything from existing WebKitAdditions to WebKit.
It also replaces the LoadOptimizer nonsense with the actual SOAuthorization API.

Configurations/WebKit.xcconfig:
NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializePluginProcess):

SourcesCocoa.txt:
UIProcess/API/APINavigationAction.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::trySOAuthorization):
(WebKit::tryInterceptNavigation):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::tryOptimizingLoad): Deleted.

UIProcess/Cocoa/SOAuthorization/NavigationSOAuthorizationSession.h: Added.

(WebKit::NavigationSOAuthorizationSession::callback):

UIProcess/Cocoa/SOAuthorization/NavigationSOAuthorizationSession.mm: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm.

(WebKit::NavigationSOAuthorizationSession::NavigationSOAuthorizationSession):
(WebKit::NavigationSOAuthorizationSession::~NavigationSOAuthorizationSession):
(WebKit::NavigationSOAuthorizationSession::shouldStartInternal):
(WebKit::NavigationSOAuthorizationSession::webViewDidMoveToWindow):

UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.h: Added.
UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.mm: Added.

(-[WKSOSecretDelegate initWithSession:]):
(-[WKSOSecretDelegate webViewDidClose:]):
(-[WKSOSecretDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[WKSOSecretDelegate webView:didFinishNavigation:]):
(WebKit::PopUpSOAuthorizationSession::PopUpSOAuthorizationSession):
(WebKit::PopUpSOAuthorizationSession::~PopUpSOAuthorizationSession):
(WebKit::PopUpSOAuthorizationSession::shouldStartInternal):
(WebKit::PopUpSOAuthorizationSession::fallBackToWebPathInternal):
(WebKit::PopUpSOAuthorizationSession::abortInternal):
(WebKit::PopUpSOAuthorizationSession::completeInternal):
(WebKit::PopUpSOAuthorizationSession::close):
(WebKit::PopUpSOAuthorizationSession::initSecretWebView):

UIProcess/Cocoa/SOAuthorization/RedirectSOAuthorizationSession.h: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm.
UIProcess/Cocoa/SOAuthorization/RedirectSOAuthorizationSession.mm: Added.

(WebKit::RedirectSOAuthorizationSession::RedirectSOAuthorizationSession):
(WebKit::RedirectSOAuthorizationSession::fallBackToWebPathInternal):
(WebKit::RedirectSOAuthorizationSession::abortInternal):
(WebKit::RedirectSOAuthorizationSession::completeInternal):
(WebKit::RedirectSOAuthorizationSession::beforeStart):

UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.h: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm.
UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.mm: Added.

(WebKit::SOAuthorizationCoordinator::SOAuthorizationCoordinator):
(WebKit::SOAuthorizationCoordinator::canAuthorize const):
(WebKit::SOAuthorizationCoordinator::tryAuthorize):

UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.h: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm.
UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm.

(+[NSURL _web_canPerformAuthorizationWithURL:]):

UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.h: Added.

(WebKit::SOAuthorizationSession::page const):
(WebKit::SOAuthorizationSession::state const):
(WebKit::SOAuthorizationSession::setState):
(WebKit::SOAuthorizationSession::navigationAction):

UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm: Added.

(WebKit::SOAuthorizationSession::SOAuthorizationSession):
(WebKit::SOAuthorizationSession::~SOAuthorizationSession):
(WebKit::SOAuthorizationSession::releaseNavigationAction):
(WebKit::SOAuthorizationSession::becomeCompleted):
(WebKit::SOAuthorizationSession::shouldStart):
(WebKit::SOAuthorizationSession::start):
(WebKit::SOAuthorizationSession::fallBackToWebPath):
(WebKit::SOAuthorizationSession::abort):
(WebKit::SOAuthorizationSession::complete):
(WebKit::SOAuthorizationSession::presentViewController):
(WebKit::SOAuthorizationSession::dismissViewController):

UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm.
UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm: Added.

(WebKit::SubFrameSOAuthorizationSession::SubFrameSOAuthorizationSession):
(WebKit::SubFrameSOAuthorizationSession::fallBackToWebPathInternal):
(WebKit::SubFrameSOAuthorizationSession::abortInternal):
(WebKit::SubFrameSOAuthorizationSession::completeInternal):
(WebKit::SubFrameSOAuthorizationSession::beforeStart):
(WebKit::SubFrameSOAuthorizationSession::loadDataToFrame):
(WebKit::SubFrameSOAuthorizationSession::postDidCancelMessageToParent):

UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.h: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm.
UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm: Added.

(-[WKSOAuthorizationDelegate authorization:presentViewController:withCompletion:]):
(-[WKSOAuthorizationDelegate authorizationDidNotHandle:]):
(-[WKSOAuthorizationDelegate authorizationDidCancel:]):
(-[WKSOAuthorizationDelegate authorizationDidComplete:]):
(-[WKSOAuthorizationDelegate authorization:didCompleteWithHTTPAuthorizationHeaders:]):
(-[WKSOAuthorizationDelegate authorization:didCompleteWithHTTPResponse:httpBody:]):
(-[WKSOAuthorizationDelegate authorization:didCompleteWithError:]):
(-[WKSOAuthorizationDelegate setSession:]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::trySOAuthorization):
(WebKit::WebPageProxy::createNewPage):
(WebKit::tryOptimizingLoad): Deleted.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setShouldSuppressSOAuthorizationInAllNavigationPolicyDecision):
(WebKit::WebPageProxy::setShouldSuppressSOAuthorizationInNextNavigationPolicyDecision):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::WebsiteDataStore):

UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::soAuthorizationCoordinator):

WebKit.xcodeproj/project.pbxproj:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeProcess):

Source/WTF:

wtf/Platform.h:

Adds a feature flag to detect AppSSO framework.

Tools:

This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.

TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.

(-[TestSOAuthorizationNavigationDelegate init]):
(-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
(-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(-[TestSOAuthorizationViewController viewDidAppear]):
(-[TestSOAuthorizationViewController viewDidDisappear]):
(overrideCanPerformAuthorizationWithURL):
(overrideSetDelegate):
(overrideBeginAuthorizationWithURL):
(overrideCancelAuthorization):
(overrideAddObserverForName):
(overrideIsURLFromAppleOwnedDomain):
(resetState):
(configureSOAuthorizationWebView):
(generateHtml):
(checkAuthorizationOptions):
(TestWebKitAPI::TEST):

1:30 PM Changeset in webkit [246513] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit

Fix the build.

UIProcess/Gamepad/ios/UIGamepadProviderIOS.mm:

(WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput):

UIProcess/_WKTouchEventGenerator.mm:

(-[_WKTouchEventGenerator _sendHIDEvent:]):
(-[_WKTouchEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):

1:23 PM Changeset in webkit [246512] by Ryan Haddad

20 edits
2 deletes in trunk/Source

Unreviewed, rolling out r246501.

Breaks Apple internal builds.

Reverted changeset:

"Support using ANGLE as the backend for the WebGL
implementation"
https://bugs.webkit.org/show_bug.cgi?id=197755
https://trac.webkit.org/changeset/246501

1:14 PM Changeset in webkit [246511] by Shawn Roberts

2 edits in trunk/LayoutTests

scrollingcoordinator/ios/sync-layer-positions-after-scroll.html is a flaky failure on iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=172001

Unreviewed test gardening.

platform/ios-simulator-wk2/TestExpectations:

12:32 PM Changeset in webkit [246510] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Settings: split the General panel into sub panels so it's less crowded
https://bugs.webkit.org/show_bug.cgi?id=198803

Reviewed by Timothy Hatcher.

UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype.initialLayout):
(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
Many of the settings in General only affect a specific part of Web Inspector, and therefore
aren't really "general".

(WI.SettingsTabContentView.prototype._createElementsSettingsView): Added.

Element Selection
CSS Changes

(WI.SettingsTabContentView.prototype._createSourcesSettingsView): Added.

Debugger
Source Maps

(WI.SettingsTabContentView.prototype._createConsoleSettingsView): Added.

Traces (renamed from "Console")
WebRTC Logging
Media Logging
MSE Logging

Localizations/en.lproj/localizedStrings.js:

12:30 PM Changeset in webkit [246509] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Sources: the Inspector Style Sheet is missing when grouped by path
https://bugs.webkit.org/show_bug.cgi?id=198860

Reviewed by Timothy Hatcher.

UserInterface/Controllers/CSSManager.js:

(WI.CSSManager.prototype.get styleSheets):
(WI.CSSManager.prototype.inspectorStyleSheetsForFrame):
(WI.CSSManager.prototype.preferredInspectorStyleSheetForFrame):
(WI.CSSManager.prototype._inspectorStyleSheetsForFrame): Deleted.
Expose a way to fetch all inspector stylesheets for a given frame.
Make sure to associate inspector stylesheets with their frame.

UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype._compareTreeElements):
(WI.SourcesNavigationSidebarPanel.prototype._addResourcesRecursivelyForFrame):
(WI.SourcesNavigationSidebarPanel.prototype._handleCSSStyleSheetAdded):
Add paths for inspector stylesheet creation/fetching when grouping by path.
Sort inspector stylesheets as the first item of an origin/frame when grouping by path.

12:29 PM Changeset in webkit [246508] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Go To Line dialog is white when in Dark Mode
https://bugs.webkit.org/show_bug.cgi?id=198596

Patch by Jamal Nasser <jamaln@mail.com> on 2019-06-17
Reviewed by Timothy Hatcher.

UserInterface/Views/GoToLineDialog.css:

(@media (prefers-color-scheme: dark)):
(.go-to-line-dialog):
(.go-to-line-dialog > div > input):
(.go-to-line-dialog > div > input::placeholder):
(.go-to-line-dialog > div::before):

11:54 AM Changeset in webkit [246507] by Tadeu Zagallo

2 edits in trunk/Source/JavaScriptCore

Concurrent GC should check the conn before starting a new collection cycle
https://bugs.webkit.org/show_bug.cgi?id=198913
<rdar://problem/49515149>

Reviewed by Filip Pizlo.

Heap::requestCollection tries to steal the conn as an optimization to avoid waking up the collector
thread if it's idle. We determine if the collector is idle by ensuring that there are no pending collections
and that the current GC phase is NotRunning. However, that's not safe immediately after the concurrent
GC has finished processing the last pending request. The collector thread will runEndPhase and immediately
start runNotRunningPhase, without checking if it still has the conn. If the mutator has stolen the conn in
the mean time, this will lead to both threads collecting concurrently, and eventually we'll crash in checkConn,
since the collector is running but doesn't have the conn anymore.

To solve this, we check if we still have the conn after holding the lock in runNotRunningPhase, in case the mutator
has stolen the conn. Ideally, we wouldn't let the mutator steal the conn in the first place, but that doesn't seem
trivial to determine.

heap/Heap.cpp:

(JSC::Heap::runNotRunningPhase):

11:53 AM Changeset in webkit [246506] by mitz@apple.com

3 edits in trunk/Source/WebKit

REGRESSION (r242686): Paths in XPC services’ LC_DYLD_ENVIRONMENT are incorrect in built products directory
https://bugs.webkit.org/show_bug.cgi?id=198904

Reviewed by Alex Christensen.

After r242686, in local builds, the XPC service executables run from their location at the
top of the built products directory, rather than inside the framework.

Configurations/BaseXPCService.xcconfig: Updated the load commands that set DYLD_FRAMEWORK_PATH and DYLD_LIBRARY_PATH for the new location in the built products directory. Also removed WK_XPC_SERVICE_INSERT_LIBRARIES_DIR that had been unused.

WebKit.xcodeproj/project.pbxproj: Made the creation of symbolic links inside the framework’s XPCServices directory predicated on whether this is an install build, rather than on the build configuration, for consistency with the condition used in the .xcconfig.

11:49 AM Changeset in webkit [246505] by ysuzuki@apple.com

12 edits
2 adds in trunk

[JSC] Introduce DisposableCallSiteIndex to enforce type-safety
https://bugs.webkit.org/show_bug.cgi?id=197378

Reviewed by Saam Barati.

JSTests:

stress/disposable-call-site-index-with-call-and-this.js: Added.

(foo):
(bar):

stress/disposable-call-site-index.js: Added.

(foo):
(bar):

Source/JavaScriptCore:

Some of CallSiteIndex are disposable. This is because some of CallSiteIndex are allocated and freed at runtime (not DFG/FTL compile time).
The example is CallSiteIndex for exception handler in GCAwareJITStubRoutineWithExceptionHandler. If we do not allocate and free CallSiteIndex,
we will create a new CallSiteIndex continuously and leak memory.

The other CallSiteIndex are not simply disposable because the ownership model is not unique one. They can be shared between multiple clients.
But not disposing them is OK because they are static one: they are allocated when compiling DFG/FTL, and we do not allocate such CallSiteIndex
at runtime.

To make this difference explicit and avoid disposing non-disposable CallSiteIndex accidentally, we introduce DisposableCallSiteIndex type, and
enforce type-safety to some degree.

We also correctly update the DisposableCallSiteIndex => CodeOrigin table when we are reusing the previously used DisposableCallSiteIndex.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
(JSC::CodeBlock::removeExceptionHandlerForCallSite):

bytecode/CodeBlock.h:
bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::callSiteIndexForExceptionHandling):
(JSC::PolymorphicAccess::regenerate):

bytecode/PolymorphicAccess.h:

(JSC::AccessGenerationState::callSiteIndexForExceptionHandling): Deleted.

dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::addUniqueCallSiteIndex):
(JSC::DFG::CommonData::addDisposableCallSiteIndex):
(JSC::DFG::CommonData::removeDisposableCallSiteIndex):
(JSC::DFG::CommonData::removeCallSiteIndex): Deleted.

dfg/DFGCommonData.h:
interpreter/CallFrame.h:

(JSC::DisposableCallSiteIndex::DisposableCallSiteIndex):
(JSC::DisposableCallSiteIndex::fromCallSiteIndex):

jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutineWithExceptionHandler::GCAwareJITStubRoutineWithExceptionHandler):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::observeZeroRefCount):
(JSC::createJITStubRoutine):

jit/GCAwareJITStubRoutine.h:
jit/JITInlineCacheGenerator.h:

11:44 AM Changeset in webkit [246504] by Justin Michaud

28 edits
1 add in trunk

[WASM-References] Add support for Funcref in parameters and return types
https://bugs.webkit.org/show_bug.cgi?id=198157

Reviewed by Yusuke Suzuki.

JSTests:

wasm/Builder.js:

(export.default.Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):

wasm/references/anyref_globals.js:
wasm/references/func_ref.js: Added.

(fullGC.gc.makeExportedFunction):
(makeExportedIdent):
(makeAnyfuncIdent):
(fun):
(assert.eq.instance.exports.fix.fun):
(assert.eq.instance.exports.fix):
(string_appeared_here.End.End.Function.End.Code.End.WebAssembly.imp.ref):
(string_appeared_here.End.End.Function.End.Code.End.WebAssembly):
(GetLocal.0.I32Const.0.TableSet.End.End.WebAssembly.fun):
(GetLocal.0.I32Const.0.TableSet.End.End.WebAssembly.assert.throws):
(GetLocal.0.I32Const.0.TableSet.End.End.WebAssembly):
(assert.throws):
(assert.throws.doTest):
(let.importedFun.of):
(makeAnyfuncIdent.fun):

wasm/references/validation.js:

(assert.throws):

wasm/wasm.json:

Source/JavaScriptCore:

Add support for funcref in parameters, globals, and in table.get/set. When converting a JSValue to
a funcref (nee anyfunc), we first make sure it is an exported wasm function or null.

We also add support for Ref.func. Anywhere a Ref.func is used, (statically) we construct a JS wrapper
for it so that we never need to construct JSValues when handling references. This should make threads
easier to implement.

Finally, we add some missing bounds checks for table.get/set.

wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::tmpForType):
(JSC::Wasm::AirIRGenerator::moveOpForValueType):
(JSC::Wasm::AirIRGenerator::AirIRGenerator):
(JSC::Wasm::AirIRGenerator::addLocal):
(JSC::Wasm::AirIRGenerator::addConstant):
(JSC::Wasm::AirIRGenerator::addRefFunc):
(JSC::Wasm::AirIRGenerator::addTableSet):
(JSC::Wasm::AirIRGenerator::setGlobal):
(JSC::Wasm::AirIRGenerator::addReturn):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addLocal):
(JSC::Wasm::B3IRGenerator::addTableSet):
(JSC::Wasm::B3IRGenerator::addRefFunc):
(JSC::Wasm::B3IRGenerator::setGlobal):

wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::compileFunctions):

wasm/WasmCallingConvention.h:

(JSC::Wasm::CallingConventionAir::marshallArgument const):
(JSC::Wasm::CallingConventionAir::setupCall const):

wasm/WasmExceptionType.h:
wasm/WasmFormat.h:

(JSC::Wasm::isValueType):
(JSC::Wasm::isSubtype):

wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

wasm/WasmInstance.cpp:

(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::getFunctionWrapper const):
(JSC::Wasm::Instance::setFunctionWrapper):

wasm/WasmInstance.h:
wasm/WasmModuleInformation.h:

(JSC::Wasm::ModuleInformation::referencedFunctions const):
(JSC::Wasm::ModuleInformation::addReferencedFunction const):

wasm/WasmSectionParser.cpp:

(JSC::Wasm::SectionParser::parseGlobal):
(JSC::Wasm::SectionParser::parseInitExpr):

wasm/WasmValidate.cpp:

(JSC::Wasm::Validate::addTableGet):
(JSC::Wasm::Validate::addTableSet):
(JSC::Wasm::Validate::addRefIsNull):
(JSC::Wasm::Validate::addRefFunc):
(JSC::Wasm::Validate::setLocal):
(JSC::Wasm::Validate::addCall):
(JSC::Wasm::Validate::addCallIndirect):

wasm/js/JSToWasm.cpp:

(JSC::Wasm::createJSToWasmWrapper):

wasm/js/JSWebAssemblyHelpers.h:

(JSC::isWebAssemblyHostFunction):

wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::visitChildren):

wasm/js/JSWebAssemblyRuntimeError.cpp:

(JSC::createJSWebAssemblyRuntimeError):

wasm/js/JSWebAssemblyRuntimeError.h:
wasm/js/WasmToJS.cpp:

(JSC::Wasm::handleBadI64Use):
(JSC::Wasm::wasmToJS):
(JSC::Wasm::emitWasmToJSException):

wasm/js/WasmToJS.h:
wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):

wasm/wasm.json:

11:29 AM Changeset in webkit [246503] by Simon Fraser

1 edit
1 add in trunk/LayoutTests

Add missing test result after r246471. EWS didn't show any failure when it was missing.

compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.

11:28 AM Changeset in webkit [246502] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Sources: searching doesn't use the case sensitive or regex global settings
https://bugs.webkit.org/show_bug.cgi?id=198897

Reviewed by Joseph Pecoraro.

UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.customPerformSearch):

11:25 AM Changeset in webkit [246501] by dino@apple.com

20 edits
2 copies
5 adds in trunk/Source

Support using ANGLE as the backend for the WebGL implementation
https://bugs.webkit.org/show_bug.cgi?id=197755

Patch by Kenneth Russell <kbr@chromium.org> on 2019-06-17
Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

Add a build step which processes ANGLE's copied public headers so they
can all be referred to under the <ANGLE/xyz.h> prefix. This avoids
touching ANGLE's headers and allows WebCore to include them with no
additional include path modifications.

ANGLE.xcodeproj/project.pbxproj:
adjust-angle-include-paths.sh: Added.

Source/WebCore:

Add new files supplying an ANGLE version of GraphicsContext3D and
Extensions3D, conditionalized under USE_ANGLE. Update Xcode project to
build these files. This option compiles and links successfully.

FIXMEs remain in several common files which will be addressed in
subsequent patches.

This work will be tested with the preexisting WebGL conformance
suite.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/GraphicsContext3D.h:
platform/graphics/GraphicsContext3DManager.cpp:

(WebCore::GraphicsContext3DManager::updateAllContexts):
(WebCore::GraphicsContext3DManager::updateHighPerformanceState):
(WebCore::GraphicsContext3DManager::disableHighPerformanceGPUTimerFired):

platform/graphics/angle/Extensions3DANGLE.cpp: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp.

(WebCore::Extensions3DANGLE::Extensions3DANGLE):
(WebCore::Extensions3DANGLE::supports):
(WebCore::Extensions3DANGLE::ensureEnabled):
(WebCore::Extensions3DANGLE::isEnabled):
(WebCore::Extensions3DANGLE::getGraphicsResetStatusARB):
(WebCore::Extensions3DANGLE::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DANGLE::initializeAvailableExtensions):
(WebCore::Extensions3DANGLE::readnPixelsEXT):
(WebCore::Extensions3DANGLE::getnUniformfvEXT):
(WebCore::Extensions3DANGLE::getnUniformivEXT):
(WebCore::Extensions3DANGLE::blitFramebuffer):
(WebCore::Extensions3DANGLE::renderbufferStorageMultisample):
(WebCore::Extensions3DANGLE::createVertexArrayOES):
(WebCore::Extensions3DANGLE::deleteVertexArrayOES):
(WebCore::Extensions3DANGLE::isVertexArrayOES):
(WebCore::Extensions3DANGLE::bindVertexArrayOES):
(WebCore::Extensions3DANGLE::insertEventMarkerEXT):
(WebCore::Extensions3DANGLE::pushGroupMarkerEXT):
(WebCore::Extensions3DANGLE::popGroupMarkerEXT):
(WebCore::Extensions3DANGLE::supportsExtension):
(WebCore::Extensions3DANGLE::drawBuffersEXT):
(WebCore::Extensions3DANGLE::drawArraysInstanced):
(WebCore::Extensions3DANGLE::drawElementsInstanced):
(WebCore::Extensions3DANGLE::vertexAttribDivisor):
(WebCore::Extensions3DANGLE::getExtensions):

platform/graphics/angle/Extensions3DANGLE.h: Added.
platform/graphics/angle/GraphicsContext3DANGLE.cpp: Copied from Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp.

(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::wipeAlphaChannelFromPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::attachDepthAndStencilBufferIfNeeded):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::setCurrentNameHashMapForShader):
(WebCore::nameHashForShader):
(WebCore::GraphicsContext3D::validateDepthStencil):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::checkVaryingsPacking const):
(WebCore::GraphicsContext3D::precisionsMatch const):
(WebCore::GraphicsContext3D::getInternalFramebufferSize const):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::mapBufferRange):
(WebCore::GraphicsContext3D::unmapBuffer):
(WebCore::GraphicsContext3D::copyBufferSubData):
(WebCore::GraphicsContext3D::getInternalformativ):
(WebCore::GraphicsContext3D::renderbufferStorageMultisample):
(WebCore::GraphicsContext3D::texStorage2D):
(WebCore::GraphicsContext3D::texStorage3D):
(WebCore::GraphicsContext3D::getActiveUniforms):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::compileShaderDirect):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttribImpl):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniformImpl):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::generateHashedName):
(WebCore::GraphicsContext3D::mappedSymbolInShaderSourceMap):
(WebCore::GraphicsContext3D::mappedSymbolName):
(WebCore::GraphicsContext3D::originalSymbolInShaderSourceMap):
(WebCore::GraphicsContext3D::originalSymbolName):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getAttribLocationDirect):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::moveErrorsToSyntheticErrorList):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::createVertexArray):
(WebCore::GraphicsContext3D::deleteVertexArray):
(WebCore::GraphicsContext3D::isVertexArray):
(WebCore::GraphicsContext3D::bindVertexArray):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getInteger64v):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getNonBuiltInActiveSymbolCount):
(WebCore::GraphicsContext3D::getUnmangledInfoLog):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::layerComposited const):
(WebCore::GraphicsContext3D::forceContextLost):
(WebCore::GraphicsContext3D::recycleContext):
(WebCore::GraphicsContext3D::dispatchContextChangedNotification):
(WebCore::GraphicsContext3D::texImage2DDirect):
(WebCore::GraphicsContext3D::drawArraysInstanced):
(WebCore::GraphicsContext3D::drawElementsInstanced):
(WebCore::GraphicsContext3D::vertexAttribDivisor):

platform/graphics/angle/TemporaryANGLESetting.cpp: Added.

(WebCore::TemporaryANGLESetting::TemporaryANGLESetting):
(WebCore::TemporaryANGLESetting::~TemporaryANGLESetting):

platform/graphics/angle/TemporaryANGLESetting.h: Added.
platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::checkGPUStatus):
(WebCore::GraphicsContext3D::screenDidChange):

platform/graphics/cocoa/WebGLLayer.h:
platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer display]):

platform/graphics/cv/TextureCacheCV.mm:

(WebCore::TextureCacheCV::create):
(WebCore::TextureCacheCV::textureFromImage):

platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::enumToStringMap):
(WebCore::VideoTextureCopierCV::initializeContextObjects):
(WebCore::VideoTextureCopierCV::initializeUVContextObjects):
(WebCore::VideoTextureCopierCV::copyImageToPlatformTexture):
(WebCore::VideoTextureCopierCV::copyVideoTextureToPlatformTexture):

platform/graphics/opengl/Extensions3DOpenGL.cpp:
platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

Source/WTF:

Add a USE_ANGLE definition to wtf/Platform.h (currently disabled)
which, when enabled, uses ANGLE instead of the OpenGL or OpenGL ES
backend.

wtf/Platform.h:

10:41 AM Changeset in webkit [246500] by Brent Fulgham

9 edits in trunk

Ensure ITP state is relayed to Network Process on restart
https://bugs.webkit.org/show_bug.cgi?id=198797
<rdar://problem/51646944>

Reviewed by Youenn Fablet.

Source/WebKit:

Now that the ITP state is maintained in the Network Process, we have to make sure that we update
that process with current ITP state if the Network Process crashes and is relaunched. This wasn't a
problem in earlier releases because we tracked all ITP state in the UIProcess.

This patch does the following:

Add a new method to WKWebsiteDataStore to allow us to trigger statistics processing, which has the side effect of syncing ITP state persistently so that it will be available after bouncing the process.
Adds a new test that sets a tracking domain, bounces the process, and confirms the state is still consistent.

Tested by TestWebKitAPI.

NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:

(WebKit::ResourceLoadStatisticsStore::processStatisticsAndDataRecords):

UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _clearPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _processStatisticsAndDataRecords:]):

UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::setResourceLoadStatisticsEnabled):

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(cleanupITPDatabase): Added.
(TEST:EnableDisableITP): Update to use cleanup method.
(TEST:NetworkProcessRestart): Added.

10:28 AM Changeset in webkit [246499] by Ross Kirsling

517 edits
2 copies
40 moves
146 adds
40 deletes in trunk/JSTests

Update test262 tests (2019.06.13)
https://bugs.webkit.org/show_bug.cgi?id=198821

Reviewed by Konstantin Tokarev.

test262/expectations.yaml:
test262/harness/:
test262/latest-changes-summary.txt:
test262/test/:
test262/test262-Revision.txt:

9:31 AM Changeset in webkit [246498] by aakash_jain@apple.com

2 edits in trunk/Tools

New EWS can't process patches larger than 640kb
https://bugs.webkit.org/show_bug.cgi?id=198851

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.

8:33 AM Changeset in webkit [246497] by Jonathan Bedard

8 edits
6 adds in trunk/Tools

webkitpy: Add macOS Catalina, iOS 13
https://bugs.webkit.org/show_bug.cgi?id=198492

Reviewed by Alexey Proskuryakov.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
BuildSlaveSupport/ews-build/steps.py:
Scripts/webkitpy/common/version_name_map.py:
Scripts/webkitpy/common/version_name_map_unittest.py:
Scripts/webkitpy/layout_tests/models/test_expectations.py:
TestResultServer/static-dashboards/flakiness_dashboard.js:

8:01 AM Changeset in webkit [246496] by commit-queue@webkit.org

14 edits in trunk/Source

[GTK] Stop accessing GdkEvent fields when possible
https://bugs.webkit.org/show_bug.cgi?id=198829

Patch by Ludovico de Nittis <ludovico.denittis@collabora.com> on 2019-06-17
Reviewed by Michael Catanzaro.

Direct access to GdkEvent structs is no longer possible in GTK 4.

Source/WebCore:

No behaviour changes.

platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::eventTypeForGdkKeyEvent):
(WebCore::modifiersForGdkKeyEvent):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

platform/gtk/PlatformMouseEventGtk.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

Source/WebKit:

Shared/gtk/WebEventFactory.cpp:

(WebKit::buttonForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

UIProcess/API/gtk/WebKitEmojiChooser.cpp:
UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:

(webkitScriptDialogImplKeyPressEvent):

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(ClickCounter::currentClickCountForGdkButtonEvent):
(webkitWebViewBaseKeyPressEvent):
(webkitWebViewBaseHandleMouseEvent):
(webkitWebViewBaseCrossingNotifyEvent):
(webkitWebViewBaseGetTouchPointsForEvent):
(webkitWebViewBaseTouchEvent):
(webkitWebViewBaseEvent):

UIProcess/gtk/GestureController.cpp:

(WebKit::GestureController::handleEvent):

UIProcess/gtk/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::filterKeyEvent):
(WebKit::InputMethodFilter::logHandleKeyboardEventForTesting):
(WebKit::InputMethodFilter::logHandleKeyboardEventWithCompositionResultsForTesting):

UIProcess/gtk/KeyBindingTranslator.cpp:

(WebKit::KeyBindingTranslator::commandsForKeyEvent):

UIProcess/gtk/ViewGestureControllerGtk.cpp:

(WebKit::isEventStop):
(WebKit::ViewGestureController::PendingSwipeTracker::scrollEventCanInfluenceSwipe):
(WebKit::ViewGestureController::PendingSwipeTracker::scrollEventGetScrollingDeltas):
(WebKit::ViewGestureController::SwipeProgressTracker::handleEvent):

UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::treeViewButtonReleaseEventCallback):
(WebKit::WebPopupMenuProxyGtk::keyPressEventCallback):

2:16 AM Changeset in webkit [246495] by Carlos Garcia Campos

4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.25.2 release

Source/cmake/OptionsGTK.cmake: Bump version numbers

Source/WebKit:

gtk/NEWS: Add release notes for 2.25.2.

1:52 AM Changeset in webkit [246494] by Carlos Garcia Campos

14 edits in trunk/Source

Unreviewed, rolling out r246467.

It broke scrolling with mouse wheel

Reverted changeset:

"[GTK] Stop accessing GdkEvent fields when possible"
https://bugs.webkit.org/show_bug.cgi?id=198829
https://trac.webkit.org/changeset/246467

1:33 AM Changeset in webkit [246493] by Carlos Garcia Campos

4 edits
2 deletes in trunk

Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1

Source/cmake/OptionsGTK.cmake:

Tools:

gtk/jhbuild.modules:
gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.

Jun 16, 2019:

10:04 PM Changeset in webkit [246492] by Alan Bujtas

2 edits in trunk/Tools

[LFC] Expand tests coverage (325 new tests -> 1198).

LayoutReloaded/misc/LFC-passing-tests.txt:

6:59 PM Changeset in webkit [246491] by Darin Adler

10 edits in trunk

Convert some uses of fixed width and fixed precision floating point formatting to use shortest instead
https://bugs.webkit.org/show_bug.cgi?id=198896

Reviewed by Sam Weinig.

Source/WebCore:

Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::loggingString const): Removed unneeded use of
FormattedNumber::fixedWidth to override the default shortest-form formatting.

page/History.cpp:

(WebCore::History::stateObjectAdded): Ditto.

page/PrintContext.cpp:

(WebCore::PrintContext::pageProperty): Use String::number instead of
String::numberToStringFixedPrecision. Also removed some uses of
FormattedNumber::fixedPrecision.

platform/graphics/FloatPolygon.cpp:

(WebCore::FloatPolygonEdge::debugString const): Ditto.

LayoutTests:

fast/loader/stateobjects/pushstate-frequency-expected.txt:
fast/loader/stateobjects/pushstate-frequency-iframe-expected.txt:
fast/loader/stateobjects/replacestate-frequency-expected.txt:
fast/loader/stateobjects/replacestate-frequency-iframe-expected.txt:

Updated to expect cleaner output without ".000000".

6:48 PM Changeset in webkit [246490] by Darin Adler

1248 edits
6 moves
3 adds
3 deletes in trunk

Rename AtomicString to AtomString
https://bugs.webkit.org/show_bug.cgi?id=195276

Reviewed by Michael Catanzaro.

many files: Let do-webcore-rename do the renaming.

Source/WTF:

wtf/text/AtomString.h: After renaming, added AtomicString as a synonym for

now; helps smooth things over with a tiny bit of Apple internal software so
we don't have to do this all at once. Can remove it soon.

Tools:

Scripts/do-webcore-rename: Updated with a list of all the identifiers

that mention "atomic string" and changed them to instead say "atom string".

6:38 PM Changeset in webkit [246489] by eric.carlson@apple.com

5 edits in trunk/Source

[MediaStream] Avoid roundoff error when setting AVCapture min/max frame rate
https://bugs.webkit.org/show_bug.cgi?id=198875
<rdar://problem/51768374>

Reviewed by Youenn Fablet.

Source/WebCore:

platform/graphics/MediaPlayer.h:

(WTF::LogArgument<MediaTime>::toString): Deleted, moved to MediaTime.h.
(WTF::LogArgument<MediaTimeRange>::toString): Deleted, moved to MediaTime.h.

platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setSessionSizeAndFrameRate): Avoid roundoff error.

Source/WTF:

wtf/MediaTime.h:

(WTF::LogArgument<MediaTime>::toString):
(WTF::LogArgument<MediaTimeRange>::toString):

5:33 PM Changeset in webkit [246488] by Simon Fraser

20 edits in trunk/Source

Implement ScrollableArea::scrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=198895

Reviewed by Antti Koivisto.

Source/WebCore:

Remove from ScrollableArea the following:

virtual int scrollSize(ScrollbarOrientation) const = 0;
virtual int scrollOffset(ScrollbarOrientation) const = 0;

and instead implement ScrollOffset scrollOffset() const.

Also make scrollPosition() pure virtual, avoiding the reverse dependency where
this base class implementation got values from scrollbars.

scrollSize(ScrollbarOrientation) was only used by ScrollAnimatorIOS and we can
do the same computation via min/max scroll positions.

RenderListBox and PopupMenuWin need implementations of scrollPosition().

Remove some PLATFORM(IOS_FAMILY) #ifdefs from ScrollableArea for code that compiles
on all platforms.

page/FrameView.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::overhangAmount const):
(WebCore::ScrollView::scrollSize const): Deleted.
(WebCore::ScrollView::scrollOffset const): Deleted.

platform/ScrollView.h:
platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::isPinnedVerticallyInDirection const):
(WebCore::ScrollableArea::scrollOffset const):
(WebCore::ScrollableArea::scrollPosition const): Deleted.

platform/ScrollableArea.h:

(WebCore::offsetForOrientation):
(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition const):
(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition const):
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMinimumPosition const):
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMaximumPosition const):
(WebCore::ScrollableArea::tiledBacking const): Deleted.

platform/Scrollbar.cpp:

(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::offsetDidChange):

platform/ios/ScrollAnimatorIOS.mm:

(WebCore::ScrollAnimatorIOS::handleTouchEvent):

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::scrollPosition const):
(WebCore::PopupMenuWin::wndProc):
(WebCore::PopupMenuWin::scrollSize const): Deleted.
(WebCore::PopupMenuWin::scrollOffset const): Deleted.

platform/win/PopupMenuWin.h:

(WebCore::PopupMenuWin::scrollOffset const): Deleted.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollSize const): Deleted.
(WebCore::RenderLayer::scrollOffset const): Deleted.

rendering/RenderLayer.h:
rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollPosition const):
(WebCore::RenderListBox::scrollSize const): Deleted.
(WebCore::RenderListBox::scrollOffset const): Deleted.

rendering/RenderListBox.h:

Source/WebKit:

UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::PopupMenuWin::scrollPosition const):
(WebKit::WebPopupMenuProxyWin::onKeyDown): Just use m_scrollOffset.
(WebKit::WebPopupMenuProxyWin::scrollSize const): Deleted.

UIProcess/win/WebPopupMenuProxyWin.h: Remove the one-axis scrollOffset()
WebProcess/Plugins/PDF/PDFPlugin.h:
WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::scrollSize const): Deleted.
(WebKit::PDFPlugin::scrollOffset const): Deleted.

WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):

3:06 PM Changeset in webkit [246487] by ysuzuki@apple.com

5 edits
1 add in trunk

[JSC] Grown region of WasmTable should be initialized with null
https://bugs.webkit.org/show_bug.cgi?id=198903

Reviewed by Saam Barati.

JSTests:

wasm/stress/wasm-table-grow-initialize.js: Added.

(shouldBe):

Source/JavaScriptCore:

Grown region of Wasmtable is now empty. We should initialize it with null.
We also rename Wasm::Table::visitChildren to Wasm::Table::visitAggregate to
align to the naming convention.

wasm/WasmTable.cpp:

(JSC::Wasm::Table::grow):
(JSC::Wasm::Table::visitAggregate):
(JSC::Wasm::Table::visitChildren): Deleted.

wasm/WasmTable.h:
wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::visitChildren):

2:04 PM Changeset in webkit [246486] by Alan Bujtas

2 edits in trunk/Source/WebCore

Address Sam's post-landing review of r246234.

layout/inlineformatting/InlineFormattingContextLineLayout.cpp:

(WebCore::Layout::InlineFormattingContext::LineLayout::createDisplayRuns const):

1:51 PM Changeset in webkit [246485] by Alan Bujtas

2 edits in trunk/Tools

[LFC] Unreviewed test gardening.

Unsupported alignments.

fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
fast/borders/empty-outline-border-assert.html -vertical-align: super
css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle

LayoutReloaded/misc/LFC-passing-tests.txt:

1:41 PM Changeset in webkit [246484] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC][IFC] Decouple baseline ascent/descent and baseline offset.
https://bugs.webkit.org/show_bug.cgi?id=198901
<rdar://problem/51782393>

Reviewed by Antti Koivisto.

Baseline offset is the baseline's distance from the line's logical top -and it is not necessarily the same as the baseline's ascent.
It's easier to track the baseline and its top separately since certain properties only change one or the other.

layout/inlineformatting/InlineFormattingContextLineLayout.cpp:

(WebCore::Layout::InlineFormattingContext::LineLayout::placeInlineItems const):
(WebCore::Layout::InlineFormattingContext::LineLayout::createDisplayRuns const):

layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::Line):
(WebCore::Layout::Line::close):
(WebCore::Layout::Line::adjustBaselineAndLineHeight):
(WebCore::Layout::Line::halfLeadingMetrics):

layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Content::baselineOffset const):
(WebCore::Layout::Line::Content::setBaselineOffset):
(WebCore::Layout::Line::baselineOffset const):

layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::baselineOffset const):
(WebCore::Layout::LineBox::LineBox):

1:19 PM Changeset in webkit [246483] by Alan Bujtas

6 edits in trunk/Source/WebCore

[LFC][IFC] Intruding float may prevent adding any inline box
https://bugs.webkit.org/show_bug.cgi?id=198891
<rdar://problem/51779956>

Reviewed by Antti Koivisto.

Take the intruding left/right float pair and find the vertical position where the next line might go
if these floats prevent us from adding even one inline box to the current line.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::mapPointToAncestor):
(WebCore::Layout::FormattingContext::mapPointToDescendent):

layout/FormattingContext.h:
layout/LayoutUnits.h:

(WebCore::Layout::Point::max):

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingContextLineLayout.cpp:

(WebCore::Layout::InlineFormattingContext::LineLayout::placeInlineItems const):
(WebCore::Layout::InlineFormattingContext::LineLayout::layout const):

1:15 PM Changeset in webkit [246482] by Alan Bujtas

6 edits in trunk/Source/WebCore

[LFC][Floats] Add bottom value to FloatingState::Constraints
https://bugs.webkit.org/show_bug.cgi?id=198889
<rdar://problem/51776730>

Reviewed by Antti Koivisto.

Constraints::left/right->y indicates where this particular constrain ends. This is going to be used by inline layout to figure where
the next line should go (vertical position).

layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::constraints const):

layout/floats/FloatingState.h:

1:04 PM Changeset in webkit [246481] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Ignore descent when in limited/full quirks mode
https://bugs.webkit.org/show_bug.cgi?id=198893
<rdar://problem/51780634>

Reviewed by Antti Koivisto.

In limited/full quirks mode, line's descent should be ignored when computing the final line height when

the line has baseline aligned content only and
these baseline aligned boxes don't have descent.

layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::isVisuallyEmpty const):
(WebCore::Layout::Line::close):

1:02 PM Changeset in webkit [246480] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Line::isVisuallyEmpty should check inline-block boxes.
https://bugs.webkit.org/show_bug.cgi?id=198894
<rdar://problem/51780886>

Reviewed by Antti Koivisto.

Non-zero width/height inline-block boxes make the line visually non-empty.

layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::isVisuallyEmpty const):

12:33 PM Changeset in webkit [246479] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC] Add Layout::Box::isContainingBlockDescendantOf
https://bugs.webkit.org/show_bug.cgi?id=198888
<rdar://problem/51776466>

Reviewed by Antti Koivisto.

Box::isDescendantOf indicates simple ancestor - descendant relationship, while
isContainingBlockDescendantOf checks the containing block chain.

layout/FormattingContext.cpp:

(WebCore::Layout::mapHorizontalPositionToAncestor):
(WebCore::Layout::FormattingContext::mapBoxToAncestor):
(WebCore::Layout::FormattingContext::mapTopToAncestor):
(WebCore::Layout::FormattingContext::mapPointToAncestor):

layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::FloatItem::isDescendantOfFormattingRoot const):

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isDescendantOf const):
(WebCore::Layout::Box::isContainingBlockDescendantOf const):

layout/layouttree/LayoutBox.h:

12:32 PM Changeset in webkit [246478] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Remove Line::Content::isVisuallyEmpty
https://bugs.webkit.org/show_bug.cgi?id=198892
<rdar://problem/51780345>

Reviewed by Antti Koivisto.

Instead of setting the isVisuallyEmpty flag, reset the line height to 0.

layout/inlineformatting/InlineFormattingContextLineLayout.cpp:

(WebCore::Layout::InlineFormattingContext::LineLayout::createDisplayRuns const):

layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::close):

layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Content::isEmpty const):
(WebCore::Layout::Line::Content::setBaseline):
(WebCore::Layout::Line::Content::isVisuallyEmpty const): Deleted.
(WebCore::Layout::Line::Content::setIsVisuallyEmpty): Deleted.

12:30 PM Changeset in webkit [246477] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC] Add limited quirks mode to LayoutState.
https://bugs.webkit.org/show_bug.cgi?id=198881
<rdar://problem/51773229>

Reviewed by Antti Koivisto.

This is in preparation for introducing limited quirks mode to inline layout.

layout/LayoutState.h:

(WebCore::Layout::LayoutState::setQuirksMode):
(WebCore::Layout::LayoutState::inQuirksMode const):
(WebCore::Layout::LayoutState::inLimitedQuirksMode const):
(WebCore::Layout::LayoutState::inNoQuirksMode const):
(WebCore::Layout::LayoutState::setInQuirksMode): Deleted.

page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

12:30 PM Changeset in webkit [246476] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Completely collapsed runs should not go to the trimmable run list.
https://bugs.webkit.org/show_bug.cgi?id=198900
<rdar://problem/51782156>

Reviewed by Antti Koivisto.

layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::trailingTrimmableWidth const):
(WebCore::Layout::Line::appendTextContent):

12:28 PM Changeset in webkit [246475] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Use the borderBox rect consistently to size the inline box.
https://bugs.webkit.org/show_bug.cgi?id=198899

Reviewed by Antti Koivisto.
<rdar://problem/51781969>

Use the margin box height (when applicable) to adjust the line height and use the borderBox rect (or font size) height to size the inline box.

layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::borderBoxHeight const):
(WebCore::Display::Box::marginBoxHeight const):

layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::appendInlineContainerStart):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendNonReplacedInlineBox):
(WebCore::Layout::Line::inlineItemContentHeight const):
(WebCore::Layout::Line::inlineItemHeight const): Deleted.

layout/inlineformatting/InlineLine.h:

11:23 AM Changeset in webkit [246474] by bshafiei@apple.com

1 copy in tags/Safari-607.3.1.2.3

Tag Safari-607.3.1.2.3.

10:58 AM Changeset in webkit [246473] by bshafiei@apple.com

1 copy in tags/Safari-607.3.4

Tag Safari-607.3.4.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed