Context Navigation

← Previous Period
Next Period →

Timeline

Jul 17, 2019:

10:16 PM Changeset in webkit [247559] by Megan Gardner

2 edits in trunk/Source/WebKit

Early Out of positionInfomation check if possible
https://bugs.webkit.org/show_bug.cgi?id=199885
<rdar://problem/53229413>

This is an early-out check that happens after most of the work is done.
Move it to happen before we make all these calls, if in the end, we will not use the information.

Reviewed by Tim Horton.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):

8:34 PM Changeset in webkit [247558] by Chris Dumez

2 edits in trunk/Source/WebKit

Unreviewed, add debug logging to help diagnose flaky crashes on the bots.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):

8:25 PM Changeset in webkit [247557] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit

[macCatalyst] Unable to interact with YouTube video while it's playing
https://bugs.webkit.org/show_bug.cgi?id=199893
<rdar://problem/51871151>

Reviewed by Simon Fraser.

Platform/spi/ios/UIKitSPI.h:
UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:

(-[WKRemoteView initWithFrame:contextID:]):
(-[WKUIRemoteView initWithFrame:pid:contextID:]):
Disable remote context hit-testing for WKUIRemoteView just like we
already do for WKRemoteView.

8:05 PM Changeset in webkit [247556] by Fujii Hironori

3 edits in trunk/LayoutTests

Unreviewed test gardening for WinCairo port

platform/wincairo-wk1/TestExpectations:
platform/wincairo/TestExpectations:

7:52 PM Changeset in webkit [247555] by Chris Dumez

17 edits in trunk/Source

Prewarm local storage in the NetworkProcess to reduce WebContent process hangs
https://bugs.webkit.org/show_bug.cgi?id=199879
<rdar://problem/53217757>

Reviewed by Ryosuke Niwa.

Source/WebCore:

When JS accesses window.localStorage for the first time, we end up doing a
synchronous IPC to the network process to pull in all items in the local
storage for the origin. If the network process does not have this data in
memory, it has to read it from a database on disk, which may take a significant
amount of time and hang the WebContent process during this time.

To alleviate this problem, this patch introduces prewarming on the local storage
in the network process when loading a given origin in the WebContent process.
This way, in most cases, when the JS accesses window.localStorage for the first
time, the synchronous IPC to the network process returns much faster (measured
50-100ms for a very large database, down from 250-300ms), as it only needs to
IPC the data over, without the need to fetch it from disk.

As a safety net to avoid excessive prewarming, we currently prewarm at most 5
security origins per page load.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData):

page/DOMWindow.cpp:

(WebCore::DOMWindow::prewarmLocalStorageIfNecessary):

page/DOMWindow.h:
page/Frame.cpp:

(WebCore::Frame::didPrewarmLocalStorage):
(WebCore::Frame::mayPrewarmLocalStorage const):

page/Frame.h:
storage/Storage.cpp:

(WebCore::Storage::prewarm):

storage/Storage.h:
storage/StorageArea.h:

(WebCore::StorageArea::prewarm):

Source/WebKit:

NetworkProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::prewarm):
(WebKit::StorageManager::getValues):

NetworkProcess/WebStorage/StorageManager.h:
NetworkProcess/WebStorage/StorageManager.messages.in:
WebProcess/WebStorage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::prewarm):

WebProcess/WebStorage/StorageAreaImpl.h:
WebProcess/WebStorage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::loadValuesIfNeeded):
(WebKit::StorageAreaMap::prewarm):

WebProcess/WebStorage/StorageAreaMap.h:

7:29 PM Changeset in webkit [247554] by rmorisset@apple.com

8 edits in trunk

[WHLSL] The lexer should not choke on a single '/'
https://bugs.webkit.org/show_bug.cgi?id=199886

Reviewed by Myles Maxfield.

Source/WebCore:

The bug is trivial: just recognize that a single '/' without a '*' or '/' afterwards is not the beginning of a comment.

While investigating this bug, I also found that part of the parser fails to properly propagate errors, so I fixed it.

New test in LayoutTests/webgpu/whlsl/float-math.html
I also added a new flag to WHLSLPrepare.cpp. It can be used to parse the full standard library (this is how I found this bug in the first place).

Modules/webgpu/WHLSL/WHLSLLexer.cpp:

(WebCore::WHLSL::Lexer::skipWhitespaceAndComments):

Modules/webgpu/WHLSL/WHLSLParser.cpp:

(WebCore::WHLSL::Parser::parsePossibleTernaryConditional):

Modules/webgpu/WHLSL/WHLSLPrepare.cpp:

(WebCore::WHLSL::prepareShared):

Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.cpp:

(WebCore::WHLSL::includeStandardLibrary):

Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.h:

LayoutTests:

Added a new basic test of division.

webgpu/whlsl/float-math.html:

7:00 PM Changeset in webkit [247553] by Simon Fraser

2 edits in trunk/Source/WebCore

Unreviewed build fix after r247549.

Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp:

6:21 PM Changeset in webkit [247552] by Megan Gardner

2 edits in trunk/Source/WebKit

Set WordIsNearTap flag, was not being set at all before
https://bugs.webkit.org/show_bug.cgi?id=199880

Reviewed by Wenson Hsieh.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):

6:18 PM Changeset in webkit [247551] by rmorisset@apple.com

14 edits
1 delete in trunk/Source/WebCore

[WHLSL] Remove traps from the compiler
https://bugs.webkit.org/show_bug.cgi?id=195811
<rdar://problem/50746299>

Reviewed by Myles Maxfield.

Remove the Trap statement from the language, see https://github.com/gpuweb/WHLSL/issues/301.

No new tests, as this part of the language was already untested, and we are removing it, not adding anything.

Modules/webgpu/WHLSL/AST/WHLSLAST.h:
Modules/webgpu/WHLSL/AST/WHLSLStatement.h:

(WebCore::WHLSL::AST::Statement::isSwitchStatement const):

Modules/webgpu/WHLSL/AST/WHLSLTrap.h: Removed.
Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:
Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
Modules/webgpu/WHLSL/WHLSLASTDumper.h:
Modules/webgpu/WHLSL/WHLSLLexer.cpp:

(WebCore::WHLSL::Token::typeName):
(WebCore::WHLSL::Lexer::recognizeKeyword):

Modules/webgpu/WHLSL/WHLSLLexer.h:
Modules/webgpu/WHLSL/WHLSLParser.cpp:

(WebCore::WHLSL::Parser::parseStatement):

Modules/webgpu/WHLSL/WHLSLParser.h:
Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp:
Modules/webgpu/WHLSL/WHLSLVisitor.cpp:

(WebCore::WHLSL::Visitor::visit):

Modules/webgpu/WHLSL/WHLSLVisitor.h:
WebCore.xcodeproj/project.pbxproj:

6:05 PM Changeset in webkit [247550] by clopez@igalia.com

12 edits in trunk/Tools

[GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
https://bugs.webkit.org/show_bug.cgi?id=199855

Reviewed by Michael Catanzaro.

The webkitpy drivers for GTK and WPE use their own versions for setting
up the environment and starting/stopping the drivers.
This refactors those drivers to use the base class driver functions.
As a benefit we get some fixes like support for setting the profiler
environment variables, and a simpler code.

Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.

Scripts/webkitpy/port/headlessdriver.py:

(HeadlessDriver._setup_environ_for_test):

Scripts/webkitpy/port/waylanddriver.py:

(WaylandDriver._setup_environ_for_test):

Scripts/webkitpy/port/westondriver.py:

(WestonDriver._setup_environ_for_test):
(WestonDriver.stop):

Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.

(WestonDriverTest.make_driver):

Scripts/webkitpy/port/xorgdriver.py:

(XorgDriver._setup_environ_for_test):

Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env

(XvfbDriver._setup_environ_for_test):

Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.

(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start):
(XvfbDriverTest.test_start_arbitrary_worker_number):

Scripts/webkitpy/w3c/wpt_runner.py:

(main): Start the driver before trying to get its environment to define all the environment variables.

Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:

(WebDriverTestRunner.init): Ditto.

glib/api_test_runner.py:

(TestRunner._setup_testing_environment): Ditto.

5:36 PM Changeset in webkit [247549] by rmorisset@apple.com

2 edits in trunk/Source/WebCore

[WHLSL] checkRecursiveType should not have exponential complexity.
https://bugs.webkit.org/show_bug.cgi?id=199835

Reviewed by Myles Maxfield.

The change is very similar to that in https://bugs.webkit.org/show_bug.cgi?id=199688.
Just keep track of which types have already been visited, and don't visit them again.

No new tests as there is no intended functional change.

Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp:

(WebCore::WHLSL::RecursiveTypeChecker::visit):
(WebCore::WHLSL::checkRecursiveTypes):

5:17 PM Changeset in webkit [247548] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Add missing #include's
https://bugs.webkit.org/show_bug.cgi?id=199856

Patch by Carlos Eduardo Ramalho <cadubentzen@gmail.com> on 2019-07-17
Reviewed by Simon Fraser.

The missing headers were found during development when unified sources changed.

No new tests required. Adding #include's only.

Modules/speech/DOMWindowSpeechSynthesis.cpp:
Modules/webgpu/WHLSL/WHLSLAutoInitializeVariables.cpp:
Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp:
Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:
Modules/webgpu/WebGPUCommandEncoder.cpp:

5:15 PM Changeset in webkit [247547] by jiewen_tan@apple.com

3 edits in trunk/Source/WebKit

Provide a NSURL cateogry to tell AppSSO Kerberos URLs
https://bugs.webkit.org/show_bug.cgi?id=199887
<rdar://problem/52323161>

Reviewed by Brent Fulgham.

UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.h:
UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm:

(+[NSURL _web_willPerformSOKerberosAuthorizationWithURL:]):

5:05 PM Changeset in webkit [247546] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Add inputmode to the feature status page
https://bugs.webkit.org/show_bug.cgi?id=199884

Reviewed by Wenson Hsieh.

Added as supported.

features.json:

4:58 PM Changeset in webkit [247545] by graouts@webkit.org

12 edits in trunk

Disable Pointer Events prior to watchOS 6
https://bugs.webkit.org/show_bug.cgi?id=199890
<rdar://problem/53206113>

Reviewed by Dean Jackson.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

4:57 PM Changeset in webkit [247544] by graouts@webkit.org

3 edits
2 adds in trunk

Unable to bring up custom media controls on iOS for video.sina.cn
https://bugs.webkit.org/show_bug.cgi?id=199889
<rdar://problem/51883919>

Reviewed by Dean Jackson.

Source/WebCore:

Videos on video.sina.cn by default have the "controls" attribute and are set not to autoplay. This means that the original state
of the media controls are set to show the built-in media controls and also show the prominent play button to begin playback. The
display of the play button also requires a tap gesture recognizer, which calls preventDefault() when the "touchend" is received
to prevent double-tap-to-zoom, but also has the side-effect of preventing a "click" event from being dispatched for a tap.

The video.sina.cn code would eventually remove the "controls" attribute, which would make the built-in media controls not visible,
but still participate in hit-testing because we keep the shadow DOM around in order to potentially show the Airplay or picture-in-picture
placards. Additionally, we wouldn't disable the tap gesture recognizer when the "controls" attribute was removed.

We now ensure that both gesture recognizers used by iOS inline media controls are only enabled when media controls are visible.

Test: media/modern-media-controls/media-controller/ios/media-controller-allows-click-over-video-with-no-controls.html

Modules/modern-media-controls/controls/ios-inline-media-controls.js:

(IOSInlineMediaControls.prototype.set showsStartButton):
(IOSInlineMediaControls.prototype.get visible):
(IOSInlineMediaControls.prototype.set visible):
(IOSInlineMediaControls.prototype._updateGestureRecognizers):
(IOSInlineMediaControls.prototype._tapGestureRecognizerStateDidChange):
(IOSInlineMediaControls.prototype._pinchGestureRecognizerStateDidChange):

LayoutTests:

This test replicates the scenario found on video.sina.cn that caused the issue: a <video> element originally has the "controls"
attribute and is not set to autoplay. This means the tap gesture recognizer is created to track a tap for the video to play. Then
the "controls" attribute is removed and we dispatch a tap on the video which would previously have *not* caused a "click" event to
eventually be dispatched on the <video> element since the tap gesture recognizer would call preventDefault(). With this patch applied,
we get the "click" event because the tap gesture recognizer is disabled once the controls are no longer visible.

media/modern-media-controls/media-controller/ios/media-controller-allows-click-over-video-with-no-controls-expected.txt: Added.
media/modern-media-controls/media-controller/ios/media-controller-allows-click-over-video-with-no-controls.html: Added.

4:12 PM Changeset in webkit [247543] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

Force useLLInt to true on arm64_32
https://bugs.webkit.org/show_bug.cgi?id=199882
<rdar://problem/53207586>

Reviewed by Yusuke Suzuki.

Some jsc tests set useLLInt=false but on arm64_32 we don't support the JIT.
This causes the option coherency checker to get angry. We should force
useLLInt=true on arm64_32 unless useJIT=true.

runtime/Options.cpp:

(JSC::recomputeDependentOptions):

4:03 PM Changeset in webkit [247542] by chris.reid@sony.com

23 edits in trunk

Bytecode cache should use FileSystem
https://bugs.webkit.org/show_bug.cgi?id=199759

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

Update bytecode cache to use platform generic FileSystem calls.

API/JSScript.mm:
CMakeLists.txt:
jsc.cpp:
runtime/CachePayload.cpp:
runtime/CachePayload.h:
runtime/CachedBytecode.h:
runtime/CachedTypes.cpp:
runtime/CachedTypes.h:
runtime/CodeCache.cpp:
runtime/CodeCache.h:
runtime/Completion.cpp:
runtime/Completion.h:

Source/WebCore:

platform/SharedBuffer.cpp:

Source/WTF:

wtf/FileSystem.cpp:
wtf/FileSystem.h:

Add support for creating MappedFileData from a preexisting file handle
for use with locked files. Also support creating MappedFileData
with either private or shared mappings.

wtf/UUID.cpp:

Avoid ASSERT with returning a LazyNeverDestroyed object that hasn't been created.

wtf/glib/FileSystemGlib.cpp:
wtf/win/FileSystemWin.cpp:

Add truncateFile implementations.

Tools:

TestWebKitAPI/Tests/WTF/FileSystem.cpp:

4:01 PM Changeset in webkit [247541] by Alan Bujtas

5 edits in trunk/Source

Unable to tap buttons at top of Wells Fargo app’s Payees screen
https://bugs.webkit.org/show_bug.cgi?id=199846
<rdar://problem/48112220>

Reviewed by Simon Fraser.

Source/WebCore:

This patch restores the stop-before-reaching-the-body heuristics for the approximate node finding feature only.
(WebFrame::approximateNodeAtViewportLocation mistakenly relied on this odd quirk of nodeRespondingToClickEvents.)

page/Frame.h:
page/ios/FrameIOS.mm:

(WebCore::Frame::approximateNodeAtViewportLocationLegacy):

Source/WebKitLegacy/mac:

WebView/WebFrame.mm:

(-[WebFrame approximateNodeAtViewportLocation:]):

3:49 PM Changeset in webkit [247540] by Simon Fraser

14 edits
4 adds in trunk

[iOS WK2] Avoid lots of compositing backing store for offscreen position:fixed descendants
https://bugs.webkit.org/show_bug.cgi?id=199819
rdar://problem/51977416

Reviewed by Zalan Bujtas.

Source/WebCore:

There was code to ensure that position:fixed layers and their descendants don't have their
backing store detached (thrown away to save memory when offscreen), since that can trigger
flashing when async scrolling moves layers in and out of the visual viewport.

However, some pages have many descendant layers of positon:fixed which entrain backing
store, because, for example, they have a stack of translated-offscreen menu elements inside
a fixed header, and those elements may composite because of overflow:scroll.

To avoid using too much memory on such pages, allow backing store detachment for fixed
layers that are outside the layout viewport. Add a flag to RenderLayer that's set for layers
which are fixed, or descendants of fixed, and consult that flag in
updateAllowsBackingStoreDetaching(). The logic there is similar to
RenderLayerCompositor::requiresCompositingForPosition().

I considered allowing all position:fixed to composite (since this patch would keep most of
the memory saving), but historically we've avoided compositing out-of-viewport
position:fixed because it's quite common to have them with negative z-index, and compositing
those has significant compositing knock-on effects.

GraphicsLayer flushing no longer needs to track the viewport-constrained status of layers,
so remove that code.

This patch removes backing-store pinning for sticky layers.
scrolling/ios/reconcile-layer-position-recursive.html then revealed a bug in
ScrollingStateStickyNode::reconcileLayerPositionForViewportRect(), which was assuming that
the sticky element was scrolled by the page, causing a bad layer position to get sync'd onto
the layer. Fixed by copying code from ScrollingTreeStickyNode that is smarter about
computing layer positions.

This patch fixes jetsams on kmart.com.au in iOS 13 beta.

Test: compositing/layer-creation/fixed-position-descendants-out-of-view.html

page/scrolling/ScrollingStateStickyNode.cpp:

(WebCore::ScrollingStateStickyNode::computeLayerPosition const):
(WebCore::ScrollingStateStickyNode::reconcileLayerPositionForViewportRect):

page/scrolling/ScrollingStateStickyNode.h:
platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setAllowsBackingStoreDetaching):
(WebCore::GraphicsLayer::allowsBackingStoreDetaching const):
(WebCore::GraphicsLayer::setIsViewportConstrained): Deleted.
(WebCore::GraphicsLayer::isViewportConstrained const): Deleted.
(WebCore::GraphicsLayer::setCanDetachBackingStore): Deleted.
(WebCore::GraphicsLayer::canDetachBackingStore const): Deleted.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush const):
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::updateCoverage):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

platform/graphics/ca/GraphicsLayerCA.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::outputPaintOrderTreeLegend):
(WebCore::outputPaintOrderTreeRecursive):

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAllowsBackingStoreDetaching):
(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
(WebCore::RenderLayerBacking::setIsScrollCoordinatedWithViewportConstrainedRole): Deleted.

rendering/RenderLayerBacking.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition const):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForLayer):

LayoutTests:

compositing/layer-creation/fixed-position-change-out-of-view-in-view.html:
compositing/layer-creation/fixed-position-descendants-out-of-view-expected.txt: Added.
compositing/layer-creation/fixed-position-descendants-out-of-view.html: Added.
compositing/layer-creation/fixed-position-out-of-view.html:
platform/ios-wk2/fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt: Added.

2:46 PM Changeset in webkit [247539] by commit-queue@webkit.org

7 edits in trunk/LayoutTests

Add a runtime-disabled dialog element skeleton
https://bugs.webkit.org/show_bug.cgi?id=199839

Patch by Alex Christensen <achristensen@webkit.org> on 2019-07-17
Reviewed by Ryosuke Niwa.

Rebaseline WK2 test expectations.

platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
platform/ios-wk2/imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:

2:40 PM Changeset in webkit [247538] by Jonathan Bedard

4 edits in trunk/Tools

check-webkit-style: Add limited Python3 support
https://bugs.webkit.org/show_bug.cgi?id=199870

Rubber-stamped by Aakash Jain.

Since new services will be added in the near future which are Python 3, we
need to support Python 3 style checks. For now, assume all Python files are
Python 2 unless otherwise specified.

Scripts/webkitpy/style/checker.py:

(_all_categories): Add pycodestyle to valid categories for testing.
(CheckerDispatcher._create_checker): Check that the provided Python file is in
one of the declared Python 3 directories.

Scripts/webkitpy/style/checkers/python.py:

(Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
instead of pep8.
(Python3Checker.init):
(Python3Checker.check):

Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
(AutoinstallImportHook._install_pycodestyle):

2:18 PM Changeset in webkit [247537] by weinig@apple.com

11 edits
1 add in trunk

Add StringBuilder member function which allows makeString() style variadic argument construction
https://bugs.webkit.org/show_bug.cgi?id=198997

Reviewed by Darin Adler.

Source/WTF:

Adds new StringBuilder::flexibleAppend(...) member function which allows passing one or more
string-adaptable (in the sense that there is StringTypeAdapter specialization for the
type) parameters. This re-ususes the variadic template infrastructure in StringConcatenate.h
that is used for makeString(...) allowing for improvements in one to benefit the other.

The advantage of StringBuilder::flexibleAppend(...) over calling StringBuilder::append(...)
multiple times (beyond the code sharing with makeString(...) is that it can avoid unnecessary
additional re-allocations when the StringBuilder needs to expand it's capacity. It does this
by computing the complete required length for all the passed arguments and then ensuring enough
capacity is available. It also reduces the allocation overhead versus the anti-pattern of
builder.append(makeString(...)).

Ideally, this member function should eventually just be called StringBuilder::append(...), but
the current overload set for StringBuilder::append(...) makes this complicated due to overloads
that take two arguments such as StringBuilder::append(const UChar*, unsigned). Going forward, we
should rename or remove those overloads and move to a standard interface.

wtf/posix/FileSystemPOSIX.cpp:

(WTF::FileSystemImpl::pathByAppendingComponents):
Adopt StringBuilder::flexibleAppend, using to combine the append of '/' and component.

wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::appendUninitializedWithoutOverflowCheck):
Extract the part of appendUnitialized that doesn't do the overflow check
into it's own member function to allow callers that have already done the
overflow check to bypass it.

(WTF::StringBuilder::appendUninitializedWithoutOverflowCheckForUChar):
(WTF::StringBuilder::appendUninitializedWithoutOverflowCheckForLChar):
Added to allow template member function flexibleAppendFromAdapters to call
appendUninitializedWithoutOverflowCheck without moving it to the header.

wtf/text/StringBuilder.h:

(WTF::StringBuilder::flexibleAppendFromAdapters):
(WTF::StringBuilder::flexibleAppend):
Modeled on tryMakeStringFromAdapters in StringConcatenate.h, these
eagerly compute the required length, expand the buffer and then use
the existing string type adaptor accumulation functions used by makeString.

wtf/text/StringConcatenate.h:

(WTF::stringTypeAdapterAccumulator):
(WTF::tryMakeStringFromAdapters):
(WTF::makeStringAccumulator): Deleted.
Renames makeStringAccumulator to stringTypeAdapterAccumulator now that it is used
by more than just makeString.

Tools:

TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

Add basic test showing that StringBuilder::flexibleAppend can be used to
append one or more string adaptable types.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add WTFStringUtilities.cpp

TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

Add basic test showing that StringBuilder::flexibleAppend can be used to
append one or more string adaptable types.

TestWebKitAPI/Tests/WTF/StringOperators.cpp:
TestWebKitAPI/WTFStringUtilities.cpp: Added.
TestWebKitAPI/WTFStringUtilities.h:

Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.

2:11 PM Changeset in webkit [247536] by rniwa@webkit.org

2 edits
1 delete in trunk/Tools

Remove the file superfluously added in r247535.

TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:

1:46 PM Changeset in webkit [247535] by aboya@igalia.com

6 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=199878

platform/gtk/TestExpectations:
platform/gtk/compositing/overflow/textarea-scroll-touch-expected.txt:
platform/gtk/fast/events/shadow-event-path-2-expected.txt:
platform/gtk/fast/events/shadow-event-path-expected.txt:
platform/wpe/TestExpectations:

1:43 PM Changeset in webkit [247534] by Chris Dumez

3 edits in trunk/Source/WebCore

Avoid unnecessary copy of monitors under DisplayRefreshMonitorManager::displayWasUpdated()
https://bugs.webkit.org/show_bug.cgi?id=199847

Reviewed by Said Abou-Hallawa.

There is always one one monitor in m_monitors for a given displayID so there is
no need to copy the monitors inside DisplayRefreshMonitorManager::displayWasUpdated()
and no need to iterate over all of them. This patch also factors a bit differently
so that it becomes more obvious.

platform/graphics/DisplayRefreshMonitorManager.cpp:

(WebCore::DisplayRefreshMonitorManager::createMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):
(WebCore::DisplayRefreshMonitorManager::displayDidRefresh):
(WebCore::DisplayRefreshMonitorManager::displayWasUpdated):
(WebCore::DisplayRefreshMonitorManager::findMonitorForDisplay const):
(WebCore::DisplayRefreshMonitorManager::monitorForDisplay const):

platform/graphics/DisplayRefreshMonitorManager.h:

1:39 PM Changeset in webkit [247533] by commit-queue@webkit.org

5 edits in trunk

Web Inspector: application/xml content not shown
https://bugs.webkit.org/show_bug.cgi?id=199861

Patch by Olivier Blin <Olivier Blin> on 2019-07-17
Reviewed by Devin Rousso.

Source/WebInspectorUI:

application/xml content from XHR requests was not shown in the
inspector, an error message was displayed instead.

application/xml content should be treated as text, since
application/xml is the standard mimetype for XML content.
Apache serves XML content with the application/xml mimetype by
default.

UserInterface/Base/MIMETypeUtilities.js:

(WI.fileExtensionForMIMEType):
Report "xml" extension for "application/xml" mimetype.
(WI.shouldTreatMIMETypeAsText):
Treat XML files as text.

LayoutTests:

inspector/unit-tests/mimetype-utilities-expected.txt:
inspector/unit-tests/mimetype-utilities.html:

Test for shouldTreatMIMETypeAsText.

1:30 PM Changeset in webkit [247532] by mark.lam@apple.com

3 edits
1 add in trunk

ArgumentsEliminationPhase should insert KillStack nodes before PutStack nodes that it adds.
https://bugs.webkit.org/show_bug.cgi?id=199821
<rdar://problem/52452328>

Reviewed by Filip Pizlo.

JSTests:

stress/arguments-elimination-should-insert-KillStacks-before-added-PutStacks.js: Added.

Source/JavaScriptCore:

Excluding the ArgumentsEliminationPhase, PutStack nodes are converted from SetLocal
nodes in the SSAConversionPhase. SetLocal nodes are always preceded by MovHint nodes,
and the SSAConversionPhase always inserts a KillStack node before a MovHint node.
Hence, a PutStack node is always preceded by a KillStack node.

However, the ArgumentsEliminationPhase can convert LoadVarargs nodes into a series
of one or more PutStacks nodes, and it prepends MovHint nodes before the PutStack
nodes. However, it neglects to prepend KillStack nodes as well. Since the
ArgumentsEliminationPhase runs after the SSAConversionPhase, the PutStack nodes
added during ArgumentsElimination will not be preceded by KillStack nodes.

This patch fixes this by inserting a KillStack in the ArgumentsEliminationPhase
before it inserts a MovHint and a PutStack node.

Consider this test case which can manifest the above issue as a crash:

function inlinee(value) {

...
let tmp = value + 1;

}

function reflect() {

return inlinee.apply(undefined, arguments);

}

function test(arr) {

let object = inlinee.apply(undefined, arr); Uses a lot of SetArgumentMaybe nodes.
reflect(); Calls with a LoadVararg, which gets converted into a PutStack of a constant.

}

In this test case, we have a scenario where a SetArgumentMaybe's stack
slot is reused as the stack slot for a PutStack later. Here, the PutStack will
put a constant undefined value. Coincidentally, the SetArgumentMaybe may also
initialize that stack slot to a constant undefined value. Note that by the time
the PutStack executes, the SetArgumentMaybe's stack slot is dead. The liveness of
these 2 values are distinct.

However, because we were missing a KillStack before the PutStack, OSR availability
analysis gets misled into thinking that the PutStack constant value is still in the
stack slot because the value left there by the SetArgumentMaybe hasn't been killed
off yet. As a result, OSR exit code will attempt to recover the PutStack's undefined
constant by loading from the stack slot instead of materializing it. Since
SetArgumentMaybe may not actually initialize the stack slot, we get a crash in OSR
exit when we try to recover the PutStack constant value from the stack slot, and
end up using what ever junk value we read from there.

Fixing the ArgumentsEliminationPhase to insert KillStack before the PutStack
removes this conflation of the PutStack's constant value with the SetArgumentMaybe's
constant value in the same stack slot. And, OSR availability analysis will no
longer be misled to load the PutStack's constant value from the stack, but will
materialize the constant instead.

dfg/DFGArgumentsEliminationPhase.cpp:

1:27 PM Changeset in webkit [247531] by sihui_liu@apple.com

3 edits in trunk/Source/WebCore

IndexedDB: error in starting version change transaction may be neglected
https://bugs.webkit.org/show_bug.cgi?id=199818
<rdar://problem/52925738>

Reviewed by Brady Eidson.

For version change transaction, IDBServer didn't wait the result of beginTransaction on the background thread
before giving the IDBClient the result of open request. In this case, beginTransaction may fail to update the
DatabaseVersion in database file or set m_originalDatabaseInfoBeforeVersionChange, but the transaction was
marked as started. When we later set m_databaseInfo with m_originalDatabaseInfoBeforeVersionChange,
m_databaseInfo could become nullptr.

To write a test for this, we will need to simulate an SQLite error. I manually tested this by crafting the
SQLiteStatement in beginTransaction, making it an invalid statement, and verified that error event, instead of
ungradeneeded event is dispatched to the IDBRequest.

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::startVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performStartVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformStartVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::beginTransactionInBackingStore): Deleted.

Modules/indexeddb/server/UniqueIDBDatabase.h:

1:06 PM Changeset in webkit [247530] by dbates@webkit.org

15 edits
4 adds in trunk

Typing into a cell in a Google Sheet lags behind by one character
https://bugs.webkit.org/show_bug.cgi?id=199587
<rdar://problem/51616845>

Reviewed by Brent Fulgham.

Source/WebCore:

Add a Google Sheets quirk. Put all DOM timers scheduled from keydown and keypress event listeners
into a holding tank. The timers continue to tick, but are barred from executing their action until
the next text insertion or deletion or 32 ms (on device) have elapsed, whichever is sooner. We only
allocate a holding tank once per document, only if the quirk is active, and this allocation is done
when the document schedules a timer on keydown or keypress. The holding tank lives for the lifetime
of the document.

The story behind the quirk:

On keypress Google Sheets schedules timers and expects that a DOM update will occur (i.e. text
will be inserted or deleted) within the same event loop iteration as the dispatched keypress. The
UI Events spec. [1] makes no such guarantee of when a DOM update must occur in relation to the keypress
event. It could happen in the same event loop iteration as the key press (as Google expects), the
next iteration, 500ms later, 2 minutes later, etc. What the spec does guarantee is that by the time
a DOM input event is dispatched that the DOM will be updated. And this is the solution to the problem
Google Sheets is trying to solve, but is doing so using pre-IE 9 technology (though similar
functionality was available via onpropertychange in IE < 9).

See also <https://github.com/w3c/uievents/issues/238>, which is tracking a spec. text update for
this quirk.

Test: fast/events/ios/dom-update-on-keydown-quirk.html

[1] <https://w3c.github.io/uievents/> (Editor's Draft, 14 October 2018)

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:

Add some files to the project.

dom/Document.cpp:

(WebCore::Document::domTimerHoldingTank): Added.

dom/Document.h:

(WebCore::Document::domTimerHoldingTankIfExists): Added.

page/DOMTimer.cpp:

(WebCore::DOMTimer::install): Put the newly instantiated timer into the holding tank.
(WebCore::DOMTimer::removeById): Remove the timer from the holding tank.
(WebCore::DOMTimer::fired): Check if the timer is in the holding tank. If it is and it is a one-
shot timer then schedule it for the next event loop iteration. If it's a repeating timer just
let it continue ticking. Otherwise, do what we no now and execute the timer's action. The reason
we do not suspend timers in the holding tank is because:

Far out timers (Google Sheets registers timers as far out as 5 minutes!) are not penalized. Though smart supension logic could avoid this. See (3).

Empirical observations indicate that the keyboard will perform the insertion or deletion reasonably quickly (not the same event loop iteration as the keydown, but within two iterations out). So, the timers in the holding tank are short-lived.

Simplifies the code. There is no need to keep additional bookkeeping to track multiple timer suspension reasons (timers currently can only have one suspension reason) or alternatively defer scheduling a timer until a later time and computing a new "fair" firing time when scheduled.

page/EventHandler.cpp:

(WebCore::EventHandler::internalKeyEvent): Place a token on the stack to put all DOM timers
scheduled on keydown and keypress into the holding tank if the quirk is enabled.

page/Quirks.cpp:

(WebCore::Quirks::needsDeferKeyDownAndKeyPressTimersUntilNextEditingCommand const): Added.

page/Quirks.h:
page/Settings.yaml: Added setting so that this quirk can be enabled from a layout test. This setting

also lets us enable the quirk for all sites or for certain third-party apps if desired.

page/ios/DOMTimerHoldingTank.cpp: Added.

(WebCore::DOMTimerHoldingTank::DOMTimerHoldingTank):
(WebCore::DOMTimerHoldingTank::add):
(WebCore::DOMTimerHoldingTank::remove):
(WebCore::DOMTimerHoldingTank::contains):
(WebCore::DOMTimerHoldingTank::removeAll):
(WebCore::DOMTimerHoldingTank::stopExceededMaximumHoldTimer):

page/ios/DOMTimerHoldingTank.h: Added.

(WebCore::DeferDOMTimersForScope::DeferDOMTimersForScope):
(WebCore::DeferDOMTimersForScope::~DeferDOMTimersForScope):
(WebCore::DeferDOMTimersForScope::isDeferring):

Source/WebKit:

Remove all timers from the holding tank on text insertion or deletion (represented as an
editing command). Timers that were in the holding tank never stopped ticking and will now
be able to execute their action.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::executeEditingCommand):
(WebKit::WebPage::insertTextAsync):
(WebKit::WebPage::setCompositionAsync):
(WebKit::WebPage::confirmCompositionAsync):
Call platformWillPerformEditingCommand().

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::platformWillPerformEditingCommand): Added.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformWillPerformEditingCommand): Remove all the timers from the holding
tank if we have a holding tank.

LayoutTests:

Add a test that enables the quirk and ensures that the DOM is up-to-date on expiration of a
zero timer scheduled from keydown, keypress, keyup, and input.

fast/events/ios/dom-update-on-keydown-quirk-expected.txt: Added.
fast/events/ios/dom-update-on-keydown-quirk.html: Added.

1:02 PM Changeset in webkit [247529] by Darin Adler

27 edits in trunk/Source

No need for isURLAllowed function in Frame
https://bugs.webkit.org/show_bug.cgi?id=120266

Reviewed by Alex Christensen.

Source/WebCore:

css/SelectorCheckerTestFunctions.h:

(WebCore::matchesFullScreenPseudoClass): Use is<> instead of
the isFrameElementBase function. Also updated includes and spacing.

dom/Document.cpp:

(WebCore::Document::resolveStyle): Shortened an old, long comment
that happened to mention HTMLFrameElementBase::isURLAllowed by name.

dom/Element.h: Deleted isFrameElementBase.

html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::updateWidget): Tweaked comment.

html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedIntoAncestor): Moved comment from
here to didFinishInsertingNode, since the code it's talking about is there.
Also got rid of unnecessary local variable.
(WebCore::HTMLBodyElement::didFinishInsertingNode): Moved comment here
and elaborated a bit. Also changed the code to copy margin attributes in a
simpler way without requiring special getter functions. There is a slight
behavior change here, but seems unlikely to affect any websites or tests.
Would be good to add better test coverage, which I think should be done
when fixing the problems described in the FIXME.

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): allowedToLoadFrameURL -> canLoadURL
Also Tweaked comments.

html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::rendererIsNeeded): isURLAllowed -> canLoad

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed initial
values for no-longer-needed data members.

(WebCore::HTMLFrameElementBase::canLoadScriptURL const): Renamed from
isURLAllowed. Also refactored so it now calls canLoadURL.
(WebCore::HTMLFrameElementBase::canLoad const): Renamed from isURLAllowed.
Also added FIXME comments about multiple ways that this code incorrectly
handles the empty string. Might inspire some tests and future fixes.
(WebCore::HTMLFrameElementBase::canLoadURL const): Renamed from isURLAllowed.
Added an overload that takes a relative URL string largely to make this
more parallel with the similar code in HTMLPlugInImageElement. Refactored
to call canAddSubframe and isProhibitedSelfReference, removing the need
to call Frame::isURLAllowed.
(WebCore::HTMLFrameElementBase::openURL): isURLAllowed -> canLoad
(WebCore::HTMLFrameElementBase::parseAttribute): Removed unneeded code
to parse marginwidth, marginheight, and scrolling, which are now done
as needed instead. Might have to add code back if we ever add code to
make these cause dynamic updates when changed, but that was not the
behavior of the existing code.
(WebCore::HTMLFrameElementBase::scrollingMode const): Changed to call
attributeWithoutSynchronization rather than reading from a data member.

html/HTMLFrameElementBase.h: Moved scrollingMode into the .cpp file.

Removed marginWidth and marginHeight since they are no longer called.
Made canContainRangeEndPoint override be private. Renamed isURLAllowed
to canLoad/canLoadScriptURL/canLoadURL. Removed unneeded isFrameElementBase
since is<HTMLFrameElementBase> already works without it. Removed unneeded
data members m_scrolling, m_marginWidth, and m_marginHeight.

html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Moved initialization
of m_contentFrame and m_sandboxFlags to the header.
(WebCore::HTMLFrameOwnerElement::clearContentFrame): 0 -> nullptr
(WebCore::HTMLFrameOwnerElement::canAddSubframe const): Added. Code was moved
here from multiple functions that enforced the subframe count limit.
(WebCore::HTMLFrameOwnerElement::isProhibitedSelfReference const): Added.
Moved code here from Frame::isURLAllowed so it's easy to use as needed.

html/HTMLFrameOwnerElement.h: Renamed isURLAllowed to canLoadScriptURL.

Added protected canAddSubframe and isProhibitedSelfReference functions.
Initialized the data members here.

html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::sandbox): Added braces for multi-line if statement.
(WebCore::HTMLIFrameElement::parseAttribute): Removed unneeded storage of the
allow attribute value. Added missing code to invalidate m_featurePolicy when
the allow attribute changes. This could change behavior, but unlikely to affect
any websites of tests. Would be good to add a test for this.
(WebCore::HTMLIFrameElement::rendererIsNeeded): isURLAllowed -> canLoad. Also
reordered the code to be more efficient for display: none (why not?).
(WebCore::HTMLIFrameElement::featurePolicy const): Use attributeWithoutSynchronization
to read the allow attribute rather than using a data member.

html/HTMLIFrameElement.h: Removed the unneeded allow function member and

m_allow data member since DOM reflection takes care of the function and the
featurePolicy function can get the attribute without a data member.

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget): allowedToLoadFrameURL -> canLoadURL
Also tweaked comments.

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::canLoadScriptURL const): Added. Code moved here
from HTMLFrameOwnerElement::isURLAllowed. Added comment about why this is not
necessarily correct and might need improvement.

html/HTMLPlugInElement.h: Added private override of canLoadScriptURL.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::canLoadURL const): Renamed from
allowedToLoadFrameURL and refactored into two functions to match the
structure of the similar function in HTMLFrameElementBase. Also refactored
to use canAddSubframe and isProhibitedSelfReference rather than Frame::isURLAllowed.
(WebCore::HTMLPlugInImageElement::canLoadPlugInContent const): Renamed from
allowedToLoadPluginContent.
(WebCore::HTMLPlugInImageElement::requestObject): allowedToLoadPluginContent
-> canLoadPlugInContent

html/HTMLPlugInImageElement.h: Renamed functions as mentioned above.

loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestFrame): isURLAllowed -> canLoadScriptURL

page/FocusController.h: Removed unneeded forward declaration of HTMLFrameOwnerElement.

page/Frame.cpp:

(WebCore::Frame::isURLAllowed const): Deleted.

page/Frame.h: Ditto.

page/FrameView.cpp:

(WebCore::FrameView::init): Removed code to initialize m_margins, since nothing
was looking at it after that.
(WebCore::FrameView::setMarginWidth): Deleted.
(WebCore::FrameView::setMarginHeight): Deleted.

page/FrameView.h: Removed marginWidth, marginHeight, setMarginWidth,

setMarginHeight, and m_margins because there was no code anywhere calling
marginWidth or marginHeight, and no other side effects of these functions.

Source/WebKit:

WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::resolveChildFrameWithNodeHandle):
Use is<HTMLFrameElementBase> instead of isFrameElementBase.

12:37 PM Changeset in webkit [247528] by mmaxfield@apple.com

4 edits
56 copies
182 moves
3 adds
23 deletes in trunk/LayoutTests

[WHLSL] Move WHLSL tests to their own folder
https://bugs.webkit.org/show_bug.cgi?id=199838

Reviewed by Robin Morisset.

webgpu/whlsl-foo.html => webgpu/whlsl/foo.html

TestExpectations:
platform/mac-wk2/TestExpectations:
webgpu/msl-harness-test.html:
webgpu/whlsl-arbitrary-vertex-attribute-locations-expected.html: Removed.
webgpu/whlsl-buffer-fragment-expected.html: Removed.
webgpu/whlsl-buffer-vertex-expected.html: Removed.
webgpu/whlsl-dereference-pointer-should-type-check-expected.html: Removed.
webgpu/whlsl-do-while-loop-continue-expected.html: Removed.
webgpu/whlsl-do-while-loop-expected.html: Removed.
webgpu/whlsl-dont-crash-parsing-enum-expected.html: Removed.
webgpu/whlsl-dot-expressions-expected.html: Removed.
webgpu/whlsl-ensure-proper-variable-lifetime-2-expected.html: Removed.
webgpu/whlsl-ensure-proper-variable-lifetime-3-expected.html: Removed.
webgpu/whlsl-ensure-proper-variable-lifetime-expected.html: Removed.
webgpu/whlsl-expected.html: Removed.
webgpu/whlsl-loops-expected.html: Removed.
webgpu/whlsl-nested-dot-expression-rvalue-expected.html: Removed.
webgpu/whlsl-return-local-variable-expected.html: Removed.
webgpu/whlsl-store-to-property-updates-properly-expected.html: Removed.
webgpu/whlsl-textures-load-expected.html: Removed.
webgpu/whlsl-textures-sample-expected.html: Removed.
webgpu/whlsl-while-loop-break-expected.html: Removed.
webgpu/whlsl-while-loop-continue-expected.html: Removed.
webgpu/whlsl-zero-initialize-values-2-expected.html: Removed.
webgpu/whlsl-zero-initialize-values-expected.html: Removed.
webgpu/whlsl/arbitrary-vertex-attribute-locations-expected.html: Copied from LayoutTests/webgpu/propertyresolver/ander-abstract-lvalue-expected.html.
webgpu/whlsl/arbitrary-vertex-attribute-locations.html: Renamed from LayoutTests/webgpu/whlsl-arbitrary-vertex-attribute-locations.html.
webgpu/whlsl/argument-evaluation-order-expected.txt: Renamed from LayoutTests/webgpu/whlsl-argument-evaluation-order-expected.txt.
webgpu/whlsl/argument-evaluation-order.html: Renamed from LayoutTests/webgpu/whlsl-argument-evaluation-order.html.
webgpu/whlsl/array-length-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-array-length-spec-tests-expected.txt.
webgpu/whlsl/array-length-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-array-length-spec-tests.html.
webgpu/whlsl/array-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-array-spec-tests-expected.txt.
webgpu/whlsl/array-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-array-spec-tests.html.
webgpu/whlsl/bad-add-expected.txt: Renamed from LayoutTests/webgpu/whlsl-bad-add-expected.txt.
webgpu/whlsl/bad-add.html: Renamed from LayoutTests/webgpu/whlsl-bad-add.html.
webgpu/whlsl/bad-ander-expected.txt: Renamed from LayoutTests/webgpu/whlsl-bad-ander-expected.txt.
webgpu/whlsl/bad-ander.html: Renamed from LayoutTests/webgpu/whlsl-bad-ander.html.
webgpu/whlsl/bad-literals-expected.txt: Renamed from LayoutTests/webgpu/whlsl-bad-literals-expected.txt.
webgpu/whlsl/bad-literals.html: Renamed from LayoutTests/webgpu/whlsl-bad-literals.html.
webgpu/whlsl/bitwise-bool-ops-expected.txt: Renamed from LayoutTests/webgpu/whlsl-bitwise-bool-ops-expected.txt.
webgpu/whlsl/bitwise-bool-ops.html: Renamed from LayoutTests/webgpu/whlsl-bitwise-bool-ops.html.
webgpu/whlsl/bools-expected.txt: Renamed from LayoutTests/webgpu/whlsl-bools-expected.txt.
webgpu/whlsl/bools.html: Renamed from LayoutTests/webgpu/whlsl-bools.html.
webgpu/whlsl/buffer-fragment-expected.html: Copied from LayoutTests/webgpu/propertyresolver/ander-expected.html.
webgpu/whlsl/buffer-fragment.html: Renamed from LayoutTests/webgpu/whlsl-buffer-fragment.html.
webgpu/whlsl/buffer-length-expected.txt: Renamed from LayoutTests/webgpu/whlsl-buffer-length-expected.txt.
webgpu/whlsl/buffer-length.html: Renamed from LayoutTests/webgpu/whlsl-buffer-length.html.
webgpu/whlsl/buffer-vertex-expected.html: Copied from LayoutTests/webgpu/propertyresolver/ander-lvalue-3-levels-expected.html.
webgpu/whlsl/buffer-vertex.html: Renamed from LayoutTests/webgpu/whlsl-buffer-vertex.html.
webgpu/whlsl/builtin-vectors-2-expected.txt: Renamed from LayoutTests/webgpu/whlsl-builtin-vectors-2-expected.txt.
webgpu/whlsl/builtin-vectors-2.html: Renamed from LayoutTests/webgpu/whlsl-builtin-vectors-2.html.
webgpu/whlsl/builtin-vectors-expected.txt: Renamed from LayoutTests/webgpu/whlsl-builtin-vectors-expected.txt.
webgpu/whlsl/builtin-vectors.html: Renamed from LayoutTests/webgpu/whlsl-builtin-vectors.html.
webgpu/whlsl/casts-expected.txt: Renamed from LayoutTests/webgpu/whlsl-casts-expected.txt.
webgpu/whlsl/casts.html: Renamed from LayoutTests/webgpu/whlsl-casts.html.
webgpu/whlsl/checker-should-set-type-of-read-modify-write-variables-expected.txt: Renamed from LayoutTests/webgpu/whlsl-checker-should-set-type-of-read-modify-write-variables-expected.txt.
webgpu/whlsl/checker-should-set-type-of-read-modify-write-variables.html: Renamed from LayoutTests/webgpu/whlsl-checker-should-set-type-of-read-modify-write-variables.html.
webgpu/whlsl/comment-parsing-expected.txt: Renamed from LayoutTests/webgpu/whlsl-comment-parsing-expected.txt.
webgpu/whlsl/comment-parsing.html: Renamed from LayoutTests/webgpu/whlsl-comment-parsing.html.
webgpu/whlsl/compute-expected.txt: Renamed from LayoutTests/webgpu/whlsl-compute-expected.txt.
webgpu/whlsl/compute.html: Renamed from LayoutTests/webgpu/whlsl-compute.html.
webgpu/whlsl/copy-expected.txt: Renamed from LayoutTests/webgpu/whlsl-copy-expected.txt.
webgpu/whlsl/copy.html: Renamed from LayoutTests/webgpu/whlsl-copy.html.
webgpu/whlsl/dereference-ordering-expected.txt: Renamed from LayoutTests/webgpu/whlsl-dereference-ordering-expected.txt.
webgpu/whlsl/dereference-ordering.html: Renamed from LayoutTests/webgpu/whlsl-dereference-ordering.html.
webgpu/whlsl/dereference-pointer-should-type-check-expected.html: Copied from LayoutTests/webgpu/propertyresolver/ander-lvalue-expected.html.
webgpu/whlsl/dereference-pointer-should-type-check.html: Renamed from LayoutTests/webgpu/whlsl-dereference-pointer-should-type-check.html.
webgpu/whlsl/do-while-loop-break-expected.html: Copied from LayoutTests/webgpu/whlsl-do-while-loop-break-expected.html.
webgpu/whlsl/do-while-loop-break.html: Renamed from LayoutTests/webgpu/whlsl-do-while-loop-break.html.
webgpu/whlsl/do-while-loop-continue-expected.html: Copied from LayoutTests/webgpu/propertyresolver/getter-expected.html.
webgpu/whlsl/do-while-loop-continue.html: Renamed from LayoutTests/webgpu/whlsl-do-while-loop-continue.html.
webgpu/whlsl/do-while-loop-expected.html: Copied from LayoutTests/webgpu/propertyresolver/indexer-ander-abstract-lvalue-expected.html.
webgpu/whlsl/do-while-loop.html: Renamed from LayoutTests/webgpu/whlsl-do-while-loop.html.
webgpu/whlsl/dont-crash-parsing-enum-expected.html: Copied from LayoutTests/webgpu/propertyresolver/indexer-ander-expected.html.
webgpu/whlsl/dont-crash-parsing-enum.html: Renamed from LayoutTests/webgpu/whlsl-dont-crash-parsing-enum.html.
webgpu/whlsl/dot-expressions-expected.html: Copied from LayoutTests/webgpu/propertyresolver/indexer-ander-lvalue-3-levels-expected.html.
webgpu/whlsl/dot-expressions.html: Renamed from LayoutTests/webgpu/whlsl-dot-expressions.html.
webgpu/whlsl/double-not-expected.txt: Renamed from LayoutTests/webgpu/whlsl-double-not-expected.txt.
webgpu/whlsl/double-not.html: Renamed from LayoutTests/webgpu/whlsl-double-not.html.
webgpu/whlsl/duplicate-types-should-not-produce-duplicate-ctors-expected.txt: Renamed from LayoutTests/webgpu/whlsl-duplicate-types-should-not-produce-duplicate-ctors-expected.txt.
webgpu/whlsl/duplicate-types-should-not-produce-duplicate-ctors.html: Renamed from LayoutTests/webgpu/whlsl-duplicate-types-should-not-produce-duplicate-ctors.html.
webgpu/whlsl/duplicates-expected.txt: Renamed from LayoutTests/webgpu/whlsl-duplicates-expected.txt.
webgpu/whlsl/duplicates.html: Renamed from LayoutTests/webgpu/whlsl-duplicates.html.
webgpu/whlsl/ensure-proper-variable-lifetime-2-expected.html: Copied from LayoutTests/webgpu/propertyresolver/indexer-ander-lvalue-expected.html.
webgpu/whlsl/ensure-proper-variable-lifetime-2.html: Renamed from LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-2.html.
webgpu/whlsl/ensure-proper-variable-lifetime-3-expected.html: Copied from LayoutTests/webgpu/propertyresolver/indexer-getter-expected.html.
webgpu/whlsl/ensure-proper-variable-lifetime-3.html: Renamed from LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-3.html.
webgpu/whlsl/ensure-proper-variable-lifetime-expected.html: Copied from LayoutTests/webgpu/propertyresolver/indexer-setter-abstract-lvalue-3-levels-expected.html.
webgpu/whlsl/ensure-proper-variable-lifetime.html: Renamed from LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime.html.
webgpu/whlsl/enum-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-enum-spec-tests-expected.txt.
webgpu/whlsl/enum-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-enum-spec-tests.html.
webgpu/whlsl/equality-expected.txt: Renamed from LayoutTests/webgpu/whlsl-equality-expected.txt.
webgpu/whlsl/equality.html: Renamed from LayoutTests/webgpu/whlsl-equality.html.
webgpu/whlsl/float-math-expected.txt: Renamed from LayoutTests/webgpu/whlsl-float-math-expected.txt.
webgpu/whlsl/float-math.html: Renamed from LayoutTests/webgpu/whlsl-float-math.html.
webgpu/whlsl/getter-setter-type-expected.txt: Renamed from LayoutTests/webgpu/whlsl-getter-setter-type-expected.txt.
webgpu/whlsl/getter-setter-type.html: Renamed from LayoutTests/webgpu/whlsl-getter-setter-type.html.
webgpu/whlsl/huge-array-expected.txt: Renamed from LayoutTests/webgpu/whlsl-huge-array-expected.txt.
webgpu/whlsl/huge-array.html: Renamed from LayoutTests/webgpu/whlsl-huge-array.html.
webgpu/whlsl/if-statement-expected.txt: Renamed from LayoutTests/webgpu/whlsl-if-statement-expected.txt.
webgpu/whlsl/if-statement.html: Renamed from LayoutTests/webgpu/whlsl-if-statement.html.
webgpu/whlsl/increment-decrement-expected.txt: Renamed from LayoutTests/webgpu/whlsl-increment-decrement-expected.txt.
webgpu/whlsl/increment-decrement.html: Renamed from LayoutTests/webgpu/whlsl-increment-decrement.html.
webgpu/whlsl/index-ander-expected.txt: Renamed from LayoutTests/webgpu/whlsl-index-ander-expected.txt.
webgpu/whlsl/index-ander.html: Renamed from LayoutTests/webgpu/whlsl-index-ander.html.
webgpu/whlsl/index-getter-setter-expected.txt: Renamed from LayoutTests/webgpu/whlsl-index-getter-setter-expected.txt.
webgpu/whlsl/index-getter-setter.html: Renamed from LayoutTests/webgpu/whlsl-index-getter-setter.html.
webgpu/whlsl/index-setter-getter-expected.txt: Renamed from LayoutTests/webgpu/whlsl-index-setter-getter-expected.txt.
webgpu/whlsl/index-setter-getter.html: Renamed from LayoutTests/webgpu/whlsl-index-setter-getter.html.
webgpu/whlsl/int-bit-math-expected.txt: Renamed from LayoutTests/webgpu/whlsl-int-bit-math-expected.txt.
webgpu/whlsl/int-bit-math.html: Renamed from LayoutTests/webgpu/whlsl-int-bit-math.html.
webgpu/whlsl/int-literal-compare-expected.txt: Renamed from LayoutTests/webgpu/whlsl-int-literal-compare-expected.txt.
webgpu/whlsl/int-literal-compare.html: Renamed from LayoutTests/webgpu/whlsl-int-literal-compare.html.
webgpu/whlsl/js/test-harness.js: Renamed from LayoutTests/webgpu/js/whlsl-test-harness.js.

(isScalar):
(convertTypeToArrayType):
(convertTypeToWHLSLType):
(whlslArgumentType):
(convertToWHLSLOutputType):
(convertToWHLSLInputType):
(WebGPUUnsupportedError):
(Data):
(Data.prototype.async.getArrayBuffer):
(Data.prototype.get type):
(Data.prototype.get isBuffer):
(Data.prototype.get buffer):
(Data.prototype.get byteLength):
(Harness):
(Harness.prototype.async.requestDevice):
(Harness.prototype.set isWHLSL):
(Harness.prototype.get isWHLSL):
(Harness.prototype.async.callTypedFunction):
(Harness.prototype.callVoidFunction):
(Harness.prototype.async.checkCompileFail):
(Harness.prototype.get device):
(Harness.prototype._clearResults):
(Harness.prototype._setUpArguments):
(Harness.prototype.async._callFunction):
(makeBool):
(makeInt):
(makeUchar):
(makeUint):
(makeFloat):
(makeFloat4):
(makeFloat4x4):
(processArrays):
(async.callBoolFunction):
(async.callIntFunction):
(async.callUcharFunction):
(async.callUintFunction):
(async.callFloatFunction):
(async.callFloat4Function):
(async.callFloat4x4Function):
(async.checkFail):
(callVoidFunction):
(const.webGPUPromiseTest):

webgpu/whlsl/logical-negation-expected.txt: Renamed from LayoutTests/webgpu/whlsl-logical-negation-expected.txt.
webgpu/whlsl/logical-negation.html: Renamed from LayoutTests/webgpu/whlsl-logical-negation.html.
webgpu/whlsl/loops-break-expected.html: Renamed from LayoutTests/webgpu/whlsl-loops-break-expected.html.
webgpu/whlsl/loops-break.html: Renamed from LayoutTests/webgpu/whlsl-loops-break.html.
webgpu/whlsl/loops-continue-expected.html: Copied from LayoutTests/webgpu/whlsl-nested-loop-expected.html.
webgpu/whlsl/loops-continue.html: Renamed from LayoutTests/webgpu/whlsl-loops-continue.html.
webgpu/whlsl/loops-expected.html: Copied from LayoutTests/webgpu/propertyresolver/indexer-setter-abstract-lvalue-expected.html.
webgpu/whlsl/loops-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-loops-spec-tests-expected.txt.
webgpu/whlsl/loops-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-loops-spec-tests.html.
webgpu/whlsl/loops.html: Renamed from LayoutTests/webgpu/whlsl-loops.html.
webgpu/whlsl/lots-of-local-variables-expected.txt: Renamed from LayoutTests/webgpu/whlsl-lots-of-local-variables-expected.txt.
webgpu/whlsl/lots-of-local-variables.html: Renamed from LayoutTests/webgpu/whlsl-lots-of-local-variables.html.
webgpu/whlsl/lvalues-expected.txt: Renamed from LayoutTests/webgpu/whlsl-lvalues-expected.txt.
webgpu/whlsl/lvalues.html: Renamed from LayoutTests/webgpu/whlsl-lvalues.html.
webgpu/whlsl/make-array-ref-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-make-array-ref-spec-tests-expected.txt.
webgpu/whlsl/make-array-ref-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-make-array-ref-spec-tests.html.
webgpu/whlsl/make-array-reference-expected.txt: Renamed from LayoutTests/webgpu/whlsl-make-array-reference-expected.txt.
webgpu/whlsl/make-array-reference.html: Renamed from LayoutTests/webgpu/whlsl-make-array-reference.html.
webgpu/whlsl/matrices-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-matrices-spec-tests-expected.txt.
webgpu/whlsl/matrices-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-matrices-spec-tests.html.
webgpu/whlsl/matrix-2-expected.txt: Renamed from LayoutTests/webgpu/whlsl-matrix-2-expected.txt.
webgpu/whlsl/matrix-2.html: Renamed from LayoutTests/webgpu/whlsl-matrix-2.html.
webgpu/whlsl/matrix-expected.txt: Renamed from LayoutTests/webgpu/whlsl-matrix-expected.txt.
webgpu/whlsl/matrix-memory-layout-expected.txt: Renamed from LayoutTests/webgpu/whlsl-matrix-memory-layout-expected.txt.
webgpu/whlsl/matrix-memory-layout.html: Renamed from LayoutTests/webgpu/whlsl-matrix-memory-layout.html.
webgpu/whlsl/matrix.html: Renamed from LayoutTests/webgpu/whlsl-matrix.html.
webgpu/whlsl/nested-dot-expression-rvalue-expected.html: Copied from LayoutTests/webgpu/propertyresolver/indexer-setter-expected.html.
webgpu/whlsl/nested-dot-expression-rvalue.html: Renamed from LayoutTests/webgpu/whlsl-nested-dot-expression-rvalue.html.
webgpu/whlsl/nested-loop-expected.html: Copied from LayoutTests/webgpu/whlsl-do-while-loop-break-expected.html.
webgpu/whlsl/nested-loop.html: Renamed from LayoutTests/webgpu/whlsl-nested-loop.html.
webgpu/whlsl/null-arg-expected.txt: Renamed from LayoutTests/webgpu/whlsl-null-arg-expected.txt.
webgpu/whlsl/null-arg.html: Renamed from LayoutTests/webgpu/whlsl-null-arg.html.
webgpu/whlsl/null-array-ref.html: Renamed from LayoutTests/webgpu/whlsl-null-array-ref.html.
webgpu/whlsl/null-dereference-expected.txt: Renamed from LayoutTests/webgpu/whlsl-null-dereference-expected.txt.
webgpu/whlsl/null-dereference.html: Renamed from LayoutTests/webgpu/whlsl-null-dereference.html.
webgpu/whlsl/oob-access-expected.txt: Renamed from LayoutTests/webgpu/whlsl-oob-access-expected.txt.
webgpu/whlsl/oob-access.html: Renamed from LayoutTests/webgpu/whlsl-oob-access.html.
webgpu/whlsl/operator-overload-expected.txt: Renamed from LayoutTests/webgpu/whlsl-operator-overload-expected.txt.
webgpu/whlsl/operator-overload.html: Renamed from LayoutTests/webgpu/whlsl-operator-overload.html.
webgpu/whlsl/overload-expected.txt: Renamed from LayoutTests/webgpu/whlsl-overload-expected.txt.
webgpu/whlsl/overload.html: Renamed from LayoutTests/webgpu/whlsl-overload.html.
webgpu/whlsl/override-subscript-expected.txt: Renamed from LayoutTests/webgpu/whlsl-override-subscript-expected.txt.
webgpu/whlsl/override-subscript.html: Renamed from LayoutTests/webgpu/whlsl-override-subscript.html.
webgpu/whlsl/plus-equals-expected.txt: Renamed from LayoutTests/webgpu/whlsl-plus-equals-expected.txt.
webgpu/whlsl/plus-equals.html: Renamed from LayoutTests/webgpu/whlsl-plus-equals.html.
webgpu/whlsl/pointer-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-pointer-spec-tests-expected.txt.
webgpu/whlsl/pointer-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-pointer-spec-tests.html.
webgpu/whlsl/postfix-prefix-expected.txt: Renamed from LayoutTests/webgpu/whlsl-postfix-prefix-expected.txt.
webgpu/whlsl/postfix-prefix.html: Renamed from LayoutTests/webgpu/whlsl-postfix-prefix.html.
webgpu/whlsl/propertyresolver/ander-abstract-lvalue-expected.html: Copied from LayoutTests/webgpu/propertyresolver/ander-abstract-lvalue-expected.html.
webgpu/whlsl/propertyresolver/ander-abstract-lvalue.html: Renamed from LayoutTests/webgpu/propertyresolver/ander-abstract-lvalue.html.
webgpu/whlsl/propertyresolver/ander-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/ander-expected.html.
webgpu/whlsl/propertyresolver/ander-lvalue-3-levels-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/ander-lvalue-3-levels-expected.html.
webgpu/whlsl/propertyresolver/ander-lvalue-3-levels.html: Renamed from LayoutTests/webgpu/propertyresolver/ander-lvalue-3-levels.html.
webgpu/whlsl/propertyresolver/ander-lvalue-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/ander-lvalue-expected.html.
webgpu/whlsl/propertyresolver/ander-lvalue.html: Renamed from LayoutTests/webgpu/propertyresolver/ander-lvalue.html.
webgpu/whlsl/propertyresolver/ander.html: Renamed from LayoutTests/webgpu/propertyresolver/ander.html.
webgpu/whlsl/propertyresolver/getter-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/getter-expected.html.
webgpu/whlsl/propertyresolver/getter.html: Renamed from LayoutTests/webgpu/propertyresolver/getter.html.
webgpu/whlsl/propertyresolver/indexer-ander-abstract-lvalue-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-ander-abstract-lvalue-expected.html.
webgpu/whlsl/propertyresolver/indexer-ander-abstract-lvalue.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-ander-abstract-lvalue.html.
webgpu/whlsl/propertyresolver/indexer-ander-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-ander-expected.html.
webgpu/whlsl/propertyresolver/indexer-ander-lvalue-3-levels-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-ander-lvalue-3-levels-expected.html.
webgpu/whlsl/propertyresolver/indexer-ander-lvalue-3-levels.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-ander-lvalue-3-levels.html.
webgpu/whlsl/propertyresolver/indexer-ander-lvalue-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-ander-lvalue-expected.html.
webgpu/whlsl/propertyresolver/indexer-ander-lvalue.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-ander-lvalue.html.
webgpu/whlsl/propertyresolver/indexer-ander.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-ander.html.
webgpu/whlsl/propertyresolver/indexer-getter-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-getter-expected.html.
webgpu/whlsl/propertyresolver/indexer-getter.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-getter.html.
webgpu/whlsl/propertyresolver/indexer-setter-abstract-lvalue-3-levels-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-setter-abstract-lvalue-3-levels-expected.html.
webgpu/whlsl/propertyresolver/indexer-setter-abstract-lvalue-3-levels.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-setter-abstract-lvalue-3-levels.html.
webgpu/whlsl/propertyresolver/indexer-setter-abstract-lvalue-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-setter-abstract-lvalue-expected.html.
webgpu/whlsl/propertyresolver/indexer-setter-abstract-lvalue.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-setter-abstract-lvalue.html.
webgpu/whlsl/propertyresolver/indexer-setter-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-setter-expected.html.
webgpu/whlsl/propertyresolver/indexer-setter-lvalue-expected.html: Copied from LayoutTests/webgpu/propertyresolver/indexer-setter-lvalue-expected.html.
webgpu/whlsl/propertyresolver/indexer-setter-lvalue.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-setter-lvalue.html.
webgpu/whlsl/propertyresolver/indexer-setter.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-setter.html.
webgpu/whlsl/propertyresolver/setter-abstract-lvalue-3-levels-expected.html: Copied from LayoutTests/webgpu/propertyresolver/setter-abstract-lvalue-3-levels-expected.html.
webgpu/whlsl/propertyresolver/setter-abstract-lvalue-3-levels.html: Renamed from LayoutTests/webgpu/propertyresolver/setter-abstract-lvalue-3-levels.html.
webgpu/whlsl/propertyresolver/setter-abstract-lvalue-expected.html: Copied from LayoutTests/webgpu/propertyresolver/setter-abstract-lvalue-expected.html.
webgpu/whlsl/propertyresolver/setter-abstract-lvalue.html: Renamed from LayoutTests/webgpu/propertyresolver/setter-abstract-lvalue.html.
webgpu/whlsl/propertyresolver/setter-lvalue-expected.html: Copied from LayoutTests/webgpu/propertyresolver/setter-lvalue-expected.html.
webgpu/whlsl/propertyresolver/setter-lvalue.html: Renamed from LayoutTests/webgpu/propertyresolver/setter-lvalue.html.
webgpu/whlsl/read-modify-write-expected.txt: Renamed from LayoutTests/webgpu/whlsl-read-modify-write-expected.txt.
webgpu/whlsl/read-modify-write-high-zombies-expected.txt: Renamed from LayoutTests/webgpu/whlsl-read-modify-write-high-zombies-expected.txt.
webgpu/whlsl/read-modify-write-high-zombies.html: Renamed from LayoutTests/webgpu/whlsl-read-modify-write-high-zombies.html.
webgpu/whlsl/read-modify-write.html: Renamed from LayoutTests/webgpu/whlsl-read-modify-write.html.
webgpu/whlsl/recursive-structs-expected.txt: Renamed from LayoutTests/webgpu/whlsl-recursive-structs-expected.txt.
webgpu/whlsl/recursive-structs.html: Renamed from LayoutTests/webgpu/whlsl-recursive-structs.html.
webgpu/whlsl/return-local-variable-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/indexer-setter-lvalue-expected.html.
webgpu/whlsl/return-local-variable.html: Renamed from LayoutTests/webgpu/whlsl-return-local-variable.html.
webgpu/whlsl/return-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-return-spec-tests-expected.txt.
webgpu/whlsl/return-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-return-spec-tests.html.
webgpu/whlsl/setter-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-setter-spec-tests-expected.txt.
webgpu/whlsl/setter-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-setter-spec-tests.html.
webgpu/whlsl/simple-arrays-expected.txt: Renamed from LayoutTests/webgpu/whlsl-simple-arrays-expected.txt.
webgpu/whlsl/simple-arrays.html: Renamed from LayoutTests/webgpu/whlsl-simple-arrays.html.
webgpu/whlsl/simple-getter-setter-expected.txt: Renamed from LayoutTests/webgpu/whlsl-simple-getter-setter-expected.txt.
webgpu/whlsl/simple-getter-setter.html: Renamed from LayoutTests/webgpu/whlsl-simple-getter-setter.html.
webgpu/whlsl/simple-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-simple-tests-expected.txt.
webgpu/whlsl/simple-tests.html: Renamed from LayoutTests/webgpu/whlsl-simple-tests.html.
webgpu/whlsl/simple-while-loop-expected.txt: Renamed from LayoutTests/webgpu/whlsl-simple-while-loop-expected.txt.
webgpu/whlsl/simple-while-loop.html: Renamed from LayoutTests/webgpu/whlsl-simple-while-loop.html.
webgpu/whlsl/store-null-expected.txt: Renamed from LayoutTests/webgpu/whlsl-store-null-expected.txt.
webgpu/whlsl/store-null.html: Renamed from LayoutTests/webgpu/whlsl-store-null.html.
webgpu/whlsl/store-to-property-updates-properly-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/setter-abstract-lvalue-3-levels-expected.html.
webgpu/whlsl/store-to-property-updates-properly.html: Renamed from LayoutTests/webgpu/whlsl-store-to-property-updates-properly.html.
webgpu/whlsl/struct-expected.txt: Renamed from LayoutTests/webgpu/whlsl-struct-expected.txt.
webgpu/whlsl/struct.html: Renamed from LayoutTests/webgpu/whlsl-struct.html.
webgpu/whlsl/switch-expected.txt: Renamed from LayoutTests/webgpu/whlsl-switch-expected.txt.
webgpu/whlsl/switch.html: Renamed from LayoutTests/webgpu/whlsl-switch.html.
webgpu/whlsl/ternary-spec-test-expected.txt: Renamed from LayoutTests/webgpu/whlsl-ternary-spec-test-expected.txt.
webgpu/whlsl/ternary-spec-test.html: Renamed from LayoutTests/webgpu/whlsl-ternary-spec-test.html.
webgpu/whlsl/test-harness-test-expected.txt: Renamed from LayoutTests/webgpu/whlsl-test-harness-test-expected.txt.
webgpu/whlsl/test-harness-test.html: Renamed from LayoutTests/webgpu/whlsl-test-harness-test.html.
webgpu/whlsl/textures-getdimensions-expected.txt: Renamed from LayoutTests/webgpu/whlsl-textures-getdimensions-expected.txt.
webgpu/whlsl/textures-getdimensions.html: Renamed from LayoutTests/webgpu/whlsl-textures-getdimensions.html.
webgpu/whlsl/textures-load-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/setter-abstract-lvalue-expected.html.
webgpu/whlsl/textures-load.html: Renamed from LayoutTests/webgpu/whlsl-textures-load.html.
webgpu/whlsl/textures-sample-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/setter-lvalue-expected.html.
webgpu/whlsl/textures-sample.html: Renamed from LayoutTests/webgpu/whlsl-textures-sample.html.
webgpu/whlsl/two-dimensional-array-expected.txt: Renamed from LayoutTests/webgpu/whlsl-two-dimensional-array-expected.txt.
webgpu/whlsl/two-dimensional-array.html: Renamed from LayoutTests/webgpu/whlsl-two-dimensional-array.html.
webgpu/whlsl/type-mismatch-expected.txt: Renamed from LayoutTests/webgpu/whlsl-type-mismatch-expected.txt.
webgpu/whlsl/type-mismatch.html: Renamed from LayoutTests/webgpu/whlsl-type-mismatch.html.
webgpu/whlsl/uint-bitwise-expected.txt: Renamed from LayoutTests/webgpu/whlsl-uint-bitwise-expected.txt.
webgpu/whlsl/uint-bitwise.html: Renamed from LayoutTests/webgpu/whlsl-uint-bitwise.html.
webgpu/whlsl/use-undefined-variable-2-expected.txt: Renamed from LayoutTests/webgpu/whlsl-use-undefined-variable-2-expected.txt.
webgpu/whlsl/use-undefined-variable-2.html: Renamed from LayoutTests/webgpu/whlsl-use-undefined-variable-2.html.
webgpu/whlsl/use-undefined-variable-expected.txt: Renamed from LayoutTests/webgpu/whlsl-use-undefined-variable-expected.txt.
webgpu/whlsl/use-undefined-variable.html: Renamed from LayoutTests/webgpu/whlsl-use-undefined-variable.html.
webgpu/whlsl/variable-shadowing-expected.txt: Renamed from LayoutTests/webgpu/whlsl-variable-shadowing-expected.txt.
webgpu/whlsl/variable-shadowing.html: Renamed from LayoutTests/webgpu/whlsl-variable-shadowing.html.
webgpu/whlsl/vector-syntax-expected.txt: Renamed from LayoutTests/webgpu/whlsl-vector-syntax-expected.txt.
webgpu/whlsl/vector-syntax.html: Renamed from LayoutTests/webgpu/whlsl-vector-syntax.html.
webgpu/whlsl/while-loop-break-expected.html: Renamed from LayoutTests/webgpu/whlsl-do-while-loop-break-expected.html.
webgpu/whlsl/while-loop-break.html: Renamed from LayoutTests/webgpu/whlsl-while-loop-break.html.
webgpu/whlsl/while-loop-continue-expected.html: Copied from LayoutTests/webgpu/propertyresolver/ander-abstract-lvalue-expected.html.
webgpu/whlsl/while-loop-continue.html: Renamed from LayoutTests/webgpu/whlsl-while-loop-continue.html.
webgpu/whlsl/whlsl-expected.html: Renamed from LayoutTests/webgpu/propertyresolver/ander-abstract-lvalue-expected.html.
webgpu/whlsl/whlsl.html: Renamed from LayoutTests/webgpu/whlsl.html.
webgpu/whlsl/wrong-argument-length-expected.txt: Renamed from LayoutTests/webgpu/whlsl-wrong-argument-length-expected.txt.
webgpu/whlsl/wrong-argument-length.html: Renamed from LayoutTests/webgpu/whlsl-wrong-argument-length.html.
webgpu/whlsl/wrong-types-expected.txt: Renamed from LayoutTests/webgpu/whlsl-wrong-types-expected.txt.
webgpu/whlsl/wrong-types.html: Renamed from LayoutTests/webgpu/whlsl-wrong-types.html.
webgpu/whlsl/zero-initialize-values-2-expected.html: Renamed from LayoutTests/webgpu/whlsl-nested-loop-expected.html.
webgpu/whlsl/zero-initialize-values-2.html: Renamed from LayoutTests/webgpu/whlsl-zero-initialize-values-2.html.
webgpu/whlsl/zero-initialize-values-expected.html: Renamed from LayoutTests/webgpu/whlsl-loops-continue-expected.html.
webgpu/whlsl/zero-initialize-values.html: Renamed from LayoutTests/webgpu/whlsl-zero-initialize-values.html.

11:58 AM Changeset in webkit [247527] by commit-queue@webkit.org

32 edits
3 adds in trunk

Add a runtime-disabled dialog element skeleton
https://bugs.webkit.org/show_bug.cgi?id=199839

Patch by Alex Christensen <achristensen@webkit.org> on 2019-07-17
Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

web-platform-tests/custom-elements/builtin-coverage-expected.txt:
web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
web-platform-tests/html/dom/reflection-misc-expected.txt:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-expected.txt:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open-expected.txt:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt:
web-platform-tests/html/semantics/interfaces-expected.txt:

Source/WebCore:

Beginning implementation of https://html.spec.whatwg.org/multipage/interactive-elements.html#the-dialog-element
Covered by rebaselining WPT tests.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
html/HTMLDialogElement.cpp: Added.

(WebCore::HTMLDialogElement::HTMLDialogElement):
(WebCore::HTMLDialogElement::open):
(WebCore::HTMLDialogElement::setOpen):
(WebCore::HTMLDialogElement::returnValue):
(WebCore::HTMLDialogElement::setReturnValue):
(WebCore::HTMLDialogElement::show):
(WebCore::HTMLDialogElement::showModal):
(WebCore::HTMLDialogElement::close):

html/HTMLDialogElement.h: Added.
html/HTMLDialogElement.idl: Added.
html/HTMLTagNames.in:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled):
(WebCore::RuntimeEnabledFeatures::dialogElementEnabled const):

Source/WebKit:

Shared/WebPreferences.yaml:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDialogElementEnabled):
(WKPreferencesGetDialogElementEnabled):

UIProcess/API/C/WKPreferencesRefPrivate.h:

Add SPI to enable the dialog element for tests.

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences dialogElementEnabled]):
(-[WebPreferences setDialogElementEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Add SPI to enable the dialog element for tests.

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
Enable the dialog element for layout tests.

11:35 AM Changeset in webkit [247526] by youenn@apple.com

2 edits in trunk/Source/ThirdParty/libwebrtc

Use VCP SPI in case creation of a compression session with VTB for 'h264.rtvc' fails
https://bugs.webkit.org/show_bug.cgi?id=199863
<rdar://problem/52922217>

Reviewed by Darin Adler.

Calling VTCompressionSessionCreate with kVTVideoEncoderList_EncoderID "com.apple.videotoolbox.videoencoder.h264.rtvc"
fails on some platforms. In such a case, use VCP SPI if available as a fallback.
Covered by exisiting webrtc tests on these specific platforms.

Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

(-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):

11:32 AM Changeset in webkit [247525] by youenn@apple.com

2 edits in trunk/Source/WebCore

Hop to the main thread when doing logging in RealtimeIncomingVideoSourceCocoa
https://bugs.webkit.org/show_bug.cgi?id=199865

Reviewed by Darin Adler.

LoggerHelper routines allow logging messages in system console and inspector console.
These routines iterate through a Vector of log observers which is not thread safe.
Document, the main log observer, also expects to be called on the main thread.
Manually tested (writing a layout test for this would require more than 2 seconds).

platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:

(WebCore::RealtimeIncomingVideoSourceCocoa::OnFrame):

11:23 AM Changeset in webkit [247524] by rniwa@webkit.org

5 edits
2 adds in trunk

[iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=199851

Reviewed by Wenson Hsieh.

Source/WebKit:

The bug was caused by the difference in the way AppKit and UIKit responds to Option + Up / Down.

On macOS, AppKit sends moveForward before sending moveToStartOfParagraph and moveBackward
before sending moveToEndOfParagraph. As a result, when Option + Down is pressed when we are at
the end of a line, we would first move to the beginning of the next line (i.e. after the line break)
before moving or extending selection with the paragraph boundary granurality.

On iOS, UIKit only calls _moveToStartOfParagraph without moving forward by a character. As a result,
moving forward by the paragraph boundary granurality immediately stops when we're starting at the
end of a line when Option + Down is pressed. Option + Up case is similar.

Fix the bug on iOS by emulating what happens on macOS. Namely, move the selection forward or backward
by the character granurality before moving by the paragraph boundary granurality.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _moveToStartOfParagraph:withHistory:]):
(-[WKContentView _moveToEndOfParagraph:withHistory:]):

Tools:

Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
this code is getting directly triggered from UIKeyboard's code.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
TestWebKitAPI/ios/UIKitSPI.h:

11:12 AM Changeset in webkit [247523] by commit-queue@webkit.org

23 edits in trunk

Unreviewed, rolling out r247505.
https://bugs.webkit.org/show_bug.cgi?id=199871

"Caused failed ASSERT in stress test" (Requested by creid on
#webkit).

Reverted changeset:

"Bytecode cache should use FileSystem"
https://bugs.webkit.org/show_bug.cgi?id=199759
https://trac.webkit.org/changeset/247505

11:11 AM Changeset in webkit [247522] by youenn@apple.com

9 edits in trunk/Source/WebCore

Add release logging to AudioSampleDataSource
https://bugs.webkit.org/show_bug.cgi?id=199814
<rdar://problem/53128140>

Reviewed by Eric Carlson.

Use release logging for AudioSampleDataSource in case of errors.
This requires passing a logger and a logger identifier.
For that purpose, pass a MediaStreamTrackPrivate to it constructor
and reuse its logger and log identifier.

For each log, hop to the main thread as release logging requires to be done in the main thread.
Add specific handling for RealtimeOutgoingAudioSource as its MediaStreamTrack can change in case of replaceTrack.
In that case, we change of logger when changing the MediaStreamTrackPrivate.

No observable change of behavior, covered by existing tests.

platform/audio/mac/AudioSampleDataSource.h:
platform/audio/mac/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::create):
(WebCore::AudioSampleDataSource::AudioSampleDataSource):
(WebCore::AudioSampleDataSource::setupConverter):
(WebCore::AudioSampleDataSource::pushSamplesInternal):
(WebCore::AudioSampleDataSource::pullSamplesInternal):
(WebCore::AudioSampleDataSource::setLogger):
(WebCore::AudioSampleDataSource::logChannel const):

platform/mediastream/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::setSource):

platform/mediastream/RealtimeOutgoingAudioSource.h:

(WebCore::RealtimeOutgoingAudioSource::sourceUpdated):

platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:

(WebCore::AudioTrackPrivateMediaStreamCocoa::audioSamplesAvailable):

platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.h:

Instead of using its own logger/identifier member field, reuse its MediaStreamTrackPrivate.

platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:

(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):
(WebCore::RealtimeOutgoingAudioSourceCocoa::sourceUpdated):

platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:
platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::prepare):

10:50 AM Changeset in webkit [247521] by commit-queue@webkit.org

13 edits in trunk/Source

Make ANGLE work inside WebKit2's sandbox
https://bugs.webkit.org/show_bug.cgi?id=199844

Patch by Kenneth Russell <kbr@chromium.org> on 2019-07-17
Reviewed by Alex Christensen.

Source/ThirdParty/ANGLE:

Cherry-pick fix for crbug.com/angleproject/3383 to eliminate use
of deprecated API in SystemInfo_mac.mm.

BUILD.gn:
src/gpu_info_util/SystemInfo.cpp:

(angle::FindActiveGPU):
(angle::PrintSystemInfo):
(angle::FindPrimaryGPU): Deleted.

src/gpu_info_util/SystemInfo.h:
src/gpu_info_util/SystemInfo_internal.h:
src/gpu_info_util/SystemInfo_linux.cpp:

(angle::GetSystemInfo):

src/gpu_info_util/SystemInfo_mac.mm:

(angle::GetSystemInfo):

src/gpu_info_util/SystemInfo_win.cpp:

(angle::GetSystemInfo):

src/tests/BUILD.gn:
src/tests/test_expectations/GPUTestConfig.cpp:
src/tests/test_utils/angle_test_instantiate.cpp:

(angle::IsConfigWhitelisted):

Source/WebCore:

Fix missing #import introduced at the last minute while removing
some debugging code in the last patch.

Tested with San Angeles WebGL demo and some conformance tests.

platform/graphics/cocoa/WebGLLayer.mm:

10:09 AM Changeset in webkit [247520] by Kocsen Chung

7 edits in branches/safari-608-branch/Source

Versioning.

10:05 AM Changeset in webkit [247519] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Hang in WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
https://bugs.webkit.org/show_bug.cgi?id=199845
<rdar://problem/53121017>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-07-17
Reviewed by Chris Fleizach.

Added check for upper bound NSNotFound for parameter to visiblePositionRangeForLine.
Fixed signed/unsigned issue for AXTextMarkerRangeForLine attribute.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine const):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

10:03 AM Changeset in webkit [247518] by Kocsen Chung

1 copy in branches/safari-608-branch

New branch.

9:59 AM Changeset in webkit [247517] by Kocsen Chung

7 edits in trunk/Source

Versioning.

9:29 AM Changeset in webkit [247516] by russell_e@apple.com

2 edits in trunk/Tools

Adding self to contributors.json

Unreviewed.

Scripts/webkitpy/common/config/contributors.json:

9:11 AM Changeset in webkit [247515] by aakash_jain@apple.com

3 edits
1 add in trunk/Tools

[ews-build] Parse full_results.json for layout-tests
https://bugs.webkit.org/show_bug.cgi?id=199804

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/steps.py:

(RunWebKitTests.start): Monitor json output.
(RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
by the patch or are pre-existing.
(ReRunWebKitTests.commandComplete): Ditto.
(RunWebKitTestsWithoutPatch.commandComplete): Ditto.

BuildSlaveSupport/ews-build/steps_unittest.py:

(BuildStepMixinAdditions.getProperty): Added.
(TestRunWebKitTests.test_parse_results_json): Added unit-tests.

BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.

8:44 AM Changeset in webkit [247514] by Michael Catanzaro

9 edits in trunk/Tools

Unreviewed, rolling out r247512.

Broke API test runners

Reverted changeset:

"[GTK][WPE][webkitpy] Refactor drivers to use the base driver
for setting up the environment and start the drivers."
https://bugs.webkit.org/show_bug.cgi?id=199855
https://trac.webkit.org/changeset/247512

7:57 AM Changeset in webkit [247513] by Truitt Savell

3 edits
203 copies
1 delete in trunk/LayoutTests

Unreviewed, rolling out r247501.

Introduced 100 failures on Mojave WK2.

Reverted changeset:

"[WHLSL] Move WHLSL tests to their own folder"
https://bugs.webkit.org/show_bug.cgi?id=199838
https://trac.webkit.org/changeset/247501

6:00 AM Changeset in webkit [247512] by clopez@igalia.com

9 edits in trunk/Tools

[GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
https://bugs.webkit.org/show_bug.cgi?id=199855

Reviewed by Carlos Garcia Campos.

Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.

Scripts/webkitpy/port/headlessdriver.py:

(HeadlessDriver._setup_environ_for_test):

Scripts/webkitpy/port/waylanddriver.py:

(WaylandDriver._setup_environ_for_test):

Scripts/webkitpy/port/westondriver.py:

(WestonDriver._setup_environ_for_test):
(WestonDriver.stop):

Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.

(WestonDriverTest.make_driver):

Scripts/webkitpy/port/xorgdriver.py:

(XorgDriver._setup_environ_for_test):

Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env

(XvfbDriver._setup_environ_for_test):

Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.

(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start):
(XvfbDriverTest.test_start_arbitrary_worker_number):

5:49 AM WebKitGTK/2.24.x edited by berto@igalia.com

(diff)

4:09 AM Changeset in webkit [247511] by Fujii Hironori

3 edits in trunk/LayoutTests

Unreviewed test gardening for WinCairo port

platform/wincairo-wk1/TestExpectations:
platform/wincairo/TestExpectations:

3:16 AM Changeset in webkit [247510] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

Unreviewed. Fix GTK and WPE debug build after r247508

UIProcess/API/glib/WebKitWebResource.cpp:

(webkitWebResourceCreate): Remove invalid assert.

3:06 AM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

2:03 AM Changeset in webkit [247509] by commit-queue@webkit.org

25 edits
58 adds in trunk

Add referrerpolicy attribute support for <script> elements
https://bugs.webkit.org/show_bug.cgi?id=185550

Patch by Rob Buis <rbuis@igalia.com> on 2019-07-17
Reviewed by Youenn Fablet.

Source/WebCore:

This patch adds 'referrerpolicy' attribute support for script elements.
If set, the value is restricted to the ReferrerPolicy enum, and
if valid it is used for the script fetch.
If not set or invalid, the current behavior is kept.

Tests: http/tests/referrer-policy-script/no-referrer-when-downgrade/cross-origin-http-http.html

http/tests/referrer-policy-script/no-referrer-when-downgrade/cross-origin-http.https.html
http/tests/referrer-policy-script/no-referrer-when-downgrade/same-origin.html
http/tests/referrer-policy-script/no-referrer/cross-origin-http-http.html
http/tests/referrer-policy-script/no-referrer/cross-origin-http.https.html
http/tests/referrer-policy-script/no-referrer/same-origin.html
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http-http.html
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/origin-when-cross-origin/same-origin.html
http/tests/referrer-policy-script/origin/cross-origin-http-http.html
http/tests/referrer-policy-script/origin/cross-origin-http.https.html
http/tests/referrer-policy-script/origin/same-origin.html
http/tests/referrer-policy-script/same-origin/cross-origin-http-http.html
http/tests/referrer-policy-script/same-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/same-origin/same-origin.html
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http-http.html
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin-when-cross-origin/same-origin.html
http/tests/referrer-policy-script/strict-origin/cross-origin-http-http.html
http/tests/referrer-policy-script/strict-origin/cross-origin-http.https.html
http/tests/referrer-policy-script/strict-origin/same-origin.html
http/tests/referrer-policy-script/unsafe-url/cross-origin-http-http.html
http/tests/referrer-policy-script/unsafe-url/cross-origin-http.https.html
http/tests/referrer-policy-script/unsafe-url/same-origin.html

bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestScriptWithCache const):

bindings/js/CachedScriptFetcher.h:

(WebCore::CachedScriptFetcher::CachedScriptFetcher):

dom/InlineClassicScript.h:
dom/LoadableClassicScript.cpp:

(WebCore::LoadableClassicScript::create):

dom/LoadableClassicScript.h:
dom/LoadableModuleScript.cpp:

(WebCore::LoadableModuleScript::create):
(WebCore::LoadableModuleScript::LoadableModuleScript):

dom/LoadableModuleScript.h:
dom/LoadableScript.h:

(WebCore::LoadableScript::LoadableScript):

dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestClassicScript):
(WebCore::ScriptElement::requestModuleScript):

dom/ScriptElement.h:
dom/ScriptElementCachedScriptFetcher.h:

(WebCore::ScriptElementCachedScriptFetcher::ScriptElementCachedScriptFetcher):

html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::referrerPolicyForBindings const):

html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setReferrerPolicyForBindings):
(WebCore::HTMLScriptElement::referrerPolicyForBindings const):
(WebCore::HTMLScriptElement::referrerPolicy const):

html/HTMLScriptElement.h:
html/HTMLScriptElement.idl:
html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::emitRule):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

html/parser/HTMLResourcePreloader.cpp:

(WebCore::PreloadRequest::resourceRequest):

html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::PreloadRequest):

platform/ReferrerPolicy.cpp:

(WebCore::referrerPolicyToString):

platform/ReferrerPolicy.h:
svg/SVGScriptElement.h:

LayoutTests:

Add tests for scripts with various referrerpolicy attribute values.

http/tests/referrer-policy-script/no-referrer-when-downgrade/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy-script/no-referrer-when-downgrade/cross-origin-http-http.html: Added.
http/tests/referrer-policy-script/no-referrer-when-downgrade/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy-script/no-referrer-when-downgrade/cross-origin-http.https.html: Added.
http/tests/referrer-policy-script/no-referrer-when-downgrade/same-origin-expected.txt: Added.
http/tests/referrer-policy-script/no-referrer-when-downgrade/same-origin.html: Added.
http/tests/referrer-policy-script/no-referrer/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy-script/no-referrer/cross-origin-http-http.html: Added.
http/tests/referrer-policy-script/no-referrer/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy-script/no-referrer/cross-origin-http.https.html: Added.
http/tests/referrer-policy-script/no-referrer/same-origin-expected.txt: Added.
http/tests/referrer-policy-script/no-referrer/same-origin.html: Added.
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http-http.html: Added.
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy-script/origin-when-cross-origin/cross-origin-http.https.html: Added.
http/tests/referrer-policy-script/origin-when-cross-origin/same-origin-expected.txt: Added.
http/tests/referrer-policy-script/origin-when-cross-origin/same-origin.html: Added.
http/tests/referrer-policy-script/origin/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy-script/origin/cross-origin-http-http.html: Added.
http/tests/referrer-policy-script/origin/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy-script/origin/cross-origin-http.https.html: Added.
http/tests/referrer-policy-script/origin/same-origin-expected.txt: Added.
http/tests/referrer-policy-script/origin/same-origin.html: Added.
http/tests/referrer-policy-script/same-origin/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy-script/same-origin/cross-origin-http-http.html: Added.
http/tests/referrer-policy-script/same-origin/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy-script/same-origin/cross-origin-http.https.html: Added.
http/tests/referrer-policy-script/same-origin/same-origin-expected.txt: Added.
http/tests/referrer-policy-script/same-origin/same-origin.html: Added.
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http-http.html: Added.
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy-script/strict-origin-when-cross-origin/cross-origin-http.https.html: Added.
http/tests/referrer-policy-script/strict-origin-when-cross-origin/same-origin-expected.txt: Added.
http/tests/referrer-policy-script/strict-origin-when-cross-origin/same-origin.html: Added.
http/tests/referrer-policy-script/strict-origin/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy-script/strict-origin/cross-origin-http-http.html: Added.
http/tests/referrer-policy-script/strict-origin/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy-script/strict-origin/cross-origin-http.https.html: Added.
http/tests/referrer-policy-script/strict-origin/same-origin-expected.txt: Added.
http/tests/referrer-policy-script/strict-origin/same-origin.html: Added.
http/tests/referrer-policy-script/unsafe-url/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy-script/unsafe-url/cross-origin-http-http.html: Added.
http/tests/referrer-policy-script/unsafe-url/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy-script/unsafe-url/cross-origin-http.https.html: Added.
http/tests/referrer-policy-script/unsafe-url/same-origin-expected.txt: Added.
http/tests/referrer-policy-script/unsafe-url/same-origin.html: Added.
http/tests/referrer-policy/resources/script.php: Added.
platform/win/TestExpectations:

1:25 AM Changeset in webkit [247508] by Carlos Garcia Campos

6 edits in trunk/Source/WebKit

[WPE][GTK] UI process crash due to NULL dereference in webkitWebViewResourceLoadStarted()
https://bugs.webkit.org/show_bug.cgi?id=199621

Reviewed by Michael Catanzaro.

Null-check frame received in injected bundle message to ensure the frame hasn't been destroyed.

UIProcess/API/glib/WebKitInjectedBundleClient.cpp:
UIProcess/API/glib/WebKitWebResource.cpp:

(webkitWebResourceCreate): Receive a reference to the frame instead of a pointer.

UIProcess/API/glib/WebKitWebResourcePrivate.h:
UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewResourceLoadStarted): Ditto.

UIProcess/API/glib/WebKitWebViewPrivate.h:

1:23 AM Changeset in webkit [247507] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

[GTK][WPE] Do not assert when receiving invalid data in injected bundle messages
https://bugs.webkit.org/show_bug.cgi?id=199830

Reviewed by Michael Catanzaro.

Just silently ignore them to avoid UI process crashes.

UIProcess/API/glib/WebKitInjectedBundleClient.cpp:

1:21 AM Changeset in webkit [247506] by Carlos Garcia Campos

3 edits in trunk/Source/WebKit

[GTK] No web view updates after swapping web process if AC mode is forced
https://bugs.webkit.org/show_bug.cgi?id=199826

Reviewed by Michael Catanzaro.

This is because when AC mode is forced the provisional page creates a drawing area that is always in AC
mode. When swapping processes, the current drawing area is destroyed (which exists AC mode) and the provisional
one is set. From that point the web process is in AC mode but the UI process isn't. We need to update the
compositing mode when swapping processes.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDidExitWebProcess):

UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h:

Jul 16, 2019:

10:21 PM Changeset in webkit [247505] by chris.reid@sony.com

23 edits in trunk

Bytecode cache should use FileSystem
https://bugs.webkit.org/show_bug.cgi?id=199759

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

Update bytecode cache to use platform generic FileSystem calls.

API/JSScript.mm:
CMakeLists.txt:
jsc.cpp:
runtime/CachePayload.cpp:
runtime/CachePayload.h:
runtime/CachedBytecode.h:
runtime/CachedTypes.cpp:
runtime/CachedTypes.h:
runtime/CodeCache.cpp:
runtime/CodeCache.h:
runtime/Completion.cpp:
runtime/Completion.h:

Source/WebCore:

platform/SharedBuffer.cpp:

Source/WTF:

wtf/FileSystem.cpp:
wtf/FileSystem.h:

Add support for creating MappedFileData from a preexisting file handle
for use with locked files. Also support creating MappedFileData
with either private or shared mappings.

wtf/UUID.cpp:

Avoid ASSERT with returning a LazyNeverDestroyed object that hasn't been created.

wtf/glib/FileSystemGlib.cpp:
wtf/win/FileSystemWin.cpp:

Add truncateFile implementations.

Tools:

TestWebKitAPI/Tests/WTF/FileSystem.cpp:

9:56 PM Changeset in webkit [247504] by Simon Fraser

3 edits in trunk/Source/WebCore

Fix includes and make a constructor explicit to avoid unified-sources-triggered test failures
https://bugs.webkit.org/show_bug.cgi?id=199849

Reviewed by Wenson Hsieh.

webkit.org/b/199587 triggered some unexpected test failures because of unified sources include
order. The TextStream operator in ScrollingTreeOverflowScrollingNode::dumpProperties() was invoking
the implicit constructor of TransformOperations.

page/scrolling/ScrollingTreeOverflowScrollingNode.cpp: Include TextStream.h
platform/graphics/transforms/TransformOperations.h: Make ctor explicit.

9:16 PM Changeset in webkit [247503] by Jonathan Bedard

2 edits in trunk/Tools

svn-create-patch duplicates diffs when adding directories
https://bugs.webkit.org/show_bug.cgi?id=199842

Reviewed by Dewei Zhu.

Scripts/svn-create-patch:

(findKind): Add function which returns what 'kind' of file the provided path is.
(generateFileList): If the path is a directory and being added, don't add it.
Instead, rely on the fact that its children will be added.

7:46 PM Changeset in webkit [247502] by commit-queue@webkit.org

7 edits
1 move in trunk/Source

REGRESSION: fast/events/watchos/double-tap-to-zoom* tests crashing in com.apple.WebKit: -[WKContentView(WKInteraction) _singleTapDidReset:]
https://bugs.webkit.org/show_bug.cgi?id=199840
<rdar://problem/52856531>

Patch by Antoine Quint <Antoine Quint> on 2019-07-16
Reviewed by Wenson Hsieh.

Source/WebCore:

Fix a build error that occured when building for the watchOS Simulator in the debug configuration.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingProxyRole):

Source/WebKit:

We need to ensure the NSNumber used for -[WKSyntheticTapGestureRecognizer lastActiveTouchIdentifier] is retained. This innocent change required
the use of RetainPtr<>, which required the move to an Objective-C++ file, which lead to a change in the order files are unified, which lead to
build errors, which leads to a much bigger patch than just the source change necessary to fix the crash.

SourcesCocoa.txt:
UIProcess/ios/WKSyntheticTapGestureRecognizer.mm: Renamed from Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.m.
UIProcess/ios/forms/WKFormPeripheralBase.h:
UIProcess/ios/forms/WKFormPeripheralBase.mm:
WebKit.xcodeproj/project.pbxproj:

5:13 PM Changeset in webkit [247501] by mmaxfield@apple.com

3 edits
203 moves
1 add in trunk/LayoutTests

[WHLSL] Move WHLSL tests to their own folder
https://bugs.webkit.org/show_bug.cgi?id=199838

Reviewed by Robin Morisset.

webgpu/whlsl-foo.html => webgpu/whlsl/foo.html

TestExpectations:
platform/mac-wk2/TestExpectations:
webgpu/whlsl/arbitrary-vertex-attribute-locations-expected.html: Renamed from LayoutTests/webgpu/whlsl-while-loop-continue-expected.html.
webgpu/whlsl/arbitrary-vertex-attribute-locations.html: Renamed from LayoutTests/webgpu/whlsl-arbitrary-vertex-attribute-locations.html.
webgpu/whlsl/argument-evaluation-order-expected.txt: Renamed from LayoutTests/webgpu/whlsl-argument-evaluation-order-expected.txt.
webgpu/whlsl/argument-evaluation-order.html: Renamed from LayoutTests/webgpu/whlsl-argument-evaluation-order.html.
webgpu/whlsl/array-length-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-array-length-spec-tests-expected.txt.
webgpu/whlsl/array-length-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-array-length-spec-tests.html.
webgpu/whlsl/array-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-array-spec-tests-expected.txt.
webgpu/whlsl/array-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-array-spec-tests.html.
webgpu/whlsl/bad-add-expected.txt: Renamed from LayoutTests/webgpu/whlsl-bad-add-expected.txt.
webgpu/whlsl/bad-add.html: Renamed from LayoutTests/webgpu/whlsl-bad-add.html.
webgpu/whlsl/bad-ander-expected.txt: Renamed from LayoutTests/webgpu/whlsl-bad-ander-expected.txt.
webgpu/whlsl/bad-ander.html: Renamed from LayoutTests/webgpu/whlsl-bad-ander.html.
webgpu/whlsl/bad-literals-expected.txt: Renamed from LayoutTests/webgpu/whlsl-bad-literals-expected.txt.
webgpu/whlsl/bad-literals.html: Renamed from LayoutTests/webgpu/whlsl-bad-literals.html.
webgpu/whlsl/bitwise-bool-ops-expected.txt: Renamed from LayoutTests/webgpu/whlsl-bitwise-bool-ops-expected.txt.
webgpu/whlsl/bitwise-bool-ops.html: Renamed from LayoutTests/webgpu/whlsl-bitwise-bool-ops.html.
webgpu/whlsl/bools-expected.txt: Renamed from LayoutTests/webgpu/whlsl-bools-expected.txt.
webgpu/whlsl/bools.html: Renamed from LayoutTests/webgpu/whlsl-bools.html.
webgpu/whlsl/buffer-fragment-expected.html: Renamed from LayoutTests/webgpu/whlsl-textures-sample-expected.html.
webgpu/whlsl/buffer-fragment.html: Renamed from LayoutTests/webgpu/whlsl-buffer-fragment.html.
webgpu/whlsl/buffer-length-expected.txt: Renamed from LayoutTests/webgpu/whlsl-use-undefined-variable-expected.txt.
webgpu/whlsl/buffer-length.html: Renamed from LayoutTests/webgpu/whlsl-buffer-length.html.
webgpu/whlsl/buffer-vertex-expected.html: Renamed from LayoutTests/webgpu/whlsl-textures-load-expected.html.
webgpu/whlsl/buffer-vertex.html: Renamed from LayoutTests/webgpu/whlsl-buffer-vertex.html.
webgpu/whlsl/builtin-vectors-2-expected.txt: Renamed from LayoutTests/webgpu/whlsl-builtin-vectors-2-expected.txt.
webgpu/whlsl/builtin-vectors-2.html: Renamed from LayoutTests/webgpu/whlsl-builtin-vectors-2.html.
webgpu/whlsl/builtin-vectors-expected.txt: Renamed from LayoutTests/webgpu/whlsl-builtin-vectors-expected.txt.
webgpu/whlsl/builtin-vectors.html: Renamed from LayoutTests/webgpu/whlsl-builtin-vectors.html.
webgpu/whlsl/casts-expected.txt: Renamed from LayoutTests/webgpu/whlsl-casts-expected.txt.
webgpu/whlsl/casts.html: Renamed from LayoutTests/webgpu/whlsl-casts.html.
webgpu/whlsl/checker-should-set-type-of-read-modify-write-variables-expected.txt: Renamed from LayoutTests/webgpu/whlsl-use-undefined-variable-2-expected.txt.
webgpu/whlsl/checker-should-set-type-of-read-modify-write-variables.html: Renamed from LayoutTests/webgpu/whlsl-checker-should-set-type-of-read-modify-write-variables.html.
webgpu/whlsl/comment-parsing-expected.txt: Renamed from LayoutTests/webgpu/whlsl-comment-parsing-expected.txt.
webgpu/whlsl/comment-parsing.html: Renamed from LayoutTests/webgpu/whlsl-comment-parsing.html.
webgpu/whlsl/compute-expected.txt: Renamed from LayoutTests/webgpu/whlsl-two-dimensional-array-expected.txt.
webgpu/whlsl/compute.html: Renamed from LayoutTests/webgpu/whlsl-compute.html.
webgpu/whlsl/copy-expected.txt: Renamed from LayoutTests/webgpu/whlsl-copy-expected.txt.
webgpu/whlsl/copy.html: Renamed from LayoutTests/webgpu/whlsl-copy.html.
webgpu/whlsl/dereference-ordering-expected.txt: Renamed from LayoutTests/webgpu/whlsl-dereference-ordering-expected.txt.
webgpu/whlsl/dereference-ordering.html: Renamed from LayoutTests/webgpu/whlsl-dereference-ordering.html.
webgpu/whlsl/dereference-pointer-should-type-check-expected.html: Renamed from LayoutTests/webgpu/whlsl-store-to-property-updates-properly-expected.html.
webgpu/whlsl/dereference-pointer-should-type-check.html: Renamed from LayoutTests/webgpu/whlsl-dereference-pointer-should-type-check.html.
webgpu/whlsl/do-while-loop-break-expected.html: Renamed from LayoutTests/webgpu/whlsl-zero-initialize-values-expected.html.
webgpu/whlsl/do-while-loop-break.html: Renamed from LayoutTests/webgpu/whlsl-do-while-loop-break.html.
webgpu/whlsl/do-while-loop-continue-expected.html: Renamed from LayoutTests/webgpu/whlsl-return-local-variable-expected.html.
webgpu/whlsl/do-while-loop-continue.html: Renamed from LayoutTests/webgpu/whlsl-do-while-loop-continue.html.
webgpu/whlsl/do-while-loop-expected.html: Renamed from LayoutTests/webgpu/whlsl-nested-dot-expression-rvalue-expected.html.
webgpu/whlsl/do-while-loop.html: Renamed from LayoutTests/webgpu/whlsl-do-while-loop.html.
webgpu/whlsl/dont-crash-parsing-enum-expected.html: Renamed from LayoutTests/webgpu/whlsl-loops-expected.html.
webgpu/whlsl/dont-crash-parsing-enum.html: Renamed from LayoutTests/webgpu/whlsl-dont-crash-parsing-enum.html.
webgpu/whlsl/dot-expressions-expected.html: Renamed from LayoutTests/webgpu/whlsl-expected.html.
webgpu/whlsl/dot-expressions.html: Renamed from LayoutTests/webgpu/whlsl-dot-expressions.html.
webgpu/whlsl/double-not-expected.txt: Renamed from LayoutTests/webgpu/whlsl-double-not-expected.txt.
webgpu/whlsl/double-not.html: Renamed from LayoutTests/webgpu/whlsl-double-not.html.
webgpu/whlsl/duplicate-types-should-not-produce-duplicate-ctors-expected.txt: Renamed from LayoutTests/webgpu/whlsl-textures-getdimensions-expected.txt.
webgpu/whlsl/duplicate-types-should-not-produce-duplicate-ctors.html: Renamed from LayoutTests/webgpu/whlsl-duplicate-types-should-not-produce-duplicate-ctors.html.
webgpu/whlsl/duplicates-expected.txt: Renamed from LayoutTests/webgpu/whlsl-duplicates-expected.txt.
webgpu/whlsl/duplicates.html: Renamed from LayoutTests/webgpu/whlsl-duplicates.html.
webgpu/whlsl/ensure-proper-variable-lifetime-2-expected.html: Renamed from LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-expected.html.
webgpu/whlsl/ensure-proper-variable-lifetime-2.html: Renamed from LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-2.html.
webgpu/whlsl/ensure-proper-variable-lifetime-3-expected.html: Renamed from LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-3-expected.html.
webgpu/whlsl/ensure-proper-variable-lifetime-3.html: Renamed from LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-3.html.
webgpu/whlsl/ensure-proper-variable-lifetime-expected.html: Renamed from LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime-2-expected.html.
webgpu/whlsl/ensure-proper-variable-lifetime.html: Renamed from LayoutTests/webgpu/whlsl-ensure-proper-variable-lifetime.html.
webgpu/whlsl/enum-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-enum-spec-tests-expected.txt.
webgpu/whlsl/enum-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-enum-spec-tests.html.
webgpu/whlsl/equality-expected.txt: Renamed from LayoutTests/webgpu/whlsl-equality-expected.txt.
webgpu/whlsl/equality.html: Renamed from LayoutTests/webgpu/whlsl-equality.html.
webgpu/whlsl/expected.html: Renamed from LayoutTests/webgpu/whlsl-dot-expressions-expected.html.
webgpu/whlsl/float-math-expected.txt: Renamed from LayoutTests/webgpu/whlsl-float-math-expected.txt.
webgpu/whlsl/float-math.html: Renamed from LayoutTests/webgpu/whlsl-float-math.html.
webgpu/whlsl/getter-setter-type-expected.txt: Renamed from LayoutTests/webgpu/whlsl-getter-setter-type-expected.txt.
webgpu/whlsl/getter-setter-type.html: Renamed from LayoutTests/webgpu/whlsl-getter-setter-type.html.
webgpu/whlsl/huge-array-expected.txt: Renamed from LayoutTests/webgpu/whlsl-simple-arrays-expected.txt.
webgpu/whlsl/huge-array.html: Renamed from LayoutTests/webgpu/whlsl-huge-array.html.
webgpu/whlsl/if-statement-expected.txt: Renamed from LayoutTests/webgpu/whlsl-if-statement-expected.txt.
webgpu/whlsl/if-statement.html: Renamed from LayoutTests/webgpu/whlsl-if-statement.html.
webgpu/whlsl/increment-decrement-expected.txt: Renamed from LayoutTests/webgpu/whlsl-increment-decrement-expected.txt.
webgpu/whlsl/increment-decrement.html: Renamed from LayoutTests/webgpu/whlsl-increment-decrement.html.
webgpu/whlsl/index-ander-expected.txt: Renamed from LayoutTests/webgpu/whlsl-index-ander-expected.txt.
webgpu/whlsl/index-ander.html: Renamed from LayoutTests/webgpu/whlsl-index-ander.html.
webgpu/whlsl/index-getter-setter-expected.txt: Renamed from LayoutTests/webgpu/whlsl-index-getter-setter-expected.txt.
webgpu/whlsl/index-getter-setter.html: Renamed from LayoutTests/webgpu/whlsl-index-getter-setter.html.
webgpu/whlsl/index-setter-getter-expected.txt: Renamed from LayoutTests/webgpu/whlsl-index-setter-getter-expected.txt.
webgpu/whlsl/index-setter-getter.html: Renamed from LayoutTests/webgpu/whlsl-index-setter-getter.html.
webgpu/whlsl/int-bit-math-expected.txt: Renamed from LayoutTests/webgpu/whlsl-int-bit-math-expected.txt.
webgpu/whlsl/int-bit-math.html: Renamed from LayoutTests/webgpu/whlsl-int-bit-math.html.
webgpu/whlsl/int-literal-compare-expected.txt: Renamed from LayoutTests/webgpu/whlsl-int-literal-compare-expected.txt.
webgpu/whlsl/int-literal-compare.html: Renamed from LayoutTests/webgpu/whlsl-int-literal-compare.html.
webgpu/whlsl/logical-negation-expected.txt: Renamed from LayoutTests/webgpu/whlsl-logical-negation-expected.txt.
webgpu/whlsl/logical-negation.html: Renamed from LayoutTests/webgpu/whlsl-logical-negation.html.
webgpu/whlsl/loops-break-expected.html: Renamed from LayoutTests/webgpu/whlsl-zero-initialize-values-2-expected.html.
webgpu/whlsl/loops-break.html: Renamed from LayoutTests/webgpu/whlsl-loops-break.html.
webgpu/whlsl/loops-continue-expected.html: Renamed from LayoutTests/webgpu/whlsl-while-loop-break-expected.html.
webgpu/whlsl/loops-continue.html: Renamed from LayoutTests/webgpu/whlsl-loops-continue.html.
webgpu/whlsl/loops-expected.html: Renamed from LayoutTests/webgpu/whlsl-dont-crash-parsing-enum-expected.html.
webgpu/whlsl/loops-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-loops-spec-tests-expected.txt.
webgpu/whlsl/loops-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-loops-spec-tests.html.
webgpu/whlsl/loops.html: Renamed from LayoutTests/webgpu/whlsl-loops.html.
webgpu/whlsl/lots-of-local-variables-expected.txt: Renamed from LayoutTests/webgpu/whlsl-lots-of-local-variables-expected.txt.
webgpu/whlsl/lots-of-local-variables.html: Renamed from LayoutTests/webgpu/whlsl-lots-of-local-variables.html.
webgpu/whlsl/lvalues-expected.txt: Renamed from LayoutTests/webgpu/whlsl-lvalues-expected.txt.
webgpu/whlsl/lvalues.html: Renamed from LayoutTests/webgpu/whlsl-lvalues.html.
webgpu/whlsl/make-array-ref-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-make-array-ref-spec-tests-expected.txt.
webgpu/whlsl/make-array-ref-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-make-array-ref-spec-tests.html.
webgpu/whlsl/make-array-reference-expected.txt: Renamed from LayoutTests/webgpu/whlsl-read-modify-write-high-zombies-expected.txt.
webgpu/whlsl/make-array-reference.html: Renamed from LayoutTests/webgpu/whlsl-make-array-reference.html.
webgpu/whlsl/matrices-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-matrices-spec-tests-expected.txt.
webgpu/whlsl/matrices-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-matrices-spec-tests.html.
webgpu/whlsl/matrix-2-expected.txt: Renamed from LayoutTests/webgpu/whlsl-read-modify-write-expected.txt.
webgpu/whlsl/matrix-2.html: Renamed from LayoutTests/webgpu/whlsl-matrix-2.html.
webgpu/whlsl/matrix-expected.txt: Renamed from LayoutTests/webgpu/whlsl-oob-access-expected.txt.
webgpu/whlsl/matrix-memory-layout-expected.txt: Renamed from LayoutTests/webgpu/whlsl-null-dereference-expected.txt.
webgpu/whlsl/matrix-memory-layout.html: Renamed from LayoutTests/webgpu/whlsl-matrix-memory-layout.html.
webgpu/whlsl/matrix.html: Renamed from LayoutTests/webgpu/whlsl-matrix.html.
webgpu/whlsl/nested-dot-expression-rvalue-expected.html: Renamed from LayoutTests/webgpu/whlsl-do-while-loop-expected.html.
webgpu/whlsl/nested-dot-expression-rvalue.html: Renamed from LayoutTests/webgpu/whlsl-nested-dot-expression-rvalue.html.
webgpu/whlsl/nested-loop-expected.html: Renamed from LayoutTests/webgpu/whlsl-nested-loop-expected.html.
webgpu/whlsl/nested-loop.html: Renamed from LayoutTests/webgpu/whlsl-nested-loop.html.
webgpu/whlsl/null-arg-expected.txt: Renamed from LayoutTests/webgpu/whlsl-null-arg-expected.txt.
webgpu/whlsl/null-arg.html: Renamed from LayoutTests/webgpu/whlsl-null-arg.html.
webgpu/whlsl/null-array-ref.html: Renamed from LayoutTests/webgpu/whlsl-null-array-ref.html.
webgpu/whlsl/null-dereference-expected.txt: Renamed from LayoutTests/webgpu/whlsl-matrix-memory-layout-expected.txt.
webgpu/whlsl/null-dereference.html: Renamed from LayoutTests/webgpu/whlsl-null-dereference.html.
webgpu/whlsl/oob-access-expected.txt: Renamed from LayoutTests/webgpu/whlsl-matrix-expected.txt.
webgpu/whlsl/oob-access.html: Renamed from LayoutTests/webgpu/whlsl-oob-access.html.
webgpu/whlsl/operator-overload-expected.txt: Renamed from LayoutTests/webgpu/whlsl-operator-overload-expected.txt.
webgpu/whlsl/operator-overload.html: Renamed from LayoutTests/webgpu/whlsl-operator-overload.html.
webgpu/whlsl/overload-expected.txt: Renamed from LayoutTests/webgpu/whlsl-overload-expected.txt.
webgpu/whlsl/overload.html: Renamed from LayoutTests/webgpu/whlsl-overload.html.
webgpu/whlsl/override-subscript-expected.txt: Renamed from LayoutTests/webgpu/whlsl-override-subscript-expected.txt.
webgpu/whlsl/override-subscript.html: Renamed from LayoutTests/webgpu/whlsl-override-subscript.html.
webgpu/whlsl/plus-equals-expected.txt: Renamed from LayoutTests/webgpu/whlsl-plus-equals-expected.txt.
webgpu/whlsl/plus-equals.html: Renamed from LayoutTests/webgpu/whlsl-plus-equals.html.
webgpu/whlsl/pointer-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-pointer-spec-tests-expected.txt.
webgpu/whlsl/pointer-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-pointer-spec-tests.html.
webgpu/whlsl/postfix-prefix-expected.txt: Renamed from LayoutTests/webgpu/whlsl-postfix-prefix-expected.txt.
webgpu/whlsl/postfix-prefix.html: Renamed from LayoutTests/webgpu/whlsl-postfix-prefix.html.
webgpu/whlsl/read-modify-write-expected.txt: Renamed from LayoutTests/webgpu/whlsl-matrix-2-expected.txt.
webgpu/whlsl/read-modify-write-high-zombies-expected.txt: Renamed from LayoutTests/webgpu/whlsl-make-array-reference-expected.txt.
webgpu/whlsl/read-modify-write-high-zombies.html: Renamed from LayoutTests/webgpu/whlsl-read-modify-write-high-zombies.html.
webgpu/whlsl/read-modify-write.html: Renamed from LayoutTests/webgpu/whlsl-read-modify-write.html.
webgpu/whlsl/recursive-structs-expected.txt: Renamed from LayoutTests/webgpu/whlsl-recursive-structs-expected.txt.
webgpu/whlsl/recursive-structs.html: Renamed from LayoutTests/webgpu/whlsl-recursive-structs.html.
webgpu/whlsl/return-local-variable-expected.html: Renamed from LayoutTests/webgpu/whlsl-do-while-loop-continue-expected.html.
webgpu/whlsl/return-local-variable.html: Renamed from LayoutTests/webgpu/whlsl-return-local-variable.html.
webgpu/whlsl/return-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-return-spec-tests-expected.txt.
webgpu/whlsl/return-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-return-spec-tests.html.
webgpu/whlsl/setter-spec-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-setter-spec-tests-expected.txt.
webgpu/whlsl/setter-spec-tests.html: Renamed from LayoutTests/webgpu/whlsl-setter-spec-tests.html.
webgpu/whlsl/simple-arrays-expected.txt: Renamed from LayoutTests/webgpu/whlsl-huge-array-expected.txt.
webgpu/whlsl/simple-arrays.html: Renamed from LayoutTests/webgpu/whlsl-simple-arrays.html.
webgpu/whlsl/simple-getter-setter-expected.txt: Renamed from LayoutTests/webgpu/whlsl-simple-getter-setter-expected.txt.
webgpu/whlsl/simple-getter-setter.html: Renamed from LayoutTests/webgpu/whlsl-simple-getter-setter.html.
webgpu/whlsl/simple-tests-expected.txt: Renamed from LayoutTests/webgpu/whlsl-simple-tests-expected.txt.
webgpu/whlsl/simple-tests.html: Renamed from LayoutTests/webgpu/whlsl-simple-tests.html.
webgpu/whlsl/simple-while-loop-expected.txt: Renamed from LayoutTests/webgpu/whlsl-simple-while-loop-expected.txt.
webgpu/whlsl/simple-while-loop.html: Renamed from LayoutTests/webgpu/whlsl-simple-while-loop.html.
webgpu/whlsl/store-null-expected.txt: Renamed from LayoutTests/webgpu/whlsl-store-null-expected.txt.
webgpu/whlsl/store-null.html: Renamed from LayoutTests/webgpu/whlsl-store-null.html.
webgpu/whlsl/store-to-property-updates-properly-expected.html: Renamed from LayoutTests/webgpu/whlsl-dereference-pointer-should-type-check-expected.html.
webgpu/whlsl/store-to-property-updates-properly.html: Renamed from LayoutTests/webgpu/whlsl-store-to-property-updates-properly.html.
webgpu/whlsl/struct-expected.txt: Renamed from LayoutTests/webgpu/whlsl-struct-expected.txt.
webgpu/whlsl/struct.html: Renamed from LayoutTests/webgpu/whlsl-struct.html.
webgpu/whlsl/switch-expected.txt: Renamed from LayoutTests/webgpu/whlsl-switch-expected.txt.
webgpu/whlsl/switch.html: Renamed from LayoutTests/webgpu/whlsl-switch.html.
webgpu/whlsl/ternary-spec-test-expected.txt: Renamed from LayoutTests/webgpu/whlsl-ternary-spec-test-expected.txt.
webgpu/whlsl/ternary-spec-test.html: Renamed from LayoutTests/webgpu/whlsl-ternary-spec-test.html.
webgpu/whlsl/test-harness-test-expected.txt: Renamed from LayoutTests/webgpu/whlsl-test-harness-test-expected.txt.
webgpu/whlsl/test-harness-test.html: Renamed from LayoutTests/webgpu/whlsl-test-harness-test.html.
webgpu/whlsl/textures-getdimensions-expected.txt: Renamed from LayoutTests/webgpu/whlsl-duplicate-types-should-not-produce-duplicate-ctors-expected.txt.
webgpu/whlsl/textures-getdimensions.html: Renamed from LayoutTests/webgpu/whlsl-textures-getdimensions.html.
webgpu/whlsl/textures-load-expected.html: Renamed from LayoutTests/webgpu/whlsl-buffer-vertex-expected.html.
webgpu/whlsl/textures-load.html: Renamed from LayoutTests/webgpu/whlsl-textures-load.html.
webgpu/whlsl/textures-sample-expected.html: Renamed from LayoutTests/webgpu/whlsl-buffer-fragment-expected.html.
webgpu/whlsl/textures-sample.html: Renamed from LayoutTests/webgpu/whlsl-textures-sample.html.
webgpu/whlsl/two-dimensional-array-expected.txt: Renamed from LayoutTests/webgpu/whlsl-compute-expected.txt.
webgpu/whlsl/two-dimensional-array.html: Renamed from LayoutTests/webgpu/whlsl-two-dimensional-array.html.
webgpu/whlsl/type-mismatch-expected.txt: Renamed from LayoutTests/webgpu/whlsl-type-mismatch-expected.txt.
webgpu/whlsl/type-mismatch.html: Renamed from LayoutTests/webgpu/whlsl-type-mismatch.html.
webgpu/whlsl/uint-bitwise-expected.txt: Renamed from LayoutTests/webgpu/whlsl-uint-bitwise-expected.txt.
webgpu/whlsl/uint-bitwise.html: Renamed from LayoutTests/webgpu/whlsl-uint-bitwise.html.
webgpu/whlsl/use-undefined-variable-2-expected.txt: Renamed from LayoutTests/webgpu/whlsl-checker-should-set-type-of-read-modify-write-variables-expected.txt.
webgpu/whlsl/use-undefined-variable-2.html: Renamed from LayoutTests/webgpu/whlsl-use-undefined-variable-2.html.
webgpu/whlsl/use-undefined-variable-expected.txt: Renamed from LayoutTests/webgpu/whlsl-buffer-length-expected.txt.
webgpu/whlsl/use-undefined-variable.html: Renamed from LayoutTests/webgpu/whlsl-use-undefined-variable.html.
webgpu/whlsl/variable-shadowing-expected.txt: Renamed from LayoutTests/webgpu/whlsl-variable-shadowing-expected.txt.
webgpu/whlsl/variable-shadowing.html: Renamed from LayoutTests/webgpu/whlsl-variable-shadowing.html.
webgpu/whlsl/vector-syntax-expected.txt: Renamed from LayoutTests/webgpu/whlsl-vector-syntax-expected.txt.
webgpu/whlsl/vector-syntax.html: Renamed from LayoutTests/webgpu/whlsl-vector-syntax.html.
webgpu/whlsl/while-loop-break-expected.html: Renamed from LayoutTests/webgpu/whlsl-loops-continue-expected.html.
webgpu/whlsl/while-loop-break.html: Renamed from LayoutTests/webgpu/whlsl-while-loop-break.html.
webgpu/whlsl/while-loop-continue-expected.html: Renamed from LayoutTests/webgpu/whlsl-arbitrary-vertex-attribute-locations-expected.html.
webgpu/whlsl/while-loop-continue.html: Renamed from LayoutTests/webgpu/whlsl-while-loop-continue.html.
webgpu/whlsl/whlsl.html: Renamed from LayoutTests/webgpu/whlsl.html.
webgpu/whlsl/wrong-argument-length-expected.txt: Renamed from LayoutTests/webgpu/whlsl-wrong-argument-length-expected.txt.
webgpu/whlsl/wrong-argument-length.html: Renamed from LayoutTests/webgpu/whlsl-wrong-argument-length.html.
webgpu/whlsl/wrong-types-expected.txt: Renamed from LayoutTests/webgpu/whlsl-wrong-types-expected.txt.
webgpu/whlsl/wrong-types.html: Renamed from LayoutTests/webgpu/whlsl-wrong-types.html.
webgpu/whlsl/zero-initialize-values-2-expected.html: Renamed from LayoutTests/webgpu/whlsl-loops-break-expected.html.
webgpu/whlsl/zero-initialize-values-2.html: Renamed from LayoutTests/webgpu/whlsl-zero-initialize-values-2.html.
webgpu/whlsl/zero-initialize-values-expected.html: Renamed from LayoutTests/webgpu/whlsl-do-while-loop-break-expected.html.
webgpu/whlsl/zero-initialize-values.html: Renamed from LayoutTests/webgpu/whlsl-zero-initialize-values.html.

4:51 PM Changeset in webkit [247500] by Justin Fan

29 edits
15 copies
4 adds in trunk

[WebGPU] Convert GPUComputePipeline LOG statements to generate GPUErrors
https://bugs.webkit.org/show_bug.cgi?id=199773

Reviewed by Myles C. Maxfield.

Source/WebCore:

Generate a GPUError if GPUComputePipeline creation fails.
Rework the WHLSL test harness to take advantage of this.

Test: webgpu/compute-pipeline-errors.html

Modules/webgpu/WebGPUComputePipelineDescriptor.cpp:

(WebCore::WebGPUComputePipelineDescriptor::tryCreateGPUComputePipelineDescriptor const):

Modules/webgpu/WebGPUComputePipelineDescriptor.h:
Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::createComputePipeline const):

platform/graphics/gpu/GPUBuffer.h:
platform/graphics/gpu/GPUComputePipeline.h:

Now inherits from GPUObjectBase, though this isn't super useful yet
since GPUComputePipeline itself does not expose any operations that can error.

platform/graphics/gpu/GPUDevice.cpp:

(WebCore::GPUDevice::tryCreateComputePipeline const):

platform/graphics/gpu/GPUDevice.h:
platform/graphics/gpu/cocoa/GPUBufferMetal.mm:

(WebCore::GPUBuffer::validateBufferUsage):

platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:

(WebCore::trySetMetalFunctions):
(WebCore::trySetFunctions):
(WebCore::convertComputePipelineDescriptor):
(WebCore::tryCreateMTLComputePipelineState):
(WebCore::GPUComputePipeline::tryCreate):
(WebCore::GPUComputePipeline::GPUComputePipeline):

LayoutTests:

Add a test to ensure GPUComputePipeline errors generate correctly.
Rework checkFail in the WHLSL test harness to check for GPUError.

webgpu/compute-pipeline-errors-expected.txt: Added.
webgpu/compute-pipeline-errors.html: Added.
webgpu/error-scopes-test.html:
webgpu/js/webgpu-functions.js:

(runTestsWithDevice): Runs tests in an object all with the same device.

webgpu/js/whlsl-test-harness.js: Add shader compilation error checking.

(Harness.prototype.async.callTypedFunction):
(Harness.prototype.async.checkCompileFail):
(Harness.prototype.async._callFunction):
(Harness):
(async.checkFail):
(Harness.prototype._callFunction): Deleted.

webgpu/whlsl-recursive-structs-expected.txt: Remove a WHLSL compiler buggy test.
webgpu/whlsl-recursive-structs.html:
webgpu/whlsl-test-harness-test-expected.txt:
webgpu/whlsl-test-harness-test.html:

4:10 PM Changeset in webkit [247499] by commit-queue@webkit.org

18 edits
1 copy
2 deletes in trunk

Unreviewed, rolling out r247493.
https://bugs.webkit.org/show_bug.cgi?id=199841

"The new whlsl-for-loop.html test is failing on the bots"
(Requested by rmorisset on #webkit).

Reverted changeset:

"[WHLSL] Desugar for loops and while loops"
https://bugs.webkit.org/show_bug.cgi?id=199726
https://trac.webkit.org/changeset/247493

3:18 PM Changeset in webkit [247498] by pvollan@apple.com

5 edits in trunk/Source/WebCore

Prewarm font cache with more fonts
https://bugs.webkit.org/show_bug.cgi?id=199283

Reviewed by Myles C. Maxfield.

Use the existing prewarm method in FontCache to prewarm the cache with a set of font family names.
The font list consists of some of the fonts used by the 10 most popular sites on Alexa top sites.
This is a confirmed improvement in page load time.

No new tests, covered by existing tests.

page/ProcessWarming.cpp:

(WebCore::ProcessWarming::prewarmGlobally):

platform/graphics/FontCache.cpp:

(WebCore::FontCache::prewarmGlobally):

platform/graphics/FontCache.h:
platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::prewarmGlobally):

1:43 PM Changeset in webkit [247497] by Alan Coon

1 copy in tags/Safari-607.3.10

Tag Safari-607.3.10.

1:36 PM Changeset in webkit [247496] by Alan Coon

7 edits in branches/safari-607-branch/Source

Versioning.

1:28 PM Changeset in webkit [247495] by Brent Fulgham

2 edits in trunk/Source/WebKit

Update WebContent Process sandbox based on user seed data
https://bugs.webkit.org/show_bug.cgi?id=199799
<rdar://problem/52903477>

Reviewed by Alexey Proskuryakov.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

1:26 PM Changeset in webkit [247494] by aestes@apple.com

2 edits in trunk/Source/WebKit

[macCatalyst] Do not include WebKitLegacy.h in WebKit.h
https://bugs.webkit.org/show_bug.cgi?id=199833
<rdar://problem/53036744>

Reviewed by Tim Horton.

Shared/API/Cocoa/WebKit.h:

1:26 PM Changeset in webkit [247493] by rmorisset@apple.com

18 edits
2 adds
1 delete in trunk

[WHLSL] Desugar for loops and while loops
https://bugs.webkit.org/show_bug.cgi?id=199726

Reviewed by Myles C. Maxfield.

Source/WebCore:

This patch makes loops behave a lot more similarly to the spec.
In particular, while loops are just degenerate for loops, so they can be desugared in the parser.
And for loops can themselves be heavily desugared, into having no initializer, one condition and one increment
by putting any initializer in a block around the loop, putting true in the condition if there is none, and putting any litteral in the increment if there is none.

Debugging this patch revealed an unrelated bug where the parser would generate an empty comma expression on ";", which the checker would then choke on.
The parser now generates an empty block in that case (as specified in the spec), which fixes the problem.

Finally, while updating the NameResolver for the new structure of loops I realized that it was needlessly generating extra NameContext.
They are not expected by the spec, that forbids naked variable declarations outside of blocks anyway.
So I removed this unnecessary work, and fixed the parser to correctly forbid such naked variable declarations.

Modules/webgpu/WHLSL/AST/WHLSLAST.h:
Modules/webgpu/WHLSL/AST/WHLSLForLoop.h:

(WebCore::WHLSL::AST::ForLoop::ForLoop):
(WebCore::WHLSL::AST::ForLoop::condition):
(WebCore::WHLSL::AST::ForLoop::increment):

Modules/webgpu/WHLSL/AST/WHLSLStatement.h:

(WebCore::WHLSL::AST::Statement::isVariableDeclarationsStatement const):

Modules/webgpu/WHLSL/AST/WHLSLWhileLoop.h: Removed.
Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:

(WebCore::WHLSL::Metal::FunctionDefinitionWriter::visit):

Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:

(WebCore::WHLSL::ASTDumper::visit):

Modules/webgpu/WHLSL/WHLSLASTDumper.h:
Modules/webgpu/WHLSL/WHLSLChecker.cpp:

(WebCore::WHLSL::Checker::visit):

Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:

(WebCore::WHLSL::NameResolver::visit):

Modules/webgpu/WHLSL/WHLSLNameResolver.h:
Modules/webgpu/WHLSL/WHLSLParser.cpp:

(WebCore::WHLSL::Parser::parseBlockBody):
(WebCore::WHLSL::Parser::parseForLoop):
(WebCore::WHLSL::Parser::parseWhileLoop):
(WebCore::WHLSL::Parser::parseStatement):
(WebCore::WHLSL::Parser::parseEffectfulExpression):

Modules/webgpu/WHLSL/WHLSLParser.h:
Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp:
Modules/webgpu/WHLSL/WHLSLVisitor.cpp:

(WebCore::WHLSL::Visitor::visit):

Modules/webgpu/WHLSL/WHLSLVisitor.h:
WebCore.xcodeproj/project.pbxproj:

LayoutTests:

I added the for-loop tests from Test.mjs (with help from Saam).
I did not add the foo9 and foo10 tests, as they are forbidden by the behavior checker in the C++ implementation (and by the spec).

I also changed one test from whlsl-return-spec-tests.html to assert_fail, because it relied on a lone variable declaration in an if, which is forbidden by the spec.

webgpu/whlsl-for-loop-expected.txt: Added.
webgpu/whlsl-for-loop.html: Added.
webgpu/whlsl-return-spec-tests.html:

1:17 PM Changeset in webkit [247492] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Changes panel should be strictly LTR
https://bugs.webkit.org/show_bug.cgi?id=199767

Reviewed by Joseph Pecoraro.

Changes panel is primarily CSS code and CSS is strictly LTR.

UserInterface/Views/ChangesDetailsSidebarPanel.js:

(WI.ChangesDetailsSidebarPanel):

1:08 PM Changeset in webkit [247491] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Fix build warning because of missing super_class initializer
https://bugs.webkit.org/show_bug.cgi?id=199825

Patch by Frederic Wang <fwang@igalia.com> on 2019-07-16
Reviewed by Jonathan Bedard.

UIProcess/ios/WKContentView.mm:

(keyCommandsPlaceholderHackForEvernote):

12:46 PM Changeset in webkit [247490] by timothy_horton@apple.com

18 edits in trunk

NSTextFinder holes don't scroll with the page
https://bugs.webkit.org/show_bug.cgi?id=199815
<rdar://problem/52280514>

Reviewed by Simon Fraser.

Source/WebCore:

rendering/ScrollAlignment.h:

Source/WebKit:

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _usePlatformFindUI]):
(-[WKWebView _setUsePlatformFindUI:]):
(-[WKWebView _ensureTextFinderClient]):
Add a bit so that clients can choose whether they want our find UI,
which respects scrolling, or the system find UI, which works when
doing multi-document searches. Right now you can't have both.

(-[WKWebView scrollFindMatchToVisible:]):
Implement and plumb scrollFindMatchToVisible.

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::indicateFindMatch):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::indicateFindMatch):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Plumb indicateFindMatch to FindController.

UIProcess/mac/WKTextFinderClient.h:
UIProcess/mac/WKTextFinderClient.mm:

(-[WKTextFinderClient initWithPage:view:usePlatformFindUI:]):
Store whether or not we are using the platform find UI.

(-[WKTextFinderClient findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:]):
If using WebKit find UI, turn on our UI in the options passed to findString[Matches].

(-[WKTextFinderClient scrollFindMatchToVisible:]):
If using WebKit find UI, when the platform tells us to reveal a find match, indicate it.

(-[WKTextFinderClient didFindStringMatchesWithRects:didWrapAround:]):
If using WebKit find UI, lie to the platform and return no rects so that it doesn't paint a yellow rectangle.

(-[WKTextFinderClient getImageForMatchResult:completionHandler:]):
If using WebKit find UI, lie to the platform and return no image so that it doesn't paint a yellow rectangle.

(-[WKTextFinderClient initWithPage:view:]): Deleted.

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll):
Make it possible to use our find UI with 'findStringMatches'; since the platform
find infrastrucutre depends on knowing about all matches up front, we need
to use 'findStringMatches' instead of 'findString', but we had never combined
that with our UI. Don't throw away the other matches when we indicate one, and
don't send DidFindString in the case we are coming from 'findStringMatches'.
This all needs a bit of cleanup in the future.

(WebKit::FindController::findString):
Tell updateFindUIAfterPageScroll that we are 'findString' so that it uses its normal behavior.

(WebKit::FindController::findStringMatches):
Tell updateFindUIAfterPageScroll that we are 'findStringMatches' so that it uses the adjusted behavior.

(WebKit::FindController::indicateFindMatch):
Add 'indicateFindMatch', which both selects the match and moves the indicator there.

WebProcess/WebPage/FindController.h:

Tools:

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[MiniBrowserNSTextFinder performAction:]):
(-[WK2BrowserWindowController awakeFromNib]):
Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
-performAction: so that we can intercept the close action and
hide our own find UI, since there is no delegate for that action yet.

TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:

(TEST):

11:56 AM Changeset in webkit [247489] by youenn@apple.com

2 edits in trunk/Source/WebCore

[iOS] Make sure the first camera device in the list is the front camera
https://bugs.webkit.org/show_bug.cgi?id=199811
<rdar://problem/53125157>

Reviewed by Jer Noble.

Some websites call getUserMedia with a deviceId constraint and theey pick the
first deviceId in the list provided by enumerateDevices.
On iOS, this is the back camera which is often not what is expected by WebRTC applications.
Instead, make sure the first camera device is the front camera.

Manually tested.

platform/mediastream/mac/AVCaptureDeviceManager.mm:

11:41 AM Changeset in webkit [247488] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[GTK] Fix a build warning in JavaScriptCore/API/tests/testapi.c
https://bugs.webkit.org/show_bug.cgi?id=199824

Patch by Joonghun Park <pjh0718@gmail.com> on 2019-07-16
Reviewed by Alex Christensen.

API/tests/testapi.c:

(main):

11:37 AM Changeset in webkit [247487] by Simon Fraser

3 edits in trunk/Source/WebCore

Remove "GraphicsContext 0x7ffd8765f6b0 stack changed by" logging
https://bugs.webkit.org/show_bug.cgi?id=199834

Reviewed by Dean Jackson.

I inadvertently left in a couple of GraphicsContextStateStackChecker (used to detect mismatched
GraphicsContext save/restore) in r246725, so remove them.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

11:25 AM Changeset in webkit [247486] by Chris Dumez

15 edits in trunk/Source

Speed up StorageManager::getValues()
https://bugs.webkit.org/show_bug.cgi?id=199812

Reviewed by Alex Christensen.

Source/WebCore:

storage/StorageMap.cpp:

(WebCore::StorageMap::importItems):

storage/StorageMap.h:

Source/WebKit:

Made the following performance improvements:

Made StorageManager a WorkQueueMessageReceiver again (like it was before it got moved from the UIProcess to the Network process). This avoids a lot of thread hopping (IPC thread -> Main thread -> StorageManagerThread -> Main Thread) and a lot of isolatedCopying of the strings.
Move values around when possible to avoid copying.
Add fast path to StorageMap::importItems() for when the StorageMap is empty when importing (15ms -> 2.5ms).

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):

NetworkProcess/WebStorage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::importItems):

NetworkProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::addAllowedSessionStorageNamespaceConnection):
(WebKit::StorageManager::removeAllowedSessionStorageNamespaceConnection):
(WebKit::StorageManager::processDidCloseConnection):
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createTransientLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::getValues):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::setItems):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):

NetworkProcess/WebStorage/StorageManager.h:

Platform/IPC/Connection.cpp:

(IPC::Connection::addWorkQueueMessageReceiver):
(IPC::Connection::removeWorkQueueMessageReceiver):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::dispatchMessage):
(IPC::Connection::dispatchMessageToWorkQueueReceiver):

Platform/IPC/Connection.h:
WebProcess/WebStorage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::loadValuesIfNeeded):
Messages to WorkQueueMessageReceivers are normally dispatched from the IPC WorkQueue. However, there is a race if
a client (here StorageManager) adds itself as a WorkQueueMessageReceiver as a result of receiving an IPC message
on the main thread (here NetworkConnectionToWebProcess::WebPageWasAdded).
The message might have already been dispatched from the IPC WorkQueue to the main thread by the time the
client registers itself as a WorkQueueMessageReceiver. To address this, we check again for messages receivers
once the message arrives on the main thread.

Source/WebKitLegacy:

Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::importItems):

Storage/StorageAreaImpl.h:
Storage/StorageAreaSync.cpp:

(WebKit::StorageAreaSync::performImport):

11:17 AM Changeset in webkit [247485] by keith_miller@apple.com

2 edits in trunk/JSTests

Unreviewed, test262 gardening.

test262/expectations.yaml:

9:52 AM Changeset in webkit [247484] by Wenson Hsieh

5 edits in trunk

[Text autosizing] [iPadOS] Paragraph text on the front page of LinkedIn.com is not boosted
https://bugs.webkit.org/show_bug.cgi?id=199827
<rdar://problem/53152660>

Reviewed by Zalan Bujtas.

Source/WebCore:

After r247467, we try to avoid boosting some text that might cause vertical overflow due to line height
increasing inside a container that expects a fixed integer number of lines. However, in the case of
linkedin.com, the line height specified is a fixed value of 26px, which greatly exceeds the specified font size
of 14px. In this case, it's safe to boost font size, since doing so would not affect the line height at all.

To handle this case, don't avoid text autosizing due to the "fixed number of lines" heuristic if the line height
is fixed, and is much larger than the font size.

Test: fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-candidates.html

rendering/style/TextSizeAdjustment.cpp:

(WebCore::AutosizeStatus::updateStatus):

LayoutTests:

Add a new test case, inspired by paragraph text in a post on linkedin.com. This text should get autosized.

fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-candidates-expected.txt:
fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-candidates.html:

9:43 AM Changeset in webkit [247483] by Alan Bujtas

5 edits in trunk/Source

[ContentChangeObserver] Cancel ongoing content observation when tap is failed/cancelled
https://bugs.webkit.org/show_bug.cgi?id=199828
<rdar://problem/53152696>

Reviewed by Wenson Hsieh.

Source/WebCore:

This patch ensures that we stop the content observation (initiated by touch start) when the tap
is cancelled/failed.

Not testable.

page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::didCancelPotentialTap):

page/ios/ContentChangeObserver.h:

Source/WebKit:

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::commitPotentialTapFailed):
(WebKit::WebPage::cancelPotentialTap):

9:18 AM Changeset in webkit [247482] by mmaxfield@apple.com

2 edits in trunk/Source/WTF

New York font erroneously gets synthetic bold
https://bugs.webkit.org/show_bug.cgi?id=199653

Unreviewed MacCatalyst build fix.

wtf/Platform.h:

8:55 AM Changeset in webkit [247481] by commit-queue@webkit.org

8 edits
4 adds
2 deletes in trunk

Remove support for beforeload on link=prefetch
https://bugs.webkit.org/show_bug.cgi?id=199632

Patch by Rob Buis <rbuis@igalia.com> on 2019-07-16
Reviewed by Youenn Fablet.

Source/WebCore:

Remove support for beforeload on link=prefetch
by not calling shouldLoadLink for prefetch.
Also make loadLink return void since it always
succeeds.

Tests: http/wpt/prefetch/beforeload-dynamic.html

http/wpt/prefetch/beforeload.html

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

loader/LinkLoader.cpp:

(WebCore::LinkLoader::prefetchIfNeeded):
(WebCore::LinkLoader::loadLink):

loader/LinkLoader.h:

LayoutTests:

Add tests to verify that beforeload event is not called for link
rel=prefetch.

TestExpectations:
fast/dom/HTMLLinkElement/prefetch-beforeload-expected.txt: Removed.
fast/dom/HTMLLinkElement/prefetch-beforeload.html: Removed.
http/wpt/prefetch/beforeload-dynamic-expected.txt: Added.
http/wpt/prefetch/beforeload-dynamic.html: Added.
http/wpt/prefetch/beforeload-expected.txt: Added.
http/wpt/prefetch/beforeload.html: Added.
platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:

8:09 AM Changeset in webkit [247480] by youenn@apple.com

2 edits in trunk/Source/WebCore

Hop to main thread for release logging in RealtimeIncomingAudioSource
https://bugs.webkit.org/show_bug.cgi?id=199813

Reviewed by Eric Carlson.

platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:

(WebCore::RealtimeIncomingAudioSourceCocoa::OnData):

7:58 AM WebKitGTK/2.24.x edited by Adrian Perez de Castro

(diff)

7:57 AM Changeset in webkit [247479] by Adrian Perez de Castro

2 edits in releases/WebKitGTK/webkit-2.24/Source/bmalloc

Merged r244422 - Unreviewed, fix build failure
https://bugs.webkit.org/show_bug.cgi?id=195938

Including <array>.

bmalloc/AvailableMemory.cpp:

7:56 AM Changeset in webkit [247478] by Adrian Perez de Castro

3 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

Merged r243633 - Opcode.h(159,27): warning: adding 'unsigned int' to a string does not append to the string [-Wstring-plus-int]
https://bugs.webkit.org/show_bug.cgi?id=196343

Reviewed by Saam Barati.

Clang reports a compilation warning and recommend '&PADDING_STRING[PADDING_STRING_LENGTH]'
instead of 'PADDING_STRING + PADDING_STRING_LENGTH'.

bytecode/Opcode.cpp:

(JSC::padOpcodeName): Moved padOpcodeName from Opcode.h because
this function is used only in Opcode.cpp. Changed macros
PADDING_STRING and PADDING_STRING_LENGTH to simple variables.
(JSC::compareOpcodePairIndices): Replaced pair with std::pair.

bytecode/Opcode.h:

(JSC::padOpcodeName): Moved.

1:09 AM Changeset in webkit [247477] by Michael Catanzaro

2 edits in trunk/Source/WTF

[WPE][GTK] Improvements and fixes in FileSystemGlib.cpp
https://bugs.webkit.org/show_bug.cgi?id=199800

Reviewed by Carlos Garcia Campos.

Use nullptr.

Fix a GFileInfo leak in getFileSize.

Use GRefPtr to clarify ownership of the GFileIOStream in openFile.

wtf/glib/FileSystemGlib.cpp:

(WTF::FileSystemImpl::getFileSize):
(WTF::FileSystemImpl::getVolumeFreeSpace):
(WTF::FileSystemImpl::openTemporaryFile):
(WTF::FileSystemImpl::openFile):
(WTF::FileSystemImpl::seekFile):
(WTF::FileSystemImpl::writeToFile):
(WTF::FileSystemImpl::readFromFile):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed