Context Navigation

← Previous Period
Next Period →

Timeline

Jul 25, 2019:

11:53 PM Changeset in webkit [247856] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit

Unreviewed build fix in NetworkDataTaskSoup.

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::authenticateCallback):
Fix incorrect use of the dereferencing operator introduced in r247831.

11:15 PM Changeset in webkit [247855] by Fujii Hironori

2 edits in trunk/Source/WebKitLegacy/win

[Win][WK1] The inspected webview window is misplaced after changing Web Inspector frontend window height
https://bugs.webkit.org/show_bug.cgi?id=200152

Reviewed by Brent Fulgham.

In WebInspectorFrontendClient::setAttachedWindowHeight, the size
of m_inspectedWebViewHwnd was changed to the whole host window
size. But, it's too tall because MiniBrowser's host window has a
toolbar. The toolbar height should be taken into account.

Change to the height of m_inspectedWebViewHwnd to the sum of
inspected WebView and inspector frontend WebView heights.

WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::setAttachedWindowHeight):

9:58 PM Changeset in webkit [247854] by ysuzuki@apple.com

3 edits in trunk/Source/JavaScriptCore

[JSC] Use unalignedLoad for JSRopeString fiber accesses
https://bugs.webkit.org/show_bug.cgi?id=200148

Reviewed by Mark Lam.

JSRopeString always have some subsequent bytes that can be accessible because MarkedBlock has Footer.
We use WTF::unalignedLoad to get fibers. And it will be converted to one load CPU instruction.

heap/MarkedBlock.h:
runtime/JSString.h:

7:38 PM Changeset in webkit [247853] by jiewen_tan@apple.com

2 edits in trunk/Source/WebKit

Unreviewed, build fix after r247851

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Reverts an unnecessary change.

6:43 PM Changeset in webkit [247852] by Fujii Hironori

2 edits in trunk/Source/WebKit

[GTK] Indistinguishable overloaded callback function inspectorViewDestroyed if RemoteWebInspectorProxyGtk.cpp and WebInspectorProxyGtk.cpp are in a unified build bundle
https://bugs.webkit.org/show_bug.cgi?id=200123

Patch by Fujii Hironori <fujii.hironori@gmail.com> on 2019-07-25
Reviewed by Carlos Garcia Campos.

UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp:

(WebKit::remoteInspectorViewDestroyed): Added.
(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):
(WebKit::inspectorViewDestroyed): Deleted.
Renamed inspectorViewDestroyed to remoteInspectorViewDestroyed.

6:26 PM Changeset in webkit [247851] by jiewen_tan@apple.com

6 edits in trunk

WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
https://bugs.webkit.org/show_bug.cgi?id=200108
<rdar://problem/53521238>

Reviewed by Chris Dumez.

Source/WebKit:

Assuming there are two loads happening one after another. There is an issue when clients save
the first decisionHandler and then call WKNavigationActionPolicyCancel for it right after the
second decisionHandler received, -[WKWebView URL] could return a null string even though it is
loading the second one.

To solve that, this patch pairs a navigationID with the pendingAPIRequestURL such that
WebPageProxy::receivedPolicyDecision could clear the pendingAPIRequestURL only if
the passed navigation ID matches the current one.

UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::activeURL):
(WebKit::PageLoadState::estimatedProgress):
(WebKit::PageLoadState::pendingAPIRequestURL const):
(WebKit::PageLoadState::pendingAPIRequest const):
(WebKit::PageLoadState::setPendingAPIRequest):
(WebKit::PageLoadState::clearPendingAPIRequest):
(WebKit::PageLoadState::isLoading):
(WebKit::PageLoadState::setPendingAPIRequestURL): Deleted.
(WebKit::PageLoadState::clearPendingAPIRequestURL): Deleted.

UIProcess/PageLoadState.h:

(WebKit::PageLoadState::setPendingAPIRequest):
(WebKit::PageLoadState::setPendingAPIRequestURL): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::launchProcessForReload):
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadDataWithNavigationShared):
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Tools:

Added an API test.

TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:

(-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
(TEST):

6:03 PM Changeset in webkit [247850] by Jonathan Bedard

2 edits in trunk/Tools

results.webkit.org: Color should be the worst result, count should include all results
https://bugs.webkit.org/show_bug.cgi?id=200127

Rubber-stamped by Aakash Jain.

resultsdbpy/resultsdbpy/view/static/js/timeline.js:

(Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.

5:44 PM Changeset in webkit [247849] by Alan Coon

5 edits in branches/safari-608.1-branch

Cherry-pick r247692. rdar://problem/53519923

Disable MediaRecorder for legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=200001
<rdar://problem/53400030>

Reviewed by Eric Carlson.

Source/WebKitLegacy/mac:

Disable MediaRecorder by default in legacy WebKit.
Add SPI to set/get this preference.

WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences _mediaRecorderEnabled]): (-[WebPreferences _setMediaRecorderEnabled:]):
WebView/WebPreferencesPrivate.h:

Tools:

Enable MediaRecorder for testing purposes.

DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:44 PM Changeset in webkit [247848] by Alan Coon

2 edits in branches/safari-608.1-branch/Source/WebCore

Cherry-pick r247620. rdar://problem/53519933

Crash under WebPage::boundaryEventOccurred
https://bugs.webkit.org/show_bug.cgi?id=199907

Reviewed by Chris Fleizach.

Add null pointer checks.

No new tests, since I have not been able to reproduce this in a test.

Modules/speech/SpeechSynthesis.cpp: (WebCore::SpeechSynthesis::didStartSpeaking): (WebCore::SpeechSynthesis::didFinishSpeaking): (WebCore::SpeechSynthesis::didPauseSpeaking): (WebCore::SpeechSynthesis::didResumeSpeaking): (WebCore::SpeechSynthesis::speakingErrorOccurred): (WebCore::SpeechSynthesis::boundaryEventOccurred):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:41 PM Changeset in webkit [247847] by Alan Coon

7 edits in branches/safari-608.1-branch/Source

Versioning.

5:40 PM Changeset in webkit [247846] by timothy_horton@apple.com

4 edits in trunk/Source/WebCore

Subpixel fringes around TextIndicator snapshots at non-integral scale factors
https://bugs.webkit.org/show_bug.cgi?id=200145

Reviewed by Simon Fraser.

page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRectWithClip):

page/FrameSnapshotting.h:
page/TextIndicator.cpp:

(WebCore::snapshotOptionsForTextIndicatorOptions):
Round the scale factor up, and snappily enclose the clip rects.

TextIndicator doesn't require the use of the precise scale factor that
the page is painted at, but we want it to be sharp, so we overshoot!

4:55 PM Changeset in webkit [247845] by Ross Kirsling

5 edits in trunk

Legacy numeric literals should not permit separators or BigInt
https://bugs.webkit.org/show_bug.cgi?id=199984

Reviewed by Keith Miller.

JSTests:

stress/big-int-literals.js:
stress/numeric-literal-separators.js:

Source/JavaScriptCore:

parser/Lexer.cpp:

(JSC::Lexer<T>::parseOctal):
(JSC::Lexer<T>::parseDecimal):

4:15 PM Changeset in webkit [247844] by ysuzuki@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix due to C++17's std::invoke_result_t
https://bugs.webkit.org/show_bug.cgi?id=200139

Use std::result_of for now until all the supported environments implement it.

heap/IsoSubspace.h:

3:51 PM Changeset in webkit [247843] by ysuzuki@apple.com

9 edits in trunk/Source/JavaScriptCore

[JSC] Ensure PackedCellPtr only takes non-large-allocation pointers
https://bugs.webkit.org/show_bug.cgi?id=200139

Reviewed by Mark Lam.

PackedCellPtr will compact a pointer by leveraging the fact that JSCell pointers are 16byte aligned.
But this fact only holds when the JSCell is not large allocation. Currently, we are using PackedCellPtr
only for the cell types which meets the above requirement. But we would like to ensure that statically.

In this patch, we add additional static/runtime assertions to ensure this invariant. We accept a cell
type of either (1) it is "final" annotated and sizeof(T) is <= MarkedSpace::largeCutoff or (2) it
is allocated from IsoSubspace.

This patch does not change any behaviors. It just adds extra static/runtime assertions.

bytecode/CodeBlock.h:

(JSC::CodeBlock::subspaceFor):

bytecode/CodeBlockJettisoningWatchpoint.h:
bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h:
dfg/DFGAdaptiveStructureWatchpoint.h:
heap/IsoSubspace.h:
heap/PackedCellPtr.h:

(JSC::PackedCellPtr::PackedCellPtr):

runtime/FunctionRareData.h:

(JSC::FunctionRareData::createAllocationProfileClearingWatchpoint):

runtime/ObjectToStringAdaptiveStructureWatchpoint.h:

3:25 PM Changeset in webkit [247842] by commit-queue@webkit.org

3 edits
5 deletes in trunk

Unreviewed, rolling out r247806.
https://bugs.webkit.org/show_bug.cgi?id=200141

It is regressing PLT (Requested by youenn on #webkit).

Reverted changeset:

"Disable speculative loading if cache is not to be used for
the load"
https://bugs.webkit.org/show_bug.cgi?id=199644
https://trac.webkit.org/changeset/247806

3:02 PM Changeset in webkit [247841] by Brent Fulgham

28 edits
1 copy in trunk/Source/WebCore

Use IWICBitmap (rather than ID2D1Bitmap) for NativeImagePtr on FTW
https://bugs.webkit.org/show_bug.cgi?id=200093

Reviewed by Dean Jackson.

Source/WebCore:

When I wrote the original Direct2D code, I did not realize that the backing memory for the
ID2D1Bitmap was inaccessible since it is effectively a representation of GPU memory. There
is no API to access or modify the pixels.

Instead, MSDN documentation indicates that we should be using IWICBitmap objects, which are
converted to ID2D1Bitmap objects when things are ready to be rendered.

This makes it possible to use the TextureMapper backend to do efficient compositing and tile
drawing, since the data backing the bitmap can now be accessed and manipulated, allowing us
to support filters and other effects.

PlatformFTW.cmake:
platform/MIMETypeRegistry.cpp:

(WebCore::supportedImageMIMETypesForEncoding):

platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/GraphicsContext.h:
platform/graphics/ImageBuffer.h:
platform/graphics/NativeImage.h:
platform/graphics/OpenGLShims.h:
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):

platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer const):

platform/graphics/texmap/BitmapTexture.cpp:

(WebCore::BitmapTexture::updateContents):

platform/graphics/texmap/BitmapTextureGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):

platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContextPlatformPrivate::setAlpha):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawDeviceBitmap):
(WebCore::GraphicsContext::releaseWindowsContext):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::beginDraw):
(WebCore::GraphicsContextPlatformPrivate::endDraw):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::clipPath):

platform/graphics/win/GraphicsContextPlatformPrivateDirect2D.h:
platform/graphics/win/ImageBufferDataDirect2D.cpp:

(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

platform/graphics/win/ImageBufferDataDirect2D.h:

(): Deleted.

platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::createCroppedImageIfNecessary):
(WebCore::createBitmapImageAfterScalingIfNeeded):
(WebCore::ImageBuffer::copyImage const):
(WebCore::ImageBuffer::sinkIntoNativeImage):
(WebCore::ImageBuffer::copyNativeImage const):
(WebCore::ImageBuffer::draw):

platform/graphics/win/ImageDecoderDirect2D.cpp:

(WebCore::ImageDecoderDirect2D::createFrameImageAtIndex):

platform/graphics/win/ImageDirect2D.cpp:

(WebCore::BitmapImage::drawFrameMatchingSourceSize):

platform/graphics/win/NativeImageDirect2D.cpp:

(WebCore::imagingFactory):
(WebCore::nativeImageSize):
(WebCore::nativeImageHasAlpha):
(WebCore::nativeImageSinglePixelSolidColor):
(WebCore::drawNativeImage):
(WebCore::clearNativeImageSubimages):

platform/graphics/win/PathDirect2D.cpp:

(WebCore::Path::strokeContains const):

platform/graphics/win/PatternDirect2D.cpp:

(WebCore::Pattern::createPlatformPattern const):

platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::read):

rendering/RenderElement.cpp:

(WebCore::RenderElement::shouldRespectImageOrientation const):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::adjustTiledBackingCoverage):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImage):

Source/WebCore/PAL:

pal/PlatformFTW.cmake:

2:18 PM Changeset in webkit [247840] by rniwa@webkit.org

6 edits in trunk/Source/WebCore

REGRESSION (r243637): Some web fonts fail to load on Google docs
https://bugs.webkit.org/show_bug.cgi?id=200106

Reviewed by Geoffrey Garen.

Prior to r243637, WebKit threw an exception if the font family name didn't parse as a CSS identifier in the setter
of family IDL attribute of FontFace interface because WebKit implemented the old spec faithfully unlike Chrome
and Firefox which basically treated it as a string and didn't throw any exception. [1]

To account for this browser behavior difference, Google docs implemented a workaround for Safari which is to wrap
some identifiers in font family names with quotation marks: docs-Amatic SC as 'docs-Amatic SC' and
docs-Playfair Display as docs-'Playfair Display'. Unfortunately, this in turn causes the latest Safari to
not match these font face family with those that appear in stylesheet since we no longer parse it as a CSS identifier.

This patch adds a site specific quirk for Google docs to undo this workaround by stripping away single quotation marks.

[1] See https://github.com/w3c/csswg-drafts/issues/3776 for the context.

css/FontFace.cpp:

(WebCore::FontFace::create):
(WebCore::FontFace::setFamily):

css/FontFace.h:
css/FontFace.idl:
page/Quirks.cpp:

(WebCore::Quirks::shouldStripQuotationMarkInFontFaceSetFamily const):

page/Quirks.h:

2:12 PM Changeset in webkit [247839] by Simon Fraser

12 edits
2 adds in trunk

[iOS WK2] A top fixed bar can flicker when scrolling with the keyboard up
https://bugs.webkit.org/show_bug.cgi?id=200105
rdar://problem/52871975

Reviewed by Wenson Hsieh.

Source/WebCore:

ScrollingTreeFrameScrollingNode::layoutViewportForScrollPosition() computes a visual viewport
from the current scroll position and scrollableAreaSize(). This doesn't know anything about
the impact of keyboards on the visual viewport, so it computes a too-large visual viewport
when the keyboard is up, triggering incorrect manipulations of the layout viewport. This
leads to the top bar flashing to position 0 when it should be hidden off the top.

Fix by feeding into the scrolling tree the height of the visual viewport which takes
FrameView::visualViewportOverrideRect() into account. This is stored on ScrollingStateFrameScrollingNode/
ScrollingTreeFrameScrollingNode.

Test: scrollingcoordinator/ios/fixed-scrolling-with-keyboard.html

page/FrameView.h:
page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::setFrameScrollingNodeState):

page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
(WebCore::ScrollingStateFrameScrollingNode::setPropertyChangedBitsAfterReattach):
(WebCore::ScrollingStateFrameScrollingNode::setOverrideVisualViewportSize):
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties const):

page/scrolling/ScrollingStateFrameScrollingNode.h:
page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitTreeState): LOG_WITH_STREAM() doesn't evaluate scrollingTreeAsText()
every time.

page/scrolling/ScrollingTreeFrameScrollingNode.cpp:

(WebCore::ScrollingTreeFrameScrollingNode::commitStateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNode::layoutViewportForScrollPosition const):
(WebCore::ScrollingTreeFrameScrollingNode::dumpProperties const):

page/scrolling/ScrollingTreeFrameScrollingNode.h:

Source/WebKit:

Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateFrameScrollingNode>::encode):
(ArgumentCoder<ScrollingStateFrameScrollingNode>::decode):

LayoutTests:

resources/ui-helper.js:

(window.UIHelper.ensureStablePresentationUpdate.return.new.Promise):
(window.UIHelper.ensureStablePresentationUpdate):

scrollingcoordinator/ios/fixed-scrolling-with-keyboard-expected.txt: Added.
scrollingcoordinator/ios/fixed-scrolling-with-keyboard.html: Added.

1:55 PM Changeset in webkit [247838] by dino@apple.com

2 edits in trunk/Source/WebKit

WebKit/UIProcess/ios/WKContentViewInteraction.mm: error: implementing deprecated method contextMenuInteractionWillPresent
https://bugs.webkit.org/show_bug.cgi?id=200136
<rdar://problem/53547698>

Reviewed by Wenson Hsieh.

Ignore deprecation warnings for these UIContextMenuInteraction delegates.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView contextMenuInteractionWillPresent:]):
(-[WKContentView contextMenuInteraction:willCommitWithAnimator:]):
(-[WKContentView contextMenuInteractionDidEnd:]):

1:53 PM Changeset in webkit [247837] by dino@apple.com

30 edits in trunk/Source

Add helper for ignoring deprecated implementation warnings
https://bugs.webkit.org/show_bug.cgi?id=200135

Reviewed by Wenson Hsieh.

Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which
is IGNORE_WARNINGS_BEGIN("deprecated-implementations")

Source/WebCore:

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[WebAccessibilityObjectWrapper accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper IGNORE_WARNINGS_END]): Deleted.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParserWillProvideContentKeyRequestInitializationData:forTrackID:]):
(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]):

platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):

Source/WebKit:

UIProcess/API/Cocoa/LegacyBundleForClass.mm:
UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(IGNORE_WARNINGS_BEGIN): Deleted.

UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:

(IGNORE_WARNINGS_BEGIN): Deleted.

UIProcess/API/Cocoa/WKConnection.mm:

(IGNORE_WARNINGS_BEGIN): Deleted.

UIProcess/API/Cocoa/WKPreviewElementInfo.mm:
UIProcess/API/Cocoa/WKProcessGroup.mm:

(IGNORE_WARNINGS_BEGIN): Deleted.

UIProcess/API/Cocoa/WKTypeRefWrapper.mm:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKWebView draggedImage:endedAt:operation:]):
(-[WKWebView accessibilityAttributeValue:]):
(-[WKWebView accessibilityAttributeValue:forParameter:]):
(-[WKWebView namesOfPromisedFilesDroppedAtDestination:]):
(-[WKWebView IGNORE_WARNINGS_END]): Deleted.

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKWebViewConfiguration _setWebsiteDataStore:]):
(-[WKWebViewConfiguration IGNORE_WARNINGS_END]): Deleted.

UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
UIProcess/API/mac/WKView.mm:

(-[WKView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKView draggedImage:endedAt:operation:]):
(-[WKView accessibilityAttributeValue:]):
(-[WKView accessibilityAttributeValue:forParameter:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
(-[WKView IGNORE_WARNINGS_END]): Deleted.

UIProcess/WKImagePreviewViewController.mm:

(-[WKImagePreviewViewController ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKImagePreviewViewController IGNORE_WARNINGS_END]): Deleted.

UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]):

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel popoverControllerDidDismissPopover:]):

UIProcess/ios/forms/WKFormPopover.mm:

(-[WKRotatingPopover popoverControllerDidDismissPopover:]):

WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFPluginAccessibilityObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:forParameter:]):
(-[WKPDFPluginAccessibilityObject accessibilityPerformAction:]):
(-[WKPDFPluginAccessibilityObject accessibilityIsAttributeSettable:]):
(-[WKPDFPluginAccessibilityObject accessibilitySetValue:forAttribute:]):
(-[WKPDFPluginAccessibilityObject IGNORE_WARNINGS_END]): Deleted.

WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

(-[WKAccessibilityWebPageObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKAccessibilityWebPageObject accessibilityIsAttributeSettable:]):
(-[WKAccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
(-[WKAccessibilityWebPageObject IGNORE_WARNINGS_END]): Deleted.

Source/WebKitLegacy/mac:

Misc/WebDownload.mm:

(-[WebDownload initWithRequest:delegate:]):

Misc/WebIconDatabase.mm:
Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebBaseNetscapePluginView IGNORE_WARNINGS_END]): Deleted.

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebDynamicScrollBarsView IGNORE_WARNINGS_END]): Deleted.

WebView/WebHTMLView.mm:

(-[WebHTMLView draggingSourceOperationMaskForLocal:]):
(-[WebHTMLView draggedImage:endedAt:operation:]):
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
(-[WebHTMLView accessibilityAttributeValue:]):
(-[WebHTMLView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebHTMLView characterIndexForPoint:]):
(-[WebHTMLView firstRectForCharacterRange:]):
(-[WebHTMLView attributedSubstringFromRange:]):
(-[WebHTMLView setMarkedText:selectedRange:]):
(-[WebHTMLView doCommandBySelector:]):
(-[WebHTMLView insertText:]):
(-[WebHTMLView IGNORE_WARNINGS_END]): Deleted.

Source/WTF:

wtf/Compiler.h:

1:21 PM Changeset in webkit [247836] by sbarati@apple.com

2 edits in trunk/Source/WebCore

Unreviewed. Speculative build fix for tvOS of missing include.

Modules/webgpu/WHLSL/WHLSLLexer.h:

12:52 PM Changeset in webkit [247835] by Michael Catanzaro

2 edits in trunk/Source/WebCore

Unreviewed, fix -Wunused-parameter warning

testing/Internals.cpp:

(WebCore::Internals::privatePlayerVolume):

12:42 PM Changeset in webkit [247834] by sbarati@apple.com

101 edits
2 adds in trunk/Source/WebCore

[WHLSL] Add descriptive error messages
https://bugs.webkit.org/show_bug.cgi?id=195682
<rdar://problem/50746322>

Reviewed by Myles C. Maxfield.

This patch adds error messages to the WHLSL compiler. I'm taking a first pass
at having decent error messages everywhere we set an error. However, we will
probably refine these messages to be more accurate and descriptive over time.

Passes that can fail no longer return a boolean. Instead, they return Expected<void, Error>.
From Error, we can generate a descriptive error message. Visitor::setError now
requires an Error as an argument. So anywhere in Visitor that might fail is
now required to provide an error message.

In a follow-up to this, we should actually make our checkFail tests test that
they get the expected error message: https://bugs.webkit.org/show_bug.cgi?id=200049

Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
Modules/webgpu/WHLSL/AST/WHLSLAssignmentExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h:
Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h:
Modules/webgpu/WHLSL/AST/WHLSLBlock.h:
Modules/webgpu/WHLSL/AST/WHLSLBooleanLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLBreak.h:
Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.h:
Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLCommaExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLContinue.h:
Modules/webgpu/WHLSL/AST/WHLSLDereferenceExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLDoWhileLoop.h:
Modules/webgpu/WHLSL/AST/WHLSLDotExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLEffectfulExpressionStatement.h:
Modules/webgpu/WHLSL/AST/WHLSLEnumerationDefinition.h:
Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h:
Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLFallthrough.h:
Modules/webgpu/WHLSL/AST/WHLSLFloatLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLForLoop.h:
Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h:
Modules/webgpu/WHLSL/AST/WHLSLGlobalVariableReference.h:
Modules/webgpu/WHLSL/AST/WHLSLIfStatement.h:
Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLLogicalExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLLogicalNotExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLMakeArrayReferenceExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLMakePointerExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLNamedType.h:
Modules/webgpu/WHLSL/AST/WHLSLNativeTypeDeclaration.h:
Modules/webgpu/WHLSL/AST/WHLSLNullLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
Modules/webgpu/WHLSL/AST/WHLSLPropertyAccessExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLQualifier.h:
Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.h:
Modules/webgpu/WHLSL/AST/WHLSLReturn.h:
Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.h:
Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.h:
Modules/webgpu/WHLSL/AST/WHLSLStatement.h:
Modules/webgpu/WHLSL/AST/WHLSLStatementList.h:
Modules/webgpu/WHLSL/AST/WHLSLStructureDefinition.h:
Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h:
Modules/webgpu/WHLSL/AST/WHLSLSwitchCase.h:
Modules/webgpu/WHLSL/AST/WHLSLSwitchStatement.h:
Modules/webgpu/WHLSL/AST/WHLSLTernaryExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.h:
Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h:
Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:
Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h:
Modules/webgpu/WHLSL/AST/WHLSLVariableDeclarationsStatement.h:
Modules/webgpu/WHLSL/AST/WHLSLVariableReference.h:
Modules/webgpu/WHLSL/AST/WHLSLWhileLoop.h:
Modules/webgpu/WHLSL/WHLSLAutoInitializeVariables.cpp:

(WebCore::WHLSL::AutoInitialize::visit):
(WebCore::WHLSL::autoInitializeVariables):

Modules/webgpu/WHLSL/WHLSLAutoInitializeVariables.h:
Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:

(WebCore::WHLSL::checkDuplicateFunctions):

Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.h:
Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.cpp:

(WebCore::WHLSL::TextureReferencesChecker::visit):
(WebCore::WHLSL::checkTextureReferences):

Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.h:
Modules/webgpu/WHLSL/WHLSLChecker.cpp:

(WebCore::WHLSL::resolveWithOperatorAnderIndexer):
(WebCore::WHLSL::resolveWithOperatorLength):
(WebCore::WHLSL::resolveWithReferenceComparator):
(WebCore::WHLSL::resolveByInstantiation):
(WebCore::WHLSL::resolveFunction):
(WebCore::WHLSL::checkSemantics):
(WebCore::WHLSL::Checker::assignTypes):
(WebCore::WHLSL::Checker::visit):
(WebCore::WHLSL::Checker::recurseAndGetInfo):
(WebCore::WHLSL::Checker::getInfo):
(WebCore::WHLSL::Checker::finishVisiting):
(WebCore::WHLSL::Checker::recurseAndRequireBoolType):
(WebCore::WHLSL::check):

Modules/webgpu/WHLSL/WHLSLChecker.h:
Modules/webgpu/WHLSL/WHLSLCodeLocation.h: Added.

(WebCore::WHLSL::CodeLocation::CodeLocation):
(WebCore::WHLSL::CodeLocation::startOffset const):
(WebCore::WHLSL::CodeLocation::endOffset const):
(WebCore::WHLSL::CodeLocation::operator== const):
(WebCore::WHLSL::CodeLocation::operator!= const):
(WebCore::WHLSL::CodeLocation::operator bool const):

Modules/webgpu/WHLSL/WHLSLComputeDimensions.cpp:

(WebCore::WHLSL::computeDimensions):

Modules/webgpu/WHLSL/WHLSLError.h: Added.

(WebCore::WHLSL::Error::Error):
(WebCore::WHLSL::Error::codeLocation const):
(WebCore::WHLSL::Error::message const):

Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp:

(WebCore::WHLSL::checkFunctionStages):

Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.h:
Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp:

(WebCore::WHLSL::Gatherer::reset):
(WebCore::WHLSL::Gatherer::visit):
(WebCore::WHLSL::gatherEntryPointItems):

Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h:
Modules/webgpu/WHLSL/WHLSLLexer.cpp:

(WebCore::WHLSL::Lexer::lineAndColumnNumberFromOffset):
(WebCore::WHLSL::Lexer::errorString):
(WebCore::WHLSL::Lexer::lineNumberFromOffset): Deleted.

Modules/webgpu/WHLSL/WHLSLLexer.h:

(WebCore::WHLSL::CodeLocation::CodeLocation):
(WebCore::WHLSL::Lexer::errorString):
(WebCore::WHLSL::AST::CodeLocation::CodeLocation): Deleted.
(WebCore::WHLSL::AST::CodeLocation::startOffset const): Deleted.
(WebCore::WHLSL::AST::CodeLocation::endOffset const): Deleted.

Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:

(WebCore::WHLSL::NameResolver::~NameResolver):
(WebCore::WHLSL::NameResolver::visit):
(WebCore::WHLSL::resolveNamesInTypes):
(WebCore::WHLSL::resolveTypeNamesInFunctions):

Modules/webgpu/WHLSL/WHLSLNameResolver.h:
Modules/webgpu/WHLSL/WHLSLParser.cpp:

(WebCore::WHLSL::Parser::parse):
(WebCore::WHLSL::intLiteralToInt):
(WebCore::WHLSL::uintLiteralToUint):
(WebCore::WHLSL::floatLiteralToFloat):
(WebCore::WHLSL::recognizeSimpleUnsignedInteger):
(WebCore::WHLSL::Parser::parseTypeArgument):
(WebCore::WHLSL::Parser::parseType):
(WebCore::WHLSL::Parser::parseForLoop):
(WebCore::WHLSL::Parser::parseWhileLoop):
(WebCore::WHLSL::Parser::parseEffectfulExpression):
(WebCore::WHLSL::Parser::parseLimitedSuffixOperator):
(WebCore::WHLSL::Parser::parseSuffixOperator):
(WebCore::WHLSL::Parser::parseExpression):
(WebCore::WHLSL::Parser::completeTernaryConditional):
(WebCore::WHLSL::Parser::completeAssignment):
(WebCore::WHLSL::Parser::completePossibleLogicalBinaryOperation):
(WebCore::WHLSL::Parser::completePossibleRelationalBinaryOperation):
(WebCore::WHLSL::Parser::completePossibleShift):
(WebCore::WHLSL::Parser::completePossibleAdd):
(WebCore::WHLSL::Parser::completePossibleMultiply):
(WebCore::WHLSL::Parser::parsePossiblePrefix):
(WebCore::WHLSL::Parser::parseCallExpression):

Modules/webgpu/WHLSL/WHLSLParser.h:

(WebCore::WHLSL::Parser::Error::Error): Deleted.
(WebCore::WHLSL::Parser::Error::dump const): Deleted.

Modules/webgpu/WHLSL/WHLSLPrepare.cpp:

(WebCore::WHLSL::prepareShared):
(WebCore::WHLSL::prepare):

Modules/webgpu/WHLSL/WHLSLPrepare.h:
Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:

(WebCore::WHLSL::setterCall):
(WebCore::WHLSL::getterCall):
(WebCore::WHLSL::modify):
(WebCore::WHLSL::PropertyResolver::visit):

Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:

(WebCore::WHLSL::checkRecursion):

Modules/webgpu/WHLSL/WHLSLRecursionChecker.h:
Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp:

(WebCore::WHLSL::checkRecursiveTypes):

Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.h:
Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.cpp:

(WebCore::WHLSL::includeStandardLibrary):

Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp:

(WebCore::WHLSL::checkStatementBehavior):

Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.h:
Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp:

(WebCore::WHLSL::synthesizeArrayOperatorLength):

Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.h:
Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:

(WebCore::WHLSL::synthesizeConstructors):

Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.h:
Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp:

(WebCore::WHLSL::synthesizeEnumerationFunctions):

Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.h:
Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp:

(WebCore::WHLSL::synthesizeStructureAccessors):

Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.h:
Modules/webgpu/WHLSL/WHLSLVisitor.h:

(WebCore::WHLSL::Visitor::hasError const):
(WebCore::WHLSL::Visitor::expectedError):
(WebCore::WHLSL::Visitor::checkErrorAndVisit):
(WebCore::WHLSL::Visitor::setError):
(WebCore::WHLSL::Visitor::error const): Deleted.
(): Deleted.

WebCore.xcodeproj/project.pbxproj:
platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:

(WebCore::trySetFunctions):

11:52 AM Changeset in webkit [247833] by russell_e@apple.com

3 edits in trunk/LayoutTests

rdar://53551736 (Layout Test editing/pasteboard/paste-and-sanitize.html is a Flaky Failure on iOS 13).

Unreviewed Test Gardening.

platform/ios-12/TestExpectations: Test is passing on iOS 12
platform/ios/TestExpectations: Marking test as flaky on iOS 13

11:28 AM Changeset in webkit [247832] by ysuzuki@apple.com

16 edits in trunk/Source/JavaScriptCore

[JSC] Make visitChildren implementation more idiomatic
https://bugs.webkit.org/show_bug.cgi?id=200121

Reviewed by Mark Lam.

This patch makes visitChildren implementations more idiomatic: cast, assert, and calling Base::visitChildren.
While this does not find interesting issues, it is still nice to have consistent implementations.
StructureChain::visitChildren missed Base::visitChildren, but it does not have much effect since StructureChain
is immortal cell.

bytecode/ExecutableToCodeBlockEdge.cpp:

(JSC::ExecutableToCodeBlockEdge::visitChildren):

runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::visitChildren):

runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::visitChildren):

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::visitChildren):

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

runtime/JSImmutableButterfly.cpp:

(JSC::JSImmutableButterfly::visitChildren):

runtime/JSModuleEnvironment.cpp:

(JSC::JSModuleEnvironment::visitChildren):

runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::visitChildren):

runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::visitChildren):

runtime/JSString.cpp:

(JSC::JSString::visitChildren):

runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::visitChildren):

runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildren):

runtime/SymbolTable.cpp:

(JSC::SymbolTable::visitChildren):

tools/JSDollarVM.cpp:

(JSC::Root::visitChildren):
(JSC::ImpureGetter::visitChildren):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::visitChildren):

11:17 AM Changeset in webkit [247831] by youenn@apple.com

17 edits in trunk/Source/WebKit

Make NetworkSession no longer RefCounted
https://bugs.webkit.org/show_bug.cgi?id=200020

This allows to have a simpler memory management model where
NetworkSession cannot live once removed from the network process session map.
This requires some additional null checks, especially in NetworkDataTask.

Reviewed by Carlos Garcia Campos.

NetworkProcess/curl/NetworkSessionCurl.h:
NetworkProcess/soup/NetworkSessionSoup.h:
NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::NetworkDataTask):

NetworkProcess/NetworkDataTask.h:
NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::~NetworkDataTaskBlob):
(WebKit::NetworkDataTaskBlob::download):

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::setSession):
(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::setResourceLoadStatisticsEnabled):
(WebKit::NetworkProcess::deleteWebsiteDataForRegistrableDomains):

NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::networkSessions):

NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::create):

NetworkProcess/NetworkSession.h:
NetworkProcess/NetworkSocketChannel.cpp:

(WebKit::NetworkSocketChannel::NetworkSocketChannel):
(WebKit::NetworkSocketChannel::~NetworkSocketChannel):

NetworkProcess/NetworkSocketChannel.h:
NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::applySniffingPoliciesAndBindRequestToInferfaceIfNeeded):
(WebKit::computeIsAlwaysOnLoggingAllowed):
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::resume):
(WebKit::NetworkDataTaskCocoa::isAlwaysOnLoggingAllowed const):

NetworkProcess/cocoa/NetworkSessionCocoa.h:
NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate initWithNetworkSession:withCredentials:]):
(WebKit::NetworkSessionCocoa::create):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::createRequest):
(WebKit::NetworkDataTaskSoup::clearRequest):
(WebKit::NetworkDataTaskSoup::cancel):
(WebKit::NetworkDataTaskSoup::authenticateCallback):
(WebKit::NetworkDataTaskSoup::authenticate):
(WebKit::NetworkDataTaskSoup::continueAuthenticate):

11:16 AM Changeset in webkit [247830] by commit-queue@webkit.org

3 edits in trunk/Tools

[Timeline]: Make timeline header width automatic, instead of fixed width
https://bugs.webkit.org/show_bug.cgi?id=200059

Patch by Zhifei Fang <zhifei_fang@apple.com> on 2019-07-25
Reviewed by Jonathan Bedard.

resultsdbpy/resultsdbpy/view/static/css/timeline.css:

(.dot.crash):
(.timeline>.header): Deleted.

resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:

(.timeline>.content):
(.timeline>.header):

11:14 AM Changeset in webkit [247829] by sbarati@apple.com

2 edits in trunk/Source/WebCore

[WHLSL] Add optional logging for phase timings
https://bugs.webkit.org/show_bug.cgi?id=200099

Reviewed by Dean Jackson.

As we're doing WHLSL compiler speedup work, it helps to be able to
log phase times. I think a few of us have written such patches locally.
In this patch, I'm adding a way to easily switch this logging on and
off by flipping a "constexpr bool" and rebuilding.

Modules/webgpu/WHLSL/WHLSLPrepare.cpp:

(WebCore::WHLSL::logPhaseTimes):
(WebCore::WHLSL::PhaseTimer::PhaseTimer):
(WebCore::WHLSL::PhaseTimer::~PhaseTimer):
(WebCore::WHLSL::prepareShared):
(WebCore::WHLSL::prepare):

11:09 AM Changeset in webkit [247828] by Chris Dumez

8 edits in trunk/Source

Avoid some unnecessary HashMap copies
https://bugs.webkit.org/show_bug.cgi?id=200129

Reviewed by Youenn Fablet.

Source/WebCore:

workers/service/server/SWServer.cpp:

(WebCore::SWServer::addRegistrationFromStore):

Source/WebKit:

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didClose):

UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::connect):

UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::ProcessLauncher):

UIProcess/Launcher/ProcessLauncher.h:

(WebKit::ProcessLauncher::create):

WebProcess/Plugins/WebPluginInfoProvider.cpp:

(WebKit::WebPluginInfoProvider::setPluginLoadClientPolicy):

11:04 AM Changeset in webkit [247827] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[WPE] Draw other button types
https://bugs.webkit.org/show_bug.cgi?id=199377

Patch by Joshua Watt <JPEW.hacker@gmail.com> on 2019-07-25
Reviewed by Michael Catanzaro.

There are other button types that should be drawn with the default style
besides just push buttons.

platform/wpe/ThemeWPE.cpp:

(WebCore::ThemeWPE::paint):
(WebCore::ThemeWPE::paintButton):

platform/wpe/ThemeWPE.h:

10:56 AM Changeset in webkit [247826] by commit-queue@webkit.org

3 edits
2 adds in trunk

REGRESSION (r244995): Assertion failure when addEventListener to an SVGElement which has an. instance in shadow tree
https://bugs.webkit.org/show_bug.cgi?id=200083

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-07-25
Reviewed by Ryosuke Niwa.

Source/WebCore:

When adding an event listener to an SVGElement, the same event listener
has to be add to all the instances of SVGElement in the shadow tree. See
SVGElement::addEventListener().

In r244995, an assertion was added to ensure if the event listener is
attached to an event target, the new event target has be the same as the
attached one. This assertion isn't correct for the event targets which
were copied from the targetElement sub tree of an SVGUseElement to the
shadow tree.

Test: svg/custom/add-event-listener-shadow-tree-element.html

bindings/js/JSLazyEventListener.cpp:

(WebCore::isCloneInShadowTreeOfSVGUseElement):
(WebCore::JSLazyEventListener::checkValidityForEventTarget):

LayoutTests:

svg/custom/add-event-listener-shadow-tree-element-expected.txt: Added.
svg/custom/add-event-listener-shadow-tree-element.html: Added.

10:55 AM Changeset in webkit [247825] by Truitt Savell

16 edits
4 deletes in trunk

Unreviewed, rolling out r247821.

Caused two crashing Layout Tests

Reverted changeset:

"Make storing cross-origin top-level prefetches in HTTP cache
optional"
https://bugs.webkit.org/show_bug.cgi?id=199499
https://trac.webkit.org/changeset/247821

10:23 AM Changeset in webkit [247824] by russell_e@apple.com

1 edit
2 adds in trunk/LayoutTests

Adding iOS-specific expectations for fast/text-indicator/text-indicator-with-low-contrast-text.html.
https://bugs.webkit.org/show_bug.cgi?id=200064

Unreviewed Test Gardening.

platform/ios/fast/text-indicator/text-indicator-with-low-contrast-text-expected.txt: Added.

9:07 AM Changeset in webkit [247823] by Michael Catanzaro

3 edits in trunk/Source/WebKit

Unreviewed, fix -Wredundant-move warning spam after r247672
https://bugs.webkit.org/show_bug.cgi?id=199967
<rdar://problem/53351435>

Platform/IPC/ArgumentCoders.cpp:

(IPC::decodeStringText):

Platform/IPC/ArgumentCoders.h:

8:42 AM Changeset in webkit [247822] by Chris Dumez

20 edits
2 adds in trunk

Avoid UI Process hangs when the WebContent process is showing JS prompts / alerts
https://bugs.webkit.org/show_bug.cgi?id=200107
<rdar://problem/53034592>

Reviewed by Geoffrey Garen.

Source/WebCore:

Add testing infrastructure for SendSyncOption::ProcessIncomingSyncMessagesWhenWaitingForSyncReply.

Test: fast/misc/testProcessIncomingSyncMessagesWhenWaitingForSyncReply.html

page/ChromeClient.h:
testing/Internals.cpp:

(WebCore::Internals::testProcessIncomingSyncMessagesWhenWaitingForSyncReply):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

Platform/IPC/Connection.cpp:

(IPC::Connection::SyncMessageState::incrementProcessIncomingSyncMessagesWhenWaitingForSyncReplyCount):
(IPC::Connection::SyncMessageState::decrementProcessIncomingSyncMessagesWhenWaitingForSyncReplyCount):
(IPC::Connection::SyncMessageState::processIncomingMessage):
(IPC::Connection::sendSyncMessage):

Platform/IPC/Connection.h:

Add support for new SendSyncOption::ProcessIncomingSyncMessagesWhenWaitingForSyncReply flag
to allow processing incoming sync messages while sending a particular sync IPC. This is the
default behavior in all processes except in the WebContent process, where we try to avoid
re-entering to prevent bugs. This flag allows the WebContent process to change its default
behavior for some specific IPCs, where we know it is safe to re-enter and where it benefits
performance to re-renter.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::testProcessIncomingSyncMessagesWhenWaitingForSyncReply):

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didReceiveSyncMessage):
(WebKit::NetworkProcessProxy::testProcessIncomingSyncMessagesWhenWaitingForSyncReply):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::testProcessIncomingSyncMessagesWhenWaitingForSyncReply):

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::testProcessIncomingSyncMessagesWhenWaitingForSyncReply):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::sendSyncWithDelayedReply):

WebProcess/WebPage/WebPage.messages.in:

SendSyncOption::ProcessIncomingSyncMessagesWhenWaitingForSyncReply
Add testing infrastructure for SendSyncOption::ProcessIncomingSyncMessagesWhenWaitingForSyncReply
flag.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
Use new SendSyncOption::ProcessIncomingSyncMessagesWhenWaitingForSyncReply flag when sending
the synchronous IPC for JS alerts / prompt / confirm. This allows the WebProcess to process
incoming synchronous IPC for other processes (in particular the UIProcess) while it is blocked
on those synchronous IPCs. It is safe to re-enter the WebContent process on these sync IPCs
since they are triggered by JS and we return to JS right after. This should avoid UIProcess
hangs when the UIProcess is sending a sync IPC to the WebContent process, which is itself
stuck on the sync IPC to show a JS alert.

LayoutTests:

Add layout test coverage for SendSyncOption::ProcessIncomingSyncMessagesWhenWaitingForSyncReply.
Without the flag on the sendSync from the WebContent process of the
NetworkConnectionToWebProcess::TestProcessIncomingSyncMessagesWhenWaitingForSyncReply IPC, the
test would hang. This is because the WebContent process sends a sync IPC to the network process,
which in turns sends one to the UIProcess, which itself sends one back to the WebContent process.
This would attempt to re-enter the WebContent process which is currently sending a sync IPC, which
is not allowed by default.

fast/misc/testProcessIncomingSyncMessagesWhenWaitingForSyncReply-expected.txt: Added.
fast/misc/testProcessIncomingSyncMessagesWhenWaitingForSyncReply.html: Added.

8:37 AM Changeset in webkit [247821] by commit-queue@webkit.org

16 edits
4 adds in trunk

Make storing cross-origin top-level prefetches in HTTP cache optional
https://bugs.webkit.org/show_bug.cgi?id=199499

Patch by Rob Buis <rbuis@igalia.com> on 2019-07-25
Reviewed by Youenn Fablet.

Source/WebCore:

Add Internals API for adding an event listener to prefetch load.

Test: http/wpt/prefetch/link-prefetch-skip-disk-cache.html

bindings/js/JSEventListener.h:
dom/EventTarget.h:

(WebCore::EventTarget::addEventListener):

dom/Node.h:
html/HTMLLinkElement.h:
testing/Internals.cpp:

(WebCore::Internals::addPrefetchLoadEventListener):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

Currently when we navigate we check if there is a cross-origin top-level
prefetch we can use for the navigation. The current solution uses the
HTTP cache as a way to store the prefetch and to immediately use it for
the navigation load. However this solution fails in case the prefetch is
not cacheable.

Instead of this, simulate a HTTP Cache entry to process the load and
afterwards try to store the navigation load into the HTTP cache, where
normal store decisions will be applied.

Test: http/wpt/prefetch/link-prefetch-skip-disk-cache.html

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::retrieveCacheEntryInternal):

NetworkProcess/NetworkResourceLoader.h:

LayoutTests:

Remove unneeded Cache-Control headers and verify that Cache-Control
effects whether the navigation gets stored in the disk cache or not.

http/tests/cache/resources/prefetched-main-resource-iframe.php:
http/tests/cache/resources/prefetched-main-resource.php:
http/wpt/prefetch/link-prefetch-skip-disk-cache-expected.txt: Added.
http/wpt/prefetch/link-prefetch-skip-disk-cache.html: Added.
http/wpt/prefetch/resources/main-resource-skip-disk-cache.py: Added.

(main):

http/wpt/prefetch/resources/navigate-skip-disk-cache.html: Added.
platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:

8:35 AM Changeset in webkit [247820] by Truitt Savell

17 edits in trunk

Unreviewed, rolling out r247817.

Broke 14 http/tests/paymentrequest/ tests. on iOS

Reverted changeset:

"Unable to tap/double tap to open files/folders in Google
Drive in Safari"
https://bugs.webkit.org/show_bug.cgi?id=200096
https://trac.webkit.org/changeset/247817

12:50 AM Changeset in webkit [247819] by Ross Kirsling

13 edits
1 add in trunk

[ESNext] Implement nullish coalescing
https://bugs.webkit.org/show_bug.cgi?id=200072

Reviewed by Darin Adler.

JSTests:

stress/nullish-coalescing.js: Added.

Source/JavaScriptCore:

Implement the nullish coalescing proposal, which has now reached Stage 3 at TC39.

This introduces a ?? operator which:

acts like

but checks for nullishness instead of truthiness

has a precedence lower than

(or any other binary operator)

must be disambiguated with parentheses when combined with

or &&

bytecompiler/NodesCodegen.cpp:

(JSC::CoalesceNode::emitBytecode): Added.
Bytecode must use OpIsUndefinedOrNull and not OpNeqNull because of document.all.

parser/ASTBuilder.h:

(JSC::ASTBuilder::makeBinaryNode):

parser/Lexer.cpp:

(JSC::Lexer<T>::lexWithoutClearingLineTerminator):

parser/NodeConstructors.h:

(JSC::CoalesceNode::CoalesceNode): Added.

parser/Nodes.h:

Introduce new token and AST node.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseBinaryExpression):
Implement early error.

parser/ParserTokens.h:

Since this patch needs to shift the value of every binary operator token anyway,
let's only bother to increment their LSBs when we actually have a precedence conflict.

parser/ResultType.h:

(JSC::ResultType::definitelyIsNull const): Added.
(JSC::ResultType::mightBeUndefinedOrNull const): Added.
(JSC::ResultType::forCoalesce): Added.
We can do better than forLogicalOp here; let's be as accurate as possible.

runtime/Options.h:

Add runtime feature flag.

Tools:

Scripts/run-jsc-stress-tests:

Jul 24, 2019:

10:35 PM Changeset in webkit [247818] by Fujii Hironori

2 edits in trunk/Tools

Add Takashi Komori and Tomoki Imai as contributors

Unreviewed.

Scripts/webkitpy/common/config/contributors.json:

9:50 PM Changeset in webkit [247817] by Alan Bujtas

17 edits in trunk

Unable to tap/double tap to open files/folders in Google Drive in Safari
https://bugs.webkit.org/show_bug.cgi?id=200096
<rdar://problem/52748552>

Reviewed by Wenson Hsieh.

Source/WebKit:

This patch reverts to the original double-tap-for-double-click implementation (see r244775 and r246347 for more information).

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

UIProcess/WebPageProxy.h:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::doubleTapForDoubleClickDelay): Deleted.
(WebKit::PageClientImpl::doubleTapForDoubleClickRadius): Deleted.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]): Do not recognize the single and double gestures the same time.
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _doubleTapRecognizedForDoubleClick:]):
(-[WKContentView _didStartProvisionalLoadForMainFrame]):
(-[WKContentView _ensureNonBlockingDoubleTapGestureRecognizer]): Deleted.
(-[WKContentView _doubleTapForDoubleClickDelay]): Deleted.
(-[WKContentView _doubleTapForDoubleClickRadius]): Deleted.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::handleDoubleTapForDoubleClickAtPoint):

WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleDoubleTapForDoubleClickAtPoint):
(WebKit::WebPage::commitPotentialTap):
(WebKit::WebPage::handlePotentialDoubleTapForDoubleClickAtPoint): Deleted.

LayoutTests:

Rebaseline.

fast/events/touch/ios/double-tap-for-double-click3-expected.txt:

9:46 PM Changeset in webkit [247816] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari Technology Preview/Safari Technology Preview 88

Added a tag for Safari Technology Preview release 88.

8:42 PM Changeset in webkit [247815] by ysuzuki@apple.com

18 edits
1 copy
1 move
1 add in trunk

[bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
https://bugs.webkit.org/show_bug.cgi?id=200103

Reviewed by Mark Lam.

Source/bmalloc:

bmalloc/IsoPage.cpp:

Source/WebCore:

No behavior change in WebCore.

page/MemoryRelease.cpp:
page/ResourceUsageThread.h:

(WebCore::TagInfo::TagInfo): Deleted.

page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::vmPageSize): Deleted.
(WebCore::logFootprintComparison): Deleted.
(WebCore::displayNameForVMTag): Deleted.
(WebCore::pagesPerVMTag): Deleted.

Source/WebCore/PAL:

Move VMTag page memory investigation code from PAL to WTF to reuse it in TestWTF.

PAL.xcodeproj/project.pbxproj:
pal/PlatformMac.cmake:

Source/WebKit:

Move MachVMSPI.h from PAL to WTF.

Platform/cocoa/SharedMemoryCocoa.cpp:

Source/WTF:

We move VMTag page investigation code from PAL to WTF to use it in TestWTF.
And we also accumulate allocated VA size in reserved field of TagInfo.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/PlatformMac.cmake:
wtf/ResourceUsage.h: Added.
wtf/cocoa/MemoryPressureHandlerCocoa.mm:
wtf/cocoa/ResourceUsageCocoa.cpp: Added.

(WTF::vmPageSize):
(WTF::logFootprintComparison):
(WTF::displayNameForVMTag):
(WTF::pagesPerVMTag):

wtf/spi/cocoa/MachVMSPI.h: Added.

Tools:

This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.

While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
to the future implementation changes while it catches the severe issues we had.

TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:

(assertEmptyPointerSet):
(assertHasOnlyObjects):
(assertClean):
(TEST):
(allocateAndDeallocate):

8:35 PM Changeset in webkit [247814] by Devin Rousso

5 edits in trunk

Web Inspector: support console.screenshot with detached Nodes that are graphical
https://bugs.webkit.org/show_bug.cgi?id=199309

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector/console/console-screenshot.html

page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

LayoutTests:

inspector/console/console-screenshot.html:
inspector/console/console-screenshot-expected.txt:

7:40 PM Changeset in webkit [247813] by sbarati@apple.com

71 edits in trunk/Source/WebCore

[WHLSL] Use bmalloc instead of system malloc for WHLSL data structures
https://bugs.webkit.org/show_bug.cgi?id=200063

Rubber-stamped by Sam Weinig.

This is a 25-30% WHLSL compile time speedup on Justin's textured-cube demo
and a ~40% compile time speedup on the hello-cube demo.

The phases that speed up from this are:
checker
includeStandardLibrary
autoInitializeVariables
resolveProperties

Modules/webgpu/WHLSL/AST/WHLSLAddressSpace.h:
Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
Modules/webgpu/WHLSL/AST/WHLSLAssignmentExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h:
Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h:
Modules/webgpu/WHLSL/AST/WHLSLBlock.h:
Modules/webgpu/WHLSL/AST/WHLSLBooleanLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLBreak.h:
Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.h:
Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLCommaExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLConstantExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLContinue.h:
Modules/webgpu/WHLSL/AST/WHLSLDereferenceExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLDoWhileLoop.h:
Modules/webgpu/WHLSL/AST/WHLSLDotExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLEffectfulExpressionStatement.h:
Modules/webgpu/WHLSL/AST/WHLSLEnumerationDefinition.h:
Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h:
Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLFallthrough.h:
Modules/webgpu/WHLSL/AST/WHLSLFloatLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h:
Modules/webgpu/WHLSL/AST/WHLSLForLoop.h:
Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h:
Modules/webgpu/WHLSL/AST/WHLSLFunctionDefinition.h:
Modules/webgpu/WHLSL/AST/WHLSLGlobalVariableReference.h:
Modules/webgpu/WHLSL/AST/WHLSLIfStatement.h:
Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h:
Modules/webgpu/WHLSL/AST/WHLSLLogicalExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLLogicalNotExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLMakeArrayReferenceExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLMakePointerExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLNamedType.h:
Modules/webgpu/WHLSL/AST/WHLSLNativeFunctionDeclaration.h:
Modules/webgpu/WHLSL/AST/WHLSLNativeTypeDeclaration.h:
Modules/webgpu/WHLSL/AST/WHLSLNullLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLNullLiteralType.h:
Modules/webgpu/WHLSL/AST/WHLSLNumThreadsFunctionAttribute.h:
Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
Modules/webgpu/WHLSL/AST/WHLSLPropertyAccessExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
Modules/webgpu/WHLSL/AST/WHLSLResolvableType.h:
Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.h:
Modules/webgpu/WHLSL/AST/WHLSLReturn.h:
Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.h:
Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.h:
Modules/webgpu/WHLSL/AST/WHLSLStatement.h:
Modules/webgpu/WHLSL/AST/WHLSLStatementList.h:
Modules/webgpu/WHLSL/AST/WHLSLStructureDefinition.h:
Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h:
Modules/webgpu/WHLSL/AST/WHLSLSwitchCase.h:
Modules/webgpu/WHLSL/AST/WHLSLSwitchStatement.h:
Modules/webgpu/WHLSL/AST/WHLSLTernaryExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLType.h:
Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h:
Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:
Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.h:
Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h:
Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h:
Modules/webgpu/WHLSL/AST/WHLSLVariableDeclarationsStatement.h:
Modules/webgpu/WHLSL/AST/WHLSLVariableReference.h:
Modules/webgpu/WHLSL/AST/WHLSLWhileLoop.h:
Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp:

7:25 PM Changeset in webkit [247812] by Devin Rousso

5 edits in trunk

Web Inspector: support console.screenshot with ImageData and ImageBitmap
https://bugs.webkit.org/show_bug.cgi?id=199304

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector/console/console-screenshot.html

page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

LayoutTests:

inspector/console/console-screenshot.html:
inspector/console/console-screenshot-expected.txt:

7:09 PM Changeset in webkit [247811] by commit-queue@webkit.org

5 edits in trunk

Three checks are missing in Proxy internal methods
https://bugs.webkit.org/show_bug.cgi?id=198630

Patch by Alexey Shvayka <Alexey Shvayka> on 2019-07-24
Reviewed by Darin Adler.

JSTests:

stress/proxy-delete.js: Assert isExtensible is called in correct order.
test262/expectations.yaml: Mark 6 test cases as passing.

Source/JavaScriptCore:

Add three missing checks in Proxy internal methods.
These checks are necessary to maintain the invariants of the essential internal methods.
(https://github.com/tc39/ecma262/pull/666)

GetOwnProperty shouldn't return non-configurable and non-writable descriptor when the target's property is writable.
Delete should return false when the target has property and is not extensible.
DefineOwnProperty should return true for a non-writable input descriptor when the target's property is non-configurable and writable.

Shipping in SpiderMonkey since https://hg.mozilla.org/integration/autoland/rev/3a06bc818bc4 (version 69)
Shipping in V8 since https://chromium.googlesource.com/v8/v8.git/+/e846ad9fa5109428be50b1989314e0e4e7267919

runtime/ProxyObject.cpp:

(JSC::ProxyObject::performInternalMethodGetOwnProperty): Add writability check.
(JSC::ProxyObject::performDelete): Add extensibility check.
(JSC::ProxyObject::performDefineOwnProperty): Add writability check.

7:04 PM Changeset in webkit [247810] by Fujii Hironori

4 edits in trunk

[CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
https://bugs.webkit.org/show_bug.cgi?id=200074

Patch by Fujii Hironori <fujii.hironori@gmail.com> on 2019-07-24
Reviewed by Michael Catanzaro.

Although WebKitCompilerFlags.cmake adds "-Wl,--no-undefined" to
CMAKE_SHARED_LINKER_FLAGS, it wasn't effective because
OptionsCommon.cmake inadvertently override the value with
CMAKE_EXE_LINKER_FLAGS as:

set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ...")

Source/cmake/OptionsCommon.cmake: Use string(APPEND) to modify

CMAKE_*_LINKER_FLAGS variables to avoid typos.

Tools:

There was a latent issue. PluginTest::indicateTestFailure was
using WTF::sleep without linking WTF.

DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:

Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.

7:02 PM Changeset in webkit [247809] by Fujii Hironori

3 edits in trunk/Tools

[GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
https://bugs.webkit.org/show_bug.cgi?id=200073

Patch by Fujii Hironori <fujii.hironori@gmail.com> on 2019-07-24
Reviewed by Michael Catanzaro.

TestWebKitAPI/PlatformGTK.cmake:
TestWebKitAPI/PlatformWPE.cmake:

Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).

7:00 PM Changeset in webkit [247808] by Fujii Hironori

3 edits in trunk/Tools

[webkitperl] runCommand doesn't work in Windows Perl
https://bugs.webkit.org/show_bug.cgi?id=199900

Reviewed by Don Olmstead.

runCommand was always failing implicit fork by using 'open' with
'-|' in Windows Perl. Explicitly specify the command to 'open' not
to do the implicit fork.

There is one more difference between Windows and Unix. 'open'
successes on Windows even for non existent command while it fails
on Unix. So, return the same error code on Unix as well as
Windows.

Scripts/VCSUtils.pm: Specified the command to 'open'.
Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'

command is not available on Windows. Use Perl ($^{X) instead.}

6:18 PM Changeset in webkit [247807] by Alan Coon

1 copy in tags/Safari-608.1.38

Tag Safari-608.1.38.

5:55 PM Changeset in webkit [247806] by youenn@apple.com

3 edits
5 adds in trunk

Disable speculative loading if cache is not to be used for the load
https://bugs.webkit.org/show_bug.cgi?id=199644

Reviewed by Alex Christensen.

Source/WebKit:

When the page is reloaded, loads are instructed to not use the cache.
It is therefore unneeded to do speculative revalidation.
Allow speculative revalidation if the cache policy is either the default HTTP policy or
if policy is to refresh all cache data.
Covered by added test.

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::cachePolicyValidForSpeculativeRevalidation):
(WebKit::NetworkCache::canRequestUseSpeculativeRevalidation):

LayoutTests:

http/wpt/fetch/disable-speculative-for-reload-expected.txt: Added.
http/wpt/fetch/disable-speculative-for-reload.html: Added.
http/wpt/fetch/resources/iframe-with-image.py: Added.

(main):

http/wpt/fetch/resources/image-load-count.py: Added.

(main):

http/wpt/fetch/resources/image-load.py: Added.

(main):

5:52 PM Changeset in webkit [247805] by Devin Rousso

2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION: Overlay: highlighting a ::before/::after shows the node info of the parent instead
https://bugs.webkit.org/show_bug.cgi?id=200051

Reviewed by Joseph Pecoraro.

When highlighting a pseudo-element, only use the parent node for selector information. All
rendering data should still come from the pseudo-element itself.

inspector/InspectorOverlay.cpp:

(WebCore::drawShapeHighlight):
(WebCore::InspectorOverlay::drawElementTitle):

5:44 PM Changeset in webkit [247804] by commit-queue@webkit.org

8 edits in trunk

Source/WebKit:
Allow Clients to Add Fields to the AutoFillContext Dictionary
https://bugs.webkit.org/show_bug.cgi?id=199326
rdar://problem/42816957

Patch by Priyanka Agarwal <pagarwal999@apple.com> on 2019-07-24
Reviewed by Wenson Hsieh.

UIProcess/API/Cocoa/_WKInputDelegate.h:

Added function declaration for function which returns additional dictionary for autofillcontext

UIProcess/ios/WKContentViewInteraction.h:

Created dictionary for additional autofillcontext

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
Populating additional dictionary for autofillcontext

(-[WKContentView _autofillContext]):
Adding new dictionary to the returned autofillcontext

Tools:
Allow Clients to Add Fields to the AutoFillContext Dictionary.
https://bugs.webkit.org/show_bug.cgi?id=199326
rdar://problem/42816957

Patch by Priyanka Agarwal <pagarwal999@apple.com> on 2019-07-24
Reviewed by Wenson Hsieh.

TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

(TestWebKitAPI::TEST): Created a test to check that the auto fill context
is being properly populated with additional context dictionary.

TestWebKitAPI/Tests/ios/TestInputDelegate.h:
TestWebKitAPI/Tests/ios/TestInputDelegate.mm:

(-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
which will populate the additional autofill context dictionary.

(-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
populates the additional autofill context dictionary.

(-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
context dictionary.

(-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
input field requires strong password work.

(-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
input field requires strong password work.

(-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
password work.

5:42 PM Changeset in webkit [247803] by Devin Rousso

8 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: no context menu items work when context menu clicking on "Add Breakpoint"
https://bugs.webkit.org/show_bug.cgi?id=199953

Reviewed by Joseph Pecoraro.

UserInterface/Views/ContextMenuUtilities.js:

(WI.addMouseDownContextMenuHandlers): Added.
Create a helper function for managing elements that show a context menu on "mousedown".

UserInterface/Base/SearchUtilities.js:

(WI.SearchUtilities.createSettingsButton):

UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype.initialLayout):
(WI.CanvasContentView.prototype._populateCanvasElementButtonContextMenu): Added.
(WI.CanvasContentView.prototype._populateViewShaderButtonContextMenu): Added.
(WI.CanvasContentView.prototype._populateViewRecordingButtonContextMenu): Added.
(WI.CanvasContentView.prototype._handleCanvasElementButtonMouseDown): Deleted.
(WI.CanvasContentView.prototype._handleViewShaderButtonMouseDown): Deleted.
(WI.CanvasContentView.prototype._handleViewRecordingButtonMouseDown): Deleted.

UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel):
(WI.DebuggerSidebarPanel.prototype._populateCreateBreakpointContextMenu): Added.
(WI.DebuggerSidebarPanel.prototype._handleCreateBreakpointMouseDown): Deleted.

UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._populateResourceGroupingModeContextMenu): Added.
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu): Added.
(WI.SourcesNavigationSidebarPanel.prototype._handleResourceGroupingModeMouseDown): Deleted.
(WI.SourcesNavigationSidebarPanel.prototype._handleCreateBreakpointMouseDown): Deleted.

UserInterface/Views/TabBar.js:

(WI.TabBar):
(WI.TabBar.prototype._handleTabPickerTabContextMenu): Deleted.

UserInterface/Views/LegacyTabBar.js:

(WI.LegacyTabBar):
(WI.LegacyTabBar.prototype._handleTabPickerTabContextMenu): Deleted.
Remove the "contextmenu" handler on the tab picker, as that's already used by the entire
tab bar to show/hide tabs.

5:21 PM Changeset in webkit [247802] by Devin Rousso

5 edits in trunk

Web Inspector: support console.screenshot with subclasses of CanvasRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=199305

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector/console/console-screenshot.html

page/PageConsoleClient.cpp:

(WebCore::canvasRenderingContext):
(WebCore::PageConsoleClient::record):
(WebCore::PageConsoleClient::recordEnd):
(WebCore::PageConsoleClient::screenshot):

LayoutTests:

inspector/console/console-screenshot.html:
inspector/console/console-screenshot-expected.txt:

5:10 PM Changeset in webkit [247801] by mark.lam@apple.com

5 edits in trunk/Source/JavaScriptCore

Remove some unused code.
https://bugs.webkit.org/show_bug.cgi?id=200101

Reviewed by Yusuke Suzuki.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::zap): Deleted.

heap/MarkedBlock.h:
heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendToMutatorMarkStack): Deleted.

heap/SlotVisitor.h:

4:51 PM Changeset in webkit [247800] by youenn@apple.com

10 edits in trunk/Source/WebCore

Remove MediaPlayerPrivate::supportsMuting()
https://bugs.webkit.org/show_bug.cgi?id=200005

Reviewed by Eric Carlson.

Remove no longer needed interface method.
No change of behavior.

WebCore.order:
platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setVolume):
(WebCore::MediaPlayer::setMuted):

platform/graphics/MediaPlayerPrivate.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:

4:51 PM Changeset in webkit [247799] by mark.lam@apple.com

4 edits in trunk/Source/JavaScriptCore

performJITMemcpy should be PACed with a non-zero diversifier when passed and called via a pointer.
https://bugs.webkit.org/show_bug.cgi?id=200100
<rdar://problem/53474939>

Reviewed by Yusuke Suzuki.

assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::CopyFunction::CopyFunction):
(JSC::ARM64Assembler::CopyFunction::operator()):

I choose to use ptrauth_auth_function() here instead of retagCodePtr() because retagCodePtr() would auth, assert, and re-pac the pointer. This is needed in general because retagCodePtr() doesn't know that you will consume the pointer immediately (and therefore crash imminently if a failed auth is encountered). Since we know here that we will call with the auth'ed pointer immediately, we can skip the assert.

This also has the benefit of letting Clang do a peephole optimization to emit
a blrab instruction with the intended diversifier, instead of emitting multiple
instructions to auth the pointer into a C function, and then using a blraaz to
do a C function call.

(JSC::ARM64Assembler::linkJumpOrCall):
(JSC::ARM64Assembler::linkCompareAndBranch):
(JSC::ARM64Assembler::linkConditionalBranch):
(JSC::ARM64Assembler::linkTestAndBranch):

assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):

runtime/JSCPtrTag.h:

4:07 PM Changeset in webkit [247798] by Alan Coon

10 edits in branches/safari-608.1-branch/Source

Cherry-pick r247746. rdar://problem/53483298

[iOS] Tapping the search field on a search results page on zillow.com shows and immediately dismisses the keyboard
https://bugs.webkit.org/show_bug.cgi?id=200044
<rdar://problem/53103732>

Reviewed by Wenson Hsieh.

Source/WebCore:

The keyboard gets dismissed as the result of scroll event.
The (horizontal)scroll event is initiated by WebKit as we try to re-center the content.
The content gets off-centered as the result of the newly constructed drop-down menu which slightly sticks out of the document to the right (layout overflows).

It works with shipping version of iOS because _zoomToFocusRect operates on stale viewport information (see r244494 for the progression).
This patch applies a site specific quirk to restore shipping behavior.

page/Quirks.cpp: (WebCore::Quirks::shouldAvoidScrollingWhenFocusedContentIsVisible const):
page/Quirks.h:

Source/WebKit:

Shared/FocusedElementInformation.cpp: (WebKit::FocusedElementInformation::encode const): (WebKit::FocusedElementInformation::decode):
Shared/FocusedElementInformation.h:
UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _zoomToFocusRect:selectionRect:insideFixed:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]):
UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _elementDidBlur]): (-[WKContentView _shouldAvoidScrollingWhenFocusedContentIsVisible]):
WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getFocusedElementInformation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:07 PM Changeset in webkit [247797] by Alan Coon

12 edits
2 adds in branches/safari-608.1-branch

Cherry-pick r247674. rdar://problem/53483295

[iOS] Fast and complex text codepaths disagree about how to lay out bopomofo with tone marks
https://bugs.webkit.org/show_bug.cgi?id=199912
<rdar://problem/52182454>

Reviewed by Simon Fraser.

Source/WebCore:

This is because CoreText has special composition rules for CJK languages, which we don't have in our simple
text codepath. Rather than implementing the composition rules in WebKit, we can simply disable them in
CoreText.

Test: fast/text/international/system-language/composition.html

platform/graphics/mac/SimpleFontDataCoreText.cpp: (WebCore::Font::getCFStringAttributes const):

Source/WebCore/PAL:

pal/spi/cocoa/CoreTextSPI.h:

LayoutTests:

css3/font-feature-font-face-local-expected.html:
css3/font-feature-font-face-local.html:
editing/mac/selection/word-thai-expected.txt:
editing/mac/selection/word-thai.html:
fast/text/international/system-language/composition-expected.txt: Added.
fast/text/international/system-language/composition.html: Added.
platform/ios/fast/text/crash-complex-text-surrogate-expected.txt:
svg/custom/glyph-selection-arabic-forms-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:07 PM Changeset in webkit [247796] by Alan Coon

19 edits
2 adds in branches/safari-608.1-branch

Cherry-pick r247671. rdar://problem/53501841

Add accessibilityInsertText for text insertion in edit fields.
https://bugs.webkit.org/show_bug.cgi?id=199973

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-07-20
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: accessibility/insert-newline.html

accessibility/ios-simulator/insert-newline.html

Accessibility clients like VoiceOver and Voice Control were entering
text in text fields by replacing the entire content of the field
(SetValue) and then setting the insertion point to the appropriate
offset (SetSelectedTextRange). accessibilityInsertText gives a simpler
interface to clients to insert text at the insertion point location.
In addition, this provides a workaround for the issue encountered with
the previous method when inserting a linebreak.

accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::insertText):
accessibility/AccessibilityObject.h:
accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper accessibilityInsertText:]):
accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityInsertText:]):

Tools:

Glue code to run new LayoutTests.

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::insertText):
WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::insertText):
WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::insertText):
WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: (WTR::AccessibilityUIElement::insertText):

LayoutTests:

Tests for inserting a newline in the middle of a text line and checking
that the insertion point and text ranges are correct.

accessibility/insert-newline-expected.txt: Added.
accessibility/insert-newline.html: Added.
accessibility/ios-simulator/insert-newline-expected.txt: Added.
accessibility/ios-simulator/insert-newline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:07 PM Changeset in webkit [247795] by Alan Coon

4 edits in branches/safari-608.1-branch/Source/WebKitLegacy

Apply patch. rdar://problem/53458020

Disable Web Animations in WebKitLegacy https://bugs.webkit.org/show_bug.cgi?id=200041 <rdar://problem/53458020>

Reviewed by Jon Lee.

We want this disabled for WebKitLegacy in shipping branches.

Source/WebKitLegacy/mac:

WebView/WebPreferences.mm: (+[WebPreferences initialize]):

Source/WebKitLegacy/win:

WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

4:07 PM Changeset in webkit [247794] by Alan Coon

12 edits in branches/safari-608.1-branch

Apply patch. rdar://problem/53457282

Disable ENABLE_LAYOUT_FORMATTING_CONTEXT https://bugs.webkit.org/show_bug.cgi?id=200038 <rdar://problem/53457282>

Reviewed by Zalan Bujtas.

This feature is not complete. It is enabled for the trunk, but needs
to be disabled in branches for shipping products.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests -- this change does not add any new functionality.

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

3:56 PM Changeset in webkit [247793] by Chris Dumez

4 edits in trunk/Source

Regression(r247400): Unable to log into AIB Mobile Banking App
https://bugs.webkit.org/show_bug.cgi?id=200094
<rdar://problem/52519818>

Reviewed by Brent Fulgham.

In r247400, a change was made to only set the 'app has universal sandbox access' flag
only when issueing the sandbox extension for / actually succeeded (it usually fails
in practice). Previously, AIB Mobile Banking app was relying on this behavior to
trigger a load for file:///login which is outside their container. However, now that
the 'app has universal sandbox access' flag is no longer set, it trips our security
checks and the load gets ignored.

To address the issue, apply only the 'app has universal sandbox access' flag fix with
a linked-on-after check.

UIProcess/Cocoa/VersionChecks.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

3:36 PM Changeset in webkit [247792] by timothy_horton@apple.com

8 edits
2 adds in trunk

Daring Fireball long press highlights are unnecessarily inflated due to false illegibility
https://bugs.webkit.org/show_bug.cgi?id=200064

Reviewed by Geoff Garen.

Source/WebCore:

If we consider text illegible on the given estimated background color,
we bail from doing a tightly fitted selection-only TextIndicator and
instead just paint the page without modification into the indicator,
causing ugly overlap and an excessively inflated indicator.

Change the mechanism we use to determine illegibility to be based on
a standard, instead of a constant chosen by hand 13 years ago.

Test: fast/text-indicator/text-indicator-with-low-contrast-text.html

platform/graphics/ColorUtilities.cpp:

(WebCore::luminance):
Fix a typo.

(WebCore::contrastRatio):
Add a function that computes the contrast ratio given two colors using
the formula from WCAG.

platform/graphics/ColorUtilities.h:
rendering/TextPaintStyle.cpp:

(WebCore::textColorIsLegibleAgainstBackgroundColor):
Make use of WCAG's minimum legible contrast ratio instead of an
arbitrary color difference cutoff for determining whether we consider
text legible. It seems sensible and also considers the text on DF readable
(which it seems to be to me!).

testing/Internals.cpp:

(WebCore::Internals::TextIndicatorInfo::TextIndicatorInfo):

testing/Internals.h:
testing/Internals.idl:

Expose all of the text rects to Internals, not just the bounding rect.
Expose some more TextIndicator options to Internals so that we can
turn on the legibility mechanism.

LayoutTests:

fast/text-indicator/text-indicator-with-low-contrast-text-expected.txt: Added.
fast/text-indicator/text-indicator-with-low-contrast-text.html: Added.

2:44 PM Changeset in webkit [247791] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Module-enabled users of WKWebProcessPlugInFrame.h fail to build; duplicate declaration
https://bugs.webkit.org/show_bug.cgi?id=200095
<rdar://problem/53512407>

Reviewed by Wenson Hsieh.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:

Import <JavaScriptCore/JavaScriptCore.h> (the module header) instead of
<JavaScriptCore/JSContext.h> directly, otherwise we can end up getting
JSContext.h included twice, to the compiler's chagrin.

2:39 PM Changeset in webkit [247790] by Devin Rousso

14 edits in trunk

Web Inspector: print the target of console.screenshot last so the target is the closest item to the image
https://bugs.webkit.org/show_bug.cgi?id=199308

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

inspector/ConsoleMessage.h:

(Inspector::ConsoleMessage::arguments const):

inspector/ScriptArguments.h:
inspector/ScriptArguments.cpp:

(Inspector::ScriptArguments::getFirstArgumentAsString const): Added.
(Inspector::ScriptArguments::getFirstArgumentAsString): Deleted.

Source/WebCore:

Right now, evaluating console.screenshot(document, "test", 1); will log a message to the
console with #document, "test", and 1, all on different lines (togglable by a
disclosure triangle) since #document isn't stringifiable.

The ideal situation would be to have "test" and 1 logged on the same line, and then have
#document be in a disclosure triangle. This way, you can "label" your images using
additional arguments (e.g. console.screenshot(document.images[1], "second image");), as
well as provide other data.

If the only argument was the target, it should print as if it was console.log(target);.

If there are no arguments, it should print the text "Viewport"` before the image.

Test: inspector/console/console-screenshot.html

page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::addMessage):
(WebCore::PageConsoleClient::screenshot):

Source/WebInspectorUI:

UserInterface/Views/ConsoleMessageView.js:

(WI.ConsoleMessageView.prototype.render):
(WI.ConsoleMessageView.prototype._appendMessageTextAndArguments):
(WI.ConsoleMessageView.prototype._handleContextMenu):

UserInterface/Views/ConsoleMessageView.css:

(.console-image > .console-message-body > :matches(hr, img)): Added.
(.console-image > .console-message-body > hr): Added.
(.console-image > .console-message-body > img): Added.
(.console-log-level.console-image::before): Added.
(.console-message-body > .console-image): Deleted.
(.console-log-level.console-image-container::before): Deleted.
Allow ConsoleMessage.MessageType.Image to be an ConsoleMessage.MessageLevel.Error, and
print the message (and extra parameters) in that case.
Drive-by: reorganize the switch-case so all paths have the same default case.

Localizations/en.lproj/localizedStrings.js:

LayoutTests:

inspector/console/console-expected.txt:
inspector/console/console-screenshot.html:
inspector/console/console-screenshot-expected.txt:

1:44 PM Changeset in webkit [247789] by Ryan Haddad

2 edits
1 copy
2 adds in trunk/LayoutTests

Unreviewed test gardening, land expectations for rdar://53324867.

platform/ios-12/fast/events/touch/ios/pointer-events-with-modifiers-expected.txt: Copied from LayoutTests/platform/ios/fast/events/touch/ios/pointer-events-with-modifiers-expected.txt.
platform/ios/fast/events/touch/ios/pointer-events-with-modifiers-expected.txt:

1:31 PM Changeset in webkit [247788] by aboya@igalia.com

1 edit
1 add in trunk/LayoutTests/imported/w3c

Unreviewed: Added missing expectation file for video_crash_empty_src.html
https://bugs.webkit.org/show_bug.cgi?id=200081

web-platform-tests/html/semantics/embedded-content/the-video-element/video_crash_empty_src-expected.txt: Added.

1:28 PM Changeset in webkit [247787] by beidson@apple.com

2 edits in trunk/Source/WebKit

Crash in WebContent process with custom schemes.
<rdar://problem/52968793> and https://bugs.webkit.org/show_bug.cgi?id=200062

Reviewed by Andy Estes.

Almost everywhere in WebURLSchemeTaskProxy where we call processNextPendingTask() we first protect the task with a ref.
But not in didReceiveData.
So lets do that.

WebProcess/WebPage/WebURLSchemeTaskProxy.cpp:

(WebKit::WebURLSchemeTaskProxy::didReceiveData): Protect this.

1:18 PM Changeset in webkit [247786] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Null check CompletionHandler in WebPreviewLoaderClient::didReceivePassword
https://bugs.webkit.org/show_bug.cgi?id=200080
<rdar://problem/37275772>

Patch by Alex Christensen <achristensen@webkit.org> on 2019-07-24
Reviewed by Chris Dumez.

WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp:

(WebKit::WebPreviewLoaderClient::didReceivePassword):

1:12 PM Changeset in webkit [247785] by Ryan Haddad

2 edits in trunk/LayoutTests

Unreviewed, update test expectations for Catalina.

platform/mac/TestExpectations:

12:21 PM Changeset in webkit [247784] by Chris Dumez

5 edits in trunk/Source/WebKit

Crash under WebKit:WTF::Detail::CallableWrapper<WebKit::ResourceLoadStatisticsMemoryStore::updateCookieBlocking(WTF::CompletionHandler<void ()>&&)::$_32::operator()()::'lambda'(), void>::call
https://bugs.webkit.org/show_bug.cgi?id=200071
<rdar://problem/53335583>

Reviewed by Brent Fulgham and Youenn Fablet.

The WebResourceLoadStatisticsStore is a main thread object. In its destructor, it was dispatching
to the background queue to destroy the m_statisticsStore / m_persistentStorage data members, which
live on the background queue. It would then synchronously wait for the background queue to finish
destroying them. The idea was to guarantee that the ResourceLoadStatisticsMemoryStore and the
ResourceLoadStatisticsPersistentStorage would never outlive the WebResourceLoadStatisticsStore,
given that they keep a raw pointer back to the WebResourceLoadStatisticsStore (via m_store data
member).

The issue is that *while* the WebResourceLoadStatisticsStore destructor is running on the main
thread, the background queue may be running code in ResourceLoadStatisticsMemoryStore or
ResourceLoadStatisticsPersistentStorage which refs the WebResourceLoadStatisticsStore, even
though its ref count has already reached 0. It is actually a common pattern in
ResourceLoadStatisticsMemoryStore to call RunLoop::main().dispatch() and ref their m_store in
the lambda, so that they can interact with the WebResourceLoadStatisticsStore.

To address the issue, we now destroy m_statisticsStore / m_persistentStorage *before* the
WebResourceLoadStatisticsStore destructor runs. The NetworkSession destructor now calls
WebResourceLoadStatisticsStore::didDestroyNetworkSession() which takes care of destroying
m_statisticsStore / m_persistentStorage on the background queue, synchronously. The
WebResourceLoadStatisticsStore destructor will only run later, once all remaining references
to it are gone.

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::didDestroyNetworkSession):

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::~NetworkSession):

11:13 AM Changeset in webkit [247783] by aboya@igalia.com

3 edits
2 adds in trunk

[MSE] Reenqueue after removeCodedFrames()
https://bugs.webkit.org/show_bug.cgi?id=199749

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Before this patch, SourceBuffer::removeCodedFrames() did not trigger
an immediate reenqueue, but rather just set the needsReenqueuing
flag, deferring it for the next append... but there may not be another
append! In that case, the removed frames would still wrongly play.

This is the case for instance in tests where a single long media
append is done and then "cropped" with SourceBuffer.erase().

Test: media/media-source/media-source-erase-after-last-append.html

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::removeCodedFrames):

LayoutTests:

Added a test that checks that when an .erase() is performed after the
last append the erased frames are indeed not played.

media/media-source/media-source-erase-after-last-append-expected.txt: Added.
media/media-source/media-source-erase-after-last-append.html: Added.

11:08 AM Changeset in webkit [247782] by youenn@apple.com

2 edits in trunk/Source/WebKit

SYS_pthread_markcancel is sometimes used by libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=200087
<rdar://problem/53408606>

Reviewed by Brent Fulgham.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

Whitelist this unix-call within WebProcess as libwebrtc uses it.

11:07 AM Changeset in webkit [247781] by commit-queue@webkit.org

6 edits in trunk/Tools

run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
https://bugs.webkit.org/show_bug.cgi?id=199489

Patch by Zhifei Fang <zhifei_fang@apple.com> on 2019-07-24
Reviewed by Aakash Jain.

BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
(RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count

BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.

(runTest): Record test binary failure
(reportTestFailures): Report test binary failure
(runJSCStressTests):

Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely

(JscOnlyPort.build_jsc_command):
(JscOnlyPort):
(JscOnlyPort.run_javascriptcore_tests_command):

Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_jsconly_port):

11:04 AM Changeset in webkit [247780] by Alan Bujtas

6 edits in trunk

ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
https://bugs.webkit.org/show_bug.cgi?id=200079
<rdar://problem/53474325>

Reviewed by Wenson Hsieh.

Source/WebKit:

Do not reset idempotent values when the text autosizing is off.

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTextAutosizingUsesIdempotentMode):
(WKPreferencesGetTextAutosizingUsesIdempotentMode):

UIProcess/API/C/WKPreferencesRef.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::resetIdempotentTextAutosizingIfNeeded):

Tools:

Reset textAutosizingUsesIdempotentMode when transitioning to a new test.

WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetPreferencesToConsistentValues):

10:36 AM Changeset in webkit [247779] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Add per-document autoplay quirk for netflix.com.
https://bugs.webkit.org/show_bug.cgi?id=200058

Reviewed by Eric Carlson.

Opt netflix.com into the desktop-style per-document autoplay quirk.

page/Quirks.cpp:

(WebCore::Quirks::needsPerDocumentAutoplayBehavior const):

10:34 AM Changeset in webkit [247778] by aboya@igalia.com

3 edits
1 add in trunk

[GStreamer] Don't crash with empty video src
https://bugs.webkit.org/show_bug.cgi?id=200081

LayoutTests/imported/w3c:

Reviewed by Philippe Normand.

web-platform-tests/html/semantics/embedded-content/the-video-element/video_crash_empty_src.html: Added.

Source/WebCore:

When a <video> element is set to load empty or about:blank, a player is still
created, but no pipeline is loaded. This patch fixes some assertion errors that
manifested in that case.

Reviewed by Philippe Normand.

Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_crash_empty_src.html

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::platformDuration const):
(WebCore::MediaPlayerPrivateGStreamer::paused const):

10:16 AM Changeset in webkit [247777] by Alan Coon

19 edits
2 adds in branches/safari-608-branch

Cherry-pick r247671. rdar://problem/53501836

Add accessibilityInsertText for text insertion in edit fields.
https://bugs.webkit.org/show_bug.cgi?id=199973

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-07-20
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: accessibility/insert-newline.html

accessibility/ios-simulator/insert-newline.html

Accessibility clients like VoiceOver and Voice Control were entering
text in text fields by replacing the entire content of the field
(SetValue) and then setting the insertion point to the appropriate
offset (SetSelectedTextRange). accessibilityInsertText gives a simpler
interface to clients to insert text at the insertion point location.
In addition, this provides a workaround for the issue encountered with
the previous method when inserting a linebreak.

accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::insertText):
accessibility/AccessibilityObject.h:
accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper accessibilityInsertText:]):
accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityInsertText:]):

Tools:

Glue code to run new LayoutTests.

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::insertText):
WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::insertText):
WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::insertText):
WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: (WTR::AccessibilityUIElement::insertText):

LayoutTests:

Tests for inserting a newline in the middle of a text line and checking
that the insertion point and text ranges are correct.

accessibility/insert-newline-expected.txt: Added.
accessibility/insert-newline.html: Added.
accessibility/ios-simulator/insert-newline-expected.txt: Added.
accessibility/ios-simulator/insert-newline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:14 AM Changeset in webkit [247776] by Alan Coon

12 edits in branches/safari-608-branch

Apply patch. rdar://problem/53483188

Disable ENABLE_LAYOUT_FORMATTING_CONTEXT https://bugs.webkit.org/show_bug.cgi?id=200038 <rdar://problem/53457282>

Reviewed by Zalan Bujtas.

This feature is not complete. It is enabled for the trunk, but needs
to be disabled in branches for shipping products.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests -- this change does not add any new functionality.

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

10:14 AM Changeset in webkit [247775] by Alan Coon

4 edits in branches/safari-608-branch/Source/WebKitLegacy

Apply patch. rdar://problem/53483293

10:14 AM Changeset in webkit [247774] by Alan Coon

2 edits in branches/safari-608-branch/Source/WTF

Cherry-pick r247754. rdar://problem/53483290

Enable HAVE_APP_LINKS_WITH_ISENABLED for entire iOS family
https://bugs.webkit.org/show_bug.cgi?id=200040
<rdar://problem/53457670>

Reviewed by Tim Horton.

This feature was enabled for just iOS, but should be enabled for tvOS
and watchOS, too.

wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:14 AM Changeset in webkit [247773] by Alan Coon

10 edits in branches/safari-608-branch/Source

Cherry-pick r247746. rdar://problem/53483297

[iOS] Tapping the search field on a search results page on zillow.com shows and immediately dismisses the keyboard
https://bugs.webkit.org/show_bug.cgi?id=200044
<rdar://problem/53103732>

Reviewed by Wenson Hsieh.

Source/WebCore:

The keyboard gets dismissed as the result of scroll event.
The (horizontal)scroll event is initiated by WebKit as we try to re-center the content.
The content gets off-centered as the result of the newly constructed drop-down menu which slightly sticks out of the document to the right (layout overflows).

It works with shipping version of iOS because _zoomToFocusRect operates on stale viewport information (see r244494 for the progression).
This patch applies a site specific quirk to restore shipping behavior.

page/Quirks.cpp: (WebCore::Quirks::shouldAvoidScrollingWhenFocusedContentIsVisible const):
page/Quirks.h:

Source/WebKit:

Shared/FocusedElementInformation.cpp: (WebKit::FocusedElementInformation::encode const): (WebKit::FocusedElementInformation::decode):
Shared/FocusedElementInformation.h:
UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _zoomToFocusRect:selectionRect:insideFixed:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]):
UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _elementDidBlur]): (-[WKContentView _shouldAvoidScrollingWhenFocusedContentIsVisible]):
WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getFocusedElementInformation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:14 AM Changeset in webkit [247772] by Alan Coon

12 edits
2 adds in branches/safari-608-branch

Cherry-pick r247674. rdar://problem/53483189

[iOS] Fast and complex text codepaths disagree about how to lay out bopomofo with tone marks
https://bugs.webkit.org/show_bug.cgi?id=199912
<rdar://problem/52182454>

Reviewed by Simon Fraser.

Source/WebCore:

This is because CoreText has special composition rules for CJK languages, which we don't have in our simple
text codepath. Rather than implementing the composition rules in WebKit, we can simply disable them in
CoreText.

Test: fast/text/international/system-language/composition.html

platform/graphics/mac/SimpleFontDataCoreText.cpp: (WebCore::Font::getCFStringAttributes const):

Source/WebCore/PAL:

pal/spi/cocoa/CoreTextSPI.h:

LayoutTests:

css3/font-feature-font-face-local-expected.html:
css3/font-feature-font-face-local.html:
editing/mac/selection/word-thai-expected.txt:
editing/mac/selection/word-thai.html:
fast/text/international/system-language/composition-expected.txt: Added.
fast/text/international/system-language/composition.html: Added.
platform/ios/fast/text/crash-complex-text-surrogate-expected.txt:
svg/custom/glyph-selection-arabic-forms-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:14 AM Changeset in webkit [247771] by Alan Coon

2 edits in branches/safari-608-branch/Source/WebKit

Revert r247700. rdar://problem/53456070

10:10 AM Changeset in webkit [247770] by Dewei Zhu

4 edits in trunk/Websites/perf.webkit.org

Use 12 digits to show a git commit.
https://bugs.webkit.org/show_bug.cgi?id=200067

Reviewed by Ryosuke Niwa.

Use 12 digits to show a git commit to reasonably descrease commit prefix collision probability
for repository with large amount of commits.

public/v3/models/commit-log.js: Increase digits from 8 to 12 for git SHA.

(CommitLog.prototype.label):
(CommitLog.prototype.diff):

unit-tests/commit-log-tests.js: Updated unit tests.
unit-tests/commit-set-tests.js: Updated unit tests.

10:10 AM Changeset in webkit [247769] by Chris Dumez

4 edits in trunk/Source/WebKit

Unreviewed, rolling out r247766.

Caused an API test failure

Reverted changeset:

"Crash under
WebKit:WTF::Detail::CallableWrapper<WebKit::ResourceLoadStatisticsMemoryStore::updateCookieBlocking(WTF::CompletionHandler<void
()>&&)::$_32::operator()()::'lambda'(), void>::call"
https://bugs.webkit.org/show_bug.cgi?id=200071
https://trac.webkit.org/changeset/247766

9:27 AM Changeset in webkit [247768] by russell_e@apple.com

2 edits in trunk/LayoutTests

Remove test expectation for fast/events/ios/keydown-keyup-keypress-keys-in-non-editable-using-chinese-keyboard.html
<rdar://problem/52608620>

Context Navigation

Timeline

Jul 25, 2019:

Jul 24, 2019:

Download in other formats: