Timeline
Jul 28, 2019:
- 9:31 PM Changeset in webkit [247900] by
-
- 16 edits in trunk/Source
Unreviewed, rolling out r247886.
https://bugs.webkit.org/show_bug.cgi?id=200214
"Causes PLT5 regression on some machines" (Requested by mlam|a
on #webkit).
Reverted changeset:
"Add crash diagnostics for debugging unexpected zapped cells."
https://bugs.webkit.org/show_bug.cgi?id=200149
https://trac.webkit.org/changeset/247886
- 7:27 PM Changeset in webkit [247899] by
-
- 2 edits in trunk/Source/WebCore
Fix the release build
- Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp:
(WebCore::WHLSL::Metal::TypeNamer::insert):
- 7:10 PM Changeset in webkit [247898] by
-
- 15 edits7 adds3 deletes in trunk
Reorganize UIScriptController into platform-specific subclasses
https://bugs.webkit.org/show_bug.cgi?id=200027
Reviewed by Simon Fraser.
Instead of a mishmash of #ifdefs and extraneous empty functions,
reorganize UIScriptController so that we have a base class
with functions that assert if called (to make it harder to
accidentally write a test that depends on unimplemented
functionality), and override them in platform specific subclasses
as functionality is added.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
- DumpRenderTree/ios/UIScriptControllerIOS.mm:
- DumpRenderTree/mac/UIScriptControllerMac.h: Added.
- DumpRenderTree/mac/UIScriptControllerMac.mm:
- TestRunnerShared/UIScriptContext/UIScriptController.cpp:
- TestRunnerShared/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
- WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
- WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
- WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
- WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
- WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
- WebKitTestRunner/mac/UIScriptControllerMac.mm:
- http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped.js:
(onload):
This test both uses event sender to click, and UIScriptController to "tap".
Since singleTapAtPoint is unimplemented on macOS, it really just ended
up doing nothing, but now it asserts. Only click or tap, but not both.
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
Skip some tests for unimplemented or unsupported features.
- platform/mac/fast/events/autoscroll-when-input-is-offscreen-expected.txt: Removed.
- platform/mac/fast/events/autoscroll-with-software-keyboard-expected.txt: Removed.
Remove unneeded test results.
- swipe/resources/swipe-test.js:
(playEventStream):
playBackEventStream is unimplemented on iOS. Also, it's not necessary
for simulated swipe to send events at all on iOS, so just bail, which
is equivalent to what used to happen.
- 7:07 PM Changeset in webkit [247897] by
-
- 2 edits in trunk/Source/WebKitLegacy/win
[Win][WK1] Can't change Web Inspector frontend height in high DPI
https://bugs.webkit.org/show_bug.cgi?id=200153
Reviewed by Don Olmstead.
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::setAttachedWindowHeight):
Applied deviceScaleFactor to the argument height.
- 7:03 PM Changeset in webkit [247896] by
-
- 13 edits2 deletes in trunk/Tools
[Win][MiniBrowser] Remove PageLoadTestClient
https://bugs.webkit.org/show_bug.cgi?id=200155
Reviewed by Brent Fulgham.
It is not used nowadays.
- MiniBrowser/win/CMakeLists.txt:
- MiniBrowser/win/Common.cpp:
(parseCommandLine):
- MiniBrowser/win/Common.h:
- MiniBrowser/win/MainWindow.cpp:
(MainWindow::init):
- MiniBrowser/win/MainWindow.h:
- MiniBrowser/win/MiniBrowserWebHost.cpp:
(MiniBrowserWebHost::updateAddressBar):
(MiniBrowserWebHost::didFinishLoadForFrame):
(MiniBrowserWebHost::didStartProvisionalLoadForFrame):
(MiniBrowserWebHost::didFailLoadWithError):
(MiniBrowserWebHost::didHandleOnloadEventsForFrame):
(MiniBrowserWebHost::didFirstLayoutInFrame):
- MiniBrowser/win/PageLoadTestClient.cpp: Removed.
- MiniBrowser/win/PageLoadTestClient.h: Removed.
- MiniBrowser/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::identifierForInitialRequest):
(ResourceLoadDelegate::willSendRequest):
(ResourceLoadDelegate::didFinishLoadingFromDataSource):
(ResourceLoadDelegate::didFailLoadingWithError):
- MiniBrowser/win/WebKitBrowserWindow.cpp:
(WebKitBrowserWindow::create):
(WebKitBrowserWindow::createNewPage):
- MiniBrowser/win/WebKitBrowserWindow.h:
- MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
(WebKitLegacyBrowserWindow::create):
(WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
(WebKitLegacyBrowserWindow::exitProgram): Deleted.
- MiniBrowser/win/WebKitLegacyBrowserWindow.h:
(WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
- MiniBrowser/win/WinMain.cpp:
(wWinMain):
- 2:28 PM Changeset in webkit [247895] by
-
- 2 edits in trunk/Source/ThirdParty
Fix static analyzer build
https://bugs.webkit.org/show_bug.cgi?id=200201
Reviewed by Anders Carlsson.
- Makefile: Add an analyze target, as this makefile is now used for full builds,
including static analyzer ones.
- 2:23 PM Changeset in webkit [247894] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Touch regions overlay needs to show touch-action:none
https://bugs.webkit.org/show_bug.cgi?id=200203
Reviewed by Wenson Hsieh.
When I added touch-action overlay painting, I didn't realize that touch-action:none
was an important value to display. But it is, so fix that.
- rendering/RenderLayerBacking.cpp:
(WebCore::patternForTouchAction):
Jul 27, 2019:
- 6:31 PM Changeset in webkit [247893] by
-
- 7 edits in trunk/Source/WebCore
[WHLSL] Remove UnnamedType copy/move constructors and mark classes as final
https://bugs.webkit.org/show_bug.cgi?id=200188
Reviewed by Myles C. Maxfield.
Since they are ref counted, you should make taking a ref to them
instead of moving or copying them. This patch encodes that by deleting
the relevant copy/move constructors and assignment operators.
- Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
- Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
(WebCore::WHLSL::AST::ArrayType::ArrayType): Deleted.
(WebCore::WHLSL::AST::ArrayType::create): Deleted.
(WebCore::WHLSL::AST::ArrayType::type const): Deleted.
(WebCore::WHLSL::AST::ArrayType::type): Deleted.
(WebCore::WHLSL::AST::ArrayType::numElements const): Deleted.
- Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
(WebCore::WHLSL::AST::PointerType::PointerType): Deleted.
(WebCore::WHLSL::AST::PointerType::create): Deleted.
- Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
- Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
(WebCore::WHLSL::AST::TypeReference::TypeReference): Deleted.
(WebCore::WHLSL::AST::TypeReference::create): Deleted.
(WebCore::WHLSL::AST::TypeReference::name): Deleted.
(WebCore::WHLSL::AST::TypeReference::typeArguments): Deleted.
(WebCore::WHLSL::AST::TypeReference::maybeResolvedType const): Deleted.
(WebCore::WHLSL::AST::TypeReference::resolvedType const): Deleted.
(WebCore::WHLSL::AST::TypeReference::setResolvedType): Deleted.
- Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:
- 5:47 PM Changeset in webkit [247892] by
-
- 17 edits in trunk/Source/WebCore
[WebGPU] Update GPUComputePipeline errors to match GPURenderPipeline implementation
https://bugs.webkit.org/show_bug.cgi?id=200097
Reviewed by Myles C. Maxfield.
Remove passing around a functionName in GPUComputePipeline creation in favor of setting it on the GPUErrorScopes.
Also, WebGPU objects no longer create new Ref<>s unless object creation succeeds.
No new tests. Covered by existing tests.
- Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::createBuffer const):
(WebCore::WebGPUDevice::createBufferMapped const):
(WebCore::WebGPUDevice::createComputePipeline const):
- platform/graphics/gpu/GPUBuffer.h:
- platform/graphics/gpu/GPUComputePipeline.h:
- platform/graphics/gpu/GPUDevice.cpp:
(WebCore::GPUDevice::tryCreateBuffer):
(WebCore::GPUDevice::tryCreateComputePipeline const):
- platform/graphics/gpu/GPUDevice.h:
- platform/graphics/gpu/GPUErrorScopes.cpp:
(WebCore::GPUErrorScopes::generatePrefixedError): Only validaton errors have messages right now.
- platform/graphics/gpu/GPUErrorScopes.h:
- platform/graphics/gpu/cocoa/GPUBufferMetal.mm:
(WebCore::GPUBuffer::validateBufferUsage):
(WebCore::GPUBuffer::tryCreate):
(WebCore::GPUBuffer::GPUBuffer):
- platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:
(WebCore::trySetMetalFunctions):
(WebCore::trySetFunctions):
(WebCore::convertComputePipelineDescriptor):
(WebCore::tryCreateMTLComputePipelineState):
(WebCore::GPUComputePipeline::tryCreate):
(WebCore::GPUComputePipeline::GPUComputePipeline):
- platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::trySetMetalFunctions):
(WebCore::trySetFunctions):
These classes were made RefCounted in a previous patch; remove their move ctors to fix build.
- Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
- Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
- Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
- Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
- Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
- Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:
- 5:42 PM Changeset in webkit [247891] by
-
- 4 edits4 adds in trunk
Expose the aria-label attribute for <video> elements.
https://bugs.webkit.org/show_bug.cgi?id=200169
<rdar://problem/51754558>
Patch by Andres Gonzalez <Andres Gonzalez> on 2019-07-27
Reviewed by Chris Fleizach.
Source/WebCore:
Tests: accessibility/ios-simulator/media-with-aria-label.html
accessibility/media-with-aria-label.html
We now expose the <video> element to accessibility clients as long as auto-play is not enabled.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityIsWebInteractiveVideo]):
LayoutTests:
- accessibility/ios-simulator/media-with-aria-label-expected.txt: Added.
- accessibility/ios-simulator/media-with-aria-label.html: Added.
- accessibility/media-with-aria-label-expected.txt: Added.
- accessibility/media-with-aria-label.html: Added.
- platform/win/TestExpectations:
- 6:41 AM Changeset in webkit [247890] by
-
- 2 edits in trunk/Source/WebKit
Allow more syscalls in the WebContent process' sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=200182
<rdar://problem/53594973>
Reviewed by Geoffrey Garen.
I reviewed all crash traces attached to the radar and found the following
syscalls that we not yet allowed by the WebContent process's sandbox
profile.
- WebProcess/com.apple.WebProcess.sb.in:
- 12:08 AM Changeset in webkit [247889] by
-
- 9 edits3 adds in trunk
[X86] Emit BT instruction for shift + mask in B3
https://bugs.webkit.org/show_bug.cgi?id=199891
Reviewed by Keith Miller.
JSTests:
- microbenchmarks/bit-test-constant.js: Added.
(let.glob.0.doTest):
- microbenchmarks/bit-test-load.js: Added.
(let.glob.0.let.arr.new.Int32Array.8.doTest):
(i):
- microbenchmarks/bit-test-nonconstant.js: Added.
(let.glob.0.doTest):
Source/JavaScriptCore:
- Add a new BranchTestBit air opcode, matching the intel bt instruction
- Select this instruction for the following patterns: if (a & (1<<b)) if ((a>>b)&1) if ((~a>>b)&1) if (~a & (1<<b))
- 15% perf progression on the nonconstant microbenchmark, neutral otherwise.
- Note: we cannot fuse loads when we have bitBase=Load, bitOffset=Tmp, since the X86 instruction has different behaviour in this mode. It will read past the current dword/qword instead of wrapping around.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchTestBit32):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branchTestBit64):
- assembler/X86Assembler.h:
(JSC::X86Assembler::bt_ir):
(JSC::X86Assembler::bt_im):
(JSC::X86Assembler::btw_ir):
(JSC::X86Assembler::btw_im):
- assembler/testmasm.cpp:
(JSC::int64Operands):
(JSC::testBranchTestBit32RegReg):
(JSC::testBranchTestBit32RegImm):
(JSC::testBranchTestBit32AddrImm):
(JSC::testBranchTestBit64RegReg):
(JSC::testBranchTestBit64RegImm):
(JSC::testBranchTestBit64AddrImm):
(JSC::run):
- b3/B3LowerToAir.cpp:
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testBranchBitTest32TmpImm):
(JSC::B3::testBranchBitTest32AddrImm):
(JSC::B3::testBranchBitTest32TmpTmp):
(JSC::B3::testBranchBitTest64TmpTmp):
(JSC::B3::testBranchBitTest64AddrTmp):
(JSC::B3::run):
