Context Navigation

← Previous Period
Next Period →

Timeline

Sep 9, 2019:

10:30 PM Changeset in webkit [249707] by Alan Coon

8 edits
3 adds in branches/safari-608-branch

Cherry-pick r249535. rdar://problem/55183140

10:03 PM Changeset in webkit [249706] by ysuzuki@apple.com

7 edits in trunk/Source/JavaScriptCore

[JSC] CodeBlock::m_constantRegisters should be guarded by ConcurrentJSLock when Vector reallocate memory
https://bugs.webkit.org/show_bug.cgi?id=201622

Reviewed by Mark Lam.

CodeBlock::visitChildren takes ConcurrentJSLock while iterating m_constantRegisters, some of the places reallocate
this Vector without taking a lock. If a Vector memory is reallocated while iterating it in concurrent collector,
the concurrent collector can see a garbage. This patch guards m_constantRegisters reallocation with ConcurrentJSLock.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setConstantRegisters):

bytecode/CodeBlock.h:

(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::addConstantLazily):

dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):
(JSC::DFG::SymbolTableAdaptor::add):
(JSC::DFG::FunctionExecutableAdaptor::add):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::registerFrozenValues):

dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalizeCommon):

dfg/DFGLazyJSValue.cpp:

(JSC::DFG::LazyJSValue::emit const):

9:51 PM Changeset in webkit [249705] by achristensen@apple.com

2 edits in trunk/Tools

Rebase API test after r249675
https://bugs.webkit.org/show_bug.cgi?id=201596

TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
We removed the restriction on WebsitePolicies with non-default persistent sessions.
We needed to change the expectations of the test that exercised that code path.

9:30 PM Changeset in webkit [249704] by achristensen@apple.com

2 edits in trunk/Tools

Fix iOS API tests after r249684
https://bugs.webkit.org/show_bug.cgi?id=201573

TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(TestWebKitAPI::getWebSocketEventWebKitLegacy):
(TestWebKitAPI::TEST):
The web thread still exists :(
That makes iOS immediate failure results more like WK2, which is fine.
The point is that the connection fails somehow and the server sees a TLS failure, which the test verifies.

9:24 PM Changeset in webkit [249703] by Chris Dumez

7 edits in trunk/Source/WebKit

[iOS] We sometimes attempt to use a terminated prewarmed WebContent process
https://bugs.webkit.org/show_bug.cgi?id=201614
<rdar://problem/54714507>

Reviewed by Geoffrey Garen.

On iOS, it is possible for our processes to get terminated (e.g. jetsammed) while the UIProcess
is suspended. Upon resuming, it takes a little while for the UIProcess to get the notification
that the mac connection to its child process has been severed and the UIProcess may try to use
it for a load. This is especially problematic for prewarmed process because the client will end
up showing a crash banner and reloading when we could have used a new process rather the prewarmed
one if we had known it was dead.

This patch makes 2 improvements:

It makes AuxiliaryProcessProxy::state() return Terminated if we still have a connection but the PID is not the PID of a running process. I also added a check in tryTakePrewarmedProcess() to not use the prewarmed process if it state() is Terminated.
When the UIProcess is about to get suspended, have the process pools terminate their non-critical processes (i.e. prewarmed + the ones used for PageCache). This makes WebKit friendlier with other apps on the system when suspended with regards to memory. Also, it makes it less likely useful WebContent processes will get jetsammed.

UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::state const):
(WebKit::AuxiliaryProcessProxy::isRunningProcessPID):

UIProcess/AuxiliaryProcessProxy.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::applicationIsAboutToSuspend):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::tryTakePrewarmedProcess):

UIProcess/WebProcessPool.h:
UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):

9:06 PM Changeset in webkit [249702] by Chris Dumez

15 edits in trunk

REGRESSION: http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html is frequently timing out on iOS EWS bots
https://bugs.webkit.org/show_bug.cgi?id=201550

Reviewed by Alex Christensen.

Source/WebCore:

loader/ResourceLoadObserver.h:

(WebCore::ResourceLoadObserver::hasStatistics const):

Source/WebKit:

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleResourceLoadStatisticsNotifyObserver):

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

Tools:

Update testRunner.statisticsNotifyObserver() to return a boolean indicating if it did
anything or not.

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::statisticsNotifyObserver):

WebKitTestRunner/InjectedBundle/InjectedBundle.h:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::statisticsNotifyObserver):

WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Update test to do checks on a timer if its call to testRunner.statisticsNotifyObserver() is a no-op
due to having no statistics to send to the network process.

http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html:

8:50 PM Changeset in webkit [249701] by timothy@apple.com

4 edits
1 add in trunk

Tap and hold on Facebook sometimes creates a tall empty selection.
https://bugs.webkit.org/show_bug.cgi?id=201618
rdar://53630145

Reviewed by Megan Gardner.

Source/WebCore:

API Test: SelectionTests.ByWordAtEndOfDocument

editing/VisibleUnits.cpp:

(WebCore::wordRangeFromPosition):
Remove special case code for the possibility of an empty paragraph and at the end
of the document. This is no longer needed and was causing a large selection to be
created on Facebook due to large areas of non-selectable content on the page.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/ios/SelectionByWord.mm: Added.

8:20 PM Changeset in webkit [249700] by Alan Coon

6 edits in branches/safari-608-branch/Source/WebKit

Cherry-pick r249649. rdar://problem/55198071

[macOS] Pid is sometimes invalid when creating sandbox extensions by pid.
https://bugs.webkit.org/show_bug.cgi?id=201543
<rdar://problem/54733465>

Reviewed by Brent Fulgham.

There is a race condition when starting a load of a local file, where the WebContent process has not finished
launching yet, and its pid is not available. When we try to create a sandbox extension by using the pid of the
WebContent process, it is not available in the cases where the WebContent process has just launched and has not
finished launching yet. This patch creates a new dummy Web page message, 'LoadRequestWaitingForPID', which will
be sent instead of a normal 'LoadRequest' message, and only when the WebContent process has not finished
launching. When the WebContent process has finished launching, and we are about to actually send the pending
messages, we can detect that a 'LoadRequestWaitingForPID' has been appended for sending, and replace it with a
normal 'LoadReqest' message where we have created the sandbox extension issue with a valid pid. The message
'LoadRequestWaitingForPID' is never intended to reach the WebContent process, it is just there to replace with
a normal 'LoadRequest' message with a new sandbox extension. In the implementation of the message handler on
the WebContent process side, we assert that the method is never called. This patch makes sure the ordering of
the Web page messages are the same, even when we modify the message.

UIProcess/AuxiliaryProcessProxy.cpp: (WebKit::AuxiliaryProcessProxy::didFinishLaunching):
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle): (WebKit::WebPageProxy::loadRequestWithNavigationShared): (WebKit::WebPageProxy::loadFile):
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::fileLoadRequest):
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:20 PM Changeset in webkit [249699] by Alan Coon

2 edits in branches/safari-608-branch/Source/WebKit

Cherry-pick r249624. rdar://problem/55202935

Marking up a note on iOS results in a PDF with no contents
https://bugs.webkit.org/show_bug.cgi?id=201530
<rdar://problem/53686019>

Unreviewed follow-up.

UIProcess/ios/WKContentView.mm: (-[WKContentView _waitForDrawToPDFCallback]): Remove an ASSERT_NOT_REACHED that fires if the synchronous wait for printing times out. This is a totally legitimite situation that can occur if the process crashes; there's no need for an assert there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:20 PM Changeset in webkit [249698] by Alan Coon

16 edits
5 adds in branches/safari-608-branch

Cherry-pick r249605. rdar://problem/55182896

Incorrect selection rect revealed after pasting images in a contenteditable element
https://bugs.webkit.org/show_bug.cgi?id=201549
<rdar://problem/50956429>

Reviewed by Simon Fraser.

Source/WebCore:

Editor::replaceSelectionWithFragment currently scrolls to reveal the selection after inserting the given
DocumentFragment. However, this scrolling occurs before any inserted images have loaded yet, which causes the
wrong caret rect to be revealed, since all image elements inserted during paste will be empty.

To fix this, we defer revealing the selection after inserting the fragment until after all images that have
been inserted are done loading. While waiting for images to load, if any layers which may be scrolled as a
result of revealing the selection are scrolled, we additionally cancel the deferred selection reveal. See
comments below for more detail.

Tests: editing/pasteboard/do-not-reveal-selection-after-programmatic-scroll.html

editing/pasteboard/reveal-selection-after-pasting-images.html
PasteImage.RevealSelectionAfterPastingImage

editing/Editing.cpp: (WebCore::visibleImageElementsInRangeWithNonLoadedImages):

Add a new helper to iterate through a range and collect all image elements in that range, that contain cached
images that have not finished loading yet.

editing/Editing.h:
editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment):

Instead of always immediately revealing the selection after applying the ReplaceSelectionCommand, collect the
image elements that were just inserted, and avoid immediately revealing the selection if any of these images
have non-null cached images, but are not loaded yet. Instead, hold on to these images in a set, remove them once
they finish loading using the new method below, and once all images are removed, reveal the selection.

(WebCore::Editor::revealSelectionIfNeededAfterLoadingImageForElement):
(WebCore::Editor::renderLayerDidScroll):

Called whenever a scrollable RenderLayer is scrolled (or in the case of FrameView, the root layer). In the case
where Editor is waiting to reveal the selection, we check to see if the scrolled layer is an ancestor of the
layer enclosing the start of the selection.

(WebCore::Editor::respondToChangedSelection):

If the selection changes between pasting and waiting for pasted images to load, just cancel waiting to reveal
the selection after pasting.

editing/Editor.h:
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertedContentRange const):

Add a helper method to grab the Range of content inserted after applying the command.

editing/ReplaceSelectionCommand.h:
page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
page/FrameView.h:
page/Page.cpp: (WebCore::Page::didFinishLoadingImageForElement):

Notify Editor after an image finishes loading.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollTo):

Source/WebKit:

Tweak some existing logic to use the new visibleImageElementsInRangeWithNonLoadedImages helper function. See
WebCore for more details.

WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::didConcludeEditDrag):

Tools:

Add an API test to exercise the scenario where we scroll to reveal the selection after pasting an image that was
directly written to the pasteboard.

TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:

LayoutTests:

Add a couple of new layout tests.

editing/pasteboard/do-not-reveal-selection-after-programmatic-scroll-expected.txt: Added.
editing/pasteboard/do-not-reveal-selection-after-programmatic-scroll.html: Added.

This test verifies that we don't try to scroll to reveal the caret after pasting, if the scroll position was
changed before the images finished loading.

editing/pasteboard/reveal-selection-after-pasting-images-expected.txt: Added.
editing/pasteboard/reveal-selection-after-pasting-images.html: Added.
platform/ios/editing/pasteboard/reveal-selection-after-pasting-images-expected.txt: Added.

This test verifies that we reveal the caret after loading multiple pasted images in a selection, and dispatch a
scroll event in the process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:19 PM Changeset in webkit [249697] by Alan Coon

6 edits
1 add in branches/safari-608-branch

Cherry-pick r249584. rdar://problem/55202935

Marking up a note on iOS results in a PDF with no contents
https://bugs.webkit.org/show_bug.cgi?id=201530
<rdar://problem/53686019>

Reviewed by Andy Estes.

Source/WebKit:

Platform/IPC/Connection.cpp: (IPC::Connection::Connection): (IPC::Connection::waitForMessage): (IPC::Connection::connectionDidClose):
Platform/IPC/Connection.h: If the main thread is blocked when the Web Content process dies, and something eventually calls waitForAndDispatchImmediately without returning control to the main run loop, we will wait for the full timeout, because a) the code to mark the connection invalid is dispatched to the main thread, and b) the secondary thread that is informed of the Web Content process dying did not yet have a "waiting for" message to mark as interrupted (because it wasn't waiting yet).

Fix this race by adding a bit that is set under the waitForMessage lock
on the secondary thread when the connection is invalidated, identically
to m_shouldWaitForSyncReplies, which solves the same problem for sync
messages.

Read the new bit when we are about to start waiting, and bail if it is set.
It's OK to not read it inside the loop because we are guaranteed to have
waitForMessage set at that point, so the normal interruption bit will work.

UIProcess/ios/WKContentView.mm: (-[WKContentView _processDidExit]): Reset _isPrintingToPDF; the Web Content process is never going to get back to us if it crashes.

(-[WKContentView _wk_pageCountForPrintFormatter:]):
Do not bail from starting a printing operation if one is already occurring.
This fixes the original bug, because Markup ends up invalidating the page
count at least one extra time before asking for the printed document.
Instead of maintaining the fragile requirement that you cannot recompute
the page count while printing, just let it happen. In order to make this
work safely, synchronously wait for the previous printed result before
continuing with the next print.

We could do more coalescing here if need be, but calls to -_recalcPageCount
are not high in volume.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Add some tests for WKWebViewPrintFormatter; specifically that it is possible to _recalcPageCount twice in quick succession, and that we don't hang if we start painting the printed content immediately after a Web Content process crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:19 PM Changeset in webkit [249696] by Alan Coon

4 edits
2 adds in branches/safari-608-branch

Cherry-pick r249581. rdar://problem/55202922

REGRESSION (iOS 13): If an overflow:hidden with a non-zero scroll position is toggled to overflow:scroll, some other scroll causes its scroll position to get reset
https://bugs.webkit.org/show_bug.cgi?id=201528
rdar://problem/55044885

Reviewed by Frédéric Wang.
Source/WebCore:

If, when an overflow scrolling node is created, the scroller has non-zero scroll
position (for example, via toggling to overflow:hidden, setting scrollTop, then toggling
to overflow:scroll), then on the next update its scroll position will reset back to zero.

The bug was that newly created ScrollingTreeScrollingNodes didn't set m_currentScrollPosition
to the scroll position coming from the state node, so a subsequent update could cause
the 0,0 currentScrollPosition to get applied. If we're making a new node, and there's no
requestedScrollPosition, then initialize m_currentScrollPosition.

Test: scrollingcoordinator/ios/scroller-initial-scroll-position.html

page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren): (WebCore::ScrollingTreeScrollingNode::commitStateAfterChildren):
page/scrolling/ScrollingTreeScrollingNode.h:

LayoutTests:

scrollingcoordinator/ios/scroller-initial-scroll-position-expected.html: Added.
scrollingcoordinator/ios/scroller-initial-scroll-position.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:19 PM Changeset in webkit [249695] by Alan Coon

5 edits in branches/safari-608-branch

Cherry-pick r249565. rdar://problem/55113261

AccessibilityRenderObject::setSelectedTextRange fails to set the selection passed an empty line.
https://bugs.webkit.org/show_bug.cgi?id=201518
<rdar://problem/54835122>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-09-06
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: accessibility/set-selected-text-range-after-newline.html

In the case of an empty line, the CharacterIterator range start and end
were not equal, thus we were not advancing the iterator and returning
the iterator range end, which is not correct. With this change we are
always advancing the iterator if its text is just '\n'. This covers all
the cases we fixed before plus empty lines.

editing/Editing.cpp: (WebCore::visiblePositionForIndexUsingCharacterIterator):

LayoutTests:

Extended this test to set the selection range passed an empty line.

accessibility/set-selected-text-range-after-newline-expected.txt:
accessibility/set-selected-text-range-after-newline.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:19 PM Changeset in webkit [249694] by Alan Coon

3 edits
2 adds in branches/safari-608-branch

Cherry-pick r249534. rdar://problem/55183098

AX: children cache are not re-computed if tab index is removed
https://bugs.webkit.org/show_bug.cgi?id=201502

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: accessibility/tabindex-removed.html

If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
information can be stale and lead to incorrect navigation with VoiceOver.

accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleAttributeChange):

LayoutTests:

accessibility/tabindex-removed-expected.txt: Added.
accessibility/tabindex-removed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:19 PM Changeset in webkit [249693] by Alan Coon

5 edits in branches/safari-608-branch

Cherry-pick r249514. rdar://problem/55182886

MobileSafari may crash when invoking the C++ lambda in -[WKContentView _shareForWebView:]
https://bugs.webkit.org/show_bug.cgi?id=201479
<rdar://problem/51511834>

Reviewed by Tim Horton.

Source/WebKit:

Fix the crash by making -_shareForWebView: robust in the case where there are no selection rects
known in the UI process when -[WKContentView _share:] is invoked.

UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _shareForWebView:]):

Tools:

Add a test to verify that the UI process doesn't crash when invoking _share: while there's no selection.

TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
TestWebKitAPI/ios/UIKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:19 PM Changeset in webkit [249692] by Alan Coon

2 edits in branches/safari-608-branch/Source/WebCore

Cherry-pick r249493. rdar://problem/55182906

[iPadOS] Unable to change sheets on Airtable.com
https://bugs.webkit.org/show_bug.cgi?id=201456
<rdar://problem/51557377>

Patch by Antoine Quint <Antoine Quint> on 2019-09-04
Reviewed by Dean Jackson.

Simulated mouse events are required to be able to manipulate cells and and columns on Airtable.com. However, dispatching a "mousedown" event on
tabs allowing to pick a different sheet ends up calling preventDefault() and prevent "click" events from being dispatched, which makes it
impossible to change sheet. We now limit the dispatch of simulated mouse events to the grid.

page/Quirks.cpp: (WebCore::Quirks::simulatedMouseEventTypeForTarget const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:19 PM Changeset in webkit [249691] by Alan Coon

2 edits in branches/safari-608-branch/Source/WebKit

Cherry-pick r249454. rdar://problem/55198071

[macOS] Unable to open local file from favorites bar
https://bugs.webkit.org/show_bug.cgi?id=201444

Reviewed by Brent Fulgham.

The sandbox extension handle should be created providing the pid of the receiving process.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:19 PM Changeset in webkit [249690] by Alan Coon

2 edits in branches/safari-608-branch/Source/WebKit

Cherry-pick r249444. rdar://problem/55093558

Null deref under -[WKWebView _addUpdateVisibleContentRectPreCommitHandler]'s handler block
https://bugs.webkit.org/show_bug.cgi?id=201436
<rdar://problem/40640475>

Reviewed by Simon Fraser.

UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView dealloc]): (-[WKWebView _addUpdateVisibleContentRectPreCommitHandler]): We crash sending a message to a deallocated WKWebView inside the handler block passed to +[CATransaction addCommitHandler:]. This seems impossible, because we carefully retain it, but it's possible that it could be the result of the handler block being installed under -dealloc (in which case retaining the WKWebView wouldn't actually extend its lifetime). -[WKWebView dealloc] is fairly sizable, and it's hard to follow all paths from it, so instead add a RELEASE_LOG_FAULT, so we'll get simulated crash logs, and bail, so we'll stop actually crashing (if this is the cause).

This is just a speculative fix, but a hopeful one, since intentionally calling
-_addUpdateVisibleContentRectPreCommitHandler: from dealloc yields a similar-looking
crash under the handler block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:19 PM Changeset in webkit [249689] by Alan Coon

2 edits in branches/safari-608-branch/Source/WebCore

Cherry-pick r248170. rdar://problem/55183128

[iOS] Directly use RealtimeMediaSourceCenter to compute the media capture state
https://bugs.webkit.org/show_bug.cgi?id=200368
<rdar://problem/53191450>

Unreviewed.
Build fix by guarding with MEDIA_STREAM in addition to IOS.

dom/Document.cpp: (WebCore::Document::updateIsPlayingMedia): (WebCore::Document::pageMutedStateDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:19 PM Changeset in webkit [249688] by Alan Coon

4 edits in branches/safari-608-branch/Source/WebCore

Cherry-pick r248161. rdar://problem/55183128

[iOS] Directly use RealtimeMediaSourceCenter to compute the media capture state
https://bugs.webkit.org/show_bug.cgi?id=200368
<rdar://problem/53191450>

Reviewed by Eric Carlson.

Instead of registering a MediaStreamTrack as a media producer to compute capture state,
go directly to the sources from the RealtimeMediaSourceCenter.
Do the same when requested to mute capture tracks.

No observable change of behavior.
Covered by manual test on iOS and existing tests.

Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::MediaStreamTrack): (WebCore::MediaStreamTrack::~MediaStreamTrack): (WebCore::MediaStreamTrack::mediaState const): (WebCore::sourceCaptureState): (WebCore::MediaStreamTrack::captureState): (WebCore::MediaStreamTrack::muteCapture):
Modules/mediastream/MediaStreamTrack.h:
dom/Document.cpp: (WebCore::Document::updateIsPlayingMedia): (WebCore::Document::pageMutedStateDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:12 PM Changeset in webkit [249687] by aakash_jain@apple.com

2 edits in trunk/Tools

[EWS] Watchlist doesn't work sometimes
https://bugs.webkit.org/show_bug.cgi?id=201433

Reviewed by Michael Catanzaro.

Scripts/webkitpy/common/config/watchlist: Updated the email addresses to the one associated with

corresponding Bugzilla accounts.

6:57 PM Changeset in webkit [249686] by jh718.park@samsung.com

48 edits
10 adds in trunk

getComputedStyle for line-height: normal should return the keyword instead of a length
https://bugs.webkit.org/show_bug.cgi?id=201296

LayoutTests/imported/w3c:

Reviewed by Ryosuke Niwa.

Per https://github.com/w3c/csswg-drafts/issues/3749,
Gecko and Blink has this behavior already.

This patch makes WebKit has the same behavior with them.

web-platform-tests/css/css-inline/parsing/line-height-computed-expected.txt: Added.
web-platform-tests/css/css-inline/parsing/line-height-computed.html: Added.
web-platform-tests/css/cssom/getComputedStyle-line-height-expected.txt: Added.
web-platform-tests/css/cssom/getComputedStyle-line-height.html: Added.
web-platform-tests/html/rendering/replaced-elements/the-select-element/select-1-line-height-expected.html: Added.
web-platform-tests/html/rendering/replaced-elements/the-select-element/select-1-line-height.html: Added.

Source/WebCore:

Reviewed by Ryosuke Niwa.

Per https://github.com/w3c/csswg-drafts/issues/3749,
Gecko and Blink has this behavior already.

This patch makes WebKit has the same behavior with them.

Tests: imported/w3c/web-platform-tests/css/css-inline/parsing/line-height-computed.html

imported/w3c/web-platform-tests/css/cssom/getComputedStyle-line-height.html
imported/w3c/web-platform-tests/html/rendering/replaced-elements/the-select-element/select-1-line-height.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::lineHeightFromStyle):

LayoutTests:

Reviewed by Ryosuke Niwa.

Per https://github.com/w3c/csswg-drafts/issues/3749,
Gecko and Blink has this behavior already.

This patch makes WebKit has the same behavior with them.

css3/calc/line-height-expected.txt:
fast/css/font-calculated-value-expected.txt:
fast/css/font-calculated-value.html:
fast/css/font-shorthand-from-longhands-expected.txt:
fast/css/font-shorthand-from-longhands.html:
fast/css/font-shorthand-line-height-expected.txt:
fast/css/font-shorthand-line-height.html:
fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-font-expected.txt:
fast/css/getComputedStyle/computed-style-font.html:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/ruby/ruby-line-height-expected.txt:
fast/ruby/ruby-line-height.html:
fast/text-autosizing/ios/idempotentmode/line-height-boosting-expected.txt:
fast/text-autosizing/ios/idempotentmode/line-height-boosting.html:
fast/text-autosizing/ios/line-height-text-autosizing-expected.txt:
fast/text-autosizing/ios/line-height-text-autosizing.html:
media/track/track-cue-rendering-on-resize-expected.txt:
media/track/track-cue-rendering-on-resize.html:
platform/gtk/fast/css/css2-system-fonts-expected.txt:
platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
platform/ios/TestExpectations:
platform/ios/css3/calc/line-height-expected.txt:
platform/ios/fast/css/css2-system-fonts-expected.txt:
platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/ios/svg/css/getComputedStyle-basic-expected.txt:
platform/mac-sierra/fast/css/getComputedStyle/computed-style-expected.txt:
platform/mac-sierra/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/mac-sierra/svg/css/getComputedStyle-basic-expected.txt:
platform/mac/fast/css/css2-system-fonts-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/mac/fast/text-autosizing/ios/line-height-text-autosizing-expected.txt:
platform/mac/svg/css/getComputedStyle-basic-expected.txt:
platform/wincairo/css3/calc/line-height-expected.txt:
platform/wincairo/fast/css/css2-system-fonts-expected.txt:
platform/wpe/fast/css/css2-system-fonts-expected.txt:
platform/wpe/fast/css/getComputedStyle/computed-style-expected.txt:
platform/wpe/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/wpe/svg/css/getComputedStyle-basic-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

6:39 PM Changeset in webkit [249685] by Justin Fan

11 edits
4 adds in trunk/Websites/webkit.org

[WebGPU] Upload Babylon.js, WSL compile, and MotionMark links to demo page
https://bugs.webkit.org/show_bug.cgi?id=201621

Reviewed by Dean Jackson.

Add new demos to the WebGPU demo collection.
Ensure error alerts/divs display properly if WebGPU is not enabled.

demos/webgpu/babylon/oneHelmetWebGPU.html:
demos/webgpu/babylon/oneSphereWebGPU.html:
demos/webgpu/compute-blur.html:
demos/webgpu/compute-boids-compile.html:
demos/webgpu/compute-boids.html:
demos/webgpu/hello-cube.html:
demos/webgpu/hello-triangle.html:
demos/webgpu/index.html:
demos/webgpu/resources/babylon-helmet.png: Added.
demos/webgpu/resources/babylon-sphere.png: Added.
demos/webgpu/resources/motionmark.jpeg: Added.
demos/webgpu/resources/webkit-logo.png: Added.
demos/webgpu/scripts/compute-boids-compile.js:
demos/webgpu/textured-cube.html:

6:39 PM Changeset in webkit [249684] by achristensen@apple.com

21 edits
1 add in trunk

Disable TLS 1.0 and 1.1 in WebSockets
https://bugs.webkit.org/show_bug.cgi?id=201573

Reviewed by Youenn Fablet.

Source/WebCore:

This expands on what I started in r249019 when I disabled legacy TLS for our use of NSURLSession.
Since our WebSocket implementation uses a different network interface, disable legacy TLS for them, too.
I use the same temporary default to re-enable legacy TLS. I also add a unit test for both WebSockets and NSURLSession use.

platform/network/cf/SocketStreamHandleImpl.h:
platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::Function<bool):
(WebCore::SocketStreamHandleImpl::setLegacyTLSEnabledCheck):
(WebCore::SocketStreamHandleImpl::createStreams):

Source/WebCore/PAL:

pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

NetworkProcess/NetworkProcessCreationParameters.h:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _allowAnyTLSCertificateForWebSocketTesting]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Tools:

TestWebKitAPI/SourcesCocoa.txt:
TestWebKitAPI/TCPServer.cpp:

(sk_CRYPTO_BUFFER_num):
(sk_CRYPTO_BUFFER_value):
(TestWebKitAPI::deleter<CRYPTO_BUFFER>::operator()):
(TestWebKitAPI::TCPServer::TCPServer):
(TestWebKitAPI::TCPServer::listenForConnections):
(TestWebKitAPI::deleter<X509>::operator()): Deleted.
(TestWebKitAPI::deleter<uint8_t::operator()): Deleted.

TestWebKitAPI/TCPServer.h:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: Added.

(-[WebSocketDelegate waitForMessage]):
(-[WebSocketDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TestWebKitAPI::TEST):

TestWebKitAPI/cocoa/TestNavigationDelegate.h:
TestWebKitAPI/cocoa/TestNavigationDelegate.mm:

(-[TestNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(-[TestNavigationDelegate waitForDidFailProvisionalNavigation]):

6:31 PM Changeset in webkit [249683] by Fujii Hironori

13 edits in trunk/Tools

[Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references
https://bugs.webkit.org/show_bug.cgi?id=201600

Reviewed by Brent Fulgham.

There were some circular references between
WebKitLegacyBrowserWindow and its delegation classes. For
example, WebKitLegacyBrowserWindow has a reference of
WebDownloadDelegate, and WebDownloadDelegate shares the ref
counter with WebKitLegacyBrowserWindow.

WebNotificationObserver was leaked because it wasn't unregistered
from the default notification center by using
IWebNotificationCenter::removeObserver.

If a new legacy window was created by mouse right click a link,
WebView was released twice because
PrintWebUIDelegate::createWebViewWithRequest didn't AddRef the
WebView.

This change does:

Make delegation classes have own ref-counter to avoid circular references
Do removeObserver notification observers
AddRef WebView in PrintWebUIDelegate::createWebViewWithRequest

MiniBrowser/win/AccessibilityDelegate.cpp:

(AccessibilityDelegate::AddRef):
(AccessibilityDelegate::Release):

MiniBrowser/win/AccessibilityDelegate.h: Added m_refCount.
MiniBrowser/win/MiniBrowserWebHost.cpp:

(MiniBrowserWebHost::QueryInterface):
(MiniBrowserWebHost::AddRef):
(MiniBrowserWebHost::Release):

MiniBrowser/win/MiniBrowserWebHost.h: Added m_refCount.
MiniBrowser/win/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::createWebViewWithRequest): Do AddRef for the returned IWebView.
(PrintWebUIDelegate::AddRef):
(PrintWebUIDelegate::Release):

MiniBrowser/win/PrintWebUIDelegate.h: Added m_refCount.
MiniBrowser/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::AddRef):
(ResourceLoadDelegate::Release):

MiniBrowser/win/ResourceLoadDelegate.h: Added m_refCount.
MiniBrowser/win/WebDownloadDelegate.cpp:

(WebDownloadDelegate::AddRef):
(WebDownloadDelegate::Release):

MiniBrowser/win/WebDownloadDelegate.h: Added m_refCount.
MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:

(WebKitLegacyBrowserWindow::~WebKitLegacyBrowserWindow): Do removeObserver notification observers.
(WebKitLegacyBrowserWindow::init):
(WebKitLegacyBrowserWindow::setUIDelegate):
(WebKitLegacyBrowserWindow::setAccessibilityDelegate):
(WebKitLegacyBrowserWindow::setResourceLoadDelegate):
(WebKitLegacyBrowserWindow::setDownloadDelegate):
(WebKitLegacyBrowserWindow::AddRef): Deleted.
(WebKitLegacyBrowserWindow::Release): Deleted.
(WebKitLegacyBrowserWindow::setFrameLoadDelegate): Deleted.
(WebKitLegacyBrowserWindow::setFrameLoadDelegatePrivate): Deleted.

MiniBrowser/win/WebKitLegacyBrowserWindow.h:

6:28 PM Changeset in webkit [249682] by Fujii Hironori

2 edits in trunk/Source/WebKitLegacy/win

[Win][WebKitLegacy] WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage]
https://bugs.webkit.org/show_bug.cgi?id=201601

Reviewed by Ross Kirsling.

Fixed a clang-cl warning. Names which aren't dllexport-ed don't
need to be in a extern "C" scope because they aren't exported to
other DLLs.

WebKitDLL.h: Moved some variables and gClassNameCount() out of extern "C" scope.

6:01 PM Changeset in webkit [249681] by timothy_horton@apple.com

5 edits in trunk/Source

Clarify some macCatalyst feature flags
https://bugs.webkit.org/show_bug.cgi?id=201619
<rdar://problem/54615618>

Reviewed by Megan Gardner.

Source/WebKit:

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _showShareSheet:inRect:completionHandler:]):
We prefer specific flags over platform checks.

Source/WTF:

wtf/Platform.h:

We prefer specific flags over platform checks.

5:45 PM Changeset in webkit [249680] by Ryan Haddad

2 edits in trunk/LayoutTests

Unreviewed test gardening, update test expectations for rdar://problem/51229282.

platform/mac-wk1/TestExpectations:

5:38 PM Changeset in webkit [249679] by Ryan Haddad

2 edits in trunk/LayoutTests

Unreviewed test gardening, update test expectations for rdar://problem/51766135.

platform/ios/TestExpectations:

5:32 PM Changeset in webkit [249678] by Ryan Haddad

2 edits in trunk/LayoutTests

REGRESSION(r236540-r236595): ASSERTION FAILED: !frameView

!frameView->isPainting() on plugins/window-open.html

https://bugs.webkit.org/show_bug.cgi?id=199089

Unreviewed test gardening.

platform/mac-wk2/TestExpectations: Skip the test.

5:23 PM Changeset in webkit [249677] by rmorisset@apple.com

2 edits in trunk/Source/JavaScriptCore

[Air] highOrderAdjacents in AbstractColoringAllocator::conservativeHeuristic should be some kind of array
https://bugs.webkit.org/show_bug.cgi?id=197305

Reviewed by Keith Miller.

Currently it is a HashSet, but it only ever holds at most registerCount() items. And linear search tends to be faster on such a small collection than hashing + searching in a HashSet.
Further benefits include avoiding the allocation of the HashSet, not actually adding the nodes adjacent to V (since there are no duplicates in the adjacency lists).

This patch also contains a trivial optimization: if the remaining number of nodes to consider + the number of highOrderAdjacents already seen is smaller than registerCount() we can return true directly.
Apart from that, the patch got some trivial cleanup of GraphColoringRegisterAllocation::allocateOnBank() (that for example was only logging the number of iterations for FP registers, and not the more interesting number for GP registers).

The time spent in the register allocator throughout JetStream2 on this MacBook Pro moves from 3767 / 3710 / 3785 ms to 3551 / 3454 / 3503 ms.
So about a 6% speedup for that phase, and between 1 and 1.5% speedup for FTL/OMG compilation overall.

No new tests as there is no intended change to the code being generated, and this was already tested by running testb3 + JetStream2.

b3/air/AirAllocateRegistersByGraphColoring.cpp:

4:51 PM Changeset in webkit [249676] by Alan Coon

7 edits in branches/safari-608-branch/Source

Versioning.

4:35 PM Changeset in webkit [249675] by Chris Dumez

16 edits
1 move in trunk

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html
https://bugs.webkit.org/show_bug.cgi?id=201596

Reviewed by Alex Christensen.

Source/WebKit:

Allow WKFramePolicyListenerUseWithPolicies() C API to switch to a persistent non-default session.
This is important since WebKitTestRunner is not using the default session anymore and I need to
be able to switch it back to its normal session after going to an ephemeral one.

UIProcess/API/C/WKFramePolicyListener.cpp:

(useWithPolicies):

Tools:

Add new testRunner.setShouldSwapToEphemeralSessionOnNextNavigation() / testRunner.setShouldSwapToDefaultSessionOnNextNavigation()
test functions to support dynamic switching between ephemeral and default/persistent session in layout tests. The new methods
do the right thing for WebKit2 and truly switch session, unlike setPrivateBrowsingEnabled_DEPRECATED() which was merely making
the WebCore::Document think it changed session.

DumpRenderTree/TestRunner.cpp:

(setShouldSwapToEphemeralSessionOnNextNavigationCallback):
(setShouldSwapToDefaultSessionOnNextNavigationCallback):
(TestRunner::staticFunctions):
(TestRunner::willNavigate):

DumpRenderTree/TestRunner.h:

(TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
(TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):

DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
(WTR::TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::decidePolicyForNavigationAction):

WebKitTestRunner/TestController.h:

(WTR::TestController::setShouldSwapToEphemeralSessionOnNextNavigation):
(WTR::TestController::setShouldSwapToDefaultSessionOnNextNavigation):

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Update layout test to use testRunner.setShouldSwapToEphemeralSessionOnNextNavigation() &
testRunner.setShouldSwapToDefaultSessionOnNextNavigation() instead of the legacy
testRunner.setPrivateBrowsingEnabled_DEPRECATED(). The test needed some extra steps to
navigate whenever we switch session but it is a lot more realistic and is really switching
session on WebKit2. The testRunner.setPrivateBrowsingEnabled_DEPRECATED() was not truly
switching session, just making the document think it did.

http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html:

4:23 PM Changeset in webkit [249674] by Alan Coon

6 edits in branches/safari-608.2.11.1-branch/Source/WebKit

Cherry-pick r249649. rdar://problem/55198064

[macOS] Pid is sometimes invalid when creating sandbox extensions by pid.
https://bugs.webkit.org/show_bug.cgi?id=201543
<rdar://problem/54733465>

Reviewed by Brent Fulgham.

There is a race condition when starting a load of a local file, where the WebContent process has not finished
launching yet, and its pid is not available. When we try to create a sandbox extension by using the pid of the
WebContent process, it is not available in the cases where the WebContent process has just launched and has not
finished launching yet. This patch creates a new dummy Web page message, 'LoadRequestWaitingForPID', which will
be sent instead of a normal 'LoadRequest' message, and only when the WebContent process has not finished
launching. When the WebContent process has finished launching, and we are about to actually send the pending
messages, we can detect that a 'LoadRequestWaitingForPID' has been appended for sending, and replace it with a
normal 'LoadReqest' message where we have created the sandbox extension issue with a valid pid. The message
'LoadRequestWaitingForPID' is never intended to reach the WebContent process, it is just there to replace with
a normal 'LoadRequest' message with a new sandbox extension. In the implementation of the message handler on
the WebContent process side, we assert that the method is never called. This patch makes sure the ordering of
the Web page messages are the same, even when we modify the message.

UIProcess/AuxiliaryProcessProxy.cpp: (WebKit::AuxiliaryProcessProxy::didFinishLaunching):
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle): (WebKit::WebPageProxy::loadRequestWithNavigationShared): (WebKit::WebPageProxy::loadFile):
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::fileLoadRequest):
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:23 PM Changeset in webkit [249673] by Alan Coon

2 edits in branches/safari-608.2.11.1-branch/Source/WebKit

Cherry-pick r249454. rdar://problem/55198064

[macOS] Unable to open local file from favorites bar
https://bugs.webkit.org/show_bug.cgi?id=201444

Reviewed by Brent Fulgham.

The sandbox extension handle should be created providing the pid of the receiving process.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:14 PM Changeset in webkit [249672] by Chris Dumez

87 edits
26 adds
10 deletes in trunk/LayoutTests

Resync service workers WPT tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=201589

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Resync service workers WPT tests from upstream 820f0f86047e6e26401e.

web-platform-tests/service-workers/service-worker/Service-Worker-Allowed-header.https-expected.txt:
web-platform-tests/service-workers/service-worker/Service-Worker-Allowed-header.https.html:
web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/postmessage.https.html:
web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https.html:
web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html:
web-platform-tests/service-workers/service-worker/about-blank-replacement.https.html:
web-platform-tests/service-workers/service-worker/activate-event-after-install-state-change.https.html:
web-platform-tests/service-workers/service-worker/activation-after-registration.https.html:
web-platform-tests/service-workers/service-worker/activation.https-expected.txt:
web-platform-tests/service-workers/service-worker/activation.https.html:
web-platform-tests/service-workers/service-worker/appcache-ordering-main.https.html:
web-platform-tests/service-workers/service-worker/claim-fetch-with-appcache.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/claim-fetch-with-appcache.https.html: Removed.
web-platform-tests/service-workers/service-worker/claim-fetch.https.html:
web-platform-tests/service-workers/service-worker/claim-not-using-registration.https.html:
web-platform-tests/service-workers/service-worker/claim-shared-worker-fetch.https.html:
web-platform-tests/service-workers/service-worker/claim-using-registration.https.html:
web-platform-tests/service-workers/service-worker/claim-worker-fetch.https-expected.txt:
web-platform-tests/service-workers/service-worker/claim-worker-fetch.https.html:
web-platform-tests/service-workers/service-worker/client-id.https.html:
web-platform-tests/service-workers/service-worker/clients-get-client-types.https.html:
web-platform-tests/service-workers/service-worker/clients-get-resultingClientId.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/clients-get-resultingClientId.https.html: Removed.
web-platform-tests/service-workers/service-worker/clients-get.https-expected.txt:
web-platform-tests/service-workers/service-worker/clients-get.https.html:
web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https.html:
web-platform-tests/service-workers/service-worker/clients-matchall-exact-controller.https-expected.txt:
web-platform-tests/service-workers/service-worker/clients-matchall-exact-controller.https.html:
web-platform-tests/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html:
web-platform-tests/service-workers/service-worker/clients-matchall-order.https.html:
web-platform-tests/service-workers/service-worker/clients-matchall.https.html:
web-platform-tests/service-workers/service-worker/controller-on-disconnect.https.html:
web-platform-tests/service-workers/service-worker/controller-on-load.https.html:
web-platform-tests/service-workers/service-worker/controller-on-reload.https.html:
web-platform-tests/service-workers/service-worker/data-transfer-files.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/data-transfer-files.https.html: Removed.
web-platform-tests/service-workers/service-worker/detached-context.https-expected.txt:
web-platform-tests/service-workers/service-worker/detached-context.https.html:
web-platform-tests/service-workers/service-worker/extendable-event-async-waituntil.https-expected.txt:
web-platform-tests/service-workers/service-worker/extendable-event-async-waituntil.https.html:
web-platform-tests/service-workers/service-worker/extendable-event-waituntil.https.html:
web-platform-tests/service-workers/service-worker/fetch-audio-tainting.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/fetch-audio-tainting.https.html: Removed.
web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-double-write.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-double-write.https.html: Removed.
web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video-cache.https.html:
web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video.https.html:
web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html:
web-platform-tests/service-workers/service-worker/fetch-csp.https.html:
web-platform-tests/service-workers/service-worker/fetch-event-after-navigation-within-page.https.html:
web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html:
web-platform-tests/service-workers/service-worker/fetch-event-network-error.https.html:
web-platform-tests/service-workers/service-worker/fetch-event-referrer-policy.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-event-referrer-policy.https.html:
web-platform-tests/service-workers/service-worker/fetch-event-respond-with-argument.https.html:
web-platform-tests/service-workers/service-worker/fetch-event-respond-with-body-loaded-in-chunk.https.html:
web-platform-tests/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html:
web-platform-tests/service-workers/service-worker/fetch-event-throws-after-respond-with.https.html:
web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-event.https.html:
web-platform-tests/service-workers/service-worker/fetch-frame-resource.https.html:
web-platform-tests/service-workers/service-worker/fetch-header-visibility.https.html:
web-platform-tests/service-workers/service-worker/fetch-request-css-base-url.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-request-css-base-url.https.html:
web-platform-tests/service-workers/service-worker/fetch-request-css-images.https.html:
web-platform-tests/service-workers/service-worker/fetch-request-html-imports.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-request-html-imports.https.html:
web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html:
web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html:
web-platform-tests/service-workers/service-worker/fetch-request-xhr-sync.https.html:
web-platform-tests/service-workers/service-worker/fetch-response-xhr.https.html:
web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html:
web-platform-tests/service-workers/service-worker/getregistration.https-expected.txt:
web-platform-tests/service-workers/service-worker/getregistration.https.html:
web-platform-tests/service-workers/service-worker/import-module-scripts.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/import-module-scripts.https.html: Removed.
web-platform-tests/service-workers/service-worker/import-scripts-mime-types.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/import-scripts-mime-types.https.html: Removed.
web-platform-tests/service-workers/service-worker/import-scripts-resource-map.https-expected.txt:
web-platform-tests/service-workers/service-worker/import-scripts-resource-map.https.html:
web-platform-tests/service-workers/service-worker/interfaces-window.https.html:
web-platform-tests/service-workers/service-worker/invalid-blobtype.https.html:
web-platform-tests/service-workers/service-worker/invalid-header.https.html:
web-platform-tests/service-workers/service-worker/iso-latin1-header.https.html:
web-platform-tests/service-workers/service-worker/multiple-update.https.html:
web-platform-tests/service-workers/service-worker/navigation-redirect.https.html:
web-platform-tests/service-workers/service-worker/onactivate-script-error.https.html:
web-platform-tests/service-workers/service-worker/performance-timeline.https.html:
web-platform-tests/service-workers/service-worker/postmessage-from-waiting-serviceworker.https.html:
web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https.html: Removed.
web-platform-tests/service-workers/service-worker/postmessage-to-client.https.html:
web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt:
web-platform-tests/service-workers/service-worker/postmessage.https.html:
web-platform-tests/service-workers/service-worker/ready.https.html:
web-platform-tests/service-workers/service-worker/redirected-response.https-expected.txt:
web-platform-tests/service-workers/service-worker/redirected-response.https.html:
web-platform-tests/service-workers/service-worker/referer.https.html:
web-platform-tests/service-workers/service-worker/register-default-scope.https.html:
web-platform-tests/service-workers/service-worker/register-wait-forever-in-install-worker.https.html:
web-platform-tests/service-workers/service-worker/registration-end-to-end.https.html:
web-platform-tests/service-workers/service-worker/registration-events.https.html:
web-platform-tests/service-workers/service-worker/registration-mime-types.https-expected.txt:
web-platform-tests/service-workers/service-worker/registration-mime-types.https.html:
web-platform-tests/service-workers/service-worker/registration-schedule-job.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/registration-schedule-job.https.html: Removed.
web-platform-tests/service-workers/service-worker/registration-scope.https-expected.txt:
web-platform-tests/service-workers/service-worker/registration-security-error.https-expected.txt:
web-platform-tests/service-workers/service-worker/registration-service-worker-attributes.https.html:
web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html:
web-platform-tests/service-workers/service-worker/resource-timing.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resource-timing.sub.https.html.
web-platform-tests/service-workers/service-worker/resource-timing.sub.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-ping-frame.py:
web-platform-tests/service-workers/service-worker/resources/appcache-ordering.manifest:
web-platform-tests/service-workers/service-worker/resources/claim-worker.js:
web-platform-tests/service-workers/service-worker/resources/classic-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/clients-get-cross-origin-frame.html:
web-platform-tests/service-workers/service-worker/resources/clients-get-resultingClientId-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/clients-get-worker.js:

(self.onmessage):

web-platform-tests/service-workers/service-worker/resources/enable-client-message-queue.html: Removed.
web-platform-tests/service-workers/service-worker/resources/extendable-event-async-waituntil.js:

(switch):
(event.request.url.indexOf):
(else.event.request.url.indexOf):

web-platform-tests/service-workers/service-worker/resources/fetch-canvas-tainting-double-write-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/fetch-cors-xhr-iframe.html:
web-platform-tests/service-workers/service-worker/resources/fetch-event-async-respond-with-worker.js:

(setTimeout):

web-platform-tests/service-workers/service-worker/resources/fetch-event-network-fallback-worker.js:
web-platform-tests/service-workers/service-worker/resources/fetch-event-test-worker.js:
web-platform-tests/service-workers/service-worker/resources/fetch-request-css-base-url-iframe.html:
web-platform-tests/service-workers/service-worker/resources/fetch-request-css-base-url-worker.js:

(self.onmessage):
(url.indexOf):
(else.url.indexOf):

web-platform-tests/service-workers/service-worker/resources/get-resultingClientId-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/import-relative.xsl: Removed.
web-platform-tests/service-workers/service-worker/resources/import-scripts-diff-resource-map-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/import-scripts-get.py: Removed.
web-platform-tests/service-workers/service-worker/resources/import-scripts-mime-types-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/imported-classic-script.js: Removed.
web-platform-tests/service-workers/service-worker/resources/imported-module-script.js: Removed.
web-platform-tests/service-workers/service-worker/resources/message-vs-microtask.html: Removed.
web-platform-tests/service-workers/service-worker/resources/module-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/navigation-redirect-other-origin.html:
web-platform-tests/service-workers/service-worker/resources/navigation-redirect-out-scope.py:
web-platform-tests/service-workers/service-worker/resources/navigation-redirect-scope1.py:
web-platform-tests/service-workers/service-worker/resources/navigation-redirect-scope2.py:
web-platform-tests/service-workers/service-worker/resources/nested-iframe-parent.html: Removed.
web-platform-tests/service-workers/service-worker/resources/performance-timeline-worker.js:

(promise_test.):
(promise_test):

web-platform-tests/service-workers/service-worker/resources/postmessage-echo-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/redirect-worker.js:

(event.waitUntil.Promise.all.waitUntilPromiseList.then):
(then):
(waitUntilPromise.caches.open.cacheName.then):
(event.respondWith.waitUntilPromise.then):

web-platform-tests/service-workers/service-worker/resources/registration-tests-mime-types.js:

(registration_tests_mime_types):

web-platform-tests/service-workers/service-worker/resources/registration-tests-scope.js:

(registration_tests_scope):

web-platform-tests/service-workers/service-worker/resources/registration-tests-security-error.js:

(registration_tests_security_error):

web-platform-tests/service-workers/service-worker/resources/resource-timing-iframe.sub.html:
web-platform-tests/service-workers/service-worker/resources/service-worker-csp-worker.py:
web-platform-tests/service-workers/service-worker/resources/service-worker-header.py:

(main):

web-platform-tests/service-workers/service-worker/resources/skip-waiting-installed-worker.js:

(event.waitUntil.self.skipWaiting.then):

web-platform-tests/service-workers/service-worker/resources/stalling-service-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/test-helpers.sub.js:

(wait_for_update):
(async.wait_for_activation_on_dummy_scope):

web-platform-tests/service-workers/service-worker/resources/test-request-headers-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/test-request-headers-worker.py: Removed.
web-platform-tests/service-workers/service-worker/resources/trickle.py: Removed.
web-platform-tests/service-workers/service-worker/resources/update-during-installation-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/update-during-installation-worker.py: Removed.
web-platform-tests/service-workers/service-worker/resources/update-fetch-worker.py: Removed.
web-platform-tests/service-workers/service-worker/resources/update-missing-import-scripts-imported-worker.py: Removed.
web-platform-tests/service-workers/service-worker/resources/update-missing-import-scripts-main-worker.py: Removed.
web-platform-tests/service-workers/service-worker/resources/update-registration-with-type.py: Removed.
web-platform-tests/service-workers/service-worker/resources/w3c-import.log:
web-platform-tests/service-workers/service-worker/resources/worker-interception-iframe.https.html:
web-platform-tests/service-workers/service-worker/resources/worker-load-interceptor.js:

(self.onfetch):

web-platform-tests/service-workers/service-worker/resources/worker-testharness.js:

(create_temporary_cache):

web-platform-tests/service-workers/service-worker/resources/xhr-iframe.html: Removed.
web-platform-tests/service-workers/service-worker/resources/xhr-response-url-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/xsl-base-url-iframe.xml: Removed.
web-platform-tests/service-workers/service-worker/resources/xsl-base-url-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/xslt-pass.xsl: Removed.
web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https-expected.txt:
web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt:
web-platform-tests/service-workers/service-worker/service-worker-csp-script.https-expected.txt:
web-platform-tests/service-workers/service-worker/service-worker-header.https-expected.txt:
web-platform-tests/service-workers/service-worker/service-worker-header.https.html:
web-platform-tests/service-workers/service-worker/serviceworker-message-event-historical.https.html:
web-platform-tests/service-workers/service-worker/shared-worker-controlled.https.html:
web-platform-tests/service-workers/service-worker/skip-waiting-installed.https-expected.txt:
web-platform-tests/service-workers/service-worker/skip-waiting-installed.https.html:
web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https.html:
web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https.html:
web-platform-tests/service-workers/service-worker/skip-waiting.https.html:
web-platform-tests/service-workers/service-worker/state.https.html:
web-platform-tests/service-workers/service-worker/synced-state.https.html:
web-platform-tests/service-workers/service-worker/uncontrolled-page.https.html:
web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https-expected.txt:
web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html:
web-platform-tests/service-workers/service-worker/unregister-then-register.https-expected.txt:
web-platform-tests/service-workers/service-worker/unregister-then-register.https.html:
web-platform-tests/service-workers/service-worker/update-after-navigation-redirect.https.html:
web-platform-tests/service-workers/service-worker/update-after-oneday.https.html:
web-platform-tests/service-workers/service-worker/update-bytecheck.https.html:
web-platform-tests/service-workers/service-worker/update-missing-import-scripts.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/update-missing-import-scripts.https.html: Removed.
web-platform-tests/service-workers/service-worker/update-no-cache-request-headers.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/update-no-cache-request-headers.https.html: Removed.
web-platform-tests/service-workers/service-worker/update-not-allowed.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/update-not-allowed.https.html: Removed.
web-platform-tests/service-workers/service-worker/update-on-navigation.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/update-on-navigation.https.html: Removed.
web-platform-tests/service-workers/service-worker/update-recovery.https.html:
web-platform-tests/service-workers/service-worker/update-registration-with-type.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/update-registration-with-type.https.html: Removed.
web-platform-tests/service-workers/service-worker/w3c-import.log:
web-platform-tests/service-workers/service-worker/websocket.https-expected.txt:
web-platform-tests/service-workers/service-worker/websocket.https.html:
web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html:
web-platform-tests/service-workers/service-worker/worker-client-id.https-expected.txt:
web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:
web-platform-tests/service-workers/service-worker/worker-interception.https.html:
web-platform-tests/service-workers/service-worker/xhr-response-url.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/xhr-response-url.https.html: Removed.
web-platform-tests/service-workers/service-worker/xsl-base-url.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/xsl-base-url.https.html: Removed.

LayoutTests:

TestExpectations:

3:45 PM Changeset in webkit [249671] by achristensen@apple.com

10 edits in trunk/Source/WebKit

Deprecate unused SPI to preconnect to a server
https://bugs.webkit.org/show_bug.cgi?id=201558

Reviewed by Youenn Fablet.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::preconnectTo): Deleted.

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/API/C/WKContext.cpp:

(WKContextPreconnectToServer):

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _preconnectToServer:]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::preconnectToServer): Deleted.

UIProcess/WebProcessPool.h:

3:38 PM Changeset in webkit [249670] by msaboff@apple.com

12 edits in trunk/Source/bmalloc

Revert to pre-r243144 scavenging behavior for macOS
https://bugs.webkit.org/show_bug.cgi?id=201555

Reviewed by Saam Barati.

The change in r243144 regressed internal power metrics for some Mac models.

bmalloc/Heap.cpp:

(bmalloc::Heap::scavenge):
(bmalloc::Heap::scavengeToHighWatermark):
(bmalloc::Heap::allocateSmallChunk):
(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::allocateLarge):

bmalloc/Heap.h:
bmalloc/IsoDirectory.h:
bmalloc/IsoDirectoryInlines.h:

(bmalloc::passedNumPages>::takeFirstEligible):
(bmalloc::passedNumPages>::scavenge):
(bmalloc::passedNumPages>::scavengeToHighWatermark):

bmalloc/IsoHeapImpl.h:
bmalloc/IsoHeapImplInlines.h:

(bmalloc::IsoHeapImpl<Config>::scavengeToHighWatermark):

bmalloc/LargeMap.cpp:

(bmalloc::LargeMap::add):

bmalloc/LargeRange.h:

(bmalloc::LargeRange::LargeRange):
(bmalloc::merge):

bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::Scavenger):
(bmalloc::Scavenger::timeSinceLastPartialScavenge):
(bmalloc::Scavenger::scavenge):
(bmalloc::Scavenger::partialScavenge):
(bmalloc::Scavenger::threadRunLoop):

bmalloc/Scavenger.h:
bmalloc/SmallPage.h:

3:17 PM Changeset in webkit [249669] by pvollan@apple.com

2 edits in trunk/Source/WebKit

Unreviewed Windows build fix.

WebProcess/WebPage/WebPage.h:

2:38 PM Changeset in webkit [249668] by ysuzuki@apple.com

6 edits
1 add in trunk

[JSC] Use metadata table to iterate specific bytecode metadata instead of propertyAccessInstructions vector
https://bugs.webkit.org/show_bug.cgi?id=201613

Reviewed by Mark Lam.

We do not need to maintain propertyAccessInstructions vector to access metadata tied to a specific bytecode opcode
since we have MetadataTable::forEach<Op> feature. This removes propertyAccessInstructions entirely, and fixes the
issue that op_create_promise missed propertyAccessInstructions registration (a name "propertyAccessInstructions" is
misleading, it is like "instructions-requires-llint-finalize").

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeLLIntInlineCaches):

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::applyModification):
(JSC::UnlinkedCodeBlock::shrinkToFit):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::addPropertyAccessInstruction): Deleted.
(JSC::UnlinkedCodeBlock::numberOfPropertyAccessInstructions const): Deleted.
(JSC::UnlinkedCodeBlock::propertyAccessInstructions const): Deleted.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitGetFromScope):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitDirectGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCreateThis):
(JSC::BytecodeGenerator::emitToThis):

runtime/CachedTypes.cpp:

(JSC::CachedCodeBlock<CodeBlockType>::decode const):
(JSC::CachedCodeBlock<CodeBlockType>::encode):

2:20 PM Changeset in webkit [249667] by aakash_jain@apple.com

2 edits in trunk/Tools

EWS testtube emoji doesn't exist on macOS Mojave
https://bugs.webkit.org/show_bug.cgi?id=201532

Reviewed by Simon Fraser.

BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble): Change the emoji to microscope emoji.

2:15 PM Changeset in webkit [249666] by jonlee@apple.com

1 edit
11 adds in trunk/Websites/webkit.org

Add Babylon demos
https://bugs.webkit.org/show_bug.cgi?id=201611

Rubber-stamped by Justin Fan.

demos/webgpu/babylon/LICENSE: Added.
demos/webgpu/babylon/babylonWebGpu.max.js: Added.
demos/webgpu/babylon/logo.svg: Added.
demos/webgpu/babylon/oneHelmetWebGPU.html: Added.
demos/webgpu/babylon/oneHelmetWebGPUGLSLShaders.js: Added.
demos/webgpu/babylon/oneHelmetWebGPUWSLShaders.js: Added.
demos/webgpu/babylon/oneSphereWebGPU.html: Added.
demos/webgpu/babylon/oneSphereWebGPUGLSLShaders.js: Added.
demos/webgpu/babylon/oneSphereWebGPUWSLShaders.js: Added.
demos/webgpu/babylon/vertexShaderGLSL1.glsl: Added.

2:07 PM Changeset in webkit [249665] by jonlee@apple.com

1 edit
3 adds in trunk/Websites/webkit.org

Add boids time test
https://bugs.webkit.org/show_bug.cgi?id=201612

Rubber-stamped by Justin Fan.

demos/webgpu/compute-boids-compile.html: Added.
demos/webgpu/scripts/compute-boids-compile.js: Added.
demos/webgpu/scripts/compute-boids-utils.js: Added.

1:54 PM Changeset in webkit [249664] by sbarati@apple.com

2 edits in trunk/Source/WebCore

Unreviewed follow up to r249630. We need padding for ADDRESS32 CPUs to allow replaceWith to work on the intended types.

Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h:

1:36 PM Changeset in webkit [249663] by aakash_jain@apple.com

2 edits in trunk/Tools

[EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
https://bugs.webkit.org/show_bug.cgi?id=201607

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/steps.py:

(AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
(AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.

1:32 PM Changeset in webkit [249662] by Adrian Perez de Castro

1 copy in releases/WPE WebKit/webkit-2.25.91

WPE WebKit 2.25.91

1:32 PM Changeset in webkit [249661] by keith_miller@apple.com

11 edits
10 adds in trunk

OSR entry into wasm misses some contexts
https://bugs.webkit.org/show_bug.cgi?id=201569

Reviewed by Yusuke Suzuki.

JSTests:

Add a new harness and wast and the generated wasm file for
testing. The idea long term is to make it easy to test by creating
a C file and converting it to a wast then modify that to produce a
test.

wasm.yaml:
wasm/wast-tests/harness.js: Added.

(async.runWasmFile):

wasm/wast-tests/osr-entry-inner-loop-branch-above-no-consts.wasm: Added.
wasm/wast-tests/osr-entry-inner-loop-branch-above-no-consts.wast: Added.
wasm/wast-tests/osr-entry-inner-loop-branch-above.wasm: Added.
wasm/wast-tests/osr-entry-inner-loop-branch-above.wast: Added.
wasm/wast-tests/osr-entry-inner-loop.wasm: Added.
wasm/wast-tests/osr-entry-inner-loop.wast: Added.
wasm/wast-tests/osr-entry-multiple-enclosed-contexts.wasm: Added.
wasm/wast-tests/osr-entry-multiple-enclosed-contexts.wast: Added.

Source/JavaScriptCore:

This patch fixes an issue where we could fail to capture some of
our contexts when OSR entering into wasm code. Before we would
only capture the state of the block immediately surrounding the
entrance loop block header. We actually need to capture all
enclosed stacks.

Additionally, we don't need to use variables for all the captured
values. We can use a Phi and insert an upsilon just below the
captured value.

interpreter/CallFrame.h:
jsc.cpp:

(GlobalObject::finishCreation):
(functionCallerIsOMGCompiled):

wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::AirIRGenerator):
(JSC::Wasm::AirIRGenerator::emitEntryTierUpCheck):
(JSC::Wasm::AirIRGenerator::emitLoopTierUpCheck):
(JSC::Wasm::AirIRGenerator::addLoop):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::createStack):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::addConstant):
(JSC::Wasm::B3IRGenerator::emitEntryTierUpCheck):
(JSC::Wasm::B3IRGenerator::emitLoopTierUpCheck):
(JSC::Wasm::B3IRGenerator::addLoop):
(JSC::Wasm::B3IRGenerator::addEndToUnreachable):
(JSC::Wasm::dumpExpressionStack):
(JSC::Wasm::B3IRGenerator::dump):
(JSC::Wasm::B3IRGenerator::Stack::Stack): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::append): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::takeLast): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::last): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::size const): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::isEmpty const): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::convertToExpressionList): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::at const): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::variableAt const): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::shrink): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::swap): Deleted.
(JSC::Wasm::B3IRGenerator::Stack::dump const): Deleted.

wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser::controlStack):

Tools:

Add new test harness mode for tests created from wast files.

Scripts/run-jsc-stress-tests:

1:32 PM Changeset in webkit [249660] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.26

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.25.91 release

Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

wpe/NEWS: Add release notes for 2.25.91.

1:29 PM Changeset in webkit [249659] by Alan Coon

7 edits in trunk/Source

Versioning.

1:23 PM Changeset in webkit [249658] by Alan Coon

7 edits in branches/safari-608.2.11.1-branch/Source

Versioning.

12:30 PM Changeset in webkit [249657] by jonlee@apple.com

7 edits
2 copies
2 moves
2 adds in trunk

Upload triangles tests for 3D suite in MotionMark
https://bugs.webkit.org/show_bug.cgi?id=201606

Reviewed by Simon Fraser.

PerformanceTests:

MotionMark/resources/debug-runner/motionmark.css:
MotionMark/resources/debug-runner/tests.js:
MotionMark/tests/3d/resources/webgl.js:
MotionMark/tests/3d/resources/webgpu.js: Added.
MotionMark/tests/3d/triangles-webgl.html: Renamed from Websites/browserbench.org/MotionMark1.1/tests/3d/webgl.html.
MotionMark/tests/3d/triangles-webgpu.html: Copied from PerformanceTests/MotionMark/tests/3d/webgl.html.

Websites/browserbench.org:

MotionMark1.1/resources/debug-runner/tests.js:
MotionMark1.1/tests/3d/resources/webgl.js:
MotionMark1.1/tests/3d/resources/webgpu.js: Added.
MotionMark1.1/tests/3d/triangles-webgl.html: Copied from PerformanceTests/MotionMark/tests/3d/webgl.html.
MotionMark1.1/tests/3d/triangles-webgpu.html: Renamed from PerformanceTests/MotionMark/tests/3d/webgl.html.

12:16 PM Changeset in webkit [249656] by jiewen_tan@apple.com

2 edits in trunk/LayoutTests

Layout Test http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=198810

Reviewed by Dewei Zhu.

http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https.html:

Removed the timeout value given these tests should report the exception immediately.

12:02 PM Changeset in webkit [249655] by Joseph Pecoraro

7 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Overview Timeline View has jarring white box-shadows in dark mode
https://bugs.webkit.org/show_bug.cgi?id=201442
<rdar://problem/54999794>

Reviewed by Devin Rousso.

UserInterface/Views/DataGrid.css:

(.data-grid:not(.variable-height-rows) table.data):
(.data-grid:not(.variable-height-rows) table.data.even-first-zebra-stripe):
(.data-grid.variable-height-rows.even-first-zebra-stripe table.data tr:nth-child(odd)):
(.data-grid.variable-height-rows.even-first-zebra-stripe table.data tr:nth-child(even)):
(.data-grid:not(.variable-height-rows) table.data.odd-first-zebra-stripe): Deleted.
(.data-grid.variable-height-rows.odd-first-zebra-stripe table.data tr:nth-child(odd)): Deleted.
(.data-grid.variable-height-rows.odd-first-zebra-stripe table.data tr:nth-child(even)): Deleted.

UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype.updateVisibleRows):

UserInterface/Views/Table.css:

(.table > .data-container > .data-list):
(.table > .data-container > .data-list.even-first-zebra-stripe):
(.table > .data-container > .data-list.odd-first-zebra-stripe): Deleted.

UserInterface/Views/Table.js:

In the gradients "even" was mistakenly first. Fix these so that "odd" is first and the
unusual case would be having "even" first. This allows us to line up with nth-of-type(even).

UserInterface/Views/Main.css:

(:root):
(@media (prefers-color-scheme: dark)):
Flip even and odd so we maintain the same styles for gradients.

UserInterface/Views/OverviewTimelineView.css:

(.timeline-view.overview > .data-grid tr):
(.timeline-view.overview > .data-grid tr:nth-child(even)):
(.timeline-view.overview > .data-grid tr.parent:not(.expanded) td.graph-column .timeline-record-bar:not(.has-inactive-segment) > .segment):
(.timeline-view.overview > .data-grid tr.parent:not(.expanded).selected td.graph-column .timeline-record-bar:not(.has-inactive-segment) > .segment):
(.timeline-view.overview > .data-grid tr.parent:not(.expanded) td.graph-column .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(.timeline-view.overview > .data-grid tr.parent:not(.expanded).selected td.graph-column .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(@media (prefers-color-scheme: dark)):
(WI.Table.prototype._updateVisibleRows):

UserInterface/Views/Variables.css:

12:01 PM Changeset in webkit [249654] by Alan Bujtas

9 edits in trunk/Source/WebCore

[LFC][TFC] Introduce cell spacing.
https://bugs.webkit.org/show_bug.cgi?id=201605
<rdar://problem/55184009>

Reviewed by Antti Koivisto.

This patch adds support for horizontal and vertical cell spacing (border-spacing). Now LFC matches table geometry for simple table content with multiple columns and rows.

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const): Now we can use the generic, check the inflow content logic for table height.

layout/LayoutUnits.h:

(WebCore::Layout::HorizontalEdges::width const):
(WebCore::Layout::VerticalEdges::height const):

layout/Verification.cpp:

(WebCore::Layout::verifyAndOutputSubtree):

layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layout):
(WebCore::Layout::TableFormattingContext::layoutTableCellBox):
(WebCore::Layout::TableFormattingContext::positionTableCells):
(WebCore::Layout::TableFormattingContext::setComputedGeometryForRows):
(WebCore::Layout::TableFormattingContext::setComputedGeometryForSections):
(WebCore::Layout::TableFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::TableFormattingContext::ensureTableGrid):
(WebCore::Layout::TableFormattingContext::computePreferredWidthForColumns):
(WebCore::Layout::TableFormattingContext::computedTableWidth):
(WebCore::Layout::TableFormattingContext::useAsContentLogicalWidth):

layout/tableformatting/TableFormattingContext.h:
layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::tableCellHeightAndMargin const):

layout/tableformatting/TableGrid.cpp:

(WebCore::Layout::TableGrid::appendCell):
(WebCore::Layout::TableGrid::widthConstraints const):
(WebCore::Layout::TableGrid::ColumnsContext::useAsLogicalWidth): Deleted.

layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::setHorizontalSpacing):
(WebCore::Layout::TableGrid::horizontalSpacing const):
(WebCore::Layout::TableGrid::setVerticalSpacing):
(WebCore::Layout::TableGrid::verticalSpacing const):
(WebCore::Layout::TableGrid::ColumnsContext::logicalWidth const):

11:56 AM Changeset in webkit [249653] by dbates@webkit.org

2 edits in trunk/Tools

Remove all selection view animations before dumping results
https://bugs.webkit.org/show_bug.cgi?id=199241

Reviewed by Wenson Hsieh.

On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
historical tests that were written for Mac and expect Mac's lack of animations that we run on
iOS and are flaky. Let's try to remove all selection view animations before dumping results and
see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
API for a test to remove selection animations at any time during the run.

WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::notifyDone):

11:29 AM Changeset in webkit [249652] by Jonathan Bedard

4 edits in trunk/Tools

run-webkit-tests: Report results archive to results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=201321

Reviewed by Aakash Jain.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run): After all tests are finish, upload the results archive for each
configuration.

Scripts/webkitpy/results/upload.py:

(Upload):
(Upload.init): Automatically define timestamp.
(Upload.upload_archive): Upload an archive associated with the test run.

Scripts/webkitpy/results/upload_unittest.py:

(UploadTest.test_buildbot):
(UploadTest):
(UploadTest.test_archive_upload):

10:52 AM Changeset in webkit [249651] by Ryan Haddad

9 edits in trunk

Unreviewed, rolling out r249574.

Caused fast/mediastream/media-stream-track-source-failure.html
to become flaky.

Reverted changeset:

"Remove MediaStreamPrivate::scheduleDeferredTask"
https://bugs.webkit.org/show_bug.cgi?id=200975
https://trac.webkit.org/changeset/249574

10:52 AM Changeset in webkit [249650] by ysuzuki@apple.com

8 edits
1 add in trunk

[JSC] Promise resolve/reject functions should be created more efficiently
https://bugs.webkit.org/show_bug.cgi?id=201488

Reviewed by Mark Lam.

JSTests:

microbenchmarks/promise-creation-many.js: Added.

(executor):

Source/JavaScriptCore:

While r246553 fixed an important issue, it makes anonymous-builtin-function creation costly since it enforces FunctionRareData allocations.
Unfortunately, anonymous-builtin-function function can be created frequently since this type of function is used
for resolve and reject arguments of Promise's executor (e.g. new Promise((resolve, reject) => ...)'s resolve and reject).
Since we are now always creating FunctionRareData for these functions, this additional allocation makes promise creation slower.

In this patch, we use isAnonymousBuiltinFunction information for hasReifiedName correctly. And we propagate isAnonymousBuiltinFunction information
to FunctionRareData to initialize m_hasReifiedName correctly. Then we can avoid unnecessary FunctionRareData allocation, which makes
anonymous-builtin-function creation faster.

We can ensure that this patch does not revert r246553's fix by running JSTests/stress/builtin-private-function-name.js test.
The simple microbenchmark shows 1.7x improvement.

ToT Patched

promise-creation-many 45.6701+-0.1488 ^{26.8663+-1.8336} definitely 1.6999x faster

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewFunctionCommon):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):

runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::create):
(JSC::FunctionRareData::FunctionRareData):

runtime/FunctionRareData.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::allocateRareData):
(JSC::JSFunction::allocateAndInitializeRareData):

runtime/JSFunctionInlines.h:

(JSC::JSFunction::hasReifiedName const):

10:44 AM Changeset in webkit [249649] by pvollan@apple.com

6 edits in trunk/Source/WebKit

[macOS] Pid is sometimes invalid when creating sandbox extensions by pid.
https://bugs.webkit.org/show_bug.cgi?id=201543
<rdar://problem/54733465>

Reviewed by Brent Fulgham.

There is a race condition when starting a load of a local file, where the WebContent process has not finished
launching yet, and its pid is not available. When we try to create a sandbox extension by using the pid of the
WebContent process, it is not available in the cases where the WebContent process has just launched and has not
finished launching yet. This patch creates a new dummy Web page message, 'LoadRequestWaitingForPID', which will
be sent instead of a normal 'LoadRequest' message, and only when the WebContent process has not finished
launching. When the WebContent process has finished launching, and we are about to actually send the pending
messages, we can detect that a 'LoadRequestWaitingForPID' has been appended for sending, and replace it with a
normal 'LoadReqest' message where we have created the sandbox extension issue with a valid pid. The message
'LoadRequestWaitingForPID' is never intended to reach the WebContent process, it is just there to replace with
a normal 'LoadRequest' message with a new sandbox extension. In the implementation of the message handler on
the WebContent process side, we assert that the method is never called. This patch makes sure the ordering of
the Web page messages are the same, even when we modify the message.

UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::didFinishLaunching):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::loadFile):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::fileLoadRequest):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

10:18 AM Changeset in webkit [249648] by Chris Dumez

5 edits
1 copy
1 add in trunk

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html
https://bugs.webkit.org/show_bug.cgi?id=201590

Reviewed by Youenn Fablet.

Tools:

Add a new API test to check that if the default session registers a service worker, the
hasServiceWorkerRegistration flag is still false in an ephemeral session.

TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

LayoutTests:

Split the layout test in 2 to test both the default and the ephemeral session without relying on the
testRunner.setPrivateBrowsingEnabled_DEPRECATED() hack.

http/tests/workers/service/basic-register-expected.txt:
http/tests/workers/service/basic-register-private-expected.txt: Copied from LayoutTests/http/tests/workers/service/basic-register-expected.txt.
http/tests/workers/service/basic-register-private.html: Added.
http/tests/workers/service/resources/basic-register.js:

(async.test):

10:02 AM Changeset in webkit [249647] by youenn@apple.com

11 edits
2 deletes in trunk/Source/WebKit

Remove ServiceWorkerProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=201506

Reviewed by Chris Dumez.

Instead of using a specific ServiceWorkerProcessProxy, move the logic directly in WebProcessProxy.
This will allow us in the future to run a service worker in a process that already runs a web page,
thus saving the need to spin off a new process.

This patch adds a new WebProcessProxy::createForServiceWorkers method instead of creating a
ServiceWorkerProcessProxy. The behavior is then similar: a process running a service worker cannot run a page.

Sources.txt:
UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _hasRegisteredServiceWorker]):

UIProcess/BackgroundProcessResponsivenessTimer.cpp:

(WebKit::BackgroundProcessResponsivenessTimer::shouldBeActive const):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::openNetworkProcessConnection):

UIProcess/ServiceWorkerProcessProxy.cpp: Removed.
UIProcess/ServiceWorkerProcessProxy.h: Removed.
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::establishWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::processForRegistrableDomain):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::updateServiceWorkerUserAgent):
(WebKit::WebProcessPool::mayHaveRegisteredServiceWorkers):
(WebKit::WebProcessPool::updateProcessAssertions):
(WebKit::WebProcessPool::isServiceWorkerPageID const):

UIProcess/WebProcessPool.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createForServiceWorkers):
(WebKit::WebProcessProxy::getLaunchOptions):
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::canBeAddedToWebProcessCache const):
(WebKit::WebProcessProxy::didSetAssertionState):
(WebKit::WebProcessProxy::didExceedCPULimit):
(WebKit::WebProcessProxy::establishServiceWorkerContext):
(WebKit::WebProcessProxy::setServiceWorkerUserAgent):
(WebKit::WebProcessProxy::updateServiceWorkerPreferencesStore):

UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::isRunningServiceWorkers const):
(WebKit::WebProcessProxy::hasServiceWorkerPageProxy):

UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess):

WebKit.xcodeproj/project.pbxproj:

8:35 AM Changeset in webkit [249646] by Jonathan Bedard

2 edits in trunk/Tools

results.webkit.org: mobile-sidebar-control should override button
https://bugs.webkit.org/show_bug.cgi?id=201566

Rubber-stamped by Aakash Jain.

resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:

(@media screen and (min-width: 600px)):
(.mobile-sidebar-control):
(.mobile-sidebar-control.display):

8:21 AM Changeset in webkit [249645] by commit-queue@webkit.org

9 edits
2 adds in trunk

[GTK][WPE] Remove attributes deprecated from MathML3
https://bugs.webkit.org/show_bug.cgi?id=197492

Patch by Rob Buis <rbuis@igalia.com> on 2019-09-09
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Import relevant WPT test.

web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added.
web-platform-tests/mathml/relations/css-styling/attribute-mapping-001.html: Added.

Source/WebCore:

Remove some MathML3 deprecated attributes:
https://github.com/mathml-refresh/mathml/issues/5#issuecomment-475506856

This change also maps the dir attribute to direction for MathML Core.

Test: imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001.html

mathml/MathMLElement.cpp:

(WebCore::MathMLElement::collectStyleForPresentationAttribute):

LayoutTests:

Disable the MathML Core flag for tests assuming MathML3 behavior.

mathml/presentation/attributes-background-color-expected.html:
mathml/presentation/attributes-background-color.html:
mathml/presentation/attributes-mathvariant.html:
mathml/presentation/direction-overall.html:
mathml/presentation/mstyle-css-attributes.html:

5:58 AM Changeset in webkit [249644] by zandobersek@gmail.com

2 edits in trunk/JSTests

Unreviewed JSC test gardening.

stress/constructFunctionSkippingEvalEnabledCheck-should-throw-out-of-memory-error.js:

This test allocates a 2GB string before it goes out and tests
out-of-memory exception when appending other strings to it. As such,
skip the test on memory-limited platforms.

2:44 AM Changeset in webkit [249643] by Carlos Garcia Campos

2 edits in trunk

Unreviewed. Bump GTK version numbers

Source/cmake/OptionsGTK.cmake:

2:21 AM Changeset in webkit [249642] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.26.0

WebKitGTK 2.26.0

2:20 AM Changeset in webkit [249641] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.26

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.26.0 release

Source/cmake/OptionsGTK.cmake: Bump version numbers

Source/WebKit:

gtk/NEWS: Add release notes for 2.26.0.

2:08 AM Changeset in webkit [249640] by youenn@apple.com

13 edits in trunk/Source

Use WebProcess processIdentifier to identify IDB connections between WebProcess and NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=201419

Reviewed by Alex Christensen.

We change from an identifier generated by NetworkProcess to WebProcess identifier.
A WebProcess identifier is unique globally and is stable even in case of NetworkProcess crash.
This removes the need for a sync IPC and makes things more easy to handle in case of NetworkProcess crash.

NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::create):
(WebKit::WebIDBConnectionToClient::WebIDBConnectionToClient):
(WebKit::WebIDBConnectionToClient::getAllDatabaseNames):

NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::establishIDBConnectionToServer):

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
WebKit.xcodeproj/project.pbxproj:
WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):
(WebKit::WebIDBConnectionToServer::identifier const):
(WebKit::WebIDBConnectionToServer::coreConnectionToServer):
(WebKit::WebIDBConnectionToServer::getAllDatabaseNames):

WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::idbConnectionToServerForSession):

WebProcess/Network/NetworkProcessConnection.h:

(WebKit::NetworkProcessConnection::existingIDBConnectionToServer const):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::networkProcessConnectionClosed):

1:54 AM WebKitGTK/2.26.x edited by Carlos Garcia Campos

(diff)

1:51 AM Changeset in webkit [249639] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.26/Source/WebKit

Merge r249569 - [GTK][WPE] Do not enable the sandbox in Snap
https://bugs.webkit.org/show_bug.cgi?id=201486

Reviewed by Carlos Garcia Campos.

Running inside of Snap adds its own complications and is simply
not supported for now.

Also update isInsideFlatpak() for consistency.

UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::isInsideFlatpak):
(WebKit::isInsideSnap):
(WebKit::ProcessLauncher::launchProcess):

1:51 AM Changeset in webkit [249638] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.26/Source/WebKit

Merge r249487 - [WPE][GTK] Fix sandbox parsing DISPLAY on X11
https://bugs.webkit.org/show_bug.cgi?id=201462

Reviewed by Michael Catanzaro.

On some setups the DISPLAY env var was incorrectly parsed.

UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bindX11):

1:50 AM Changeset in webkit [249637] by youenn@apple.com

17 edits
2 deletes in trunk/Source

Move checkProcessLocalPortForActivity from provider to registry
https://bugs.webkit.org/show_bug.cgi?id=201400

Reviewed by Alex Christensen.

Source/WebCore:

Update the registry to take a callback that is used to implement checkProcessLocalPortForActivity.
This allows WK1 and WK2 to have their own implementation.

Make the call to checkProcessLocalPortForActivity directly on the registry.
Remove unneeded worker checkProcessLocalPortForActivity method.
No change of behavior.

dom/messageports/MessagePortChannel.cpp:

(WebCore::MessagePortChannel::checkRemotePortForActivity):

dom/messageports/MessagePortChannelProvider.h:
dom/messageports/MessagePortChannelProviderImpl.cpp:

(WebCore::createMessagePortChannelRegistry):
(WebCore::MessagePortChannelProviderImpl::MessagePortChannelProviderImpl):
(WebCore::MessagePortChannelProviderImpl::checkProcessLocalPortForActivity): Deleted.

dom/messageports/MessagePortChannelProviderImpl.h:
dom/messageports/MessagePortChannelRegistry.cpp:

(WebCore::MessagePortChannelRegistry::MessagePortChannelRegistry):
(WebCore::MessagePortChannelRegistry::checkProcessLocalPortForActivity):

dom/messageports/MessagePortChannelRegistry.h:

(WebCore::MessagePortChannelRegistry::provider): Deleted.

dom/messageports/WorkerMessagePortChannelProvider.cpp:

(WebCore::WorkerMessagePortChannelProvider::checkProcessLocalPortForActivity): Deleted.

dom/messageports/WorkerMessagePortChannelProvider.h:

Source/WebKit:

Implement registry callback at NetworkProcess level.
Remove NetworkMessagePortChannelProvider since only a registry is now needed.

NetworkProcess/NetworkConnectionToWebProcess.cpp:
NetworkProcess/NetworkMessagePortChannelProvider.cpp: Removed.
NetworkProcess/NetworkMessagePortChannelProvider.h: Removed.
NetworkProcess/NetworkProcess.cpp:

(WebKit::createMessagePortChannelRegistry):
(WebKit::m_messagePortChannelRegistry):
(WebKit::m_messagePortChannelProvider): Deleted.

NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::messagePortChannelRegistry):

Sources.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebMessagePortChannelProvider.cpp:

(WebKit::WebMessagePortChannelProvider::checkProcessLocalPortForActivity): Deleted.

WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h:

1:43 AM Changeset in webkit [249636] by Adrian Perez de Castro

2 edits in releases/WebKitGTK/webkit-2.26/Source/WebCore/platform/gtk/po

Merged r249633 - [l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=201592

Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2019-09-09
Rubber-stamped by Carlos Garcia Campos.

pt_BR.po:

1:41 AM Changeset in webkit [249635] by Adrian Perez de Castro

2 edits in releases/WebKitGTK/webkit-2.26/Source/WebCore/platform/gtk/po

Merged r249634 - Updated German translation
https://bugs.webkit.org/show_bug.cgi?id=201582

Patch by Christian Kirbach <Christian.Kirbach@googlemail.com> on 2019-09-07
Rubber-stamped by Adrian Perez de Castro.

de.po:

1:37 AM Changeset in webkit [249634] by Adrian Perez de Castro

2 edits in trunk/Source/WebCore/platform/gtk/po

Updated German translation
https://bugs.webkit.org/show_bug.cgi?id=201582

Patch by Christian Kirbach <Christian.Kirbach@googlemail.com> on 2019-09-07
Rubber-stamped by Adrian Perez de Castro.

de.po:

1:29 AM Changeset in webkit [249633] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=201592

Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2019-09-09
Rubber-stamped by Carlos Garcia Campos.

pt_BR.po:

Sep 8, 2019:

11:41 PM Changeset in webkit [249632] by david_quesada@apple.com

2 edits in trunk/Source/WebKit

Remove some unused constants in VersionChecks.h
https://bugs.webkit.org/show_bug.cgi?id=201599

Reviewed by Youenn Fablet.

UIProcess/Cocoa/VersionChecks.h:

Remove two macros that are unused as of r244512.

9:04 PM Changeset in webkit [249631] by Wenson Hsieh

2 edits in trunk/Source/WebKit

[macCatalyst] The last typed character in password fields shouldn't be echoed
https://bugs.webkit.org/show_bug.cgi?id=201595
<rdar://problem/55166367>

Reviewed by Tim Horton.

Disable password echoing on macCatalyst, to better match behavior on macOS.

Shared/WebPreferencesDefaultValues.h:

8:23 PM Changeset in webkit [249630] by sbarati@apple.com

9 edits
2 adds in trunk

[WHLSL] Add back a version of the property resolver
https://bugs.webkit.org/show_bug.cgi?id=201251

Reviewed by Robin Morisset.

Source/WebCore:

This patch adds back the property resolver to aid in how we emit metal code.
The goal of the new property resolver phase is to allow two things:

For property access expressions, metal codegen should be allowed to evaluate

the base, and if it's an index expression, the index, as many times as needed.
So this patch ensures that if Metal evaluates such things, effects aren't performed
more than once.

For ReadModifyWrite expressions, metal codegen should be able to evaluate the

leftValueExpression as many times as it'd like without performing the effects of
leftValueExpression more than once.

Here are a couple examples of this transformation:
a()[b()] -> (temp1 = a(), temp2 = b(), temp1[temp2])
(*a())[b()] += 42; -> (temp1 = &*a(), temp2 = b(), (*temp1)[temp2] += 42)

The interesting rules break down like:

When the base is an lvalue, we take its address and replace the old base

with a dereference of the new pointer variable.

When the base is an rvalue, we evaluate it and store it in a temporary

variable, and switch the base to be a reference of that variable.

All indices are evaluated before the property access instruction and

replaced with a reference to the temporary variable.

Test: webgpu/whlsl/property-evaluation-order.html

Modules/webgpu/WHLSL/AST/WHLSLExpression.cpp:

(WebCore::WHLSL::AST::Expression::mayBeEffectful const):

Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h:
Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h:
Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:

(WebCore::WHLSL::Metal::FunctionDefinitionWriter::visit):

Modules/webgpu/WHLSL/WHLSLHighZombieFinder.cpp:

(WebCore::WHLSL::findHighZombies):

Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:

(WebCore::WHLSL::PropertyResolver::handleLeftHandSideBase):
(WebCore::WHLSL::PropertyResolver::handlePropertyAccess):
(WebCore::WHLSL::resolveProperties):

Context Navigation

Timeline

Sep 9, 2019:

Sep 8, 2019:

Download in other formats: