Timeline

Sep 11, 2019:

11:55 PM Changeset in webkit [249799] by Joseph Pecoraro

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Inspector Timeline always starts at about 500ms mark on a reload
​https://bugs.webkit.org/show_bug.cgi?id=200637
<rdar://problem/54218967>

Reviewed by Devin Rousso.

The Timeline was getting a startTime value from before the user started
the timeline recording because of artificial adjustments that were made
to CPUTimelineRecords. Ignore adjusted values when updating the Timeline's
start and end times.

• UserInterface/Models/Timeline.js:

(WI.Timeline.prototype._updateTimesIfNeeded):
Use unadjusted times, which should fall in the user started / stopped
timeline range.

• UserInterface/Models/TimelineRecord.js:

(WI.TimelineRecord.prototype.get unadjustedStartTime):
(WI.TimelineRecord.prototype.get unadjustedEndTime):
Default implementation uses startTime/endTime.

• UserInterface/Models/CPUTimelineRecord.js:

(WI.CPUTimelineRecord.prototype.get unadjustedStartTime):

• UserInterface/Models/MemoryTimelineRecord.js:

(WI.MemoryTimelineRecord.prototype.get unadjustedStartTime):
Each of these adjusted their startTime.

11:51 PM Changeset in webkit [249798] by youenn@apple.com

• 9 edits
  2 adds in trunk

Source/ThirdParty/libwebrtc:
Disable DTLS1.0
​https://bugs.webkit.org/show_bug.cgi?id=201679

Reviewed by Alex Christensen.

• Source/webrtc/rtc_base/opensslstreamadapter.cc:

Set minimum version to DTLS1.2 when DTLS1.2 is supported.
This makes sure any client will never downgrade to DTLS1.0.

Source/WebCore:
Disable DTLS1.0
​https://bugs.webkit.org/show_bug.cgi?id=201679

Reviewed by Alex Christensen.

Add an option to force to use DTLS1.0 and nothing else.
Add internals API to enter in that mode to verify that normal configurations cannot communicate with DTLS1.0.

Test: webrtc/datachannel/dtls10.html

• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::setEnableWebRTCEncryption):
(WebCore::LibWebRTCProvider::setUseDTLS10):

• platform/mediastream/libwebrtc/LibWebRTCProvider.h:
• testing/Internals.cpp:

(WebCore::Internals::setUseDTLS10):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:
Disable DTLS10
​https://bugs.webkit.org/show_bug.cgi?id=201679

Reviewed by Alex Christensen.

• webrtc/datachannel/dtls10-expected.txt: Added.
• webrtc/datachannel/dtls10.html: Added.

11:04 PM Changeset in webkit [249797] by Joseph Pecoraro

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: CPU: Overlay Markers for Thread views are off by 500ms
​https://bugs.webkit.org/show_bug.cgi?id=201709
<rdar://problem/55289279>

Reviewed by Devin Rousso.

• UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.prototype.layout):
Use the CPUTimelineRecord's timestamp (same as the record's endTime) as the
point when the CPU sample is taken. This aligns with the rest of the UI that
assumes that the 500ms before the sample point leads up to the sample value.

10:47 PM Changeset in webkit [249796] by Joseph Pecoraro

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Do not show override actions unless Sources tab is enabled
​https://bugs.webkit.org/show_bug.cgi?id=201708

Reviewed by Devin Rousso.

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.supportsLocalResourceOverrides):

10:40 PM Changeset in webkit [249795] by Keith Rollin

• 4 edits in trunk/Source

Log timeoutValue passed on to CFNetwork
​https://bugs.webkit.org/show_bug.cgi?id=201701
<rdar://problem/55279683>

Reviewed by Chris Dumez.

Source/WebCore:

Export ResourceRequest::timeoutValue for use in WebKit.

No new tests -- no new or changed functionality.

• platform/network/ResourceRequestBase.h:

Source/WebKit:

We occasionally see cases where resource-loads into CFNetwork take a
long time. Rather than timing out after the default of 60s, they stay
pending for many minutes. To better understand why this is happening,
log the timeoutValue we pass to CFNetwork when loading resources.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::startNetworkLoad):

10:29 PM Changeset in webkit [249794] by sbarati@apple.com

• 2 edits in trunk/Source/WebCore

[WHLSL] Remove null from the standard library
​https://bugs.webkit.org/show_bug.cgi?id=201672

Reviewed by Robin Morisset.

I meant to remove null from the standard library in r249351, but
I had omitted the code I wrote to do that when I rebased that patch.
This patch removes it and ensures all tests pass when parsing the entire
standard library.

• Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:

10:06 PM Changeset in webkit [249793] by Ryan Haddad

• 1418 edits
  1 copy
  14 moves
  27 adds
  252 deletes in trunk/Source/ThirdParty/ANGLE

Unreviewed, rolling out r249791.

Breaks internal production builds.

Reverted changeset:

"Update ANGLE"
​https://bugs.webkit.org/show_bug.cgi?id=201156
​https://trac.webkit.org/changeset/249791

9:32 PM Changeset in webkit [249792] by Chris Dumez

• 6 edits in trunk

Use same parser for <meta http-equiv="refresh"> and Refresh HTTP header
​https://bugs.webkit.org/show_bug.cgi?id=201694

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

• web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing-expected.txt:

Source/WebCore:

Use same parser for <meta http-equiv="refresh"> and Refresh HTTP header. This aligns
our behavior with Blink and makes us more compliant on web-platform-tests. This also
simplifies our code.

No new tests, rebaselined existing test.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):

• platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPRefresh): Deleted.

• platform/network/HTTPParsers.h:

8:08 PM Changeset in webkit [249791] by achristensen@apple.com

• 1414 edits
  346 adds
  37 deletes in trunk/Source/ThirdParty/ANGLE

Update ANGLE
​https://bugs.webkit.org/show_bug.cgi?id=201156

Patch by James Darpinian <James Darpinian> on 2019-09-11
Reviewed by Alex Christensen.

Update to 2019-9-9, revision 79ad0411911b2fc84834c3705f55707be9e4b498
I merged a bunch of changes to upstream ANGLE, to minimize the changes
necessary when updating ANGLE in WebKit.

• ANGLE.plist: Update commit hashes
• ANGLE.txt: Removed in favor of LICENSE
• ANGLE.xcodeproj/project.pbxproj: Updated with upstream changes

Also, copy src/commit.h to id/commit.h during build

• CMakeLists.txt: Updated with upstream changes

Also, copy src/commit.h to id/commit.h during build

• Compiler.cmake: Updated with upstream changes
• GLESv2.cmake: Updated with upstream changes
• adjust-angle-include-paths-rule: Support "" as well as <> for includes
• adjust-angle-include-paths.sh: Support "" as well as <> for includes
• changes.diff: Pared down to just legal disclaimer and warning flag changes
• update-angle.sh: Update ANGLE.plist

• Many other files modified/added/removed upstream

7:31 PM Changeset in webkit [249790] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: checkerboard has too much contrast in dark mode
​https://bugs.webkit.org/show_bug.cgi?id=201670

Reviewed by Timothy Hatcher.

• UserInterface/Views/CanvasTabContentView.css:

(.content-view.canvas > .preview > img, .content-view.canvas .preview-container > canvas): Deleted.
Don't force a background-color: white; in dark mode.

6:48 PM Changeset in webkit [249789] by Fujii Hironori

• 2 edits in trunk/Tools

[Win][MiniBrowser] Select all text in the URL bar by clicking it
​https://bugs.webkit.org/show_bug.cgi?id=201677

Reviewed by Don Olmstead.

• MiniBrowser/win/MainWindow.cpp:

(EditProc): Post EM_SETSEL in WM_SETFOCUS to select all text.

6:06 PM Changeset in webkit [249788] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: don't show Changes panel when selecting text node
​https://bugs.webkit.org/show_bug.cgi?id=201669

Reviewed by Joseph Pecoraro.

Show Changes panel only for elements regardless of "Show only for selected node" setting.

• UserInterface/Views/ChangesDetailsSidebarPanel.js:

(WI.ChangesDetailsSidebarPanel.prototype.supportsDOMNode):
(WI.ChangesDetailsSidebarPanel.prototype.inspect): Deleted.

4:34 PM Changeset in webkit [249787] by sbarati@apple.com

• 11 edits
  4 adds in trunk

[WHLSL] Ensure structs/arrays with pointers as fields are disallowed
​https://bugs.webkit.org/show_bug.cgi?id=201525

Reviewed by Robin Morisset.

Source/WebCore:

This patch adds a pass which both ensures that references are always initialized with
concrete values and that we support logical mode validation by disallowing nested references.

Specifically, the pass:

1. Disallows structs to have fields which are references. This prevents us from having to

figure out how to default initialize such a struct. We could relax this in the future if we
did an analysis on which structs contain reference fields, and ensure such struct variables
always have initializers. This would also require us to create constructors for structs which
initialize each field.

2. We also do the same for arrays.
3. References can only be one level deep. So no pointers to pointers. No references to

references, etc. This is to support logical mode validation rules.

Test: webgpu/whlsl/ensure-proper-pointer-usage.html

• Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.cpp: Added.

(WebCore::WHLSL::checkReferenceTypes):

• Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.h: Added.
• Modules/webgpu/WHLSL/WHLSLChecker.cpp:

(WebCore::WHLSL::Checker::visit):

• Modules/webgpu/WHLSL/WHLSLPrepare.cpp:

(WebCore::WHLSL::prepareShared):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

This patch fixes a bug in our test harness where we forgot to wait for the gpu
device to load before running test harness tests. This patch fixes this oversight
and asserts that we have always finished loading before running a test.

• webgpu/whlsl/array-spec-tests.html:
• webgpu/whlsl/ensure-proper-pointer-usage-expected.txt: Added.
• webgpu/whlsl/ensure-proper-pointer-usage.html: Added.
• webgpu/whlsl/js/test-harness.js:

(Harness):
(Harness.prototype.async.requestDevice):
(Harness.prototype.async.callTypedFunction):
(Harness.prototype.async.checkCompileFail):

• webgpu/whlsl/pointer-spec-tests.html:
• webgpu/whlsl/test-harness-test.html:

4:28 PM Changeset in webkit [249786] by Devin Rousso

• 38 edits
  4 moves
  12 adds
  8 deletes in trunk

Web Inspector: Canvas: instrument WebGPUDevice instead of GPUCanvasContext
​https://bugs.webkit.org/show_bug.cgi?id=201650

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Most of the actual "work" done with Web GPU actually uses a WebGPUDevice.

A GPUCanvasContext is basically just a display "client" of the device, and isn't even
required (e.g. compute pipeline). We should treat the GPUCanvasContext almost like a
-webkit-canvas client of a WebGPUDevice.

• inspector/protocol/Canvas.json:
  • Add powerPreference key to ContextAttributes type.
  • Rename requestCSSCanvasClientNodes command to requestClientNodes for the above reason.
  • Rename cssCanvasClientNodesChanged event to clientNodesChanged for the above reason.
  • Rename resolveCanvasContext command to resolveContext since a WebGPUDevice isn't really a "canvas".

Source/WebCore:

Most of the actual "work" done with Web GPU actually uses a WebGPUDevice.

A GPUCanvasContext is basically just a display "client" of the device, and isn't even
required (e.g. compute pipeline). We should treat the GPUCanvasContext almost like a
-webkit-canvas client of a WebGPUDevice.

Tests: inspector/canvas/create-context-webgpu.html

inspector/canvas/requestClientNodes-webgpu.html
inspector/canvas/resolveContext-webgpu.html

• Modules/webgpu/WebGPUAdapter.cpp:

(WebCore::WebGPUAdapter::requestDevice const):
Notify web inspector after a device is created.

• Modules/webgpu/WebGPUDevice.idl:
• Modules/webgpu/WebGPUDevice.h:
• Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::instances): Added.
(WebCore::WebGPUDevice::instancesMutex): Added.
(WebCore::WebGPUDevice::~WebGPUDevice): Added.
Notify web inspector when the device is about to be destructed.

• Modules/webgpu/GPUCanvasContext.h:
• Modules/webgpu/GPUCanvasContext.cpp:

(WebCore::GPUCanvasContext::create):
(WebCore::GPUCanvasContext::configureSwapChain):

• inspector/InspectorCanvas.h:
• inspector/InspectorCanvas.cpp:

(WebCore::canvasIfContextMatchesDevice): Added.
(WebCore::InspectorCanvas::create):
(WebCore::InspectorCanvas::InspectorCanvas):
(WebCore::InspectorCanvas::canvasContext const): Added.
(WebCore::InspectorCanvas::canvasElement const): Added.
(WebCore::InspectorCanvas::isDeviceForCanvasContext const): Added.
(WebCore::InspectorCanvas::deviceContext const): Added.
(WebCore::InspectorCanvas::scriptExecutionContext const): Added.
(WebCore::InspectorCanvas::resolveContext const): Added.
(WebCore::InspectorCanvas::clientNodes const): Added.
(WebCore::InspectorCanvas::canvasChanged):
(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::buildObjectForCanvas):
(WebCore::InspectorCanvas::releaseObjectForRecording):
(WebCore::InspectorCanvas::getCanvasContentAsDataURL):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::canvasElement): Deleted.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCreateWebGPUDeviceImpl): Added.
(WebCore::InspectorInstrumentation::willDestroyWebGPUDeviceImpl): Added.
(WebCore::InspectorInstrumentation::willConfigureSwapChainImpl): Added.

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didCreateWebGPUDevice): Added.
(WebCore::InspectorInstrumentation::willDestroyWebGPUDevice): Added.
(WebCore::InspectorInstrumentation::willConfigureSwapChain): Added.

• inspector/agents/InspectorCanvasAgent.h:
• inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::requestClientNodes): Added.
(WebCore::InspectorCanvasAgent::resolveContext): Added.
(WebCore::InspectorCanvasAgent::startRecording):
(WebCore::InspectorCanvasAgent::stopRecording):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didChangeCSSCanvasClientNodes):
(WebCore::InspectorCanvasAgent::didChangeCanvasMemory):
(WebCore::InspectorCanvasAgent::canvasDestroyed):
(WebCore::InspectorCanvasAgent::recordCanvasAction):
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
(WebCore::InspectorCanvasAgent::didCreateWebGPUDevice): Added.
(WebCore::InspectorCanvasAgent::willDestroyWebGPUDevice): Added.
(WebCore::InspectorCanvasAgent::willConfigureSwapChain): Added.
(WebCore::InspectorCanvasAgent::clearCanvasData):
(WebCore::InspectorCanvasAgent::bindCanvas):
(WebCore::InspectorCanvasAgent::unbindCanvas):
(WebCore::InspectorCanvasAgent::findInspectorCanvas):
(WebCore::InspectorCanvasAgent::requestCSSCanvasClientNodes): Deleted.
(WebCore::contextAsScriptValue): Deleted.
(WebCore::InspectorCanvasAgent::resolveCanvasContext): Deleted.

• inspector/InspectorShaderProgram.cpp:

(WebCore::InspectorShaderProgram::context const):

Source/WebInspectorUI:

Most of the actual "work" done with Web GPU actually uses a WebGPUDevice.

A GPUCanvasContext is basically just a display "client" of the device, and isn't even
required (e.g. compute pipeline). We should treat the GPUCanvasContext almost like a
-webkit-canvas client of a WebGPUDevice.

• UserInterface/Protocol/CanvasObserver.js:

(WI.CanvasObserver.prototype.clientNodesChanged): Added.
(WI.CanvasObserver.prototype.cssCanvasClientNodesChanged):

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.clientNodesChanged): Added.
(WI.CanvasManager.prototype.cssCanvasClientNodesChanged): Deleted.

• UserInterface/Models/Canvas.js:

(WI.Canvas.resetUniqueDisplayNameNumbers):
(WI.Canvas.prototype.get displayName):
(WI.Canvas.prototype.requestNode):
(WI.Canvas.prototype.requestClientNodes): Added.
(WI.Canvas.prototype.requestSize):
(WI.Canvas.prototype.clientNodesChanged): Added.
(WI.Canvas.prototype.requestCSSCanvasClientNodes): Deleted.
(WI.Canvas.prototype.cssCanvasClientNodesChanged): Deleted.

• UserInterface/Protocol/RemoteObject.js:

(WI.RemoteObject.resolveCanvasContext):

• UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype.attached):
(WI.CanvasContentView.prototype._refreshPixelSize):

• UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WI.CanvasDetailsSidebarPanel.prototype.set canvas):
(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):
(WI.CanvasDetailsSidebarPanel.prototype.layout):
(WI.CanvasDetailsSidebarPanel.prototype._refreshSourceSection):
(WI.CanvasDetailsSidebarPanel.prototype._refreshClientsSection): Added.
(WI.CanvasDetailsSidebarPanel.prototype._refreshCSSCanvasSection): Deleted.

• UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView.prototype._contentViewMouseEnter):

• UserInterface/Views/CanvasTreeElement.js:

(WI.CanvasTreeElement.prototype._handleMouseOver):

• Localizations/en.lproj/localizedStrings.js:

LayoutTests:

• inspector/canvas/create-context-webgpu.html:
• inspector/canvas/create-context-webgpu-expected.txt:
• inspector/canvas/resources/create-context-utilities.js:

(createDetachedCanvas):
(createCSSCanvas):
(destroyCanvases):

• inspector/canvas/requestClientNodes.html: Added.
• inspector/canvas/requestClientNodes-expected.txt: Added.
• inspector/canvas/requestClientNodes-css.html: Renamed from LayoutTests/inspector/canvas/css-canvas-clients.html.
• inspector/canvas/requestClientNodes-css-expected.txt: Renamed from LayoutTests/inspector/canvas/css-canvas-clients-expected.txt.
• inspector/canvas/requestClientNodes-webgpu.html: Added.
• inspector/canvas/requestClientNodes-webgpu-expected.txt: Added.

• inspector/canvas/resolveContext-2d.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-2d.html.
• inspector/canvas/resolveContext-2d-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-2d-expected.txt.
• inspector/canvas/resolveContext-bitmaprenderer.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-bitmaprenderer.html.
• inspector/canvas/resolveContext-bitmaprenderer-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-bitmaprenderer-expected.txt.
• inspector/canvas/resolveContext-webgl.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl.html.
• inspector/canvas/resolveContext-webgl-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl-expected.txt.
• inspector/canvas/resolveContext-webgl2.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl2.html.
• inspector/canvas/resolveContext-webgl2-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl2-expected.txt.
• inspector/canvas/resolveContext-webgpu.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgpu.html.
• inspector/canvas/resolveContext-webgpu-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgpu-expected.txt.

• inspector/canvas/context-attributes-expected.txt:

• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wpe/TestExpectations:

4:10 PM Changeset in webkit [249785] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Protect UserMediaRequest when stopping it
​https://bugs.webkit.org/show_bug.cgi?id=201687
<rdar://problem/55241215>

Reviewed by Eric Carlson.

By removing the request from the map, we may destroy the request.
To make sure it stays alive, take the request from the map.

• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::cancelUserMediaRequest):

4:05 PM Changeset in webkit [249784] by Alan Coon

• 7 edits in branches/safari-608.2.11.1-branch/Source

Versioning.

3:57 PM Changeset in webkit [249783] by Alan Coon

• 1 copy in tags/Safari-608.2.11.1.5

Tag Safari-608.2.11.1.5.

3:42 PM Changeset in webkit [249782] by Chris Dumez

• 3 edits
  2 adds in trunk/LayoutTests

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/cache-storage/cache-persistency.https.html
​https://bugs.webkit.org/show_bug.cgi?id=201691

Reviewed by Alex Christensen.

Split cache-persistency.https.html into 2 tests (one for private session and one for
regular session) to avoid relying on legacy testRunner.setPrivateBrowsingEnabled_DEPRECATED().

• http/tests/cache-storage/cache-persistency-private-expected.txt: Added.
• http/tests/cache-storage/cache-persistency-private.html: Added.
• http/tests/cache-storage/cache-persistency.https-expected.txt:
• http/tests/cache-storage/cache-persistency.https.html:

3:38 PM Changeset in webkit [249781] by Chris Dumez

• 5 edits in trunk

Posting a message to a redundant service worker should fail silently instead of throwing
​https://bugs.webkit.org/show_bug.cgi?id=201696

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that one more check is passing.

• web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt:

Source/WebCore:

Posting a message to a redundant service worker should fail silently instead of throwing:

• ​https://w3c.github.io/ServiceWorker/#dom-serviceworker-postmessage-message-options
• ​https://w3c.github.io/ServiceWorker/#run-service-worker (step 2)

No new tests, rebaselined existing test.

• workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::runServiceWorkerIfNecessary):

3:36 PM Changeset in webkit [249780] by ysuzuki@apple.com

• 24 edits
  9 adds in trunk

[JSC] Add StringCodePointAt intrinsic
​https://bugs.webkit.org/show_bug.cgi?id=201673

Reviewed by Michael Saboff.

JSTests:

• stress/string-char-at-constant-index-out-of-range.js: Added.

(shouldBe):
(test):

• stress/string-char-code-at-constant-index-out-of-range.js: Added.

(shouldBe):
(test):

• stress/string-code-point-at--out-of-range.js: Added.

(shouldBe):
(test):

• stress/string-code-point-at-basic.js: Added.

(test):

• stress/string-code-point-at-constant-index-out-of-range.js: Added.

(shouldBe):
(test):

• stress/string-code-point-at-constant-int32-max-index-out-of-range.js: Added.

(shouldBe):
(test):

• stress/string-code-point-at-constant-surrogate-pair.js: Added.

(shouldBe):
(test):
(breaking):

• stress/string-code-point-at-surrogate-pair.js: Added.

(shouldBe):

• stress/string-code-point-at.js: Added.

(shouldBe):

Source/JavaScriptCore:

JetStream2/UniPoker executes String#codePointAt frequently. We should handle it in ThunkGenerator, DFG, and FTL like we are doing so for String#charCodeAt.
This patch adds these supports for String#codePointAt to get ~10% score improvement in JetStream2/UniPoker.

In ThunkGenerator, we add a thunk for String#codePointAt, which accelerates LLInt and Baseline. In DFG, we handle this as StringCodePointAt node, and emit
inlined code in DFG and FTL. The characteristics of StringCodePointAt node is basically the same to StringCharAt. It has String array-mode, so it emits
preceding CheckArray. This ensures that (1) StringCodePointAt node itself does not do GC since the string is always resolved, and (2) we can skip the rope
check. This thing is just the same to the existing StringCharCodeAt mechanism.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileStringCodePointAt):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCodePointAt):

• jit/JITInlines.h:

(JSC::JIT::emitLoadCharacterString):

• jit/ThunkGenerators.cpp:

(JSC::stringGetByValGenerator):
(JSC::stringCharLoad):
(JSC::stringPrototypeCodePointAtThunkGenerator):

• jit/ThunkGenerators.h:
• runtime/Intrinsic.cpp:

(JSC::intrinsicName):

• runtime/Intrinsic.h:
• runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

• runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

3:27 PM Changeset in webkit [249779] by Chris Dumez

• 19 edits in trunk

Align our XPath API with the specification and other browsers
​https://bugs.webkit.org/show_bug.cgi?id=201660

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/dom/interfaces-expected.txt:

Source/WebCore:

Align our XPath API with the specification and other browsers:

• Document/XPathEvaluator.createExpression()'s first parameter should be mandatory
• Document/XPathEvaluator.evaluate()'s first 2 parameters should be mandatory
• XPathExpression.evaluate()'s first parameter should be mandatory

I have confirmed in the latest Chrome and Firefox that they match the specification.

No new tests, rebaselined existing test.

• dom/Document.cpp:

(WebCore::Document::evaluate):

• dom/Document.h:
• dom/Document.idl:
• inspector/InspectorNodeFinder.cpp:

(WebCore::InspectorNodeFinder::searchUsingXPath):

• xml/XPathEvaluator.cpp:

(WebCore::XPathEvaluator::evaluate):

• xml/XPathEvaluator.h:
• xml/XPathEvaluator.idl:
• xml/XPathExpression.cpp:

(WebCore::XPathExpression::evaluate):

• xml/XPathExpression.h:
• xml/XPathExpression.idl:
• xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode):

• xml/XPathUtil.h:

2:43 PM Changeset in webkit [249778] by Ryan Haddad

• 52 edits
  1 copy
  1 move
  4 adds in trunk

Unreviewed, rolling out r249768.

Caused 4 API tests to assert, perf test failures, and layout
test crashes under ASan

Reverted changeset:

"Remove unnecessary abstractions around WebsiteDataStore"
​https://bugs.webkit.org/show_bug.cgi?id=201655
​https://trac.webkit.org/changeset/249768

2:22 PM Changeset in webkit [249777] by msaboff@apple.com

• 3 edits
  1 add in trunk

JSC crashes due to stack overflow while building RegExp
​https://bugs.webkit.org/show_bug.cgi?id=201649

Reviewed by Yusuke Suzuki.

JSTests:

New regression test.

• stress/regexp-bol-optimize-out-of-stack.js: Added.

(test):
(catch):

Source/JavaScriptCore:

Check for running out of stack when we are optimizing RegExp containing BOL terms or
other deep copying of disjunctions.

• yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
(JSC::Yarr::YarrPatternConstructor::copyTerm):
(JSC::Yarr::YarrPatternConstructor::error):
(JSC::Yarr::YarrPattern::compile):

2:10 PM Changeset in webkit [249776] by Truitt Savell

• 38 edits
  1 copy
  4 moves
  7 adds
  12 deletes in trunk

Unreviewed, rolling out r249753.

caused inspector/canvas/shaderProgram-add-remove-webgl.html to
crash on all Mac platforms.

Reverted changeset:

"Web Inspector: Canvas: instrument WebGPUDevice instead of
GPUCanvasContext"
​https://bugs.webkit.org/show_bug.cgi?id=201650
​https://trac.webkit.org/changeset/249753

1:12 PM Changeset in webkit [249775] by Alan Coon

• 10 edits in branches/safari-608.2.11.1-branch/Source

Apply patch. rdar://problem/55240886

1:12 PM Changeset in webkit [249774] by Alan Coon

• 8 edits in branches/safari-608.2.11.1-branch/Source

Revert "Cherry-pick r249359. rdar://problem/55240886"

1:11 PM Changeset in webkit [249773] by Alan Coon

• 10 edits in branches/safari-608.2.11.1-branch/Source

Revert "Cherry-pick r249748. rdar://problem/55240886"

1:11 PM Changeset in webkit [249772] by Alan Coon

• 1 edit in branches/safari-608.2.11.1-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h

Revert "Cherry-pick r249748. rdar://problem/55240886"

11:03 AM Changeset in webkit [249771] by Kocsen Chung

• 1 edit in branches/safari-608.2.11.1-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h

Cherry-pick r249748. rdar://problem/55240886

Build fix.

10:29 AM Changeset in webkit [249770] by Antti Koivisto

• 6 edits in trunk/Source

REGRESSION (245006): can't scroll in "read more" view in Eventbrite app
​https://bugs.webkit.org/show_bug.cgi?id=201683
<rdar://problem/54582602>

Reviewed by Simon Fraser.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isEventbrite):

Source/WebKit:

Content <body> has 'overflow:hidden'.

• UIProcess/Cocoa/VersionChecks.h:
• UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::hasScrollableMainFrame const):

Fix by adding an app specific LinkedOnOrAfter quirk that always allows main frame scrolling.

10:11 AM Changeset in webkit [249769] by Kocsen Chung

• 1 copy in tags/Safari-609.1.4

Tag Safari-609.1.4.

9:37 AM Changeset in webkit [249768] by achristensen@apple.com

• 52 edits
  1 move
  4 deletes in trunk

Remove unnecessary abstractions around WebsiteDataStore
​https://bugs.webkit.org/show_bug.cgi?id=201655

Reviewed by Chris Dumez.

Source/WebKit:

This patch does four things to simplify WebsiteDataStore code:

1. It removes API::WebsiteDataStore, which was just an unnecessary wrapper around WebKit::WebsiteDataStore.
2. It deprecates the unused aliases of WebsiteDataStore, WKApplicationCacheManagerRef and WKKeyValueStorageManagerRef
3. It removes the unused APIProcessPoolConfiguration properties that have been moved to WebsiteDataStore.
4. It makes WKWebsiteDataStore._delegate weak instead of strong, as already annotated in WKWebsiteDataStorePrivate.h

There should be no change in behavior from this patch.

• PlatformFTW.cmake:
• PlatformWin.cmake:
• Sources.txt:
• SourcesCocoa.txt:
• SourcesGTK.txt:
• SourcesWPE.txt:
• UIProcess/API/APIHTTPCookieStore.cpp:
• UIProcess/API/APIHTTPCookieStore.h:
• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::websiteDataStore):
(API::PageConfiguration::setWebsiteDataStore):

• UIProcess/API/APIPageConfiguration.h:
• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::ProcessPoolConfiguration):
(API::ProcessPoolConfiguration::copy):
(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration): Deleted.

• UIProcess/API/APIProcessPoolConfiguration.h:
• UIProcess/API/APIWebsiteDataStore.cpp: Removed.
• UIProcess/API/APIWebsiteDataStore.h: Removed.
• UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::data):

• UIProcess/API/APIWebsitePolicies.h:
• UIProcess/API/C/WKAPICast.h:
• UIProcess/API/C/WKApplicationCacheManager.cpp:

(WKApplicationCacheManagerGetTypeID):
(WKApplicationCacheManagerGetApplicationCacheOrigins):
(WKApplicationCacheManagerDeleteEntriesForOrigin):
(WKApplicationCacheManagerDeleteAllEntries):

• UIProcess/API/C/WKApplicationCacheManager.h:
• UIProcess/API/C/WKFramePolicyListener.cpp:

(useWithPolicies):

• UIProcess/API/C/WKKeyValueStorageManager.cpp:

(WKKeyValueStorageManagerGetTypeID):
(WKKeyValueStorageManagerGetOriginKey):
(WKKeyValueStorageManagerGetCreationTimeKey):
(WKKeyValueStorageManagerGetModificationTimeKey):
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):
(WKKeyValueStorageManagerDeleteEntriesForOrigin):
(WKKeyValueStorageManagerDeleteAllEntries):

• UIProcess/API/C/WKKeyValueStorageManager.h:
• UIProcess/API/C/WKResourceCacheManager.cpp:

(WKResourceCacheManagerGetTypeID):
(WKResourceCacheManagerGetCacheOrigins):
(WKResourceCacheManagerClearCacheForOrigin):
(WKResourceCacheManagerClearCacheForAllOrigins):
(toWebsiteDataTypes): Deleted.

• UIProcess/API/C/WKResourceCacheManager.h:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreGetTypeID):
(WKWebsiteDataStoreGetDefaultDataStore):
(WKWebsiteDataStoreCreateNonPersistentDataStore):
(WKWebsiteDataStoreCreateWithConfiguration):
(WKWebsiteDataStoreGetHTTPCookieStore):
(WKWebsiteDataStoreSetResourceLoadStatisticsDebugModeWithCompletionHandler):
(WKWebsiteDataStoreSetResourceLoadStatisticsPrevalentResourceForDebugMode):
(WKWebsiteDataStoreSetStatisticsLastSeen):
(WKWebsiteDataStoreSetStatisticsPrevalentResource):
(WKWebsiteDataStoreSetStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreDumpResourceLoadStatistics):
(WKWebsiteDataStoreIsStatisticsPrevalentResource):
(WKWebsiteDataStoreIsStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubresourceUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubFrameUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsRedirectingTo):
(WKWebsiteDataStoreSetStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreIsStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreSetStatisticsGrandfathered):
(WKWebsiteDataStoreIsStatisticsGrandfathered):
(WKWebsiteDataStoreSetStatisticsSubframeUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsCrossSiteLoadWithLinkDecoration):
(WKWebsiteDataStoreSetStatisticsTimeToLiveUserInteraction):
(WKWebsiteDataStoreStatisticsProcessStatisticsAndDataRecords):
(WKWebsiteDataStoreStatisticsUpdateCookieBlocking):
(WKWebsiteDataStoreStatisticsSubmitTelemetry):
(WKWebsiteDataStoreSetStatisticsNotifyPagesWhenDataRecordsWereScanned):
(WKWebsiteDataStoreSetStatisticsIsRunningTest):
(WKWebsiteDataStoreSetStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
(WKWebsiteDataStoreSetStatisticsNotifyPagesWhenTelemetryWasCaptured):
(WKWebsiteDataStoreSetStatisticsMinimumTimeBetweenDataRecordsRemoval):
(WKWebsiteDataStoreSetStatisticsGrandfatheringTime):
(WKWebsiteDataStoreSetStatisticsMaxStatisticsEntries):
(WKWebsiteDataStoreSetStatisticsPruneEntriesDownTo):
(WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStore):
(WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
(WKWebsiteDataStoreStatisticsClearThroughWebsiteDataRemoval):
(WKWebsiteDataStoreStatisticsDeleteCookiesForTesting):
(WKWebsiteDataStoreStatisticsHasLocalStorage):
(WKWebsiteDataStoreSetStatisticsCacheMaxAgeCap):
(WKWebsiteDataStoreStatisticsHasIsolatedSession):
(WKWebsiteDataStoreStatisticsResetToConsistentState):
(WKWebsiteDataStoreRemoveAllFetchCaches):
(WKWebsiteDataStoreRemoveFetchCacheForOrigin):
(WKWebsiteDataStoreRemoveAllIndexedDatabases):
(WKWebsiteDataStoreRemoveLocalStorage):
(WKWebsiteDataStoreRemoveAllServiceWorkerRegistrations):
(WKWebsiteDataStoreGetFetchCacheOrigins):
(WKWebsiteDataStoreGetFetchCacheSizeForOrigin):
(WKWebsiteDataStoreCopyServiceWorkerRegistrationDirectory):
(WKWebsiteDataStoreSetServiceWorkerRegistrationDirectory):
(WKWebsiteDataStoreSetPerOriginStorageQuota):
(WKWebsiteDataStoreClearAllDeviceOrientationPermissions):
(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):
(WKWebsiteDataStoreClearAdClickAttributionsThroughWebsiteDataRemoval):

• UIProcess/API/C/WKWebsitePolicies.cpp:
• UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm: Removed.
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore defaultDataStore]):
(+[WKWebsiteDataStore nonPersistentDataStore]):
(-[WKWebsiteDataStore dealloc]):
(-[WKWebsiteDataStore httpCookieStore]):
(-[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):
(-[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:]):
(+[WKWebsiteDataStore _defaultDataStoreExists]):
(+[WKWebsiteDataStore _deleteDefaultDataStoreForTesting]):
(-[WKWebsiteDataStore _initWithConfiguration:]):
(-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):
(-[WKWebsiteDataStore _resourceLoadStatisticsEnabled]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsEnabled:]):
(-[WKWebsiteDataStore _resourceLoadStatisticsDebugMode]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsDebugMode:]):
(-[WKWebsiteDataStore _perOriginStorageQuota]):
(-[WKWebsiteDataStore _setPerOriginStorageQuota:]):
(-[WKWebsiteDataStore _cacheStorageDirectory]):
(-[WKWebsiteDataStore _setCacheStorageDirectory:]):
(-[WKWebsiteDataStore _serviceWorkerRegistrationDirectory]):
(-[WKWebsiteDataStore _setServiceWorkerRegistrationDirectory:]):
(-[WKWebsiteDataStore _setBoundInterfaceIdentifier:]):
(-[WKWebsiteDataStore _boundInterfaceIdentifier]):
(-[WKWebsiteDataStore _setAllowsCellularAccess:]):
(-[WKWebsiteDataStore _allowsCellularAccess]):
(-[WKWebsiteDataStore _setProxyConfiguration:]):
(-[WKWebsiteDataStore _sourceApplicationBundleIdentifier]):
(-[WKWebsiteDataStore _setSourceApplicationBundleIdentifier:]):
(-[WKWebsiteDataStore _sourceApplicationSecondaryIdentifier]):
(-[WKWebsiteDataStore _setSourceApplicationSecondaryIdentifier:]):
(-[WKWebsiteDataStore _setAllowsTLSFallback:]):
(-[WKWebsiteDataStore _allowsTLSFallback]):
(-[WKWebsiteDataStore _proxyConfiguration]):
(-[WKWebsiteDataStore _indexedDBDatabaseDirectory]):
(-[WKWebsiteDataStore _resourceLoadStatisticsSetShouldSubmitTelemetry:]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsTestingCallback:]):
(-[WKWebsiteDataStore _getAllStorageAccessEntriesFor:completionHandler:]):
(-[WKWebsiteDataStore _scheduleCookieBlockingUpdate:]):
(-[WKWebsiteDataStore _setPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _getIsPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _clearPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _processStatisticsAndDataRecords:]):
(-[WKWebsiteDataStore _hasRegisteredServiceWorker]):
(-[WKWebsiteDataStore _delegate]):
(-[WKWebsiteDataStore set_delegate:]):

• UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h:
• UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp: Removed.
• UIProcess/API/win/APIWebsiteDataStoreWin.cpp:

(API::WebsiteDataStore::defaultApplicationCacheDirectory): Deleted.
(API::WebsiteDataStore::defaultCacheStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultNetworkCacheDirectory): Deleted.
(API::WebsiteDataStore::defaultIndexedDBDatabaseDirectory): Deleted.
(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory): Deleted.
(API::WebsiteDataStore::defaultLocalStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultMediaKeysStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultWebSQLDatabaseDirectory): Deleted.
(API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory): Deleted.
(API::WebsiteDataStore::cacheDirectoryFileSystemRepresentation): Deleted.
(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation): Deleted.

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::websiteDataStoreFromSessionID):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebFramePolicyListenerProxy.cpp:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):

• UIProcess/WebProcessPool.cpp:

(WebKit::m_webProcessCache):
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::establishWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::resolvePathsForSandboxExtensions):
(WebKit::WebProcessPool::tryTakePrewarmedProcess):
(WebKit::WebProcessPool::sendWebProcessDataStoreParameters):
(WebKit::WebProcessPool::processDidFinishLaunching):
(WebKit::WebProcessPool::processForRegistrableDomain):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::mayHaveRegisteredServiceWorkers):

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::defaultApplicationCacheDirectory):
(WebKit::WebsiteDataStore::defaultCacheStorageDirectory):
(WebKit::WebsiteDataStore::defaultNetworkCacheDirectory):
(WebKit::WebsiteDataStore::defaultMediaCacheDirectory):
(WebKit::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):
(WebKit::WebsiteDataStore::defaultLocalStorageDirectory):
(WebKit::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(WebKit::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):
(WebKit::WebsiteDataStore::defaultJavaScriptConfigurationDirectory):
(WebKit::WebsiteDataStore::tempDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::globalDefaultDataStore):
(WebKit::WebsiteDataStore::defaultDataStore):
(WebKit::WebsiteDataStore::deleteDefaultDataStoreForTesting):
(WebKit::WebsiteDataStore::defaultDataStoreExists):
(WebKit::WebsiteDataStore::defaultDataStoreConfiguration):
(WebKit::WebsiteDataStore::isAssociatedProcessPool const):
(WebKit::WebsiteDataStore::processPools const):
(WebKit::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory):

• UIProcess/WebsiteData/WebsiteDataStore.h:
• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:

(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):

• UIProcess/WebsiteData/win/WebsiteDataStoreWin.cpp:

(WebKit::WebsiteDataStore::defaultApplicationCacheDirectory):
(WebKit::WebsiteDataStore::defaultCacheStorageDirectory):
(WebKit::WebsiteDataStore::defaultNetworkCacheDirectory):
(WebKit::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):
(WebKit::WebsiteDataStore::defaultLocalStorageDirectory):
(WebKit::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(WebKit::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):
(WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

• UIProcess/glib/WebsiteDataStoreGLib.cpp: Copied from Source/WebKit/UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp.

(API::WebsiteDataStore::defaultApplicationCacheDirectory): Deleted.
(API::WebsiteDataStore::defaultNetworkCacheDirectory): Deleted.
(API::WebsiteDataStore::defaultCacheStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultIndexedDBDatabaseDirectory): Deleted.
(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory): Deleted.
(API::WebsiteDataStore::defaultLocalStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultMediaKeysStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultWebSQLDatabaseDirectory): Deleted.
(API::WebsiteDataStore::defaultHSTSDirectory): Deleted.
(API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory): Deleted.
(API::WebsiteDataStore::cacheDirectoryFileSystemRepresentation): Deleted.
(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation): Deleted.

• WebKit.xcodeproj/project.pbxproj:

LayoutTests:

• platform/mac-wk2/TestExpectations:

9:36 AM Changeset in webkit [249767] by Kocsen Chung

• 10 edits in branches/safari-608.2.11.1-branch/Source

Cherry-pick r249748. rdar://problem/55240886

Nullptr crash in Page::sessionID() via WebKit::WebFrameLoaderClient::detachedFromParent2()
​https://bugs.webkit.org/show_bug.cgi?id=201625

Reviewed by Ryosuke Niwa.

This is based on a patch from Ryosuke Niwa.

Source/WebCore:

Drop setHasFrameSpecificStorageAccess() in WebCore and call it from the WebKit layer instead.

• dom/DocumentStorageAccess.cpp: (WebCore::DocumentStorageAccess::requestStorageAccess): (WebCore::DocumentStorageAccess::setHasFrameSpecificStorageAccess): Deleted.
• dom/DocumentStorageAccess.h:
• loader/EmptyFrameLoaderClient.h:
• loader/FrameLoaderClient.h:

Source/WebKit:

The crash was caused by WebFrameLoaderClient::sessionID() calling WebPage::sessionID() without
checking the nullity of WebPage::m_page which can be null. Added a null check.

Because passing a wrong session to RemoveStorageAccessForFrame could result in a leak, this patch
also replaces m_hasFrameSpecificStorageAccess boolean with an optioanl struct which stores
session ID, frame ID, and page ID even after WebCore::Frame or WebCore::Page had been cleared
or before WebFrameLoaderClient::m_frame is set.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::sessionID const): (WebKit::WebFrameLoaderClient::setHasFrameSpecificStorageAccess): (WebKit::WebFrameLoaderClient::detachedFromParent2): (WebKit::WebFrameLoaderClient::dispatchWillChangeDocument):
• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebPage/WebFrame.h: (WebKit::WebFrame::frameLoaderClient const):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::requestStorageAccess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:36 AM Changeset in webkit [249766] by Kocsen Chung

• 8 edits in branches/safari-608.2.11.1-branch/Source

Cherry-pick r249359. rdar://problem/55240886

DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID
​https://bugs.webkit.org/show_bug.cgi?id=201364

Reviewed by John Wilander.

Source/WebCore:

DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID. pageID is
redundant since it is being ignored by the callee. For the frame, simply pass the frame object in.

• dom/DocumentStorageAccess.cpp: (WebCore::DocumentStorageAccess::hasStorageAccess): (WebCore::DocumentStorageAccess::requestStorageAccess):
• page/ChromeClient.h: (WebCore::ChromeClient::hasStorageAccess): (WebCore::ChromeClient::requestStorageAccess):

Source/WebKit:

• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::hasStorageAccess): (WebKit::WebChromeClient::requestStorageAccess):
• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::hasStorageAccess): (WebKit::WebPage::requestStorageAccess):
• WebProcess/WebPage/WebPage.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:01 AM Changeset in webkit [249765] by Ryan Haddad

• 10 edits
  4 deletes in trunk

Unreviewed, rolling out r249758.

Breaks the watchOS build.

Reverted changeset:

"[WHLSL] Ensure structs/arrays with pointers as fields are
disallowed"
​https://bugs.webkit.org/show_bug.cgi?id=201525
​https://trac.webkit.org/changeset/249758

8:41 AM Changeset in webkit [249764] by Kocsen Chung

• 7 edits in branches/safari-608.2.11.1-branch/Source

Versioning.

8:36 AM Changeset in webkit [249763] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, re-skip service worker test that was unskipped in r249716

This test is still a flaky timeout.

• TestExpectations:

7:52 AM Changeset in webkit [249762] by ajuma@chromium.org

• 4 edits in trunk/Source/WebCore

Prevent reentrancy FrameLoader::dispatchUnloadEvents()
​https://bugs.webkit.org/show_bug.cgi?id=200738

Reviewed by Brady Eidson.

Reentrancy causes m_pageDismissalEventBeingDispatched to be incorrectly
updated, so don't allow reentrancy.

Since this prevents m_pageDismissalEventBeingDispatched from being reset
inside a reentrant call, it can have the unintended effect of causing
FrameLoader::stopAllLoaders to early-out when called from
FrameLoader::detachFromParent while a frame's unload event handler
calls document.open() on a parent frame and causes itself to become
detached. Allowing a load to continue in a detached frame will lead to
a crash. To prevent this, add a new argument to FrameLoader::stopAllLoaders
that FrameLoader::detachFromParent can use to prevent an early-out.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::dispatchUnloadEvents):
(WebCore::FrameLoader::dispatchBeforeUnloadEvent):
Ensure that m_pageDismissalEventBeingDispatched is reset to its previous value, even if this is not None.

• loader/FrameLoader.h:
• loader/FrameLoaderTypes.h:

Add a StopLoadingPolicy enum.

4:49 AM Changeset in webkit [249761] by cturner@igalia.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Do not adopt floating references.
​https://bugs.webkit.org/show_bug.cgi?id=201685

Reviewed by Carlos Garcia Campos.

Covered by existing tests.

• platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer): gst_element_factory_make returns
floating references, you do not adopt such references, rather you
sink them.

4:34 AM Changeset in webkit [249760] by commit-queue@webkit.org

• 87 edits
  8 copies
  3 moves
  169 adds
  5 deletes in trunk/LayoutTests

Bug 201603 - Synchronize MathML WPT tests against upstream
​https://bugs.webkit.org/show_bug.cgi?id=201603

Patch by Frederic Wang <​fwang@igalia.com> on 2019-09-11
Reviewed by Rob Buis.

LayoutTests/imported/w3c:

• resources/resource-files.json:
• web-platform-tests/mathml/presentation-markup/direction/direction-006-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-006.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-007-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-007.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-008-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-008.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-009-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-009.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-010-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-010.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-overall-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-overall.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-token-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-token.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/w3c-import.log: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-1.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-bar-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-002.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically-2-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically-2.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically-3-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically-3.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001-expected.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.html: Removed.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-004-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-004.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-mrow-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001-expected.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-001-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-001.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-002-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-002.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-003-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-003.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-004-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-004.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-005-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-005.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-006-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-006.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-visibility-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline.html: Added.
• web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-stretchy-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-stretchy.html: Added.
• web-platform-tests/mathml/presentation-markup/mrow/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/w3c-import.log.
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-form-dynamic-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-dynamic.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-minus-plus-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-minus-plus.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-default-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-default.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-dynamic-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-dynamic.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-paint-lspace-rspace-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-paint-lspace-rspace.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-3.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-4.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-5.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html:
• web-platform-tests/mathml/presentation-markup/spaces/mspace-children-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/mspace-children.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-1.html:
• web-platform-tests/mathml/presentation-markup/spaces/space-2.html:
• web-platform-tests/mathml/presentation-markup/spaces/space-like-001-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-001.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-002-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-002.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-003-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-003.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-004-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-004.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html:
• web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/attribute-mapping-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/color-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/color-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/color-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/color-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/color-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/color-003.html: Added.
• web-platform-tests/mathml/relations/css-styling/color-004-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/color-004.html: Added.
• web-platform-tests/mathml/relations/css-styling/color-1.html: Removed.
• web-platform-tests/mathml/relations/css-styling/display-1.html:
• web-platform-tests/mathml/relations/css-styling/display-contents-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/display-contents.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-011-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-011.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-012-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-012.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-013-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-013.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-014-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-014.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-015-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-015.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-1-expected.txt:
• web-platform-tests/mathml/relations/css-styling/displaystyle-1.html:
• web-platform-tests/mathml/relations/css-styling/displaystyle-2-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-2.html: Added.
• web-platform-tests/mathml/relations/css-styling/dynamic-dir-1-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/dynamic-dir-1.html: Added.
• web-platform-tests/mathml/relations/css-styling/lengths-1.html:
• web-platform-tests/mathml/relations/css-styling/lengths-2-expected.html: Removed.
• web-platform-tests/mathml/relations/css-styling/lengths-2-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/lengths-2.html:
• web-platform-tests/mathml/relations/css-styling/lengths-3-expected.txt: Removed.
• web-platform-tests/mathml/relations/css-styling/lengths-3.html: Removed.
• web-platform-tests/mathml/relations/css-styling/mathbackground-001-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-001-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-002-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-002-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-003-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-003-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-003.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-004-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-004-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-004.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-001-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-001-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-002-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-002-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-003-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-003-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-003.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-004-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-004-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-004.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-css-keywords-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-css-keywords.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-legacy-values-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-legacy-values.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathvariant-auto-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathvariant-auto.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-case-sensitivity-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathvariant-case-sensitivity.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-initial-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-initial.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-italic-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-looped-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-looped.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-monospace-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-monospace.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-bold-italic-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-bold-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-italic-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-script-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-script.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-stretched-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-stretched.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-tailed-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-tailed.html:
• web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-002-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-border-margin-001-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-border-margin-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/w3c-import.log: Added.
• web-platform-tests/mathml/relations/css-styling/visibility-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/visibility-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/visibility-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/visibility-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/visibility-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/visibility-003.html: Added.
• web-platform-tests/mathml/relations/css-styling/visibility-004-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/visibility-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-1.html.
• web-platform-tests/mathml/relations/css-styling/w3c-import.log:
• web-platform-tests/mathml/relations/css-styling/width-height-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/width-height-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/writing-mode/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/w3c-import.log.
• web-platform-tests/mathml/relations/css-styling/writing-mode/writing-mode-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/writing-mode/writing-mode-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/writing-mode/writing-mode-002-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/writing-mode/writing-mode-002.html: Added.
• web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative-expected.txt:
• web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative.html:
• web-platform-tests/mathml/relations/text-and-math/use-typo-metrics-1.html:
• web-platform-tests/mathml/tools/fractions.py:
• web-platform-tests/mathml/tools/math-text.py: Added.
• web-platform-tests/mathml/tools/mathvariant-transforms.py:
• web-platform-tests/mathml/tools/percentscaledown.py: Added.
• web-platform-tests/mathml/tools/stacks.py:
• web-platform-tests/mathml/tools/w3c-import.log:

LayoutTests:

• TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-2-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt: Added.
• platform/mac-wk1/TestExpectations:

1:28 AM Changeset in webkit [249759] by Carlos Garcia Campos

• 12 edits
  2 deletes in trunk/Tools

[GTK][WPE] Stop using the session bus in the unit tests
​https://bugs.webkit.org/show_bug.cgi?id=201636

Reviewed by Žan Doberšek.

We are actually using GTestDBus, not the actual session bus of the user session, but it would still be better to
use a private p2p DBus connection. This is also the way we encourage apps to implement the communication with
the web process extension. This patch removes the WebKitTestBus class and starts a DBus server before every
test. The server address is passed to the web extension as initialization parameter to connect directly to
it. We keep a global list of connections to the server and a HashMap to get the current active connection for
a WebKitWebView.

• TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:

(beforeAll):
(afterAll):

• TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:

(testProcessPerWebView):
(beforeAll):
(afterAll):

• TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebExtensionGetTitle):
(testWebExtensionInputElementIsUserEdited):
(testDocumentLoadedSignal):
(testWebKitWebViewProcessCrashed):
(testWebExtensionIsolatedWorld):
(testInstallMissingPluginsPermissionRequest):
(testWebExtensionFormControlsAssociated):
(FormSubmissionTest::FormSubmissionTest):
(beforeAll):
(afterAll):

• TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:

(DelayedSignal::DelayedSignal):
(emitPageCreated):
(pageCreatedCallback):
(webkit_web_extension_initialize_with_user_data):

• TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
• TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:

(AccessibilityTest::AccessibilityTest):
(AccessibilityTest::ensureProxy):
(beforeAll):
(afterAll):

• TestWebKitAPI/glib/CMakeLists.txt:
• TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:

(dbusConnectionClosed):
(dbusServerConnection):
(startDBusServer):
(stopDBusServer):
(main):

• TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::initializeWebExtensions):

• TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Removed.
• TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Removed.
• TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::~WebViewTest):
(WebViewTest::extensionProxy):

• TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:

12:17 AM Changeset in webkit [249758] by sbarati@apple.com

• 10 edits
  4 adds in trunk

[WHLSL] Ensure structs/arrays with pointers as fields are disallowed
​https://bugs.webkit.org/show_bug.cgi?id=201525

Reviewed by Robin Morisset.

Source/WebCore:

This patch adds a pass which both ensures that references are always initialized with
concrete values and that we support logical mode validation by disallowing nested references.

Specifically, the pass:

1. Disallows structs to have fields which are references. This prevents us from having to

figure out how to default initialize such a struct. We could relax this in the future if we
did an analysis on which structs contain reference fields, and ensure such struct variables
always have initializers. This would also require us to create constructors for structs which
initialize each field.

2. We also do the same for arrays.
3. References can only be one level deep. So no pointers to pointers. No references to

references, etc. This is to support logical mode validation rules.

Test: webgpu/whlsl/ensure-proper-pointer-usage.html

• Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.cpp: Added.

(WebCore::WHLSL::checkReferenceTypes):

• Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.h: Added.
• Modules/webgpu/WHLSL/WHLSLChecker.cpp:

(WebCore::WHLSL::Checker::visit):

• Modules/webgpu/WHLSL/WHLSLPrepare.cpp:

(WebCore::WHLSL::prepareShared):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

This patch fixes a bug in our test harness where we forgot to wait for the gpu
device to load before running test harness tests. This patch fixes this oversight
and asserts that we have always finished loading before running a test.

• webgpu/whlsl/array-spec-tests.html:
• webgpu/whlsl/ensure-proper-pointer-usage-expected.txt: Added.
• webgpu/whlsl/ensure-proper-pointer-usage.html: Added.
• webgpu/whlsl/js/test-harness.js:

(Harness):
(Harness.prototype.async.requestDevice):
(Harness.prototype.async.callTypedFunction):
(Harness.prototype.async.checkCompileFail):

• webgpu/whlsl/pointer-spec-tests.html:
• webgpu/whlsl/test-harness-test.html:

12:01 AM Changeset in webkit [249757] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

REGRESSION: Scrubbing on ted.com does not work well
​https://bugs.webkit.org/show_bug.cgi?id=201635
<rdar://problem/51463649>

Patch by Antoine Quint <Antoine Quint> on 2019-09-11
Reviewed by Dean Jackson.

This website uses custom media controls that simply don't work well on iOS when the User-Agent string is the desktop one, so we default to the mobile UA.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingRecommendedForRequest):

Sep 10, 2019:

11:34 PM Changeset in webkit [249756] by Kocsen Chung

• 7 edits in trunk/Source

Versioning.

11:06 PM Changeset in webkit [249755] by Fujii Hironori

• 3 edits in trunk/Source/WebKitLegacy/win

[Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
​https://bugs.webkit.org/show_bug.cgi?id=192581
<rdar://problem/46651605>

Reviewed by Alex Christensen.

WebKitLegacy COM interfaces have same name methods within the old
and new interfaces. For example, both IWebEditingDelegate and
IWebEditingDelegate2 interfaces have 'shouldInsertNode' method.
This is a part of public API, can't be renamed.

• Interfaces/IWebEditingDelegate.idl:
• Interfaces/IWebViewPrivate.idl:

Added #pragma to ignore the warning.

9:51 PM Changeset in webkit [249754] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r233780): After swiping to navigate back, pinching to zoom in on webcontent snaps back to zoomed out when letting go
​https://bugs.webkit.org/show_bug.cgi?id=201671
<rdar://problem/50488372>

Reviewed by Simon Fraser.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):
Reset m_lastTransactionIDWithScaleChange, since it is not guaranteed
to only march forward. Otherwise, we can get stuck with a very large
m_lastTransactionIDWithScaleChange, and will not allow stable-state
user-driven zooms until the current transactionID exceeds it.

9:34 PM Changeset in webkit [249753] by Devin Rousso

• 38 edits
  4 moves
  12 adds
  8 deletes in trunk

Web Inspector: Canvas: instrument WebGPUDevice instead of GPUCanvasContext
​https://bugs.webkit.org/show_bug.cgi?id=201650

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Most of the actual "work" done with Web GPU actually uses a WebGPUDevice.

A GPUCanvasContext is basically just a display "client" of the device, and isn't even
required (e.g. compute pipeline). We should treat the GPUCanvasContext almost like a
-webkit-canvas client of a WebGPUDevice.

• inspector/protocol/Canvas.json:
  • Add powerPreference key to ContextAttributes type.
  • Rename requestCSSCanvasClientNodes command to requestClientNodes for the above reason.
  • Rename cssCanvasClientNodesChanged event to clientNodesChanged for the above reason.
  • Rename resolveCanvasContext command to resolveContext since a WebGPUDevice isn't really a "canvas".

Source/WebCore:

Most of the actual "work" done with Web GPU actually uses a WebGPUDevice.

A GPUCanvasContext is basically just a display "client" of the device, and isn't even
required (e.g. compute pipeline). We should treat the GPUCanvasContext almost like a
-webkit-canvas client of a WebGPUDevice.

Tests: inspector/canvas/create-context-webgpu.html

inspector/canvas/requestClientNodes-webgpu.html
inspector/canvas/resolveContext-webgpu.html

• Modules/webgpu/WebGPUAdapter.cpp:

(WebCore::WebGPUAdapter::requestDevice const):
Notify web inspector after a device is created.

• Modules/webgpu/WebGPUDevice.idl:
• Modules/webgpu/WebGPUDevice.h:
• Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::instances): Added.
(WebCore::WebGPUDevice::instancesMutex): Added.
(WebCore::WebGPUDevice::~WebGPUDevice): Added.
Notify web inspector when the device is about to be destructed.

• Modules/webgpu/GPUCanvasContext.h:
• Modules/webgpu/GPUCanvasContext.cpp:

(WebCore::GPUCanvasContext::create):
(WebCore::GPUCanvasContext::configureSwapChain):

• inspector/InspectorCanvas.h:
• inspector/InspectorCanvas.cpp:

(WebCore::canvasIfContextMatchesDevice): Added.
(WebCore::InspectorCanvas::create):
(WebCore::InspectorCanvas::InspectorCanvas):
(WebCore::InspectorCanvas::canvasContext const): Added.
(WebCore::InspectorCanvas::canvasElement const): Added.
(WebCore::InspectorCanvas::isDeviceForCanvasContext const): Added.
(WebCore::InspectorCanvas::deviceContext const): Added.
(WebCore::InspectorCanvas::scriptExecutionContext const): Added.
(WebCore::InspectorCanvas::resolveContext const): Added.
(WebCore::InspectorCanvas::clientNodes const): Added.
(WebCore::InspectorCanvas::canvasChanged):
(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::buildObjectForCanvas):
(WebCore::InspectorCanvas::releaseObjectForRecording):
(WebCore::InspectorCanvas::getCanvasContentAsDataURL):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::canvasElement): Deleted.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCreateWebGPUDeviceImpl): Added.
(WebCore::InspectorInstrumentation::willDestroyWebGPUDeviceImpl): Added.
(WebCore::InspectorInstrumentation::willConfigureSwapChainImpl): Added.

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didCreateWebGPUDevice): Added.
(WebCore::InspectorInstrumentation::willDestroyWebGPUDevice): Added.
(WebCore::InspectorInstrumentation::willConfigureSwapChain): Added.

• inspector/agents/InspectorCanvasAgent.h:
• inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::requestClientNodes): Added.
(WebCore::InspectorCanvasAgent::resolveContext): Added.
(WebCore::InspectorCanvasAgent::startRecording):
(WebCore::InspectorCanvasAgent::stopRecording):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didChangeCSSCanvasClientNodes):
(WebCore::InspectorCanvasAgent::didChangeCanvasMemory):
(WebCore::InspectorCanvasAgent::canvasDestroyed):
(WebCore::InspectorCanvasAgent::recordCanvasAction):
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
(WebCore::InspectorCanvasAgent::didCreateWebGPUDevice): Added.
(WebCore::InspectorCanvasAgent::willDestroyWebGPUDevice): Added.
(WebCore::InspectorCanvasAgent::willConfigureSwapChain): Added.
(WebCore::InspectorCanvasAgent::clearCanvasData):
(WebCore::InspectorCanvasAgent::bindCanvas):
(WebCore::InspectorCanvasAgent::unbindCanvas):
(WebCore::InspectorCanvasAgent::findInspectorCanvas):
(WebCore::InspectorCanvasAgent::requestCSSCanvasClientNodes): Deleted.
(WebCore::contextAsScriptValue): Deleted.
(WebCore::InspectorCanvasAgent::resolveCanvasContext): Deleted.

• inspector/InspectorShaderProgram.cpp:

(WebCore::InspectorShaderProgram::context const):

Source/WebInspectorUI:

Most of the actual "work" done with Web GPU actually uses a WebGPUDevice.

A GPUCanvasContext is basically just a display "client" of the device, and isn't even
required (e.g. compute pipeline). We should treat the GPUCanvasContext almost like a
-webkit-canvas client of a WebGPUDevice.

• UserInterface/Protocol/CanvasObserver.js:

(WI.CanvasObserver.prototype.clientNodesChanged): Added.
(WI.CanvasObserver.prototype.cssCanvasClientNodesChanged):

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.clientNodesChanged): Added.
(WI.CanvasManager.prototype.cssCanvasClientNodesChanged): Deleted.

• UserInterface/Models/Canvas.js:

(WI.Canvas.resetUniqueDisplayNameNumbers):
(WI.Canvas.prototype.get displayName):
(WI.Canvas.prototype.requestNode):
(WI.Canvas.prototype.requestClientNodes): Added.
(WI.Canvas.prototype.requestSize):
(WI.Canvas.prototype.clientNodesChanged): Added.
(WI.Canvas.prototype.requestCSSCanvasClientNodes): Deleted.
(WI.Canvas.prototype.cssCanvasClientNodesChanged): Deleted.

• UserInterface/Protocol/RemoteObject.js:

(WI.RemoteObject.resolveCanvasContext):

• UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype.attached):
(WI.CanvasContentView.prototype._refreshPixelSize):

• UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WI.CanvasDetailsSidebarPanel.prototype.set canvas):
(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):
(WI.CanvasDetailsSidebarPanel.prototype.layout):
(WI.CanvasDetailsSidebarPanel.prototype._refreshSourceSection):
(WI.CanvasDetailsSidebarPanel.prototype._refreshClientsSection): Added.
(WI.CanvasDetailsSidebarPanel.prototype._refreshCSSCanvasSection): Deleted.

• UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView.prototype._contentViewMouseEnter):

• UserInterface/Views/CanvasTreeElement.js:

(WI.CanvasTreeElement.prototype._handleMouseOver):

• Localizations/en.lproj/localizedStrings.js:

LayoutTests:

• inspector/canvas/create-context-webgpu.html:
• inspector/canvas/create-context-webgpu-expected.txt:
• inspector/canvas/resources/create-context-utilities.js:

(createDetachedCanvas):
(createCSSCanvas):
(destroyCanvases):

• inspector/canvas/requestClientNodes.html: Added.
• inspector/canvas/requestClientNodes-expected.txt: Added.
• inspector/canvas/requestClientNodes-css.html: Renamed from LayoutTests/inspector/canvas/css-canvas-clients.html.
• inspector/canvas/requestClientNodes-css-expected.txt: Renamed from LayoutTests/inspector/canvas/css-canvas-clients-expected.txt.
• inspector/canvas/requestClientNodes-webgpu.html: Added.
• inspector/canvas/requestClientNodes-webgpu-expected.txt: Added.

• inspector/canvas/resolveContext-2d.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-2d.html.
• inspector/canvas/resolveContext-2d-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-2d-expected.txt.
• inspector/canvas/resolveContext-bitmaprenderer.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-bitmaprenderer.html.
• inspector/canvas/resolveContext-bitmaprenderer-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-bitmaprenderer-expected.txt.
• inspector/canvas/resolveContext-webgl.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl.html.
• inspector/canvas/resolveContext-webgl-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl-expected.txt.
• inspector/canvas/resolveContext-webgl2.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl2.html.
• inspector/canvas/resolveContext-webgl2-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl2-expected.txt.
• inspector/canvas/resolveContext-webgpu.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgpu.html.
• inspector/canvas/resolveContext-webgpu-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgpu-expected.txt.

• inspector/canvas/context-attributes-expected.txt:

• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wpe/TestExpectations:

9:15 PM Changeset in webkit [249752] by dino@apple.com

• 2 edits in trunk/Tools

setup-git-clone is using http not https
​https://bugs.webkit.org/show_bug.cgi?id=201658

Reviewed by Sam Weinig.

• Scripts/webkitpy/tool/commands/setupgitclone.py:

(SetupGitClone.execute):

9:01 PM Changeset in webkit [249751] by Joseph Pecoraro

• 7 edits
  4 deletes in trunk

Web Inspector: Remove legacy CodeMirror based pretty printers
​https://bugs.webkit.org/show_bug.cgi?id=201624

Reviewed by Devin Rousso.

Source/WebInspectorUI:

• Tools/PrettyPrinting/FormatterDebug.js: Removed.
• Tools/PrettyPrinting/Utilities.js: Removed.
• Tools/PrettyPrinting/codemirror-additions.css: Removed.
• Tools/PrettyPrinting/index.html: Removed.
• Tools/PrettyPrinting/populate/apple.css: Removed.
• UserInterface/Controllers/Formatter.js: Removed.
• UserInterface/Main.html:
• UserInterface/Test.html:
• UserInterface/Views/CodeMirrorFormatters.js: Removed.
• UserInterface/Views/TextEditor.js:

(WI.TextEditor.prototype.prettyPrint):
(WI.TextEditor.prototype._canUseFormatterWorker): Deleted.
(WI.TextEditor.prototype._startCodeMirrorPrettyPrint): Deleted.

• WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
• WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

LayoutTests:

• inspector/codemirror/prettyprinting-css-expected.txt: Removed.
• inspector/codemirror/prettyprinting-css.html: Removed.
• inspector/codemirror/prettyprinting-javascript-expected.txt: Removed.
• inspector/codemirror/prettyprinting-javascript.html: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/basic-expected.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/basic.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/calc-expected.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/calc.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/gradient-expected.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/gradient.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/keyframes-expected.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/keyframes.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/media-query-expected.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/media-query.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/selectors-expected.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/selectors.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/wrapping-expected.css: Removed.
• inspector/codemirror/resources/prettyprinting/css-tests/wrapping.css: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/block-comment-expected.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/block-comment.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/do-while-loop-expected.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/do-while-loop.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/do-while-within-if-expected.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/do-while-within-if.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/if-followed-by-while-expected.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/if-followed-by-while.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/if-while-within-do-while-expected.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/if-while-within-do-while.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/single-statement-blocks-expected.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/single-statement-blocks.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/switch-case-default-expected.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/switch-case-default.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/unary-binary-operators-expected.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/unary-binary-operators.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/while-within-do-while-expected.js: Removed.
• inspector/codemirror/resources/prettyprinting/javascript-tests/while-within-do-while.js: Removed.
• inspector/codemirror/resources/prettyprinting/utilities.js: Removed.

6:57 PM Changeset in webkit [249750] by Fujii Hironori

• 2 edits in trunk/Source/WebKitLegacy

Unreviewed, rolling out r239097.

This is not a right fix. DumpRenderTree, MiniBrowser and
TestWebKitAPI are still reporting the same warning.

Reverted changeset:

"[Win][WebKitLegacy][Clang] WebKit.h warning:
'IWebEditingDelegate2::shouldInsertNode' hides overloaded
virtual function [-Woverloaded-virtual]"
​https://bugs.webkit.org/show_bug.cgi?id=192581
​https://trac.webkit.org/changeset/239097

6:12 PM Changeset in webkit [249749] by Matt Lewis

• 4 edits
  2 adds in trunk/Tools

run-webkit-test: Allow results to be uploaded without scm checkout
​https://bugs.webkit.org/show_bug.cgi?id=200787

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/common/checkout/scm/detection.py:

(SCMDetector.detect_scm_system): Added in detection of stub repository.

• Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.

(StubRepository):
(StubRepository.init):
(StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
find the directory containing the checkout_information.json of the stub repository.
(StubRepository.in_working_directory): Required functions to be implemented.
(StubRepository.svn_revision): Required functions to be implemented.
(StubRepository.native_revision): Required functions to be implemented.
(StubRepository.native_branch): Required functions to be implemented.
(StubRepository._decode_json): Decodes checkout_information.json.
(StubRepository.find_checkout_root): Required functions to be implemented.

• Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.

(StubRepositoryTest): Unit test for stub_repository SCM.
(StubRepositoryTest.mock_host_for_stub_repository):
(StubRepositoryTest.test_in_working_directory):
(StubRepositoryTest.test_native_revision):
(StubRepositoryTest.test_native_branch):
(StubRepositoryTest.test_svn_revision):
(StubRepositoryTest.test_find_checkout_root):

• Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.

• Scripts/webkitpy/port/base.py:

(Port.commits_for_upload): Removed unnecessary scm initialization.

5:54 PM Changeset in webkit [249748] by Chris Dumez

• 10 edits in trunk/Source

Nullptr crash in Page::sessionID() via WebKit::WebFrameLoaderClient::detachedFromParent2()
​https://bugs.webkit.org/show_bug.cgi?id=201625

Reviewed by Ryosuke Niwa.

This is based on a patch from Ryosuke Niwa.

Source/WebCore:

Drop setHasFrameSpecificStorageAccess() in WebCore and call it from the WebKit layer instead.

• dom/DocumentStorageAccess.cpp:

(WebCore::DocumentStorageAccess::requestStorageAccess):
(WebCore::DocumentStorageAccess::setHasFrameSpecificStorageAccess): Deleted.

• dom/DocumentStorageAccess.h:
• loader/EmptyFrameLoaderClient.h:
• loader/FrameLoaderClient.h:

Source/WebKit:

The crash was caused by WebFrameLoaderClient::sessionID() calling WebPage::sessionID() without
checking the nullity of WebPage::m_page which can be null. Added a null check.

Because passing a wrong session to RemoveStorageAccessForFrame could result in a leak, this patch
also replaces m_hasFrameSpecificStorageAccess boolean with an optioanl struct which stores
session ID, frame ID, and page ID even after WebCore::Frame or WebCore::Page had been cleared
or before WebFrameLoaderClient::m_frame is set.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::sessionID const):
(WebKit::WebFrameLoaderClient::setHasFrameSpecificStorageAccess):
(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::dispatchWillChangeDocument):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebPage/WebFrame.h:

(WebKit::WebFrame::frameLoaderClient const):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestStorageAccess):

5:46 PM Changeset in webkit [249747] by ysuzuki@apple.com

• 6 edits in trunk/Source/JavaScriptCore

[JSC] 32bit bitwide operation with all-one (-1) is wrong in B3
​https://bugs.webkit.org/show_bug.cgi?id=201634

Reviewed by Mark Lam and Robin Morisset.

This patch includes two things. One is fixing 32bit bitwise operation with allOne constants. Another is fixing the existing bug in BitAnd strength reduction.

1. 32bit bitwise operation with allOne constants

Accidentally, the B3::Value is ConstInt32(-1), value->isInt(std::numeric_limits<uint32_t>::max()) returns false!
For example, in BitAnd strength reduction,

1034 Turn this: BitAnd(value, all-ones)
1035 Into this: value.
1036 if ((m_value->type() == Int64 && m_value->child(1)->isInt(std::numeric_limits<uint64_t>::max()))

1037

(m_value->type() == Int32 && m_value->child(1)->isInt(std::numeric_limits<uint32_t>::max()))) {

1038 replaceWithIdentity(m_value->child(0));
1039 break;
1040 }

We use m_value->child(1)->isInt(std::numeric_limits<uint32_t>::max()). However, Value::isInt is,

262 inline bool Value::isInt(int64_t value) const
263 {
264 return hasInt() && asInt() == value;
265 }

So, UINT32_MAX is expanded to int64_t, but it is not -1 since UINT32_MAX can be representable in int64_t. And Value::asInt implementation is,

257 inline int64_t Value::asInt() const
258 {
259 return hasInt32() ? asInt32() : asInt64();
260 }

So, we perform static_cast<int64_t>(-1) == static_cast<int64_t>(UINT32_MAX). This is false, but this comparison is not what we want!
We should use isInt32 and isInt64 for bit patterns (like, operands for Bitwise opcodes).

2. BitAnd and BitOr strength reduction bug

We also fix the following optimization.

Turn this: BitAnd(Op(value, constant1), constant2)
where !(constant1 & constant2)
and Op is BitOr or BitXor
into this: BitAnd(value, constant2)

Since we stop further optimization when we match if (m_value->child(1)->hasInt()), the following optimization is never taken.

Turn this: BitAnd(BitXor(x, allOnes), c)
Into this: BitXor(BitOr(x, ~c), allOnes)

And we also found that this not-used optimization has a bug not inserting a newly produced constant B3::Value. This patch also fixes it.

For both, this patch adds tests. And (2) fix can be ensured that the testb3 does not crash with validate-graph option.

• b3/B3LowerToAir.cpp:
• b3/B3ReduceStrength.cpp:
• b3/testb3.h:
• b3/testb3_2.cpp:

(testBitAndNotNot32):
(testBitAndNotImm):
(testBitAndNotImm32):
(testBitOrAndAndArgs32):
(testBitOrAndSameArgs32):
(testBitOrNotNot32):
(testBitOrNotImm32):
(addBitTests):

• b3/testb3_3.cpp:

(testBitXorAndAndArgs32):
(testBitXorAndSameArgs32):

5:35 PM Changeset in webkit [249746] by Chris Dumez

• 7 edits
  2 adds in trunk

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/cookies/private-cookie-storage.html
​https://bugs.webkit.org/show_bug.cgi?id=201648

Reviewed by Alex Christensen.

Use testRunner.setShouldSwapToEphemeralSessionOnNextNavigation() / setShouldSwapToDefaultSessionOnNextNavigation() to
truly switch session on WebKit2 instead of using the testRunner.setPrivateBrowsingEnabled_DEPRECATED() hack.

• http/tests/cookies/private-cookie-storage-expected.txt:
• http/tests/cookies/private-cookie-storage.html:
• http/tests/cookies/resources/cookies-test-pre.js:

(testCookies):

5:30 PM Changeset in webkit [249745] by Alan Coon

• 1 copy in tags/Safari-608.3.2

Tag Safari-608.3.2.

5:26 PM Changeset in webkit [249744] by Ryan Haddad

• 2 edits in trunk/LayoutTests

[iOS] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/registration-mime-types.https.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=201190

Unreviewed test gardening.

• platform/ios/TestExpectations:

5:17 PM Changeset in webkit [249743] by ysuzuki@apple.com

• 6 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r249721.
​https://bugs.webkit.org/show_bug.cgi?id=201667

Discovering existing bug (Requested by yusukesuzuki on
#webkit).

Reverted changeset:

"[JSC] 32bit bitwide operation with all-one (-1) is wrong in
B3"
​https://bugs.webkit.org/show_bug.cgi?id=201634
​https://trac.webkit.org/changeset/249721

Patch by Commit Queue <​commit-queue@webkit.org> on 2019-09-10

5:05 PM Changeset in webkit [249742] by Alan Coon

• 1 copy in tags/Safari-608.2.11.1.4

Tag Safari-608.2.11.1.4.

5:02 PM Changeset in webkit [249741] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video.https.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=201665

Unreviewed test gardening.

This test was unskipped as part of r249716, but it is still frequently failing.

• TestExpectations: Skip the test again.

4:18 PM Changeset in webkit [249740] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] CodeBlock::calleeSaveRegisters should not see half-baked JITData
​https://bugs.webkit.org/show_bug.cgi?id=201664
<rdar://problem/52126927>

Reviewed by Tadeu Zagallo.

We are hitting the crash accessing invalid-pointer as CodeBlock::calleeSaveRegisters result.
This is because concurrent Baseline JIT compiler can access m_jitData without taking a lock through CodeBlock::calleeSaveRegisters.
Since m_jitData can be initialized in the main thread while calling CodeBlock::calleeSaveRegisters from concurrent Baseline JIT compiler thread,
we can see half-baked JITData structure which holds garbage pointers.

But we do not want to make CodeBlock::calleeSaveRegisters() call with CodeBlock::m_lock due to several reasons.

1. This function is very primitive one and it is called from various AssemblyHelpers functions and other code-generation functions. Some of these functions are called while taking this exact same lock, so dead-lock can happen.
2. JITData::m_calleeSaveRegisters is filled only for DFG and FTL CodeBlock. And DFG and FTL code accesses these field after initializing properly. For Baseline JIT compiler case, only thing we should do is that JITData should say m_calleeSaveRegisters is nullptr and it won't be filled for this CodeBlock.

Instead of guarding CodeBlock::calleeSaveRegisters() function with CodeBlock::m_lock, this patch inserts WTF::storeStoreFence when filling m_jitData. This ensures that
JITData::m_calleeSaveRegisters is initialized with nullptr when this JITData pointer is exposed to concurrent Baseline JIT compiler thread.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::ensureJITDataSlow):

4:12 PM Changeset in webkit [249739] by beidson@apple.com

• 26 edits
  3 adds in trunk

Add SPI to save a PDF from the contents of a WKWebView.
<rdar://problem/48955900> and ​https://bugs.webkit.org/show_bug.cgi?id=195765

Reviewed by Tim Horton.

Source/WebCore:

Covered by API tests.

• page/FrameView.cpp:

(WebCore::FrameView::paintContents): Don't paint the debug color outside of the FrameRect.

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setURLForRect):

• rendering/PaintPhase.h: Add "AnnotateLinks" option to always gather and annotation links.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::hasOutlineAnnotation const): Also return true when the PaintOptions include "AnnotateLinks"

Source/WebKit:

This is refactoring a combination of "snapshotFirstPage" PDF printing code and the
"takeSnapshot" API code to capture the on-screen visible page to a PDF at full fidelity.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takePDFSnapshotWithConfiguration:completionHandler:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::drawToPDF):
(WebKit::WebPageProxy::drawToPDFCallback):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:

• UIProcess/ios/WKContentView.mm:

(-[WKContentView _wk_pageCountForPrintFormatter:]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::drawToPDFCallback): Move to cross platform WebPageProxy.

• WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::pdfSnapshotAtSize):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pdfSnapshotAtSize): Instead of assuming 1 page capped at 200 inches,

paginate every 200 inches.

(WebKit::WebPage::drawToPDF):
(WebKit::paintSnapshotAtSize): Deleted.
(WebKit::WebPage::pdfSnapshotAtSize): Deleted.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Tools:

-Add an "Export to PDF..." menu option to MiniBrowser.
-Add API tests for the API itself.

• MiniBrowser/MiniBrowser.entitlements:

• MiniBrowser/mac/BrowserWindowController.h:
• MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController forceRepaint:]):
(-[BrowserWindowController saveAsPDF:]):

• MiniBrowser/mac/MainMenu.xib:

• MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController validateMenuItem:]):

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController saveAsPDF:]):

• TestWebKitAPI/Configurations/Base.xcconfig:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm: Added.

(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/TestPDFDocument.h: Added.
• TestWebKitAPI/cocoa/TestPDFDocument.mm: Added.

(TestWebKitAPI::toCGRect):
(TestWebKitAPI::toPlatformPoint):
(TestWebKitAPI::TestPDFAnnotation::TestPDFAnnotation):
(TestWebKitAPI::TestPDFAnnotation::isLink const):
(TestWebKitAPI::TestPDFAnnotation::bounds const):
(TestWebKitAPI::TestPDFAnnotation::linkURL const):
(TestWebKitAPI::TestPDFPage::create):
(TestWebKitAPI::TestPDFPage::TestPDFPage):
(TestWebKitAPI::TestPDFPage::annotations):
(TestWebKitAPI::TestPDFPage::characterCount const):
(TestWebKitAPI::TestPDFPage::text const):
(TestWebKitAPI::TestPDFPage::rectForCharacterAtIndex const):
(TestWebKitAPI::TestPDFPage::characterIndexAtPoint const):
(TestWebKitAPI::TestPDFPage::bounds const):
(TestWebKitAPI::TestPDFPage::colorAtPoint const):
(TestWebKitAPI::TestPDFDocument::createFromData):
(TestWebKitAPI::TestPDFDocument::TestPDFDocument):
(TestWebKitAPI::TestPDFDocument::pageCount const):
(TestWebKitAPI::TestPDFDocument::page):

3:48 PM Changeset in webkit [249738] by Keith Rollin

• 2 edits in trunk/Tools

Remove SSL-based TLSDeprecation.mm contents
​https://bugs.webkit.org/show_bug.cgi?id=201657
<rdar://problem/55237678>

Reviewed by Alex Christensen.

This file does not build on watchOS due to references to SSL
facilities. Conditionalize out the contents on HAVE_SSL.

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

3:28 PM Changeset in webkit [249737] by jiewen_tan@apple.com

• 5 edits in trunk

REGRESSION: [ Catalina WK2 ] http/wpt/webauthn/public-key-credential-create-success-u2f.https.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=201620
<rdar://problem/51524958>

Reviewed by Alex Christensen.

Source/WebCore:

Covered by existing tests.

• Modules/webauthn/fido/U2fResponseConverter.cpp:

(fido::WebCore::createAttestedCredentialDataFromU2fRegisterResponse):
Change the way how the aaguid is initialized to see if that fixes the issue.

LayoutTests:

• http/wpt/webauthn/public-key-credential-create-success-u2f.https.html:

Remove the timeout value given those tests should never time out.

• platform/mac-wk2/TestExpectations:

Change the test expectation to Pass.

3:07 PM Changeset in webkit [249736] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] ResultType implementation is wrong for bit ops, and ends up making ArithDiv take the DFG Int32 fast path even if Baseline constantly produces Double result
​https://bugs.webkit.org/show_bug.cgi?id=198253

Reviewed by Mark Lam.

ResultType of bitwise operation needs to include TypeMaybeNumber. TypeInt32 is something like a flag indicating the number looks like a int32.
When it is specified, TypeMaybeNumber must exist too. This issue compiles op_div in JetStream2/async-fs slow-path. And eventually DFG first mis-compiles
it with Int32 ArithDiv while that div always produces double. And unnecessary OSR exit happens.

In this patch, we add TypeMaybeNumber to bigIntOrInt32Type correctly.

• parser/ResultType.h:

(JSC::ResultType::bigIntOrInt32Type):

3:03 PM Changeset in webkit [249735] by Ryan Haddad

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline imported/w3c/web-platform-tests/css/cssom/interfaces.html after r249672.

Unreviewed test gardening.

• web-platform-tests/css/cssom/interfaces-expected.txt:

2:59 PM Changeset in webkit [249734] by Simon Fraser

• 2 edits in trunk/LayoutTests

Attempt to make this test not flakey.
​https://bugs.webkit.org/show_bug.cgi?id=201482

• legacy-animation-engine/compositing/transitions/add-remove-transition.html:

2:43 PM Changeset in webkit [249733] by Chris Dumez

• 4 edits in trunk

Add missing origin check for Service-Worker-Allowed header
​https://bugs.webkit.org/show_bug.cgi?id=201653

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

• web-platform-tests/service-workers/service-worker/Service-Worker-Allowed-header.https-expected.txt:

Source/WebCore:

Add missing origin check for Service-Worker-Allowed header:

• ​https://w3c.github.io/ServiceWorker/#update-algorithm (step 15. 2.)

• workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::didReceiveResponse):

1:37 PM Changeset in webkit [249732] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

REGRESSION (r249460): LayoutTests/webgpu/viewport-scissor-rect-triangle-strip.html is Failing
​https://bugs.webkit.org/show_bug.cgi?id=201478

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-09-10
Reviewed by Simon Fraser.

-- Revert r249460 which changed drawGreenAndBlueCheckerboardInSoftware().
-- Remove the orientation bit from webgpu/resources/blue-checkered.png

so drawing it is not affected by r249364.

• webgpu/js/webgpu-functions.js:

(drawGreenAndBlueCheckerboardInSoftware):

• webgpu/resources/blue-checkered.png:

1:14 PM Changeset in webkit [249731] by Chris Dumez

• 57 edits
  93 adds in trunk/LayoutTests/imported/w3c

Re-sync web-platform-tests IDL interfaces from upstream
​https://bugs.webkit.org/show_bug.cgi?id=201630

Reviewed by Alex Christensen.

Re-sync web-platform-tests IDL interfaces from upstream 603a271948a7162.

• web-platform-tests/interfaces/BackgroundSync.idl: Added.
• web-platform-tests/interfaces/CSP.idl: Added.
• web-platform-tests/interfaces/CSS-Parser-API.idl: Added.
• web-platform-tests/interfaces/DOM-Parsing.idl:
• web-platform-tests/interfaces/FileAPI.idl:
• web-platform-tests/interfaces/IndexedDB.idl:
• web-platform-tests/interfaces/InputDeviceCapabilities.idl: Added.
• web-platform-tests/interfaces/META.yml: Added.
• web-platform-tests/interfaces/README.md: Added.
• web-platform-tests/interfaces/SRI.idl: Added.
• web-platform-tests/interfaces/WebCryptoAPI.idl:
• web-platform-tests/interfaces/accelerometer.idl:
• web-platform-tests/interfaces/ambient-light.idl:
• web-platform-tests/interfaces/animation-worklet.idl: Added.
• web-platform-tests/interfaces/appmanifest.idl: Added.
• web-platform-tests/interfaces/audio-output.idl: Added.
• web-platform-tests/interfaces/background-fetch.idl:
• web-platform-tests/interfaces/battery-status.idl: Added.
• web-platform-tests/interfaces/beacon.idl: Added.
• web-platform-tests/interfaces/clipboard-apis.idl:
• web-platform-tests/interfaces/compat.idl: Added.
• web-platform-tests/interfaces/console.idl:
• web-platform-tests/interfaces/cookie-store.idl:
• web-platform-tests/interfaces/cors-rfc1918.idl: Added.
• web-platform-tests/interfaces/csp-embedded-enforcement.idl: Added.
• web-platform-tests/interfaces/css-animations.idl: Added.
• web-platform-tests/interfaces/css-conditional.idl: Added.
• web-platform-tests/interfaces/css-counter-styles.idl: Added.
• web-platform-tests/interfaces/css-device-adapt.idl: Added.
• web-platform-tests/interfaces/css-font-loading.idl: Added.
• web-platform-tests/interfaces/css-fonts.idl: Added.
• web-platform-tests/interfaces/css-images.idl: Added.
• web-platform-tests/interfaces/css-layout-api.idl: Added.
• web-platform-tests/interfaces/css-masking.idl: Added.
• web-platform-tests/interfaces/css-paint-api.idl: Added.
• web-platform-tests/interfaces/css-regions.idl: Added.
• web-platform-tests/interfaces/css-transitions.idl: Added.
• web-platform-tests/interfaces/css-typed-om.idl:
• web-platform-tests/interfaces/element-timing.idl: Added.
• web-platform-tests/interfaces/encoding.idl:
• web-platform-tests/interfaces/encrypted-media.idl:
• web-platform-tests/interfaces/entries-api.idl:
• web-platform-tests/interfaces/event-timing.idl: Added.
• web-platform-tests/interfaces/feature-policy.idl: Added.
• web-platform-tests/interfaces/fetch.idl:
• web-platform-tests/interfaces/filter-effects.idl: Added.
• web-platform-tests/interfaces/font-metrics-api.idl: Added.
• web-platform-tests/interfaces/fullscreen.idl:
• web-platform-tests/interfaces/gamepad.idl:
• web-platform-tests/interfaces/generic-sensor.idl: Added.
• web-platform-tests/interfaces/geolocation-API.idl: Added.
• web-platform-tests/interfaces/geolocation-sensor.idl:
• web-platform-tests/interfaces/geometry.idl:
• web-platform-tests/interfaces/gyroscope.idl:
• web-platform-tests/interfaces/hr-time.idl:
• web-platform-tests/interfaces/html-media-capture.idl: Added.
• web-platform-tests/interfaces/image-capture.idl: Added.
• web-platform-tests/interfaces/input-events.idl: Added.
• web-platform-tests/interfaces/intersection-observer.idl:
• web-platform-tests/interfaces/keyboard-lock.idl: Added.
• web-platform-tests/interfaces/keyboard-map.idl: Added.
• web-platform-tests/interfaces/largest-contentful-paint.idl: Added.
• web-platform-tests/interfaces/layout-instability.idl: Added.
• web-platform-tests/interfaces/longtasks.idl: Added.
• web-platform-tests/interfaces/magnetometer.idl:
• web-platform-tests/interfaces/media-capabilities.idl: Added.
• web-platform-tests/interfaces/media-playback-quality.idl: Added.
• web-platform-tests/interfaces/media-source.idl: Added.
• web-platform-tests/interfaces/mediacapture-depth.idl: Added.
• web-platform-tests/interfaces/mediacapture-fromelement.idl: Added.
• web-platform-tests/interfaces/mediasession.idl: Added.
• web-platform-tests/interfaces/mediastream-recording.idl: Added.
• web-platform-tests/interfaces/mst-content-hint.idl: Added.
• web-platform-tests/interfaces/navigation-timing.idl: Added.
• web-platform-tests/interfaces/netinfo.idl: Added.
• web-platform-tests/interfaces/notifications.idl: Added.
• web-platform-tests/interfaces/orientation-event.idl: Added.
• web-platform-tests/interfaces/orientation-sensor.idl:
• web-platform-tests/interfaces/page-visibility.idl: Added.
• web-platform-tests/interfaces/paint-timing.idl: Added.
• web-platform-tests/interfaces/payment-handler.idl:
• web-platform-tests/interfaces/payment-method-basic-card.idl: Added.
• web-platform-tests/interfaces/payment-request.idl:
• web-platform-tests/interfaces/permissions.idl: Added.
• web-platform-tests/interfaces/picture-in-picture.idl: Added.
• web-platform-tests/interfaces/pointerevents-extension.idl: Added.
• web-platform-tests/interfaces/pointerevents.idl: Added.
• web-platform-tests/interfaces/pointerlock.idl: Added.
• web-platform-tests/interfaces/presentation-api.idl: Added.
• web-platform-tests/interfaces/proximity.idl:
• web-platform-tests/interfaces/push-api.idl: Added.
• web-platform-tests/interfaces/remote-playback.idl: Added.
• web-platform-tests/interfaces/reporting.idl: Added.
• web-platform-tests/interfaces/requestidlecallback.idl: Added.
• web-platform-tests/interfaces/resize-observer.idl: Added.
• web-platform-tests/interfaces/screen-capture.idl: Added.
• web-platform-tests/interfaces/screen-orientation.idl:
• web-platform-tests/interfaces/scroll-animations.idl: Added.
• web-platform-tests/interfaces/secure-contexts.idl: Added.
• web-platform-tests/interfaces/selection-api.idl:
• web-platform-tests/interfaces/server-timing.idl: Added.
• web-platform-tests/interfaces/shape-detection-api.idl: Added.
• web-platform-tests/interfaces/speech-api.idl: Added.
• web-platform-tests/interfaces/storage.idl:
• web-platform-tests/interfaces/touch-events.idl: Added.
• web-platform-tests/interfaces/trusted-types.tentative.idl: Added.
• web-platform-tests/interfaces/uievents.idl:
• web-platform-tests/interfaces/url.idl:
• web-platform-tests/interfaces/user-timing.idl: Added.
• web-platform-tests/interfaces/vibration.idl: Added.
• web-platform-tests/interfaces/wai-aria.idl: Added.
• web-platform-tests/interfaces/wake-lock.idl:
• web-platform-tests/interfaces/wasm-js-api.idl: Added.
• web-platform-tests/interfaces/wasm-web-api.idl: Added.
• web-platform-tests/interfaces/web-animations.idl: Added.
• web-platform-tests/interfaces/web-bluetooth.idl: Added.
• web-platform-tests/interfaces/web-nfc.idl:
• web-platform-tests/interfaces/web-share.idl:
• web-platform-tests/interfaces/webaudio.idl: Added.
• web-platform-tests/interfaces/webauthn.idl:
• web-platform-tests/interfaces/webdriver.idl: Added.
• web-platform-tests/interfaces/webgl1.idl: Added.
• web-platform-tests/interfaces/webgl2.idl: Added.
• web-platform-tests/interfaces/webidl.idl:
• web-platform-tests/interfaces/webmidi.idl: Added.
• web-platform-tests/interfaces/webrtc-dscp.idl: Added.
• web-platform-tests/interfaces/webrtc-stats.idl: Added.
• web-platform-tests/interfaces/webusb.idl:
• web-platform-tests/interfaces/webvtt.idl: Added.
• web-platform-tests/interfaces/webxr.idl:
• web-platform-tests/interfaces/worklets.idl: Added.
• web-platform-tests/interfaces/xhr.idl:
• web-platform-tests/interfaces/xslt.tentative.idl: Added.

12:57 PM Changeset in webkit [249730] by commit-queue@webkit.org

• 1 edit
  3 adds in trunk/LayoutTests

SMIL animations of SVG <view> element have no effect
​https://bugs.webkit.org/show_bug.cgi?id=201536

Patch by Nikolas Zimmermann <​zimmermann@kde.org> on 2019-09-10
Reviewed by Rob Buis.

Added a new layout test to verify that navigating to different anchors within the same
external SVG does not cause reloads. Instead scrollToAnchor() is used which causes an
in-place navigation in the same document. The new test verifies that the SVGSVGElement
is preserved when navigating between anchors, which indicates that no new document was
created. Verify that the SVGViewSpec API works as intended, across navigations.

• svg/dom/SVGViewSpec-multiple-views-expected.txt: Added.
• svg/dom/SVGViewSpec-multiple-views.html: Added.
• svg/dom/resources/multiple-view-elements.svg: Added.

12:42 PM Changeset in webkit [249729] by sihui_liu@apple.com

• 3 edits in trunk/Source/WebCore

IndexedDB: cache prepared SQLiteStatement in SQLiteIDBCursor
​https://bugs.webkit.org/show_bug.cgi?id=201548

Reviewed by Alex Christensen.

This should be a performance improvement as we don't compile the same SQLiteStatement everytime it is used.

No new tests, no behavior change.

• Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord):

• Modules/indexeddb/server/SQLiteIDBCursor.h:

12:07 PM Changeset in webkit [249728] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, re-skip service worker test that was unskipped in r249716.

This test is still flaky.

• TestExpectations:

12:03 PM Changeset in webkit [249727] by Alan Coon

• 1 edit in branches/safari-608-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp

Unreviewed build fix. rdar://problem/55198064

12:01 PM Changeset in webkit [249726] by Alan Coon

• 12 edits in branches/safari-608.2.11.1-branch/Source/bmalloc

Cherry-pick r249670. rdar://problem/55225974

Revert to pre-r243144 scavenging behavior for macOS
​https://bugs.webkit.org/show_bug.cgi?id=201555

Reviewed by Saam Barati.

The change in r243144 regressed internal power metrics for some Mac models.

• bmalloc/Heap.cpp: (bmalloc::Heap::scavenge): (bmalloc::Heap::scavengeToHighWatermark): (bmalloc::Heap::allocateSmallChunk): (bmalloc::Heap::allocateSmallPage): (bmalloc::Heap::allocateLarge):
• bmalloc/Heap.h:
• bmalloc/IsoDirectory.h:
• bmalloc/IsoDirectoryInlines.h: (bmalloc::passedNumPages>::takeFirstEligible): (bmalloc::passedNumPages>::scavenge): (bmalloc::passedNumPages>::scavengeToHighWatermark):
• bmalloc/IsoHeapImpl.h:
• bmalloc/IsoHeapImplInlines.h: (bmalloc::IsoHeapImpl<Config>::scavengeToHighWatermark):
• bmalloc/LargeMap.cpp: (bmalloc::LargeMap::add):
• bmalloc/LargeRange.h: (bmalloc::LargeRange::LargeRange): (bmalloc::merge):
• bmalloc/Scavenger.cpp: (bmalloc::Scavenger::Scavenger): (bmalloc::Scavenger::timeSinceLastPartialScavenge): (bmalloc::Scavenger::scavenge): (bmalloc::Scavenger::partialScavenge): (bmalloc::Scavenger::threadRunLoop):
• bmalloc/Scavenger.h:
• bmalloc/SmallPage.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:43 AM Changeset in webkit [249725] by Chris Dumez

• 3 edits
  93 deletes in trunk/LayoutTests

Unreviewed, rolling out r249724.

Patch included a lot more changes than intended

Reverted changeset:

"Unreviewed, re-skip service worker test that was unskipped in
r249716."
​https://trac.webkit.org/changeset/249724

11:18 AM Changeset in webkit [249724] by Chris Dumez

• 2 edits
  93 adds in trunk/LayoutTests

Unreviewed, re-skip service worker test that was unskipped in r249716.

This test is still flaky.

• TestExpectations:

11:14 AM Changeset in webkit [249723] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Hangs on Swiss.com due to the web process being blocked on StorageAreaMap::LoadValuesIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=201644
<rdar://problem/54942761>

Reviewed by Geoffrey Garen.

Mark the StorageManagerSet::GetValues sync IPC from the WebContent process to the Network
process with a UnboundedSynchronousIPCScope so that it will process critical sync IPC
from the UIProcess (such as WebPage::GetPositionInformation) while waiting for a reply.

• WebProcess/WebStorage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::loadValuesIfNeeded):

10:41 AM Changeset in webkit [249722] by youenn@apple.com

• 9 edits in trunk/Source/WebCore

RTCPeerConnection can only be instantiated in documents
​https://bugs.webkit.org/show_bug.cgi?id=201639

Reviewed by Alex Christensen.

Make it clear that RTCDataChannel expects Document since peer connections
and data channels can only be instantiated in document environments.
We keep one downcast in RTCPeerConnection constructor due to a limitation
in binding generator for JS built-ins.
No change of behavior.

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::create):
(WebCore::RTCDataChannel::RTCDataChannel):

• Modules/mediastream/RTCDataChannel.h:
• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::certificatesFromConfiguration):
(WebCore::RTCPeerConnection::createDataChannel):
(WebCore::RTCPeerConnection::document):

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:

(WebCore::LibWebRTCDataChannelHandler::channelEvent):

• Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::OnDataChannel):

10:07 AM Changeset in webkit [249721] by ysuzuki@apple.com

• 6 edits in trunk/Source/JavaScriptCore

[JSC] 32bit bitwide operation with all-one (-1) is wrong in B3
​https://bugs.webkit.org/show_bug.cgi?id=201634

Reviewed by Mark Lam.

Accidentally, the B3::Value is ConstInt32(-1), value->isInt(std::numeric_limits<uint32_t>::max()) returns false!
For example, in BitAnd strength reduction,

1034 Turn this: BitAnd(value, all-ones)
1035 Into this: value.
1036 if ((m_value->type() == Int64 && m_value->child(1)->isInt(std::numeric_limits<uint64_t>::max()))

1037

(m_value->type() == Int32 && m_value->child(1)->isInt(std::numeric_limits<uint32_t>::max()))) {

1038 replaceWithIdentity(m_value->child(0));
1039 break;
1040 }

We use m_value->child(1)->isInt(std::numeric_limits<uint32_t>::max()). However, Value::isInt is,

262 inline bool Value::isInt(int64_t value) const
263 {
264 return hasInt() && asInt() == value;
265 }

So, UINT32_MAX is expanded to int64_t, but it is not -1 since UINT32_MAX can be representable in int64_t. And Value::asInt implementation is,

257 inline int64_t Value::asInt() const
258 {
259 return hasInt32() ? asInt32() : asInt64();
260 }

So, we perform static_cast<int64_t>(-1) == static_cast<int64_t>(UINT32_MAX). This is false, but this comparison is not what we want!
We should use isInt32 and isInt64 for bit patterns (like, operands for Bitwise opcodes).

We also fix the following optimization.

Turn this: BitAnd(Op(value, constant1), constant2)
where !(constant1 & constant2)
and Op is BitOr or BitXor
into this: BitAnd(value, constant2)

Since we stop further optimization when we match if (m_value->child(1)->hasInt()), the following optimization is never taken.

Turn this: BitAnd(BitXor(x, allOnes), c)
Into this: BitXor(BitOr(x, ~c), allOnes)

We add 32bit version of B3 tests for these optimizations.

• b3/B3LowerToAir.cpp:
• b3/B3ReduceStrength.cpp:
• b3/testb3.h:
• b3/testb3_2.cpp:

(testBitAndNotNot32):
(testBitAndNotImm):
(testBitAndNotImm32):
(testBitOrAndAndArgs32):
(testBitOrAndSameArgs32):
(testBitOrNotNot32):
(testBitOrNotImm32):
(addBitTests):

• b3/testb3_3.cpp:

(testBitXorAndAndArgs32):
(testBitXorAndSameArgs32):

9:56 AM Changeset in webkit [249720] by david_quesada@apple.com

• 2 edits in trunk/Source/WebKit

Remove a leftover reference to the StorageProcess
​https://bugs.webkit.org/show_bug.cgi?id=192759

Reviewed by Alex Christensen.

• WebKit.xcodeproj/project.pbxproj:

Remove com.apple.WebKit.Storage.sb as an input file to the "Copy iOS Sandbox Profiles
for Manual Sandboxing" build phase. The file no longer exists.

9:42 AM Changeset in webkit [249719] by Chris Dumez

• 143 edits
  23 copies
  5 moves
  251 adds
  14 deletes in trunk/LayoutTests

Re-sync workers web platform tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=201629

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Re-sync workers web platform tests from upstream 603a271948a7162.

• web-platform-tests/workers/META.yml: Added.
• web-platform-tests/workers/OWNERS: Removed.
• web-platform-tests/workers/README.md:
• web-platform-tests/workers/SharedWorker-constructor-expected.txt: Added.
• web-platform-tests/workers/SharedWorker-constructor.html: Added.
• web-platform-tests/workers/SharedWorker-detach-frame-in-error-event-expected.txt: Added.
• web-platform-tests/workers/SharedWorker-detach-frame-in-error-event.html: Added.
• web-platform-tests/workers/SharedWorker-exception-expected.txt: Added.
• web-platform-tests/workers/SharedWorker-exception-propagation-expected.txt: Added.
• web-platform-tests/workers/SharedWorker-exception-propagation.html: Added.
• web-platform-tests/workers/SharedWorker-exception.html: Added.
• web-platform-tests/workers/SharedWorker-script-error-expected.txt: Added.
• web-platform-tests/workers/SharedWorker-script-error.html: Added.
• web-platform-tests/workers/SharedWorker-simple-expected.txt: Added.
• web-platform-tests/workers/SharedWorker-simple.html: Added.
• web-platform-tests/workers/SharedWorkerPerformanceNow-expected.txt: Added.
• web-platform-tests/workers/SharedWorkerPerformanceNow.html: Added.
• web-platform-tests/workers/SharedWorker_dataUrl-expected.txt: Added.
• web-platform-tests/workers/SharedWorker_dataUrl.html: Added.
• web-platform-tests/workers/Worker-call.worker-expected.txt: Added.
• web-platform-tests/workers/Worker-call.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/Worker-call.worker.js: Added.

(test):

• web-platform-tests/workers/Worker-messageport-expected.txt: Added.
• web-platform-tests/workers/Worker-messageport.html: Added.
• web-platform-tests/workers/Worker-multi-port-expected.txt: Added.
• web-platform-tests/workers/Worker-multi-port.html: Added.
• web-platform-tests/workers/Worker-nested-importScripts-error-expected.txt: Added.
• web-platform-tests/workers/Worker-nested-importScripts-error.html: Added.
• web-platform-tests/workers/Worker-simultaneous-errors-expected.txt: Added.
• web-platform-tests/workers/Worker-simultaneous-errors.html: Added.
• web-platform-tests/workers/Worker-structure-message-expected.txt: Added.
• web-platform-tests/workers/Worker-structure-message.html: Added.
• web-platform-tests/workers/Worker-terminate-forever-expected.txt: Added.
• web-platform-tests/workers/Worker-terminate-forever.html: Added.
• web-platform-tests/workers/Worker-termination-with-port-messages-expected.txt: Added.
• web-platform-tests/workers/Worker-termination-with-port-messages.html: Added.
• web-platform-tests/workers/Worker-timeout-cancel-order-expected.txt: Added.
• web-platform-tests/workers/Worker-timeout-cancel-order.html: Added.
• web-platform-tests/workers/Worker-timeout-decreasing-order-expected.txt: Added.
• web-platform-tests/workers/Worker-timeout-decreasing-order.html: Added.
• web-platform-tests/workers/Worker-timeout-increasing-order-expected.txt: Added.
• web-platform-tests/workers/Worker-timeout-increasing-order.html: Added.
• web-platform-tests/workers/WorkerGlobalScope-close-expected.txt: Added.
• web-platform-tests/workers/WorkerGlobalScope-close.html: Added.
• web-platform-tests/workers/WorkerGlobalScope_close-expected.txt: Removed.
• web-platform-tests/workers/WorkerGlobalScope_close.htm: Removed.
• web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker-expected.txt: Added.
• web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/WorkerGlobalScope_requestAnimationFrame.tentative.worker.js: Added.
• web-platform-tests/workers/WorkerLocation-origin.sub.window.js: Removed.
• web-platform-tests/workers/WorkerPerformanceNow-expected.txt: Added.
• web-platform-tests/workers/WorkerPerformanceNow.html: Added.
• web-platform-tests/workers/Worker_cross_origin_security_err.htm:
• web-platform-tests/workers/baseurl/alpha/import-in-moduleworker-expected.txt: Added.
• web-platform-tests/workers/baseurl/alpha/import-in-moduleworker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/workers/baseurl/alpha/importScripts.html.
• web-platform-tests/workers/baseurl/alpha/importScripts-in-sharedworker-expected.txt: Added.
• web-platform-tests/workers/baseurl/alpha/importScripts-in-sharedworker.html: Added.
• web-platform-tests/workers/baseurl/alpha/importScripts-in-worker-expected.txt: Added.
• web-platform-tests/workers/baseurl/alpha/importScripts-in-worker.html: Added.
• web-platform-tests/workers/baseurl/alpha/sharedworker-in-worker-expected.txt: Added.
• web-platform-tests/workers/baseurl/alpha/sharedworker-in-worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/workers/baseurl/alpha/sharedworker.html.
• web-platform-tests/workers/baseurl/alpha/w3c-import.log:
• web-platform-tests/workers/baseurl/alpha/worker-in-worker-expected.txt: Added.
• web-platform-tests/workers/baseurl/alpha/worker-in-worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/workers/baseurl/alpha/worker.html.
• web-platform-tests/workers/baseurl/alpha/xhr-in-moduleworker-expected.txt: Added.
• web-platform-tests/workers/baseurl/alpha/xhr-in-moduleworker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/workers/baseurl/alpha/xhr.html.
• web-platform-tests/workers/baseurl/alpha/xhr-in-sharedworker-expected.txt: Added.
• web-platform-tests/workers/baseurl/alpha/xhr-in-sharedworker.html: Added.
• web-platform-tests/workers/baseurl/alpha/xhr-in-worker-expected.txt: Added.
• web-platform-tests/workers/baseurl/alpha/xhr-in-worker.html: Added.
• web-platform-tests/workers/baseurl/beta/import.py: Added.

(main):

• web-platform-tests/workers/baseurl/beta/script.js:
• web-platform-tests/workers/baseurl/beta/w3c-import.log:
• web-platform-tests/workers/baseurl/beta/xhr-worker.py: Added.

(main):

• web-platform-tests/workers/baseurl/gamma/import.js: Added.
• web-platform-tests/workers/baseurl/gamma/importScripts.js:

(test):

• web-platform-tests/workers/baseurl/gamma/script-module.js: Added.
• web-platform-tests/workers/baseurl/gamma/script.js:
• web-platform-tests/workers/baseurl/gamma/w3c-import.log:
• web-platform-tests/workers/baseurl/gamma/xhr-worker.js: Added.
• web-platform-tests/workers/constructors/SharedWorker/connect-event.html:
• web-platform-tests/workers/constructors/SharedWorker/connect-event.js: Added.

(onconnect):

• web-platform-tests/workers/constructors/SharedWorker/dummy-name.html:
• web-platform-tests/workers/constructors/SharedWorker/dummy-shared-worker.html:
• web-platform-tests/workers/constructors/SharedWorker/dummy-shared-worker.js: Added.
• web-platform-tests/workers/constructors/SharedWorker/empty-name.html:
• web-platform-tests/workers/constructors/SharedWorker/empty.js: Added.
• web-platform-tests/workers/constructors/SharedWorker/global-members.html:
• web-platform-tests/workers/constructors/SharedWorker/global-members.js: Added.

(onconnect):

• web-platform-tests/workers/constructors/SharedWorker/interface-objects.html:
• web-platform-tests/workers/constructors/SharedWorker/interface-objects.js: Added.

(handleCall):
(onconnect):

• web-platform-tests/workers/constructors/SharedWorker/name.html:
• web-platform-tests/workers/constructors/SharedWorker/name.js: Added.

(onconnect):

• web-platform-tests/workers/constructors/SharedWorker/port-onmessage.html:
• web-platform-tests/workers/constructors/SharedWorker/port-onmessage.js: Added.

(onconnect):

• web-platform-tests/workers/constructors/SharedWorker/port-properties.html:
• web-platform-tests/workers/constructors/SharedWorker/port-readonly.html:
• web-platform-tests/workers/constructors/SharedWorker/same-origin.html:
• web-platform-tests/workers/constructors/SharedWorker/unexpected-global-properties.html:
• web-platform-tests/workers/constructors/SharedWorker/unexpected-global-properties.js: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/constructors/SharedWorker/unexpected-global-properties.html.

(onconnect):

• web-platform-tests/workers/constructors/SharedWorker/w3c-import.log:
• web-platform-tests/workers/constructors/Worker/AbstractWorker.onerror-expected.txt:
• web-platform-tests/workers/constructors/Worker/AbstractWorker.onerror.html:
• web-platform-tests/workers/constructors/Worker/AbstractWorker.onerror.js: Added.
• web-platform-tests/workers/constructors/Worker/Worker-constructor-expected.txt: Added.
• web-platform-tests/workers/constructors/Worker/Worker-constructor.html: Added.
• web-platform-tests/workers/constructors/Worker/no-arguments-ctor-expected.txt: Removed.
• web-platform-tests/workers/constructors/Worker/no-arguments-ctor.html: Removed.
• web-platform-tests/workers/constructors/Worker/resolve-empty-string-expected.txt: Removed.
• web-platform-tests/workers/constructors/Worker/resolve-empty-string.html: Removed.
• web-platform-tests/workers/constructors/Worker/same-origin.html:
• web-platform-tests/workers/constructors/Worker/sample_worker/w3c-import.log:
• web-platform-tests/workers/constructors/Worker/terminate.html:
• web-platform-tests/workers/constructors/Worker/terminate.js: Added.

(f):

• web-platform-tests/workers/constructors/Worker/unresolvable-url-expected.txt: Removed.
• web-platform-tests/workers/constructors/Worker/unresolvable-url.html: Removed.
• web-platform-tests/workers/constructors/Worker/w3c-import.log:
• web-platform-tests/workers/dedicated-worker-from-blob-url.window-expected.txt: Added.
• web-platform-tests/workers/dedicated-worker-from-blob-url.window.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/dedicated-worker-from-blob-url.window.js: Added.

(message_from_port):

• web-platform-tests/workers/examples/fetch_tests_from_worker-expected.txt: Added.
• web-platform-tests/workers/examples/fetch_tests_from_worker.html: Added.
• web-platform-tests/workers/examples/fetch_tests_from_worker.js: Added.

(test):

• web-platform-tests/workers/examples/general.worker-expected.txt: Added.
• web-platform-tests/workers/examples/general.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/examples/general.worker.js: Added.

(test):

• web-platform-tests/workers/examples/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/baseurl/alpha/w3c-import.log.
• web-platform-tests/workers/interfaces.worker-expected.txt: Removed.
• web-platform-tests/workers/interfaces.worker.js: Removed.
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/event-ports-dedicated.html:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/event-ports-dedicated.js: Added.

(onmessage):

• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/imagedata-cloned-canvas-in-array.html:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/imagedata-cloned-canvas-in-array.js: Added.

(onmessage):

• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-dictionary-expected.txt: Added.
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-dictionary.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-null-in-array.html.
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-dictionary.js: Added.

(onmessage):

• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-null-expected.txt:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-null-in-array.html:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-null-in-array.js: Added.

(catch):

• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-null.html:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-null.js: Added.

(catch):

• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-undefined.html:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-undefined.js: Added.

(catch):

• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/setting-postMessage.html:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/setting-postMessage.js: Added.
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/structured-clone-imagedata.html:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/structured-clone-imagedata.js: Added.

(onmessage):

• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/structured-clone-message.html:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/structured-clone-message.js: Added.

(i.catch):

• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/w3c-import.log:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/w3c-import.log:
• web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/name/getting.html:
• web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/name/getting.js: Added.

(switch):

• web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/name/setting.html:
• web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/name/setting.js: Added.
• web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/name/w3c-import.log:
• web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/onconnect.html:
• web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/onconnect.js: Added.

(catch):
(try.self.onconnect.handleEvent):
(f):

• web-platform-tests/workers/interfaces/SharedWorkerGlobalScope/w3c-import.log:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/close/incoming-message.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/close/incoming-message.js: Added.

(onmessage):

• web-platform-tests/workers/interfaces/WorkerGlobalScope/close/sending-messages.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/close/sending-messages.js: Added.
• web-platform-tests/workers/interfaces/WorkerGlobalScope/close/setInterval.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/close/setInterval.js: Added.

(interval1.setInterval):
(interval2.setInterval):

• web-platform-tests/workers/interfaces/WorkerGlobalScope/close/setTimeout.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/close/setTimeout.js: Added.

(x):

• web-platform-tests/workers/interfaces/WorkerGlobalScope/close/w3c-import.log:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/members.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/members.js: Added.
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect-expected.txt:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect-module-expected.txt: Added.
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect-module.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect.html.
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect-sharedworker-expected.txt: Added.
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect-sharedworker.html: Added.
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect.js: Added.
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/returns-same-object.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/returns-same-object.js: Added.
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/setting-members.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/setting-members.js: Added.

(catch):

• web-platform-tests/workers/interfaces/WorkerGlobalScope/location/w3c-import.log:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror-expected.txt:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.js: Added.

(onerror):
(x):

• web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/handled.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/handled.js: Added.

(onerror):
(x):

• web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/not-handled.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/not-handled.js: Added.

(onerror):
(x):

• web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/propagate-to-window-onerror.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/propagate-to-window-onerror.js: Added.

(x):

• web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/w3c-import.log:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/self.html:
• web-platform-tests/workers/interfaces/WorkerGlobalScope/self.js: Added.

(check):

• web-platform-tests/workers/interfaces/WorkerGlobalScope/w3c-import.log:
• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/001.html:
• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/001.js: Added.

(setTimeout):

• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/002.html:
• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/002.js: Added.

(t.setTimeout):

• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/003.html:
• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/003.js: Added.

(setInterval):

• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/004.html:
• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/004.js: Added.

(t.setInterval):

• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/005-expected.txt: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/005.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/001.html.
• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/005.js: Added.

(t.setInterval):

• web-platform-tests/workers/interfaces/WorkerUtils/WindowTimers/w3c-import.log:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/003.html:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/003.js: Added.

(catch):

• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/004.html:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/004.js: Added.

(catch):

• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/005.html:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/005.js: Added.

(catch):

• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/006.html:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/006.js: Added.

(catch):

• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/007.html:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/007.js: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/008.html:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/008.js: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/009.html:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/009.js: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/010.html:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/010.js: Added.

(catch):

• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/011.html:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/011.js: Added.

(catch):

• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/012.html:
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/012.js: Added.

(catch):

• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/1.headers: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/null.headers: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/undefined.headers: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/importScripts/w3c-import.log:
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/002.html:
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/002.js: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/003.html:
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/003.js: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/004.html:
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/004.js: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/005.html:
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/005.js: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/006.html:
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/006.js: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/007.html:
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/007.js: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/language.html:
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/language.js: Added.
• web-platform-tests/workers/interfaces/WorkerUtils/navigator/w3c-import.log:
• web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.js: Added.

(import_blob_url_test):

• web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/modules/dedicated-worker-import-csp-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-csp.html: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-data-url.any-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-data-url.any.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/modules/dedicated-worker-import-data-url.any.js: Added.

(import_data_url_test):

• web-platform-tests/workers/modules/dedicated-worker-import-data-url.any.worker-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-data-url.any.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/modules/dedicated-worker-import-failure-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-failure.html: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-meta-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-meta.html: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-referrer-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-import-referrer.html: Added.
• web-platform-tests/workers/modules/dedicated-worker-import.any-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-import.any.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/modules/dedicated-worker-import.any.js: Added.

(import_test):

• web-platform-tests/workers/modules/dedicated-worker-import.any.worker-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-import.any.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/modules/dedicated-worker-options-credentials-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-options-credentials.html: Added.
• web-platform-tests/workers/modules/dedicated-worker-options-credentials.html.headers: Added.
• web-platform-tests/workers/modules/dedicated-worker-options-type-expected.txt: Added.
• web-platform-tests/workers/modules/dedicated-worker-options-type.html: Added.
• web-platform-tests/workers/modules/resources/credentials.py: Added.

(main):

• web-platform-tests/workers/modules/resources/dynamic-import-and-then-static-import-worker.js: Added.
• web-platform-tests/workers/modules/resources/dynamic-import-given-url-worker.js: Added.
• web-platform-tests/workers/modules/resources/dynamic-import-remote-origin-credentials-checker-worker.sub.js: Added.
• web-platform-tests/workers/modules/resources/dynamic-import-remote-origin-referrer-checker-worker.sub.js: Added.
• web-platform-tests/workers/modules/resources/dynamic-import-remote-origin-script-worker.sub.js: Added.
• web-platform-tests/workers/modules/resources/dynamic-import-same-origin-credentials-checker-worker.js: Added.
• web-platform-tests/workers/modules/resources/dynamic-import-same-origin-referrer-checker-worker.js: Added.
• web-platform-tests/workers/modules/resources/dynamic-import-worker.js: Added.
• web-platform-tests/workers/modules/resources/empty-worker.js: Added.
• web-platform-tests/workers/modules/resources/eval-dynamic-import-worker.js: Added.
• web-platform-tests/workers/modules/resources/export-on-dynamic-import-script.js: Added.
• web-platform-tests/workers/modules/resources/export-on-dynamic-import-script.js.headers: Added.
• web-platform-tests/workers/modules/resources/export-on-load-script.js: Added.
• web-platform-tests/workers/modules/resources/export-on-load-script.js.headers: Added.
• web-platform-tests/workers/modules/resources/export-on-static-import-script.js: Added.
• web-platform-tests/workers/modules/resources/export-on-static-import-script.js.headers: Added.
• web-platform-tests/workers/modules/resources/import-meta-url-worker.js: Added.
• web-platform-tests/workers/modules/resources/import-scripts-worker.js: Added.

(catch):

• web-platform-tests/workers/modules/resources/import-test-cases.js: Added.
• web-platform-tests/workers/modules/resources/nested-dynamic-import-worker.js: Added.
• web-platform-tests/workers/modules/resources/nested-static-import-worker.js: Added.
• web-platform-tests/workers/modules/resources/new-worker-window.html: Added.
• web-platform-tests/workers/modules/resources/post-message-on-load-worker.js: Added.
• web-platform-tests/workers/modules/resources/referrer-checker.py: Added.

(main):

• web-platform-tests/workers/modules/resources/static-import-and-then-dynamic-import-worker.js: Added.
• web-platform-tests/workers/modules/resources/static-import-non-existent-script-worker.js: Added.
• web-platform-tests/workers/modules/resources/static-import-remote-origin-credentials-checker-worker.sub.js: Added.
• web-platform-tests/workers/modules/resources/static-import-remote-origin-referrer-checker-worker.sub.js: Added.
• web-platform-tests/workers/modules/resources/static-import-remote-origin-script-worker.sub.js: Added.
• web-platform-tests/workers/modules/resources/static-import-same-origin-credentials-checker-worker.js: Added.
• web-platform-tests/workers/modules/resources/static-import-same-origin-referrer-checker-worker.js: Added.
• web-platform-tests/workers/modules/resources/static-import-worker.js: Added.
• web-platform-tests/workers/modules/resources/w3c-import.log: Added.
• web-platform-tests/workers/modules/w3c-import.log: Added.
• web-platform-tests/workers/name-property-expected.txt:
• web-platform-tests/workers/name-property.html:
• web-platform-tests/workers/nested_worker.worker.js:

(async_test):

• web-platform-tests/workers/nested_worker_close_from_parent_worker-expected.txt: Added.
• web-platform-tests/workers/nested_worker_close_from_parent_worker.html: Added.
• web-platform-tests/workers/nested_worker_close_self.worker-expected.txt: Added.
• web-platform-tests/workers/nested_worker_close_self.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/nested_worker_close_self.worker.js: Added.

(async_test):

• web-platform-tests/workers/nested_worker_importScripts.worker-expected.txt: Added.
• web-platform-tests/workers/nested_worker_importScripts.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/nested_worker_importScripts.worker.js: Added.

(async_test):

• web-platform-tests/workers/nested_worker_sync_xhr.worker-expected.txt: Added.
• web-platform-tests/workers/nested_worker_sync_xhr.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/nested_worker_sync_xhr.worker.js: Added.

(async_test):

• web-platform-tests/workers/nested_worker_terminate_from_document-expected.txt: Added.
• web-platform-tests/workers/nested_worker_terminate_from_document.html: Added.
• web-platform-tests/workers/non-automated/navigator-onLine.html:
• web-platform-tests/workers/non-automated/navigator-onLine.js: Added.

(string_appeared_here.in.self.onmessage):
(else.e.ports.0.onmessage):
(else.onconnect):

• web-platform-tests/workers/non-automated/w3c-import.log:
• web-platform-tests/workers/opaque-origin.html:
• web-platform-tests/workers/semantics/encodings/001.html:
• web-platform-tests/workers/semantics/encodings/001.html.headers: Removed.
• web-platform-tests/workers/semantics/encodings/001.js: Added.
• web-platform-tests/workers/semantics/encodings/001.js.headers: Added.
• web-platform-tests/workers/semantics/encodings/002.html:
• web-platform-tests/workers/semantics/encodings/002.html.headers: Removed.
• web-platform-tests/workers/semantics/encodings/002.js: Added.

(onconnect):

• web-platform-tests/workers/semantics/encodings/002.js.headers: Added.
• web-platform-tests/workers/semantics/encodings/003.html:
• web-platform-tests/workers/semantics/encodings/003.js: Added.
• web-platform-tests/workers/semantics/encodings/004.html:
• web-platform-tests/workers/semantics/encodings/004.js: Added.

(onconnect):

• web-platform-tests/workers/semantics/encodings/w3c-import.log:
• web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt:
• web-platform-tests/workers/semantics/interface-objects/001.worker.js:
• web-platform-tests/workers/semantics/interface-objects/002.worker-expected.txt:
• web-platform-tests/workers/semantics/interface-objects/002.worker.js:
• web-platform-tests/workers/semantics/interface-objects/003.html:
• web-platform-tests/workers/semantics/interface-objects/003.js: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/003.html.

(onconnect):

• web-platform-tests/workers/semantics/interface-objects/004.html:
• web-platform-tests/workers/semantics/interface-objects/004.js: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/004.html.

(onconnect):

• web-platform-tests/workers/semantics/interface-objects/w3c-import.log:
• web-platform-tests/workers/semantics/multiple-workers/001.html:
• web-platform-tests/workers/semantics/multiple-workers/001.js: Added.

(string_appeared_here.in.self.onmessage):
(else.e.ports.0.onmessage):
(else.onconnect):

• web-platform-tests/workers/semantics/multiple-workers/002.html:
• web-platform-tests/workers/semantics/multiple-workers/002.js: Added.
• web-platform-tests/workers/semantics/multiple-workers/003.html:
• web-platform-tests/workers/semantics/multiple-workers/003.js: Added.

(location.hash.string_appeared_here.w2.onmessage):
(else.w3.onmessage):
(else):

• web-platform-tests/workers/semantics/multiple-workers/004-expected.txt:
• web-platform-tests/workers/semantics/multiple-workers/004.html:
• web-platform-tests/workers/semantics/multiple-workers/005.html:
• web-platform-tests/workers/semantics/multiple-workers/006.html:
• web-platform-tests/workers/semantics/multiple-workers/007.html:
• web-platform-tests/workers/semantics/multiple-workers/008-1.html:
• web-platform-tests/workers/semantics/multiple-workers/008.html:
• web-platform-tests/workers/semantics/multiple-workers/008.js: Added.

(onconnect):

• web-platform-tests/workers/semantics/multiple-workers/w3c-import.log:
• web-platform-tests/workers/semantics/navigation/001-1.html:
• web-platform-tests/workers/semantics/navigation/001-1.js: Added.

(setInterval):

• web-platform-tests/workers/semantics/navigation/w3c-import.log:
• web-platform-tests/workers/semantics/reporting-errors/001.html:
• web-platform-tests/workers/semantics/reporting-errors/001.js: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/semantics/reporting-errors/001.html.

(onerror):
(onconnect):

• web-platform-tests/workers/semantics/reporting-errors/002.html:
• web-platform-tests/workers/semantics/reporting-errors/002.js: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/semantics/reporting-errors/002.html.

(onconnect):

• web-platform-tests/workers/semantics/reporting-errors/003.html:
• web-platform-tests/workers/semantics/reporting-errors/003.js: Added.

(onconnect):

• web-platform-tests/workers/semantics/reporting-errors/004-1.html:
• web-platform-tests/workers/semantics/reporting-errors/004.html:
• web-platform-tests/workers/semantics/reporting-errors/004.js: Added.

(onconnect):

• web-platform-tests/workers/semantics/reporting-errors/w3c-import.log:
• web-platform-tests/workers/semantics/run-a-worker/001.html:
• web-platform-tests/workers/semantics/run-a-worker/001.js: Added.
• web-platform-tests/workers/semantics/run-a-worker/002.html:
• web-platform-tests/workers/semantics/run-a-worker/002.js: Added.

(onconnect):

• web-platform-tests/workers/semantics/run-a-worker/003.html:
• web-platform-tests/workers/semantics/run-a-worker/w3c-import.log:
• web-platform-tests/workers/semantics/structured-clone/w3c-import.log:
• web-platform-tests/workers/semantics/xhr/001.html:
• web-platform-tests/workers/semantics/xhr/001.js: Added.

(xhr.onreadystatechange):

• web-platform-tests/workers/semantics/xhr/002.html:
• web-platform-tests/workers/semantics/xhr/002.js: Added.
• web-platform-tests/workers/semantics/xhr/003.html:
• web-platform-tests/workers/semantics/xhr/003.js: Copied from LayoutTests/imported/w3c/web-platform-tests/workers/semantics/xhr/003.html.

(xhr.onreadystatechange):
(onconnect):

• web-platform-tests/workers/semantics/xhr/004.html:
• web-platform-tests/workers/semantics/xhr/004.js: Added.

(onconnect):

• web-platform-tests/workers/semantics/xhr/support/w3c-import.log:
• web-platform-tests/workers/semantics/xhr/w3c-import.log:
• web-platform-tests/workers/shared-worker-from-blob-url.window-expected.txt: Added.
• web-platform-tests/workers/shared-worker-from-blob-url.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker.html.
• web-platform-tests/workers/shared-worker-from-blob-url.window.js: Added.

(message_from_port):

• web-platform-tests/workers/support/SharedWorker-common.js: Added.

(generateError):
(event.ports.0.onmessage):
(onconnect):
(handleMessage):

• web-platform-tests/workers/support/SharedWorker-create-common.js: Added.

(createWorker.worker.port.onmessage):
(createWorker.worker.postMessage):
(createWorker):

• web-platform-tests/workers/support/SharedWorker-script-error.js: Added.

(event.ports.0.onmessage):
(onconnect):
(else.onerror):
(handleMessage):

• web-platform-tests/workers/support/Worker-common.js: Added.

(onmessage):

• web-platform-tests/workers/support/Worker-create-common.js: Added.

(createWorker):

• web-platform-tests/workers/support/Worker-messageport.js: Added.

(onmessage):
(pingBack):

• web-platform-tests/workers/support/Worker-run-forever.js: Added.
• web-platform-tests/workers/support/Worker-structure-message.js: Added.

(self.onmessage):

• web-platform-tests/workers/support/Worker-termination-with-port-messages.js: Added.

(echo):
(onmessage):

• web-platform-tests/workers/support/Worker-thread-multi-port.js: Added.

(onmessage):
(testPassed):
(testFailed):

• web-platform-tests/workers/support/Worker-timeout-cancel-order.js: Added.

(t1.setTimeout):
(setTimeout):

• web-platform-tests/workers/support/Worker-timeout-decreasing-order.js: Added.

(setTimeout):

• web-platform-tests/workers/support/Worker-timeout-increasing-order.js: Added.

(setTimeout):

• web-platform-tests/workers/support/WorkerGlobalScope-close.js: Added.

(else.messagePort.onmessage):
(onmessage):

• web-platform-tests/workers/support/WorkerSendingPerformanceNow.js: Added.

(calcResponse):
(self.onmessage):
(port.onmessage):

• web-platform-tests/workers/support/iframe_sw_dataUrl.html: Added.
• web-platform-tests/workers/support/importScripts-1.js: Added.
• web-platform-tests/workers/support/importScripts-2.js: Added.
• web-platform-tests/workers/support/importScripts-3.js: Added.
• web-platform-tests/workers/support/imported_script.py: Added.

(main):

• web-platform-tests/workers/support/invalidScript.js: Added.
• web-platform-tests/workers/support/name.js:

(test):

• web-platform-tests/workers/support/parent_of_nested_worker.js: Added.

(try.worker.onmessage):
(catch):

• web-platform-tests/workers/support/sync_xhr.js: Added.

(catch):

• web-platform-tests/workers/support/sync_xhr_target.xml: Added.
• web-platform-tests/workers/support/throw-on-message-Worker.js: Added.

(self.onerror):
(self.onmessage):

• web-platform-tests/workers/support/w3c-import.log:
• web-platform-tests/workers/w3c-import.log:
• web-platform-tests/workers/worker-performance.worker-expected.txt:

LayoutTests:

• TestExpectations:
• tests-options.json:

9:06 AM Changeset in webkit [249718] by youenn@apple.com

• 11 edits in trunk

Remove MediaStreamPrivate::scheduleDeferredTask
​https://bugs.webkit.org/show_bug.cgi?id=200975
LayoutTests/imported/w3c:

Reviewed by Eric Carlson.

• web-platform-tests/mediacapture-streams/MediaStream-finished-add.https-expected.txt:

Source/WebCore:

Reviewed by Eric Carlson.

All calls to scheduleDeferredTask are done on the main thread.
This was initially done to trigger less reconfiguration.
But this makes the implementation significantly more complex.

For instance, we have to wait for the document to update its media state
and send it to UIProcess before calling the allow completion handler.

Covered by existing tests.

• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
Make sure to update the document media state once the tracks have been added, similarly to the other constructor.
This ensures the document media state is computed with the new MediaStreamTrack.

• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::isMediaStreamCorrectlyStarted):
(WebCore::UserMediaRequest::allow):
(WebCore::UserMediaRequest::stop):
(WebCore::UserMediaRequest::mediaStreamDidFail):

• Modules/mediastream/UserMediaRequest.h:
• page/MediaProducer.h:

(WebCore::MediaProducer::isCapturing):
Make sure to include getDisplayMedia as part of capture check.

• platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::trackMutedChanged):
(WebCore::MediaStreamPrivate::trackEnabledChanged):
(WebCore::MediaStreamPrivate::trackStarted):
(WebCore::MediaStreamPrivate::trackEnded):

• platform/mediastream/MediaStreamPrivate.h:

LayoutTests:

<rdar://problem/55113418>

Reviewed by Eric Carlson.

• fast/mediastream/media-stream-track-source-failure.html:

page mediaState may be updated synchronously.
Get it just before failing a capture track to verify that the state is being updated after the track is stopped.

9:06 AM Changeset in webkit [249717] by Alan Coon

• 1 edit in branches/safari-608.2.11.1-branch/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp

Unreviewed build fix. rdar://problem/55198064

8:42 AM Changeset in webkit [249716] by Chris Dumez

• 20 edits in trunk/LayoutTests

Unreviewed, unskip / rebaseline a few service worker tests
​https://bugs.webkit.org/show_bug.cgi?id=201626

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/client-navigate.https-expected.txt:
• web-platform-tests/service-workers/service-worker/embed-and-object-are-not-intercepted.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video-cache.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video-with-range-request.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video.https-expected.txt:
• web-platform-tests/service-workers/service-worker/import-module-scripts.https-expected.txt:
• web-platform-tests/service-workers/service-worker/import-scripts-redirect.https-expected.txt:
• web-platform-tests/service-workers/service-worker/multipart-image.https-expected.txt:
• web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:
• web-platform-tests/service-workers/service-worker/performance-timeline.https-expected.txt:
• web-platform-tests/service-workers/service-worker/ready.https-expected.txt:
• web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https-expected.txt:
• web-platform-tests/service-workers/service-worker/sandboxed-iframe-fetch-event.https-expected.txt:
• web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https-expected.txt:
• web-platform-tests/service-workers/service-worker/update-not-allowed.https-expected.txt:
• web-platform-tests/service-workers/service-worker/update.https-expected.txt:
• web-platform-tests/service-workers/service-worker/worker-client-id.https-expected.txt:
• web-platform-tests/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https-expected.txt:

LayoutTests:

• TestExpectations:

8:27 AM Changeset in webkit [249715] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Audio sometimes fail to capture in WebRTC
​https://bugs.webkit.org/show_bug.cgi?id=180748
<rdar://problem/36032346>

Reviewed by Eric Carlson.

In some cases, Safari is not receiving unsuspend notifications.
In that case, the capture unit might stay in suspend state forever.
To work around that, we force to unsuspend whenever there is a new capture happening.
This will make it so that reloading the page will unsuspend the page.

Manually tested by triggering Siri, starting to use the microphone and quickly going back to a capturing page.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioSharedUnit::provideSpeakerData):
When suspension happens, the buffer size might change.
Since this is only an issue if there are some references data, we now do not fail the capture when there
is no reference data.
(WebCore::CoreAudioSharedUnit::resume):
(WebCore::CoreAudioSharedUnit::prepareForNewCapture):
Make sure to start with a clean slate by setting suspend state to false for the shared unit.
And failing all previous sources in case we are going back from suspension.
(WebCore::CoreAudioSharedUnit::startInternal):
(WebCore::CoreAudioCaptureSourceFactory::audioCaptureDeviceManager):
(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):

8:10 AM Changeset in webkit [249714] by Adrian Perez de Castro

• 8 edits in trunk/Source

[GTK][WPE] Fixes for non-unified builds after r249022
​https://bugs.webkit.org/show_bug.cgi?id=201610

Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests needed.

• fileapi/NetworkSendQueue.h: Add missing inclusion of wtf/WeakPtr.h; add the namespace to WTF::WeakPtr

which is needed because there is no "using" clause.

• inspector/InspectorInstrumentation.cpp: Add missing inclusion of the PageDOMDebuggerAgent.h header.
• inspector/agents/WebDebuggerAgent.cpp: Add missing inclusion of the ScriptExecutionContext.h header.
• inspector/agents/page/PageDOMDebuggerAgent.cpp: Add missing inclusion of the InstrumentingAgents.h header.

Source/WebKit:

• NetworkProcess/NetworkCORSPreflightChecker.h: Add missing inclusion of the WebPageProxyIdentifier.h header.
• NetworkProcess/NetworkLoadChecker.h: Add missing inclusion of the WebPageProxyIdentifier.h header.

7:45 AM Changeset in webkit [249713] by commit-queue@webkit.org

• 4 edits
  13 adds in trunk/LayoutTests

Ensure tests for legacy features are in LayoutTests/mathml
​https://bugs.webkit.org/show_bug.cgi?id=201604

Patch by Frederic Wang <​fwang@igalia.com> on 2019-09-10
Reviewed by Rob Buis.

This patch copies MathML WPT tests verifying legacy support for features removed from MathML
Core. These tests will be overriden or removed in a future WPT synchronization, so we need
to keep local copies to check these legacy features when the "MathML Core" option is
disabled.

• TestExpectations: Copy expectation.
• mathml/non-core/frac-linethickness-001-expected.html: Added.
• mathml/non-core/frac-linethickness-001.html: Added.
• mathml/non-core/frac-linethickness-002-expected.html: Added.
• mathml/non-core/frac-linethickness-002.html: Added.
• mathml/non-core/frac-numalign-denomalign-001-expected.html: Added.
• mathml/non-core/frac-numalign-denomalign-001.html: Added.
• mathml/non-core/lengths-1-expected.html: Added.
• mathml/non-core/lengths-1.html: Added.
• mathml/non-core/lengths-2-expected.html: Added.
• mathml/non-core/lengths-2.html: Added.
• mathml/non-core/lengths-3-expected.txt: Added.
• mathml/non-core/lengths-3.html: Added.
• platform/gtk/TestExpectations: Copy expectation.
• platform/win/TestExpectations: Add failure expectations.

6:52 AM Changeset in webkit [249712] by youenn@apple.com

• 4 edits in trunk/Source/WebKit

UserMediaProcessManager is revoking sandbox extensions too aggressively
​https://bugs.webkit.org/show_bug.cgi?id=201638

Reviewed by Eric Carlson.

Sandbox revocation was sometimes happening when a page is being closed while another page from the same process is starting capture.
In that case, revocation might happen while it should not.
To prevent this, we do not revoke sandbox extensions if there are pending captures for a page of the process.
Whenever a page does not have any pending capture, sandbox extensions may be revoked.

Covered by OnDeviceChangeCrash API test in debug mode.

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):

• UIProcess/UserMediaPermissionRequestManagerProxy.h:

(WebKit::UserMediaPermissionRequestManagerProxy::hasPendingCapture const):

• UIProcess/UserMediaProcessManager.cpp:

(WebKit::UserMediaProcessManager::revokeSandboxExtensionsIfNeeded):

5:47 AM Changeset in webkit [249711] by Michael Catanzaro

• 2 edits in trunk/Tools

Unreviewed, remove myself from watchlists

• Scripts/webkitpy/common/config/watchlist:

5:04 AM Changeset in webkit [249710] by youenn@apple.com

• 5 edits
  2 adds in trunk

Add support to RTCDataChannel.send(Blob)
​https://bugs.webkit.org/show_bug.cgi?id=201377

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCDataChannel-send-blob-order-expected.txt: Added.
• web-platform-tests/webrtc/RTCDataChannel-send-blob-order.html: Added.
• web-platform-tests/webrtc/RTCDataChannel-send-expected.txt:

Source/WebCore:

Make use of NetworkSendQueue to enqueue and send properly messages.
Test: imported/w3c/web-platform-tests/webrtc/RTCDataChannel-send-blob-order.html

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::createMessageQueue):
(WebCore::RTCDataChannel::RTCDataChannel):
(WebCore::RTCDataChannel::send):
(WebCore::RTCDataChannel::close):

• Modules/mediastream/RTCDataChannel.h:

3:53 AM Changeset in webkit [249709] by rniwa@webkit.org

• 12 edits
  2 adds in trunk

Option + arrow moves caret past whitespace on iOS
​https://bugs.webkit.org/show_bug.cgi?id=201575

Reviewed by Wenson Hsieh.

Source/WebCore:

The bug was caused by findNextWordFromIndex on iOS behaving differently from macOS and UIKit by skipping
trailing whitespace after a word when moving forward and not skipping leading whitespace when moving backward.

This patch introduces a new mode (StopAfterWord) of findNextWordFromIndex in iOS that better matches
the behavior of findNextWordFromIndex on macOS and UIKit, and use it in various modify* functions of
FrameSelection when the selection update is triggered by user.

The legacy mode (LegacyStopBeforeWord) is used in all other call sites as well as when modify* functions
are invoked from author scripts.

Test: editing/selection/ios/move-by-word-with-keyboard.html

• editing/FrameSelection.cpp:

(WebCore::nextWordWhitespaceModeInIOS): Added. A helper to convert EUserTriggered to NextWordModeInIOS.
(WebCore::FrameSelection::nextWordPositionForPlatform):
(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft):
(WebCore::FrameSelection::modifyExtendingBackward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::updateAppearance):

• editing/FrameSelection.h:
• editing/TextIterator.cpp:

(WebCore::SearchBuffer::isWordStartMatch const):

• editing/VisibleUnits.cpp:

(WebCore::previousWordPositionBoundary):
(WebCore::previousWordPosition):
(WebCore::nextWordPositionBoundary):
(WebCore::nextWordPosition):

• editing/VisibleUnits.h:
• platform/text/TextBoundaries.cpp:

(WebCore::findNextWordFromIndex):

• platform/text/TextBoundaries.h:
• platform/text/mac/TextBoundaries.mm:

(WebCore::findNextWordFromIndex): Added a new mode.

LayoutTests:

Added a new test for moving caret by word granularity on iOS.

• editing/selection/ios/move-by-word-with-keyboard-expected.txt: Added.
• editing/selection/ios/move-by-word-with-keyboard.html: Added.
• editing/selection/ios/select-non-editable-text-using-keyboard-expected.txt: Rebaselined.
• editing/selection/ios/select-non-editable-text-using-keyboard.html: Updated the expected

selection string due to the behavior change. Also fixed a bug that some test cases were
not waiting for a secondary selectionchange event that happens after an extra selection
update with character granularity introduced in r247524.

2:42 AM Changeset in webkit [249708] by ysuzuki@apple.com

• 20 edits
  2 deletes in trunk

[WebAssembly] Use StreamingParser in existing Wasm::BBQPlan
​https://bugs.webkit.org/show_bug.cgi?id=189043

Reviewed by Keith Miller.

JSTests:

The offset performing the validation becomes a bit different.
The offset 0 is nice since it is the starting offset of the Module header signature compared to the offset 8.

• wasm/js-api/version.js:

Source/JavaScriptCore:

This patch integrates Wasm::StreamingParser into the existing Wasm::BBQPlan.
And remove Wasm::ModuleParser. This patch paves the way to implementing Wasm streaming features by
using Wasm::StreamingParser.

Currently, we are not using streaming feature of StreamingParser. In a subsequent patch, we will
create a mechanism to pipe a chunk of data to streaming parser to enable WebAssembly.compileStreaming
and instantiateStreaming.

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• tools/JSDollarVM.cpp:

(JSC::WasmStreamingParser::WasmStreamingParser):

• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::parseAndCompileAir):

• wasm/WasmAirIRGenerator.h:
• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::parseAndCompile): Use FunctionData, it is good since it is more strongly typed.

• wasm/WasmB3IRGenerator.h:
• wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::BBQPlan):
(JSC::Wasm::BBQPlan::didReceiveFunctionData): Add a callback, which invokes validation.
(JSC::Wasm::BBQPlan::parseAndValidateModule): Use StreamingParser instead of old ModuleParser.
(JSC::Wasm::BBQPlan::compileFunctions):
(JSC::Wasm::BBQPlan::complete):

• wasm/WasmBBQPlan.h:
• wasm/WasmModuleParser.cpp: Removed.
• wasm/WasmModuleParser.h: Removed.
• wasm/WasmOMGForOSREntryPlan.cpp:

(JSC::Wasm::OMGForOSREntryPlan::work):

• wasm/WasmOMGPlan.cpp:

(JSC::Wasm::OMGPlan::work):

• wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::fail): Make fail function callable multiple times. The first error will be used.

• wasm/WasmSectionParser.cpp:

(JSC::Wasm::SectionParser::parseCode): Since the Code section is specially handled in StreamingParser, this code is never used.

• wasm/WasmStreamingParser.cpp:

(JSC::Wasm::StreamingParser::StreamingParser):
(JSC::Wasm::StreamingParser::parseCodeSectionSize):
(JSC::Wasm::StreamingParser::parseFunctionPayload):
(JSC::Wasm::StreamingParser::parseSectionPayload):
(JSC::Wasm::StreamingParser::finalize): Call client's callbacks at appropriate timings.

• wasm/WasmStreamingParser.h:

(JSC::Wasm::StreamingParserClient::didReceiveSectionData):
(JSC::Wasm::StreamingParserClient::didReceiveFunctionData):
(JSC::Wasm::StreamingParserClient::didFinishParsing): Add StreamingParserClient,
which has 3 callbacks right now. StreamingParser gets this client and call these callbacks
at appropriate timings.

• wasm/WasmValidate.cpp:

(JSC::Wasm::validateFunction):

• wasm/WasmValidate.h: Use FunctionData, it is good since it is more strongly typed.