Timeline

Sep 12, 2019:

11:15 PM Changeset in webkit [249825] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed debug build fix for GLib-based ports.

• platform/glib/UserAgentGLib.cpp: Add the HTTPParsers.h header

inclusion to bring in the isValidUserAgentHeaderValue() declaration as
required for an assertion check.

9:09 PM WPE edited by ChangSeok Oh

(diff)

7:03 PM Changeset in webkit [249824] by Fujii Hironori

• 2 edits in trunk/Source/WebKitLegacy/win

[Win][WK1] Invert Colors inverts a part of the viewport in high DPI
​https://bugs.webkit.org/show_bug.cgi?id=201719

Reviewed by Don Olmstead.

• WebView.cpp:

(WebView::paintWithDirect2D):
(WebView::paintIntoBackingStore):
Call gc.restore() after inverting the dirty rect.

5:59 PM Changeset in webkit [249823] by achristensen@apple.com

• 1414 edits
  346 adds
  37 deletes in trunk/Source/ThirdParty/ANGLE

Update ANGLE
​https://bugs.webkit.org/show_bug.cgi?id=201156

Patch by James Darpinian <James Darpinian> on 2019-09-12
Reviewed by Alex Christensen.

Update to 2019-9-9, revision 79ad0411911b2fc84834c3705f55707be9e4b498
I merged a bunch of changes to upstream ANGLE, to minimize the changes
necessary when updating ANGLE in WebKit.

• ANGLE.plist: Update commit hashes
• ANGLE.txt: Removed in favor of LICENSE
• ANGLE.xcodeproj/project.pbxproj: Updated with upstream changes Also, copy src/commit.h to id/commit.h during build
• CMakeLists.txt: Updated with upstream changes Also, copy src/commit.h to id/commit.h during build
• Compiler.cmake: Updated with upstream changes
• GLESv2.cmake: Updated with upstream changes
• adjust-angle-include-paths-rule: Support "" as well as <> for includes
• adjust-angle-include-paths.sh: Support "" as well as <> for includes
• changes.diff: Pared down to just legal disclaimer and warning flag changes
• update-angle.sh: Update ANGLE.plist

• Many other files modified/added/removed upstream

5:39 PM Changeset in webkit [249822] by commit-queue@webkit.org

• 61 edits
  1 delete in trunk/Source/WebCore

SVGLengthValue should use two enums for 'type' and 'mode' instead of one unsigned for 'units'
​https://bugs.webkit.org/show_bug.cgi?id=201663

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-09-12
Reviewed by Simon Fraser, Nikolas Zimmermann.

SVGLengthValue had one unsigned to store SVGLengthMode and SVGLengthType.
It used to allocate the least significant 4 bits of this unsigned to the
SVGLengthMode while it leaves the rest for SVGLengthType.

This will not be needed if SVGLengthMode and SVGLengthType are made of
size uint_8.

Also in this patch:

-- SVGLengthNegativeValuesMode is made enum class.

-- SVGLengthValue::blend() is moved to SVGLengthValue.cpp so we do not

need to include SVGLengthContext.h in SVGLengthValue.h.

-- SVGLengthType and SVGLengthMode are moved to SVGLengthValue.h. Instead

of having SVGLengthValue.h includes SVGLengthConttext.h, the opposite
will happen.

-- SVGAnimatedPropertyDescription.h is deleted. It should have been deleted

with the SVG tear off objects removal.

-- SVGPropertyTraits<SVGAngleValue> and SVGPropertyTraits<SVGLengthValue>

are deleted. They should have been deleted with SVGAnimatedType removal.

-- SVGLengthValue::lengthModeForAnimatedLengthAttribute() is deleted. It

was only called from SVGPropertyTraits<SVGLengthValue>.

• WebCore.xcodeproj/project.pbxproj:
• css/StyleResolver.h:
• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

• rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):

• rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):

• rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):

• rendering/svg/SVGPathData.cpp:

(WebCore::pathFromCircleElement):
(WebCore::pathFromEllipseElement):
(WebCore::pathFromRectElement):

• rendering/svg/SVGTextLayoutEngineBaseline.cpp:

(WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift const):

• rendering/svg/SVGTextLayoutEngineSpacing.cpp:

(WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):

• svg/LinearGradientAttributes.h:

(WebCore::LinearGradientAttributes::LinearGradientAttributes):

• svg/RadialGradientAttributes.h:

(WebCore::RadialGradientAttributes::RadialGradientAttributes):

• svg/SVGAngleValue.h:

(WebCore::SVGPropertyTraits<SVGAngleValue>::initialValue): Deleted.
(WebCore::SVGPropertyTraits<SVGAngleValue>::toString): Deleted.

• svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::parseAttribute):

• svg/SVGCircleElement.h:
• svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::parseAttribute):

• svg/SVGCursorElement.h:
• svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::parseAttribute):

• svg/SVGEllipseElement.h:
• svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::parseAttribute):

• svg/SVGFilterElement.h:
• svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute):

• svg/SVGFilterPrimitiveStandardAttributes.h:
• svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::parseAttribute):

• svg/SVGForeignObjectElement.h:
• svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::parseAttribute):

• svg/SVGImageElement.h:
• svg/SVGLength.h:

(WebCore::SVGLength::unitType const):
(WebCore::SVGLength::setValueForBindings):
(WebCore::SVGLength::newValueSpecifiedUnits):
(WebCore::SVGLength::convertToSpecifiedUnits):
(WebCore::SVGLength::unitType): Deleted.

• svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::valueForLength):
(WebCore::SVGLengthContext::convertValueToUserUnits const):
(WebCore::SVGLengthContext::convertValueFromUserUnits const):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToPercentage const):
(WebCore::SVGLengthContext::convertValueFromPercentageToUserUnits const):

• svg/SVGLengthContext.h:

(): Deleted.

• svg/SVGLengthList.h:

(WebCore::SVGLengthList::create):

• svg/SVGLengthValue.cpp:

(WebCore::lengthTypeToString):
(WebCore::parseLengthType):
(WebCore::primitiveTypeToLengthType):
(WebCore::lengthTypeToPrimitiveType):
(WebCore::SVGLengthValue::SVGLengthValue):
(WebCore::SVGLengthValue::construct):
(WebCore::SVGLengthValue::blend):
(WebCore::SVGLengthValue::fromCSSPrimitiveValue):
(WebCore::SVGLengthValue::toCSSPrimitiveValue):
(WebCore::SVGLengthValue::setValueAsString):
(WebCore::SVGLengthValue::valueAsString const):
(WebCore::SVGLengthValue::valueForBindings const):
(WebCore::SVGLengthValue::setValue):
(WebCore::SVGLengthValue::convertToSpecifiedUnits):
(WebCore::storeUnit): Deleted.
(WebCore::extractMode): Deleted.
(WebCore::extractType): Deleted.
(WebCore::SVGLengthValue::operator== const): Deleted.
(WebCore::SVGLengthValue::operator!= const): Deleted.
(WebCore::SVGLengthValue::unitType const): Deleted.
(WebCore::SVGLengthValue::unitMode const): Deleted.
(WebCore::SVGLengthValue::valueAsPercentage const): Deleted.
(WebCore::SVGLengthValue::newValueSpecifiedUnits): Deleted.
(WebCore::SVGLengthValue::lengthModeForAnimatedLengthAttribute): Deleted.

• svg/SVGLengthValue.h:

(WebCore::SVGLengthValue::lengthType const):
(WebCore::SVGLengthValue::lengthMode const):
(WebCore::SVGLengthValue::isZero const):
(WebCore::SVGLengthValue::isRelative const):
(WebCore::SVGLengthValue::valueAsPercentage const):
(WebCore::SVGLengthValue::valueInSpecifiedUnits const):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::SVGLengthValue::blend const): Deleted.
(WebCore::SVGPropertyTraits<SVGLengthValue>::initialValue): Deleted.
(WebCore::SVGPropertyTraits<SVGLengthValue>::parse): Deleted.
(WebCore::SVGPropertyTraits<SVGLengthValue>::toString): Deleted.

• svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::parseAttribute):

• svg/SVGLineElement.h:
• svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::parseAttribute):

• svg/SVGLinearGradientElement.h:
• svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::parseAttribute):

• svg/SVGMarkerElement.h:
• svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::parseAttribute):

• svg/SVGMaskElement.h:
• svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::parseAttribute):

• svg/SVGPatternElement.h:
• svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::parseAttribute):

• svg/SVGRadialGradientElement.h:
• svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::parseAttribute):

• svg/SVGRectElement.h:
• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::hasIntrinsicWidth const):
(WebCore::SVGSVGElement::hasIntrinsicHeight const):
(WebCore::SVGSVGElement::intrinsicWidth const):
(WebCore::SVGSVGElement::intrinsicHeight const):

• svg/SVGSVGElement.h:
• svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::parseAttribute):
(WebCore::SVGTextContentElement::textLengthAnimated):

• svg/SVGTextContentElement.h:
• svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::parseAttribute):

• svg/SVGTextPathElement.h:
• svg/SVGTextPositioningElement.h:
• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::parseAttribute):

• svg/SVGUseElement.h:
• svg/properties/SVGAnimatedPropertyAccessorImpl.h:
• svg/properties/SVGAnimatedPropertyDescription.h: Removed.
• svg/properties/SVGAnimationAdditiveListFunctionImpl.h:

(WebCore::SVGAnimationLengthListFunction::animate):

• svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:

(WebCore::SVGAnimationLengthFunction::animate):

• svg/properties/SVGValuePropertyAnimatorImpl.h:
• svg/properties/SVGValuePropertyListAnimatorImpl.h:

5:01 PM Changeset in webkit [249821] by Chris Dumez

• 4 edits in trunk

Node.replaceChild()'s pre-replacement validations are not done in the right order
​https://bugs.webkit.org/show_bug.cgi?id=201741

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

• web-platform-tests/dom/nodes/Node-replaceChild-expected.txt:

Source/WebCore:

Node.replaceChild()'s pre-replacement validations are not done in the right order (spec order):

• ​https://dom.spec.whatwg.org/#concept-node-replace

In particular, we do not do check 3 (If child’s parent is not parent, then throw a
"NotFoundError" DOMException.) at the right time, because we were making this check
*after* checkPreReplacementValidity(), instead of *during*.

No new tests, rebaselined existing test.

• dom/ContainerNode.cpp:

(WebCore::checkAcceptChild):
(WebCore::ContainerNode::ensurePreInsertionValidity):
(WebCore::checkPreReplacementValidity):
(WebCore::ContainerNode::replaceChild):

4:59 PM Changeset in webkit [249820] by Ryan Haddad

• 36 edits in trunk/Source

Unreviewed, rolling out r249801.

Caused two servier worker layout tests to become flaky.

Reverted changeset:

"Use WebProcess processIdentifier to identify Service Worker
connections"
​https://bugs.webkit.org/show_bug.cgi?id=201459
​https://trac.webkit.org/changeset/249801

3:55 PM Changeset in webkit [249819] by Ryan Haddad

• 1 edit
  3 adds in trunk/LayoutTests

Unreviewed test gardening, rebaseline inspector/model/remote-object.html for WK1 after r249808.

• platform/mac-wk1/inspector/model/remote-object-expected.txt: Added.

3:46 PM Changeset in webkit [249818] by Chris Dumez

• 9 edits in trunk/Source/WebKit

Pass sessionID to WebProcess with other WebProcessDataStoreParameters
​https://bugs.webkit.org/show_bug.cgi?id=201730

Reviewed by Alex Christensen.

Pass sessionID to WebProcess with other WebProcessDataStoreParameters and store
it on the WebProcess object. In follow-up patches, I will use this sessionID
more and leverage the fact that we have one sessionID per Webprocess to simplify
the WebKit2-layer code.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• Shared/WebProcessDataStoreParameters.h:

(WebKit::WebProcessDataStoreParameters::encode const):
(WebKit::WebProcessDataStoreParameters::decode):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::tryTakePrewarmedProcess):
(WebKit::WebProcessPool::webProcessDataStoreParameters):
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::sendWebProcessDataStoreParameters): Deleted.

• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::setWebsiteDataStore):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setWebsiteDataStoreParameters):

• WebProcess/WebProcess.h:

(WebKit::WebProcess::sessionID const):

3:12 PM Changeset in webkit [249817] by Chris Dumez

• 21 edits in trunk

[WKTR] Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED()
​https://bugs.webkit.org/show_bug.cgi?id=201546

Reviewed by Alex Christensen.

Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED() from WebKitTestRunner as it does not do
the right thing for WebKit2 and tests have been rewritten to not use it.

Source/WebCore:

• page/PageGroup.cpp:

(WebCore::PageGroup::addPage):
(WebCore::PageGroup::setSessionIDForTesting): Deleted.

• page/PageGroup.h:

(): Deleted.

Source/WebKit:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession): Deleted.

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetPrivateBrowsingEnabled): Deleted.

• WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled): Deleted.

• WebProcess/InjectedBundle/InjectedBundle.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureLegacyPrivateBrowsingSessionInNetworkProcess): Deleted.

• WebProcess/WebProcess.h:
• WebProcess/WebStorage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::setSessionIDForTesting):

Tools:

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED): Deleted.

• WebKitTestRunner/InjectedBundle/TestRunner.h:

2:47 PM Changeset in webkit [249816] by sbarati@apple.com

• 3 edits in trunk/Source/WebCore

[WHLSL] Slim down WSLMatrix and inline constructors in native code
​https://bugs.webkit.org/show_bug.cgi?id=201568

Reviewed by Robin Morisset.

Before, our WSL Matrix in MSL had templates to figure out how we're
constructing it. For example, with a list of elements, or a list of
columns. However, we can remove this template code since when we're
emitting Metal code, we know exactly how we're constructing the WSL
matrix. So the NativeFunctionWriter now inlines the proper stores
into the WSLMatrix elements.

This patch speeds up Metal compile times in boids by ~4ms (16%) with
a p-value of 0.0001.

Covered by existing tests.

• Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.cpp:

(WebCore::WHLSL::Metal::metalCodePrologue):

• Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.cpp:

(WebCore::WHLSL::Metal::inlineNativeFunction):

1:18 PM Changeset in webkit [249815] by Simon Fraser

• 7 edits in trunk/Source

REGRESSION (iOS 13): Top fixed element on apple.com flickers in size while pinching in
​https://bugs.webkit.org/show_bug.cgi?id=201668
rdar://problem/51934041

Reviewed by Frédéric Wang.

Source/WebCore:

When computing the new layout viewport rect in ScrollingTreeFrameScrollingNode, use
"StickToDocumentBounds" mode, not "StickToViewportBounds", because otherwise we'll compute
a layout viewport that has negative top/left offsets which causes fixed elements to jump outside
the viewport. The only code that should be moving things outside the viewport (a temporary effect
that happens when pinching) is the 'isBelowMinimumScale' path in WebPageProxy::computeCustomFixedPositionRect().

With this change ScrollingTreeFrameScrollingNode no longer needs m_behaviorForFixed; it can be removed later.

Not currently testable, since it involves pinching in past minimum zoom and transients state.

• page/scrolling/ScrollingTreeFrameScrollingNode.cpp:

(WebCore::ScrollingTreeFrameScrollingNode::layoutViewportForScrollPosition const):

Source/WebKit:

The UI process can have transient state that pushes scrolling-tree-managed layers into custom
locations while pinch-zooming. We have to apply this state both when the visible rects
in the UI process change (existing code in -[WKContentView didUpdateVisibleRect:...]) and when
we get new layers from the web process (added in RemoteLayerTreeDrawingAreaProxy::commitLayerTree()
in this patch).

Move some code into WebPageProxy to create functions that we can call from both places.

For manual testing, visit a page with fixed banners, pinch in slightly, then pinch out and,
while keeping your fingers down, move the contents around.

• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView didUpdateVisibleRect:unobscuredRect:contentInsets:unobscuredRectInScrollViewCoordinates:obscuredInsets:unobscuredSafeAreaInsets:inputViewBounds:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::unconstrainedLayoutViewportRect const):
(WebKit::WebPageProxy::adjustLayersForLayoutViewport):

1:10 PM Changeset in webkit [249814] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Unreviewed test gardening, rebaseline inspector/model/remote-object.html after r249808.

• inspector/model/remote-object-expected.txt:

12:36 PM Changeset in webkit [249813] by Wenson Hsieh

• 3 edits
  2 adds in trunk

[Cocoa] Text indicator for an image link on the front page of apple.com looks wrong
​https://bugs.webkit.org/show_bug.cgi?id=201724
<rdar://problem/54622894>

Reviewed by Tim Horton.

Source/WebCore:

When computing the bounds of the range (<a>, 0) to (<a>, 1) for a text indicator snapshot where <a> is a link
with a single non-breaking whitespace character, we currently use the text rect of the single space. This leads
to a confusing text indicator, as the resulting snapshot is a tiny blank square in the top left corner of the
link. This problem manifests when starting a drag or showing the system context menu on iOS, or force clicking
or three-finger tapping to show a preview on macOS.

To address this scenario, tweak the heuristic in the case where the text indicator option
TextIndicatorOptionUseBoundingRectAndPaintAllContentForComplexRanges is specified, such that we consider a range
containing only text with whitespaces to be "complex"; additionally, instead of falling back to the range's
bounding rect (which in this case is still tiny), fall back to the common ancestor container's bounding rect,
which encompasses not only the text inside the range but also the element containing the range (in this case,
the anchor element).

Test: fast/text-indicator/text-indicator-empty-link.html

• page/TextIndicator.cpp:

(WebCore::containsOnlyWhiteSpaceText):

Add a helper to determine whether a Range is comprised only of rendered text that only contains whitespace
characters.

(WebCore::initializeIndicator):

See ChangeLog entry above for more detail.

LayoutTests:

Add a new layout test to exercise this scenario.

• fast/text-indicator/text-indicator-empty-link-expected.txt: Added.
• fast/text-indicator/text-indicator-empty-link.html: Added.

9:55 AM Changeset in webkit [249812] by beidson@apple.com

• 4 edits in trunk

PDF exporting on iOS should include URL rects.
<rdar://problem/54900133> and ​https://bugs.webkit.org/show_bug.cgi?id=201693

Reviewed by Tim Horton.

Source/WebCore:

Turns out that PDF exporting on iOS works fine.

Tracking back through history it was disabled at least pre-2014.

It was almost certainly disabled because it didn't work way back then,
but it works great now.

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setURLForRect): Remove the iOS platform exclusion.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:

(TestWebKitAPI::TEST): Enable on iOS.

9:39 AM Changeset in webkit [249811] by Chris Dumez

• 64 edits
  4 moves
  26 adds
  5 deletes in trunk/LayoutTests

Re-sync dom web-platform-tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=201697

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Re-sync dom web-platform-tests from upstream ab331d317554a3ba61.

• web-platform-tests/dom/META.yml: Added.
• web-platform-tests/dom/OWNERS: Removed.
• web-platform-tests/dom/abort/w3c-import.log:
• web-platform-tests/dom/collections/HTMLCollection-as-proto-length-get-throws-expected.txt: Removed.
• web-platform-tests/dom/collections/HTMLCollection-as-proto-length-get-throws.html: Removed.
• web-platform-tests/dom/collections/HTMLCollection-as-prototype-expected.txt: Added.
• web-platform-tests/dom/collections/HTMLCollection-as-prototype.html: Added.
• web-platform-tests/dom/collections/HTMLCollection-delete-expected.txt: Added.
• web-platform-tests/dom/collections/HTMLCollection-delete.html: Added.
• web-platform-tests/dom/collections/w3c-import.log:
• web-platform-tests/dom/historical-expected.txt:
• web-platform-tests/dom/historical.html:
• web-platform-tests/dom/idlharness.any.html: Added.
• web-platform-tests/dom/idlharness.any.js: Added.
• web-platform-tests/dom/idlharness.any.worker-expected.txt: Added.
• web-platform-tests/dom/idlharness.any.worker.html: Added.
• web-platform-tests/dom/idlharness.window-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt.
• web-platform-tests/dom/idlharness.window.html: Added.
• web-platform-tests/dom/idlharness.window.js: Added.
• web-platform-tests/dom/interfaces.html: Removed.
• web-platform-tests/dom/lists/DOMTokenList-coverage-for-attributes-expected.txt:
• web-platform-tests/dom/lists/DOMTokenList-coverage-for-attributes.html:
• web-platform-tests/dom/lists/w3c-import.log:
• web-platform-tests/dom/nodes/Comment-Text-constructor.js:
• web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
• web-platform-tests/dom/nodes/Document-Element-getElementsByTagName.js:

(test_getElementsByTagName):

• web-platform-tests/dom/nodes/Document-Element-getElementsByTagNameNS.js:

(test_getElementsByTagNameNS):

• web-platform-tests/dom/nodes/Document-URL-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-URL.sub-expected.txt.
• web-platform-tests/dom/nodes/Document-URL.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-URL.sub.html.
• web-platform-tests/dom/nodes/Document-constructor-expected.txt:
• web-platform-tests/dom/nodes/Document-constructor-svg.svg: Removed.
• web-platform-tests/dom/nodes/Document-constructor.html:
• web-platform-tests/dom/nodes/Document-contentType/contentType/w3c-import.log:
• web-platform-tests/dom/nodes/Document-contentType/resources/w3c-import.log:
• web-platform-tests/dom/nodes/Document-contentType/support/w3c-import.log:
• web-platform-tests/dom/nodes/Document-createAttribute-expected.txt:
• web-platform-tests/dom/nodes/Document-createAttribute.html:
• web-platform-tests/dom/nodes/Document-createElement-expected.txt:
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/w3c-import.log:
• web-platform-tests/dom/nodes/Document-createElement-namespace.html:
• web-platform-tests/dom/nodes/Document-createElement.html:
• web-platform-tests/dom/nodes/Document-createElementNS-expected.txt:
• web-platform-tests/dom/nodes/Document-createElementNS.js:
• web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt: Added.
• web-platform-tests/dom/nodes/Document-createEvent.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.html.
• web-platform-tests/dom/nodes/Document-getElementsByClassName-expected.txt: Added.
• web-platform-tests/dom/nodes/Document-getElementsByClassName.html: Added.
• web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
• web-platform-tests/dom/nodes/Document-getElementsByTagNameNS-expected.txt:
• web-platform-tests/dom/nodes/Element-getElementsByClassName-expected.txt:
• web-platform-tests/dom/nodes/Element-getElementsByClassName.html:
• web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
• web-platform-tests/dom/nodes/Element-getElementsByTagNameNS-expected.txt:
• web-platform-tests/dom/nodes/Element-matches-expected.txt:
• web-platform-tests/dom/nodes/Element-webkitMatchesSelector-expected.txt:
• web-platform-tests/dom/nodes/Node-childNodes-expected.txt:
• web-platform-tests/dom/nodes/Node-childNodes.html:
• web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
• web-platform-tests/dom/nodes/Node-cloneNode.html:
• web-platform-tests/dom/nodes/Node-insertBefore-expected.txt:
• web-platform-tests/dom/nodes/Node-insertBefore.html:
• web-platform-tests/dom/nodes/Node-normalize-expected.txt:
• web-platform-tests/dom/nodes/Node-normalize.html:
• web-platform-tests/dom/nodes/Node-replaceChild-expected.txt:
• web-platform-tests/dom/nodes/Node-replaceChild.html:
• web-platform-tests/dom/nodes/Node-textContent.html:
• web-platform-tests/dom/nodes/ParentNode-children-expected.txt: Added.
• web-platform-tests/dom/nodes/ParentNode-children.html: Added.
• web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
• web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt:
• web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht.xht:
• web-platform-tests/dom/nodes/ParentNode-querySelector-All.html:
• web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt: Added.
• web-platform-tests/dom/nodes/aria-element-reflection.tentative.html: Added.
• web-platform-tests/dom/nodes/attributes.html:
• web-platform-tests/dom/nodes/pre-insertion-checks.js: Added.

(getNonParentNodes):
(getNonInsertableNodes):
(getNonDocumentParentNodes):
(test):

• web-platform-tests/dom/nodes/productions.js:
• web-platform-tests/dom/nodes/query-target-in-load-event-expected.txt: Added.
• web-platform-tests/dom/nodes/query-target-in-load-event.html: Added.
• web-platform-tests/dom/nodes/query-target-in-load-event.part.html: Added.
• web-platform-tests/dom/nodes/remove-and-adopt-crash-expected.txt: Added.
• web-platform-tests/dom/nodes/remove-and-adopt-crash.html: Added.
• web-platform-tests/dom/nodes/rootNode-expected.txt:
• web-platform-tests/dom/nodes/rootNode.html:
• web-platform-tests/dom/nodes/selectors.js:
• web-platform-tests/dom/nodes/w3c-import.log:
• web-platform-tests/dom/ranges/Range-intersectsNode-2-expected.txt: Added.
• web-platform-tests/dom/ranges/Range-intersectsNode-2.html: Added.
• web-platform-tests/dom/ranges/w3c-import.log:
• web-platform-tests/dom/w3c-import.log:

LayoutTests:

• TestExpectations:
• platform/mac-wk2/imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
• tests-options.json:

8:53 AM WebKitGTK/2.26.x edited by Adrian Perez de Castro

(diff)

8:33 AM Changeset in webkit [249810] by Adrian Perez de Castro

• 9 edits in trunk

[GTK][WPE] webkit_settings_set_user_agent() allows content forbidden in HTTP headers
​https://bugs.webkit.org/show_bug.cgi?id=201077

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Add a function to validate whether a string contains a valid value
which can be used in a HTTP User-Agent header.

Covered by new WebCore API test HTTPParsers.ValidateUserAgentValues.

• platform/glib/UserAgentGLib.cpp:

(WebCore::standardUserAgent): Assert that the returned string is a valid User-Agent.
(WebCore::standardUserAgentForURL): Ditto.

• platform/network/HTTPParsers.cpp: Added a series of helper functions which skip over

characters of a string, which can be used to scan over the different elements of an
User-Agent value; all of them receive the position from the input string where to start
scanning, updating it to the position right after the scanned item (this follow the
convention already in use by other functions in the source file). Each of them has
been annotated with the RFC number and section which contains the definition of the
scanned item, and the corresponding BNF rules to make the code easier to follow.
(WebCore::skipWhile): Added.
(WebCore::isVisibleCharacter): Added.
(WebCore::isOctectInFieldContentCharacter): Added.
(WebCore::isCommentTextCharacter): Added.
(WebCore::isHTTPTokenCharacter): Added.
(WebCore::isValidHTTPToken): Refactored to use the new isHTTPTokenCharacter()
helper function instead of having the test inside the loop.
(WebCore::skipCharacter): Added.
(WebCore::skipQuotedPair): Added.
(WebCore::skipComment): Added.
(WebCore::skipHTTPToken): Added.
(WebCore::skipUserAgentProduct): Added.
(WebCore::isValidUserAgentHeaderValue): Added.

• platform/network/HTTPParsers.h: Add prototype for isValidUserAgentHeaderValue().

Source/WebKit:

• UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_set_user_agent): Check the passed string using the new
WebCore::isValidUserAgentHeaderValue() function, and return early without
changing the setting if the string is not usable in the User-Agent HTTP
header.

Tools:

• TestWebKitAPI/CMakeLists.txt: Add missing HTTPParsers.cpp to be built into TestWebCore.
• TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:

(TestWebKitAPI::TEST): Add tests for WebCore::isValidUserAgentHeaderValue().

8:09 AM Changeset in webkit [249809] by Devin Rousso

• 3 edits in trunk/LayoutTests

REGRESSION? (r249786): inspector/canvas/context-attributes.html is failing on macOS WK1
​https://bugs.webkit.org/show_bug.cgi?id=201714
<rdar://problem/55290473>

Reviewed by Joseph Pecoraro.

• inspector/canvas/context-attributes.html:
• inspector/canvas/context-attributes-expected.txt:

8:04 AM Changeset in webkit [249808] by mark.lam@apple.com

• 54 edits
  4 adds in trunk

Harden JSC against the abuse of runtime options.
​https://bugs.webkit.org/show_bug.cgi?id=201597
<rdar://problem/55167068>

Reviewed by Filip Pizlo.

JSTests:

Remove the call to forceGCSlowPaths(). This utility function will be removed.
The modern way to set the required option is to use @ requireOptions.

• stress/ftl-try-catch-oom-error-lazy-slow-path.js:

Source/JavaScriptCore:

Linux parts contributed by Carlos Garcia Campos <​cgarcia@igalia.com>.

1. Introduce a JSC::Config struct that will be protected as ReadOnly once the first VM instance is constructed. The end of the VM constructor calls Config::permanentlyFreeze() which will make the Config ReadOnly.

Note: this is currently only supported for OS(DARWIN) and OS(LINUX).
OS(WINDOWS) will need to implement some missing pieces before it can enable
this hardening (see FIXME in JSCConfig.cpp).

The hardening strategy here is to put immutable global values into the Config.
Any modifications that need to be made to these values must be done before the
first VM instance is done instantiating. This ensures that no script will
ever run while the Config is still writable.

Also, the policy for this hardening is that a process is opted in by default.
If there's a valid need to disable this hardening (e.g. for some test
environments), the relevant process will need to opt itself out by calling
Config::configureForTesting().

The jsc shell, WK2 UI and WebContent processes are opted in by default.
Only test processes may be opt out.

2. Put all JSC::Options in the Config. This enforces the invariant that options can only be changed before we instantiate a VM. Once a VM is instantiated, the options are immutable.

3. Remove functionForceGCSlowPaths() from the jsc shell. Setting Options::forceGCSlowPaths this way is no longer allowed.

4. Re-factored the Options code (Options.h) into:
   • OptionEntry.h: the data structure that stores the option values.
   • OptionsList.h: the list of options.
   • Options.h: the Options singleton object which is the interface for accessing options.

Renamed the JSC_OPTIONS macro to FOR_EACH_JSC_OPTION, because
"FOR_EACH_JSC_OPTION(SET_OPTION_VALUE)" reads a lot better than
"JSC_OPTIONS(FOR_EACH_OPTION)".

5. Change testapi to call Config::configureForTesting(). Parts of testapi makes use of setting options in its tests. Hence, this hardening is disabled for testapi.

Note: the jsc shell does enable this hardening.

6. Put ExecutableAllocator's immutable globals in the Config.

7. RELEASE_ASSERT that restrictedOptionsEnabled in order to use the FunctionOverrides test utility.

8. RELEASE_ASSERT that Options::useDollarVM() is enabled in order to use the $vm.

We must RELEASE_ASSERT(Options::useDollarVM()) in all JSDollarVM functions
that are non-trivial at an eye's glance. This includes (but is not limited to):

constructors
create() factory
createStructure() factory
finishCreation()
HOST_CALL or operation functions
Constructors and methods of utility and test classes

The only exception are some constexpr constructors used for instantiating
globals (since these must have trivial constructors) e.g. DOMJITAttribute.
Instead, these constructors should always be ALWAYS_INLINE.

• API/glib/JSCOptions.cpp:

(jscOptionsSetValue):
(jscOptionsGetValue):
(jsc_options_foreach):
(jsc_options_get_option_group):

• API/tests/testapi.c:

(main):

• API/tests/testapi.cpp:

(configureJSCForTesting):

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• jit/ExecutableAllocator.cpp:

(JSC::isJITEnabled):
(JSC::ExecutableAllocator::setJITEnabled):
(JSC::ExecutableAllocator::initializeUnderlyingAllocator):
(JSC::ExecutableAllocator::isValid const):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutableAllocator::memoryPressureMultiplier):
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::isValidExecutableMemory):
(JSC::ExecutableAllocator::getLock const):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::dumpProfile):
(JSC::startOfFixedExecutableMemoryPoolImpl):
(JSC::endOfFixedExecutableMemoryPoolImpl):
(JSC::isJITPC):
(JSC::dumpJITMemory):
(JSC::ExecutableAllocator::initialize):
(JSC::ExecutableAllocator::singleton):

• jit/ExecutableAllocator.h:

(JSC::performJITMemcpy):

• jsc.cpp:

(GlobalObject::finishCreation):
(functionJSCOptions):
(jscmain):
(functionForceGCSlowPaths): Deleted.

• runtime/ConfigFile.cpp:

(JSC::ConfigFile::parse):

• runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

• runtime/JSCConfig.cpp: Added.

(JSC::Config::disableFreezingForTesting):
(JSC::Config::enableRestrictedOptions):
(JSC::Config::permanentlyFreeze):

• runtime/JSCConfig.h: Added.

(JSC::Config::configureForTesting):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::exposeDollarVM):

• runtime/OptionEntry.h: Added.

(JSC::OptionRange::operator= ):
(JSC::OptionRange::rangeString const):

• runtime/Options.cpp:

(JSC::Options::isAvailable):
(JSC::scaleJITPolicy):
(JSC::Options::initialize):
(JSC::Options::setOptions):
(JSC::Options::setOptionWithoutAlias):
(JSC::Options::setAliasedOption):
(JSC::Option::dump const):
(JSC::Option::operator== const):
(): Deleted.
(JSC::Options::enableRestrictedOptions): Deleted.

• runtime/Options.h:

(JSC::Option::Option):
(JSC::Option::defaultOption const):
(JSC::Option::boolVal):
(JSC::Option::unsignedVal):
(JSC::Option::doubleVal):
(JSC::Option::int32Val):
(JSC::Option::optionRangeVal):
(JSC::Option::optionStringVal):
(JSC::Option::gcLogLevelVal):
(JSC::OptionRange::operator= ): Deleted.
(JSC::OptionRange::rangeString const): Deleted.

• runtime/OptionsList.h: Added.

(JSC::countNumberOfJSCOptions):

• runtime/VM.cpp:

(JSC::VM::VM):

• tools/FunctionOverrides.cpp:

(JSC::FunctionOverrides::FunctionOverrides):
(JSC::FunctionOverrides::reinstallOverrides):
(JSC::FunctionOverrides::initializeOverrideFor):
(JSC::FunctionOverrides::parseOverridesInFile):

• tools/JSDollarVM.cpp:

(JSC::JSDollarVMCallFrame::JSDollarVMCallFrame):
(JSC::JSDollarVMCallFrame::createStructure):
(JSC::JSDollarVMCallFrame::create):
(JSC::JSDollarVMCallFrame::finishCreation):
(JSC::JSDollarVMCallFrame::addProperty):
(JSC::Element::Element):
(JSC::Element::create):
(JSC::Element::createStructure):
(JSC::Root::Root):
(JSC::Root::create):
(JSC::Root::createStructure):
(JSC::SimpleObject::SimpleObject):
(JSC::SimpleObject::create):
(JSC::SimpleObject::createStructure):
(JSC::ImpureGetter::ImpureGetter):
(JSC::ImpureGetter::createStructure):
(JSC::ImpureGetter::create):
(JSC::ImpureGetter::finishCreation):
(JSC::ImpureGetter::getOwnPropertySlot):
(JSC::CustomGetter::CustomGetter):
(JSC::CustomGetter::createStructure):
(JSC::CustomGetter::create):
(JSC::CustomGetter::getOwnPropertySlot):
(JSC::CustomGetter::customGetter):
(JSC::CustomGetter::customGetterAcessor):
(JSC::RuntimeArray::create):
(JSC::RuntimeArray::destroy):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
(JSC::RuntimeArray::createPrototype):
(JSC::RuntimeArray::createStructure):
(JSC::RuntimeArray::finishCreation):
(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::lengthGetter):
(JSC::DOMJITNode::DOMJITNode):
(JSC::DOMJITNode::createStructure):
(JSC::DOMJITNode::checkSubClassSnippet):
(JSC::DOMJITNode::create):
(JSC::DOMJITGetter::DOMJITGetter):
(JSC::DOMJITGetter::createStructure):
(JSC::DOMJITGetter::create):
(JSC::DOMJITGetter::DOMJITAttribute::DOMJITAttribute):
(JSC::DOMJITGetter::DOMJITAttribute::slowCall):
(JSC::DOMJITGetter::DOMJITAttribute::callDOMGetter):
(JSC::DOMJITGetter::customGetter):
(JSC::DOMJITGetter::finishCreation):
(JSC::DOMJITGetterComplex::DOMJITGetterComplex):
(JSC::DOMJITGetterComplex::createStructure):
(JSC::DOMJITGetterComplex::create):
(JSC::DOMJITGetterComplex::DOMJITAttribute::DOMJITAttribute):
(JSC::DOMJITGetterComplex::DOMJITAttribute::slowCall):
(JSC::DOMJITGetterComplex::DOMJITAttribute::callDOMGetter):
(JSC::DOMJITGetterComplex::functionEnableException):
(JSC::DOMJITGetterComplex::customGetter):
(JSC::DOMJITGetterComplex::finishCreation):
(JSC::DOMJITFunctionObject::DOMJITFunctionObject):
(JSC::DOMJITFunctionObject::createStructure):
(JSC::DOMJITFunctionObject::create):
(JSC::DOMJITFunctionObject::functionWithTypeCheck):
(JSC::DOMJITFunctionObject::functionWithoutTypeCheck):
(JSC::DOMJITFunctionObject::checkSubClassSnippet):
(JSC::DOMJITFunctionObject::finishCreation):
(JSC::DOMJITCheckSubClassObject::DOMJITCheckSubClassObject):
(JSC::DOMJITCheckSubClassObject::createStructure):
(JSC::DOMJITCheckSubClassObject::create):
(JSC::DOMJITCheckSubClassObject::functionWithTypeCheck):
(JSC::DOMJITCheckSubClassObject::functionWithoutTypeCheck):
(JSC::DOMJITCheckSubClassObject::finishCreation):
(JSC::DOMJITGetterBaseJSObject::DOMJITGetterBaseJSObject):
(JSC::DOMJITGetterBaseJSObject::createStructure):
(JSC::DOMJITGetterBaseJSObject::create):
(JSC::DOMJITGetterBaseJSObject::DOMJITAttribute::DOMJITAttribute):
(JSC::DOMJITGetterBaseJSObject::DOMJITAttribute::slowCall):
(JSC::DOMJITGetterBaseJSObject::DOMJITAttribute::callDOMGetter):
(JSC::DOMJITGetterBaseJSObject::customGetter):
(JSC::DOMJITGetterBaseJSObject::finishCreation):
(JSC::JSTestCustomGetterSetter::JSTestCustomGetterSetter):
(JSC::JSTestCustomGetterSetter::create):
(JSC::JSTestCustomGetterSetter::createStructure):
(JSC::customSetAccessor):
(JSC::customSetValue):
(JSC::JSTestCustomGetterSetter::finishCreation):
(JSC::Element::handleOwner):
(JSC::Element::finishCreation):
(JSC::WasmStreamingParser::WasmStreamingParser):
(JSC::WasmStreamingParser::create):
(JSC::WasmStreamingParser::createStructure):
(JSC::WasmStreamingParser::finishCreation):
(JSC::functionWasmStreamingParserAddBytes):
(JSC::functionWasmStreamingParserFinalize):
(JSC::functionCrash):
(JSC::functionBreakpoint):
(JSC::functionDFGTrue):
(JSC::functionFTLTrue):
(JSC::functionCpuMfence):
(JSC::functionCpuRdtsc):
(JSC::functionCpuCpuid):
(JSC::functionCpuPause):
(JSC::functionCpuClflush):
(JSC::CallerFrameJITTypeFunctor::CallerFrameJITTypeFunctor):
(JSC::getExecutableForFunction):
(JSC::functionLLintTrue):
(JSC::functionJITTrue):
(JSC::functionNoInline):
(JSC::functionGC):
(JSC::functionEdenGC):
(JSC::functionDumpSubspaceHashes):
(JSC::functionCallFrame):
(JSC::functionCodeBlockForFrame):
(JSC::codeBlockFromArg):
(JSC::functionCodeBlockFor):
(JSC::functionDumpSourceFor):
(JSC::functionDumpBytecodeFor):
(JSC::doPrint):
(JSC::functionDataLog):
(JSC::functionPrint):
(JSC::functionDumpCallFrame):
(JSC::functionDumpStack):
(JSC::functionDumpRegisters):
(JSC::functionDumpCell):
(JSC::functionIndexingMode):
(JSC::functionInlineCapacity):
(JSC::functionValue):
(JSC::functionGetPID):
(JSC::functionHaveABadTime):
(JSC::functionIsHavingABadTime):
(JSC::functionCreateGlobalObject):
(JSC::functionCreateProxy):
(JSC::functionCreateRuntimeArray):
(JSC::functionCreateNullRopeString):
(JSC::functionCreateImpureGetter):
(JSC::functionCreateCustomGetterObject):
(JSC::functionCreateDOMJITNodeObject):
(JSC::functionCreateDOMJITGetterObject):
(JSC::functionCreateDOMJITGetterComplexObject):
(JSC::functionCreateDOMJITFunctionObject):
(JSC::functionCreateDOMJITCheckSubClassObject):
(JSC::functionCreateDOMJITGetterBaseJSObject):
(JSC::functionCreateWasmStreamingParser):
(JSC::functionSetImpureGetterDelegate):
(JSC::functionCreateBuiltin):
(JSC::functionGetPrivateProperty):
(JSC::functionCreateRoot):
(JSC::functionCreateElement):
(JSC::functionGetElement):
(JSC::functionCreateSimpleObject):
(JSC::functionGetHiddenValue):
(JSC::functionSetHiddenValue):
(JSC::functionShadowChickenFunctionsOnStack):
(JSC::functionSetGlobalConstRedeclarationShouldNotThrow):
(JSC::functionFindTypeForExpression):
(JSC::functionReturnTypeFor):
(JSC::functionFlattenDictionaryObject):
(JSC::functionDumpBasicBlockExecutionRanges):
(JSC::functionHasBasicBlockExecuted):
(JSC::functionBasicBlockExecutionCount):
(JSC::functionEnableExceptionFuzz):
(JSC::changeDebuggerModeWhenIdle):
(JSC::functionEnableDebuggerModeWhenIdle):
(JSC::functionDisableDebuggerModeWhenIdle):
(JSC::functionDeleteAllCodeWhenIdle):
(JSC::functionGlobalObjectCount):
(JSC::functionGlobalObjectForObject):
(JSC::functionGetGetterSetter):
(JSC::functionLoadGetterFromGetterSetter):
(JSC::functionCreateCustomTestGetterSetter):
(JSC::functionDeltaBetweenButterflies):
(JSC::functionTotalGCTime):
(JSC::functionParseCount):
(JSC::functionIsWasmSupported):
(JSC::JSDollarVM::finishCreation):
(JSC::JSDollarVM::addFunction):
(JSC::JSDollarVM::addConstructibleFunction):

• tools/JSDollarVM.h:

Source/WebCore:

No new tests. Covered by existing tests.

Enable Options::useDollarVM before we tell the JSGlobalObject to exposeDollarVM().
The $vm utility is now hardened to require that Options::useDollarVM be
enabled in order for it to be used.

• testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):

Source/WebKit:

Linux parts contributed by Carlos Garcia Campos <​cgarcia@igalia.com>.

1. Add plumbing to allow WK2 tests to configureJSCForTesting().
2. Removed the call enable Options::useBigInt in WebInspectorUI. WebInspectorUI doesn't really need it for now.

• PluginProcess/unix/PluginProcessMainUnix.cpp:
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

• Shared/unix/AuxiliaryProcessMain.cpp:

(WebKit::AuxiliaryProcessMainBase::parseCommandLine):

• Shared/unix/AuxiliaryProcessMain.h:

(WebKit::AuxiliaryProcessMain):

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

• UIProcess/API/APIProcessPoolConfiguration.h:
• UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationSetShouldConfigureJSCForTesting):

• UIProcess/API/C/WKContextConfigurationRef.h:
• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration configureJSCForTesting]):
(-[_WKProcessPoolConfiguration setConfigureJSCForTesting:]):

• UIProcess/Launcher/ProcessLauncher.h:

(WebKit::ProcessLauncher::Client::shouldConfigureJSCForTesting const):

• UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::shouldConfigureJSCForTesting const):

• UIProcess/WebProcessProxy.h:
• WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::WebInspectorUI):

Source/WTF:

Add a source file that was missing so that Xcode can search its contents too.

• WTF.xcodeproj/project.pbxproj:

Tools:

Linux parts contributed by Carlos Garcia Campos <​cgarcia@igalia.com>.
Windows parts contributed by Fujii Hironori <Fujii Hironori>.

Call JSC::Config::configureForTesting() in test harnesses or at the top of tests
to disable the hardening on test runs. Tests rely on setting options to enable
test features.

• DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):

• DumpRenderTree/win/DumpRenderTree.cpp:

(initialize):

• TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextWithInjectedBundle):

• TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:

(main):

• TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:

(TestWebKitAPI::TEST):
(TestWebKitAPI::runActiveSessionTest):

• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

• TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/WKWebViewConfigurationExtras.h:
• TestWebKitAPI/WKWebViewConfigurationExtras.mm:

(+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
(+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::generateContextConfiguration const):

7:13 AM Changeset in webkit [249807] by Keith Rollin

• 7 edits in trunk/Tools

Fix PDFKit references in TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=201700
<rdar://problem/55279539>

Reviewed by Youenn Fablet.

These references fail in watchOS and tvOS, so remove them on those
platforms.

• TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
• TestWebKitAPI/cocoa/TestPDFDocument.h:
• TestWebKitAPI/cocoa/TestPDFDocument.mm:
• TestWebKitAPI/config.h:

6:52 AM Changeset in webkit [249806] by Michael Catanzaro

• 3 edits in trunk/Source/WebKit

Fix accidental copies in NetworkLoadChecker.cpp
​https://bugs.webkit.org/show_bug.cgi?id=199528

Reviewed by Youenn Fablet.

Coverity noticed that we are copying a ResourceRequest and a ContentExtensionResultOrError
in NetworkLoadChecker::checkRequest by mistake, when the intent was to move them as rvalue
references.

• NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::checkRequest):

• NetworkProcess/NetworkLoadChecker.h:

3:59 AM Changeset in webkit [249805] by Joseph Pecoraro

• 2 edits in trunk/Source/WebKit

Web Inspector: Crashes when intercept response continues with original content
​https://bugs.webkit.org/show_bug.cgi?id=201707
<rdar://problem/55261857>

Reviewed by David Kilzer.

• WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveData):
Copy the data for the callback since the deferral may run it much later.

3:53 AM Changeset in webkit [249804] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Layout Test http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=199075

Patch by Russell Epstein <Russell Epstein> on 2019-09-12
Reviewed by Youenn Fablet.

Currently, this test includes js-test.js twice, which is causing the test to be flaky.

• http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html: Removed second instance.

1:47 AM Changeset in webkit [249803] by youenn@apple.com

• 20 edits in trunk/Source

Use typed identifiers for IDB connection identifiers
​https://bugs.webkit.org/show_bug.cgi?id=201682

Reviewed by Chris Dumez.

Source/WebCore:

Migrate from uint64_t to a typed identifier for IDB connection identifiers.
The identifier is reusing the process identifier type.
No change of behavior.

• Modules/indexeddb/client/IDBConnectionProxy.h:

(WebCore::IDBClient::IDBConnectionProxy::serverConnectionIdentifier const):

• Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::identifier const):

• Modules/indexeddb/client/IDBConnectionToServer.h:
• Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
• Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::identifier const):

• Modules/indexeddb/server/IDBConnectionToClient.h:
• Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::getAllDatabaseNames):
(WebCore::IDBServer::IDBServer::performGetAllDatabaseNames):
(WebCore::IDBServer::IDBServer::didGetAllDatabaseNames):

• Modules/indexeddb/server/IDBServer.h:
• Modules/indexeddb/shared/IDBRequestData.cpp:

(WebCore::IDBRequestData::serverConnectionIdentifier const):

• Modules/indexeddb/shared/IDBRequestData.h:
• Modules/indexeddb/shared/IDBResourceIdentifier.cpp:

(WebCore::IDBResourceIdentifier::IDBResourceIdentifier):
(WebCore::IDBResourceIdentifier::emptyValue):
(WebCore::IDBResourceIdentifier::deletedValue):
(WebCore::IDBResourceIdentifier::isHashTableDeletedValue const):
(WebCore::IDBResourceIdentifier::loggingString const):

• Modules/indexeddb/shared/IDBResourceIdentifier.h:

(WebCore::IDBResourceIdentifier::hash const):
(WebCore::IDBResourceIdentifier::connectionIdentifier const):
(WTF::crossThreadCopy):

• Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::identifier const):

• Modules/indexeddb/shared/InProcessIDBServer.h:

Source/WebKit:

Remove no longer needed conversion from process identifier to idb connection identifier.

• NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::identifier const):

• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:

1:44 AM Changeset in webkit [249802] by cturner@igalia.com

• 2 edits in trunk/Source/WebKit

[GTK] Allow CacheStore::destroyEngine to destroy default engine for soup.
​https://bugs.webkit.org/show_bug.cgi?id=201690

Reviewed by Carlos Garcia Campos.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::destroyEngine): As we do for
NetworkProcess::destroySession, also allow destroying the engine
for the default session for the same reason.

1:18 AM Changeset in webkit [249801] by youenn@apple.com

• 36 edits in trunk/Source

Use WebProcess processIdentifier to identify Service Worker connections
​https://bugs.webkit.org/show_bug.cgi?id=201459

Reviewed by Chris Dumez.

Source/WebCore:

No observable change of behavior.

• workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::postMessage):
Pass sessionID to ease NetworkProcess selection of the client process connection.

• workers/service/ServiceWorkerTypes.h:

Mark server connection identifier be process identifier based.

• workers/service/context/SWContextManager.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::Connection):

• workers/service/server/SWServer.h:

Let connection identifier be set in constructor instead of generated.

Source/WebCore/PAL:

• pal/SessionID.h:

(PAL::SessionID::SessionID):

Source/WebKit:

Make WebSWServerConnection be stored in NetworkConnectionToWebProcess.
They are now keyed by session IDs hence why WebSWClientConnection is using the session ID as message connection ID.
Creation no longer requires a sync IPC since the connection is uniquely identified by its session ID and its process ID.
These IDs are stable over network process crash.
Within NetworkProcess, a server connection is managed by a SWServer which is session ID specific.
In that case, the process identifier uniquely identifies the connection.

Move WebSWServerToContextConnection be owned by NetworkConnectionToWebProcess.
Instead of creating it when webprocess is connecting to network process, use a dedicated IPC message.
This is similar to WebSWServerConnection once WebProcess asks to create it.
This will allow existing WebProcess, in cache or running pages, to run service workers as well.
A context connection map is kept in Network Process to reuse context connections since these connections are not sessionID specific.

Migrate from a single boolean to a HashSet to track whether some connections are in the process of being created.
Previously if two requests to create connections were done shortly one after the other on different registrable
domains, the second request would not be processed.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::establishSWServerConnection):
(WebKit::NetworkConnectionToWebProcess::establishSWContextConnection):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didReceiveMessage):
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
(WebKit::NetworkProcess::forEachSWServer):
(WebKit::NetworkProcess::needsServerToContextConnectionForRegistrableDomain const):
(WebKit::NetworkProcess::createServerToContextConnection):
(WebKit::NetworkProcess::postMessageToServiceWorkerClient):
(WebKit::NetworkProcess::registerSWServerConnection):
(WebKit::NetworkProcess::unregisterSWServerConnection):
(WebKit::NetworkProcess::registerSWContextConnection):
(WebKit::NetworkProcess::unregisterSWContextConnection):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerClient):

• NetworkProcess/ServiceWorker/WebSWServerConnection.h:
• NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::WebSWServerToContextConnection):
(WebKit::WebSWServerToContextConnection::~WebSWServerToContextConnection):
(WebKit::WebSWServerToContextConnection::postMessageToServiceWorkerClient):
(WebKit::WebSWServerToContextConnection::connectionMayNoLongerBeNeeded):

• NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
• NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::openNetworkProcessConnection):
(WebKit::NetworkProcessProxy::establishWorkerContextConnectionToNetworkProcess):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::establishWorkerContextConnectionToNetworkProcess):

• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::establishServiceWorkerContext):

• UIProcess/WebProcessProxy.h:
• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::serviceWorkerConnectionForSession):

• WebProcess/Network/NetworkProcessConnection.h:
• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::WebSWClientConnection):
(WebKit::WebSWClientConnection::~WebSWClientConnection):
(WebKit::WebSWClientConnection::messageSenderConnection const):
(WebKit::WebSWClientConnection::scheduleJobInServer):
(WebKit::WebSWClientConnection::finishFetchingScriptInServer):
(WebKit::WebSWClientConnection::addServiceWorkerRegistrationInServer):
(WebKit::WebSWClientConnection::removeServiceWorkerRegistrationInServer):
(WebKit::WebSWClientConnection::postMessageToServiceWorker):
(WebKit::WebSWClientConnection::registerServiceWorkerClient):
(WebKit::WebSWClientConnection::unregisterServiceWorkerClient):
(WebKit::WebSWClientConnection::didResolveRegistrationPromise):
(WebKit::WebSWClientConnection::matchRegistration):
(WebKit::WebSWClientConnection::runOrDelayTaskForImport):
(WebKit::WebSWClientConnection::whenRegistrationReady):
(WebKit::WebSWClientConnection::getRegistrations):
(WebKit::WebSWClientConnection::startFetch):
(WebKit::WebSWClientConnection::cancelFetch):
(WebKit::WebSWClientConnection::continueDidReceiveFetchResponse):
(WebKit::WebSWClientConnection::connectionToServerLost):
(WebKit::WebSWClientConnection::clear):
(WebKit::WebSWClientConnection::syncTerminateWorker):
(WebKit::WebSWClientConnection::updateThrottleState):
(WebKit::WebSWClientConnection::storeRegistrationsOnDiskForTesting):

• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::WebSWContextManagerConnection):
(WebKit::m_userAgent):
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerClient):

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::establishWorkerContextConnectionToNetworkProcess):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

12:50 AM Changeset in webkit [249800] by Joseph Pecoraro

• 3 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: null is not an object (evaluating 'selectedTreeElement.representedObject')
​https://bugs.webkit.org/show_bug.cgi?id=201716
<rdar://problem/55292615>

Reviewed by Devin Rousso.

• UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved):

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved):
If a breakpoint was removed without a selection in the breakpoint tree outline
then there may be no selected tree element.

Sep 11, 2019:

11:55 PM Changeset in webkit [249799] by Joseph Pecoraro

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Inspector Timeline always starts at about 500ms mark on a reload
​https://bugs.webkit.org/show_bug.cgi?id=200637
<rdar://problem/54218967>

Reviewed by Devin Rousso.

The Timeline was getting a startTime value from before the user started
the timeline recording because of artificial adjustments that were made
to CPUTimelineRecords. Ignore adjusted values when updating the Timeline's
start and end times.

• UserInterface/Models/Timeline.js:

(WI.Timeline.prototype._updateTimesIfNeeded):
Use unadjusted times, which should fall in the user started / stopped
timeline range.

• UserInterface/Models/TimelineRecord.js:

(WI.TimelineRecord.prototype.get unadjustedStartTime):
(WI.TimelineRecord.prototype.get unadjustedEndTime):
Default implementation uses startTime/endTime.

• UserInterface/Models/CPUTimelineRecord.js:

(WI.CPUTimelineRecord.prototype.get unadjustedStartTime):

• UserInterface/Models/MemoryTimelineRecord.js:

(WI.MemoryTimelineRecord.prototype.get unadjustedStartTime):
Each of these adjusted their startTime.

11:51 PM Changeset in webkit [249798] by youenn@apple.com

• 9 edits
  2 adds in trunk

Source/ThirdParty/libwebrtc:
Disable DTLS1.0
​https://bugs.webkit.org/show_bug.cgi?id=201679

Reviewed by Alex Christensen.

• Source/webrtc/rtc_base/opensslstreamadapter.cc:

Set minimum version to DTLS1.2 when DTLS1.2 is supported.
This makes sure any client will never downgrade to DTLS1.0.

Source/WebCore:
Disable DTLS1.0
​https://bugs.webkit.org/show_bug.cgi?id=201679

Reviewed by Alex Christensen.

Add an option to force to use DTLS1.0 and nothing else.
Add internals API to enter in that mode to verify that normal configurations cannot communicate with DTLS1.0.

Test: webrtc/datachannel/dtls10.html

• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::setEnableWebRTCEncryption):
(WebCore::LibWebRTCProvider::setUseDTLS10):

• platform/mediastream/libwebrtc/LibWebRTCProvider.h:
• testing/Internals.cpp:

(WebCore::Internals::setUseDTLS10):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:
Disable DTLS10
​https://bugs.webkit.org/show_bug.cgi?id=201679

Reviewed by Alex Christensen.

• webrtc/datachannel/dtls10-expected.txt: Added.
• webrtc/datachannel/dtls10.html: Added.

11:04 PM Changeset in webkit [249797] by Joseph Pecoraro

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: CPU: Overlay Markers for Thread views are off by 500ms
​https://bugs.webkit.org/show_bug.cgi?id=201709
<rdar://problem/55289279>

Reviewed by Devin Rousso.

• UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.prototype.layout):
Use the CPUTimelineRecord's timestamp (same as the record's endTime) as the
point when the CPU sample is taken. This aligns with the rest of the UI that
assumes that the 500ms before the sample point leads up to the sample value.

10:47 PM Changeset in webkit [249796] by Joseph Pecoraro

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Do not show override actions unless Sources tab is enabled
​https://bugs.webkit.org/show_bug.cgi?id=201708

Reviewed by Devin Rousso.

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.supportsLocalResourceOverrides):

10:40 PM Changeset in webkit [249795] by Keith Rollin

• 4 edits in trunk/Source

Log timeoutValue passed on to CFNetwork
​https://bugs.webkit.org/show_bug.cgi?id=201701
<rdar://problem/55279683>

Reviewed by Chris Dumez.

Source/WebCore:

Export ResourceRequest::timeoutValue for use in WebKit.

No new tests -- no new or changed functionality.

• platform/network/ResourceRequestBase.h:

Source/WebKit:

We occasionally see cases where resource-loads into CFNetwork take a
long time. Rather than timing out after the default of 60s, they stay
pending for many minutes. To better understand why this is happening,
log the timeoutValue we pass to CFNetwork when loading resources.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::startNetworkLoad):

10:29 PM Changeset in webkit [249794] by sbarati@apple.com

• 2 edits in trunk/Source/WebCore

[WHLSL] Remove null from the standard library
​https://bugs.webkit.org/show_bug.cgi?id=201672

Reviewed by Robin Morisset.

I meant to remove null from the standard library in r249351, but
I had omitted the code I wrote to do that when I rebased that patch.
This patch removes it and ensures all tests pass when parsing the entire
standard library.

• Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:

10:06 PM Changeset in webkit [249793] by Ryan Haddad

• 1418 edits
  1 copy
  14 moves
  27 adds
  252 deletes in trunk/Source/ThirdParty/ANGLE

Unreviewed, rolling out r249791.

Breaks internal production builds.

Reverted changeset:

"Update ANGLE"
​https://bugs.webkit.org/show_bug.cgi?id=201156
​https://trac.webkit.org/changeset/249791

9:32 PM Changeset in webkit [249792] by Chris Dumez

• 6 edits in trunk

Use same parser for <meta http-equiv="refresh"> and Refresh HTTP header
​https://bugs.webkit.org/show_bug.cgi?id=201694

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

• web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing-expected.txt:

Source/WebCore:

Use same parser for <meta http-equiv="refresh"> and Refresh HTTP header. This aligns
our behavior with Blink and makes us more compliant on web-platform-tests. This also
simplifies our code.

No new tests, rebaselined existing test.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):

• platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPRefresh): Deleted.

• platform/network/HTTPParsers.h:

8:08 PM Changeset in webkit [249791] by achristensen@apple.com

• 1414 edits
  346 adds
  37 deletes in trunk/Source/ThirdParty/ANGLE

Update ANGLE
​https://bugs.webkit.org/show_bug.cgi?id=201156

Patch by James Darpinian <James Darpinian> on 2019-09-11
Reviewed by Alex Christensen.

Update to 2019-9-9, revision 79ad0411911b2fc84834c3705f55707be9e4b498
I merged a bunch of changes to upstream ANGLE, to minimize the changes
necessary when updating ANGLE in WebKit.

• ANGLE.plist: Update commit hashes
• ANGLE.txt: Removed in favor of LICENSE
• ANGLE.xcodeproj/project.pbxproj: Updated with upstream changes

Also, copy src/commit.h to id/commit.h during build

• CMakeLists.txt: Updated with upstream changes

Also, copy src/commit.h to id/commit.h during build

• Compiler.cmake: Updated with upstream changes
• GLESv2.cmake: Updated with upstream changes
• adjust-angle-include-paths-rule: Support "" as well as <> for includes
• adjust-angle-include-paths.sh: Support "" as well as <> for includes
• changes.diff: Pared down to just legal disclaimer and warning flag changes
• update-angle.sh: Update ANGLE.plist

• Many other files modified/added/removed upstream

7:31 PM Changeset in webkit [249790] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: checkerboard has too much contrast in dark mode
​https://bugs.webkit.org/show_bug.cgi?id=201670

Reviewed by Timothy Hatcher.

• UserInterface/Views/CanvasTabContentView.css:

(.content-view.canvas > .preview > img, .content-view.canvas .preview-container > canvas): Deleted.
Don't force a background-color: white; in dark mode.

6:48 PM Changeset in webkit [249789] by Fujii Hironori

• 2 edits in trunk/Tools

[Win][MiniBrowser] Select all text in the URL bar by clicking it
​https://bugs.webkit.org/show_bug.cgi?id=201677

Reviewed by Don Olmstead.

• MiniBrowser/win/MainWindow.cpp:

(EditProc): Post EM_SETSEL in WM_SETFOCUS to select all text.

6:06 PM Changeset in webkit [249788] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: don't show Changes panel when selecting text node
​https://bugs.webkit.org/show_bug.cgi?id=201669

Reviewed by Joseph Pecoraro.

Show Changes panel only for elements regardless of "Show only for selected node" setting.

• UserInterface/Views/ChangesDetailsSidebarPanel.js:

(WI.ChangesDetailsSidebarPanel.prototype.supportsDOMNode):
(WI.ChangesDetailsSidebarPanel.prototype.inspect): Deleted.

4:34 PM Changeset in webkit [249787] by sbarati@apple.com

• 11 edits
  4 adds in trunk

[WHLSL] Ensure structs/arrays with pointers as fields are disallowed
​https://bugs.webkit.org/show_bug.cgi?id=201525

Reviewed by Robin Morisset.

Source/WebCore:

This patch adds a pass which both ensures that references are always initialized with
concrete values and that we support logical mode validation by disallowing nested references.

Specifically, the pass:

1. Disallows structs to have fields which are references. This prevents us from having to

figure out how to default initialize such a struct. We could relax this in the future if we
did an analysis on which structs contain reference fields, and ensure such struct variables
always have initializers. This would also require us to create constructors for structs which
initialize each field.

2. We also do the same for arrays.
3. References can only be one level deep. So no pointers to pointers. No references to

references, etc. This is to support logical mode validation rules.

Test: webgpu/whlsl/ensure-proper-pointer-usage.html

• Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.cpp: Added.

(WebCore::WHLSL::checkReferenceTypes):

• Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.h: Added.
• Modules/webgpu/WHLSL/WHLSLChecker.cpp:

(WebCore::WHLSL::Checker::visit):

• Modules/webgpu/WHLSL/WHLSLPrepare.cpp:

(WebCore::WHLSL::prepareShared):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

This patch fixes a bug in our test harness where we forgot to wait for the gpu
device to load before running test harness tests. This patch fixes this oversight
and asserts that we have always finished loading before running a test.

• webgpu/whlsl/array-spec-tests.html:
• webgpu/whlsl/ensure-proper-pointer-usage-expected.txt: Added.
• webgpu/whlsl/ensure-proper-pointer-usage.html: Added.
• webgpu/whlsl/js/test-harness.js:

(Harness):
(Harness.prototype.async.requestDevice):
(Harness.prototype.async.callTypedFunction):
(Harness.prototype.async.checkCompileFail):

• webgpu/whlsl/pointer-spec-tests.html:
• webgpu/whlsl/test-harness-test.html:

4:28 PM Changeset in webkit [249786] by Devin Rousso

• 38 edits
  4 moves
  12 adds
  8 deletes in trunk

Web Inspector: Canvas: instrument WebGPUDevice instead of GPUCanvasContext
​https://bugs.webkit.org/show_bug.cgi?id=201650

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Most of the actual "work" done with Web GPU actually uses a WebGPUDevice.

A GPUCanvasContext is basically just a display "client" of the device, and isn't even
required (e.g. compute pipeline). We should treat the GPUCanvasContext almost like a
-webkit-canvas client of a WebGPUDevice.

• inspector/protocol/Canvas.json:
  • Add powerPreference key to ContextAttributes type.
  • Rename requestCSSCanvasClientNodes command to requestClientNodes for the above reason.
  • Rename cssCanvasClientNodesChanged event to clientNodesChanged for the above reason.
  • Rename resolveCanvasContext command to resolveContext since a WebGPUDevice isn't really a "canvas".

Source/WebCore:

Most of the actual "work" done with Web GPU actually uses a WebGPUDevice.

A GPUCanvasContext is basically just a display "client" of the device, and isn't even
required (e.g. compute pipeline). We should treat the GPUCanvasContext almost like a
-webkit-canvas client of a WebGPUDevice.

Tests: inspector/canvas/create-context-webgpu.html

inspector/canvas/requestClientNodes-webgpu.html
inspector/canvas/resolveContext-webgpu.html

• Modules/webgpu/WebGPUAdapter.cpp:

(WebCore::WebGPUAdapter::requestDevice const):
Notify web inspector after a device is created.

• Modules/webgpu/WebGPUDevice.idl:
• Modules/webgpu/WebGPUDevice.h:
• Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::instances): Added.
(WebCore::WebGPUDevice::instancesMutex): Added.
(WebCore::WebGPUDevice::~WebGPUDevice): Added.
Notify web inspector when the device is about to be destructed.

• Modules/webgpu/GPUCanvasContext.h:
• Modules/webgpu/GPUCanvasContext.cpp:

(WebCore::GPUCanvasContext::create):
(WebCore::GPUCanvasContext::configureSwapChain):

• inspector/InspectorCanvas.h:
• inspector/InspectorCanvas.cpp:

(WebCore::canvasIfContextMatchesDevice): Added.
(WebCore::InspectorCanvas::create):
(WebCore::InspectorCanvas::InspectorCanvas):
(WebCore::InspectorCanvas::canvasContext const): Added.
(WebCore::InspectorCanvas::canvasElement const): Added.
(WebCore::InspectorCanvas::isDeviceForCanvasContext const): Added.
(WebCore::InspectorCanvas::deviceContext const): Added.
(WebCore::InspectorCanvas::scriptExecutionContext const): Added.
(WebCore::InspectorCanvas::resolveContext const): Added.
(WebCore::InspectorCanvas::clientNodes const): Added.
(WebCore::InspectorCanvas::canvasChanged):
(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::buildObjectForCanvas):
(WebCore::InspectorCanvas::releaseObjectForRecording):
(WebCore::InspectorCanvas::getCanvasContentAsDataURL):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::canvasElement): Deleted.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCreateWebGPUDeviceImpl): Added.
(WebCore::InspectorInstrumentation::willDestroyWebGPUDeviceImpl): Added.
(WebCore::InspectorInstrumentation::willConfigureSwapChainImpl): Added.

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didCreateWebGPUDevice): Added.
(WebCore::InspectorInstrumentation::willDestroyWebGPUDevice): Added.
(WebCore::InspectorInstrumentation::willConfigureSwapChain): Added.

• inspector/agents/InspectorCanvasAgent.h:
• inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::requestClientNodes): Added.
(WebCore::InspectorCanvasAgent::resolveContext): Added.
(WebCore::InspectorCanvasAgent::startRecording):
(WebCore::InspectorCanvasAgent::stopRecording):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didChangeCSSCanvasClientNodes):
(WebCore::InspectorCanvasAgent::didChangeCanvasMemory):
(WebCore::InspectorCanvasAgent::canvasDestroyed):
(WebCore::InspectorCanvasAgent::recordCanvasAction):
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
(WebCore::InspectorCanvasAgent::didCreateWebGPUDevice): Added.
(WebCore::InspectorCanvasAgent::willDestroyWebGPUDevice): Added.
(WebCore::InspectorCanvasAgent::willConfigureSwapChain): Added.
(WebCore::InspectorCanvasAgent::clearCanvasData):
(WebCore::InspectorCanvasAgent::bindCanvas):
(WebCore::InspectorCanvasAgent::unbindCanvas):
(WebCore::InspectorCanvasAgent::findInspectorCanvas):
(WebCore::InspectorCanvasAgent::requestCSSCanvasClientNodes): Deleted.
(WebCore::contextAsScriptValue): Deleted.
(WebCore::InspectorCanvasAgent::resolveCanvasContext): Deleted.

• inspector/InspectorShaderProgram.cpp:

(WebCore::InspectorShaderProgram::context const):

Source/WebInspectorUI:

Most of the actual "work" done with Web GPU actually uses a WebGPUDevice.

A GPUCanvasContext is basically just a display "client" of the device, and isn't even
required (e.g. compute pipeline). We should treat the GPUCanvasContext almost like a
-webkit-canvas client of a WebGPUDevice.

• UserInterface/Protocol/CanvasObserver.js:

(WI.CanvasObserver.prototype.clientNodesChanged): Added.
(WI.CanvasObserver.prototype.cssCanvasClientNodesChanged):

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.clientNodesChanged): Added.
(WI.CanvasManager.prototype.cssCanvasClientNodesChanged): Deleted.

• UserInterface/Models/Canvas.js:

(WI.Canvas.resetUniqueDisplayNameNumbers):
(WI.Canvas.prototype.get displayName):
(WI.Canvas.prototype.requestNode):
(WI.Canvas.prototype.requestClientNodes): Added.
(WI.Canvas.prototype.requestSize):
(WI.Canvas.prototype.clientNodesChanged): Added.
(WI.Canvas.prototype.requestCSSCanvasClientNodes): Deleted.
(WI.Canvas.prototype.cssCanvasClientNodesChanged): Deleted.

• UserInterface/Protocol/RemoteObject.js:

(WI.RemoteObject.resolveCanvasContext):

• UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype.attached):
(WI.CanvasContentView.prototype._refreshPixelSize):

• UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WI.CanvasDetailsSidebarPanel.prototype.set canvas):
(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):
(WI.CanvasDetailsSidebarPanel.prototype.layout):
(WI.CanvasDetailsSidebarPanel.prototype._refreshSourceSection):
(WI.CanvasDetailsSidebarPanel.prototype._refreshClientsSection): Added.
(WI.CanvasDetailsSidebarPanel.prototype._refreshCSSCanvasSection): Deleted.

• UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView.prototype._contentViewMouseEnter):

• UserInterface/Views/CanvasTreeElement.js:

(WI.CanvasTreeElement.prototype._handleMouseOver):

• Localizations/en.lproj/localizedStrings.js:

LayoutTests:

• inspector/canvas/create-context-webgpu.html:
• inspector/canvas/create-context-webgpu-expected.txt:
• inspector/canvas/resources/create-context-utilities.js:

(createDetachedCanvas):
(createCSSCanvas):
(destroyCanvases):

• inspector/canvas/requestClientNodes.html: Added.
• inspector/canvas/requestClientNodes-expected.txt: Added.
• inspector/canvas/requestClientNodes-css.html: Renamed from LayoutTests/inspector/canvas/css-canvas-clients.html.
• inspector/canvas/requestClientNodes-css-expected.txt: Renamed from LayoutTests/inspector/canvas/css-canvas-clients-expected.txt.
• inspector/canvas/requestClientNodes-webgpu.html: Added.
• inspector/canvas/requestClientNodes-webgpu-expected.txt: Added.

• inspector/canvas/resolveContext-2d.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-2d.html.
• inspector/canvas/resolveContext-2d-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-2d-expected.txt.
• inspector/canvas/resolveContext-bitmaprenderer.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-bitmaprenderer.html.
• inspector/canvas/resolveContext-bitmaprenderer-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-bitmaprenderer-expected.txt.
• inspector/canvas/resolveContext-webgl.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl.html.
• inspector/canvas/resolveContext-webgl-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl-expected.txt.
• inspector/canvas/resolveContext-webgl2.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl2.html.
• inspector/canvas/resolveContext-webgl2-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgl2-expected.txt.
• inspector/canvas/resolveContext-webgpu.html: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgpu.html.
• inspector/canvas/resolveContext-webgpu-expected.txt: Renamed from LayoutTests/inspector/canvas/resolveCanvasContext-webgpu-expected.txt.

• inspector/canvas/context-attributes-expected.txt:

• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wpe/TestExpectations:

4:10 PM Changeset in webkit [249785] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Protect UserMediaRequest when stopping it
​https://bugs.webkit.org/show_bug.cgi?id=201687
<rdar://problem/55241215>

Reviewed by Eric Carlson.

By removing the request from the map, we may destroy the request.
To make sure it stays alive, take the request from the map.

• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::cancelUserMediaRequest):

4:05 PM Changeset in webkit [249784] by Alan Coon

• 7 edits in branches/safari-608.2.11.1-branch/Source

Versioning.

3:57 PM Changeset in webkit [249783] by Alan Coon

• 1 copy in tags/Safari-608.2.11.1.5

Tag Safari-608.2.11.1.5.

3:42 PM Changeset in webkit [249782] by Chris Dumez

• 3 edits
  2 adds in trunk/LayoutTests

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/cache-storage/cache-persistency.https.html
​https://bugs.webkit.org/show_bug.cgi?id=201691

Reviewed by Alex Christensen.

Split cache-persistency.https.html into 2 tests (one for private session and one for
regular session) to avoid relying on legacy testRunner.setPrivateBrowsingEnabled_DEPRECATED().

• http/tests/cache-storage/cache-persistency-private-expected.txt: Added.
• http/tests/cache-storage/cache-persistency-private.html: Added.
• http/tests/cache-storage/cache-persistency.https-expected.txt:
• http/tests/cache-storage/cache-persistency.https.html:

3:38 PM Changeset in webkit [249781] by Chris Dumez

• 5 edits in trunk

Posting a message to a redundant service worker should fail silently instead of throwing
​https://bugs.webkit.org/show_bug.cgi?id=201696

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that one more check is passing.

• web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt:

Source/WebCore:

Posting a message to a redundant service worker should fail silently instead of throwing:

• ​https://w3c.github.io/ServiceWorker/#dom-serviceworker-postmessage-message-options
• ​https://w3c.github.io/ServiceWorker/#run-service-worker (step 2)

No new tests, rebaselined existing test.

• workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::runServiceWorkerIfNecessary):

3:36 PM Changeset in webkit [249780] by ysuzuki@apple.com

• 24 edits
  9 adds in trunk

[JSC] Add StringCodePointAt intrinsic
​https://bugs.webkit.org/show_bug.cgi?id=201673

Reviewed by Michael Saboff.

JSTests:

• stress/string-char-at-constant-index-out-of-range.js: Added.

(shouldBe):
(test):

• stress/string-char-code-at-constant-index-out-of-range.js: Added.

(shouldBe):
(test):

• stress/string-code-point-at--out-of-range.js: Added.

(shouldBe):
(test):

• stress/string-code-point-at-basic.js: Added.

(test):

• stress/string-code-point-at-constant-index-out-of-range.js: Added.

(shouldBe):
(test):

• stress/string-code-point-at-constant-int32-max-index-out-of-range.js: Added.

(shouldBe):
(test):

• stress/string-code-point-at-constant-surrogate-pair.js: Added.

(shouldBe):
(test):
(breaking):

• stress/string-code-point-at-surrogate-pair.js: Added.

(shouldBe):

• stress/string-code-point-at.js: Added.

(shouldBe):

Source/JavaScriptCore:

JetStream2/UniPoker executes String#codePointAt frequently. We should handle it in ThunkGenerator, DFG, and FTL like we are doing so for String#charCodeAt.
This patch adds these supports for String#codePointAt to get ~10% score improvement in JetStream2/UniPoker.

In ThunkGenerator, we add a thunk for String#codePointAt, which accelerates LLInt and Baseline. In DFG, we handle this as StringCodePointAt node, and emit
inlined code in DFG and FTL. The characteristics of StringCodePointAt node is basically the same to StringCharAt. It has String array-mode, so it emits
preceding CheckArray. This ensures that (1) StringCodePointAt node itself does not do GC since the string is always resolved, and (2) we can skip the rope
check. This thing is just the same to the existing StringCharCodeAt mechanism.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileStringCodePointAt):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCodePointAt):

• jit/JITInlines.h:

(JSC::JIT::emitLoadCharacterString):

• jit/ThunkGenerators.cpp:

(JSC::stringGetByValGenerator):
(JSC::stringCharLoad):
(JSC::stringPrototypeCodePointAtThunkGenerator):

• jit/ThunkGenerators.h:
• runtime/Intrinsic.cpp:

(JSC::intrinsicName):

• runtime/Intrinsic.h:
• runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

• runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

3:27 PM Changeset in webkit [249779] by Chris Dumez

• 19 edits in trunk

Align our XPath API with the specification and other browsers
​https://bugs.webkit.org/show_bug.cgi?id=201660

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/dom/interfaces-expected.txt:

Source/WebCore:

Align our XPath API with the specification and other browsers:

• Document/XPathEvaluator.createExpression()'s first parameter should be mandatory
• Document/XPathEvaluator.evaluate()'s first 2 parameters should be mandatory
• XPathExpression.evaluate()'s first parameter should be mandatory

I have confirmed in the latest Chrome and Firefox that they match the specification.

No new tests, rebaselined existing test.

• dom/Document.cpp:

(WebCore::Document::evaluate):

• dom/Document.h:
• dom/Document.idl:
• inspector/InspectorNodeFinder.cpp:

(WebCore::InspectorNodeFinder::searchUsingXPath):

• xml/XPathEvaluator.cpp:

(WebCore::XPathEvaluator::evaluate):

• xml/XPathEvaluator.h:
• xml/XPathEvaluator.idl:
• xml/XPathExpression.cpp:

(WebCore::XPathExpression::evaluate):

• xml/XPathExpression.h:
• xml/XPathExpression.idl:
• xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode):

• xml/XPathUtil.h:

2:43 PM Changeset in webkit [249778] by Ryan Haddad

• 52 edits
  1 copy
  1 move
  4 adds in trunk

Unreviewed, rolling out r249768.

Caused 4 API tests to assert, perf test failures, and layout
test crashes under ASan

Reverted changeset:

"Remove unnecessary abstractions around WebsiteDataStore"
​https://bugs.webkit.org/show_bug.cgi?id=201655
​https://trac.webkit.org/changeset/249768

2:22 PM Changeset in webkit [249777] by msaboff@apple.com

• 3 edits
  1 add in trunk

JSC crashes due to stack overflow while building RegExp
​https://bugs.webkit.org/show_bug.cgi?id=201649

Reviewed by Yusuke Suzuki.

JSTests:

New regression test.

• stress/regexp-bol-optimize-out-of-stack.js: Added.

(test):
(catch):

Source/JavaScriptCore:

Check for running out of stack when we are optimizing RegExp containing BOL terms or
other deep copying of disjunctions.

• yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
(JSC::Yarr::YarrPatternConstructor::copyTerm):
(JSC::Yarr::YarrPatternConstructor::error):
(JSC::Yarr::YarrPattern::compile):

2:10 PM Changeset in webkit [249776] by Truitt Savell

• 38 edits
  1 copy
  4 moves
  7 adds
  12 deletes in trunk

Unreviewed, rolling out r249753.

caused inspector/canvas/shaderProgram-add-remove-webgl.html to
crash on all Mac platforms.

Reverted changeset:

"Web Inspector: Canvas: instrument WebGPUDevice instead of
GPUCanvasContext"
​https://bugs.webkit.org/show_bug.cgi?id=201650
​https://trac.webkit.org/changeset/249753

1:12 PM Changeset in webkit [249775] by Alan Coon

• 10 edits in branches/safari-608.2.11.1-branch/Source

Apply patch. rdar://problem/55240886

1:12 PM Changeset in webkit [249774] by Alan Coon

• 8 edits in branches/safari-608.2.11.1-branch/Source

Revert "Cherry-pick r249359. rdar://problem/55240886"

1:11 PM Changeset in webkit [249773] by Alan Coon

• 10 edits in branches/safari-608.2.11.1-branch/Source

Revert "Cherry-pick r249748. rdar://problem/55240886"

1:11 PM Changeset in webkit [249772] by Alan Coon

• 1 edit in branches/safari-608.2.11.1-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h

Revert "Cherry-pick r249748. rdar://problem/55240886"

11:03 AM Changeset in webkit [249771] by Kocsen Chung

• 1 edit in branches/safari-608.2.11.1-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h

Cherry-pick r249748. rdar://problem/55240886

Build fix.

10:29 AM Changeset in webkit [249770] by Antti Koivisto

• 6 edits in trunk/Source

REGRESSION (245006): can't scroll in "read more" view in Eventbrite app
​https://bugs.webkit.org/show_bug.cgi?id=201683
<rdar://problem/54582602>

Reviewed by Simon Fraser.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isEventbrite):

Source/WebKit:

Content <body> has 'overflow:hidden'.

• UIProcess/Cocoa/VersionChecks.h:
• UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::hasScrollableMainFrame const):

Fix by adding an app specific LinkedOnOrAfter quirk that always allows main frame scrolling.

10:11 AM Changeset in webkit [249769] by Kocsen Chung

• 1 copy in tags/Safari-609.1.4

Tag Safari-609.1.4.

9:37 AM Changeset in webkit [249768] by achristensen@apple.com

• 52 edits
  1 move
  4 deletes in trunk

Remove unnecessary abstractions around WebsiteDataStore
​https://bugs.webkit.org/show_bug.cgi?id=201655

Reviewed by Chris Dumez.

Source/WebKit:

This patch does four things to simplify WebsiteDataStore code:

1. It removes API::WebsiteDataStore, which was just an unnecessary wrapper around WebKit::WebsiteDataStore.
2. It deprecates the unused aliases of WebsiteDataStore, WKApplicationCacheManagerRef and WKKeyValueStorageManagerRef
3. It removes the unused APIProcessPoolConfiguration properties that have been moved to WebsiteDataStore.
4. It makes WKWebsiteDataStore._delegate weak instead of strong, as already annotated in WKWebsiteDataStorePrivate.h

There should be no change in behavior from this patch.

• PlatformFTW.cmake:
• PlatformWin.cmake:
• Sources.txt:
• SourcesCocoa.txt:
• SourcesGTK.txt:
• SourcesWPE.txt:
• UIProcess/API/APIHTTPCookieStore.cpp:
• UIProcess/API/APIHTTPCookieStore.h:
• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::websiteDataStore):
(API::PageConfiguration::setWebsiteDataStore):

• UIProcess/API/APIPageConfiguration.h:
• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::ProcessPoolConfiguration):
(API::ProcessPoolConfiguration::copy):
(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration): Deleted.

• UIProcess/API/APIProcessPoolConfiguration.h:
• UIProcess/API/APIWebsiteDataStore.cpp: Removed.
• UIProcess/API/APIWebsiteDataStore.h: Removed.
• UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::data):

• UIProcess/API/APIWebsitePolicies.h:
• UIProcess/API/C/WKAPICast.h:
• UIProcess/API/C/WKApplicationCacheManager.cpp:

(WKApplicationCacheManagerGetTypeID):
(WKApplicationCacheManagerGetApplicationCacheOrigins):
(WKApplicationCacheManagerDeleteEntriesForOrigin):
(WKApplicationCacheManagerDeleteAllEntries):

• UIProcess/API/C/WKApplicationCacheManager.h:
• UIProcess/API/C/WKFramePolicyListener.cpp:

(useWithPolicies):

• UIProcess/API/C/WKKeyValueStorageManager.cpp:

(WKKeyValueStorageManagerGetTypeID):
(WKKeyValueStorageManagerGetOriginKey):
(WKKeyValueStorageManagerGetCreationTimeKey):
(WKKeyValueStorageManagerGetModificationTimeKey):
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):
(WKKeyValueStorageManagerDeleteEntriesForOrigin):
(WKKeyValueStorageManagerDeleteAllEntries):

• UIProcess/API/C/WKKeyValueStorageManager.h:
• UIProcess/API/C/WKResourceCacheManager.cpp:

(WKResourceCacheManagerGetTypeID):
(WKResourceCacheManagerGetCacheOrigins):
(WKResourceCacheManagerClearCacheForOrigin):
(WKResourceCacheManagerClearCacheForAllOrigins):
(toWebsiteDataTypes): Deleted.

• UIProcess/API/C/WKResourceCacheManager.h:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreGetTypeID):
(WKWebsiteDataStoreGetDefaultDataStore):
(WKWebsiteDataStoreCreateNonPersistentDataStore):
(WKWebsiteDataStoreCreateWithConfiguration):
(WKWebsiteDataStoreGetHTTPCookieStore):
(WKWebsiteDataStoreSetResourceLoadStatisticsDebugModeWithCompletionHandler):
(WKWebsiteDataStoreSetResourceLoadStatisticsPrevalentResourceForDebugMode):
(WKWebsiteDataStoreSetStatisticsLastSeen):
(WKWebsiteDataStoreSetStatisticsPrevalentResource):
(WKWebsiteDataStoreSetStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreDumpResourceLoadStatistics):
(WKWebsiteDataStoreIsStatisticsPrevalentResource):
(WKWebsiteDataStoreIsStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubresourceUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubFrameUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsRedirectingTo):
(WKWebsiteDataStoreSetStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreIsStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreSetStatisticsGrandfathered):
(WKWebsiteDataStoreIsStatisticsGrandfathered):
(WKWebsiteDataStoreSetStatisticsSubframeUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsCrossSiteLoadWithLinkDecoration):
(WKWebsiteDataStoreSetStatisticsTimeToLiveUserInteraction):
(WKWebsiteDataStoreStatisticsProcessStatisticsAndDataRecords):
(WKWebsiteDataStoreStatisticsUpdateCookieBlocking):
(WKWebsiteDataStoreStatisticsSubmitTelemetry):
(WKWebsiteDataStoreSetStatisticsNotifyPagesWhenDataRecordsWereScanned):
(WKWebsiteDataStoreSetStatisticsIsRunningTest):
(WKWebsiteDataStoreSetStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
(WKWebsiteDataStoreSetStatisticsNotifyPagesWhenTelemetryWasCaptured):
(WKWebsiteDataStoreSetStatisticsMinimumTimeBetweenDataRecordsRemoval):
(WKWebsiteDataStoreSetStatisticsGrandfatheringTime):
(WKWebsiteDataStoreSetStatisticsMaxStatisticsEntries):
(WKWebsiteDataStoreSetStatisticsPruneEntriesDownTo):
(WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStore):
(WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
(WKWebsiteDataStoreStatisticsClearThroughWebsiteDataRemoval):
(WKWebsiteDataStoreStatisticsDeleteCookiesForTesting):
(WKWebsiteDataStoreStatisticsHasLocalStorage):
(WKWebsiteDataStoreSetStatisticsCacheMaxAgeCap):
(WKWebsiteDataStoreStatisticsHasIsolatedSession):
(WKWebsiteDataStoreStatisticsResetToConsistentState):
(WKWebsiteDataStoreRemoveAllFetchCaches):
(WKWebsiteDataStoreRemoveFetchCacheForOrigin):
(WKWebsiteDataStoreRemoveAllIndexedDatabases):
(WKWebsiteDataStoreRemoveLocalStorage):
(WKWebsiteDataStoreRemoveAllServiceWorkerRegistrations):
(WKWebsiteDataStoreGetFetchCacheOrigins):
(WKWebsiteDataStoreGetFetchCacheSizeForOrigin):
(WKWebsiteDataStoreCopyServiceWorkerRegistrationDirectory):
(WKWebsiteDataStoreSetServiceWorkerRegistrationDirectory):
(WKWebsiteDataStoreSetPerOriginStorageQuota):
(WKWebsiteDataStoreClearAllDeviceOrientationPermissions):
(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):
(WKWebsiteDataStoreClearAdClickAttributionsThroughWebsiteDataRemoval):

• UIProcess/API/C/WKWebsitePolicies.cpp:
• UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm: Removed.
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore defaultDataStore]):
(+[WKWebsiteDataStore nonPersistentDataStore]):
(-[WKWebsiteDataStore dealloc]):
(-[WKWebsiteDataStore httpCookieStore]):
(-[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):
(-[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:]):
(+[WKWebsiteDataStore _defaultDataStoreExists]):
(+[WKWebsiteDataStore _deleteDefaultDataStoreForTesting]):
(-[WKWebsiteDataStore _initWithConfiguration:]):
(-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):
(-[WKWebsiteDataStore _resourceLoadStatisticsEnabled]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsEnabled:]):
(-[WKWebsiteDataStore _resourceLoadStatisticsDebugMode]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsDebugMode:]):
(-[WKWebsiteDataStore _perOriginStorageQuota]):
(-[WKWebsiteDataStore _setPerOriginStorageQuota:]):
(-[WKWebsiteDataStore _cacheStorageDirectory]):
(-[WKWebsiteDataStore _setCacheStorageDirectory:]):
(-[WKWebsiteDataStore _serviceWorkerRegistrationDirectory]):
(-[WKWebsiteDataStore _setServiceWorkerRegistrationDirectory:]):
(-[WKWebsiteDataStore _setBoundInterfaceIdentifier:]):
(-[WKWebsiteDataStore _boundInterfaceIdentifier]):
(-[WKWebsiteDataStore _setAllowsCellularAccess:]):
(-[WKWebsiteDataStore _allowsCellularAccess]):
(-[WKWebsiteDataStore _setProxyConfiguration:]):
(-[WKWebsiteDataStore _sourceApplicationBundleIdentifier]):
(-[WKWebsiteDataStore _setSourceApplicationBundleIdentifier:]):
(-[WKWebsiteDataStore _sourceApplicationSecondaryIdentifier]):
(-[WKWebsiteDataStore _setSourceApplicationSecondaryIdentifier:]):
(-[WKWebsiteDataStore _setAllowsTLSFallback:]):
(-[WKWebsiteDataStore _allowsTLSFallback]):
(-[WKWebsiteDataStore _proxyConfiguration]):
(-[WKWebsiteDataStore _indexedDBDatabaseDirectory]):
(-[WKWebsiteDataStore _resourceLoadStatisticsSetShouldSubmitTelemetry:]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsTestingCallback:]):
(-[WKWebsiteDataStore _getAllStorageAccessEntriesFor:completionHandler:]):
(-[WKWebsiteDataStore _scheduleCookieBlockingUpdate:]):
(-[WKWebsiteDataStore _setPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _getIsPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _clearPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _processStatisticsAndDataRecords:]):
(-[WKWebsiteDataStore _hasRegisteredServiceWorker]):
(-[WKWebsiteDataStore _delegate]):
(-[WKWebsiteDataStore set_delegate:]):

• UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h:
• UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp: Removed.
• UIProcess/API/win/APIWebsiteDataStoreWin.cpp:

(API::WebsiteDataStore::defaultApplicationCacheDirectory): Deleted.
(API::WebsiteDataStore::defaultCacheStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultNetworkCacheDirectory): Deleted.
(API::WebsiteDataStore::defaultIndexedDBDatabaseDirectory): Deleted.
(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory): Deleted.
(API::WebsiteDataStore::defaultLocalStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultMediaKeysStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultWebSQLDatabaseDirectory): Deleted.
(API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory): Deleted.
(API::WebsiteDataStore::cacheDirectoryFileSystemRepresentation): Deleted.
(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation): Deleted.

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::websiteDataStoreFromSessionID):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebFramePolicyListenerProxy.cpp:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):

• UIProcess/WebProcessPool.cpp:

(WebKit::m_webProcessCache):
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::establishWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::resolvePathsForSandboxExtensions):
(WebKit::WebProcessPool::tryTakePrewarmedProcess):
(WebKit::WebProcessPool::sendWebProcessDataStoreParameters):
(WebKit::WebProcessPool::processDidFinishLaunching):
(WebKit::WebProcessPool::processForRegistrableDomain):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::mayHaveRegisteredServiceWorkers):

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::defaultApplicationCacheDirectory):
(WebKit::WebsiteDataStore::defaultCacheStorageDirectory):
(WebKit::WebsiteDataStore::defaultNetworkCacheDirectory):
(WebKit::WebsiteDataStore::defaultMediaCacheDirectory):
(WebKit::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):
(WebKit::WebsiteDataStore::defaultLocalStorageDirectory):
(WebKit::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(WebKit::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):
(WebKit::WebsiteDataStore::defaultJavaScriptConfigurationDirectory):
(WebKit::WebsiteDataStore::tempDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::globalDefaultDataStore):
(WebKit::WebsiteDataStore::defaultDataStore):
(WebKit::WebsiteDataStore::deleteDefaultDataStoreForTesting):
(WebKit::WebsiteDataStore::defaultDataStoreExists):
(WebKit::WebsiteDataStore::defaultDataStoreConfiguration):
(WebKit::WebsiteDataStore::isAssociatedProcessPool const):
(WebKit::WebsiteDataStore::processPools const):
(WebKit::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory):

• UIProcess/WebsiteData/WebsiteDataStore.h:
• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:

(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):

• UIProcess/WebsiteData/win/WebsiteDataStoreWin.cpp:

(WebKit::WebsiteDataStore::defaultApplicationCacheDirectory):
(WebKit::WebsiteDataStore::defaultCacheStorageDirectory):
(WebKit::WebsiteDataStore::defaultNetworkCacheDirectory):
(WebKit::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):
(WebKit::WebsiteDataStore::defaultLocalStorageDirectory):
(WebKit::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(WebKit::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):
(WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

• UIProcess/glib/WebsiteDataStoreGLib.cpp: Copied from Source/WebKit/UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp.

(API::WebsiteDataStore::defaultApplicationCacheDirectory): Deleted.
(API::WebsiteDataStore::defaultNetworkCacheDirectory): Deleted.
(API::WebsiteDataStore::defaultCacheStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultIndexedDBDatabaseDirectory): Deleted.
(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory): Deleted.
(API::WebsiteDataStore::defaultLocalStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultMediaKeysStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultWebSQLDatabaseDirectory): Deleted.
(API::WebsiteDataStore::defaultHSTSDirectory): Deleted.
(API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory): Deleted.
(API::WebsiteDataStore::cacheDirectoryFileSystemRepresentation): Deleted.
(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation): Deleted.

• WebKit.xcodeproj/project.pbxproj:

LayoutTests:

• platform/mac-wk2/TestExpectations:

9:36 AM Changeset in webkit [249767] by Kocsen Chung

• 10 edits in branches/safari-608.2.11.1-branch/Source

Cherry-pick r249748. rdar://problem/55240886

Nullptr crash in Page::sessionID() via WebKit::WebFrameLoaderClient::detachedFromParent2()
​https://bugs.webkit.org/show_bug.cgi?id=201625

Reviewed by Ryosuke Niwa.

This is based on a patch from Ryosuke Niwa.

Source/WebCore:

Drop setHasFrameSpecificStorageAccess() in WebCore and call it from the WebKit layer instead.

• dom/DocumentStorageAccess.cpp: (WebCore::DocumentStorageAccess::requestStorageAccess): (WebCore::DocumentStorageAccess::setHasFrameSpecificStorageAccess): Deleted.
• dom/DocumentStorageAccess.h:
• loader/EmptyFrameLoaderClient.h:
• loader/FrameLoaderClient.h:

Source/WebKit:

The crash was caused by WebFrameLoaderClient::sessionID() calling WebPage::sessionID() without
checking the nullity of WebPage::m_page which can be null. Added a null check.

Because passing a wrong session to RemoveStorageAccessForFrame could result in a leak, this patch
also replaces m_hasFrameSpecificStorageAccess boolean with an optioanl struct which stores
session ID, frame ID, and page ID even after WebCore::Frame or WebCore::Page had been cleared
or before WebFrameLoaderClient::m_frame is set.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::sessionID const): (WebKit::WebFrameLoaderClient::setHasFrameSpecificStorageAccess): (WebKit::WebFrameLoaderClient::detachedFromParent2): (WebKit::WebFrameLoaderClient::dispatchWillChangeDocument):
• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebPage/WebFrame.h: (WebKit::WebFrame::frameLoaderClient const):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::requestStorageAccess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:36 AM Changeset in webkit [249766] by Kocsen Chung

• 8 edits in branches/safari-608.2.11.1-branch/Source

Cherry-pick r249359. rdar://problem/55240886

DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID
​https://bugs.webkit.org/show_bug.cgi?id=201364

Reviewed by John Wilander.

Source/WebCore:

DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID. pageID is
redundant since it is being ignored by the callee. For the frame, simply pass the frame object in.

• dom/DocumentStorageAccess.cpp: (WebCore::DocumentStorageAccess::hasStorageAccess): (WebCore::DocumentStorageAccess::requestStorageAccess):
• page/ChromeClient.h: (WebCore::ChromeClient::hasStorageAccess): (WebCore::ChromeClient::requestStorageAccess):

Source/WebKit:

• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::hasStorageAccess): (WebKit::WebChromeClient::requestStorageAccess):
• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::hasStorageAccess): (WebKit::WebPage::requestStorageAccess):
• WebProcess/WebPage/WebPage.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:01 AM Changeset in webkit [249765] by Ryan Haddad

• 10 edits
  4 deletes in trunk

Unreviewed, rolling out r249758.

Breaks the watchOS build.

Reverted changeset:

"[WHLSL] Ensure structs/arrays with pointers as fields are
disallowed"
​https://bugs.webkit.org/show_bug.cgi?id=201525
​https://trac.webkit.org/changeset/249758

8:41 AM Changeset in webkit [249764] by Kocsen Chung

• 7 edits in branches/safari-608.2.11.1-branch/Source

Versioning.

8:36 AM Changeset in webkit [249763] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, re-skip service worker test that was unskipped in r249716

This test is still a flaky timeout.

• TestExpectations:

7:52 AM Changeset in webkit [249762] by ajuma@chromium.org

• 4 edits in trunk/Source/WebCore

Prevent reentrancy FrameLoader::dispatchUnloadEvents()
​https://bugs.webkit.org/show_bug.cgi?id=200738

Reviewed by Brady Eidson.

Reentrancy causes m_pageDismissalEventBeingDispatched to be incorrectly
updated, so don't allow reentrancy.

Since this prevents m_pageDismissalEventBeingDispatched from being reset
inside a reentrant call, it can have the unintended effect of causing
FrameLoader::stopAllLoaders to early-out when called from
FrameLoader::detachFromParent while a frame's unload event handler
calls document.open() on a parent frame and causes itself to become
detached. Allowing a load to continue in a detached frame will lead to
a crash. To prevent this, add a new argument to FrameLoader::stopAllLoaders
that FrameLoader::detachFromParent can use to prevent an early-out.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::dispatchUnloadEvents):
(WebCore::FrameLoader::dispatchBeforeUnloadEvent):
Ensure that m_pageDismissalEventBeingDispatched is reset to its previous value, even if this is not None.

• loader/FrameLoader.h:
• loader/FrameLoaderTypes.h:

Add a StopLoadingPolicy enum.

4:49 AM Changeset in webkit [249761] by cturner@igalia.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Do not adopt floating references.
​https://bugs.webkit.org/show_bug.cgi?id=201685

Reviewed by Carlos Garcia Campos.

Covered by existing tests.

• platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer): gst_element_factory_make returns
floating references, you do not adopt such references, rather you
sink them.

4:34 AM Changeset in webkit [249760] by commit-queue@webkit.org

• 87 edits
  8 copies
  3 moves
  169 adds
  5 deletes in trunk/LayoutTests

Bug 201603 - Synchronize MathML WPT tests against upstream
​https://bugs.webkit.org/show_bug.cgi?id=201603

Patch by Frederic Wang <​fwang@igalia.com> on 2019-09-11
Reviewed by Rob Buis.

LayoutTests/imported/w3c:

• resources/resource-files.json:
• web-platform-tests/mathml/presentation-markup/direction/direction-006-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-006.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-007-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-007.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-008-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-008.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-009-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-009.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-010-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-010.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-overall-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-overall.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-token-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction-token.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/direction.html: Added.
• web-platform-tests/mathml/presentation-markup/direction/w3c-import.log: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-1.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-bar-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-002.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically-2-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically-2.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically-3-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically-3.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-created-dynamically.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001-expected.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.html: Removed.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-004-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-004.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-mrow-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001-expected.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-001-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-001.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-002-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-002.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-003-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-003.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-004-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-004.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-005-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-005.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-006-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-gap-006.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-visibility-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline.html: Added.
• web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-stretchy-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-stretchy.html: Added.
• web-platform-tests/mathml/presentation-markup/mrow/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/w3c-import.log.
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-form-dynamic-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-dynamic.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-minus-plus-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form-minus-plus.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-form.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-default-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-default.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-dynamic-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-dynamic.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-paint-lspace-rspace-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-paint-lspace-rspace.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-3.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-4.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-5.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html:
• web-platform-tests/mathml/presentation-markup/spaces/mspace-children-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/mspace-children.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-1.html:
• web-platform-tests/mathml/presentation-markup/spaces/space-2.html:
• web-platform-tests/mathml/presentation-markup/spaces/space-like-001-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-001.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-002-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-002.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-003-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-003.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-004-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/spaces/space-like-004.html: Added.
• web-platform-tests/mathml/presentation-markup/spaces/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html:
• web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/attribute-mapping-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/color-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/color-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/color-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/color-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/color-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/color-003.html: Added.
• web-platform-tests/mathml/relations/css-styling/color-004-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/color-004.html: Added.
• web-platform-tests/mathml/relations/css-styling/color-1.html: Removed.
• web-platform-tests/mathml/relations/css-styling/display-1.html:
• web-platform-tests/mathml/relations/css-styling/display-contents-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/display-contents.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-011-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-011.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-012-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-012.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-013-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-013.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-014-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-014.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-015-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-015.html: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-1-expected.txt:
• web-platform-tests/mathml/relations/css-styling/displaystyle-1.html:
• web-platform-tests/mathml/relations/css-styling/displaystyle-2-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/displaystyle-2.html: Added.
• web-platform-tests/mathml/relations/css-styling/dynamic-dir-1-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/dynamic-dir-1.html: Added.
• web-platform-tests/mathml/relations/css-styling/lengths-1.html:
• web-platform-tests/mathml/relations/css-styling/lengths-2-expected.html: Removed.
• web-platform-tests/mathml/relations/css-styling/lengths-2-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/lengths-2.html:
• web-platform-tests/mathml/relations/css-styling/lengths-3-expected.txt: Removed.
• web-platform-tests/mathml/relations/css-styling/lengths-3.html: Removed.
• web-platform-tests/mathml/relations/css-styling/mathbackground-001-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-001-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-002-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-002-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-003-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-003-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-003.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-004-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-004-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathbackground-004.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-001-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-001-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-002-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-002-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-003-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-003-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-003.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-004-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-004-notref.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathcolor-004.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-css-keywords-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-css-keywords.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-legacy-values-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-legacy-values.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathvariant-auto-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathvariant-auto.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-case-sensitivity-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathvariant-case-sensitivity.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-initial-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-initial.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-italic-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-looped-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-looped.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-monospace-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-monospace.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-bold-italic-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-bold-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-italic-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-script-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-script.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-stretched-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-stretched.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-tailed-expected.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-tailed.html:
• web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-002-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-border-margin-001-expected.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-border-margin-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/w3c-import.log: Added.
• web-platform-tests/mathml/relations/css-styling/visibility-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/visibility-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/visibility-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/visibility-002.html: Added.
• web-platform-tests/mathml/relations/css-styling/visibility-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/visibility-003.html: Added.
• web-platform-tests/mathml/relations/css-styling/visibility-004-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-1-expected.html.
• web-platform-tests/mathml/relations/css-styling/visibility-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-1.html.
• web-platform-tests/mathml/relations/css-styling/w3c-import.log:
• web-platform-tests/mathml/relations/css-styling/width-height-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/width-height-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/writing-mode/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/w3c-import.log.
• web-platform-tests/mathml/relations/css-styling/writing-mode/writing-mode-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/writing-mode/writing-mode-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/writing-mode/writing-mode-002-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/writing-mode/writing-mode-002.html: Added.
• web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative-expected.txt:
• web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative.html:
• web-platform-tests/mathml/relations/text-and-math/use-typo-metrics-1.html:
• web-platform-tests/mathml/tools/fractions.py:
• web-platform-tests/mathml/tools/math-text.py: Added.
• web-platform-tests/mathml/tools/mathvariant-transforms.py:
• web-platform-tests/mathml/tools/percentscaledown.py: Added.
• web-platform-tests/mathml/tools/stacks.py:
• web-platform-tests/mathml/tools/w3c-import.log:

LayoutTests:

• TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-2-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt: Added.
• platform/mac-wk1/TestExpectations:

1:28 AM Changeset in webkit [249759] by Carlos Garcia Campos

• 12 edits
  2 deletes in trunk/Tools

[GTK][WPE] Stop using the session bus in the unit tests
​https://bugs.webkit.org/show_bug.cgi?id=201636

Reviewed by Žan Doberšek.

We are actually using GTestDBus, not the actual session bus of the user session, but it would still be better to
use a private p2p DBus connection. This is also the way we encourage apps to implement the communication with
the web process extension. This patch removes the WebKitTestBus class and starts a DBus server before every
test. The server address is passed to the web extension as initialization parameter to connect directly to
it. We keep a global list of connections to the server and a HashMap to get the current active connection for
a WebKitWebView.

• TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:

(beforeAll):
(afterAll):

• TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:

(testProcessPerWebView):
(beforeAll):
(afterAll):

• TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebExtensionGetTitle):
(testWebExtensionInputElementIsUserEdited):
(testDocumentLoadedSignal):
(testWebKitWebViewProcessCrashed):
(testWebExtensionIsolatedWorld):
(testInstallMissingPluginsPermissionRequest):
(testWebExtensionFormControlsAssociated):
(FormSubmissionTest::FormSubmissionTest):
(beforeAll):
(afterAll):

• TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:

(DelayedSignal::DelayedSignal):
(emitPageCreated):
(pageCreatedCallback):
(webkit_web_extension_initialize_with_user_data):

• TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
• TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:

(AccessibilityTest::AccessibilityTest):
(AccessibilityTest::ensureProxy):
(beforeAll):
(afterAll):

• TestWebKitAPI/glib/CMakeLists.txt:
• TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:

(dbusConnectionClosed):
(dbusServerConnection):
(startDBusServer):
(stopDBusServer):
(main):

• TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::initializeWebExtensions):

• TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Removed.
• TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Removed.
• TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::~WebViewTest):
(WebViewTest::extensionProxy):

• TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:

12:17 AM Changeset in webkit [249758] by sbarati@apple.com

• 10 edits
  4 adds in trunk

[WHLSL] Ensure structs/arrays with pointers as fields are disallowed
​https://bugs.webkit.org/show_bug.cgi?id=201525

Reviewed by Robin Morisset.

Source/WebCore:

This patch adds a pass which both ensures that references are always initialized with
concrete values and that we support logical mode validation by disallowing nested references.

Specifically, the pass:

1. Disallows structs to have fields which are references. This prevents us from having to

figure out how to default initialize such a struct. We could relax this in the future if we
did an analysis on which structs contain reference fields, and ensure such struct variables
always have initializers. This would also require us to create constructors for structs which
initialize each field.

2. We also do the same for arrays.
3. References can only be one level deep. So no pointers to pointers. No references to

references, etc. This is to support logical mode validation rules.

Test: webgpu/whlsl/ensure-proper-pointer-usage.html

• Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.cpp: Added.

(WebCore::WHLSL::checkReferenceTypes):

• Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.h: Added.
• Modules/webgpu/WHLSL/WHLSLChecker.cpp:

(WebCore::WHLSL::Checker::visit):

• Modules/webgpu/WHLSL/WHLSLPrepare.cpp:

(WebCore::WHLSL::prepareShared):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

This patch fixes a bug in our test harness where we forgot to wait for the gpu
device to load before running test harness tests. This patch fixes this oversight
and asserts that we have always finished loading before running a test.

• webgpu/whlsl/array-spec-tests.html:
• webgpu/whlsl/ensure-proper-pointer-usage-expected.txt: Added.
• webgpu/whlsl/ensure-proper-pointer-usage.html: Added.
• webgpu/whlsl/js/test-harness.js:

(Harness):
(Harness.prototype.async.requestDevice):
(Harness.prototype.async.callTypedFunction):
(Harness.prototype.async.checkCompileFail):

• webgpu/whlsl/pointer-spec-tests.html:
• webgpu/whlsl/test-harness-test.html:

12:01 AM Changeset in webkit [249757] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

REGRESSION: Scrubbing on ted.com does not work well
​https://bugs.webkit.org/show_bug.cgi?id=201635
<rdar://problem/51463649>

Patch by Antoine Quint <Antoine Quint> on 2019-09-11
Reviewed by Dean Jackson.

This website uses custom media controls that simply don't work well on iOS when the User-Agent string is the desktop one, so we default to the mobile UA.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingRecommendedForRequest):