Timeline

Sep 21, 2019:

11:12 PM Changeset in webkit [250197] by mitz@apple.com

• 2 edits in trunk/Source/WebKit

Fix an assertion failure introduced in r250186.

• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformGetLaunchOptionsWithAttributes): Corrected the

assertion.

11:04 PM Changeset in webkit [250196] by Chris Dumez

• 24 edits in trunk/Source

Reduce use of SessionID::defaultSessionID() in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=202080

Reviewed by Alex Christensen.

Source/WebCore:

Reduce use of SessionID::defaultSessionID() in WebKit. Falling back to the default session
when you don't know which session to use is never a good idea and a potential privacy issue.

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):

• dom/Document.cpp:

(WebCore::Document::logger):

• dom/Document.h:
• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAdClickAttribution const):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):

• loader/EmptyFrameLoaderClient.h:
• loader/FrameLoaderClient.h:
• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::updateCachedResourceWithCurrentRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):

• loader/cache/CachedResourceLoader.h:

(WebCore::CachedResourceLoader::clearDocumentLoader):

• page/Frame.cpp:
• page/Frame.h:
• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::isAlwaysOnLoggingAllowed const):

Source/WebKit:

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::convertMainResourceLoadToDownload):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertMainResourceLoadToDownload):

• WebProcess/WebPage/WebFrame.h:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::convertMainResourceLoadToDownload):

Source/WebKitLegacy/win:

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::convertMainResourceLoadToDownload):

• WebCoreSupport/WebFrameLoaderClient.h:

10:17 PM Changeset in webkit [250195] by Chris Dumez

• 7 edits in trunk/Source/WebCore

ServiceWorkerContextData does not need a sessionID
​https://bugs.webkit.org/show_bug.cgi?id=202087

Reviewed by Alex Christensen.

• workers/service/ServiceWorkerContextData.cpp:

(WebCore::ServiceWorkerContextData::isolatedCopy const):

• workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

• workers/service/server/RegistrationDatabase.cpp:

(WebCore::RegistrationDatabase::RegistrationDatabase):
(WebCore::RegistrationDatabase::importRecords):

• workers/service/server/RegistrationDatabase.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::updateWorker):

• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::contextData const):

10:17 PM Changeset in webkit [250194] by Chris Dumez

• 3 edits in trunk/Source/WebKit

Drop unnecessary NetworkProcess::m_sessionByConnection
​https://bugs.webkit.org/show_bug.cgi?id=202088

Reviewed by Alex Christensen.

• NetworkProcess/NetworkProcess.cpp:
• NetworkProcess/NetworkProcess.h:

10:16 PM Changeset in webkit [250193] by Chris Dumez

• 7 edits in trunk/Source

WebIDBConnectionToClient does not need to be RefCounted or a SessionID
​https://bugs.webkit.org/show_bug.cgi?id=202089

Reviewed by Alex Christensen.

Source/WebCore:

Drop some dead code.

• Modules/indexeddb/server/IDBConnectionToClientDelegate.h:

Source/WebKit:

WebIDBConnectionToClient does not need to be RefCounted, the ref() / deref() virtual function
it implemented from its interface were dead code. We now stop subclassing RefCounted and have
the NetworkConnectionToWebProcess fully own the WebIDBConnectionToClient. Instead of the
WebIDBConnectionToClient having 3 data members for the NetworkProcess, the sessionID and the IPC
connection, use a single data member to its NetworkConnectionToWebProcess parent. It can get
everything it needs from its parent.

• NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::WebIDBConnectionToClient):
(WebKit::WebIDBConnectionToClient::idbServer):
(WebKit::WebIDBConnectionToClient::disconnectedFromWebProcess):
(WebKit::WebIDBConnectionToClient::messageSenderConnection const):
(WebKit::WebIDBConnectionToClient::connectionToClient):
(WebKit::WebIDBConnectionToClient::deleteDatabase):
(WebKit::WebIDBConnectionToClient::openDatabase):
(WebKit::WebIDBConnectionToClient::abortTransaction):
(WebKit::WebIDBConnectionToClient::commitTransaction):
(WebKit::WebIDBConnectionToClient::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToClient::createObjectStore):
(WebKit::WebIDBConnectionToClient::deleteObjectStore):
(WebKit::WebIDBConnectionToClient::renameObjectStore):
(WebKit::WebIDBConnectionToClient::clearObjectStore):
(WebKit::WebIDBConnectionToClient::createIndex):
(WebKit::WebIDBConnectionToClient::deleteIndex):
(WebKit::WebIDBConnectionToClient::renameIndex):
(WebKit::WebIDBConnectionToClient::putOrAdd):
(WebKit::WebIDBConnectionToClient::getRecord):
(WebKit::WebIDBConnectionToClient::getAllRecords):
(WebKit::WebIDBConnectionToClient::getCount):
(WebKit::WebIDBConnectionToClient::deleteRecord):
(WebKit::WebIDBConnectionToClient::openCursor):
(WebKit::WebIDBConnectionToClient::iterateCursor):
(WebKit::WebIDBConnectionToClient::establishTransaction):
(WebKit::WebIDBConnectionToClient::databaseConnectionPendingClose):
(WebKit::WebIDBConnectionToClient::databaseConnectionClosed):
(WebKit::WebIDBConnectionToClient::abortOpenAndUpgradeNeeded):
(WebKit::WebIDBConnectionToClient::didFireVersionChangeEvent):
(WebKit::WebIDBConnectionToClient::openDBRequestCancelled):
(WebKit::WebIDBConnectionToClient::confirmDidCloseFromServer):
(WebKit::WebIDBConnectionToClient::getAllDatabaseNames):

• NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::establishIDBConnectionToServer):

• NetworkProcess/NetworkConnectionToWebProcess.h:

10:15 PM Changeset in webkit [250192] by Chris Dumez

• 6 edits in trunk/Source/WebCore

[CURL] CurlRequest does not need a sessionID
​https://bugs.webkit.org/show_bug.cgi?id=202086

Reviewed by Alex Christensen.

• platform/network/curl/CurlFormDataStream.cpp:

(WebCore::CurlFormDataStream::CurlFormDataStream):

• platform/network/curl/CurlFormDataStream.h:
• platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::CurlRequest):

• platform/network/curl/CurlRequest.h:

(WebCore::CurlRequest::create):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::createCurlRequest):

10:15 PM Changeset in webkit [250191] by Chris Dumez

• 5 edits in trunk/Source/WebCore

CookieRequestHeaderFieldProxy does not need a SessionID
​https://bugs.webkit.org/show_bug.cgi?id=202084

Reviewed by Alex Christensen.

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didOpenSocketStream):

• loader/CookieJar.cpp:

(WebCore::CookieJar::cookieRequestHeaderFieldProxy):

• loader/CookieJar.h:
• platform/network/CookieRequestHeaderFieldProxy.h:

(WebCore::CookieRequestHeaderFieldProxy::encode const):
(WebCore::CookieRequestHeaderFieldProxy::decode):

10:14 PM Changeset in webkit [250190] by Chris Dumez

• 3 edits in trunk/Source/WebCore

DocumentLoader::m_temporaryServiceWorkerClient does not need a sessionID
​https://bugs.webkit.org/show_bug.cgi?id=202083

Reviewed by Alex Christensen.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::registerTemporaryServiceWorkerClient):
(WebCore::DocumentLoader::unregisterTemporaryServiceWorkerClient):

• loader/DocumentLoader.h:

9:01 PM Changeset in webkit [250189] by mark.lam@apple.com

• 6 edits in trunk/Source/JavaScriptCore

Move JSLexicalEnvironment, DirectArguments, and ScopedArguments cells out of the Gigacage.
​https://bugs.webkit.org/show_bug.cgi?id=202082

Reviewed by Tadeu Zagallo.

They are not being caged anyway.

• runtime/DirectArguments.h:
• runtime/JSLexicalEnvironment.h:

(JSC::JSLexicalEnvironment::subspaceFor):

• runtime/ScopedArguments.h:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

7:40 PM Changeset in webkit [250188] by Brent Fulgham

• 10 edits in trunk/Source/WebCore

[FTW] Resolve crashes found while running canvas tests
​https://bugs.webkit.org/show_bug.cgi?id=202062

Reviewed by Don Olmstead.

• platform/graphics/Pattern.h:
• platform/graphics/win/Direct2DOperations.cpp:

(WebCore::Direct2D::FillSource::FillSource): Take GraphicsContext as argument, rather than
a PlatformContextDirect2D since downstream operations require the former.
(WebCore::Direct2D::StrokeSource::StrokeSource): Ditto.
(WebCore::Direct2D::clip): Use new 'pushClip' helper function.

• platform/graphics/win/Direct2DOperations.h:
• platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::strokeRect):

• platform/graphics/win/GraphicsContextImplDirect2D.cpp:

(WebCore::GraphicsContextImplDirect2D::fillRect): Update to pass GraphicsContext.
(WebCore::GraphicsContextImplDirect2D::fillRectWithRoundedHole): Ditto.
(WebCore::GraphicsContextImplDirect2D::fillPath): Ditto.
(WebCore::GraphicsContextImplDirect2D::strokeRect): Ditto.
(WebCore::GraphicsContextImplDirect2D::strokePath): Ditto.
(WebCore::GraphicsContextImplDirect2D::drawGlyphs): Ditto.

• platform/graphics/win/ImageBufferDataDirect2D.cpp:

(WebCore::ImageBufferData::copyRectFromSourceToData): Correct return behavior.
(WebCore::ImageBufferData::compatibleBitmap): Make a copy if the render target is
backed by the ID2D1Bitmap we are trying to draw with.

• platform/graphics/win/PatternDirect2D.cpp:

(WebCore::Pattern::createPlatformPattern const): Remove 'PlatformContextDirect2D' contructor,
since we always need a GraphicsContext for the Image class.

• platform/graphics/win/PlatformContextDirect2D.cpp:

(WebCore::PlatformContextDirect2D::clipLayer const): Added.
(WebCore::PlatformContextDirect2D::clearClips): Added.
(WebCore::PlatformContextDirect2D::restore): Update to use m_stateStack, rather than
the m_renderStates vector.
(WebCore::PlatformContextDirect2D::save): Ditto.
(WebCore::PlatformContextDirect2D::pushRenderClip): Ditto.
(WebCore::PlatformContextDirect2D::setActiveLayer): Ditto.
(WebCore::PlatformContextDirect2D::endDraw): Ditto.
(WebCore::PlatformContextDirect2D::notifyPostDrawObserver): Ditto.
(WebCore::PlatformContextDirect2D::pushClip): Ditto.

• platform/graphics/win/PlatformContextDirect2D.h:

(WebCore::PlatformContextDirect2D::hasSavedState const):
(WebCore::PlatformContextDirect2D::clipLayer const): Deleted.

4:13 PM Changeset in webkit [250187] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Regression(iOS 13) web views do not deal properly with their window's UIScene changing
​https://bugs.webkit.org/show_bug.cgi?id=202070
<rdar://problem/55580699>

Reviewed by Tim Horton.

Web views do not deal properly with their window's UIScene changing. If a Safari window is in the
background for 1 minute, its UIScene will be detached and the window will get a new UIScene if
the user later switches to this window. Our web views listen to UIScene notifications to determine
their visibility and currently stop receiving visibility updates once the window’s UIScene has
changed. This causes view freezes because our WebContent process does not know its view is visible
and keeps its layer tree frozen.

Previously, when our view would be added to a window, we would get this window's UIScene and listen
for UISceneDidEnterBackgroundNotification / UISceneWillEnterForegroundNotification for this UIScene
object. Instead, we now listen to these notifications for ALL the application's UIScenes. Our handler
then checks if the notification's UIScene object matches the current window's UIScene before
forwarding the notification to the rest of WebKit.

• UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):
(WebKit::ApplicationStateTracker::~ApplicationStateTracker):

3:57 PM Changeset in webkit [250186] by mitz@apple.com

• 4 edits in trunk/Source/WebKit

Safari 13 may launch leftover 32-bit plug-in process from Safari 12’s WebKit, which crashes
​https://bugs.webkit.org/show_bug.cgi?id=202077
<rdar://problem/55547063>

Reviewed by Sam Weinig.

• Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::getPluginArchitecture): Removed support for i386 plug-ins.

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName): Assert that the requested process type is not Plugin32.

• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformGetLaunchOptionsWithAttributes): Assert that the

plug-in architecture is x86_64.

1:20 PM Changeset in webkit [250185] by Caio Lima

• 2 edits in trunk/JSTests

stress/test-out-of-memory.js is not throwing OOM into ARMv7 and MIPS
​https://bugs.webkit.org/show_bug.cgi?id=202011

Reviewed by Mark Lam.

We are skipping this test into MIPS and ARMv7 because some of its assumptions
are not valid for them. The current behavior of the test in those architectures
is that it does not throw during new ArrayBuffer(1000) allocation site,
because eden collection keeps happening between iterations. The collection
is triggered on those architectures because the amount of stress
new Promise generates into GC limits is not enough to avoid them
while loop is executing.

Changing the size of UInt8Array from 80000000 to 160000000 can
be an alternative fix to avoid collection happening during ArrayBuffer
allocation loop, but we can't guarantee this test is always going to execute
without error when Gigacage is disabled, given we can reach an OOM state in
some allocations that need to succeed, making this test flaky for those
architectures.

• stress/test-out-of-memory.js:

11:30 AM Changeset in webkit [250184] by Tadeu Zagallo

• 14 edits
  1 add in trunk

AccessCase should strongly visit its dependencies while on stack
​https://bugs.webkit.org/show_bug.cgi?id=201986
<rdar://problem/55521953>

Reviewed by Saam Barati and Yusuke Suzuki.

JSTests:

• stress/ftl-put-by-id-setter-exception-interesting-live-state-2.js: Added.

(foo):
(warmup):

Source/JavaScriptCore:

AccessCase::doesCalls is responsible for specifying the cells it depends on, so that
MarkingGCAwareJITStubRoutine can strongly visit them while the stub is on stack. However,
it was missing most of its dependencies, which led to it being collected while on stack.
This manifested in the flaky test stress/ftl-put-by-id-setter-exception-interesting-live-state.js
as the PolymorphicAccess being collected and removing its exception handler from the code
block, which led to exception propagating past the try/catch.

In order to fix this, we abstract the dependency gathering logic from AccessCase into
forEachDependentCell and use it to implement visitWeak as well as doesCalls in order to
guarantee that their implementation is consistent.

• bytecode/AccessCase.cpp:

(JSC::AccessCase::forEachDependentCell const):
(JSC::AccessCase::doesCalls const):
(JSC::AccessCase::visitWeak const):

• bytecode/AccessCase.h:
• bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::lastSeenCallee const):
(JSC::CallLinkInfo::haveLastSeenCallee const):
(JSC::CallLinkInfo::lastSeenCallee): Deleted.
(JSC::CallLinkInfo::haveLastSeenCallee): Deleted.

• bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::isDirect const):
(JSC::CallLinkInfo::isLinked const):
(JSC::CallLinkInfo::stub const):
(JSC::CallLinkInfo::forEachDependentCell const):
(JSC::CallLinkInfo::isLinked): Deleted.
(JSC::CallLinkInfo::stub): Deleted.

• bytecode/ObjectPropertyCondition.cpp:

(JSC::ObjectPropertyCondition::isStillLive const):

• bytecode/ObjectPropertyCondition.h:

(JSC::ObjectPropertyCondition::forEachDependentCell const):

• bytecode/ObjectPropertyConditionSet.cpp:

(JSC::ObjectPropertyConditionSet::areStillLive const):

• bytecode/ObjectPropertyConditionSet.h:

(JSC::ObjectPropertyConditionSet::forEachDependentCell const):

• bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::isStillLive const):

• bytecode/PropertyCondition.h:

(JSC::PropertyCondition::forEachDependentCell const):

• jit/PolymorphicCallStubRoutine.cpp:

(JSC::PolymorphicCallStubRoutine::visitWeak):

• jit/PolymorphicCallStubRoutine.h:

(JSC::PolymorphicCallStubRoutine::forEachDependentCell):

9:08 AM Changeset in webkit [250183] by graouts@webkit.org

• 4 edits
  4 adds in trunk

[Pointer Events] touch-action set to pan-x or pan-y alone should disable scrolling altogether if the intial gesture is in the disallowed direction
​https://bugs.webkit.org/show_bug.cgi?id=202053
<rdar://problem/54542190>

Reviewed by Tim Horton.

Source/WebKit:

Although the Pointer Events specification does not specify this clearly (see ​https://github.com/w3c/pointerevents/issues/303), setting "touch-action" to a value
that only allows scrolling a specific direction ("pan-x" or "pan-y") should disable scrolling in the specified direction if the panning gesture initially is directed
in the opposite direction. In practice, this means that setting "touch-action: pan-y" on an element should disable scrolling if the user initially pans horizontally,
even if later on in the gesture the user pans vertically. This allows for sites that want to offer a programmatic horizontal scroller to disable vertical scrolling
if the user pans horizontally.

In order to support this, we add four UISwipeGestureRecognizers, one for each direction, and we selectively allows touches to be recognizer for them based on the
"touch-action" value specified at the initial touch location for a given gesture. In the case of "touch-action: pan-y" we only allow the left and right swipe recognizers
to be enabled, and in the case of "touch-action: pan-x" we only allow the up and down swipe recognizers to be enabled. If any of those gesture recognizers is recognized,
scrolling will be disabled for the duration of this gesture. If a UIScrollView panning gesture recognizer is recognized prior to a swipe, they won't have a chance to be
recognized.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):

LayoutTests:

Add new tests checking that setting "touch-action: pan-y" on an element and initiating a horizontal panning gesture will disallow scrolling vertically
if a vertical scrolling gesture follows. We test both the case where scrolling would apply to the whole page and the case where scrolling would apply
to an "overflow: scroll" element.

• pointerevents/ios/touch-action-pan-y-horizontal-gesture-prevents-vertical-scrolling-expected.txt: Added.
• pointerevents/ios/touch-action-pan-y-horizontal-gesture-prevents-vertical-scrolling.html: Added.
• pointerevents/ios/touch-action-pan-y-in-overflow-scroll-horizontal-gesture-prevents-vertical-scrolling-expected.txt: Added.
• pointerevents/ios/touch-action-pan-y-in-overflow-scroll-horizontal-gesture-prevents-vertical-scrolling.html: Added.

8:34 AM Changeset in webkit [250182] by graouts@webkit.org

• 5 edits
  4 adds in trunk

releasePointerCapture() not working for implicit capture; can't opt-in to pointerenter/leave for touches
​https://bugs.webkit.org/show_bug.cgi?id=199803
<rdar://problem/53127223>

Reviewed by Dean Jackson.

Source/WebCore:

In order to dispatch boundary events (pointerover/out/enter/leave) when the implicit pointer capture is released on iOS,
we need to track the target of the pointer events that was dispatched last for a given pointer id. Then we compare that
target with the current target when dispatching a new pointer event and determine whether we should dispatch boundary
events using the exact same approach used to dispatch mouse boundary events in EventHandler::updateMouseEventTargetNode().

Tests: pointerevents/ios/boundary-events-through-hierarchy-without-pointer-capture.html

pointerevents/ios/boundary-events-without-pointer-capture.html

• page/PointerCaptureController.cpp:

(WebCore::hierarchyHasCapturingEventListeners):
(WebCore::PointerCaptureController::dispatchEventForTouchAtIndex):
(WebCore::PointerCaptureController::pointerEventWillBeDispatched):
(WebCore::PointerCaptureController::ensureCapturingDataForPointerEvent):
(WebCore::PointerCaptureController::cancelPointer):

• page/PointerCaptureController.h:

LayoutTests:

Add new tests that check we correctly dispatch boundary events on iOS when pointer capture is disabled.

• pointerevents/ios/boundary-events-through-hierarchy-without-pointer-capture-expected.txt: Added.
• pointerevents/ios/boundary-events-through-hierarchy-without-pointer-capture.html: Added.
• pointerevents/ios/boundary-events-without-pointer-capture-expected.txt: Added.
• pointerevents/ios/boundary-events-without-pointer-capture.html: Added.
• pointerevents/utils.js:

6:51 AM Changeset in webkit [250181] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC] LayoutContext::m_formattingContextRootListForLayout should be a WeakHashSet
​https://bugs.webkit.org/show_bug.cgi?id=202068
<rdar://problem/55579352>

Reviewed by Alex Christensen.

• layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::layout):
(WebCore::Layout::LayoutContext::styleChanged):
(WebCore::Layout::LayoutContext::markNeedsUpdate):

• layout/LayoutContext.h:
• page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

4:39 AM Changeset in webkit [250180] by ddkilzer@apple.com

• 12 edits in trunk/Source

clang-tidy: Fix unnecessary copy/ref churn of for loop variables in WTF/JavaScriptCore
<​https://webkit.org/b/202069>

Reviewed by Mark Lam.

Fix unwanted copying/ref churn of loop variables by making them
const references.

Source/JavaScriptCore:

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setConstantIdentifierSetRegisters):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::activateExtraDomains):

• inspector/remote/cocoa/RemoteInspectorCocoa.mm:

(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::xpcConnectionFailed):
(Inspector::RemoteInspector::pushListingsNow):

• parser/Parser.h:

(JSC::Scope::computeLexicallyCapturedVariablesAndPurgeCandidates):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::performGetOwnPropertyNames):

• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::registerForReportAtExit):
(JSC::SamplingProfiler::reportTopFunctions):
(JSC::SamplingProfiler::reportTopBytecodes):

• runtime/TypeSet.cpp:

(JSC::StructureShape::inspectorRepresentation):
(JSC::StructureShape::merge):

Source/WTF:

• wtf/AggregateLogger.h:

(WTF::AggregateLogger::log const):

Sep 20, 2019:

11:37 PM Changeset in webkit [250179] by aestes@apple.com

• 21 edits
  3 copies
  1 add in trunk/Source

[Apple Pay] Clean up handling of summary items and payment method updates
​https://bugs.webkit.org/show_bug.cgi?id=202018
<rdar://problem/55470632>

Reviewed by Tim Horton.

Source/WebCore:

Replaced the PaymentMethodUpdate struct with a class that knows how to convert from
ApplePayPaymentMethodUpdate structs to PKPaymentRequestPaymentMethodUpdate instances.

Moved some scattered-around free functions for converting payment summary items into
PaymentSummaryItems{.h,Cocoa.mm}.

• Modules/applepay/ApplePayPaymentMethodUpdate.h:
• Modules/applepay/ApplePaySession.cpp:

(WebCore::finishConverting):
(WebCore::convertAndValidateTotal):
(WebCore::convertAndValidate):

• Modules/applepay/ApplePaySessionPaymentRequest.h:
• Modules/applepay/PaymentCoordinator.h:
• Modules/applepay/PaymentCoordinatorClient.h:
• Modules/applepay/PaymentHeaders.h:
• Modules/applepay/PaymentMethodUpdate.h: Added.
• Modules/applepay/PaymentSummaryItems.h: Added.
• Modules/applepay/cocoa/PaymentMethodUpdateCocoa.mm: Added.

(WebCore::PaymentMethodUpdate::PaymentMethodUpdate):
(WebCore::PaymentMethodUpdate::totalAndLineItems const):
(WebCore::PaymentMethodUpdate::platformUpdate const):

• Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm: Added.

(WebCore::toDecimalNumber):
(WebCore::toPKPaymentSummaryItemType):
(WebCore::toPKPaymentSummaryItem):
(WebCore::platformSummaryItems):

• Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::paymentMethodUpdated):

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::completePaymentMethodSelection):

Source/WebKit:

Now that PaymentMethodUpdate knows how to convert itself to a
PKPaymentRequestPaymentMethodUpdate, PaymentAuthorizationPresenter can merely pass the
converted update directly to the platform delegate rather than passing the individual
components and relying on the delegate to instantiate the platform update itself. Added
FIXMEs for applying a similar treatment to ShippingContactUpdate and ShippingMethodUpdate.

• Platform/cocoa/PaymentAuthorizationPresenter.h:
• Platform/cocoa/PaymentAuthorizationPresenter.mm:

(WebKit::PaymentAuthorizationPresenter::completePaymentMethodSelection):
(WebKit::PaymentAuthorizationPresenter::completeShippingContactSelection):
(WebKit::PaymentAuthorizationPresenter::completeShippingMethodSelection):

• Platform/cocoa/WKPaymentAuthorizationDelegate.h:
• Platform/cocoa/WKPaymentAuthorizationDelegate.mm:

(-[WKPaymentAuthorizationDelegate completePaymentMethodSelection:]):
(-[WKPaymentAuthorizationDelegate completeShippingContactSelection:]):
(-[WKPaymentAuthorizationDelegate completeShippingMethodSelection:]):
(-[WKPaymentAuthorizationDelegate _didSelectPaymentMethod:completion:]):
(-[WKPaymentAuthorizationDelegate _didSelectShippingContact:completion:]):
(-[WKPaymentAuthorizationDelegate _didSelectShippingMethod:completion:]):
(-[WKPaymentAuthorizationDelegate completeShippingContactSelection:summaryItems:shippingMethods:errors:]): Deleted.

• Shared/ApplePay/WebPaymentCoordinatorProxy.h:
• Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
• Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest):
(WebKit::toPKPaymentSummaryItemType): Deleted.
(WebKit::toPKPaymentSummaryItem): Deleted.
(WebKit::toPKPaymentSummaryItems): Deleted.

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::PaymentMethodUpdate>::encode):
(IPC::ArgumentCoder<WebCore::PaymentMethodUpdate>::decode):

10:29 PM Changeset in webkit [250178] by mitz@apple.com

• 7 copies
  1 add in releases/Apple/watchOS 6.0

Added a tag for watchOS 6.0.

10:27 PM Changeset in webkit [250177] by mitz@apple.com

• 8 copies
  1 add in releases/Apple/iOS 13.0

Added a tag for iOS 13.0.

7:11 PM Changeset in webkit [250176] by keith_miller@apple.com

• 3 edits in trunk/Source/JavaScriptCore

eliding a move in Air O0 needs to mark the dest's old reg as available
​https://bugs.webkit.org/show_bug.cgi?id=202066

Reviewed by Saam Barati.

Also adds a new release method that handles all the invariants of
returning a register to the available register pool.

• b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:

(JSC::B3::Air::GenerateAndAllocateRegisters::release):
(JSC::B3::Air::GenerateAndAllocateRegisters::spill):
(JSC::B3::Air::GenerateAndAllocateRegisters::freeDeadTmpsIfNeeded):
(JSC::B3::Air::GenerateAndAllocateRegisters::generate):

• b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:

6:24 PM Changeset in webkit [250175] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Assertion fires when animating a discrete property with values range and multiple animators
​https://bugs.webkit.org/show_bug.cgi?id=201926

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-09-20
Reviewed by Darin Adler.

Source/WebCore:

The first animator of a property is considered the result element. The
other animators will be just contributers to the first animator. For the
first animator and in SVGSMILElement::progress(), we call resetAnimatedType()
which creates m_animator in SVGAnimateElementBase::animator(). But for
the other animators we do not call resetAnimatedType(). So their m_animator
will stay null until they are used for the first time.

If SVGAnimationElement::startedActiveInterval() calls calculateToAtEndOfDurationValue()
for a discrete property this will have no effect and the call should be
ignored. So SVGAnimateElementBase::calculateToAtEndOfDurationValue()
should bail out early if isDiscreteAnimator() is true.

The bug is isDiscreteAnimator() will return false if the m_animator is
null even if the animated property is discrete, e.g. SVGAnimatedString.
The fix is to make isDiscreteAnimator() ensure m_animator is created.

Unrelated change:
Make most of the protected methods of SVGAnimateElementBase be private.

Test: svg/animations/multiple-discrete-values-animate.svg

• svg/SVGAnimateElementBase.cpp:

(WebCore::SVGAnimateElementBase::calculateFromAndByValues):
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue):

LayoutTests:

Animate a discrete property, such as SVGAnimatedString. There should be
multiple animators and the range of animation has to be set by the 'values'
attribute.

• svg/animations/multiple-discrete-values-animate-expected.txt: Added.
• svg/animations/multiple-discrete-values-animate.svg: Added.

6:07 PM Changeset in webkit [250174] by aakash_jain@apple.com

• 3 edits in trunk/Tools

[EWS] JSC queues should re-build ToT and compare results on build failure
​https://bugs.webkit.org/show_bug.cgi?id=201999

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/factories.py:

(JSCTestsFactory.init): Do not add the UnApplyPatchIfRequired and CompileJSCOnlyToT step here, as
these are dynamically added (if required) in steps.py in CompileWebKit.evaluateCommand() using addStepsAfterCurrentStep().
Also setting skipUpload=False since we don't need to upload the archive for this queue. Building and testing is done in same build.

• BuildSlaveSupport/ews-build/steps.py:

(CompileWebKit.evaluateCommand): Add CompileJSCOnlyToT or CompileWebKitToT build-step based on 'group' property.
(AnalyzeCompileWebKitResults.start): Ditto.
(CompileJSCOnly.start): Set the 'group' property to 'jsc'.
(CompileJSCOnlyToT.evaluateCommand): Over-ride evaluateCommand, so that base-class' (CompileWebKit) evaluateCommand is
not used, base class evaluateCommand adds build-steps dynamically.

5:36 PM Changeset in webkit [250173] by Keith Rollin

• 2 edits in trunk/Source/WebCore

Remove dead code for a specific macOS and iOS SDK
​https://bugs.webkit.org/show_bug.cgi?id=202054
<rdar://problem/55569619>

Reviewed by Zalan Bujtas.

ComplexTextController::collectComplexTextRunsForCharacters in
ComplexTextControllerCoreText.mm has some code for compatibility with
specifically macOS 10.14.0 and iOS 12.0 (see Bug 186571). We don't
build for these targets any more (when we build for macOS 10.14, it's
for a later minor revision), so this code can be removed.

No new tests -- no new or changed functionality.

• platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

5:29 PM Changeset in webkit [250172] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Harden assertion in StructureIDTable::get().
​https://bugs.webkit.org/show_bug.cgi?id=202067
<rdar://problem/55577923>

Reviewed by Keith Miller.

• runtime/StructureIDTable.h:

(JSC::StructureIDTable::get):

5:17 PM Changeset in webkit [250171] by Keith Rollin

• 4 edits in trunk/Source

Remove some support for < iOS 13
​https://bugs.webkit.org/show_bug.cgi?id=202027
<rdar://problem/55547109>

Reviewed by Alex Christensen.

Remove some support for iOS versions less than 13.0.

Update conditionals that reference IPHONE_OS_VERSION_MIN_REQUIRED
and IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
values >= 130000. This means that expressions like
"IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
"IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.

After version checks have been removed, there are some cases where the

preprocessor conditional looks like "#if PLATFORM(MAC)

PLATFORM(IOS_FAMILY)". These can be collapsed into "#if
PLATFORM(COCOA)". This additional cleanup will be performed in a
subsequent patch.

This removal is part of a series of patches effecting the removal of
dead code for old versions of iOS. This particular pass involves
changes in which Joe Pecoraro was involved. These changes are isolated
from other similar changes in order to facilitate the reviewing
process.

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

5:15 PM Changeset in webkit [250170] by Kocsen Chung

• 1 copy in branches/safari-608.2.30.1-branch

New branch.

5:13 PM Changeset in webkit [250169] by achristensen@apple.com

• 42 edits
  1 move
  4 deletes in trunk/Source

Remove unnecessary abstractions around WebsiteDataStore
​https://bugs.webkit.org/show_bug.cgi?id=201655

Reviewed by Chris Dumez.

Source/WebCore:

• Modules/webdatabase/cocoa/DatabaseManagerCocoa.mm:

(WebCore::DatabaseManager::platformInitialize):

Source/WebKit:

• PlatformFTW.cmake:
• PlatformWin.cmake:
• Sources.txt:
• SourcesCocoa.txt:
• SourcesGTK.txt:
• SourcesWPE.txt:
• UIProcess/API/APIHTTPCookieStore.cpp:
• UIProcess/API/APIHTTPCookieStore.h:
• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::websiteDataStore):
(API::PageConfiguration::setWebsiteDataStore):

• UIProcess/API/APIPageConfiguration.h:
• UIProcess/API/APIProcessPoolConfiguration.cpp:
• UIProcess/API/APIWebsiteDataStore.cpp: Removed.
• UIProcess/API/APIWebsiteDataStore.h: Removed.
• UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::WebsitePolicies):
(API::WebsitePolicies::setWebsiteDataStore):
(API::WebsitePolicies::data):

• UIProcess/API/APIWebsitePolicies.h:
• UIProcess/API/C/WKAPICast.h:
• UIProcess/API/C/WKContext.cpp:

(WKContextSetCacheModel):
(WKContextGetCacheModel):

• UIProcess/API/C/WKFramePolicyListener.cpp:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreGetTypeID):
(WKWebsiteDataStoreGetDefaultDataStore):
(WKWebsiteDataStoreCreateNonPersistentDataStore):
(WKWebsiteDataStoreCreateWithConfiguration):
(WKWebsiteDataStoreGetHTTPCookieStore):
(WKWebsiteDataStoreSetResourceLoadStatisticsDebugModeWithCompletionHandler):
(WKWebsiteDataStoreSetResourceLoadStatisticsPrevalentResourceForDebugMode):
(WKWebsiteDataStoreSetStatisticsLastSeen):
(WKWebsiteDataStoreSetStatisticsPrevalentResource):
(WKWebsiteDataStoreSetStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreDumpResourceLoadStatistics):
(WKWebsiteDataStoreIsStatisticsPrevalentResource):
(WKWebsiteDataStoreIsStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubresourceUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubFrameUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsRedirectingTo):
(WKWebsiteDataStoreSetStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreIsStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreSetStatisticsGrandfathered):
(WKWebsiteDataStoreIsStatisticsGrandfathered):
(WKWebsiteDataStoreSetStatisticsSubframeUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsCrossSiteLoadWithLinkDecoration):
(WKWebsiteDataStoreSetStatisticsTimeToLiveUserInteraction):
(WKWebsiteDataStoreStatisticsProcessStatisticsAndDataRecords):
(WKWebsiteDataStoreStatisticsUpdateCookieBlocking):
(WKWebsiteDataStoreStatisticsSubmitTelemetry):
(WKWebsiteDataStoreSetStatisticsNotifyPagesWhenDataRecordsWereScanned):
(WKWebsiteDataStoreSetStatisticsIsRunningTest):
(WKWebsiteDataStoreSetStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
(WKWebsiteDataStoreSetStatisticsNotifyPagesWhenTelemetryWasCaptured):
(WKWebsiteDataStoreSetStatisticsMinimumTimeBetweenDataRecordsRemoval):
(WKWebsiteDataStoreSetStatisticsGrandfatheringTime):
(WKWebsiteDataStoreSetStatisticsMaxStatisticsEntries):
(WKWebsiteDataStoreSetStatisticsPruneEntriesDownTo):
(WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStore):
(WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
(WKWebsiteDataStoreStatisticsClearThroughWebsiteDataRemoval):
(WKWebsiteDataStoreStatisticsDeleteCookiesForTesting):
(WKWebsiteDataStoreStatisticsHasLocalStorage):
(WKWebsiteDataStoreSetStatisticsCacheMaxAgeCap):
(WKWebsiteDataStoreStatisticsHasIsolatedSession):
(WKWebsiteDataStoreStatisticsResetToConsistentState):
(WKWebsiteDataStoreRemoveAllFetchCaches):
(WKWebsiteDataStoreRemoveFetchCacheForOrigin):
(WKWebsiteDataStoreRemoveAllIndexedDatabases):
(WKWebsiteDataStoreRemoveLocalStorage):
(WKWebsiteDataStoreRemoveAllServiceWorkerRegistrations):
(WKWebsiteDataStoreGetFetchCacheOrigins):
(WKWebsiteDataStoreGetFetchCacheSizeForOrigin):
(WKWebsiteDataStoreCopyServiceWorkerRegistrationDirectory):
(WKWebsiteDataStoreSetServiceWorkerRegistrationDirectory):
(WKWebsiteDataStoreClearAllDeviceOrientationPermissions):
(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):
(WKWebsiteDataStoreClearAdClickAttributionsThroughWebsiteDataRemoval):

• UIProcess/API/C/WKWebsitePolicies.cpp:
• UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm: Removed.
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore defaultDataStore]):
(+[WKWebsiteDataStore nonPersistentDataStore]):
(-[WKWebsiteDataStore dealloc]):
(-[WKWebsiteDataStore httpCookieStore]):
(-[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):
(-[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:]):
(+[WKWebsiteDataStore _defaultDataStoreExists]):
(+[WKWebsiteDataStore _deleteDefaultDataStoreForTesting]):
(-[WKWebsiteDataStore _initWithConfiguration:]):
(-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):
(-[WKWebsiteDataStore _resourceLoadStatisticsEnabled]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsEnabled:]):
(-[WKWebsiteDataStore _resourceLoadStatisticsDebugMode]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsDebugMode:]):
(-[WKWebsiteDataStore _cacheStorageDirectory]):
(-[WKWebsiteDataStore _setCacheStorageDirectory:]):
(-[WKWebsiteDataStore _serviceWorkerRegistrationDirectory]):
(-[WKWebsiteDataStore _setServiceWorkerRegistrationDirectory:]):
(-[WKWebsiteDataStore _setBoundInterfaceIdentifier:]):
(-[WKWebsiteDataStore _boundInterfaceIdentifier]):
(-[WKWebsiteDataStore _setAllowsCellularAccess:]):
(-[WKWebsiteDataStore _allowsCellularAccess]):
(-[WKWebsiteDataStore _setProxyConfiguration:]):
(-[WKWebsiteDataStore _sourceApplicationBundleIdentifier]):
(-[WKWebsiteDataStore _setSourceApplicationBundleIdentifier:]):
(-[WKWebsiteDataStore _sourceApplicationSecondaryIdentifier]):
(-[WKWebsiteDataStore _setSourceApplicationSecondaryIdentifier:]):
(-[WKWebsiteDataStore _proxyConfiguration]):
(-[WKWebsiteDataStore _indexedDBDatabaseDirectory]):
(-[WKWebsiteDataStore _resourceLoadStatisticsSetShouldSubmitTelemetry:]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsTestingCallback:]):
(-[WKWebsiteDataStore _getAllStorageAccessEntriesFor:completionHandler:]):
(-[WKWebsiteDataStore _scheduleCookieBlockingUpdate:]):
(-[WKWebsiteDataStore _setPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _getIsPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _clearPrevalentDomain:completionHandler:]):
(-[WKWebsiteDataStore _processStatisticsAndDataRecords:]):
(-[WKWebsiteDataStore _hasRegisteredServiceWorker]):
(-[WKWebsiteDataStore _delegate]):
(-[WKWebsiteDataStore set_delegate:]):

• UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h:
• UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp: Removed.
• UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(webkitWebsiteDataManagerSetProperty):
(webkitWebsiteDataManagerGetDataStore):
(webkit_website_data_manager_get_local_storage_directory):
(webkit_website_data_manager_get_disk_cache_directory):
(webkit_website_data_manager_get_offline_application_cache_directory):
(webkit_website_data_manager_get_indexeddb_directory):
(webkit_website_data_manager_get_websql_directory):
(webkit_website_data_manager_get_hsts_cache_directory):
(webkit_website_data_manager_fetch):
(webkit_website_data_manager_remove):
(webkit_website_data_manager_clear):
(webkitWebsiteDataManagerCreate): Deleted.

• UIProcess/API/glib/WebKitWebsiteDataManagerPrivate.h:
• UIProcess/API/win/APIWebsiteDataStoreWin.cpp: Removed.
• UIProcess/Cocoa/NavigationState.mm:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::websiteDataStoreFromSessionID):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebFramePolicyListenerProxy.cpp:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):

• UIProcess/WebProcessPool.cpp:

(WebKit::m_webProcessCache):
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::establishWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::tryTakePrewarmedProcess):
(WebKit::WebProcessPool::processDidFinishLaunching):
(WebKit::WebProcessPool::processForRegistrableDomain):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::mayHaveRegisteredServiceWorkers):

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::defaultApplicationCacheDirectory):
(WebKit::WebsiteDataStore::defaultCacheStorageDirectory):
(WebKit::WebsiteDataStore::defaultNetworkCacheDirectory):
(WebKit::WebsiteDataStore::defaultMediaCacheDirectory):
(WebKit::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):
(WebKit::WebsiteDataStore::defaultLocalStorageDirectory):
(WebKit::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(WebKit::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):
(WebKit::WebsiteDataStore::defaultJavaScriptConfigurationDirectory):
(WebKit::WebsiteDataStore::tempDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::globalDefaultDataStore):
(WebKit::WebsiteDataStore::defaultDataStore):
(WebKit::WebsiteDataStore::deleteDefaultDataStoreForTesting):
(WebKit::WebsiteDataStore::defaultDataStoreExists):
(WebKit::WebsiteDataStore::defaultDataStoreConfiguration):
(WebKit::WebsiteDataStore::isAssociatedProcessPool const):
(WebKit::WebsiteDataStore::defaultMediaCacheDirectory):
(WebKit::WebsiteDataStore::defaultJavaScriptConfigurationDirectory):
(WebKit::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory):

• UIProcess/WebsiteData/WebsiteDataStore.h:
• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
• UIProcess/WebsiteData/win/WebsiteDataStoreWin.cpp:

(WebKit::WebsiteDataStore::defaultApplicationCacheDirectory):
(WebKit::WebsiteDataStore::defaultCacheStorageDirectory):
(WebKit::WebsiteDataStore::defaultNetworkCacheDirectory):
(WebKit::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):
(WebKit::WebsiteDataStore::defaultLocalStorageDirectory):
(WebKit::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(WebKit::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(WebKit::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):
(WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

• UIProcess/glib/WebProcessProxyGLib.cpp:

(WebKit::WebProcessProxy::platformGetLaunchOptions):

• UIProcess/glib/WebsiteDataStoreGLib.cpp: Copied from Source/WebKit/UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp.

(API::WebsiteDataStore::defaultApplicationCacheDirectory): Deleted.
(API::WebsiteDataStore::defaultNetworkCacheDirectory): Deleted.
(API::WebsiteDataStore::defaultCacheStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultIndexedDBDatabaseDirectory): Deleted.
(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory): Deleted.
(API::WebsiteDataStore::defaultLocalStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultMediaKeysStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory): Deleted.
(API::WebsiteDataStore::defaultWebSQLDatabaseDirectory): Deleted.
(API::WebsiteDataStore::defaultHSTSDirectory): Deleted.
(API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory): Deleted.
(API::WebsiteDataStore::cacheDirectoryFileSystemRepresentation): Deleted.
(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation): Deleted.

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:

(WebKit::WebMediaKeyStorageManager::setWebsiteDataStore):

4:59 PM Changeset in webkit [250168] by Kocsen Chung

• 1 copy in tags/Safari-608.2.11.1.10

Tag Safari-608.2.11.1.10.

4:59 PM Changeset in webkit [250167] by commit-queue@webkit.org

• 3 edits
  3 adds
  2 deletes in trunk

[resource-timing] Report performance entries with all HTTP status codes
​https://bugs.webkit.org/show_bug.cgi?id=202040

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-09-20
Reviewed by Joseph Pecoraro.

LayoutTests/imported/w3c:

• web-platform-tests/resource-timing/resource_ignore_failures-expected.txt: Removed.
• web-platform-tests/resource-timing/resource_ignore_failures.html: Removed.

This test is no longer in wpt and it would regress with this change, so we remove it.

• web-platform-tests/resource-timing/resources/status-code.py: Added.

(main):

• web-platform-tests/resource-timing/status-codes-create-entry-expected.txt: Added.
• web-platform-tests/resource-timing/status-codes-create-entry.html: Added.

Source/WebCore:

This follows a Chromium change at ​https://chromium-review.googlesource.com/c/chromium/src/+/1796544
The spec change is being discussed at ​https://github.com/w3c/resource-timing/issues/165

Test: imported/w3c/web-platform-tests/resource-timing/status-codes-create-entry.html

I had to slightly modify the test to make sure the entry count was > 0 instead of == 1 to reduce flakyness because sometimes we load the 200 image twice.
I'll submit a PR to WPT, too.

• loader/ResourceTimingInformation.cpp:

(WebCore::ResourceTimingInformation::shouldAddResourceTiming):

4:54 PM Changeset in webkit [250166] by Kocsen Chung

• 9 edits in branches/safari-608.2.11.1-branch/Source/WebKit

Revert to match Safari-608.2.11.1.7 content.

4:46 PM Changeset in webkit [250165] by Chris Dumez

• 6 edits in trunk

REGRESSION (iOS 13): rAF stops firing when navigating away cross-origin and then back
​https://bugs.webkit.org/show_bug.cgi?id=201767
<rdar://problem/55350854>

Reviewed by Tim Horton.

Source/WebKit:

This is a follow-up to r249961 to address crashes when navigating back cross-origin to a page
that uses requestAnimationFrame. r249961 took care of moving RemoteLayerTreeDisplayRefreshMonitor
objects from one RemoteLayerTreeDrawingArea to another but failed to tell those monitors
about their new drawingArea. As a result, RemoteLayerTreeDrawingArea::willDestroyDisplayRefreshMonitor()
would not get called on the new drawing area when it should have.

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h:
• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm:

(WebKit::RemoteLayerTreeDisplayRefreshMonitor::updateDrawingArea):

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::adoptDisplayRefreshMonitorsFromDrawingArea):

LayoutTests:

Call finishJSTest() on a timer to make it more likely to reproduce the bug.

• http/tests/navigation/page-cache-requestAnimationFrame.html:

4:18 PM Changeset in webkit [250164] by Kocsen Chung

• 1 copy in tags/Safari-608.3.3

Tag Safari-608.3.3.

4:17 PM Changeset in webkit [250163] by Kocsen Chung

• 1 delete in tags/Safari-608.3.3

Delete tag.

4:16 PM Changeset in webkit [250162] by Kocsen Chung

• 1 copy in tags/Safari-608.3.3

Tag Safari-608.3.3.

3:58 PM Changeset in webkit [250161] by Keith Rollin

• 3 edits in trunk/Source/WebCore

Remove check of setSourceAppPid selector that's no longer needed
​https://bugs.webkit.org/show_bug.cgi?id=201971
<rdar://problem/55505761>

Reviewed by Andy Estes.

Bug 172152 introduced a check of the NEFilterSource selector
setSourceAppPid in order to support OS's that didn't support it. All
supported Cocoa platforms now support it, so the check can be removed.

Source/WebCore:

No new tests -- no new or changed functionality.

• platform/cocoa/NetworkExtensionContentFilter.mm:

(WebCore::NetworkExtensionContentFilter::initialize):

Source/WebCore/PAL:

• pal/spi/cocoa/NEFilterSourceSPI.h:

3:19 PM Changeset in webkit [250160] by Keith Rollin

• 12 edits
  1 delete in trunk

Remove some support for < iOS 13
​https://bugs.webkit.org/show_bug.cgi?id=201967
<rdar://problem/55504738>

Reviewed by Andy Estes.

Remove some support for iOS versions less than 13.0.

Update conditionals that reference IPHONE_OS_VERSION_MIN_REQUIRED
and IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
values >= 130000. This means that expressions like
"IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
"IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.

After version checks have been removed, there are some cases where the

preprocessor conditional looks like "#if PLATFORM(MAC)

PLATFORM(IOS_FAMILY)". These can be collapsed into "#if
PLATFORM(COCOA)". This additional cleanup will be performed in a
subsequent patch.

This removal is part of a series of patches effecting the removal of
dead code for old versions of iOS. This particular pass involves
changes in which Andy Estes was involved. These changes are isolated
from other similar changes in order to facilitate the reviewing
process.

Source/WebCore:

No new tests -- no new or changed functionality.

• platform/cocoa/NetworkExtensionContentFilter.mm:

(WebCore::NetworkExtensionContentFilter::initialize):

Source/WebCore/PAL:

• pal/spi/cocoa/NEFilterSourceSPI.h:

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _dataForPreviewItemController:atPosition:type:]):

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _uploadItemFromMediaInfo:successBlock:failureBlock:]):

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm: Removed.

2:51 PM Changeset in webkit [250159] by Kocsen Chung

• 7 edits in branches/safari-608.2.11.1-branch/Source

Versioning.

2:50 PM Changeset in webkit [250158] by Kocsen Chung

• 1 copy in tags/Safari-608.2.11.1.9

Tag Safari-608.2.11.1.9.

2:49 PM Changeset in webkit [250157] by timothy_horton@apple.com

• 5 edits in trunk/Source/WebKit

Sanitize suggested filenames used for saving PDFs
​https://bugs.webkit.org/show_bug.cgi?id=202034
<rdar://problem/53183075>

Reviewed by Chris Dumez.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFinishLoadingDataForCustomContentProvider):
(WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw): Deleted.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication):
(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw): Deleted.
Sanitize suggested filenames to ensure that they comprise only one path component
when concatenated with their destination directory.

2:45 PM Changeset in webkit [250156] by achristensen@apple.com

• 4 edits in trunk/Tools

Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=202025

Reviewed by Chris Dumez.

One expected change in behavior is that the resource load statistics directory is not created on startup with an ephemeral session any more
because we call the constructor of WebsiteDataStoreConfiguration inside _WKWebsiteDataStoreConfiguration and set the default directory like we do the other directories.

• TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::websiteDataStore):
(WTR::TestController::generatePageConfiguration):

2:40 PM Changeset in webkit [250155] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Add release logging for when a view is added / removed from a window
​https://bugs.webkit.org/show_bug.cgi?id=202050

Reviewed by Tim Horton.

Add release logging for when a view is added / removed from a window to help determine the
view's visibility in the logs.

• UIProcess/ios/WKApplicationStateTrackingView.mm:

(-[WKApplicationStateTrackingView willMoveToWindow:]):
(-[WKApplicationStateTrackingView didMoveToWindow]):

2:37 PM Changeset in webkit [250154] by Chris Dumez

• 2 edits in trunk/Source/WebKit

ApplicationStateTracker::m_isBackground initialization does not account for UIScenes
​https://bugs.webkit.org/show_bug.cgi?id=202048

Reviewed by Geoffrey Garen.

ApplicationStateTracker::m_isBackground initialization does not account for UIScenes, it merely checks
the visibility state of the whole app. It should instead check the visibility state of the window's
UIScene.

This patch also refactors the code a little bit to reduce #ifdef'ing.

• UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):

2:35 PM Changeset in webkit [250153] by Chris Dumez

• 44 edits in trunk/Source

Document no longer needs to store a SessionID
​https://bugs.webkit.org/show_bug.cgi?id=202024

Reviewed by Geoffrey Garen.

Document no longer needs to store a SessionID, now that we have a single
session per WebProcess. It can simply get its sessionID from its Page.

Source/WebCore:

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::create):

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didOpenSocketStream):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

• dom/DOMImplementation.cpp:

(WebCore::createXMLDocument):
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):

• dom/DOMImplementation.h:
• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::m_undoManager):
(WebCore::Document::create):
(WebCore::Document::createNonRenderedPlaceholder):
(WebCore::Document::cloneDocumentWithoutChildren const):
(WebCore::Document::sessionID const):
(WebCore::Document::privateBrowsingStateDidChange):
(WebCore::Document::ensureTemplateDocument):
(WebCore::Document::logger):
(WebCore::Document::didLogMessage):

• dom/Document.h:

(WebCore::Document::create):

• dom/XMLDocument.h:

(WebCore::XMLDocument::create):
(WebCore::XMLDocument::createXHTML):
(WebCore::XMLDocument::XMLDocument):

• html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocument::FTPDirectoryDocument):

• html/FTPDirectoryDocument.h:
• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAdClickAttribution const):

• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::createSynthesizedDocument):
(WebCore::HTMLDocument::HTMLDocument):
(WebCore::HTMLDocument::cloneDocumentWithoutChildren const):

• html/HTMLDocument.h:

(WebCore::HTMLDocument::create):

• html/ImageDocument.cpp:

(WebCore::ImageDocument::ImageDocument):

• html/MediaDocument.cpp:

(WebCore::MediaDocument::MediaDocument):

• html/MediaDocument.h:
• html/PluginDocument.cpp:

(WebCore::PluginDocument::PluginDocument):

• html/TextDocument.cpp:

(WebCore::TextDocument::TextDocument):

• html/TextDocument.h:
• inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):

• loader/CookieJar.cpp:

(WebCore::CookieJar::cookieRequestHeaderFieldProxy):
(WebCore::CookieJar::cookieRequestHeaderFieldValue const):

• loader/CookieJar.h:
• loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::createDocument):

• loader/SinkDocument.cpp:

(WebCore::SinkDocument::SinkDocument):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::setResponse):
(WebCore::CachedResource::varyHeaderValuesMatch):

• loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::finishLoading):

• loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::ensureCustomFontData):

• page/Page.cpp:

(WebCore::Page::configureLoggingChannel):

• platform/network/CacheValidation.cpp:

(WebCore::cookieRequestHeaderFieldValue):
(WebCore::collectVaryingRequestHeaders):
(WebCore::verifyVaryingRequestHeaders):

• platform/network/CacheValidation.h:
• svg/SVGDocument.cpp:

(WebCore::SVGDocument::SVGDocument):
(WebCore::SVGDocument::cloneDocumentWithoutChildren const):

• svg/SVGDocument.h:

(WebCore::SVGDocument::create):

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::isAlwaysOnLoggingAllowed const):

• worklets/WorkletGlobalScope.cpp:

(WebCore::WorkletGlobalScope::WorkletGlobalScope):

• worklets/WorkletGlobalScope.h:
• xml/DOMParser.cpp:

(WebCore::DOMParser::parseFromString):

• xml/DOMParser.h:
• xml/DOMParser.idl:
• xml/XMLHttpRequest.cpp:
• xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

Source/WebKit:

• WebProcess/WebPage/WebCookieJar.cpp:

(WebKit::WebCookieJar::cookieRequestHeaderFieldValue const):

• WebProcess/WebPage/WebCookieJar.h:

2:23 PM Changeset in webkit [250152] by Devin Rousso

• 5 edits
  2 adds in trunk

Web Inspector: HTML Formatter - better indentation/newline handling for self closing tags
​https://bugs.webkit.org/show_bug.cgi?id=202036

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

• UserInterface/Workers/Formatter/HTMLFormatter.js:

(HTMLFormatter.prototype._before):

LayoutTests:

• inspector/formatting/formatting-xml.html:
• inspector/formatting/formatting-xml-expected.txt:
• inspector/formatting/resources/xml-tests/self-closing.xml: Added.
• inspector/formatting/resources/xml-tests/self-closing-expected.xml: Added.

2:06 PM Changeset in webkit [250151] by Chris Dumez

• 3 edits in trunk/Source/WebKit

[iOS] ASSERTION FAILED: Unsafe to ref/deref of ShareableBitmap from different threads
​https://bugs.webkit.org/show_bug.cgi?id=201712
<rdar://problem/55289916>

Reviewed by Tim Horton.

Make sure ShareableBitmap objects are always ref'd / deref'd on the main thread by dispatching to
the main thread in ShareableBitmap::releaseBitmapContextData() before calling deref().

• Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::ShareableBitmap):
(WebKit::ShareableBitmap::~ShareableBitmap):

• Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::releaseBitmapContextData):

2:01 PM Changeset in webkit [250150] by achristensen@apple.com

• 15 edits in trunk/Source/WebKit

Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=202025

Reviewed by Chris Dumez.

Most of these were only needed before initNonPersistentConfiguration existed.

• UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp:

(WKWebsiteDataStoreConfigurationGetPerOriginStorageQuota):
(WKWebsiteDataStoreConfigurationSetPerOriginStorageQuota):

• UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetPerOriginStorageQuota):

• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _initWithConfiguration:]):
(-[WKWebsiteDataStore _perOriginStorageQuota]):
(-[WKWebsiteDataStore _setPerOriginStorageQuota:]):

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:

(-[_WKWebsiteDataStoreConfiguration perOriginStorageQuota]):
(-[_WKWebsiteDataStoreConfiguration setPerOriginStorageQuota:]):
(-[_WKWebsiteDataStoreConfiguration boundInterfaceIdentifier]):
(-[_WKWebsiteDataStoreConfiguration setBoundInterfaceIdentifier:]):
(-[_WKWebsiteDataStoreConfiguration allowsCellularAccess]):
(-[_WKWebsiteDataStoreConfiguration setAllowsCellularAccess:]):
(-[_WKWebsiteDataStoreConfiguration proxyConfiguration]):
(-[_WKWebsiteDataStoreConfiguration setProxyConfiguration:]):

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::parameters):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::setSourceApplicationSecondaryIdentifier):
(WebKit::WebsiteDataStore::setSourceApplicationBundleIdentifier):

• UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::setBoundInterfaceIdentifier):
(WebKit::WebsiteDataStore::boundInterfaceIdentifier):
(WebKit::WebsiteDataStore::sourceApplicationBundleIdentifier const):
(WebKit::WebsiteDataStore::sourceApplicationSecondaryIdentifier const):
(WebKit::WebsiteDataStore::setAllowsCellularAccess):
(WebKit::WebsiteDataStore::allowsCellularAccess):
(WebKit::WebsiteDataStore::setProxyConfiguration):
(WebKit::WebsiteDataStore::proxyConfiguration):
(WebKit::WebsiteDataStore::setPerOriginStorageQuota): Deleted.

• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:

(WebKit::WebsiteDataStoreConfiguration::copy):

• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:

(WebKit::WebsiteDataStoreConfiguration::boundInterfaceIdentifier const):
(WebKit::WebsiteDataStoreConfiguration::setBoundInterfaceIdentifier):
(WebKit::WebsiteDataStoreConfiguration::allowsCellularAccess const):
(WebKit::WebsiteDataStoreConfiguration::setAllowsCellularAccess):
(WebKit::WebsiteDataStoreConfiguration::proxyConfiguration const):
(WebKit::WebsiteDataStoreConfiguration::setProxyConfiguration):

1:49 PM Changeset in webkit [250149] by Joseph Pecoraro

• 7 edits
  2 deletes in trunk/Source/WebInspectorUI

Web Inspector: Remove BranchManager in favor of just using currentRevision
​https://bugs.webkit.org/show_bug.cgi?id=202000

Reviewed by Devin Rousso.

Remove BranchManager. The Branch concept never got fleshed out, and would
likely be too complex for the average case. Local Overrides are simpler.
In the interest of expanding Local Overrides to more content lets simply
by removing Branches.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/Main.js:

(WI.loaded):

• UserInterface/Controllers/BranchManager.js: Removed.
• UserInterface/Controllers/CSSManager.js:

(WI.CSSManager.prototype._resourceContentDidChange.applyStyleSheetChanges.styleSheetFound):
(WI.CSSManager.prototype._resourceContentDidChange.applyStyleSheetChanges):
(WI.CSSManager.prototype._resourceContentDidChange):
(WI.CSSManager.prototype._updateResourceContent.fetchedStyleSheetContent):

• UserInterface/Main.html:
• UserInterface/Models/Branch.js: Removed.
• UserInterface/Models/SourceCode.js:

(WI.SourceCode.prototype._processContent):
(WI.SourceCode):

• UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype._textEditorContentDidChange):

1:36 PM Changeset in webkit [250148] by achristensen@apple.com

• 12 edits
  2 adds in trunk/Source/WebKit

Introduce LegacyGlobalSettings for settings the NetworkProcess needs from a WebProcessPool
​https://bugs.webkit.org/show_bug.cgi?id=201970

Reviewed by Geoff Garen.

I'm starting by moving the cache model to this new abstraction.
We were using it in tests to disable the page cache, which should be done with a boolean on the pool configuration, not by changing the cache model.
We were also using it in WKContextSetCacheModel which has several clients that won't change quickly, so this abstraction is used to maintain existing behavior.
I need this so I can make a NetworkProcess not depend on anything from a WebProcessPool when starting.

• Sources.txt:
• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

• UIProcess/API/APIProcessPoolConfiguration.h:
• UIProcess/API/C/WKContext.cpp:

(WKContextSetCacheModel):
(WKContextGetCacheModel):

• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration pageCacheEnabled]):
(-[_WKProcessPoolConfiguration setPageCacheEnabled:]):

• UIProcess/LegacyGlobalSettings.cpp: Added.

(WebKit::LegacyGlobalSettings::singleton):
(WebKit::LegacyGlobalSettings::setCacheModel):

• UIProcess/LegacyGlobalSettings.h: Added.

(WebKit::LegacyGlobalSettings::cacheModel const):

• UIProcess/WebProcessCache.cpp:

(WebKit::WebProcessCache::updateCapacity):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::updateMaxSuspendedPageCount):
(WebKit::WebProcessPool::setCacheModel):

• UIProcess/WebProcessPool.h:
• WebKit.xcodeproj/project.pbxproj:

1:30 PM Changeset in webkit [250147] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[SVG2]: Add auto behavior for rx and ry to the SVG <ellipse> and <rect> elements (Addressing review comments)
​https://bugs.webkit.org/show_bug.cgi?id=199843

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-09-20
Reviewed by Darin Adler.

Make RenderSVGEllipse calculate of the ellipse's rx and ry more efficiently.

• rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):

1:29 PM Changeset in webkit [250146] by achristensen@apple.com

• 7 edits in trunk/Source/WebKit

Deprecate unused C API aliases for WebsiteDataStore
​https://bugs.webkit.org/show_bug.cgi?id=202029

Reviewed by Chris Dumez.

This is a piece of r249768.

• UIProcess/API/C/WKApplicationCacheManager.cpp:

(WKApplicationCacheManagerGetTypeID):
(WKApplicationCacheManagerGetApplicationCacheOrigins):
(WKApplicationCacheManagerDeleteEntriesForOrigin):
(WKApplicationCacheManagerDeleteAllEntries):

• UIProcess/API/C/WKApplicationCacheManager.h:
• UIProcess/API/C/WKKeyValueStorageManager.cpp:

(WKKeyValueStorageManagerGetTypeID):
(WKKeyValueStorageManagerGetOriginKey):
(WKKeyValueStorageManagerGetCreationTimeKey):
(WKKeyValueStorageManagerGetModificationTimeKey):
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):
(WKKeyValueStorageManagerDeleteEntriesForOrigin):
(WKKeyValueStorageManagerDeleteAllEntries):

• UIProcess/API/C/WKKeyValueStorageManager.h:
• UIProcess/API/C/WKResourceCacheManager.cpp:

(WKResourceCacheManagerGetTypeID):
(WKResourceCacheManagerGetCacheOrigins):
(WKResourceCacheManagerClearCacheForOrigin):
(WKResourceCacheManagerClearCacheForAllOrigins):
(toWebsiteDataTypes): Deleted.

• UIProcess/API/C/WKResourceCacheManager.h:

1:21 PM Changeset in webkit [250145] by Adrian Perez de Castro

• 2 edits in trunk

Unreviewed. Bump WPE version numbers.

• Source/cmake/OptionsWPE.cmake:

1:17 PM Changeset in webkit [250144] by achristensen@apple.com

• 11 edits in trunk/Source

Remove functionality to disable TLS fallback
​https://bugs.webkit.org/show_bug.cgi?id=201998

Reviewed by Geoff Garen.

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

Since r249019 it is not used. It was a useful experiment and I'm glad we didn't see any regressions.

• NetworkProcess/NetworkSessionCreationParameters.cpp:

(WebKit::NetworkSessionCreationParameters::privateSessionParameters):
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

• NetworkProcess/NetworkSessionCreationParameters.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _setAllowsTLSFallback:]):
(-[WKWebsiteDataStore _allowsTLSFallback]):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::parameters):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setAllowsTLSFallback): Deleted.

• UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::allowsTLSFallback const): Deleted.

1:11 PM Changeset in webkit [250143] by achristensen@apple.com

• 17 edits in trunk/Source/WebKit

Remove unused storage paths on APIProcessPoolConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=202028

Reviewed by Chris Dumez.

This is a piece of r249768.
There is no way to set these paths and they have been replaced by WebsiteDataStore paths.
There was one remaining use of the global disk cache directory in NetworkProcess::setCacheModel,
which I replaced with the default session's disk cache directory, which is equivalent.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setCacheModel):

• NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::diskCacheDirectory const): Deleted.

• NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
(WebKit::NetworkProcessCreationParameters::NetworkProcessCreationParameters): Deleted.

• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::NetworkSession):

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::open):
(WebKit::NetworkCache::Cache::Cache):

• NetworkProcess/cache/NetworkCache.h:

(WebKit::NetworkCache::Cache::storageDirectory):

• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):
(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration): Deleted.
(API::ProcessPoolConfiguration::ProcessPoolConfiguration): Deleted.
(API::ProcessPoolConfiguration::~ProcessPoolConfiguration): Deleted.

• UIProcess/API/APIProcessPoolConfiguration.h:
• UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextConstructed):
(webkit_web_context_set_disk_cache_directory):
(websiteDataStoreConfigurationForWebProcessPoolConfiguration): Deleted.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::resolvePathsForSandboxExtensions):
(WebKit::WebProcessPool::webProcessDataStoreParameters):

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::processPools const):

• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:

1:10 PM Changeset in webkit [250142] by Keith Rollin

• 8 edits in trunk/Source

Remove some support for < iOS 13
​https://bugs.webkit.org/show_bug.cgi?id=202032
<rdar://problem/55548468>

Reviewed by Alex Christensen.

Remove some support for iOS versions less than 13.0.

Update conditionals that reference IPHONE_OS_VERSION_MIN_REQUIRED
and IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
values >= 130000. This means that expressions like
"IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
"IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.

This removal is part of a series of patches effecting the removal of
dead code for old versions of iOS. This particular pass involves
changes in which Dan Bates was involved. These changes are isolated
from other similar changes in order to facilitate the reviewing
process.

Source/WebCore:

No new tests -- no new or changed functionality.

• platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):

• platform/network/cocoa/CookieCocoa.mm:

(WebCore::Cookie::operator NSHTTPCookie * _Nullable const):

• platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interpretKeyEvent:isCharEvent:]):

Source/WebKitLegacy/mac:

• WebView/WebHTMLView.mm:

(-[WebHTMLView _handleEditingKeyEvent:]):

12:47 PM Changeset in webkit [250141] by Adrian Perez de Castro

• 1 copy in releases/WPE WebKit/webkit-2.26.0

WPE WebKit 2.26.0

12:46 PM Changeset in webkit [250140] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.26

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.26.0 release

.:

• Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

• wpe/NEWS: Add release notes for 2.26.0

12:39 PM Changeset in webkit [250139] by Truitt Savell

• 66 edits
  1 move
  15 deletes in trunk

Unreviewed, rolling out r250114.

Broke ~16 webgpu/ tests on Mojave wk2

Reverted changeset:

"Web Inspector: Canvas: show WebGPU shader pipelines"
​https://bugs.webkit.org/show_bug.cgi?id=201675
​https://trac.webkit.org/changeset/250114

12:31 PM Changeset in webkit [250138] by Keith Rollin

• 6 edits in trunk

Remove some support for < iOS 13
​https://bugs.webkit.org/show_bug.cgi?id=201973
<rdar://problem/55506966>

Reviewed by Alex Christensen.

Remove some support for iOS versions less than 13.0.

Update conditionals that reference IPHONE_OS_VERSION_MIN_REQUIRED
and IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
values >= 130000. This means that expressions like
"IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
"IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.

This removal is part of a series of patches effecting the removal of
dead code for old versions of iOS. This particular pass involves
changes in which Chris Dumez was involved. These changes are isolated
from other similar changes in order to facilitate the reviewing
process.

Source/WebKit:

• NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:

(WebKit::Download::resume):

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

11:42 AM Changeset in webkit [250137] by Alan Coon

• 3 edits
  4 adds in branches/safari-608-branch

Revert "Revert r247573. rdar://problem/55461395"

11:18 AM Changeset in webkit [250136] by Alan Coon

• 8 edits in branches/safari-608.2.11.1-branch/Source/WebKit

Apply patch. rdar://problem/55564031

10:24 AM Changeset in webkit [250135] by Alan Coon

• 7 edits in branches/safari-608.2.11.1-branch/Source

Versioning.

10:21 AM Changeset in webkit [250134] by Alan Coon

• 3 edits
  4 deletes in branches/safari-608-branch

Revert r247573. rdar://problem/55461395

8:53 AM Changeset in webkit [250133] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Unreviewed, fix confusing release logging under WebPageProxy::loadRequestWithNavigationShared().

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadRequestWithNavigationShared):

8:41 AM Changeset in webkit [250132] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

Implement Position::upstream and Position::downstream with line layout iterator
​https://bugs.webkit.org/show_bug.cgi?id=202043

Reviewed by Zalan Bujtas.

These can eventually work without switching to lineboxes.

• dom/Position.cpp:

(WebCore::Position::upstream const):
(WebCore::Position::downstream const):

Factor the loops into TextBox::isLastOnLine function.

• rendering/line/LineLayoutInterfaceTextBoxes.cpp:

(WebCore::LineLayoutInterface::TextBox::isLastOnLine const):

Looking into root boxes is a much more efficient way to figure this out.

(WebCore::LineLayoutInterface::TextBox::isLast const):
(WebCore::LineLayoutInterface::TextBoxIterator::ComplexPath::nextInlineTextBoxInTextOrder const):
(WebCore::LineLayoutInterface::TextBoxIterator::traverseNextInTextOrder):

• rendering/line/LineLayoutInterfaceTextBoxes.h:

8:40 AM Changeset in webkit [250131] by sbarati@apple.com

• 2 edits in trunk/JSTests

Unreviewed. Make toctou-having-a-bad-time-new-array.js run for less time because it's timing out on the debug bots.

• stress/toctou-having-a-bad-time-new-array.js:

8:23 AM Changeset in webkit [250130] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Regression(r248832): Unable to quicklook HTML files in Mail
​https://bugs.webkit.org/show_bug.cgi?id=202012
<rdar://problem/55285295>

Reviewed by Per Arne Vollan.

Follow-up to fix bug in r250110. Now that loadFile() calls
maybeInitializeSandboxExtensionHandle(), it no longer needs to
call assumeReadAccessToBaseURL(). This is because maybeInitializeSandboxExtensionHandle()
already take care of it.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadFile):

8:07 AM Changeset in webkit [250129] by commit-queue@webkit.org

• 6 edits
  1 add in trunk/Source

Implement memory monitoring functions for Linux OS
​https://bugs.webkit.org/show_bug.cgi?id=200391

Patch by Paulo Matos <Paulo Matos> on 2019-09-20
Reviewed by Žan Doberšek.

Source/JavaScriptCore:

• jsc.cpp:

Source/WTF:

• wtf/PlatformGTK.cmake:
• wtf/PlatformJSCOnly.cmake:
• wtf/PlatformWPE.cmake:
• wtf/linux/ProcessMemoryFootprint.h: Added.

(ProcessMemoryFootprint::now):
(ProcessMemoryFootprint::resetPeak):

7:29 AM WebKitGTK/2.26.x edited by Adrian Perez de Castro

(diff)

6:36 AM Changeset in webkit [250128] by Alan Bujtas

• 22 edits
  2 copies in trunk/Source/WebCore

[LFC] Introduce LayoutContext class
​https://bugs.webkit.org/show_bug.cgi?id=202026
<rdar://problem/55546622>

Reviewed by Antti Koivisto.

Move context related functionality from LayoutState to LayoutContext.
To initiate a layout, create a LayoutContext, pass the current LayoutState object in and call layout().

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):

• layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::createFormattingStateForFormattingRootIfNeeded):
(WebCore::Layout::LayoutState::updateLayout): Deleted.
(WebCore::Layout::LayoutState::layoutFormattingContextSubtree): Deleted.
(WebCore::Layout::LayoutState::styleChanged): Deleted.
(WebCore::Layout::LayoutState::markNeedsUpdate): Deleted.
(WebCore::Layout::LayoutState::createFormattingContext): Deleted.
(WebCore::Layout::LayoutState::run): Deleted.

• layout/LayoutState.h:

(WebCore::Layout::LayoutState::hasFormattingState const):
(WebCore::Layout::LayoutState::setQuirksMode):
(WebCore::Layout::LayoutState::inNoQuirksMode const):
(WebCore::Layout::LayoutState::updateAll): Deleted.

• layout/Verification.cpp:

(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree):
(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const): Deleted.

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraints):

• layout/blockformatting/BlockInvalidation.cpp:

(WebCore::Layout::computeUpdateType):
(WebCore::Layout::computeUpdateTypeForAncestor):
(WebCore::Layout::BlockInvalidation::invalidate):

• layout/blockformatting/BlockInvalidation.h:
• layout/displaytree/DisplayBox.h:
• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingRoot):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):

• layout/inlineformatting/InlineInvalidation.cpp:

(WebCore::Layout::InlineInvalidation::invalidate):

• layout/inlineformatting/InlineInvalidation.h:
• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::printLayoutTreeForLiveDocuments):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutTableCellBox):
(WebCore::Layout::TableFormattingContext::computePreferredWidthForColumns):

• layout/tableformatting/TableInvalidation.cpp:

(WebCore::Layout::TableInvalidation::invalidate):

• layout/tableformatting/TableInvalidation.h:
• page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

4:00 AM Changeset in webkit [250127] by commit-queue@webkit.org

• 76 edits
  1 copy
  63 adds in trunk/LayoutTests

Synchronize MathML WPT tests against upstream
​https://bugs.webkit.org/show_bug.cgi?id=201975

Patch by Rob Buis <​rbuis@igalia.com> on 2019-09-20
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Sync is based on a3a4442b04c37155f81c4ad4ae9c06339f76ce14.

• resources/import-expectations.json:
• web-platform-tests/mathml/presentation-markup/direction/direction-006.html:
• web-platform-tests/mathml/presentation-markup/direction/direction-007.html:
• web-platform-tests/mathml/presentation-markup/direction/direction-008.html:
• web-platform-tests/mathml/presentation-markup/direction/direction-009.html:
• web-platform-tests/mathml/presentation-markup/direction/direction-010.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-bar-002-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-bar-002.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-default-padding-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-default-padding.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-rendering-from-in-flow-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-rendering-from-in-flow.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/menclose/legacy-menclose-radical-notation-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/menclose/legacy-menclose-radical-notation.html: Added.
• web-platform-tests/mathml/presentation-markup/menclose/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/w3c-import.log.
• web-platform-tests/mathml/presentation-markup/mrow/legacy-mrow-like-elements-001-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/mrow/legacy-mrow-like-elements-001.html: Added.
• web-platform-tests/mathml/presentation-markup/mrow/legacy-mrow-like-elements-002-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/mrow/legacy-mrow-like-elements-002.html: Added.
• web-platform-tests/mathml/presentation-markup/mrow/legacy-mstyle-attributes-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/mrow/legacy-mstyle-attributes.html: Added.
• web-platform-tests/mathml/presentation-markup/mrow/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt:
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001.html:
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt:
• web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-form-dynamic.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-form-minus-plus.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-form.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-default.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-dynamic.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-from-in-flow-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits-from-in-flow.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/mo-movablelimits.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-paint-lspace-rspace.html:
• web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-001-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-001.html: Added.
• web-platform-tests/mathml/presentation-markup/operators/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/radicals/radical-rendering-from-in-flow-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/radicals/radical-rendering-from-in-flow.html: Added.
• web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/scripts/cramped-001-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/scripts/cramped-001.html: Added.
• web-platform-tests/mathml/presentation-markup/scripts/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/spaces/space-like-004-expected.txt:
• web-platform-tests/mathml/presentation-markup/spaces/space-like-004.html:
• web-platform-tests/mathml/presentation-markup/tables/table-001-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/tables/table-001.html: Added.
• web-platform-tests/mathml/presentation-markup/tables/table-002-expected.txt: Added.
• web-platform-tests/mathml/presentation-markup/tables/table-002.html: Added.
• web-platform-tests/mathml/presentation-markup/tables/w3c-import.log:
• web-platform-tests/mathml/relations/css-styling/attribute-mapping-001.html:
• web-platform-tests/mathml/relations/css-styling/displaystyle-011.html:
• web-platform-tests/mathml/relations/css-styling/displaystyle-012.html:
• web-platform-tests/mathml/relations/css-styling/displaystyle-013.html:
• web-platform-tests/mathml/relations/css-styling/displaystyle-014.html:
• web-platform-tests/mathml/relations/css-styling/displaystyle-015.html:
• web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt: Added.
• web-platform-tests/mathml/relations/css-styling/ignored-properties-001.html: Added.
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-css-keywords.html:
• web-platform-tests/mathml/relations/css-styling/mathsize-attribute-legacy-values.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-auto.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-initial.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-looped.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-monospace.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-bold-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-script.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-stretched.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-tailed.html:
• web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout.html:
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002.html:
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-002.html:
• web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002.html:
• web-platform-tests/mathml/relations/css-styling/w3c-import.log:
• web-platform-tests/mathml/relations/css-styling/width-height-001.html:
• web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative-expected.txt:
• web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative.html:
• web-platform-tests/mathml/relations/html5-tree/css-inline-style-dynamic.tentative-expected.html:
• web-platform-tests/mathml/relations/html5-tree/display-2-expected.html: Added.
• web-platform-tests/mathml/relations/html5-tree/display-2.html: Added.
• web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:
• web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative.html:
• web-platform-tests/mathml/relations/html5-tree/tabindex-001-expected.txt: Added.
• web-platform-tests/mathml/relations/html5-tree/tabindex-001.html: Added.
• web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Added.
• web-platform-tests/mathml/relations/html5-tree/tabindex-002.html: Added.
• web-platform-tests/mathml/relations/html5-tree/w3c-import.log:
• web-platform-tests/mathml/support/box-navigation.js: Added.

(IsInFlow):
(firstInFlowChild):
(nextInFlowSibling):
(previousInFlowSibling):

• web-platform-tests/mathml/support/feature-detection.js:

(MathMLFeatureDetection.string_appeared_here):
(MathMLFeatureDetection.has_mspace): Deleted.
(MathMLFeatureDetection.has_operator_spacing): Deleted.
(MathMLFeatureDetection.has_mfrac): Deleted.
(MathMLFeatureDetection.has_msqrt): Deleted.
(MathMLFeatureDetection.has_menclose): Deleted.
(MathMLFeatureDetection.has_dir): Deleted.

• web-platform-tests/mathml/support/mathml-fragments.js:

(FragmentHelper.createElement):
(FragmentHelper.forceNonEmptyElement):
(FragmentHelper.forceNonEmptyDescendants):

• web-platform-tests/mathml/support/operator-dictionary.js: Added.

(async.fetchOperatorDictionary):
(splitKey):
(spaceIndexToLength):
(defaultPropertyValue):

• web-platform-tests/mathml/support/operator-dictionary.json: Added.
• web-platform-tests/mathml/support/w3c-import.log:
• web-platform-tests/mathml/tools/mathvariant-transforms.py:
• web-platform-tests/mathml/tools/operator-dictionary.py: Added.

(parseHexaNumber):
(parseHexaSequence):
(parseSpaces):
(parseProperties):
(buildKeyAndValueFrom):
(createSizeVariants):
(createStretchy):

• web-platform-tests/mathml/tools/operator-dictionary.xsl: Added.
• web-platform-tests/mathml/tools/utils/misc.py:
• web-platform-tests/mathml/tools/utils/w3c-import.log:
• web-platform-tests/mathml/tools/w3c-import.log:

LayoutTests:

• TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/legacy-mrow-like-elements-001-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/legacy-mstyle-attributes-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/dir-mo-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-001-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/cramped-001-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/table-001-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/table-002-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-001-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Added.
• platform/ios-wk1/imported/w3c/web-platform-tests/matml/presentation-markup/operators/operator-dictionary-001-expected.txt: Added.
• platform/ios-wk1/imported/w3c/web-platform-tests/matml/relations/css-styling/ignored-properties-001-expected.txt: Added.
• platform/mac/TestExpectations:
• tests-options.json:

1:45 AM Changeset in webkit [250126] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

UI process crash when using callOnMainThread() after the main thread dispatcher has been destroyed
​https://bugs.webkit.org/show_bug.cgi?id=197266

Patch by Libor Bukata <​libor.bukata@oracle.com> on 2019-09-20
Reviewed by Carlos Garcia Campos.

• wtf/generic/MainThreadGeneric.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):

1:33 AM Changeset in webkit [250125] by jh718.park@samsung.com

• 2 edits in trunk/Source/WebKit

Unreviewed. Remove duplicated HashMap iteration since r248734.

ASSERT statement already exists for |storageNamespaceID|,
so |HashMap.get| for the parameter is not needed.

• NetworkProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::destroySessionStorageNamespace):

1:28 AM Changeset in webkit [250124] by Devin Rousso

• 9 edits in trunk/Source/JavaScriptCore

ASSERT NOT REACHED in Inspector::InjectedScriptModule::ensureInjected() seen with inspector/heap/getRemoteObject.html
​https://bugs.webkit.org/show_bug.cgi?id=201713
<rdar://problem/55290349>

Reviewed by Joseph Pecoraro.

Expose the Exception object by leveraging an Expected of JSValue as the return value
instead of using a referenced bool (which wouldn't include any of the exception's info).

• bindings/ScriptFunctionCall.h:
• bindings/ScriptFunctionCall.cpp:

(Deprecated::ScriptFunctionCall::call):

• inspector/InjectedScript.cpp:

(Inspector::InjectedScript::wrapCallFrames const):
(Inspector::InjectedScript::wrapObject const):
(Inspector::InjectedScript::wrapJSONString const):
(Inspector::InjectedScript::wrapTable const):
(Inspector::InjectedScript::previewValue const):
(Inspector::InjectedScript::findObjectById const):
(Inspector::InjectedScript::releaseObjectGroup):

• inspector/InjectedScriptBase.h:
• inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::callFunctionWithEvalEnabled const):
(Inspector::InjectedScriptBase::makeCall):
(Inspector::InjectedScriptBase::makeAsyncCall):

• inspector/InjectedScriptManager.h:
• inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::createInjectedScript):
(Inspector::InjectedScriptManager::injectedScriptFor):

• inspector/InjectedScriptModule.cpp:

(Inspector::InjectedScriptModule::ensureInjected):

12:09 AM Changeset in webkit [250123] by jh718.park@samsung.com

• 3 edits in trunk/Source/WebKit

Unreviewed. Fix Build warning below since r248734.

warning: unused variable ‘foo’ [-Wunused-variable]

• NetworkProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::destroySessionStorageNamespace):

• NetworkProcess/WebStorage/StorageManagerSet.cpp:

(WebKit::StorageManagerSet::add):
(WebKit::StorageManagerSet::waitUntilTasksFinished):