⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 3, 2019:

11:15 PM Changeset in webkit [250707] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK] WebAutomation: make setWindowRect synchronous
​https://bugs.webkit.org/show_bug.cgi?id=202530

Reviewed by Carlos Alberto Lopez Perez.

Move/resize window is asynchronous in GTK, but automation expects it to be synchronous so that get window rect
after setting it always returns the value set. Use a nested run loop to wait for the configure events after the
move/resize.

  • UIProcess/API/glib/WebKitUIClient.cpp:

(UIClient::windowConfigureEventCallback):
(UIClient::setWindowFrameTimerFired):

11:04 PM Changeset in webkit [250706] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

Unreviewed. Address review comments after r250646.

I forgot to include the documentation improvements suggested.

  • UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_class_init):

10:52 PM Changeset in webkit [250705] by Alan Coon
  • 7 edits in branches/safari-608.3-branch/Source

Versioning.

10:50 PM Changeset in webkit [250704] by Alan Coon
  • 5 edits
    1 add in branches/safari-608.3-branch

Cherry-pick r249538. rdar://problem/55911485

LazyClassStructure::setConstructor should not store the constructor to the global object
​https://bugs.webkit.org/show_bug.cgi?id=201484
<rdar://problem/50400451>

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/web-assembly-constructors-should-not-override-global-object-property.js: Added.

Source/JavaScriptCore:

LazyClassStructure::setConstructor sets the constructor as a property of the global object.
This became a problem when it started being used for WebAssembly constructors, such as Module
and Instance, since they are properties of the WebAssembly object, not the global object. That
resulted in properties of the global object replaced whenever a lazy WebAssembly constructor
was first accessed. e.g.

globalThis.Module = x;
WebAssembly.Module;
globalThis.Module === WebAssembly.Module;

  • runtime/LazyClassStructure.cpp: (JSC::LazyClassStructure::Initializer::setConstructor):
  • runtime/LazyClassStructure.h:
  • runtime/Lookup.h: (JSC::reifyStaticProperty):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:36 PM Changeset in webkit [250703] by Alan Coon
  • 1 copy in tags/Safari-608.2.40.1.2

Tag Safari-608.2.40.1.2.

10:32 PM Changeset in webkit [250702] by Alan Coon
  • 7 edits in branches/safari-608.2.40.1-branch/Source

Versioning.

10:22 PM Changeset in webkit [250701] by Antti Koivisto
  • 5 edits in trunk

[CSS Shadow Parts] Correct interaction with other pseudo elements
​https://bugs.webkit.org/show_bug.cgi?id=202526

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-shadow-parts/interaction-with-pseudo-elements-expected.txt:

Source/WebCore:

Cases like foo::part(bar)::before should work.

This patch doesn't cover ::placeholder which is implemented as PseudoElementWebKitCustom (like internal -webkit-* properties).

  • css/CSSSelector.h:

(WebCore::isTreeStructuralPseudoClass):

Add a helper.

  • css/parser/CSSSelectorParser.cpp:

Allow non-structural pseudo classes after ::part().
Allow other pseudo elements after ::part().

(WebCore::CSSSelectorParser::consumePseudo):

No need for DisallowPseudoElementsScope, we are just parsing identifiers.

10:05 PM Changeset in webkit [250700] by chris.reid@sony.com
  • 3 edits in trunk/Source/WebKit

[WinCairo] Remote inspector client target list is racy
​https://bugs.webkit.org/show_bug.cgi?id=202169

Reviewed by Ross Kirsling.

Original patch by Basuke Suzuki.

Use LoaderClient to defer javascript target update calls to until after the page finished load.

  • UIProcess/socket/RemoteInspectorProtocolHandler.cpp:
  • UIProcess/socket/RemoteInspectorProtocolHandler.h:
10:05 PM Changeset in webkit [250699] by chris.reid@sony.com
  • 3 edits in trunk/Source/JavaScriptCore

[WinCairo] Remote Inspector doesn't gracefully shutdown
​https://bugs.webkit.org/show_bug.cgi?id=202546

Reviewed by Ross Kirsling.

Call shutdown before closesocket in windows to close the connection gracefully.

This also fixes some potential threading issues where m_clientConnection
is set on a worker thread but cleared on the main thread.
Remove callOnMainThread in the server too since execution gets paused during JS breakpoints.

  • inspector/remote/socket/RemoteInspectorServer.cpp:
  • inspector/remote/socket/win/RemoteInspectorSocketWin.cpp:
8:49 PM Changeset in webkit [250698] by Keith Rollin
  • 2 edits in trunk/Source/WTF

Remove some support for < iOS 13
​https://bugs.webkit.org/show_bug.cgi?id=202549
<rdar://problem/55967232>

Reviewed by Alex Christensen.

Remove some support for iOS versions less than 13.0.

Update conditionals that reference IPHONE_OS_VERSION_MIN_REQUIRED
and IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
values >= 130000. This means that expressions like
"IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
"IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.

This removal is part of a series of patches effecting the removal of
dead code for old versions of iOS. This particular pass involves
changes in which Michael Saboff was involved. These changes are
isolated from other similar changes in order to facilitate the
reviewing process.

  • wtf/spi/darwin/ProcessMemoryFootprint.h:
8:48 PM Changeset in webkit [250697] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Fix WebGL 1 conformance regressions when USE_ANGLE=1
​https://bugs.webkit.org/show_bug.cgi?id=202545

Prevent ANGLE from automatically using ES3 when ES2 is requested.

WEBGL_debug_shaders extension should not accept or return null.

Enable ANGLE's new support for emulating RGB on RGBA IOSurfaces.

Patch by James Darpinian <James Darpinian> on 2019-10-03
Reviewed by Alex Christensen.

  • html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::getTranslatedShaderSource):

  • html/canvas/WebGLDebugShaders.h:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::validateVertexAttributes):

  • platform/graphics/angle/Extensions3DANGLE.cpp:

(WebCore::Extensions3DANGLE::getTranslatedShaderSourceANGLE):

  • platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer allocateIOSurfaceBackingStoreWithSize:usingAlpha:]):

7:00 PM Changeset in webkit [250696] by rniwa@webkit.org
  • 14 edits
    37 adds in trunk/LayoutTests

Resync WPT shadow DOM tests
​https://bugs.webkit.org/show_bug.cgi?id=202497

Rubber-stamped by Sam Weinig.

LayoutTests/imported/w3c:

Sync shadow DOM tests as of e33c216e635b4615e4332953fcb758f698ecd510. Also added enough support for
sending key events so that sequential focusing tests would work.

  • web-platform-tests/resources/testdriver-vendor.js:
  • web-platform-tests/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint-expected.txt:
  • web-platform-tests/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html:
  • web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element.html:
  • web-platform-tests/shadow-dom/Element-interface-attachShadow-expected.txt:
  • web-platform-tests/shadow-dom/Element-interface-attachShadow.html:
  • web-platform-tests/shadow-dom/META.yml: Added.
  • web-platform-tests/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees-expected.txt: Added.
  • web-platform-tests/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees.html: Added.
  • web-platform-tests/shadow-dom/directionality-002.tentative-expected.html: Added.
  • web-platform-tests/shadow-dom/directionality-002.tentative.html: Added.
  • web-platform-tests/shadow-dom/focus/DocumentOrShadowRoot-activeElement-expected.txt: Added.
  • web-platform-tests/shadow-dom/focus/DocumentOrShadowRoot-activeElement.html: Added.
  • web-platform-tests/shadow-dom/focus/focus-selector-delegatesFocus-expected.txt: Added.
  • web-platform-tests/shadow-dom/focus/focus-selector-delegatesFocus.html: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-negative-expected.txt: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-negative.html: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-slot-one-expected.txt: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-slot-one.html: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-varying-tabindex-expected.txt: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-varying-tabindex.html: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-zero-expected.txt: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-zero-host-negative-expected.txt: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-zero-host-negative.html: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-zero-host-not-set-expected.txt: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-zero-host-not-set.html: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-zero-host-one-expected.txt: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-zero-host-one.html: Added.
  • web-platform-tests/shadow-dom/focus/focus-tabindex-order-shadow-zero.html: Added.
  • web-platform-tests/shadow-dom/focus/resources/shadow-utils.js: Added.

(prepareDOM):
(setTabIndex):
(removeTabIndex):
(resetFocus):
(navigateFocusForward):
(async.assertFocusOrder):

  • web-platform-tests/shadow-dom/focus/resources/w3c-import.log: Added.
  • web-platform-tests/shadow-dom/focus/w3c-import.log: Added.
  • web-platform-tests/shadow-dom/offsetParent-across-shadow-boundaries-expected.txt: Added.
  • web-platform-tests/shadow-dom/offsetParent-across-shadow-boundaries.html: Added.
  • web-platform-tests/shadow-dom/resources/shadow-dom.js:

(createTestTree):

  • web-platform-tests/shadow-dom/scroll-to-the-fragment-in-shadow-tree.html:
  • web-platform-tests/shadow-dom/w3c-import.log:

LayoutTests:

Added a failing expectation. Also skipped focus tests on iOS for now since sending tab key via UIController
doesn't seem to move the focus on iOS somehow even though manual testing seems to work.

  • TestExpectations:
  • platform/ios/TestExpectations:
  • /platform/mac-highsierra-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Added.
6:26 PM Changeset in webkit [250695] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix testmasm failure on ASan builds.
​https://bugs.webkit.org/show_bug.cgi?id=202554

Reviewed by Yusuke Suzuki.

Gigacage is disabled on ASan builds. So testmasm is sad. Make the relevant test
bail gracefully if Gigacage should be disabled.

Also converted some ASSERTs into RELEASE_ASSERTs. This is a test. No reason to
not assert always.

  • assembler/testmasm.cpp:

(JSC::testCagePreservesPACFailureBit):

6:09 PM Changeset in webkit [250694] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

[iOS] WebContent process can be interrupted during suspension; loses "Now Playing" status
​https://bugs.webkit.org/show_bug.cgi?id=202537
<rdar://problem/55952707>

Reviewed by Eric Carlson.

Always deactivate the AVAudioSession when the last playing PlatformAudioSession ends playback and the application is in the background.

  • platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::removeSession): (WebCore::PlatformMediaSessionManager::processWillSuspend): (WebCore::PlatformMediaSessionManager::maybeDeactivateAudioSession):
  • platform/audio/PlatformMediaSessionManager.h: (WebCore::PlatformMediaSessionManager::isApplicationInBackground const):
  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::sessionWillEndPlayback):
5:37 PM Changeset in webkit [250693] by Chris Dumez
  • 7 edits
    5 adds in trunk

Allow pages using FontFaceSet to enter the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=202476

Reviewed by Myles C. Maxfield.

Source/WebCore:

Allow pages using FontFaceSet to enter the back/forward cache by updating its
implementation to queue all its tasks that run script to a SuspendableTaskQueue.
The SuspendableTaskQueue makes sure to properly suspend while in PageCache and
run the tasks when resuming from PageCache.

Test: http/tests/navigation/page-cache-fontfaceset.html

  • PlatformWin.cmake:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::fontLoadEventOccurred):

  • css/FontFaceSet.cpp:

(WebCore::FontFaceSet::FontFaceSet):
(WebCore::FontFaceSet::canSuspendForDocumentSuspension const):
(WebCore::FontFaceSet::didFirstLayout):
(WebCore::FontFaceSet::completedLoading):
(WebCore::FontFaceSet::faceFinished):

  • css/FontFaceSet.h:
  • platform/SuspendableTaskQueue.cpp: Added.

(WebCore::SuspendableTaskQueue::SuspendableTaskQueue):
(WebCore::SuspendableTaskQueue::close):
(WebCore::SuspendableTaskQueue::cancelAllTasks):
(WebCore::SuspendableTaskQueue::enqueueTask):
(WebCore::SuspendableTaskQueue::runOneTask):
(WebCore::SuspendableTaskQueue::activeDOMObjectName const):
(WebCore::SuspendableTaskQueue::canSuspendForDocumentSuspension const):
(WebCore::SuspendableTaskQueue::stop):
(WebCore::SuspendableTaskQueue::suspend):
(WebCore::SuspendableTaskQueue::resume):

  • platform/SuspendableTaskQueue.h: Added.

(WebCore::SuspendableTaskQueue::create):
(WebCore::SuspendableTaskQueue::isClosed const):
(WebCore::SuspendableTaskQueue::hasPendingTasks const):
Add a SuspendableTaskQueue class which is Page-Cache aware and can be used to queue
generic tasks as WTF::Function<void<>> lambdas.

LayoutTests:

Add layout test coverage.

  • http/tests/navigation/page-cache-fontfaceset-expected.txt: Added.
  • http/tests/navigation/page-cache-fontfaceset.html: Added.
  • http/tests/navigation/resources/page-cache-fontfaceset-iframe.html: Added.
4:08 PM Changeset in webkit [250692] by Alan Coon
  • 18 edits in branches/safari-608-branch

Cherry-pick r250659. rdar://problem/55954229

Support googleLegacyAppidSupport extension
​https://bugs.webkit.org/show_bug.cgi?id=202427
<rdar://problem/55887473>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch adds support for googleLegacyAppidSupport extension, when set:
1) user agent should only use the U2F transport protocol,
2) should only communicate with roaming authenticators, and
3) should use a hard-coded appID of ​https://www.gstatic.com/securitykey/origins.json.
To be noticed as the name implies, this extension is exclusively for RP ID = google.com.

Implementation wise, all operations are captured in methods with name processGoogleLegacyAppIdSupportExtension.
1) AuthenticatorCoordinator takes care of setting the value.
2) U2fCommandConstructor takes care of hard coding the AppID.
3) AuthenticatorManager takes care of removing AuthenticatorTransport::Internal from TransportSet, so startDiscovery
will not poke platform authenticators.
4) CtapAuthenticator takes care of downgrading to U2fAuthenticator.
5) U2fAuthenticator takes care of setting the AppID in the response.

Partially covered by new test cases in existing tests, and remaining will be covered by manual tests.

  • Modules/webauthn/AuthenticationExtensionsClientInputs.h: (WebCore::AuthenticationExtensionsClientInputs::encode const): (WebCore::AuthenticationExtensionsClientInputs::decode):
  • Modules/webauthn/AuthenticationExtensionsClientInputs.idl:
  • Modules/webauthn/AuthenticatorCoordinator.cpp: (WebCore::AuthenticatorCoordinatorInternal::processGoogleLegacyAppIdSupportExtension): (WebCore::AuthenticatorCoordinator::create const):
  • Modules/webauthn/PublicKeyCredentialCreationOptions.h: (WebCore::PublicKeyCredentialCreationOptions::encode const): (WebCore::PublicKeyCredentialCreationOptions::decode):
  • Modules/webauthn/fido/U2fCommandConstructor.cpp: (fido::convertToU2fRegisterCommand): (fido::processGoogleLegacyAppIdSupportExtension):
  • Modules/webauthn/fido/U2fCommandConstructor.h:

Source/WebKit:

  • UIProcess/WebAuthentication/AuthenticatorManager.cpp: (WebKit::AuthenticatorManagerInternal::collectTransports): (WebKit::AuthenticatorManagerInternal::processGoogleLegacyAppIdSupportExtension): (WebKit::AuthenticatorManager::handleRequest):
  • UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp: (WebKit::CtapAuthenticator::makeCredential): (WebKit::CtapAuthenticator::processGoogleLegacyAppIdSupportExtension):
  • UIProcess/WebAuthentication/fido/CtapAuthenticator.h:
  • UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp: (WebKit::U2fAuthenticator::continueRegisterCommandAfterResponseReceived):

Tools:

Adds an API test for googleLegacyAppidSupport extension.

  • TestWebKitAPI/Tests/WebCore/FidoTestData.h:
  • TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: (TestWebKitAPI::constructMakeCredentialRequest): (TestWebKitAPI::constructMakeCredentialRequestWithGoogleLegacyAppidSupport): (TestWebKitAPI::TEST):

LayoutTests:

Add tests to confirm the googleLegacyAppidSupport extension is ignored for RP ID != google.com.

  • http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-success-hid.https.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:08 PM Changeset in webkit [250691] by Alan Coon
  • 13 edits in branches/safari-608-branch/Source

Cherry-pick r249949. rdar://problem/55964883

[WebAuthn] Use WebPreferences instead of RuntimeEnabledFeatures in UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=198176
<rdar://problem/55285709>

Reviewed by Youenn Fablet.

Source/WebCore:

No changes of behavior.

  • Modules/webauthn/PublicKeyCredential.cpp: (WebCore::PublicKeyCredential::isUserVerifyingPlatformAuthenticatorAvailable): Resolves the promise with false immediately when the feature flag is false.

Source/WebKit:

This patch does the following two things:
1) It merges WebAuthenticationRequestData::creationOptions and requestOptions into a variant, and therefore
merges code paths that involve WebAuthenticationRequestData.
2) It teaches WebAuthenticationRequestData to store a WebPreferences such that AuthenticatorManager could utilize
runtime feature flags to turn features on or off.

  • UIProcess/WebAuthentication/Authenticator.cpp: (WebKit::Authenticator::handleRequest):
  • UIProcess/WebAuthentication/AuthenticatorManager.cpp: (WebKit::AuthenticatorManager::handleRequest): (WebKit::AuthenticatorManager::clearState): (WebKit::AuthenticatorManager::authenticatorAdded): (WebKit::AuthenticatorManager::startDiscovery): (WebKit::AuthenticatorManager::makeCredential): Deleted. (WebKit::AuthenticatorManager::getAssertion): Deleted.
  • UIProcess/WebAuthentication/AuthenticatorManager.h:
  • UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticator::makeCredential): (WebKit::LocalAuthenticator::continueMakeCredentialAfterUserConsented): (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested): (WebKit::LocalAuthenticator::getAssertion): (WebKit::LocalAuthenticator::continueGetAssertionAfterUserConsented):
  • UIProcess/WebAuthentication/Cocoa/LocalService.mm: (WebKit::LocalService::isAvailable): Don't check RuntimeEnabledFeatures given it is for WebCore.
  • UIProcess/WebAuthentication/WebAuthenticationRequestData.h: (): Deleted.
  • UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp: (WebKit::WebAuthenticatorCoordinatorProxy::makeCredential): (WebKit::WebAuthenticatorCoordinatorProxy::getAssertion): (WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
  • UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
  • UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp: (WebKit::CtapAuthenticator::makeCredential): (WebKit::CtapAuthenticator::continueMakeCredentialAfterResponseReceived const): (WebKit::CtapAuthenticator::getAssertion):
  • UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp: (WebKit::U2fAuthenticator::makeCredential): (WebKit::U2fAuthenticator::checkExcludeList): (WebKit::U2fAuthenticator::issueRegisterCommand): (WebKit::U2fAuthenticator::getAssertion): (WebKit::U2fAuthenticator::issueSignCommand): (WebKit::U2fAuthenticator::continueRegisterCommandAfterResponseReceived): (WebKit::U2fAuthenticator::continueSignCommandAfterResponseReceived):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:07 PM Changeset in webkit [250690] by Alan Coon
  • 2 edits in branches/safari-608-branch/Tools

Cherry-pick r248325. rdar://problem/55964805

Unreviewed, a build fix after r248308

Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.

  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@248325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:07 PM Changeset in webkit [250689] by Alan Coon
  • 4 edits in branches/safari-608-branch

Unreviewed, a build fix after r248319.

Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.

Source/WebKit:

  • UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticator::makeCredential):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserConsented):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
(WebKit::LocalAuthenticator::getAssertion):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserConsented):

Tools:

  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::addTestKeyToKeychain):
(WTR::TestController::cleanUpKeychain):
(WTR::TestController::keyExistsInKeychain):

4:07 PM Changeset in webkit [250688] by Alan Coon
  • 6 edits in branches/safari-608-branch

Cherry-pick r248319. rdar://problem/55964805

Unreviewed, a build fix after r248308

Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.

Source/WebKit:

  • UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticator::makeCredential): (WebKit::LocalAuthenticator::continueMakeCredentialAfterUserConsented): (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested): (WebKit::LocalAuthenticator::getAssertion): (WebKit::LocalAuthenticator::continueGetAssertionAfterUserConsented):

Source/WTF:

  • wtf/Platform.h:

Tools:

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::addTestKeyToKeychain): (WTR::TestController::cleanUpKeychain): (WTR::TestController::keyExistsInKeychain):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@248319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:07 PM Changeset in webkit [250687] by Alan Coon
  • 16 edits
    1 add in branches/safari-608-branch

Cherry-pick r248308. rdar://problem/55964805

[WebAuthN] Enable LocalAuthenticator for macOS
​https://bugs.webkit.org/show_bug.cgi?id=182772
<rdar://problem/43347920>

Reviewed by Brent Fulgham.

Source/WebKit:

This patch enables LocalAuthenticator for macOS. The majority
of this patch is to tweak macOS keychain to use the modern one.

  • Configurations/WebKit.xcconfig:
  • Platform/spi/Cocoa/DeviceIdentitySPI.h:
  • UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticatorInternal::toVector): (WebKit::LocalAuthenticator::makeCredential): (WebKit::LocalAuthenticator::continueMakeCredentialAfterUserConsented): (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested): (WebKit::LocalAuthenticator::getAssertion): (WebKit::LocalAuthenticator::continueGetAssertionAfterUserConsented):
  • UIProcess/WebAuthentication/Cocoa/LocalConnection.mm: (WebKit::LocalConnection::getUserConsent const): (WebKit::LocalConnection::getAttestation const):
  • UIProcess/WebAuthentication/Cocoa/LocalService.mm: (WebKit::LocalService::isAvailable):
  • UIProcess/WebAuthentication/Mock/MockLocalConnection.mm: (WebKit::MockLocalConnection::getAttestation const):
  • config.h:

Source/WTF:

  • wtf/Platform.h: Adds HAVE_DEVICE_IDENTITY.
  • wtf/spi/cocoa/SecuritySPI.h: Adds a SPI for telling macOS keychain to use the modern one.

Tools:

Add an entitlement file to WebKitTestRunner such that it can access
the modern macOS keychain.

  • WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::addTestKeyToKeychain): (WTR::TestController::cleanUpKeychain): (WTR::TestController::keyExistsInKeychain):

LayoutTests:

Enable existing local authenticator tests for macOS. Since OpenSource bots
don't have the internal setting to include restricted entitlements, tests
will fail on OpenSource bots.

  • platform/mac-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@248308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:16 PM Changeset in webkit [250686] by Chris Dumez
  • 5 edits
    2 adds in trunk

Provisional / scheduled loads in subframes should not prevent a page from entering the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=202474

Reviewed by Alex Christensen.

Source/WebCore:

Provisional / scheduled loads in subframes should not prevent a page from entering the back/forward cache.
To address the issue, we now make sure to stop all loads before checking for PageCache eligibility.

Test: fast/history/page-cache-quick-redirect-iframe.html

  • history/PageCache.cpp:

(WebCore::PageCache::addIfCacheable):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopForPageCache):

  • loader/FrameLoader.h:

LayoutTests:

Add layout test coverage.

  • fast/history/page-cache-subframes-with-provisional-load-expected.txt: Added.
  • fast/history/page-cache-subframes-with-provisional-load.html: Added.
2:41 PM Changeset in webkit [250685] by Alan Coon
  • 18 edits in branches/safari-608-branch

Cherry-pick r249108. rdar://problem/55927253

[WebAuthn] Support HID authenticators on iOS
​https://bugs.webkit.org/show_bug.cgi?id=201084
<rdar://problem/51908390>

Reviewed by Youenn Fablet.

Source/WebCore/PAL:

  • pal/spi/cocoa/IOKitSPI.h: Move IOHIDDevice.h and IOHIDManager.h to IOKitSPI.h given they are in iOS.

Source/WebKit:

This patch makes the macOS HID implementation available in iOS as well.
Mostly, it removes the PLATFORM(MAC) compile time flag.

  • UIProcess/WebAuthentication/AuthenticatorManager.cpp: (WebKit::AuthenticatorManagerInternal::collectTransports):
  • UIProcess/WebAuthentication/AuthenticatorTransportService.cpp: (WebKit::AuthenticatorTransportService::create): (WebKit::AuthenticatorTransportService::createMock):
  • UIProcess/WebAuthentication/Cocoa/HidConnection.h:
  • UIProcess/WebAuthentication/Cocoa/HidConnection.mm:
  • UIProcess/WebAuthentication/Cocoa/HidService.h:
  • UIProcess/WebAuthentication/Cocoa/HidService.mm:
  • UIProcess/WebAuthentication/Cocoa/NfcConnection.mm: (WebKit::NfcConnection::NfcConnection): A tentative solution before there is an official UI.
  • UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
  • UIProcess/WebAuthentication/Mock/MockHidConnection.h:
  • UIProcess/WebAuthentication/Mock/MockHidService.cpp:
  • UIProcess/WebAuthentication/Mock/MockHidService.h:
  • UIProcess/WebAuthentication/fido/CtapHidDriver.cpp:
  • UIProcess/WebAuthentication/fido/CtapHidDriver.h:

LayoutTests:

  • platform/ios-wk2/TestExpectations: Unskips HID tests for iOS.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:41 PM Changeset in webkit [250684] by Alan Coon
  • 4 edits in branches/safari-608-branch/Source

Cherry-pick r249068. rdar://problem/55927255

Unreviewed, build fix after r249059

Source/WebKit:

  • UIProcess/WebAuthentication/Cocoa/NfcConnection.mm: (WebKit::NfcConnection::NfcConnection): Remove the HAVE() macro.

Source/WTF:

  • wtf/Platform.h: Make HAVE_NEAR_FIELD available only on iOS 13+ and macOS Catalina+.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:41 PM Changeset in webkit [250683] by Alan Coon
  • 31 edits
    9 copies
    16 adds in branches/safari-608-branch

Cherry-pick r249059. rdar://problem/55927255

[WebAuthn] Support NFC authenticators for iOS
​https://bugs.webkit.org/show_bug.cgi?id=188624
<rdar://problem/43354214>

Reviewed by Chris Dumez.

Source/WebCore:

Tests: http/wpt/webauthn/ctap-nfc-failure.https.html

http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html
http/wpt/webauthn/public-key-credential-create-success-nfc.https.html
http/wpt/webauthn/public-key-credential-get-failure-nfc.https.html
http/wpt/webauthn/public-key-credential-get-success-nfc.https.html

  • Modules/webauthn/apdu/ApduResponse.h: Adds a new method to support moving m_data.
  • Modules/webauthn/fido/FidoConstants.h: Adds constants for NFC applet selection.

Source/WebKit:

This patch implements support for NFC authenticators including both FIDO2 and U2F ones. It utilizes a private
framework called NearField instead of CoreNFC to be able to supply a custom UI later if necessary.

The patch follows almost the same flow as previous HID and Local authenticator support.
1) Discovery is via NfcService which will invoke NFHardwareManager to start a generic NFC reader session.
2) Once a reader session is established, a NfcConnection is created to start the polling and register the WKNFReaderSessionDelegate
to wait for 'didDetectTags'.
3) When tags are detected, NfcConnection will determine if it meets our requriements: { type, connectability, fido applet availability }.
The first tag that meets all requirement will then be returned for WebAuthn operations.
4) The first WebAuthn operation is to send authenticatorGetInfo command to determine the supported protocol, and then initialize corresponding
authenticators. Noted, the sending/receiving of this command is now abstracted into FidoService which will be shared across HidService and NfcService.
5) From then, the actual WebAuthn request, either makeCredential or getAssertion will be sent.

For testing, this patch follows the same flow as well.
1) MockNfcService overrides NfcService to mock the behavior of NFC Tags discovery.
2) The same class also swizzles methods from NFReaderSession to mock tag connection and communication.

  • Platform/spi/Cocoa/NearFieldSPI.h: Added.
  • Sources.txt:
  • SourcesCocoa.txt:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):
  • UIProcess/WebAuthentication/AuthenticatorManager.cpp: (WebKit::AuthenticatorManagerInternal::collectTransports):
  • UIProcess/WebAuthentication/AuthenticatorTransportService.cpp: (WebKit::AuthenticatorTransportService::create): (WebKit::AuthenticatorTransportService::createMock):
  • UIProcess/WebAuthentication/Cocoa/HidService.h:
  • UIProcess/WebAuthentication/Cocoa/HidService.mm: (WebKit::HidService::HidService): (WebKit::HidService::deviceAdded): (WebKit::HidService::continueAddDeviceAfterGetInfo): Deleted.
  • UIProcess/WebAuthentication/Cocoa/NearFieldSoftLink.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h.
  • UIProcess/WebAuthentication/Cocoa/NearFieldSoftLink.mm: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h.
  • UIProcess/WebAuthentication/Cocoa/NfcConnection.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h.
  • UIProcess/WebAuthentication/Cocoa/NfcConnection.mm: Added. (WebKit::fido::compareVersion): (WebKit::NfcConnection::NfcConnection): (WebKit::NfcConnection::~NfcConnection): (WebKit::NfcConnection::transact const): (WebKit::NfcConnection::didDetectTags const):
  • UIProcess/WebAuthentication/Cocoa/NfcService.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h.
  • UIProcess/WebAuthentication/Cocoa/NfcService.mm: Added. (WebKit::NfcService::NfcService): (WebKit::NfcService::~NfcService): (WebKit::NfcService::didConnectTag): (WebKit::NfcService::startDiscoveryInternal): (WebKit::NfcService::platformStartDiscovery):
  • UIProcess/WebAuthentication/Cocoa/WKNFReaderSessionDelegate.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h.
  • UIProcess/WebAuthentication/Cocoa/WKNFReaderSessionDelegate.mm: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h. (-[WKNFReaderSessionDelegate initWithConnection:]): (-[WKNFReaderSessionDelegate readerSession:didDetectTags:]):
  • UIProcess/WebAuthentication/Mock/MockHidConnection.cpp: (WebKit::MockHidConnection::send): (WebKit::MockHidConnection::registerDataReceivedCallbackInternal): (WebKit::MockHidConnection::parseRequest): (WebKit::MockHidConnection::feedReports): (WebKit::MockHidConnection::shouldContinueFeedReports):
  • UIProcess/WebAuthentication/Mock/MockNfcService.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h.
  • UIProcess/WebAuthentication/Mock/MockNfcService.mm: Added. (-[WKMockNFTag type]): (-[WKMockNFTag initWithNFTag:]): (-[WKMockNFTag description]): (-[WKMockNFTag isEqualToNFTag:]): (-[WKMockNFTag initWithType:]): (WebKit::MockNfcService::MockNfcService): (WebKit::MockNfcService::transceive): (WebKit::MockNfcService::platformStartDiscovery): (WebKit::MockNfcService::detectTags const):
  • UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h:
  • UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
  • UIProcess/WebAuthentication/fido/CtapAuthenticator.h:
  • UIProcess/WebAuthentication/fido/CtapNfcDriver.cpp: Added. (WebKit::CtapNfcDriver::CtapNfcDriver): (WebKit::CtapNfcDriver::transact): (WebKit::CtapNfcDriver::respondAsync const):
  • UIProcess/WebAuthentication/fido/CtapNfcDriver.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h.
  • UIProcess/WebAuthentication/fido/FidoService.cpp: Added. (WebKit::FidoService::FidoService): (WebKit::FidoService::getInfo): (WebKit::FidoService::continueAfterGetInfo):
  • UIProcess/WebAuthentication/fido/FidoService.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.h.
  • UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:
  • UIProcess/WebAuthentication/fido/U2fAuthenticator.h:
  • UIProcess/ios/WebPageProxyIOS.mm:
  • WebKit.xcodeproj/project.pbxproj:

Source/WTF:

  • wtf/Platform.h: Add a feature flag for NearField.

Tools:

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setWebAuthenticationMockConfiguration): Setup NFC mock testing configuration.

LayoutTests:

  • http/wpt/webauthn/ctap-nfc-failure.https-expected.txt: Added.
  • http/wpt/webauthn/ctap-nfc-failure.https.html: Added.
  • http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt: Added.
  • http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html: Added.
  • http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-success-hid.https.html: This patch replaces the "local" keyword with "hid".
  • http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt: Added.
  • http/wpt/webauthn/public-key-credential-create-success-nfc.https.html: Added.
  • http/wpt/webauthn/public-key-credential-get-failure-nfc.https-expected.txt: Added.
  • http/wpt/webauthn/public-key-credential-get-failure-nfc.https.html: Added.
  • http/wpt/webauthn/public-key-credential-get-success-nfc.https-expected.txt: Added.
  • http/wpt/webauthn/public-key-credential-get-success-nfc.https.html: Added.
  • http/wpt/webauthn/resources/util.js:
  • platform/ios-simulator-wk2/TestExpectations: Skip NFC tests for simulators.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:41 PM Changeset in webkit [250682] by Alan Coon
  • 6 edits
    1 copy
    4 moves in branches/safari-608-branch/Source/WebKit

Cherry-pick r248631. rdar://problem/55934340

[WebAuthn] Make CtapHidAuthenticator/U2fHidAuthenticator to CtapAuthenticator/U2fAuthenticator
​https://bugs.webkit.org/show_bug.cgi?id=191527
<rdar://problem/54237146>

Reviewed by Chris Dumez.

This patch makes an ABC CtapDriver, which services as an abstract interface for CtapAuthenticator/U2fAuthenticator to talk to
the actual object that implement the specific CTAP protocol that mananges communications over different transports, for example,
CtapHidDriver, such that CtapAuthenticator/U2fAuthenticator can be shared across different transports.

This patch also renames CtapHidAuthenticator/U2fHidAuthenticator to CtapAuthenticator/U2fAuthenticator correspondingly.

  • Sources.txt:
  • UIProcess/WebAuthentication/Cocoa/HidService.mm: (WebKit::HidService::continueAddDeviceAfterGetInfo):
  • UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp: Renamed from Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp. (WebKit::CtapAuthenticator::CtapAuthenticator): (WebKit::CtapAuthenticator::makeCredential): (WebKit::CtapAuthenticator::continueMakeCredentialAfterResponseReceived const): (WebKit::CtapAuthenticator::getAssertion): (WebKit::CtapAuthenticator::continueGetAssertionAfterResponseReceived): (WebKit::CtapAuthenticator::tryDowngrade):
  • UIProcess/WebAuthentication/fido/CtapAuthenticator.h: Copied from Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidAuthenticator.h.
  • UIProcess/WebAuthentication/fido/CtapDriver.h: Renamed from Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidAuthenticator.h.
  • UIProcess/WebAuthentication/fido/CtapHidDriver.h: (WebKit::CtapHidDriver::setProtocol):
  • UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp: Renamed from Source/WebKit/UIProcess/WebAuthentication/fido/U2fHidAuthenticator.cpp. (WebKit::U2fAuthenticator::U2fAuthenticator): (WebKit::U2fAuthenticator::makeCredential): (WebKit::U2fAuthenticator::checkExcludeList): (WebKit::U2fAuthenticator::issueRegisterCommand): (WebKit::U2fAuthenticator::getAssertion): (WebKit::U2fAuthenticator::issueSignCommand): (WebKit::U2fAuthenticator::issueNewCommand): (WebKit::U2fAuthenticator::issueCommand): (WebKit::U2fAuthenticator::responseReceived): (WebKit::U2fAuthenticator::continueRegisterCommandAfterResponseReceived): (WebKit::U2fAuthenticator::continueCheckOnlyCommandAfterResponseReceived): (WebKit::U2fAuthenticator::continueBogusCommandAfterResponseReceived): (WebKit::U2fAuthenticator::continueSignCommandAfterResponseReceived):
  • UIProcess/WebAuthentication/fido/U2fAuthenticator.h: Renamed from Source/WebKit/UIProcess/WebAuthentication/fido/U2fHidAuthenticator.h.
  • WebKit.xcodeproj/project.pbxproj:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@248631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:40 PM Changeset in webkit [250681] by Alan Coon
  • 2 edits in branches/safari-608-branch/LayoutTests

Cherry-pick r249107. rdar://problem/55927255

Unreviewed, test gardening

  • platform/mac-wk2/TestExpectations: Skip WebAuthn tests for HighSierra and Mojave.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:40 PM Changeset in webkit [250680] by Alan Coon
  • 4 edits
    3 adds in branches/safari-608-branch/Source/WebKit

Cherry-pick r250658. rdar://problem/55954221

[WebAuthn] Implement dummy _WKWebAuthenticationPanel SPI
​https://bugs.webkit.org/show_bug.cgi?id=202507
<rdar://problem/55918793>

Reviewed by Brent Fulgham.

This patch implements dummy _WKWebAuthenticationPanel SPI to unblock Safari.

Here are the illustrations for each SPI:
1) -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] is used at the beginning of
any WebAuthn ceremonies. A WKFrameInfo is provided for more info of the initiating frame so clients could decide either show
the RP ID or the origin of the frame which may or may not be the RP ID. A callback of _WKWebAuthenticationPanelResult is
provided such that clients could inform WebKit to continue the ceremony or not. Case like rate limiting of a modular dialog
could result in _WKWebAuthenticationPanelResultDidNotPresent. Then WebKit will abort the operation.
_WKWebAuthenticationPanelResultUnavailable tells WebKit the client has no UI implemented and therefore WebKit will operate
in a non UI mode which basically will only enable HID authenticators, and is the current behavior of macOS Safari.
2) -[_WKWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:] is primarily to instruct users to do some
actionable thing to recover from some error state. However, it could be used for pure info as well. For
_WKWebAuthenticationPanelInfoMultipleNFCTagPresents, users can be instructed to only hold one NFC tag to the scanner. For
_WKWebAuthenticationPanelInfoNoCredentialsFound, users can potentially switch to another security key that could hit a match.
3) -[_WKWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:] is to dismiss UI.
_WKWebAuthenticationResult is provided such that client could show different animations as a hint to the user. The reasons for
failure could either be timeout or InvalidStateError which will be reported to the page as well. InvalidStateError signals a
credential matching an entry of the exclude list (excludeCredentials) is found on the authenticator.
4) -[_WKWebAuthenticationPanel cancel] is the way clients tell WebKit a user cancel.

  • SourcesCocoa.txt:
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h: Added.
  • UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm: Added. (-[_WKWebAuthenticationPanel _initWithRelayingPartyID:]): (-[_WKWebAuthenticationPanel relyingPartyID]): (-[_WKWebAuthenticationPanel cancel]):
  • UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h: Added.
  • WebKit.xcodeproj/project.pbxproj:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:37 PM Changeset in webkit [250679] by Ross Kirsling
  • 7 edits in trunk/Source

Socket RWI client should acquire backend commands from server
​https://bugs.webkit.org/show_bug.cgi?id=202421

Reviewed by Devin Rousso.

Source/JavaScriptCore:

  • inspector/remote/socket/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::setupInspectorClient):
(Inspector::RemoteInspectorServer::backendCommands const):

  • inspector/remote/socket/RemoteInspectorServer.h:

(Inspector::RemoteInspectorServer::setBackendCommandsPath):
Assuming a path to InspectorBackendCommands.js has been provided,
read the file and send off its base64-encoded contents in a "BackendCommands" message when setting up a client.

Source/WebKit:

  • UIProcess/socket/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorClient::dispatchMap):
(WebKit::RemoteInspectorClient::setBackendCommands):

  • UIProcess/socket/RemoteInspectorClient.h:

Receive "BackendCommands" message from server (which is already base64-encoded) and hand it over to RWIProxy.

  • UIProcess/win/WebProcessPoolWin.cpp:

(WebKit::backendCommandsPath):
(WebKit::initializeRemoteInspectorServer):
On Windows, initialize server with the path to InspectorBackendCommands.js from the CFBundle.

2:29 PM Changeset in webkit [250678] by Chris Dumez
  • 3 edits
    3 adds in trunk

XMLHttpRequest sometimes prevents pages from entering the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=202434
<rdar://problem/55890340>

Reviewed by Geoffrey Garen.

Source/WebCore:

XMLHttpRequest::canSuspendForDocumentSuspension() was returning false if the document has not fired
the window's load event, with a comment explaining that cancelling the XHR in the upon suspension
may cause the load event to get fired and thus run script when forbidden. However, we should only
return false if the XMLHttpRequest is actually loading (m_loader is not null). XHRs that are not
loading should never prevent page caching.

I saw failures to enter the back/forward cache on yandex.ru and taobao.com because of this.

Test: http/tests/navigation/page-cache-failed-xhr.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::canSuspendForDocumentSuspension const):

LayoutTests:

Add layout test coverage.

  • http/tests/navigation/page-cache-failed-xhr-expected.txt: Added.
  • http/tests/navigation/page-cache-failed-xhr.html: Added.
  • http/tests/navigation/resources/page-cache-failed-xhr-frame.html: Added.
2:16 PM Changeset in webkit [250677] by achristensen@apple.com
  • 10 edits in trunk/Source/WebKit

Replace _WKProcessPoolConfiguration.suppressesConnectionTerminationOnSystemChange with SPI on _WKWebsiteDataStoreConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=202544

Reviewed by Tim Horton.

The _WKProcessPoolConfiguration SPI was originally introduced in rdar://problem/40650244
Keep both working during the transition period, but we need it to not be on the process pool.

  • NetworkProcess/NetworkSessionCreationParameters.cpp:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

  • NetworkProcess/NetworkSessionCreationParameters.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:

(-[_WKWebsiteDataStoreConfiguration suppressesConnectionTerminationOnSystemChange]):
(-[_WKWebsiteDataStoreConfiguration setSuppressesConnectionTerminationOnSystemChange:]):

  • UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::parameters):

  • UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:

(WebKit::WebsiteDataStoreConfiguration::copy):

  • UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:

(WebKit::WebsiteDataStoreConfiguration::suppressesConnectionTerminationOnSystemChange const):
(WebKit::WebsiteDataStoreConfiguration::setSuppressesConnectionTerminationOnSystemChange):

1:50 PM Changeset in webkit [250676] by wilander@apple.com
  • 53 edits
    8 adds in trunk

Resource Load Statistics: Downgrade document.referrer for all third-party iframes
​https://bugs.webkit.org/show_bug.cgi?id=202506
<rdar://problem/55786397>

Reviewed by Brent Fulgham.

Source/WebCore:

This change downgrades document.referrer for all third-party iframes if ITP/Resource Load Statistics
is enabled. The behavior matches the downgrade of all HTTP referrers for third-party resources
which landed in ​https://trac.webkit.org/changeset/250413/webkit.

Tests: http/tests/resourceLoadStatistics/downgrade-document-referrer-nested-third-party-iframe.html

http/tests/resourceLoadStatistics/downgrade-document-referrer-third-party-iframe.html
http/tests/resourceLoadStatistics/leave-empty-document-referrer-alone-third-party-iframe.html

  • dom/Document.cpp:

(WebCore::Document::referrer):
(WebCore::Document::referrer const): Deleted.

Can no longer be const since it lazily downgrades and saves the referrer on read.

  • dom/Document.h:

LayoutTests:

The tests that are not new rely on document.referrer and so they are made to turn off
ITP before they run to maintain a full referrer.

  • http/tests/media/media-stream/enumerate-devices-source-id.html:
  • http/tests/referrer-policy-iframe/no-referrer-when-downgrade/cross-origin-http-http.html:
  • http/tests/referrer-policy-iframe/no-referrer-when-downgrade/cross-origin-http.https.html:
  • http/tests/referrer-policy-iframe/no-referrer-when-downgrade/same-origin.html:
  • http/tests/referrer-policy-iframe/no-referrer/cross-origin-http-http.html:
  • http/tests/referrer-policy-iframe/no-referrer/cross-origin-http.https.html:
  • http/tests/referrer-policy-iframe/no-referrer/same-origin.html:
  • http/tests/referrer-policy-iframe/origin-when-cross-origin/cross-origin-http-http.html:
  • http/tests/referrer-policy-iframe/origin-when-cross-origin/cross-origin-http.https.html:
  • http/tests/referrer-policy-iframe/origin-when-cross-origin/same-origin.html:
  • http/tests/referrer-policy-iframe/origin/cross-origin-http-http.html:
  • http/tests/referrer-policy-iframe/origin/cross-origin-http.https.html:
  • http/tests/referrer-policy-iframe/origin/same-origin.html:
  • http/tests/referrer-policy-iframe/same-origin/cross-origin-http-http.html:
  • http/tests/referrer-policy-iframe/same-origin/cross-origin-http.https.html:
  • http/tests/referrer-policy-iframe/same-origin/same-origin.html:
  • http/tests/referrer-policy-iframe/strict-origin-when-cross-origin/cross-origin-http-http.html:
  • http/tests/referrer-policy-iframe/strict-origin-when-cross-origin/cross-origin-http.https.html:
  • http/tests/referrer-policy-iframe/strict-origin-when-cross-origin/same-origin.html:
  • http/tests/referrer-policy-iframe/strict-origin/cross-origin-http-http.html:
  • http/tests/referrer-policy-iframe/strict-origin/cross-origin-http.https.html:
  • http/tests/referrer-policy-iframe/strict-origin/same-origin.html:
  • http/tests/referrer-policy-iframe/unsafe-url/cross-origin-http-http.html:
  • http/tests/referrer-policy-iframe/unsafe-url/cross-origin-http.https.html:
  • http/tests/referrer-policy-iframe/unsafe-url/same-origin.html:
  • http/tests/referrer-policy/no-referrer-when-downgrade/cross-origin-http-http.html:
  • http/tests/referrer-policy/no-referrer-when-downgrade/cross-origin-http.https.html:
  • http/tests/referrer-policy/no-referrer-when-downgrade/same-origin.html:
  • http/tests/referrer-policy/no-referrer/cross-origin-http-http.html:
  • http/tests/referrer-policy/no-referrer/cross-origin-http.https.html:
  • http/tests/referrer-policy/no-referrer/same-origin.html:
  • http/tests/referrer-policy/origin-when-cross-origin/cross-origin-http-http.html:
  • http/tests/referrer-policy/origin-when-cross-origin/cross-origin-http.https.html:
  • http/tests/referrer-policy/origin-when-cross-origin/same-origin.html:
  • http/tests/referrer-policy/origin/cross-origin-http-http.html:
  • http/tests/referrer-policy/origin/cross-origin-http.https.html:
  • http/tests/referrer-policy/origin/same-origin.html:
  • http/tests/referrer-policy/same-origin/cross-origin-http-http.html:
  • http/tests/referrer-policy/same-origin/cross-origin-http.https.html:
  • http/tests/referrer-policy/same-origin/same-origin.html:
  • http/tests/referrer-policy/strict-origin-when-cross-origin/cross-origin-http-http.html:
  • http/tests/referrer-policy/strict-origin-when-cross-origin/cross-origin-http.https.html:
  • http/tests/referrer-policy/strict-origin-when-cross-origin/same-origin.html:
  • http/tests/referrer-policy/strict-origin/cross-origin-http-http.html:
  • http/tests/referrer-policy/strict-origin/cross-origin-http.https.html:
  • http/tests/referrer-policy/strict-origin/same-origin.html:
  • http/tests/referrer-policy/unsafe-url/cross-origin-http-http.html:
  • http/tests/referrer-policy/unsafe-url/cross-origin-http.https.html:
  • http/tests/referrer-policy/unsafe-url/same-origin.html:
  • http/tests/resourceLoadStatistics/downgrade-document-referrer-nested-third-party-iframe-expected.txt: Added.
  • http/tests/resourceLoadStatistics/downgrade-document-referrer-nested-third-party-iframe.html: Added.
  • http/tests/resourceLoadStatistics/downgrade-document-referrer-third-party-iframe-expected.txt: Added.
  • http/tests/resourceLoadStatistics/downgrade-document-referrer-third-party-iframe.html: Added.
  • http/tests/resourceLoadStatistics/leave-empty-document-referrer-alone-third-party-iframe-expected.txt: Added.
  • http/tests/resourceLoadStatistics/leave-empty-document-referrer-alone-third-party-iframe.html: Added.
  • http/tests/resourceLoadStatistics/resources/nest-iframe-report-document-referrer.html: Added.
  • http/tests/resourceLoadStatistics/resources/report-document-referrer.html: Added.
1:49 PM Changeset in webkit [250675] by Alan Coon
  • 1 copy in tags/Safari-608.3.9

Tag Safari-608.3.9.

1:41 PM Changeset in webkit [250674] by dino@apple.com
  • 3 edits in branches/safari-608-branch/Source

Build fixes for r249855. rdar://problem/55927247

FrameIdentifier isn't a type on this branch yet, so just use uint64_t where necessary.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

  • testing/Internals.cpp:

(WebCore::Internals::frameIdentifier const):

Source/WebKit:

  • UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
1:08 PM Changeset in webkit [250673] by pvollan@apple.com
  • 17 edits
    1 add in trunk

REGRESSION(249649): Unable to open local files in MiniBrowser on macOS
​https://bugs.webkit.org/show_bug.cgi?id=201798

Reviewed by Brent Fulgham.

Source/WebKit:

The commit <​https://trac.webkit.org/changeset/249649> introduced a MiniBrowser regression on macOS where MiniBrowser
is not able to open local files. The change set r249649 fixed a problem where the WebContent process PID was not ready
to be used when creating a sandbox extension. This happened in the cases where the WebContent process had not finished
launching when the load started. The WebContent process is also creating sandbox extensions for the Networking process
for the files being loaded, and also needs to be passing the audit token of the Networking process when creating these.
This patch implements getting the audit token for the Networking process when the WebProcess is sending a message to
the UI process to establish the Networking process connection. The audit token is stored in the NetworkProcessConnection
object, and passed to the NetworkLoadParameters object when the load is started. Finally, when encoding the Network
resources load parameters, the audit token is used to create an extension for the Networking process.

API test: WKWebView.LoadFileWithLoadRequest

  • NetworkProcess/NetworkLoadParameters.h:
  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):

  • Platform/IPC/ArgumentCoders.cpp:

(IPC::ArgumentCoder<audit_token_t>::encode):
(IPC::ArgumentCoder<audit_token_t>::decode):

  • Platform/IPC/ArgumentCoders.h:
  • Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::SandboxExtensionImpl::create):
(WebKit::SandboxExtensionImpl::sandboxExtensionForType):
(WebKit::SandboxExtensionImpl::SandboxExtensionImpl):
(WebKit::SandboxExtension::createHandleForMachLookupByPid):
(WebKit::SandboxExtension::createHandleForReadByPid):
(WebKit::SandboxExtension::createHandleForReadByAuditToken):

  • Shared/SandboxExtension.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::openNetworkProcessConnection):

  • UIProcess/WebProcessProxy.messages.in:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Network/NetworkProcessConnection.h:

(WebKit::NetworkProcessConnection::setNetworkProcessAuditToken):
(WebKit::NetworkProcessConnection::networkProcessAuditToken const):

  • WebProcess/Network/NetworkProcessConnectionInfo.h: Added.

(WebKit::NetworkProcessConnectionInfo::identifier):
(WebKit::NetworkProcessConnectionInfo::encode const):
(WebKit::NetworkProcessConnectionInfo::decode):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::preconnectTo):

  • WebProcess/WebProcess.cpp:

(WebKit::getNetworkProcessConnection):
(WebKit::WebProcess::ensureNetworkProcessConnection):

Source/WTF:

Add HAVE_AUDIT_TOKEN and SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN defines.

  • wtf/Platform.h:

Tools:

Added API test WKWebView.LoadFileWithLoadRequest.

  • TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
12:38 PM Changeset in webkit [250672] by Devin Rousso
  • 24 edits
    2 deletes in trunk/Source/WebCore

Web Inspector: remove InspectorInstrumentationCookie
​https://bugs.webkit.org/show_bug.cgi?id=202487

Reviewed by Matt Baker.

All it does is create a shallow-copy of the InstrumentingAgents (it copies a pointer to
the InstrumentingAgents object, so any of the pointers to the InspectorAgent that are
contained therein are shared between each instance) and save the tracking
InspectorTimelineAgent's id (monotonically increasing integer).

All uses of InspectorInstrumentationCookie are local values, so there's no way that the
InspectorTimelineAgent (or the id) could change in between an
InspectorInstrumentation::will* and an InspectorInstrumentation::did*, as both the
tracking state and id are controlled by the frontend and cannot "interrupt".

Removing InspectorInstrumentationCookie _can_ cause issues is in situations where the
ScriptExecutionContext (or Page) changes between the InspectorInstrumentation::will*
and the InspectorInstrumentation::did*, but this can be avoided so long as a pointer to
the "context" used for InspectorInstrumentation::will* is saved.

Covered by existing tests: inspector/timeline/*

  • inspector/InspectorInstrumentationCookie.h: Removed.
  • inspector/InspectorInstrumentationCookie.cpp: Removed.
  • inspector/agents/InspectorTimelineAgent.h:
  • inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::didPaint):
(WebCore::InspectorTimelineAgent::clearRecordStack): Deleted.

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::constructCustomElementSynchronously):
(WebCore::JSCustomElementInterface::upgradeElement):
(WebCore::JSCustomElementInterface::invokeCallback):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSExecState.h:
  • bindings/js/JSExecStateInstrumentation.h:

(WebCore::JSExecState::instrumentFunctionInternal):
(WebCore::JSExecState::instrumentFunctionCall):
(WebCore::JSExecState::instrumentFunctionConstruct):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::executeFunctionInContext):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluateModule):

  • dom/Document.cpp:

(WebCore::Document::resolveStyle):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::innerInvokeEventListeners):

  • dom/MutationObserver.cpp:

(WebCore::MutationObserver::deliver):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceRequestAnimationFrameCallbacks):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::fired):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchEvent):

  • page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layout):

  • page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::notify):

  • page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::deliver):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::didCallFunction):
(WebCore::InspectorInstrumentation::willDispatchEvent):
(WebCore::InspectorInstrumentation::didDispatchEvent):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::didDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::willEvaluateScript):
(WebCore::InspectorInstrumentation::didEvaluateScript):
(WebCore::InspectorInstrumentation::willFireTimer):
(WebCore::InspectorInstrumentation::didFireTimer):
(WebCore::InspectorInstrumentation::willLayout):
(WebCore::InspectorInstrumentation::didLayout):
(WebCore::InspectorInstrumentation::willRecalculateStyle):
(WebCore::InspectorInstrumentation::didRecalculateStyle):
(WebCore::InspectorInstrumentation::willFireAnimationFrame):
(WebCore::InspectorInstrumentation::didFireAnimationFrame):
(WebCore::InspectorInstrumentation::willFireObserverCallback):
(WebCore::InspectorInstrumentation::didFireObserverCallback):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willCallFunctionImpl):
(WebCore::InspectorInstrumentation::didCallFunctionImpl):
(WebCore::InspectorInstrumentation::willDispatchEventImpl):
(WebCore::InspectorInstrumentation::didDispatchEventImpl):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::didDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::willEvaluateScriptImpl):
(WebCore::InspectorInstrumentation::didEvaluateScriptImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::didFireTimerImpl):
(WebCore::InspectorInstrumentation::willLayoutImpl):
(WebCore::InspectorInstrumentation::didLayoutImpl):
(WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameImpl):
(WebCore::InspectorInstrumentation::didFireAnimationFrameImpl):
(WebCore::InspectorInstrumentation::willFireObserverCallbackImpl):
(WebCore::InspectorInstrumentation::didFireObserverCallbackImpl):
(WebCore::InspectorInstrumentation::retrieveTimelineAgent): Deleted.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
12:34 PM Changeset in webkit [250671] by Alan Coon
  • 1 edit in branches/safari-608-branch/Source/WebCore/dom/Document.h

Unreviewed build fix. rdar://problem/55927247

12:34 PM Changeset in webkit [250670] by Alan Coon
  • 2 edits in branches/safari-608-branch/Source/WebKit

Cherry-pick r250619. rdar://problem/55927263

Provide originating website URL to AR QuickLook
​https://bugs.webkit.org/show_bug.cgi?id=202451

Reviewed by Antoine Quint.

Declare the setAdditionalParameters method and
call it with the originating page URL if available.

  • UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 PM Changeset in webkit [250669] by Alan Coon
  • 2 edits in branches/safari-608-branch/Source/WebCore

Cherry-pick r250238. rdar://problem/55927247

REGRESSION (r249855): Remove debug logging from WebCore::RenderImage::paintIntoRect()
<​https://webkit.org/b/202103>

Reviewed by Zalan Bujtas.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintIntoRect): Remove debug logging statements.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 PM Changeset in webkit [250668] by Alan Coon
  • 29 edits
    2 adds in branches/safari-608-branch

Cherry-pick r249855. rdar://problem/55927247

Provide a prototype for AR QuickLook to trigger processing in the originating page
​https://bugs.webkit.org/show_bug.cgi?id=201371
<rdar://54904781>

Reviewed by Simon Fraser.

Source/WebCore:

  • dom/Document.cpp: (WebCore::Document::dispatchSystemPreviewActionEvent): Create and dispatch a MessageEvent.
  • dom/Document.h:
  • html/HTMLAnchorElement.cpp: Send along the page and frame identifiers for this object to ensure that any reply goes to the correct place. (WebCore::HTMLAnchorElement::handleClick):
  • loader/FrameLoadRequest.h: Use the new SystemPreviewInfo type. (WebCore::FrameLoadRequest::isSystemPreview const): (WebCore::FrameLoadRequest::systemPreviewInfo const): (WebCore::FrameLoadRequest::systemPreviewRect const): Deleted.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL):
  • loader/FrameLoaderTypes.h: Provide encoders for the type. (WebCore::SystemPreviewInfo::encode const): (WebCore::SystemPreviewInfo::decode):
  • platform/network/ResourceRequestBase.cpp: Use the new type. (WebCore::ResourceRequestBase::isSystemPreview const): (WebCore::ResourceRequestBase::systemPreviewInfo const): (WebCore::ResourceRequestBase::setSystemPreviewInfo): (WebCore::ResourceRequestBase::setSystemPreview): Deleted. (WebCore::ResourceRequestBase::systemPreviewRect const): Deleted. (WebCore::ResourceRequestBase::setSystemPreviewRect): Deleted.
  • platform/network/ResourceRequestBase.h:
  • testing/Internals.cpp: Expose the frame and page identifiers to testing. (WebCore::Internals::frameIdentifier const): (WebCore::Internals::pageIdentifier const):
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

Provide a way for a Web page to know if an action in the AR scene
was performed, if and only if the system AR library calls a delegate with
particular parameters. Post a message to the originating frame so
the page can detect the action.

  • Scripts/webkit/messages.py: Include the right header for SystemPreviewInfo.
  • Shared/WebCoreArgumentCoders.cpp: Use SystemPreviewInfo. (IPC::ArgumentCoder<ResourceRequest>::encode): (IPC::ArgumentCoder<ResourceRequest>::decode):
  • UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _triggerSystemPreviewActionOnFrame:page:]): New helper/test function to trigger the system preview action.
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/Cocoa/DownloadClient.mm: Use new type. (WebKit::DownloadClient::didStart):
  • UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Implement the delegate so that we can detect an action. When it happens, tell the WebPageProxy to send a message.
  • UIProcess/Downloads/DownloadProxy.h: Use SystemPreviewInfo type. (WebKit::DownloadProxy::systemPreviewDownloadInfo const): (WebKit::DownloadProxy::systemPreviewDownloadRect const): Deleted.
  • UIProcess/SystemPreviewController.h: (WebKit::SystemPreviewController::previewInfo const):
  • UIProcess/WebPageProxy.cpp: Send it over to the Web Process. (WebKit::WebPageProxy::systemPreviewActionTriggered const):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: Check the destination still exists, and then talk to the Document. (WebKit::WebPage::systemPreviewActionTriggered):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • TestWebKitAPI/Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:25 PM Changeset in webkit [250667] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

REGRESSION: touchend doesn't trigger on element when touch is released outside of its bounds
​https://bugs.webkit.org/show_bug.cgi?id=202527
<rdar://55883213>

Patch by Antoine Quint <Antoine Quint> on 2019-10-03
Reviewed by Dean Jackson.

Add a test that checks a scenario where an element that listens to "touchstart", "touchmove" and "touchend" events
is only the target of move-phase touches but neither start and end phases. The code change that fixes the reported
issue where the "touchend" wouldn't be dispatched is done in Internal.

  • pointerevents/utils.js:

(EventTracker.prototype.handleEvent):
(EventTracker.prototype._handleTouchEvent):

12:03 PM Changeset in webkit [250666] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebCore

IndexedDB: add size estimate for key path when estimate task size
​https://bugs.webkit.org/show_bug.cgi?id=202480

Reviewed by Geoffrey Garen.

No observable behavior change.

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::estimateSize):

11:32 AM Changeset in webkit [250665] by Jonathan Bedard
  • 2 edits in trunk/Tools

Add myself to various tools watchlists
​https://bugs.webkit.org/show_bug.cgi?id=202532

Reviewed by Aakash Jain.

  • Scripts/webkitpy/common/config/watchlist: Add myself to the watchlist of

PerformanceTests, SVNScripts, webkitperl and webkitpy.

11:15 AM Changeset in webkit [250664] by Konstantin Tokarev
  • 3 edits in trunk/Source/WebKit

CMake-built WebKit.framework should launch XPC services successfully
​https://bugs.webkit.org/show_bug.cgi?id=202490

Reviewed by Carlos Alberto Lopez Perez.

target_link_options() requires CMake 3.10, however we can avoid
raising required CMake version by moving it to PlatformMac.cmake,
also avoid introduction of new CMake variable.

  • CMakeLists.txt:
  • PlatformMac.cmake:
11:09 AM Changeset in webkit [250663] by youenn@apple.com
  • 7 edits
    2 adds in trunk

Regression: iOS 13.1 MediaStreamTrack.enabled = false kills audio track
​https://bugs.webkit.org/show_bug.cgi?id=202405
<rdar://problem/55922616>

Reviewed by Eric Carlson.

Source/WebCore:

When the web page is setting enabled to false, media session might change from PlayRecord to None.
This might trigger CoreAudio to no longer output audio samples, thus triggering our audio capture failure timer.
This would end the track after 2 seconds.
Given audio tracks can be reenabled by a web page, we should not change the Media Session setup based on that.
This patch updates MediaStream::mediaType to return independently of the enabled state.

Add internals API to write a cross platform test.

Test: fast/mediastream/audio-track-enabled.html
Manually tested as well.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::mediaType const):

  • platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::hasCaptureAudioSource const):

  • testing/Internals.cpp:

(WebCore::Internals::supportsAudioSession const):
(WebCore::Internals::audioSessionCategory const):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • fast/mediastream/audio-track-enabled-expected.txt: Added.
  • fast/mediastream/audio-track-enabled.html: Added.
11:07 AM Changeset in webkit [250662] by youenn@apple.com
  • 7 edits in trunk

http/tests/security/navigate-when-restoring-cached-page.html should not use RTCPeerConnection to not enter in page cache
​https://bugs.webkit.org/show_bug.cgi?id=202521

Reviewed by Chris Dumez.

Source/WebCore:

Introduce a dummy ActiveDOMObject which can never be suspended for document suspension.
Allow a page to create this dummy ActiveDOMObject through internals.
Covered by updated test.

  • dom/ActiveDOMObject.h:
  • testing/Internals.cpp:

(WebCore::Internals::preventDocumentForEnteringPageCache):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Make use of new internals API to prevent the page to go in page cache.

  • http/tests/security/navigate-when-restoring-cached-page.html:
10:49 AM Changeset in webkit [250661] by timothy_horton@apple.com
  • 10 edits in trunk/Source/WebCore

WebKit doesn't build with trunk clang
​https://bugs.webkit.org/show_bug.cgi?id=202511

Reviewed by Anders Carlsson.

  • Modules/fetch/FetchLoader.h:
  • Modules/geolocation/Geolocation.h:
  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/shared/InProcessIDBServer.cpp:
  • Modules/indexeddb/shared/InProcessIDBServer.h:
  • Modules/notifications/Notification.cpp:
  • Modules/notifications/Notification.h:
  • platform/graphics/ca/TileController.h:
  • workers/service/context/ServiceWorkerThreadProxy.h:

Fix the build by exporting destructors and custom delete operators.
I don't know why this changed, but trunk clang insists.
There are also some new warnings; this only fixes the hard errors.

10:45 AM Changeset in webkit [250660] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Yet another build fix

  • css/typedom/TypedOMCSSImageValue.h:

Forward declare Document.

10:39 AM Changeset in webkit [250659] by jiewen_tan@apple.com
  • 18 edits in trunk

Support googleLegacyAppidSupport extension
​https://bugs.webkit.org/show_bug.cgi?id=202427
<rdar://problem/55887473>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch adds support for googleLegacyAppidSupport extension, when set:
1) user agent should only use the U2F transport protocol,
2) should only communicate with roaming authenticators, and
3) should use a hard-coded appID of ​https://www.gstatic.com/securitykey/origins.json.
To be noticed as the name implies, this extension is exclusively for RP ID = google.com.

Implementation wise, all operations are captured in methods with name processGoogleLegacyAppIdSupportExtension.
1) AuthenticatorCoordinator takes care of setting the value.
2) U2fCommandConstructor takes care of hard coding the AppID.
3) AuthenticatorManager takes care of removing AuthenticatorTransport::Internal from TransportSet, so startDiscovery
will not poke platform authenticators.
4) CtapAuthenticator takes care of downgrading to U2fAuthenticator.
5) U2fAuthenticator takes care of setting the AppID in the response.

Partially covered by new test cases in existing tests, and remaining will be covered by manual tests.

  • Modules/webauthn/AuthenticationExtensionsClientInputs.h:

(WebCore::AuthenticationExtensionsClientInputs::encode const):
(WebCore::AuthenticationExtensionsClientInputs::decode):

  • Modules/webauthn/AuthenticationExtensionsClientInputs.idl:
  • Modules/webauthn/AuthenticatorCoordinator.cpp:

(WebCore::AuthenticatorCoordinatorInternal::processGoogleLegacyAppIdSupportExtension):
(WebCore::AuthenticatorCoordinator::create const):

  • Modules/webauthn/PublicKeyCredentialCreationOptions.h:

(WebCore::PublicKeyCredentialCreationOptions::encode const):
(WebCore::PublicKeyCredentialCreationOptions::decode):

  • Modules/webauthn/fido/U2fCommandConstructor.cpp:

(fido::convertToU2fRegisterCommand):
(fido::processGoogleLegacyAppIdSupportExtension):

  • Modules/webauthn/fido/U2fCommandConstructor.h:

Source/WebKit:

  • UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManagerInternal::collectTransports):
(WebKit::AuthenticatorManagerInternal::processGoogleLegacyAppIdSupportExtension):
(WebKit::AuthenticatorManager::handleRequest):

  • UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:

(WebKit::CtapAuthenticator::makeCredential):
(WebKit::CtapAuthenticator::processGoogleLegacyAppIdSupportExtension):

  • UIProcess/WebAuthentication/fido/CtapAuthenticator.h:
  • UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:

(WebKit::U2fAuthenticator::continueRegisterCommandAfterResponseReceived):

Tools:

Adds an API test for googleLegacyAppidSupport extension.

  • TestWebKitAPI/Tests/WebCore/FidoTestData.h:
  • TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:

(TestWebKitAPI::constructMakeCredentialRequest):
(TestWebKitAPI::constructMakeCredentialRequestWithGoogleLegacyAppidSupport):
(TestWebKitAPI::TEST):

LayoutTests:

Add tests to confirm the googleLegacyAppidSupport extension is ignored for RP ID != google.com.

  • http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
9:48 AM Changeset in webkit [250658] by jiewen_tan@apple.com
  • 4 edits
    3 adds in trunk/Source/WebKit

[WebAuthn] Implement dummy _WKWebAuthenticationPanel SPI
​https://bugs.webkit.org/show_bug.cgi?id=202507
<rdar://problem/55918793>

Reviewed by Brent Fulgham.

This patch implements dummy _WKWebAuthenticationPanel SPI to unblock Safari.

Here are the illustrations for each SPI:
1) -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] is used at the beginning of
any WebAuthn ceremonies. A WKFrameInfo is provided for more info of the initiating frame so clients could decide either show
the RP ID or the origin of the frame which may or may not be the RP ID. A callback of _WKWebAuthenticationPanelResult is
provided such that clients could inform WebKit to continue the ceremony or not. Case like rate limiting of a modular dialog
could result in _WKWebAuthenticationPanelResultDidNotPresent. Then WebKit will abort the operation.
_WKWebAuthenticationPanelResultUnavailable tells WebKit the client has no UI implemented and therefore WebKit will operate
in a non UI mode which basically will only enable HID authenticators, and is the current behavior of macOS Safari.
2) -[_WKWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:] is primarily to instruct users to do some
actionable thing to recover from some error state. However, it could be used for pure info as well. For
_WKWebAuthenticationPanelInfoMultipleNFCTagPresents, users can be instructed to only hold one NFC tag to the scanner. For
_WKWebAuthenticationPanelInfoNoCredentialsFound, users can potentially switch to another security key that could hit a match.
3) -[_WKWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:] is to dismiss UI.
_WKWebAuthenticationResult is provided such that client could show different animations as a hint to the user. The reasons for
failure could either be timeout or InvalidStateError which will be reported to the page as well. InvalidStateError signals a
credential matching an entry of the exclude list (excludeCredentials) is found on the authenticator.
4) -[_WKWebAuthenticationPanel cancel] is the way clients tell WebKit a user cancel.

  • SourcesCocoa.txt:
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h: Added.
  • UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm: Added.

(-[_WKWebAuthenticationPanel _initWithRelayingPartyID:]):
(-[_WKWebAuthenticationPanel relyingPartyID]):
(-[_WKWebAuthenticationPanel cancel]):

  • UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h: Added.
  • WebKit.xcodeproj/project.pbxproj:
9:46 AM Changeset in webkit [250657] by Kocsen Chung
  • 5 edits in branches/safari-608.3-branch/Source

Cherry-pick r250642. rdar://problem/55947639

[iOS] When hit testing for a context menu interaction, do not consider whether the element is contenteditable
​https://bugs.webkit.org/show_bug.cgi?id=202498
<rdar://problem/54723131>

Reviewed by Tim Horton.

Source/WebCore:

When the user selects a context menu action, WebKit performs a hit test in order to find the
acted-on element on the page. This is separate from the hit test performed to generate the
context menu's targeted preview. Since an arbitrary amount of time can elapse between
preview generation and action selection, this second hit-tests might return a different
element.

One case where we know a different element can be returned is in apps that dynamically
enable and disable editing. If editing is disabled when the first hit test occurs but is
enabled when the second one occurs, different elements will be returned due to
Frame::qualifyingNodeAtViewportLocation preferring to return the root editable element when
the approximate node is contenteditable.

While the appropriate long-term fix is to only hit-test once and use that element for both
preview generation and action selection, this patch implements a short-term fix to address
the specific problem in rdar://problem/54723131 by disabling the contenteditable behavior
described above for context menu interaction hit testing.

The long-term fix is tracked by <​https://webkit.org/b/202499>.

  • page/Frame.h:
  • page/ios/FrameIOS.mm: (WebCore::Frame::qualifyingNodeAtViewportLocation): (WebCore::Frame::approximateNodeAtViewportLocationLegacy): (WebCore::ancestorRespondingToClickEventsNodeQualifier): (WebCore::Frame::nodeRespondingToClickEvents): (WebCore::Frame::nodeRespondingToDoubleClickEvent): (WebCore::Frame::nodeRespondingToInteraction): (WebCore::Frame::nodeRespondingToScrollWheelEvents):

Source/WebKit:

  • WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::startInteractionWithElementAtPosition): Changed to call WebCore::Frame::nodeRespondingToInteraction.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:11 AM Changeset in webkit [250656] by jh718.park@samsung.com
  • 5 edits
    2 moves
    4 deletes in trunk/LayoutTests/imported/w3c

Unreviewed. Move below's shape-outside-foo wpt tests to its proper place.
​https://bugs.webkit.org/show_bug.cgi?id=202529

  • web-platform-tests/css/css-masking/parsing/shape-outside-invalid-expected.txt: Removed.
  • web-platform-tests/css/css-masking/parsing/shape-outside-invalid.html: Removed.
  • web-platform-tests/css/css-masking/parsing/shape-outside-valid-expected.txt: Removed.
  • web-platform-tests/css/css-masking/parsing/shape-outside-valid.html: Removed.
  • web-platform-tests/css/css-shapes/parsing/shape-outside-computed-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/shape-outside-computed-expected.txt.
  • web-platform-tests/css/css-shapes/parsing/shape-outside-computed.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/shape-outside-computed.html.
  • web-platform-tests/css/css-shapes/parsing/shape-outside-invalid-expected.txt:
  • web-platform-tests/css/css-shapes/parsing/shape-outside-invalid.html:
  • web-platform-tests/css/css-shapes/parsing/shape-outside-valid-expected.txt:
  • web-platform-tests/css/css-shapes/parsing/shape-outside-valid.html:
8:46 AM Changeset in webkit [250655] by commit-queue@webkit.org
  • 14 edits in trunk

Web Inspector: tests under LayoutTests/inspector/debugger are flaky
​https://bugs.webkit.org/show_bug.cgi?id=137131
<rdar://problem/18461335>

Patch by Yury Semikhatsky <​yurys@chromium.org> on 2019-10-03
Reviewed by Devin Rousso.

Source/JavaScriptCore:

Changed breakpoint resolution logic to make it consistent across platforms and
better handle the case when there are several DebuggerPausePositions at the same
offset (but with different types).

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::hasOpDebugForLineAndColumn):

  • bytecode/CodeBlock.h:
  • debugger/Breakpoint.h: Removed Breakpoint::unspecifiedColumn, Optional<unsigned>

is used instead where needed. It allows to avoid code that relies on (int)UINT_MAX => -1
conversion.

  • debugger/Debugger.cpp:

(JSC::Debugger::resolveBreakpoint): clarified that in the map columns are 0-based.

  • debugger/DebuggerParseData.cpp:

(JSC::DebuggerPausePositions::breakpointLocationForLineColumn): replaced custom
binary search with std::lower_bound. If there are several pause positions at the
same offset they will be sorted by the type and the algorithm is guaranteed to see
leftmost one first.

(JSC::DebuggerPausePositions::sort): use type as secondary ordering component.

  • debugger/DebuggerParseData.h: Rearranged type constants so that Enter < Pause < Leave

this change along with sorting by type should guarantee that in case of several pause
positions at the same line Enter goes before Pause before Leave and the breakpoint
resolution will yield result similar to that when each pause locations has different
position.

  • inspector/protocol/Debugger.json: clarified that positions are 0-based.
  • parser/ParserTokens.h:

(JSC::JSTextPosition::column const): added helper method for computing column.

Source/WebCore:

Fix debugger tests on GTK. All tests that pause on breakpoint didn't work because
in layout tests InspectorFrontendClientLocal was using Timer to dispatch commands
sent from the local front-end page to the inspected one. When paused inside a script
triggered by the front-end nested timer event would be scheduled but never fired
because in glib implementation of RunLoop::TimerBase uses event source which doesn't
allow recursion (g_source_set_can_recurse is not called on the source), so dispatching
Debugger.resume command didn't work when paused inside another inspector command (e.g.
eval). RunLoop itself uses event source which does allow recursion. So instead of using
a timer for asynchronous command dispatching with delay=0 we now schedule a task in
RunLoop's queue.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorBackendDispatchTask::dispatch):
(WebCore::InspectorBackendDispatchTask::reset):
(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorBackendDispatchTask::scheduleOneShot): ensures that there is one inspector
dispatch task in the queue.
(WebCore::InspectorBackendDispatchTask::dispatchOneMessage): this is mostly the same behavior
as was with timerFired, we should be able to dispatch all accumulated messages from the queue
in one batch but for now I'd like to keep it one per iteration.

LayoutTests:

Enable inspector/debugger tests on GTK.

  • inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt: Rebaselined the test

after changes in the breakpoint resolution code. Now the output on GTK is the same as on Mac.

  • platform/gtk/TestExpectations:
8:07 AM Changeset in webkit [250654] by keith_miller@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix assembler on ARM64E
​https://bugs.webkit.org/show_bug.cgi?id=202528

Reviewed by Michael Saboff.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::callOperation):

  • assembler/MacroAssemblerARM64E.h:

(JSC::MacroAssemblerARM64E::callOperation):

7:03 AM Changeset in webkit [250653] by commit-queue@webkit.org
  • 17 edits
    1 copy
    13 adds
    12 deletes in trunk

CSS ellipse() doesn't accept single <shape-radius>
​https://bugs.webkit.org/show_bug.cgi?id=181745

CSS ellipse() should only accept 0 or 2 radii.
The corresponding csswg discussion is
​https://github.com/w3c/csswg-drafts/issues/2175.
LayoutTests/imported/w3c:

Patch by Joonghun Park <​pjh0718@gmail.com> on 2019-10-03
Reviewed by Antti Koivisto.

  • web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-computed.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/shape-outside-computed-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/shape-outside-computed.html: Added.
  • web-platform-tests/css/css-masking/parsing/shape-outside-invalid-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/parsing/shape-outside-invalid-expected.txt.
  • web-platform-tests/css/css-masking/parsing/shape-outside-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/shape-outside-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/shape-outside-valid.html: Added.
  • web-platform-tests/css/css-shapes/parsing/shape-outside-invalid-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-ellipse-001-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-ellipse-005-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-ellipse-010-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-ellipse-010.html:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-ellipse-011-expected.txt:
  • web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-ellipse-011.html:
  • web-platform-tests/css/css-shapes/shape-outside/values/support/parsing-utils.js:

Source/WebCore:

Patch by Joonghun Park <​pjh0718@gmail.com> on 2019-10-03
Reviewed by Antti Koivisto.

Tests: imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed.html

imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-invalid.html
imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-valid.html
imported/w3c/web-platform-tests/css/css-masking/parsing/shape-outside-computed.html
imported/w3c/web-platform-tests/css/css-masking/parsing/shape-outside-invalid.html
imported/w3c/web-platform-tests/css/css-masking/parsing/shape-outside-valid.html

  • css/CSSBasicShapes.cpp:

(WebCore::CSSBasicShapeEllipse::cssText const):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeBasicShapeEllipse):

LayoutTests:

Remove the layout tests duplicated with the wpt ported version ones.

Patch by Joonghun Park <​pjh0718@gmail.com> on 2019-10-03
Reviewed by Antti Koivisto.

  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017-expected.html: Removed.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-001-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-001.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-005-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-005.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-010-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-010.html: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-011-expected.txt: Removed.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-011.html: Removed.
  • fast/shapes/parsing/parsing-shape-outside-expected.txt:
  • fast/shapes/parsing/parsing-test-utils.js:
  • platform/gtk/TestExpectations:
  • platform/ios/TestExpectations:
7:00 AM Changeset in webkit [250652] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

REGRESSION(r249428): [GStreamer] VP9 video rendered green
​https://bugs.webkit.org/show_bug.cgi?id=201422

Adding patches in -base to fix the issue.

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2019-10-03
Reviewed by Philippe Normand.

  • gstreamer/jhbuild.modules:
  • gstreamer/patches/base-0001-glupload-Add-VideoMetas-and-GLSyncMeta-to-the-raw-up.patch: Added.
2:52 AM Changeset in webkit [250651] by zandobersek@gmail.com
  • 7 edits in trunk/Source/WebKit

[GTK][WPE] Enable async scrolling
​https://bugs.webkit.org/show_bug.cgi?id=202449

Reviewed by Carlos Garcia Campos.

For WPE, explicitly enable the threaded scrolling preference on the
WebPreferences object. For GTK, the same preference is enabled in
parallel with the forced-compositing preference, as the async scrolling
feature depends on always-on AC mode.

To help with quick evaluation of potential issues around async scrolling
the feature can still be disabled via the WEBKIT_DISABLE_ASYNC_SCROLLING
environment variable, though this only works in DEVELOPER_MODE builds.

  • Shared/WebPreferencesDefaultValues.h: Default-enable async frame and

overflow scrolling on Nicosia-using ports.

  • UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_set_hardware_acceleration_policy):

  • UIProcess/API/wpe/WPEView.cpp:

(WKWPE::m_backend):

  • UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore):

  • WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::DrawingAreaCoordinatedGraphics):
(WebKit::DrawingAreaCoordinatedGraphics::updatePreferences):
(WebKit::DrawingAreaCoordinatedGraphics::supportsAsyncScrolling):

  • WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:
2:47 AM Changeset in webkit [250650] by zandobersek@gmail.com
  • 5 edits in trunk/Source

[Nicosia] Enable runtime checks and triggers for async non-main-frame scrolling
​https://bugs.webkit.org/show_bug.cgi?id=202509

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Add build guards that would enable runtime checks of the asynchronous
frame scrolling setting in the ScrollingCoordinator and
RenderLayerCompositor classes for the Nicosia-using ports.

The check in ScrollingCoordinator avoids bailing on coordinating
scrolling for non-main frames when the setting is enabled. The check in
RenderLayerCompositor avoids imposing a requirement for a composition
layer for any non-main frame when the setting is disabled.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView const):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame const):

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Allow the non-main-frame compositing trigger for the Nicosia-using ports
as well. This will enable non-main-frame compositing if the related
setting is also enabled.

2:20 AM Changeset in webkit [250649] by magomez@igalia.com
  • 9 edits
    1 copy
    205 adds in trunk/LayoutTests

[WPE] Unreviewed WPE gardening after r250642
​https://bugs.webkit.org/show_bug.cgi?id=202515

Unreviewed WPE gardening after r250642. Adding some missing results and updating
some expectations.

  • platform/wpe/TestExpectations:
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-grad-24-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-grad-stops-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-pattern-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-pattern-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-pattern-03-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-pattern-04-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-pattern-05-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-pattern-06-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-pattern-07-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-pattern-08-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/pservers-pattern-09-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/render-elems-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/render-elems-02-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/render-elems-03-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/render-elems-06-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/render-elems-07-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/render-elems-08-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/render-groups-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/render-groups-03-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/script-handle-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/script-handle-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/script-handle-03-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/script-handle-04-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/script-specify-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/script-specify-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-circle-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-circle-02-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-ellipse-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-ellipse-02-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-ellipse-03-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-grammar-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-intro-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-intro-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-line-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-line-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-polygon-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-polygon-02-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-polygon-03-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-polyline-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-polyline-02-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-rect-02-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-rect-03-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-rect-04-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-rect-05-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-rect-06-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/shapes-rect-07-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-cond-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-cond-02-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-cond-03-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-cond-overview-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-cond-overview-03-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-cond-overview-04-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-cond-overview-05-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-defs-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-03-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-04-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-05-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-06-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-07-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-08-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-11-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-12-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-13-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-14-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-15-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-16-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-17-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-18-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-19-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-dom-20-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-frag-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-frag-02-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-frag-03-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-frag-04-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-frag-05-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-frag-06-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-group-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-group-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-group-03-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-03-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-04-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-05-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-06-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-07-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-08-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-09-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-10-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-11-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-12-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-13-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-14-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-15-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-16-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-17-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-18-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-image-19-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-svg-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-svg-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-svg-03-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-symbol-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-03-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-04-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-05-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-06-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-07-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-08-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-09-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-10-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-11-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-12-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-13-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-14-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/struct-use-15-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-class-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-css-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-css-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-css-03-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-css-04-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-css-05-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-css-06-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-css-07-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-css-08-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-css-09-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-css-10-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-elem-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-inherit-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-pres-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-pres-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-pres-03-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-pres-04-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/styling-pres-05-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/svgdom-over-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-align-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-align-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-align-03-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-align-04-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-align-05-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-align-06-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-align-07-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-align-08-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-altglyph-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-altglyph-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-altglyph-03-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-bidi-01-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-deco-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-dom-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-dom-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-dom-03-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-dom-04-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-dom-05-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-fonts-02-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-fonts-03-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-fonts-04-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-fonts-05-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-fonts-202-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-fonts-203-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-fonts-204-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-03-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-04-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-05-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-06-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-07-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-09-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-10-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-11-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-intro-12-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-path-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-path-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-spacing-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-text-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-text-04-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-text-05-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-text-06-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-text-07-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-text-08-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-text-09-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-text-10-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-text-11-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-text-12-t-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-tref-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-tref-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-tref-03-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-tselect-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-tselect-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-tselect-03-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-tspan-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/text-tspan-02-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-basic-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-basic-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-02-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-03-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-05-b-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-06-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-07-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-08-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-svgfittoviewbox-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-svglengthlist-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-svgnumberlist-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-svgstringlist-01-f-manual-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-svgtransformable-01-f-manual-expected.txt: Added.
  • platform/wpe/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/wpe/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • platform/wpe/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
  • platform/wpe/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/wpe/svg/custom/viewbox-syntax-expected.txt:
  • platform/wpe/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/wpe/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
1:54 AM Changeset in webkit [250648] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit

[GTK] Don't hardcode swipe navigation gesture style
​https://bugs.webkit.org/show_bug.cgi?id=202447

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2019-10-03
Reviewed by Carlos Garcia Campos.

Use GTK foreign drawing to draw swipe gesture dimming and shadow instead of
hardcoded opacity and gradient values.

Have separate elements for dimming and shadow. Additionally, add border
and outline. Dimming layer opacity always matches progress, shadow opacity
is 1 except when the page is almost completely retracted. Border and outline
opacity is always 1. Outline is drawn above the top page. For determining
shadow, border and outline width, 'min-width' property is used.

Each element also has .right or .left style class depending on text direction.

Creating patterns is relatively expensive, so do it once a gesture
starts and clear them once it ends. Style changes are currently not
handled, since it's unlikely anything would change while the gesture
is done. Dimming layer is created with the same width as webview and is
clipped when drawing.

Translate existing dimming and shadow into css as is, add subtle border and
outline. Since it's controlled via css, downstreams can override the style.

Set WebKitWebView css name to 'webkitwebview', and only apply styles for
elements directly preceded by it, otherwise the selectors are too generic.

  • PlatformGTK.cmake: Add gtk.css to gresource bundle.
  • Resources/gtk/gtk-theme.css: Added.

(webkitwebview > dimming):
(webkitwebview > shadow):
(webkitwebview > shadow.right):
(webkitwebview > shadow.left):
(webkitwebview > border):
(webkitwebview > outline):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_class_init): Set css name to 'webkitwebview'.

  • UIProcess/ViewGestureController.h:
  • UIProcess/gtk/ViewGestureControllerGtk.cpp:

(WebKit::ViewGestureController::createStyleContext):
(WebKit::createElementPattern):
(WebKit::elementWidth):
(WebKit::ViewGestureController::beginSwipeGesture): Create helper patterns.
(WebKit::ViewGestureController::draw): Rework drawing to use the patterns.
(WebKit::ViewGestureController::removeSwipeSnapshot): Clear the patterns.

1:39 AM Changeset in webkit [250647] by Dewei Zhu
  • 4 edits in trunk/Websites/perf.webkit.org

Fix a bug that warning icon causes infinite rendering when it has warning message.
​https://bugs.webkit.org/show_bug.cgi?id=202502

Reviewed by Ryosuke Niwa.

Fix the problem that a warning icon with a warning message will result in infinite rendering.

  • public/v3/components/button-base.js:

(ButtonBase):
(ButtonBase.prototype.setButtonTitle): Fixed a typo in function name and moved the title update to
render function.
(ButtonBase.prototype.render): Added the logic to render title.

  • public/v3/components/test-group-revision-table.js: Set warning message by invoking setButtonTitle.
  • public/v3/components/warning-icon.js: Removed the warning messge related code and leave the responsibility

to ButtonBase.
(WarningIcon):
(WarningIcon.prototype.render):

1:25 AM Changeset in webkit [250646] by Carlos Garcia Campos
  • 6 edits in trunk

[GTK] Make PSON optional
​https://bugs.webkit.org/show_bug.cgi?id=200967

Reviewed by Michael Catanzaro.

Source/WebKit:

It's not possible to enable PSON by default and keep backwards compatibility, applications might need to use new
API to monitor the page ID changes in the Web view. So, this patch adds a construct only property to
WebKitWebContext to enable PSON.

  • UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextGetProperty):
(webkitWebContextSetProperty):
(webkitWebContextConstructed):
(webkit_web_context_class_init):

Tools:

Enable PSON in MiniBrowser and unit tests. Also add more tests to page-id to check that we can still talk to the
right web process after cross-site history navigation.

  • MiniBrowser/gtk/main.c:

(main):

  • TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebExtensionPageID):

  • TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::Test):

1:24 AM Changeset in webkit [250645] by Carlos Garcia Campos
  • 15 edits in trunk

[GTK][WPE] Add WebKitWebView:page-id property
​https://bugs.webkit.org/show_bug.cgi?id=201642

Reviewed by Michael Catanzaro.

Source/WebKit:

The page ID of a WebKitWebView can now change, so we need a way to get notified when it changes.

  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewGetProperty): Add getter for page-id.
(webkit_web_view_class_init): Add page-id property
(webkitWebViewDidChangePageID): Emit notify::page-id.

  • UIProcess/API/glib/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeWebPageID const): Call webkitWebViewDidChangePageID().

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/wpe/APIViewClient.h:

(API::ViewClient::didChangePageID): Added virtual method.

  • UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeWebPageID const): Call WKWPE::View::didChangePageID().

  • UIProcess/API/wpe/PageClientImpl.h:
  • UIProcess/API/wpe/WPEView.cpp:

(WKWPE::View::didChangePageID): Call API::ViewClient::didChangePageID().

  • UIProcess/API/wpe/WPEView.h:
  • UIProcess/PageClient.h:

(WebKit::PageClient::didChangeWebPageID const): Added virtual method.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::swapToWebProcess): Call PageClient::didChangeWebPageID().

Tools:

Add a test case to check the new property.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(checkTitle):
(testWebExtensionGetTitle):
(webViewPageIDChanged):
(testWebExtensionPageID):
(beforeAll):

Oct 2, 2019:

11:59 PM Changeset in webkit [250644] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/mac

Provide TAPI the full target triple instead of just the arch
​https://bugs.webkit.org/show_bug.cgi?id=202486

Reviewed by Simon Fraser.

  • MigrateHeaders.make:

For accuracy and consistency's sake, pass the whole target identifier
instead of just one piece.

10:22 PM Changeset in webkit [250643] by Antti Koivisto
  • 10 edits in trunk

[CSS Shadow Parts] Support multiple arguments for ::part()
​https://bugs.webkit.org/show_bug.cgi?id=202482

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-shadow-parts/multiple-parts-expected.txt:

Source/WebCore:

Support ::part(foo bar).

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):
(WebCore::CSSSelector::setArgumentList):
(WebCore::CSSSelector::setLangArgumentList): Deleted.

Give this a more generic name and use it for ::part() too.

  • css/CSSSelector.h:

(WebCore::CSSSelector::argumentList const):
(WebCore::CSSSelector::langArgumentList const): Deleted.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):

Match only if all parts are found from the element 'part' attribute.

  • css/parser/CSSParserSelector.cpp:

(WebCore::CSSParserSelector::setArgumentList):
(WebCore::CSSParserSelector::setLangArgumentList): Deleted.

  • css/parser/CSSParserSelector.h:
  • css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumePseudo):

Parse the list.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

9:53 PM Changeset in webkit [250642] by aestes@apple.com
  • 5 edits in trunk/Source

[iOS] When hit testing for a context menu interaction, do not consider whether the element is contenteditable
​https://bugs.webkit.org/show_bug.cgi?id=202498
<rdar://problem/54723131>

Reviewed by Tim Horton.

Source/WebCore:

When the user selects a context menu action, WebKit performs a hit test in order to find the
acted-on element on the page. This is separate from the hit test performed to generate the
context menu's targeted preview. Since an arbitrary amount of time can elapse between
preview generation and action selection, this second hit-tests might return a different
element.

One case where we know a different element can be returned is in apps that dynamically
enable and disable editing. If editing is disabled when the first hit test occurs but is
enabled when the second one occurs, different elements will be returned due to
Frame::qualifyingNodeAtViewportLocation preferring to return the root editable element when
the approximate node is contenteditable.

While the appropriate long-term fix is to only hit-test once and use that element for both
preview generation and action selection, this patch implements a short-term fix to address
the specific problem in rdar://problem/54723131 by disabling the contenteditable behavior
described above for context menu interaction hit testing.

The long-term fix is tracked by <​https://webkit.org/b/202499>.

  • page/Frame.h:
  • page/ios/FrameIOS.mm:

(WebCore::Frame::qualifyingNodeAtViewportLocation):
(WebCore::Frame::approximateNodeAtViewportLocationLegacy):
(WebCore::ancestorRespondingToClickEventsNodeQualifier):
(WebCore::Frame::nodeRespondingToClickEvents):
(WebCore::Frame::nodeRespondingToDoubleClickEvent):
(WebCore::Frame::nodeRespondingToInteraction):
(WebCore::Frame::nodeRespondingToScrollWheelEvents):

Source/WebKit:

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::startInteractionWithElementAtPosition): Changed to call
WebCore::Frame::nodeRespondingToInteraction.

7:47 PM Changeset in webkit [250641] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview/Safari Technology Preview 93

Added a tag for Safari Technology Preview release 93.

5:53 PM Changeset in webkit [250640] by mmaxfield@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION (r245672): <select> dropdown with text-rendering: optimizeLegibility freezes Safari
​https://bugs.webkit.org/show_bug.cgi?id=202198

Reviewed by Tim Horton.

Source/WebKit:

NSFont has a bug where passing "auto" to kCTFontOpticalSizeAttribute
causes an exception to be thrown. We don't catch the exception, so we
pop up back to the runloop, which confuses the UI process.

The solution is twofold: 1) Workaround the bug by passing the font size
to kCTFontOpticalSizeAttribute instead, and 2) catch any exceptions that
this part of the code might throw.

  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::showPopupMenu):

Source/WTF:

  • wtf/Platform.h:

LayoutTests:

  • fast/forms/select-font-optical-size-expected.txt: Added.
  • fast/forms/select-font-optical-size.html: Added.
5:19 PM Changeset in webkit [250639] by Jonathan Bedard
  • 2 edits in trunk/Tools

results.webkit.org: Only automatically search when multiple lines are pasted
​https://bugs.webkit.org/show_bug.cgi?id=202496

Rubber-stamped by Aakash Jain.

  • resultsdbpy/resultsdbpy/view/static/js/search.js:

(SearchBar): If only a single line has been pasted, do not automatically dispatch
the search.

4:41 PM Changeset in webkit [250638] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

[CMake] Don't link WebKit.framework with SecItemShim
​​https://bugs.webkit.org/show_bug.cgi?id=202490

  • PlatformMac.cmake:

Otherwise everything that uses the Security framework crashes immediately.
We only need it in the NetworkProcess.

4:30 PM Changeset in webkit [250637] by Alan Coon
  • 7 edits in branches/safari-608.3-branch/Source

Versioning.

4:20 PM Changeset in webkit [250636] by mark.lam@apple.com
  • 4 edits
    1 add in trunk

DoubleToStringConverter::ToExponential() should null terminate its string.
​https://bugs.webkit.org/show_bug.cgi?id=202492
<rdar://problem/55907708>

Reviewed by Filip Pizlo.

JSTests:

  • stress/dtoa-AddSubstring-should-uses-strnlen-in-assertion.js: Added.

Source/WTF:

  • wtf/dtoa/double-conversion.cc:
  • DoubleToStringConverter::DoubleToAscii() always produces a null terminated string. Fixed the padding loop in DoubleToStringConverter::ToExponential() that follows it to also keep the null terminator.
  • wtf/dtoa/utils.h:

(WTF::double_conversion::StringBuilder::AddSubstring):

  • An assertion in here was using strlen() which indicates that it expects a null terminator in the incoming string. However, this requirement is too restrictive. The code does not actually depend on the string having a null terminator, only that a null terminator does not manifest before the nth character. Changed the assertion to use strnlen() instead to reflect this.
3:41 PM Changeset in webkit [250635] by Alan Coon
  • 7 edits in branches/safari-608-branch/Source

Versioning.

3:37 PM Changeset in webkit [250634] by Alan Coon
  • 1 copy in branches/safari-608.3-branch

New branch.

2:54 PM Changeset in webkit [250633] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: for rules that don't match selected node, property values always show as invalid
​https://bugs.webkit.org/show_bug.cgi?id=201571

Reviewed by Matt Baker.

The gist of the bug:

  • WI.CSSProperty is instantiated with valid false.
  • CSSAgent.getMatchedStylesForNode never updates WI.CSSProperty instances because the edited style does not in fact match the selected DOM node. A valid CSS property is shown as invalid.

To resolve this, WI.CSSProperty instances are now updated after editing
in the callback of CSSAgent.setStyleText.

  • UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles.prototype.changeStyleText):
(WI.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
Don't store style in this._stylesMap of WI.DOMNodeStyles when the style doesn't match the selected node.

2:50 PM Changeset in webkit [250632] by Alan Coon
  • 1 copy in tags/Safari-608.3.8

Tag Safari-608.3.8.

2:45 PM Changeset in webkit [250631] by Jonathan Bedard
  • 2 edits in trunk/Tools

Python 3: Add test-webkitpy for Python 3 (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=201954

Unreviewed follow-up fix.

  • Scripts/test-webkitpy-python3: Add copyright.
2:23 PM Changeset in webkit [250630] by ysuzuki@apple.com
  • 49 edits
    2 copies
    4 adds in trunk

[JSC] AsyncGenerator should have internal fields
​https://bugs.webkit.org/show_bug.cgi?id=201498

Reviewed by Saam Barati.

JSTests:

  • stress/async-generator-construct-failure.js: Added.

(shouldThrow):
(async.gen):
(TypeError):

  • stress/async-generator-prototype-change.js: Added.

(shouldBe):
(async.gen):

  • stress/async-generator-prototype-closure.js: Added.

(shouldBe):
(test.async.gen):
(test):

  • stress/create-async-generator.js: Added.

(shouldBe):
(test.async.generator):
(test):

Source/JavaScriptCore:

This patch introduces JSAsyncGenerator. We did this already for JSGenerator. This patch does the same thing for JSAsyncGenerator
This patch cleans up JSGenerator's code to share it with JSAsyncGenerator, e.g. JSGenerator::initialValues etc.
It improves JetStream2/async-fs by ~10%.

We also fixed the pre-existing bug. We are using OpcodeID for the key of hashmap. And using op_add code as a part of key.
By adding a new bytecode, it suddenly becomes 0. And 0 is not valid key in WTF::HashMap. This patch adds 1 to opcodeID when using
for HashMap's key to fix this issue.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • builtins/AsyncGeneratorPrototype.js:

(globalPrivate.asyncGeneratorQueueIsEmpty):
(globalPrivate.asyncGeneratorQueueEnqueue):
(globalPrivate.asyncGeneratorQueueDequeue):
(globalPrivate.isExecutionState):
(globalPrivate.isSuspendYieldState):
(globalPrivate.asyncGeneratorReject):
(globalPrivate.asyncGeneratorResolve):
(asyncGeneratorYieldAwaited):
(globalPrivate.asyncGeneratorYield):
(globalPrivate.doAsyncGeneratorBodyCall):
(globalPrivate.asyncGeneratorResumeNext):
(globalPrivate.asyncGeneratorEnqueue):

  • builtins/BuiltinNames.h:
  • bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/BytecodeList.rb:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeLLIntInlineCaches):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitPutAsyncGeneratorFields):
(JSC::BytecodeGenerator::emitCreateAsyncGenerator):
(JSC::BytecodeGenerator::emitYieldPoint):
(JSC::BytecodeGenerator::emitYield):
(JSC::BytecodeGenerator::emitAwait):
(JSC::BytecodeGenerator::emitDelegateYield):
(JSC::BytecodeGenerator::emitGeneratorStateChange):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitIsAsyncGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::asyncGeneratorInternalFieldIndex):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_getAsyncGeneratorInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putAsyncGeneratorInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isAsyncGenerator):
(JSC::YieldExprNode::emitBytecode):
(JSC::AwaitExprNode::emitBytecode):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::handleCreateInternalFieldObject):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToNewInternalFieldObject):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::convertToNewGenerator): Deleted.

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCreateInternalFieldObject):
(JSC::DFG::SpeculativeJIT::compileCreateGenerator):
(JSC::DFG::SpeculativeJIT::compileCreateAsyncGenerator):
(JSC::DFG::SpeculativeJIT::compileNewInternalFieldObject):
(JSC::DFG::SpeculativeJIT::compileNewGenerator):
(JSC::DFG::SpeculativeJIT::compileNewAsyncGenerator):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStoreBarrierInsertionPhase.cpp:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileNewInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileNewGenerator):
(JSC::FTL::DFG::LowerDFGToB3::compileNewAsyncGenerator):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateGenerator):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateAsyncGenerator):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JITInlines.h:

(JSC::JIT::copiedArithProfile):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::createInternalFieldObject):
(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:
  • runtime/JSAsyncGenerator.cpp: Copied from Source/JavaScriptCore/runtime/JSGenerator.cpp.

(JSC::JSAsyncGenerator::create):
(JSC::JSAsyncGenerator::createStructure):
(JSC::JSAsyncGenerator::JSAsyncGenerator):
(JSC::JSAsyncGenerator::finishCreation):
(JSC::JSAsyncGenerator::visitChildren):

  • runtime/JSAsyncGenerator.h: Copied from Source/JavaScriptCore/runtime/JSGenerator.h.
  • runtime/JSAsyncGeneratorFunction.h:
  • runtime/JSGenerator.cpp:

(JSC::JSGenerator::finishCreation):

  • runtime/JSGenerator.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::asyncGeneratorStructure const):

  • runtime/JSType.cpp:

(WTF::printInternal):

  • runtime/JSType.h:
2:19 PM Changeset in webkit [250629] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes
​https://bugs.webkit.org/show_bug.cgi?id=202493

Reviewed by Saam Barati.

I added this optimization for DFG but forgot to do it for the FTL
at the same time. This patch rectifies that.

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

2:15 PM Changeset in webkit [250628] by Antti Koivisto
  • 23 edits in trunk

[CSS Shadow Parts] Basic ::part() pseudo element support
​https://bugs.webkit.org/show_bug.cgi?id=202456

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-shadow-parts/all-hosts-expected.txt:
  • web-platform-tests/css/css-shadow-parts/complex-matching-expected.txt:
  • web-platform-tests/css/css-shadow-parts/inner-host-expected.txt:
  • web-platform-tests/css/css-shadow-parts/invalidation-change-part-name-expected.txt:
  • web-platform-tests/css/css-shadow-parts/invalidation-change-part-name-idl-domtokenlist-expected.txt:
  • web-platform-tests/css/css-shadow-parts/invalidation-change-part-name-idl-setter-expected.txt:
  • web-platform-tests/css/css-shadow-parts/invalidation-complex-selector-expected.txt:
  • web-platform-tests/css/css-shadow-parts/precedence-part-vs-part-expected.txt:
  • web-platform-tests/css/css-shadow-parts/simple-expected.txt:

Source/WebCore:

Implement basic parsing and selector matching for ::part() pseudo element.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::parsePseudoElementType):
(WebCore::CSSSelector::selectorText const):

  • css/CSSSelector.h:
  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchPartPseudoElementRules):

  • css/ElementRuleCollector.h:
  • css/RuleSet.cpp:

(WebCore::RuleSet::addRule):

  • css/RuleSet.h:

(WebCore::RuleSet::partPseudoElementRules const):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):

  • css/SelectorPseudoElementTypeMap.in:
  • css/parser/CSSParserSelector.cpp:

(WebCore::CSSParserSelector::parsePseudoElementSelector):

Also added ::slotted to SelectorPseudoElementTypeMap.in to resolve a FIXME here.

  • css/parser/CSSParserSelector.h:

(WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):

  • css/parser/CSSSelectorParser.cpp:

(WebCore::isOnlyPseudoElementFunction):
(WebCore::CSSSelectorParser::consumePseudo):

Parse single values only, multipart ::part(foo bar) case is not yet handled.

  • dom/Element.cpp:

(WebCore::Element::partNames const):

1:50 PM November 2019 Meeting edited by Jon Davis
Added WebKit Goals for 2020 to 11 AM timeslot (diff)
1:49 PM Changeset in webkit [250627] by Alan Coon
  • 5 edits
    1 delete in branches/safari-608-branch

Revert "Cherry-pick r249538. rdar://problem/55911485"

This reverts commit r250612.

1:48 PM Changeset in webkit [250626] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Adopt copyToVector() in AnimationTimeline::animationsForElement()
​https://bugs.webkit.org/show_bug.cgi?id=202488

Patch by Antoine Quint <Antoine Quint> on 2019-10-02
Reviewed by Wenson Hsieh.

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationsForElement const):

1:35 PM Changeset in webkit [250625] by achristensen@apple.com
  • 5 edits in trunk

CMake-built WebKit.framework should launch XPC services successfully
​https://bugs.webkit.org/show_bug.cgi?id=202490

Rubber-stamped by Tim Horton.

.:

  • Source/cmake/OptionsMac.cmake:

Source/WebKit:

  • CMakeLists.txt:
  • PlatformMac.cmake:
1:11 PM Changeset in webkit [250624] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Source/WebCore:
[GStreamer] Let playbin handle redirects for us when appropriate
​https://bugs.webkit.org/show_bug.cgi?id=195326

A simplified mechanism has been added in GStreamer to handle corner cases.

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2019-10-02
Reviewed by Xabier Rodriguez-Calvar.

Not easily testable at our level

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):

Tools:
[GSTreamer] Let playbin handle redirects for us when appropriate
​https://bugs.webkit.org/show_bug.cgi?id=195326

Added required patche in GStreamer

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2019-10-02
Reviewed by Xabier Rodriguez-Calvar.

  • gstreamer/patches/base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Added.
  • gstreamer/patches/good-0001-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Added.
1:07 PM Changeset in webkit [250623] by aakash_jain@apple.com
  • 3 edits
    2 adds in trunk/Tools

[ews] Add API endpoint to retry failed builds for a patch
​https://bugs.webkit.org/show_bug.cgi?id=202424

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-app/ews/urls.py: Added url mapping for /retry.
  • BuildSlaveSupport/ews-app/ews/views/retrypatch.py: Added.

(RetryPatch.get): Display the web-form to retry the patch. Retry button which will be added soon will
use this form.
(RetryPatch.post): Handle the post request and retry the patch.

  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble.find_failed_builds_for_patch): Method to find failed builds for a patch.

  • BuildSlaveSupport/ews-app/ews/templates/retry.html: Added, similar to submittoews.html. This

allows to retry a patch through a web-form as well.

12:36 PM Changeset in webkit [250622] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

Another build fix

  • css/typedom/TypedOMCSSImageValue.cpp:

(WebCore::TypedOMCSSImageValue::TypedOMCSSImageValue):

  • css/typedom/TypedOMCSSImageValue.h:

I feel like I am actively being thwarted.

12:21 PM Changeset in webkit [250621] by commit-queue@webkit.org
  • 27 edits
    6 adds in trunk

Updated resource load statistics are never merged into the SQLite Database backend (202372).
​https://bugs.webkit.org/show_bug.cgi?id=202372
<rdar://problem/55854542>

Patch by Kate Cheney <Kate Cheney> on 2019-10-02
Reviewed by Brent Fulgham.

Source/WebKit:

This patch has a lot of changes to the test infrastructure to be able
to test the mergeStatistics function. Merging functionality mimics
that of the ResourceLoadStatisticsMemoryStore and the merge() function in
ResourceLoadStatistics.cpp.

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore):
Added new SQLite queries that are needed to merge new statistics.

(WebKit::ResourceLoadStatisticsDatabaseStore::prepareStatements):
Added new prepare statements for new SQLite queries.

(WebKit::ResourceLoadStatisticsDatabaseStore::insertObservedDomain):
Updated to use domainID() instead of confirmDomainDoesNotExist which
was deleted. Changed the insert bind parameters
to utilize new enum of Observed Domain table indices which will help
reduce errors in the future if the database schema changes.

(WebKit::ResourceLoadStatisticsDatabaseStore::relationshipExists const):
Changed {public} to {private} in logging statement to avoid leaking
sensitive information when logging the query error.

(WebKit::ResourceLoadStatisticsDatabaseStore::confirmDomainDoesNotExist const): Deleted.
This function essentially does the exact same thing as domainID and
we can reduce code duplication by deleting it and transitioning all
other functions to use domainID instead.

(WebKit::ResourceLoadStatisticsDatabaseStore::domainID const):
Changed {public} to {private} in logging statement to avoid leaking
sensitive information when logging the query error.

(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationships):
In order to reuse this code for the merge statistics function, I added
a check before each insert call to ensure the relationship does not
already exist in the database. This was not needed before because it
was only called on an empty database.

(WebKit::ResourceLoadStatisticsDatabaseStore::merge):
(WebKit::ResourceLoadStatisticsDatabaseStore::mergeStatistic):
(WebKit::ResourceLoadStatisticsDatabaseStore::mergeStatistics):
Merges new statistic.

(WebKit::ResourceLoadStatisticsDatabaseStore::incrementRecordsDeletedCountForDomains):
(WebKit::ResourceLoadStatisticsDatabaseStore::recursivelyFindNonPrevalentDomainsThatRedirectedToThisDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::markAsPrevalentIfHasRedirectedToPrevalent):
(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccessUnderOpener):
(WebKit::ResourceLoadStatisticsDatabaseStore::grandfatherDataForDomains):
(WebKit::ResourceLoadStatisticsDatabaseStore::ensurePrevalentResourcesForDebugMode):
(WebKit::ResourceLoadStatisticsDatabaseStore::setUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasHadUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::setPrevalentResource):
(WebKit::ResourceLoadStatisticsDatabaseStore::setDomainsAsPrevalent):
(WebKit::ResourceLoadStatisticsDatabaseStore::predicateValueForDomain const):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearPrevalentResource):
Changed {public} to {private} in logging statement to avoid leaking
sensitive information when logging the query error.

(WebKit::ResourceLoadStatisticsDatabaseStore::setGrandfathered):
Fix a bug uncovered by the new test cases.

(WebKit::ResourceLoadStatisticsDatabaseStore::ensureResourceStatisticsForRegistrableDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearDatabaseContents):
(WebKit::ResourceLoadStatisticsDatabaseStore::cookieTreatmentForOrigin const):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearExpiredUserInteractions):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearGrandfathering):
(WebKit::ResourceLoadStatisticsDatabaseStore::pruneStatisticsIfNeeded):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateLastSeen):
Changed {public} to {private} in logging statement to avoid leaking
sensitive information when logging the query error.

(WebKit::ResourceLoadStatisticsDatabaseStore::updateDataRecordsRemoved):
A new function that utilizes a query needed for the merging of two
statistics.

(WebKit::ResourceLoadStatisticsDatabaseStore::confirmDomainDoesNotExist const): Deleted.

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::mergeStatistics):
(WebKit::ResourceLoadStatisticsMemoryStore::wasAccessedAsFirstPartyDueToUserInteraction const): Deleted.
Removed the check for updating times accessed due to first party
interaction, which is data no longer needed in updated ITP.

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
  • NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:

Added the mergeStatistics function (previously only in the memory
store) to the parent class now that it is used by both stores.

  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
This function now calls mergeStatistics on the database store if
enabled.

(WebKit::WebResourceLoadStatisticsStore::mergeStatisticForTesting):
This function builds a vector from the sample data to test the
mergeStatistics() function of the database store.

  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::mergeStatisticForTesting):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetStatisticsMergeStatistic):
Fixed bug where isGrandfathered function in WKWebsiteDataStoreRef
was calling hasHadUserInteraction by mistake.

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::mergeStatisticForTesting):

  • UIProcess/Network/NetworkProcessProxy.h:

This code is for testing the mergeStatistics() function.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::isGrandfathered):
(WebKit::WebsiteDataStore::mergeStatisticForTesting):

  • UIProcess/WebsiteData/WebsiteDataStore.h:

Added this function which contacts the networkProcess to retrieve the
grandfathered value for a domain. This was not included before because
of a bug in WKWebsiteDataStoreRef.

Tools:

Added testing functionality to the mergeStatistics() function of the
SQLite backend.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setStatisticsMergeStatistic):
(WTR::TestRunner::statisticsCallDidSetMergeStatisticCallback):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::setStatisticsMergeStatistic):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::didMergeStatistic):

  • WebKitTestRunner/TestInvocation.h:

LayoutTests:

Added layout tests to test succesful merging of resource load
statistics into SQLite backend.

  • http/tests/resourceLoadStatistics/merge-statistic-does-not-overwrite-database-expected.txt: Added.
  • http/tests/resourceLoadStatistics/merge-statistic-does-not-overwrite-database.html: Added.
  • http/tests/resourceLoadStatistics/merge-statistic-does-overwrite-database-expected.txt: Added.
  • http/tests/resourceLoadStatistics/merge-statistic-does-overwrite-database.html: Added.
  • http/tests/resourceLoadStatistics/merge-statistic-does-partially-overwrite-database-expected.txt: Added.
  • http/tests/resourceLoadStatistics/merge-statistic-does-partially-overwrite-database.html: Added.
12:10 PM Changeset in webkit [250620] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Another build fix

  • css/typedom/TypedOMCSSImageValue.h:
11:53 AM Changeset in webkit [250619] by dino@apple.com
  • 2 edits in trunk/Source/WebKit

Provide originating website URL to AR QuickLook
​https://bugs.webkit.org/show_bug.cgi?id=202451

Reviewed by Antoine Quint.

Declare the setAdditionalParameters method and
call it with the originating page URL if available.

  • UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
11:49 AM Changeset in webkit [250618] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r250149): changing CSS via the Styles details sidebar panel doesn't update the associated resource
​https://bugs.webkit.org/show_bug.cgi?id=202446

Reviewed by Joseph Pecoraro.

When updating the text of a WI.CSSProperty (or the selector of a WI.CSSRule) is updated,
Web Inspector will update the backend style sheet, which will notify the WI.CSSManager of
the change, without ever going through the associated WI.SourceCode. WI.CSSManager then
updates the content of the WI.SourceCode to reflect these changes, but at that point the
WI.SourceCode hadn't yet "moved" it's currentRevision forward of it's originalRevision
which means it would get overridden the first time the WI.SourceCode updates itself.

Modify WI.SourceCode such that every path to get the currentRevision ensures that it is
"moved" forward before the WI.SourceCodeRevision value is returned.

  • UserInterface/Models/SourceCode.js:

(WI.SourceCode.prototype.get currentRevision):
(WI.SourceCode.prototype.get content):
(WI.SourceCode.prototype.revisionContentDidChange):
(WI.SourceCode.prototype._initializeCurrentRevisionIfNeeded): Added.
(WI.SourceCode.prototype._processContent):

11:30 AM Changeset in webkit [250617] by graouts@webkit.org
  • 17 edits in trunk

LayoutTests/imported/w3c:
[Web Animations] Implement replaced animations
​https://bugs.webkit.org/show_bug.cgi?id=202190
<rdar://55697719>

Reviewed by Dean Jackson.

Mark WPT progressions.

  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-replaced-animations-expected.txt:
  • web-platform-tests/web-animations/interfaces/Animatable/getAnimations-expected.txt:
  • web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt:
  • web-platform-tests/web-animations/interfaces/Animation/persist-expected.txt:
  • web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement-expected.txt:

Source/WebCore:
Try to fix the Windows build

Patch by Tim Horton <​timothy_horton@apple.com> on 2019-10-02

  • css/typedom/TypedOMCSSImageValue.cpp:

(WebCore::TypedOMCSSImageValue::document const):

  • css/typedom/TypedOMCSSImageValue.h:

Out-of-line this instead of including Document.h in TypedOMCSSImageValue,
which was an earlier build fix from r250610.

  • platform/graphics/cg/GradientCG.cpp:
  • platform/graphics/win/GlyphPageTreeNodeCGWin.cpp:
  • platform/graphics/win/GraphicsContextCGWin.cpp:

Try to fix the build.

11:29 AM Changeset in webkit [250616] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

[ews] windows or wincairo queue should use del instead of rm command
​https://bugs.webkit.org/show_bug.cgi?id=202477

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/steps.py:

(CleanUpGitIndexLock.start): Use 'del' command instead of rm for windows and wincairo.

  • BuildSlaveSupport/ews-build/steps_unittest.py:

(TestCleanUpGitIndexLock.test_success_wincairo): Added unit-test.

11:19 AM Changeset in webkit [250615] by timothy_horton@apple.com
  • 6 edits in trunk/Source/WebCore

Try to fix the Windows build

  • css/typedom/TypedOMCSSImageValue.cpp:

(WebCore::TypedOMCSSImageValue::document const):

  • css/typedom/TypedOMCSSImageValue.h:

Out-of-line this instead of including Document.h in TypedOMCSSImageValue,
which was an earlier build fix from r250610.

  • platform/graphics/cg/GradientCG.cpp:
  • platform/graphics/win/GlyphPageTreeNodeCGWin.cpp:
  • platform/graphics/win/GraphicsContextCGWin.cpp:

Try to fix the build.

10:43 AM Changeset in webkit [250614] by Keith Rollin
  • 5 edits in trunk/Source/WebKit

Properly mark canceled resources in NetworkActivityTracker
​https://bugs.webkit.org/show_bug.cgi?id=202440
<rdar://problem/55843651>

Reviewed by Brent Fulgham.

The nw_activity facility tracking resource loads did not originally
have support for reporting resources that were canceled. It now has
that support (since late MacOS 14-aligned SDKs), so add support for it
in NetworkActivityTracker and use it in places where we were
previously reporting the status of canceled resources as "None".

  • NetworkProcess/NetworkActivityTracker.h:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::stopAllNetworkActivityTracking):
(WebKit::NetworkConnectionToWebProcess::stopAllNetworkActivityTrackingForPage):

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::cleanup):

  • NetworkProcess/cocoa/NetworkActivityTrackerCocoa.mm:

(WebKit::NetworkActivityTracker::complete):

10:31 AM Changeset in webkit [250613] by youenn@apple.com
  • 2 edits in trunk/Tools

Add a test to check the case of launching two service worker processes shortly one after the other
​https://bugs.webkit.org/show_bug.cgi?id=202450

Reviewed by Chris Dumez.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
10:23 AM Changeset in webkit [250612] by Alan Coon
  • 5 edits
    1 add in branches/safari-608-branch

Cherry-pick r249538. rdar://problem/55911485

LazyClassStructure::setConstructor should not store the constructor to the global object
​https://bugs.webkit.org/show_bug.cgi?id=201484
<rdar://problem/50400451>

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/web-assembly-constructors-should-not-override-global-object-property.js: Added.

Source/JavaScriptCore:

LazyClassStructure::setConstructor sets the constructor as a property of the global object.
This became a problem when it started being used for WebAssembly constructors, such as Module
and Instance, since they are properties of the WebAssembly object, not the global object. That
resulted in properties of the global object replaced whenever a lazy WebAssembly constructor
was first accessed. e.g.

globalThis.Module = x;
WebAssembly.Module;
globalThis.Module === WebAssembly.Module;

  • runtime/LazyClassStructure.cpp: (JSC::LazyClassStructure::Initializer::setConstructor):
  • runtime/LazyClassStructure.h:
  • runtime/Lookup.h: (JSC::reifyStaticProperty):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@249538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:07 AM Changeset in webkit [250611] by Alan Coon
  • 7 edits in branches/safari-608-branch/Source

Versioning.

9:34 AM Changeset in webkit [250610] by Keith Rollin
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r250595.

macCatalyst appears to have triggered the the problem where the build
can sometimes fail if the unified sources mechanism doesn't group
together the right set of files.

  • css/typedom/TypedOMCSSImageValue.h:
9:26 AM Changeset in webkit [250609] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews] Dedicate a bot for macOS-High-Sierra-Debug-Build-EWS queue
​https://bugs.webkit.org/show_bug.cgi?id=202469

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/config.json: Dedicate ews112 to macOS debug builder queue.
9:21 AM Changeset in webkit [250608] by Jonathan Bedard
  • 1 edit
    1 add in trunk/Tools

Python 3: Add test-webkitpy for Python 3
​https://bugs.webkit.org/show_bug.cgi?id=201954

Reviewed by Aakash Jain.

  • Scripts/test-webkitpy-python3: Added.
8:58 AM Changeset in webkit [250607] by Truitt Savell
  • 17 edits in trunk

Unreviewed, rolling out r250603.

Caused testing to exit early with crashes on Mac

Reverted changeset:

"[Web Animations] Implement replaced animations"
​https://bugs.webkit.org/show_bug.cgi?id=202190
​https://trac.webkit.org/changeset/250603

8:51 AM Changeset in webkit [250606] by magomez@igalia.com
  • 1 edit
    433 adds in trunk/LayoutTests

[WPE] Unreviewed gardening: add new expectations after r250602
​https://bugs.webkit.org/show_bug.cgi?id=202461

Unreviewed WPE gardening. Add missing results after r250276.

  • platform/wpe/imported/w3c/web-platform-tests/svg/: Added.
8:33 AM Changeset in webkit [250605] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Web Inspector: Debugger: support emulateUserGesture parameter in Debugger.evaluateOnCallFrame
​https://bugs.webkit.org/show_bug.cgi?id=200272
<rdar://problem/53797509>

Patch by Yury Semikhatsky <​yurys@chromium.org> on 2019-10-02
Reviewed by Devin Rousso.

User interaction inspector tests were accidentally disabled on both WebKit1 and WebKit2.
Marking them as passing on WebKit2.

  • platform/wk2/TestExpectations:
6:51 AM Changeset in webkit [250604] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Gardening build fix: Hide store64/load64 functions from 32bit
​https://bugs.webkit.org/show_bug.cgi?id=202453

Unreviewed.

Prior patch for bug 202250 breaks 32bit builds because functions
store64 and load64 do not exist. ifdef these functions away from 32bits since
they are not used in 32bit code path.

Patch by Paulo Matos <Paulo Matos> on 2019-10-02

  • jit/AssemblyHelpers.h:
4:47 AM Changeset in webkit [250603] by graouts@webkit.org
  • 17 edits in trunk

[Web Animations] Implement replaced animations
​https://bugs.webkit.org/show_bug.cgi?id=202190
<rdar://55697719>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark WPT progressions.

  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-replaced-animations-expected.txt:
  • web-platform-tests/web-animations/interfaces/Animatable/getAnimations-expected.txt:
  • web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt:
  • web-platform-tests/web-animations/interfaces/Animation/persist-expected.txt:
  • web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement-expected.txt:

Source/WebCore:

Implementing section "5.5 Replacing Animations" (​https://drafts.csswg.org/web-animations/#replacing-animations) of the Web Animations
specification which allows for Web Animations to be destroyed when they are superseded by another animation and the developer doesn't
explicitly opt into persisting them using the persist() method.

An animation is marked as replaceable (to sum up) when it's finished and another animation for the same property takes precedence.
As part of DocumentTimeline::internalUpdateAnimationsAndSendEvents(), we'll go through all replaceable animations, dispatch a "remove"
DOM event, and remove them from our list of animations.

We also make a couple of fixes in this patch that were uncovered while working on the WPT tests for replaced animations:

  • we would incorrectly parse single values for a property that allows lists (change in KeyframeEffect's processKeyframeLikeObject())
  • we didn't account for the position in the global animation list when sorted animations by composite order (AnimationTimeline::animationsForElement())

Finally, to get more readable results, we implement a stub of commitStyles(). Its full implementation is tracked by ​http://wkb.ug/202193.

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationTimingDidChange): Mark the position of the animation in the global animation list, to which it may only be added once.
(WebCore::AnimationTimeline::animationsForElement const): Account for the animation's position in the global animation when sorting.

  • animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::bindingsReplaceState const): Flush pending styles when querying the ready state for a declarative animation.

  • animation/DeclarativeAnimation.h:
  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::internalUpdateAnimationsAndSendEvents): Run the "remove replaced animations" procedure as the second step in the "update animations
and send events" procedure.
(WebCore::DocumentTimeline::animationCanBeRemoved): Determine whether a given animation may be removed based on its finished state, replace state and whether
it is fully superseded by another animation targeting the same property on the same target element.
(WebCore::DocumentTimeline::removeReplacedAnimations): Remove any removable animation and dispatch a "remove" DOM event for each removed animation.

  • animation/DocumentTimeline.h:
  • animation/KeyframeEffect.cpp:

(WebCore::processKeyframeLikeObject): Fix an issue found in a replaced animations WPT test that showed that we didn't record the value of an animation that allows lists.

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::isReplaceable const):
(WebCore::WebAnimation::persist): Mark the replace state as "persisted" and ensure the animation is set on the animation list for its target element in case it had already
been removed based on its persisted state.
(WebCore::WebAnimation::commitStyles): Stub for a new function.

  • animation/WebAnimation.h:

(WebCore::WebAnimation::replaceState const):
(WebCore::WebAnimation::setReplaceState):
(WebCore::WebAnimation::bindingsReplaceState const):
(WebCore::WebAnimation::globalPosition const):
(WebCore::WebAnimation::setGlobalPosition):

  • animation/WebAnimation.idl:
  • dom/EventNames.h: Add the new "remove" event so that the "onremove" DOM property is available on Animation objects.
4:26 AM Changeset in webkit [250602] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix for non-Mac ports after r250600.

  • UIProcess/WebProcessPool.cpp:

Make the CoreGraphicsSPI.h header include exclusive to the Mac port.

4:10 AM Changeset in webkit [250601] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix in Nicosia's ScrollingTreePositionedNode class.

  • page/scrolling/nicosia/ScrollingTreePositionedNode.cpp:

(WebCore::ScrollingTreePositionedNode::applyLayerPositions):
Fix the name of the variable included in the log call.

4:04 AM Changeset in webkit [250600] by graouts@webkit.org
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix for macOS, broken by r250595.

  • UIProcess/WebProcessPool.cpp:
2:41 AM Changeset in webkit [250599] by youenn@apple.com
  • 21 edits
    1 copy in trunk/Source

Use strongly typed identifiers for webrtc sockets
​https://bugs.webkit.org/show_bug.cgi?id=202400

Reviewed by Chris Dumez.

Source/WebCore:

No observable change of behavior.

  • Headers.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/libwebrtc/LibWebRTCSocketIdentifier.h: Copied from Source/WebKit/NetworkProcess/webrtc/NetworkRTCSocket.h.

Source/WebKit:

Refactoring to use LibWebRTCSocketIdentifier instead of uint64_t.

  • NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:

(WebKit::LibWebRTCSocketClient::LibWebRTCSocketClient):

  • NetworkProcess/webrtc/LibWebRTCSocketClient.h:
  • NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::createSocket):
(WebKit::NetworkRTCProvider::createUDPSocket):
(WebKit::NetworkRTCProvider::createServerTCPSocket):
(WebKit::NetworkRTCProvider::createClientTCPSocket):
(WebKit::NetworkRTCProvider::wrapNewTCPConnection):
(WebKit::NetworkRTCProvider::addSocket):
(WebKit::NetworkRTCProvider::takeSocket):
(WebKit::NetworkRTCProvider::newConnection):
(WebKit::NetworkRTCProvider::didReceiveNetworkRTCSocketMessage):
(WebKit::NetworkRTCProvider::closeListeningSockets):
(WebKit::NetworkRTCProvider::callSocket):

  • NetworkProcess/webrtc/NetworkRTCProvider.h:
  • NetworkProcess/webrtc/NetworkRTCProvider.messages.in:
  • NetworkProcess/webrtc/NetworkRTCSocket.cpp:

(WebKit::NetworkRTCSocket::NetworkRTCSocket):

  • NetworkProcess/webrtc/NetworkRTCSocket.h:
  • Scripts/webkit/messages.py:
  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveMessage):

  • WebProcess/Network/webrtc/LibWebRTCNetwork.h:

(WebKit::LibWebRTCNetwork::socket):

  • WebProcess/Network/webrtc/LibWebRTCSocket.cpp:

(WebKit::LibWebRTCSocket::LibWebRTCSocket):

  • WebProcess/Network/webrtc/LibWebRTCSocket.h:
  • WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:

(WebKit::LibWebRTCSocketFactory::createServerTcpSocket):
(WebKit::LibWebRTCSocketFactory::createUdpSocket):
(WebKit::LibWebRTCSocketFactory::createClientTcpSocket):
(WebKit::LibWebRTCSocketFactory::createNewConnectionSocket):

  • WebProcess/Network/webrtc/LibWebRTCSocketFactory.h:

(WebKit::LibWebRTCSocketFactory::socket):
(WebKit::LibWebRTCSocketFactory::resolver):
(WebKit::LibWebRTCSocketFactory::takeResolver):
(WebKit::LibWebRTCSocketFactory::disableNonLocalhostConnections):

  • WebProcess/Network/webrtc/WebRTCSocket.cpp:

(WebKit::WebRTCSocket::signalOnNetworkThread):
(WebKit::WebRTCSocket::WebRTCSocket):
(WebKit::WebRTCSocket::signalSentPacket):
(WebKit::WebRTCSocket::signalConnect):
(WebKit::WebRTCSocket::signalClose):
(WebKit::WebRTCSocket::signalNewConnection):

  • WebProcess/Network/webrtc/WebRTCSocket.h:
  • WebProcess/Network/webrtc/WebRTCSocket.messages.in:
1:29 AM Changeset in webkit [250598] by Carlos Garcia Campos
  • 1 edit
    623 adds in trunk/LayoutTests

Unreviewed GTK gardening. Add missing results after r250276.

  • platform/gtk/imported/w3c/web-platform-tests/svg/: Added.
1:00 AM Changeset in webkit [250597] by Carlos Garcia Campos
  • 22 edits
    5 deletes in trunk

[GTK][WPE] Stop using legacy custom protocol implementation
​https://bugs.webkit.org/show_bug.cgi?id=202407

Reviewed by Žan Doberšek.

.:

Make LEGACY_CUSTOM_PROTOCOL_MANAGER disabled by default.

  • Source/cmake/OptionsFTW.cmake:
  • Source/cmake/OptionsPlayStation.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Remove the code to setup custom protocols in soup session.

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):

  • platform/network/soup/SoupNetworkSession.h:

Source/WebKit:

Use the new approach, which is simpler and doesn't require to go to the network process to load custom
protocols.

  • NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp: Removed.
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::m_messagePortChannelRegistry):

  • NetworkProcess/soup/WebKitSoupRequestInputStream.cpp: Removed.
  • NetworkProcess/soup/WebKitSoupRequestInputStream.h: Removed.
  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • SourcesGTK.txt:
  • SourcesWPE.txt:
  • UIProcess/API/glib/WebKitCustomProtocolManagerClient.cpp: Removed.
  • UIProcess/API/glib/WebKitCustomProtocolManagerClient.h: Removed.
  • UIProcess/API/glib/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestCreate):
(webkit_uri_scheme_request_get_scheme):
(webkit_uri_scheme_request_get_uri):
(webkit_uri_scheme_request_get_path):
(webkit_uri_scheme_request_get_web_view):
(webkitURISchemeRequestReadCallback):
(webkit_uri_scheme_request_finish_error):

  • UIProcess/API/glib/WebKitURISchemeRequestPrivate.h:
  • UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextConstructed):
(webkitWebContextDispose):
(webkit_web_context_register_uri_scheme):
(webkitWebContextCreatePageForWebView):

  • UIProcess/API/glib/WebKitWebContextPrivate.h:
  • UIProcess/WebURLSchemeTask.h:

(WebKit::WebURLSchemeTask::request const):

  • UIProcess/soup/WebProcessPoolSoup.cpp:

Tools:

Remove the tests to check failure after committed, because it's not possible to test it with current code.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(testWebContextURIScheme):

12:45 AM Changeset in webkit [250596] by zandobersek@gmail.com
  • 11 edits in trunk

[Nicosia] Enable async scrolling at build-time for Nicosia-using ports
​https://bugs.webkit.org/show_bug.cgi?id=202397

Reviewed by Carlos Garcia Campos.

.:

Enable ASYNC_SCROLLING code for ports leveraging the Nicosia layering
system. This still has to be runtime-enabled in the DrawingArea
implementation.

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsPlayStation.cmake:
  • Source/cmake/OptionsWPE.cmake:

Source/WebCore:

  • PlatformPlayStation.cmake: Add missing build targets.
  • SourcesGTK.txt: Ditto.

Source/WebKit:

  • Shared/WebEvent.h:

Enable WebWheelEvent phasing for WPE, as required by the
ASYNC_SCROLLING code.

Source/WTF:

  • wtf/Platform.h:

Flip ENABLE_KINETIC_SCROLLING to 1 also for PlayStation and WPE ports
when ASYNC_SCROLLING is enabled.

Note: See TracTimeline for information about the timeline view.