Timeline

Oct 6, 2019:

7:30 PM Changeset in webkit [250770] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

attachShadow should support attaching a shadow root to a main element
​https://bugs.webkit.org/show_bug.cgi?id=197726

Reviewed by Antti Koivisto.

Source/WebCore:

Added main element to the list of elements that support an author shadow root.

Test: fast/shadow-dom/attach-shadow-to-elements.html

• dom/Element.cpp:

(WebCore::canAttachAuthorShadowRoot):

LayoutTests:

Added a test for attachShadow.

• fast/shadow-dom/attach-shadow-to-elements-expected.txt: Added.
• fast/shadow-dom/attach-shadow-to-elements.html: Added.

6:58 AM Changeset in webkit [250769] by Alan Bujtas

• 11 edits
  2 adds in trunk/Source/WebCore

[LFC][Painting] Introduce Display::Painter
​https://bugs.webkit.org/show_bug.cgi?id=202614
<rdar://problem/56010347>

Reviewed by Antti Koivisto.

Display::Painter is responsible for rendering the nodes in the display tree. Testing purposes/WK1 only at this point.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• layout/LayoutContext.cpp:

(WebCore::Layout::initializeLayoutState):
(WebCore::Layout::LayoutContext::runLayout):
(WebCore::Layout::LayoutContext::runLayoutAndVerify):
(WebCore::Layout::LayoutContext::runLayoutAndPaint):
(WebCore::Layout::LayoutContext::run): Deleted.

• layout/LayoutContext.h:
• layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::LayoutState):

• layout/LayoutState.h:

(WebCore::Layout::LayoutState::root const):

• layout/Verification.cpp:

(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree):

• layout/displaytree/DisplayPainter.cpp: Added.

(WebCore::Display::Painter::paint):

• layout/displaytree/DisplayPainter.h: Added.
• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::printLayoutTreeForLiveDocuments):

• page/FrameView.cpp:

(WebCore::FrameView::paintContents):

• page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

2:57 AM Changeset in webkit [250768] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

Node::ref/deref should be const
​https://bugs.webkit.org/show_bug.cgi?id=202562

Reviewed by Ryosuke Niwa.

This enables RefPtr<const Element> and matches RefCounted.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchAuthorShadowPseudoElementRules):
(WebCore::ElementRuleCollector::matchHostPseudoClassRules):
(WebCore::ElementRuleCollector::matchSlottedPseudoElementRules):
(WebCore::ElementRuleCollector::matchPartPseudoElementRules):
(WebCore::ElementRuleCollector::collectMatchingShadowPseudoElementRules):
(WebCore::ElementRuleCollector::collectSlottedPseudoElementRulesForSlot):
(WebCore::ElementRuleCollector::matchUARules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::matchAllRules):

Use it to ref elements in ElementRuleCollector.

• css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::element const):

• dom/Node.h:

(WebCore::Node::ref const):
(WebCore::Node::deref const):
(WebCore::Node::ref): Deleted.
(WebCore::Node::deref): Deleted.

Oct 5, 2019:

10:35 AM Changeset in webkit [250767] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC] LayoutChildtIteratorAdapter -> LayoutChildIteratorAdapter
​https://bugs.webkit.org/show_bug.cgi?id=202612
<rdar://problem/56007611>

Reviewed by Anders Carlsson.

• layout/layouttree/LayoutChildIterator.h:

(WebCore::Layout::LayoutChildIterator<T>::LayoutChildIterator):
(WebCore::Layout::LayoutChildIterator<T>::operator):
(WebCore::Layout::LayoutChildIteratorAdapter<T>::LayoutChildIteratorAdapter):
(WebCore::Layout::LayoutChildIteratorAdapter<T>::begin const):
(WebCore::Layout::LayoutChildIteratorAdapter<T>::end const):
(WebCore::Layout::LayoutChildIteratorAdapter<T>::first const):
(WebCore::Layout::LayoutChildIteratorAdapter<T>::last const):
(WebCore::Layout::childrenOfType):
(WebCore::Layout::LayoutChildtIterator<T>::LayoutChildtIterator): Deleted.
(WebCore::Layout::LayoutChildtIterator<T>::operator): Deleted.
(WebCore::Layout::LayoutChildtIteratorAdapter<T>::LayoutChildtIteratorAdapter): Deleted.
(WebCore::Layout::LayoutChildtIteratorAdapter<T>::begin const): Deleted.
(WebCore::Layout::LayoutChildtIteratorAdapter<T>::end const): Deleted.
(WebCore::Layout::LayoutChildtIteratorAdapter<T>::first const): Deleted.
(WebCore::Layout::LayoutChildtIteratorAdapter<T>::last const): Deleted.

7:05 AM Changeset in webkit [250766] by Alan Bujtas

• 34 edits in trunk/Source/WebCore

[LFC] Remove redundant includes.
​https://bugs.webkit.org/show_bug.cgi?id=202610
<rdar://problem/56003250>

Reviewed by Tim Horton.

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:
• layout/FormattingContextQuirks.cpp:
• layout/FormattingState.h:
• layout/LayoutContext.h:
• layout/LayoutState.h:
• layout/LayoutUnits.h:
• layout/blockformatting/BlockFormattingContext.cpp:
• layout/blockformatting/BlockFormattingContext.h:
• layout/blockformatting/BlockFormattingState.cpp:
• layout/blockformatting/BlockFormattingState.h:
• layout/blockformatting/BlockInvalidation.h:
• layout/displaytree/DisplayRect.h:
• layout/displaytree/DisplayRun.h:
• layout/floats/FloatAvoider.cpp:
• layout/floats/FloatAvoider.h:
• layout/floats/FloatBox.h:
• layout/floats/FloatingContext.cpp:
• layout/floats/FloatingContext.h:
• layout/floats/FloatingState.h:
• layout/inlineformatting/InlineFormattingContext.cpp:
• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextGeometry.cpp:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:
• layout/inlineformatting/InlineInvalidation.h:
• layout/inlineformatting/InlineLine.h:
• layout/inlineformatting/InlineLineBreaker.cpp:
• layout/inlineformatting/InlineLineLayout.cpp:
• layout/layouttree/LayoutBox.h:
• layout/tableformatting/TableFormattingContext.h:
• layout/tableformatting/TableFormattingContextGeometry.cpp:
• layout/tableformatting/TableGrid.h:
• layout/tableformatting/TableInvalidation.h: