Context Navigation

← Previous Period
Next Period →

Timeline

Oct 9, 2019:

11:59 PM Changeset in webkit [250957] by youenn@apple.com

4 edits in trunk/Source

A service worker process should not be created when enqueuing a service worker job
https://bugs.webkit.org/show_bug.cgi?id=202578
<rdar://problem/55979690>

Reviewed by Chris Dumez.

Source/WebCore:

Ask for a service worker context connection when planning to install or run a service worker.
This allows to not spin unnecessarily service worker processes for jobs that do not end up installing a service worker.

Covered by existing tests.

workers/service/server/SWServer.cpp:

(WebCore::SWServer::tryInstallContextData):
(WebCore::SWServer::runServiceWorkerIfNecessary):

Source/WebKit:

Remove the calls to create service worker context connection.
They are now done at SWServer level when trying to either run a service worker or install one.

NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::postMessageToServiceWorker):
(WebKit::WebSWServerConnection::scheduleJobInServer):

10:28 PM Changeset in webkit [250956] by yurys@chromium.org

5 edits in trunk/LayoutTests

LayoutTest inspector/dom-debugger/node-removed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=154610
<rdar://problem/24801209>

Reviewed by Matt Baker.

Reenabled the test on all platforms.

The test was missing call to Debugger.setBreakpointsActive. Apparently at the time
it was written calling Debugger.setBreakpoint automatically activated breakpoint but
the behavior changed over time. I also removed some unnecessary code.

inspector/dom-debugger/node-removed-expected.txt:
inspector/dom-debugger/node-removed.html:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:

10:12 PM Changeset in webkit [250955] by Nikita Vasilyev

3 edits in trunk/Source/WebInspectorUI

REGRESSION(r250948): Web Inspector: Styles: CSS selector becomes gray after stopping editing without modifying it
https://bugs.webkit.org/show_bug.cgi?id=202781

Reviewed by Matt Baker.

When not editing, CSS selectors that match the selected node are highlighted (black in the light mode,
white in the dark mode). When editing starts, span elements that provide highlighting get removed.
When editing stops, active selectors should get highlighted.

r250948 stopped calling _renderSelector when selector wasn't modified.

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetSelectorFieldDidCommit):

UserInterface/Views/SpreadsheetSelectorField.js:

(WI.SpreadsheetSelectorField.prototype._handleBlur):

8:08 PM Changeset in webkit [250954] by Wenson Hsieh

2 edits in trunk/Source/WebCore

Unreviewed, fix the internal iOS build

page/PointerCaptureController.h: Add some missing forward declarations.

7:23 PM Changeset in webkit [250953] by Keith Rollin

3 edits in trunk/Source/WTF

Remove some support for < iOS 13
https://bugs.webkit.org/show_bug.cgi?id=202371
<rdar://problem/55853960>

Reviewed by Youenn Fablet.

Remove some support for iOS versions less than 13.0.

Update conditionals that reference IPHONE_OS_VERSION_MIN_REQUIRED
and IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
values >= 130000. This means that expressions like
"IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
"IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.

This removal is part of a series of patches effecting the removal of
dead code for old versions of iOS. This particular pass involves
changes in which Dean Jackson was involved. These changes are isolated
from other similar changes in order to facilitate the reviewing
process.

wtf/FeatureDefines.h:
wtf/Platform.h:

7:02 PM Changeset in webkit [250952] by mmaxfield@apple.com

3 edits in trunk/LayoutTests

Make fast/text/complex-initial-advance.html more robust
https://bugs.webkit.org/show_bug.cgi?id=202708

Unreviewed follow up to r250884.

Makes test robust enough to pass on Mojave.

fast/text/complex-initial-advance-expected.html:
fast/text/complex-initial-advance.html:

6:44 PM Changeset in webkit [250951] by sihui_liu@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, fix an asserition after r250937.

Space increase tasks will be finished once it's started.

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::finishSpaceIncreaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):

6:27 PM Changeset in webkit [250950] by Wenson Hsieh

25 edits
1 copy in trunk/Source

[Clipboard API] Refactor Pasteboard item reading functions to work on both iOS and macOS
https://bugs.webkit.org/show_bug.cgi?id=202647

Reviewed by Tim Horton.

Source/WebCore:

Moves some pasteboard helper functions out of iOS-specific code, and into platform-agnostic code. See below for
more details. There is no change in behavior, as nothing exercises these new pasteboard functions on macOS yet.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/Pasteboard.cpp:

(WebCore::Pasteboard::allPasteboardItemInfo const):
(WebCore::Pasteboard::pasteboardItemInfo const):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::readBuffer):
(WebCore::Pasteboard::readURL):

Add some new helpers on Pasteboard to read Strings, data, and URLs from the platform pasteboard. These forward
to the platform strategy which, in WebKit2, are currently implemented using sync IPC, but could be changed in
the future to be fully asynchronous.

platform/Pasteboard.h:

(WebCore::Pasteboard::name const):

Expose a cross-platform name() getter on Pasteboard. On non-Cocoa platforms, this simply returns the empty
string, but on macOS and iOS, this returns the platform pasteboard name, which is stored in m_pasteboardName.

platform/PasteboardItemInfo.h:

(WebCore::PasteboardItemInfo::pathForContentType const):
(WebCore::PasteboardItemInfo::contentTypeForHighestFidelityItem const):
(WebCore::PasteboardItemInfo::encode const):
(WebCore::PasteboardItemInfo::decode):

Adds a couple of new members to PasteboardItemInfo (which represents metadata about a given item in the platform
pasteboard). These are changeCount (which is self explanatory), and webSafeTypesByFidelity, which is a list of
types in fidelity order which contains the list of pasteboard types that are safe to expose to bindings. These
may include types such as "text/plain", "text/html", "text/uri-list", and "image/png".

To distinguish this list from the existing contentTypesByFidelity list, I've also renamed contentTypesByFidelity
to platformTypesByFidelity, to make it more obvious that this other list of types are platform-specific, and not
generally safe to expose to the web.

platform/PasteboardStrategy.h:
platform/PlatformPasteboard.h:

Move several helpers out into platform-agnostic code.

platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::fileContentState):

platform/cocoa/PlatformPasteboardCocoa.mm: Added.

Add a new file to contain the implementation of PlatformPasteboard::allPasteboardItemInfo, which is the same
across Cocoa platforms.

(WebCore::PlatformPasteboard::allPasteboardItemInfo):

platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::readRespectingUTIFidelities):

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::informationForItemAtIndex):
(WebCore::PlatformPasteboard::readBuffer const):
(WebCore::PlatformPasteboard::readString const):
(WebCore::PlatformPasteboard::readURL const):

Additionally refactor all methods on PlatformPasteboard that take pasteboard item indices as signed integers
(int) to receive size_t values instead.

(WebCore::PlatformPasteboard::allPasteboardItemInfo): Deleted.

platform/libwpe/PasteboardLibWPE.cpp:

(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::read):

platform/libwpe/PlatformPasteboardLibWPE.cpp:

(WebCore::PlatformPasteboard::readString const):

Add an implementation stub for WPE.

platform/mac/PlatformPasteboardMac.mm:

(WebCore::modernPasteboardTypeForWebSafeMIMEType):
(WebCore::webSafeMIMETypeForModernPasteboardType):

Add helpers to convert between modern NSPasteboardTypes and web-safe types. While some logic exists today on
macOS to convert between legacy pasteboard types and web-safe types, conversion between the modern pasteboard
types and web-safe types are needed since NSPasteboardItem's types only support NSPasteboardTypes and
dynamically declared types that match the format of a universal type identfier (for instance, "com.foo.bar").

(WebCore::PlatformPasteboard::readBuffer const):
(WebCore::PlatformPasteboard::readString const):
(WebCore::PlatformPasteboard::readURL const):
(WebCore::PlatformPasteboard::count const):
(WebCore::PlatformPasteboard::informationForItemAtIndex):

Implement all of these helpers by looking up the NSPasteboardItem at the given item index and querying it for
data for non-legacy pasteboard types.

(WebCore::PlatformPasteboard::itemAtIndex const):

Source/WebKit:

Refactor iOS-specific pasteboard functions to be platform-agnostic. See WebCore ChangeLog for more details.

UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::allPasteboardItemInfo):
(WebKit::WebPasteboardProxy::informationForItemAtIndex):
(WebKit::WebPasteboardProxy::getPasteboardItemsCount):
(WebKit::WebPasteboardProxy::readStringFromPasteboard):
(WebKit::WebPasteboardProxy::readURLFromPasteboard):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
(WebKit::WebPasteboardProxy::writeURLToPasteboard):
(WebKit::WebPasteboardProxy::writeWebContentToPasteboard):
(WebKit::WebPasteboardProxy::writeImageToPasteboard):
(WebKit::WebPasteboardProxy::writeStringToPasteboard):

UIProcess/WebPasteboardProxy.cpp:

UIProcess/WebPasteboardProxy.h:
UIProcess/WebPasteboardProxy.messages.in:
UIProcess/wpe/WebPasteboardProxyWPE.cpp:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::informationForItemAtIndex):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
(WebKit::WebPlatformStrategies::readURLFromPasteboard):
(WebKit::WebPlatformStrategies::readStringFromPasteboard):
(WebKit::WebPlatformStrategies::writeToPasteboard):
(WebKit::WebPlatformStrategies::updateSupportedTypeIdentifiers):

WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

Refactor iOS-specific pasteboard functions to be platform-agnostic. See WebCore ChangeLog for more details.

WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::informationForItemAtIndex):
(WebPlatformStrategies::allPasteboardItemInfo):
(WebPlatformStrategies::getPasteboardItemsCount):
(WebPlatformStrategies::readBufferFromPasteboard):
(WebPlatformStrategies::readURLFromPasteboard):
(WebPlatformStrategies::readStringFromPasteboard):
(WebPlatformStrategies::writeToPasteboard):
(WebPlatformStrategies::updateSupportedTypeIdentifiers):

6:01 PM Changeset in webkit [250949] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed. Try to fix build for Windows C_LOOP

llint/LowLevelInterpreter.asm:

5:55 PM Changeset in webkit [250948] by Nikita Vasilyev

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Modifying CSS selector by pressing Enter or Tab causes 2 CSS.setRuleSelector backend calls
https://bugs.webkit.org/show_bug.cgi?id=202769
<rdar://problem/56132166>

Reviewed by Matt Baker.

Previously, spreadsheetSelectorFieldDidChange would get called twice:

On Enter or Tab key press.
On blur event.

With this patch, it only gets called on blur event.

UserInterface/Models/CSSRule.js:

(WI.CSSRule.prototype.set selectorText):
Remove dead code. Calling _selectorResolved(true) would cause an uncaught exception.

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetSelectorFieldDidChange): Removed.
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetSelectorFieldDidCommit): Added.
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetSelectorFieldWillNavigate): Added.
Split spreadsheetSelectorFieldDidChange into spreadsheetSelectorFieldDidCommit and spreadsheetSelectorFieldWillNavigate.

UserInterface/Views/SpreadsheetSelectorField.js:

(WI.SpreadsheetSelectorField):
(WI.SpreadsheetSelectorField.prototype.startEditing):
(WI.SpreadsheetSelectorField.prototype.stopEditing):
(WI.SpreadsheetSelectorField.prototype._handleBlur):
(WI.SpreadsheetSelectorField.prototype._handleKeyDown):
Add _valueBeforeEditing to check if the value was modified before the blur event.
Similar logic exists in SpreadsheetTextField.

5:36 PM Changeset in webkit [250947] by Alan Coon

25 edits
13 deletes in tags/Safari-609.1.6

Revert r250540. rdar://problem/56052722

5:24 PM Changeset in webkit [250946] by Simon Fraser

45 edits
1 move
1 add
1 delete in trunk

Rename WheelEventTestTrigger and improve naming in related code
https://bugs.webkit.org/show_bug.cgi?id=202772

Reviewed by Tim Horton.

Change the "test trigger" terminology to "monitor wheel events"; after all, tests
call monitorWheelEvents() and callAfterScrollingCompletes(), and this is not triggering
a test.

Source/WebCore:

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
page/FrameView.cpp:

(WebCore::FrameView::adjustScrollbarsForLayout):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::didAddScrollbar):

page/Page.cpp:

(WebCore::Page::ensureWheelEventTestMonitor):
(WebCore::Page::ensureTestTrigger): Deleted.

page/Page.h:

(WebCore::Page::wheelEventTestMonitor const):
(WebCore::Page::clearWheelEventTestMonitor):
(WebCore::Page::isMonitoringWheelEvents const):
(WebCore::Page::testTrigger const): Deleted.
(WebCore::Page::clearTrigger): Deleted.
(WebCore::Page::expectsWheelEventTriggers const): Deleted.

page/WheelEventTestMonitor.cpp: Added.

(WebCore::WheelEventTestMonitor::WheelEventTestMonitor):
(WebCore::WheelEventTestMonitor::clearAllTestDeferrals):
(WebCore::WheelEventTestMonitor::setTestCallbackAndStartNotificationTimer):
(WebCore::WheelEventTestMonitor::deferForReason):
(WebCore::WheelEventTestMonitor::removeDeferralForReason):
(WebCore::WheelEventTestMonitor::triggerTestTimerFired):
(WebCore::operator<<):

page/WheelEventTestMonitor.h: Renamed from Source/WebCore/page/WheelEventTestTrigger.h.
page/WheelEventTestTrigger.cpp: Removed.
page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformPrepareForWheelEvents):

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::updateIsMonitoringWheelEventsForFrameView):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::deferWheelEventTestCompletionForReason const):
(WebCore::AsyncScrollingCoordinator::removeWheelEventTestCompletionDeferralForReason const):
(WebCore::AsyncScrollingCoordinator::updateExpectsWheelEventTestTriggerWithFrameView): Deleted.
(WebCore::AsyncScrollingCoordinator::deferTestsForReason const): Deleted.
(WebCore::AsyncScrollingCoordinator::removeTestDeferralForReason const): Deleted.

page/scrolling/AsyncScrollingCoordinator.h:
page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::updateIsMonitoringWheelEventsForFrameView):
(WebCore::ScrollingCoordinator::updateExpectsWheelEventTestTriggerWithFrameView): Deleted.

page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setPropertyChangedBitsAfterReattach):
(WebCore::ScrollingStateScrollingNode::setIsMonitoringWheelEvents):
(WebCore::ScrollingStateScrollingNode::dumpProperties const):
(WebCore::ScrollingStateScrollingNode::setExpectsWheelEventTestTrigger): Deleted.

page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::isMonitoringWheelEvents const):
(WebCore::ScrollingStateScrollingNode::expectsWheelEventTestTrigger const): Deleted.

page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::deferWheelEventTestCompletionForReason):
(WebCore::ScrollingTree::removeWheelEventTestCompletionDeferralForReason):
(WebCore::ScrollingTree::deferTestsForReason): Deleted.
(WebCore::ScrollingTree::removeTestDeferralForReason): Deleted.

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren):

page/scrolling/ScrollingTreeScrollingNode.h:
page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::deferWheelEventTestCompletionForReason):
(WebCore::ThreadedScrollingTree::removeWheelEventTestCompletionDeferralForReason):
(WebCore::ThreadedScrollingTree::deferTestsForReason): Deleted.
(WebCore::ThreadedScrollingTree::removeTestDeferralForReason): Deleted.

page/scrolling/ThreadedScrollingTree.h:
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::deferWheelEventTestCompletionForReason const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::removeWheelEventTestCompletionDeferralForReason const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::deferTestsForReason const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::removeTestDeferralForReason const): Deleted.

platform/Logging.h:
platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::deferWheelEventTestCompletionForReason const):
(WebCore::ScrollAnimator::removeWheelEventTestCompletionDeferralForReason const):
(WebCore::ScrollAnimator::deferTestsForReason const): Deleted.
(WebCore::ScrollAnimator::removeTestDeferralForReason const): Deleted.

platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::ScrollAnimator::setWheelEventTestMonitor):
(WebCore::ScrollAnimator::ScrollAnimator::setWheelEventTestTrigger): Deleted.

platform/cocoa/ScrollController.h:

(WebCore::ScrollControllerClient::deferWheelEventTestCompletionForReason const):
(WebCore::ScrollControllerClient::removeWheelEventTestCompletionDeferralForReason const):
(WebCore::ScrollControllerClient::deferTestsForReason const): Deleted.
(WebCore::ScrollControllerClient::removeTestDeferralForReason const): Deleted.

platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::startSnapRubberbandTimer):
(WebCore::ScrollController::stopSnapRubberbandTimer):
(WebCore::ScrollController::scheduleStatelessScrollSnap):
(WebCore::ScrollController::startDeferringWheelEventTestCompletionDueToScrollSnapping):
(WebCore::ScrollController::stopDeferringWheelEventTestCompletionDueToScrollSnapping):
(WebCore::ScrollController::startScrollSnapTimer):
(WebCore::ScrollController::stopScrollSnapTimer):
(WebCore::ScrollController::startDeferringTestsDueToScrollSnapping): Deleted.
(WebCore::ScrollController::stopDeferringTestsDueToScrollSnapping): Deleted.

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::didBeginScrollGesture const):
(WebCore::ScrollAnimatorMac::didEndScrollGesture const):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

rendering/RenderBox.cpp:

(WebCore::setupWheelEventMonitor):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::setupWheelEventTestTrigger): Deleted.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::createScrollbar):

rendering/RenderListBox.cpp:

(WebCore::setupWheelEventTestMonitor):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::createScrollbar):
(WebCore::setupWheelEventTestTrigger): Deleted.

testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::monitorWheelEvents):
(WebCoreTestSupport::setTestCallbackAndStartNotificationTimer):
(WebCoreTestSupport::clearWheelEventTestMonitor):
(WebCoreTestSupport::clearWheelEventTestTrigger): Deleted.

testing/js/WebCoreTestSupport.h:

Source/WebKit:

UIProcess/API/C/WKPage.cpp:

(WKPageClearWheelEventTestMonitor):
(WKPageClearWheelEventTestTrigger): Deleted.

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::clearWheelEventTestMonitor):
(WebKit::WebPageProxy::clearWheelEventTestTrigger): Deleted.

UIProcess/WebPageProxy.h:
WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageStartMonitoringScrollOperations):
(WKBundlePageRegisterScrollOperationCompletionCallback):

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::createScrollbar):

WebProcess/WebPage/EventDispatcher.cpp:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::clearWheelEventTestMonitor):
(WebKit::WebPage::clearWheelEventTestTrigger): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

5:13 PM Changeset in webkit [250945] by dbates@webkit.org

6 edits
1 add in trunk

Add support for CompactPointerTuple<..., OptionSet<...>>
https://bugs.webkit.org/show_bug.cgi?id=201316

Reviewed by Yusuke Suzuki.

Source/WebCore:

Use the new CompactPointerTuple capability to replace CompactPointerTuple<RenderObject*, uint8_t>
with CompactPointerTuple<RenderObject*, OptionSet<ElementStyleFlag>> in Node.h.

dom/Node.h:

(WebCore::Node::hasStyleFlag const):
(WebCore::Node::setStyleFlag):
(WebCore::Node::clearStyleFlags):
Update code now that we support CompactPointerTuple<..., OptionSet<...>>.

Source/WTF:

Support using an OptionSet<> for the byte value portion of a CompactPointerTuple so that
you can encode both a pointer and 8-bit bitmask in a type-safe way. Another benefit of
supporting OptionSet<> is that we have a LLDB pretty-printer for it so this makes it easy
to see the set flags in such a CompactPointerTuple.

wtf/CompactPointerTuple.h:

Tools:

Add a test to ensure we encode and decode a compact pointer tuple correctly when an uint8_t and
a OptionSet<> as the byte value portion of the tuple.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/CompactPointerTuple.cpp: Added.

(TestWebKitAPI::TEST):

5:03 PM Changeset in webkit [250944] by wilander@apple.com

20 edits
8 adds in trunk

IsLoggedIn: Add as experimental feature
https://bugs.webkit.org/show_bug.cgi?id=202707
<rdar://problem/56095064>

Reviewed by Brent Fulgham and Chris Dumez.

IsLoggedIn was proposed to the WebAppSec WG at TPAC 2019.
So far there is only an explainer posted to the mailing list:
https://lists.w3.org/Archives/Public/public-webappsec/2019Sep/0004.html

Source/WebCore:

This patch adds the three experimental web APIs:

Promise<void> setLoggedIn()
Promise<void> setLoggedOut()
Promise<bool> isLoggedIn()

It also tests that those APIs are only exposed in secure contexts.

The functionality is implemented as a supplement to Navigator.

Tests: http/tests/is-logged-in/available-in-secure-contexts.https.html

http/tests/is-logged-in/unavailable-in-insecure-contexts.html

DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
page/NavigatorIsLoggedIn.cpp: Added.

(WebCore::NavigatorIsLoggedIn::from):
(WebCore::NavigatorIsLoggedIn::supplementName):
(WebCore::NavigatorIsLoggedIn::setLoggedIn):
(WebCore::NavigatorIsLoggedIn::setLoggedOut):
(WebCore::NavigatorIsLoggedIn::isLoggedIn):

page/NavigatorIsLoggedIn.h: Added.
page/NavigatorIsLoggedIn.idl: Added.
page/PointerCaptureController.cpp:
page/PointerCaptureController.h:
page/Settings.yaml:

Source/WebKit:

Shared/WebPreferences.yaml:

LayoutTests:

http/tests/is-logged-in/available-in-secure-contexts.https-expected.txt: Added.
http/tests/is-logged-in/available-in-secure-contexts.https.html: Added.
http/tests/is-logged-in/unavailable-in-insecure-contexts-expected.txt: Added.
http/tests/is-logged-in/unavailable-in-insecure-contexts.html: Added.
platform/ios-device-wk1/TestExpectations:
platform/ios-simulator-wk1/TestExpectations:
platform/ios-wk1/TestExpectations:
platform/mac-highsierra/fast/dom/navigator-detached-no-crash-expected.txt:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt:
platform/wincairo-wk1/TestExpectations:

4:50 PM Changeset in webkit [250943] by russell_e@apple.com

6 edits
1 delete in trunk

Unreviewed, rolling out r250930.

Broke watchOS Builds

Reverted changeset:

"Add support for CompactPointerTuple<..., OptionSet<...>>"
https://bugs.webkit.org/show_bug.cgi?id=201316
https://trac.webkit.org/changeset/250930

4:39 PM Changeset in webkit [250942] by Alan Bujtas

2 edits in trunk/LayoutTests

[iOS] LayoutTest fast/events/touch/ios/double-tap-for-double-click2.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=202765
<rdar://problem/56123067>

Reviewed by Wenson Hsieh.

Currently when a dblclick handler is dynamically registered while executing the click handler, we don't always pick up the newly added handler (see webkit.org/b/202766).
Modify the test so that it passes consistently (and still preserve the dynamic behavior).

fast/events/touch/ios/double-tap-for-double-click2.html:

4:31 PM Changeset in webkit [250941] by Alan Coon

1 copy in tags/Safari-608.3.10.1.3

Tag Safari-608.3.10.1.3.

4:03 PM Changeset in webkit [250940] by jiewen_tan@apple.com

72 edits
2 adds
1 delete in trunk

[WebAuthn] Move the mock testing entrance to Internals
https://bugs.webkit.org/show_bug.cgi?id=202560
<rdar://problem/55973793>

Reviewed by Chris Dumez.

Source/WebCore:

This patch moves TestRunner.setWebAuthenticationMockConfiguration to
Internals.setMockWebAuthenticationConfiguration and removes the old
entrance. The purpose of this patch is to allow API tests to use
the same mock infrastructure that is used by layout tests.

No new tests, covered by updates on existing tests.

DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webauthn/PublicKeyCredentialCreationOptions.h:
WebCore.xcodeproj/project.pbxproj:
page/ChromeClient.h:

(WebCore::ChromeClient::setMockWebAuthenticationConfiguration):

testing/Internals.cpp:

(WebCore::Internals::setMockWebAuthenticationConfiguration):

testing/Internals.h:
testing/Internals.idl:
testing/MockWebAuthenticationConfiguration.h: Added.

(WebCore::MockWebAuthenticationConfiguration::LocalConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::LocalConfiguration::decode):
(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::decode):
(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::decode):
(WebCore::MockWebAuthenticationConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::decode):

testing/MockWebAuthenticationConfiguration.idl: Added.

Source/WebKit:

UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration): Deleted.

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/WebAuthentication/AuthenticatorTransportService.cpp:

(WebKit::AuthenticatorTransportService::createMock):

UIProcess/WebAuthentication/AuthenticatorTransportService.h:
UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:

(WebKit::MockAuthenticatorManager::MockAuthenticatorManager):

UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.h:
UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:

(WebKit::MockHidConnection::send):
(WebKit::MockHidConnection::registerDataReceivedCallbackInternal):
(WebKit::MockHidConnection::parseRequest):
(WebKit::MockHidConnection::feedReports):
(WebKit::MockHidConnection::shouldContinueFeedReports):

UIProcess/WebAuthentication/Mock/MockHidConnection.h:
UIProcess/WebAuthentication/Mock/MockHidService.cpp:

(WebKit::MockHidService::MockHidService):

UIProcess/WebAuthentication/Mock/MockHidService.h:
UIProcess/WebAuthentication/Mock/MockLocalConnection.h:
UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:

(WebKit::MockLocalConnection::MockLocalConnection):

UIProcess/WebAuthentication/Mock/MockLocalService.h:
UIProcess/WebAuthentication/Mock/MockLocalService.mm:

(WebKit::MockLocalService::MockLocalService):

UIProcess/WebAuthentication/Mock/MockNfcService.h:
UIProcess/WebAuthentication/Mock/MockNfcService.mm:

(WebKit::MockNfcService::MockNfcService):
(WebKit::MockNfcService::platformStartDiscovery):
(WebKit::MockNfcService::detectTags const):

UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h: Removed.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setMockWebAuthenticationConfiguration):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebsiteData/WebsiteDataStore.h:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setMockWebAuthenticationConfiguration):

WebProcess/WebCoreSupport/WebChromeClient.h:

Tools:

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebAuthenticationMockConfiguration): Deleted.

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::setWebAuthenticationMockConfiguration): Deleted.

WebKitTestRunner/TestController.h:
WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

http/wpt/webauthn/ctap-hid-failure.https.html:
http/wpt/webauthn/ctap-hid-success.https.html:
http/wpt/webauthn/ctap-nfc-failure.https.html:
http/wpt/webauthn/idl.https.html:
http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https.html:
http/wpt/webauthn/public-key-credential-create-failure-hid.https.html:
http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html:
http/wpt/webauthn/public-key-credential-create-failure-local.https.html:
http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html:
http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https.html:
http/wpt/webauthn/public-key-credential-create-failure-u2f.https.html:
http/wpt/webauthn/public-key-credential-create-failure.https.html:
http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
http/wpt/webauthn/public-key-credential-create-success-local.https.html:
http/wpt/webauthn/public-key-credential-create-success-nfc.https.html:
http/wpt/webauthn/public-key-credential-create-success-u2f.https.html:
http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html:
http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:
http/wpt/webauthn/public-key-credential-get-failure-local-silent.https.html:
http/wpt/webauthn/public-key-credential-get-failure-local.https.html:
http/wpt/webauthn/public-key-credential-get-failure-nfc.https.html:
http/wpt/webauthn/public-key-credential-get-failure-u2f-silent.https.html:
http/wpt/webauthn/public-key-credential-get-failure-u2f.https.html:
http/wpt/webauthn/public-key-credential-get-failure.https.html:
http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
http/wpt/webauthn/public-key-credential-get-success-local.https.html:
http/wpt/webauthn/public-key-credential-get-success-nfc.https.html:
http/wpt/webauthn/public-key-credential-get-success-u2f.https.html:
http/wpt/webauthn/resources/public-key-credential-ip-address.https.html:

3:48 PM Changeset in webkit [250939] by Simon Fraser

5 edits in trunk/Source/WebCore

Clean up WheelEventTestTriggers logging
https://bugs.webkit.org/show_bug.cgi?id=202764

Reviewed by Tim Horton.

Make DeferTestTriggerReason a bit set, and use OptionSet<> rather than StdSet. Make
DeferTestTriggerReason and ScrollableAreaReasonMap loggable, and simplify the logging.

page/WheelEventTestTrigger.cpp:

(WebCore::WheelEventTestTrigger::clearAllTestDeferrals):
(WebCore::WheelEventTestTrigger::deferTestsForReason):
(WebCore::WheelEventTestTrigger::removeTestDeferralForReason):
(WebCore::WheelEventTestTrigger::triggerTestTimerFired):
(WebCore::operator<<):
(WebCore::dumpState): Deleted.

page/WheelEventTestTrigger.h:
page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::deferTestsForReason const):
(WebCore::AsyncScrollingCoordinator::removeTestDeferralForReason const):

page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::deferTestsForReason const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::removeTestDeferralForReason const):

3:46 PM Changeset in webkit [250938] by dino@apple.com

2 edits in trunk/LayoutTests

Layout test fast/events/touch/ios/passive-by-default-overridden-on-document-and-window.html is a flaky failure on Internal iOS testers
https://bugs.webkit.org/show_bug.cgi?id=202770
<rdar://51715312>

Reviewed by Megan Gardner.

Remove the touchmove listeners after firing once, because we can't
tell exactly how many we'll get for a drag.

fast/events/touch/ios/passive-by-default-overridden-on-document-and-window.html:

3:38 PM Changeset in webkit [250937] by sihui_liu@apple.com

8 edits in trunk/Source/WebCore

IndexedDB: update size to actual disk usage only when estimated increase is bigger than space available
https://bugs.webkit.org/show_bug.cgi?id=201957

Reviewed by Youenn Fablet.

For better performance.

Covered by existing tests.

Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::QuotaUser::resetSpaceUsed): m_estimatedSpaceIncrease will be updated when task
is finished, so no need to clear it when doing reset.
(WebCore::IDBServer::IDBServer::QuotaUser::computeSpaceUsed):

Modules/indexeddb/server/IDBServer.h:

Modules/indexeddb/server/UniqueIDBDatabase.cpp: instead of reading file size after each task, just add the

task size to known usage and get an estimated usage.
(WebCore::IDBServer::UniqueIDBDatabase::startSpaceIncreaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::finishSpaceIncreaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
(WebCore::IDBServer::UniqueIDBDatabase::deleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::shutdownForClose):
(WebCore::IDBServer::UniqueIDBDatabase::didShutdownForClose):
(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::generateUniqueCallbackIdentifier):
(WebCore::IDBServer::UniqueIDBDatabase::storeCallbackOrFireError):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::didOpenBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStoreAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCreateObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::renameObjectStoreAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformRenameObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::createIndexAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCreateIndex):
(WebCore::IDBServer::UniqueIDBDatabase::renameIndexAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformRenameIndex):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAddAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformPutOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::postDatabaseTaskReply):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):
(WebCore::IDBServer::UniqueIDBDatabase::performErrorCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performKeyDataCallback):
(WebCore::IDBServer::UniqueIDBDatabase::forgetErrorCallback):
(WebCore::IDBServer::generateUniqueCallbackIdentifier): Deleted.
(WebCore::IDBServer::UniqueIDBDatabase::updateSpaceUsedIfNeeded): Deleted.

Modules/indexeddb/server/UniqueIDBDatabase.h:

storage/StorageQuotaManager.cpp: use m_state to decide what action to take on next request. Previously when a

request asked for size bigger than space available, we would go to ask for more space directly. Now because IDB
can be reporting estimated usage, we first ask IDB to compute its actual disk usage and ask for more space if
actual space available is smaller than requested size.
(WebCore::StorageQuotaManager::askUserToInitialize):
(WebCore::StorageQuotaManager::removeUser):
(WebCore::StorageQuotaManager::requestSpace):
(WebCore::StorageQuotaManager::askForMoreSpace):
(WebCore::StorageQuotaManager::processPendingRequests):

storage/StorageQuotaManager.h:
storage/StorageQuotaUser.h:

(WebCore::StorageQuotaUser::computeSpaceUsed):

3:20 PM Changeset in webkit [250936] by sihui_liu@apple.com

6 edits
3 adds in trunk

IndexedDB: include size of index records in size estimate of put/add task
https://bugs.webkit.org/show_bug.cgi?id=202483

Reviewed by Geoffrey Garen.

Source/WebCore:

SQLiteIDBBackingStore has two tables IndexRecords and Records. For add operation add(VALUE, KEY), we add a new
record to Records table. If we can extract index value from VALUE for some index, we would add a new record to
IndexRecords table.

We estimated the task szie of add task with (KEY_SIZE + VALUE_SIZE), but we didn't count the size that could be
added to the IndexRecords table. This could lead to storage abuse.

Test: storage/indexeddb/request-size-estimate.html

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):

LayoutTests:

platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:
storage/indexeddb/request-size-estimate-expected.txt: Added.
storage/indexeddb/request-size-estimate.html: Added.
storage/indexeddb/resources/request-size-estimate.js: Added.

(randomKey):
(randomPropertyValue):
(createObject):
(prepareDatabase):
(onOpenSuccess):

3:03 PM Changeset in webkit [250935] by Chris Dumez

5 edits
2 adds in trunk

Youtube.com is unable to enter the back/forward cache on macOS
https://bugs.webkit.org/show_bug.cgi?id=202754
<rdar://problem/56117666>

Reviewed by Eric Carlson.

Source/WebCore:

As of r250542, the MainThreadGenericEventQueue used by both MediaSource and
SourceBuffer to fire event is PageCache-aware. As a result, both these
ActiveDOMObjects can now safety suspend without risking running script while
in the page cache. I did have to update some logic in MediaSource::removeSourceBuffer()
to make sure we do not unnecessarily construct new ActiveDOMObjects while
suspending, as this is not allowed.

Test: media/media-source/media-source-page-cache.html

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::removeSourceBuffer):
(WebCore::MediaSource::canSuspendForDocumentSuspension const):

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::canSuspendForDocumentSuspension const):

Modules/mediasource/SourceBuffer.h:

LayoutTests:

Add layout test coverage.

media/media-source/media-source-page-cache-expected.txt: Added.
media/media-source/media-source-page-cache.html: Added.

2:29 PM Changeset in webkit [250934] by aestes@apple.com

2 edits in trunk/Source/WebKit

[Cocoa] IPC::decode should gracefully handle a nil allowed class
https://bugs.webkit.org/show_bug.cgi?id=202753

Reviewed by Geoffrey Garen.

If IPC::decode is called with a nil allowed class, an NSInvalidArgumentException will be
thrown when trying to create an NSArray literal with a nil value. Depending on who calls
IPC::decode, this exception might or might not be caught, leading to dropped messages or
crashes.

One case of this happening is tracked by rdar://problem/55839467. In this case, the nil
allowed class was due to a build misconfiguration, and the exception caused the UI process
to not respond to a synchronous IPC message, hanging the WebContent process.

rdar://problem/55839467 was resolved by fixing the build misconfiguration, but this patch
improves IPC::decode so that a nil allowed class results in a message decoding failure
rather than a maybe-caught NSException.

Shared/Cocoa/ArgumentCodersCocoa.h:

(IPC::decode):

2:27 PM Changeset in webkit [250933] by Alan Coon

11 edits
1 delete in tags/Safari-609.1.6

Revert r250878. rdar://problem/56127001

2:23 PM Changeset in webkit [250932] by ysuzuki@apple.com

11 edits
1 delete in trunk

Unreviewed, roll out r250878
https://bugs.webkit.org/show_bug.cgi?id=202656

Breaking vimeo page.

JSTests:

stress/getter-setter-should-be-cell.js: Removed.

Source/JavaScriptCore:

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGFixupPhase.cpp:
runtime/GetterSetter.cpp:
runtime/GetterSetter.h:
runtime/JSGlobalObject.cpp:

(JSC::getGetterById):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::regExpProtoGlobalGetter const):
(JSC::JSGlobalObject::regExpProtoUnicodeGetter const):
(JSC::JSGlobalObject::getterSetterStructure const):

runtime/JSType.h:
runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

2:06 PM Changeset in webkit [250931] by Truitt Savell

2 edits in trunk/LayoutTests

Mark crypto/workers/subtle/aes-indexeddb.html as a timeout on Mojave Release wk2
https://bugs.webkit.org/show_bug.cgi?id=202500

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

2:02 PM Changeset in webkit [250930] by dbates@webkit.org

6 edits
1 add in trunk

Add support for CompactPointerTuple<..., OptionSet<...>>
https://bugs.webkit.org/show_bug.cgi?id=201316

Reviewed by Yusuke Suzuki.

Source/WebCore:

Use the new CompactPointerTuple capability to replace CompactPointerTuple<RenderObject*, uint8_t>
with CompactPointerTuple<RenderObject*, OptionSet<ElementStyleFlag>> in Node.h.

dom/Node.h:

(WebCore::Node::hasStyleFlag const):
(WebCore::Node::setStyleFlag):
(WebCore::Node::clearStyleFlags):
Update code now that we support CompactPointerTuple<..., OptionSet<...>>.

Source/WTF:

wtf/CompactPointerTuple.h:

Tools:

Add a test to ensure we encode and decode a compact pointer tuple correctly when an uint8_t and
a OptionSet<> as the byte value portion of the tuple.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/CompactPointerTuple.cpp: Added.

(TestWebKitAPI::TEST):

2:01 PM Changeset in webkit [250929] by Alan Bujtas

3 edits
2 adds in trunk

RunResolver::rangeForRendererWithOffsets should check for range end
https://bugs.webkit.org/show_bug.cgi?id=202761
<rdar://problem/55917924>

Reviewed by Antti Koivisto.

Source/WebCore:

This patch ensures that when rangeForRenderer comes back with a collapsed run (empty range), rangeForRendererWithOffsets returns an empty range as well.

Test: fast/text/simple-line-layout-range-check-end.html

rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::rangeForRendererWithOffsets const):

LayoutTests:

fast/text/simple-line-layout-range-check-end-expected.txt: Added.
fast/text/simple-line-layout-range-check-end.html: Added.

1:38 PM Changeset in webkit [250928] by Alan Coon

12 edits in tags/Safari-609.1.6

Partially undo r250811
https://bugs.webkit.org/show_bug.cgi?id=202715
<rdar://problem/56084287>

Reviewed by Chris Dumez.

Source/WebCore:

This patch changes the SerializedScriptValue to always wrap CryptoKey objects again.
CryptoKey objects could belong to an array or another object. In those cases, IDBObjectStore
cannot set the flag for the embedded Cryptokey objects. Neither can postMessage to unset
the flag. Therefore, there is no way to separate the serialization process into two and
this patch restores the old behaviour. However, the hardening part of r250811 is kept
and therefore the crash should still be prevented.

No new test, updated existing test

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::putOrAdd):
(WebCore::JSC::setIsWrappingRequiredForCryptoKey): Deleted.

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readTerminal):

crypto/CryptoKey.h:

(WebCore::CryptoKey::allows const):
(WebCore::CryptoKey::isWrappingRequired const): Deleted.
(WebCore::CryptoKey::setIsWrappingRequired): Deleted.
(): Deleted.

dom/ScriptExecutionContext.h:

Tools:

TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:

Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.

LayoutTests:

Some rebaselines.

crypto/workers/subtle/ec-postMessage-worker-expected.txt:
crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
crypto/workers/subtle/rsa-postMessage-worker-expected.txt:

1:21 PM Changeset in webkit [250927] by Alan Coon

1 copy in tags/Safari-609.1.6

Tag Safari-609.1.6.

1:12 PM Changeset in webkit [250926] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[iOS] Layout Test fast/events/touch/ios/touchstart-and-touchend-outside-touchmove-target.html is Timing Out
https://bugs.webkit.org/show_bug.cgi?id=202759
<rdar://problem/56122388>

Patch by Antoine Quint <Antoine Quint> on 2019-10-09
Reviewed by Dean Jackson.

This test would be run after fast/events/touch/ios/touchmove-cancelable-after-touchstart.html which does not
cleanly finish its simulated touch gesture with a touchend. Now that it does both tests can run one after the
other reliably.

fast/events/touch/ios/touchmove-cancelable-after-touchstart.html:

1:01 PM Changeset in webkit [250925] by Alan Coon

1 copy in tags/Safari-608.3.10.0.2

Tag Safari-608.3.10.0.2.

12:57 PM Changeset in webkit [250924] by Jonathan Bedard

6 edits in trunk/Tools

results.webkit.org: Increase default limit for test results
https://bugs.webkit.org/show_bug.cgi?id=202757

Rubber-stamped by Aakash Jain.

resultsdbpy/resultsdbpy/controller/suite_controller.py:

(SuiteController): Increase DEFAULT_LIMIT.

resultsdbpy/resultsdbpy/controller/test_controller.py:

(TestController): Ditto.

resultsdbpy/resultsdbpy/view/static/js/commit.js:

(_CommitBank.prototype._load): Make commit shards larger.

resultsdbpy/resultsdbpy/view/static/js/drawer.js: Increase default slider size.
resultsdbpy/resultsdbpy/view/templates/commits.html: Keep smaller slider size.

12:41 PM Changeset in webkit [250923] by Alan Coon

7 edits in branches/safari-608.3.10.0-branch/Source

Versioning.

12:40 PM Changeset in webkit [250922] by aboya@igalia.com

6 edits
11 adds in trunk

[MSE][GStreamer] Fix video sometimes not appearing
https://bugs.webkit.org/show_bug.cgi?id=201401

Reviewed by Xabier Rodriguez-Calvar.

LayoutTests/imported/w3c:

Added a test that reproduces the sequence of operations that was
causing the video to not appear in WebKitGTK and checks that this time
there is visible output.

web-platform-tests/lint.whitelist:
web-platform-tests/media-source/mediasource-video-is-visible-expected.html: Added.
web-platform-tests/media-source/mediasource-video-is-visible.html: Added.
web-platform-tests/media-source/mp4/test-a-1s.mp4: Added.
web-platform-tests/media-source/mp4/test-a-1s.mp4-manifest.json: Added.
web-platform-tests/media-source/mp4/test-v-1s-blue.mp4: Added.
web-platform-tests/media-source/mp4/test-v-1s-blue.mp4-manifest.json: Added.
web-platform-tests/media-source/webm/test-a-1s.webm: Added.
web-platform-tests/media-source/webm/test-a-1s.webm-manifest.json: Added.
web-platform-tests/media-source/webm/test-v-1s-blue.webm: Added.
web-platform-tests/media-source/webm/test-v-1s-blue.webm-manifest.json: Added.

Source/WebCore:

The code in MediaPlayerPrivateGStreamer::changePipelineState() was
supposed to call ensureGLVideoSinkContext() on upwards transitions
to PAUSED but the code did not take into account non-step-by-step
state transitions, which happens frequently with playbin3 in the MSE
case.

Before the patch, when playbin3 transitioned from READY to PLAYING
without stopping for preroll this call would not be made and the
texture IDs received at the sink would not correspond to the
compositor GL context, leading to artifacts (often the player controls
or a blank screen).

Test: imported/w3c/web-platform-tests/media-source/mediasource-video-is-visible.html

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):

LayoutTests:

Added an exact expectation picture to avoid errors in the test runner
(only a fuzzy match is expected, and different platforms render video
with slightly different colors).

platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-video-is-visible-expected.html: Added.
platform/mac/TestExpectations:

12:27 PM Changeset in webkit [250921] by dino@apple.com

2 edits in trunk/LayoutTests

REGRESSION (r250755): fast/events/ios/ipad/fast-click-not-always.html is Failing
https://bugs.webkit.org/show_bug.cgi?id=202760
<rdar://56079585>

Reviewed by Antoine Quint.

Update the preference name.

fast/events/ios/ipad/fast-click-not-always.html:

12:23 PM Changeset in webkit [250920] by aboya@igalia.com

3 edits in trunk/LayoutTests

Unreviewed minor WinCairo test gardening
https://bugs.webkit.org/show_bug.cgi?id=187762

platform/win/TestExpectations:
platform/wincairo/TestExpectations:

11:40 AM Changeset in webkit [250919] by dino@apple.com

2 edits in trunk/Tools

Provide an alternate command-line flag for timeout in run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=202758
<rdar://problem/56124032>

Reviewed by Tim Horton.

I always get the flag "--time-out-ms" wrong.
Everywhere else we use the single-word version of "timeout", including
the documentation for --time-out-ms!

Add an alternate that is just "--timeout", and update the documentation
to mention it is measured in milliseconds.

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

11:10 AM Changeset in webkit [250918] by eric.carlson@apple.com

6 edits in trunk

[ Mac WK2 ] Layout Test fast/mediastream/MediaStreamTrack-getSettings.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196400
<rdar://problem/49567579>

Reviewed by Youenn Fablet.

Source/WebCore:

No new tests, this fixes a broken test.

platform/mediastream/mac/MockRealtimeAudioSourceMac.h:
platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::MockRealtimeAudioSourceMac::reconfigure): Reconfigure buffers as well.
(WebCore::MockRealtimeAudioSourceMac::render): Call reconfigure if the buffer isn't
configured correctly.
(WebCore::MockRealtimeAudioSourceMac::settingsDidChange): Call reconfigure.

platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::MockRealtimeAudioSource): Set sample rate to default.

LayoutTests:

fast/mediastream/MediaStreamTrack-getSettings.html: Cleanup test.
platform/mac-wk2/TestExpectations: Unskip test.

10:29 AM Changeset in webkit [250917] by dino@apple.com

4 edits in trunk/LayoutTests

Layout Test webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance.html is failing since ANGLE roll
https://bugs.webkit.org/show_bug.cgi?id=201784
<rdar://problem/55358159>

Reviewed by Antoine Quint.

This test needed updating.

platform/ios/TestExpectations:
webgl/2.0.0/resources/webgl_test_files/conformance/glsl/misc/shaders-with-invariance.html:

10:26 AM Changeset in webkit [250916] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed, address Darin's post-landing comments for r250912.

The array should be const.

css/CSSDefaultStyleSheets.cpp:

10:24 AM Changeset in webkit [250915] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Clean up: Remove pre-macOS Sierra workaround for missing kVK_RightCommand
https://bugs.webkit.org/show_bug.cgi?id=202597

Reviewed by Anders Carlsson.

kVK_RightCommand has been defined in HIToolbox/Events.h since macOS Sierra. We no longer
need to maintain code to manually define it.

platform/mac/PlatformEventFactoryMac.mm:

(WebCore::keyForKeyEvent):

9:45 AM Changeset in webkit [250914] by Antti Koivisto

2 edits in trunk/Source/WebCore

[CSS Shadow Parts] Minor exportparts attribute parsing cleanups
https://bugs.webkit.org/show_bug.cgi?id=202740

Reviewed by Zalan Bujtas.

dom/ShadowRoot.cpp:

(WebCore::parsePartMapping):
(WebCore::parsePartMappingsList):

Return the map as the return value.

(WebCore::ShadowRoot::partMappings const):

9:29 AM Changeset in webkit [250913] by aestes@apple.com

4 edits in trunk/Source

[iOS] Remove redundant uses of USE(UIKIT_EDITING)
https://bugs.webkit.org/show_bug.cgi?id=202717

Reviewed by Anders Carlsson.

Source/WebCore:

page/ios/FrameIOS.mm:

(WebCore::Frame::qualifyingNodeAtViewportLocation):
(WebCore::Frame::approximateNodeAtViewportLocationLegacy):

Source/WebKitLegacy/ios:

WebCoreSupport/WebVisiblePosition.mm:

(-[DOMNode startPosition]):
(-[DOMNode endPosition]):

7:38 AM Changeset in webkit [250912] by Chris Dumez

2 edits in trunk/Source/WebCore

[iOS] REGRESSION (r250398) Layout Test fast/history/page-cache-element-state-focused.html is failing
https://bugs.webkit.org/show_bug.cgi?id=202712
<rdar://problem/56082428>

Reviewed by Antti Koivisto.

The test was failing depending on the order in which the tests were executed. The reason is that
elements would either use the full UA stylesheet (html.css) or the simple one in CSSDefaultStyleSheets.cpp.
Unfortunately, the outline-width was different on iOS between the simple stylesheet and the full one, causing
the test output to look different depending on which stylesheet was used.

Address the issue by making sure that the outline-width is 3px on IOS_FAMILY in the simple stylesheet, to
be consistent with the value in the full stylesheet (html.css).

css/CSSDefaultStyleSheets.cpp:

7:23 AM Changeset in webkit [250911] by aboya@igalia.com

6 edits
1 add in trunk/LayoutTests

[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=202751

TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt: Added.
platform/gtk/accessibility/roles-exposed-expected.txt:
platform/gtk/fast/tokenizer/script_extra_close-expected.txt:
platform/wpe/TestExpectations:

7:07 AM Changeset in webkit [250910] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][Painting] Decouple content and decoration painting
https://bugs.webkit.org/show_bug.cgi?id=202718
<rdar://problem/56104661>

Reviewed by Antti Koivisto.

This patch adds support for individual run painting <div><span style="background-color: red">red</span>black</div>.
This is pretty much all we can do with the current data structures (lack of context).

layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintBoxDecoration):
(WebCore::Display::paintInlineContent):
(WebCore::Display::Painter::paint):
(WebCore::Display::paintBlockLevelBoxDecoration): Deleted.

layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::appendInlineContainerStart):
(WebCore::Layout::Line::appendInlineContainerEnd):

4:33 AM Changeset in webkit [250909] by Adrian Perez de Castro

2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for non-unified builds.

dfg/DFGByteCodeParser.cpp: Add missing inclusion of the GetterSetter.h header.

3:25 AM Changeset in webkit [250908] by magomez@igalia.com

5 edits in trunk/LayoutTests

Unreviewed WPE gardening after r250889.

platform/wpe/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-text-expected.txt:

2:41 AM Changeset in webkit [250907] by Fujii Hironori

2 edits in trunk/Source/JavaScriptCore

[Win] error LNK2019: unresolved external symbol "public: cdecl JSC::Strong<enum JSC::Unknown>::Strong<enum JSC::Unknown>(class JSC::VM &,class JSC::JSValue)"
https://bugs.webkit.org/show_bug.cgi?id=202722

Unreviewed flaky build fix for Windows ports.

JSC::Strong is used without including "StrongInlines.h".

runtime/JSCInlines.h: Added #include "StrongInlines.h".

2:37 AM Changeset in webkit [250906] by Fujii Hironori

2 edits in trunk/Source/WebCore

Unreviewed build fix for Windows ports
https://bugs.webkit.org/show_bug.cgi?id=202630
<rdar://problem/56107907>

dom/Document.cpp(3990): error C2653: 'MediaStreamTrack': is not a class or namespace name
dom/Document.cpp(3990): error C3861: 'captureState': identifier not found

dom/Document.cpp:

(WebCore::Document::updateIsPlayingMedia): Restored #if ENABLE(MEDIA_STREAM).

2:12 AM Changeset in webkit [250905] by Antti Koivisto

2 edits in trunk/Source/WebCore

[CSS Shadow Parts] Mark as supported in features.json
https://bugs.webkit.org/show_bug.cgi?id=202730

Reviewed Ryosuke Niwa.

features.json:

1:48 AM Changeset in webkit [250904] by youenn@apple.com

10 edits
2 deletes in trunk

Remove testRunner.setWebRTCUnifiedPlanEnabled
https://bugs.webkit.org/show_bug.cgi?id=202700

Reviewed by Eric Carlson.

Source/WebKit:

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Tools:

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Remove legacy tests and migrate simulcast test to unified plan.

fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:
platform/gtk/TestExpectations:
webrtc/simulcast-h264.html:
webrtc/video-addLegacyTransceiver.html: Removed.
webrtc/video-with-receiver.html: Removed.

1:45 AM Changeset in webkit [250903] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Wayland: do not use EGL_PLATFORM_WAYLAND_KHR with eglGetPlatformDisplayEXT
https://bugs.webkit.org/show_bug.cgi?id=202689

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2019-10-09
Reviewed by Žan Doberšek.

Use EGL_PLATFORM_WAYLAND_EXT instead. It shouldn't really matter because both are the same value.

platform/graphics/wayland/PlatformDisplayWayland.cpp:

(WebCore::PlatformDisplayWayland::initialize):

1:25 AM Changeset in webkit [250902] by Antti Koivisto

6 edits in trunk

[CSS Shadow Parts] Allow exporting single part with multiple names using exportparts attribute
https://bugs.webkit.org/show_bug.cgi?id=202719

Reviewed by Ryosuke Niwa.

Source/WebCore:

Cases like exportparts="part:export1, part:export2" should work.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):

Allow one part name to expand into multiple names for matching.

dom/ShadowRoot.cpp:

(WebCore::parsePartMappingsList):

Allow multiple names per mapping.

(WebCore::ShadowRoot::partMappings const):

dom/ShadowRoot.h:

LayoutTests:

fast/css/shadow-parts/exportparts-syntax-expected.txt:

1:20 AM WebKitGTK/2.26.x edited by Philippe Normand

(diff)

1:17 AM Changeset in webkit [250901] by Philippe Normand

2 edits in trunk/Source/WebCore

REGRESSION(r246399): [GStreamer] Problems playing AAC streams
https://bugs.webkit.org/show_bug.cgi?id=202204

Reviewed by Xabier Rodriguez-Calvar.

Push the EOS event in the WebKitWebSrc element when the internal
queue is empty only for non-live resources. In the live case the
queue might drain temporarily but that's OK because data would
still be queued in downstream elements.

No new tests, the EOS event was pushed too early because of this
regression but there's no way to differentiate it from an expected
event in a layout test.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcCreate):

12:48 AM Changeset in webkit [250900] by youenn@apple.com

4 edits in trunk/Source/WebCore

MediaStreamTrack does not need to be a Document audio producer
https://bugs.webkit.org/show_bug.cgi?id=202630

Reviewed by Eric Carlson.

Instead of having all tracks being MediaProducer, we can use the new methods introduced for iOS
to mute/unmute capture tracks and get capture media state.
This allows to not register tracks that are not capture tracks.
Covered by existing tests.

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setMuted):
(WebCore::MediaStreamTrack::applyConstraints):
(WebCore::MediaStreamTrack::mediaState const):
(WebCore::MediaStreamTrack::updateCaptureAccordingToMutedState):
(WebCore::MediaStreamTrack::pageMutedStateDidChange): Deleted.

Modules/mediastream/MediaStreamTrack.h:
dom/Document.cpp:

(WebCore::Document::updateIsPlayingMedia):
(WebCore::Document::pageMutedStateDidChange):

12:42 AM Changeset in webkit [250899] by Carlos Garcia Campos

6 edits in trunk

REGRESSION(r250597): [GTK][WPE] 2.27.1 shows HTML content as text/plain in custom protocols when passing a charset in content type
https://bugs.webkit.org/show_bug.cgi?id=202633

Reviewed by Žan Doberšek.

Source/WebKit:

This is a regression of the switch to use the new custom protocols implementation. Before r250597, we extracted
the mime type and charset from content type in the network process, but we are now sending the response directly
from the UI process, so we need to do that when building our response. Rename the mime_type parameter as
content_type to avoid confusion, since it's documented as the content type.

UIProcess/API/glib/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback):
(webkit_uri_scheme_request_finish):

UIProcess/API/gtk/WebKitURISchemeRequest.h:
UIProcess/API/wpe/WebKitURISchemeRequest.h:

Tools:

Add a test case.

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(testWebContextURIScheme):

12:22 AM Changeset in webkit [250898] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

[GTK][WPE] about:gpu should also show the client EGL extensions
https://bugs.webkit.org/show_bug.cgi?id=202690

Reviewed by Carlos Alberto Lopez Perez.

We are showing the extensions supported by the display.

UIProcess/API/glib/WebKitProtocolHandler.cpp:

(WebKit::WebKitProtocolHandler::handleGPU):

12:20 AM Changeset in webkit [250897] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

CustomProtocols: convert log messages in WebURLSchemeTaskProxy to RELEASE_LOG
https://bugs.webkit.org/show_bug.cgi?id=202686

Reviewed by Alex Christensen.

Instead of using WTFLogAlways, since those messages are confusing on stdout.

WebProcess/WebPage/WebURLSchemeTaskProxy.cpp:

(WebKit::WebURLSchemeTaskProxy::didPerformRedirection):
(WebKit::WebURLSchemeTaskProxy::didReceiveResponse):
(WebKit::WebURLSchemeTaskProxy::didReceiveData):

12:19 AM Changeset in webkit [250896] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

[WPE][GTK] WebKitSecurityManager should consider webkit:// to be a local URI scheme
https://bugs.webkit.org/show_bug.cgi?id=202638

Reviewed by Michael Catanzaro.

UIProcess/API/glib/WebKitProtocolHandler.cpp:

(WebKit::WebKitProtocolHandler::WebKitProtocolHandler):

12:17 AM Changeset in webkit [250895] by Alan Coon

12 edits in branches/safari-608.3.10.0-branch

Cherry-pick r250887. rdar://problem/56105002

Partially undo r250811
https://bugs.webkit.org/show_bug.cgi?id=202715
<rdar://problem/56084287>

Reviewed by Chris Dumez.

Source/WebCore:

This patch changes the SerializedScriptValue to always wrap CryptoKey objects again.
CryptoKey objects could belong to an array or another object. In those cases, IDBObjectStore
cannot set the flag for the embedded Cryptokey objects. Neither can postMessage to unset
the flag. Therefore, there is no way to separate the serialization process into two and
this patch restores the old behaviour. However, the hardening part of r250811 is kept
and therefore the crash should still be prevented.

No new test, updated existing test

Modules/indexeddb/IDBObjectStore.cpp: (WebCore::IDBObjectStore::putOrAdd): (WebCore::JSC::setIsWrappingRequiredForCryptoKey): Deleted.
bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
crypto/CryptoKey.h: (WebCore::CryptoKey::allows const): (WebCore::CryptoKey::isWrappingRequired const): Deleted. (WebCore::CryptoKey::setIsWrappingRequired): Deleted. (): Deleted.
dom/ScriptExecutionContext.h:

Tools:

TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html: Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.

LayoutTests:

Some rebaselines.

crypto/workers/subtle/ec-postMessage-worker-expected.txt:
crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
crypto/workers/subtle/rsa-postMessage-worker-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:17 AM Changeset in webkit [250894] by Alan Coon

3 edits in branches/safari-608.3.10.0-branch/LayoutTests

Cherry-pick r250844. rdar://problem/56061124

Unreviewed, test gardening

TestExpectations:
platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:16 AM Changeset in webkit [250893] by Alan Coon

23 edits
3 adds in branches/safari-608.3.10.0-branch

Cherry-pick r250811. rdar://problem/56061124

Only wrapping CryptoKeys for IDB during serialization
https://bugs.webkit.org/show_bug.cgi?id=202500
<rdar://problem/52445927>

Reviewed by Chris Dumez.

Source/WebCore:

Wrapping CryptoKeys during IDB serialization is a legacy request from Netflix when WebKit was an
early adopter. It is not necessary for other kinds of serialization. However, given existing keys
stored in users' idb are wrapped, the wrapping/unwrapping mechanism cannot be easily discarded.
Therefore, this patch restricts the wrapping/unwrapping mechanism to idb only.

To do so, a isWrappingRequired flag is added to CryptoKey such that whenever idb sees a CryptoKey,
it can set it. SerializedScriptValue will then only wrap a CryptoKey when this flag is set. Otherwise,
a new tag UnwrappedCryptoKeyTag is used to store unwrapped CryptoKeys in order to keep the old CryptoKeyTag
binaries intact. For deserialization, each type will be deserialized differently.

Besides the above, this patch also hardens WorkerGlobalScope::wrapCryptoKey/unwrapCryptoKey for
any potential racy issues. CryptoBooleanContainer is introduced to capture boolean in the lambda.
workerGlobalScope is replaced with workerMessagingProxy. Now, every variables captured in the lambdas
should be either a copy or a thread safe ref of the original object.

Test: crypto/workers/subtle/aes-indexeddb.html

Modules/indexeddb/IDBObjectStore.cpp: (WebCore::JSC::setIsWrappingRequiredForCryptoKey): (WebCore::IDBObjectStore::putOrAdd):
bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
crypto/CryptoKey.h: (WebCore::CryptoKey::isWrappingRequired const): (WebCore::CryptoKey::setIsWrappingRequired):
dom/ScriptExecutionContext.h:
workers/WorkerGlobalScope.cpp: (WebCore::CryptoBooleanContainer::create): (WebCore::CryptoBooleanContainer::boolean const): (WebCore::CryptoBooleanContainer::setBoolean): (WebCore::WorkerGlobalScope::wrapCryptoKey): (WebCore::WorkerGlobalScope::unwrapCryptoKey):
workers/WorkerGlobalScope.h:
workers/WorkerLoaderProxy.h: (WebCore::WorkerLoaderProxy::isWorkerMessagingProxy const):
workers/WorkerMessagingProxy.h: (isType):

Tools:

Modifies IndexedDB.StructuredCloneBackwardCompatibility test to include CryptoKeys.

TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: (-[StructuredCloneBackwardCompatibilityNavigationDelegate _webCryptoMasterKeyForWebView:]): (TEST):
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html:

LayoutTests:

Adds a new test aes-indexeddb.html to do idb in workers and makes
other tests more deterministic.

crypto/workers/subtle/aes-indexeddb-expected.txt: Added.
crypto/workers/subtle/aes-indexeddb.html: Added.
crypto/workers/subtle/ec-postMessage-worker-expected.txt:
crypto/workers/subtle/ec-postMessage-worker.html:
crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
crypto/workers/subtle/hrsa-postMessage-worker.html:
crypto/workers/subtle/resources/aes-indexeddb.js: Added.
crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
crypto/workers/subtle/rsa-postMessage-worker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:01 AM Changeset in webkit [250892] by Alan Coon

12 edits in branches/safari-608.3.10.1-branch

Cherry-pick r250887. rdar://problem/56104999

Partially undo r250811
https://bugs.webkit.org/show_bug.cgi?id=202715
<rdar://problem/56084287>

Reviewed by Chris Dumez.

Source/WebCore:

This patch changes the SerializedScriptValue to always wrap CryptoKey objects again.
CryptoKey objects could belong to an array or another object. In those cases, IDBObjectStore
cannot set the flag for the embedded Cryptokey objects. Neither can postMessage to unset
the flag. Therefore, there is no way to separate the serialization process into two and
this patch restores the old behaviour. However, the hardening part of r250811 is kept
and therefore the crash should still be prevented.

No new test, updated existing test

Modules/indexeddb/IDBObjectStore.cpp: (WebCore::IDBObjectStore::putOrAdd): (WebCore::JSC::setIsWrappingRequiredForCryptoKey): Deleted.
bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
crypto/CryptoKey.h: (WebCore::CryptoKey::allows const): (WebCore::CryptoKey::isWrappingRequired const): Deleted. (WebCore::CryptoKey::setIsWrappingRequired): Deleted. (): Deleted.
dom/ScriptExecutionContext.h:

Tools:

TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html: Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.

LayoutTests:

Some rebaselines.

crypto/workers/subtle/ec-postMessage-worker-expected.txt:
crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
crypto/workers/subtle/rsa-postMessage-worker-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:01 AM Changeset in webkit [250891] by Alan Coon

3 edits in branches/safari-608.3.10.1-branch/LayoutTests

Cherry-pick r250844. rdar://problem/56075033

Unreviewed, test gardening

TestExpectations:
platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:01 AM Changeset in webkit [250890] by Alan Coon

23 edits
3 adds in branches/safari-608.3.10.1-branch

Cherry-pick r250811. rdar://problem/56075033

Only wrapping CryptoKeys for IDB during serialization
https://bugs.webkit.org/show_bug.cgi?id=202500
<rdar://problem/52445927>

Reviewed by Chris Dumez.

Source/WebCore:

Wrapping CryptoKeys during IDB serialization is a legacy request from Netflix when WebKit was an
early adopter. It is not necessary for other kinds of serialization. However, given existing keys
stored in users' idb are wrapped, the wrapping/unwrapping mechanism cannot be easily discarded.
Therefore, this patch restricts the wrapping/unwrapping mechanism to idb only.

To do so, a isWrappingRequired flag is added to CryptoKey such that whenever idb sees a CryptoKey,
it can set it. SerializedScriptValue will then only wrap a CryptoKey when this flag is set. Otherwise,
a new tag UnwrappedCryptoKeyTag is used to store unwrapped CryptoKeys in order to keep the old CryptoKeyTag
binaries intact. For deserialization, each type will be deserialized differently.

Besides the above, this patch also hardens WorkerGlobalScope::wrapCryptoKey/unwrapCryptoKey for
any potential racy issues. CryptoBooleanContainer is introduced to capture boolean in the lambda.
workerGlobalScope is replaced with workerMessagingProxy. Now, every variables captured in the lambdas
should be either a copy or a thread safe ref of the original object.

Test: crypto/workers/subtle/aes-indexeddb.html

Modules/indexeddb/IDBObjectStore.cpp: (WebCore::JSC::setIsWrappingRequiredForCryptoKey): (WebCore::IDBObjectStore::putOrAdd):
bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
crypto/CryptoKey.h: (WebCore::CryptoKey::isWrappingRequired const): (WebCore::CryptoKey::setIsWrappingRequired):
dom/ScriptExecutionContext.h:
workers/WorkerGlobalScope.cpp: (WebCore::CryptoBooleanContainer::create): (WebCore::CryptoBooleanContainer::boolean const): (WebCore::CryptoBooleanContainer::setBoolean): (WebCore::WorkerGlobalScope::wrapCryptoKey): (WebCore::WorkerGlobalScope::unwrapCryptoKey):
workers/WorkerGlobalScope.h:
workers/WorkerLoaderProxy.h: (WebCore::WorkerLoaderProxy::isWorkerMessagingProxy const):
workers/WorkerMessagingProxy.h: (isType):

Tools:

Modifies IndexedDB.StructuredCloneBackwardCompatibility test to include CryptoKeys.

TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: (-[StructuredCloneBackwardCompatibilityNavigationDelegate _webCryptoMasterKeyForWebView:]): (TEST):
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html:

LayoutTests:

Adds a new test aes-indexeddb.html to do idb in workers and makes
other tests more deterministic.

crypto/workers/subtle/aes-indexeddb-expected.txt: Added.
crypto/workers/subtle/aes-indexeddb.html: Added.
crypto/workers/subtle/ec-postMessage-worker-expected.txt:
crypto/workers/subtle/ec-postMessage-worker.html:
crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
crypto/workers/subtle/hrsa-postMessage-worker.html:
crypto/workers/subtle/resources/aes-indexeddb.js: Added.
crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
crypto/workers/subtle/rsa-postMessage-worker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Oct 8, 2019:

11:39 PM Changeset in webkit [250889] by Antti Koivisto

6 edits in trunk/Source

[CSS Shadow Parts] Enable by default
https://bugs.webkit.org/show_bug.cgi?id=202644

Reviewed by Ryosuke Niwa.

Source/WebCore:

Flip the switch.

page/RuntimeEnabledFeatures.h:

Source/WebKit:

Shared/WebPreferences.yaml:

Flip the switch.

Source/WebKitLegacy/mac:

WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

11:36 PM Changeset in webkit [250888] by Alan Coon

7 edits in branches/safari-608.3.10.1-branch/Source

Versioning.

9:15 PM Changeset in webkit [250887] by jiewen_tan@apple.com

12 edits in trunk

Partially undo r250811
https://bugs.webkit.org/show_bug.cgi?id=202715
<rdar://problem/56084287>

Reviewed by Chris Dumez.

Source/WebCore:

No new test, updated existing test

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::putOrAdd):
(WebCore::JSC::setIsWrappingRequiredForCryptoKey): Deleted.

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readTerminal):

crypto/CryptoKey.h:

(WebCore::CryptoKey::allows const):
(WebCore::CryptoKey::isWrappingRequired const): Deleted.
(WebCore::CryptoKey::setIsWrappingRequired): Deleted.
(): Deleted.

dom/ScriptExecutionContext.h:

Tools:

TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:

Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.

LayoutTests:

Some rebaselines.

crypto/workers/subtle/ec-postMessage-worker-expected.txt:
crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
crypto/workers/subtle/rsa-postMessage-worker-expected.txt:

8:50 PM Changeset in webkit [250886] by ysuzuki@apple.com

3 edits in trunk/Source/JavaScriptCore

[JSC] FTL vmCall should check # of arguments
https://bugs.webkit.org/show_bug.cgi?id=202683

Reviewed by Saam Barati.

This patch inserts static_assert for # of arguments when using FTL vmCall.
It turned out that such check is useful when converting ExecState* to JSGlobalObject*.
Like, first, adding JSGlobalObject* parameter, making it compiled and removing ExecState* and m_callFrame parameter later.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileToObjectOrCallObjectConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileToThis):
(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMul):
(JSC::FTL::DFG::LowerDFGToB3::compileStrCat):
(JSC::FTL::DFG::LowerDFGToB3::compileArithClz32):
(JSC::FTL::DFG::LowerDFGToB3::compileValueDiv):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMod):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAbs):
(JSC::FTL::DFG::LowerDFGToB3::compileArithUnary):
(JSC::FTL::DFG::LowerDFGToB3::compileValuePow):
(JSC::FTL::DFG::LowerDFGToB3::compileArithRound):
(JSC::FTL::DFG::LowerDFGToB3::compileArithFloor):
(JSC::FTL::DFG::LowerDFGToB3::compileArithCeil):
(JSC::FTL::DFG::LowerDFGToB3::compileArithTrunc):
(JSC::FTL::DFG::LowerDFGToB3::compileArithSqrt):
(JSC::FTL::DFG::LowerDFGToB3::compileArithFRound):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitAnd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitOr):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitXor):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitRShift):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitLShift):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayify):
(JSC::FTL::DFG::LowerDFGToB3::compileGetById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsIsLockFree):
(JSC::FTL::DFG::LowerDFGToB3::compileDefineDataProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileDefineAccessorProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileGetIndexedPropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPrototypeOf):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutGetterSetterById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteById):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPush):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPop):
(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateScopedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateRest):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectKeys):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectCreate):
(JSC::FTL::DFG::LowerDFGToB3::compileNewPromise):
(JSC::FTL::DFG::LowerDFGToB3::compileNewInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileNewSymbol):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArray):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateThis):
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf):
(JSC::FTL::DFG::LowerDFGToB3::compileToPrimitive):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToB3::compileStringFromCharCode):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compileSameValue):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileSwitch):
(JSC::FTL::DFG::LowerDFGToB3::compileThrow):
(JSC::FTL::DFG::LowerDFGToB3::compileThrowStaticError):
(JSC::FTL::DFG::LowerDFGToB3::mapHashString):
(JSC::FTL::DFG::LowerDFGToB3::compileMapHash):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket):
(JSC::FTL::DFG::LowerDFGToB3::compileSetAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileMapSet):
(JSC::FTL::DFG::LowerDFGToB3::compileWeakSetAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileWeakMapSet):
(JSC::FTL::DFG::LowerDFGToB3::compileInByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileHasOwnProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileParseInt):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOfCustom):
(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileHasGenericProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileHasStructureProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDirectPname):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPropertyEnumerator):
(JSC::FTL::DFG::LowerDFGToB3::compileToIndexString):
(JSC::FTL::DFG::LowerDFGToB3::compileRegExpExec):
(JSC::FTL::DFG::LowerDFGToB3::compileRegExpExecNonGlobalOrSticky):
(JSC::FTL::DFG::LowerDFGToB3::compileRegExpMatchFastGlobal):
(JSC::FTL::DFG::LowerDFGToB3::compileRegExpTest):
(JSC::FTL::DFG::LowerDFGToB3::compileRegExpMatchFast):
(JSC::FTL::DFG::LowerDFGToB3::compileSetFunctionName):
(JSC::FTL::DFG::LowerDFGToB3::compileStringReplace):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::reallocatePropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::compare):
(JSC::FTL::DFG::LowerDFGToB3::compileStringSlice):
(JSC::FTL::DFG::LowerDFGToB3::compileToLowerCase):
(JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithRadix):
(JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithValidRadixConstant):
(JSC::FTL::DFG::LowerDFGToB3::compileResolveScopeForHoistingFuncDeclInEval):
(JSC::FTL::DFG::LowerDFGToB3::compileResolveScope):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compilePutDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOM):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter):
(JSC::FTL::DFG::LowerDFGToB3::nonSpeculativeCompare):
(JSC::FTL::DFG::LowerDFGToB3::stringsEqual):
(JSC::FTL::DFG::LowerDFGToB3::ensureShadowChickenPacket):
(JSC::FTL::DFG::LowerDFGToB3::contiguousPutByValOutOfBounds):
(JSC::FTL::DFG::LowerDFGToB3::switchStringSlow):
(JSC::FTL::DFG::LowerDFGToB3::emitStoreBarrier):
(JSC::FTL::DFG::LowerDFGToB3::vmCall):

ftl/FTLOutput.h:

(JSC::FTL::Output::callWithoutSideEffects):

8:31 PM Changeset in webkit [250885] by Justin Fan

3 edits in trunk/LayoutTests

WebGPU tests are skipped on iOS
https://bugs.webkit.org/show_bug.cgi?id=192889

Unreviewed test expectation updates.

Unskip WebGPU tests on iOS devices while skipping on simulator.

platform/ios-simulator/TestExpectations:
platform/ios/TestExpectations:

7:12 PM Changeset in webkit [250884] by mmaxfield@apple.com

4 edits in trunk/LayoutTests

Make fast/text/complex-initial-advance.html more robust
https://bugs.webkit.org/show_bug.cgi?id=202708
<rdar://problem/49539493>

Reviewed by Tim Horton.

We are hitting floating point precision issues. Fortunately, the part of the text that is
hitting these issues isn't actually necessary for the test.

fast/text/complex-initial-advance-expected.html:
fast/text/complex-initial-advance.html:
platform/mac/TestExpectations:

6:54 PM Changeset in webkit [250883] by ysuzuki@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, roll out r250848
https://bugs.webkit.org/show_bug.cgi?id=202683

Causing JSTests failures.

ftl/FTLLowerDFGToB3.cpp:

6:03 PM Changeset in webkit [250882] by Alan Coon

1 copy in tags/Safari-608.3.10.0.1

Tag Safari-608.3.10.0.1.

6:02 PM Changeset in webkit [250881] by Alan Coon

1 delete in tags/Safari-608.3.10.0.1

Delete tag.

5:52 PM Changeset in webkit [250880] by Alan Coon

6 edits in branches/safari-608.3.10.0-branch/Source/WebKit

Revert "Cherry-pick r250755. rdar://problem/56061130"

This reverts commit r250829.

5:52 PM Changeset in webkit [250879] by Alan Coon

11 edits in branches/safari-608.3.10.0-branch/Source/WebKit

Revert "Cherry-pick r250780. rdar://problem/56061130"

This reverts commit r250830.

5:25 PM Changeset in webkit [250878] by ysuzuki@apple.com

11 edits
1 add in trunk

[JSC] GetterSetter should be JSCell, not JSObject
https://bugs.webkit.org/show_bug.cgi?id=202656

Reviewed by Tadeu Zagallo and Saam Barati.

JSTests:

stress/getter-setter-should-be-cell.js: Added.

(foo.with.):
(foo.with.get for):
(foo.with.bar):
(foo):

Source/JavaScriptCore:

Essentially, GetterSetter is not a JSObject. It is like a JSCell. But we made GetterSetter JSObject
to leverage existing strict-eq implementations for JSObject: pointer-comparison. But given the following
conditions,

GetterSetter strict-eq comparison only happens in builtin code when using @tryGetById.
RHS of that comparison is always folded into constant in DFG.
We already use pointer-comparison for cells that are neither JSString nor JSBigInt.
DFG strength reduction already has a rule which makes CompareStrictEq(Cell-not-JSString/JSBigInt, Constant) ComparePtrEq.

So we already support non-JSString/JSBigInt cell comparison in JSC JS code. We should use it instead of making GetterSetter JSObject.
This patch makes GetterSetter JSCell, and makes getterSetterStructure per-VM structure.

The attached test reported AI validation failure. AI assumed that GetterSetter's realm should be the same to the base object. But
this is incorrect in our runtime code: we are creating GetterSetter with lexical realm (JSGlobalObject). But the fundamental problem
is that GetterSetter is JSObject and tied to JSGlobalObject while it is not necessary.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGFixupPhase.cpp:
runtime/GetterSetter.cpp:
runtime/GetterSetter.h:
runtime/JSGlobalObject.cpp:

(JSC::getGetterById):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::regExpProtoGlobalGetter const):
(JSC::JSGlobalObject::regExpProtoUnicodeGetter const):
(JSC::JSGlobalObject::customGetterSetterFunctionStructure const):
(JSC::JSGlobalObject::getterSetterStructure const): Deleted.

runtime/JSType.h:
runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

4:38 PM Changeset in webkit [250877] by Jonathan Bedard

3 edits in trunk/Tools

REGRESSION (r250375): [old EWS] JSC EWS is always marking Patches as success
https://bugs.webkit.org/show_bug.cgi?id=202419

Rubber-stamped by Aakash Jain.

Scripts/webkitpy/common/system/executive.py:

(Executive._run_command_with_teed_output): Return exit code.

Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_run_command_with_bad_command): Test that exceptions are raised
For non-zero exit codes.

4:23 PM Changeset in webkit [250876] by aestes@apple.com

19 edits
2 moves in trunk/Source/WebKit

[iOS] Add a fast path that avoids hit testing during context menu interactions on elements
https://bugs.webkit.org/show_bug.cgi?id=202510
<rdar://problem/55939313>

Reviewed by Tim Horton.

When computing position information for an element, we can store sufficient context
information in InteractionInformationAtPosition such that the same element could be
retrieved again without hit testing. The existing TextInputContext can already store an
element's page identifier, document identifier, and element identifier, which is sufficient
context for such a task.

This patch renames TextInputContext to ElementContext and uses it when populating new
InteractionInformationAtPosition structs in elementPositionInformation(). When a context
menu interaction occurs, WebPage::startInteractionWithElementContextOrPosition() uses this
context to look up the interaction element by its identifier triplet, falling back to hit
testing if this lookup fails.

Scripts/webkit/messages.py:
Shared/DocumentEditingContext.h:
Shared/DocumentEditingContext.mm:

(IPC::ArgumentCoder<WebKit::DocumentEditingContextRequest>::decode):

Shared/ElementContext.cpp: Renamed from Source/WebKit/Shared/TextInputContext.cpp.

(IPC::ArgumentCoder<WebKit::ElementContext>::encode):
(IPC::ArgumentCoder<WebKit::ElementContext>::decode):

Shared/ElementContext.h: Renamed from Source/WebKit/Shared/TextInputContext.h.

(WebKit::operator==):

Shared/ios/InteractionInformationAtPosition.h:
Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

Sources.txt:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _requestTextInputContextsInRect:completionHandler:]):

UIProcess/API/Cocoa/_WKTextInputContext.mm:

(-[_WKTextInputContext _initWithTextInputContext:]):
(-[_WKTextInputContext _textInputContext]):

UIProcess/API/Cocoa/_WKTextInputContextInternal.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::textInputContextsInRect):
(WebKit::WebPageProxy::focusTextInputContext):

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView actionSheetAssistant:willStartInteractionWithElement:]):
(-[WKContentView assignLegacyDataForContextMenuInteraction]):
(-[WKContentView continueContextMenuInteraction:]):
(-[WKContentView continueContextMenuInteractionWithDataDetectors:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::startInteractionWithPositionInformation):
(WebKit::WebPageProxy::startInteractionWithElementAtPosition): Deleted.

WebKit.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::textInputContextsInRect):
(WebKit::WebPage::focusTextInputContext):
(WebKit::WebPage::elementForContext const):
(WebKit::WebPage::contextForElement const):
(WebKit::WebPage::elementForTextInputContext): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::elementPositionInformation):
(WebKit::WebPage::startInteractionWithElementContextOrPosition):
(WebKit::WebPage::requestDocumentEditingContext):
(WebKit::WebPage::startInteractionWithElementAtPosition): Deleted.

4:19 PM Changeset in webkit [250875] by Alan Coon

1 copy in tags/Safari-608.3.10.0.1

Tag Safari-608.3.10.0.1.

4:15 PM Changeset in webkit [250874] by Devin Rousso

27 edits
2 adds in trunk

Web Inspector: Canvas: modifications to shader modules can be shared between vertex/fragment shaders
https://bugs.webkit.org/show_bug.cgi?id=202031

Reviewed by Dean Jackson.

Source/JavaScriptCore:

inspector/protocol/Canvas.json:

Create a distinct ShaderProgram type so that additional data can be bundled and sent to
the frontend as part of the programCreated event without having to worry about having too
many arguments.

Source/WebCore:

Test: inspector/canvas/updateShader-webgpu-sharedVertexFragment.html

Modules/webgpu/WebGPUPipeline.h:
Modules/webgpu/WebGPUComputePipeline.cpp:

(WebCore::WebGPUComputePipeline::cloneShaderModules): Added.
(WebCore::WebGPUComputePipeline::recompile):

Modules/webgpu/WebGPURenderPipeline.cpp:

(WebCore::WebGPURenderPipeline::cloneShaderModules): Added.
(WebCore::WebGPURenderPipeline::recompile):
Recreate the vertex/fragment/compute shader module(s) when recompiling so that modifications
to it via this pipeline don't affect other pipelines that also use the same shader module.

inspector/InspectorShaderProgram.h:
inspector/InspectorShaderProgram.cpp:

(WebCore::InspectorShaderProgram::updateShader):
(WebCore::InspectorShaderProgram::buildObjectForShaderProgram): Added.

inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didCreateWebGLProgram):
(WebCore::InspectorCanvasAgent::didCreateWebGPUPipeline):
Include as part of the Canvas.event.programCreated payload a flag indicating whether the
vertex shader module and fragment shader module are the same for WebGPURenderPipelines.

Source/WebInspectorUI:

If the vertex and fragment shaders share the same source module for a WebGPU shader pipeline,
only display a single editable content view for that shader pipeline in the Canvas Tab.

UserInterface/Models/ShaderProgram.js:

(WI.ShaderProgram):
(WI.ShaderProgram.prototype.get sharesVertexFragmentShader): Added.

UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.programCreated):

UserInterface/Protocol/CanvasObserver.js:

(WI.CanvasObserver.prototype.programCreated):

UserInterface/Views/ShaderProgramContentView.js:

(WI.ShaderProgramContentView):
(WI.ShaderProgramContentView.prototype.shown):
(WI.ShaderProgramContentView.prototype.hidden):
(WI.ShaderProgramContentView.prototype._refreshContent):

UserInterface/Views/ShaderProgramContentView.css:

(.content-view.shader-program > .shader.compute, .content-view.shader-program > .shader.vertex.shares-vertex-fragment-shader): Added.
(body[dir=ltr] .content-view.shader-program > .shader.vertex:not(.shares-vertex-fragment-shader), body[dir=rtl] .content-view.shader-program > .shader.fragment): Added.
(body[dir=ltr] .content-view.shader-program > .shader.fragment, body[dir=rtl] .content-view.shader-program > .shader.vertex:not(.shares-vertex-fragment-shader)): Added.
(.content-view.shader-program > .shader.compute): Deleted.
(body[dir=ltr] .content-view.shader-program > .shader.vertex, body[dir=rtl] .content-view.shader-program > .shader.fragment): Deleted.
(body[dir=ltr] .content-view.shader-program > .shader.fragment, body[dir=rtl] .content-view.shader-program > .shader.vertex): Deleted.

UserInterface/Views/CodeMirrorAdditions.js:

Replace the vertex/fragment specific MIME types with a more general "render" MIME type.

Localizations/en.lproj/localizedStrings.js:

LayoutTests:

inspector/canvas/updateShader-webgpu-sharedVertexFragment.html: Added.
inspector/canvas/updateShader-webgpu-sharedVertexFragment-expected.txt: Added.

platform/gtk/TestExpectations:
platform/ios/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:
platform/wpe/TestExpectations:

4:05 PM Changeset in webkit [250873] by Alan Coon

1 copy in tags/Safari-608.3.10.1.2

Tag Safari-608.3.10.1.2.

4:03 PM Changeset in webkit [250872] by yurys@chromium.org

5 edits in trunk/LayoutTests

Web Inspector: inspector/layers/layers-for-node.html and inspector/timeline/line-column.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=202649

Reviewed by Devin Rousso.

Unflake a couple of inspector protocol tests. r250655 replaced Timer-based queue
with RunLoop-based one for inspector message dispatching. The tests apparently relied
on the timing of the message delivery and had been less flaky before. Updated the tests
to wait for explicit signals rather than relying on event timing.

inspector/layers/layers-for-node-expected.txt:
inspector/layers/layers-for-node.html: Updated the test to wait for the first

LayerTree.layerTreeDidChange event before requesting initial layer tree.

Also after adding a node wait for next RAF to avoid flakiness.

inspector/timeline/line-column-expected.txt:
inspector/timeline/line-column.html: There a style recalc event

which appears intermittently in the recorded profile making the test
flaky. To avoid that dump only events that are always present.

4:01 PM Changeset in webkit [250871] by Adrian Perez de Castro

1 copy in releases/WPE WebKit/webkit-2.27.1

WPE WebKit 2.27.1

4:00 PM Changeset in webkit [250870] by Adrian Perez de Castro

4 edits in trunk

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.1 release

Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

wpe/NEWS: Add release notes for 2.27.1

3:30 PM Changeset in webkit [250869] by Jonathan Bedard

5 edits in trunk/Tools

Python 3: Add support to auto-importer
https://bugs.webkit.org/show_bug.cgi?id=201955

Reviewed by Aakash Jain.

Scripts/test-webkitpy-python3: Auto-install everything.
Scripts/webkitpy/common/system/autoinstall.py: Import urlopen and urlparse for Python3.
Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Update function definition for Python3.
(AutoinstallImportHook._install_mechanize): Use Python 2/3 compatible version of mechanize.
(AutoinstallImportHook._install_requests): Update urllib3 and requests version.
(AutoinstallImportHook._install_coverage): Use Python 2/3 compatible version of coverage.
(AutoinstallImportHook.greater_than_equal_to_version): Use range instead of xrange.
(AutoinstallImportHook._install_selenium): Update urllib3 version.
(AutoinstallImportHook.install_chromedriver):
(AutoinstallImportHook.install_geckodriver):
(AutoinstallImportHook.get_latest_pypi_url):
(AutoinstallImportHook.install_binary):

Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest):
(ThirdpartyTest.test_import_hook): Deleted.

3:19 PM Changeset in webkit [250868] by yurys@chromium.org

2 edits in trunk/Tools

Restore my committer status.

Uneviewed.

Scripts/webkitpy/common/config/contributors.json:

3:16 PM Changeset in webkit [250867] by rmorisset@apple.com

2 edits in trunk/Source/WTF

dataLogIf should be ALWAYS_INLINE
https://bugs.webkit.org/show_bug.cgi?id=202703

Reviewed by Saam Barati.

We often have the following pattern:
`
static constexpr bool verbose = false;
...
dataLogLnIf(verbose, "Something is happening");
`
To make sure that these are always properly eliminated I'd like to make dataLogIf/dataLogLnIf ALWAYS_INLINE.

We may as well mark the branch as UNLIKELY too, for the cases where the condition comes from Options::verboseSomething() and is only known at runtime.

wtf/DataLog.h:

(WTF::dataLogIf):
(WTF::dataLogLnIf):

3:13 PM Changeset in webkit [250866] by commit-queue@webkit.org

17 edits
4 adds in trunk

Implement Telemetry and Dumping Routines for SQLite backend (195088)
https://bugs.webkit.org/show_bug.cgi?id=195088
<rdar://problem/54213407>

Patch by Kate Cheney <Kate Cheney> on 2019-10-08
Reviewed by John Wilander.

Source/WebKit:

Implemented database telemetry calculating for ITP. Mimicked
ResourceLoadStatisticsMemoryStore telemetry logging behavior using
SQLite Queries as opposed to vector sorting/manipulation. Once fully
integrated, this will simplify analysis of ITP data by transitioning
ITP data storage from a plist to a SQLite database.

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore):
Added SQL queries to be initialized in the constructor. These queries
are needed to mimic the telemetry calculations done in
ResourceLoadStatisticsMemoryStore.

(WebKit::resetStatement):
To reduce code duplication, this function holds common code to reset
a SQL query.

(WebKit::ResourceLoadStatisticsDatabaseStore::prepareStatements):
Added SQL queries needed for telemetry calculations to be prepared.

(WebKit::joinSubStatisticsForSorting):
This function returns the query string for sorting resources that is
shared by many queries.

(WebKit::ResourceLoadStatisticsDatabaseStore::getMedianOfPrevalentResourcesWithUserInteraction const):
Implemented a function to take the median days since user interaction
from all prevalent resources in the database with user interaction
(sorted by max count of subframes, subresources and unique redirects under
the top frame domain).

(WebKit::ResourceLoadStatisticsDatabaseStore::getNumberOfPrevalentResources const):
Executes a SQL query to get the number of prevalent resources to log as
telemetry.

(WebKit::ResourceLoadStatisticsDatabaseStore::getNumberOfPrevalentResourcesWithUI const):
Executes a SQL query to get the number of prevalent resources with user
interaction to log as telemetry.

(WebKit::ResourceLoadStatisticsDatabaseStore::getTopPrevelentResourceDaysSinceUI const):
Prepares and executes a SQL query to get the days since user
interaction from the top prevalent resource to be recorded as
telemetry data.

(WebKit::ResourceLoadStatisticsDatabaseStore::getMedianStatisticOfPrevalentResourceWithoutUserInteraction const):
Implemented a function which takes a statistic and returns the value
of that statistic for the median prevalent resource without user
interaction to be recorded as telemetry data.

(WebKit::ResourceLoadStatisticsDatabaseStore::getNumberOfPrevalentResourcesInTopResources const):
Returns the count of prevalent resources in the top x resources
sorted by sum of substatistics again to be logged as telemetry.

(WebKit::ResourceLoadStatisticsDatabaseStore::calculateTelemetryData const):
Function which executes all functions which populate the struct with
telemetry data. This struct will then be passed to
WebResourceLoadStatisticsTelemetry to be logged.

(WebKit::ResourceLoadStatisticsDatabaseStore::calculateAndSubmitTelemetry const):
Initializes the telemetry struct and calls the function to populate
it, then passes it to the WebResourceLoadStatisticsTelemetry object
to be recorded.

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:

Describe PrevalentResourceDatabaseTelemetry Struct to be passed and
logged as telemetry data.

NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::databaseSubmitTopLists):
Logging telemetry data by looping through 2D array of statistics for
the top 1, 3, 10, 50, and 100 prevalent resources sorted by the sum
of substatistics under the top frame domain. This matches the logging
already done in ResourceLoadStatisticsMemoryStore.

(WebKit::WebResourceLoadStatisticsTelemetry::submitTelemetry):
Submits data to the webPageProxy logs and plists.

NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.h:

Added new submitTopList function to accomodate database telemetry
logging.

NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::notifyPageStatisticsTelemetryFinished):

NetworkProcess/NetworkSession.h:
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::notifyResourceLoadStatisticsTelemetryFinished):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:

Updated the current testing for telemetry which only tested 3
statistics. With this patch it now tests 10 statistics.

Tools:

Updated the current testing for telemetry which only tested 3
statistics. With this patch it now tests 10 statistics.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::statisticsDidRunTelemetryCallback):

WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Updated the current testing for telemetry which only tested 3
statistics. With this patch it now tests 10 statistics.

http/tests/resourceLoadStatistics/telemetry-generation-advanced-functionality-database-expected.txt: Added.
http/tests/resourceLoadStatistics/telemetry-generation-advanced-functionality-database.html: Added.
http/tests/resourceLoadStatistics/telemetry-generation-basic-functionality-database-expected.txt: Added.
http/tests/resourceLoadStatistics/telemetry-generation-basic-functionality-database.html: Added.

3:00 PM Changeset in webkit [250865] by Alan Coon

23 edits
3 deletes in branches/safari-608.3.10.1-branch

Revert "Cherry-pick r250811. rdar://problem/56075033"

This reverts commit r250834.

3:00 PM Changeset in webkit [250864] by Alan Coon

23 edits
3 deletes in branches/safari-608.3.10.0-branch

Revert "Cherry-pick r250811. rdar://problem/56061124"

This reverts commit r250835.

2:56 PM Changeset in webkit [250863] by timothy@apple.com

4 edits
1 add in trunk

Copying white text from dark mode WebKit apps and pasting in a light mode app results in white (invisible) text.
https://bugs.webkit.org/show_bug.cgi?id=202662
rdar://problem/48677354

Reviewed by Megan Gardner.

Source/WebCore:

Covered by new API tests.

HTMLConverter needs to strip white text colors when the document is in dark mode, like it does for black in light mode.

editing/cocoa/HTMLConverter.mm:

(normalizedColor): Handle dark mode and ignore white.
(HTMLConverterCaches::colorPropertyValueForNode): Pass element to normalizedColor.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm: Added.

(readRTFDataFromPasteboard):
(copyAttributedStringFromHTML):
(checkColor):
(TEST):

2:53 PM WebKitGTK/2.26.x edited by Adrian Perez de Castro

(diff)

2:40 PM Changeset in webkit [250862] by Antti Koivisto

1 edit
2 adds in trunk/LayoutTests

[CSS Shadow Parts] Add test for exportparts list syntax
https://bugs.webkit.org/show_bug.cgi?id=202695

Reviewed by Ryosuke Niwa.

The test shows that we don't handle exporting same part under multiple names correctly.

fast/css/shadow-parts/exportparts-syntax-expected.txt: Added.
fast/css/shadow-parts/exportparts-syntax.html: Added.

2:40 PM Changeset in webkit [250861] by Antti Koivisto

4 edits
2 adds in trunk

[CSS Shadow Parts] Fix style invalidation with class selector and ::before and ::after
https://bugs.webkit.org/show_bug.cgi?id=202694

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/css/shadow-parts/invalidation-class-before-after.html

style/StyleInvalidator.cpp:

(WebCore::Style::Invalidator::invalidateIfNeeded):
(WebCore::Style::Invalidator::invalidateStyleWithMatchElement):

Invalidate in the shadow tree if the computed match element is host.

(WebCore::Style::Invalidator::invalidateInShadowTreeIfNeeded):

Factor into a function.

style/StyleInvalidator.h:

LayoutTests:

fast/css/shadow-parts/invalidation-class-before-after-expected.txt: Added.
fast/css/shadow-parts/invalidation-class-before-after.html: Added.

2:23 PM Changeset in webkit [250860] by commit-queue@webkit.org

4 edits
6 adds in trunk

JSON.parse incorrectly handles array proxies
https://bugs.webkit.org/show_bug.cgi?id=199292

Patch by Alexey Shvayka <Alexey Shvayka> on 2019-10-08
Reviewed by Saam Barati.

JSTests:

microbenchmarks/json-parse-array-reviver-same-value.js: Added.
microbenchmarks/json-parse-array-reviver.js: Added.
microbenchmarks/json-parse-object-reviver-same-value.js: Added.
microbenchmarks/json-parse-object-reviver.js: Added.
stress/json-parse-reviver-array-proxy.js: Added.
stress/json-parse-reviver-revoked-proxy.js: Added.
test262/expectations.yaml: Mark 6 test cases as passing.

Source/JavaScriptCore:

Use isArray to correctly detect proxied arrays.
Make "length" lookup observable to array proxies and handle exceptions.

runtime/JSONObject.cpp:

(JSC::Walker::walk):

2:09 PM Changeset in webkit [250859] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: make it more obvious that the cards in the overview are clickable
https://bugs.webkit.org/show_bug.cgi?id=202680

Reviewed by Matt Baker.

Add a slight darkening (or lightening when in dark mode) of the background behind the
content preview in the overview.

UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview .content-view.canvas):
(.content-view.canvas-overview .content-view.canvas, .content-view.canvas-overview .content-view.canvas > .preview > img): Added.
(.content-view.canvas-overview .content-view.canvas.recording-active > .progress-view, .content-view.canvas-overview .content-view.canvas > .preview):
(.content-view.canvas-overview .content-view.canvas.recording-active > .progress-view:hover, .content-view.canvas-overview .content-view.canvas > .preview:hover): Added.
(@media (prefers-color-scheme: dark) .content-view.canvas-overview .content-view.canvas, .content-view.canvas-overview .content-view.canvas > .preview > img): Added.
(@media (prefers-color-scheme: dark) .content-view.canvas-overview .content-view.canvas.recording-active > .progress-view:hover, .content-view.canvas-overview .content-view.canvas > .preview:hover): Added.

1:49 PM Changeset in webkit [250858] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: don't show an empty preview for WebGPU devices
https://bugs.webkit.org/show_bug.cgi?id=202679

Reviewed by Matt Baker.

HTMLCanvasElement.prototype.toDataURL hasn't been hooked up for GPUCanvasContext yet, so
calling Canvas.requestContent with a WebGPUDevice won't give us any good results.

As such, the Web Inspector frontend should show something slightly more actionable, such as
a more generic non-error "No Preview Available" message.

UserInterface/Models/Canvas.js:

(WI.Canvas.supportsRequestContentForContextType): Added.
(WI.Canvas.prototype.requestContent):

UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype._showError):

1:39 PM Changeset in webkit [250857] by Adrian Perez de Castro

17 edits in trunk/Source

[GTK][WPE] Fix non-unified builds after r250486
https://bugs.webkit.org/show_bug.cgi?id=202636

Reviewed by Youenn Fablet.

Source/JavaScriptCore:

runtime/JSLock.h: Add missing inclusion of wtf/ForbidHeapAllocation.h
wasm/WasmSignature.cpp: Add missing inclusions of wtf/CommaPrinter.h and

wtf/StringPrintStream.h (needed by debug builds).

wasm/WasmStreamingParser.cpp: Add missing inclusion of WasmSignatureInlines.h to

avoid missing symbols during linking.

Source/WebCore:

No new tests needed.

Modules/fetch/FetchLoader.h: Add missing forward declaration of WebCore::SharedBuffer.
Modules/indexeddb/shared/IDBGetAllRecordsData.cpp: Add missing inclusion of header

wtf/text/StringConcatenateNumbers.h

Modules/indexeddb/shared/IDBIterateCursorData.cpp: Ditto.
animation/DocumentTimeline.cpp: Add missing inclusion of the EventNames.h and

JavaScriptCore/VM.h headers.

bindings/js/JSDOMWindowCustom.cpp: Add missing inclusion of the JSDOMConvertCallbacks.h

header.

bindings/js/JSIDBRequestCustom.cpp: Add missing inclusion of the JSDOMConvertIndexedDB.h

and JSDOMConvertSequences.h headers.

bindings/js/JSRemoteDOMWindowCustom.cpp: Add missing inclusion of the

JSDOMExceptionHandling.h header.

bindings/js/ScriptController.cpp: Add missing inclusion of the

JavaScriptCore/WeakGCMapInlines.h header to avoid missing symbols during linking.

bindings/js/ScriptModuleLoader.h: Add missing inclusion of the wtf/HashSet.h header

and add a forward declaration for the JSC::JSModuleRecord type.

bindings/js/WindowProxy.cpp: Add missing inclusion of the JavaScriptCore/StrongInlines.h

header to avoid missing symbols during linking.

css/FontFaceSet.cpp: Add missing inclusion of the DOMPromiseProxy.h header.
css/FontFaceSet.h: Add missing inclusion of the IDLTypes.h header.
dom/IdleDeadline.h: Add missing inclusion of the wtf/Ref.h header.
history/CachedPage.h: Add missing inclusion of the wtf/MonotonicTime.h header.
html/canvas/WebGLBuffer.h: Add missing inclusion of the wtf/RefPtr.h header.
html/canvas/WebGLFramebuffer.h: Add missing inclusion of the wtf/HashMap.h and

wtf/Vector.h headers.

html/canvas/WebGLProgram.h: Add missing inclusion of the wtf/HashFunctions.h, wtf/Lock.h,

and wtf/Vector.h headers; add the missing namespace to an usage of WTF::LockHolder.

html/canvas/WebGLShader.h: Add missing inclusion of the wtf/text/WTFString.h header.
inspector/InspectorController.cpp: Add missing inclusion of the SharedBuffer.h header.
inspector/agents/InspectorCanvasAgent.cpp: Add missing inclusion of the ImageBitmap.h

header.

page/DOMWindowExtension.cpp: Add missing inclusion of the Document.h header.
page/scrolling/nicosia/ScrollingTreeFixedNode.cpp: Add missing inclusion of the

ScrollingTreeFrameScrollingNode.h header.

page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp: Add missing inclusion

of the Logging.h header.

page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp: Add missing

inclusion of the ScrollingTree.h header.

page/scrolling/nicosia/ScrollingTreeStickyNode.cpp: Add missing inclusion of the

ScrollingTreeOverflowScrollProxyNode.h header.

platform/SuspendableTaskQueue.cpp: Add missing inclusion of the ScriptExecutionContext.h

header.

workers/Worker.cpp: Add missing inclusion of the JavaScriptCore/ScriptCallStack.h header.

Source/WebKit:

NetworkProcess/NetworkConnectionToWebProcess.cpp: Add missing inclusion of the

Logging.h header.

1:32 PM Changeset in webkit [250856] by Wenson Hsieh

2 edits
27 adds in trunk/LayoutTests

[Clipboard API] Import web-platform-tests/clipboard-apis
https://bugs.webkit.org/show_bug.cgi?id=202642

Reviewed by Ryosuke Niwa.

Upstream tests and current test expectations from web-platform-tests/clipboard-apis/.

resources/import-expectations.json:
web-platform-tests/clipboard-apis/META.yml: Added.
web-platform-tests/clipboard-apis/async-interfaces.https-expected.txt: Added.
web-platform-tests/clipboard-apis/async-interfaces.https.html: Added.
web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https-expected.txt: Added.
web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https.html: Added.
web-platform-tests/clipboard-apis/async-write-dttext-read-dttext-manual.https-expected.txt: Added.
web-platform-tests/clipboard-apis/async-write-dttext-read-dttext-manual.https.html: Added.
web-platform-tests/clipboard-apis/async-write-dttext-read-text-manual.https-expected.txt: Added.
web-platform-tests/clipboard-apis/async-write-dttext-read-text-manual.https.html: Added.
web-platform-tests/clipboard-apis/async-write-text-read-dttext-manual.https-expected.txt: Added.
web-platform-tests/clipboard-apis/async-write-text-read-dttext-manual.https.html: Added.
web-platform-tests/clipboard-apis/async-write-text-read-text-manual.https-expected.txt: Added.
web-platform-tests/clipboard-apis/async-write-text-read-text-manual.https.html: Added.
web-platform-tests/clipboard-apis/clipboard-events-synthetic-expected.txt: Added.
web-platform-tests/clipboard-apis/clipboard-events-synthetic.html: Added.
web-platform-tests/clipboard-apis/w3c-import.log: Added.

1:15 PM Changeset in webkit [250855] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: unable to click on overview path component when jumping directly to a shader
https://bugs.webkit.org/show_bug.cgi?id=202682

Reviewed by Matt Baker.

UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView):
The WI.TreeOutline used for the hierarchical path components is actually held by the
Canvas Tab, not the Canvas navigation sidebar panel. As a result, if the hierarchical path
is changed by anything other than the hierarchical path itself (e.g. a selection in the
navigation sidebar, or clicking on the [gl] shader or [o_o] recording buttons in the
overview preview tile), the selection state of the WI.TreeOutline can get out of sync. In
this case, the WI.TreeOutline still thinks that "Overview" is selected because the change
in content view was triggered by something unrelated to the WI.TreeOutline (see above for
specific examples). The simple solution is to just allow repeat selection, as this is only
an issue here because the canvas navigation sidebar isn't always visible, as well as to
allow the "Overview" to be listed as the root path item.

UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel.prototype.updateRepresentedObjects):
If a WI.Canvas is one of the current represented objects, attempt to select it, even if
it matches the currently shown WI.Canvas. This covers the situation where the WI.Canvas
is selected via its hierarchical path component, ensuring that the selected item in the
navigation sidebar always matches the hierarchical path components.

1:08 PM Changeset in webkit [250854] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: the navigation sidebar icon isn't inverted in dark mode
https://bugs.webkit.org/show_bug.cgi?id=202681

Reviewed by Matt Baker.

UserInterface/Views/CanvasSidebarPanel.css:

(@media (prefers-color-scheme: dark) .sidebar > .panel.navigation.canvas > .content > .tree-outline .item.canvas .icon): Added.

UserInterface/Views/CanvasTabContentView.css:

(@media (prefers-color-scheme: dark) .content-view.tab.canvas .navigation-bar > .item .canvas-overview .icon):
Drive-by: slightly darken the Canvas Overview hierarchical path component icon so it better

matches the colors of the nearby canvas icons.

12:53 PM Changeset in webkit [250853] by youenn@apple.com

11 edits in trunk

MediaStreamTrack should be a PlatformMediaSessionClient instead of MediaStream
https://bugs.webkit.org/show_bug.cgi?id=202631

Reviewed by Eric Carlson.

Source/WebCore:

Make MediaStreamTrack a PlatformMediaSessionClient, which allows tracking tracks that are not owned by a stream.
MediaStream is no longer a PlatformMediaSessionClient so we move some of MediaStream API implementation to MediaStreamTrack.

Covered by updated test.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::startProducingData):
(WebCore::MediaStream::stopProducingData):
(WebCore::MediaStream::statusDidChange):
(WebCore::MediaStream::mediaType const): Deleted.
(WebCore::MediaStream::presentationType const): Deleted.
(WebCore::MediaStream::characteristics const): Deleted.
(WebCore::MediaStream::mayResumePlayback): Deleted.
(WebCore::MediaStream::suspendPlayback): Deleted.
(WebCore::MediaStream::sourceApplicationIdentifier const): Deleted.
(WebCore::MediaStream::canProduceAudio const): Deleted.
(WebCore::MediaStream::processingUserGestureForMedia const): Deleted.

Modules/mediastream/MediaStream.h:
Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::configureTrackRendering):
(WebCore::MediaStreamTrack::mediaType const):
(WebCore::MediaStreamTrack::presentationType const):
(WebCore::MediaStreamTrack::characteristics const):
(WebCore::MediaStreamTrack::mayResumePlayback):
(WebCore::MediaStreamTrack::suspendPlayback):
(WebCore::MediaStreamTrack::sourceApplicationIdentifier const):
(WebCore::MediaStreamTrack::canProduceAudio const):
(WebCore::MediaStreamTrack::processingUserGestureForMedia const):

Modules/mediastream/MediaStreamTrack.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load):

platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::hasVideo const):
(WebCore::MediaStreamPrivate::hasAudio const):
(WebCore::MediaStreamPrivate::hasCaptureVideoSource const): Deleted.
(WebCore::MediaStreamPrivate::hasCaptureAudioSource const): Deleted.

platform/mediastream/MediaStreamPrivate.h:
platform/mediastream/MediaStreamTrackPrivate.h:

LayoutTests:

fast/mediastream/audio-track-enabled.html:

12:50 PM Changeset in webkit [250852] by beidson@apple.com

25 edits
6 adds in trunk

Service Worker Fetch events should time out.
https://bugs.webkit.org/show_bug.cgi?id=202188

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/workers/service/basic-timeout.https.html

workers/service/server/SWServer.h:
workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::setHasTimedOutAnyFetchTasks):
(WebCore::SWServerWorker::hasTimedOutAnyFetchTasks const):

Source/WebKit:

When we start a fetch task in the server, we also start a timeout on that fetch task.

"Time out" means the fetch task must continue to make progress at the given frequency (once every 60 seconds by default)

If any given fetch task times out in a service worker instance, that instance loses the right to handle fetches.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setServiceWorkerFetchTimeoutForTesting):
(WebKit::NetworkProcess::resetServiceWorkerFetchTimeoutForTesting):

NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::serviceWorkerFetchTimeout const):

NetworkProcess/NetworkProcess.messages.in:

NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::didReceiveRedirectResponse):
(WebKit::ServiceWorkerFetchTask::didReceiveResponse):
(WebKit::ServiceWorkerFetchTask::didReceiveData):
(WebKit::ServiceWorkerFetchTask::didReceiveFormData):
(WebKit::ServiceWorkerFetchTask::didFinish):
(WebKit::ServiceWorkerFetchTask::didFail):
(WebKit::ServiceWorkerFetchTask::didNotHandle):

NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:

(WebKit::ServiceWorkerFetchTask::create):
(WebKit::ServiceWorkerFetchTask::serviceWorkerIdentifier const):
(WebKit::ServiceWorkerFetchTask::wasHandled const):
(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask): Deleted.

NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startFetch):

NetworkProcess/ServiceWorker/WebSWServerConnection.h:

NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::startFetch):
(WebKit::WebSWServerToContextConnection::fetchTaskTimedOut):

NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:

UIProcess/API/C/WKContext.cpp:

(WKContextSetServiceWorkerFetchTimeoutForTesting):
(WKContextResetServiceWorkerFetchTimeoutForTesting):

UIProcess/API/C/WKContext.h:

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setServiceWorkerTimeoutForTesting):
(WebKit::WebProcessPool::resetServiceWorkerTimeoutForTesting):

UIProcess/WebProcessPool.h:

Tools:

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setServiceWorkerFetchTimeout):

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::setServiceWorkerFetchTimeoutForTesting):

WebKitTestRunner/TestController.h:
WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

http/tests/workers/service/basic-timeout.https-expected.txt: Added.
http/tests/workers/service/basic-timeout.https.html: Added.
http/tests/workers/service/resources/basic-timeout-worker.js: Added.

(event.event.request.url.indexOf):

http/tests/workers/service/resources/basic-timeout.js: Added.

(async.test.finishThisTest):
(async.test.try):
(async.test.try.checkSuccessAgain):
(async.test):

http/tests/workers/service/resources/succeed-fallback-check.php: Added.
http/tests/workers/service/resources/timeout-fallback.html: Added.

12:38 PM Changeset in webkit [250851] by Matt Lewis

5 edits in trunk/Tools

Unreviewed, rolling out r250784.

Broke running layout tests.

Reverted changeset:

"results.webkit.org: Start reporting results"
https://bugs.webkit.org/show_bug.cgi?id=202639
https://trac.webkit.org/changeset/250784

12:37 PM Changeset in webkit [250850] by Matt Lewis

2 edits in trunk/Tools

Make iPhone simulators pass --iPhone-simulator instead of --iOS
https://bugs.webkit.org/show_bug.cgi?id=202701

Reviewed by Aakash Jain.

BuildSlaveSupport/build.webkit.org-config/steps.py:

(appendCustomTestingFlags):

12:24 PM Changeset in webkit [250849] by commit-queue@webkit.org

19 edits in trunk

Accept two values in the overflow shorthand
https://bugs.webkit.org/show_bug.cgi?id=184691

Patch by Alexey Shvayka <Alexey Shvayka> on 2019-10-08
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/css-overflow/overflow-shorthand-001-expected.txt:
web-platform-tests/css/css-overflow/parsing/overflow-computed-expected.txt:
web-platform-tests/css/css-overflow/parsing/overflow-valid-expected.txt:
web-platform-tests/css/cssom/shorthand-values-expected.txt:

Source/WebCore:

In https://github.com/w3c/csswg-drafts/issues/2484 it was resolved to accept one or two values in
the overflow shorthand, instead of only one. If two values are specified, the first would be used
for overflow-x and the second for overflow-y. This change was shipped in Firefox 61 and Chrome 68.
This patch implements new syntax while preserving handling of -webkit-paged-x and -webkit-paged-y.

Tests: fast/css/cssText-shorthand.html

fast/css/getComputedStyle/getComputedStyle-overflow.html
imported/w3c/web-platform-tests/css/css-overflow/overflow-shorthand-001.html
imported/w3c/web-platform-tests/css/css-overflow/parsing/overflow-computed.html
imported/w3c/web-platform-tests/css/css-overflow/parsing/overflow-valid.html
imported/w3c/web-platform-tests/css/cssom/shorthand-values.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

css/CSSProperties.json:
css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue const):

css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeOverflowShorthand):
(WebCore::CSSPropertyParser::parseShorthand):

css/parser/CSSPropertyParser.h:

LayoutTests:

fast/css/cssText-shorthand-expected.txt:
fast/css/getComputedStyle/getComputedStyle-overflow-expected.txt:
fast/css/getComputedStyle/getComputedStyle-overflow.html:
platform/ios/fast/css/invalidation-errors-2-expected.txt:
platform/ios/fast/css/invalidation-errors-expected.txt:
platform/mac/fast/css/invalidation-errors-2-expected.txt:
platform/mac/fast/css/invalidation-errors-expected.txt:

12:00 PM Changeset in webkit [250848] by ysuzuki@apple.com

2 edits in trunk/Source/JavaScriptCore

[JSC] FTL vmCall should check # of arguments
https://bugs.webkit.org/show_bug.cgi?id=202683

Reviewed by Saam Barati.

ftl/FTLLowerDFGToB3.cpp:

11:59 AM Changeset in webkit [250847] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-build] Do not print worker environment variables in each build step [part 3]
https://bugs.webkit.org/show_bug.cgi?id=202698

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/steps.py:

(RunJavaScriptCoreTests.init): Disabled logging of environment variables.
(ExtractTestResults.init): Ditto.

BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

11:58 AM Changeset in webkit [250846] by ajuma@chromium.org

2 edits in trunk/LayoutTests

Unreviewed test gardening

TestExpectations:

11:54 AM Changeset in webkit [250845] by Wenson Hsieh

2 edits in trunk/Source/WebCore

Unreviewed, fix WebCore's features.json after r250824

features.json: Remove an erroneous "specification" key.

11:48 AM Changeset in webkit [250844] by jiewen_tan@apple.com

3 edits in trunk/LayoutTests

Unreviewed, test gardening

TestExpectations:
platform/ios-simulator/TestExpectations:

11:39 AM Changeset in webkit [250843] by Chris Dumez

4 edits in trunk/Source/WebCore

Make sure ActiveDOMObject properly deals with detached documents
https://bugs.webkit.org/show_bug.cgi?id=202596

Reviewed by Geoffrey Garen.

For detached document, the script execution context is their context document.
The ActiveDOMObject constructor taking a Document& would make sure to get the
document's contextDocument. However, if the ActiveDOMObject constructor taking
a ScriptExecutionContext* is called, it would assume this is the right script
execution context, which is unsafe. In this patch, all ActiveDOMObject
constructors now check for detached documents and make sure to use their
context document when necessary.

dom/ActiveDOMObject.cpp:

(WebCore::suitableScriptExecutionContext):
(WebCore::ActiveDOMObject::ActiveDOMObject):

dom/ActiveDOMObject.h:
dom/Document.h:

11:30 AM Changeset in webkit [250842] by Ross Kirsling

42 edits
22 moves
2 adds
79 deletes in trunk/JSTests

Update test262 (2019.10.08).

Rubber-stamped by Keith Miller.

test262/config.yaml:
test262/expectations.yaml:
test262/latest-changes-summary.txt:
test262/test/:
test262/test262-Revision.txt:

11:28 AM Changeset in webkit [250841] by graouts@webkit.org

2 edits in trunk/LayoutTests

fast/events/touch/ios/mouse-events-dispatch-with-touch.html is timing out on iOS
https://bugs.webkit.org/show_bug.cgi?id=202688
<rdar://problem/52700396>

Reviewed by Dean Jackson.

Since this test was originally added, the behavior of simulated mouse events changed to not dispatch any event when there is more than a
single active touch on the screen. This test needs to be adapted to this new behavior.

fast/events/touch/ios/mouse-events-dispatch-with-touch.html:

11:21 AM Changeset in webkit [250840] by Matt Lewis

2 edits in trunk/Tools

Fixing the triggerable templates in the config for catalina.
https://bugs.webkit.org/show_bug.cgi?id=202652

Reviewed by Jonathan Bedard.

BuildSlaveSupport/build.webkit.org-config/config.json:

10:54 AM Changeset in webkit [250839] by Ross Kirsling

25 edits in trunk/Source

Unreviewed. Restabilize non-unified build.

Source/WebCore:

Modules/fetch/FetchLoader.h:
animation/DocumentTimeline.cpp:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSIDBRequestCustom.cpp:
bindings/js/JSRemoteDOMWindowCustom.cpp:
bindings/js/ScriptModuleLoader.h:
bindings/js/WindowProxy.cpp:
css/FontFaceSet.cpp:
css/FontFaceSet.h:
css/typedom/StylePropertyMapReadOnly.cpp:
history/CachedPage.h:
html/canvas/WebGLBuffer.cpp:
html/canvas/WebGLBuffer.h:
html/canvas/WebGLFramebuffer.h:
html/canvas/WebGLProgram.cpp:
html/canvas/WebGLProgram.h:
html/canvas/WebGLShader.h:
inspector/InspectorController.cpp:
inspector/agents/InspectorCanvasAgent.cpp:
workers/Worker.cpp:
workers/service/ServiceWorkerContainer.cpp:
workers/service/ServiceWorkerGlobalScope.cpp:

Source/WebKit:

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:

10:44 AM Changeset in webkit [250838] by dino@apple.com

2 edits in trunk/Source/WebKit

Sort Internal and Experimental features by human readable name
https://bugs.webkit.org/show_bug.cgi?id=202667

Reviewed by Zalan Bujtas.

Sort the statically generated vectors of internal and
experimental features by their human readable name, rather than
the feature key, so that looking at them in the Settings app
doesn't make people who like alphabetical order angry.

Scripts/GeneratePreferences.rb: Add an extra sort call to the list generation.

10:26 AM Changeset in webkit [250837] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC][Painting] Add very basic block and inline painting
https://bugs.webkit.org/show_bug.cgi?id=202697
<rdar://problem/56076562>

Reviewed by Antti Koivisto.

This is a very basic border/background painting with simple text. No phases/z-index/layers of any kind.

layout/displaytree/DisplayBox.h: This seems to be getting out of hand.

(WebCore::Display::Box::moveBy):

layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintBlockLevelBoxDecoration):
(WebCore::Display::paintInlineContent):
(WebCore::Display::Painter::paint):

layout/floats/FloatingContext.h:
layout/inlineformatting/InlineFormattingState.h:

(WebCore::Layout::InlineFormattingState::inlineRuns const):
(WebCore::Layout::InlineFormattingState::lineBoxes const):

9:55 AM Changeset in webkit [250836] by youenn@apple.com

3 edits in trunk/LayoutTests

Simplify data channel buffer amount low tests
https://bugs.webkit.org/show_bug.cgi?id=202693

Reviewed by Eric Carlson.

Neither of these tests need to handle a remoteChannel.
Remove the related code and remove variables that are also unneeded.

webrtc/datachannel/bufferedAmountLowThreshold-default.html:
webrtc/datachannel/bufferedAmountLowThreshold.html:

9:32 AM Changeset in webkit [250835] by Alan Coon

23 edits
3 adds in branches/safari-608.3.10.0-branch

Cherry-pick r250811. rdar://problem/56061124

Only wrapping CryptoKeys for IDB during serialization
https://bugs.webkit.org/show_bug.cgi?id=202500
<rdar://problem/52445927>

Reviewed by Chris Dumez.

Source/WebCore:

Wrapping CryptoKeys during IDB serialization is a legacy request from Netflix when WebKit was an
early adopter. It is not necessary for other kinds of serialization. However, given existing keys
stored in users' idb are wrapped, the wrapping/unwrapping mechanism cannot be easily discarded.
Therefore, this patch restricts the wrapping/unwrapping mechanism to idb only.

To do so, a isWrappingRequired flag is added to CryptoKey such that whenever idb sees a CryptoKey,
it can set it. SerializedScriptValue will then only wrap a CryptoKey when this flag is set. Otherwise,
a new tag UnwrappedCryptoKeyTag is used to store unwrapped CryptoKeys in order to keep the old CryptoKeyTag
binaries intact. For deserialization, each type will be deserialized differently.

Besides the above, this patch also hardens WorkerGlobalScope::wrapCryptoKey/unwrapCryptoKey for
any potential racy issues. CryptoBooleanContainer is introduced to capture boolean in the lambda.
workerGlobalScope is replaced with workerMessagingProxy. Now, every variables captured in the lambdas
should be either a copy or a thread safe ref of the original object.

Test: crypto/workers/subtle/aes-indexeddb.html

Modules/indexeddb/IDBObjectStore.cpp: (WebCore::JSC::setIsWrappingRequiredForCryptoKey): (WebCore::IDBObjectStore::putOrAdd):
bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
crypto/CryptoKey.h: (WebCore::CryptoKey::isWrappingRequired const): (WebCore::CryptoKey::setIsWrappingRequired):
dom/ScriptExecutionContext.h:
workers/WorkerGlobalScope.cpp: (WebCore::CryptoBooleanContainer::create): (WebCore::CryptoBooleanContainer::boolean const): (WebCore::CryptoBooleanContainer::setBoolean): (WebCore::WorkerGlobalScope::wrapCryptoKey): (WebCore::WorkerGlobalScope::unwrapCryptoKey):
workers/WorkerGlobalScope.h:
workers/WorkerLoaderProxy.h: (WebCore::WorkerLoaderProxy::isWorkerMessagingProxy const):
workers/WorkerMessagingProxy.h: (isType):

Tools:

Modifies IndexedDB.StructuredCloneBackwardCompatibility test to include CryptoKeys.

TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: (-[StructuredCloneBackwardCompatibilityNavigationDelegate _webCryptoMasterKeyForWebView:]): (TEST):
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html:

LayoutTests:

Adds a new test aes-indexeddb.html to do idb in workers and makes
other tests more deterministic.

crypto/workers/subtle/aes-indexeddb-expected.txt: Added.
crypto/workers/subtle/aes-indexeddb.html: Added.
crypto/workers/subtle/ec-postMessage-worker-expected.txt:
crypto/workers/subtle/ec-postMessage-worker.html:
crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
crypto/workers/subtle/hrsa-postMessage-worker.html:
crypto/workers/subtle/resources/aes-indexeddb.js: Added.
crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
crypto/workers/subtle/rsa-postMessage-worker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:20 AM Changeset in webkit [250834] by Alan Coon

23 edits
3 adds in branches/safari-608.3.10.1-branch

Cherry-pick r250811. rdar://problem/56075033

Only wrapping CryptoKeys for IDB during serialization
https://bugs.webkit.org/show_bug.cgi?id=202500
<rdar://problem/52445927>

Reviewed by Chris Dumez.

Source/WebCore:

Wrapping CryptoKeys during IDB serialization is a legacy request from Netflix when WebKit was an
early adopter. It is not necessary for other kinds of serialization. However, given existing keys
stored in users' idb are wrapped, the wrapping/unwrapping mechanism cannot be easily discarded.
Therefore, this patch restricts the wrapping/unwrapping mechanism to idb only.

To do so, a isWrappingRequired flag is added to CryptoKey such that whenever idb sees a CryptoKey,
it can set it. SerializedScriptValue will then only wrap a CryptoKey when this flag is set. Otherwise,
a new tag UnwrappedCryptoKeyTag is used to store unwrapped CryptoKeys in order to keep the old CryptoKeyTag
binaries intact. For deserialization, each type will be deserialized differently.

Besides the above, this patch also hardens WorkerGlobalScope::wrapCryptoKey/unwrapCryptoKey for
any potential racy issues. CryptoBooleanContainer is introduced to capture boolean in the lambda.
workerGlobalScope is replaced with workerMessagingProxy. Now, every variables captured in the lambdas
should be either a copy or a thread safe ref of the original object.

Test: crypto/workers/subtle/aes-indexeddb.html

Modules/indexeddb/IDBObjectStore.cpp: (WebCore::JSC::setIsWrappingRequiredForCryptoKey): (WebCore::IDBObjectStore::putOrAdd):
bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
crypto/CryptoKey.h: (WebCore::CryptoKey::isWrappingRequired const): (WebCore::CryptoKey::setIsWrappingRequired):
dom/ScriptExecutionContext.h:
workers/WorkerGlobalScope.cpp: (WebCore::CryptoBooleanContainer::create): (WebCore::CryptoBooleanContainer::boolean const): (WebCore::CryptoBooleanContainer::setBoolean): (WebCore::WorkerGlobalScope::wrapCryptoKey): (WebCore::WorkerGlobalScope::unwrapCryptoKey):
workers/WorkerGlobalScope.h:
workers/WorkerLoaderProxy.h: (WebCore::WorkerLoaderProxy::isWorkerMessagingProxy const):
workers/WorkerMessagingProxy.h: (isType):

Tools:

Modifies IndexedDB.StructuredCloneBackwardCompatibility test to include CryptoKeys.

TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: (-[StructuredCloneBackwardCompatibilityNavigationDelegate _webCryptoMasterKeyForWebView:]): (TEST):
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html:
TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html:

LayoutTests:

Adds a new test aes-indexeddb.html to do idb in workers and makes
other tests more deterministic.

crypto/workers/subtle/aes-indexeddb-expected.txt: Added.
crypto/workers/subtle/aes-indexeddb.html: Added.
crypto/workers/subtle/ec-postMessage-worker-expected.txt:
crypto/workers/subtle/ec-postMessage-worker.html:
crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
crypto/workers/subtle/hrsa-postMessage-worker.html:
crypto/workers/subtle/resources/aes-indexeddb.js: Added.
crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
crypto/workers/subtle/rsa-postMessage-worker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:13 AM Changeset in webkit [250833] by Alan Coon

5 edits in branches/safari-608.3.10.1-branch

Apply patch. rdar://problem/55920073

9:10 AM Changeset in webkit [250832] by Alan Coon

7 edits in branches/safari-608.3.10.1-branch/Source

Versioning.

9:04 AM Changeset in webkit [250831] by Wenson Hsieh

2 edits in trunk/Source/WebCore

Unreviewed, try to fix the WinCairo build after r250824

dom/IdleDeadline.h:

Add a missing include for <wtf/Ref.h>, such that the adoptRef function is defined.

9:00 AM Changeset in webkit [250830] by Alan Coon

11 edits in branches/safari-608.3.10.0-branch/Source/WebKit

Cherry-pick r250780. rdar://problem/56061130

Provide options for DTTZ to happen in more situations
https://bugs.webkit.org/show_bug.cgi?id=202634
<rdar://problem/55732762>

Reviewed by Antoine Quint.

Add two options that can be enabled to trigger double tap zooming
in more places.

Firstly, an option to keep listening for a double-tap-to-zoom if the
first tap found a click handler on the body or document element. The
tap will still be dispatched. This is probably the most common case
for disabling a DTTZ.

Secondly, an option to always keep listening for a double-tap-to-zoom,
even if there was a clickable (non-root) element under the first tap.

Shared/WebPreferences.yaml: Add ZoomOnDoubleTapWhenRoot and AlwaysZoomOnDoubleTap.
UIProcess/PageClient.h: The message from the WebProcess now tells the UIProcess if the tapped element was a root-level (document or body).
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::handleSmartMagnificationInformationForPotentialTap):
UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]): (-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:nodeIsRootLevel:]): Handle the two new options.

UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::handleSmartMagnificationInformationForPotentialTap):
WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::potentialTapAtPosition): Check if the tap was on a root-level element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:00 AM Changeset in webkit [250829] by Alan Coon

6 edits in branches/safari-608.3.10.0-branch/Source/WebKit

Cherry-pick r250755. rdar://problem/56061130

Use a better name than allowFastClicksEverywhere
https://bugs.webkit.org/show_bug.cgi?id=202607
<rdar://problem/55997133>

Reviewed by Tim Horton.

This preference name is quite confusing. Change it to
PreferFasterClickOverDoubleTap.

Shared/WebPreferences.yaml:
Shared/WebPreferencesDefaultValues.h:
UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::preferFasterClickOverDoubleTap const): (WebKit::WebPageProxy::allowsFastClicksEverywhere const): Deleted.
UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:]):
UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:00 AM Changeset in webkit [250828] by Alan Coon

5 edits in branches/safari-608.3.10.0-branch/Source/WebCore

Cherry-pick r250694. rdar://problem/56061133

[iOS] WebContent process can be interrupted during suspension; loses "Now Playing" status

https://bugs.webkit.org/show_bug.cgi?id=202537
<rdar://problem/55952707>

Reviewed by Eric Carlson.

Always deactivate the AVAudioSession when the last playing PlatformAudioSession ends playback and the application is in the background.

platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::removeSession): (WebCore::PlatformMediaSessionManager::processWillSuspend): (WebCore::PlatformMediaSessionManager::maybeDeactivateAudioSession):
platform/audio/PlatformMediaSessionManager.h: (WebCore::PlatformMediaSessionManager::isApplicationInBackground const):
platform/audio/ios/MediaSessionManagerIOS.h:
platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::sessionWillEndPlayback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:51 AM Changeset in webkit [250827] by Wenson Hsieh

2 edits in trunk/Source/WebCore

Unreviewed, try to fix the open source macOS build after r250824

bindings/js/JSDOMConvertRecord.h:

Add a missing #include for JSDOMGlobalObject. This file utilizes methods on JSDOMGlobalObject, but only ensures
that it has a forward declaration of JSDOMGlobalObject (by way of including JSDOMExceptionHandling.h through
JSDOMConvertBase.h).

8:14 AM Changeset in webkit [250826] by Alan Coon

2 edits in branches/safari-608.3.10.0-branch/Source/WebKit

Cherry-pick r250438. rdar://problem/55984974

Unreviewed build-fix: wrap the AssertionServicesSPI.h in an IOS_FAMILY check.

WebProcess/cocoa/WebProcessCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:13 AM Changeset in webkit [250825] by Wenson Hsieh

3 edits in trunk/Source/WebCore

Unreviewed, update DerivedSources xcfilelists after r250816

DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:

7:50 AM Changeset in webkit [250824] by Wenson Hsieh

27 edits
9 copies
6 adds in trunk

[Clipboard API] Introduce bindings for the async Clipboard API
https://bugs.webkit.org/show_bug.cgi?id=202622
<rdar://problem/56038126>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds IDL for the async clipboard API (with the exception of delayed item generation interfaces, which
I'll iterate on and introduce separately). See: https://w3c.github.io/clipboard-apis/#async-clipboard-api for
more information.

Tests: editing/async-clipboard/clipboard-interfaces.html

editing/async-clipboard/clipboard-wrapper-stays-alive.html

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/async-clipboard/Clipboard.cpp:

(WebCore::Clipboard::create):
(WebCore::Clipboard::Clipboard):
(WebCore::Clipboard::navigator):
(WebCore::Clipboard::eventTargetInterface const):
(WebCore::Clipboard::scriptExecutionContext const):
(WebCore::Clipboard::readText):
(WebCore::Clipboard::writeText):
(WebCore::Clipboard::read):
(WebCore::Clipboard::write):

Stub out these API calls for now by immediately rejecting the given promise.

Modules/async-clipboard/Clipboard.h:
Modules/async-clipboard/Clipboard.idl:
Modules/async-clipboard/ClipboardItem.cpp:

(WebCore::ClipboardItem::ClipboardItem):
(WebCore::ClipboardItem::create):
(WebCore::ClipboardItem::types const):
(WebCore::ClipboardItem::getType):

Stub out these API calls for now by immediately rejecting the given promise.

(WebCore::navigator):

Modules/async-clipboard/ClipboardItem.h:

(WebCore::ClipboardItem::presentationStyle const):

Modules/async-clipboard/ClipboardItem.idl:
Modules/async-clipboard/NavigatorClipboard.cpp:

(WebCore::NavigatorClipboard::NavigatorClipboard):
(WebCore::NavigatorClipboard::clipboard):
(WebCore::NavigatorClipboard::from):
(WebCore::NavigatorClipboard::supplementName):

Modules/async-clipboard/NavigatorClipboard.h:
Modules/async-clipboard/NavigatorClipboard.idl:
Modules/mediastream/MediaStreamTrack.cpp:
Modules/mediastream/RTCDTMFSender.cpp:
Modules/mediastream/RTCRtpSender.cpp:
Modules/webgpu/WebGPUPipeline.h:

More unified sources-related build fixes.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
dom/DeviceOrientationOrMotionEvent.cpp:

Unified sources-related build fix.

dom/EventTargetFactory.in:
features.json:

Add Async Clipboard API as a feature in development on webkit.org.

page/Settings.yaml:

Source/WebKit:

Adds a new experimental feature flag. See WebCore ChangeLog for more details.

Shared/WebPreferences.yaml:

LayoutTests:

editing/async-clipboard/clipboard-interfaces-expected.txt: Added.
editing/async-clipboard/clipboard-interfaces.html: Added.

Add a new test to sanity check the new clipboard API interfaces and interface extensions.

editing/async-clipboard/clipboard-wrapper-stays-alive-expected.txt: Added.
editing/async-clipboard/clipboard-wrapper-stays-alive.html: Added.

Add a new test to make sure that the clipboard wrapper stays alive between GC passes, even when the clipboard's
navigator is kept alive, independently of its window object.

fast/dom/navigator-detached-no-crash-expected.txt:
platform/ios-wk1/TestExpectations:
platform/mac-highsierra/fast/dom/navigator-detached-no-crash-expected.txt:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt:
platform/mac/fast/dom/navigator-detached-no-crash-expected.txt:
platform/win/fast/dom/navigator-detached-no-crash-expected.txt:
platform/wincairo/fast/dom/navigator-detached-no-crash-expected.txt:

Update an existing layout test to include "navigator.clipboard".

6:56 AM Changeset in webkit [250823] by ajuma@chromium.org

3 edits
4 copies
51 adds
1 delete in trunk/LayoutTests

Import autofocus Web Platform Tests
https://bugs.webkit.org/show_bug.cgi?id=202641

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Import web platform tests for autofocus, and remove duplicated test from
http/wpt/html/semantics/forms/autofocus.

resources/import-expectations.json:
web-platform-tests/html/interaction/focus/the-autofocus-attribute/autofocus-in-not-fully-active-document-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/autofocus-in-not-fully-active-document.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/autofocus-on-stable-document-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/autofocus-on-stable-document.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/first-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/first-reconnected-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/first-reconnected.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/first-when-later-but-before-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/first-when-later-but-before.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/first-when-later-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/first-when-later.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/first.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/focusable-area-in-top-document-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/focusable-area-in-top-document.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/no-cross-origin-autofocus-expected.txt: Renamed from LayoutTests/http/wpt/html/semantics/forms/autofocus/no-cross-origin-autofocus.sub-expected.txt.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/no-cross-origin-autofocus.html: Copied from LayoutTests/http/wpt/html/semantics/forms/autofocus/no-cross-origin-autofocus.sub.html.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/no-sandboxed-automatic-features-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/no-sandboxed-automatic-features.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/not-on-first-task-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/not-on-first-task.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/queue-non-focusable-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/queue-non-focusable.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/resources/child-autofocus.html: Renamed from LayoutTests/http/wpt/html/semantics/forms/autofocus/resources/child-autofocus.html.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/resources/child-iframe.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/resources/erase-first.css: Added.

(#first):

web-platform-tests/html/interaction/focus/the-autofocus-attribute/resources/frame-with-autofocus-element.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/resources/grand-child-autofocus.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/resources/moving-autofocus-to-parent.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/resources/utils.js: Added.

(waitForEvent):
(timeOut):
(async.waitUntilStableAutofocusState):

web-platform-tests/html/interaction/focus/the-autofocus-attribute/resources/w3c-import.log: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/same-origin-autofocus-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/same-origin-autofocus.html: Renamed from LayoutTests/http/wpt/html/semantics/forms/autofocus/no-cross-origin-autofocus.sub.html.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/skip-another-top-level-browsing-context-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/skip-another-top-level-browsing-context.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/skip-document-with-fragment-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/skip-document-with-fragment.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/skip-non-focusable-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/skip-non-focusable.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/skip-not-fully-active-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/skip-not-fully-active.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/spin-by-blocking-style-sheet-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/spin-by-blocking-style-sheet.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/supported-elements-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/supported-elements.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/update-the-rendering-expected.txt: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/update-the-rendering.html: Added.
web-platform-tests/html/interaction/focus/the-autofocus-attribute/w3c-import.log: Added.

LayoutTests:

platform/ios-wk2/imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-attribute/update-the-rendering-expected.txt: Added.
platform/mac-wk1/imported/w3c/web-platform-tests/html/interaction/focus/the-autofocus-attribute/update-the-rendering-expected.txt: Added.

5:51 AM Changeset in webkit [250822] by commit-queue@webkit.org

5 edits in trunk

Fetch: data: URL HEAD request should result in empty response body
https://bugs.webkit.org/show_bug.cgi?id=175764

Patch by Rob Buis <rbuis@igalia.com> on 2019-10-08
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update improved test results.

web-platform-tests/fetch/api/basic/scheme-data.any.js:
web-platform-tests/xhr/data-uri-expected.txt:

Source/WebCore:

Do not build the response body for HEAD requests for data urls:
https://fetch.spec.whatwg.org/#concept-main-fetch (Step 13)

Tests: imported/web-platform-tests/fetch/api/basic/scheme-data.any.js

imported/web-platform-tests/xhr/data-uri.html

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::loadDataURL):

5:22 AM Changeset in webkit [250821] by Antti Koivisto

10 edits
9 adds in trunk

[CSS Shadow Parts] Implement style invalidation
https://bugs.webkit.org/show_bug.cgi?id=202632

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

web-platform-tests/css/css-shadow-parts/invalidation-change-exportparts-forward-expected.txt:
web-platform-tests/css/css-shadow-parts/invalidation-change-part-name-expected.txt:
web-platform-tests/css/css-shadow-parts/invalidation-change-part-name-forward-expected.txt:

Source/WebCore:

Tests: fast/css/shadow-parts/invalidation-class-descendant-combinator-export.html

fast/css/shadow-parts/invalidation-class-descendant-combinator.html
fast/css/shadow-parts/invalidation-class-sibling-combinator-export.html
fast/css/shadow-parts/invalidation-class-sibling-combinator.html

css/RuleFeature.cpp:

(WebCore::isSiblingOrSubject):

Don't treat crossing to host as moving to ancestor when computing elements impacted by a selector.
StyleInvalidator expects these relations to be about the host element, shadow tree invalidation in handled separately.

dom/Element.cpp:

(WebCore::Element::attributeChanged):

Invalidate parts in shadow tree on 'exportparts' attribute mutation.

(WebCore::Element::partAttributeChanged):

Invalidate element on 'part' attribute mutation.

style/StyleInvalidator.cpp:

(WebCore::Style::Invalidator::Invalidator):
(WebCore::Style::Invalidator::invalidateIfNeeded):

Invalidate parts in shadow tree during class and attribute mutation invalidation.

(WebCore::Style::Invalidator::invalidateShadowParts):

style/StyleInvalidator.h:

(WebCore::Style::Invalidator::dirtiesAllStyle const):
(WebCore::Style::Invalidator::hasShadowPseudoElementRulesInAuthorSheet const): Deleted.

Remove an unncessary bool.

LayoutTests:

Add some tests to verify class mutations and combinators with ::part and exportpart.

fast/css/shadow-parts/invalidation-class-descendant-combinator-expected.txt: Added.
fast/css/shadow-parts/invalidation-class-descendant-combinator-export-expected.txt: Added.
fast/css/shadow-parts/invalidation-class-descendant-combinator-export.html: Added.
fast/css/shadow-parts/invalidation-class-descendant-combinator.html: Added.
fast/css/shadow-parts/invalidation-class-sibling-combinator-expected.txt: Added.
fast/css/shadow-parts/invalidation-class-sibling-combinator-export-expected.txt: Added.
fast/css/shadow-parts/invalidation-class-sibling-combinator-export.html: Added.
fast/css/shadow-parts/invalidation-class-sibling-combinator.html: Added.

3:03 AM Changeset in webkit [250820] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

[GTK] Navigation gesture improvements
https://bugs.webkit.org/show_bug.cgi?id=202645

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2019-10-08
Reviewed by Carlos Garcia Campos.

Measure velocity threshold in pixels per second rather than distance (range [0-1])
per second. The value is the same as it was on touchpads, since a fixed distance is
used, but is now consistent on touchscreens, regardless of the webview width.

Add a threshold for cancelling gesture when the page is more than halfway
through, so that it's symmetric with the first half.

Align the moving page to pixel grid on hidpi devices correctly. Just
rounding the position doesn't work correctly, since the cairo context is
pre-scaled. Multiplying by scale factor, rounding and then dividing by
scale factor fixes this.

UIProcess/ViewGestureController.h:
UIProcess/gtk/ViewGestureControllerGtk.cpp:

(WebKit::ViewGestureController::SwipeProgressTracker::reset):
(WebKit::ViewGestureController::SwipeProgressTracker::handleEvent):
(WebKit::ViewGestureController::SwipeProgressTracker::shouldCancel):
(WebKit::ViewGestureController::draw):

2:06 AM Changeset in webkit [250819] by Carlos Garcia Campos

6 edits
3 deletes in trunk/Source

Unreviewed. Remove unused WebKitSoupRequestGeneric after r250597

Source/WebCore:

platform/Soup.cmake:
platform/SourcesSoup.txt:
platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupRequest const):

platform/network/soup/WebKitSoupRequestGeneric.cpp: Removed.
platform/network/soup/WebKitSoupRequestGeneric.h: Removed.
platform/network/soup/WebKitSoupRequestGenericClient.h: Removed.

Source/WebKit:

NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h:

1:52 AM Changeset in webkit [250818] by Adrian Perez de Castro

3 edits in trunk/Source/WebKit

[WPE][GTK] Build fails with ENABLE_WEBDRIVER=OFF
https://bugs.webkit.org/show_bug.cgi?id=202658

Reviewed by Carlos Garcia Campos.

UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp: Add missing

ENABLE(WEBDRIVER_MOUSE_INTERACTIONS) and ENABLE(WEBDRIVER_KEYBOARD_INTERACTIONS)
preprocessor guards.

UIProcess/Automation/wpe/WebAutomationSessionWPE.cpp: Ditto.

12:31 AM Changeset in webkit [250817] by Antti Koivisto

8 edits in trunk

[CSS Shadow Parts] Internal shadow pseudo elements should work with ::part
https://bugs.webkit.org/show_bug.cgi?id=202620

Reviewed by Ryosuke Niwa.

Source/WebCore:

Selectors like ::part(foo)::placeholder should work.

This involves hop out of a UA shadow tree and then from an author shadow tree.

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchPartPseudoElementRules):

If we are matching a pseudo element in a UA shadow tree, see if part rules can match is the surrounding scope.

(WebCore::ElementRuleCollector::matchPartPseudoElementRulesForScope):

css/ElementRuleCollector.h:
css/RuleSet.cpp:

(WebCore::RuleSet::addRule):

Sort rules with both internal pseudo element and ::part to the part bucket.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively const):

css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::splitCompoundAtImplicitShadowCrossingCombinator):

Allow multiple ShadowDescendant relations for ::part.

LayoutTests:

Note that imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-pseudo-elements.html placeholder subtest still
won't pass because we we don't support getComputedStyle for internal pseudo elements. Visually it now work fully.

TestExpectations:

Unskip imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-placeholder.html

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed