⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 10, 2019:

11:59 PM Changeset in webkit [251002] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit

Remove unused WebProcessPool::requestNetworkingStatistics
​https://bugs.webkit.org/show_bug.cgi?id=202818

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-10-10
Reviewed by Chris Dumez.

Its only use was removed in rdar://problem/56160996

  • NetworkProcess/Downloads/DownloadManager.h:

(WebKit::DownloadManager::isDownloading const):
(WebKit::DownloadManager::activeDownloadCount const): Deleted.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::getNetworkProcessStatistics): Deleted.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • Shared/Authentication/AuthenticationManager.h:

(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount const): Deleted.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didReceiveMessage):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::getStatistics):
(WebKit::WebProcessPool::requestNetworkingStatistics): Deleted.

  • UIProcess/WebProcessPool.h:
10:18 PM Changeset in webkit [251001] by Fujii Hironori
  • 2 edits in trunk/Tools

[WinCairo] auto-installing raises exception "Inner message: global name 'urllib2' is not defined" since r250869
​https://bugs.webkit.org/show_bug.cgi?id=202839

Reviewed by Jonathan Bedard.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._download_to_stream): Replaced urllib2.urlopen with urlopen.

7:47 PM Changeset in webkit [251000] by Konstantin Tokarev
  • 3 edits in trunk/Source/WebCore

Guard GCrypt-specific code with USE(GCRYPT) instead of PLATFORM macros
​https://bugs.webkit.org/show_bug.cgi?id=202829

Reviewed by Jiewen Tan.

  • crypto/keys/CryptoKeyEC.h:
  • crypto/keys/CryptoKeyRSA.h:
7:23 PM Changeset in webkit [250999] by keith_miller@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

GenerateAndAllocateRegisters can trivially elide self moves at end of liveness
​https://bugs.webkit.org/show_bug.cgi?id=202833

Reviewed by Saam Barati.

This also fixes a bug where if a tmp is moved to itself at the end of its lifetime
we would mess up the accounting for the tmp.

In order to catch these bugs earlier during generation I added a
checkConsistency function that if a tmp is in a reg that reg is
not available and that reg thinks the tmp is also allocated in it.

  • b3/B3Bank.h:

(JSC::B3::bankForReg):

  • b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:

(JSC::B3::Air::GenerateAndAllocateRegisters::checkConsistency):
(JSC::B3::Air::GenerateAndAllocateRegisters::generate):

  • b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
6:50 PM Changeset in webkit [250998] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

New html5lib requires newer version of six.py than that shipped in macOS 10.14.6
​https://bugs.webkit.org/show_bug.cgi?id=202830

Autoinstall six along with html5lib.

Patch by Kenneth Russell <​kbr@chromium.org> on 2019-10-10
Reviewed by Jonathan Bedard.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_mechanize):
(AutoinstallImportHook._install_pytest):

6:30 PM Changeset in webkit [250997] by Jonathan Bedard
  • 3 edits in trunk/Tools

results.webkit.org: Sort out certificates on Catalina
​https://bugs.webkit.org/show_bug.cgi?id=202837

Unreviewed infrastructure repair.

This is a temporary strategy until we sort out our certificates on the newly
deployed Catalina bots.

  • Scripts/webkitpy/results/upload.py:

(Upload.upload):
(Upload.upload_archive):

  • Scripts/webkitpy/results/upload_unittest.py:

(UploadTest.test_upload):
(UploadTest.test_archive_upload):

5:25 PM Changeset in webkit [250996] by yurys@chromium.org
  • 64 edits in trunk/Source

Web Inspector: use more C++ keywords for defining agents
​https://bugs.webkit.org/show_bug.cgi?id=200959
<rdar://problem/54735374>

Reviewed by Joseph Pecoraro.

Add override annotation to overrided virtual methods in inspector code. This
change is automatically generated by the following command:
clang-tidy -checks='-*,modernize-use-override' -header-filter='.*inspector.*' -fix -p WebKitBuild/Release/

WebKitBuild/Release/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-84c9f43f-*.cpp
WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource-84c9f43f-*.cpp

Source/JavaScriptCore:

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptModule.h:
  • inspector/JSGlobalObjectConsoleClient.h:
  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectScriptDebugServer.h:
  • inspector/JSInjectedScriptHost.cpp:
  • inspector/ScriptDebugServer.h:
  • inspector/agents/InspectorAgent.h:
  • inspector/agents/InspectorAuditAgent.h:
  • inspector/agents/InspectorConsoleAgent.h:
  • inspector/agents/InspectorDebuggerAgent.h:
  • inspector/agents/InspectorHeapAgent.h:
  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/agents/InspectorScriptProfilerAgent.h:
  • inspector/agents/InspectorTargetAgent.h:
  • inspector/agents/JSGlobalObjectAuditAgent.h:
  • inspector/agents/JSGlobalObjectDebuggerAgent.h:
  • inspector/agents/JSGlobalObjectRuntimeAgent.h:
  • inspector/remote/RemoteAutomationTarget.h:
  • inspector/remote/RemoteConnectionToTarget.h:

Source/WebCore:

No new tests. No behavior changes.

  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/PageScriptDebugServer.h:
  • inspector/WebInjectedScriptManager.h:
  • inspector/WorkerInspectorController.h:
  • inspector/WorkerScriptDebugServer.h:
  • inspector/WorkerToPageFrontendChannel.h:
  • inspector/agents/InspectorApplicationCacheAgent.h:
  • inspector/agents/InspectorCPUProfilerAgent.h:
  • inspector/agents/InspectorCSSAgent.h:
  • inspector/agents/InspectorCanvasAgent.h:
  • inspector/agents/InspectorDOMAgent.h:
  • inspector/agents/InspectorDOMDebuggerAgent.h:
  • inspector/agents/InspectorDOMStorageAgent.h:
  • inspector/agents/InspectorDatabaseAgent.h:
  • inspector/agents/InspectorIndexedDBAgent.cpp:
  • inspector/agents/InspectorIndexedDBAgent.h:
  • inspector/agents/InspectorLayerTreeAgent.h:
  • inspector/agents/InspectorMemoryAgent.h:
  • inspector/agents/InspectorNetworkAgent.cpp:
  • inspector/agents/InspectorNetworkAgent.h:
  • inspector/agents/InspectorPageAgent.h:
  • inspector/agents/InspectorTimelineAgent.h:
  • inspector/agents/InspectorWorkerAgent.h:
  • inspector/agents/WebConsoleAgent.h:
  • inspector/agents/WebDebuggerAgent.h:
  • inspector/agents/WebHeapAgent.h:
  • inspector/agents/page/PageAuditAgent.h:
  • inspector/agents/page/PageConsoleAgent.h:
  • inspector/agents/page/PageDOMDebuggerAgent.h:
  • inspector/agents/page/PageDebuggerAgent.h:
  • inspector/agents/page/PageHeapAgent.h:
  • inspector/agents/page/PageNetworkAgent.h:
  • inspector/agents/page/PageRuntimeAgent.h:
  • inspector/agents/worker/ServiceWorkerAgent.h:
  • inspector/agents/worker/WorkerAuditAgent.h:
  • inspector/agents/worker/WorkerConsoleAgent.h:
  • inspector/agents/worker/WorkerDOMDebuggerAgent.h:
  • inspector/agents/worker/WorkerDebuggerAgent.h:
  • inspector/agents/worker/WorkerNetworkAgent.h:
  • inspector/agents/worker/WorkerRuntimeAgent.h:
4:44 PM Changeset in webkit [250995] by mark.lam@apple.com
  • 3 edits in trunk/JSTests

Modify JSTests/stress/string-overflow-createError-*.js tests to allow an OOME result.
​https://bugs.webkit.org/show_bug.cgi?id=202828

Reviewed by Yusuke Suzuki.

The tests intentionally allocate a very large string. Hence, for some memory
limited configurations, it is perfectly reasonable for the test to throw an Out
Of Memory error.

  • stress/string-overflow-createError-builder.js:
  • stress/string-overflow-createError-fit.js:
3:28 PM Changeset in webkit [250994] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

Use HAVE(IOSURFACE_RGB10) instead of PLATFORM(IOS_FAMILY) where appropriate
​https://bugs.webkit.org/show_bug.cgi?id=202823

Reviewed by Wenson Hsieh.

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::layerContentsFormat):

  • platform/ios/LegacyTileGridTile.mm:

(WebCore::LegacyTileGridTile::LegacyTileGridTile):

3:02 PM Changeset in webkit [250993] by clopez@igalia.com
  • 5 edits
    138 adds in trunk/LayoutTests

Import css/css-images WPT tests
​https://bugs.webkit.org/show_bug.cgi?id=200210

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Imported css/css-images tests from WPT ToT (a879756282) and generated expectations for the non ref-tests.

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/css/css-images/META.yml: Added.
  • web-platform-tests/css/css-images/css-image-fallbacks-and-annotations-expected.html: Added.
  • web-platform-tests/css/css-images/css-image-fallbacks-and-annotations.html: Added.
  • web-platform-tests/css/css-images/css-image-fallbacks-and-annotations002-expected.html: Added.
  • web-platform-tests/css/css-images/css-image-fallbacks-and-annotations002.html: Added.
  • web-platform-tests/css/css-images/css-image-fallbacks-and-annotations003-expected.html: Added.
  • web-platform-tests/css/css-images/css-image-fallbacks-and-annotations003.html: Added.
  • web-platform-tests/css/css-images/css-image-fallbacks-and-annotations004-expected.html: Added.
  • web-platform-tests/css/css-images/css-image-fallbacks-and-annotations004.html: Added.
  • web-platform-tests/css/css-images/css-image-fallbacks-and-annotations005-expected.html: Added.
  • web-platform-tests/css/css-images/css-image-fallbacks-and-annotations005.html: Added.
  • web-platform-tests/css/css-images/gradient-border-box-expected.html: Added.
  • web-platform-tests/css/css-images/gradient-border-box.html: Added.
  • web-platform-tests/css/css-images/gradient-button-expected.html: Added.
  • web-platform-tests/css/css-images/gradient-button.html: Added.
  • web-platform-tests/css/css-images/gradient-content-box-expected.html: Added.
  • web-platform-tests/css/css-images/gradient-content-box.html: Added.
  • web-platform-tests/css/css-images/gradient-crash-expected.html: Added.
  • web-platform-tests/css/css-images/gradient-crash.html: Added.
  • web-platform-tests/css/css-images/gradient-move-stops-expected.html: Added.
  • web-platform-tests/css/css-images/gradient-move-stops.html: Added.
  • web-platform-tests/css/css-images/gradient/color-stops-parsing-expected.txt: Added.
  • web-platform-tests/css/css-images/gradient/color-stops-parsing.html: Added.
  • web-platform-tests/css/css-images/gradient/w3c-import.log: Added.
  • web-platform-tests/css/css-images/gradients-with-border-expected.html: Added.
  • web-platform-tests/css/css-images/gradients-with-border.html: Added.
  • web-platform-tests/css/css-images/gradients-with-transparent-expected.html: Added.
  • web-platform-tests/css/css-images/gradients-with-transparent.html: Added.
  • web-platform-tests/css/css-images/idlharness-expected.txt: Added.
  • web-platform-tests/css/css-images/idlharness.html: Added.
  • web-platform-tests/css/css-images/image-fit-001.xht: Added.
  • web-platform-tests/css/css-images/image-fit-006.xht: Added.
  • web-platform-tests/css/css-images/inheritance-expected.txt: Added.
  • web-platform-tests/css/css-images/inheritance.html: Added.
  • web-platform-tests/css/css-images/linear-gradient-1-expected.html: Added.
  • web-platform-tests/css/css-images/linear-gradient-1.html: Added.
  • web-platform-tests/css/css-images/linear-gradient-2-expected.html: Added.
  • web-platform-tests/css/css-images/linear-gradient-2.html: Added.
  • web-platform-tests/css/css-images/multiple-position-color-stop-conic-expected.html: Added.
  • web-platform-tests/css/css-images/multiple-position-color-stop-conic.html: Added.
  • web-platform-tests/css/css-images/multiple-position-color-stop-linear-2-expected.html: Added.
  • web-platform-tests/css/css-images/multiple-position-color-stop-linear-2.html: Added.
  • web-platform-tests/css/css-images/multiple-position-color-stop-linear-expected.html: Added.
  • web-platform-tests/css/css-images/multiple-position-color-stop-linear.html: Added.
  • web-platform-tests/css/css-images/multiple-position-color-stop-radial-2-expected.html: Added.
  • web-platform-tests/css/css-images/multiple-position-color-stop-radial-2.html: Added.
  • web-platform-tests/css/css-images/multiple-position-color-stop-radial-expected.html: Added.
  • web-platform-tests/css/css-images/multiple-position-color-stop-radial.html: Added.
  • web-platform-tests/css/css-images/parsing/gradient-position-invalid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/gradient-position-invalid.html: Added.
  • web-platform-tests/css/css-images/parsing/gradient-position-valid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/gradient-position-valid.html: Added.
  • web-platform-tests/css/css-images/parsing/image-orientation-computed-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/image-orientation-computed.html: Added.
  • web-platform-tests/css/css-images/parsing/image-orientation-invalid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/image-orientation-invalid.html: Added.
  • web-platform-tests/css/css-images/parsing/image-orientation-valid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/image-orientation-valid.html: Added.
  • web-platform-tests/css/css-images/parsing/image-rendering-computed-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/image-rendering-computed.html: Added.
  • web-platform-tests/css/css-images/parsing/image-rendering-invalid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/image-rendering-invalid.html: Added.
  • web-platform-tests/css/css-images/parsing/image-rendering-valid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/image-rendering-valid.html: Added.
  • web-platform-tests/css/css-images/parsing/image-resolution-invalid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/image-resolution-invalid.html: Added.
  • web-platform-tests/css/css-images/parsing/image-resolution-valid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/image-resolution-valid.html: Added.
  • web-platform-tests/css/css-images/parsing/object-fit-computed-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/object-fit-computed.html: Added.
  • web-platform-tests/css/css-images/parsing/object-fit-invalid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/object-fit-invalid.html: Added.
  • web-platform-tests/css/css-images/parsing/object-fit-valid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/object-fit-valid.html: Added.
  • web-platform-tests/css/css-images/parsing/object-position-computed-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/object-position-computed.html: Added.
  • web-platform-tests/css/css-images/parsing/object-position-invalid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/object-position-invalid.html: Added.
  • web-platform-tests/css/css-images/parsing/object-position-valid-expected.txt: Added.
  • web-platform-tests/css/css-images/parsing/object-position-valid.html: Added.
  • web-platform-tests/css/css-images/parsing/w3c-import.log: Added.
  • web-platform-tests/css/css-images/support/1x1-green.gif: Added.
  • web-platform-tests/css/css-images/support/1x1-green.png: Added.
  • web-platform-tests/css/css-images/support/1x1-green.svg: Added.
  • web-platform-tests/css/css-images/support/1x1-lime.png: Added.
  • web-platform-tests/css/css-images/support/1x1-maroon.png: Added.
  • web-platform-tests/css/css-images/support/1x1-navy.png: Added.
  • web-platform-tests/css/css-images/support/1x1-red.png: Added.
  • web-platform-tests/css/css-images/support/1x1-white.png: Added.
  • web-platform-tests/css/css-images/support/60x60-gg-rr.png: Added.
  • web-platform-tests/css/css-images/support/60x60-green.png: Added.
  • web-platform-tests/css/css-images/support/60x60-red.png: Added.
  • web-platform-tests/css/css-images/support/a-green.css: Added.

(.a):

  • web-platform-tests/css/css-images/support/b-green.css: Added.

(.b):

  • web-platform-tests/css/css-images/support/c-red.css: Added.

(.c):

  • web-platform-tests/css/css-images/support/cat.png: Added.
  • web-platform-tests/css/css-images/support/import-green.css: Added.

(.import):

  • web-platform-tests/css/css-images/support/import-red.css: Added.

(.import):

  • web-platform-tests/css/css-images/support/intrinsic-size.jpg: Added.
  • web-platform-tests/css/css-images/support/intrinsic-size.png: Added.
  • web-platform-tests/css/css-images/support/pattern-grg-rgr-grg.png: Added.
  • web-platform-tests/css/css-images/support/pattern-grg-rrg-rgg.png: Added.
  • web-platform-tests/css/css-images/support/pattern-rgr-grg-rgr.png: Added.
  • web-platform-tests/css/css-images/support/pattern-tr.png: Added.
  • web-platform-tests/css/css-images/support/ruler-h-50%.png: Added.
  • web-platform-tests/css/css-images/support/ruler-h-50px.png: Added.
  • web-platform-tests/css/css-images/support/ruler-v-100px.png: Added.
  • web-platform-tests/css/css-images/support/ruler-v-50px.png: Added.
  • web-platform-tests/css/css-images/support/square-purple.png: Added.
  • web-platform-tests/css/css-images/support/square-teal.png: Added.
  • web-platform-tests/css/css-images/support/square-white.png: Added.
  • web-platform-tests/css/css-images/support/support/swatch-green.png: Added.
  • web-platform-tests/css/css-images/support/support/swatch-red.png: Added.
  • web-platform-tests/css/css-images/support/support/w3c-import.log: Added.
  • web-platform-tests/css/css-images/support/swatch-blue.png: Added.
  • web-platform-tests/css/css-images/support/swatch-green.png: Added.
  • web-platform-tests/css/css-images/support/swatch-lime.png: Added.
  • web-platform-tests/css/css-images/support/swatch-orange.png: Added.
  • web-platform-tests/css/css-images/support/swatch-red.png: Added.
  • web-platform-tests/css/css-images/support/swatch-white.png: Added.
  • web-platform-tests/css/css-images/support/swatch-yellow.png: Added.
  • web-platform-tests/css/css-images/support/test-bl.png: Added.
  • web-platform-tests/css/css-images/support/test-br.png: Added.
  • web-platform-tests/css/css-images/support/test-inner-half-size.png: Added.
  • web-platform-tests/css/css-images/support/test-outer.png: Added.
  • web-platform-tests/css/css-images/support/test-tl.png: Added.
  • web-platform-tests/css/css-images/support/test-tr.png: Added.
  • web-platform-tests/css/css-images/support/w3c-import.log: Added.
  • web-platform-tests/css/css-images/tiled-gradients-expected.html: Added.
  • web-platform-tests/css/css-images/tiled-gradients.html: Added.
  • web-platform-tests/css/css-images/tiled-radial-gradients-expected.html: Added.
  • web-platform-tests/css/css-images/tiled-radial-gradients.html: Added.
  • web-platform-tests/css/css-images/w3c-import.log: Added.

LayoutTests:

Import css/css-images tests

  • TestExpectations: Mark the new imported ref-tests that fail and a test that crashes.
2:57 PM Changeset in webkit [250992] by clopez@igalia.com
  • 2 edits in trunk/Tools

W3C test importer breaks svg files.
​https://bugs.webkit.org/show_bug.cgi?id=202806

Reviewed by Jonathan Bedard.

The WebKit W3C importer tries to rewrite the xml/html/css files
when importing the tests to rewrite paths and such.

The issue is that to decide if rewrite the file or not uses the
mimetype and the current code was comparing for something like
if "xml" in str(mimetype[0])

But svg files have mimetype "image/svg+xml" so the previous code
was trying to rewrite svg files, breaking them.

This patches changes that code to only rewrite if the mimetype
also contains the "application/" or "text/" string.

It also adds an info log (printed when verbose enabled) to tell
that a file has been rewritten.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.import_tests):

2:57 PM Changeset in webkit [250991] by Devin Rousso
  • 17 edits
    6 deletes in trunk/Source/WebInspectorUI

Web Inspector: Sources: enable tab by default
​https://bugs.webkit.org/show_bug.cgi?id=202341

Reviewed by Joseph Pecoraro.

The experimental Sources Tab has progressed enough that it can be enabled by default. There
are some new features that are only available in the Sources Tab that are also ready to be
used (e.g. local resource overrides).

  • UserInterface/Main.html:
  • UserInterface/Base/Main.js:

(WI.loaded):

  • UserInterface/Base/Setting.js:
  • UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.showResources):

  • UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager):
(WI.NetworkManager.supportsLocalResourceOverrides):

  • UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForURL):

  • UserInterface/Views/DefaultDashboardView.js:

(WI.DefaultDashboardView.prototype._resourcesItemWasClicked):

  • UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement.prototype.populateContextMenu):

  • UserInterface/Views/SearchResultTreeElement.js:

(WI.SearchResultTreeElement.prototype.populateContextMenu):

  • UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype._populateIconElementContextMenu):

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/SourcesTabContentView.js:

(WI.SourcesTabContentView.isTabAllowed): Deleted.

  • UserInterface/Views/DebuggerSidebarPanel.css: Removed.
  • UserInterface/Views/DebuggerSidebarPanel.js: Removed.
  • UserInterface/Views/DebuggerTabContentView.js: Removed.
  • UserInterface/Views/ResourceSidebarPanel.css: Removed.
  • UserInterface/Views/ResourceSidebarPanel.js: Removed.
  • UserInterface/Views/ResourcesTabContentView.js: Removed.

Remove the experimental setting, as well as code for the Resources Tab and the Debugger Tab.

  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
2:56 PM Changeset in webkit [250990] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Catalina] LayoutTest fast/canvas/webgl/texImage2D-mse-flip-{true,false}.html failing
​https://bugs.webkit.org/show_bug.cgi?id=202771
<rdar://problem/49441298>

Reviewed by Eric Carlson.

Catalina no longer creates IOSurface-backed CVPixelBuffers by default for certain
codecs; make the CVPixelBuffers generated by WebCoreDecompressionSession IOSurface-backed
explicitly by passing in the correct attributes when creating the VTDecompressionSession.

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample):

2:38 PM Changeset in webkit [250989] by mmaxfield@apple.com
  • 4 edits in trunk

[Cocoa] font-family:system-ui on Chinese systems don't get Chinese quote marks
​https://bugs.webkit.org/show_bug.cgi?id=202778
<rdar://problem/52594556>

Reviewed by Simon Fraser.

Source/WebCore:

This was caught by fast/text/international/system-language/han-quotes.html,
but we didn't have time to fix it until now.

Test: fast/text/international/system-language/han-quotes.html

  • platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:

(WebCore::SystemFontDatabaseCoreText::createSystemUIFont):

LayoutTests:

  • platform/mac/TestExpectations:
2:20 PM Changeset in webkit [250988] by Basuke Suzuki
  • 11 edits in trunk/Source

[WinCairo] Move remote communication handling from RemoteInspectorServer to RemoteInspector.
​https://bugs.webkit.org/show_bug.cgi?id=202763

Reviewed by Ross Kirsling.

Source/JavaScriptCore:

Because RemoteInspector now exists in UIProcess, the old implementation which communicate with RemoteInspector
in WebProcess and RemoteInspectorServer in UIProcess was meaningless or even bad. Remove this complex
implementation and move communication handling from RemoteInspectorServer to RemoteInspector and communicate
each other directly.

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/socket/RemoteInspectorConnectionClient.cpp:
  • inspector/remote/socket/RemoteInspectorConnectionClient.h:
  • inspector/remote/socket/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::~RemoteInspectorServer):
(Inspector::RemoteInspectorServer::start):
(Inspector::RemoteInspectorServer::didAccept):

  • inspector/remote/socket/RemoteInspectorServer.h:
  • inspector/remote/socket/RemoteInspectorSocket.cpp:

(Inspector::RemoteInspector::connect):
(Inspector::RemoteInspector::didClose):
(Inspector::RemoteInspector::sendWebInspectorEvent):
(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::pushListingsNow):
(Inspector::RemoteInspector::pushListingsSoon):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::setup):
(Inspector::RemoteInspector::sendMessageToTarget):
(Inspector::RemoteInspector::backendCommands const):
(Inspector::RemoteInspector::dispatchMap):
(Inspector::RemoteInspector::setupInspectorClient):
(Inspector::RemoteInspector::setupTarget):
(Inspector::RemoteInspector::frontendDidClose):
(Inspector::RemoteInspector::sendMessageToBackend):

  • inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:

(Inspector::RemoteInspectorSocketEndpoint::~RemoteInspectorSocketEndpoint):
(Inspector::RemoteInspectorSocketEndpoint::listenInet):
(Inspector::RemoteInspectorSocketEndpoint::isListening):
(Inspector::RemoteInspectorSocketEndpoint::workerThread):
(Inspector::RemoteInspectorSocketEndpoint::generateConnectionID):
(Inspector::RemoteInspectorSocketEndpoint::makeConnection):
(Inspector::RemoteInspectorSocketEndpoint::createClient):
(Inspector::RemoteInspectorSocketEndpoint::createListener):
(Inspector::RemoteInspectorSocketEndpoint::invalidateListener):
(Inspector::RemoteInspectorSocketEndpoint::getPort const):
(Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled):

  • inspector/remote/socket/RemoteInspectorSocketEndpoint.h:

Source/WebKit:

Remove deleted method invocations.

  • UIProcess/win/WebProcessPoolWin.cpp:

(WebKit::initializeRemoteInspectorServer):
(WebKit::WebProcessPool::platformInitialize):

1:30 PM Changeset in webkit [250987] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed, tweak test to address flakiness on WK1.

  • media/media-source/media-source-page-cache-expected.txt:
  • media/media-source/media-source-page-cache.html:
1:29 PM Changeset in webkit [250986] by Jonathan Bedard
  • 2 edits in trunk/Tools

results.webkit.org: Serve correct exit codes when aborting
​https://bugs.webkit.org/show_bug.cgi?id=202817

Rubber-stamped by Aakash Jain.

  • resultsdbpy/resultsdbpy/view/view_routes.py:

(ViewRoutes.error): Return exit code along with html string.

12:52 PM Changeset in webkit [250985] by youenn@apple.com
  • 7 edits
    3 adds in trunk

Do not timeout a load intercepted by service worker that receives a response
​https://bugs.webkit.org/show_bug.cgi?id=202787

Reviewed by Chris Dumez.

Source/WebKit:

Stop making ServiceWorkerFetchTask ref counted since it is not needed and
can potentially make ServiceWorkerFetchTask oulive its WebSWServerToContextConnection member.

Stop the ServiceWorkerFetchTask timeout timer whenever receiving a response so that the load will not timeout in that case.
This ensures that a load that is starting in a service worker will not be failing.
Instead the load will go to network process.

Removed m_didReachTerminalState which is not needed as WebSWServerToContextConnection unregisters the ServiceWorkerFetchTask
as an IPC listener for all terminating messages.

  • NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::didReceiveRedirectResponse):
(WebKit::ServiceWorkerFetchTask::didReceiveResponse):
(WebKit::ServiceWorkerFetchTask::didReceiveData):
(WebKit::ServiceWorkerFetchTask::didReceiveFormData):
(WebKit::ServiceWorkerFetchTask::didFinish):
(WebKit::ServiceWorkerFetchTask::didFail):
(WebKit::ServiceWorkerFetchTask::didNotHandle):
(WebKit::ServiceWorkerFetchTask::timeoutTimerFired):

  • NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
  • NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::startFetch):
(WebKit::WebSWServerToContextConnection::fetchTaskTimedOut):
Use a Vector instead of a HasSet for performance reasons.
Update according fetch map using unique_ptr instead of Ref<>.

  • NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:

LayoutTests:

  • http/wpt/service-workers/fetch-timeout-worker.js: Added.

(async.doTest):

  • http/wpt/service-workers/fetch-timeout.https-expected.txt: Added.
  • http/wpt/service-workers/fetch-timeout.https.html: Added.
  • http/wpt/service-workers/resources/lengthy-pass.py:

(main):

12:49 PM Changeset in webkit [250984] by Matt Lewis
  • 2 edits in trunk/Tools

Emergency unittest fix for wkbuild.

Unreviewed test fix.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

(ShouldBuildTest):

12:42 PM Changeset in webkit [250983] by mmaxfield@apple.com
  • 3 edits
    4 adds in trunk

FontFaceSet's ready promise is not always resolved
​https://bugs.webkit.org/show_bug.cgi?id=202548

Reviewed by Youenn Fablet.

Source/WebCore:

When we do layout on an element, FontRanges::glyphDataForCharacter() will cause the first
available font to start loading, but will continue looking at subsequent fonts to see if
there's a good one we can render while the load is happening. When looking for a fallback
font, it calls FontRanges::Range::font() with a ExternalResourceDownloadPolicy set to
Forbid. This is fine, except that a side effect of calling this function is that the
CSSFontFace marks itself as Loading, which means document.fonts.ready is deferred. Then,
the load finishes, and the subsequent CSSFontFace is never actually used, meaning it never
exits the Loading state, which means document.fonts.ready never fires.

The solution to this is to just only allow the font to enter the Loading state if it's not
one of these "subsequent" fonts.

Test: fast/text/fontfaceset-ready-not-fired.html

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::pump):

LayoutTests:

  • fast/text/fontfaceset-ready-not-fired-expected.txt: Added.
  • fast/text/fontfaceset-ready-not-fired.html: Added.
  • fast/text/fontfaceset-ready-not-fired-2-expected.txt: Added.
  • fast/text/fontfaceset-ready-not-fired-2.html: Added.
12:40 PM Changeset in webkit [250982] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, speculative fix build failure on 32bit
​https://bugs.webkit.org/show_bug.cgi?id=202569

  • llint/LowLevelInterpreter32_64.asm:
11:44 AM Changeset in webkit [250981] by aakash_jain@apple.com
  • 4 edits in trunk/Tools

Updated new Catalina queues names as per new Buildbot naming scheme
​https://bugs.webkit.org/show_bug.cgi?id=202816

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Renamed builder name and removed spaces.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Ditto.
  • BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
11:42 AM Changeset in webkit [250980] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

MockRealtimeVideoSource::setFrameRateWithPreset should not use preset after moving it
​https://bugs.webkit.org/show_bug.cgi?id=202800

Reviewed by Alexey Proskuryakov.

This does not affect behavior right now since clients typically get the intrinsic size through media samples.
But this could create some inconsistencies.

  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::setFrameRateWithPreset):

11:35 AM Changeset in webkit [250979] by Matt Lewis
  • 3 edits in trunk/Tools

Fixing build scheduling for Catalina queues.
​https://bugs.webkit.org/show_bug.cgi?id=202814

Reviewed by Aakash Jain.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Drive By fix of Trigger.
  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

11:23 AM Changeset in webkit [250978] by Wenson Hsieh
  • 2 edits in trunk/LayoutTests

pointerevents/ios/touch-action-pinch-zoom-allows-zooming.html is failing after r250361
​https://bugs.webkit.org/show_bug.cgi?id=202777
<rdar://problem/56128421>

Reviewed by Tim Horton.

This layout test is intended to verify that pinching to zoom out in an element with touch-action: pinch-zoom
will cause the page scale to change (i.e. decrease). This test works on iPhone, where the initial-scale meta
viewport property is respected. However, a desktop viewport configuration is used by default on iPad, which
ignores the initial-scale property by default.

Prior to r250361, we would always try and scale down content to fit within the viewport, such that the initial
scale in this layout test on iPad would be approximately 0.384; this meant that the test would pass, regardless
of whether it even attempted to pinch zoom at all, since it would always pass the pageScale != 1 assertion.

However, after r250361, we now no longer attempt to scale down to fit the viewport when the content width is
excessively large (the maximum width breakpoint is 1920px), which makes the initial scale 1. This layout test
makes the content width 2000px, which exceeds this maximum width limit and causes us to avoid shrinking to fit.
This means that we'll end up failing the pageScale assertion and timing out as a result.

To fix this, simply mark the test as contentMode=mobile, such that even on iPad, we'll respect the
initial-scale meta viewport property, and the test will actually pinch to zoom the page out as expected.

  • pointerevents/ios/touch-action-pinch-zoom-allows-zooming.html:
11:04 AM Changeset in webkit [250977] by Devin Rousso
  • 5 edits in trunk/Source/WebCore

Web Inspector: Timelines: don't call willDispatchEvent/didDispatchEvent unless there is a listener for the event
​https://bugs.webkit.org/show_bug.cgi?id=202713

Reviewed by Joseph Pecoraro.

Fixes failing inspector/timeline/timeline-recording.html after r250672. This was because the
InspectorTimelineAgent expected a corresponding willDispatchEvent before it was told
about the didDispatchEvent, which wasn't happening since only willDispatchEvent would
early-return if the DOMWindow didn't have any event listeners for the dispatched event. By
making the DOMWindow::dispatchEvent itself early-return in that case, it now handles both
willDispatchEvent and didDispatchEvent, ensuring that they are always called in pairs.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchEvent):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::innerInvokeEventListeners):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willDispatchEvent):
(WebCore::InspectorInstrumentation::didDispatchEvent):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::didDispatchEventOnWindow):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willDispatchEventImpl):
(WebCore::InspectorInstrumentation::didDispatchEventImpl):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::didDispatchEventOnWindowImpl):
InspectorInstrumentation::willDispatchEventImpl was always called with hasEventListeners
as true, so there's no reason to keep that parameter around. Similarly, the change inside
DOMWindow::dispatchEvent will make it so that the same is true for
InspectorInstrumentation::willDispatchEventOnWindowImpl as well.

10:17 AM Changeset in webkit [250976] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Flaky Test: media/media-source/media-source-page-cache.html
​https://bugs.webkit.org/show_bug.cgi?id=202775

Reviewed by Eric Carlson.

SourceBufferList should never prevent entering the page cache, even if it has
pending events in its queue. Its queue is a MainThreadGenericEventQueue, which
is Page Cache-aware and will properly suspend the firing of events when needed.

No new tests, covered by flaky test which should no longer be.

  • Modules/mediasource/SourceBufferList.cpp:

(WebCore::SourceBufferList::canSuspendForDocumentSuspension const):

9:57 AM Changeset in webkit [250975] by sihui_liu@apple.com
  • 4 edits
    1 add in trunk

Add a unit test for StorageQuotaManager
​https://bugs.webkit.org/show_bug.cgi?id=202755

Reviewed by Youenn Fablet.

Source/WebCore:

Expose state of StorageQuotaManager for newly added unit test.

  • storage/StorageQuotaManager.h:

(WebCore::StorageQuotaManager::state const):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/StorageQuotaManager.cpp: Added.

(TestWebKitAPI::TEST):

9:37 AM Changeset in webkit [250974] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

SpeculativeLoad should use CompletionHandler
​https://bugs.webkit.org/show_bug.cgi?id=202795

Patch by Rob Buis <​rbuis@igalia.com> on 2019-10-10
Reviewed by Chris Dumez.

SpeculativeLoad should use CompletionHandler, as remarked in
Bug 201641 review.

  • NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
9:17 AM Changeset in webkit [250973] by Wenson Hsieh
  • 34 edits
    8 copies
    5 adds
    1 delete in trunk

Support programmatic paste requests on macOS
​https://bugs.webkit.org/show_bug.cgi?id=202773
<rdar://problem/48957166>

Reviewed by Tim Horton.

Source/WebCore:

Adds support for programmatic paste requests on macOS. See below for more details.

Tests: editing/pasteboard/dom-paste/dom-paste-confirmation.html

editing/pasteboard/dom-paste/dom-paste-consecutive-confirmations.html
editing/pasteboard/dom-paste/dom-paste-rejection.html
editing/pasteboard/dom-paste/dom-paste-requires-user-gesture.html
editing/pasteboard/dom-paste/dom-paste-same-origin.html

  • editing/EditorCommand.cpp:

(WebCore::defaultValueForSupportedPaste):
(WebCore::supportedPaste):
(WebCore::allowPasteFromDOM):
(WebCore::enabledPaste):

Fixes an existing bug uncovered by the layout test editing/execCommand/clipboard-access.html, which tests the
results of document.queryCommandEnabled("copy") and document.queryCommandEnabled("paste"). The problem here
is that document.queryCommandEnabled("paste") returns true if DOM paste access requests are enabled, regardless
of whether or not there is an active user gesture. This is inconsistent with the behavior of "copy" and "cut",
which return false in the case where there is no user gesture (and the clipboard access policy is also equal to
ClipboardAccessPolicy::RequiresUserGesture -- refer to allowCopyCutFromDOM).

When pasting, we only DOM paste access requests to be triggered only in the case where there is a user gesture.
This means that enabledPaste should additionally be gated on a user gesture check. For consistency with the
implementation of enabledCopy, we introduce a allowPasteFromDOM helper that is similar to
allowCopyCutFromDOM, and additionally check this constraint when the paste command's source is the DOM (as
opposed to a menu or key binding).

This adjustment also adds a missing canDHTMLPaste() check prior to consulting canPaste(). This ensures that when
evaluating document.queryCommandEnabled("Paste"), we'll dispatch a "beforepaste" event, similar to how
evaluating document.queryCommandEnabled("Copy") dispatches a "beforecopy" event.

  • platform/LocalizedStrings.h:

Mark a function as WEBCORE_EXPORT.

Source/WebKit:

Adds support for programmatic paste requests on macOS, as well as some testing SPI in WKWebView to allow
WebKitTestRunner to grab the NSMenu used for the DOM paste request. This patch adopts the same strategy taken to
allow programmatic paste on iOS, by allowing programmatic pastes coming from the page to show platform UI which
the user must then interact with in order to proceed with the paste. See below for more details.

  • Shared/WebPreferencesDefaultValues.h:

Make this available on both iOS and macOS (iOS family is omitted for now, since callout bar UI is not generally
present on non-iOS iOS-family platforms such as Apple Watch).

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _web_grantDOMPasteAccess]):

This selector is called when the user taps the Paste option in the presented NSMenu.

(-[WKWebView _activeMenu]):

Returns the currently active NSMenu. Only for testing purposes.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _web_grantDOMPasteAccess]):

Same exercise as above, only for WKView instead of WKWebView.

  • UIProcess/Cocoa/WebViewImpl.h:

(WebKit::WebViewImpl::domPasteMenu const):

  • UIProcess/Cocoa/WebViewImpl.mm:

(-[WKDOMPasteMenuDelegate initWithWebViewImpl:]):
(-[WKDOMPasteMenuDelegate menuDidClose:]):
(-[WKDOMPasteMenuDelegate numberOfItemsInMenu:]):
(-[WKDOMPasteMenuDelegate confinementRectForMenu:onScreen:]):

Adds a new object, whose purpose is to be a delegate for the NSMenu that is presented when requesting DOM paste
access. This object is used instead of WKWebView, since API clients may end up making the WKWebView the delegate
for a different menu, in which case some implementations (either theirs or ours) of NSMenuDelegate methods would
not be called. Avoiding this would require the client to be aware that WKWebView conforms to NSMenuDelegate,
which is only declared privately.

(WebKit::WebViewImpl::handleProcessSwapOrExit):

On process swap or exit, automatically bail out of any pending DOM paste request by denying it.

(WebKit::WebViewImpl::requestDOMPasteAccess):
(WebKit::WebViewImpl::handleDOMPasteRequestWithResult):

Handle the DOM paste request by showing an NSMenu near the mouse cursor with a single option to paste.

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::requestDOMPasteAccess):

Tools:

Adds new testing support to enable us to test programmatic paste requests on macOS.

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:

Add a few new UIScriptController methods:

  • activateAtPoint(x, y, callback): used to activate content underneath at (x, y), in root view coordinates (WKWebView on macOS, and WKContentView on iOS). On macOS, this moves the mouse to the given location and clicks.
  • chooseMenuAction(action, callback): used to select a menu item with the given title.
  • dismissMenu(): dismisses the platform menu.

Note that dismissMenu and chooseMenuAction currently only work for the DOM paste menu, but could be extended in
the future to handle the system context menu.

  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::dismissMenu):
(WTR::UIScriptController::chooseMenuAction):

  • TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::activateAtPoint):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView initWithFrame:configuration:]):
(-[TestRunnerWKWebView _didShowMenu]):
(-[TestRunnerWKWebView _didHideMenu]):

Make these present across both macOS and iOS. On macOS, we listen for NSMenuDidBeginTrackingNotification and
NSMenuDidEndTrackingNotification to know when a menu has been shown or dismissed.

(-[TestRunnerWKWebView dismissActiveMenu]):
(-[TestRunnerWKWebView resetInteractionCallbacks]):

Make these available on both iOS and macOS. The only interaction callbacks on macOS are currently
didShowMenuCallback and didHideMenuCallback.

(-[TestRunnerWKWebView _willHideMenu]):

  • WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
  • WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::setDidShowMenuCallback):
(WTR::UIScriptControllerCocoa::setDidHideMenuCallback):
(WTR::UIScriptControllerCocoa::dismissMenu):
(WTR::UIScriptControllerCocoa::isShowingMenu const):

Move these implementations into UIScriptControllerCocoa, from UIScriptControllerIOS.

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):

Instead of clearing all interaction callbacks in TestControllerIOS, do it in TestControllerCocoa where it
affects both macOS and iOS.

  • WebKitTestRunner/ios/UIScriptControllerIOS.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::activateAtPoint):
(WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
(WTR::UIScriptControllerIOS::chooseMenuAction):
(WTR::UIScriptControllerIOS::rectForMenuAction const):
(WTR::UIScriptControllerIOS::setDidShowMenuCallback): Deleted.
(WTR::UIScriptControllerIOS::setDidHideMenuCallback): Deleted.
(WTR::UIScriptControllerIOS::isShowingMenu const): Deleted.

Abstract rectForMenuAction and singleTapAtPointWithModifiers out into private helper methods, such that they can
be used from within other script controller methods.

  • WebKitTestRunner/mac/UIScriptControllerMac.h:
  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

Implement the new script controller hooks on macOS.

(WTR::UIScriptControllerMac::clearAllCallbacks):
(WTR::UIScriptControllerMac::chooseMenuAction):
(WTR::UIScriptControllerMac::activateAtPoint):

LayoutTests:

Refactors existing layout tests for programmatic paste requests on iOS, such that they now run in both iOS and
macOS. See below for more details.

  • TestExpectations:
  • editing/pasteboard/dom-paste/dom-paste-confirmation-expected.txt: Renamed from LayoutTests/editing/pasteboard/ios/dom-paste-confirmation-expected.txt.
  • editing/pasteboard/dom-paste/dom-paste-confirmation.html: Renamed from LayoutTests/editing/pasteboard/ios/dom-paste-confirmation.html.
  • editing/pasteboard/dom-paste/dom-paste-consecutive-confirmations-expected.txt: Added.
  • editing/pasteboard/dom-paste/dom-paste-consecutive-confirmations.html: Renamed from LayoutTests/editing/pasteboard/ios/dom-paste-consecutive-confirmations.html.
  • editing/pasteboard/dom-paste/dom-paste-rejection-expected.txt: Added.
  • editing/pasteboard/dom-paste/dom-paste-rejection.html: Renamed from LayoutTests/editing/pasteboard/ios/dom-paste-rejection.html.
  • editing/pasteboard/dom-paste/dom-paste-requires-user-gesture-expected.txt: Renamed from LayoutTests/editing/pasteboard/ios/dom-paste-requires-user-gesture-expected.txt.
  • editing/pasteboard/dom-paste/dom-paste-requires-user-gesture.html: Renamed from LayoutTests/editing/pasteboard/ios/dom-paste-requires-user-gesture.html.
  • editing/pasteboard/dom-paste/dom-paste-same-origin-expected.txt: Renamed from LayoutTests/editing/pasteboard/ios/dom-paste-same-origin-expected.txt.
  • editing/pasteboard/dom-paste/dom-paste-same-origin.html: Renamed from LayoutTests/editing/pasteboard/ios/dom-paste-same-origin.html.
  • editing/pasteboard/dom-paste/resources/dom-paste-helper.js: Added.

Re-word some of these layout tests' descriptions to reference "clicks or taps", instead of just "taps", and also
replace mentions of "callout bars" with platform-agnostic "menus".

(return.new.Promise.):
(async._waitForOrTriggerPasteMenu):
(async.triggerPasteMenuAfterActivatingLocation):
(async.waitForPasteMenu):

Refactor these testing helpers to support both iOS and macOS:

(1) Replace code that finds callout bar menu items and synthesizes taps on iOS, with code that instead chooses a
menu item with the given title (in this case, "Paste"). This is supported on both macOS and iOS, where we invoke
the NSMenuItem's action and dismiss the menu item, and find and tap the callout bar menu item, respectively.

(2) Implement UIScriptController::activateAtPoint, which is used as a cross-platform way of activating an
element at the given point. On iOS, this taps the given location, and on macOS, this moves the mouse to that
location and then simulates a click (mouse down and mouse up). In a subsequent patch, we should additionally use
this in the implementation of UIHelper.activateAt().

  • editing/pasteboard/ios/dom-paste-consecutive-confirmations-expected.txt: Removed.
  • editing/pasteboard/ios/dom-paste-rejection-expected.txt: Removed.
  • editing/pasteboard/ios/resources/dom-paste-helper.js: Removed.
  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:

Skip editing/pasteboard/dom-paste everywhere for now, except for macOS and iOS WebKit2.

8:56 AM Changeset in webkit [250972] by youenn@apple.com
  • 64 edits
    47 adds
    14 deletes in trunk/Source/ThirdParty/libwebrtc

Update libwebrtc third-party jsoncpp to M78
​https://bugs.webkit.org/show_bug.cgi?id=202729

Reviewed by Eric Carlson.

  • Source/third_party/jsoncpp: Updated.
8:31 AM Changeset in webkit [250971] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[GTK][WPE] Lots of media related tests crashing or flaky after r250918 - [ Mac WK2 ] Layout Test fast/mediastream/MediaStreamTrack-getSettings.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=202784

Unreviewed, fix GTK and WPE test crashes.

  • platform/mediastream/gstreamer/MockGStreamerAudioCaptureSource.cpp:

(WebCore::WrappedMockRealtimeAudioSource::render): Reconfigure if necessary.
(WebCore::WrappedMockRealtimeAudioSource::reconfigure): New, setup for rendering.
(WebCore::WrappedMockRealtimeAudioSource::settingsDidChange): Call reconfigure.

8:19 AM Changeset in webkit [250970] by Jonathan Bedard
  • 2 edits in trunk/Tools

results.webkit.org: Increase default limit for test results (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=202757

Unreviewed follow-up fix.

  • resultsdbpy/resultsdbpy/view/templates/commits.html: Switch default and maximum limits.
8:15 AM Changeset in webkit [250969] by youenn@apple.com
  • 13 edits in trunk/Source

Remove unified plan runtime flag
​https://bugs.webkit.org/show_bug.cgi?id=202721

Reviewed by Geoffrey Garen.

Source/WebCore:

Covered by existing tests.

  • Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::RTCRtpSender):

  • Modules/mediastream/RTCRtpTransceiver.idl:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::setConfiguration):
(WebCore::LibWebRTCMediaEndpoint::addTrack):
(WebCore::LibWebRTCMediaEndpoint::doCreateOffer):
(WebCore::LibWebRTCMediaEndpoint::collectTransceivers):
(WebCore::LibWebRTCMediaEndpoint::removeRemoteTrack):
(WebCore::LibWebRTCMediaEndpoint::OnTrack):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::addTrack):
(WebCore::LibWebRTCPeerConnectionBackend::addTransceiverFromTrackOrKind):
(WebCore::LibWebRTCPeerConnectionBackend::addTransceiver):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
  • Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

(WebCore::LibWebRTCRtpSenderBackend::replaceTrack):

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebRTCVP8CodecEnabled):

  • testing/Internals.cpp:

(WebCore::Internals::useMockRTCPeerConnectionFactory):

Source/WebKit:

  • Shared/WebPreferences.yaml:
  • UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsConstructed): Remove ability to disable unified plan.

8:14 AM Changeset in webkit [250968] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Flaky Test: imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.floatsource.html
​https://bugs.webkit.org/show_bug.cgi?id=202782

Patch by Chris Lord <Chris Lord> on 2019-10-10
Reviewed by Youenn Fablet.

Some OffscreenCanvas tests are failing due to unhandled Promise
rejection from unimplemented API. Mark this, and other tests that are
affected with DumpJSConsoleLogInStdErr.

7:57 AM Changeset in webkit [250967] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

Remove a "The " in "The The HTTP headers of the response"
​https://bugs.webkit.org/show_bug.cgi?id=194851

Reviewed by Carlos Garcia Campos.

  • Shared/API/glib/WebKitURIResponse.cpp:

(webkit_uri_response_class_init): Fix typo in description of the WebKitURIResponse::http-headers property.

7:47 AM Changeset in webkit [250966] by Jonathan Bedard
  • 6 edits in trunk/Tools

results.webkit.org: Start reporting results
​https://bugs.webkit.org/show_bug.cgi?id=202639

Reviewed by Dewei Zhu.

  • BuildSlaveSupport/build.webkit.org-config/loadConfig.py:

(loadBuilderConfig): Load API key for results.webkit.org.

  • BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:

(create_mock_slave_passwords_dict): Add mock for API key.

  • BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunWebKitTests): Start reporting to results.webkit.org.
(RunWebKitTests.init): Do not print the environment to hide the API key.
(RunWebKitTests.start): Add the API key to the environment.
(RunAPITests): Start reporting to results.webkit.org.
(RunAPITests.init): Do not print the environment to hide the API key.
(RunAPITests.start): Add the API key to the environment.
(RunPythonTests): Start reporting to results.webkit.org.
(RunPythonTests.init): Do not print the environment to hide the API key.
(RunPythonTests.start): Add the API key to the environment.

  • Scripts/webkitpy/results/upload.py:

(Upload):
(Upload.upload): Add API_KEY, if it exists, to the request.
(Upload.upload_archive): Ditto.

7:24 AM Changeset in webkit [250965] by Chris Dumez
  • 7 edits
    2 adds in trunk

DOMCacheStorage should not prevent pages from entering the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=202608

Reviewed by Youenn Fablet.

Source/WebCore:

Make DOMCacheStorage fully suspendable by queueing all its asynchronous promise resolutions
to a SuspendableTaskQueue. This makes sure that no promises are resolved while suspended
in the page cache.

Test: http/tests/navigation/page-cache-domcachestorage-pending-promise.html

  • Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::DOMCacheStorage):
(WebCore::DOMCacheStorage::doSequentialMatch):
(WebCore::DOMCacheStorage::match):
(WebCore::DOMCacheStorage::has):
(WebCore::DOMCacheStorage::open):
(WebCore::DOMCacheStorage::doOpen):
(WebCore::DOMCacheStorage::remove):
(WebCore::DOMCacheStorage::doRemove):
(WebCore::DOMCacheStorage::keys):
(WebCore::DOMCacheStorage::canSuspendForDocumentSuspension const):

  • Modules/cache/DOMCacheStorage.h:

LayoutTests:

Add layout test coverage.

  • http/tests/navigation/page-cache-domcachestorage-pending-promise-expected.txt: Added.
  • http/tests/navigation/page-cache-domcachestorage-pending-promise.html: Added.
4:19 AM Changeset in webkit [250964] by youenn@apple.com
  • 3 edits
    1130 copies
    119 adds
    1 delete in trunk/Source/ThirdParty/libwebrtc

Rename yasm-1.3.0 folder to yasm
​https://bugs.webkit.org/show_bug.cgi?id=202725

Reviewed by Eric Carlson.

To align with upstream repository.

  • Configurations/yasm.xcconfig:
  • Source/third_party/yasm: Renamed from Source/ThirdParty/libwebrtc/Source/third_party/yasm-1.3.0.
  • libwebrtc.xcodeproj/project.pbxproj:
3:38 AM Changeset in webkit [250963] by magomez@igalia.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK and WPE gardening after r250954.

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
2:17 AM Changeset in webkit [250962] by youenn@apple.com
  • 421 edits
    14 copies
    4 moves
    176 adds
    3 deletes in trunk/Source/ThirdParty/libwebrtc

Update libwebrtc third-party abseilcpp to M78
​https://bugs.webkit.org/show_bug.cgi?id=202726

Reviewed by Alex Christensen.

  • CMakeLists.txt: Remove optional.cc.
  • Source/third_party/abseil-cpp: Updated.
  • libwebrtc.xcodeproj/project.pbxproj: Remove optional.cc.
1:45 AM Changeset in webkit [250961] by youenn@apple.com
  • 12 edits in trunk/Source/ThirdParty/libwebrtc

Update libwebrtc third-party opus to M78
​https://bugs.webkit.org/show_bug.cgi?id=202728

Reviewed by Alex Christensen.

  • Source/third_party/opus: Updated.
1:16 AM Changeset in webkit [250960] by youenn@apple.com
  • 47 edits
    1 delete in trunk/Source/ThirdParty/libwebrtc

Update libwebrtc third-arty libyuv to M78
​https://bugs.webkit.org/show_bug.cgi?id=202727

Reviewed by Alex Christensen.

libyuv

  • Source/third_party/libyuv: Updated.
1:00 AM Changeset in webkit [250959] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

[Mac] Allow SYS_pthread_markcancel call
​https://bugs.webkit.org/show_bug.cgi?id=202723

Reviewed by Alex Christensen.

Allow this pthread call as libwebrtc uses it on the Mac as well.

  • WebProcess/com.apple.WebProcess.sb.in:
12:44 AM Changeset in webkit [250958] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Add asserts to MediaStreamPrivate observer routines
​https://bugs.webkit.org/show_bug.cgi?id=202724

Reviewed by Alex Christensen.

These methods are only to be called in main thread.
Add asserts to validate this.
No change of behavior.

  • platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::addObserver):
(WebCore::MediaStreamPrivate::removeObserver):
(WebCore::MediaStreamPrivate::forEachObserver const):

Oct 9, 2019:

11:59 PM Changeset in webkit [250957] by youenn@apple.com
  • 4 edits in trunk/Source

A service worker process should not be created when enqueuing a service worker job
​https://bugs.webkit.org/show_bug.cgi?id=202578
<rdar://problem/55979690>

Reviewed by Chris Dumez.

Source/WebCore:

Ask for a service worker context connection when planning to install or run a service worker.
This allows to not spin unnecessarily service worker processes for jobs that do not end up installing a service worker.

Covered by existing tests.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::tryInstallContextData):
(WebCore::SWServer::runServiceWorkerIfNecessary):

Source/WebKit:

Remove the calls to create service worker context connection.
They are now done at SWServer level when trying to either run a service worker or install one.

  • NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::postMessageToServiceWorker):
(WebKit::WebSWServerConnection::scheduleJobInServer):

10:28 PM Changeset in webkit [250956] by yurys@chromium.org
  • 5 edits in trunk/LayoutTests

LayoutTest inspector/dom-debugger/node-removed.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=154610
<rdar://problem/24801209>

Reviewed by Matt Baker.

Reenabled the test on all platforms.

The test was missing call to Debugger.setBreakpointsActive. Apparently at the time
it was written calling Debugger.setBreakpoint automatically activated breakpoint but
the behavior changed over time. I also removed some unnecessary code.

  • inspector/dom-debugger/node-removed-expected.txt:
  • inspector/dom-debugger/node-removed.html:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
10:12 PM Changeset in webkit [250955] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

REGRESSION(r250948): Web Inspector: Styles: CSS selector becomes gray after stopping editing without modifying it
​https://bugs.webkit.org/show_bug.cgi?id=202781

Reviewed by Matt Baker.

When not editing, CSS selectors that match the selected node are highlighted (black in the light mode,
white in the dark mode). When editing starts, span elements that provide highlighting get removed.
When editing stops, active selectors should get highlighted.

r250948 stopped calling _renderSelector when selector wasn't modified.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetSelectorFieldDidCommit):

  • UserInterface/Views/SpreadsheetSelectorField.js:

(WI.SpreadsheetSelectorField.prototype._handleBlur):

8:08 PM Changeset in webkit [250954] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix the internal iOS build

  • page/PointerCaptureController.h: Add some missing forward declarations.
7:23 PM Changeset in webkit [250953] by Keith Rollin
  • 3 edits in trunk/Source/WTF

Remove some support for < iOS 13
​https://bugs.webkit.org/show_bug.cgi?id=202371
<rdar://problem/55853960>

Reviewed by Youenn Fablet.

Remove some support for iOS versions less than 13.0.

Update conditionals that reference IPHONE_OS_VERSION_MIN_REQUIRED
and IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
values >= 130000. This means that expressions like
"IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
"IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.

This removal is part of a series of patches effecting the removal of
dead code for old versions of iOS. This particular pass involves
changes in which Dean Jackson was involved. These changes are isolated
from other similar changes in order to facilitate the reviewing
process.

  • wtf/FeatureDefines.h:
  • wtf/Platform.h:
7:02 PM Changeset in webkit [250952] by mmaxfield@apple.com
  • 3 edits in trunk/LayoutTests

Make fast/text/complex-initial-advance.html more robust
​https://bugs.webkit.org/show_bug.cgi?id=202708

Unreviewed follow up to r250884.

Makes test robust enough to pass on Mojave.

  • fast/text/complex-initial-advance-expected.html:
  • fast/text/complex-initial-advance.html:
6:44 PM Changeset in webkit [250951] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix an asserition after r250937.

Space increase tasks will be finished once it's started.

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::finishSpaceIncreaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):

6:27 PM Changeset in webkit [250950] by Wenson Hsieh
  • 25 edits
    1 copy in trunk/Source

[Clipboard API] Refactor Pasteboard item reading functions to work on both iOS and macOS
​https://bugs.webkit.org/show_bug.cgi?id=202647

Reviewed by Tim Horton.

Source/WebCore:

Moves some pasteboard helper functions out of iOS-specific code, and into platform-agnostic code. See below for
more details. There is no change in behavior, as nothing exercises these new pasteboard functions on macOS yet.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Pasteboard.cpp:

(WebCore::Pasteboard::allPasteboardItemInfo const):
(WebCore::Pasteboard::pasteboardItemInfo const):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::readBuffer):
(WebCore::Pasteboard::readURL):

Add some new helpers on Pasteboard to read Strings, data, and URLs from the platform pasteboard. These forward
to the platform strategy which, in WebKit2, are currently implemented using sync IPC, but could be changed in
the future to be fully asynchronous.

  • platform/Pasteboard.h:

(WebCore::Pasteboard::name const):

Expose a cross-platform name() getter on Pasteboard. On non-Cocoa platforms, this simply returns the empty
string, but on macOS and iOS, this returns the platform pasteboard name, which is stored in m_pasteboardName.

  • platform/PasteboardItemInfo.h:

(WebCore::PasteboardItemInfo::pathForContentType const):
(WebCore::PasteboardItemInfo::contentTypeForHighestFidelityItem const):
(WebCore::PasteboardItemInfo::encode const):
(WebCore::PasteboardItemInfo::decode):

Adds a couple of new members to PasteboardItemInfo (which represents metadata about a given item in the platform
pasteboard). These are changeCount (which is self explanatory), and webSafeTypesByFidelity, which is a list of
types in fidelity order which contains the list of pasteboard types that are safe to expose to bindings. These
may include types such as "text/plain", "text/html", "text/uri-list", and "image/png".

To distinguish this list from the existing contentTypesByFidelity list, I've also renamed contentTypesByFidelity
to platformTypesByFidelity, to make it more obvious that this other list of types are platform-specific, and not
generally safe to expose to the web.

  • platform/PasteboardStrategy.h:
  • platform/PlatformPasteboard.h:

Move several helpers out into platform-agnostic code.

  • platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::fileContentState):

  • platform/cocoa/PlatformPasteboardCocoa.mm: Added.

Add a new file to contain the implementation of PlatformPasteboard::allPasteboardItemInfo, which is the same
across Cocoa platforms.

(WebCore::PlatformPasteboard::allPasteboardItemInfo):

  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::readRespectingUTIFidelities):

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::informationForItemAtIndex):
(WebCore::PlatformPasteboard::readBuffer const):
(WebCore::PlatformPasteboard::readString const):
(WebCore::PlatformPasteboard::readURL const):

Additionally refactor all methods on PlatformPasteboard that take pasteboard item indices as signed integers
(int) to receive size_t values instead.

(WebCore::PlatformPasteboard::allPasteboardItemInfo): Deleted.

  • platform/libwpe/PasteboardLibWPE.cpp:

(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::read):

  • platform/libwpe/PlatformPasteboardLibWPE.cpp:

(WebCore::PlatformPasteboard::readString const):

Add an implementation stub for WPE.

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::modernPasteboardTypeForWebSafeMIMEType):
(WebCore::webSafeMIMETypeForModernPasteboardType):

Add helpers to convert between modern NSPasteboardTypes and web-safe types. While some logic exists today on
macOS to convert between legacy pasteboard types and web-safe types, conversion between the modern pasteboard
types and web-safe types are needed since NSPasteboardItem's types only support NSPasteboardTypes and
dynamically declared types that match the format of a universal type identfier (for instance, "com.foo.bar").

(WebCore::PlatformPasteboard::readBuffer const):
(WebCore::PlatformPasteboard::readString const):
(WebCore::PlatformPasteboard::readURL const):
(WebCore::PlatformPasteboard::count const):
(WebCore::PlatformPasteboard::informationForItemAtIndex):

Implement all of these helpers by looking up the NSPasteboardItem at the given item index and querying it for
data for non-legacy pasteboard types.

(WebCore::PlatformPasteboard::itemAtIndex const):

Source/WebKit:

Refactor iOS-specific pasteboard functions to be platform-agnostic. See WebCore ChangeLog for more details.

  • UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::allPasteboardItemInfo):
(WebKit::WebPasteboardProxy::informationForItemAtIndex):
(WebKit::WebPasteboardProxy::getPasteboardItemsCount):
(WebKit::WebPasteboardProxy::readStringFromPasteboard):
(WebKit::WebPasteboardProxy::readURLFromPasteboard):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
(WebKit::WebPasteboardProxy::writeURLToPasteboard):
(WebKit::WebPasteboardProxy::writeWebContentToPasteboard):
(WebKit::WebPasteboardProxy::writeImageToPasteboard):
(WebKit::WebPasteboardProxy::writeStringToPasteboard):

  • UIProcess/WebPasteboardProxy.cpp:

(WebKit::WebPasteboardProxy::allPasteboardItemInfo):
(WebKit::WebPasteboardProxy::informationForItemAtIndex):
(WebKit::WebPasteboardProxy::getPasteboardItemsCount):
(WebKit::WebPasteboardProxy::readStringFromPasteboard):
(WebKit::WebPasteboardProxy::readURLFromPasteboard):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):

  • UIProcess/WebPasteboardProxy.h:
  • UIProcess/WebPasteboardProxy.messages.in:
  • UIProcess/wpe/WebPasteboardProxyWPE.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::informationForItemAtIndex):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
(WebKit::WebPlatformStrategies::readURLFromPasteboard):
(WebKit::WebPlatformStrategies::readStringFromPasteboard):
(WebKit::WebPlatformStrategies::writeToPasteboard):
(WebKit::WebPlatformStrategies::updateSupportedTypeIdentifiers):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

Refactor iOS-specific pasteboard functions to be platform-agnostic. See WebCore ChangeLog for more details.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::informationForItemAtIndex):
(WebPlatformStrategies::allPasteboardItemInfo):
(WebPlatformStrategies::getPasteboardItemsCount):
(WebPlatformStrategies::readBufferFromPasteboard):
(WebPlatformStrategies::readURLFromPasteboard):
(WebPlatformStrategies::readStringFromPasteboard):
(WebPlatformStrategies::writeToPasteboard):
(WebPlatformStrategies::updateSupportedTypeIdentifiers):

6:01 PM Changeset in webkit [250949] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Try to fix build for Windows C_LOOP

  • llint/LowLevelInterpreter.asm:
5:55 PM Changeset in webkit [250948] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Modifying CSS selector by pressing Enter or Tab causes 2 CSS.setRuleSelector backend calls
​https://bugs.webkit.org/show_bug.cgi?id=202769
<rdar://problem/56132166>

Reviewed by Matt Baker.

Previously, spreadsheetSelectorFieldDidChange would get called twice:

  1. On Enter or Tab key press.
  2. On blur event.

With this patch, it only gets called on blur event.

  • UserInterface/Models/CSSRule.js:

(WI.CSSRule.prototype.set selectorText):
Remove dead code. Calling _selectorResolved(true) would cause an uncaught exception.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetSelectorFieldDidChange): Removed.
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetSelectorFieldDidCommit): Added.
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetSelectorFieldWillNavigate): Added.
Split spreadsheetSelectorFieldDidChange into spreadsheetSelectorFieldDidCommit and spreadsheetSelectorFieldWillNavigate.

  • UserInterface/Views/SpreadsheetSelectorField.js:

(WI.SpreadsheetSelectorField):
(WI.SpreadsheetSelectorField.prototype.startEditing):
(WI.SpreadsheetSelectorField.prototype.stopEditing):
(WI.SpreadsheetSelectorField.prototype._handleBlur):
(WI.SpreadsheetSelectorField.prototype._handleKeyDown):
Add _valueBeforeEditing to check if the value was modified before the blur event.
Similar logic exists in SpreadsheetTextField.

5:36 PM Changeset in webkit [250947] by Alan Coon
  • 25 edits
    13 deletes in tags/Safari-609.1.6

Revert r250540. rdar://problem/56052722

5:24 PM Changeset in webkit [250946] by Simon Fraser
  • 45 edits
    1 move
    1 add
    1 delete in trunk

Rename WheelEventTestTrigger and improve naming in related code
​https://bugs.webkit.org/show_bug.cgi?id=202772

Reviewed by Tim Horton.

Change the "test trigger" terminology to "monitor wheel events"; after all, tests
call monitorWheelEvents() and callAfterScrollingCompletes(), and this is not triggering
a test.

Source/WebCore:

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp:

(WebCore::FrameView::adjustScrollbarsForLayout):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::didAddScrollbar):

  • page/Page.cpp:

(WebCore::Page::ensureWheelEventTestMonitor):
(WebCore::Page::ensureTestTrigger): Deleted.

  • page/Page.h:

(WebCore::Page::wheelEventTestMonitor const):
(WebCore::Page::clearWheelEventTestMonitor):
(WebCore::Page::isMonitoringWheelEvents const):
(WebCore::Page::testTrigger const): Deleted.
(WebCore::Page::clearTrigger): Deleted.
(WebCore::Page::expectsWheelEventTriggers const): Deleted.

  • page/WheelEventTestMonitor.cpp: Added.

(WebCore::WheelEventTestMonitor::WheelEventTestMonitor):
(WebCore::WheelEventTestMonitor::clearAllTestDeferrals):
(WebCore::WheelEventTestMonitor::setTestCallbackAndStartNotificationTimer):
(WebCore::WheelEventTestMonitor::deferForReason):
(WebCore::WheelEventTestMonitor::removeDeferralForReason):
(WebCore::WheelEventTestMonitor::triggerTestTimerFired):
(WebCore::operator<<):

  • page/WheelEventTestMonitor.h: Renamed from Source/WebCore/page/WheelEventTestTrigger.h.
  • page/WheelEventTestTrigger.cpp: Removed.
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformPrepareForWheelEvents):

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::updateIsMonitoringWheelEventsForFrameView):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::deferWheelEventTestCompletionForReason const):
(WebCore::AsyncScrollingCoordinator::removeWheelEventTestCompletionDeferralForReason const):
(WebCore::AsyncScrollingCoordinator::updateExpectsWheelEventTestTriggerWithFrameView): Deleted.
(WebCore::AsyncScrollingCoordinator::deferTestsForReason const): Deleted.
(WebCore::AsyncScrollingCoordinator::removeTestDeferralForReason const): Deleted.

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::updateIsMonitoringWheelEventsForFrameView):
(WebCore::ScrollingCoordinator::updateExpectsWheelEventTestTriggerWithFrameView): Deleted.

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setPropertyChangedBitsAfterReattach):
(WebCore::ScrollingStateScrollingNode::setIsMonitoringWheelEvents):
(WebCore::ScrollingStateScrollingNode::dumpProperties const):
(WebCore::ScrollingStateScrollingNode::setExpectsWheelEventTestTrigger): Deleted.

  • page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::isMonitoringWheelEvents const):
(WebCore::ScrollingStateScrollingNode::expectsWheelEventTestTrigger const): Deleted.

  • page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::deferWheelEventTestCompletionForReason):
(WebCore::ScrollingTree::removeWheelEventTestCompletionDeferralForReason):
(WebCore::ScrollingTree::deferTestsForReason): Deleted.
(WebCore::ScrollingTree::removeTestDeferralForReason): Deleted.

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren):

  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::deferWheelEventTestCompletionForReason):
(WebCore::ThreadedScrollingTree::removeWheelEventTestCompletionDeferralForReason):
(WebCore::ThreadedScrollingTree::deferTestsForReason): Deleted.
(WebCore::ThreadedScrollingTree::removeTestDeferralForReason): Deleted.

  • page/scrolling/ThreadedScrollingTree.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::deferWheelEventTestCompletionForReason const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::removeWheelEventTestCompletionDeferralForReason const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::deferTestsForReason const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::removeTestDeferralForReason const): Deleted.

  • platform/Logging.h:
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::deferWheelEventTestCompletionForReason const):
(WebCore::ScrollAnimator::removeWheelEventTestCompletionDeferralForReason const):
(WebCore::ScrollAnimator::deferTestsForReason const): Deleted.
(WebCore::ScrollAnimator::removeTestDeferralForReason const): Deleted.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::ScrollAnimator::setWheelEventTestMonitor):
(WebCore::ScrollAnimator::ScrollAnimator::setWheelEventTestTrigger): Deleted.

  • platform/cocoa/ScrollController.h:

(WebCore::ScrollControllerClient::deferWheelEventTestCompletionForReason const):
(WebCore::ScrollControllerClient::removeWheelEventTestCompletionDeferralForReason const):
(WebCore::ScrollControllerClient::deferTestsForReason const): Deleted.
(WebCore::ScrollControllerClient::removeTestDeferralForReason const): Deleted.

  • platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::startSnapRubberbandTimer):
(WebCore::ScrollController::stopSnapRubberbandTimer):
(WebCore::ScrollController::scheduleStatelessScrollSnap):
(WebCore::ScrollController::startDeferringWheelEventTestCompletionDueToScrollSnapping):
(WebCore::ScrollController::stopDeferringWheelEventTestCompletionDueToScrollSnapping):
(WebCore::ScrollController::startScrollSnapTimer):
(WebCore::ScrollController::stopScrollSnapTimer):
(WebCore::ScrollController::startDeferringTestsDueToScrollSnapping): Deleted.
(WebCore::ScrollController::stopDeferringTestsDueToScrollSnapping): Deleted.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::didBeginScrollGesture const):
(WebCore::ScrollAnimatorMac::didEndScrollGesture const):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

  • rendering/RenderBox.cpp:

(WebCore::setupWheelEventMonitor):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::setupWheelEventTestTrigger): Deleted.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::createScrollbar):

  • rendering/RenderListBox.cpp:

(WebCore::setupWheelEventTestMonitor):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::createScrollbar):
(WebCore::setupWheelEventTestTrigger): Deleted.

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::monitorWheelEvents):
(WebCoreTestSupport::setTestCallbackAndStartNotificationTimer):
(WebCoreTestSupport::clearWheelEventTestMonitor):
(WebCoreTestSupport::clearWheelEventTestTrigger): Deleted.

  • testing/js/WebCoreTestSupport.h:

Source/WebKit:

  • UIProcess/API/C/WKPage.cpp:

(WKPageClearWheelEventTestMonitor):
(WKPageClearWheelEventTestTrigger): Deleted.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::clearWheelEventTestMonitor):
(WebKit::WebPageProxy::clearWheelEventTestTrigger): Deleted.

  • UIProcess/WebPageProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageStartMonitoringScrollOperations):
(WKBundlePageRegisterScrollOperationCompletionCallback):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::createScrollbar):

  • WebProcess/WebPage/EventDispatcher.cpp:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::clearWheelEventTestMonitor):
(WebKit::WebPage::clearWheelEventTestTrigger): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

5:13 PM Changeset in webkit [250945] by dbates@webkit.org
  • 6 edits
    1 add in trunk

Add support for CompactPointerTuple<..., OptionSet<...>>
​https://bugs.webkit.org/show_bug.cgi?id=201316

Reviewed by Yusuke Suzuki.

Source/WebCore:

Use the new CompactPointerTuple capability to replace CompactPointerTuple<RenderObject*, uint8_t>
with CompactPointerTuple<RenderObject*, OptionSet<ElementStyleFlag>> in Node.h.

  • dom/Node.h:

(WebCore::Node::hasStyleFlag const):
(WebCore::Node::setStyleFlag):
(WebCore::Node::clearStyleFlags):
Update code now that we support CompactPointerTuple<..., OptionSet<...>>.

Source/WTF:

Support using an OptionSet<> for the byte value portion of a CompactPointerTuple so that
you can encode both a pointer and 8-bit bitmask in a type-safe way. Another benefit of
supporting OptionSet<> is that we have a LLDB pretty-printer for it so this makes it easy
to see the set flags in such a CompactPointerTuple.

  • wtf/CompactPointerTuple.h:

Tools:

Add a test to ensure we encode and decode a compact pointer tuple correctly when an uint8_t and
a OptionSet<> as the byte value portion of the tuple.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/CompactPointerTuple.cpp: Added.

(TestWebKitAPI::TEST):

5:03 PM Changeset in webkit [250944] by wilander@apple.com
  • 20 edits
    8 adds in trunk

IsLoggedIn: Add as experimental feature
​https://bugs.webkit.org/show_bug.cgi?id=202707
<rdar://problem/56095064>

Reviewed by Brent Fulgham and Chris Dumez.

IsLoggedIn was proposed to the WebAppSec WG at TPAC 2019.
So far there is only an explainer posted to the mailing list:
​https://lists.w3.org/Archives/Public/public-webappsec/2019Sep/0004.html

Source/WebCore:

This patch adds the three experimental web APIs:

  • Promise<void> setLoggedIn()
  • Promise<void> setLoggedOut()
  • Promise<bool> isLoggedIn()

It also tests that those APIs are only exposed in secure contexts.

The functionality is implemented as a supplement to Navigator.

Tests: http/tests/is-logged-in/available-in-secure-contexts.https.html

http/tests/is-logged-in/unavailable-in-insecure-contexts.html

  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Headers.cmake:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • page/NavigatorIsLoggedIn.cpp: Added.

(WebCore::NavigatorIsLoggedIn::from):
(WebCore::NavigatorIsLoggedIn::supplementName):
(WebCore::NavigatorIsLoggedIn::setLoggedIn):
(WebCore::NavigatorIsLoggedIn::setLoggedOut):
(WebCore::NavigatorIsLoggedIn::isLoggedIn):

  • page/NavigatorIsLoggedIn.h: Added.
  • page/NavigatorIsLoggedIn.idl: Added.
  • page/PointerCaptureController.cpp:
  • page/PointerCaptureController.h:
  • page/Settings.yaml:

Source/WebKit:

  • Shared/WebPreferences.yaml:

LayoutTests:

  • http/tests/is-logged-in/available-in-secure-contexts.https-expected.txt: Added.
  • http/tests/is-logged-in/available-in-secure-contexts.https.html: Added.
  • http/tests/is-logged-in/unavailable-in-insecure-contexts-expected.txt: Added.
  • http/tests/is-logged-in/unavailable-in-insecure-contexts.html: Added.
  • platform/ios-device-wk1/TestExpectations:
  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/mac-highsierra/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/wincairo-wk1/TestExpectations:
4:50 PM Changeset in webkit [250943] by russell_e@apple.com
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r250930.

Broke watchOS Builds

Reverted changeset:

"Add support for CompactPointerTuple<..., OptionSet<...>>"
​https://bugs.webkit.org/show_bug.cgi?id=201316
​https://trac.webkit.org/changeset/250930

4:39 PM Changeset in webkit [250942] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[iOS] LayoutTest fast/events/touch/ios/double-tap-for-double-click2.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=202765
<rdar://problem/56123067>

Reviewed by Wenson Hsieh.

Currently when a dblclick handler is dynamically registered while executing the click handler, we don't always pick up the newly added handler (see webkit.org/b/202766).
Modify the test so that it passes consistently (and still preserve the dynamic behavior).

  • fast/events/touch/ios/double-tap-for-double-click2.html:
4:31 PM Changeset in webkit [250941] by Alan Coon
  • 1 copy in tags/Safari-608.3.10.1.3

Tag Safari-608.3.10.1.3.

4:03 PM Changeset in webkit [250940] by jiewen_tan@apple.com
  • 72 edits
    2 adds
    1 delete in trunk

[WebAuthn] Move the mock testing entrance to Internals
​https://bugs.webkit.org/show_bug.cgi?id=202560
<rdar://problem/55973793>

Reviewed by Chris Dumez.

Source/WebCore:

This patch moves TestRunner.setWebAuthenticationMockConfiguration to
Internals.setMockWebAuthenticationConfiguration and removes the old
entrance. The purpose of this patch is to allow API tests to use
the same mock infrastructure that is used by layout tests.

No new tests, covered by updates on existing tests.

  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/webauthn/PublicKeyCredentialCreationOptions.h:
  • WebCore.xcodeproj/project.pbxproj:
  • page/ChromeClient.h:

(WebCore::ChromeClient::setMockWebAuthenticationConfiguration):

  • testing/Internals.cpp:

(WebCore::Internals::setMockWebAuthenticationConfiguration):

  • testing/Internals.h:
  • testing/Internals.idl:
  • testing/MockWebAuthenticationConfiguration.h: Added.

(WebCore::MockWebAuthenticationConfiguration::LocalConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::LocalConfiguration::decode):
(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::decode):
(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::decode):
(WebCore::MockWebAuthenticationConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::decode):

  • testing/MockWebAuthenticationConfiguration.idl: Added.

Source/WebKit:

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration): Deleted.

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/WebAuthentication/AuthenticatorTransportService.cpp:

(WebKit::AuthenticatorTransportService::createMock):

  • UIProcess/WebAuthentication/AuthenticatorTransportService.h:
  • UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:

(WebKit::MockAuthenticatorManager::MockAuthenticatorManager):

  • UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.h:
  • UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:

(WebKit::MockHidConnection::send):
(WebKit::MockHidConnection::registerDataReceivedCallbackInternal):
(WebKit::MockHidConnection::parseRequest):
(WebKit::MockHidConnection::feedReports):
(WebKit::MockHidConnection::shouldContinueFeedReports):

  • UIProcess/WebAuthentication/Mock/MockHidConnection.h:
  • UIProcess/WebAuthentication/Mock/MockHidService.cpp:

(WebKit::MockHidService::MockHidService):

  • UIProcess/WebAuthentication/Mock/MockHidService.h:
  • UIProcess/WebAuthentication/Mock/MockLocalConnection.h:
  • UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:

(WebKit::MockLocalConnection::MockLocalConnection):

  • UIProcess/WebAuthentication/Mock/MockLocalService.h:
  • UIProcess/WebAuthentication/Mock/MockLocalService.mm:

(WebKit::MockLocalService::MockLocalService):

  • UIProcess/WebAuthentication/Mock/MockNfcService.h:
  • UIProcess/WebAuthentication/Mock/MockNfcService.mm:

(WebKit::MockNfcService::MockNfcService):
(WebKit::MockNfcService::platformStartDiscovery):
(WebKit::MockNfcService::detectTags const):

  • UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setMockWebAuthenticationConfiguration):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebsiteData/WebsiteDataStore.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setMockWebAuthenticationConfiguration):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebAuthenticationMockConfiguration): Deleted.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::setWebAuthenticationMockConfiguration): Deleted.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

  • http/wpt/webauthn/ctap-hid-failure.https.html:
  • http/wpt/webauthn/ctap-hid-success.https.html:
  • http/wpt/webauthn/ctap-nfc-failure.https.html:
  • http/wpt/webauthn/idl.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-hid.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-local.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-u2f.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure.https.html:
  • http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
  • http/wpt/webauthn/public-key-credential-create-success-local.https.html:
  • http/wpt/webauthn/public-key-credential-create-success-nfc.https.html:
  • http/wpt/webauthn/public-key-credential-create-success-u2f.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-local-silent.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-local.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-nfc.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-u2f-silent.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-u2f.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-local.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-nfc.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-u2f.https.html:
  • http/wpt/webauthn/resources/public-key-credential-ip-address.https.html:
3:48 PM Changeset in webkit [250939] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Clean up WheelEventTestTriggers logging
​https://bugs.webkit.org/show_bug.cgi?id=202764

Reviewed by Tim Horton.

Make DeferTestTriggerReason a bit set, and use OptionSet<> rather than StdSet. Make
DeferTestTriggerReason and ScrollableAreaReasonMap loggable, and simplify the logging.

  • page/WheelEventTestTrigger.cpp:

(WebCore::WheelEventTestTrigger::clearAllTestDeferrals):
(WebCore::WheelEventTestTrigger::deferTestsForReason):
(WebCore::WheelEventTestTrigger::removeTestDeferralForReason):
(WebCore::WheelEventTestTrigger::triggerTestTimerFired):
(WebCore::operator<<):
(WebCore::dumpState): Deleted.

  • page/WheelEventTestTrigger.h:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::deferTestsForReason const):
(WebCore::AsyncScrollingCoordinator::removeTestDeferralForReason const):

  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::deferTestsForReason const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::removeTestDeferralForReason const):

3:46 PM Changeset in webkit [250938] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Layout test fast/events/touch/ios/passive-by-default-overridden-on-document-and-window.html is a flaky failure on Internal iOS testers
​https://bugs.webkit.org/show_bug.cgi?id=202770
<rdar://51715312>

Reviewed by Megan Gardner.

Remove the touchmove listeners after firing once, because we can't
tell exactly how many we'll get for a drag.

  • fast/events/touch/ios/passive-by-default-overridden-on-document-and-window.html:
3:38 PM Changeset in webkit [250937] by sihui_liu@apple.com
  • 8 edits in trunk/Source/WebCore

IndexedDB: update size to actual disk usage only when estimated increase is bigger than space available
​https://bugs.webkit.org/show_bug.cgi?id=201957

Reviewed by Youenn Fablet.

For better performance.

Covered by existing tests.

  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::QuotaUser::resetSpaceUsed): m_estimatedSpaceIncrease will be updated when task
is finished, so no need to clear it when doing reset.
(WebCore::IDBServer::IDBServer::QuotaUser::computeSpaceUsed):

  • Modules/indexeddb/server/IDBServer.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp: instead of reading file size after each task, just add the

task size to known usage and get an estimated usage.
(WebCore::IDBServer::UniqueIDBDatabase::startSpaceIncreaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::finishSpaceIncreaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
(WebCore::IDBServer::UniqueIDBDatabase::deleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::shutdownForClose):
(WebCore::IDBServer::UniqueIDBDatabase::didShutdownForClose):
(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::generateUniqueCallbackIdentifier):
(WebCore::IDBServer::UniqueIDBDatabase::storeCallbackOrFireError):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::didOpenBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStoreAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCreateObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::renameObjectStoreAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformRenameObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::createIndexAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCreateIndex):
(WebCore::IDBServer::UniqueIDBDatabase::renameIndexAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformRenameIndex):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAddAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformPutOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::postDatabaseTaskReply):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):
(WebCore::IDBServer::UniqueIDBDatabase::performErrorCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performKeyDataCallback):
(WebCore::IDBServer::UniqueIDBDatabase::forgetErrorCallback):
(WebCore::IDBServer::generateUniqueCallbackIdentifier): Deleted.
(WebCore::IDBServer::UniqueIDBDatabase::updateSpaceUsedIfNeeded): Deleted.

  • Modules/indexeddb/server/UniqueIDBDatabase.h:
  • storage/StorageQuotaManager.cpp: use m_state to decide what action to take on next request. Previously when a

request asked for size bigger than space available, we would go to ask for more space directly. Now because IDB
can be reporting estimated usage, we first ask IDB to compute its actual disk usage and ask for more space if
actual space available is smaller than requested size.
(WebCore::StorageQuotaManager::askUserToInitialize):
(WebCore::StorageQuotaManager::removeUser):
(WebCore::StorageQuotaManager::requestSpace):
(WebCore::StorageQuotaManager::askForMoreSpace):
(WebCore::StorageQuotaManager::processPendingRequests):

  • storage/StorageQuotaManager.h:
  • storage/StorageQuotaUser.h:

(WebCore::StorageQuotaUser::computeSpaceUsed):

3:20 PM Changeset in webkit [250936] by sihui_liu@apple.com
  • 6 edits
    3 adds in trunk

IndexedDB: include size of index records in size estimate of put/add task
​https://bugs.webkit.org/show_bug.cgi?id=202483

Reviewed by Geoffrey Garen.

Source/WebCore:

SQLiteIDBBackingStore has two tables IndexRecords and Records. For add operation add(VALUE, KEY), we add a new
record to Records table. If we can extract index value from VALUE for some index, we would add a new record to
IndexRecords table.

We estimated the task szie of add task with (KEY_SIZE + VALUE_SIZE), but we didn't count the size that could be
added to the IndexRecords table. This could lead to storage abuse.

Test: storage/indexeddb/request-size-estimate.html

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):

LayoutTests:

  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • storage/indexeddb/request-size-estimate-expected.txt: Added.
  • storage/indexeddb/request-size-estimate.html: Added.
  • storage/indexeddb/resources/request-size-estimate.js: Added.

(randomKey):
(randomPropertyValue):
(createObject):
(prepareDatabase):
(onOpenSuccess):

3:03 PM Changeset in webkit [250935] by Chris Dumez
  • 5 edits
    2 adds in trunk

Youtube.com is unable to enter the back/forward cache on macOS
​https://bugs.webkit.org/show_bug.cgi?id=202754
<rdar://problem/56117666>

Reviewed by Eric Carlson.

Source/WebCore:

As of r250542, the MainThreadGenericEventQueue used by both MediaSource and
SourceBuffer to fire event is PageCache-aware. As a result, both these
ActiveDOMObjects can now safety suspend without risking running script while
in the page cache. I did have to update some logic in MediaSource::removeSourceBuffer()
to make sure we do not unnecessarily construct new ActiveDOMObjects while
suspending, as this is not allowed.

Test: media/media-source/media-source-page-cache.html

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::removeSourceBuffer):
(WebCore::MediaSource::canSuspendForDocumentSuspension const):

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::canSuspendForDocumentSuspension const):

  • Modules/mediasource/SourceBuffer.h:

LayoutTests:

Add layout test coverage.

  • media/media-source/media-source-page-cache-expected.txt: Added.
  • media/media-source/media-source-page-cache.html: Added.
2:29 PM Changeset in webkit [250934] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit

[Cocoa] IPC::decode should gracefully handle a nil allowed class
​https://bugs.webkit.org/show_bug.cgi?id=202753

Reviewed by Geoffrey Garen.

If IPC::decode is called with a nil allowed class, an NSInvalidArgumentException will be
thrown when trying to create an NSArray literal with a nil value. Depending on who calls
IPC::decode, this exception might or might not be caught, leading to dropped messages or
crashes.

One case of this happening is tracked by rdar://problem/55839467. In this case, the nil
allowed class was due to a build misconfiguration, and the exception caused the UI process
to not respond to a synchronous IPC message, hanging the WebContent process.

rdar://problem/55839467 was resolved by fixing the build misconfiguration, but this patch
improves IPC::decode so that a nil allowed class results in a message decoding failure
rather than a maybe-caught NSException.

  • Shared/Cocoa/ArgumentCodersCocoa.h:

(IPC::decode):

2:27 PM Changeset in webkit [250933] by Alan Coon
  • 11 edits
    1 delete in tags/Safari-609.1.6

Revert r250878. rdar://problem/56127001

2:23 PM Changeset in webkit [250932] by ysuzuki@apple.com
  • 11 edits
    1 delete in trunk

Unreviewed, roll out r250878
​https://bugs.webkit.org/show_bug.cgi?id=202656

Breaking vimeo page.

JSTests:

  • stress/getter-setter-should-be-cell.js: Removed.

Source/JavaScriptCore:

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGFixupPhase.cpp:
  • runtime/GetterSetter.cpp:
  • runtime/GetterSetter.h:
  • runtime/JSGlobalObject.cpp:

(JSC::getGetterById):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::regExpProtoGlobalGetter const):
(JSC::JSGlobalObject::regExpProtoUnicodeGetter const):
(JSC::JSGlobalObject::getterSetterStructure const):

  • runtime/JSType.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
2:06 PM Changeset in webkit [250931] by Truitt Savell
  • 2 edits in trunk/LayoutTests

Mark crypto/workers/subtle/aes-indexeddb.html as a timeout on Mojave Release wk2
​https://bugs.webkit.org/show_bug.cgi?id=202500

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:02 PM Changeset in webkit [250930] by dbates@webkit.org
  • 6 edits
    1 add in trunk

Add support for CompactPointerTuple<..., OptionSet<...>>
​https://bugs.webkit.org/show_bug.cgi?id=201316

Reviewed by Yusuke Suzuki.

Source/WebCore:

Use the new CompactPointerTuple capability to replace CompactPointerTuple<RenderObject*, uint8_t>
with CompactPointerTuple<RenderObject*, OptionSet<ElementStyleFlag>> in Node.h.

  • dom/Node.h:

(WebCore::Node::hasStyleFlag const):
(WebCore::Node::setStyleFlag):
(WebCore::Node::clearStyleFlags):
Update code now that we support CompactPointerTuple<..., OptionSet<...>>.

Source/WTF:

Support using an OptionSet<> for the byte value portion of a CompactPointerTuple so that
you can encode both a pointer and 8-bit bitmask in a type-safe way. Another benefit of
supporting OptionSet<> is that we have a LLDB pretty-printer for it so this makes it easy
to see the set flags in such a CompactPointerTuple.

  • wtf/CompactPointerTuple.h:

Tools:

Add a test to ensure we encode and decode a compact pointer tuple correctly when an uint8_t and
a OptionSet<> as the byte value portion of the tuple.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/CompactPointerTuple.cpp: Added.

(TestWebKitAPI::TEST):

2:01 PM Changeset in webkit [250929] by Alan Bujtas
  • 3 edits
    2 adds in trunk

RunResolver::rangeForRendererWithOffsets should check for range end
​https://bugs.webkit.org/show_bug.cgi?id=202761
<rdar://problem/55917924>

Reviewed by Antti Koivisto.

Source/WebCore:

This patch ensures that when rangeForRenderer comes back with a collapsed run (empty range), rangeForRendererWithOffsets returns an empty range as well.

Test: fast/text/simple-line-layout-range-check-end.html

  • rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::rangeForRendererWithOffsets const):

LayoutTests:

  • fast/text/simple-line-layout-range-check-end-expected.txt: Added.
  • fast/text/simple-line-layout-range-check-end.html: Added.
1:38 PM Changeset in webkit [250928] by Alan Coon
  • 12 edits in tags/Safari-609.1.6

Partially undo r250811
​https://bugs.webkit.org/show_bug.cgi?id=202715
<rdar://problem/56084287>

Reviewed by Chris Dumez.

Source/WebCore:

This patch changes the SerializedScriptValue to always wrap CryptoKey objects again.
CryptoKey objects could belong to an array or another object. In those cases, IDBObjectStore
cannot set the flag for the embedded Cryptokey objects. Neither can postMessage to unset
the flag. Therefore, there is no way to separate the serialization process into two and
this patch restores the old behaviour. However, the hardening part of r250811 is kept
and therefore the crash should still be prevented.

No new test, updated existing test

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::putOrAdd):
(WebCore::JSC::setIsWrappingRequiredForCryptoKey): Deleted.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readTerminal):

  • crypto/CryptoKey.h:

(WebCore::CryptoKey::allows const):
(WebCore::CryptoKey::isWrappingRequired const): Deleted.
(WebCore::CryptoKey::setIsWrappingRequired): Deleted.
(): Deleted.

  • dom/ScriptExecutionContext.h:

Tools:

  • TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:

Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.

LayoutTests:

Some rebaselines.

  • crypto/workers/subtle/ec-postMessage-worker-expected.txt:
  • crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
  • crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
1:21 PM Changeset in webkit [250927] by Alan Coon
  • 1 copy in tags/Safari-609.1.6

Tag Safari-609.1.6.

1:12 PM Changeset in webkit [250926] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[iOS] Layout Test fast/events/touch/ios/touchstart-and-touchend-outside-touchmove-target.html is Timing Out
​https://bugs.webkit.org/show_bug.cgi?id=202759
<rdar://problem/56122388>

Patch by Antoine Quint <Antoine Quint> on 2019-10-09
Reviewed by Dean Jackson.

This test would be run after fast/events/touch/ios/touchmove-cancelable-after-touchstart.html which does not
cleanly finish its simulated touch gesture with a touchend. Now that it does both tests can run one after the
other reliably.

  • fast/events/touch/ios/touchmove-cancelable-after-touchstart.html:
1:01 PM Changeset in webkit [250925] by Alan Coon
  • 1 copy in tags/Safari-608.3.10.0.2

Tag Safari-608.3.10.0.2.

12:57 PM Changeset in webkit [250924] by Jonathan Bedard
  • 6 edits in trunk/Tools

results.webkit.org: Increase default limit for test results
​https://bugs.webkit.org/show_bug.cgi?id=202757

Rubber-stamped by Aakash Jain.

  • resultsdbpy/resultsdbpy/controller/suite_controller.py:

(SuiteController): Increase DEFAULT_LIMIT.

  • resultsdbpy/resultsdbpy/controller/test_controller.py:

(TestController): Ditto.

  • resultsdbpy/resultsdbpy/view/static/js/commit.js:

(_CommitBank.prototype._load): Make commit shards larger.

  • resultsdbpy/resultsdbpy/view/static/js/drawer.js: Increase default slider size.
  • resultsdbpy/resultsdbpy/view/templates/commits.html: Keep smaller slider size.
12:41 PM Changeset in webkit [250923] by Alan Coon
  • 7 edits in branches/safari-608.3.10.0-branch/Source

Versioning.

12:40 PM Changeset in webkit [250922] by aboya@igalia.com
  • 6 edits
    11 adds in trunk

[MSE][GStreamer] Fix video sometimes not appearing
​https://bugs.webkit.org/show_bug.cgi?id=201401

Reviewed by Xabier Rodriguez-Calvar.

LayoutTests/imported/w3c:

Added a test that reproduces the sequence of operations that was
causing the video to not appear in WebKitGTK and checks that this time
there is visible output.

  • web-platform-tests/lint.whitelist:
  • web-platform-tests/media-source/mediasource-video-is-visible-expected.html: Added.
  • web-platform-tests/media-source/mediasource-video-is-visible.html: Added.
  • web-platform-tests/media-source/mp4/test-a-1s.mp4: Added.
  • web-platform-tests/media-source/mp4/test-a-1s.mp4-manifest.json: Added.
  • web-platform-tests/media-source/mp4/test-v-1s-blue.mp4: Added.
  • web-platform-tests/media-source/mp4/test-v-1s-blue.mp4-manifest.json: Added.
  • web-platform-tests/media-source/webm/test-a-1s.webm: Added.
  • web-platform-tests/media-source/webm/test-a-1s.webm-manifest.json: Added.
  • web-platform-tests/media-source/webm/test-v-1s-blue.webm: Added.
  • web-platform-tests/media-source/webm/test-v-1s-blue.webm-manifest.json: Added.

Source/WebCore:

The code in MediaPlayerPrivateGStreamer::changePipelineState() was
supposed to call ensureGLVideoSinkContext() on upwards transitions
to PAUSED but the code did not take into account non-step-by-step
state transitions, which happens frequently with playbin3 in the MSE
case.

Before the patch, when playbin3 transitioned from READY to PLAYING
without stopping for preroll this call would not be made and the
texture IDs received at the sink would not correspond to the
compositor GL context, leading to artifacts (often the player controls
or a blank screen).

Test: imported/w3c/web-platform-tests/media-source/mediasource-video-is-visible.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):

LayoutTests:

Added an exact expectation picture to avoid errors in the test runner
(only a fuzzy match is expected, and different platforms render video
with slightly different colors).

  • platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-video-is-visible-expected.html: Added.
  • platform/mac/TestExpectations:
12:27 PM Changeset in webkit [250921] by dino@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r250755): fast/events/ios/ipad/fast-click-not-always.html is Failing
​https://bugs.webkit.org/show_bug.cgi?id=202760
<rdar://56079585>

Reviewed by Antoine Quint.

Update the preference name.

  • fast/events/ios/ipad/fast-click-not-always.html:
12:23 PM Changeset in webkit [250920] by aboya@igalia.com
  • 3 edits in trunk/LayoutTests

Unreviewed minor WinCairo test gardening
​https://bugs.webkit.org/show_bug.cgi?id=187762

  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
11:40 AM Changeset in webkit [250919] by dino@apple.com
  • 2 edits in trunk/Tools

Provide an alternate command-line flag for timeout in run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=202758
<rdar://problem/56124032>

Reviewed by Tim Horton.

I always get the flag "--time-out-ms" wrong.
Everywhere else we use the single-word version of "timeout", including
the documentation for --time-out-ms!

Add an alternate that is just "--timeout", and update the documentation
to mention it is measured in milliseconds.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

11:10 AM Changeset in webkit [250918] by eric.carlson@apple.com
  • 6 edits in trunk

[ Mac WK2 ] Layout Test fast/mediastream/MediaStreamTrack-getSettings.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=196400
<rdar://problem/49567579>

Reviewed by Youenn Fablet.

Source/WebCore:

No new tests, this fixes a broken test.

  • platform/mediastream/mac/MockRealtimeAudioSourceMac.h:
  • platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::MockRealtimeAudioSourceMac::reconfigure): Reconfigure buffers as well.
(WebCore::MockRealtimeAudioSourceMac::render): Call reconfigure if the buffer isn't
configured correctly.
(WebCore::MockRealtimeAudioSourceMac::settingsDidChange): Call reconfigure.

  • platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::MockRealtimeAudioSource): Set sample rate to default.

LayoutTests:

  • fast/mediastream/MediaStreamTrack-getSettings.html: Cleanup test.
  • platform/mac-wk2/TestExpectations: Unskip test.
10:29 AM Changeset in webkit [250917] by dino@apple.com
  • 4 edits in trunk/LayoutTests

Layout Test webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance.html is failing since ANGLE roll
​https://bugs.webkit.org/show_bug.cgi?id=201784
<rdar://problem/55358159>

Reviewed by Antoine Quint.

This test needed updating.

  • platform/ios/TestExpectations:
  • webgl/2.0.0/resources/webgl_test_files/conformance/glsl/misc/shaders-with-invariance.html:
10:26 AM Changeset in webkit [250916] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, address Darin's post-landing comments for r250912.

The array should be const.

  • css/CSSDefaultStyleSheets.cpp:
10:24 AM Changeset in webkit [250915] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Clean up: Remove pre-macOS Sierra workaround for missing kVK_RightCommand
​https://bugs.webkit.org/show_bug.cgi?id=202597

Reviewed by Anders Carlsson.

kVK_RightCommand has been defined in HIToolbox/Events.h since macOS Sierra. We no longer
need to maintain code to manually define it.

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::keyForKeyEvent):

9:45 AM Changeset in webkit [250914] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

[CSS Shadow Parts] Minor exportparts attribute parsing cleanups
​https://bugs.webkit.org/show_bug.cgi?id=202740

Reviewed by Zalan Bujtas.

  • dom/ShadowRoot.cpp:

(WebCore::parsePartMapping):
(WebCore::parsePartMappingsList):

Return the map as the return value.

(WebCore::ShadowRoot::partMappings const):

9:29 AM Changeset in webkit [250913] by aestes@apple.com
  • 4 edits in trunk/Source

[iOS] Remove redundant uses of USE(UIKIT_EDITING)
​https://bugs.webkit.org/show_bug.cgi?id=202717

Reviewed by Anders Carlsson.

Source/WebCore:

  • page/ios/FrameIOS.mm:

(WebCore::Frame::qualifyingNodeAtViewportLocation):
(WebCore::Frame::approximateNodeAtViewportLocationLegacy):

Source/WebKitLegacy/ios:

  • WebCoreSupport/WebVisiblePosition.mm:

(-[DOMNode startPosition]):
(-[DOMNode endPosition]):

7:38 AM Changeset in webkit [250912] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

[iOS] REGRESSION (r250398) Layout Test fast/history/page-cache-element-state-focused.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=202712
<rdar://problem/56082428>

Reviewed by Antti Koivisto.

The test was failing depending on the order in which the tests were executed. The reason is that
elements would either use the full UA stylesheet (html.css) or the simple one in CSSDefaultStyleSheets.cpp.
Unfortunately, the outline-width was different on iOS between the simple stylesheet and the full one, causing
the test output to look different depending on which stylesheet was used.

Address the issue by making sure that the outline-width is 3px on IOS_FAMILY in the simple stylesheet, to
be consistent with the value in the full stylesheet (html.css).

  • css/CSSDefaultStyleSheets.cpp:
7:23 AM Changeset in webkit [250911] by aboya@igalia.com
  • 6 edits
    1 add in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=202751

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt: Added.
  • platform/gtk/accessibility/roles-exposed-expected.txt:
  • platform/gtk/fast/tokenizer/script_extra_close-expected.txt:
  • platform/wpe/TestExpectations:
7:07 AM Changeset in webkit [250910] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][Painting] Decouple content and decoration painting
​https://bugs.webkit.org/show_bug.cgi?id=202718
<rdar://problem/56104661>

Reviewed by Antti Koivisto.

This patch adds support for individual run painting <div><span style="background-color: red">red</span>black</div>.
This is pretty much all we can do with the current data structures (lack of context).

  • layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintBoxDecoration):
(WebCore::Display::paintInlineContent):
(WebCore::Display::Painter::paint):
(WebCore::Display::paintBlockLevelBoxDecoration): Deleted.

  • layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::appendInlineContainerStart):
(WebCore::Layout::Line::appendInlineContainerEnd):

4:33 AM Changeset in webkit [250909] by Adrian Perez de Castro
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for non-unified builds.

  • dfg/DFGByteCodeParser.cpp: Add missing inclusion of the GetterSetter.h header.
3:25 AM Changeset in webkit [250908] by magomez@igalia.com
  • 5 edits in trunk/LayoutTests

Unreviewed WPE gardening after r250889.

  • platform/wpe/TestExpectations:
  • platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-text-expected.txt:
2:41 AM Changeset in webkit [250907] by Fujii Hironori
  • 2 edits in trunk/Source/JavaScriptCore

[Win] error LNK2019: unresolved external symbol "public: cdecl JSC::Strong<enum JSC::Unknown>::Strong<enum JSC::Unknown>(class JSC::VM &,class JSC::JSValue)"
​https://bugs.webkit.org/show_bug.cgi?id=202722

Unreviewed flaky build fix for Windows ports.

JSC::Strong is used without including "StrongInlines.h".

  • runtime/JSCInlines.h: Added #include "StrongInlines.h".
2:37 AM Changeset in webkit [250906] by Fujii Hironori
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Windows ports
​https://bugs.webkit.org/show_bug.cgi?id=202630
<rdar://problem/56107907>

dom/Document.cpp(3990): error C2653: 'MediaStreamTrack': is not a class or namespace name
dom/Document.cpp(3990): error C3861: 'captureState': identifier not found

  • dom/Document.cpp:

(WebCore::Document::updateIsPlayingMedia): Restored #if ENABLE(MEDIA_STREAM).

2:12 AM Changeset in webkit [250905] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

[CSS Shadow Parts] Mark as supported in features.json
​https://bugs.webkit.org/show_bug.cgi?id=202730

Reviewed Ryosuke Niwa.

  • features.json:
1:48 AM Changeset in webkit [250904] by youenn@apple.com
  • 10 edits
    2 deletes in trunk

Remove testRunner.setWebRTCUnifiedPlanEnabled
​https://bugs.webkit.org/show_bug.cgi?id=202700

Reviewed by Eric Carlson.

Source/WebKit:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Remove legacy tests and migrate simulcast test to unified plan.

  • fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:
  • platform/gtk/TestExpectations:
  • webrtc/simulcast-h264.html:
  • webrtc/video-addLegacyTransceiver.html: Removed.
  • webrtc/video-with-receiver.html: Removed.
1:45 AM Changeset in webkit [250903] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Wayland: do not use EGL_PLATFORM_WAYLAND_KHR with eglGetPlatformDisplayEXT
​https://bugs.webkit.org/show_bug.cgi?id=202689

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2019-10-09
Reviewed by Žan Doberšek.

Use EGL_PLATFORM_WAYLAND_EXT instead. It shouldn't really matter because both are the same value.

  • platform/graphics/wayland/PlatformDisplayWayland.cpp:

(WebCore::PlatformDisplayWayland::initialize):

1:25 AM Changeset in webkit [250902] by Antti Koivisto
  • 6 edits in trunk

[CSS Shadow Parts] Allow exporting single part with multiple names using exportparts attribute
​https://bugs.webkit.org/show_bug.cgi?id=202719

Reviewed by Ryosuke Niwa.

Source/WebCore:

Cases like exportparts="part:export1, part:export2" should work.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):

Allow one part name to expand into multiple names for matching.

  • dom/ShadowRoot.cpp:

(WebCore::parsePartMappingsList):

Allow multiple names per mapping.

(WebCore::ShadowRoot::partMappings const):

  • dom/ShadowRoot.h:

LayoutTests:

  • fast/css/shadow-parts/exportparts-syntax-expected.txt:
1:20 AM WebKitGTK/2.26.x edited by Philippe Normand
(diff)
1:17 AM Changeset in webkit [250901] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

REGRESSION(r246399): [GStreamer] Problems playing AAC streams
​https://bugs.webkit.org/show_bug.cgi?id=202204

Reviewed by Xabier Rodriguez-Calvar.

Push the EOS event in the WebKitWebSrc element when the internal
queue is empty only for non-live resources. In the live case the
queue might drain temporarily but that's OK because data would
still be queued in downstream elements.

No new tests, the EOS event was pushed too early because of this
regression but there's no way to differentiate it from an expected
event in a layout test.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcCreate):

12:48 AM Changeset in webkit [250900] by youenn@apple.com
  • 4 edits in trunk/Source/WebCore

MediaStreamTrack does not need to be a Document audio producer
​https://bugs.webkit.org/show_bug.cgi?id=202630

Reviewed by Eric Carlson.

Instead of having all tracks being MediaProducer, we can use the new methods introduced for iOS
to mute/unmute capture tracks and get capture media state.
This allows to not register tracks that are not capture tracks.
Covered by existing tests.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setMuted):
(WebCore::MediaStreamTrack::applyConstraints):
(WebCore::MediaStreamTrack::mediaState const):
(WebCore::MediaStreamTrack::updateCaptureAccordingToMutedState):
(WebCore::MediaStreamTrack::pageMutedStateDidChange): Deleted.

  • Modules/mediastream/MediaStreamTrack.h:
  • dom/Document.cpp:

(WebCore::Document::updateIsPlayingMedia):
(WebCore::Document::pageMutedStateDidChange):

12:42 AM Changeset in webkit [250899] by Carlos Garcia Campos
  • 6 edits in trunk

REGRESSION(r250597): [GTK][WPE] 2.27.1 shows HTML content as text/plain in custom protocols when passing a charset in content type
​https://bugs.webkit.org/show_bug.cgi?id=202633

Reviewed by Žan Doberšek.

Source/WebKit:

This is a regression of the switch to use the new custom protocols implementation. Before r250597, we extracted
the mime type and charset from content type in the network process, but we are now sending the response directly
from the UI process, so we need to do that when building our response. Rename the mime_type parameter as
content_type to avoid confusion, since it's documented as the content type.

  • UIProcess/API/glib/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback):
(webkit_uri_scheme_request_finish):

  • UIProcess/API/gtk/WebKitURISchemeRequest.h:
  • UIProcess/API/wpe/WebKitURISchemeRequest.h:

Tools:

Add a test case.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(testWebContextURIScheme):

12:22 AM Changeset in webkit [250898] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] about:gpu should also show the client EGL extensions
​https://bugs.webkit.org/show_bug.cgi?id=202690

Reviewed by Carlos Alberto Lopez Perez.

We are showing the extensions supported by the display.

  • UIProcess/API/glib/WebKitProtocolHandler.cpp:

(WebKit::WebKitProtocolHandler::handleGPU):

12:20 AM Changeset in webkit [250897] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

CustomProtocols: convert log messages in WebURLSchemeTaskProxy to RELEASE_LOG
​https://bugs.webkit.org/show_bug.cgi?id=202686

Reviewed by Alex Christensen.

Instead of using WTFLogAlways, since those messages are confusing on stdout.

  • WebProcess/WebPage/WebURLSchemeTaskProxy.cpp:

(WebKit::WebURLSchemeTaskProxy::didPerformRedirection):
(WebKit::WebURLSchemeTaskProxy::didReceiveResponse):
(WebKit::WebURLSchemeTaskProxy::didReceiveData):

12:19 AM Changeset in webkit [250896] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[WPE][GTK] WebKitSecurityManager should consider webkit:// to be a local URI scheme
​https://bugs.webkit.org/show_bug.cgi?id=202638

Reviewed by Michael Catanzaro.

  • UIProcess/API/glib/WebKitProtocolHandler.cpp:

(WebKit::WebKitProtocolHandler::WebKitProtocolHandler):

12:17 AM Changeset in webkit [250895] by Alan Coon
  • 12 edits in branches/safari-608.3.10.0-branch

Cherry-pick r250887. rdar://problem/56105002

Partially undo r250811
​https://bugs.webkit.org/show_bug.cgi?id=202715
<rdar://problem/56084287>

Reviewed by Chris Dumez.

Source/WebCore:

This patch changes the SerializedScriptValue to always wrap CryptoKey objects again.
CryptoKey objects could belong to an array or another object. In those cases, IDBObjectStore
cannot set the flag for the embedded Cryptokey objects. Neither can postMessage to unset
the flag. Therefore, there is no way to separate the serialization process into two and
this patch restores the old behaviour. However, the hardening part of r250811 is kept
and therefore the crash should still be prevented.

No new test, updated existing test

  • Modules/indexeddb/IDBObjectStore.cpp: (WebCore::IDBObjectStore::putOrAdd): (WebCore::JSC::setIsWrappingRequiredForCryptoKey): Deleted.
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
  • crypto/CryptoKey.h: (WebCore::CryptoKey::allows const): (WebCore::CryptoKey::isWrappingRequired const): Deleted. (WebCore::CryptoKey::setIsWrappingRequired): Deleted. (): Deleted.
  • dom/ScriptExecutionContext.h:

Tools:

  • TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html: Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.

LayoutTests:

Some rebaselines.

  • crypto/workers/subtle/ec-postMessage-worker-expected.txt:
  • crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
  • crypto/workers/subtle/rsa-postMessage-worker-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:17 AM Changeset in webkit [250894] by Alan Coon
  • 3 edits in branches/safari-608.3.10.0-branch/LayoutTests

Cherry-pick r250844. rdar://problem/56061124

Unreviewed, test gardening

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:16 AM Changeset in webkit [250893] by Alan Coon
  • 23 edits
    3 adds in branches/safari-608.3.10.0-branch

Cherry-pick r250811. rdar://problem/56061124

Only wrapping CryptoKeys for IDB during serialization
​https://bugs.webkit.org/show_bug.cgi?id=202500
<rdar://problem/52445927>

Reviewed by Chris Dumez.

Source/WebCore:

Wrapping CryptoKeys during IDB serialization is a legacy request from Netflix when WebKit was an
early adopter. It is not necessary for other kinds of serialization. However, given existing keys
stored in users' idb are wrapped, the wrapping/unwrapping mechanism cannot be easily discarded.
Therefore, this patch restricts the wrapping/unwrapping mechanism to idb only.

To do so, a isWrappingRequired flag is added to CryptoKey such that whenever idb sees a CryptoKey,
it can set it. SerializedScriptValue will then only wrap a CryptoKey when this flag is set. Otherwise,
a new tag UnwrappedCryptoKeyTag is used to store unwrapped CryptoKeys in order to keep the old CryptoKeyTag
binaries intact. For deserialization, each type will be deserialized differently.

Besides the above, this patch also hardens WorkerGlobalScope::wrapCryptoKey/unwrapCryptoKey for
any potential racy issues. CryptoBooleanContainer is introduced to capture boolean in the lambda.
workerGlobalScope is replaced with workerMessagingProxy. Now, every variables captured in the lambdas
should be either a copy or a thread safe ref of the original object.

Test: crypto/workers/subtle/aes-indexeddb.html

  • Modules/indexeddb/IDBObjectStore.cpp: (WebCore::JSC::setIsWrappingRequiredForCryptoKey): (WebCore::IDBObjectStore::putOrAdd):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
  • crypto/CryptoKey.h: (WebCore::CryptoKey::isWrappingRequired const): (WebCore::CryptoKey::setIsWrappingRequired):
  • dom/ScriptExecutionContext.h:
  • workers/WorkerGlobalScope.cpp: (WebCore::CryptoBooleanContainer::create): (WebCore::CryptoBooleanContainer::boolean const): (WebCore::CryptoBooleanContainer::setBoolean): (WebCore::WorkerGlobalScope::wrapCryptoKey): (WebCore::WorkerGlobalScope::unwrapCryptoKey):
  • workers/WorkerGlobalScope.h:
  • workers/WorkerLoaderProxy.h: (WebCore::WorkerLoaderProxy::isWorkerMessagingProxy const):
  • workers/WorkerMessagingProxy.h: (isType):

Tools:

Modifies IndexedDB.StructuredCloneBackwardCompatibility test to include CryptoKeys.

  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: (-[StructuredCloneBackwardCompatibilityNavigationDelegate _webCryptoMasterKeyForWebView:]): (TEST):
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html:

LayoutTests:

Adds a new test aes-indexeddb.html to do idb in workers and makes
other tests more deterministic.

  • crypto/workers/subtle/aes-indexeddb-expected.txt: Added.
  • crypto/workers/subtle/aes-indexeddb.html: Added.
  • crypto/workers/subtle/ec-postMessage-worker-expected.txt:
  • crypto/workers/subtle/ec-postMessage-worker.html:
  • crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
  • crypto/workers/subtle/hrsa-postMessage-worker.html:
  • crypto/workers/subtle/resources/aes-indexeddb.js: Added.
  • crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
  • crypto/workers/subtle/rsa-postMessage-worker.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:01 AM Changeset in webkit [250892] by Alan Coon
  • 12 edits in branches/safari-608.3.10.1-branch

Cherry-pick r250887. rdar://problem/56104999

Partially undo r250811
​https://bugs.webkit.org/show_bug.cgi?id=202715
<rdar://problem/56084287>

Reviewed by Chris Dumez.

Source/WebCore:

This patch changes the SerializedScriptValue to always wrap CryptoKey objects again.
CryptoKey objects could belong to an array or another object. In those cases, IDBObjectStore
cannot set the flag for the embedded Cryptokey objects. Neither can postMessage to unset
the flag. Therefore, there is no way to separate the serialization process into two and
this patch restores the old behaviour. However, the hardening part of r250811 is kept
and therefore the crash should still be prevented.

No new test, updated existing test

  • Modules/indexeddb/IDBObjectStore.cpp: (WebCore::IDBObjectStore::putOrAdd): (WebCore::JSC::setIsWrappingRequiredForCryptoKey): Deleted.
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
  • crypto/CryptoKey.h: (WebCore::CryptoKey::allows const): (WebCore::CryptoKey::isWrappingRequired const): Deleted. (WebCore::CryptoKey::setIsWrappingRequired): Deleted. (): Deleted.
  • dom/ScriptExecutionContext.h:

Tools:

  • TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html: Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.

LayoutTests:

Some rebaselines.

  • crypto/workers/subtle/ec-postMessage-worker-expected.txt:
  • crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
  • crypto/workers/subtle/rsa-postMessage-worker-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:01 AM Changeset in webkit [250891] by Alan Coon
  • 3 edits in branches/safari-608.3.10.1-branch/LayoutTests

Cherry-pick r250844. rdar://problem/56075033

Unreviewed, test gardening

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:01 AM Changeset in webkit [250890] by Alan Coon
  • 23 edits
    3 adds in branches/safari-608.3.10.1-branch

Cherry-pick r250811. rdar://problem/56075033

Only wrapping CryptoKeys for IDB during serialization
​https://bugs.webkit.org/show_bug.cgi?id=202500
<rdar://problem/52445927>

Reviewed by Chris Dumez.

Source/WebCore:

Wrapping CryptoKeys during IDB serialization is a legacy request from Netflix when WebKit was an
early adopter. It is not necessary for other kinds of serialization. However, given existing keys
stored in users' idb are wrapped, the wrapping/unwrapping mechanism cannot be easily discarded.
Therefore, this patch restricts the wrapping/unwrapping mechanism to idb only.

To do so, a isWrappingRequired flag is added to CryptoKey such that whenever idb sees a CryptoKey,
it can set it. SerializedScriptValue will then only wrap a CryptoKey when this flag is set. Otherwise,
a new tag UnwrappedCryptoKeyTag is used to store unwrapped CryptoKeys in order to keep the old CryptoKeyTag
binaries intact. For deserialization, each type will be deserialized differently.

Besides the above, this patch also hardens WorkerGlobalScope::wrapCryptoKey/unwrapCryptoKey for
any potential racy issues. CryptoBooleanContainer is introduced to capture boolean in the lambda.
workerGlobalScope is replaced with workerMessagingProxy. Now, every variables captured in the lambdas
should be either a copy or a thread safe ref of the original object.

Test: crypto/workers/subtle/aes-indexeddb.html

  • Modules/indexeddb/IDBObjectStore.cpp: (WebCore::JSC::setIsWrappingRequiredForCryptoKey): (WebCore::IDBObjectStore::putOrAdd):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
  • crypto/CryptoKey.h: (WebCore::CryptoKey::isWrappingRequired const): (WebCore::CryptoKey::setIsWrappingRequired):
  • dom/ScriptExecutionContext.h:
  • workers/WorkerGlobalScope.cpp: (WebCore::CryptoBooleanContainer::create): (WebCore::CryptoBooleanContainer::boolean const): (WebCore::CryptoBooleanContainer::setBoolean): (WebCore::WorkerGlobalScope::wrapCryptoKey): (WebCore::WorkerGlobalScope::unwrapCryptoKey):
  • workers/WorkerGlobalScope.h:
  • workers/WorkerLoaderProxy.h: (WebCore::WorkerLoaderProxy::isWorkerMessagingProxy const):
  • workers/WorkerMessagingProxy.h: (isType):

Tools:

Modifies IndexedDB.StructuredCloneBackwardCompatibility test to include CryptoKeys.

  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: (-[StructuredCloneBackwardCompatibilityNavigationDelegate _webCryptoMasterKeyForWebView:]): (TEST):
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html:

LayoutTests:

Adds a new test aes-indexeddb.html to do idb in workers and makes
other tests more deterministic.

  • crypto/workers/subtle/aes-indexeddb-expected.txt: Added.
  • crypto/workers/subtle/aes-indexeddb.html: Added.
  • crypto/workers/subtle/ec-postMessage-worker-expected.txt:
  • crypto/workers/subtle/ec-postMessage-worker.html:
  • crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
  • crypto/workers/subtle/hrsa-postMessage-worker.html:
  • crypto/workers/subtle/resources/aes-indexeddb.js: Added.
  • crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
  • crypto/workers/subtle/rsa-postMessage-worker.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@250811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Note: See TracTimeline for information about the timeline view.