Timeline

Oct 18, 2019:

11:31 PM Changeset in webkit [251321] by ysuzuki@apple.com

• 8 edits
  1 add in trunk

[JSC] DFG::CommonData modification by DFG reallyAdd should be guarded by CodeBlock's lock
​https://bugs.webkit.org/show_bug.cgi?id=203177

Reviewed by Mark Lam.

JSTests:

• stress/dfg-really-add-locking.js: Added.

Source/JavaScriptCore:

When doing DFG reallyAdd, DFG::JITCode is already set in CodeBlock and DFG::CommonData can be
reachable from CodeBlock. So concurrent collector can trace entries of DFG::CommonData while DFG reallyAdd
is modifying it. It would be possible that we install DFG::JITCode after performing DFG reallyAdd, but for now,
we just protect DFG reallyAdd's DFG::CommonData modification by CodeBlock's lock so that concurrent collector
does not trace them in a racy manner.

• dfg/DFGDesiredGlobalProperties.cpp:

(JSC::DFG::DesiredGlobalProperties::reallyAdd):

• dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::reallyAdd):

• dfg/DFGDesiredTransitions.cpp:

(JSC::DFG::DesiredTransition::reallyAdd):

• dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):
(JSC::DFG::SymbolTableAdaptor::add):
(JSC::DFG::FunctionExecutableAdaptor::add):
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::add):

• dfg/DFGDesiredWatchpoints.h:

(JSC::DFG::SetPointerAdaptor::add):

• dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::reallyAdd):

10:48 PM Changeset in webkit [251320] by timothy_horton@apple.com

• 11 edits
  2 adds in trunk/Source

macCatalyst: Cursor should send mouse events, not touch events
​https://bugs.webkit.org/show_bug.cgi?id=203175
<rdar://problem/56321134>

Reviewed by Simon Fraser.

Source/WebCore:

• dom/Element.cpp:

(WebCore::shouldIgnoreMouseEvent):
(WebCore::Element::dispatchMouseEvent):

• page/PointerCaptureController.cpp:

(WebCore::PointerCaptureController::reset):
Share more code between platforms that support touch events and platforms that don't;
we want to be able to dispatch pointer events that originate from mouse events
in macCatalyst despite touch events being enabled (by virtue of being iOS WebKit),
so un-ifdef that code.

Source/WebKit:

• Platform/spi/ios/UIKitSPI.h:
• Shared/NativeWebMouseEvent.h:
• Shared/ios/NativeWebMouseEventIOS.mm:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
Add a NativeWebMouseEvent constructor that doesn't actually wrap a native event,
for creating totally-synthetic events.

• UIProcess/ios/WKMouseGestureRecognizer.h: Added.
• UIProcess/ios/WKMouseGestureRecognizer.mm: Added.

(webEventModifiersForUIKeyModifierFlags):
(-[WKMouseGestureRecognizer initWithTarget:action:]):
(-[WKMouseGestureRecognizer setView:]):
(-[WKMouseGestureRecognizer lastMouseEvent]):
(-[WKMouseGestureRecognizer lastMouseLocation]):
(-[WKMouseGestureRecognizer mouseTouch]):
(-[WKMouseGestureRecognizer _wantsHoverEvents]):
(-[WKMouseGestureRecognizer reset]):
(-[WKMouseGestureRecognizer _shouldReceiveTouch:forEvent:recognizerView:]):
(-[WKMouseGestureRecognizer _shouldReceivePress:]):
(-[WKMouseGestureRecognizer createMouseEventWithType:]):
(-[WKMouseGestureRecognizer touchesBegan:withEvent:]):
(-[WKMouseGestureRecognizer touchesMoved:withEvent:]):
(-[WKMouseGestureRecognizer touchesEnded:withEvent:]):
(-[WKMouseGestureRecognizer touchesCancelled:withEvent:]):
(-[WKMouseGestureRecognizer _hoverEntered:withEvent:]):
(-[WKMouseGestureRecognizer _hoverMoved:withEvent:]):
(-[WKMouseGestureRecognizer _hoverExited:withEvent:]):
(-[WKMouseGestureRecognizer _hoverCancelled:withEvent:]):
(-[WKMouseGestureRecognizer locationInView:]):
(-[WKMouseGestureRecognizer canPreventGestureRecognizer:]):
(-[WKMouseGestureRecognizer canBePreventedByGestureRecognizer:]):
Instead of just using UIHoverGestureRecognizer, introduce a new gesture
recognizer that does what it did, but also supports cases where the button
is pressed (so, mousedown and mouseup instead of just mousemove),
and synthesizes mouse events for all state transitions. These events
should look roughly identical to what a non-macCatalyst app would get
in AppKit's mouseUp/mouseDown/mouseMoved NSResponder methods.

• SourcesCocoa.txt:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _showShareSheet:inRect:completionHandler:]):
(-[WKContentView _mouseGestureRecognizerChanged:]):
(webEventFlagsForUIKeyModifierFlags): Deleted.
(-[WKContentView _hoverGestureRecognizerChanged:]): Deleted.

• WebKit.xcodeproj/project.pbxproj:

Make use of WKMouseGestureRecognizer to plumb the synthesized events directly
to the macOS-style "handleMouseEvent" codepath, instead of going through
the touch events path (and then subsequently generating synthetic clicks).
Also, ensure that other gesture recognizers ignore the mouse "touch" entirely
by returning NO in shouldReceiveTouch.

7:28 PM Changeset in webkit [251319] by Simon Fraser

• 6 edits in trunk/Source/WebCore

Make it possible to query scrollbar pseudo-style without having a scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=203174

Reviewed by Tim Horton.

A future patch needs the ability to query scrollbar pseudo-style without having
a scrollbar, and it was ugly to pass a live RenderScrollbar into CSS style resolution
functions. Instead, pass in a pure-data object that has information about the scrollbar.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

• css/SelectorChecker.h:
• css/SelectorCheckerTestFunctions.h:

(WebCore::scrollbarMatchesEnabledPseudoClass):
(WebCore::scrollbarMatchesDisabledPseudoClass):
(WebCore::scrollbarMatchesHoverPseudoClass):
(WebCore::scrollbarMatchesActivePseudoClass):
(WebCore::scrollbarMatchesHorizontalPseudoClass):
(WebCore::scrollbarMatchesVerticalPseudoClass):
(WebCore::scrollbarMatchesDecrementPseudoClass):
(WebCore::scrollbarMatchesIncrementPseudoClass):
(WebCore::scrollbarMatchesStartPseudoClass):
(WebCore::scrollbarMatchesEndPseudoClass):
(WebCore::scrollbarMatchesDoubleButtonPseudoClass):
(WebCore::scrollbarMatchesSingleButtonPseudoClass):
(WebCore::scrollbarMatchesNoButtonPseudoClass):
(WebCore::scrollbarMatchesCornerPresentPseudoClass):

• css/StyleResolver.h:

(WebCore::PseudoStyleRequest::PseudoStyleRequest):

• rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::getScrollbarPseudoStyle):

6:18 PM Changeset in webkit [251318] by commit-queue@webkit.org

• 118 edits
  7 deletes in trunk

[SVG2]: Remove the SVGExternalResourcesRequired interface
​https://bugs.webkit.org/show_bug.cgi?id=191293

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-10-18
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/svg/import/types-dom-04-b-manual.svg:

Use the preserveAlpha property of <feConvolveMatrix> element to test
SVGAnimatedBoolean.

Source/WebCore:

The spec page is: ​https://www.w3.org/TR/SVG/changes.html.

r251290 made externalResourcesRequired have no effect on firing the load
event. All the control was moved to SVGURIReference. This patch will remove
this interface entirely to conform with SVG2 specs and other browsers.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• svg/SVGAElement.cpp:

(WebCore::SVGAElement::SVGAElement):
(WebCore::SVGAElement::parseAttribute):
(WebCore::SVGAElement::svgAttributeChanged):

• svg/SVGAElement.h:
• svg/SVGAElement.idl:
• svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::isSupportedAttribute):
(WebCore::SVGAnimationElement::parseAttribute):

• svg/SVGAnimationElement.h:
• svg/SVGAnimationElement.idl:
• svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::SVGCircleElement):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):

• svg/SVGCircleElement.h:
• svg/SVGCircleElement.idl:
• svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::parseAttribute):
(WebCore::SVGClipPathElement::svgAttributeChanged):

• svg/SVGClipPathElement.h:
• svg/SVGClipPathElement.idl:
• svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::SVGCursorElement):
(WebCore::SVGCursorElement::parseAttribute):

• svg/SVGCursorElement.h:
• svg/SVGCursorElement.idl:
• svg/SVGDefsElement.cpp:

(WebCore::SVGDefsElement::SVGDefsElement):

• svg/SVGDefsElement.h:
• svg/SVGDefsElement.idl:
• svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::SVGEllipseElement):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):

• svg/SVGEllipseElement.h:
• svg/SVGEllipseElement.idl:
• svg/SVGExternalResourcesRequired.cpp: Removed.
• svg/SVGExternalResourcesRequired.h: Removed.
• svg/SVGExternalResourcesRequired.idl: Removed.
• svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::SVGFEImageElement):
(WebCore::SVGFEImageElement::parseAttribute):

• svg/SVGFEImageElement.h:
• svg/SVGFEImageElement.idl:
• svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::SVGFilterElement):
(WebCore::SVGFilterElement::parseAttribute):
(WebCore::SVGFilterElement::svgAttributeChanged):

• svg/SVGFilterElement.h:
• svg/SVGFilterElement.idl:
• svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::SVGFontElement):

• svg/SVGFontElement.h:
• svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):

• svg/SVGForeignObjectElement.h:
• svg/SVGForeignObjectElement.idl:
• svg/SVGGElement.cpp:

(WebCore::SVGGElement::SVGGElement):
(WebCore::SVGGElement::parseAttribute): Deleted.
(WebCore::SVGGElement::svgAttributeChanged): Deleted.

• svg/SVGGElement.h:
• svg/SVGGElement.idl:
• svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::SVGGradientElement):
(WebCore::SVGGradientElement::parseAttribute):

• svg/SVGGradientElement.h:
• svg/SVGGradientElement.idl:
• svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::SVGImageElement):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):

• svg/SVGImageElement.h:
• svg/SVGImageElement.idl:
• svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::SVGLineElement):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):

• svg/SVGLineElement.h:
• svg/SVGLineElement.idl:
• svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::SVGMPathElement):
(WebCore::SVGMPathElement::parseAttribute):
(WebCore::SVGMPathElement::svgAttributeChanged):

• svg/SVGMPathElement.h:
• svg/SVGMPathElement.idl:
• svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::SVGMarkerElement):
(WebCore::SVGMarkerElement::parseAttribute):
(WebCore::SVGMarkerElement::svgAttributeChanged):

• svg/SVGMarkerElement.h:
• svg/SVGMarkerElement.idl:
• svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::SVGMaskElement):
(WebCore::SVGMaskElement::parseAttribute):
(WebCore::SVGMaskElement::svgAttributeChanged):

• svg/SVGMaskElement.h:
• svg/SVGMaskElement.idl:
• svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):

• svg/SVGPathElement.h:
• svg/SVGPathElement.idl:
• svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::SVGPatternElement):
(WebCore::SVGPatternElement::parseAttribute):
(WebCore::SVGPatternElement::svgAttributeChanged):

• svg/SVGPatternElement.h:
• svg/SVGPatternElement.idl:
• svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::SVGPolyElement):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):

• svg/SVGPolyElement.h:
• svg/SVGPolygonElement.idl:
• svg/SVGPolylineElement.idl:
• svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::SVGRectElement):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):

• svg/SVGRectElement.h:
• svg/SVGRectElement.idl:
• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::svgAttributeChanged):

• svg/SVGSVGElement.h:
• svg/SVGSVGElement.idl:
• svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::SVGScriptElement):
(WebCore::SVGScriptElement::parseAttribute):
(WebCore::SVGScriptElement::svgAttributeChanged):

• svg/SVGScriptElement.h:
• svg/SVGScriptElement.idl:
• svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::SVGSwitchElement):

• svg/SVGSwitchElement.h:
• svg/SVGSwitchElement.idl:
• svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::SVGSymbolElement):
(WebCore::SVGSymbolElement::parseAttribute):
(WebCore::SVGSymbolElement::svgAttributeChanged): Deleted.

• svg/SVGSymbolElement.h:
• svg/SVGSymbolElement.idl:
• svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::SVGTextContentElement):
(WebCore::SVGTextContentElement::parseAttribute):
(WebCore::SVGTextContentElement::svgAttributeChanged):

• svg/SVGTextContentElement.h:
• svg/SVGTextContentElement.idl:
• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::svgAttributeChanged):

• svg/SVGUseElement.h:
• svg/SVGUseElement.idl:
• svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::SVGViewElement):
(WebCore::SVGViewElement::parseAttribute):
(WebCore::SVGViewElement::svgAttributeChanged):

• svg/SVGViewElement.h:
• svg/SVGViewElement.idl:

LayoutTests:

• platform/gtk/TestExpectations:

The script-change-externalResourcesRequired-while-loading.svg has to be
removed and it was flaky on all platforms.

• platform/gtk/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual-expected.txt:
• platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual-expected.txt:
• platform/ios/TestExpectations:
• platform/ios/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• platform/mac/TestExpectations:
• platform/mac/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual-expected.txt:
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• platform/win/TestExpectations:
• platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual-expected.txt:
• platform/wpe/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• svg/W3C-SVG-1.1-SE/types-dom-04-b.svg:

Use the preserveAlpha property of <feConvolveMatrix> element to test
SVGAnimatedBoolean.

• svg/animations/animate-externalResourcesRequired-no-load-event-expected.txt: Removed.
• svg/animations/animate-externalResourcesRequired-no-load-event.html: Removed.
• svg/custom/path-domsubtreemodified-crash.html:

• svg/dom/SVGAnimatedBoolean-expected.txt:
• svg/dom/SVGAnimatedBoolean.html:

Use the preserveAlpha property of <feConvolveMatrix> element to test
SVGAnimatedBoolean.

• svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading-expected.txt: Removed.
• svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg: Removed.
• svg/dom/SVGScriptElement/script-load-and-error-events.svg:
• svg/dom/SVGScriptElement/script-onerror-bubbling.svg:
• svg/dom/SVGScriptElement/script-reexecution.svg:
• svg/dynamic-updates/SVGUseElement-dom-href1-attr.html:

6:02 PM Changeset in webkit [251317] by jiewen_tan@apple.com

• 22 edits
  1 copy
  1 move
  1 add in trunk

[WebAuthn] Warn users when no credentials are found
​https://bugs.webkit.org/show_bug.cgi?id=203147
<rdar://problem/55931123>

Reviewed by Brent Fulgham.

Source/WebKit:

This patch returns _WKWebAuthenticationPanelUpdateNoCredentialsFound to client via
-[_WKWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:] when either
CtapAuthenticator receives kCtap2ErrNoCredentials or U2fAuthenticator exhausts the
allow list.

This patch also enhances CtapAuthenticator::tryDowngrade to check if the CTAP command
can be converted to U2F commands to ensure kCtap2ErrNoCredentials is returned if it
is the case. Otherwise, after downgrading, U2fAuthenticator will return NotSupportedError
given it can't convert the commands.

• UIProcess/API/APIUIClient.h:
• UIProcess/API/APIWebAuthenticationPanelClient.h:

(API::WebAuthenticationPanelClient::updatePanel const):

• UIProcess/WebAuthentication/Authenticator.h:
• UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::authenticatorStatusUpdated):

• UIProcess/WebAuthentication/AuthenticatorManager.h:
• UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.h:
• UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:

(WebKit::WebAuthenticationPanelClient::WebAuthenticationPanelClient):
(WebKit::wkWebAuthenticationPanelUpdate):
(WebKit::WebAuthenticationPanelClient::updatePanel const):

• UIProcess/WebAuthentication/WebAuthenticationFlags.h: Renamed from Source/WebKit/UIProcess/WebAuthentication/WebAuthenticationPanelFlags.h.
• UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
• UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
• UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:

(WebKit::CtapAuthenticator::continueGetAssertionAfterResponseReceived):
(WebKit::CtapAuthenticator::tryDowngrade):

• UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:

(WebKit::U2fAuthenticator::issueSignCommand):

• WebKit.xcodeproj/project.pbxproj:

Tools:

Adds new tests for _WKWebAuthenticationPanelUpdateNoCredentialsFound.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-cancel.html:
• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-no-credentials.html: Added.
• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html:
• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html:
• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-u2f-no-credentials.html: Added.

LayoutTests:

Adds new tests for CtapAuthenticator::tryDowngrade enhancement.

• http/wpt/webauthn/public-key-credential-get-failure-hid.https-expected.txt:
• http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:

5:47 PM Changeset in webkit [251316] by Wenson Hsieh

• 17 edits in trunk

[Clipboard API] Refactor Pasteboard::read() to take an optional item index
​https://bugs.webkit.org/show_bug.cgi?id=203161

Reviewed by Tim Horton.

Source/WebCore:

Adds an optional itemIndex argument to Pasteboard::read(PasteboardPlainText&) and
Pasteboard::read(PasteboardWebContentReader&, WebContentReadingPolicy). See below for more details.

Tests: CopyHTML.ItemTypesWhenCopyingWebContent

PasteWebArchive.WebArchiveTypeIdentifier

• editing/mac/EditorMac.mm:

(WebCore::Editor::dataSelectionForPasteboard):

Recognize "com.apple.webarchive" alongside "Apple Web Archive pasteboard type" when writing and reading from the
platform pasteboard on macOS. We add support for this here because the existing private type cannot be written
to an NSPasteboardItem, since it does not conform to a valid UTI format. Luckily, there already exists a UTI
that represents a web archive, so we can use it instead.

We need to write and read web archive data from NSPasteboardItem in order to support the case where there are
multiple items in the pasteboard that contain different web archive data.

• platform/Pasteboard.h:
• platform/StaticPasteboard.h:
• platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::read):

• platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::read):

Read the string from itemIndex if specified; otherwise, fall back to index 0. This could actually be fixed in
the future to scan all pasteboard items for a suitable string instead of falling back on the first item, but for
now, we maintain the existing behavior.

(WebCore::Pasteboard::readRespectingUTIFidelities):

If an itemIndex is specified, ignore all other item indices when looking for suitable content.

• platform/libwpe/PasteboardLibWPE.cpp:

(WebCore::Pasteboard::read):

• platform/mac/DragDataMac.mm:

(WebCore::DragData::containsCompatibleContent const):

• platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::write):
(WebCore::readStringAtPreferredItemIndex):
(WebCore::readBufferAtPreferredItemIndex):

Add helper methods to read strings and buffers from the pasteboard, at an optional itemIndex if specified.

(WebCore::Pasteboard::read):

Adopt the helper functions when reading plain text and web content, and respect the given itemIndex. To do
this, we need to read both legacy and modern types from the pasteboard, instead of just legacy types. This is
because NSPasteboardItem on macOS only accepts and provides data in the form of modern pasteboard types.

• platform/mac/PlatformPasteboardMac.mm:

(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
(WebCore::PlatformPasteboard::readBuffer const):
(WebCore::PlatformPasteboard::readString const):

Fix these methods to accept platform pasteboard types instead of MIME types, to match the behavior of existing
readBuffer and readString methods in PlatformPasteboardIOS.

• platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::read):

Source/WebKit:

• Shared/mac/PasteboardTypes.mm:

(WebKit::PasteboardTypes::forEditing):
(WebKit::PasteboardTypes::forSelection):

Support "com.apple.webarchive" alongside the private "Apple Web Archive pasteboard type".

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::setPromisedDataForImage):

Tools:

Add a couple of new API tests to verify that the web archive type identifier ("com.apple.webarchive") is (1)
written to the pasteboard when copying a rich text selection, and (2) is read when attempting to paste web
content.

• TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:

5:44 PM Changeset in webkit [251315] by Devin Rousso

• 11 edits in trunk/Source/WebCore

[ASAN] Fix WebGPU tests after r250258
​https://bugs.webkit.org/show_bug.cgi?id=203133
<rdar://problem/56379008>

Reviewed by Joseph Pecoraro.

• platform/graphics/gpu/GPUObjectBase.h:

(WebCore::GPUObjectBase::~GPUObjectBase): Added.
Add a default virtual destructor since this class class is the one that is RefCounted and
the WebGPUPipeline subclass is virtual.

• Modules/webgpu/WebGPUPipeline.h:

(WebCore::WebGPUPipeline::scriptExecutionContext const): Deleted.

• Modules/webgpu/WebGPUPipeline.cpp:

(WebCore::WebGPUPipeline::WebGPUPipeline):
(WebCore::WebGPUPipeline::contextDestroyed): Added.
Make WebGPUPipeline a subclass of ContextDestructionObserver so that the raw pointer to
the associated ScriptExecutionContext is properly cleared and isn't UAFd.

• Modules/webgpu/WebGPUComputePipeline.h:
• Modules/webgpu/WebGPUComputePipeline.cpp:

(WebCore::WebGPUComputePipeline::create):
(WebCore::WebGPUComputePipeline::WebGPUComputePipeline):
(WebCore::WebGPUComputePipeline::cloneShaderModules):
(WebCore::WebGPUComputePipeline::recompile):

• Modules/webgpu/WebGPURenderPipeline.h:
• Modules/webgpu/WebGPURenderPipeline.cpp:

(WebCore::WebGPURenderPipeline::create):
(WebCore::WebGPURenderPipeline::WebGPURenderPipeline):
(WebCore::WebGPURenderPipeline::cloneShaderModules):
(WebCore::WebGPURenderPipeline::recompile):

• Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::createRenderPipeline):
(WebCore::WebGPUDevice::createComputePipeline):
Rework how Web Inspector preserves related shader modules so that there isn't as much wasted
space in the class layout, as we can use the RefPtr itself instead of an Optional.

• Modules/webgpu/WebGPUBuffer.idl:

Now that GPUObjectBase has a virtual destructor, it has a vtable, which means that this
object also does and therefore cannot be marked with ImplementationLacksVTable.

• inspector/InspectorShaderProgram.cpp:

(WebCore::shaderForType):
(WebCore::InspectorShaderProgram::requestShaderSource):
(WebCore::InspectorShaderProgram::updateShader):
(WebCore::InspectorShaderProgram::buildObjectForShaderProgram):

5:41 PM Changeset in webkit [251314] by russell_e@apple.com

• 2 edits in trunk/LayoutTests

[ Mac Debug WK1 ] REGRESSION (r251262?): fast/scrolling/latching/scroll-select-bottom-test.html is a Flaky Failure
​https://bugs.webkit.org/show_bug.cgi?id=203176

Unreviewed Test Gardening.

• platform/mac-wk1/TestExpectations:

4:58 PM Changeset in webkit [251313] by russell_e@apple.com

• 2 edits in trunk/LayoutTests

[ Mac WK1 ] REGRESSION (r251261): Layout Test inspector/console/webcore-logging.html is consistently Failing
​https://bugs.webkit.org/show_bug.cgi?id=203173

Unreviewed Test Gardening.

• platform/mac-wk1/TestExpectations:

4:55 PM Changeset in webkit [251312] by Jonathan Bedard

• 5 edits in trunk/Tools

Python 3: Add support in webkitpy.common.watchlist
​https://bugs.webkit.org/show_bug.cgi?id=202473

Reviewed by Dewei Zhu.

• Scripts/test-webkitpy-python3: Add webkitpy.common.watchlist.
• Scripts/webkitpy/common/watchlist/watchlist.py:

(WatchList.find_matching_definitions): Use items instead of iteritems.

• Scripts/webkitpy/common/watchlist/watchlist_unittest.py:

(WatchListTest.test_filename_definition_no_matches): Back-slash needs to be escaped.
(WatchListTest.test_filename_definition): Ditto.
(WatchListTest.test_cc_rules_simple): Ditto.
(WatchListTest.test_cc_rules_complex): Ditto.
(WatchListTest.test_cc_and_message_rules_complex): Ditto.
(WatchListTest.test_cc_and_message_rules_no_matches): Ditto.
(WatchListTest.test_more_and_less_match): Ditto.
(WatchListTest.test_complex_match): Ditto.

• Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:

(WatchListParserTest.test_bad_definition): Back-slash needs to be escaped.
(WatchListParserTest.test_bad_filename_regex): Ditto.
(WatchListParserTest.test_bad_more_regex): Ditto.
(WatchListParserTest.test_bad_match_type): Ditto.
(WatchListParserTest.test_match_type_typo): Ditto.
(WatchListParserTest.test_empty_cc_rule): Ditto.
(WatchListParserTest.test_cc_rule_with_invalid_email): Ditto.
(WatchListParserTest.test_cc_rule_with_secondary_email): Ditto.
(WatchListParserTest.test_empty_message_rule): Ditto.
(WatchListParserTest.test_unused_defintion): Ditto.
(WatchListParserTest.test_cc_rule_with_undefined_defintion_with_suggestion): Ditto.

4:46 PM Changeset in webkit [251311] by Truitt Savell

• 2 edits in trunk/LayoutTests

Layout Test inspector/layers/layers-for-node.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=203171

unreviewed test gardening

• platform/mac/TestExpectations:

4:42 PM Changeset in webkit [251310] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Remove myself from the CMake watchlist
​https://bugs.webkit.org/show_bug.cgi?id=203166

Patch by Raphael Kubo da Costa <​rakuco@webkit.org> on 2019-10-18
Reviewed by Aakash Jain.

• Scripts/webkitpy/common/config/watchlist:

4:36 PM Changeset in webkit [251309] by rniwa@webkit.org

• 4 edits in trunk

[iOS] REGRESSION(r251269): fast/events/ios/rotation/do-not-shrink-to-fit-content-after-rotation.html and fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html fail
​https://bugs.webkit.org/show_bug.cgi?id=203162
<rdar://problem/56418459>

Reviewed by Simon Fraser.

Source/WebKit:

Synchronously update the rendering before the orientation change and other viewport size updates.

Otherwise, resize event will be dispatched in the middle of orientation animation,
and would result in non-determistic results.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):

LayoutTests:

Rebaselined the test now that the order of execution of orientationchange and resize events have changed.

• fast/events/ios/rotation/layout-viewport-during-safari-type-rotation-expected.txt:

4:34 PM Changeset in webkit [251308] by rniwa@webkit.org

• 4 edits
  1 add in trunk/Source/WebCore

Refactor AbstractEventLoop out of WindowEventLoop
​https://bugs.webkit.org/show_bug.cgi?id=203136
<rdar://problem/56396749>

Reviewed by Antti Koivisto.

Extract AbstractEventLoop out of WindowEventLoop as a preparation for adding WorkerEventLoop.

Also replaced m_activeTaskCount with a boolean m_isScheduledToRun since it doesn't need to count.

• WebCore.xcodeproj/project.pbxproj:
• dom/AbstractEventLoop.cpp: Added.
• dom/AbstractEventLoop.h: Added.

(WebCore::AbstractEventLoop): Added.

• dom/WindowEventLoop.cpp:

(WebCore::WindowEventLoop::WindowEventLoop): Deleted. Use the default constructor in the header instead.
(WebCore::WindowEventLoop::queueTask):
(WebCore::WindowEventLoop::suspend):
(WebCore::WindowEventLoop::resume):
(WebCore::WindowEventLoop::scheduleToRunIfNeeded): Extracted out of queueTask.
(WebCore::WindowEventLoop::run):

• dom/WindowEventLoop.h:

4:32 PM Changeset in webkit [251307] by ysuzuki@apple.com

• 4 edits in trunk/Source

[JSC] Make ConcurrentJSLock Lock even if ENABLE_CONCURRENT_JS=OFF
​https://bugs.webkit.org/show_bug.cgi?id=202892

Reviewed by Mark Lam.

Source/JavaScriptCore:

We are using ConcurrentJSLock to guard data structure against concurrent compilers.
But these data structures should be guarded by GC concurrent collector, so we are using this ConcurrentJSLock
to guard them against concurrent collector too.
The problem is that ENABLE(CONCURRENT_JS) relies on ENABLE(DFG_JIT). If we configure JSC with the options like,

ENABLE_DFG_JIT 0
ENABLE_FTL_JIT 0

Then, the built JSC becomes

ENABLE_CONCURRENT_JS 0
But, Concurrent GC is enabled.

This is wrong due to several reasons.

1. Baseline JIT can produce JIT related data structures that are traced by concurrent collector. In the above options, these data structures are not guarded by lock.
2. Baseline JIT also has concurrent JIT compiler. But ENABLE_CONCURRENT_JS does not reflect this.

In this patch, we fix two things.

1. We should make ConcurrentJSLock always Lock. In 64bit environment we are supporting actively (including watchOS ARM64_32), we are enabling ENABLE(JIT) regardless of we are actually using JIT. So, anyway, this is already a Lock. Flipping these bits does not matter in 32bit architectures since they do not have concurrent compilers anyway. This makes things simpler: it is always a Lock. And concurrent collector can use it.
2. We should make ENABLE(CONCURRENT_JS) ON when ENABLE(JIT) is true, to reflect the fact that Baseline JIT has concurrent compiler.

• runtime/ConcurrentJSLock.h:

(JSC::ConcurrentJSLocker::ConcurrentJSLocker):

Source/WTF:

BaselineJIT also has concurrent compiler. ENABLE(CONCURRENT_JS) should not rely on ENABLE(DFG_JIT).
It should rely on ENABLE(JIT) instead.

• wtf/Platform.h:

3:54 PM Changeset in webkit [251306] by Devin Rousso

• 16 edits
  2 adds in trunk

Web Inspector: Elements: allow WebKit engineers to edit UserAgent shadow trees
​https://bugs.webkit.org/show_bug.cgi?id=203159

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/protocol/DOM.json:

Add setAllowEditingUserAgentShadowTrees command.

Source/WebCore:

Test: inspector/dom/setAllowEditingUserAgentShadowTrees.html

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::assertEditableNode):
(WebCore::InspectorDOMAgent::setInspectedNode):
(WebCore::InspectorDOMAgent::setAllowEditingUserAgentShadowTrees): Added.

Source/WebInspectorUI:

• UserInterface/Controllers/DOMManager.js:

(WI.DOMManager.prototype.initializeTarget):
(WI.DOMManager.supportsEditingUserAgentShadowTrees): Added.

• UserInterface/Models/CSSStyleDeclaration.js:

(WI.CSSStyleDeclaration.prototype.get editable):

• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForDOMNode):

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype.get editable):
(WI.DOMTreeElement.prototype._startEditingTarget):
(WI.DOMTreeElement.prototype.populateDOMNodeContextMenu):

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:

(WI.GeneralStyleDetailsSidebarPanel):
(WI.GeneralStyleDetailsSidebarPanel.prototype._showPanel):
(WI.GeneralStyleDetailsSidebarPanel.prototype._handleNodeChanged): Added.

• UserInterface/Views/StyleDetailsPanel.js:

(WI.StyleDetailsPanel.prototype.get supportsNewRule): Added.
(WI.StyleDetailsPanel.prototype.markAsNeedsRefresh):
(WI.StyleDetailsPanel.prototype.refresh):

• UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel.prototype.get supportsNewRule): Added.
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.newRuleButtonClicked):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.newRuleButtonContextMenu):
Don't show the "Add Rule" button if the selected node is inside a UserAgent shadow tree.

• UserInterface/Base/Setting.js:
• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createEngineeringSettingsView):

LayoutTests:

• inspector/dom/setAllowEditingUserAgentShadowTrees.html: Added.
• inspector/dom/setAllowEditingUserAgentShadowTrees-expected.txt: Added.

3:45 PM Changeset in webkit [251305] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Document::m_closeAfterStyleRecalc is unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=203143

Reviewed by Antti Koivisto.

Removed the code to defer implicit close until the style recalc is done
since we call FrameLoader::checkCompleted asynchronously via a timer these days.

• dom/Document.cpp:

(WebCore::Document::resolveStyle):
(WebCore::Document::implicitClose):

• dom/Document.h:

3:45 PM Changeset in webkit [251304] by Chris Dumez

• 5 edits in trunk/Source/WebKit

[iOS] "Unexpectedly Resumed" process assertion may cause us to get terminated
​https://bugs.webkit.org/show_bug.cgi?id=203046
<rdar://problem/56179592>

Reviewed by Geoffrey Garen.

This patch implements the following to avoid getting terminated:

1. Schedule the task to release the assertion on a background thread instead of the main thread so that we end up releasing the task even if the main thread is somehow hung.
2. Add an invalidation handler to the process assertion which releases the assertion upon expiration.

• UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::processWasUnexpectedlyUnsuspended):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::processDidResume):

• WebProcess/WebProcess.h:
• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::processTaskStateDidChange):

3:29 PM Changeset in webkit [251303] by dino@apple.com

• 10 edits
  2 adds in trunk

texImage2D for a half-float texture only accepts null
​https://bugs.webkit.org/show_bug.cgi?id=169999
<rdar://problem/31713571>

Reviewed by Simon Fraser.

Source/WebCore:

After we initially implemented this, the extension was
modified such that texImage2D could upload to half-float
from a Uint16 array.

Test: fast/canvas/webgl/oes-texture-half-float-uint16.html

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::validateArrayBufferType): Accept
Uint16.

LayoutTests:

Add a new test, and update the expected results of existing tests.

• fast/canvas/webgl/oes-texture-half-float-uint16-expected.txt: Added.
• fast/canvas/webgl/oes-texture-half-float-uint16.html: Added.
• webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt:
• webgl/2.0.0/conformance2/extensions/ext-color-buffer-float-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt:

3:27 PM Changeset in webkit [251302] by Devin Rousso

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: $0 is shown for the wrong node when selecting elements in a user agent shadow tree
​https://bugs.webkit.org/show_bug.cgi?id=203155

Reviewed by Matt Baker.

Rather than naively using the last selected node (from WI.TreeOutline), we should wait
to see if the inspected page's DOM agent allows the selected node to be used as the
inspected node, and if so then to show the $0.

• UserInterface/Controllers/DOMManager.js:

(WI.DOMManager.prototype.setInspectedNode):

• UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView):

• UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype._handleInspectedNodeChanged): Added.

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom li.inspected-node > span::after): Added.
(.tree-outline.dom:focus li.inspected-node.selected > span::after): Added.
(.tree-outline.dom.show-last-selected li.last-selected > span::after): Deleted.
(.tree-outline.dom.show-last-selected:focus li.last-selected > span::after): Deleted.

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.selectionControllerSelectionDidChange):

3:23 PM Changeset in webkit [251301] by dbates@webkit.org

• 2 edits in trunk/LayoutTests

fast/events/ios/forward-delete-in-editable.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=203049
<rdar://problem/52969457>

Reviewed by Wenson Hsieh.

Now that <rdar://problem/45772078> is fixed we can write the test such that we check the test
result after we receive a DOM key up for the forward delete. Currently the test makes use of a
workaround that incorrectly assumes that the keyboard will call back into WebKit to perform the
forward deletion before the web process blur()s the field. This is not guaranteed to happen.
Instead wait until we receive a DOM key up for the delete key.

• fast/events/ios/forward-delete-in-editable.html:

3:21 PM Changeset in webkit [251300] by dbates@webkit.org

• 2 edits in trunk/LayoutTests

Layout Test http/tests/security/contentSecurityPolicy/iframe-allowed-when-loaded-via-javascript-url.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=202481
<rdar://problem/55916200>

Reviewed by Youenn Fablet.

Have the iframe's document call testRunner.notifyDone() instead of assuming that the document will
be loaded by the next turn of the event loop.

• http/tests/security/contentSecurityPolicy/iframe-allowed-when-loaded-via-javascript-url.html:

3:16 PM Changeset in webkit [251299] by dbates@webkit.org

• 4 edits in trunk

REGRESSION (r241747): [iOS] Adjust default SVG focus ring width to match width for HTML documents
​https://bugs.webkit.org/show_bug.cgi?id=203011

Reviewed by Wenson Hsieh.

Source/WebCore:

Update default user agent stylesheet for SVG documents (i.e. .svg resources) to use the same 3px
outline width for focused elements as we do for HTML documents.

This makes the test imported/blink/svg/custom/focus-ring-2.svg pass on iOS.

• css/svg.css:

LayoutTests:

Remove the test imported/blink/svg/custom/focus-ring-2.svg now that it passes, again.

• platform/ios/TestExpectations:

3:00 PM Changeset in webkit [251298] by jer.noble@apple.com

• 21 edits
  3 copies
  3 moves
  4 adds
  1 delete in trunk

Add experimental HDR MediaCapabilities support.
​https://bugs.webkit.org/show_bug.cgi?id=203113

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/mediacapabilities/mock-decodingInfo-hdr.html

platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr.html

Add support for MediaCapabilities.decodeInfo() HDR support detection.

Add new enum IDL types to MediaCapabilities and remove old unused ones. Add
mock implementation for HDR detection. Add Cocoa platform implementation.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/mediacapabilities/ColorGamut.idl:
• Modules/mediacapabilities/HdrMetadataType.idl:
• Modules/mediacapabilities/ScreenLuminance.h:
• Modules/mediacapabilities/TransferFunction.idl:
• Modules/mediacapabilities/VideoConfiguration.idl:
• Scripts/GenerateSettings.rb:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/scripts/CodeGenerator.pm:

(WK_ucfirst):

• bindings/scripts/CodeGeneratorJS.pm:

(ToMethodName):

• page/Settings.yaml:
• platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:

(WebCore::createMediaPlayerDecodingConfigurationCocoa):

• platform/mediacapabilities/ColorGamut.h:
• platform/mediacapabilities/HdrMetadataType.h:
• platform/mediacapabilities/TransferFunction.h:
• platform/mediacapabilities/VideoConfiguration.h:
• platform/mock/MediaEngineConfigurationFactoryMock.cpp:

(WebCore::canDecodeMedia):
(WebCore::canEncodeMedia):

Source/WebKit:

Add experimental hdrMediaCapabilitiesEnabled preference.

• Shared/WebPreferences.yaml:

LayoutTests:

• media/mediacapabilities/mock-decodingInfo-alphaChannel-expected.txt:
• media/mediacapabilities/mock-decodingInfo-hdr-expected.txt: Added.
• media/mediacapabilities/mock-decodingInfo-hdr.html: Added.
• platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr-expected.txt: Added.
• platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr.html: Added.

2:33 PM Changeset in webkit [251297] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r251254): Elements: forced pseudo-class indicator isn't visible for selected nodes
​https://bugs.webkit.org/show_bug.cgi?id=203158

Reviewed by Matt Baker.

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom li > :not(.selection-area)): Added.
(.tree-outline.dom li > span): Deleted.

2:30 PM Changeset in webkit [251296] by Wenson Hsieh

• 2 edits in trunk/Tools

Unreviewed, remove an extraneous header import after r251279

Address a post-landing review comment.

• DumpRenderTree/mac/DumpRenderTreePasteboard.mm:

1:55 PM Changeset in webkit [251295] by jiewen_tan@apple.com

• 58 edits
  3 copies
  2 deletes in trunk

[WebAuthn] Implement AuthenticatorCancel
​https://bugs.webkit.org/show_bug.cgi?id=191523
<rdar://problem/55920204>

Reviewed by Brent Fulgham.

Source/WebCore:

Covered by new tests in existing test files.

• Modules/credentialmanagement/CredentialsContainer.cpp:

(WebCore::CredentialsContainer::get):
(WebCore::CredentialsContainer::isCreate):

• Modules/webauthn/AuthenticatorCoordinator.cpp:

(WebCore::AuthenticatorCoordinator::create const):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):

• Modules/webauthn/AuthenticatorCoordinator.h:
• Modules/webauthn/AuthenticatorCoordinatorClient.cpp: Removed.
• Modules/webauthn/AuthenticatorCoordinatorClient.h:
• Modules/webauthn/PublicKeyCredential.cpp:

(WebCore::PublicKeyCredential::tryCreate):

• Modules/webauthn/PublicKeyCredential.h:
• Modules/webauthn/PublicKeyCredentialData.h:
• Modules/webauthn/fido/DeviceRequestConverter.h:
• Modules/webauthn/fido/FidoHidMessage.cpp:

(fido::FidoHidMessage::FidoHidMessage):

• Modules/webauthn/fido/FidoHidPacket.cpp:

(fido::FidoHidInitPacket::getSerializedData const):
(fido::FidoHidContinuationPacket::getSerializedData const):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• testing/MockWebAuthenticationConfiguration.h:

(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::decode):

• testing/MockWebAuthenticationConfiguration.idl:

Adds a new option to test AuthenticatorCancel.

Source/WebKit:

This patch implement two ways to cancel a pending WebAuthn ceremony:
1) Via navigation activities. Activities include i) main frame navigation, ii) main frame reload,
iii) main frame destruction, iv) sub frame navigation, and v) sub frame destruction. All the above
activities will cancel any pending WebAuthn ceremony that is associated with the frame. To prove
the association, a GlobalFrameIdentifier is bridged into WebAuthenticationRequestData. Navigation
cancel is done in WebPageProxy::didStartProvisionalLoadForFrameShared, and destruction cancel is done
in WebProcessProxy::didDestroyFrame and WebPageProxy::resetState.
2) Via UI. This path is simply bridged -[_WKWebAuthenticationPanel cancel] into AuthenticatorManager.
Noted, this patch follows the spec to wait until time out to notify RPs.
References: i) Step 20 of ​https://www.w3.org/TR/webauthn/#createCredential, ii) Step 18 of
​https://www.w3.org/TR/webauthn/#getAssertion

As for what the cancel actually does, it:
1) stops any HID/NFC scanning;
2) sends CTAPHID_CANCEL to any HID authenticators that have been added. Reference:
​https://fidoalliance.org/specs/fido-v2.0-ps-20190130/fido-client-to-authenticator-protocol-v2.0-ps-20190130.html#usb-hid-cancel
Sending CTAPHID_CANCEL, however, is not trivial. An abstract class FidoAuthenticator is crafted to
do this labor for both CtapAuthenticator and U2fAuthenticator during the time of destructions.
Noted: The CtapHidDriver is the only CtapDriver implements the cancel method. Since the message
is sent during state reset, lifecycle of the HidConenction and HidService which manage the underlying
IOHIDDeviceRef is very hard to hold. This is required for the regular async sender. Therefore,
HidConnection::sendSync is crafted to send the message synchronously to get rid of the tediousness
of managing those lifecycles.

P.S. Vector::grow doesn't initialize POD types. Therefore, this patch also appends it with memset
for FidoHidPacket.

P.S.S. This patch also simplifies AuthenticatorCoordinatorClient by: i) moving code from AuthenticatorCoordinatorClient
to WebAuthenticatorCoordinatorClient, and ii) using sendWithAsyncReply. The latter allows us to
get rid of the complex mechanism of ensuring the right reply is returned.

• DerivedSources.make:
• Sources.txt:
• UIProcess/API/APIWebAuthenticationPanel.cpp:

(API::WebAuthenticationPanel::create):
(API::WebAuthenticationPanel::WebAuthenticationPanel):
(API::WebAuthenticationPanel::cancel const):

• UIProcess/API/APIWebAuthenticationPanel.h:
• UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(-[_WKWebAuthenticationPanel cancel]):

• UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::cancelRequest):
(WebKit::AuthenticatorManager::clearState):
(WebKit::AuthenticatorManager::runPanel):
(WebKit::AuthenticatorManager::resetState):

• UIProcess/WebAuthentication/AuthenticatorManager.h:
• UIProcess/WebAuthentication/Cocoa/HidConnection.h:

(WebKit::HidConnection::isInitialized const):
(WebKit::HidConnection::setIsInitialized):

• UIProcess/WebAuthentication/Cocoa/HidConnection.mm:

(WebKit::HidConnection::~HidConnection):
(WebKit::HidConnection::initialize):
(WebKit::HidConnection::terminate):
(WebKit::HidConnection::sendSync):
(WebKit::HidConnection::send):
(WebKit::HidConnection::registerDataReceivedCallback):

• UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:

(WebKit::MockHidConnection::initialize):
(WebKit::MockHidConnection::terminate):
(WebKit::MockHidConnection::sendSync):
(WebKit::MockHidConnection::send):
(WebKit::MockHidConnection::feedReports):

• UIProcess/WebAuthentication/Mock/MockHidConnection.h:
• UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
• UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:

(WebKit::WebAuthenticatorCoordinatorProxy::makeCredential):
(WebKit::WebAuthenticatorCoordinatorProxy::getAssertion):
(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
(WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable):
(WebKit::WebAuthenticatorCoordinatorProxy::requestReply): Deleted.

• UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
• UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
• UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:

(WebKit::CtapAuthenticator::CtapAuthenticator):
(WebKit::CtapAuthenticator::makeCredential):
(WebKit::CtapAuthenticator::getAssertion):
(WebKit::CtapAuthenticator::tryDowngrade):

• UIProcess/WebAuthentication/fido/CtapAuthenticator.h:
• UIProcess/WebAuthentication/fido/CtapDriver.h:

(WebKit::CtapDriver::cancel):

• UIProcess/WebAuthentication/fido/CtapHidDriver.cpp:

(WebKit::CtapHidDriver::Worker::write):
(WebKit::CtapHidDriver::Worker::read):
(WebKit::CtapHidDriver::Worker::returnMessage):
(WebKit::CtapHidDriver::Worker::reset):
(WebKit::CtapHidDriver::Worker::cancel):
(WebKit::CtapHidDriver::continueAfterChannelAllocated):
(WebKit::CtapHidDriver::continueAfterResponseReceived):
(WebKit::CtapHidDriver::returnResponse):
(WebKit::CtapHidDriver::reset):
(WebKit::CtapHidDriver::cancel):

• UIProcess/WebAuthentication/fido/CtapHidDriver.h:
• UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp: Copied from Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.cpp.

(WebKit::FidoAuthenticator::FidoAuthenticator):
(WebKit::FidoAuthenticator::~FidoAuthenticator):
(WebKit::FidoAuthenticator::driver const):
(WebKit::FidoAuthenticator::releaseDriver):

• UIProcess/WebAuthentication/fido/FidoAuthenticator.h: Copied from Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.cpp.
• UIProcess/WebAuthentication/fido/FidoService.cpp:

(WebKit::FidoService::continueAfterGetInfo):

• UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:

(WebKit::U2fAuthenticator::U2fAuthenticator):
(WebKit::U2fAuthenticator::issueCommand):

• UIProcess/WebAuthentication/fido/U2fAuthenticator.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::resetState):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didDestroyFrame):

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:

(WebKit::WebAuthenticatorCoordinator::WebAuthenticatorCoordinator):
(WebKit::WebAuthenticatorCoordinator::makeCredential):
(WebKit::WebAuthenticatorCoordinator::getAssertion):
(WebKit::WebAuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable):
(WebKit::WebAuthenticatorCoordinator::~WebAuthenticatorCoordinator): Deleted.

• WebProcess/WebAuthentication/WebAuthenticatorCoordinator.h:
• WebProcess/WebAuthentication/WebAuthenticatorCoordinator.messages.in: Removed.
• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::fromCoreFrame):

• WebProcess/WebPage/WebFrame.h:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-cancel.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html.
• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html:
• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html:
• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html:

LayoutTests:

Modified one of the error message that is no longer emitted.

• http/wpt/webauthn/public-key-credential-create-failure.https.html:
• http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
• http/wpt/webauthn/public-key-credential-get-failure.https.html:
• http/wpt/webauthn/public-key-credential-get-success-hid.https.html:

12:44 PM Changeset in webkit [251294] by rniwa@webkit.org

• 3 edits in trunk/LayoutTests

Flaky Test: fast/events/resize-subframe-in-rendering-update.html
​https://bugs.webkit.org/show_bug.cgi?id=203140

Reviewed by Simon Fraser.

The flakiness was caused by the race condition between rAF and setTimeout. In many cases,
setTimeout was getting scheduled after the next rAF and prevented some assertions to run in time.

Fixed the flakiness by moving setTimeout to outside the setTimeout in which tests run so that
those assertions would always run.

Rebaselined the test since these assertions in setTimeout are now always included in the results.

• fast/events/resize-subframe-in-rendering-update-expected.txt:
• fast/events/resize-subframe-in-rendering-update.html:

12:18 PM Changeset in webkit [251293] by BJ Burg

• 2 edits in trunk/Tools

Cleanup: Stop setting -ApplePersistenceIgnoreState when running debug Mac WebKit
​https://bugs.webkit.org/show_bug.cgi?id=203156

Reviewed by Jonathan Bedard.

This is no longer needed. The new value has been supported since 2014.

• Scripts/webkitdirs.pm:

(argumentsForRunAndDebugMacWebKitApp):

11:54 AM Changeset in webkit [251292] by Simon Fraser

• 5 edits in trunk/Source/WebCore

Add TextStream dumping for BasicShape types
​https://bugs.webkit.org/show_bug.cgi?id=203150

Reviewed by Zalan Bujtas.

Add dumping for the classes, and make the BasicShape enum an enum class.

• css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeCircle::dump const):
(WebCore::BasicShapeEllipse::dump const):
(WebCore::BasicShapePolygon::dump const):
(WebCore::BasicShapePath::dump const):
(WebCore::BasicShapeInset::dump const):
(WebCore::operator<<):

• rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::BasicShapeCenterCoordinate):

11:46 AM Changeset in webkit [251291] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

ElementRuleCollector function signature cleanups
​https://bugs.webkit.org/show_bug.cgi?id=203153
<rdar://problem/56412684>

Unreviewed followup.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::transferMatchedRules):

Try to appease MSVC.

11:29 AM Changeset in webkit [251290] by commit-queue@webkit.org

• 28 edits
  4 adds
  12 deletes in trunk

Load event must be fired only for the SVG structurally external elements and the outermost SVG element
​https://bugs.webkit.org/show_bug.cgi?id=203044

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-10-18
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/svg/geometry/svg-image-intrinsic-size-with-cssstyle-auto-expected.txt:

The timeout issues are now fixed. webkit.org/b/202013 will fix the other
failures.

• web-platform-tests/svg/images/20x20.png: Added.

Add an image which is referenced by these tests:

web-platform-tests/svg/import/styling-pres-02-f-manual.svg
web-platform-tests/svg/import/struct-use-01-t-manual.svg
web-platform-tests/svg/import/interact-events-02-b-manual.svg

• web-platform-tests/svg/linking/scripted/href-script-element-expected.txt:

Source/WebCore:

The SVG1.1 spec for SVGLoad event is:

​https://www.w3.org/TR/SVG11/interact.html

The SVG2 spec for the load event is:

​https://www.w3.org/TR/SVG/changes.html#interact
​https://www.w3.org/TR/SVG/interact.html

SVG2 removes the SVGExternalResourcesRequired interface. It also simplifies
the rules for firing the load event and made them consistent with the HTML
specs. The plan is to remove SVGExternalResourcesRequired in a following
patch. This patch makes SVGExternalResourcesRequired have no effect on the
load event firing rules. It moves all the functionalities to SVGURIReference
as a step towards removing the SVGExternalResourcesRequired interface.

Test: svg/custom/image-load-event.html

• dom/Document.cpp:

(WebCore::Document::implicitClose):
Do not use the SVGLoad term. It has been removed from the specs.

• dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):

• dom/ScriptElement.h:

(WebCore::ScriptElement::errorOccurred const):
(WebCore::ScriptElement::setErrorOccurred):
Add a method to track the occurrence of loading error. errorOccurred()

haveFiredLoadEvent() means no pending loading activity.

• svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::dispatchLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): Deleted.

• svg/SVGDocumentExtensions.h:

Do not use the SVGLoad term.

• svg/SVGElement.cpp:

(WebCore::SVGElement::sendLoadEventIfPossible):
(WebCore::SVGElement::loadEventTimerFired):
(WebCore::SVGElement::loadEventTimer):
(WebCore::SVGElement::finishParsingChildren):
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Deleted.
(WebCore::SVGElement::sendSVGLoadEventIfPossibleAsynchronously): Deleted.
(WebCore::SVGElement::svgLoadEventTimerFired): Deleted.
(WebCore::SVGElement::svgLoadEventTimer): Deleted.

• svg/SVGElement.h:

finishParsingChildren() won't fire 'load' event anymore. The 'load' event
will be fired explicitly for the outermost SVG element from Document::implicitClose().

• svg/SVGExternalResourcesRequired.cpp:

(WebCore::SVGExternalResourcesRequired::svgAttributeChanged):
(WebCore::SVGExternalResourcesRequired::dispatchLoadEvent): Deleted.
(WebCore::SVGExternalResourcesRequired::insertedIntoDocument): Deleted.
(WebCore::SVGExternalResourcesRequired::finishParsingChildren): Deleted.
(WebCore::SVGExternalResourcesRequired::haveLoadedRequiredResources const): Deleted.

• svg/SVGExternalResourcesRequired.h:

(WebCore::SVGExternalResourcesRequired::setHaveFiredLoadEvent): Deleted.
(WebCore::SVGExternalResourcesRequired::isParserInserted const): Deleted.
(WebCore::SVGExternalResourcesRequired::haveFiredLoadEvent const): Deleted.

• svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::haveLoadedRequiredResources):

• svg/SVGImageLoader.cpp:

(WebCore::SVGImageLoader::dispatchLoadEvent):
The value of externalResourcesRequired() no longer controls firing the
'load' event.

• svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::SVGScriptElement):
(WebCore::SVGScriptElement::insertedIntoAncestor):
(WebCore::SVGScriptElement::dispatchErrorEvent):
(WebCore::SVGScriptElement::finishParsingChildren): Deleted.

• svg/SVGScriptElement.h:

dispatchErrorEvent() is now a virtual function. Let SVGScriptElement
overrides it so it can track when the loader finishes its activity.

• svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::SVGStyleElement):

• svg/SVGStyleElement.h:

• svg/SVGURIReference.cpp:

(WebCore::SVGURIReference::contextElement const):
(WebCore::SVGURIReference::parseAttribute):
(WebCore::SVGURIReference::haveLoadedRequiredResources const):
(WebCore::SVGURIReference::dispatchLoadEvent):

• svg/SVGURIReference.h:

(WebCore::SVGURIReference::haveFiredLoadEvent const):
(WebCore::SVGURIReference::setHaveFiredLoadEvent):
(WebCore::SVGURIReference::errorOccurred const):
(WebCore::SVGURIReference::setErrorOccurred):
SVGURIReference will decide whether the 'load' event can be fired or not.

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::insertedIntoAncestor):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::finishParsingChildren): Deleted.
(WebCore::SVGUseElement::isValid const): Deleted.
(WebCore::SVGUseElement::haveLoadedRequiredResources): Deleted.
(WebCore::SVGUseElement::setHaveFiredLoadEvent): Deleted.
(WebCore::SVGUseElement::haveFiredLoadEvent const): Deleted.
(WebCore::SVGUseElement::svgLoadEventTimer): Deleted.

• svg/SVGUseElement.h:

SVGUseElement needs to track firing the load event or error occurrence
the same way SVGImageElement and SVGScriptElement do.

LayoutTests:

• fast/dom/crash-moving-subtree-between-documents.html:
• fast/dom/focus-style-resolution.html:
• fast/html/marquee-reparent-check.html:

The SVGElement element should not fire "load" event. Set the HTML <body>
element's "onload" event handler to be the function which was set to the
SVGElement's "onload" event handler.

• svg/custom/image-load-event-expected.html: Added.
• svg/custom/image-load-event.html: Added.

Images with external resources or data URIs must fire load events once
the data is loaded or decoded.

• svg/custom/loadevents-async-expected.txt: Removed.
• svg/custom/loadevents-async.html: Removed.
• svg/custom/loadevents-capturing-expected.txt: Removed.
• svg/custom/loadevents-capturing.svg: Removed.
• svg/custom/loadevents-externalresourcesrequired-displaynone-expected.txt: Removed.
• svg/custom/loadevents-externalresourcesrequired-displaynone.svg: Removed.
• svg/custom/loadevents-externalresourcesrequired-expected.txt: Removed.
• svg/custom/loadevents-externalresourcesrequired.svg: Removed.
• svg/custom/loadevents-normal-displaynone-expected.txt: Removed.
• svg/custom/loadevents-normal-displaynone.svg: Removed.
• svg/custom/loadevents-normal-expected.txt: Removed.
• svg/custom/loadevents-normal.svg: Removed.

These tests were implementing the SVG1.1 SVGLoad event interactivity:
​https://www.w3.org/TR/SVG11/interact.html where every SVG element had to
fire the SVGLoad event once it parsed its closing tag. SVG structurally
external elements were firing load events when the corresponding external
resources had finished loading but only if externalResourcesRequired = true.

• svg/dom/SVGScriptElement/script-load-and-error-events.svg:

This test had two wrong assumptions:
1) The SVG structurally external element fires a load event when parsing
the children finishes. Then they may fire another load or error event if
externalResourcesRequired = true.
2) The outermost SVG element will not fire its load event unless all the
children fires their load events correctly.

11:08 AM Changeset in webkit [251289] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

ElementRuleCollector function signature cleanups
​https://bugs.webkit.org/show_bug.cgi?id=203153

Reviewed by Zalan Bujtas.

Many functions in ElementRuleCollector take repetitive arguments that can be removed:

• Make includeEmptyRules argument a class member
• Remove RuleRange argument, update the ranges in rule transfer step.

• css/ElementRuleCollector.cpp:

(WebCore::MatchRequest::MatchRequest):
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::transferMatchedRules):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchesAnyAuthorRules):
(WebCore::ElementRuleCollector::collectMatchingAuthorRules):
(WebCore::ElementRuleCollector::matchAuthorShadowPseudoElementRules):
(WebCore::ElementRuleCollector::matchHostPseudoClassRules):
(WebCore::ElementRuleCollector::matchSlottedPseudoElementRules):
(WebCore::ElementRuleCollector::matchPartPseudoElementRules):
(WebCore::ElementRuleCollector::matchPartPseudoElementRulesForScope):
(WebCore::ElementRuleCollector::collectMatchingShadowPseudoElementRules):
(WebCore::ElementRuleCollector::collectSlottedPseudoElementRulesForSlot):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::matchUARules):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::ElementRuleCollector::matchAllRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):

• css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::setIncludeEmptyRules):
(WebCore::ElementRuleCollector::transferMatchedRules):

Range update happens now here based on the supplied argument.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):

10:35 AM Changeset in webkit [251288] by russell_e@apple.com

• 2 edits in trunk/LayoutTests

REGRESSION (r251262): Layout Test scrollingcoordinator/ios/non-stable-viewport-scroll.html is a Flaky Failure
​https://bugs.webkit.org/show_bug.cgi?id=203157

Unreviewed Test Gardening.

• platform/ios-simulator-wk2/TestExpectations: Marked

scrollingcoordinator/ios/non-stable-viewport-scroll.html as flaky

9:58 AM Changeset in webkit [251287] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[iOS] Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is frequently failing or timing out (198185)
​https://bugs.webkit.org/show_bug.cgi?id=198185
<rdar://problem/51074251>

Patch by Kate Cheney <Kate Cheney> on 2019-10-18
Reviewed by Youenn Fablet.

Fixes a flaky failure caused by test results being checked before data
records have finished processing. This patch uses a callback to
ensure data processing has finished before continuing.

• http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html:
• platform/ios-wk2/TestExpectations:

9:28 AM Changeset in webkit [251286] by Truitt Savell

• 2 edits in trunk/LayoutTests

REGRESSION: Layout Test webgl/many-contexts.html is a flaky timeout on Mojave
​https://bugs.webkit.org/show_bug.cgi?id=198867

Unreviewed test gardening

• platform/mac/TestExpectations:

9:20 AM Changeset in webkit [251285] by Antti Koivisto

• 9 edits in trunk

[CSS Shadow Parts] :part rules should be able to override style attribute
​https://bugs.webkit.org/show_bug.cgi?id=202919

Reviewed by Zalan Bujtas.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-shadow-parts/simple-inline-expected.txt:

Source/WebCore:

Element inline style was simply appended to the matching declaration list and not sorted with the rest of the author style.
This used to work because before CSS Shadow Parts feature inline style would always win.

Fixing this involves refactoring the rule collection code to remove this assumption.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addMatchedRule):

Both initialize and update ranges here.

(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::addElementStyleProperties):

Both initialize and update ranges here.

(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):

Split out transfering to a separate function.

(WebCore::ElementRuleCollector::transferMatchedRules):

Add a parameter to limit transfer to rules from a scope.

(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchesAnyAuthorRules):

Replace hasMatchedRules() with a more specific function. This can use collectMatchingAuthorRules and avoids unnecessary sorting step.

(WebCore::ElementRuleCollector::collectMatchingAuthorRules):

Split out collecting the rules from matchAuthorRules. Like other collect functions, this doesn't do any sorting.

(WebCore::ElementRuleCollector::matchAllRules):

Add element inline style before transfering rules from the containing host scope.

(WebCore::ElementRuleCollector::addElementInlineStyleProperties):

Factor adding inline style into a function.

9:14 AM Changeset in webkit [251284] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][TFC] Include horizontal spacing when checking for the extra horizontal space
​https://bugs.webkit.org/show_bug.cgi?id=203154
<rdar://problem/56408032>

Reviewed by Antti Koivisto.

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace):

9:12 AM Changeset in webkit [251283] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][TFC] Fix table's total horizontal spacing computation
​https://bugs.webkit.org/show_bug.cgi?id=203151
<rdar://problem/56406930>

Reviewed by Antti Koivisto.

The horizontal spacing value sets the gaps between

1. first column and the left edge of the table's content box
2. between 2 columns
3. last column and the right edge of the table's content box

In case of 'n' columns, the number of gaps is 'n + 1'.

• layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::totalHorizontalSpacing const):

9:11 AM Changeset in webkit [251282] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][TFC] Cache table's width constraint values.
​https://bugs.webkit.org/show_bug.cgi?id=203135
<rdar://problem/56396352>

Reviewed by Antti Koivisto.

This patch ensures that when computedIntrinsicWidthConstraints is called from both the preferred width and the actual layout codepaths during a layout frame, we don't
end up building up the grid twice.

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::TableFormattingContext::computePreferredWidthForColumns):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace):

• layout/tableformatting/TableGrid.cpp:

(WebCore::Layout::TableGrid::widthConstraints):
(WebCore::Layout::TableGrid::widthConstraints const): Deleted.

• layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::hasComputedWidthConstraints const):

9:09 AM Changeset in webkit [251281] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][BFC] TableFormattingContext::computedIntrinsicWidthConstraints should not expect a valid containing block's width
​https://bugs.webkit.org/show_bug.cgi?id=203131
<rdar://problem/56394676>

Reviewed by Antti Koivisto.

When TableFormattingContext::computedIntrinsicWidthConstraints is called by the preferred width computation (<div style="float: left"><table>)
the containing block's width is not yet set (it gets computed based on the preferred width) so computedIntrinsicWidthConstraints should not be relying
on it. Let's move that logic out to TableFormattingContext::layoutInFlowContent() where it belongs.

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::TableFormattingContext::ensureTableGrid):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace):
(WebCore::Layout::TableFormattingContext::computedTableWidth): Deleted.
(WebCore::Layout::TableFormattingContext::distributeExtraHorizontalSpace): Deleted.

• layout/tableformatting/TableFormattingContext.h:

7:54 AM Changeset in webkit [251280] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][BFC] Fix block level formatting root inflow box height computation
​https://bugs.webkit.org/show_bug.cgi?id=203085
<rdar://problem/56372306>

Reviewed by Antti Koivisto.

Section 10.6.7 (​https://www.w3.org/TR/CSS22/visudet.html#root-height) defines the height computation for block level formatting context roots.
We already use it for floats, out-of-flow and block level boxes when overflow computes to not "visible".
This patch makes generic in-flow non-replaced BFC roots (e.g. principal block container box for <table>) compute their heights according to 10.6.7.

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

7:24 AM Changeset in webkit [251279] by Wenson Hsieh

• 27 edits
  1 copy
  6 adds in trunk

[Clipboard API] Support navigator.clipboard.read()
​https://bugs.webkit.org/show_bug.cgi?id=203021

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline a web platform test, now that Clipboard.read() no longer immediately rejects.

• web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https-expected.txt:

Source/WebCore:

Add support for navigator.clipboard.read(), which returns a promise that resolves to a list of ClipboardItems.
See below for more details.

Tests: editing/async-clipboard/clipboard-change-data-while-reading.html

editing/async-clipboard/clipboard-read-basic.html

• Modules/async-clipboard/Clipboard.cpp:

(WebCore::Clipboard::read):

Implement read(). This makes two calls to the platform pasteboard: the first to get the current change count,
and if the change count is different from the changeCount used for the last read() call (or there are no
existing clipboard items being tracked), then we request pasteboard item information for all items on the
pasteboard, and use this information to create new clipboard items. Otherwise, if the changeCount is still valid
for the current list of clipboard items, simply return these clipboard items.

If the changeCount ends up being different in between the initial changeCount request and when the pasteboard
item information is received, we immediately bail with a NotAllowedError. The new layout test
clipboard-change-data-while-reading.html exercises this scenario.

(WebCore::Clipboard::getType):
(WebCore::Clipboard::frame const):

• Modules/async-clipboard/Clipboard.h:
• Modules/async-clipboard/ClipboardItem.cpp:

(WebCore::ClipboardItem::blobFromString):
(WebCore::ClipboardItem::ClipboardItem):
(WebCore::ClipboardItem::create):
(WebCore::ClipboardItem::navigator):

Refactor this so that each clipboard item itself has a WeakPtr to its Navigator. This avoids having to follow
the weak pointer to the Clipboard to get to the Clipboard's navigator during garbage collection when computing
reachability from opaque roots, since this may happen on a background (GC) thread.

(WebCore::ClipboardItem::clipboard):

• Modules/async-clipboard/ClipboardItem.h:
• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:

(WebCore::ClipboardItemBindingsDataSource::getType):
(WebCore::blobFromString): Deleted.

Move this to ClipboardItem, and make it a static method.

• Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp:

(WebCore::ClipboardItemPasteboardDataSource::ClipboardItemPasteboardDataSource):
(WebCore::ClipboardItemPasteboardDataSource::getType):

• Modules/async-clipboard/ClipboardItemPasteboardDataSource.h:

Move a couple of member variables (index and changeCount) out of ClipboardItem. Instead of having each
ClipboardItem keep track of this information, have the Clipboard that owns the ClipboardItem keep this
information. This means that reading data from ClipboardItem will (in a future patch) work by having the item
ask its Clipboard object to read data on its behalf.

• platform/Pasteboard.cpp:

(WebCore::Pasteboard::allPasteboardItemInfo const):
(WebCore::Pasteboard::pasteboardItemInfo const):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::readBuffer):
(WebCore::Pasteboard::readURL):

Add some null checks to handle the case where there is no pasteboard strategy.

Tools:

Make adjustments to WebKitTestRunner and DumpRenderTree to support the new layout tests. See below for more
details.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• DumpRenderTree/mac/DumpRenderTreePasteboard.mm:

(-[LocalPasteboard pasteboardItems]):

Fixes an existing issue with the mock NSPasteboard used for layout tests. Currently, our logic for converting
the contents of the platform pasteboard to NSPasteboardItem simply writes the pasteboard data as-is to
NSPasteboardItems. However, these pasteboard types may be legacy pasteboard types, in which case
NSPasteboardItem will simply handle the call to -setData:forType: as a no-op. AppKit has logic in this
scenario to canonicalize these legacy pasteboard types to their modern counterparts, but this is absent in
DumpRenderTreePasteboard and WebKitTestRunnerPasteboard.

Address this by teaching the mock pasteboards to convert legacy types to modern types when generating platform
pasteboard items.

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::copyText):

Add a new UIScriptController method to write a string to the platform pasteboard. This patch adds support for
this new testing hook on macOS and iOS, in WebKit2 (WebKitTestRunner).

• TestRunnerShared/mac/NSPasteboardAdditions.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.h.
• TestRunnerShared/mac/NSPasteboardAdditions.mm: Added.

(+[NSPasteboard _modernPasteboardType:]):

Add a helper to convert legacy pasteboard types (and dynamic UTIs that map to legacy pasteboard types) to
modern pasteboard types, suitable for writing to NSPasteboardItems on macOS.

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
• WebKitTestRunner/ios/UIScriptControllerIOS.h:
• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::copyText):

• WebKitTestRunner/mac/UIScriptControllerMac.h:
• WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptControllerMac::copyText):

• WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:

Apply the same fix for WebKitTestRunner's mock NSPasteboard.

(-[LocalPasteboard _clearContentsWithoutUpdatingChangeCount]):
(-[LocalPasteboard clearContents]):

Make -clearContents clear out all the contents on the mock pasteboard, instead of crashing in AppKit.

(-[LocalPasteboard declareTypes:owner:]):
(-[LocalPasteboard pasteboardItems]):

LayoutTests:

• editing/async-clipboard/clipboard-change-data-while-reading-expected.txt: Added.
• editing/async-clipboard/clipboard-change-data-while-reading.html: Added.

Add a new layout test to verify that if the platform pasteboard changes in the middle of a DOM paste access
request, the promise returned by Clipboard.read() should reject, and the page should not receive any clipboard
items.

• editing/async-clipboard/clipboard-read-basic-expected.txt: Added.
• editing/async-clipboard/clipboard-read-basic.html: Added.

Add a new layout test to exercise Clipboard.read(). Since we don't support reading data from clipboard items
yet, this only checks the types of each pasteboard item. This test additionally ensures that the ClipboardItems
returned from the API are the same between calls to Clipboard.read() if the data hasn't changed.

• editing/async-clipboard/resources/async-clipboard-helpers.js:

(writeToClipboardUsingDataTransfer):

Add a new helper to synchronously write data to the clipboard using execCommand and DataTransfer API.

(async.triggerProgrammaticPaste):

Add a new helper to trigger programmatic paste by activating the given element or location. Also receives an
array of options (which, for now, just supports a single option to change the pasteboard when granting DOM paste
access).

• platform/ios-wk1/TestExpectations: Skip clipboard-change-data-while-reading.html for now in WebKit1.
• platform/mac-wk1/TestExpectations: Skip clipboard-change-data-while-reading.html for now in WebKit1.
• platform/win/TestExpectations: Skip the new layout tests on Windows for now.

3:40 AM Changeset in webkit [251278] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit

Avoid crashes on GCC-compiled binaries by avoiding a use-after-move
that's the result of differring call conventions.

Rubber-stamped by Carlos Garcia Campos.

• NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startFetch): Copy the SW identifier from
the ServiceWorkerFetchTask before it's moved into the lambda.

1:35 AM Changeset in webkit [251277] by youenn@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Update libwebrtc third-party abseilcpp to M78
​https://bugs.webkit.org/show_bug.cgi?id=202726
<rdar://problem/56147823>

Unreviewed.

• Source/third_party/abseil-cpp/absl/strings/string_view.h:

(absl::string_view::CheckLengthInternal):
Build fix for debug bots.

1:29 AM Changeset in webkit [251276] by Fujii Hironori

• 2 edits in trunk/Source/JavaScriptCore

[Clang][Windows] Options.cpp(317,25): error: no matching function for call to 'optionTypeSpecificIndex'
​https://bugs.webkit.org/show_bug.cgi?id=203142

Unreviewed build fix

clang-cl reported a compilation error for MSVC bug workaround code of optionTypeSpecificIndex.

runtime\Options.cpp(294,12): error: variables defined in a constexpr function must be initialized

size_t index;

• runtime/Options.cpp:

(JSC::optionTypeSpecificIndex): Initialize the variable 'index'.

Oct 17, 2019:

10:01 PM Changeset in webkit [251275] by Chris Dumez

• 6 edits in trunk

Don't put pages that have not reached the non-visually empty layout milestone in the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=203108
<rdar://problem/56375671>

Reviewed by Geoff Garen.

Source/WebCore:

We don't want to go back to a visually empty page on back/forward navigation.

• history/BackForwardCache.cpp:

(WebCore::canCacheFrame):

• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::visuallyEmptyKey):

• page/DiagnosticLoggingKeys.h:

LayoutTests:

• http/tests/navigation/page-cache-pending-load.html:

Tweak test to add the stylesheet to the body instead of the head since a document
with a pending stylesheet before the body qualifies as visually empty. The test
would be flaky otherwise.

9:35 PM Changeset in webkit [251274] by mark.lam@apple.com

• 7 edits
  1 add in trunk

Add missing checks after calls to the sameValue() JSValue comparator.
​https://bugs.webkit.org/show_bug.cgi?id=203126
<rdar://problem/56366561>

Reviewed by Saam Barati.

JSTests:

• stress/validate-exception-check-in-proxy-object-put.js: Added.

Source/JavaScriptCore:

• runtime/JSFunction.cpp:

(JSC::JSFunction::defineOwnProperty):

• runtime/JSObject.cpp:

(JSC::JSObject::defineOwnIndexedProperty):
(JSC::validateAndApplyPropertyDescriptor):

• runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::equalTo const):

• runtime/ProxyObject.cpp:

(JSC::performProxyGet):
(JSC::ProxyObject::performPut):
(JSC::ProxyObject::performSetPrototype):
(JSC::ProxyObject::performGetPrototype):

• runtime/RegExpObject.cpp:

(JSC::RegExpObject::defineOwnProperty):

9:24 PM Changeset in webkit [251273] by Simon Fraser

• 11 edits
  5 copies
  2 moves
  3 adds in trunk

Only include "deep color" in layer tree dumps if a tests requests it
​https://bugs.webkit.org/show_bug.cgi?id=203125

Reviewed by Tim Horton.
Source/WebCore:

Layer tree dumping tests can fail when run on different devices because the "deep color"
property on layers is device-dependent. Stop dumping this by default, and have one test
that sets the bit. iphone-7 is the only device we test that has deep color support.

Tests: compositing/contents-format/deep-color-backing-store.html

compositing/contents-format/ipad/deep-color-backing-store.html
compositing/contents-format/iphone-7/deep-color-backing-store.html

• page/Frame.h:
• platform/graphics/GraphicsLayerClient.h:
• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

• testing/Internals.cpp:

(WebCore::toLayerTreeFlags):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• TestExpectations:
• compositing/contents-format/deep-color-backing-store-expected.txt: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.
• compositing/contents-format/deep-color-backing-store.html: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html.
• compositing/contents-format/ipad/deep-color-backing-store-expected.txt: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.
• compositing/contents-format/ipad/deep-color-backing-store.html: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html.
• compositing/contents-format/iphone-7/deep-color-backing-store-expected.txt: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.
• compositing/contents-format/iphone-7/deep-color-backing-store.html: Renamed from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html.
• platform/ipad/TestExpectations:
• platform/iphone-7/TestExpectations: Added.
• platform/mac-wk1/compositing/contents-format/deep-color-backing-store-expected.txt: Renamed from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.

7:27 PM Changeset in webkit [251272] by Simon Fraser

• 6 edits in trunk/LayoutTests

REGRESSION (r243347) Layout tests fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on* are flakey
​https://bugs.webkit.org/show_bug.cgi?id=203122
rdar://problem/50058173

Reviewed by Wenson Hsieh.

Rewrite these tests to wait for scrolling to finish, since the overflow is now accelerated and we need
to wait for momentum to end.

Also have them use UIHelper, factoring a function to work with overflow as well as document scroll.

• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt:
• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html:
• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt:
• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html:
• resources/ui-helper.js:

(window.UIHelper.callFunctionAndWaitForEvent):
(window.UIHelper.callFunctionAndWaitForScrollToFinish):
(window.UIHelper.callFunctionAndWaitForTargetScrollToFinish.return.new.Promise):
(window.UIHelper.callFunctionAndWaitForTargetScrollToFinish):
(window.UIHelper.callFunctionAndWaitForScrollToFinish.return.new.Promise): Deleted.

5:42 PM Changeset in webkit [251271] by sbarati@apple.com

• 4 edits
  1 add in trunk

GetByVal and PutByVal on ArrayStorage need to use the same AbstractHeap
​https://bugs.webkit.org/show_bug.cgi?id=203124
<rdar://problem/55988183>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/licm-array-storage-get-and-put-by-val.js: Added.

(assert):
(foo):

Source/JavaScriptCore:

• dfg/DFGAbstractHeap.h:
• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

5:29 PM Changeset in webkit [251270] by dino@apple.com

• 3 edits
  5 adds in trunk

ctx.font = "" asserts in CSS parser
​https://bugs.webkit.org/show_bug.cgi?id=203127
<rdar://problem/56391016>

Reviewed by Devin Rousso.

Source/WebCore:

The HTML specification says:
"values that cannot be parsed as CSS font values are ignored", so
return early if we get an empty string, otherwise the CSS parser
will assert. This was the only case I could find where we sidestepped
most of the parsing infrastructure and injected a raw string.

Test: http/wpt/2dcontext/text-styles/2d.text.font.parse.invalid.html

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

LayoutTests:

Copy the updated test from my WPT pull request. Once this
is merged into WPT, we won't need this version.

• http/wpt/2dcontext/text-styles/2d.text.font.parse.invalid-expected.txt: Added.
• http/wpt/2dcontext/text-styles/2d.text.font.parse.invalid.html: Added.
• http/wpt/resources/canvas-tests.css: Added.
• http/wpt/resources/canvas-tests.js: Added.

5:15 PM Changeset in webkit [251269] by rniwa@webkit.org

• 9 edits
  2 adds in trunk

Integrate resize event with HTML5 event loop
​https://bugs.webkit.org/show_bug.cgi?id=202964

Reviewed by Geoffrey Garen.

Source/WebCore:

Dispatch resize events in "run the resize steps" during the "update the rendering":
​https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering

Exisitng code in WebCore which was dispatching or scheduling dispatching of resize events now simply sets
a flag on document and schedules a rendering update. In Page::updateRendering, we fire resize events on
any documents with this flag set.

Test: fast/events/resize-subframe-in-rendering-update.html

• dom/Document.cpp:

(WebCore::Document::setNeedsDOMWindowResizeEvent): Added.
(WebCore::Document::setNeedsVisualViewportResize): Added.
(WebCore::Document::runResizeSteps): Added. ​https://drafts.csswg.org/cssom-view/#run-the-resize-steps

• dom/Document.h:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::resizeTo const):

• page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded): Now sets m_needsDOMWindowResizeEvent on Document instead of
enqueuing a resize event.

• page/Page.cpp:

(WebCore::Page::updateRendering): Call runResizeSteps on each document.
(WebCore::Page::collectDocuments): Added.

• page/Page.h:
• page/VisualViewport.cpp:

(WebCore::VisualViewport::enqueueResizeEvent):

LayoutTests:

Added a regression test and fixed an existing test to work with the new behavior.

• fast/events/resize-subframe-in-rendering-update-expected.txt: Added.
• fast/events/resize-subframe-in-rendering-update.html: Added.
• fast/shadow-dom/trusted-event-scoped-flags.html:

5:02 PM Changeset in webkit [251268] by Basuke Suzuki

• 2 edits in trunk/Source/bmalloc

[bmalloc] Bug fix for wait time when it's in mini mode.
​https://bugs.webkit.org/show_bug.cgi?id=203121

Reviewed by Yusuke Suzuki.

Since r243144, m_waitTime is never changed on mini mode.

• bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::threadRunLoop):

4:42 PM Changeset in webkit [251267] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r251255.

This is causing the existing back/forward tests to be flaky

Reverted changeset:

"Don't put pages that have not reached the non-visually empty
layout milestone in the back/forward cache"
​https://bugs.webkit.org/show_bug.cgi?id=203108
​https://trac.webkit.org/changeset/251255

4:38 PM Changeset in webkit [251266] by timothy_horton@apple.com

• 1 edit
  1 add in trunk/LayoutTests

Land a missing test baseline

• fast/forms/ios/inputmode-none-with-hardware-keyboard-expected.txt: Added.

3:53 PM Changeset in webkit [251265] by sbarati@apple.com

• 3 edits
  1 add in trunk/PerformanceTests

Have a CLI version of JetStream 2 to run on watchOS
​https://bugs.webkit.org/show_bug.cgi?id=202998
<rdar://problem/56208554>

Reviewed by Tadeu Zagallo.

This patch adds a CLI version of JS2 to run on watchOS. We run most subtests
from the browser version of JS2, but skip a few tests that are particularly
long running, like WSL and some of WTB. We also don't run the Wasm tests
as we don't JIT on watchOS. Each test runs for fewer iterations in the watch
version. 15 is the default iteration count. This benchmark runs in 7 minutes on
a Series 4 watch.

• JetStream2/JetStreamDriver.js:

(getIterationCount):
(getWorstCaseCount):
(Driver.prototype.async.start):
(Driver.prototype.resultsJSON):
(Driver.prototype.dumpJSONResultsIfNeeded):
(Driver.prototype.async.reportScoreToRunBenchmarkRunner):
(DefaultBenchmark):

• JetStream2/RexBench/UniPoker/benchmark.js:

(Benchmark.prototype.validate):
(Benchmark):

• JetStream2/watch-cli.js: Added.

3:45 PM Changeset in webkit [251264] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Harden capacity checks in DFG::LocalCSEPhase::SmallMap.
​https://bugs.webkit.org/show_bug.cgi?id=203123
<rdar://problem/56339943>

Change addPure() and addImpure() to use RELEASE_ASSERT in their capacity checks.

Reviewed by Keith Miller.

• dfg/DFGCSEPhase.cpp:

3:18 PM Changeset in webkit [251263] by mark.lam@apple.com

• 60 edits in trunk

Use constexpr in more places and remove some unnecessary external linkage.
​https://bugs.webkit.org/show_bug.cgi?id=203115

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

• API/JSWrapperMap.mm:
• heap/MarkedBlock.cpp:
• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):

• inspector/ScriptCallStack.h:
• interpreter/CLoopStack.h:
• interpreter/CallFrame.h:
• interpreter/ShadowChicken.h:
• jit/AssemblyHelpers.cpp:

(JSC::emitRandomThunkImpl):

• jit/GPRInfo.cpp:
• jit/GPRInfo.h:
• jit/JIT.h:
• jit/PCToCodeOriginMap.cpp:
• jit/SpecializedThunkJIT.h:
• jit/ThunkGenerators.cpp:

(JSC::roundThunkGenerator):

• jit/UnusedPointer.h:
• llint/LLIntData.h:
• llint/LLIntPCRanges.h:
• parser/Lexer.h:
• parser/Nodes.h:
• runtime/CodeCache.cpp:
• runtime/CodeCache.h:
• runtime/ErrorInstance.h:
• runtime/JSAsyncFunction.h:
• runtime/JSAsyncGeneratorFunction.h:
• runtime/JSBoundFunction.h:
• runtime/JSCallee.h:
• runtime/JSFunction.h:
• runtime/JSGeneratorFunction.h:
• runtime/JSNativeStdFunction.h:
• runtime/JSRunLoopTimer.cpp:

(): Deleted.

• runtime/JSRunLoopTimer.h:
• runtime/ProxyObject.h:
• runtime/Watchdog.cpp:

(): Deleted.

• runtime/Watchdog.h:
• wasm/js/WebAssemblyFunction.h:
• wasm/js/WebAssemblyFunctionBase.h:
• wasm/js/WebAssemblyWrapperFunction.h:

Source/WebCore:

No new tests because this patch adds no new functionality.

• html/track/TextTrackCueGeneric.cpp:
• html/track/VTTCue.cpp:
• page/EventHandler.cpp:

(WebCore::SyntheticTouchPoint::SyntheticTouchPoint):

• page/FrameTree.h:
• page/scrolling/ScrollingMomentumCalculator.cpp:

(WebCore::projectedInertialScrollDistance):

• platform/graphics/FontTaggedSettings.h:
• platform/graphics/Region.cpp:
• platform/graphics/filters/FELighting.cpp:
• rendering/TableLayout.h:
• rendering/svg/SVGRenderingContext.h:

Source/WebKit:

• UIProcess/API/APIContentRuleListStore.h:
• WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

Source/WTF:

Also removed unused lockSpinLimit in Threading.h.

• wtf/MD5.h:
• wtf/SHA1.h:
• wtf/StackBounds.h:
• wtf/Threading.h:

Tools:

• TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:

3:15 PM Changeset in webkit [251262] by Simon Fraser

• 12 edits in trunk

[ Mojave+ ] Layout Test compositing/fixed-with-main-thread-scrolling.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=198757

Reviewed by Tim Horton.

Source/WebCore:

WheelEventTestMonitor depends on "deferral reasons" getting added and removed, such that there is always
at least one reason active until scrolling quiesces.

WheelEventTestMonitor made the incorrect assumption that every call into ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent()
would result in a scroll change making it to the main thread, so it would defer "ScrollingThreadSyncNeeded" there,
and rely on AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll() to remove that deferral reason.
That assumption is wrong, because wheel events may coalesce, or have no impact on scroll position if already scrolled
to the max/min extent (e.g. when rubber banding).

Fix by adding a new "HandlingWheelEvent" deferral reason for the duration that the scrolling thread is processing an wheel event,
and then having ScrollingThreadSyncNeeded just represent the phase where any resulting scroll is being sent to the UI process.
These phases should always overlap.

This required moving isMonitoringWheelEvents() from the root scrolling node to the ScrollingTree.

• page/WheelEventTestMonitor.cpp:

(WebCore::operator<<):

• page/WheelEventTestMonitor.h:
• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitTreeState):

• page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::isMonitoringWheelEvents const):

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren):

• page/scrolling/ScrollingTreeScrollingNode.h:
• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):

• page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::deferWheelEventTestCompletionForReason const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::removeWheelEventTestCompletionDeferralForReason const):

LayoutTests:

Remove expectation for compositing/fixed-with-main-thread-scrolling.html.

• platform/mac-wk2/TestExpectations:

3:05 PM Changeset in webkit [251261] by sihui_liu@apple.com

• 10 edits in trunk

Using version 1 CFRunloopSource for faster task dispatch
​https://bugs.webkit.org/show_bug.cgi?id=202874

Reviewed by Geoffrey Garen.

Source/WTF:

We used CFRunLoopWakeUp to wake up runloop to process source, which seems to be slow according to profiling. To
avoid calling CFRunLoopWakeUp, we should use version 1 CFRunloopSource instead of version 0. This patch brings
about 15% speedup for test PerformanceTests/IndexedDB/basic/objectstore-get.html.

• wtf/RunLoop.cpp:

(WTF::RunLoop::initializeWebRunLoop):
(WTF::RunLoop::web):

• wtf/RunLoop.h:
• wtf/cf/RunLoopCF.cpp:

(WTF::RunLoop::performWork):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):

• wtf/cocoa/MainThreadCocoa.mm:

(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::initializeWebThread):
(-[JSWTFMainThreadCaller call]): Deleted.

Tools:

Fix a flaky test.

• TestWebKitAPI/Tests/WebKit/getUserMedia.html:

LayoutTests:

Fix a flaky test.

• inspector/css/pseudo-creation-expected.txt:
• inspector/css/pseudo-creation.html:

2:44 PM Changeset in webkit [251260] by Adrian Perez de Castro

• 2 edits in trunk/PerformanceTests

[Linux] Avoid usage of <sys/sysctl.h> in MallocBench
​https://bugs.webkit.org/show_bug.cgi?id=203109

Reviewed by Carlos Alberto Lopez Perez.

• MallocBench/MallocBench/CPUCount.cpp: Only include <sys/sysctl.h> if

the sysctl() function will be used.

2:39 PM Changeset in webkit [251259] by Jonathan Bedard

• 4 edits in trunk/Tools

Python 3: Add support in webkitpy.common.net.buildbot
​https://bugs.webkit.org/show_bug.cgi?id=202466

Reviewed by Stephanie Lewis.

• Scripts/test-webkitpy-python3: Add webkitpy.common.net.buildbot to the test list.
• Scripts/webkitpy/common/net/buildbot/buildbot.py:

(Builder.url_encoded_name): Call compatible urllib quote.
(Builder.revision_build_pairs_with_results): Convert iterator to list before returning.
(Build.results_url): Call compatible urllib quote.
(BuildBot._parse_last_build_cell):renderContents needs to be decoded in Python 3.
(BuildBot._parse_current_build_cell): BeautifulSoup and bs4 render breaks differently.
(BuildBot._fetch_build_dictionary): Call compatible urllib quote.

• Scripts/webkitpy/common/net/regressionwindow.py:

(RegressionWindow.revisions): Convert range(...) to list.

2:22 PM Changeset in webkit [251258] by rniwa@webkit.org

• 6 edits
  4 adds in trunk

Make requestIdleCallback suspendable
​https://bugs.webkit.org/show_bug.cgi?id=203023

Reviewed by Chris Dumez.

Source/WebCore:

Make requestIdleCallback suspendable by making WindowEventLoop itself suspendable.
Because WindowEventLoop can be shared across documents, we don't want to make it an ActiveDOMObject.

Instead, we would make CachedFrameBase::restore and CachedFrame manually invoke suspend & resume.

Test: requestidlecallback/requestidlecallback-in-page-cache.html

• dom/Document.h:

(WebCore::Document::eventLoopIfExists): Added. This should probably go away once most of the event loop
is implemented since we're almost always going to have this object then.

• dom/WindowEventLoop.cpp:

(WebCore::WindowEventLoop::queueTask): Because m_tasks may contain tasks of suspended documents,
we check m_activeTaskCount, which is only positive when there is a task for non-suspended documents,
to decide whether we schedule a callback or not.
(WebCore::WindowEventLoop::suspend): Added. No-op for now.
(WebCore::WindowEventLoop::resume): Added. Schedule a callback if there is a task associated with
this document.
(WebCore::WindowEventLoop::run): Skip a task for a suspended document, and add it back to m_tasks along
with other tasks that got scheduled by running the current working set of tasks.

• dom/WindowEventLoop.h:
• history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):

LayoutTests:

• requestidlecallback/requestidlecallback-in-page-cache-expected.txt: Added.
• requestidlecallback/requestidlecallback-in-page-cache.html: Added.
• requestidlecallback/resources: Added.
• requestidlecallback/resources/page-cache-helper.html: Added.

2:20 PM Changeset in webkit [251257] by Brent Fulgham

• 2 edits in trunk/Source/JavaScriptCore

Build fix for newer versions of MSVC.

Rubber stamped by Mark Lam.

Some versions of MSVC optimize the inline optimization of
index away, triggering an uninitialized variable error. This
change avoids this problem.

• runtime/Options.cpp:

(JSC::optionTypeSpecificIndex):

2:02 PM Changeset in webkit [251256] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews] status bubbles should show details from all the builds in case build is retried
​https://bugs.webkit.org/show_bug.cgi?id=203117

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble): Display messages from all the builds (including retried builds) for a patch on a queue.
(StatusBubble._steps_messages_from_multiple_builds): Method to generate status using information from all the retried builds.
(StatusBubble.get_all_builds_for_queue): Method to get all the builds instead of just the latest one.
(StatusBubble.get_latest_build_for_queue): Modified to use the new get_all_builds_for_queue() method.

1:31 PM Changeset in webkit [251255] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Don't put pages that have not reached the non-visually empty layout milestone in the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=203108

Reviewed by Geoffrey Garen.

We don't want to go back to a visually empty page on back/forward navigation.

• history/BackForwardCache.cpp:

(WebCore::canCacheFrame):

• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::visuallyEmptyKey):

• page/DiagnosticLoggingKeys.h:

1:21 PM Changeset in webkit [251254] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: selection shouldn't be dimmed by shadow trees
​https://bugs.webkit.org/show_bug.cgi?id=203057

Reviewed by Joseph Pecoraro.

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom li .selection-area):
(.tree-outline.dom li > span): Added.
Don't force the .selection-area to be behind (z-index: -1;) the rest of the content, as
that also puts it behind any background-color. Instead, we should make all the content in
every WI.DOMTreeElement be above (z-index: 1;) the rest of the content, including the
.selection-area and any parent's background-color.

12:23 PM Changeset in webkit [251253] by commit-queue@webkit.org

• 1 edit
  1 add in trunk/LayoutTests/imported/w3c

Remove duplicate MathML tests
​https://bugs.webkit.org/show_bug.cgi?id=202979

Patch by Rob Buis <​rbuis@igalia.com> on 2019-10-17
Reviewed by Frédéric Wang.

Commit r251187 removed operators/mo-form-fallback-expected.html by
accident, add it again.

• web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback-expected.html: Added.

12:21 PM Changeset in webkit [251252] by commit-queue@webkit.org

• 14 edits
  2 adds in trunk

transform-box: content-box, stroke-box missing
​https://bugs.webkit.org/show_bug.cgi?id=201892

Patch by Dirk Schulze <​krit@webkit.org> on 2019-10-17
Reviewed by Simon Fraser.

Source/WebCore:

Added the keywords content-box and stroke-box to the
transform-box CSS property.
Those keywords were added to the spec after the implementation
in WebKit.

Test: transforms/transform-box.html

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TransformBox const):

• css/CSSProperties.json:
• css/CSSValueKeywords.in:
• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):

• rendering/RenderLayer.cpp:

(WebCore::computeReferenceBox):
(WebCore::transformBoxToCSSBoxType):
(WebCore::RenderLayer::currentTransform const):

• rendering/style/RenderStyleConstants.h:
• svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::animatedLocalTransform const):

LayoutTests:

• fast/css/transform-box-parsing.html:
• svg/transforms/svg-transform-box-expected.html:
• svg/transforms/svg-transform-box.html:
• transforms/transform-box-expected.html: Added.
• transforms/transform-box.html: Added.

12:06 PM Changeset in webkit [251251] by Simon Fraser

• 4 edits in trunk/LayoutTests

[iOS Sim] Layout Test scrollingcoordinator/ios/ui-scroll-fixed.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=196612
rdar://problem/49612867

Reviewed by Antti Koivisto.

This test hit a really obscure bug where a combination of an immediate scroll, and
an ancestor reposition left the layer position of a position:fixed layer unchanged.
The position of this layer in the UI process had been previously modified by
the scrolling tree for the scroll, but because the WebContent-side mutations left
the actual position unchanged, we'd never apply a new position via a commit, so left
the layer in the wrong location.

Removing the m_wasScrolledByDelegatedScrollingSincePreviousCommit check in ScrollingTree::applyLayerPositionsAfterCommit()
fixes this, but has perf implications. Alternative fixes require complex state tracking.
Since this is so hard to hit with noisy user scrolling, just change the test to avoid
the perfect storm of scrolls and offsets.

• platform/ios-simulator-wk2/TestExpectations:
• scrollingcoordinator/ios/ui-scroll-fixed-expected.html:
• scrollingcoordinator/ios/ui-scroll-fixed.html:

11:49 AM Changeset in webkit [251250] by emilio

• 2 edits in trunk/Tools

[GTK] Explicitly use Python 2 in jhbuild-wrapper
​https://bugs.webkit.org/show_bug.cgi?id=202790

Reviewed by Adrian Perez de Castro.

jhbuildutils.py requires Python 2 for the moment, so using just
python fails in distros where Python 3 is the default.

• jhbuild/jhbuild-wrapper:

11:19 AM Changeset in webkit [251249] by youenn@apple.com

• 3 edits in trunk/Source/WebCore

SincResampler does not need to create a new AudioBus for each consumeSource call
​https://bugs.webkit.org/show_bug.cgi?id=202983

Reviewed by Eric Carlson.

Allocate an internal AudioBus once and for all.
No observable change of behavior.

• platform/audio/SincResampler.cpp:

(WebCore::SincResampler::consumeSource):

• platform/audio/SincResampler.h:

11:18 AM Changeset in webkit [251248] by youenn@apple.com

• 1 edit
  23 adds in trunk/Source/ThirdParty/libwebrtc

Add libwebrtc third-party pfft
​https://bugs.webkit.org/show_bug.cgi?id=202733

Reviewed by Eric Carlson.

Initial check-in of pfft which is now used in libwebrtc.

• Source/third_party/pffft: Added.

11:15 AM Changeset in webkit [251247] by Truitt Savell

• 2 edits in trunk/LayoutTests

Unreviewed, rolling out r251231.

This test is still very flakey on all platforms.

Reverted changeset:

"[GStreamer] media/video-seek-after-end.html is no longer
flakey"
​https://bugs.webkit.org/show_bug.cgi?id=203079
​https://trac.webkit.org/changeset/251231

11:13 AM Changeset in webkit [251246] by Truitt Savell

• 2 edits in trunk/LayoutTests

Unreviewed, rolling out r251245.

Addressing this issue differently

Reverted changeset:

"Marking media/video-seek-after-end.html as failing"
​https://bugs.webkit.org/show_bug.cgi?id=203111
​https://trac.webkit.org/changeset/251245

10:52 AM Changeset in webkit [251245] by Truitt Savell

• 2 edits in trunk/LayoutTests

Marking media/video-seek-after-end.html as failing
​https://bugs.webkit.org/show_bug.cgi?id=203111

Unreviewed test gardening.

• platform/mac/TestExpectations:

10:35 AM Changeset in webkit [251244] by Chris Dumez

• 115 edits in trunk/Source/WebCore

Deprecate ActiveDOMObject::canSuspendForDocumentSuspension()
​https://bugs.webkit.org/show_bug.cgi?id=203086

Reviewed by Geoffrey Garen.

Rename ActiveDOMObject::canSuspendForDocumentSuspension() to shouldPreventEnteringBackForwardCache_DEPRECATED()
to make it clear that no new overrides should be added and that it is no longer OK to prevent the page from
entering the back/forward cache. Also provide a default implementation that returns false so that well-behaved
classes no longer need to override this.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::ApplePaySession::canSuspendForDocumentSuspension const): Deleted.

• Modules/applepay/ApplePaySession.h:
• Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::canSuspendForDocumentSuspension const): Deleted.

• Modules/cache/DOMCache.h:
• Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::canSuspendForDocumentSuspension const): Deleted.

• Modules/cache/DOMCacheStorage.h:
• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::MediaKeySession::canSuspendForDocumentSuspension const): Deleted.

• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp:

(WebCore::WebKitMediaKeySession::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::WebKitMediaKeySession::canSuspendForDocumentSuspension const): Deleted.

• Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:
• Modules/entriesapi/FileSystemDirectoryReader.cpp:

(WebCore::FileSystemDirectoryReader::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::FileSystemDirectoryReader::canSuspendForDocumentSuspension const): Deleted.

• Modules/entriesapi/FileSystemDirectoryReader.h:
• Modules/entriesapi/FileSystemEntry.cpp:

(WebCore::FileSystemEntry::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::FileSystemEntry::canSuspendForDocumentSuspension const): Deleted.

• Modules/entriesapi/FileSystemEntry.h:
• Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::FetchRequest::canSuspendForDocumentSuspension const): Deleted.

• Modules/fetch/FetchRequest.h:
• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::FetchResponse::canSuspendForDocumentSuspension const): Deleted.

• Modules/fetch/FetchResponse.h:
• Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::page const):
(WebCore::Geolocation::canSuspendForDocumentSuspension const): Deleted.

• Modules/geolocation/Geolocation.h:
• Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::canSuspendForDocumentSuspension const): Deleted.

• Modules/indexeddb/IDBDatabase.h:
• Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::canSuspendForDocumentSuspension const): Deleted.

• Modules/indexeddb/IDBIndex.h:
• Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::canSuspendForDocumentSuspension const): Deleted.

• Modules/indexeddb/IDBObjectStore.h:
• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::canSuspendForDocumentSuspension const): Deleted.

• Modules/indexeddb/IDBRequest.h:
• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::canSuspendForDocumentSuspension const): Deleted.

• Modules/indexeddb/IDBTransaction.h:
• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::MediaRecorder::canSuspendForDocumentSuspension const): Deleted.

• Modules/mediarecorder/MediaRecorder.h:
• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::canSuspendForDocumentSuspension const): Deleted.

• Modules/mediasource/MediaSource.h:
• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::canSuspendForDocumentSuspension const): Deleted.

• Modules/mediasource/SourceBuffer.h:
• Modules/mediasource/SourceBufferList.cpp:

(WebCore::SourceBufferList::canSuspendForDocumentSuspension const): Deleted.

• Modules/mediasource/SourceBufferList.h:
• Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::canSuspendForDocumentSuspension const): Deleted.

• Modules/mediastream/MediaDevices.h:
• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::MediaStream::canSuspendForDocumentSuspension const): Deleted.

• Modules/mediastream/MediaStream.h:
• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::MediaStreamTrack::canSuspendForDocumentSuspension const): Deleted.

• Modules/mediastream/MediaStreamTrack.h:
• Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::RTCDTMFSender::canSuspendForDocumentSuspension const): Deleted.

• Modules/mediastream/RTCDTMFSender.h:
• Modules/mediastream/RTCDataChannel.h:
• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::RTCPeerConnection::canSuspendForDocumentSuspension const): Deleted.

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::UserMediaRequest::canSuspendForDocumentSuspension const): Deleted.

• Modules/mediastream/UserMediaRequest.h:
• Modules/notifications/Notification.cpp:

(WebCore::Notification::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::Notification::canSuspendForDocumentSuspension const): Deleted.

• Modules/notifications/Notification.h:
• Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::PaymentRequest::canSuspendForDocumentSuspension const): Deleted.

• Modules/paymentrequest/PaymentRequest.h:
• Modules/paymentrequest/PaymentResponse.cpp:

(WebCore::PaymentResponse::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::PaymentResponse::canSuspendForDocumentSuspension const): Deleted.

• Modules/paymentrequest/PaymentResponse.h:
• Modules/pictureinpicture/PictureInPictureWindow.cpp:

(WebCore::PictureInPictureWindow::canSuspendForDocumentSuspension const): Deleted.

• Modules/pictureinpicture/PictureInPictureWindow.h:
• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::AudioContext::canSuspendForDocumentSuspension const): Deleted.

• Modules/webaudio/AudioContext.h:
• Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::DatabaseContext::canSuspendForDocumentSuspension const): Deleted.

• Modules/webdatabase/DatabaseContext.h:
• Modules/webgpu/GPUCanvasContext.h:
• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::canSuspendForDocumentSuspension const): Deleted.

• Modules/websockets/WebSocket.h:
• Modules/webvr/VRDisplay.cpp:

(WebCore::VRDisplay::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::VRDisplay::canSuspendForDocumentSuspension const): Deleted.

• Modules/webvr/VRDisplay.h:
• animation/WebAnimation.cpp:

(WebCore::WebAnimation::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::WebAnimation::canSuspendForDocumentSuspension const): Deleted.

• animation/WebAnimation.h:
• css/FontFaceSet.cpp:

(WebCore::FontFaceSet::canSuspendForDocumentSuspension const): Deleted.

• css/FontFaceSet.h:
• dom/ActiveDOMObject.h:
• dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueueBase<T>::canSuspendForDocumentSuspension const): Deleted.

• dom/GenericEventQueue.h:
• dom/MessagePort.cpp:

(WebCore::MessagePort::canSuspendForDocumentSuspension const): Deleted.

• dom/MessagePort.h:
• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjectsForDocumentSuspension):

• fileapi/FileReader.cpp:

(WebCore::FileReader::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::FileReader::canSuspendForDocumentSuspension const): Deleted.

• fileapi/FileReader.h:
• html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::canSuspendForDocumentSuspension const): Deleted.

• html/HTMLMarqueeElement.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canSuspendForDocumentSuspension const): Deleted.

• html/HTMLMediaElement.h:
• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::canSuspendForDocumentSuspension const): Deleted.

• html/HTMLSourceElement.h:
• html/ImageBitmap.cpp:
• html/PublicURLManager.cpp:

(WebCore::PublicURLManager::canSuspendForDocumentSuspension const): Deleted.

• html/PublicURLManager.h:
• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::canSuspendForDocumentSuspension const): Deleted.

• html/canvas/WebGLRenderingContextBase.h:
• html/track/TrackListBase.cpp:

(WebCore::TrackListBase::canSuspendForDocumentSuspension const): Deleted.

• html/track/TrackListBase.h:
• page/EventSource.cpp:

(WebCore::EventSource::canSuspendForDocumentSuspension const): Deleted.

• page/EventSource.h:
• page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::canSuspendForDocumentSuspension const): Deleted.

• page/IntersectionObserver.h:
• page/ResizeObserver.cpp:

(WebCore::ResizeObserver::canSuspendForDocumentSuspension const): Deleted.

• page/ResizeObserver.h:
• page/SuspendableTimer.cpp:

(WebCore::SuspendableTimerBase::canSuspendForDocumentSuspension const): Deleted.

• page/SuspendableTimer.h:
• platform/SuspendableTaskQueue.cpp:

(WebCore::SuspendableTaskQueue::canSuspendForDocumentSuspension const): Deleted.

• platform/SuspendableTaskQueue.h:
• testing/Internals.cpp:
• workers/Worker.cpp:

(WebCore::Worker::canSuspendForDocumentSuspension const): Deleted.

• workers/Worker.h:
• workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::canSuspendForDocumentSuspension const): Deleted.

• workers/service/ServiceWorker.h:
• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::canSuspendForDocumentSuspension const): Deleted.

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::canSuspendForDocumentSuspension const): Deleted.

• workers/service/ServiceWorkerRegistration.h:
• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::shouldPreventEnteringBackForwardCache_DEPRECATED const):
(WebCore::XMLHttpRequest::canSuspendForDocumentSuspension const): Deleted.

• xml/XMLHttpRequest.h:

10:08 AM Changeset in webkit [251243] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][TFC] Table formatting context accesses geometry information from parent BFC
​https://bugs.webkit.org/show_bug.cgi?id=203082
<rdar://problem/56370827>

Reviewed by Antti Koivisto.

Tables are wrapped in a 2 level formatting context structure. A <table> element initiates a block formatting context for its principal table box
where the caption and the table content live. It also initiates a table wrapper box which establishes the table formatting context.
In many cases the TFC needs access to the parent (generated) BFC.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):

• layout/FormattingContext.h:
• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::computedTableWidth):

10:02 AM Changeset in webkit [251242] by Simon Fraser

• 7 edits in trunk/LayoutTests

Two fast/scrolling/ios/touch-scroll* tests failing in iOS 13
​https://bugs.webkit.org/show_bug.cgi?id=203070
rdar://problem/51756254

Reviewed by Wenson Hsieh.

For some reason the uiController.dragFromPointToPoint() in these tests was too long
to trigger scrolling (maybe an OS change). Fix them to use UIHelper and a shorter
duration, and also to not be sensitive to the exact distance scrolled.

• fast/scrolling/ios/touch-scroll-pointer-events-none-expected.txt:
• fast/scrolling/ios/touch-scroll-pointer-events-none.html:
• fast/scrolling/ios/touch-scroll-visibility-hidden-expected.txt:
• fast/scrolling/ios/touch-scroll-visibility-hidden.html:
• platform/ios-wk2/TestExpectations:
• resources/ui-helper.js:

(window.UIHelper.dragFromPointToPoint):

9:52 AM Changeset in webkit [251241] by Simon Fraser

• 2 edits
  2 adds in trunk/LayoutTests

REGRESSION (r245483) [iPad Simulator] 2 Layout tests fast/scrolling/ios/overflow-scroll-inherited.html fast/scrolling/ios/overflow-scrolling-touch-enabled-stacking.html are failing
​https://bugs.webkit.org/show_bug.cgi?id=203069
rdar://problem/51868813

Reviewed by Zalan Bujtas.

Add new result for overflow-scroll-inherited.html, since -webkit-overflow-scrolling:touch is a no-op
on iPad on iOS 13.

We can't have different image references for different devices, so keep overflow-scrolling-touch-enabled-stacking.html
as an image failure.

• platform/ipad-12/fast/scrolling/ios/overflow-scroll-inherited-expected.txt: Added.
• platform/ipad/TestExpectations:
• platform/ipad/fast/scrolling/ios/overflow-scroll-inherited-expected.txt: Added.

9:46 AM Changeset in webkit [251240] by mmaxfield@apple.com

• 3 edits
  1 add
  3 deletes in trunk/LayoutTests

Make fast/text/font-cursive-italic-cjk.html more robust
​https://bugs.webkit.org/show_bug.cgi?id=203072

Reviewed by Alexey Proskuryakov.

Instead of naming STKaiti by name, we can just use an -expected-mismatch test.

• fast/text/font-cursive-italic-cjk-2-expected.html: Removed.
• fast/text/font-cursive-italic-cjk-2.html: Removed.
• fast/text/font-cursive-italic-cjk-expected-mismatch.html: Added.
• fast/text/font-cursive-italic-cjk-expected.html: Removed.
• fast/text/font-cursive-italic-cjk.html:
• platform/mac/TestExpectations:

9:38 AM Changeset in webkit [251239] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

[LFC][Painting] Add support for image/background image painting
​https://bugs.webkit.org/show_bug.cgi?id=203054
<rdar://problem/56347733>

Reviewed by Antti Koivisto.

In addition to image rendering, this patch also addresses various run/decoration painting issues.

• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintBoxDecoration):
(WebCore::Display::paintInlineContent):
(WebCore::Display::absoluteDisplayBox):
(WebCore::Display::paintBoxDecorationAndChildren):
(WebCore::Display::Painter::paint):

• layout/displaytree/DisplayRun.h:

(WebCore::Display::Run::setImage):
(WebCore::Display::Run::image const):

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::appendNonReplacedInlineBox):
(WebCore::Layout::Line::appendReplacedInlineBox):

• layout/layouttree/LayoutReplaced.h:

(WebCore::Layout::Replaced::setCachedImage):
(WebCore::Layout::Replaced::cachedImage const):

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createLayoutBox):

9:28 AM Changeset in webkit [251238] by Alan Bujtas

• 11 edits in trunk/Source/WebCore

[LFC][IFC] Add Display::Run/LineBox mapping
​https://bugs.webkit.org/show_bug.cgi?id=203051
<rdar://problem/56342487>

Reviewed by Antti Koivisto.

Mapping enables us to paint baseline aligned runs on the current line. This is temporary until after we figure out the final run/line structure.

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):

• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintInlineContent):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineDescentNeedsCollapsing const):

• layout/inlineformatting/InlineFormattingState.h:

(WebCore::Layout::InlineFormattingState::addLineBox):
(WebCore::Layout::InlineFormattingState::lineBoxForRun const):
(WebCore::Layout::InlineFormattingState::addInlineRun):

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::Run::Run):
(WebCore::Layout::Line::alignContentVertically):
(WebCore::Layout::Line::adjustBaselineAndLineHeight):

• layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Run::displayRun const):
(WebCore::Layout::Line::Run::logicalRect const):
(WebCore::Layout::Line::Run::adjustLogicalTop):
(WebCore::Layout::Line::Run::moveVertically):
(WebCore::Layout::Line::Run::moveHorizontally):
(WebCore::Layout::Line::Run::expand):

• layout/inlineformatting/InlineLineBox.h:
• layout/inlineformatting/InlineLineLayout.h:
• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputInlineRuns):

9:24 AM Changeset in webkit [251237] by commit-queue@webkit.org

• 4 edits in trunk/Source

[Web Animations] Enable the Web Animations JavaScript API by default
​https://bugs.webkit.org/show_bug.cgi?id=203075

Patch by Antoine Quint <Antoine Quint> on 2019-10-17
Reviewed by Antti Koivisto.

Source/WebCore:

• page/RuntimeEnabledFeatures.h:

Source/WebKit:

• Shared/WebPreferences.yaml:

9:04 AM Changeset in webkit [251236] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Unreviewed, fix watchOS and tvOS builds after r251224

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::shouldTreatAtLeastOneTypeAsFile):

Move the shouldTreatAtLeastOneTypeAsFile helper function out of the PASTEBOARD_SUPPORTS_ITEM_PROVIDERS
section, and into generic iOS-family code so that it can be used in pasteboardMayContainFilePaths.

8:47 AM Changeset in webkit [251235] by clopez@igalia.com

• 2 edits in trunk/PerformanceTests

[GTK] Perf test IndexedDB/basic/index-cursor-delete.html timeouts
​https://bugs.webkit.org/show_bug.cgi?id=203083

Unreviewed gardening.

• Skipped: Skip a test that is timing out on the GTK perf bot.

8:14 AM Changeset in webkit [251234] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Check values of variables before extracting index in perl
​https://bugs.webkit.org/show_bug.cgi?id=202333

Patch by Paulo Matos <Paulo Matos> on 2019-10-17
Reviewed by Jonathan Bedard.

If compiler doesn't properly report the host and target it was
compiled for, lacking better information we just go ahead and assume
there is no cross compilation involved.

• Scripts/webkitdirs.pm:

(isCrossCompilation):

8:08 AM Changeset in webkit [251233] by Pablo Saavedra

• 1 edit
  1 add in trunk/Tools

Add a driver for MiniBrowser running with WPE for
benchmark_runner
​https://bugs.webkit.org/show_bug.cgi?id=202994

Reviewed by Žan Doberšek.

• Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowserwpe_driver.py: Added.

(WPEMiniBrowserDriver):
(WPEMiniBrowserDriver.launch_url):
(WPEMiniBrowserDriver.launch_driver):

7:51 AM Changeset in webkit [251232] by clopez@igalia.com

• 2 edits in trunk/Tools

run-buildbot-test: sqlalchemy exception when upgrading the database
​https://bugs.webkit.org/show_bug.cgi?id=202927

Reviewed by Adrian Perez de Castro.

Update the version of sqlalchemy-migrate for pip used for the test.
That fixes the exception when upgrading the database.

• BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:

4:28 AM Changeset in webkit [251231] by cturner@igalia.com

• 2 edits in trunk/LayoutTests

[GStreamer] media/video-seek-after-end.html is no longer flakey
​https://bugs.webkit.org/show_bug.cgi?id=203079

Unreviewed test gardening

• TestExpectations:

3:29 AM Changeset in webkit [251230] by youenn@apple.com

• 3 edits in trunk/Source/WebCore

MultiChannelResampler does not need to recreate a ChannelProvider for every process call
​https://bugs.webkit.org/show_bug.cgi?id=202982

Reviewed by Eric Carlson.

We no longer allocate a new ChannelProvider for every process call.
No observable change of behavior.

• platform/audio/MultiChannelResampler.cpp:

(WebCore::MultiChannelResampler::ChannelProvider::ChannelProvider):
(WebCore::MultiChannelResampler::ChannelProvider::setProvider):
(WebCore::MultiChannelResampler::MultiChannelResampler):
(WebCore::MultiChannelResampler::process):

• platform/audio/MultiChannelResampler.h:

2:05 AM Changeset in webkit [251229] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network: updates when toggling resource caching should be sent to every connected target
​https://bugs.webkit.org/show_bug.cgi?id=203025

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WI._resourceCachingDisabledSettingChanged):

1:12 AM Changeset in webkit [251228] by clopez@igalia.com

• 2 edits in trunk/Source/WebKit

[GTK][WPE] File and Directory Entries API is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=202796

Reviewed by Adrian Perez de Castro.

Enable by default the DirectoryUpload runtime setting that is
used to enable the APIs of the File and Directory Entries API.

Enable also the DataTransferItemsEnabled runtime setting that
exposes the DataTransferItem API. This makes the manual tests
available at ​https://w3c-test.org/entries-api mostly pass on
platform GTK (those tests need also the DataTransferItem API
to enable the drag-and-drop).

The bug <​https://webkit.org/b/98940> for DataTransferItem API
remains open because the layout test editing/pasteboard/data-transfer-items.html
is still not passing completely. However other manual tests for
DataTransferItem pass after enabling it.

• Shared/WebPreferencesDefaultValues.h:

1:00 AM Changeset in webkit [251227] by Devin Rousso

• 238 edits
  7 copies
  3 moves
  23 adds
  5 deletes in trunk

Web Inspector: rework frontend agent construction to allow commands/events to be controlled by the related target's type
​https://bugs.webkit.org/show_bug.cgi?id=200384
<rdar://problem/53850352>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/scripts/codegen/generate_js_backend_commands.py:

(JSBackendCommandsGenerator.generate_domain):
(JSBackendCommandsGenerator.generate_domain.generate_parameter_object):

• inspector/scripts/codegen/models.py:

(validate_target_types): Added.
(Protocol.parse_domain):
(Protocol.parse_command):
(Protocol.parse_event):
(Domain.init):
(Domains):
(Command.init):
(Event.init):

• inspector/protocol/ApplicationCache.json:
• inspector/protocol/Audit.json:
• inspector/protocol/CPUProfiler.json:
• inspector/protocol/CSS.json:
• inspector/protocol/Canvas.json:
• inspector/protocol/Console.json:
• inspector/protocol/DOM.json:
• inspector/protocol/DOMDebugger.json:
• inspector/protocol/DOMStorage.json:
• inspector/protocol/Database.json:
• inspector/protocol/Debugger.json:
• inspector/protocol/Heap.json:
• inspector/protocol/IndexedDB.json:
• inspector/protocol/Inspector.json:
• inspector/protocol/LayerTree.json:
• inspector/protocol/Memory.json:
• inspector/protocol/Network.json:
• inspector/protocol/Page.json:
• inspector/protocol/Recording.json:
• inspector/protocol/Runtime.json:
• inspector/protocol/ScriptProfiler.json:
• inspector/protocol/Security.json:
• inspector/protocol/ServiceWorker.json:
• inspector/protocol/Target.json:
• inspector/protocol/Timeline.json:
• inspector/protocol/Worker.json:

Add debuggableTypes and targetTypes arrays to domains/commands/events that are used when
generating InspectorBackendCommands.js for more accurate compatibility checks.

• inspector/InspectorTarget.h:
• inspector/agents/InspectorTargetAgent.h:
• inspector/agents/InspectorTargetAgent.cpp:

(Inspector::targetTypeToProtocolType):
(Inspector::InspectorTargetAgent::exists): Deleted.
Remove Target.exists now that the frontend can do proper feature checking.

• inspector/remote/RemoteControllableTarget.h:
• inspector/remote/RemoteInspectionTarget.h:
• inspector/remote/RemoteInspectorConstants.h:
• inspector/remote/cocoa/RemoteInspectorCocoa.mm:

(Inspector::RemoteInspector::listingForInspectionTarget const):

• inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::listingForInspectionTarget const):

• inspector/remote/socket/RemoteInspectorSocket.cpp:

(Inspector::RemoteInspector::listingForInspectionTarget const):
Split the Web debuggable type into Page (WebCore::Page) and WebPage (WebKit::WebPageProxy).

• inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
• inspector/scripts/tests/generic/command-targetType-matching-domain-debuggableType.json: Added.
• inspector/scripts/tests/generic/domain-availability.json: Removed.
• inspector/scripts/tests/generic/domain-debuggableTypes.json: Added.
• inspector/scripts/tests/generic/domain-targetType-matching-domain-debuggableType.json: Added.
• inspector/scripts/tests/generic/domain-targetTypes.json: Added.
• inspector/scripts/tests/generic/event-targetType-matching-domain-debuggableType.json: Added.
• inspector/scripts/tests/generic/expected/command-targetType-matching-domain-debuggableType.json-result: Added.
• inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/generic/expected/domain-debuggableTypes.json-result: Added.
• inspector/scripts/tests/generic/expected/domain-targetType-matching-domain-debuggableType.json-result: Added.
• inspector/scripts/tests/generic/expected/domain-targetTypes.json-result: Added.
• inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
• inspector/scripts/tests/generic/expected/enum-values.json-result:
• inspector/scripts/tests/generic/expected/event-targetType-matching-domain-debuggableType.json-result: Added.
• inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
• inspector/scripts/tests/generic/expected/fail-on-command-targetType-matching-domain-debuggableType.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-command-targetTypes-type.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-command-targetTypes-value.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-domain-availability-type.json-error: Removed.
• inspector/scripts/tests/generic/expected/fail-on-domain-availability-value.json-error: Removed.
• inspector/scripts/tests/generic/expected/fail-on-domain-availability.json-error: Removed.
• inspector/scripts/tests/generic/expected/fail-on-domain-debuggableTypes-type.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-domain-debuggableTypes-value.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-domain-targetType-matching-domain-debuggableType.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-domain-targetTypes-type.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-domain-targetTypes-value.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-event-targetType-matching-domain-debuggableType.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-event-targetTypes-type.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-event-targetTypes-value.json-error: Added.
• inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
• inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
• inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
• inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
• inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
• inspector/scripts/tests/generic/expected/version.json-result:
• inspector/scripts/tests/generic/fail-on-command-targetType-matching-domain-debuggableType.json: Added.
• inspector/scripts/tests/generic/fail-on-command-targetTypes-type.json: Added.
• inspector/scripts/tests/generic/fail-on-command-targetTypes-value.json: Added.
• inspector/scripts/tests/generic/fail-on-domain-debuggableTypes-type.json: Added.
• inspector/scripts/tests/generic/fail-on-domain-debuggableTypes-value.json: Added.
• inspector/scripts/tests/generic/fail-on-domain-targetType-matching-domain-debuggableType.json: Added.
• inspector/scripts/tests/generic/fail-on-domain-targetTypes-type.json: Added.
• inspector/scripts/tests/generic/fail-on-domain-targetTypes-value.json: Added.
• inspector/scripts/tests/generic/fail-on-event-targetType-matching-domain-debuggableType.json: Added.
• inspector/scripts/tests/generic/fail-on-event-targetTypes-type.json: Added.
• inspector/scripts/tests/generic/fail-on-event-targetTypes-value.json: Added.
• inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:

Update test results, as well as added new tests for debuggableTypes and targetTypes.

Source/WebCore:

• inspector/InspectorFrontendClient.h:

(WebCore::InspectorFrontendClient::backendCommandsURL): Deleted.
(WebCore::InspectorFrontendClient::debuggableType): Deleted.

• inspector/InspectorFrontendClientLocal.h:
• page/PageDebuggable.h:

(WebCore::PageDebuggable::type const):

• testing/Internals.cpp:

(WebCore::InspectorStubFrontend::debuggableType const): Added.
Split the Web debuggable type into Page (WebCore::Page) and WebPage (WebKit::WebPageProxy).

Source/WebInspectorUI:

InspectorBackend.domains.${domain} isn't a truly valid way to feature check, as it
indicates what's supported by the WebKit framework underlying whatever's currently being
inspected, not what the current inspection target supports.

As an example, inspecting an iOS JSContext will still show InspectorBackend.domains.DOM
as the DOMAgent is supported by WebKit, even though JSContexts have no concept of the
DOM. In this example, however, window.DOMAgent would NOT exist, as the availability
check for the DOM domain wouldn't pass, meaning that the agent never gets connected.

In order to do proper feature checking, InspectorBackend.domains needs to be accurate
depending on the debuggable type. Furthermore, each target underneath that debuggable needs
to be able to "choose" what commands/events are supported based on that target's type.

This patch modifies how InspectorBackendCommands.js ties into InspectorBackend. Rather
than directly creating an InspectorBackend.Agent for each domain, we now create more of a
"blueprint" of the domain, and wait to actually create an InspectorBackend.Agent until we
have a WI.Target (and therefore an InspectorBackend.Connection). Each "concept" of the
protocol now directly maps to an object.

• InspectorBackend.Domain
• InspectorBackend.Command
• InspectorBackend.Event
• InspectorBackend.Dispatcher

When a WI.Target is created, it gets the list of InspectorBackend.Domain that support
that WI.Target's type (specified in the protocol JSON files) and generates an
InspectorBackend.Agent for each, which in turn generates an InspectorBackend.Callable
for each supported InspectorBackend.Command and instantiates InspectorBackend.Dispatcher.

Activating a InspectorBackend.Domain means it's visible for InspectorBackend feature
checking. This must be done this way for older ITML backends that will still appear as
"JSContext" targets and therefore go through the "extra domains" path. Ideally, the process
of registering a domain should be enough to activate it. <​https://webkit.org/b/201150>

Feature checking can now only be done via hasDomain, hasCommand, and hasEvent on
InspectorBackend or a specific WI.Target, and there are different implications for each:

• InspectorBackend.hasDomain(DOM) asks whether the DOM domain is supported by the current debuggable, but says nothing about whether any WI.Target support DOM.
• target.hasDomain("DOM") asks whether the given target supports DOM, which is limited by InspectorBackend.hasDomain("DOM").

Now that InspectorBackend.Agent is only created by a WI.Target, it's no longer valid to
write window.DOMAgent, as there is no "global" agent. All protocol logic _must_ go through
a WI.Target. <​https://webkit.org/b/201149>

Debuggable Types:

• JavaScript (JSC::JSGlobalObject)
• Page (WebCore::Page)
• ServiceWorker (WebCore::ServiceWorkerThreadProxy)
• WebPage (WebKit::WebPageProxy)

Target Types:

• JavaScript (direct connection)
• Page (multi-target connection to any Worker)
• ServiceWorker (direct connection)
• WebPage (multi-target connection to 1+ Page)
• Worker (direct connection, only available for Page debuggables)

• UserInterface/Base/DebuggableType.js:
• UserInterface/Base/TargetType.js: Copied from Source/WebInspectorUI/UserInterface/Base/DebuggableType.js.
• UserInterface/Protocol/Connection.js:
• UserInterface/Protocol/InspectorBackend.js:

• UserInterface/Protocol/ApplicationCacheObserver.js:
• UserInterface/Protocol/CPUProfilerObserver.js:
• UserInterface/Protocol/CSSObserver.js:
• UserInterface/Protocol/CanvasObserver.js:
• UserInterface/Protocol/ConsoleObserver.js:
• UserInterface/Protocol/DOMObserver.js:
• UserInterface/Protocol/DOMStorageObserver.js:
• UserInterface/Protocol/DatabaseObserver.js:
• UserInterface/Protocol/DebuggerObserver.js:
• UserInterface/Protocol/HeapObserver.js:
• UserInterface/Protocol/InspectorObserver.js:
• UserInterface/Protocol/LayerTreeObserver.js:
• UserInterface/Protocol/MemoryObserver.js:
• UserInterface/Protocol/NetworkObserver.js:
• UserInterface/Protocol/PageObserver.js:
• UserInterface/Protocol/RuntimeObserver.js:
• UserInterface/Protocol/ScriptProfilerObserver.js:
• UserInterface/Protocol/TargetObserver.js:
• UserInterface/Protocol/TimelineObserver.js:
• UserInterface/Protocol/WorkerObserver.js:

All observers now extend from InspectorBackend.Dispatcher and have a separate instance for
each InspectorBackend.Agent, each having their own _target.

• UserInterface/Protocol/Target.js:
• UserInterface/Protocol/DirectBackendTarget.js:
• UserInterface/Protocol/JavaScriptContextTarget.js: Removed.
• UserInterface/Protocol/MultiplexingBackendTarget.js:
• UserInterface/Protocol/PageTarget.js:
• UserInterface/Protocol/WorkerTarget.js:

Agents are now created per-target instead of copied from the "global" list. This means that
agents can have a different set of commands/events depending on the associated target.

• UserInterface/Base/Main.js:
• UserInterface/Base/Utilities.js:
• UserInterface/Controllers/AppController.js:
• UserInterface/Controllers/AppControllerBase.js:
• UserInterface/Controllers/ApplicationCacheManager.js:
• UserInterface/Controllers/AuditManager.js:
• UserInterface/Controllers/BreakpointPopoverController.js:
• UserInterface/Controllers/CSSManager.js:
• UserInterface/Controllers/CanvasManager.js:
• UserInterface/Controllers/ConsoleManager.js:
• UserInterface/Controllers/DOMDebuggerManager.js:
• UserInterface/Controllers/DOMManager.js:
• UserInterface/Controllers/DOMStorageManager.js:
• UserInterface/Controllers/DatabaseManager.js:
• UserInterface/Controllers/DebuggerManager.js:
• UserInterface/Controllers/HeapManager.js:
• UserInterface/Controllers/IndexedDBManager.js:
• UserInterface/Controllers/JavaScriptLogViewController.js:
• UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
• UserInterface/Controllers/LayerTreeManager.js:
• UserInterface/Controllers/MemoryManager.js:
• UserInterface/Controllers/NetworkManager.js:
• UserInterface/Controllers/RuntimeManager.js:
• UserInterface/Controllers/TargetManager.js:
• UserInterface/Controllers/TimelineManager.js:
• UserInterface/Controllers/WorkerManager.js:
• UserInterface/Main.html:
• UserInterface/Models/AuditTestBase.js:
• UserInterface/Models/AuditTestCase.js:
• UserInterface/Models/AuditTestCaseResult.js:
• UserInterface/Models/CPUInstrument.js:
• UserInterface/Models/CPUTimelineRecord.js:
• UserInterface/Models/CSSCompletions.js:
• UserInterface/Models/CSSStyleSheet.js:
• UserInterface/Models/Canvas.js:
• UserInterface/Models/DOMNode.js:
• UserInterface/Models/DOMNodeStyles.js:
• UserInterface/Models/DOMStorageObject.js:
• UserInterface/Models/DOMTree.js:
• UserInterface/Models/DatabaseObject.js:
• UserInterface/Models/FPSInstrument.js:
• UserInterface/Models/GarbageCollection.js:
• UserInterface/Models/HeapAllocationsInstrument.js:
• UserInterface/Models/Instrument.js:
• UserInterface/Models/MediaInstrument.js:
• UserInterface/Models/MemoryInstrument.js:
• UserInterface/Models/MemoryPressureEvent.js:
• UserInterface/Models/MemoryTimelineRecord.js:
• UserInterface/Models/Recording.js:
• UserInterface/Models/Resource.js:
• UserInterface/Models/ScriptInstrument.js:
• UserInterface/Models/ScriptSyntaxTree.js:
• UserInterface/Models/ScriptTimelineRecord.js:
• UserInterface/Models/ShaderProgram.js:
• UserInterface/Models/SourceMapResource.js:
• UserInterface/Models/TimelineRecording.js:
• UserInterface/Protocol/RemoteObject.js:
• UserInterface/Test.html:
• UserInterface/Test/FrontendTestHarness.js:
• UserInterface/Test/Test.js:
• UserInterface/Test/TestAppController.js:
• UserInterface/Views/AuditNavigationSidebarPanel.js:
• UserInterface/Views/AuditTabContentView.js:
• UserInterface/Views/CanvasTabContentView.js:
• UserInterface/Views/ContextMenuUtilities.js:
• UserInterface/Views/CookieStorageContentView.js:
• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
• UserInterface/Views/DOMTreeContentView.js:
• UserInterface/Views/ElementsTabContentView.js:
• UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js:
• UserInterface/Views/Layers3DContentView.js:
• UserInterface/Views/LayersTabContentView.js:
• UserInterface/Views/LayoutTimelineView.js:
• UserInterface/Views/LogContentView.js:
• UserInterface/Views/NetworkTabContentView.js:
• UserInterface/Views/NetworkTableContentView.js:
• UserInterface/Views/NetworkTimelineView.js:
• UserInterface/Views/ObjectTreeView.js:
• UserInterface/Views/QuickConsole.js:
• UserInterface/Views/ResourceDetailsSidebarPanel.js:
• UserInterface/Views/ScriptClusterTimelineView.js:
• UserInterface/Views/ScriptDetailsTimelineView.js:
• UserInterface/Views/ScriptTreeElement.js:
• UserInterface/Views/SearchSidebarPanel.js:
• UserInterface/Views/SearchTabContentView.js:
• UserInterface/Views/SettingsTabContentView.js:
• UserInterface/Views/SourceCodeTextEditor.js:
• UserInterface/Views/SourcesNavigationSidebarPanel.js:
• UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
• UserInterface/Views/SpreadsheetStyleProperty.js:
• UserInterface/Views/StorageTabContentView.js:
• UserInterface/Views/TimelineRecordingContentView.js:
• UserInterface/Views/TimelineTabContentView.js:
• UserInterface/Views/Toolbar.js:
• UserInterface/Views/WebSocketContentView.js:
• UserInterface/Views/WorkerTreeElement.js:

Replace all instances of window.DomainAgent with target.DomainAgent, where target is
either derived from an associated model object or WI.assumingMainTarget().
Split the WI.DebuggableType.Web debuggable type into WI.DebuggableType.Page (WebCore::Page)
and WI.DebuggableType.WebPage (WebKit::WebPageProxy).

• UserInterface/Protocol/Legacy/*:
• Versions/*:

Update protocol files for older versions of iOS.

• .eslintrc:
• Localizations/en.lproj/localizedStrings.js:

Source/WebKit:

• WebProcess/WebPage/RemoteWebInspectorUI.h:

(WebKit::WebInspectorUI::backendCommandsURL const): Added.
(WebKit::WebInspectorUI::debuggableType const): Added.
(WebKit::WebInspectorUI::backendCommandsURL): Deleted.
(WebKit::WebInspectorUI::debuggableType): Deleted.

• WebProcess/WebPage/WebInspectorUI.h:

(WebKit::WebInspectorUI::backendCommandsURL const): Added.
(WebKit::WebInspectorUI::debuggableType const): Added.

• UIProcess/WebPageDebuggable.h:

(WebKit::WebPageDebuggable::type const):

• UIProcess/glib/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorClient::RemoteInspectorClient):

• UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
• UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(debuggableTypeString):
Split the Web debuggable type into Page (WebCore::Page) and WebPage (WebKit::WebPageProxy).

Source/WebKitLegacy/mac:

• WebCoreSupport/WebInspectorClient.h:

(WebInspectorFrontendClient::debuggableType const): Added.
Split the Web debuggable type into Page (WebCore::Page) and WebPage (WebKit::WebPageProxy).

Source/WebKitLegacy/win:

• WebCoreSupport/WebInspectorClient.h:

(WebInspectorFrontendClient::debuggableType const): Added.
Split the Web debuggable type into Page (WebCore::Page) and WebPage (WebKit::WebPageProxy).

LayoutTests:

• inspector/canvas/requestShaderSource-webgl.html:
• inspector/canvas/updateShader-webgl:
• inspector/page/overrideSetting.html:
• inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
• inspector/page/overrideSetting-MockCaptureDevicesEnabled.html:
• inspector/runtime/parse.html:

Replace all instances of DomainAgent.Enum with InspectorBackend.domains.Domain.Enum.

• inspector/audit/run.html:
• inspector/audit/version.html:
• inspector/recording/version.html:

Use new InspectorBackend methods.

• inspector/unit-tests/target-manager.html:
• inspector/unit-tests/target-manager-expected.txt:
• inspector/worker/console-basic.html:
• inspector/worker/debugger-pause.html:
• inspector/worker/debugger-scripts.html:
• inspector/worker/debugger-shared-breakpoint.html:
• inspector/worker/resources-in-worker.html:
• inspector/worker/resources/dom-debugger-utilities.js:
• inspector/worker/runtime-basic.html:
• http/tests/inspector/worker/blob-script-with-cross-domain-imported-scripts.html:

Replace WI.Target.Type with WI.TargetType.

• inspector/dom/inspect.html:
• inspector/dom/inspect-expected.txt:

Rewrite test since faking events from the backend now requires a target.

• inspector/unit-tests/set-utilities.html:
• inspector/unit-tests/set-utilities-expected.txt:

Add tests for Set.prototype.addAll.