Context Navigation

← Previous Period
Next Period →

Timeline

Oct 25, 2019:

11:45 PM Changeset in webkit [251629] by yurys@chromium.org

1 edit
1 delete in trunk/LayoutTests

Web Inspector: remove custom expectations from platform/gtk/inspector-protocol
https://bugs.webkit.org/show_bug.cgi?id=203453

Unreviewed, test expectations cleanup.

platform/gtk/inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local-expected.txt: Removed.
platform/gtk/inspector-protocol/debugger/setBreakpoint-dfg-expected.txt: Removed.
platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Removed.

Removed platform/gtk/inspector-protocol altogether as there is no LayoutTests/inspector-protocol
folder any more. Corresponding tests were either deleted or moved to LayoutTests/inspector a while ago.

11:12 PM Changeset in webkit [251628] by yurys@chromium.org

6 edits in trunk/LayoutTests

[GTK] Layout test inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139359

Reviewed by Devin Rousso.

Renable the test on all platforms. With the current implementation of inspector client in tests
response to Debugger.resume is dispatched in the front-end synchronously and the front-end would
call InspectoTest.log when inspected script execution is not yet resumed.

inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt:
inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:

9:53 PM Changeset in webkit [251627] by Chris Dumez

2 edits in trunk/Source/WebKit

REGRESSION(r251599): Crash in MobileSafari tests (ASSERTION FAILED: m_pendingRequestToSuspendID)
https://bugs.webkit.org/show_bug.cgi?id=203437
<rdar://problem/56633399>

Reviewed by Geoffrey Garen.

UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::updateAssertionIfNeeded):
Start the timer before sending the PrepareToSuspend IPC. The reason is that if the process has been
terminated, the completion handler may run synchronously and cancel the request to suspend / stop
the timer. Therefore, re-starting the timer after would be a mistake.

7:38 PM Changeset in webkit [251626] by eric.carlson@apple.com

10 edits in trunk

Support for callbacks for manifest events
https://bugs.webkit.org/show_bug.cgi?id=202101
<rdar://problem/54277362>

Reviewed by Jer Noble.
Source/WebCore:

Use AVPlayerItemMetadataCollector to get manifest based time metadata. Use
AVPlayerItemMetadataOutput to get time metadata instead of listening for a "timedMetadata"
KVO on AVPlayer.

No new tests, existing test updated.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::globalMetadataProcessingQueue):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::metadataType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataGroupDidArrive):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(WebCore::itemKVOProperties):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFMovieObserver metadataOutput:didOutputTimedMetadataGroups:fromPlayerItemTrack:]):
(-[WebCoreAVFMovieObserver metadataCollector:didCollectDateRangeMetadataGroups:indexesOfNewGroups:indexesOfModifiedGroups:]):

Source/WebCore/PAL:

pal/cocoa/AVFoundationSoftLink.h:
pal/cocoa/AVFoundationSoftLink.mm:

LayoutTests:

http/tests/media/resources/hls/metadata/prog_index.m3u8:
http/tests/media/track-in-band-hls-metadata-expected.txt:
http/tests/media/track-in-band-hls-metadata.html:

7:36 PM Changeset in webkit [251625] by Wenson Hsieh

6 edits in trunk/LayoutTests

[iOS WK2] fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196298
<rdar://problem/49337021>

Reviewed by Simon Fraser.

fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta-expected.txt:
fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta.html:

Adjust this flaky layout test so that it's more robust:

Begin the test after the first visible content rect update following the load event.
Add an initial step to the test to sanity check the viewport dimensions when setting the minimum effective

device width to 0.

At each step, instead of waiting for the next visible content rect update and presentation update, simply

wait for the window width to reach the expected value.

From local testing, this brings the test failure rate down from ~25 failures in 1000 runs to 0 failures.

platform/ios-simulator-wk2/TestExpectations:
platform/ios/TestExpectations:

Remove the failing test expectations.

platform/ipad/fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta-expected.txt:

Adjust the text expectations so that they contain an entry for setMinimumEffectiveWidth(0) as well.

6:57 PM Changeset in webkit [251624] by Devin Rousso

5 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: un-experimentalize showing rule icons
https://bugs.webkit.org/show_bug.cgi?id=203308

Reviewed by Joseph Pecoraro.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Base/Setting.js:
UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._renderSelector):

6:48 PM Changeset in webkit [251623] by aestes@apple.com

15 edits
2 copies
1 add in trunk/Source

[Quick Look] Move the QLPreviewConverter delegate into PreviewConverter and vend a C++ client interface
https://bugs.webkit.org/show_bug.cgi?id=203396

Reviewed by Alex Christensen.

Source/WebCore:

PreviewConverter existed as a thin wrapper around QLPreviewConverter for use by
LegacyPreviewLoader and Quick Look NSData loading in WebKitLegacy. This patch makes two
changes to this arrangement:

The QLPreviewConverter delegate and the bulk of the conversion state machine was moved

into PreviewConverter, which now vends a C++ client interface. LegacyPreviewLoader is now a
client of its PreviewConverter, retaining the responsiility of interacting with the
ResourceLoader and LegacyPreviewLoaderClient.

The Quick Look NSData loading code for WebKitLegacy now uses QLPreviewConverter API

directly rather than creating a PreviewConverter. This code path does not require a delegate
nor any of the other logic in PreviewConverter.

This change also organizes PreviewConverter into a cross-platform .cpp file and an
iOS-specific .mm file for the direct usage of QLPreviewConverter API. LegacyPreviewConverter
was also organized such that it can be changed from .mm to .cpp in a future patch.

No change in behavior. Covered by existing API and layout tests.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setPreviewConverter):

loader/DocumentLoader.h: Changed m_previewConverter from std::unique_ptr to RefPtr.

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): Used makeUnique directly instead of
LegacyPreviewLoader::create().

loader/ios/LegacyPreviewLoader.h: Privately inherited from PreviewConverterClient and

PreviewConverterProvider and migrated WebPreviewLoader ivars to member variables.

loader/ios/LegacyPreviewLoader.mm:

(WebCore::makeClient):
(WebCore::LegacyPreviewLoader::didReceiveBuffer):
(WebCore::LegacyPreviewLoader::didFinishLoading):
(WebCore::LegacyPreviewLoader::didFail):
(WebCore::LegacyPreviewLoader::previewConverterDidStartConverting):
(WebCore::LegacyPreviewLoader::previewConverterDidReceiveData):
(WebCore::LegacyPreviewLoader::previewConverterDidFinishConverting):
(WebCore::LegacyPreviewLoader::previewConverterDidFailUpdating):
(WebCore::LegacyPreviewLoader::previewConverterDidFailConverting):
(WebCore::LegacyPreviewLoader::providePasswordForPreviewConverter):
(WebCore::LegacyPreviewLoader::provideMainResourceForPreviewConverter):
(WebCore::LegacyPreviewLoader::LegacyPreviewLoader):
(WebCore::LegacyPreviewLoader::didReceiveData):
(WebCore::LegacyPreviewLoader::didReceiveResponse):
(testingClient): Deleted.
(emptyClient): Deleted.
(-[WebPreviewLoader initWithResourceLoader:resourceResponse:]): Deleted.
(-[WebPreviewLoader appendDataArray:]): Deleted.
(-[WebPreviewLoader finishedAppending]): Deleted.
(-[WebPreviewLoader failed]): Deleted.
(-[WebPreviewLoader _loadPreviewIfNeeded]): Deleted.
(-[WebPreviewLoader connection:didReceiveData:lengthReceived:]): Deleted.
(-[WebPreviewLoader connectionDidFinishLoading:]): Deleted.
(isQuickLookPasswordError): Deleted.
(-[WebPreviewLoader connection:didFailWithError:]): Deleted.
(WebCore::LegacyPreviewLoader::~LegacyPreviewLoader): Deleted.
(WebCore::LegacyPreviewLoader::create): Deleted.

platform/PreviewConverter.cpp: Added.

(WebCore::PreviewConverter::supportsMIMEType):
(WebCore::PreviewConverter::previewResponse const):
(WebCore::PreviewConverter::previewError const):
(WebCore::PreviewConverter::previewData const):
(WebCore::PreviewConverter::updateMainResource):
(WebCore::PreviewConverter::appendFromBuffer):
(WebCore::PreviewConverter::finishUpdating):
(WebCore::PreviewConverter::failedUpdating):
(WebCore::PreviewConverter::hasClient const):
(WebCore::PreviewConverter::addClient):
(WebCore::PreviewConverter::removeClient):
(WebCore::sharedPasswordForTesting):
(WebCore::PreviewConverter::passwordForTesting):
(WebCore::PreviewConverter::setPasswordForTesting):
(WebCore::PreviewConverter::iterateClients):
(WebCore::PreviewConverter::didAddClient):
(WebCore::PreviewConverter::didFailConvertingWithError):
(WebCore::PreviewConverter::didFailUpdating):
(WebCore::PreviewConverter::replayToClient):
(WebCore::PreviewConverter::delegateDidReceiveData):
(WebCore::PreviewConverter::delegateDidFinishLoading):
(WebCore::PreviewConverter::delegateDidFailWithError):

platform/PreviewConverter.h:

(WebCore::PreviewConverter::PreviewConverter): Deleted.
(WebCore::PreviewConverter::platformConverter const): Deleted.

platform/PreviewConverterClient.h: Copied from Source/WebCore/platform/PreviewConverter.h.
platform/PreviewConverterProvider.h: Copied from Source/WebCore/platform/PreviewConverter.h.
platform/ios/PreviewConverterIOS.mm:

(-[WebPreviewConverterDelegate initWithDelegate:]):
(-[WebPreviewConverterDelegate connection:didReceiveData:lengthReceived:]):
(-[WebPreviewConverterDelegate connectionDidFinishLoading:]):
(-[WebPreviewConverterDelegate connection:didFailWithError:]):
(WebCore::PreviewConverter::PreviewConverter):
(WebCore::PreviewConverter::platformSupportedMIMETypes):
(WebCore::PreviewConverter::safeRequest const):
(WebCore::PreviewConverter::platformPreviewResponse const):
(WebCore::PreviewConverter::platformAppend):
(WebCore::PreviewConverter::platformFinishedAppending):
(WebCore::PreviewConverter::platformFailedAppending):
(WebCore::PreviewConverter::isPlatformPasswordError const):
(WebCore::optionsWithPassword):
(WebCore::PreviewConverter::platformUnlockWithPassword):
(WebCore::PreviewConverter::supportsMIMEType): Deleted.
(WebCore::PreviewConverter::previewRequest const): Deleted.
(WebCore::PreviewConverter::previewResponse const): Deleted.

platform/ios/QuickLook.mm:

(WebCore::registerQLPreviewConverterIfNeeded): Used QLPreviewConverter directly.

Source/WebCore/PAL:

pal/spi/ios/QuickLookSPI.h:

Source/WTF:

wtf/FeatureDefines.h: Defined ENABLE_PREVIEW_CONVERTER.

6:40 PM Changeset in webkit [251622] by Wenson Hsieh

2 edits in trunk/LayoutTests

Adjust a layout test after r251522
https://bugs.webkit.org/show_bug.cgi?id=202663

Reviewed by Simon Fraser.

Fix relative file paths when including ui-helper.js and basic-gestures.js.

fast/events/touch/ios/long-press-on-link.html:

6:21 PM Changeset in webkit [251621] by yurys@chromium.org

4 edits in trunk/LayoutTests

[GTK] LayoutTests/inspector tests timeout
https://bugs.webkit.org/show_bug.cgi?id=147518

Reviewed by Devin Rousso.

Renable inspector/model tests on GTK.

TestExpectations: There are two real issues that actually happen on all platforms,

filed separate bugs for each of them.

platform/gtk/TestExpectations:
platform/mac/TestExpectations:

6:10 PM Changeset in webkit [251620] by yurys@chromium.org

14 edits
6 adds in trunk

Web Inspector: support emulateUserGesture parameter in Runtime.callFunctionOn
https://bugs.webkit.org/show_bug.cgi?id=200262

Reviewed by Devin Rousso.

Source/JavaScriptCore:

inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::callFunctionOn):

inspector/agents/InspectorRuntimeAgent.h:
inspector/protocol/Runtime.json:

Source/WebCore:

Support emulateUserGesture in Runtime.callFunctionOn

Tests: inspector/runtime/callFunctionOn-emulateUserGesture-userIsInteracting.html

inspector/runtime/callFunctionOn-emulateUserGesture.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
inspector/agents/page/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::evaluateOnCallFrame):

inspector/agents/page/PageRuntimeAgent.cpp:

(WebCore::asBool):
(WebCore::PageRuntimeAgent::evaluate):
(WebCore::PageRuntimeAgent::callFunctionOn):

inspector/agents/page/PageRuntimeAgent.h:
inspector/agents/page/UserGestureEmulationScope.cpp: Added.

(WebCore::UserGestureEmulationScope::UserGestureEmulationScope): Extracted logic
of overriding user gesture into the scope object to share it between evaluate and
callFunctionOn as well as PageDebuggerAgent::evaluateOnCallFrame.
(WebCore::UserGestureEmulationScope::~UserGestureEmulationScope):

inspector/agents/page/UserGestureEmulationScope.h: Added.

LayoutTests:

Supported emulateUserGesture in Runtime.callFunctionOn protocol command.

TestExpectations:
inspector/runtime/callFunctionOn-emulateUserGesture-expected.txt: Added.
inspector/runtime/callFunctionOn-emulateUserGesture-userIsInteracting-expected.txt: Added.
inspector/runtime/callFunctionOn-emulateUserGesture-userIsInteracting.html: Added.
inspector/runtime/callFunctionOn-emulateUserGesture.html: Added.
platform/wk2/TestExpectations:

Only enable the new test on WK2, as the user interaction state is only supported by WK2.

6:03 PM Changeset in webkit [251619] by Megan Gardner

2 edits in trunk/LayoutTests

Fix autoscroll test specifically for iPad
https://bugs.webkit.org/show_bug.cgi?id=203392
<rdar://problem/51712479>

Reviewed by Wenson Hsieh.

On iPad, we only have one gesture that will set off the magnified caret gesture.
If we touch in the same point as where we touched to focus the element, in the
test environment, nothing resets the positionInformation, which then erroneously
thinks that there is no focused element, which then blocks the caret gesture from
starting. The easiest fix for this is to not have the point to focus the element
be the same point that we use to start the caret gesture.

fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html:

5:53 PM Changeset in webkit [251618] by sihui_liu@apple.com

3 edits in trunk/LayoutTests

REGRESSION (r251261?): Flaky Test: inspector/runtime/getProperties.html
https://bugs.webkit.org/show_bug.cgi?id=203271
<rdar://problem/56557216>

Reviewed by Devin Rousso.

r251261 was reverted and the test has become not so flaky, but the previous flakiness showed us a potential bug
in the test: it is possible that the console message for unhandled rejected promise gets dispatched after
dumping the results. To make the test more robust, stop showing that message in console.

inspector/runtime/getProperties-expected.txt:
inspector/runtime/getProperties.html:

5:46 PM Changeset in webkit [251617] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Remove redundant LineLayout::LineInput c'tor
https://bugs.webkit.org/show_bug.cgi?id=203425
<rdar://problem/56624666>

Reviewed by Antti Koivisto.

Move the SkipAligment paramenter to the LineLayout from LineLayout::LineInput, because it's the property of the layout and not an input to the actual line.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):

layout/inlineformatting/InlineLineLayout.cpp:

(WebCore::Layout::LineLayout::LineInput::LineInput):
(WebCore::Layout::LineLayout::LineLayout):

layout/inlineformatting/InlineLineLayout.h:

5:37 PM Changeset in webkit [251616] by ddkilzer@apple.com

4 edits in trunk/Source/WebKit

Unused arguments in MESSAGE_CHECK_CONTEXTID() macros
<https://webkit.org/b/203389>
<rdar://problem/55935374>

Reviewed by Alex Christensen.

UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(#define MESSAGE_CHECK_CONTEXTID):

Rename macro argument from contextID to identifier and change contextIdto identifier in the body of the macro so that the argument is always used.

(WebKit::PlaybackSessionManagerProxy::setUpPlaybackControlsManagerWithID):
(WebKit::PlaybackSessionManagerProxy::currentTimeChanged):
(WebKit::PlaybackSessionManagerProxy::bufferedTimeChanged):
(WebKit::PlaybackSessionManagerProxy::seekableRangesVectorChanged):
(WebKit::PlaybackSessionManagerProxy::canPlayFastReverseChanged):
(WebKit::PlaybackSessionManagerProxy::audioMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionManagerProxy::legibleMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionManagerProxy::audioMediaSelectionIndexChanged):
(WebKit::PlaybackSessionManagerProxy::legibleMediaSelectionIndexChanged):
(WebKit::PlaybackSessionManagerProxy::externalPlaybackPropertiesChanged):
(WebKit::PlaybackSessionManagerProxy::wirelessVideoPlaybackDisabledChanged):
(WebKit::PlaybackSessionManagerProxy::mutedChanged):
(WebKit::PlaybackSessionManagerProxy::volumeChanged):
(WebKit::PlaybackSessionManagerProxy::durationChanged):
(WebKit::PlaybackSessionManagerProxy::playbackStartedTimeChanged):
(WebKit::PlaybackSessionManagerProxy::rateChanged):
(WebKit::PlaybackSessionManagerProxy::pictureInPictureSupportedChanged):
(WebKit::PlaybackSessionManagerProxy::pictureInPictureActiveChanged):
(WebKit::PlaybackSessionManagerProxy::handleControlledElementIDResponse const):

Change contextID to contextId to match local variable name now that MESSAGE_CHECK_CONTEXTID() doesn't paper over this typo for us.

UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(#define MESSAGE_CHECK_CONTEXTID):

Rename macro argument from contextID to identifier and change contextIdto identifier in the body of the macro so that the argument is always used.

UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(#define MESSAGE_CHECK_CONTEXTID):

Rename macro argument and variable in the body of the macro from id to identifier for consistency.

5:21 PM Changeset in webkit [251615] by pvollan@apple.com

6 edits in trunk/LayoutTests

REGRESSION: fast/css/paint-order.html and fast/css/paint-order-shadow.html are failing
https://bugs.webkit.org/show_bug.cgi?id=203313
<rdar://problem/52557916>

Reviewed by Alexey Proskuryakov.

Catalina introduced a regression, causing these tests to fail. This was not a regression related to the feature these
tests are testing, but a regression related to the rendering position and size of a specific glyph. Given this, the
tests are changed to take this into consideration, making them pass both on Catalina and previous versions of the OS.

fast/css/paint-order-expected.html:
fast/css/paint-order-shadow-expected.html:
fast/css/paint-order-shadow.html:
fast/css/paint-order.html:
platform/mac/TestExpectations:

5:16 PM Changeset in webkit [251614] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

macCatalyst: Build failures in projects that have both AppKit and WAK headers
https://bugs.webkit.org/show_bug.cgi?id=203429
<rdar://problem/56598370>

Reviewed by Sam Weinig.

platform/ios/wak/WAKAppKitStubs.h:

Slightly abuse the preprocessor to avoid errors due to redefining AppKit symbols.

5:00 PM Changeset in webkit [251613] by Jonathan Bedard

9 edits in trunk/Tools

Python 3: Add support in webkitpy.common.checkout
https://bugs.webkit.org/show_bug.cgi?id=201956

Reviewed by Dewei Zhu.

Scripts/test-webkitpy-python3: Add webkitpy.common.checkout.
Scripts/webkitpy/common/checkout/changelog.py: Import Python 3 compatible unicdoe.
Scripts/webkitpy/common/checkout/changelog_unittest.py: Import Python 3 compatible StringIO.
Scripts/webkitpy/common/checkout/checkout.py: Use Python 3 compatible reduce.

(Checkout._modified_files_matching_predicate): Convert iterators into lists before returning.
(Checkout.suggested_reviewers): Ditto.

Scripts/webkitpy/common/checkout/checkout_mock.py: Use full import paths.
Scripts/webkitpy/common/checkout/checkout_unittest.py: Use full import paths, convert

iterators into lists.

Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Use full import paths, use Python 3

compatible StringIO.

Scripts/webkitpy/common/config/committers.py:

(Contributor.hash): Committers need to be hashable to be inserted into a set.

5:00 PM Changeset in webkit [251612] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[iOS] Fix sandbox violations seen while running layout tests
https://bugs.webkit.org/show_bug.cgi?id=203419

Reviewed by Brent Fulgham.

Deny mach lookup to 'com.apple.logd' and 'com.apple.logd.events' and suppress logs, since these are
believed to be unneeded in the WebContent process. Allow sysctl write to 'vm.footprint_suspend'.
Deny mach lookup to 'com.apple.system.notification_center' and suppress logs, since allowing this
is not believed to be needed in the WebContent process.

No new tests, covered by existing tests.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

4:22 PM Changeset in webkit [251611] by Antti Koivisto

10 edits in trunk/Source/WebCore

Move more cascade related code from StyleResolver to PropertyCascade
https://bugs.webkit.org/show_bug.cgi?id=203409

Reviewed by Zalan Bujtas.

Move a bunch of StyleResolver member functions to PropertyCascade.
Make ApplyCascadedPropertyState part of the PropertyCascade internal state.
Pass around a reference to the PropertyCascade itself instead of the state object The state contained PropertyCascade member already so this is equivalent but simpler.

css/CSSVariableReferenceValue.cpp:

(WebCore::resolveVariableFallback):
(WebCore::resolveVariableReference):
(WebCore::resolveTokenRange):
(WebCore::CSSVariableReferenceValue::resolveVariableReferences const):

css/CSSVariableReferenceValue.h:
css/ElementRuleCollector.h:
css/StyleResolver.cpp:

These become PropertyCascade members.

css/StyleResolver.h:

(WebCore::StyleResolver::State::authorRollback const): Deleted.
(WebCore::StyleResolver::State::userRollback const): Deleted.
(WebCore::StyleResolver::State::setAuthorRollback): Deleted.
(WebCore::StyleResolver::State::setUserRollback): Deleted.

Rollbacks are now owned by PropertyCascade.

css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseValueWithVariableReferences):

css/parser/CSSParser.h:
style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::PropertyCascade):
(WebCore::Style::PropertyCascade::set):
(WebCore::Style::PropertyCascade::addNormalMatches):
(WebCore::Style::PropertyCascade::addImportantMatches):
(WebCore::Style::PropertyCascade::applyDeferredProperties):
(WebCore::Style::PropertyCascade::applyProperties):
(WebCore::Style::PropertyCascade::applyPropertiesImpl):
(WebCore::Style::PropertyCascade::applyCustomProperties):
(WebCore::Style::PropertyCascade::applyCustomProperty):
(WebCore::Style::PropertyCascade::propertyCascadeForRollback):
(WebCore::Style::PropertyCascade::Property::apply):

style/PropertyCascade.h:

(WebCore::Style::PropertyCascade::styleResolver):
(WebCore::Style::PropertyCascade::hasAppliedProperty const):
(WebCore::Style::PropertyCascade::customProperties): Deleted.

4:16 PM Changeset in webkit [251610] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Add support for no-wrap
https://bugs.webkit.org/show_bug.cgi?id=203424
<rdar://problem/56624136>

Reviewed by Antti Koivisto.

Consult the white-space style property about line wrapping when the content overflows and can't be split.

layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::isContentWrappingAllowed):
(WebCore::Layout::LineBreaker::breakingContextForInlineContent):
(WebCore::Layout::LineBreaker::wordBreakingBehavior const):

layout/inlineformatting/InlineLineBreaker.h:

4:12 PM Changeset in webkit [251609] by Truitt Savell

2 edits in trunk/LayoutTests

Adding expectations for editing/pasteboard/smart-paste-paragraph-003.html
https://bugs.webkit.org/show_bug.cgi?id=203264

Unreviewed test gardening

platform/ios-wk2/TestExpectations:

4:00 PM Changeset in webkit [251608] by Jonathan Bedard

5 edits in trunk/Tools

Python 3: Add support in webkitpy.xcode
https://bugs.webkit.org/show_bug.cgi?id=203417

Reviewed by Dewei Zhu.

Scripts/test-webkitpy-python3: Add webkitpy.xcode.
Scripts/webkitpy/common/system/filesystem_mock.py:

(ReadableBinaryFileObject.seek): Add seek function to mirror actual binary file
behavior and support plistlib.

Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDeviceManager._disambiguate_device_type): Use values instead of itervalues.
(SimulatedDeviceManager._get_device_identifier_for_type): Use items instead of iteritems.
(SimulatedDeviceManager.device_count_for_type): Use values instead of itervalues.

Scripts/webkitpy/xcode/simulated_device_unittest.py:

(SimulatedDeviceTest.mock_host_for_simctl): Use items instead of iteritems.
(change_state_to): Explicitly use bytes to edit a binary file.

3:41 PM Changeset in webkit [251607] by Dewei Zhu

4 edits in trunk/Websites/perf.webkit.org

Add SSL support for peformance dashboard database connection.
https://bugs.webkit.org/show_bug.cgi?id=203426

Reviewed by Ryosuke Niwa.

Performance dashboard should allow connecting Postgres database with SSL.

public/include/db.php: Add SSL configuration to connection string if specified.
tools/js/database.js: Add SSL configuration to connection string if specified.

(Database.prototype._prepareSSLConfig):
(Database.prototype.connect):

unit-tests/checkconfig.js: Added unit tests for optional ssl fields.

3:37 PM Changeset in webkit [251606] by yurys@chromium.org

2 edits in trunk/LayoutTests

inspector/heap/getRemoteObject.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=156077
<rdar://problem/25469998>

Unreviewed test gardening. Skip the test on GTK in addition to Mac WK2 as it's
now failing and crashing.

platform/gtk/TestExpectations:

3:17 PM Changeset in webkit [251605] by rniwa@webkit.org

11 edits
4 deletes in trunk

Unreviewed, rolling out r251322.
https://bugs.webkit.org/show_bug.cgi?id=203430

Causing more test failures after the rollout of resize event
patch (Requested by rniwa on #webkit).

Reverted changeset:

"Integrate media query evaluation into HTML5 event loop"
https://bugs.webkit.org/show_bug.cgi?id=203134
https://trac.webkit.org/changeset/251322

Patch by Commit Queue <commit-queue@webkit.org> on 2019-10-25

3:07 PM Changeset in webkit [251604] by aakash_jain@apple.com

2 edits in trunk/Tools

[EWS] Status page should show compiler ERRORS
https://bugs.webkit.org/show_bug.cgi?id=203418

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/steps.py:

(BuildLogLineObserver): Class for Analyzing build logs and extracting error logs.
(CompileWebKit.start): Initialize the log observer.
(CompileWebKit):
(CompileWebKit.errorReceived): Add the error to the errors log.

2:44 PM Changeset in webkit [251603] by youenn@apple.com

4 edits in trunk/Source/WebCore

Introduce AudioTrackPrivateMediaStreamCocoa::clear()
https://bugs.webkit.org/show_bug.cgi?id=203369
<rdar://problem/49017262>

Reviewed by Jer Noble.

Introduce the clear method to make sure the AudioTrackPrivteMediaStreamCocoa is in a clean state.
This will help further simplifications.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):

platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:

(WebCore::AudioTrackPrivateMediaStreamCocoa::~AudioTrackPrivateMediaStreamCocoa):
(WebCore::AudioTrackPrivateMediaStreamCocoa::clear):

platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.h:

2:28 PM Changeset in webkit [251602] by Matt Lewis

32 edits
2 deletes in trunk

Rolling out r251579,r251162,r251512,r251500, and r251498 for build failures
and test failures

Unreviewed rollout.

Source/WebCore:

Modules/webauthn/AuthenticatorCoordinator.cpp:
Modules/webauthn/WebAuthenticationConstants.h:
testing/MockWebAuthenticationConfiguration.h:

(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::decode):

testing/MockWebAuthenticationConfiguration.idl:

Source/WebKit:

Platform/spi/Cocoa/NearFieldSPI.h:
UIProcess/API/APIWebAuthenticationPanel.cpp:

(API::WebAuthenticationPanel::create):
(API::WebAuthenticationPanel::WebAuthenticationPanel):

UIProcess/API/APIWebAuthenticationPanel.h:
UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(-[_WKWebAuthenticationPanel relyingPartyID]):
(wkWebAuthenticationTransport): Deleted.
(-[_WKWebAuthenticationPanel transports]): Deleted.
(wkWebAuthenticationType): Deleted.
(-[_WKWebAuthenticationPanel type]): Deleted.

UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::WebCore::collectTransports):
(WebKit::AuthenticatorManager::handleRequest):
(WebKit::AuthenticatorManager::respondReceived):
(WebKit::AuthenticatorManager::respondReceivedInternal):
(WebKit::AuthenticatorManager::startDiscovery):
(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::runPanel):
(WebKit::AuthenticatorManager::startRequest):
(WebKit::AuthenticatorManager::invokePendingCompletionHandler):
(WebKit::WebCore::getClientDataType): Deleted.
(WebKit::AuthenticatorManager::serviceStatusUpdated): Deleted.
(WebKit::AuthenticatorManager::filterTransports const): Deleted.
(WebKit::AuthenticatorManager::getTransports const): Deleted.
(WebKit::AuthenticatorManager::restartDiscovery): Deleted.

UIProcess/WebAuthentication/AuthenticatorManager.h:

(WebKit::AuthenticatorManager::respondReceivedInternal): Deleted.

UIProcess/WebAuthentication/AuthenticatorTransportService.cpp:

(WebKit::AuthenticatorTransportService::startDiscovery):
(WebKit::AuthenticatorTransportService::restartDiscovery): Deleted.

UIProcess/WebAuthentication/AuthenticatorTransportService.h:

(WebKit::AuthenticatorTransportService::restartDiscoveryInternal): Deleted.

UIProcess/WebAuthentication/Cocoa/NfcConnection.h:
UIProcess/WebAuthentication/Cocoa/NfcConnection.mm:

(WebKit::NfcConnection::NfcConnection):
(WebKit::NfcConnection::~NfcConnection):
(WebKit::NfcConnection::didDetectTags const):
(WebKit::NfcConnection::create): Deleted.
(WebKit::NfcConnection::stop const): Deleted.
(WebKit::NfcConnection::didDetectTags): Deleted.
(WebKit::NfcConnection::restartPolling): Deleted.
(WebKit::NfcConnection::startPolling): Deleted.

UIProcess/WebAuthentication/Cocoa/NfcService.h:
UIProcess/WebAuthentication/Cocoa/NfcService.mm:

(WebKit::NfcService::NfcService):
(WebKit::NfcService::didConnectTag):
(WebKit::NfcService::setDriver):
(WebKit::NfcService::platformStartDiscovery):
(WebKit::NfcService::isAvailable): Deleted.
(WebKit::NfcService::didDetectMultipleTags const): Deleted.
(WebKit::NfcService::setConnection): Deleted.
(WebKit::NfcService::restartDiscoveryInternal): Deleted.

UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:

(WebKit::MockAuthenticatorManager::filterTransports const): Deleted.

UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.h:
UIProcess/WebAuthentication/Mock/MockNfcService.h:
UIProcess/WebAuthentication/Mock/MockNfcService.mm:

(-[WKMockNFTag initWithNFTag:]):
(-[WKMockNFTag dealloc]):
(-[WKMockNFTag initWithType:]):
(WebKit::MockNfcService::platformStartDiscovery):
(WebKit::MockNfcService::detectTags const):
(-[WKMockNFTag tagID]): Deleted.
(-[WKMockNFTag initWithType:tagID:]): Deleted.
(WebKit::MockNfcService::receiveStopPolling): Deleted.
(WebKit::MockNfcService::receiveStartPolling): Deleted.

UIProcess/WebAuthentication/fido/CtapNfcDriver.cpp:

(WebKit::CtapNfcDriver::CtapNfcDriver):

UIProcess/WebAuthentication/fido/CtapNfcDriver.h:
UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
(-[TestWebAuthenticationPanelUIDelegate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
(TestWebKitAPI::TEST):
(-[TestWebAuthenticationPanelUIDelegate panel]): Deleted.

TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc-multiple-tags.html: Removed.
TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid.html: Removed.

LayoutTests:

http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt:
http/wpt/webauthn/public-key-credential-create-success-nfc.https.html:

2:24 PM Changeset in webkit [251601] by Wenson Hsieh

6 edits in trunk

[iOS 13] fast/forms/ios/accessory-bar-navigation.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=203294
<rdar://problem/54520848>

Reviewed by Tim Horton.

Source/WebKit:

Add an SPI declaration (as well as an internal-SKD-only header import) for UIKeyboardPreferencesController.
See Tools/ChangeLog for more details.

Platform/spi/ios/UIKitSPI.h:

Tools:

This layout test consistently fails when it is the first test to involve bringing up the keyboard that is run in
a newly created iOS simulator. This is because a software keyboard is presented when focusing the input fields
in the test, and the test expectation (which depends on the visual viewport) requires a hardware keyboard.

WebKitTestRunner already simulates the hardware keyboard being attached using the call to GraphicsServices SPI
in TestController::platformResetStateToConsistentValues. However, this was effectively a no-op in the case where
the simulated device has never (in its lifetime, even through reboots) brought up an input view. This is because
-[UIKeyboardImpl hardwareKeyboardAvailabilityChanged] is never called, due to UIInputResponderController never
having an active instance with an input view set. As a result, the automaticMinimizationEnabled property of
UIKeyboardImpl is never set to its correct initial value (which depends on GSEventIsHardwareKeyboardAttached()).

This leads to UIKeyboardImpl not automatically minimizing itself even though the hardware keyboard is attached
(but only until the next time the keyboard is shown, after a hardware keyboard availability change notification
has been sent, which occurs between every layout test).

To work around this source of flakiness, we ensure that the keyboard preference for enabling automatic
minimization has been set to @YES by the time we attempt to simulate connecting the hardware keyboard by calling
GSEventIsHardwareKeyboardAttached. Note that the extra step of writing the value to com.apple.Preferences is
necessary because logic in TextInput.framework exists that periodically wipes out any cached values for keyboard
preferences on UIInputResponderController, and then attempts to regenerate them by reading defaults in
com.apple.Preferences. However, the same logic also fails to actually update com.apple.Preferences before
reading from it, which results in a software keyboard *very* rarely appearing again when running layout tests
that don't expect to observe a software keyboard.

WebKitTestRunner/ios/TestControllerIOS.mm:

LayoutTests:

Upstream an iOS 13 layout test result into open source. Note that fast/forms/ios is not currently run in open
automation at all, so this expectation was unused anyways.

fast/forms/ios/accessory-bar-navigation-expected.txt:

1:41 PM Changeset in webkit [251600] by rniwa@webkit.org

19 edits
4 adds in trunk

Add exclusion rules to text manipulation SPI
https://bugs.webkit.org/show_bug.cgi?id=203398
<rdar://problem/56567256>

Reviewed by Wenson Hsieh.

Source/WebCore:

This patch adds the ability to define a ordered set of rules to exclude or include content an element of
a certain name or one with a certain attribute value.

Also made completeManipulation return more detailed errors for debugging purposes.

Tests: TextManipulation.StartTextManipulationApplySingleExcluionRuleForElement

TextManipulation.StartTextManipulationApplyInclusionExclusionRulesForAttributes
TextManipulation.CompleteTextManipulationFailWhenExclusionIsViolated

editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::ExclusionRule::match const): Added.
(WebCore::ExclusionRuleMatcher): Added. This class is responsible for figuring out whether a given node
is excluded or included in the text manipulation.
(WebCore::ExclusionRuleMatcher::ExclusionRuleMatcher): Added.
(WebCore::ExclusionRuleMatcher::isExcluded): Added.
(WebCore::ExclusionRuleMatcher::typeForElement): Added.
(WebCore::TextManipulationController::startObservingParagraphs): Added a Vector of ExclusionRule as
an argument.
(WebCore::TextManipulationController::completeManipulation):
(WebCore::TextManipulationController::replace):

editing/TextManipulationController.h:

(WebCore::TextManipulationController::ExclusionRule): Added.
(WebCore::TextManipulationController::ManipulationResult): Added.
(WebCore::TextManipulationController::ManipulationToken::encode const): Include isExcluded boolean.
(WebCore::TextManipulationController::ManipulationToken::decode): Ditto.
(WebCore::TextManipulationController::ExclusionRule::encode const): Added.
(WebCore::TextManipulationController::ExclusionRule::decode): Added.
(WebCore::TextManipulationController::ExclusionRule::ElementRule::encode const): Added.
(WebCore::TextManipulationController::ExclusionRule::ElementRule::decode): Added.
(WebCore::TextManipulationController::ExclusionRule::AttributeRule::encode const): Added.
(WebCore::TextManipulationController::ExclusionRule::AttributeRule::decode): Added.

Source/WebKit:

Added SPI to specify the configuration for the text manipulation (see r251574), in particular, the set of rules
governing which content should be excluded or included in text manipulations.

Test: TextManipulation.StartTextManipulationExitEarlyWithoutDelegate

SourcesCocoa.txt:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _startTextManipulationsWithConfiguration:completion:]): Takes _WKTextManipulationConfiguration
as an argument. Also fixed a bug that we weren't calling the completion handler when the delegate was not set.
(-[WKWebView _completeTextManipulation:completion:]):
(-[WKWebView _startTextManipulationsWithCompletionHandler:]): Deleted.

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/_WKTextManipulationConfiguration.h: Added.
UIProcess/API/Cocoa/_WKTextManipulationConfiguration.mm: Added.
UIProcess/API/Cocoa/_WKTextManipulationExclusionRule.h: Added.
UIProcess/API/Cocoa/_WKTextManipulationExclusionRule.mm: Added.

(-[_WKTextManipulationExclusionRule initExclusion:forElement:]): Added.
(-[_WKTextManipulationExclusionRule initExclusion:forAttribute:value:]): Added.
(-[_WKTextManipulationExclusionRule elementName]): Added.
(-[_WKTextManipulationExclusionRule attributeName]): Added.
(-[_WKTextManipulationExclusionRule attributeValue]): Added.

UIProcess/API/Cocoa/_WKTextManipulationToken.h: Added excluded boolean property.
UIProcess/API/Cocoa/_WKTextManipulationToken.mm: Removed the superflous import of RetainPtr.h
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startTextManipulations):
(WebKit::WebPageProxy::completeTextManipulation):

UIProcess/WebPageProxy.h:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::startTextManipulations):
(WebKit::WebPage::completeTextManipulation):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

Added tests for including & excluding content based on element names and attribute values.

Also added a test to make sure _startTextManipulationsWithConfiguration calls the completion handler
even when the _WKTextManipulationDelegate isn't set.

TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

12:25 PM Changeset in webkit [251599] by Chris Dumez

17 edits in trunk/Source/WebKit

[iOS][WK2] Use sendWithAsyncReply() to simplify the prepareToSuspend logic
https://bugs.webkit.org/show_bug.cgi?id=203422

Reviewed by Alex Christensen.

Use sendWithAsyncReply() to simplify the prepareToSuspend logic and make it easier to
understand.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processWillSuspendImminentlyForTestingSync):
(WebKit::NetworkProcess::prepareToSuspend):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _processWillSuspendImminentlyForTesting]):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::sendPrepareToSuspend):
(WebKit::NetworkProcessProxy::processReadyToSuspend): Deleted.

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::processReadyToSuspend):
(WebKit::ProcessThrottler::sendPrepareToSuspendIPC):

UIProcess/ProcessThrottler.h:
UIProcess/ProcessThrottlerClient.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendPrepareToSuspend):
(WebKit::WebProcessProxy::processReadyToSuspend): Deleted.

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::prepareToSuspend):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

12:04 PM Changeset in webkit [251598] by youenn@apple.com

7 edits in trunk

WebProcess should unregister its interest for a SWServerRegistration when all its corresponding ServiceWorkerRegistrations are destroyed
https://bugs.webkit.org/show_bug.cgi?id=203410

Reviewed by Chris Dumez.

Source/WebKit:

A SWServerRegistration is keeping a list of web processes that should be notified of change to its state.
Previously, WebProcesses were registering their interest to a SWServerRegistration on construction of a ServiceWorkerRegistration,
and unregistering their interest on destruction of a ServiceWorkerRegistration.

This does not work in case two ServiceWorkerRegistrations are created for the same SWServerRegistration in the same WebProcess.
In that case, when one of the two ServiceWorkerRegistration is destroyed, the WebProcess will no longer be notified of changes to the SWServerRegistration,
thus breaking the second ServiceWorkerRegistration behavior.

We introduce a map at WebProcess level to keep track of the number of ServiceWorkerRegistration created for a given SWServerRegistration.

Covered by re-enabled tests.

WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::addServiceWorkerRegistrationInServer):
(WebKit::WebSWClientConnection::removeServiceWorkerRegistrationInServer):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addServiceWorkerRegistration):
(WebKit::WebProcess::removeServiceWorkerRegistration):

WebProcess/WebProcess.h:

LayoutTests:

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

11:22 AM Changeset in webkit [251597] by Truitt Savell

4 edits in trunk/LayoutTests

Followup test gardening after r251591
https://bugs.webkit.org/show_bug.cgi?id=203291

Unreviewed test gardening.

platform/ios/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac/TestExpectations:

10:47 AM Changeset in webkit [251596] by achristensen@apple.com

1 edit
4 adds in trunk/LayoutTests

Rebase WK1 test after r251582
https://bugs.webkit.org/show_bug.cgi?id=203383

platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/scripting-1: Added.
platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element: Added.
platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module: Added.
platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt: Added.

10:16 AM Changeset in webkit [251595] by Simon Fraser

2 edits in trunk/Source/WebCore

Move code around in CSSCalculationValue.cpp
https://bugs.webkit.org/show_bug.cgi?id=203397

Reviewed by Zalan Bujtas.

Large amounts of code were in inline (but virtual) functions in CSSCalcPrimitiveValue, CSSCalcOperation
and CSSCalcExpressionNodeParser, making it hard to navigate around this file. Move code into
out-of-line functions. No behavior changes.

css/CSSCalculationValue.cpp:

(WebCore::CSSCalcPrimitiveValue::createCalcExpression const):
(WebCore::CSSCalcPrimitiveValue::doubleValue const):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx const):
(WebCore::CSSCalcPrimitiveValue::collectDirectComputationalDependencies const):
(WebCore::CSSCalcPrimitiveValue::collectDirectRootComputationalDependencies const):
(WebCore::CSSCalcPrimitiveValue::equals const):
(WebCore::CSSCalcOperation::create):
(WebCore::CSSCalcOperation::createMinOrMax):
(WebCore::CSSCalcOperation::createSimplified):
(WebCore::CSSCalcOperation::primitiveType const):
(WebCore::CSSCalcOperation::createCalcExpression const):
(WebCore::CSSCalcOperation::doubleValue const):
(WebCore::CSSCalcOperation::computeLengthPx const):
(WebCore::CSSCalcOperation::collectDirectComputationalDependencies const):
(WebCore::CSSCalcOperation::collectDirectRootComputationalDependencies const):
(WebCore::CSSCalcOperation::buildCssText):
(WebCore::CSSCalcOperation::customCSSText const):
(WebCore::CSSCalcOperation::equals const):
(WebCore::CSSCalcOperation::evaluateOperator):
(WebCore::CSSCalcExpressionNodeParser::parseCalc):
(WebCore::CSSCalcExpressionNodeParser::parseValue):
(WebCore::checkDepthAndIndex):
(WebCore::CSSCalcExpressionNodeParser::parseValueTerm):
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
(WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):
(WebCore::CSSCalcExpressionNodeParser::parseMinMaxExpression):
(WebCore::CSSCalcExpressionNodeParser::parseValueExpression):
(WebCore::CSSCalcValue::customCSSText const):
(WebCore::CSSCalcValue::equals const):
(WebCore::CSSCalcValue::clampToPermittedRange const):
(WebCore::CSSCalcValue::doubleValue const):
(WebCore::CSSCalcValue::computeLengthPx const):

9:20 AM Changeset in webkit [251594] by youenn@apple.com

21 edits in trunk

mp4 video element broken with service worker
https://bugs.webkit.org/show_bug.cgi?id=184447
<rdar://problem/39313155>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/fetch/range/sw.https.window-expected.txt:

Source/WebCore:

Update fetch header handling to properly handle range header as per https://fetch.spec.whatwg.org/#headers-class.
In particular, remove thre range header from a Request/Headers object whenever modified.
Add checks so that range responses are not reused for non range requests.
For that purpose, add a range-requested flag to ResourceResponse.
Ass helper routines implementing part of fetch spec.
Covered by enabled test.

Modules/fetch/FetchHeaders.cpp:

(WebCore::removePrivilegedNoCORSRequestHeaders):
(WebCore::appendToHeaderMap):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::set):

Modules/fetch/FetchHeaders.h:

(WebCore::FetchHeaders::setInternalHeaders):

Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::initializeWith):

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

platform/network/HTTPParsers.cpp:

(WebCore::isNoCORSSafelistedRequestHeaderName):
(WebCore::isPriviledgedNoCORSRequestHeaderName):

platform/network/HTTPParsers.h:
platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):

platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::isRangeRequested const):
(WebCore::ResourceResponseBase::setAsRangeRequested):
(WebCore::ResourceResponseBase::encode const):
(WebCore::ResourceResponseBase::decode):

Source/WebKit:

Make a response as range-requested as per https://fetch.spec.whatwg.org/#http-network-or-cache-fetch step 15.

NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::checkRedirection):
(WebKit::NetworkLoadChecker::validateResponse):

NetworkProcess/NetworkLoadChecker.h:
NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

LayoutTests:

Enable test for WK2, not WK1.

TestExpectations:
platform/mac-wk1/TestExpectations:

9:16 AM Changeset in webkit [251593] by Jonathan Bedard

2 edits in trunk/Tools

results.webkit.org: Report the correct flavor for leaks
https://bugs.webkit.org/show_bug.cgi?id=203413

Reviewed by Aakash Jain.

BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunWebKit1LeakTests.start):

8:44 AM Changeset in webkit [251592] by Chris Dumez

11 edits in trunk

Unreviewed, rolling out r251586.

New test is flaky

Reverted changeset:

"DatabaseContext should not prevent entering the back/forward
cache"
https://bugs.webkit.org/show_bug.cgi?id=203103
https://trac.webkit.org/changeset/251586

8:29 AM Changeset in webkit [251591] by graouts@webkit.org

33 edits
11 copies
30 moves
312 adds
43 deletes in trunk/LayoutTests

[Web Animations] Update WPT tests related to Web Animations and remove imported Mozilla tests
https://bugs.webkit.org/show_bug.cgi?id=203291
<rdar://problem/56577481>

Reviewed by Youenn Fablet.

LayoutTests/imported/mozilla:

css-animations/test_animation-cancel-expected.txt: Removed.
css-animations/test_animation-cancel.html: Removed.
css-animations/test_animation-currenttime-expected.txt: Removed.
css-animations/test_animation-currenttime.html: Removed.
css-animations/test_animation-finish-expected.txt: Removed.
css-animations/test_animation-finish.html: Removed.
css-animations/test_animation-finished-expected.txt: Removed.
css-animations/test_animation-finished.html: Removed.
css-animations/test_animation-id.html: Removed.
css-animations/test_animation-pausing.html: Removed.
css-animations/test_animation-playstate.html: Removed.
css-animations/test_animation-ready.html: Removed.
css-animations/test_animation-reverse-expected.txt: Removed.
css-animations/test_animation-reverse.html: Removed.
css-animations/test_animation-starttime-expected.txt: Removed.
css-animations/test_animation-starttime.html: Removed.
css-animations/test_animations-dynamic-changes.html: Removed.
css-animations/test_event-dispatch.html: Removed.
css-animations/test_event-order-expected.txt: Removed.
css-animations/test_event-order.html: Removed.
css-animations/test_setting-effect.html: Removed.
css-transitions/test_animation-cancel.html: Removed.
css-transitions/test_animation-currenttime-expected.txt: Removed.
css-transitions/test_animation-currenttime.html: Removed.
css-transitions/test_animation-finished-expected.txt: Removed.
css-transitions/test_animation-finished.html: Removed.
css-transitions/test_animation-pausing-expected.txt: Removed.
css-transitions/test_animation-pausing.html: Removed.
css-transitions/test_animation-ready-expected.txt: Removed.
css-transitions/test_animation-ready.html: Removed.
css-transitions/test_animation-starttime-expected.txt: Removed.
css-transitions/test_animation-starttime.html: Removed.
css-transitions/test_csstransition-transitionproperty.html: Removed.
css-transitions/test_document-get-animations-expected.txt: Removed.
css-transitions/test_document-get-animations.html: Removed.
css-transitions/test_element-get-animations-expected.txt: Removed.
css-transitions/test_element-get-animations.html: Removed.
css-transitions/test_event-dispatch.html: Removed.
css-transitions/test_keyframeeffect-getkeyframes-expected.txt: Removed.
css-transitions/test_keyframeeffect-getkeyframes.html: Removed.
css-transitions/test_setting-effect-expected.txt: Removed.
css-transitions/test_setting-effect.html: Removed.

LayoutTests/imported/w3c:

resources/import-expectations.json:
web-platform-tests/css/css-animations/AnimationEffect-getComputedTiming.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-computed-timing-expected.txt.
web-platform-tests/css/css-animations/AnimationEffect-getComputedTiming.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-computed-timing.html.
web-platform-tests/css/css-animations/CSSAnimation-animationName.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_cssanimation-animationname-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-animationName.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_cssanimation-animationname.html.
web-platform-tests/css/css-animations/CSSAnimation-canceling.tentative-expected.txt: Added.
web-platform-tests/css/css-animations/CSSAnimation-canceling.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-effect.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_setting-effect-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-effect.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-finished.tentative-expected.txt: Added.
web-platform-tests/css/css-animations/CSSAnimation-finished.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-getCurrentTime.tentative-expected.txt: Added.
web-platform-tests/css/css-animations/CSSAnimation-getCurrentTime.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-id.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-id-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-id.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-pausing.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-pausing-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-pausing.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-playState.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-playstate-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-playState.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-ready.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-ready-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-ready.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-startTime.tentative-expected.txt: Added.
web-platform-tests/css/css-animations/CSSAnimation-startTime.tentative.html: Added.
web-platform-tests/css/css-animations/CSSPseudoElement-getAnimations.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_pseudoElement-get-animations-expected.txt.
web-platform-tests/css/css-animations/CSSPseudoElement-getAnimations.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_pseudoElement-get-animations.html.
web-platform-tests/css/css-animations/Document-getAnimations.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_document-get-animations-expected.txt.
web-platform-tests/css/css-animations/Document-getAnimations.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_document-get-animations.html.
web-platform-tests/css/css-animations/Element-getAnimations-dynamic-changes.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animations-dynamic-changes-expected.txt.
web-platform-tests/css/css-animations/Element-getAnimations-dynamic-changes.tentative.html: Added.
web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_element-get-animations-expected.txt.
web-platform-tests/css/css-animations/Element-getAnimations.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_element-get-animations.html.
web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_keyframeeffect-getkeyframes-expected.txt.
web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_keyframeeffect-getkeyframes.html.
web-platform-tests/css/css-animations/KeyframeEffect-target.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_effect-target-expected.txt.
web-platform-tests/css/css-animations/KeyframeEffect-target.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_effect-target.html.
web-platform-tests/css/css-animations/META.yml: Added.
web-platform-tests/css/css-animations/OWNERS: Removed.
web-platform-tests/css/css-animations/animation-opacity-pause-and-set-time-expected.html: Added.
web-platform-tests/css/css-animations/animation-opacity-pause-and-set-time.html: Added.
web-platform-tests/css/css-animations/animation-pseudo-dynamic-001-expected.html: Added.
web-platform-tests/css/css-animations/animation-pseudo-dynamic-001.html: Added.
web-platform-tests/css/css-animations/animation-transform-pause-and-set-time-expected.html: Added.
web-platform-tests/css/css-animations/animation-transform-pause-and-set-time.html: Added.
web-platform-tests/css/css-animations/animationevent-interface-expected.txt:
web-platform-tests/css/css-animations/animationevent-interface.js:

(test):
(test.):

web-platform-tests/css/css-animations/animationevent-marker-pseudoelement-expected.txt: Added.
web-platform-tests/css/css-animations/animationevent-marker-pseudoelement.html: Added.
web-platform-tests/css/css-animations/computed-style-animation-parsing-expected.txt: Added.
web-platform-tests/css/css-animations/computed-style-animation-parsing.html: Added.
web-platform-tests/css/css-animations/event-dispatch.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_event-dispatch-expected.txt.
web-platform-tests/css/css-animations/event-dispatch.tentative.html: Added.
web-platform-tests/css/css-animations/event-order.tentative-expected.txt: Added.
web-platform-tests/css/css-animations/event-order.tentative.html: Added.
web-platform-tests/css/css-animations/historical-expected.txt: Added.
web-platform-tests/css/css-animations/historical.html: Added.
web-platform-tests/css/css-animations/idlharness-expected.txt: Added.
web-platform-tests/css/css-animations/idlharness.html: Added.
web-platform-tests/css/css-animations/inheritance-expected.txt: Added.
web-platform-tests/css/css-animations/inheritance.html: Added.
web-platform-tests/css/css-animations/keyframes-remove-documentElement-crash-expected.txt: Added.
web-platform-tests/css/css-animations/keyframes-remove-documentElement-crash.html: Added.
web-platform-tests/css/css-animations/parsing/animation-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-name-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-name-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-name-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-name-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-name-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-name-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-shorthand-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-shorthand.html: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-valid.html: Added.
web-platform-tests/css/css-animations/parsing/w3c-import.log: Added.
web-platform-tests/css/css-animations/responsive/column-rule-color-001-expected.txt: Added.
web-platform-tests/css/css-animations/responsive/column-rule-color-001.html: Added.
web-platform-tests/css/css-animations/responsive/column-width-001-expected.txt: Added.
web-platform-tests/css/css-animations/responsive/column-width-001.html: Added.
web-platform-tests/css/css-animations/responsive/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/css/css-animations/style-animation-parsing-expected.txt: Added.
web-platform-tests/css/css-animations/style-animation-parsing.html: Added.
web-platform-tests/css/css-animations/support/testcommon.js:
web-platform-tests/css/css-animations/support/w3c-import.log:
web-platform-tests/css/css-animations/w3c-import.log:
web-platform-tests/css/css-transitions/AnimationEffect-getComputedTiming.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_animation-computed-timing-expected.txt.
web-platform-tests/css/css-transitions/AnimationEffect-getComputedTiming.tentative.html: Renamed from LayoutTests/imported/mozilla/css-transitions/test_animation-computed-timing.html.
web-platform-tests/css/css-transitions/CSSPseudoElement-getAnimations.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_pseudoElement-get-animations-expected.txt.
web-platform-tests/css/css-transitions/CSSPseudoElement-getAnimations.tentative.html: Renamed from LayoutTests/imported/mozilla/css-transitions/test_pseudoElement-get-animations.html.
web-platform-tests/css/css-transitions/CSSTransition-canceling.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_animation-cancel-expected.txt.
web-platform-tests/css/css-transitions/CSSTransition-canceling.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-currentTime.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/CSSTransition-currentTime.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-effect.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/CSSTransition-effect.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-finished.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/CSSTransition-finished.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-ready.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/CSSTransition-ready.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-startTime.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/CSSTransition-startTime.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-transitionProperty.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_csstransition-transitionproperty-expected.txt.
web-platform-tests/css/css-transitions/CSSTransition-transitionProperty.tentative.html: Added.
web-platform-tests/css/css-transitions/Document-getAnimations.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/Document-getAnimations.tentative.html: Added.
web-platform-tests/css/css-transitions/Element-getAnimations.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/Element-getAnimations.tentative.html: Added.
web-platform-tests/css/css-transitions/KeyframeEffect-getKeyframes.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/KeyframeEffect-getKeyframes.tentative.html: Added.
web-platform-tests/css/css-transitions/KeyframeEffect-target.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_effect-target-expected.txt.
web-platform-tests/css/css-transitions/KeyframeEffect-target.tentative.html: Renamed from LayoutTests/imported/mozilla/css-transitions/test_effect-target.html.
web-platform-tests/css/css-transitions/META.yml: Added.
web-platform-tests/css/css-transitions/README.md: Added.
web-platform-tests/css/css-transitions/before-load-001-expected.txt: Added.
web-platform-tests/css/css-transitions/before-load-001.html: Added.
web-platform-tests/css/css-transitions/changing-while-transition-001-expected.txt: Added.
web-platform-tests/css/css-transitions/changing-while-transition-001.html: Added.
web-platform-tests/css/css-transitions/changing-while-transition-002-expected.txt: Added.
web-platform-tests/css/css-transitions/changing-while-transition-002.html: Added.
web-platform-tests/css/css-transitions/changing-while-transition-003-expected.txt: Added.
web-platform-tests/css/css-transitions/changing-while-transition-003.html: Added.
web-platform-tests/css/css-transitions/currentcolor-animation-001-expected.txt: Added.
web-platform-tests/css/css-transitions/currentcolor-animation-001.html: Added.
web-platform-tests/css/css-transitions/disconnected-element-001-expected.txt: Added.
web-platform-tests/css/css-transitions/disconnected-element-001.html: Added.
web-platform-tests/css/css-transitions/event-dispatch.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_event-dispatch-expected.txt.
web-platform-tests/css/css-transitions/event-dispatch.tentative.html: Added.
web-platform-tests/css/css-transitions/events-001-expected.txt: Added.
web-platform-tests/css/css-transitions/events-001.html: Added.
web-platform-tests/css/css-transitions/events-002-expected.txt: Added.
web-platform-tests/css/css-transitions/events-002.html: Added.
web-platform-tests/css/css-transitions/events-003-expected.txt: Added.
web-platform-tests/css/css-transitions/events-003.html: Added.
web-platform-tests/css/css-transitions/events-004-expected.txt: Added.
web-platform-tests/css/css-transitions/events-004.html: Added.
web-platform-tests/css/css-transitions/events-005-expected.txt: Added.
web-platform-tests/css/css-transitions/events-005.html: Added.
web-platform-tests/css/css-transitions/events-006-expected.txt: Added.
web-platform-tests/css/css-transitions/events-006.html: Added.
web-platform-tests/css/css-transitions/events-007-expected.txt: Added.
web-platform-tests/css/css-transitions/events-007.html: Added.
web-platform-tests/css/css-transitions/historical-expected.txt: Added.
web-platform-tests/css/css-transitions/historical.html: Added.
web-platform-tests/css/css-transitions/idlharness-expected.txt: Added.
web-platform-tests/css/css-transitions/idlharness.html: Added.
web-platform-tests/css/css-transitions/inherit-height-transition-expected.txt: Added.
web-platform-tests/css/css-transitions/inherit-height-transition.html: Added.
web-platform-tests/css/css-transitions/inheritance-expected.txt: Added.
web-platform-tests/css/css-transitions/inheritance.html: Added.
web-platform-tests/css/css-transitions/no-transition-from-ua-to-blocking-stylesheet-expected.html: Added.
web-platform-tests/css/css-transitions/no-transition-from-ua-to-blocking-stylesheet.html: Added.
web-platform-tests/css/css-transitions/non-rendered-element-001-expected.txt: Added.
web-platform-tests/css/css-transitions/non-rendered-element-001.html: Added.
web-platform-tests/css/css-transitions/non-rendered-element-002-expected.txt: Added.
web-platform-tests/css/css-transitions/non-rendered-element-002.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-computed-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-computed.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-computed-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-computed.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-invalid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-invalid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-valid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-valid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-computed-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-computed.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-invalid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-invalid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-valid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-valid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-invalid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-invalid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-computed-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-computed.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-invalid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-invalid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-valid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-valid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-shorthand-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-shorthand.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-invalid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-invalid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-valid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-valid.html: Added.
web-platform-tests/css/css-transitions/parsing/w3c-import.log: Added.
web-platform-tests/css/css-transitions/properties-value-001-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-001.html: Added.
web-platform-tests/css/css-transitions/properties-value-002-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-002.html: Added.
web-platform-tests/css/css-transitions/properties-value-003-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-003.html: Added.
web-platform-tests/css/css-transitions/properties-value-auto-001-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-auto-001.html: Added.
web-platform-tests/css/css-transitions/properties-value-implicit-001-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-implicit-001.html: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-001-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-001.html: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-002-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-002.html: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-003-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-003.html: Added.
web-platform-tests/css/css-transitions/pseudo-elements-001-expected.txt: Added.
web-platform-tests/css/css-transitions/pseudo-elements-001.html: Added.
web-platform-tests/css/css-transitions/pseudo-elements-002-expected.txt: Added.
web-platform-tests/css/css-transitions/pseudo-elements-002.html: Added.
web-platform-tests/css/css-transitions/starting-of-transitions-001-expected.txt: Added.
web-platform-tests/css/css-transitions/starting-of-transitions-001.html: Added.
web-platform-tests/css/css-transitions/support/1x1-green.png: Added.
web-platform-tests/css/css-transitions/support/1x1-lime.png: Added.
web-platform-tests/css/css-transitions/support/1x1-maroon.png: Added.
web-platform-tests/css/css-transitions/support/1x1-navy.png: Added.
web-platform-tests/css/css-transitions/support/1x1-red.png: Added.
web-platform-tests/css/css-transitions/support/1x1-white.png: Added.
web-platform-tests/css/css-transitions/support/60x60-gg-rr.png: Added.
web-platform-tests/css/css-transitions/support/60x60-green.png: Added.
web-platform-tests/css/css-transitions/support/60x60-red.png: Added.
web-platform-tests/css/css-transitions/support/README: Added.
web-platform-tests/css/css-transitions/support/a-green-transition.css: Added.

(.a):

web-platform-tests/css/css-transitions/support/a-green.css: Added.

(.a):

web-platform-tests/css/css-transitions/support/b-green.css: Added.

(.b):

web-platform-tests/css/css-transitions/support/c-red.css: Added.

(.c):

web-platform-tests/css/css-transitions/support/cat.png: Added.
web-platform-tests/css/css-transitions/support/generalParallelTest.js: Added.

(suite.root.generalParallelTest.setup):
(suite.root.generalParallelTest.data.transition.computedStyle):
(suite.root.generalParallelTest.data.container.computedStyle):
(suite.root.generalParallelTest.data.pseudo.computedStyle):
(suite.root.generalParallelTest._setupDom):
(suite.root.generalParallelTest.):
(suite.root.generalParallelTest._setupEvents):
(suite.root.generalParallelTest.teardown):
(suite.root.generalParallelTest.sliceStart):
(suite.root.generalParallelTest.sliceDone):
(suite.root.generalParallelTest.done):
(suite.root.generalParallelTest.addStyles):
(suite.root.generalParallelTest.getStyle):
(suite.root.generalParallelTest._getStyleFor):
(suite.root.generalParallelTest._addClass):
(suite.root.generalParallelTest._removeClass):
(suite.root.generalParallelTest.startTransition):
(suite.root.generalParallelTest.runLoop):
(suite.root.generalParallelTest.startValueCollection):
(suite.root.generalParallelTest.stopValueCollection):
(suite.root.generalParallelTest.assertExpectedEventsFunc):
(suite.root.generalParallelTest.assertIntermediateValuesFunc):

web-platform-tests/css/css-transitions/support/helper.js: Added.

(root.setStyle):
(serializeStyles):
(root.computedStyle):
(root.reflow):
(root.extend):
(root.domFixture):
(root.assert_times_equal):
(root.assert_time_equals_literal):
(root.assert_end_events_equal):
(root.assert_end_event_batch_equal):
(root.addDiv):
(root.addStyle):
(root.waitForFrame):
(root.waitForAnimationFrames.return.new.Promise):
(root.waitForAnimationFrames):
(root.frameTimeout):

web-platform-tests/css/css-transitions/support/import-green.css: Added.

(.import):

web-platform-tests/css/css-transitions/support/import-red.css: Added.

(.import):

web-platform-tests/css/css-transitions/support/one.gif: Added.
web-platform-tests/css/css-transitions/support/pattern-grg-rgr-grg.png: Added.
web-platform-tests/css/css-transitions/support/pattern-grg-rrg-rgg.png: Added.
web-platform-tests/css/css-transitions/support/pattern-rgr-grg-rgr.png: Added.
web-platform-tests/css/css-transitions/support/pattern-tr.png: Added.
web-platform-tests/css/css-transitions/support/properties.js: Added.

(values.string_appeared_here):
(assemble.):
(assemble):
(root.getPropertyTests):
(root.getMissingPropertyTests):
(root.getUnspecifiedPropertyTests):
(root.getFontSizeRelativePropertyTests):
(root.getAutoPropertyTests):
(root.filterPropertyTests):

web-platform-tests/css/css-transitions/support/ruler-h-50%.png: Added.
web-platform-tests/css/css-transitions/support/ruler-h-50px.png: Added.
web-platform-tests/css/css-transitions/support/ruler-v-100px.png: Added.
web-platform-tests/css/css-transitions/support/ruler-v-50px.png: Added.
web-platform-tests/css/css-transitions/support/runParallelAsyncHarness.js: Added.

(noop):
(runLoop.concludeSlice):
(root.runParallelAsyncHarness):

web-platform-tests/css/css-transitions/support/square-purple.png: Added.
web-platform-tests/css/css-transitions/support/square-teal.png: Added.
web-platform-tests/css/css-transitions/support/square-white.png: Added.
web-platform-tests/css/css-transitions/support/support/README: Added.
web-platform-tests/css/css-transitions/support/support/swatch-green.png: Added.
web-platform-tests/css/css-transitions/support/support/swatch-red.png: Added.
web-platform-tests/css/css-transitions/support/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/css/css-transitions/support/swatch-blue.png: Added.
web-platform-tests/css/css-transitions/support/swatch-green.png: Added.
web-platform-tests/css/css-transitions/support/swatch-lime.png: Added.
web-platform-tests/css/css-transitions/support/swatch-orange.png: Added.
web-platform-tests/css/css-transitions/support/swatch-red.png: Added.
web-platform-tests/css/css-transitions/support/swatch-teal.png: Added.
web-platform-tests/css/css-transitions/support/swatch-white.png: Added.
web-platform-tests/css/css-transitions/support/swatch-yellow.png: Added.
web-platform-tests/css/css-transitions/support/test-bl.png: Added.
web-platform-tests/css/css-transitions/support/test-br.png: Added.
web-platform-tests/css/css-transitions/support/test-inner-half-size.png: Added.
web-platform-tests/css/css-transitions/support/test-outer.png: Added.
web-platform-tests/css/css-transitions/support/test-tl.png: Added.
web-platform-tests/css/css-transitions/support/test-tr.png: Added.
web-platform-tests/css/css-transitions/support/two.gif: Added.
web-platform-tests/css/css-transitions/support/vendorPrefix.js: Added.

(root.addVendorPrefix):
(root.addValueVendorPrefix):
(root.getVendorPrefix):
(root.getValueVendorPrefix):

web-platform-tests/css/css-transitions/support/w3c-import.log: Added.
web-platform-tests/css/css-transitions/transition-001-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-001.html: Added.
web-platform-tests/css/css-transitions/transition-background-position-with-edge-offset-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-background-position-with-edge-offset.html: Added.
web-platform-tests/css/css-transitions/transition-delay-001-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-delay-001.html: Added.
web-platform-tests/css/css-transitions/transition-duration-001-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-duration-001.html: Added.
web-platform-tests/css/css-transitions/transition-property-001-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-property-001.html: Added.
web-platform-tests/css/css-transitions/transition-property-002-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-property-002.html: Added.
web-platform-tests/css/css-transitions/transition-reparented-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-reparented.html: Added.
web-platform-tests/css/css-transitions/transition-test-expected.html: Added.
web-platform-tests/css/css-transitions/transition-test.html: Added.
web-platform-tests/css/css-transitions/transitioncancel-001-expected.txt: Added.
web-platform-tests/css/css-transitions/transitioncancel-001.html: Added.
web-platform-tests/css/css-transitions/transitionevent-interface-expected.txt: Added.
web-platform-tests/css/css-transitions/transitionevent-interface.html: Added.
web-platform-tests/css/css-transitions/w3c-import.log: Added.
web-platform-tests/css/css-transitions/zero-duration-multiple-transition-expected.txt: Added.
web-platform-tests/css/css-transitions/zero-duration-multiple-transition.html: Added.
web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
web-platform-tests/web-animations/animation-model/animation-types/property-types.js:

(const.visibilityType.testAdditionOrAccumulation):
(const.filterListType.testInterpolation):

web-platform-tests/web-animations/animation-model/animation-types/w3c-import.log: Added.
web-platform-tests/web-animations/animation-model/combining-effects/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/animation-model/keyframe-effects/w3c-import.log: Added.
web-platform-tests/web-animations/interfaces/Animatable/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/interfaces/Animation/idlharness.window-expected.txt: Added.
web-platform-tests/web-animations/interfaces/Animation/idlharness.window.html: Added.
web-platform-tests/web-animations/interfaces/Animation/oncancel.html:
web-platform-tests/web-animations/interfaces/Animation/w3c-import.log: Added.
web-platform-tests/web-animations/interfaces/AnimationEffect/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness.window-expected.txt: Added.
web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness.window.html: Added.
web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/interfaces/Document/getAnimations-expected.txt:
web-platform-tests/web-animations/interfaces/Document/getAnimations.html:
web-platform-tests/web-animations/interfaces/Document/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness.window-expected.txt: Added.
web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness.window.html: Added.
web-platform-tests/web-animations/interfaces/DocumentTimeline/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness.window-expected.txt: Added.
web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness.window.html: Added.
web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt:
web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html:
web-platform-tests/web-animations/interfaces/KeyframeEffect/w3c-import.log: Added.
web-platform-tests/web-animations/resources/w3c-import.log: Added.
web-platform-tests/web-animations/timing-model/animation-effects/w3c-import.log: Added.
web-platform-tests/web-animations/timing-model/animations/w3c-import.log: Added.
web-platform-tests/web-animations/timing-model/time-transformations/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/timing-model/timelines/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.

LayoutTests:

TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
platform/ios/TestExpectations:
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
tests-options.json:

8:12 AM Changeset in webkit [251590] by Alan Bujtas

12 edits
1 copy in trunk/Source/WebCore

[LFC][IFC] Add support for preserved new line (pre, pre-wrap, break-spaces, pre-line)
https://bugs.webkit.org/show_bug.cgi?id=203395
<rdar://problem/56606243>

Reviewed by Antti Koivisto.

<pre>Let's wrap the line
when the inline item's type is forced line break.</pre>

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/LayoutContext.h:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContent):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineDescentNeedsCollapsing const):

layout/inlineformatting/InlineItem.cpp: Copied from Source/WebCore/layout/tableformatting/TableInvalidation.cpp.

(WebCore::Layout::InlineItem::isForcedLineBreak const):
(WebCore::Layout::InlineItem::isText const):

layout/inlineformatting/InlineItem.h:

(WebCore::Layout::InlineItem::isBox const):
(WebCore::Layout::InlineItem::isText const): Deleted.
(WebCore::Layout::InlineItem::isHardLineBreak const): Deleted.
(WebCore::Layout::InlineItem::isLineBreak const): Deleted.

layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::close):
(WebCore::Layout::Line::alignContentVertically):
(WebCore::Layout::Line::append):
(WebCore::Layout::Line::appendLineBreak):
(WebCore::Layout::Line::adjustBaselineAndLineHeight):
(WebCore::Layout::Line::inlineItemContentHeight const):
(WebCore::Layout::Line::appendHardLineBreak): Deleted.

layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Run::isText const):
(WebCore::Layout::Line::Run::isForcedLineBreak const):
(WebCore::Layout::Line::Run::isLineBreak const): Deleted.

layout/inlineformatting/InlineLineLayout.cpp:

(WebCore::Layout::inlineItemWidth):
(WebCore::Layout::LineLayout::placeInlineItem):
(WebCore::Layout::LineLayout::shouldProcessUncommittedContent const):

layout/inlineformatting/InlineTextItem.h:

(WebCore::Layout::InlineTextItem::isSegmentBreak const):

layout/tableformatting/TableInvalidation.cpp:

8:09 AM WebKitGTK/Debugging edited by clopez@igalia.com

(diff)

8:08 AM WebKitGTK/Debugging edited by clopez@igalia.com

(diff)

6:01 AM Changeset in webkit [251589] by Chris Dumez

2 edits in trunk/Source/WebKit

[iOS] Regression(r251067) WebProcesses with service workers no longer keep their network process alive
https://bugs.webkit.org/show_bug.cgi?id=203388
<rdar://problem/56600074>

Reviewed by Geoffrey Garen.

Historically, WebProcessProxy::didSetAssertionState() used to return early for service worker processes
because we did not want service worker processes to prevent the network process from suspending. The
WebProcesses using the service worker process would prevent the network process from suspending when
they are visible, so it would work fine.

However, after r251067, there is no longer a concept of service worker process per se. Service workers
will now sometimes run in regular WebProcesses where we have pages. In such cases, didSetAssertionState()
would still return early and fail to keep its network process alive, even when the page(s) in this process
are visible on screen.

To address the issue, we now only return early if the process has a service worker but no page.
This should restore pre-existing behavior.

Note that this was causing hangs such as <rdar://problem/56245136> because the WebProcess would be
stuck on sync IPC to a suspended network process.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didSetAssertionState):

5:09 AM Changeset in webkit [251588] by Ross Kirsling

5 edits in trunk

test262-runner should be able to pass JSC a feature flag
https://bugs.webkit.org/show_bug.cgi?id=203301

Reviewed by Keith Miller.

JSTests:

test262/config.yaml:

Add feature flag mapping.
Also skip a few forgotten features as well as BigInt TypedArray tests.

test262/expectations.yaml:

Regenerate expectations.

Tools:

Scripts/test262/Runner.pm:

Recognize mapping from 262 features to JSC runtime options.

2:11 AM Changeset in webkit [251587] by Jonathan Bedard

10 edits in trunk/Tools

Python 3: Add support in webkitpy.common.checkout.scm
https://bugs.webkit.org/show_bug.cgi?id=203277

Reviewed by Stephanie Lewis.

Scripts/test-webkitpy-python3: Add webkitpy.common.checkout.scm, add --all flag.
Scripts/webkitpy/common/checkout/scm/detection.py: Use full import paths.
Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Ditto.
Scripts/webkitpy/common/checkout/scm/git.py:

(Git.revisions_changing_file): Convert filter iterator to list.
(Git.prepend_svn_revision): Patches need to be bytes.

Scripts/webkitpy/common/checkout/scm/scm.py: Import unicode.
Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Use full import paths,

differentiate between binary and text files, replace assertItemsEqual with sorted,
list fix regexes on byte arrays.

Scripts/webkitpy/common/checkout/scm/stub_repository.py: Use full import paths.
Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Use full import paths.
Scripts/webkitpy/common/checkout/scm/svn.py: Use full import paths.

(SVN.diff_for_revision): Diff for revision should be byte array.
(SVN.propget): Use Python 3 compatible encoding.

1:14 AM Changeset in webkit [251586] by Chris Dumez

11 edits in trunk

DatabaseContext should not prevent entering the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203103

Reviewed by Geoffrey Garen.

Source/WebCore:

Let pages with active webdatabase transactions into the back/forward cache. We make sure
to queue tasks that run script to the Window event loop, so that they get delayed when
the document is suspended.

No new tests, updated existing test.

Modules/webdatabase/Database.cpp:

(WebCore::Database::runTransaction):

Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::shouldPreventEnteringBackForwardCache_DEPRECATED const): Deleted.

Modules/webdatabase/DatabaseContext.h:
Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):

Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::performPendingCallback):

LayoutTests:

fast/history/page-cache-webdatabase-pending-transaction-expected.txt:
fast/history/page-cache-webdatabase-pending-transaction.html:

Update existing test to reflect behavior change.

platform/gtk/TestExpectations:
platform/mac/TestExpectations:

Unmark test as flaky.

1:14 AM Changeset in webkit [251585] by Chris Dumez

7 edits in trunk/Source/WebKit

Standardize "PageID=" vs "pageID =" in release logging
https://bugs.webkit.org/show_bug.cgi?id=203002

Reviewed by Geoffrey Garen.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _updateVisibleContentRects]):
(-[WKWebView _cancelAnimatedResize]):
(-[WKWebView _didCompleteAnimatedResize]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):
(-[WKWebView _resizeWhileHidingContentWithUpdates:]):

UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::processDidTerminate):
(WebKit::ProvisionalPageProxy::cancel):
(WebKit::ProvisionalPageProxy::loadData):
(WebKit::ProvisionalPageProxy::loadRequest):
(WebKit::ProvisionalPageProxy::goToBackForwardItem):
(WebKit::ProvisionalPageProxy::didCreateMainFrame):
(WebKit::ProvisionalPageProxy::didStartProvisionalLoadForFrame):
(WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):
(WebKit::ProvisionalPageProxy::didCommitLoadForFrame):

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::loadResource):
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::serviceWorkerDidNotHandle):
(WebKit::WebResourceLoader::didFailResourceLoad):
(WebKit::WebResourceLoader::didBlockAuthenticationChallenge):
(WebKit::WebResourceLoader::stopLoadingAfterXFrameOptionsOrContentSecurityPolicyDenied):
(WebKit::WebResourceLoader::didReceiveResource):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::freezeLayerTree):
(WebKit::WebPage::unfreezeLayerTree):

Oct 24, 2019:

11:59 PM Changeset in webkit [251584] by mark.lam@apple.com

33 edits
4 adds in trunk/Source

Move JSC::Register inline methods into RegisterInlines.h.
https://bugs.webkit.org/show_bug.cgi?id=203391

Reviewed by Yusuke Suzuki and Keith Miller.

Source/JavaScriptCore:

We're doing this because:

RegisterInlines.h is the canonical place to put inline Register methods.
It helps reduce build time. e.g. build-jsc went from 208.02 to 196.81 seconds (about a 5% reduction).
This enables experimental work to box JSCells in JSValue.

This patch also handles the fallout of this change, which necessitates more
inline methods being moved from <file>.h to their respective <file>Inlines.h.

JSArray.h used to include ButterflyInlines.h and JSCellInlines.h. This is a
violation of inclusion ordering (.h should not #include Inlines.h). This
violation has been removed.

API/JSAPIGlobalObject.mm:
CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.h:

(JSC::CallFrame::r): Deleted.
(JSC::CallFrame::uncheckedR): Deleted.

bytecode/MetadataTable.cpp:
ftl/FTLLowerDFGToB3.cpp:
interpreter/CallFrame.h:

(JSC::CallFrame::guaranteedJSValueCallee const): Deleted.
(JSC::CallFrame::jsCallee const): Deleted.
(JSC::CallFrame::codeBlock const): Deleted.
(JSC::CallFrame::unsafeCodeBlock const): Deleted.
(JSC::CallFrame::scope const): Deleted.
(JSC::CallFrame::topOfFrame): Deleted.
(JSC::CallFrame::setScope): Deleted.
(JSC::CallFrame::setCallee): Deleted.
(JSC::CallFrame::setCodeBlock): Deleted.

interpreter/CallFrameInlines.h:

(JSC::CallFrame::r):
(JSC::CallFrame::uncheckedR):
(JSC::CallFrame::guaranteedJSValueCallee const):
(JSC::CallFrame::jsCallee const):
(JSC::CallFrame::codeBlock const):
(JSC::CallFrame::unsafeCodeBlock const):
(JSC::CallFrame::lexicalGlobalObject const):
(JSC::CallFrame::setCallee):
(JSC::CallFrame::setCodeBlock):
(JSC::CallFrame::setScope):
(JSC::CallFrame::scope const):
(JSC::CallFrame::topOfFrame):

interpreter/Interpreter.cpp:
interpreter/ProtoCallFrame.h:

(JSC::ProtoCallFrame::init): Deleted.

interpreter/ProtoCallFrameInlines.h: Added.

(JSC::ProtoCallFrame::init):
(JSC::ProtoCallFrame::callee const):
(JSC::ProtoCallFrame::setCallee):
(JSC::ProtoCallFrame::codeBlock const):
(JSC::ProtoCallFrame::setCodeBlock):

interpreter/Register.h:

(JSC::Register::callFrame const): Deleted.
(JSC::Register::codeBlock const): Deleted.
(JSC::Register::asanUnsafeCodeBlock const): Deleted.

interpreter/RegisterInlines.h: Added.

(JSC::Register::callFrame const):
(JSC::Register::codeBlock const):
(JSC::Register::asanUnsafeCodeBlock const):
(JSC::Register::object const):
(JSC::Register::operator=):
(JSC::Register::scope const):

interpreter/StackVisitor.cpp:
jit/AssemblyHelpers.h:
llint/LLIntSlowPaths.cpp:
runtime/ArrayStorage.h:

(JSC::ArrayStorage::optimalVectorLength): Deleted.

runtime/ArrayStorageInlines.h: Added.

(JSC::ArrayStorage::availableVectorLength):
(JSC::ArrayStorage::optimalVectorLength):
(JSC::ArrayStorage::totalSize const):

runtime/ButterflyInlines.h:
runtime/ClassInfo.h:
runtime/GetVM.h: Added.
runtime/JSArray.h:
runtime/JSArrayInlines.h:
runtime/JSCellInlines.h:
runtime/JSGlobalObject.h:
runtime/JSObject.h:

(JSC::Register::object const): Deleted.
(JSC::Register::operator=): Deleted.

runtime/JSObjectInlines.h:
runtime/JSScope.h:

(JSC::Register::operator=): Deleted.
(JSC::Register::scope const): Deleted.
(JSC::CallFrame::lexicalGlobalObject const): Deleted.

runtime/JSString.h:
runtime/PropertyNameArray.h:
runtime/PropertySlot.h:
runtime/VMInlines.h:
tools/HeapVerifier.cpp:
wasm/js/WebAssemblyFunction.cpp:

Source/WebCore:

No new tests needed because there is no behavior change.

platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

10:45 PM Changeset in webkit [251583] by zandobersek@gmail.com

4 edits in trunk/Source/JavaScriptCore

REGRESSION(r251468): Build, test failures in 32-bit JSC after BytecodeIndex refactoring
https://bugs.webkit.org/show_bug.cgi?id=203290

Reviewed by Keith Miller.

bytecode/BytecodeIndex.h:

(JSC::BytecodeIndex::BytecodeIndex):
Add a BytecodeIndex(WTF::HashTableDeletedValueType) constructor.

bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):
Have the CodeOrigin(WTF::HashTableDeletedValueType) constructor
initialize the BytecodeIndex object accordingly, as a deleted value.
(JSC::CodeOrigin::isHashTableDeletedValue const):
Test BytecodeIndex object's deleted-value condition through the
corresponding BytecodeIndex::isHashTableDeletedValue() method.

profiler/ProfilerOrigin.h:

(JSC::Profiler::Origin::Origin):
Simplify the m_bytecodeIndex member initialization for a deleted value.
(JSC::Profiler::Origin::operator! const):
Fix the negation operator, returning true if the m_bytecodeIndex is
either empty or deleted.

10:05 PM Changeset in webkit [251582] by commit-queue@webkit.org

15 edits in trunk

Add more information to SRI failure console messages
https://bugs.webkit.org/show_bug.cgi?id=203383

Patch by Alex Christensen <achristensen@webkit.org> on 2019-10-24
Reviewed by Geoff Garen.

Source/WebCore:

bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::notifyFinished):

dom/LoadableClassicScript.cpp:

(WebCore::LoadableClassicScript::notifyFinished):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::reportIntegrityMetadataError):

loader/DocumentThreadableLoader.h:
loader/SubresourceIntegrity.cpp:

(WebCore::integrityMismatchDescription):

loader/SubresourceIntegrity.h:

LayoutTests:

http/tests/subresource-integrity/sri-enabled-with-setting-expected.txt:
http/tests/subresource-integrity/sri-module-expected.txt:
http/tests/subresource-integrity/sri-script-expected.txt:
http/tests/subresource-integrity/sri-style-expected.txt:

9:22 PM Changeset in webkit [251581] by Devin Rousso

30 edits in trunk

Automate generation of computedProperties
https://bugs.webkit.org/show_bug.cgi?id=198680
<rdar://problem/51507834>

Reviewed by Simon Fraser.

Source/WebCore:

A property should be listed as part of a CSSStyleDeclaration if:

it will not be skipped (skip-builder) when generating/building properties
it's not internal-only
it has more than one non-skip-builder/non-internal-only property in longhands
- if all the longhands are skip-builder/internal-only then the property doesn't really "have" any longhand properties
- if there's only one property in longhands, then it's more of an alias than a longhand

css/makeprop.pl:

(sortWithPrefixedPropertiesLast): Added.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::cssText const):
(WebCore::CSSComputedStyleDeclaration::length const):
(WebCore::CSSComputedStyleDeclaration::item const):
(WebCore::ComputedStyleExtractor::copyPropertiesInSet):
(WebCore::ComputedStyleExtractor::copyProperties):

css/StyleProperties.h:
css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::MutableStyleProperties):
(WebCore::StyleProperties::copyPropertiesInSet):
(WebCore::MutableStyleProperties::create):

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
platform/mac-sierra/fast/css/getComputedStyle/computed-style-expected.txt:
platform/wpe/fast/css/getComputedStyle/computed-style-expected.txt:

fast/css/getComputedStyle/computed-style-font-family-expected.txt:
platform/gtk/fast/css/getComputedStyle/computed-style-font-family-expected.txt:
platform/ios/fast/css/getComputedStyle/computed-style-font-family-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-font-family-expected.txt:
platform/mac-sierra/fast/css/getComputedStyle/computed-style-font-family-expected.txt:
platform/wpe/fast/css/getComputedStyle/computed-style-font-family-expected.txt:

fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/mac-sierra/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/wpe/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

svg/css/getComputedStyle-basic-expected.txt:
platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
platform/ios/svg/css/getComputedStyle-basic-expected.txt:
platform/mac/svg/css/getComputedStyle-basic-expected.txt:
platform/mac-sierra/svg/css/getComputedStyle-basic-expected.txt:
platform/wpe/svg/css/getComputedStyle-basic-expected.txt:

8:16 PM Changeset in webkit [251580] by Simon Fraser

4 edits in trunk

imported/w3c/web-platform-tests/css/css-values/calc-positive-fraction-001.html fails
https://bugs.webkit.org/show_bug.cgi?id=203332

Reviewed by Dean Jackson.
Source/WebCore:

The calc() spec <https://drafts.csswg.org/css-values-4/#calc-range> says that you clamp
and round the result of the clamp computation. Do that, instead of treating non-integral
calc results as invalid for CSS properties that only take integers.

Tests: imported/w3c/web-platform-tests/css/css-values/calc-positive-fraction-001.html

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::CalcParser::consumeInteger):
(WebCore::CSSPropertyParserHelpers::consumeInteger):

LayoutTests:

imported/w3c/web-platform-tests/css/css-values/calc-positive-fraction-001.html passes now.

TestExpectations:

6:36 PM Changeset in webkit [251579] by jiewen_tan@apple.com

2 edits in trunk/Tools

Unreviewed, a test fix after r251498

TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid.html:

6:30 PM Changeset in webkit [251578] by dino@apple.com

17 edits in branches/safari-608-branch

Cherry-pick r251390. rdar://56579651

Dispatch AR event on the originating anchor element
https://bugs.webkit.org/show_bug.cgi?id=203198
<rdar://55743929>

Reviewed by Simon Fraser.

Source/WebCore:

Expose an ElementContext on the SystemPreviewInfo, so that
when something happens in the AR QuickLook an event can be
fired on the originating <a> element.

dom/Document.cpp: (WebCore::Document::dispatchSystemPreviewActionEvent): Make sure we dispatch only to the HTMLAnchorElement.
dom/Document.h:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick):
loader/FrameLoaderTypes.h: (WebCore::SystemPreviewInfo::encode const): (WebCore::SystemPreviewInfo::decode):
testing/Internals.cpp: (WebCore::Internals::elementIdentifier const):
testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

Use the ElementContext on SystemPreviewInfo.

UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _triggerSystemPreviewActionOnElement:frame:page:]): (-[WKWebView _triggerSystemPreviewActionOnFrame:page:]): Deleted.
UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
UIProcess/SystemPreviewController.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::systemPreviewActionTriggered):

Tools:

Improve this test, most importantly so that it
actually works :)

Retrieve the ElementIdentifier for the <a> element,
and trigger a system preview action on it.

TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm: (-[TestSystemPreviewTriggeredHandler userContentController:didReceiveScriptMessage:]): (TestWebKitAPI::TEST):
TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html:

6:07 PM Changeset in webkit [251577] by Chris Dumez

17 edits in trunk/Source/WebKit

Simplify ProcessThrottler implementation
https://bugs.webkit.org/show_bug.cgi?id=203370

Reviewed by Alex Christensen.

Simplify ProcessThrottler implementation by:

Getting rid of CancelPrepareToSuspend IPC. Instead a regular ProcessDidResume IPC is sent to the child process.
Getting rid of the ProcessWillSuspendImminently IPC and send a regular ProcessDidResume IPC with a 'isSuspensionImminent' flag instead.
Whether the suspension is imminent or not, the child process now always responds with a ProcessReadyToSuspend IPC. This simplifies our logic as the idea is that treating imminent and non-imminent suspension should share as much of the same logic as possible.
All PrepareToSuspend IPCs now have an associated identifier and the child process sends back this identifier when responding with a ProcessReadyToSuspend IPC. This allows the ProcessThrottler to easily ignore outdated requests to suspend, without requiring the m_suspendMessageCount data member we had.

This patch also adds more logging to ProcessThrottler and the suspension logic in the child
processes. All ProcessThrottler logging now also shows the child process's PID for clarity.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processWillSuspendImminentlyForTestingSync):
(WebKit::NetworkProcess::prepareToSuspend):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _processWillSuspendImminentlyForTesting]):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::sendPrepareToSuspend):
(WebKit::NetworkProcessProxy::processReadyToSuspend):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
UIProcess/ProcessThrottler.cpp:

(WebKit::generatePrepareToSuspendRequestID):
(WebKit::ProcessThrottler::ProcessThrottler):
(WebKit::m_backgroundCounter):
(WebKit::ProcessThrottler::expectedAssertionState):
(WebKit::ProcessThrottler::updateAssertionStateNow):
(WebKit::ProcessThrottler::setAssertionState):
(WebKit::ProcessThrottler::updateAssertionIfNeeded):
(WebKit::ProcessThrottler::didConnectToProcess):
(WebKit::ProcessThrottler::prepareToSuspendTimeoutTimerFired):
(WebKit::ProcessThrottler::processReadyToSuspend):
(WebKit::ProcessThrottler::clearPendingRequestToSuspend):
(WebKit::ProcessThrottler::sendPrepareToSuspendIPC):
(WebKit::ProcessThrottler::uiAssertionWillExpireImminently):

UIProcess/ProcessThrottler.h:
UIProcess/ProcessThrottlerClient.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendPrepareToSuspend):
(WebKit::WebProcessProxy::processReadyToSuspend):

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::prepareToSuspend):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

6:00 PM Changeset in webkit [251576] by dino@apple.com

7 edits
1 add in branches/safari-608-branch/Source

Cherry-pick r251388. rdar://56579651

Move ElementContext from WebKit to WebCore
https://bugs.webkit.org/show_bug.cgi?id=203210
<rdar://problem/56475682>

Reviewed by Simon Fraser.

5:27 PM Changeset in webkit [251575] by zhifei_fang@apple.com

2 edits in trunk/LayoutTests

[jsc test] Skip intl-numberformat.js test
https://bugs.webkit.org/show_bug.cgi?id=203279

Reviewed by Yusuke Suzuki.

js/script-tests/intl-numberformat.js:

5:08 PM Changeset in webkit [251574] by rniwa@webkit.org

23 edits
8 adds in trunk

Add a mechanism to find and manipulate text by paragraphs
https://bugs.webkit.org/show_bug.cgi?id=203286

Reviewed by Wenson Hsieh.

Source/WebCore:

This patch introduces TextManipulationController which allows WebKit clients to find and replace
text content in a given document by paragraph boundary. For now, TextManipulationController finds
all paragraphs in the document and invokes the callback for each paragraph. In the future, this
controller will support detecting removal and insertion of new content to the document.

Tests: TextManipulation.StartTextManipulationFindSimpleParagraphs

TextManipulation.StartTextManipulationFindParagraphsWithMultileTokens
TextManipulation.CompleteTextManipulationShouldReplaceSimpleParagraphContent
TextManipulation.CompleteTextManipulationShouldFailWhenContentIsChanged
TextManipulation.CompleteTextManipulationShouldFailWhenDocumentHasBeenNavigatedAway

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Clear TextManipulationController. Otherwise m_items
in TextManipulationController may keep a bunch of nodes alive and not let this document destructed.
(WebCore::Document::textManipulationController): Added.

dom/Document.h:

(WebCore::Document::textManipulationControllerIfExists): Added.

editing/TextManipulationController.cpp: Added.

(WebCore::TextManipulationController::TextManipulationController): Added.
(WebCore::TextManipulationController::startObservingParagraphs): Finds all pargraphs and invoke
the callback.
(WebCore::TextManipulationController::addItem): Added. A helper for startObservingParagraphs.
(WebCore::TextManipulationController::completeManipulation): Added.
(WebCore::TextManipulationController::replace): Added. A helper for completeManipulation.

editing/TextManipulationController.h: Added.

(WebCore::TextManipulationController::ManipulationToken::encode const): Added.
(WebCore::TextManipulationController::ManipulationToken::decode): Added.

Source/WebKit:

This patch introduces a new SPI to find paragraphs of text and let client replace the content of each paragraph.
For now, this SPI is limited to find & replace contents of main frame's document.

WKWebView's _startTextManipulationsWithCompletionHandler sends StartTextManipulations message to WebContent process
to find all paragraphs in the main frame. WebContent process will send back DidFindTextManipulationItem message
for each paragraph, which in turn calls back _WKTextManipulationDelegate's _webView: didFindTextManipulationItem:.

Upon receiving this delegate callback, the client can invoke WKWebView's _completeTextManipulation to replace
the content. It will send CompleteTextManipulation to WebContent process, which will invoke completeManipulation
on main frame's document's TextManipulationController.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _textManipulationDelegate]): Aded.
(-[WKWebView _setTextManipulationDelegate:]): Aded.
(-[WKWebView _startTextManipulationsWithCompletionHandler:]):
(-[WKWebView _completeTextManipulation:completion:]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/_WKTextManipulationDelegate.h: Added.
UIProcess/API/Cocoa/_WKTextManipulationItem.h: Added.
UIProcess/API/Cocoa/_WKTextManipulationItem.mm: Added.

(-[_WKTextManipulationItem initWithIdentifier:tokens:]):
(-[_WKTextManipulationItem identifier]):
(-[_WKTextManipulationItem tokens]):

UIProcess/API/Cocoa/_WKTextManipulationToken.h: Added.
UIProcess/API/Cocoa/_WKTextManipulationToken.mm: Added.

(-[_WKTextManipulationToken init]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startTextManipulations):
(WebKit::WebPageProxy::didFindTextManipulationItem):
(WebKit::WebPageProxy::completeTextManipulation):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::startTextManipulations):
(WebKit::WebPage::completeTextManipulation):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

Added basic API tests for the new SPI.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm: Added.

(-[TextManipulationDelegate init]):
(-[TextManipulationDelegate _webView:didFindItem:forFrame:]):
(-[TextManipulationDelegate items]):
(TestWebKitAPI::createItem):

4:45 PM Changeset in webkit [251573] by Russell Epstein

32 edits
9 copies
21 moves
45 adds
65 deletes in trunk/LayoutTests

Unreviewed, rolling out r251536.

Landed 3 Broken Tests.

Reverted changeset:

"[Web Animations] Update WPT tests related to Web Animations
and remove imported Mozilla tests"
https://bugs.webkit.org/show_bug.cgi?id=203291
https://trac.webkit.org/changeset/251536

4:07 PM Changeset in webkit [251572] by Alan Coon

3 edits in tags/Safari-609.1.8/Source/WebCore

Cherry-pick r251571. rdar://problem/56560773

Build fix after r251567.

page/Page.cpp: (WebCore::Page::collectDocuments):
page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:57 PM Changeset in webkit [251571] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

Build fix after r251567.

page/Page.cpp:

(WebCore::Page::collectDocuments):

page/Page.h:

3:54 PM Changeset in webkit [251570] by Alan Coon

9 edits
2 deletes in tags/Safari-609.1.8

Cherry-pick r251567. rdar://problem/56560773

Unreviewed, rolling out r251269, r251294, and r251328.
https://bugs.webkit.org/show_bug.cgi?id=203384

Probably made many animation tests flaky (Requested by rniwa
on #webkit).

Reverted changesets:

"Integrate resize event with HTML5 event loop"
https://bugs.webkit.org/show_bug.cgi?id=202964
https://trac.webkit.org/changeset/251269

"Flaky Test: fast/events/resize-subframe-in-rendering-
update.html"
https://bugs.webkit.org/show_bug.cgi?id=203140
https://trac.webkit.org/changeset/251294

"Flaky Test: fast/events/resize-subframe-in-rendering-
update.html"
https://bugs.webkit.org/show_bug.cgi?id=203140
https://trac.webkit.org/changeset/251328

Patch by Commit Queue <commit-queue@webkit.org> on 2019-10-24

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:51 PM Changeset in webkit [251569] by Matt Lewis

21 edits
8 deletes in trunk

Unreviewed, rolling out r251558.

This broke internal builds

Reverted changeset:

"Add a mechanism to find and manipulate text by paragraphs"
https://bugs.webkit.org/show_bug.cgi?id=203286
https://trac.webkit.org/changeset/251558

3:48 PM Changeset in webkit [251568] by achristensen@apple.com

2 edits in trunk/Source/WebKit

REGRESSION(r251409) Service worker connection should not be established without service worker entitlement
https://bugs.webkit.org/show_bug.cgi?id=203385
<rdar://problem/37790257>

Reviewed by Chris Dumez.

r251409 introduced a new call to establishSWServerConnection that should have an entitlement check.
This was caught by a unit test in CI that is not easy to reproduce in WebKit's test. See the radar.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):

3:40 PM Changeset in webkit [251567] by rniwa@webkit.org

9 edits
2 deletes in trunk

Unreviewed, rolling out r251269, r251294, and r251328.
https://bugs.webkit.org/show_bug.cgi?id=203384

Probably made many animation tests flaky (Requested by rniwa
on #webkit).

Reverted changesets:

"Integrate resize event with HTML5 event loop"
https://bugs.webkit.org/show_bug.cgi?id=202964
https://trac.webkit.org/changeset/251269

"Flaky Test: fast/events/resize-subframe-in-rendering-
update.html"
https://bugs.webkit.org/show_bug.cgi?id=203140
https://trac.webkit.org/changeset/251294

"Flaky Test: fast/events/resize-subframe-in-rendering-
update.html"
https://bugs.webkit.org/show_bug.cgi?id=203140
https://trac.webkit.org/changeset/251328

Patch by Commit Queue <commit-queue@webkit.org> on 2019-10-24

3:14 PM Changeset in webkit [251566] by Brent Fulgham

2 edits in trunk/Source/WebKit

[iOS] Mismatch in com.apple.coremedia.audiodeviceclock declarations
https://bugs.webkit.org/show_bug.cgi?id=203367
<rdar://problem/56581166>

Reviewed by Per Arne Vollan.

The 'common.sb' sandbox allows access to "com.apple.coremedia.audiodeviceclock.xpc", but
the WebContent sandbox blocked access to "com.apple.coremedia.audiodeviceclock". This means
we aren't blocking that endpoint.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

3:12 PM Changeset in webkit [251565] by sihui_liu@apple.com

6 edits in trunk

[ Mac WK1 ] REGRESSION (r251261): Layout Test inspector/console/webcore-logging.html is consistently Failing
https://bugs.webkit.org/show_bug.cgi?id=203173
<rdar://problem/56424721>

Source/JavaScriptCore:

Hold a strong reference to JSGlobalOjbect in ConsoleMessage so that object is not garbage collected before
WebConsoleAgent::frameWindowDiscarded.

Covered by existing test: inspector/console/webcore-logging.html.

Reviewed by Geoffrey Garen.

inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::clear):

inspector/ConsoleMessage.h:

LayoutTests:

Reviewed by Geoffrey Garen.

play() returns a promise and the promise can be rejected by a later pause(). We didn't handle
that case so we could receive a type JavaScript message for the unhandled rejected promise.

inspector/console/webcore-logging.html:
platform/mac-wk1/TestExpectations:

3:00 PM Changeset in webkit [251564] by Dewei Zhu

34 edits in trunk/Websites/perf.webkit.org

Refactor "builds" table "build_number" row to "build_tag" to fit more generic use cases.
https://bugs.webkit.org/show_bug.cgi?id=203270

Reviewed by Ryosuke Niwa.

Rename "build_number" to "build_tag" to fit more generic use cases.
Add support to be backward compatible to accept reports contain either
"buildNumber" or "buildTag".

browser-tests/index.html:
init-database.sql:
migrate-database.sql: Updated migration sql for this change.
public/admin/test-configurations.php:
public/api/measurement-set.php:
public/api/runs.php:
public/api/upload-root.php: Added support for both "buildNumber" and "buildTag".
public/include/report-processor.php: Added support for both "buildNumber" and "buildTag".
public/v3/models/builder.js:

(Builder.prototype.urlForBuild):
(Builder):
(Build):
(Build.prototype.buildTag):
(Build.prototype.label):
(Build.prototype.url):
(Build.prototype.buildNumber): Deleted.

public/v3/models/measurement-adaptor.js:

(MeasurementAdaptor):
(MeasurementAdaptor.prototype.applyTo.return.build):

public/v3/pages/chart-pane-status-view.js:
public/v3/pages/test-freshness-page.js:

(TestFreshnessPage.prototype._renderTooltip):

server-tests/admin-platforms-tests.js:

(reportsForDifferentPlatforms):

server-tests/admin-reprocess-report-tests.js:
server-tests/api-commits-tests.js:
server-tests/api-manifest-tests.js:
server-tests/api-measurement-set-tests.js:
server-tests/api-report-tests.js: Added unit tests for testing "buildNumber" and "buildTag".

(emptyReport):
(reportWitMismatchingCommitTime):
(reportWithOneSecondCommitTimeDifference):
(emptySlaveReport):
(makeReport):
(reportWithSameSubtestName):

server-tests/api-upload-root-tests.js: Added unit tests for testing "buildNumber" and "buildTag".
server-tests/privileged-api-add-build-requests-tests.js:
server-tests/privileged-api-create-analysis-task-tests.js:
server-tests/privileged-api-create-test-group-tests.js:

(createAnalysisTask):

server-tests/privileged-api-upate-run-status.js:
server-tests/privileged-api-update-test-group-tests.js:

(async.createAnalysisTask):

server-tests/resources/mock-data.js:

(MockData.addMockConfiguration):
(MockData.sampleBuildData):
(MockData.finishedBuildData):

server-tests/tools-sync-buildbot-integration-tests.js:
tools/js/buildbot-syncer.js:

(BuildbotBuildEntry.prototype.initialize):
(BuildbotBuildEntry.prototype.buildTag):
(BuildbotBuildEntry.prototype.url):
(BuildbotSyncer.prototype.urlForBuildTag):
(BuildbotBuildEntry.prototype.buildNumber): Deleted.
(BuildbotSyncer.prototype.urlForBuildNumber): Deleted.

unit-tests/analysis-task-tests.js:

(measurementCluster):

unit-tests/buildbot-syncer-tests.js:
unit-tests/measurement-adaptor-tests.js:
unit-tests/measurement-set-analyzer-tests.js:
unit-tests/measurement-set-tests.js:
unit-tests/resources/mock-v3-models.js:

2:42 PM Changeset in webkit [251563] by Brent Fulgham

2 edits in trunk/Source/WebKit

[iOS] Mismatch in com.apple.MediaPlayer.RemotePlayerService declarations
https://bugs.webkit.org/show_bug.cgi?id=203368
<rdar://problem/56581152>

Reviewed by Per Arne Vollan.

The 'common.sb' sandbox allows access to the xpc-service-name "com.apple.MediaPlayer.RemotePlayerService",
but we block access to the global-name "com.apple.MediaPlayer.RemoteService". We aren't blocking
the right thing.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

2:28 PM Changeset in webkit [251562] by jiewen_tan@apple.com

2 edits in trunk/Tools

Unreviewed, a test fix after r251498

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

2:21 PM Changeset in webkit [251561] by Simon Fraser

3 edits in trunk/LayoutTests

Unreviewed test gardening.

Make the test added in r251385 pass in WebKit1.

compositing/video/video-border-radius-clipping-expected.html:
compositing/video/video-border-radius-clipping.html:

2:17 PM Changeset in webkit [251560] by beidson@apple.com

5 edits in trunk

Expose pageZoom as API.
https://bugs.webkit.org/show_bug.cgi?id=203381

Reviewed by Andy Estes.

Source/WebKit:

No new tests (No behavior change, identical to SPI)

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView setPageZoom:]):
(-[WKWebView pageZoom]):
(-[WKWebView _pageZoomFactor]):
(-[WKWebView _setPageZoomFactor:]):

Tools:

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController toggleZoomMode:]):
(-[WK2BrowserWindowController resetZoom:]):
(-[WK2BrowserWindowController canResetZoom]):
(-[WK2BrowserWindowController currentZoomFactor]):
(-[WK2BrowserWindowController setCurrentZoomFactor:]):

2:11 PM Changeset in webkit [251559] by ysuzuki@apple.com

11 edits in trunk/Source/JavaScriptCore

[JSC] Properly organize wasm operations
https://bugs.webkit.org/show_bug.cgi?id=203360

Reviewed by Keith Miller.

This patch cleans up operation functions called from Wasm.

Properly name these operations with prefix "operation".
Do not use lambda. Define function with JIT_OPERATION.
Consolidate them in WasmOperations.cpp.

wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::addRefFunc):
(JSC::Wasm::AirIRGenerator::addTableGet):
(JSC::Wasm::AirIRGenerator::addTableSet):
(JSC::Wasm::AirIRGenerator::addTableSize):
(JSC::Wasm::AirIRGenerator::addTableGrow):
(JSC::Wasm::AirIRGenerator::addTableFill):
(JSC::Wasm::AirIRGenerator::addGrowMemory):
(JSC::Wasm::AirIRGenerator::emitWriteBarrierForJSWrapper):
(JSC::Wasm::AirIRGenerator::addOp<OpType::I32Popcnt>):
(JSC::Wasm::AirIRGenerator::addOp<OpType::I64Popcnt>):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addTableGet):
(JSC::Wasm::B3IRGenerator::addTableSet):
(JSC::Wasm::B3IRGenerator::addRefFunc):
(JSC::Wasm::B3IRGenerator::addTableSize):
(JSC::Wasm::B3IRGenerator::addTableGrow):
(JSC::Wasm::B3IRGenerator::addTableFill):
(JSC::Wasm::B3IRGenerator::addGrowMemory):
(JSC::Wasm::B3IRGenerator::emitWriteBarrierForJSWrapper):
(JSC::Wasm::B3IRGenerator::addOp<OpType::I32Popcnt>):
(JSC::Wasm::B3IRGenerator::addOp<OpType::I64Popcnt>):

wasm/WasmInstance.cpp:

(JSC::Wasm::getWasmTableElement): Deleted.
(JSC::Wasm::setWasmTableElement): Deleted.
(JSC::Wasm::doWasmTableGrow): Deleted.
(JSC::Wasm::doWasmTableFill): Deleted.
(JSC::Wasm::doWasmRefFunc): Deleted.

wasm/WasmInstance.h:
wasm/WasmOperations.cpp:

(JSC::Wasm::operationWasmUnwind):
(JSC::Wasm::operationConvertToF64):
(JSC::Wasm::operationConvertToI32):
(JSC::Wasm::operationConvertToF32):
(JSC::Wasm::operationIterateResults):
(JSC::Wasm::operationAllocateResultsArray):
(JSC::Wasm::operationWasmWriteBarrierSlowPath):
(JSC::Wasm::operationPopcount32):
(JSC::Wasm::operationPopcount64):
(JSC::Wasm::operationGrowMemory):
(JSC::Wasm::operationGetWasmTableElement):
(JSC::Wasm::setWasmTableElement):
(JSC::Wasm::operationSetWasmTableElement):
(JSC::Wasm::operationWasmTableGrow):
(JSC::Wasm::operationWasmTableFill):
(JSC::Wasm::operationWasmRefFunc):
(JSC::Wasm::operationGetWasmTableSize):
(JSC::Wasm::operationWasmToJSException):

wasm/WasmOperations.h:
wasm/js/JSToWasm.cpp:

(JSC::Wasm::marshallJSResult):
(JSC::Wasm::allocateResultsArray): Deleted.

wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):
(JSC::Wasm::operationWasmToJSException): Deleted.

wasm/js/WasmToJS.h:
wasm/js/WebAssemblyInstanceConstructor.cpp:

2:01 PM Changeset in webkit [251558] by rniwa@webkit.org

21 edits
8 adds in trunk

Add a mechanism to find and manipulate text by paragraphs
https://bugs.webkit.org/show_bug.cgi?id=203286

Reviewed by Wenson Hsieh.

Source/WebCore:

Tests: TextManipulation.StartTextManipulationFindSimpleParagraphs

TextManipulation.StartTextManipulationFindParagraphsWithMultileTokens
TextManipulation.CompleteTextManipulationShouldReplaceSimpleParagraphContent
TextManipulation.CompleteTextManipulationShouldFailWhenContentIsChanged
TextManipulation.CompleteTextManipulationShouldFailWhenDocumentHasBeenNavigatedAway

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

dom/Document.h:

(WebCore::Document::textManipulationControllerIfExists): Added.

editing/TextManipulationController.cpp: Added.

editing/TextManipulationController.h: Added.

(WebCore::TextManipulationController::ManipulationToken::encode const): Added.
(WebCore::TextManipulationController::ManipulationToken::decode): Added.

Source/WebKit:

This patch introduces a new SPI to find paragraphs of text and let client replace the content of each paragraph.
For now, this SPI is limited to find & replace contents of main frame's document.

UIProcess/API/Cocoa/WKWebView.mm:

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/_WKTextManipulationDelegate.h: Added.
UIProcess/API/Cocoa/_WKTextManipulationItem.h: Added.
UIProcess/API/Cocoa/_WKTextManipulationItem.mm: Added.

(-[_WKTextManipulationItem initWithIdentifier:tokens:]):
(-[_WKTextManipulationItem identifier]):
(-[_WKTextManipulationItem tokens]):

UIProcess/API/Cocoa/_WKTextManipulationToken.h: Added.
UIProcess/API/Cocoa/_WKTextManipulationToken.mm: Added.

(-[_WKTextManipulationToken init]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startTextManipulations):
(WebKit::WebPageProxy::didFindTextManipulationItem):
(WebKit::WebPageProxy::completeTextManipulation):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::startTextManipulations):
(WebKit::WebPage::completeTextManipulation):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

Added basic API tests for the new SPI.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm: Added.

(-[TextManipulationDelegate init]):
(-[TextManipulationDelegate _webView:didFindItem:forFrame:]):
(-[TextManipulationDelegate items]):
(TestWebKitAPI::createItem):

1:48 PM Changeset in webkit [251557] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[Web Animations] Fix compositing/backing/transform-transition-from-outside-view.html
https://bugs.webkit.org/show_bug.cgi?id=184566

Patch by Antoine Quint <Antoine Quint> on 2019-10-24
Reviewed by Simon Fraser.

For the most part this is the same fix that Simon Fraser made to address 184611 in r251412 although here I also
changed the setTimeout call to requestAnimationFrame in order to ensure that the backing store bit was set in the
layer dump for WK1.

TestExpectations:
compositing/backing/transform-transition-from-outside-view.html:

1:27 PM Changeset in webkit [251556] by ysuzuki@apple.com

9 edits in trunk/Source/JavaScriptCore

[JSC] Remove LLInt's Callee size assumption
https://bugs.webkit.org/show_bug.cgi?id=203282

Reviewed by Mark Lam.

LLInt code still assumes that Callee is always allocated in non-LargeAllocation.
This patch removes this assumption by following three changes.

If we can get CodeBlock, we get VM& from CodeBlock.
In nativeCallTrampoline and internalFunctionCallTrampoline, we get VM& from JSGlobalObject. It involves one more pointer-chasing but it is OK since this JSGlobalObject's VM* field will be touched in called native functions anyway. And this code is only used when we are not using JIT.
In exception handling code in LLInt, we get VM& from callee by checking LargeAllocation possibility. This is OK since it is only executed when exception unwinding happens, and which is an expensive operation anyway.

heap/LargeAllocation.h:

(JSC::LargeAllocation::headerSize):

heap/WeakSet.h:

(JSC::WeakSet::WeakSet):
(JSC::WeakSet::vm const):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::vm const):
(JSC::JSGlobalObject::defaultCodeGenerationMode const):

runtime/VM.h:

(JSC::WeakSet::heap const):

1:07 PM Changeset in webkit [251555] by Brent Fulgham

2 edits in trunk/Source/WebKit

Unreviewed fix after r251511.

Some syctl names were omitted from the initial checkin.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

1:04 PM Changeset in webkit [251554] by Alan Bujtas

8 edits in trunk/Source/WebCore

[LFC][IFC] Add support for partial leading and trailing content
https://bugs.webkit.org/show_bug.cgi?id=203375

Reviewed by Antti Koivisto.

This patch adds support for splitting text content across multiple lines when needed.
It also supports complex cases when the text content spreads across multiple inline level boxes with different word-break values e.g.
<span style="word-break: keep-all">donotsplitthiscontent</span><span style="word-break: break-all">splitthiscontent</span>
would produce something like this with certain constraints.

-> | <- available width

"donotsplitthiscontentsplit
thiscontent"

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):

layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::LineBreaker::breakingContextForInlineContent):
(WebCore::Layout::LineBreaker::shouldWrapFloatBox):
(WebCore::Layout::LineBreaker::wordBreakingBehavior const):
(WebCore::Layout::LineBreaker::tryBreakingTextRun const):
(WebCore::Layout::LineBreaker::breakingContext): Deleted.
(WebCore::Layout::LineBreaker::breakingContextForFloat): Deleted.

layout/inlineformatting/InlineLineBreaker.h:
layout/inlineformatting/InlineLineLayout.cpp:

(WebCore::Layout::LineLayout::LineInput::LineInput):
(WebCore::Layout::LineLayout::layout):
(WebCore::Layout::LineLayout::close):
(WebCore::Layout::LineLayout::placeInlineItem):
(WebCore::Layout::LineLayout::processUncommittedContent):
(WebCore::Layout::LineLayout::shouldProcessUncommittedContent const):
(WebCore::Layout::LineLayout::UncommittedContent::trim):

layout/inlineformatting/InlineLineLayout.h:
layout/inlineformatting/InlineTextItem.cpp:

(WebCore::Layout::InlineTextItem::left const):
(WebCore::Layout::InlineTextItem::right const):
(WebCore::Layout::InlineTextItem::split const): Deleted.

layout/inlineformatting/InlineTextItem.h:

12:43 PM Changeset in webkit [251553] by beidson@apple.com

9 edits
2 adds in trunk

Formalize PDF snapshot API.
https://bugs.webkit.org/show_bug.cgi?id=203374

Reviewed by Tim Horton.

Source/WebKit:

Covered by API tests and MiniBrowser usage.

SourcesCocoa.txt:
UIProcess/API/Cocoa/WKPDFConfiguration.h: Added.
UIProcess/API/Cocoa/WKPDFConfiguration.mm: Added.

(-[WKPDFConfiguration init]):
(-[WKPDFConfiguration copyWithZone:]):

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView createPDFWithConfiguration:completionHandler:]):
(-[WKWebView _takePDFSnapshotWithConfiguration:completionHandler:]):

UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h: Unified build strikes again.

WebKit.xcodeproj/project.pbxproj:

Tools:

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController saveAsPDF:]):

TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:

(TestWebKitAPI::TEST):

12:27 PM Changeset in webkit [251552] by yurys@chromium.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: assertion failure at GeneralStyleDetailsSidebarPanel.js:34:23
https://bugs.webkit.org/show_bug.cgi?id=203376

Reviewed by Devin Rousso.

Use class's prototype instead of class itself when doing instanceof check.

UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:

(WI.GeneralStyleDetailsSidebarPanel):

12:12 PM Changeset in webkit [251551] by Brent Fulgham

2 edits in trunk/Source/WebKit

[iOS] Remove 'deny' rules that do not have a corresponding 'allow' rule
https://bugs.webkit.org/show_bug.cgi?id=203352

Reviewed by Per Arne Vollan.

Now that we no longer import 'common.sb', and have removed entries that allowed
services that we block, we can remove the 'deny' command. This is safe because
everything is denied by default.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

12:09 PM Changeset in webkit [251550] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, skip new tests added in 251509 on Windows

DataTransferItems is not supported on this platform.

platform/win/TestExpectations:

12:02 PM Changeset in webkit [251549] by Alan Coon

7 edits in branches/safari-608-branch/Source

Versioning.

11:53 AM Changeset in webkit [251548] by yurys@chromium.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: CONSOLE ERROR removeEventListener cannot remove blackboxed-urls-changed because it doesn't exist.
https://bugs.webkit.org/show_bug.cgi?id=203372

Reviewed by Devin Rousso.

Avoid console errors when opening source panel.

UserInterface/Views/SourceCodeTreeElement.js:

(WI.SourceCodeTreeElement.prototype._updateSourceCode): Only remove listener if it has
been added before.

11:50 AM Changeset in webkit [251547] by achristensen@apple.com

22 edits
2 adds in trunk/Source

Pass CORS-enabled schemes through WebProcess instead of having them NetworkProcess-global
https://bugs.webkit.org/show_bug.cgi?id=202891

Reviewed by Youenn Fablet.

Source/WebCore:

platform/LegacySchemeRegistry.cpp:

(WebCore::LegacySchemeRegistry::registerURLSchemeAsCORSEnabled):
(WebCore::LegacySchemeRegistry::shouldTreatURLSchemeAsCORSEnabled):
(WebCore::LegacySchemeRegistry::allURLSchemesRegisteredAsCORSEnabled):

platform/LegacySchemeRegistry.h:

Source/WebKit:

No change in behavior. Now the LegacySchemeRegistry is not used as much in the NetworkProcess, a step towards no use at all.
This functionality is currently only available through the glib API webkit_security_manager_register_uri_scheme_as_cors_enabled
but it has been requested in bug 201180 and bug 199064.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::registerURLSchemesAsCORSEnabled):

NetworkProcess/NetworkConnectionToWebProcess.h:

(WebKit::NetworkConnectionToWebProcess::schemeRegistry):

NetworkProcess/NetworkConnectionToWebProcess.messages.in:
NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::doesNotNeedCORSCheck const):

NetworkProcess/NetworkLoadChecker.h:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::registerURLSchemeAsCORSEnabled const): Deleted.

NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

NetworkProcess/NetworkProcessCreationParameters.h:
NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::m_shouldCaptureExtraNetworkLoadMetrics):

NetworkProcess/NetworkSchemeRegistry.cpp: Added.

(WebKit::NetworkSchemeRegistry::registerURLSchemeAsCORSEnabled):
(WebKit::NetworkSchemeRegistry::shouldTreatURLSchemeAsCORSEnabled):

NetworkProcess/NetworkSchemeRegistry.h: Added.

(WebKit::NetworkSchemeRegistry::create):

NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
Use nullptr, indicating that the PingLoad constructor that is used in ad click attribution should not check the custom scheme registry.
This is Ok because ad click attribution is only used for HTTP family schemes.
(WebKit::m_blobFiles):

NetworkProcess/PingLoad.h:
Sources.txt:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::registerURLSchemeAsCORSEnabled):

WebKit.xcodeproj/project.pbxproj:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::registerURLSchemeAsCORSEnabled):
(WebKit::WebProcess::ensureNetworkProcessConnection):
(WebKit::WebProcess::registerURLSchemeAsCORSEnabled const): Deleted.

WebProcess/WebProcess.h:

10:51 AM Changeset in webkit [251546] by aestes@apple.com

5 edits in trunk

[Cocoa] Make it possible to convert SharedBuffer segments and data views to NSData without copying
https://bugs.webkit.org/show_bug.cgi?id=203348

Reviewed by Alex Christensen.

Source/WebCore:

Added an API test.

platform/SharedBuffer.h:
platform/cocoa/SharedBufferCocoa.mm:

(-[WebCoreSharedBufferData initWithDataSegment:position:]):
(-[WebCoreSharedBufferData length]):
(-[WebCoreSharedBufferData bytes]):
(WebCore::SharedBuffer::createCFData const):
(WebCore::SharedBuffer::createNSDataArray const):
(WebCore::SharedBuffer::DataSegment::createNSData const):
(WebCore::SharedBufferDataView::createNSData const):
(-[WebCoreSharedBufferData initWithSharedBufferDataSegment:]): Deleted.

Tools:

TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:

(TestWebKitAPI::TEST_F):

9:57 AM Changeset in webkit [251545] by Chris Dumez

5 edits
2 adds in trunk

FetchResponse should not prevent entering the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203092
<rdar://problem/56554677>

Reviewed by Alex Christensen.

Source/WebCore:

Drop shouldPreventEnteringBackForwardCache_DEPRECATED() in FetchResponse to allow pages to
enter the back/forward cache, even when the fetch response has a blob loader. r251495
already made this safe by updating the FetchBodyOwner parent class to not resolve promises
while in the back/forward cache.

Test: fast/history/page-cache-active-fetch-response-blobReadAsBlob.html

Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::shouldPreventEnteringBackForwardCache_DEPRECATED const): Deleted.

Modules/fetch/FetchResponse.h:

LayoutTests:

Add layout test coverage.

TestExpectations:
fast/history/page-cache-active-fetch-response-blobReadAsBlob-expected.txt: Added.
fast/history/page-cache-active-fetch-response-blobReadAsBlob.html: Added.

9:39 AM Changeset in webkit [251544] by aboya@igalia.com

2 edits in trunk/Source/WebCore

[MSE][GStreamer] Reintroduce ensureGLVideoSinkContext() fix
https://bugs.webkit.org/show_bug.cgi?id=201401

Reviewed by Philippe Normand.

That patch was almost mechanically reverted temporarily along the rest
of the WebKitMediaSrc rework. In theory that should have been OK since
it was supposed to fix a regression of that patch... But actually
the bug was already causing problems before, the WebKitMediaSrc rework
just exposed a more common case.

It has been reported that the same bug arises when adding some CSS
styles to the <video> element, and the patch fixes the issue.

And the patch actually makes sense in any case... since without it
some perfectly valid state transitions are not covered!

So I'm reintroducing it.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):

9:35 AM Changeset in webkit [251543] by graouts@webkit.org

3 edits in trunk/Source/WebCore

[Web Animations] Only process CSS properties affected by a given CSS transition
https://bugs.webkit.org/show_bug.cgi?id=203238

Reviewed by Simon Fraser.

When the "transition" property, or one of its longhands, would change we would iterate over every known CSS property to identify whether the before and after
styles showed reasons to create, modify or cancel a backing CSSTransition object. However, we only need to do this in the case where "transition-property" is
"all", ie. where the Animation object has its animationMode() set to Animation::AnimateAll. In all other cases, we only need to iterate over the CSS properties
specified by "transition-property".

We now compile a list of CSS properties to iterate over by looking at all properties listed in the "transition-property" for the before and after styles.

animation/AnimationTimeline.cpp:

(WebCore::compileTransitionPropertiesInStyle):
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
(WebCore::AnimationTimeline::updateCSSTransitionsForElement):

animation/AnimationTimeline.h:

9:24 AM Changeset in webkit [251542] by youenn@apple.com

5 edits in trunk

XMLHttpRequest.responseXML url should be the HTTP response URL
https://bugs.webkit.org/show_bug.cgi?id=203289

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/xhr-response-url.https-expected.txt:
web-platform-tests/xhr/responsexml-document-properties-expected.txt:

Source/WebCore:

Follow https://xhr.spec.whatwg.org/#document-response step 9.
Covered by rebased tests.

xml/XMLHttpRequest.cpp:

9:12 AM Changeset in webkit [251541] by Truitt Savell

2 edits in trunk/LayoutTests

Removing expectations for legacy-animation-engine/compositing/backing/transform-transition-from-outside-view.html
https://bugs.webkit.org/show_bug.cgi?id=203225

unreviewed test gardening.

platform/mac-wk2/TestExpectations:

9:06 AM Changeset in webkit [251540] by Antti Koivisto

5 edits
2 adds in trunk/Source/WebCore

Move property cascade out of StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=203361

Reviewed by Zalan Bujtas.

Rename StyleResolver::CascadedProperties -> Style::PropertyCascade and move it into a file of its own.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::cascadedPropertiesForRollback):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::applyCascadedPropertiesImpl):
(WebCore::shouldApplyPropertyInParseOrder): Deleted.
(WebCore::isValidMarkerStyleProperty): Deleted.
(WebCore::isValidCueStyleProperty): Deleted.
(WebCore::StyleResolver::CascadedProperties::CascadedProperties): Deleted.
(WebCore::StyleResolver::CascadedProperties::hasProperty const): Deleted.
(WebCore::StyleResolver::CascadedProperties::property): Deleted.
(WebCore::StyleResolver::CascadedProperties::hasCustomProperty const): Deleted.
(WebCore::StyleResolver::CascadedProperties::customProperty const): Deleted.
(WebCore::StyleResolver::CascadedProperties::setPropertyInternal): Deleted.
(WebCore::StyleResolver::CascadedProperties::set): Deleted.
(WebCore::StyleResolver::CascadedProperties::setDeferred): Deleted.
(WebCore::StyleResolver::CascadedProperties::addMatch): Deleted.
(WebCore::declarationsForCascadeLevel): Deleted.
(WebCore::StyleResolver::CascadedProperties::addNormalMatches): Deleted.
(WebCore::hasImportantProperties): Deleted.
(WebCore::StyleResolver::CascadedProperties::addImportantMatches): Deleted.
(WebCore::StyleResolver::CascadedProperties::applyDeferredProperties): Deleted.
(WebCore::StyleResolver::CascadedProperties::Property::apply): Deleted.

css/StyleResolver.h:

(WebCore::StyleResolver::State::authorRollback const):
(WebCore::StyleResolver::State::userRollback const):
(WebCore::StyleResolver::State::setAuthorRollback):
(WebCore::StyleResolver::State::setUserRollback):
(WebCore::StyleResolver::CascadedProperties::customProperties): Deleted.
(WebCore::StyleResolver::cascadeLevel const): Deleted.
(WebCore::StyleResolver::setCascadeLevel): Deleted.

style/PropertyCascade.cpp: Added.

(WebCore::Style::shouldApplyPropertyInParseOrder):
(WebCore::Style::isValidMarkerStyleProperty):
(WebCore::Style::isValidCueStyleProperty):
(WebCore::Style::PropertyCascade::PropertyCascade):
(WebCore::Style::PropertyCascade::setPropertyInternal):
(WebCore::Style::PropertyCascade::set):
(WebCore::Style::PropertyCascade::setDeferred):
(WebCore::Style::PropertyCascade::addMatch):
(WebCore::Style::declarationsForCascadeLevel):
(WebCore::Style::PropertyCascade::addNormalMatches):
(WebCore::Style::hasImportantProperties):
(WebCore::Style::PropertyCascade::addImportantMatches):
(WebCore::Style::PropertyCascade::applyDeferredProperties):
(WebCore::Style::PropertyCascade::Property::apply):

style/PropertyCascade.h: Added.

(WebCore::Style::PropertyCascade::customProperties):
(WebCore::Style::PropertyCascade::hasProperty const):
(WebCore::Style::PropertyCascade::property):
(WebCore::Style::PropertyCascade::hasCustomProperty const):
(WebCore::Style::PropertyCascade::customProperty const):

9:02 AM Changeset in webkit [251539] by Kocsen Chung

4 edits in tags/Safari-609.1.8

Cherry-pick r251523. rdar://problem/56553939

WebBackForwardCache::removeEntriesMatching() may re-enter and crash
https://bugs.webkit.org/show_bug.cgi?id=203341
<rdar://problem/56553939>

Reviewed by Geoffrey Garen.

Source/WebKit:

When WebBackForwardCache::removeEntriesMatching() was clearing the WebBackForwardListItem's
WebBackForwardCacheEntry, it could destroyed a SuspendedPageProxy which could shutdown a
WebProcess. Upon shutting down, we would try to remove WebBackForwardCache entries associated
with a given process, re-enter removeEntriesMatching() and crash.

To address the issue, I made WebBackForwardCache::removeEntriesMatching() safe to re-enter.
We now clear the WebBackForwardListItems' WebBackForwardCacheEntries only after we're done
updating m_itemsWithCachedPage.

UIProcess/WebBackForwardCache.cpp: (WebKit::WebBackForwardCache::removeEntriesMatching):

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:52 AM Changeset in webkit [251538] by Truitt Savell

2 edits in trunk/LayoutTests

REGRESSION: [ iOS ] ( r251015 ) Layout Test fast/text/whitespace/pre-wrap-overflow-selection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=203366

Unreviewed test gardening

platform/ios/TestExpectations:

7:39 AM Changeset in webkit [251537] by Chris Dumez

7 edits in trunk

AudioContext should not prevent entering the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203102

Reviewed by Geoffrey Garen.

Source/WebCore:

Allow pages with AudioContexts that are rendering in the back/forward cache.
Upon entering the back/forward cache, we suspend rendering and update IsPlaying
state so that the browser no longer shows the "Audio Playing" icon. Upon restoring
from the back/forward cache, we resume rendering and update IsPlaying state again
so that the browser shows the "Audio Playing" icon again. I tested it on:

http://webaudioplayground.appspot.com

With regards to events dispatching, the AudioContext class is already using a
GenericEventQueue that properly delays event dispatching while in the back/forward
cache.

No new tests, updated existing test.

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::suspend):
(WebCore::AudioContext::resume):
(WebCore::AudioContext::suspendRendering):
(WebCore::AudioContext::resumeRendering):

Modules/webaudio/AudioContext.h:
Modules/webaudio/AudioContext.idl:

LayoutTests:

Update layout test coverage.

fast/history/page-cache-running-audiocontext-expected.txt:
fast/history/page-cache-running-audiocontext.html:

6:25 AM Changeset in webkit [251536] by commit-queue@webkit.org

32 edits
41 copies
312 adds
3 deletes in trunk/LayoutTests

[Web Animations] Update WPT tests related to Web Animations and remove imported Mozilla tests
https://bugs.webkit.org/show_bug.cgi?id=203291

Patch by Antoine Quint <Antoine Quint> on 2019-10-24
Reviewed by Youenn Fablet.

LayoutTests/imported/mozilla:

css-animations/test_animation-cancel-expected.txt: Removed.
css-animations/test_animation-cancel.html: Removed.
css-animations/test_animation-currenttime-expected.txt: Removed.
css-animations/test_animation-currenttime.html: Removed.
css-animations/test_animation-finish-expected.txt: Removed.
css-animations/test_animation-finish.html: Removed.
css-animations/test_animation-finished-expected.txt: Removed.
css-animations/test_animation-finished.html: Removed.
css-animations/test_animation-id.html: Removed.
css-animations/test_animation-pausing.html: Removed.
css-animations/test_animation-playstate.html: Removed.
css-animations/test_animation-ready.html: Removed.
css-animations/test_animation-reverse-expected.txt: Removed.
css-animations/test_animation-reverse.html: Removed.
css-animations/test_animation-starttime-expected.txt: Removed.
css-animations/test_animation-starttime.html: Removed.
css-animations/test_animations-dynamic-changes.html: Removed.
css-animations/test_event-dispatch.html: Removed.
css-animations/test_event-order-expected.txt: Removed.
css-animations/test_event-order.html: Removed.
css-animations/test_setting-effect.html: Removed.
css-transitions/test_animation-cancel.html: Removed.
css-transitions/test_animation-currenttime-expected.txt: Removed.
css-transitions/test_animation-currenttime.html: Removed.
css-transitions/test_animation-finished-expected.txt: Removed.
css-transitions/test_animation-finished.html: Removed.
css-transitions/test_animation-pausing-expected.txt: Removed.
css-transitions/test_animation-pausing.html: Removed.
css-transitions/test_animation-ready-expected.txt: Removed.
css-transitions/test_animation-ready.html: Removed.
css-transitions/test_animation-starttime-expected.txt: Removed.
css-transitions/test_animation-starttime.html: Removed.
css-transitions/test_csstransition-transitionproperty.html: Removed.
css-transitions/test_document-get-animations-expected.txt: Removed.
css-transitions/test_document-get-animations.html: Removed.
css-transitions/test_element-get-animations-expected.txt: Removed.
css-transitions/test_element-get-animations.html: Removed.
css-transitions/test_event-dispatch.html: Removed.
css-transitions/test_keyframeeffect-getkeyframes-expected.txt: Removed.
css-transitions/test_keyframeeffect-getkeyframes.html: Removed.
css-transitions/test_setting-effect-expected.txt: Removed.
css-transitions/test_setting-effect.html: Removed.

LayoutTests/imported/w3c:

resources/import-expectations.json:
web-platform-tests/css/css-animations: Resynced.
web-platform-tests/css/css-transitions: Imported.
web-platform-tests/web-animations: Resynced.

LayoutTests:

TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
platform/mac-wk1/TestExpectations:
platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
platform/win/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
tests-options.json:

4:26 AM Changeset in webkit [251535] by clopez@igalia.com

3 edits in trunk/Source/WebKit

[GTK][WPE] Enable runtime setting with experimental features for Server Timing API
https://bugs.webkit.org/show_bug.cgi?id=203295

Reviewed by Carlos Garcia Campos.

Enable the runtime ServerTiming by default when GTK or WPE is built
with experimental features enabled.

No new tests, no change in behaviour for WTR.

Shared/WebPreferences.yaml:
Shared/WebPreferencesDefaultValues.h:

2:06 AM Changeset in webkit [251534] by zandobersek@gmail.com

9 edits in trunk/Source/JavaScriptCore

[JSC] Get 32-bit ports back into building order
https://bugs.webkit.org/show_bug.cgi?id=203358

Reviewed by Carlos Garcia Campos.

Get JSC building again on 32-bit architectures after changes in r251468.
Some 32-bit code in LLint and JIT is brought back, and additional casts
around BytecodeIndex construction are added as necessary.

dfg/DFGOSRExit.cpp:

(JSC::DFG::reifyInlinedCallFrames):

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

interpreter/CallFrame.cpp:

(JSC::CallFrame::setCurrentVPC):

jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):

jit/JITInlines.h:

(JSC::JIT::updateTopCallFrame):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_log_shadow_chicken_tail):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id_direct):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emit_op_in_by_id):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

1:36 AM Changeset in webkit [251533] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Disable pichdr generation on MIPS for return location labels
https://bugs.webkit.org/show_bug.cgi?id=203040

Patch by Paulo Matos <Paulo Matos> on 2019-10-24
Reviewed by Yusuke Suzuki.

Disable generation of pichdr for return location labels generated in
defineOSRExitReturnLabel. Since r250806 (Allow OSR exit to the LLInt),
MIPS was segfaulting since the pichdr after an OSR exit was corruption
the gp register.

offlineasm/mips.rb:

1:18 AM Changeset in webkit [251532] by Antti Koivisto

7 edits in trunk/Source/WebCore

Move MatchResult and related types out of StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=203252

Reviewed by Zalan Bujtas.

Reverse the dependency between StyleResolver and ElementRuleCollector so that the former depends on the latter.
This makes the code easier to understand and enables further cleanups.

The patch also gets rid of the confusing RuleRange objects in fovor of splitting declarations from different cascade levels to separate vectors.
The desired cascade level is indicated with an enum instead of a range.

There is also some general modernization.

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchResult const):
(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::transferMatchedRules):
(WebCore::ElementRuleCollector::matchAllRules):
(WebCore::ElementRuleCollector::addMatchedProperties):
(WebCore::ElementRuleCollector::matchedResult): Deleted.

css/ElementRuleCollector.h:

(WebCore::PseudoStyleRequest::PseudoStyleRequest):
(WebCore::MatchResult::isEmpty const):
(WebCore::operator==):
(WebCore::operator!=):

css/PageRuleCollector.cpp:

(WebCore::PageRuleCollector::matchPageRules):

css/PageRuleCollector.h:

(WebCore::PageRuleCollector::matchResult const):
(WebCore::PageRuleCollector::matchedResult): Deleted.

css/StyleResolver.cpp:

(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::computeMatchedPropertiesHash):
(WebCore::StyleResolver::findFromMatchedPropertiesCache):
(WebCore::extractDirectionAndWritingMode):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::cascadedPropertiesForRollback):
(WebCore::StyleResolver::CascadedProperties::addMatch):
(WebCore::declarationsForCascadeLevel):
(WebCore::StyleResolver::CascadedProperties::addNormalMatches):
(WebCore::StyleResolver::CascadedProperties::addImportantMatches):
(WebCore::StyleResolver::MatchResult::addMatchedProperties): Deleted.
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.
(WebCore::cascadeLevelForIndex): Deleted.

css/StyleResolver.h:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::MatchedPropertiesCacheItem):
(WebCore::PseudoStyleRequest::PseudoStyleRequest): Deleted.
(WebCore::StyleResolver::RuleRange::RuleRange): Deleted.
(WebCore::StyleResolver::MatchRanges::MatchRanges): Deleted.
(WebCore::StyleResolver::MatchRanges::UARuleRange): Deleted.
(WebCore::StyleResolver::MatchRanges::authorRuleRange): Deleted.
(WebCore::StyleResolver::MatchRanges::userRuleRange): Deleted.
(WebCore::StyleResolver::MatchResult::MatchResult): Deleted.
(WebCore::StyleResolver::MatchResult::matchedProperties const): Deleted.
(WebCore::StyleResolver::isRightPage const): Deleted.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed