Context Navigation

← Previous Period
Next Period →

Timeline

Oct 26, 2019:

1:50 PM Changeset in webkit [251639] by youenn@apple.com

12 edits
2 adds in trunk

Enforce user gesture for getUserMedia in case a previous getUserMedia call was denied
https://bugs.webkit.org/show_bug.cgi?id=203362

Reviewed by Eric Carlson.

Source/WebCore:

Compute whether a media request is user priviledged or not.
It is priviledged if it is created as part of a user gesture and no request of the same type
has been previously created for the same user gesture.
If getDisplayMedia is called twice as part of a single user gesture, getDisplaMedia will reject for the second call.

Test: fast/mediastream/getUserMedia-deny-persistency5.html and updated test.

Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::computeUserGesturePriviledge):
(WebCore::MediaDevices::getUserMedia):
(WebCore::MediaDevices::getDisplayMedia):
(WebCore::MediaDevices::getUserMedia const): Deleted.
(WebCore::MediaDevices::getDisplayMedia const): Deleted.

Modules/mediastream/MediaDevices.h:
platform/mediastream/MediaStreamRequest.h:

(WebCore::MediaStreamRequest::encode const):
(WebCore::MediaStreamRequest::decode):

Source/WebKit:

In case the request has user gesture priviledge, do not look at denied request history.

UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::getRequestAction):

UIProcess/UserMediaPermissionRequestProxy.h:

(WebKit::UserMediaPermissionRequestProxy::isUserGesturePriviledged const):

Tools:

Update test to take into account the ability to reask permission.

TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:

(TestWebKitAPI::TEST_F):

LayoutTests:

fast/mediastream/getUserMedia-deny-persistency5-expected.txt:
fast/mediastream/getUserMedia-deny-persistency5.html:
fast/mediastream/screencapture-user-gesture-expected.txt:
fast/mediastream/screencapture-user-gesture.html:

12:16 PM Changeset in webkit [251638] by Alan Bujtas

9 edits in trunk/Source/WebCore

[LFC] Do not layout on every paint frame.
https://bugs.webkit.org/show_bug.cgi?id=203462
<rdar://problem/56646779>

Reviewed by Antti Koivisto.

This is in preparation for being able to run layout benchmarks.

layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::runLayoutAndVerify):
(WebCore::Layout::LayoutContext::paint):
(WebCore::Layout::LayoutContext::runLayoutAndPaint): Deleted.

layout/LayoutContext.h:
layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::LayoutState):

layout/LayoutState.h:
layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::printLayoutTreeForLiveDocuments):

page/FrameView.cpp:

(WebCore::FrameView::paintContents):

page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layoutUsingFormattingContext):
(WebCore::FrameViewLayoutContext::layout):
(WebCore::layoutUsingFormattingContext): Deleted.

page/FrameViewLayoutContext.h:

(WebCore::FrameViewLayoutContext::initialLayoutState const):

10:17 AM Changeset in webkit [251637] by commit-queue@webkit.org

21 edits
26 adds in trunk

Main implementation for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=200764

Patch by Rob Buis <rbuis@igalia.com> on 2019-10-26
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Set correct test option.

web-platform-tests/loading/lazyload/image-loading-lazy.tentative-expected.txt: Added.
web-platform-tests/loading/lazyload/image-loading-lazy.tentative.html:

Source/WebCore:

Implement lazy image loading as specified here [1]. Lazy image loading
is controlled by the loading attribute on <img>. When the loading attribute is
auto or not specified, the behavior is like before this patch, i.e. loading is
eager.

Not all loading=lazy requests will turn into actual lazy image loads, when
scripting is turned off or images are not http(s), they will not be deferred.

This implementation relies on Intersection Observer and hence works on WK2 only.

Deferred images are painted using a simple outline until fully loaded.

[1] https://github.com/whatwg/html/pull/3752/files

Tests: http/tests/lazyload/attribute.html

http/tests/lazyload/invisible-image.html
http/tests/lazyload/js-image.html
http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html
http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html
http/tests/lazyload/lazy.html
http/tests/lazyload/scroll-element-moved-from-document.html
http/tests/lazyload/scroll-element-removed-from-document.html
http/tests/lazyload/scroll.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::lazyLoadImageObserver):

dom/Document.h:
html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::loadDeferredImage):
(WebCore::HTMLImageElement::didMoveToNewDocument):
(WebCore::HTMLImageElement::loadingForBindings const):
(WebCore::HTMLImageElement::setLoadingForBindings):
(WebCore::HTMLImageElement::isDeferred const):
(WebCore::HTMLImageElement::isLazyLoadable const):

html/HTMLImageElement.h:
html/HTMLImageElement.idl:
html/LazyLoadImageObserver.cpp: Added.

(WebCore::LazyLoadImageObserver::observe):
(WebCore::LazyLoadImageObserver::unobserve):
(WebCore::LazyLoadImageObserver::intersectionObserver):
(WebCore::LazyLoadImageObserver::isObserved const):

html/LazyLoadImageObserver.h: Added.
html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::loadDeferredImage):

loader/ImageLoader.h:

(WebCore::ImageLoader::isDeferred const):

loader/cache/CachedImage.h:
loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy const):
(WebCore::CachedResourceLoader::clientDefersImage const):
(WebCore::CachedResourceLoader::shouldDeferImageLoad const):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

loader/cache/CachedResourceLoader.h:
rendering/RenderImage.cpp:

(WebCore::isDeferredImage):
(WebCore::RenderImage::paintReplaced):

LayoutTests:

Import relevant tests into http/tests/lazyload.
Skip lazy image load tests for WK1 and windows, which
has IntersectionObserver turned off by default.

TestExpectations:
http/tests/lazyload/attribute-expected.txt: Added.
http/tests/lazyload/attribute.html: Added.
http/tests/lazyload/invisible-image-expected.txt: Added.
http/tests/lazyload/invisible-image.html: Added.
http/tests/lazyload/js-image-expected.txt: Added.
http/tests/lazyload/js-image.html: Added.
http/tests/lazyload/lazy-expected.txt: Added.
http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled-expected.txt: Added.
http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html: Added.
http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled-expected.txt: Added.
http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html: Added.
http/tests/lazyload/lazy.html: Added.
http/tests/lazyload/lazy2-expected.txt: Added.
http/tests/lazyload/placeholder.js: Added.

(is_image_fully_loaded):

http/tests/lazyload/resources/lazy-load-in-iframe.html: Added.
http/tests/lazyload/scroll-element-moved-from-document-expected.txt: Added.
http/tests/lazyload/scroll-element-moved-from-document.html: Added.
http/tests/lazyload/scroll-element-removed-from-document-expected.txt: Added.
http/tests/lazyload/scroll-element-removed-from-document.html: Added.
http/tests/lazyload/scroll-expected.txt: Added.
http/tests/lazyload/scroll.html: Added.
platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:

8:15 AM Changeset in webkit [251636] by Antti Koivisto

5 edits in trunk/Source/WebCore

Move StyleResolver::applyProperty to PropertyCascade
https://bugs.webkit.org/show_bug.cgi?id=203458

Reviewed by Zalan Bujtas.

Move the more of the property applying code out of StyleResolver.

css/StyleResolver.cpp:

(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::isValidVisitedLinkProperty): Deleted.
(WebCore::StyleResolver::applyProperty): Deleted.
(WebCore::StyleResolver::resolvedVariableValue const): Deleted.

css/StyleResolver.h:
style/PropertyCascade.cpp:

(WebCore::Style::isValidVisitedLinkProperty):
(WebCore::Style::PropertyCascade::applyCustomProperty):
(WebCore::Style::PropertyCascade::propertyCascadeForRollback):
(WebCore::Style::PropertyCascade::applyProperty):
(WebCore::Style::PropertyCascade::resolveValue):
(WebCore::Style::PropertyCascade::resolvedVariableValue):

style/PropertyCascade.h:

(WebCore::Style::PropertyCascade::property const):
(WebCore::Style::PropertyCascade::property): Deleted.
(WebCore::Style::PropertyCascade::hasAppliedProperty const): Deleted.

8:10 AM Changeset in webkit [251635] by Simon Fraser

3 edits
100 adds in trunk/LayoutTests/imported/w3c

Import css/css-syntax WPT tests
https://bugs.webkit.org/show_bug.cgi?id=203444

Reviewed by Antti Koivisto.

Imported from WPT at 5eebc927c57ec8c5e234fef8e4cc480ac339462c (Mon Oct 21 20:23:09 2019 +0100).

resources/import-expectations.json:
resources/resource-files.json:
web-platform-tests/css/css-syntax/META.yml: Added.
web-platform-tests/css/css-syntax/anb-parsing-expected.txt: Added.
web-platform-tests/css/css-syntax/anb-parsing.html: Added.
web-platform-tests/css/css-syntax/anb-serialization-expected.txt: Added.
web-platform-tests/css/css-syntax/anb-serialization.html: Added.
web-platform-tests/css/css-syntax/cdc-vs-ident-tokens-expected.txt: Added.
web-platform-tests/css/css-syntax/cdc-vs-ident-tokens.html: Added.
web-platform-tests/css/css-syntax/charset-is-not-a-rule-expected.txt: Added.
web-platform-tests/css/css-syntax/charset-is-not-a-rule.html: Added.
web-platform-tests/css/css-syntax/charset/.htaccess: Added.
web-platform-tests/css/css-syntax/charset/MANIFEST: Added.
web-platform-tests/css/css-syntax/charset/page-utf16-css-bomless-utf16-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-utf16-css-bomless-utf16.html: Added.
web-platform-tests/css/css-syntax/charset/page-utf16-css-bomless-utf16be-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-utf16-css-bomless-utf16be.html: Added.
web-platform-tests/css/css-syntax/charset/page-utf16-css-no-decl-ascii-only-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-utf16-css-no-decl-ascii-only.html: Added.
web-platform-tests/css/css-syntax/charset/page-utf16-css-no-decl-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-utf16-css-no-decl.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-charset-attribute-bogus-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-charset-attribute-bogus.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-1250-charset-attribute-windows-1253-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-1250-charset-attribute-windows-1253.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-bogus-charset-attribute-windows-1250-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-bogus-charset-attribute-windows-1250.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-bogus-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-bogus.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-utf16-ascii-only-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-utf16-ascii-only.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-utf16-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-utf16.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-utf16be-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-utf16be.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-windows-1250-in-utf16-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-windows-1250-in-utf16.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-windows-1250-in-utf16be-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-at-charset-windows-1250-in-utf16be.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-http-bogus-at-charset-windows-1250-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-http-bogus-at-charset-windows-1250.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-http-bogus-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-http-bogus.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-http-windows-1250-at-charset-windows-1253-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-http-windows-1250-at-charset-windows-1253.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-no-decl-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-no-decl.html: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-utf8-bom-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/page-windows-1251-css-utf8-bom.html: Added.
web-platform-tests/css/css-syntax/charset/support/MANIFEST: Added.
web-platform-tests/css/css-syntax/charset/support/at-charset-bogus.css: Added.

(@charset "bogus";):

web-platform-tests/css/css-syntax/charset/support/at-charset-utf16-ascii-only.css: Added.

(@charset "utf-16";):

web-platform-tests/css/css-syntax/charset/support/at-charset-utf16.css: Added.

(@charset "utf-16";):

web-platform-tests/css/css-syntax/charset/support/at-charset-utf16be.css: Added.

(@charset "utf-16be";):

web-platform-tests/css/css-syntax/charset/support/at-charset-windows-1250-in-utf16.css: Added.
web-platform-tests/css/css-syntax/charset/support/at-charset-windows-1250-in-utf16be.css: Added.
web-platform-tests/css/css-syntax/charset/support/at-charset-windows-1250.css: Added.

(@charset "windows-1250";):

web-platform-tests/css/css-syntax/charset/support/bomless-utf16.css: Added.
web-platform-tests/css/css-syntax/charset/support/bomless-utf16be.css: Added.
web-platform-tests/css/css-syntax/charset/support/http-bogus-at-charset-windows-1250.bogus.css: Added.

(@charset "windows-1250";):

web-platform-tests/css/css-syntax/charset/support/http-bogus-at-charset-windows-1250.bogus.css.headers: Added.
web-platform-tests/css/css-syntax/charset/support/http-bogus.bogus.css: Added.

(#È):

web-platform-tests/css/css-syntax/charset/support/http-bogus.bogus.css.headers: Added.
web-platform-tests/css/css-syntax/charset/support/http-windows-1250-at-charset-windows-1253.windows1250.css: Added.

(@charset "windows-1253";):

web-platform-tests/css/css-syntax/charset/support/http-windows-1250-at-charset-windows-1253.windows1250.css.headers: Added.
web-platform-tests/css/css-syntax/charset/support/no-decl-ascii-only.css: Added.

(#foo):

web-platform-tests/css/css-syntax/charset/support/no-decl.css: Added.

(#È):

web-platform-tests/css/css-syntax/charset/support/utf8-bom.css: Added.

(#È):

web-platform-tests/css/css-syntax/charset/support/w3c-import.log: Added.
web-platform-tests/css/css-syntax/charset/w3c-import.log: Added.
web-platform-tests/css/css-syntax/charset/xml-stylesheet-page-windows-1251-charset-attribute-windows-1250-expected.txt: Added.
web-platform-tests/css/css-syntax/charset/xml-stylesheet-page-windows-1251-charset-attribute-windows-1250.xhtml: Added.
web-platform-tests/css/css-syntax/decimal-points-in-numbers-expected.txt: Added.
web-platform-tests/css/css-syntax/decimal-points-in-numbers.html: Added.
web-platform-tests/css/css-syntax/declarations-trim-whitespace-expected.txt: Added.
web-platform-tests/css/css-syntax/declarations-trim-whitespace.html: Added.
web-platform-tests/css/css-syntax/escaped-eof-expected.txt: Added.
web-platform-tests/css/css-syntax/escaped-eof.html: Added.
web-platform-tests/css/css-syntax/ident-three-code-points-expected.txt: Added.
web-platform-tests/css/css-syntax/ident-three-code-points.html: Added.
web-platform-tests/css/css-syntax/inclusive-ranges-expected.txt: Added.
web-platform-tests/css/css-syntax/inclusive-ranges.html: Added.
web-platform-tests/css/css-syntax/input-preprocessing-expected.txt: Added.
web-platform-tests/css/css-syntax/input-preprocessing.html: Added.
web-platform-tests/css/css-syntax/serialize-consecutive-tokens-expected.txt: Added.
web-platform-tests/css/css-syntax/serialize-consecutive-tokens.html: Added.
web-platform-tests/css/css-syntax/unclosed-constructs-expected.txt: Added.
web-platform-tests/css/css-syntax/unclosed-constructs.html: Added.
web-platform-tests/css/css-syntax/unclosed-url-at-eof-expected.txt: Added.
web-platform-tests/css/css-syntax/unclosed-url-at-eof.html: Added.
web-platform-tests/css/css-syntax/unicode-range-selector-expected.txt: Added.
web-platform-tests/css/css-syntax/unicode-range-selector.html: Added.
web-platform-tests/css/css-syntax/urange-parsing-expected.txt: Added.
web-platform-tests/css/css-syntax/urange-parsing.html: Added.
web-platform-tests/css/css-syntax/url-whitespace-consumption-expected.txt: Added.
web-platform-tests/css/css-syntax/url-whitespace-consumption.html: Added.
web-platform-tests/css/css-syntax/w3c-import.log: Added.
web-platform-tests/css/css-syntax/whitespace-expected.txt: Added.
web-platform-tests/css/css-syntax/whitespace.html: Added.

7:50 AM Changeset in webkit [251634] by Simon Fraser

25 edits
3 adds in trunk/LayoutTests/imported/w3c

Update css/support directory in WPT
https://bugs.webkit.org/show_bug.cgi?id=203452

Reviewed by Antti Koivisto.

Various WPT are relying on new functionality in css/support (e.g. test_shorthand_value).
In addition, the behavior for testing computed style of properties which don't exist has changed,
causing changes in test output.

resources/import-expectations.json:
web-platform-tests/css/css-animations/parsing/animation-computed-expected.txt:
web-platform-tests/css/css-animations/parsing/animation-shorthand-expected.txt:
web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt:
web-platform-tests/css/css-images/inheritance-expected.txt:
web-platform-tests/css/css-images/parsing/image-orientation-computed-expected.txt:
web-platform-tests/css/css-images/parsing/image-rendering-computed-expected.txt:
web-platform-tests/css/css-images/parsing/object-fit-computed-expected.txt:
web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt:
web-platform-tests/css/css-overflow/inheritance-expected.txt:
web-platform-tests/css/css-overflow/parsing/overflow-computed-expected.txt:
web-platform-tests/css/css-overscroll-behavior/inheritance-expected.txt:
web-platform-tests/css/css-shapes/parsing/shape-outside-computed-expected.txt:
web-platform-tests/css/css-text/inheritance-expected.txt:
web-platform-tests/css/css-transitions/parsing/transition-shorthand-expected.txt:
web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt:
web-platform-tests/css/css-values/clamp-length-computed-expected.txt:
web-platform-tests/css/css-values/minmax-length-computed-expected.txt:
web-platform-tests/css/css-values/minmax-length-percent-computed-expected.txt:
web-platform-tests/css/cssom-view/inheritance-expected.txt:
web-platform-tests/css/support/computed-testcommon.js:

(test_computed_value):

web-platform-tests/css/support/inheritance-testcommon.js:

(assert_initial):

web-platform-tests/css/support/parsing-testcommon.js:
web-platform-tests/css/support/w3c-import.log:

5:53 AM Changeset in webkit [251633] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC][IFC] Completely collapsed runs should not have advance width
https://bugs.webkit.org/show_bug.cgi?id=203457
<rdar://problem/56645024>

Reviewed by Antti Koivisto.

Let's reset the advance width for completely collapsed runs (any a collapsible space immediatelly following another
collapsible space).
https://drafts.csswg.org/css-text-3/#white-space-phase-1

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineDescentNeedsCollapsing const):

layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::Run::canBeExtended const):
(WebCore::Layout::Line::isVisuallyEmpty const):
(WebCore::Layout::Line::removeTrailingTrimmableContent):
(WebCore::Layout::Line::trailingTrimmableWidth const):
(WebCore::Layout::Line::appendTextContent):

layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Run::expand):
(WebCore::Layout::Line::Run::isCollapsedToZeroAdvanceWidth const):
(WebCore::Layout::Line::Run::setCollapsesToZeroAdvanceWidth):
(WebCore::Layout::Line::Run::isVisuallyEmpty const): Deleted.
(WebCore::Layout::Line::Run::setVisuallyIsEmpty): Deleted.

5:47 AM Changeset in webkit [251632] by Antti Koivisto

4 edits in trunk/Source/WebCore

Build cascade in PropertyCascade constructor
https://bugs.webkit.org/show_bug.cgi?id=203455

Reviewed by Zalan Bujtas.

Instead of calling addNormalMatches/addImportantMatches several times, clients now simply
pass the desired cascade levels to the constructor.

css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):

style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::PropertyCascade):
(WebCore::Style::PropertyCascade::addMatch):
(WebCore::Style::PropertyCascade::addNormalMatches):

Return if there were any important matches so we may skip the step later.

(WebCore::Style::PropertyCascade::addImportantMatches):
(WebCore::Style::PropertyCascade::applyDeferredProperties):
(WebCore::Style::PropertyCascade::applyPropertiesImpl):
(WebCore::Style::PropertyCascade::propertyCascadeForRollback):
(WebCore::Style::PropertyCascade::applyProperty):
(WebCore::Style::PropertyCascade::Property::apply): Deleted.

Also make this PropertyCascade::applyProperty

style/PropertyCascade.h:

12:31 AM Changeset in webkit [251631] by yurys@chromium.org

1 edit
1 copy
1 delete in trunk/LayoutTests

[GTK] LayoutTests/inspector tests timeout
https://bugs.webkit.org/show_bug.cgi?id=147518

Unreviewed. Added missing generic test expectation (it was accidentally placed under platform/mac).

inspector/model/remote-object-dom-expected.txt: Renamed from LayoutTests/platform/mac/inspector/model/remote-object-dom-expected.txt.

12:12 AM Changeset in webkit [251630] by commit-queue@webkit.org

63 edits
11 copies
5 adds
2 deletes in trunk

Put OffscreenCanvas behind a build flag
https://bugs.webkit.org/show_bug.cgi?id=203146

Patch by Chris Lord <Chris Lord> on 2019-10-26
Reviewed by Ryosuke Niwa.

Put OffscreenCanvas behind a build flag and enable building with
experimental features on GTK and WPE.

Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsWPE.cmake:
Source/cmake/WebKitFeatures.cmake:

LayoutTests/imported/w3c:

OffscreenCanvas is disabled by default, adjust expectations accordingly.

web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt:
web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt:
web-platform-tests/html/dom/idlharness.https-expected.txt:
web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt:

PerformanceTests:

StitchMarker/wtf/FeatureDefines.h:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. No behavior changes.

Configurations/FeatureDefines.xcconfig:
bindings/js/JSEventTargetCustom.cpp:
bindings/js/JSOffscreenCanvasRenderingContext2DCustom.cpp:
dom/EventTargetFactory.in:
html/ImageBitmap.idl:
html/OffscreenCanvas.cpp:
html/OffscreenCanvas.h:
html/OffscreenCanvas.idl:
html/canvas/CanvasRenderingContext.cpp:
html/canvas/ImageBitmapRenderingContext.idl:
html/canvas/OffscreenCanvasRenderingContext2D.cpp:
html/canvas/OffscreenCanvasRenderingContext2D.h:
html/canvas/OffscreenCanvasRenderingContext2D.idl:
html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::canvas):

html/canvas/WebGLRenderingContextBase.h:
html/canvas/WebGLRenderingContextBase.idl:
inspector/agents/InspectorCanvasAgent.cpp:
page/PageConsoleClient.cpp:

(WebCore::canvasRenderingContext):

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setImageBitmapEnabled):
(WebCore::RuntimeEnabledFeatures::imageBitmapEnabled const):
(WebCore::RuntimeEnabledFeatures::setOffscreenCanvasEnabled):
(WebCore::RuntimeEnabledFeatures::offscreenCanvasEnabled const):

page/WindowOrWorkerGlobalScope.idl:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Split the ImageBitmapOffscreenCanvas setting into two separate
settings so OffscreenCanvas can be disabled at build time.

Configurations/FeatureDefines.xcconfig:
Shared/WebPreferences.yaml:
Shared/WebPreferencesDefaultValues.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::WebInspectorUI):

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Put OffscreenCanvas behind a build flag and enable the runtime setting
when running tests on platforms where it's built (GTK and WPE).

Scripts/webkitperl/FeatureList.pm:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setOffscreenCanvasEnabled):

WebKitTestRunner/InjectedBundle/TestRunner.h:

Websites/webkit.org:

Update to reflect split ImageBitmapOffscreenCanvas settings.

experimental-features.html:

LayoutTests:

OffscreenCanvas is disabled by default except on GTK/WPE. Adjust test
expectations accordingly.

TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt.
platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt.
platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt.
platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt.
platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt.
platform/gtk/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt.
platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/ios/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/wpe/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt: Renamed from LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt.
platform/wpe/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/transfer-errors.window-expected.txt.

Oct 25, 2019:

11:45 PM Changeset in webkit [251629] by yurys@chromium.org

1 edit
1 delete in trunk/LayoutTests

Web Inspector: remove custom expectations from platform/gtk/inspector-protocol
https://bugs.webkit.org/show_bug.cgi?id=203453

Unreviewed, test expectations cleanup.

platform/gtk/inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local-expected.txt: Removed.
platform/gtk/inspector-protocol/debugger/setBreakpoint-dfg-expected.txt: Removed.
platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Removed.

Removed platform/gtk/inspector-protocol altogether as there is no LayoutTests/inspector-protocol
folder any more. Corresponding tests were either deleted or moved to LayoutTests/inspector a while ago.

11:12 PM Changeset in webkit [251628] by yurys@chromium.org

6 edits in trunk/LayoutTests

[GTK] Layout test inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139359

Reviewed by Devin Rousso.

Renable the test on all platforms. With the current implementation of inspector client in tests
response to Debugger.resume is dispatched in the front-end synchronously and the front-end would
call InspectoTest.log when inspected script execution is not yet resumed.

inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt:
inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:

9:53 PM Changeset in webkit [251627] by Chris Dumez

2 edits in trunk/Source/WebKit

REGRESSION(r251599): Crash in MobileSafari tests (ASSERTION FAILED: m_pendingRequestToSuspendID)
https://bugs.webkit.org/show_bug.cgi?id=203437
<rdar://problem/56633399>

Reviewed by Geoffrey Garen.

UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::updateAssertionIfNeeded):
Start the timer before sending the PrepareToSuspend IPC. The reason is that if the process has been
terminated, the completion handler may run synchronously and cancel the request to suspend / stop
the timer. Therefore, re-starting the timer after would be a mistake.

7:38 PM Changeset in webkit [251626] by eric.carlson@apple.com

10 edits in trunk

Support for callbacks for manifest events
https://bugs.webkit.org/show_bug.cgi?id=202101
<rdar://problem/54277362>

Reviewed by Jer Noble.
Source/WebCore:

Use AVPlayerItemMetadataCollector to get manifest based time metadata. Use
AVPlayerItemMetadataOutput to get time metadata instead of listening for a "timedMetadata"
KVO on AVPlayer.

No new tests, existing test updated.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::globalMetadataProcessingQueue):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::metadataType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataGroupDidArrive):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(WebCore::itemKVOProperties):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFMovieObserver metadataOutput:didOutputTimedMetadataGroups:fromPlayerItemTrack:]):
(-[WebCoreAVFMovieObserver metadataCollector:didCollectDateRangeMetadataGroups:indexesOfNewGroups:indexesOfModifiedGroups:]):

Source/WebCore/PAL:

pal/cocoa/AVFoundationSoftLink.h:
pal/cocoa/AVFoundationSoftLink.mm:

LayoutTests:

http/tests/media/resources/hls/metadata/prog_index.m3u8:
http/tests/media/track-in-band-hls-metadata-expected.txt:
http/tests/media/track-in-band-hls-metadata.html:

7:36 PM Changeset in webkit [251625] by Wenson Hsieh

6 edits in trunk/LayoutTests

[iOS WK2] fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196298
<rdar://problem/49337021>

Reviewed by Simon Fraser.

fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta-expected.txt:
fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta.html:

Adjust this flaky layout test so that it's more robust:

Begin the test after the first visible content rect update following the load event.
Add an initial step to the test to sanity check the viewport dimensions when setting the minimum effective

device width to 0.

At each step, instead of waiting for the next visible content rect update and presentation update, simply

wait for the window width to reach the expected value.

From local testing, this brings the test failure rate down from ~25 failures in 1000 runs to 0 failures.

platform/ios-simulator-wk2/TestExpectations:
platform/ios/TestExpectations:

Remove the failing test expectations.

platform/ipad/fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta-expected.txt:

Adjust the text expectations so that they contain an entry for setMinimumEffectiveWidth(0) as well.

6:57 PM Changeset in webkit [251624] by Devin Rousso

5 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: un-experimentalize showing rule icons
https://bugs.webkit.org/show_bug.cgi?id=203308

Reviewed by Joseph Pecoraro.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Base/Setting.js:
UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._renderSelector):

6:48 PM Changeset in webkit [251623] by aestes@apple.com

15 edits
2 copies
1 add in trunk/Source

[Quick Look] Move the QLPreviewConverter delegate into PreviewConverter and vend a C++ client interface
https://bugs.webkit.org/show_bug.cgi?id=203396

Reviewed by Alex Christensen.

Source/WebCore:

PreviewConverter existed as a thin wrapper around QLPreviewConverter for use by
LegacyPreviewLoader and Quick Look NSData loading in WebKitLegacy. This patch makes two
changes to this arrangement:

The QLPreviewConverter delegate and the bulk of the conversion state machine was moved

into PreviewConverter, which now vends a C++ client interface. LegacyPreviewLoader is now a
client of its PreviewConverter, retaining the responsiility of interacting with the
ResourceLoader and LegacyPreviewLoaderClient.

The Quick Look NSData loading code for WebKitLegacy now uses QLPreviewConverter API

directly rather than creating a PreviewConverter. This code path does not require a delegate
nor any of the other logic in PreviewConverter.

This change also organizes PreviewConverter into a cross-platform .cpp file and an
iOS-specific .mm file for the direct usage of QLPreviewConverter API. LegacyPreviewConverter
was also organized such that it can be changed from .mm to .cpp in a future patch.

No change in behavior. Covered by existing API and layout tests.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setPreviewConverter):

loader/DocumentLoader.h: Changed m_previewConverter from std::unique_ptr to RefPtr.

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): Used makeUnique directly instead of
LegacyPreviewLoader::create().

loader/ios/LegacyPreviewLoader.h: Privately inherited from PreviewConverterClient and

PreviewConverterProvider and migrated WebPreviewLoader ivars to member variables.

loader/ios/LegacyPreviewLoader.mm:

(WebCore::makeClient):
(WebCore::LegacyPreviewLoader::didReceiveBuffer):
(WebCore::LegacyPreviewLoader::didFinishLoading):
(WebCore::LegacyPreviewLoader::didFail):
(WebCore::LegacyPreviewLoader::previewConverterDidStartConverting):
(WebCore::LegacyPreviewLoader::previewConverterDidReceiveData):
(WebCore::LegacyPreviewLoader::previewConverterDidFinishConverting):
(WebCore::LegacyPreviewLoader::previewConverterDidFailUpdating):
(WebCore::LegacyPreviewLoader::previewConverterDidFailConverting):
(WebCore::LegacyPreviewLoader::providePasswordForPreviewConverter):
(WebCore::LegacyPreviewLoader::provideMainResourceForPreviewConverter):
(WebCore::LegacyPreviewLoader::LegacyPreviewLoader):
(WebCore::LegacyPreviewLoader::didReceiveData):
(WebCore::LegacyPreviewLoader::didReceiveResponse):
(testingClient): Deleted.
(emptyClient): Deleted.
(-[WebPreviewLoader initWithResourceLoader:resourceResponse:]): Deleted.
(-[WebPreviewLoader appendDataArray:]): Deleted.
(-[WebPreviewLoader finishedAppending]): Deleted.
(-[WebPreviewLoader failed]): Deleted.
(-[WebPreviewLoader _loadPreviewIfNeeded]): Deleted.
(-[WebPreviewLoader connection:didReceiveData:lengthReceived:]): Deleted.
(-[WebPreviewLoader connectionDidFinishLoading:]): Deleted.
(isQuickLookPasswordError): Deleted.
(-[WebPreviewLoader connection:didFailWithError:]): Deleted.
(WebCore::LegacyPreviewLoader::~LegacyPreviewLoader): Deleted.
(WebCore::LegacyPreviewLoader::create): Deleted.

platform/PreviewConverter.cpp: Added.

(WebCore::PreviewConverter::supportsMIMEType):
(WebCore::PreviewConverter::previewResponse const):
(WebCore::PreviewConverter::previewError const):
(WebCore::PreviewConverter::previewData const):
(WebCore::PreviewConverter::updateMainResource):
(WebCore::PreviewConverter::appendFromBuffer):
(WebCore::PreviewConverter::finishUpdating):
(WebCore::PreviewConverter::failedUpdating):
(WebCore::PreviewConverter::hasClient const):
(WebCore::PreviewConverter::addClient):
(WebCore::PreviewConverter::removeClient):
(WebCore::sharedPasswordForTesting):
(WebCore::PreviewConverter::passwordForTesting):
(WebCore::PreviewConverter::setPasswordForTesting):
(WebCore::PreviewConverter::iterateClients):
(WebCore::PreviewConverter::didAddClient):
(WebCore::PreviewConverter::didFailConvertingWithError):
(WebCore::PreviewConverter::didFailUpdating):
(WebCore::PreviewConverter::replayToClient):
(WebCore::PreviewConverter::delegateDidReceiveData):
(WebCore::PreviewConverter::delegateDidFinishLoading):
(WebCore::PreviewConverter::delegateDidFailWithError):

platform/PreviewConverter.h:

(WebCore::PreviewConverter::PreviewConverter): Deleted.
(WebCore::PreviewConverter::platformConverter const): Deleted.

platform/PreviewConverterClient.h: Copied from Source/WebCore/platform/PreviewConverter.h.
platform/PreviewConverterProvider.h: Copied from Source/WebCore/platform/PreviewConverter.h.
platform/ios/PreviewConverterIOS.mm:

(-[WebPreviewConverterDelegate initWithDelegate:]):
(-[WebPreviewConverterDelegate connection:didReceiveData:lengthReceived:]):
(-[WebPreviewConverterDelegate connectionDidFinishLoading:]):
(-[WebPreviewConverterDelegate connection:didFailWithError:]):
(WebCore::PreviewConverter::PreviewConverter):
(WebCore::PreviewConverter::platformSupportedMIMETypes):
(WebCore::PreviewConverter::safeRequest const):
(WebCore::PreviewConverter::platformPreviewResponse const):
(WebCore::PreviewConverter::platformAppend):
(WebCore::PreviewConverter::platformFinishedAppending):
(WebCore::PreviewConverter::platformFailedAppending):
(WebCore::PreviewConverter::isPlatformPasswordError const):
(WebCore::optionsWithPassword):
(WebCore::PreviewConverter::platformUnlockWithPassword):
(WebCore::PreviewConverter::supportsMIMEType): Deleted.
(WebCore::PreviewConverter::previewRequest const): Deleted.
(WebCore::PreviewConverter::previewResponse const): Deleted.

platform/ios/QuickLook.mm:

(WebCore::registerQLPreviewConverterIfNeeded): Used QLPreviewConverter directly.

Source/WebCore/PAL:

pal/spi/ios/QuickLookSPI.h:

Source/WTF:

wtf/FeatureDefines.h: Defined ENABLE_PREVIEW_CONVERTER.

6:40 PM Changeset in webkit [251622] by Wenson Hsieh

2 edits in trunk/LayoutTests

Adjust a layout test after r251522
https://bugs.webkit.org/show_bug.cgi?id=202663

Reviewed by Simon Fraser.

Fix relative file paths when including ui-helper.js and basic-gestures.js.

fast/events/touch/ios/long-press-on-link.html:

6:21 PM Changeset in webkit [251621] by yurys@chromium.org

4 edits in trunk/LayoutTests

[GTK] LayoutTests/inspector tests timeout
https://bugs.webkit.org/show_bug.cgi?id=147518

Reviewed by Devin Rousso.

Renable inspector/model tests on GTK.

TestExpectations: There are two real issues that actually happen on all platforms,

filed separate bugs for each of them.

platform/gtk/TestExpectations:
platform/mac/TestExpectations:

6:10 PM Changeset in webkit [251620] by yurys@chromium.org

14 edits
6 adds in trunk

Web Inspector: support emulateUserGesture parameter in Runtime.callFunctionOn
https://bugs.webkit.org/show_bug.cgi?id=200262

Reviewed by Devin Rousso.

Source/JavaScriptCore:

inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::callFunctionOn):

inspector/agents/InspectorRuntimeAgent.h:
inspector/protocol/Runtime.json:

Source/WebCore:

Support emulateUserGesture in Runtime.callFunctionOn

Tests: inspector/runtime/callFunctionOn-emulateUserGesture-userIsInteracting.html

inspector/runtime/callFunctionOn-emulateUserGesture.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
inspector/agents/page/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::evaluateOnCallFrame):

inspector/agents/page/PageRuntimeAgent.cpp:

(WebCore::asBool):
(WebCore::PageRuntimeAgent::evaluate):
(WebCore::PageRuntimeAgent::callFunctionOn):

inspector/agents/page/PageRuntimeAgent.h:
inspector/agents/page/UserGestureEmulationScope.cpp: Added.

(WebCore::UserGestureEmulationScope::UserGestureEmulationScope): Extracted logic
of overriding user gesture into the scope object to share it between evaluate and
callFunctionOn as well as PageDebuggerAgent::evaluateOnCallFrame.
(WebCore::UserGestureEmulationScope::~UserGestureEmulationScope):

inspector/agents/page/UserGestureEmulationScope.h: Added.

LayoutTests:

Supported emulateUserGesture in Runtime.callFunctionOn protocol command.

TestExpectations:
inspector/runtime/callFunctionOn-emulateUserGesture-expected.txt: Added.
inspector/runtime/callFunctionOn-emulateUserGesture-userIsInteracting-expected.txt: Added.
inspector/runtime/callFunctionOn-emulateUserGesture-userIsInteracting.html: Added.
inspector/runtime/callFunctionOn-emulateUserGesture.html: Added.
platform/wk2/TestExpectations:

Only enable the new test on WK2, as the user interaction state is only supported by WK2.

6:03 PM Changeset in webkit [251619] by Megan Gardner

2 edits in trunk/LayoutTests

Fix autoscroll test specifically for iPad
https://bugs.webkit.org/show_bug.cgi?id=203392
<rdar://problem/51712479>

Reviewed by Wenson Hsieh.

On iPad, we only have one gesture that will set off the magnified caret gesture.
If we touch in the same point as where we touched to focus the element, in the
test environment, nothing resets the positionInformation, which then erroneously
thinks that there is no focused element, which then blocks the caret gesture from
starting. The easiest fix for this is to not have the point to focus the element
be the same point that we use to start the caret gesture.

fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html:

5:53 PM Changeset in webkit [251618] by sihui_liu@apple.com

3 edits in trunk/LayoutTests

REGRESSION (r251261?): Flaky Test: inspector/runtime/getProperties.html
https://bugs.webkit.org/show_bug.cgi?id=203271
<rdar://problem/56557216>

Reviewed by Devin Rousso.

r251261 was reverted and the test has become not so flaky, but the previous flakiness showed us a potential bug
in the test: it is possible that the console message for unhandled rejected promise gets dispatched after
dumping the results. To make the test more robust, stop showing that message in console.

inspector/runtime/getProperties-expected.txt:
inspector/runtime/getProperties.html:

5:46 PM Changeset in webkit [251617] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Remove redundant LineLayout::LineInput c'tor
https://bugs.webkit.org/show_bug.cgi?id=203425
<rdar://problem/56624666>

Reviewed by Antti Koivisto.

Move the SkipAligment paramenter to the LineLayout from LineLayout::LineInput, because it's the property of the layout and not an input to the actual line.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):

layout/inlineformatting/InlineLineLayout.cpp:

(WebCore::Layout::LineLayout::LineInput::LineInput):
(WebCore::Layout::LineLayout::LineLayout):

layout/inlineformatting/InlineLineLayout.h:

5:37 PM Changeset in webkit [251616] by ddkilzer@apple.com

4 edits in trunk/Source/WebKit

Unused arguments in MESSAGE_CHECK_CONTEXTID() macros
<https://webkit.org/b/203389>
<rdar://problem/55935374>

Reviewed by Alex Christensen.

UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(#define MESSAGE_CHECK_CONTEXTID):

Rename macro argument from contextID to identifier and change contextIdto identifier in the body of the macro so that the argument is always used.

(WebKit::PlaybackSessionManagerProxy::setUpPlaybackControlsManagerWithID):
(WebKit::PlaybackSessionManagerProxy::currentTimeChanged):
(WebKit::PlaybackSessionManagerProxy::bufferedTimeChanged):
(WebKit::PlaybackSessionManagerProxy::seekableRangesVectorChanged):
(WebKit::PlaybackSessionManagerProxy::canPlayFastReverseChanged):
(WebKit::PlaybackSessionManagerProxy::audioMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionManagerProxy::legibleMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionManagerProxy::audioMediaSelectionIndexChanged):
(WebKit::PlaybackSessionManagerProxy::legibleMediaSelectionIndexChanged):
(WebKit::PlaybackSessionManagerProxy::externalPlaybackPropertiesChanged):
(WebKit::PlaybackSessionManagerProxy::wirelessVideoPlaybackDisabledChanged):
(WebKit::PlaybackSessionManagerProxy::mutedChanged):
(WebKit::PlaybackSessionManagerProxy::volumeChanged):
(WebKit::PlaybackSessionManagerProxy::durationChanged):
(WebKit::PlaybackSessionManagerProxy::playbackStartedTimeChanged):
(WebKit::PlaybackSessionManagerProxy::rateChanged):
(WebKit::PlaybackSessionManagerProxy::pictureInPictureSupportedChanged):
(WebKit::PlaybackSessionManagerProxy::pictureInPictureActiveChanged):
(WebKit::PlaybackSessionManagerProxy::handleControlledElementIDResponse const):

Change contextID to contextId to match local variable name now that MESSAGE_CHECK_CONTEXTID() doesn't paper over this typo for us.

UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(#define MESSAGE_CHECK_CONTEXTID):

Rename macro argument from contextID to identifier and change contextIdto identifier in the body of the macro so that the argument is always used.

UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(#define MESSAGE_CHECK_CONTEXTID):

Rename macro argument and variable in the body of the macro from id to identifier for consistency.

5:21 PM Changeset in webkit [251615] by pvollan@apple.com

6 edits in trunk/LayoutTests

REGRESSION: fast/css/paint-order.html and fast/css/paint-order-shadow.html are failing
https://bugs.webkit.org/show_bug.cgi?id=203313
<rdar://problem/52557916>

Reviewed by Alexey Proskuryakov.

Catalina introduced a regression, causing these tests to fail. This was not a regression related to the feature these
tests are testing, but a regression related to the rendering position and size of a specific glyph. Given this, the
tests are changed to take this into consideration, making them pass both on Catalina and previous versions of the OS.

fast/css/paint-order-expected.html:
fast/css/paint-order-shadow-expected.html:
fast/css/paint-order-shadow.html:
fast/css/paint-order.html:
platform/mac/TestExpectations:

5:16 PM Changeset in webkit [251614] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

macCatalyst: Build failures in projects that have both AppKit and WAK headers
https://bugs.webkit.org/show_bug.cgi?id=203429
<rdar://problem/56598370>

Reviewed by Sam Weinig.

platform/ios/wak/WAKAppKitStubs.h:

Slightly abuse the preprocessor to avoid errors due to redefining AppKit symbols.

5:00 PM Changeset in webkit [251613] by Jonathan Bedard

9 edits in trunk/Tools

Python 3: Add support in webkitpy.common.checkout
https://bugs.webkit.org/show_bug.cgi?id=201956

Reviewed by Dewei Zhu.

Scripts/test-webkitpy-python3: Add webkitpy.common.checkout.
Scripts/webkitpy/common/checkout/changelog.py: Import Python 3 compatible unicdoe.
Scripts/webkitpy/common/checkout/changelog_unittest.py: Import Python 3 compatible StringIO.
Scripts/webkitpy/common/checkout/checkout.py: Use Python 3 compatible reduce.

(Checkout._modified_files_matching_predicate): Convert iterators into lists before returning.
(Checkout.suggested_reviewers): Ditto.

Scripts/webkitpy/common/checkout/checkout_mock.py: Use full import paths.
Scripts/webkitpy/common/checkout/checkout_unittest.py: Use full import paths, convert

iterators into lists.

Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Use full import paths, use Python 3

compatible StringIO.

Scripts/webkitpy/common/config/committers.py:

(Contributor.hash): Committers need to be hashable to be inserted into a set.

5:00 PM Changeset in webkit [251612] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[iOS] Fix sandbox violations seen while running layout tests
https://bugs.webkit.org/show_bug.cgi?id=203419

Reviewed by Brent Fulgham.

Deny mach lookup to 'com.apple.logd' and 'com.apple.logd.events' and suppress logs, since these are
believed to be unneeded in the WebContent process. Allow sysctl write to 'vm.footprint_suspend'.
Deny mach lookup to 'com.apple.system.notification_center' and suppress logs, since allowing this
is not believed to be needed in the WebContent process.

No new tests, covered by existing tests.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

4:22 PM Changeset in webkit [251611] by Antti Koivisto

10 edits in trunk/Source/WebCore

Move more cascade related code from StyleResolver to PropertyCascade
https://bugs.webkit.org/show_bug.cgi?id=203409

Reviewed by Zalan Bujtas.

Move a bunch of StyleResolver member functions to PropertyCascade.
Make ApplyCascadedPropertyState part of the PropertyCascade internal state.
Pass around a reference to the PropertyCascade itself instead of the state object The state contained PropertyCascade member already so this is equivalent but simpler.

css/CSSVariableReferenceValue.cpp:

(WebCore::resolveVariableFallback):
(WebCore::resolveVariableReference):
(WebCore::resolveTokenRange):
(WebCore::CSSVariableReferenceValue::resolveVariableReferences const):

css/CSSVariableReferenceValue.h:
css/ElementRuleCollector.h:
css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::resolvedVariableValue const):
(WebCore::StyleResolver::cascadedPropertiesForRollback): Deleted.
(WebCore::StyleResolver::applyCascadedCustomProperty): Deleted.
(WebCore::StyleResolver::applyCascadedProperties): Deleted.
(WebCore::StyleResolver::applyCascadedPropertiesImpl): Deleted.

These become PropertyCascade members.

css/StyleResolver.h:

(WebCore::StyleResolver::State::authorRollback const): Deleted.
(WebCore::StyleResolver::State::userRollback const): Deleted.
(WebCore::StyleResolver::State::setAuthorRollback): Deleted.
(WebCore::StyleResolver::State::setUserRollback): Deleted.

Rollbacks are now owned by PropertyCascade.

css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseValueWithVariableReferences):

css/parser/CSSParser.h:
style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::PropertyCascade):
(WebCore::Style::PropertyCascade::set):
(WebCore::Style::PropertyCascade::addNormalMatches):
(WebCore::Style::PropertyCascade::addImportantMatches):
(WebCore::Style::PropertyCascade::applyDeferredProperties):
(WebCore::Style::PropertyCascade::applyProperties):
(WebCore::Style::PropertyCascade::applyPropertiesImpl):
(WebCore::Style::PropertyCascade::applyCustomProperties):
(WebCore::Style::PropertyCascade::applyCustomProperty):
(WebCore::Style::PropertyCascade::propertyCascadeForRollback):
(WebCore::Style::PropertyCascade::Property::apply):

style/PropertyCascade.h:

(WebCore::Style::PropertyCascade::styleResolver):
(WebCore::Style::PropertyCascade::hasAppliedProperty const):
(WebCore::Style::PropertyCascade::customProperties): Deleted.

4:16 PM Changeset in webkit [251610] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Add support for no-wrap
https://bugs.webkit.org/show_bug.cgi?id=203424
<rdar://problem/56624136>

Reviewed by Antti Koivisto.

Consult the white-space style property about line wrapping when the content overflows and can't be split.

layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::isContentWrappingAllowed):
(WebCore::Layout::LineBreaker::breakingContextForInlineContent):
(WebCore::Layout::LineBreaker::wordBreakingBehavior const):

layout/inlineformatting/InlineLineBreaker.h:

4:12 PM Changeset in webkit [251609] by Truitt Savell

2 edits in trunk/LayoutTests

Adding expectations for editing/pasteboard/smart-paste-paragraph-003.html
https://bugs.webkit.org/show_bug.cgi?id=203264

Unreviewed test gardening

platform/ios-wk2/TestExpectations:

4:00 PM Changeset in webkit [251608] by Jonathan Bedard

5 edits in trunk/Tools

Python 3: Add support in webkitpy.xcode
https://bugs.webkit.org/show_bug.cgi?id=203417

Reviewed by Dewei Zhu.

Scripts/test-webkitpy-python3: Add webkitpy.xcode.
Scripts/webkitpy/common/system/filesystem_mock.py:

(ReadableBinaryFileObject.seek): Add seek function to mirror actual binary file
behavior and support plistlib.

Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDeviceManager._disambiguate_device_type): Use values instead of itervalues.
(SimulatedDeviceManager._get_device_identifier_for_type): Use items instead of iteritems.
(SimulatedDeviceManager.device_count_for_type): Use values instead of itervalues.

Scripts/webkitpy/xcode/simulated_device_unittest.py:

(SimulatedDeviceTest.mock_host_for_simctl): Use items instead of iteritems.
(change_state_to): Explicitly use bytes to edit a binary file.

3:41 PM Changeset in webkit [251607] by Dewei Zhu

4 edits in trunk/Websites/perf.webkit.org

Add SSL support for peformance dashboard database connection.
https://bugs.webkit.org/show_bug.cgi?id=203426

Reviewed by Ryosuke Niwa.

Performance dashboard should allow connecting Postgres database with SSL.

public/include/db.php: Add SSL configuration to connection string if specified.
tools/js/database.js: Add SSL configuration to connection string if specified.

(Database.prototype._prepareSSLConfig):
(Database.prototype.connect):

unit-tests/checkconfig.js: Added unit tests for optional ssl fields.

3:37 PM Changeset in webkit [251606] by yurys@chromium.org

2 edits in trunk/LayoutTests

inspector/heap/getRemoteObject.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=156077
<rdar://problem/25469998>

Unreviewed test gardening. Skip the test on GTK in addition to Mac WK2 as it's
now failing and crashing.

platform/gtk/TestExpectations:

3:17 PM Changeset in webkit [251605] by rniwa@webkit.org

11 edits
4 deletes in trunk

Unreviewed, rolling out r251322.
https://bugs.webkit.org/show_bug.cgi?id=203430

Causing more test failures after the rollout of resize event
patch (Requested by rniwa on #webkit).

Reverted changeset:

"Integrate media query evaluation into HTML5 event loop"
https://bugs.webkit.org/show_bug.cgi?id=203134
https://trac.webkit.org/changeset/251322

Patch by Commit Queue <commit-queue@webkit.org> on 2019-10-25

3:07 PM Changeset in webkit [251604] by aakash_jain@apple.com

2 edits in trunk/Tools

[EWS] Status page should show compiler ERRORS
https://bugs.webkit.org/show_bug.cgi?id=203418

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/steps.py:

(BuildLogLineObserver): Class for Analyzing build logs and extracting error logs.
(CompileWebKit.start): Initialize the log observer.
(CompileWebKit):
(CompileWebKit.errorReceived): Add the error to the errors log.

2:44 PM Changeset in webkit [251603] by youenn@apple.com

4 edits in trunk/Source/WebCore

Introduce AudioTrackPrivateMediaStreamCocoa::clear()
https://bugs.webkit.org/show_bug.cgi?id=203369
<rdar://problem/49017262>

Reviewed by Jer Noble.

Introduce the clear method to make sure the AudioTrackPrivteMediaStreamCocoa is in a clean state.
This will help further simplifications.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):

platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:

(WebCore::AudioTrackPrivateMediaStreamCocoa::~AudioTrackPrivateMediaStreamCocoa):
(WebCore::AudioTrackPrivateMediaStreamCocoa::clear):

platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.h:

2:28 PM Changeset in webkit [251602] by Matt Lewis

32 edits
2 deletes in trunk

Rolling out r251579,r251162,r251512,r251500, and r251498 for build failures
and test failures

Unreviewed rollout.

Source/WebCore:

Modules/webauthn/AuthenticatorCoordinator.cpp:
Modules/webauthn/WebAuthenticationConstants.h:
testing/MockWebAuthenticationConfiguration.h:

(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::decode):

testing/MockWebAuthenticationConfiguration.idl:

Source/WebKit:

Platform/spi/Cocoa/NearFieldSPI.h:
UIProcess/API/APIWebAuthenticationPanel.cpp:

(API::WebAuthenticationPanel::create):
(API::WebAuthenticationPanel::WebAuthenticationPanel):

UIProcess/API/APIWebAuthenticationPanel.h:
UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(-[_WKWebAuthenticationPanel relyingPartyID]):
(wkWebAuthenticationTransport): Deleted.
(-[_WKWebAuthenticationPanel transports]): Deleted.
(wkWebAuthenticationType): Deleted.
(-[_WKWebAuthenticationPanel type]): Deleted.

UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::WebCore::collectTransports):
(WebKit::AuthenticatorManager::handleRequest):
(WebKit::AuthenticatorManager::respondReceived):
(WebKit::AuthenticatorManager::respondReceivedInternal):
(WebKit::AuthenticatorManager::startDiscovery):
(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::runPanel):
(WebKit::AuthenticatorManager::startRequest):
(WebKit::AuthenticatorManager::invokePendingCompletionHandler):
(WebKit::WebCore::getClientDataType): Deleted.
(WebKit::AuthenticatorManager::serviceStatusUpdated): Deleted.
(WebKit::AuthenticatorManager::filterTransports const): Deleted.
(WebKit::AuthenticatorManager::getTransports const): Deleted.
(WebKit::AuthenticatorManager::restartDiscovery): Deleted.

UIProcess/WebAuthentication/AuthenticatorManager.h:

(WebKit::AuthenticatorManager::respondReceivedInternal): Deleted.

UIProcess/WebAuthentication/AuthenticatorTransportService.cpp:

(WebKit::AuthenticatorTransportService::startDiscovery):
(WebKit::AuthenticatorTransportService::restartDiscovery): Deleted.

UIProcess/WebAuthentication/AuthenticatorTransportService.h:

(WebKit::AuthenticatorTransportService::restartDiscoveryInternal): Deleted.

UIProcess/WebAuthentication/Cocoa/NfcConnection.h:
UIProcess/WebAuthentication/Cocoa/NfcConnection.mm:

(WebKit::NfcConnection::NfcConnection):
(WebKit::NfcConnection::~NfcConnection):
(WebKit::NfcConnection::didDetectTags const):
(WebKit::NfcConnection::create): Deleted.
(WebKit::NfcConnection::stop const): Deleted.
(WebKit::NfcConnection::didDetectTags): Deleted.
(WebKit::NfcConnection::restartPolling): Deleted.
(WebKit::NfcConnection::startPolling): Deleted.

UIProcess/WebAuthentication/Cocoa/NfcService.h:
UIProcess/WebAuthentication/Cocoa/NfcService.mm:

(WebKit::NfcService::NfcService):
(WebKit::NfcService::didConnectTag):
(WebKit::NfcService::setDriver):
(WebKit::NfcService::platformStartDiscovery):
(WebKit::NfcService::isAvailable): Deleted.
(WebKit::NfcService::didDetectMultipleTags const): Deleted.
(WebKit::NfcService::setConnection): Deleted.
(WebKit::NfcService::restartDiscoveryInternal): Deleted.

UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:

(WebKit::MockAuthenticatorManager::filterTransports const): Deleted.

UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.h:
UIProcess/WebAuthentication/Mock/MockNfcService.h:
UIProcess/WebAuthentication/Mock/MockNfcService.mm:

(-[WKMockNFTag initWithNFTag:]):
(-[WKMockNFTag dealloc]):
(-[WKMockNFTag initWithType:]):
(WebKit::MockNfcService::platformStartDiscovery):
(WebKit::MockNfcService::detectTags const):
(-[WKMockNFTag tagID]): Deleted.
(-[WKMockNFTag initWithType:tagID:]): Deleted.
(WebKit::MockNfcService::receiveStopPolling): Deleted.
(WebKit::MockNfcService::receiveStartPolling): Deleted.

UIProcess/WebAuthentication/fido/CtapNfcDriver.cpp:

(WebKit::CtapNfcDriver::CtapNfcDriver):

UIProcess/WebAuthentication/fido/CtapNfcDriver.h:
UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
(-[TestWebAuthenticationPanelUIDelegate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
(TestWebKitAPI::TEST):
(-[TestWebAuthenticationPanelUIDelegate panel]): Deleted.

TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc-multiple-tags.html: Removed.
TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid.html: Removed.

LayoutTests:

http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt:
http/wpt/webauthn/public-key-credential-create-success-nfc.https.html:

2:24 PM Changeset in webkit [251601] by Wenson Hsieh

6 edits in trunk

[iOS 13] fast/forms/ios/accessory-bar-navigation.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=203294
<rdar://problem/54520848>

Reviewed by Tim Horton.

Source/WebKit:

Add an SPI declaration (as well as an internal-SKD-only header import) for UIKeyboardPreferencesController.
See Tools/ChangeLog for more details.

Platform/spi/ios/UIKitSPI.h:

Tools:

This layout test consistently fails when it is the first test to involve bringing up the keyboard that is run in
a newly created iOS simulator. This is because a software keyboard is presented when focusing the input fields
in the test, and the test expectation (which depends on the visual viewport) requires a hardware keyboard.

WebKitTestRunner already simulates the hardware keyboard being attached using the call to GraphicsServices SPI
in TestController::platformResetStateToConsistentValues. However, this was effectively a no-op in the case where
the simulated device has never (in its lifetime, even through reboots) brought up an input view. This is because
-[UIKeyboardImpl hardwareKeyboardAvailabilityChanged] is never called, due to UIInputResponderController never
having an active instance with an input view set. As a result, the automaticMinimizationEnabled property of
UIKeyboardImpl is never set to its correct initial value (which depends on GSEventIsHardwareKeyboardAttached()).

This leads to UIKeyboardImpl not automatically minimizing itself even though the hardware keyboard is attached
(but only until the next time the keyboard is shown, after a hardware keyboard availability change notification
has been sent, which occurs between every layout test).

To work around this source of flakiness, we ensure that the keyboard preference for enabling automatic
minimization has been set to @YES by the time we attempt to simulate connecting the hardware keyboard by calling
GSEventIsHardwareKeyboardAttached. Note that the extra step of writing the value to com.apple.Preferences is
necessary because logic in TextInput.framework exists that periodically wipes out any cached values for keyboard
preferences on UIInputResponderController, and then attempts to regenerate them by reading defaults in
com.apple.Preferences. However, the same logic also fails to actually update com.apple.Preferences before
reading from it, which results in a software keyboard *very* rarely appearing again when running layout tests
that don't expect to observe a software keyboard.

WebKitTestRunner/ios/TestControllerIOS.mm:

LayoutTests:

Upstream an iOS 13 layout test result into open source. Note that fast/forms/ios is not currently run in open
automation at all, so this expectation was unused anyways.

fast/forms/ios/accessory-bar-navigation-expected.txt:

1:41 PM Changeset in webkit [251600] by rniwa@webkit.org

19 edits
4 adds in trunk

Add exclusion rules to text manipulation SPI
https://bugs.webkit.org/show_bug.cgi?id=203398
<rdar://problem/56567256>

Reviewed by Wenson Hsieh.

Source/WebCore:

This patch adds the ability to define a ordered set of rules to exclude or include content an element of
a certain name or one with a certain attribute value.

Also made completeManipulation return more detailed errors for debugging purposes.

Tests: TextManipulation.StartTextManipulationApplySingleExcluionRuleForElement

TextManipulation.StartTextManipulationApplyInclusionExclusionRulesForAttributes
TextManipulation.CompleteTextManipulationFailWhenExclusionIsViolated

editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::ExclusionRule::match const): Added.
(WebCore::ExclusionRuleMatcher): Added. This class is responsible for figuring out whether a given node
is excluded or included in the text manipulation.
(WebCore::ExclusionRuleMatcher::ExclusionRuleMatcher): Added.
(WebCore::ExclusionRuleMatcher::isExcluded): Added.
(WebCore::ExclusionRuleMatcher::typeForElement): Added.
(WebCore::TextManipulationController::startObservingParagraphs): Added a Vector of ExclusionRule as
an argument.
(WebCore::TextManipulationController::completeManipulation):
(WebCore::TextManipulationController::replace):

editing/TextManipulationController.h:

(WebCore::TextManipulationController::ExclusionRule): Added.
(WebCore::TextManipulationController::ManipulationResult): Added.
(WebCore::TextManipulationController::ManipulationToken::encode const): Include isExcluded boolean.
(WebCore::TextManipulationController::ManipulationToken::decode): Ditto.
(WebCore::TextManipulationController::ExclusionRule::encode const): Added.
(WebCore::TextManipulationController::ExclusionRule::decode): Added.
(WebCore::TextManipulationController::ExclusionRule::ElementRule::encode const): Added.
(WebCore::TextManipulationController::ExclusionRule::ElementRule::decode): Added.
(WebCore::TextManipulationController::ExclusionRule::AttributeRule::encode const): Added.
(WebCore::TextManipulationController::ExclusionRule::AttributeRule::decode): Added.

Source/WebKit:

Added SPI to specify the configuration for the text manipulation (see r251574), in particular, the set of rules
governing which content should be excluded or included in text manipulations.

Test: TextManipulation.StartTextManipulationExitEarlyWithoutDelegate

SourcesCocoa.txt:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _startTextManipulationsWithConfiguration:completion:]): Takes _WKTextManipulationConfiguration
as an argument. Also fixed a bug that we weren't calling the completion handler when the delegate was not set.
(-[WKWebView _completeTextManipulation:completion:]):
(-[WKWebView _startTextManipulationsWithCompletionHandler:]): Deleted.

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/_WKTextManipulationConfiguration.h: Added.
UIProcess/API/Cocoa/_WKTextManipulationConfiguration.mm: Added.
UIProcess/API/Cocoa/_WKTextManipulationExclusionRule.h: Added.
UIProcess/API/Cocoa/_WKTextManipulationExclusionRule.mm: Added.

(-[_WKTextManipulationExclusionRule initExclusion:forElement:]): Added.
(-[_WKTextManipulationExclusionRule initExclusion:forAttribute:value:]): Added.
(-[_WKTextManipulationExclusionRule elementName]): Added.
(-[_WKTextManipulationExclusionRule attributeName]): Added.
(-[_WKTextManipulationExclusionRule attributeValue]): Added.

UIProcess/API/Cocoa/_WKTextManipulationToken.h: Added excluded boolean property.
UIProcess/API/Cocoa/_WKTextManipulationToken.mm: Removed the superflous import of RetainPtr.h
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startTextManipulations):
(WebKit::WebPageProxy::completeTextManipulation):

UIProcess/WebPageProxy.h:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::startTextManipulations):
(WebKit::WebPage::completeTextManipulation):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

Added tests for including & excluding content based on element names and attribute values.

Also added a test to make sure _startTextManipulationsWithConfiguration calls the completion handler
even when the _WKTextManipulationDelegate isn't set.

TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

12:25 PM Changeset in webkit [251599] by Chris Dumez

17 edits in trunk/Source/WebKit

[iOS][WK2] Use sendWithAsyncReply() to simplify the prepareToSuspend logic
https://bugs.webkit.org/show_bug.cgi?id=203422

Reviewed by Alex Christensen.

Use sendWithAsyncReply() to simplify the prepareToSuspend logic and make it easier to
understand.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processWillSuspendImminentlyForTestingSync):
(WebKit::NetworkProcess::prepareToSuspend):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _processWillSuspendImminentlyForTesting]):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::sendPrepareToSuspend):
(WebKit::NetworkProcessProxy::processReadyToSuspend): Deleted.

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::processReadyToSuspend):
(WebKit::ProcessThrottler::sendPrepareToSuspendIPC):

UIProcess/ProcessThrottler.h:
UIProcess/ProcessThrottlerClient.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendPrepareToSuspend):
(WebKit::WebProcessProxy::processReadyToSuspend): Deleted.

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::prepareToSuspend):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

12:04 PM Changeset in webkit [251598] by youenn@apple.com

7 edits in trunk

WebProcess should unregister its interest for a SWServerRegistration when all its corresponding ServiceWorkerRegistrations are destroyed
https://bugs.webkit.org/show_bug.cgi?id=203410

Reviewed by Chris Dumez.

Source/WebKit:

A SWServerRegistration is keeping a list of web processes that should be notified of change to its state.
Previously, WebProcesses were registering their interest to a SWServerRegistration on construction of a ServiceWorkerRegistration,
and unregistering their interest on destruction of a ServiceWorkerRegistration.

This does not work in case two ServiceWorkerRegistrations are created for the same SWServerRegistration in the same WebProcess.
In that case, when one of the two ServiceWorkerRegistration is destroyed, the WebProcess will no longer be notified of changes to the SWServerRegistration,
thus breaking the second ServiceWorkerRegistration behavior.

We introduce a map at WebProcess level to keep track of the number of ServiceWorkerRegistration created for a given SWServerRegistration.

Covered by re-enabled tests.

WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::addServiceWorkerRegistrationInServer):
(WebKit::WebSWClientConnection::removeServiceWorkerRegistrationInServer):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addServiceWorkerRegistration):
(WebKit::WebProcess::removeServiceWorkerRegistration):

WebProcess/WebProcess.h:

LayoutTests:

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

11:22 AM Changeset in webkit [251597] by Truitt Savell

4 edits in trunk/LayoutTests

Followup test gardening after r251591
https://bugs.webkit.org/show_bug.cgi?id=203291

Unreviewed test gardening.

platform/ios/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac/TestExpectations:

10:47 AM Changeset in webkit [251596] by achristensen@apple.com

1 edit
4 adds in trunk/LayoutTests

Rebase WK1 test after r251582
https://bugs.webkit.org/show_bug.cgi?id=203383

platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/scripting-1: Added.
platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element: Added.
platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module: Added.
platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt: Added.

10:16 AM Changeset in webkit [251595] by Simon Fraser

2 edits in trunk/Source/WebCore

Move code around in CSSCalculationValue.cpp
https://bugs.webkit.org/show_bug.cgi?id=203397

Reviewed by Zalan Bujtas.

Large amounts of code were in inline (but virtual) functions in CSSCalcPrimitiveValue, CSSCalcOperation
and CSSCalcExpressionNodeParser, making it hard to navigate around this file. Move code into
out-of-line functions. No behavior changes.

css/CSSCalculationValue.cpp:

(WebCore::CSSCalcPrimitiveValue::createCalcExpression const):
(WebCore::CSSCalcPrimitiveValue::doubleValue const):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx const):
(WebCore::CSSCalcPrimitiveValue::collectDirectComputationalDependencies const):
(WebCore::CSSCalcPrimitiveValue::collectDirectRootComputationalDependencies const):
(WebCore::CSSCalcPrimitiveValue::equals const):
(WebCore::CSSCalcOperation::create):
(WebCore::CSSCalcOperation::createMinOrMax):
(WebCore::CSSCalcOperation::createSimplified):
(WebCore::CSSCalcOperation::primitiveType const):
(WebCore::CSSCalcOperation::createCalcExpression const):
(WebCore::CSSCalcOperation::doubleValue const):
(WebCore::CSSCalcOperation::computeLengthPx const):
(WebCore::CSSCalcOperation::collectDirectComputationalDependencies const):
(WebCore::CSSCalcOperation::collectDirectRootComputationalDependencies const):
(WebCore::CSSCalcOperation::buildCssText):
(WebCore::CSSCalcOperation::customCSSText const):
(WebCore::CSSCalcOperation::equals const):
(WebCore::CSSCalcOperation::evaluateOperator):
(WebCore::CSSCalcExpressionNodeParser::parseCalc):
(WebCore::CSSCalcExpressionNodeParser::parseValue):
(WebCore::checkDepthAndIndex):
(WebCore::CSSCalcExpressionNodeParser::parseValueTerm):
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
(WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):
(WebCore::CSSCalcExpressionNodeParser::parseMinMaxExpression):
(WebCore::CSSCalcExpressionNodeParser::parseValueExpression):
(WebCore::CSSCalcValue::customCSSText const):
(WebCore::CSSCalcValue::equals const):
(WebCore::CSSCalcValue::clampToPermittedRange const):
(WebCore::CSSCalcValue::doubleValue const):
(WebCore::CSSCalcValue::computeLengthPx const):

9:20 AM Changeset in webkit [251594] by youenn@apple.com

21 edits in trunk

mp4 video element broken with service worker
https://bugs.webkit.org/show_bug.cgi?id=184447
<rdar://problem/39313155>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/fetch/range/sw.https.window-expected.txt:

Source/WebCore:

Update fetch header handling to properly handle range header as per https://fetch.spec.whatwg.org/#headers-class.
In particular, remove thre range header from a Request/Headers object whenever modified.
Add checks so that range responses are not reused for non range requests.
For that purpose, add a range-requested flag to ResourceResponse.
Ass helper routines implementing part of fetch spec.
Covered by enabled test.

Modules/fetch/FetchHeaders.cpp:

(WebCore::removePrivilegedNoCORSRequestHeaders):
(WebCore::appendToHeaderMap):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::set):

Modules/fetch/FetchHeaders.h:

(WebCore::FetchHeaders::setInternalHeaders):

Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::initializeWith):

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

platform/network/HTTPParsers.cpp:

(WebCore::isNoCORSSafelistedRequestHeaderName):
(WebCore::isPriviledgedNoCORSRequestHeaderName):

platform/network/HTTPParsers.h:
platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):

platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::isRangeRequested const):
(WebCore::ResourceResponseBase::setAsRangeRequested):
(WebCore::ResourceResponseBase::encode const):
(WebCore::ResourceResponseBase::decode):

Source/WebKit:

Make a response as range-requested as per https://fetch.spec.whatwg.org/#http-network-or-cache-fetch step 15.

NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::checkRedirection):
(WebKit::NetworkLoadChecker::validateResponse):

NetworkProcess/NetworkLoadChecker.h:
NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

LayoutTests:

Enable test for WK2, not WK1.

TestExpectations:
platform/mac-wk1/TestExpectations:

9:16 AM Changeset in webkit [251593] by Jonathan Bedard

2 edits in trunk/Tools

results.webkit.org: Report the correct flavor for leaks
https://bugs.webkit.org/show_bug.cgi?id=203413

Reviewed by Aakash Jain.

BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunWebKit1LeakTests.start):

8:44 AM Changeset in webkit [251592] by Chris Dumez

11 edits in trunk

Unreviewed, rolling out r251586.

New test is flaky

Reverted changeset:

"DatabaseContext should not prevent entering the back/forward
cache"
https://bugs.webkit.org/show_bug.cgi?id=203103
https://trac.webkit.org/changeset/251586

8:29 AM Changeset in webkit [251591] by graouts@webkit.org

33 edits
11 copies
30 moves
312 adds
43 deletes in trunk/LayoutTests

[Web Animations] Update WPT tests related to Web Animations and remove imported Mozilla tests
https://bugs.webkit.org/show_bug.cgi?id=203291
<rdar://problem/56577481>

Reviewed by Youenn Fablet.

LayoutTests/imported/mozilla:

css-animations/test_animation-cancel-expected.txt: Removed.
css-animations/test_animation-cancel.html: Removed.
css-animations/test_animation-currenttime-expected.txt: Removed.
css-animations/test_animation-currenttime.html: Removed.
css-animations/test_animation-finish-expected.txt: Removed.
css-animations/test_animation-finish.html: Removed.
css-animations/test_animation-finished-expected.txt: Removed.
css-animations/test_animation-finished.html: Removed.
css-animations/test_animation-id.html: Removed.
css-animations/test_animation-pausing.html: Removed.
css-animations/test_animation-playstate.html: Removed.
css-animations/test_animation-ready.html: Removed.
css-animations/test_animation-reverse-expected.txt: Removed.
css-animations/test_animation-reverse.html: Removed.
css-animations/test_animation-starttime-expected.txt: Removed.
css-animations/test_animation-starttime.html: Removed.
css-animations/test_animations-dynamic-changes.html: Removed.
css-animations/test_event-dispatch.html: Removed.
css-animations/test_event-order-expected.txt: Removed.
css-animations/test_event-order.html: Removed.
css-animations/test_setting-effect.html: Removed.
css-transitions/test_animation-cancel.html: Removed.
css-transitions/test_animation-currenttime-expected.txt: Removed.
css-transitions/test_animation-currenttime.html: Removed.
css-transitions/test_animation-finished-expected.txt: Removed.
css-transitions/test_animation-finished.html: Removed.
css-transitions/test_animation-pausing-expected.txt: Removed.
css-transitions/test_animation-pausing.html: Removed.
css-transitions/test_animation-ready-expected.txt: Removed.
css-transitions/test_animation-ready.html: Removed.
css-transitions/test_animation-starttime-expected.txt: Removed.
css-transitions/test_animation-starttime.html: Removed.
css-transitions/test_csstransition-transitionproperty.html: Removed.
css-transitions/test_document-get-animations-expected.txt: Removed.
css-transitions/test_document-get-animations.html: Removed.
css-transitions/test_element-get-animations-expected.txt: Removed.
css-transitions/test_element-get-animations.html: Removed.
css-transitions/test_event-dispatch.html: Removed.
css-transitions/test_keyframeeffect-getkeyframes-expected.txt: Removed.
css-transitions/test_keyframeeffect-getkeyframes.html: Removed.
css-transitions/test_setting-effect-expected.txt: Removed.
css-transitions/test_setting-effect.html: Removed.

LayoutTests/imported/w3c:

resources/import-expectations.json:
web-platform-tests/css/css-animations/AnimationEffect-getComputedTiming.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-computed-timing-expected.txt.
web-platform-tests/css/css-animations/AnimationEffect-getComputedTiming.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-computed-timing.html.
web-platform-tests/css/css-animations/CSSAnimation-animationName.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_cssanimation-animationname-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-animationName.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_cssanimation-animationname.html.
web-platform-tests/css/css-animations/CSSAnimation-canceling.tentative-expected.txt: Added.
web-platform-tests/css/css-animations/CSSAnimation-canceling.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-effect.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_setting-effect-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-effect.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-finished.tentative-expected.txt: Added.
web-platform-tests/css/css-animations/CSSAnimation-finished.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-getCurrentTime.tentative-expected.txt: Added.
web-platform-tests/css/css-animations/CSSAnimation-getCurrentTime.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-id.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-id-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-id.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-pausing.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-pausing-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-pausing.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-playState.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-playstate-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-playState.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-ready.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animation-ready-expected.txt.
web-platform-tests/css/css-animations/CSSAnimation-ready.tentative.html: Added.
web-platform-tests/css/css-animations/CSSAnimation-startTime.tentative-expected.txt: Added.
web-platform-tests/css/css-animations/CSSAnimation-startTime.tentative.html: Added.
web-platform-tests/css/css-animations/CSSPseudoElement-getAnimations.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_pseudoElement-get-animations-expected.txt.
web-platform-tests/css/css-animations/CSSPseudoElement-getAnimations.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_pseudoElement-get-animations.html.
web-platform-tests/css/css-animations/Document-getAnimations.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_document-get-animations-expected.txt.
web-platform-tests/css/css-animations/Document-getAnimations.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_document-get-animations.html.
web-platform-tests/css/css-animations/Element-getAnimations-dynamic-changes.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_animations-dynamic-changes-expected.txt.
web-platform-tests/css/css-animations/Element-getAnimations-dynamic-changes.tentative.html: Added.
web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_element-get-animations-expected.txt.
web-platform-tests/css/css-animations/Element-getAnimations.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_element-get-animations.html.
web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_keyframeeffect-getkeyframes-expected.txt.
web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_keyframeeffect-getkeyframes.html.
web-platform-tests/css/css-animations/KeyframeEffect-target.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_effect-target-expected.txt.
web-platform-tests/css/css-animations/KeyframeEffect-target.tentative.html: Renamed from LayoutTests/imported/mozilla/css-animations/test_effect-target.html.
web-platform-tests/css/css-animations/META.yml: Added.
web-platform-tests/css/css-animations/OWNERS: Removed.
web-platform-tests/css/css-animations/animation-opacity-pause-and-set-time-expected.html: Added.
web-platform-tests/css/css-animations/animation-opacity-pause-and-set-time.html: Added.
web-platform-tests/css/css-animations/animation-pseudo-dynamic-001-expected.html: Added.
web-platform-tests/css/css-animations/animation-pseudo-dynamic-001.html: Added.
web-platform-tests/css/css-animations/animation-transform-pause-and-set-time-expected.html: Added.
web-platform-tests/css/css-animations/animation-transform-pause-and-set-time.html: Added.
web-platform-tests/css/css-animations/animationevent-interface-expected.txt:
web-platform-tests/css/css-animations/animationevent-interface.js:

(test):
(test.):

web-platform-tests/css/css-animations/animationevent-marker-pseudoelement-expected.txt: Added.
web-platform-tests/css/css-animations/animationevent-marker-pseudoelement.html: Added.
web-platform-tests/css/css-animations/computed-style-animation-parsing-expected.txt: Added.
web-platform-tests/css/css-animations/computed-style-animation-parsing.html: Added.
web-platform-tests/css/css-animations/event-dispatch.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-animations/test_event-dispatch-expected.txt.
web-platform-tests/css/css-animations/event-dispatch.tentative.html: Added.
web-platform-tests/css/css-animations/event-order.tentative-expected.txt: Added.
web-platform-tests/css/css-animations/event-order.tentative.html: Added.
web-platform-tests/css/css-animations/historical-expected.txt: Added.
web-platform-tests/css/css-animations/historical.html: Added.
web-platform-tests/css/css-animations/idlharness-expected.txt: Added.
web-platform-tests/css/css-animations/idlharness.html: Added.
web-platform-tests/css/css-animations/inheritance-expected.txt: Added.
web-platform-tests/css/css-animations/inheritance.html: Added.
web-platform-tests/css/css-animations/keyframes-remove-documentElement-crash-expected.txt: Added.
web-platform-tests/css/css-animations/keyframes-remove-documentElement-crash.html: Added.
web-platform-tests/css/css-animations/parsing/animation-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-delay-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-direction-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-duration-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-fill-mode-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-iteration-count-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-name-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-name-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-name-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-name-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-name-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-name-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-play-state-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-shorthand-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-shorthand.html: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-invalid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-invalid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html: Added.
web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt: Added.
web-platform-tests/css/css-animations/parsing/animation-valid.html: Added.
web-platform-tests/css/css-animations/parsing/w3c-import.log: Added.
web-platform-tests/css/css-animations/responsive/column-rule-color-001-expected.txt: Added.
web-platform-tests/css/css-animations/responsive/column-rule-color-001.html: Added.
web-platform-tests/css/css-animations/responsive/column-width-001-expected.txt: Added.
web-platform-tests/css/css-animations/responsive/column-width-001.html: Added.
web-platform-tests/css/css-animations/responsive/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/css/css-animations/style-animation-parsing-expected.txt: Added.
web-platform-tests/css/css-animations/style-animation-parsing.html: Added.
web-platform-tests/css/css-animations/support/testcommon.js:
web-platform-tests/css/css-animations/support/w3c-import.log:
web-platform-tests/css/css-animations/w3c-import.log:
web-platform-tests/css/css-transitions/AnimationEffect-getComputedTiming.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_animation-computed-timing-expected.txt.
web-platform-tests/css/css-transitions/AnimationEffect-getComputedTiming.tentative.html: Renamed from LayoutTests/imported/mozilla/css-transitions/test_animation-computed-timing.html.
web-platform-tests/css/css-transitions/CSSPseudoElement-getAnimations.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_pseudoElement-get-animations-expected.txt.
web-platform-tests/css/css-transitions/CSSPseudoElement-getAnimations.tentative.html: Renamed from LayoutTests/imported/mozilla/css-transitions/test_pseudoElement-get-animations.html.
web-platform-tests/css/css-transitions/CSSTransition-canceling.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_animation-cancel-expected.txt.
web-platform-tests/css/css-transitions/CSSTransition-canceling.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-currentTime.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/CSSTransition-currentTime.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-effect.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/CSSTransition-effect.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-finished.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/CSSTransition-finished.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-ready.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/CSSTransition-ready.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-startTime.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/CSSTransition-startTime.tentative.html: Added.
web-platform-tests/css/css-transitions/CSSTransition-transitionProperty.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_csstransition-transitionproperty-expected.txt.
web-platform-tests/css/css-transitions/CSSTransition-transitionProperty.tentative.html: Added.
web-platform-tests/css/css-transitions/Document-getAnimations.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/Document-getAnimations.tentative.html: Added.
web-platform-tests/css/css-transitions/Element-getAnimations.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/Element-getAnimations.tentative.html: Added.
web-platform-tests/css/css-transitions/KeyframeEffect-getKeyframes.tentative-expected.txt: Added.
web-platform-tests/css/css-transitions/KeyframeEffect-getKeyframes.tentative.html: Added.
web-platform-tests/css/css-transitions/KeyframeEffect-target.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_effect-target-expected.txt.
web-platform-tests/css/css-transitions/KeyframeEffect-target.tentative.html: Renamed from LayoutTests/imported/mozilla/css-transitions/test_effect-target.html.
web-platform-tests/css/css-transitions/META.yml: Added.
web-platform-tests/css/css-transitions/README.md: Added.
web-platform-tests/css/css-transitions/before-load-001-expected.txt: Added.
web-platform-tests/css/css-transitions/before-load-001.html: Added.
web-platform-tests/css/css-transitions/changing-while-transition-001-expected.txt: Added.
web-platform-tests/css/css-transitions/changing-while-transition-001.html: Added.
web-platform-tests/css/css-transitions/changing-while-transition-002-expected.txt: Added.
web-platform-tests/css/css-transitions/changing-while-transition-002.html: Added.
web-platform-tests/css/css-transitions/changing-while-transition-003-expected.txt: Added.
web-platform-tests/css/css-transitions/changing-while-transition-003.html: Added.
web-platform-tests/css/css-transitions/currentcolor-animation-001-expected.txt: Added.
web-platform-tests/css/css-transitions/currentcolor-animation-001.html: Added.
web-platform-tests/css/css-transitions/disconnected-element-001-expected.txt: Added.
web-platform-tests/css/css-transitions/disconnected-element-001.html: Added.
web-platform-tests/css/css-transitions/event-dispatch.tentative-expected.txt: Renamed from LayoutTests/imported/mozilla/css-transitions/test_event-dispatch-expected.txt.
web-platform-tests/css/css-transitions/event-dispatch.tentative.html: Added.
web-platform-tests/css/css-transitions/events-001-expected.txt: Added.
web-platform-tests/css/css-transitions/events-001.html: Added.
web-platform-tests/css/css-transitions/events-002-expected.txt: Added.
web-platform-tests/css/css-transitions/events-002.html: Added.
web-platform-tests/css/css-transitions/events-003-expected.txt: Added.
web-platform-tests/css/css-transitions/events-003.html: Added.
web-platform-tests/css/css-transitions/events-004-expected.txt: Added.
web-platform-tests/css/css-transitions/events-004.html: Added.
web-platform-tests/css/css-transitions/events-005-expected.txt: Added.
web-platform-tests/css/css-transitions/events-005.html: Added.
web-platform-tests/css/css-transitions/events-006-expected.txt: Added.
web-platform-tests/css/css-transitions/events-006.html: Added.
web-platform-tests/css/css-transitions/events-007-expected.txt: Added.
web-platform-tests/css/css-transitions/events-007.html: Added.
web-platform-tests/css/css-transitions/historical-expected.txt: Added.
web-platform-tests/css/css-transitions/historical.html: Added.
web-platform-tests/css/css-transitions/idlharness-expected.txt: Added.
web-platform-tests/css/css-transitions/idlharness.html: Added.
web-platform-tests/css/css-transitions/inherit-height-transition-expected.txt: Added.
web-platform-tests/css/css-transitions/inherit-height-transition.html: Added.
web-platform-tests/css/css-transitions/inheritance-expected.txt: Added.
web-platform-tests/css/css-transitions/inheritance.html: Added.
web-platform-tests/css/css-transitions/no-transition-from-ua-to-blocking-stylesheet-expected.html: Added.
web-platform-tests/css/css-transitions/no-transition-from-ua-to-blocking-stylesheet.html: Added.
web-platform-tests/css/css-transitions/non-rendered-element-001-expected.txt: Added.
web-platform-tests/css/css-transitions/non-rendered-element-001.html: Added.
web-platform-tests/css/css-transitions/non-rendered-element-002-expected.txt: Added.
web-platform-tests/css/css-transitions/non-rendered-element-002.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-computed-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-computed.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-computed-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-computed.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-invalid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-invalid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-valid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-delay-valid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-computed-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-computed.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-invalid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-invalid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-valid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-duration-valid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-invalid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-invalid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-computed-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-computed.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-invalid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-invalid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-valid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-property-valid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-shorthand-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-shorthand.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-invalid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-invalid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-timing-function-valid.html: Added.
web-platform-tests/css/css-transitions/parsing/transition-valid-expected.txt: Added.
web-platform-tests/css/css-transitions/parsing/transition-valid.html: Added.
web-platform-tests/css/css-transitions/parsing/w3c-import.log: Added.
web-platform-tests/css/css-transitions/properties-value-001-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-001.html: Added.
web-platform-tests/css/css-transitions/properties-value-002-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-002.html: Added.
web-platform-tests/css/css-transitions/properties-value-003-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-003.html: Added.
web-platform-tests/css/css-transitions/properties-value-auto-001-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-auto-001.html: Added.
web-platform-tests/css/css-transitions/properties-value-implicit-001-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-implicit-001.html: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-001-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-001.html: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-002-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-002.html: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-003-expected.txt: Added.
web-platform-tests/css/css-transitions/properties-value-inherit-003.html: Added.
web-platform-tests/css/css-transitions/pseudo-elements-001-expected.txt: Added.
web-platform-tests/css/css-transitions/pseudo-elements-001.html: Added.
web-platform-tests/css/css-transitions/pseudo-elements-002-expected.txt: Added.
web-platform-tests/css/css-transitions/pseudo-elements-002.html: Added.
web-platform-tests/css/css-transitions/starting-of-transitions-001-expected.txt: Added.
web-platform-tests/css/css-transitions/starting-of-transitions-001.html: Added.
web-platform-tests/css/css-transitions/support/1x1-green.png: Added.
web-platform-tests/css/css-transitions/support/1x1-lime.png: Added.
web-platform-tests/css/css-transitions/support/1x1-maroon.png: Added.
web-platform-tests/css/css-transitions/support/1x1-navy.png: Added.
web-platform-tests/css/css-transitions/support/1x1-red.png: Added.
web-platform-tests/css/css-transitions/support/1x1-white.png: Added.
web-platform-tests/css/css-transitions/support/60x60-gg-rr.png: Added.
web-platform-tests/css/css-transitions/support/60x60-green.png: Added.
web-platform-tests/css/css-transitions/support/60x60-red.png: Added.
web-platform-tests/css/css-transitions/support/README: Added.
web-platform-tests/css/css-transitions/support/a-green-transition.css: Added.

(.a):

web-platform-tests/css/css-transitions/support/a-green.css: Added.

(.a):

web-platform-tests/css/css-transitions/support/b-green.css: Added.

(.b):

web-platform-tests/css/css-transitions/support/c-red.css: Added.

(.c):

web-platform-tests/css/css-transitions/support/cat.png: Added.
web-platform-tests/css/css-transitions/support/generalParallelTest.js: Added.

(suite.root.generalParallelTest.setup):
(suite.root.generalParallelTest.data.transition.computedStyle):
(suite.root.generalParallelTest.data.container.computedStyle):
(suite.root.generalParallelTest.data.pseudo.computedStyle):
(suite.root.generalParallelTest._setupDom):
(suite.root.generalParallelTest.):
(suite.root.generalParallelTest._setupEvents):
(suite.root.generalParallelTest.teardown):
(suite.root.generalParallelTest.sliceStart):
(suite.root.generalParallelTest.sliceDone):
(suite.root.generalParallelTest.done):
(suite.root.generalParallelTest.addStyles):
(suite.root.generalParallelTest.getStyle):
(suite.root.generalParallelTest._getStyleFor):
(suite.root.generalParallelTest._addClass):
(suite.root.generalParallelTest._removeClass):
(suite.root.generalParallelTest.startTransition):
(suite.root.generalParallelTest.runLoop):
(suite.root.generalParallelTest.startValueCollection):
(suite.root.generalParallelTest.stopValueCollection):
(suite.root.generalParallelTest.assertExpectedEventsFunc):
(suite.root.generalParallelTest.assertIntermediateValuesFunc):

web-platform-tests/css/css-transitions/support/helper.js: Added.

(root.setStyle):
(serializeStyles):
(root.computedStyle):
(root.reflow):
(root.extend):
(root.domFixture):
(root.assert_times_equal):
(root.assert_time_equals_literal):
(root.assert_end_events_equal):
(root.assert_end_event_batch_equal):
(root.addDiv):
(root.addStyle):
(root.waitForFrame):
(root.waitForAnimationFrames.return.new.Promise):
(root.waitForAnimationFrames):
(root.frameTimeout):

web-platform-tests/css/css-transitions/support/import-green.css: Added.

(.import):

web-platform-tests/css/css-transitions/support/import-red.css: Added.

(.import):

web-platform-tests/css/css-transitions/support/one.gif: Added.
web-platform-tests/css/css-transitions/support/pattern-grg-rgr-grg.png: Added.
web-platform-tests/css/css-transitions/support/pattern-grg-rrg-rgg.png: Added.
web-platform-tests/css/css-transitions/support/pattern-rgr-grg-rgr.png: Added.
web-platform-tests/css/css-transitions/support/pattern-tr.png: Added.
web-platform-tests/css/css-transitions/support/properties.js: Added.

(values.string_appeared_here):
(assemble.):
(assemble):
(root.getPropertyTests):
(root.getMissingPropertyTests):
(root.getUnspecifiedPropertyTests):
(root.getFontSizeRelativePropertyTests):
(root.getAutoPropertyTests):
(root.filterPropertyTests):

web-platform-tests/css/css-transitions/support/ruler-h-50%.png: Added.
web-platform-tests/css/css-transitions/support/ruler-h-50px.png: Added.
web-platform-tests/css/css-transitions/support/ruler-v-100px.png: Added.
web-platform-tests/css/css-transitions/support/ruler-v-50px.png: Added.
web-platform-tests/css/css-transitions/support/runParallelAsyncHarness.js: Added.

(noop):
(runLoop.concludeSlice):
(root.runParallelAsyncHarness):

web-platform-tests/css/css-transitions/support/square-purple.png: Added.
web-platform-tests/css/css-transitions/support/square-teal.png: Added.
web-platform-tests/css/css-transitions/support/square-white.png: Added.
web-platform-tests/css/css-transitions/support/support/README: Added.
web-platform-tests/css/css-transitions/support/support/swatch-green.png: Added.
web-platform-tests/css/css-transitions/support/support/swatch-red.png: Added.
web-platform-tests/css/css-transitions/support/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/css/css-transitions/support/swatch-blue.png: Added.
web-platform-tests/css/css-transitions/support/swatch-green.png: Added.
web-platform-tests/css/css-transitions/support/swatch-lime.png: Added.
web-platform-tests/css/css-transitions/support/swatch-orange.png: Added.
web-platform-tests/css/css-transitions/support/swatch-red.png: Added.
web-platform-tests/css/css-transitions/support/swatch-teal.png: Added.
web-platform-tests/css/css-transitions/support/swatch-white.png: Added.
web-platform-tests/css/css-transitions/support/swatch-yellow.png: Added.
web-platform-tests/css/css-transitions/support/test-bl.png: Added.
web-platform-tests/css/css-transitions/support/test-br.png: Added.
web-platform-tests/css/css-transitions/support/test-inner-half-size.png: Added.
web-platform-tests/css/css-transitions/support/test-outer.png: Added.
web-platform-tests/css/css-transitions/support/test-tl.png: Added.
web-platform-tests/css/css-transitions/support/test-tr.png: Added.
web-platform-tests/css/css-transitions/support/two.gif: Added.
web-platform-tests/css/css-transitions/support/vendorPrefix.js: Added.

(root.addVendorPrefix):
(root.addValueVendorPrefix):
(root.getVendorPrefix):
(root.getValueVendorPrefix):

web-platform-tests/css/css-transitions/support/w3c-import.log: Added.
web-platform-tests/css/css-transitions/transition-001-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-001.html: Added.
web-platform-tests/css/css-transitions/transition-background-position-with-edge-offset-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-background-position-with-edge-offset.html: Added.
web-platform-tests/css/css-transitions/transition-delay-001-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-delay-001.html: Added.
web-platform-tests/css/css-transitions/transition-duration-001-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-duration-001.html: Added.
web-platform-tests/css/css-transitions/transition-property-001-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-property-001.html: Added.
web-platform-tests/css/css-transitions/transition-property-002-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-property-002.html: Added.
web-platform-tests/css/css-transitions/transition-reparented-expected.txt: Added.
web-platform-tests/css/css-transitions/transition-reparented.html: Added.
web-platform-tests/css/css-transitions/transition-test-expected.html: Added.
web-platform-tests/css/css-transitions/transition-test.html: Added.
web-platform-tests/css/css-transitions/transitioncancel-001-expected.txt: Added.
web-platform-tests/css/css-transitions/transitioncancel-001.html: Added.
web-platform-tests/css/css-transitions/transitionevent-interface-expected.txt: Added.
web-platform-tests/css/css-transitions/transitionevent-interface.html: Added.
web-platform-tests/css/css-transitions/w3c-import.log: Added.
web-platform-tests/css/css-transitions/zero-duration-multiple-transition-expected.txt: Added.
web-platform-tests/css/css-transitions/zero-duration-multiple-transition.html: Added.
web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
web-platform-tests/web-animations/animation-model/animation-types/property-types.js:

(const.visibilityType.testAdditionOrAccumulation):
(const.filterListType.testInterpolation):

web-platform-tests/web-animations/animation-model/animation-types/w3c-import.log: Added.
web-platform-tests/web-animations/animation-model/combining-effects/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/animation-model/keyframe-effects/w3c-import.log: Added.
web-platform-tests/web-animations/interfaces/Animatable/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/interfaces/Animation/idlharness.window-expected.txt: Added.
web-platform-tests/web-animations/interfaces/Animation/idlharness.window.html: Added.
web-platform-tests/web-animations/interfaces/Animation/oncancel.html:
web-platform-tests/web-animations/interfaces/Animation/w3c-import.log: Added.
web-platform-tests/web-animations/interfaces/AnimationEffect/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness.window-expected.txt: Added.
web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness.window.html: Added.
web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/interfaces/Document/getAnimations-expected.txt:
web-platform-tests/web-animations/interfaces/Document/getAnimations.html:
web-platform-tests/web-animations/interfaces/Document/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness.window-expected.txt: Added.
web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness.window.html: Added.
web-platform-tests/web-animations/interfaces/DocumentTimeline/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness.window-expected.txt: Added.
web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness.window.html: Added.
web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt:
web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html:
web-platform-tests/web-animations/interfaces/KeyframeEffect/w3c-import.log: Added.
web-platform-tests/web-animations/resources/w3c-import.log: Added.
web-platform-tests/web-animations/timing-model/animation-effects/w3c-import.log: Added.
web-platform-tests/web-animations/timing-model/animations/w3c-import.log: Added.
web-platform-tests/web-animations/timing-model/time-transformations/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/timing-model/timelines/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.
web-platform-tests/web-animations/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/w3c-import.log.

LayoutTests:

TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
platform/ios/TestExpectations:
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
tests-options.json:

8:12 AM Changeset in webkit [251590] by Alan Bujtas

12 edits
1 copy in trunk/Source/WebCore

[LFC][IFC] Add support for preserved new line (pre, pre-wrap, break-spaces, pre-line)
https://bugs.webkit.org/show_bug.cgi?id=203395
<rdar://problem/56606243>

Reviewed by Antti Koivisto.

<pre>Let's wrap the line
when the inline item's type is forced line break.</pre>

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/LayoutContext.h:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContent):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineDescentNeedsCollapsing const):

layout/inlineformatting/InlineItem.cpp: Copied from Source/WebCore/layout/tableformatting/TableInvalidation.cpp.

(WebCore::Layout::InlineItem::isForcedLineBreak const):
(WebCore::Layout::InlineItem::isText const):

layout/inlineformatting/InlineItem.h:

(WebCore::Layout::InlineItem::isBox const):
(WebCore::Layout::InlineItem::isText const): Deleted.
(WebCore::Layout::InlineItem::isHardLineBreak const): Deleted.
(WebCore::Layout::InlineItem::isLineBreak const): Deleted.

layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::close):
(WebCore::Layout::Line::alignContentVertically):
(WebCore::Layout::Line::append):
(WebCore::Layout::Line::appendLineBreak):
(WebCore::Layout::Line::adjustBaselineAndLineHeight):
(WebCore::Layout::Line::inlineItemContentHeight const):
(WebCore::Layout::Line::appendHardLineBreak): Deleted.

layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Run::isText const):
(WebCore::Layout::Line::Run::isForcedLineBreak const):
(WebCore::Layout::Line::Run::isLineBreak const): Deleted.

layout/inlineformatting/InlineLineLayout.cpp:

(WebCore::Layout::inlineItemWidth):
(WebCore::Layout::LineLayout::placeInlineItem):
(WebCore::Layout::LineLayout::shouldProcessUncommittedContent const):

layout/inlineformatting/InlineTextItem.h:

(WebCore::Layout::InlineTextItem::isSegmentBreak const):

layout/tableformatting/TableInvalidation.cpp:

8:09 AM WebKitGTK/Debugging edited by clopez@igalia.com

(diff)

8:08 AM WebKitGTK/Debugging edited by clopez@igalia.com

(diff)

6:01 AM Changeset in webkit [251589] by Chris Dumez

2 edits in trunk/Source/WebKit

[iOS] Regression(r251067) WebProcesses with service workers no longer keep their network process alive
https://bugs.webkit.org/show_bug.cgi?id=203388
<rdar://problem/56600074>

Reviewed by Geoffrey Garen.

Historically, WebProcessProxy::didSetAssertionState() used to return early for service worker processes
because we did not want service worker processes to prevent the network process from suspending. The
WebProcesses using the service worker process would prevent the network process from suspending when
they are visible, so it would work fine.

However, after r251067, there is no longer a concept of service worker process per se. Service workers
will now sometimes run in regular WebProcesses where we have pages. In such cases, didSetAssertionState()
would still return early and fail to keep its network process alive, even when the page(s) in this process
are visible on screen.

To address the issue, we now only return early if the process has a service worker but no page.
This should restore pre-existing behavior.

Note that this was causing hangs such as <rdar://problem/56245136> because the WebProcess would be
stuck on sync IPC to a suspended network process.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didSetAssertionState):

5:09 AM Changeset in webkit [251588] by Ross Kirsling

5 edits in trunk

test262-runner should be able to pass JSC a feature flag
https://bugs.webkit.org/show_bug.cgi?id=203301

Reviewed by Keith Miller.

JSTests:

test262/config.yaml:

Add feature flag mapping.
Also skip a few forgotten features as well as BigInt TypedArray tests.

test262/expectations.yaml:

Regenerate expectations.

Tools:

Scripts/test262/Runner.pm:

Recognize mapping from 262 features to JSC runtime options.

2:11 AM Changeset in webkit [251587] by Jonathan Bedard

10 edits in trunk/Tools

Python 3: Add support in webkitpy.common.checkout.scm
https://bugs.webkit.org/show_bug.cgi?id=203277

Reviewed by Stephanie Lewis.

Scripts/test-webkitpy-python3: Add webkitpy.common.checkout.scm, add --all flag.
Scripts/webkitpy/common/checkout/scm/detection.py: Use full import paths.
Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Ditto.
Scripts/webkitpy/common/checkout/scm/git.py:

(Git.revisions_changing_file): Convert filter iterator to list.
(Git.prepend_svn_revision): Patches need to be bytes.

Scripts/webkitpy/common/checkout/scm/scm.py: Import unicode.
Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Use full import paths,

differentiate between binary and text files, replace assertItemsEqual with sorted,
list fix regexes on byte arrays.

Scripts/webkitpy/common/checkout/scm/stub_repository.py: Use full import paths.
Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Use full import paths.
Scripts/webkitpy/common/checkout/scm/svn.py: Use full import paths.

(SVN.diff_for_revision): Diff for revision should be byte array.
(SVN.propget): Use Python 3 compatible encoding.

1:14 AM Changeset in webkit [251586] by Chris Dumez

11 edits in trunk

DatabaseContext should not prevent entering the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203103

Reviewed by Geoffrey Garen.

Source/WebCore:

Let pages with active webdatabase transactions into the back/forward cache. We make sure
to queue tasks that run script to the Window event loop, so that they get delayed when
the document is suspended.

No new tests, updated existing test.

Modules/webdatabase/Database.cpp:

(WebCore::Database::runTransaction):

Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::shouldPreventEnteringBackForwardCache_DEPRECATED const): Deleted.

Modules/webdatabase/DatabaseContext.h:
Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):

Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::performPendingCallback):

LayoutTests:

fast/history/page-cache-webdatabase-pending-transaction-expected.txt:
fast/history/page-cache-webdatabase-pending-transaction.html:

Update existing test to reflect behavior change.

platform/gtk/TestExpectations:
platform/mac/TestExpectations:

Unmark test as flaky.

1:14 AM Changeset in webkit [251585] by Chris Dumez

7 edits in trunk/Source/WebKit

Standardize "PageID=" vs "pageID =" in release logging
https://bugs.webkit.org/show_bug.cgi?id=203002

Reviewed by Geoffrey Garen.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _updateVisibleContentRects]):
(-[WKWebView _cancelAnimatedResize]):
(-[WKWebView _didCompleteAnimatedResize]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):
(-[WKWebView _resizeWhileHidingContentWithUpdates:]):

UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::processDidTerminate):
(WebKit::ProvisionalPageProxy::cancel):
(WebKit::ProvisionalPageProxy::loadData):
(WebKit::ProvisionalPageProxy::loadRequest):
(WebKit::ProvisionalPageProxy::goToBackForwardItem):
(WebKit::ProvisionalPageProxy::didCreateMainFrame):
(WebKit::ProvisionalPageProxy::didStartProvisionalLoadForFrame):
(WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):
(WebKit::ProvisionalPageProxy::didCommitLoadForFrame):

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::loadResource):
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::serviceWorkerDidNotHandle):
(WebKit::WebResourceLoader::didFailResourceLoad):
(WebKit::WebResourceLoader::didBlockAuthenticationChallenge):
(WebKit::WebResourceLoader::stopLoadingAfterXFrameOptionsOrContentSecurityPolicyDenied):
(WebKit::WebResourceLoader::didReceiveResource):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):

Context Navigation

Timeline

Oct 26, 2019:

Oct 25, 2019:

Download in other formats: