Timeline

Nov 7, 2019:

8:02 PM Changeset in webkit [252232] by mitz@apple.com

• 8 copies
  1 add in releases/Apple/iOS 13.2.2

Added a tag for iOS 13.2.2.

7:55 PM Changeset in webkit [252231] by Tadeu Zagallo

• 5 edits in trunk/Source/JavaScriptCore

Use fewer virtual registers in Wasm LLInt
​https://bugs.webkit.org/show_bug.cgi?id=203861

Reviewed by Saam Barati.

Reduce the number of virtual registers in two ways:

• Re-use arguments for result values (e.g. the result of add lhs, rhs should go in lhs, not a new virtual register)
• Re-use the argument register space for return values that should be placed in registers

• bytecode/BytecodeList.rb:
• generator/Wasm.rb:
• llint/WebAssembly.asm:
• wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::callInformationFor):
(JSC::Wasm::LLIntGenerator::addReturn):
(JSC::Wasm::LLIntGenerator::addRefIsNull):
(JSC::Wasm::LLIntGenerator::addTableGet):
(JSC::Wasm::LLIntGenerator::addTableGrow):
(JSC::Wasm::LLIntGenerator::addGrowMemory):
(JSC::Wasm::LLIntGenerator::addSelect):
(JSC::Wasm::LLIntGenerator::load):

6:52 PM Changeset in webkit [252230] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Default NamepaceURI must be gotten from the topmost parent before the SVG <foreignObject>
​https://bugs.webkit.org/show_bug.cgi?id=203868

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-11-07
Reviewed by Ryosuke Niwa.

Source/WebCore:

Ensure that we don't cross boundaries from HTML to SVG when traversing
the tree of nodes upward. We need to stop at the foreignObject if it is
one of the ancestors of the contextElement.

Tests: svg/foreignObject/foreign-object-dynamic-parsing.svg

• html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::HTMLTableCellElement):
This assertion should not fire if the tag has a prefix like <h:th> or
<h:td> where 'h' is a defined namespace.

• xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::parseDocumentFragment):
Stop at the first SVG <foreignObject> ancestor when calculating the
defaultNamespaceURI.

• xml/parser/XMLDocumentParser.h:
• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

(WebCore::XMLDocumentParser::startElementNs):
We need to special case setting the namespaceURI of the SVGElmenets. The
defaultNamespaceURI can be wrong for them if the context element is an
HTML element, <div> for example, and the innerHTML is set to something
like: '<svg><rect/></svg>'.

LayoutTests:

• svg/foreignObject/foreign-object-dynamic-parsing-expected.svg: Added.
• svg/foreignObject/foreign-object-dynamic-parsing.svg: Added.

6:46 PM Changeset in webkit [252229] by rmorisset@apple.com

• 46 edits in trunk/Source/JavaScriptCore

Split ArithProfile into a Unary and a Binary version
​https://bugs.webkit.org/show_bug.cgi?id=202832
<rdar://problem/56266847>

Reviewed by Keith Miller.

ArithProfile was for a long time only used for add/sub/mul/div, but recently it started being used for negate. And it will soon also have to be used for inc and dec due to BigInt.
So in this patch I make a separate version that only has the data for a single argument, and thus takes half as much memory.

After discussing this change with Phil I realized that the ResultType(s) that were taking space in ArithProfile are not needed: they never change and a copy is already in the bytecode instruction itself.
Removing them allowed shrinking both kinds of ArithProfile to fit in 16 bits (9 and 13 respectively).
I kept the two kinds separate because they may shrink or grow independently in the future.

This also required adding the "orh" instruction to the offline assembler, to set bits in the ArithProfile.
This in turn motivated the addition of "storeh", as on RISC platforms "orh" on a memory location is actually loadh -> orh -> storeh.

• bytecode/ArithProfile.cpp:

(JSC::ArithProfile<BitfieldType>::emitObserveResult):
(JSC::ArithProfile<BitfieldType>::shouldEmitSetDouble const):
(JSC::ArithProfile<BitfieldType>::emitSetDouble const):
(JSC::ArithProfile<BitfieldType>::shouldEmitSetNonNumeric const):
(JSC::ArithProfile<BitfieldType>::shouldEmitSetBigInt const):
(JSC::ArithProfile<BitfieldType>::emitSetNonNumeric const):
(JSC::ArithProfile<BitfieldType>::emitSetBigInt const):
(WTF::printInternal):

• bytecode/ArithProfile.h:

(JSC::ArithProfile::didObserveNonInt32 const):
(JSC::ArithProfile::didObserveDouble const):
(JSC::ArithProfile::didObserveNonNegZeroDouble const):
(JSC::ArithProfile::didObserveNegZeroDouble const):
(JSC::ArithProfile::didObserveNonNumeric const):
(JSC::ArithProfile::didObserveBigInt const):
(JSC::ArithProfile::didObserveInt32Overflow const):
(JSC::ArithProfile::didObserveInt52Overflow const):
(JSC::ArithProfile::setObservedNonNegZeroDouble):
(JSC::ArithProfile::setObservedNegZeroDouble):
(JSC::ArithProfile::setObservedNonNumeric):
(JSC::ArithProfile::setObservedBigInt):
(JSC::ArithProfile::setObservedInt32Overflow):
(JSC::ArithProfile::setObservedInt52Overflow):
(JSC::ArithProfile::observeResult):
(JSC::ArithProfile::addressOfBits const):
(JSC::ArithProfile::bits const):
(JSC::ArithProfile::ArithProfile):
(JSC::ArithProfile::hasBits const):
(JSC::ArithProfile::setBit):
(JSC::UnaryArithProfile::UnaryArithProfile):
(JSC::UnaryArithProfile::observedIntBits):
(JSC::UnaryArithProfile::observedNumberBits):
(JSC::UnaryArithProfile::argObservedType const):
(JSC::UnaryArithProfile::setArgObservedType):
(JSC::UnaryArithProfile::argSawInt32):
(JSC::UnaryArithProfile::argSawNumber):
(JSC::UnaryArithProfile::argSawNonNumber):
(JSC::UnaryArithProfile::observeArg):
(JSC::UnaryArithProfile::isObservedTypeEmpty):
(JSC::BinaryArithProfile::BinaryArithProfile):
(JSC::BinaryArithProfile::observedIntIntBits):
(JSC::BinaryArithProfile::observedNumberIntBits):
(JSC::BinaryArithProfile::observedIntNumberBits):
(JSC::BinaryArithProfile::observedNumberNumberBits):
(JSC::BinaryArithProfile::setLhsObservedType):
(JSC::BinaryArithProfile::setRhsObservedType):
(JSC::BinaryArithProfile::observeLHS):
(JSC::BinaryArithProfile::observeLHSAndRHS):
(JSC::BinaryArithProfile::isObservedTypeEmpty):

• bytecode/BytecodeList.rb:
• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::addJITAddIC):
(JSC::CodeBlock::addJITMulIC):
(JSC::CodeBlock::addJITSubIC):
(JSC::CodeBlock::addJITNegIC):
(JSC::CodeBlock::binaryArithProfileForBytecodeOffset):
(JSC::CodeBlock::unaryArithProfileForBytecodeOffset):
(JSC::CodeBlock::binaryArithProfileForPC):
(JSC::CodeBlock::unaryArithProfileForPC):
(JSC::CodeBlock::couldTakeSpecialFastCase):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::addMathIC):

• bytecode/Fits.h:
• bytecode/MethodOfGettingAValueProfile.cpp:

(JSC::MethodOfGettingAValueProfile::emitReportValue const):
(JSC::MethodOfGettingAValueProfile::reportValue):

• bytecode/MethodOfGettingAValueProfile.h:

(JSC::MethodOfGettingAValueProfile::MethodOfGettingAValueProfile):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitUnaryOp):

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::UnaryOpNode::emitBytecode):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileValueSub):
(JSC::DFG::SpeculativeJIT::compileValueNegate):
(JSC::DFG::SpeculativeJIT::compileValueMul):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMul):
(JSC::FTL::DFG::LowerDFGToB3::compileUnaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueNegate):

• jit/JIT.h:
• jit/JITAddGenerator.cpp:

(JSC::JITAddGenerator::generateInline):
(JSC::JITAddGenerator::generateFastPath):

• jit/JITAddGenerator.h:
• jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitMathICFast):
(JSC::JIT::emitMathICSlow):
(JSC::JIT::emit_op_div):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_sub):

• jit/JITDivGenerator.cpp:

(JSC::JITDivGenerator::generateFastPath):

• jit/JITDivGenerator.h:

(JSC::JITDivGenerator::JITDivGenerator):

• jit/JITInlines.h:

(JSC::JIT::copiedArithProfile):

• jit/JITMathIC.h:

(JSC::JITMathIC::JITMathIC):
(JSC::JITMathIC::generateInline):
(JSC::JITMathIC::arithProfile const):
(JSC::isBinaryProfileEmpty):
(JSC::JITBinaryMathIC::JITBinaryMathIC):
(JSC::isUnaryProfileEmpty):
(JSC::JITUnaryMathIC::JITUnaryMathIC):

• jit/JITMulGenerator.cpp:

(JSC::JITMulGenerator::generateInline):
(JSC::JITMulGenerator::generateFastPath):

• jit/JITMulGenerator.h:
• jit/JITNegGenerator.cpp:

(JSC::JITNegGenerator::generateInline):
(JSC::JITNegGenerator::generateFastPath):

• jit/JITNegGenerator.h:
• jit/JITOperations.cpp:
• jit/JITOperations.h:
• jit/JITSubGenerator.cpp:

(JSC::JITSubGenerator::generateInline):
(JSC::JITSubGenerator::generateFastPath):

• jit/JITSubGenerator.h:
• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

• llint/LLIntOffsetsExtractor.cpp:

(JSC::LLIntOffsetsExtractor::dummy):

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• parser/ResultType.h:

(JSC::ResultType::ResultType):

• runtime/CommonSlowPaths.cpp:

(JSC::updateArithProfileForUnaryArithOp):
(JSC::updateArithProfileForBinaryArithOp):
(JSC::SLOW_PATH_DECL):

6:45 PM Changeset in webkit [252228] by Chris Dumez

• 6 edits in trunk

TestController may reuse a view that used window.open(), which prevents process-swapping and causes flakiness
​https://bugs.webkit.org/show_bug.cgi?id=203981

Reviewed by Ryosuke Niwa.

Tools:

Stop reusing WebViews that have created other WebViews (via window.open()) since this prevents process-swapping
and may therefore cause flakiness (see Bug 203965).

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::ensureViewSupportsOptionsForTest):

• WebKitTestRunner/TestController.h:

LayoutTests:

Drop temporary flakiness workaround that was landed in r252214.

• http/tests/inspector/target/target-events-for-provisional-page.html:

6:35 PM Changeset in webkit [252227] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Use ActiveDOMObject::queueTaskKeepingObjectAlive() in DOMCache
​https://bugs.webkit.org/show_bug.cgi?id=203985

Reviewed by Ryosuke Niwa.

Use ActiveDOMObject::queueTaskKeepingObjectAlive() in DOMCache and drop DOMCache::enqueueTask().

• Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::match):
(WebCore::DOMCache::matchAll):
(WebCore::DOMCache::addAll):
(WebCore::DOMCache::putWithResponseData):
(WebCore::DOMCache::put):
(WebCore::DOMCache::remove):
(WebCore::DOMCache::keys):
(WebCore::DOMCache::enqueueTask): Deleted.

• Modules/cache/DOMCache.h:

5:38 PM Changeset in webkit [252226] by commit-queue@webkit.org

• 16 edits
  6 adds in trunk/Source/WebCore

Please support WEBGL_compressed_texture_etc1 extension (and possibly WEBGL_compressed_texture_etc too)
​https://bugs.webkit.org/show_bug.cgi?id=197900

Patch by Kenneth Russell <​kbr@chromium.org> on 2019-11-07
Reviewed by Dean Jackson.

Support the ETC1 and ETC2 compressed texture formats in WebKit's WebGL
implementation.

Tested by changing the code to allocate an OpenGL ES 3.0 context for WebGL,
and running in the iOS Simulator. The WebGL conformance tests
webgl-compressed-texture-etc.html and webgl-compressed-texture-etc1.html all
pass with these changes.

When an ANGLE backend is supported on iOS, these extensions will
automatically be supported, and some of the new validation code can be
removed.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

• html/canvas/WebGLCompressedTextureETC.cpp: Added.

(WebCore::WebGLCompressedTextureETC::WebGLCompressedTextureETC):
(WebCore::WebGLCompressedTextureETC::getName const):
(WebCore::WebGLCompressedTextureETC::supported):

• html/canvas/WebGLCompressedTextureETC.h: Added.
• html/canvas/WebGLCompressedTextureETC.idl: Added.
• html/canvas/WebGLCompressedTextureETC1.cpp: Added.

(WebCore::WebGLCompressedTextureETC1::WebGLCompressedTextureETC1):
(WebCore::WebGLCompressedTextureETC1::getName const):
(WebCore::WebGLCompressedTextureETC1::supported):

• html/canvas/WebGLCompressedTextureETC1.h: Added.
• html/canvas/WebGLCompressedTextureETC1.idl: Added.
• html/canvas/WebGLExtension.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContextBase::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContextBase::validateCompressedTexSubDimensions):

• html/canvas/WebGLRenderingContextBase.h:
• platform/graphics/Extensions3D.h:
• platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

• platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension):

5:35 PM Changeset in webkit [252225] by Justin Fan

• 3 edits
  20 adds in trunk/LayoutTests

[WebGL] Fixing WebGL tests: Add new baselines for iOS bots
​https://bugs.webkit.org/show_bug.cgi?id=203938

Unreviewed test expectation gardening.

Follow-up to ​https://bugs.webkit.org/show_bug.cgi?id=203908.
New baselines for iOS tests generated from simulator.

• TestExpectations:
• platform/ios/TestExpectations:
• platform/ios/webgl/1.0.3/conformance/extensions/get-extension-expected.txt: Added.
• platform/ios/webgl/1.0.3/conformance/extensions/oes-texture-float-expected.txt: Added.
• platform/ios/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt: Added.
• platform/ios/webgl/1.0.3/conformance/extensions/webgl-draw-buffers-expected.txt: Added.
• platform/ios/webgl/1.0.3/conformance/more/functions/readPixelsBadArgs-expected.txt: Added.
• platform/ios/webgl/1.0.3/conformance/more/functions/texImage2DHTML-expected.txt: Added.
• platform/ios/webgl/1.0.3/conformance/more/functions/texSubImage2DHTML-expected.txt: Added.
• platform/ios/webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added.
• platform/ios/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt: Added.
• platform/ios/webgl/1.0.3/conformance/textures/texture-npot-video-expected.txt: Added.
• platform/ios/webgl/2.0.0/conformance/extensions/angle-instanced-arrays-expected.txt: Added.
• platform/ios/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt: Added.

5:29 PM Changeset in webkit [252224] by ysuzuki@apple.com

• 2 edits in trunk/Source/bmalloc

[bmalloc] Bug fix for wait time when it's in mini mode.
​https://bugs.webkit.org/show_bug.cgi?id=203121

Reviewed by Saam Barati.

Basuke pointed out that we never changed m_waitTime in scavenger when we are in iOS and mini-mode.
So previously, we are always executing scavenger for each 10ms in mini-mode. After fixing it, we
found that this unintentional behavior was better policy for RAMification.
In this patch, we explicitly use the old behavior, "scavenge for each 10ms" in iOS mini-mode.
We should revisit scavenger's behavior in the future to explore further better behavior.

• bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::threadRunLoop):

5:18 PM Changeset in webkit [252223] by timothy_horton@apple.com

• 2 edits
  1 delete in trunk/Source/WebKit

Remove an unused icon resource
​https://bugs.webkit.org/show_bug.cgi?id=203983

Reviewed by Wenson Hsieh.

• Resources/mac/mediaIcon.pdf: Removed.
• WebKit.xcodeproj/project.pbxproj:

This file has not been used in years.

5:15 PM Changeset in webkit [252222] by Justin Fan

• 1 edit
  1 add in trunk/LayoutTests

webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=203984

Unreviewed test expectation addition.

Skip context-release-upon-reload.html on High Sierra WK1 debug bots.

• platform/mac-highsierra-wk1/TestExpectations: Added.

5:13 PM Changeset in webkit [252221] by rniwa@webkit.org

• 8 edits
  7 adds in trunk

WindowEventLoop should be shared among similar origin documents
​https://bugs.webkit.org/show_bug.cgi?id=203882

Reviewed by Wenson Hsieh.

Source/WebCore:

Made WindowEventLoop shared across similar origin documents.

Also added internals.queueTask to directly test the event loop behavior
since implicitly testing it via other features has been very cumbersome.

This will help test other features that use the HTML5 event loop as well.

Tests: http/tests/eventloop/queue-task-across-cross-site-frames.html

http/tests/eventloop/queue-task-across-frames.html

• dom/Document.cpp:

(WebCore::Document::eventLoop): Use WindowEventLoop::ensureForRegistrableDomain.

• dom/WindowEventLoop.cpp:

(WebCore::WindowEventLoop::ensureForRegistrableDomain): Added. Replaces create,
and returns an existing WindowEventLoop if the RegistrableDomain matches.
(WebCore::WindowEventLoop::WindowEventLoop): Added.
(WebCore::WindowEventLoop::~WindowEventLoop): Added. Removes itself from the map.

• dom/WindowEventLoop.h:
• testing/Internals.cpp:

(WebCore::Internals::queueTask): Added.

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

Added some tests to make sure the event loop is shared among similar origin documents.

• http/tests/eventloop: Added.
• http/tests/eventloop/queue-task-across-cross-site-frames-expected.txt: Added.
• http/tests/eventloop/queue-task-across-cross-site-frames.html: Added.
• http/tests/eventloop/queue-task-across-frames-expected.txt: Added.
• http/tests/eventloop/queue-task-across-frames.html: Added.
• http/tests/eventloop/resources: Added.
• http/tests/eventloop/resources/eventloop-helper.html: Added.

5:08 PM Changeset in webkit [252220] by Alan Coon

• 7 edits in tags/Safari-609.1.10.1/Source

Versioning.

5:04 PM Changeset in webkit [252219] by Alan Coon

• 1 copy in tags/Safari-609.1.10.1

New tag.

4:57 PM Changeset in webkit [252218] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Drop GenericEventQueue class now that it is unused
​https://bugs.webkit.org/show_bug.cgi?id=203980

Reviewed by Ryosuke Niwa.

Drop GenericEventQueue class now that it is unused. All users have been ported to the HTML
event loop. MainThreadGenericEventQueue remains for now but will get dropped in a follow-up
patch, once it is no longer used.

• dom/GenericEventQueue.cpp:

(WebCore::MainThreadGenericEventQueue::MainThreadGenericEventQueue):
(WebCore::MainThreadGenericEventQueue::enqueueEvent):
(WebCore::MainThreadGenericEventQueue::dispatchOneEvent):
(WebCore::MainThreadGenericEventQueue::close):
(WebCore::MainThreadGenericEventQueue::cancelAllEvents):
(WebCore::MainThreadGenericEventQueue::hasPendingEvents const):
(WebCore::MainThreadGenericEventQueue::hasPendingEventsOfType const):
(WebCore::MainThreadGenericEventQueue::setPaused):
(WebCore::MainThreadGenericEventQueue::suspend):
(WebCore::MainThreadGenericEventQueue::resume):
(WebCore::MainThreadGenericEventQueue::rescheduleAllEventsIfNeeded):
(WebCore::MainThreadGenericEventQueue::stop):
(WebCore::MainThreadGenericEventQueue::activeDOMObjectName const):
(WebCore::TaskQueueConstructor::construct): Deleted.
(WebCore::TaskQueueConstructor<Timer>::construct): Deleted.
(WebCore::GenericEventQueueBase<T>::GenericEventQueueBase): Deleted.
(WebCore::GenericEventQueueBase<T>::enqueueEvent): Deleted.
(WebCore::GenericEventQueueBase<T>::dispatchOneEvent): Deleted.
(WebCore::GenericEventQueueBase<T>::close): Deleted.
(WebCore::GenericEventQueueBase<T>::cancelAllEvents): Deleted.
(WebCore::GenericEventQueueBase<T>::hasPendingEvents const): Deleted.
(WebCore::GenericEventQueueBase<T>::hasPendingEventsOfType const): Deleted.
(WebCore::GenericEventQueueBase<T>::setPaused): Deleted.
(WebCore::GenericEventQueueBase<T>::suspend): Deleted.
(WebCore::GenericEventQueueBase<T>::resume): Deleted.
(WebCore::GenericEventQueueBase<T>::rescheduleAllEventsIfNeeded): Deleted.
(WebCore::GenericEventQueueBase<T>::stop): Deleted.
(WebCore::GenericEventQueueBase<T>::activeDOMObjectName const): Deleted.
(WebCore::GenericEventQueue::create): Deleted.

• dom/GenericEventQueue.h:

(WebCore::GenericEventQueueBase::isSuspended const): Deleted.
(WebCore::GenericEventQueueBase::isSuspendedOrPausedByClient const): Deleted.
(WebCore::MainThreadGenericEventQueue::MainThreadGenericEventQueue): Deleted.
(WebCore::GenericEventQueue::GenericEventQueue): Deleted.

4:52 PM Changeset in webkit [252217] by youenn@apple.com

• 4 edits in trunk/LayoutTests

Layout Test http/tests/appcache/remove-cache.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=199124
<rdar://problem/52008712>

Reviewed by Chris Dumez.

The flakiness probably comes from the use of a setTimeout that might kick in while in most runs, it never kicks in.
When the timer kicks in, the test is reloaded, which triggers a new console log line.
The current console lines do not bring more values than what the test checks with appcache events.
Removing console log lines from the expected file will fix the flakiness.

• TestExpectations:
• http/tests/appcache/remove-cache-expected.txt:
• platform/mac/TestExpectations:

4:37 PM Changeset in webkit [252216] by Tadeu Zagallo

• 2 edits in trunk/Source/JavaScriptCore

[WebAssembly] Inspector's DebuggerCallFrame should be aware of Wasm frames
​https://bugs.webkit.org/show_bug.cgi?id=203925

Reviewed by Mark Lam.

The DebuggerCallFrame checks for CallFrame::codeBlock to determine if it the current frame is a
valid JS frame, but since the Wasm interpreter stores the Wasm::FunctionCodeBlock to this slot,
that check is not sufficient. Add an extra check for CalleeBits::isWasm.

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::sourceIDForCallFrame):

3:56 PM Changeset in webkit [252215] by Alan Coon

• 1 copy in tags/Safari-608.4.9.1.2

Tag Safari-608.4.9.1.2.

3:44 PM Changeset in webkit [252214] by yurys@chromium.org

• 2 edits in trunk/LayoutTests

Web Inspector: http/tests/inspector/target/target-events-for-provisional-page.html is flaky when running with other tests
​https://bugs.webkit.org/show_bug.cgi?id=203965
<rdar://problem/56988642>

Reviewed by Devin Rousso.

Enforce enableProcessSwapOnWindowOpen=true for the test so that it PSON is enabled regardless of other tests
that may run before (the test may reuse Page instance from the previous test on which
Page::openedByDOMWithOpener==true).

• http/tests/inspector/target/target-events-for-provisional-page.html:

3:39 PM Changeset in webkit [252213] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r251958): console prompt is automatically focused when page is reloaded
​https://bugs.webkit.org/show_bug.cgi?id=203932

Reviewed by Timothy Hatcher.

• UserInterface/Base/Main.js:

(WI._restoreCookieForOpenTabs):
Only attempt to autofocus when Web Inspector is first opened.

3:24 PM Changeset in webkit [252212] by Chris Dumez

• 5 edits in trunk/Source/WebCore

Port Worker to the HTML5 event loop
​https://bugs.webkit.org/show_bug.cgi?id=203919

Reviewed by Ryosuke Niwa.

• dom/ActiveDOMObject.h:
• workers/Worker.cpp:

(WebCore::Worker::Worker):
(WebCore::Worker::terminate):
(WebCore::Worker::hasPendingActivity const):
(WebCore::Worker::notifyFinished):
(WebCore::Worker::dispatchEvent):
(WebCore::Worker::enqueueEvent): Deleted.

• workers/Worker.h:
• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):

3:20 PM Changeset in webkit [252211] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] Add logging and telemetry to more mach lookup rules
​https://bugs.webkit.org/show_bug.cgi?id=203978

Reviewed by Brent Fulgham.

Add logging and telemetry to help determine if mach lookup of these services can be denied in the WebContent process.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

3:16 PM Changeset in webkit [252210] by Kate Cheney

• 18 edits in trunk/LayoutTests

Many resourceLoadStatistics tests and storageAccess tests using the ITP
Database redirect to the corresponding memory store test after setting
a cookie
​https://bugs.webkit.org/show_bug.cgi?id=203958
<rdar://problem/56984114>

Reviewed by John Wilander.

This patch fixes incorrect redirects in some ITP database store tests.
They should redirect back to themselves as opposed to corresponding
memory store tests to be sure they are testing the correct
functionality.

• http/tests/resourceLoadStatistics/add-blocking-to-redirect-database.html:
• http/tests/resourceLoadStatistics/blocking-in-web-worker-script-import-database.html:
• http/tests/resourceLoadStatistics/cookie-deletion-database.html:
• http/tests/resourceLoadStatistics/cookies-with-and-without-user-interaction-database.html:
• http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations-database.html:
• http/tests/resourceLoadStatistics/downgraded-referrer-for-navigation-with-link-query-from-prevalent-resource-database.html:
• http/tests/resourceLoadStatistics/grandfathering-database.html:
• http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context-database.html:
• http/tests/resourceLoadStatistics/ping-to-prevalent-resource-database.html:
• http/tests/storageAccess/deny-due-to-no-interaction-under-general-third-party-cookie-blocking-database.html:
• http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking-database.html:
• http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-database.html:
• http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral-database.html:
• http/tests/storageAccess/has-storage-access-under-general-third-party-cookie-blocking-with-cookie-database.html:
• http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access-database.html:
• http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access-database.html:
• http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access-database.html:

3:16 PM Changeset in webkit [252209] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Port MessagePort to the HTML5 event loop
​https://bugs.webkit.org/show_bug.cgi?id=203960

Reviewed by Ryosuke Niwa.

• dom/MessagePort.cpp:

(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::close):
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::dispatchEvent):

• dom/MessagePort.h:
• dom/TaskSource.h:

3:01 PM Changeset in webkit [252208] by Antti Koivisto

• 11 edits
  2 adds in trunk/Source/WebCore

Factor matched declarations cache into a class
​https://bugs.webkit.org/show_bug.cgi?id=203972

Reviewed by Zalan Bujtas.

Move the code out from StyleResolver and rename "matched properties cache" -> "matched declarations cache"
to better describe it.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::declarationsForOrigin):

Add a helper.

(WebCore::ElementRuleCollector::transferMatchedRules):

Reserve vector capacity before adding rules.

(WebCore::ElementRuleCollector::addMatchedProperties):

• css/ElementRuleCollector.h:

(WebCore::MatchResult::operator== const):
(WebCore::MatchResult::operator!= const):

Remove the unneeded inline capacity so we can just use MatchResult itself in the cache.

• css/RuleSet.cpp:

(WebCore::RuleSet::addChildRules):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::invalidateMatchedDeclarationsCache):
(WebCore::StyleResolver::clearCachedDeclarationsAffectedByViewportUnits):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::sweepMatchedPropertiesCache): Deleted.
(WebCore::StyleResolver::computeMatchedPropertiesHash): Deleted.
(WebCore::StyleResolver::findFromMatchedPropertiesCache): Deleted.
(WebCore::StyleResolver::addToMatchedPropertiesCache): Deleted.
(WebCore::StyleResolver::invalidateMatchedPropertiesCache): Deleted.
(WebCore::StyleResolver::clearCachedPropertiesAffectedByViewportUnits): Deleted.
(WebCore::isCacheableInMatchedPropertiesCache): Deleted.

• css/StyleResolver.h:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::MatchedPropertiesCacheItem): Deleted.

• dom/Document.cpp:

(WebCore::Document::invalidateMatchedPropertiesCacheAndForceStyleRecalc):
(WebCore::Document::updateViewportUnitsOnResize):

• page/Page.cpp:

(WebCore::Page::updateStyleAfterChangeInEnvironment):

• style/MatchedDeclarationsCache.cpp: Added.

(WebCore::Style::MatchedDeclarationsCache::MatchedDeclarationsCache):
(WebCore::Style::MatchedDeclarationsCache::isCacheable):
(WebCore::Style::MatchedDeclarationsCache::computeHash):
(WebCore::Style::MatchedDeclarationsCache::find):
(WebCore::Style::MatchedDeclarationsCache::add):
(WebCore::Style::MatchedDeclarationsCache::invalidate):
(WebCore::Style::MatchedDeclarationsCache::clearEntriesAffectedByViewportUnits):
(WebCore::Style::MatchedDeclarationsCache::sweep):

• style/MatchedDeclarationsCache.h: Added.
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):

2:53 PM Changeset in webkit [252207] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

UserMediaController::from(document) can return nullptr
​https://bugs.webkit.org/show_bug.cgi?id=203977
<rdar://problem/56908013>

Reviewed by Jer Noble.

• Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::stop): NULL-check the UserMediaController.

2:36 PM Changeset in webkit [252206] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Port ServiceWorkerContainer to the HTML5 event loop
​https://bugs.webkit.org/show_bug.cgi?id=203963

Reviewed by Ryosuke Niwa.

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::startMessages):
(WebCore::ServiceWorkerContainer::postMessage):

• workers/service/ServiceWorkerContainer.h:

2:18 PM Changeset in webkit [252205] by rniwa@webkit.org

• 16 edits
  4 adds in trunk

Integrate scroll event into HTML5 event loop
​https://bugs.webkit.org/show_bug.cgi?id=203839
<rdar://problem/56890922>

Reviewed by Simon Fraser.

Source/WebCore:

Dispatch scroll events on each pending scroll event targets inside the update-the-rendering step
of the event loop as specified in the HTML5 and CSSOM View Module specifications:
​https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering
​https://drafts.csswg.org/cssom-view/#run-the-scroll-steps

The new behavior also matches that of Chrome and Firefox.

Like resize event, the current visual viewport specification does not specify when scroll event
is dispatched on visualViewport interface: ​https://github.com/WICG/visual-viewport/issues/66
For now, we always dispatch upon it after dispatching on all pending scroll event targets.

Tests: fast/events/scroll-multiple-elements-in-rendering-update.html

fast/events/scroll-subframe-in-rendering-update.html
fast/visual-viewport/visual-viewport-scroll-after-resize-in-subframe.html

• dom/Document.cpp:

(WebCore::Document::addPendingScrollEventTarget): Added.
(WebCore::Document::setNeedsVisualViewportScrollEvent): Added.
(WebCore::Document::runScrollSteps): Added. This implements run the scroll steps in CSS OM View.

• dom/Document.h:
• dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent): Deleted.
(WebCore::DocumentEventQueue::enqueueScrollEvent): Deleted.

• dom/DocumentEventQueue.h:
• page/EventHandler.cpp:

(WebCore::EventHandler::sendScrollEvent):

• page/Page.cpp:

(WebCore::Page::updateRendering): Invoke runScrollSteps on each document in the frame tree order.

• page/VisualViewport.cpp:

(WebCore::VisualViewport::update):
(WebCore::VisualViewport::enqueueScrollEvent): Deleted.

• page/VisualViewport.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollTo):

LayoutTests:

Added tests to test the timing at which scroll events are fired across multiple elements and documents,
and with visualViewport, and updated the existing tests to work with the new timing.

• editing/selection/overflow-scroll-while-selecting-text.html:
• fast/events/scroll-multiple-elements-in-rendering-update-expected.txt: Added.
• fast/events/scroll-multiple-elements-in-rendering-update.html: Added.
• fast/events/scroll-subframe-in-rendering-update-expected.txt: Added.
• fast/events/scroll-subframe-in-rendering-update.html: Added.
• fast/scrolling/programmatic-scroll-to-negative-offset.html:
• fast/shadow-dom/trusted-event-scoped-flags.html:
• fast/visual-viewport/visual-viewport-scroll-after-resize-in-subframe-expected.txt: Added.
• fast/visual-viewport/visual-viewport-scroll-after-resize-in-subframe.html: Added.
• tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html:

1:34 PM Changeset in webkit [252204] by Justin Fan

• 5 edits in trunk/LayoutTests

REGRESSION: r252121 introduced timeout in webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html
​https://bugs.webkit.org/show_bug.cgi?id=203949

Unreviewed test expectation gardening.

shader-with-non-reserved-words takes dozens of minutes to pass. Skip everywhere.

• platform/gtk/TestExpectations:
• platform/ios-simulator-wk2/TestExpectations:
• platform/mac/TestExpectations:
• platform/wpe/TestExpectations:

1:07 PM Changeset in webkit [252203] by Simon Fraser

• 4 edits in trunk/LayoutTests

REGRESSION (r252161): 3 transitions/ tests time-out
​https://bugs.webkit.org/show_bug.cgi?id=203966

Reviewed by Dean Jackson.

Fix the shadow parsing code to deal with non-integral values.

• legacy-animation-engine/transitions/resources/transition-test-helpers.js:

(isShadow):

• transitions/resources/transition-test-helpers.js:

(isShadow):

12:36 PM Changeset in webkit [252202] by Devin Rousso

• 10 edits
  2 copies
  5 moves
  48 adds
  3 deletes in trunk

Web Inspector: REGRESSION(r250087): inspector/model/remote-object.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=202934
<rdar://problem/56270900>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

In r250087, the inspector injected script was changed so that remote objects actually
iterate the keys of an array and generate a property descriptor for each. While this worked
fine (and was performant) for fetching remote objects, this was not efficient when creating
object previews, as that path wouldn't be limited by any sort of fetchCount, meaning that
a descriptor for every index would be created even though only the first 10 would be used.

Refactor the inspector injected script code so that both the fetch and preview paths only
examine exactly the number of properties desired instead of considering all of them and then
slicing to fit.

• inspector/InjectedScriptSource.js:

(InjectedScript.prototype._getProperties):
(InjectedScript.prototype._forEachPropertyDescriptor): Added.
(InjectedScript.prototype._forEachPropertyDescriptor.createFakeValueDescriptor): Added.
(InjectedScript.prototype._forEachPropertyDescriptor.processDescriptor): Added.
(InjectedScript.prototype._forEachPropertyDescriptor.processProperty): Added.
(RemoteObject.prototype._generatePreview):
(RemoteObject.prototype._appendPropertyPreview): Added.
(RemoteObject.prototype._appendPropertyPreview.appendPreview): Added.
(InjectedScript.prototype._propertyDescriptors): Deleted.
(InjectedScript.prototype._propertyDescriptors.processProperties): Deleted.
(InjectedScript.prototype._propertyDescriptors.arrayIndexPropertyNames): Deleted.
(RemoteObject.prototype._appendPropertyPreviews): Deleted.

Source/WebInspectorUI:

• UserInterface/Views/ObjectTreeView.js:

(WI.ObjectTreeView.addShowMoreIfNeeded):
Drive-by: ensure that the indeterminate progress spinner is added after the last button.

LayoutTests:

Split inspector/model/remote-object.html into separate tests for each type of object being
tested, as well as specialized tests for extremely large values. This allows us to better
know which specific expression can cause a timeout.

• inspector/model/remote-object.html: Removed.
• inspector/model/remote-object-expected.txt: Removed.
• platform/mac-wk1/inspector/model/remote-object-expected.txt: Removed.

• inspector/model/remote-object/array.html: Added.
• inspector/model/remote-object/array-expected.txt: Added.
• inspector/model/remote-object/array-large.html: Added.
• inspector/model/remote-object/array-large-expected.txt: Added.
• inspector/model/remote-object/boolean.html: Added.
• inspector/model/remote-object/boolean-expected.txt: Added.
• inspector/model/remote-object/class.html: Added.
• inspector/model/remote-object/class-expected.txt: Added.
• inspector/model/remote-object/date.html: Added.
• inspector/model/remote-object/date-expected.txt: Added.
• inspector/model/remote-object/error.html: Added.
• inspector/model/remote-object/error-expected.txt: Added.
• inspector/model/remote-object/function.html: Added.
• inspector/model/remote-object/function-expected.txt: Added.
• inspector/model/remote-object/immutable.html: Added.
• inspector/model/remote-object/immutable-expected.txt: Added.
• inspector/model/remote-object/iterator.html: Added.
• inspector/model/remote-object/iterator-expected.txt: Added.
• inspector/model/remote-object/iterator-large.html: Added.
• inspector/model/remote-object/iterator-large-expected.txt: Added.
• inspector/model/remote-object/map.html: Added.
• inspector/model/remote-object/map-expected.txt: Added.
• inspector/model/remote-object/map-large.html: Added.
• inspector/model/remote-object/map-large-expected.txt: Added.
• inspector/model/remote-object/null.html: Added.
• inspector/model/remote-object/null-expected.txt: Added.
• inspector/model/remote-object/number.html: Added.
• inspector/model/remote-object/number-expected.txt: Added.
• platform/mac-wk1/inspector/number-expected.txt: Added.
• inspector/model/remote-object/object.html: Added.
• inspector/model/remote-object/object-expected.txt: Added.
• inspector/model/remote-object/object-large.html: Added.
• inspector/model/remote-object/object-large-expected.txt: Added.
• inspector/model/remote-object/promise.html: Added.
• inspector/model/remote-object/promise-expected.txt: Added.
• inspector/model/remote-object/regexp.html: Added.
• inspector/model/remote-object/regexp-expected.txt: Added.
• inspector/model/remote-object/set.html: Added.
• inspector/model/remote-object/set-expected.txt: Added.
• inspector/model/remote-object/set-large.html: Added.
• inspector/model/remote-object/set-large-expected.txt: Added.
• inspector/model/remote-object/string.html: Added.
• inspector/model/remote-object/string-expected.txt: Added.
• inspector/model/remote-object/string-large.html: Added.
• inspector/model/remote-object/string-large-expected.txt: Added.
• inspector/model/remote-object/undefined.html: Added.
• inspector/model/remote-object/undefined-expected.txt: Added.

• inspector/model/remote-object/dom.html: Renamed from LayoutTests/inspector/model/remote-object-dom.html.
• inspector/model/remote-object/dom-expected.txt: Renamed from LayoutTests/inspector/model/remote-object-dom-expected.txt.
• inspector/model/remote-object/iterators-mutated.html: Renamed from LayoutTests/inspector/model/remote-object-mutated-iterators.html.
• inspector/model/remote-object/iterators-mutated-expected.txt: Renamed from LayoutTests/inspector/model/remote-object-mutated-iterators-expected.txt.

• inspector/model/remote-object/resources/remote-object-utilities.js: Renamed from LayoutTests/inspector/model/resources/remote-object-utilities.js.

• inspector/runtime/getDisplayableProperties.html:
• inspector/runtime/getDisplayableProperties-expected.txt:
• inspector/runtime/getProperties.html:
• inspector/runtime/getProperties-expected.txt:

Drive-by: fix assertion for when the __proto__ is included if fetchStart is 0.

• TestExpectations:

12:31 PM Changeset in webkit [252201] by Devin Rousso

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r249451): missing "Reveal in DOM Tree" on nodes logged to the console
​https://bugs.webkit.org/show_bug.cgi?id=203836

Reviewed by Timothy Hatcher.

• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForDOMNode):

• UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype.populateContextMenu):
DOM trees in the console are marked as being non-editable, which is intended to prevent
modifications (e.g. changing an attribute) from being made in the console as the DOM tree
there is not hooked up to the associated DOM agent. In r249451 however, this guard was over
expanded to include non-editing actions, like "Reveal in DOM Tree" and DOM breakpoints.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype._handleContextMenuEvent):
Drive-by: add a separator before "Copy Selected" so it doesn't end up in the same group as

any "Collapse All" from a WI.TreeOutline.

12:17 PM Changeset in webkit [252200] by Devin Rousso

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Local Resource Overrides: automatically show a file picker when attempting to create an override for non-text resources
​https://bugs.webkit.org/show_bug.cgi?id=203917

Reviewed by Timothy Hatcher.

Since there's no way to edit non-text resources (e.g. images, fonts, etc.) in Web Inspector,
when creating a local override for non-text resources, default to showing a file picker and
creating a local override from the content and MIME type of whatever file is chosen.

Still provide a way (shift-click) to create a local override for non-text resources from the
resource's contents, as that can be useful if the user just wants to change some headers.

• UserInterface/Models/Resource.js:

(WI.Resource.prototype.async createLocalResourceOverride):

• UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView):
(WI.ResourceContentView.prototype.get createLocalResourceOverrideTooltip): Added.
(WI.ResourceContentView.prototype.requestLocalResourceOverrideInitialContent): Added.
(WI.ResourceContentView.prototype.async _getContentForLocalResourceOverrideFromFile): Added.
(WI.ResourceContentView.prototype._handleCreateLocalResourceOverride):
(WI.ResourceContentView.prototype._handleImportLocalResourceOverride):
(WI.ResourceContentView.prototype.localResourceOverrideInitialContent): Deleted.
(WI.ResourceContentView.prototype.async _handleCreateLocalResourceOverride): Deleted.

• UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype.get createLocalResourceOverrideTooltip): Added.
(WI.TextResourceContentView.prototype.requestLocalResourceOverrideInitialContent): Added.
(WI.TextResourceContentView.prototype.localResourceOverrideInitialContent): Deleted.

• Localizations/en.lproj/localizedStrings.js:

12:02 PM Changeset in webkit [252199] by Devin Rousso

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: add a marker for when a stop was requested
​https://bugs.webkit.org/show_bug.cgi?id=203935

Reviewed by Timothy Hatcher.

After r244195, the Web Inspector frontend doesn't stop updating the current time marker
until after it receives all of the corresponding *.trackingComplete events. This means
that sometimes, the current time marker can move far past the time at which the stop was
requested, such as if there's a blocking script.

We should indicate where the stop was requested, as that is often right after a particular
issue is reproduced during a timeline recording, rather than have the user try to figure out
where they stopped.

Only keep a marker for the last stop request, and hide the marker once capturing resumes.

It's still useful to have the current time marker continue updating, as we should show all
the information we have about captured things, such as blocking scripts.

• UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview):
(WI.TimelineOverview.prototype._handleTimelineCapturingStateChanged):

• UserInterface/Models/TimelineMarker.js:
• UserInterface/Views/TimelineRuler.js:

(WI.TimelineRuler.prototype.addMarker):

• UserInterface/Views/TimelineRuler.css:

(.timeline-ruler > .markers > .marker.stopping-time): Added.
(.timeline-ruler > .markers > .marker.current-time):
(.timeline-ruler > .markers > .marker:matches(.stopping-time, .current-time)::after): Added.
(@media (prefers-color-scheme: dark) .timeline-ruler > .markers > .marker.stopping-time): Added.
(.timeline-ruler > .markers > .marker.current-time::after): Deleted.
Make the current time marker always on top (z-index).

• Localizations/en.lproj/localizedStrings.js:

11:59 AM Changeset in webkit [252198] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r251958): automatic console prompt focusing prevents any "space" shortcuts from working
​https://bugs.webkit.org/show_bug.cgi?id=203939

Reviewed by Timothy Hatcher.

• UserInterface/Base/Main.js:

(WI.isShowingTimelineTab): Added.
(WI.isShowingAuditTab): Added.
(WI._restoreCookieForOpenTabs):

11:46 AM Changeset in webkit [252197] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: Unable to get object details - GlobalObject
​https://bugs.webkit.org/show_bug.cgi?id=203930
<rdar://problem/56960937>

In r248286, calls to Heap.snapshot, Heap.getPreview, and Heap.getRemoteObject were
moved to the WI.HeapManager instead of being inside view code. During this move, extra
WI.reportInternalError calls were added, which wasn't entirely correct as it is fully
possible (and expected) that any of these commands are invoked with old heap snapshot nodes
that may no longer exist. As such, calling any error an "internal error" isn't strictly
correct, and instead should just be a log. Also, the frontend code that calls these commands
is able to handle errors, again because it is expected.

Reviewed by Brian Burg.

• UserInterface/Controllers/HeapManager.js:

(WI.HeapManager.prototype.snapshot):
(WI.HeapManager.prototype.getPreview):
(WI.HeapManager.prototype.getRemoteObject):

11:42 AM Changeset in webkit [252196] by commit-queue@webkit.org

• 4 edits in trunk

JSTests:
didPassSomeTestsSilenty is misspelled in standalone-pre.js
​https://bugs.webkit.org/show_bug.cgi?id=203948

Patch by Tuomas Karkkainen <​tuomas.webkit@apple.com> on 2019-11-07
Reviewed by Yusuke Suzuki.

• stress/resources/standalone-pre.js:

LayoutTests:
didPassSomeTestsSilenty and didFaileSomeTests are misspelled in standalone-pre.js
​https://bugs.webkit.org/show_bug.cgi?id=203948

Patch by Tuomas Karkkainen <​tuomas.webkit@apple.com> on 2019-11-07
Reviewed by Yusuke Suzuki.

• resources/standalone-pre.js:

11:24 AM Changeset in webkit [252195] by Ross Kirsling

• 3 edits in trunk/JSTests

Unskip test262 tests for async-iteration
​https://bugs.webkit.org/show_bug.cgi?id=203921

Reviewed by Keith Miller.

This should have been done two years ago, it seems.

• test262/config.yaml:
• test262/expectations.yaml:

11:16 AM Changeset in webkit [252194] by Alan Coon

• 13 edits
  1 move
  2 adds in branches/safari-608-branch/Source

Cherry-pick r252175. rdar://problem/56971561

AX: WKWebView does not shift Accessibility Focus for Catalyst (203798)
​https://bugs.webkit.org/show_bug.cgi?id=203798

Patch by Eric Liang <​ericliang@apple.com> on 2019-11-06
Reviewed by Chris Fleizach.

Source/WebCore:

Changed to use the new cocoa directory instead of macOS only

• accessibility/mac/AXObjectCacheMac.mm:
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

Source/WebCore/PAL:

Changed the path of NSAccessibilitySPI from Mac to Cocoa

• PAL.xcodeproj/project.pbxproj:
• pal/spi/cocoa/NSAccessibilitySPI.h: Renamed from Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h.

Source/WebKit:

Added the code to register/unregister remote UI Process identifier on the host app.
This is used so that the host app can appear as the sender for notifications sent from its web processes. Unfortunately this has to be done in WebKit: in accessibility bundles the swizzled code is not called because of bundle loading time.
Added AppKit softlink for Mac catalyst.

• SourcesCocoa.txt:
• UIProcess/Cocoa/WebViewImpl.mm:
• UIProcess/ios/AppKitSoftLink.h: Added.
• UIProcess/ios/AppKitSoftLink.mm: Added.
• UIProcess/ios/ViewGestureControllerIOS.mm: (-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):
• UIProcess/ios/WKContentView.mm: (-[WKContentView _updateRemoteAccessibilityRegistration:]): (-[WKContentView _accessibilityRegisterUIProcessTokens]): (-[WKContentView _processDidExit]):
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
• WebProcess/WebPage/mac/WebPageMac.mm:
• WebProcess/cocoa/WebProcessCocoa.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:12 AM Changeset in webkit [252193] by Alan Coon

• 13 edits
  1 move
  2 adds in branches/safari-608.4.9.1-branch/Source

Cherry-pick r252175. rdar://problem/56971561

AX: WKWebView does not shift Accessibility Focus for Catalyst (203798)
​https://bugs.webkit.org/show_bug.cgi?id=203798

Patch by Eric Liang <​ericliang@apple.com> on 2019-11-06
Reviewed by Chris Fleizach.

Source/WebCore:

Changed to use the new cocoa directory instead of macOS only

• accessibility/mac/AXObjectCacheMac.mm:
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

Source/WebCore/PAL:

Changed the path of NSAccessibilitySPI from Mac to Cocoa

• PAL.xcodeproj/project.pbxproj:
• pal/spi/cocoa/NSAccessibilitySPI.h: Renamed from Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h.

Source/WebKit:

Added the code to register/unregister remote UI Process identifier on the host app.
This is used so that the host app can appear as the sender for notifications sent from its web processes. Unfortunately this has to be done in WebKit: in accessibility bundles the swizzled code is not called because of bundle loading time.
Added AppKit softlink for Mac catalyst.

• SourcesCocoa.txt:
• UIProcess/Cocoa/WebViewImpl.mm:
• UIProcess/ios/AppKitSoftLink.h: Added.
• UIProcess/ios/AppKitSoftLink.mm: Added.
• UIProcess/ios/ViewGestureControllerIOS.mm: (-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):
• UIProcess/ios/WKContentView.mm: (-[WKContentView _updateRemoteAccessibilityRegistration:]): (-[WKContentView _accessibilityRegisterUIProcessTokens]): (-[WKContentView _processDidExit]):
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
• WebProcess/WebPage/mac/WebPageMac.mm:
• WebProcess/cocoa/WebProcessCocoa.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:10 AM Changeset in webkit [252192] by Alan Coon

• 7 edits in branches/safari-608.4.9.1-branch/Source

Versioning.

10:31 AM Changeset in webkit [252191] by commit-queue@webkit.org

• 6 edits in trunk

HasProperty result of Proxy in prototype chain is ignored
​https://bugs.webkit.org/show_bug.cgi?id=203560

Patch by Alexey Shvayka <Alexey Shvayka> on 2019-11-07
Reviewed by Ross Kirsling.

JSTests:

• stress/proxy-get-prototype-of.js: Correct Proxy "has" trap test.
• test262/expectations.yaml: Mark 6 test cases as passing.

Source/JavaScriptCore:

Before this change, when HasProperty was called on ordinary object with Proxy in prototype chain,
falsy result of Proxy's "has" trap was ignored and prototype chain was inspected further.

According to spec, OrdinaryHasProperty unconditionally returns result of parent's HasProperty call.
(step 5.a of ​https://tc39.es/ecma262/#sec-ordinaryhasproperty)

• runtime/JSObjectInlines.h:

(JSC::JSObject::getPropertySlot):
(JSC::JSObject::getNonIndexPropertySlot):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::performHasProperty): Walk the prototype chain in performDefaultHasProperty.

10:30 AM Changeset in webkit [252190] by aakash_jain@apple.com

• 3 edits in trunk/Tools

[ews] rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch
​https://bugs.webkit.org/show_bug.cgi?id=203959

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/ews-build/steps.py:

(RunJSCTestsWithoutPatch): Renamed.

• BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

10:03 AM Changeset in webkit [252189] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][MarginCollapsing] Drag anonymous block level boxes into margin collapsing
​https://bugs.webkit.org/show_bug.cgi?id=203927
<rdar://problem/56963636>

Reviewed by Antti Koivisto.

We've been ignoring anonymous block level boxes in the context of margin collapsing. Now with IFC, we can't really do that anymore.
This patch removes the early bailout on anon boxes and addresses the fallout.

• layout/MarginTypes.h:
• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginBefore const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginAfter const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::updateMarginAfterForPreviousSibling):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginAfter const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::estimatedMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeIgnoringCollapsingThrough):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedVerticalValues):

9:31 AM Changeset in webkit [252188] by Adrian Perez de Castro

• 1 copy in releases/WPE WebKit/webkit-2.26.2

WPE WebKit 2.26.2

9:30 AM Changeset in webkit [252187] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.26

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.26.2 release

.:

• Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

• wpe/NEWS: Add release notes for 2.26.2.

9:30 AM Changeset in webkit [252186] by Adrian Perez de Castro

• 7 edits in releases/WebKitGTK/webkit-2.26/Source

Unreviewed build fixed for non-unified builds.

Source/WebCore:

No new tests needed.

• Modules/indexeddb/shared/IDBGetAllRecordsData.cpp: Add missing inclusion of the

wtf/text/StringConcatenateNumbers.h header.

• Modules/indexeddb/shared/IDBIterateCursorData.cpp: Ditto.
• page/DOMWindowExtension.cpp: Add missing inclusion of the Document.h header.
• platform/glib/UserAgentGLib.cpp: Add missing inclusion of the HTTPParsers.h header.

Source/WebKit:

• NetworkProcess/NetworkConnectionToWebProcess.cpp: Add missin inclusion of the Logging.h header

9:05 AM Changeset in webkit [252185] by achristensen@apple.com

• 18 edits in trunk

Re-enable NSURLSession isolation after r252116
​https://bugs.webkit.org/show_bug.cgi?id=203934
<rdar://problem/56921584>

Reviewed by Chris Dumez.

Source/WebCore:

• platform/network/StoredCredentialsPolicy.h:

Source/WebKit:

r252116 was a rollout of r248640, which introduced cases where data tasks from different NSURLSessions
which can have the same task identifiers were put into the same maps. This key collision caused data from the wrong
tasks to be sent to NetworkResourceLoader, causing rare and strange loading bugs. In order to prevent insertion into
wrong maps again, I made a new abstraction, SessionWrapper, which wraps a NSURLSession, its delegate, and all maps
that are scoped to that NSURLSession. Along the way I found a few other places where we had made similar mistakes.

Covered by an API test which would've failed before r252116 because it exercises the key collision condition,
and by tests which were skipped in r252116 and I now unskipped.

• NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:

(WebKit::Download::resume):

• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa):

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate initWithSessionWrapper:withCredentials:]):
(-[WKNetworkSessionDelegate sessionInvalidated]):
(-[WKNetworkSessionDelegate existingTask:]):
(-[WKNetworkSessionDelegate sessionCocoa]):
(-[WKNetworkSessionDelegate URLSession:didBecomeInvalidWithError:]):
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:]):
(processServerTrustEvaluation):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didFinishDownloadingToURL:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didBecomeDownloadTask:]):
(-[WKNetworkSessionDelegate existingWebSocketTask:]):
(WebKit::SessionWrapper::initialize):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::NetworkSessionCocoa::initializeEphemeralStatelessSession):
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
(WebKit::NetworkSessionCocoa::isolatedSession):
(WebKit::NetworkSessionCocoa::invalidateAndCancel):
(WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):
(WebKit::NetworkSessionCocoa::createWebSocketTask):
(WebKit::NetworkSessionCocoa::addWebSocketTask):
(WebKit::NetworkSessionCocoa::removeWebSocketTask):
(-[WKNetworkSessionDelegate initWithNetworkSession:withCredentials:]): Deleted.
(WebKit::NetworkSessionCocoa::initializeEphemeralStatelessCookielessSession): Deleted.
(WebKit::NetworkSessionCocoa::session): Deleted.
(WebKit::NetworkSessionCocoa::dataTaskForIdentifier): Deleted.
(WebKit::NetworkSessionCocoa::downloadTaskWithResumeData): Deleted.
(WebKit::NetworkSessionCocoa::addDownloadID): Deleted.
(WebKit::NetworkSessionCocoa::downloadID): Deleted.
(WebKit::NetworkSessionCocoa::takeDownloadID): Deleted.
(WebKit::NetworkSessionCocoa::webSocketDataTaskForIdentifier): Deleted.

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _logUserInteraction:completionHandler:]):

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(-[DataTaskIdentifierCollisionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[DataTaskIdentifierCollisionDelegate waitForMessages:]):
(-[DataTaskIdentifierCollisionDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(TEST):

LayoutTests:

• platform/wk2/TestExpectations:

Re-enable skipped tests.

8:32 AM Changeset in webkit [252184] by commit-queue@webkit.org

• 5 edits in trunk/Tools

Add support for remotes file for EWS builders
​https://bugs.webkit.org/show_bug.cgi?id=203899

Patch by Paulo Matos <Paulo Matos> on 2019-11-07
Reviewed by Aakash Jain.

Require to support builders that cross-compile and run tests on native machines
through the use of --remote-config-file.

• BuildSlaveSupport/ews-build/factories.py:

(Factory.init):
(StyleFactory.init):
(WatchListFactory.init):

• BuildSlaveSupport/ews-build/loadConfig.py:

(loadBuilderConfig):

• BuildSlaveSupport/ews-build/steps.py:

(ConfigureBuild.init):
(ConfigureBuild.start):
(RunJavaScriptCoreTests.start):

• BuildSlaveSupport/ews-build/steps_unittest.py:

(TestRunJavaScriptCoreTests.test_remote_success):

6:55 AM Changeset in webkit [252183] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

ASSERTION FAILED: m_clientCounts.contains(contextId) in WebKit::VideoFullscreenManagerProxy::removeClientForContext(uint64_t)
​https://bugs.webkit.org/show_bug.cgi?id=203918

Patch by Peng Liu <Peng Liu> on 2019-11-07
Reviewed by Jer Noble.

Postpone the transition to exit fullscreen of a video element
before the previous transition of fullscreen mode change is completed.

Fix a flakey layout test (media/video-autoplay.html). No new test is needed.

• WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):

6:15 AM Changeset in webkit [252182] by Andres Gonzalez

• 8 edits in trunk/Source/WebCore

Rename AXIsolatedTreeNode to AXIsolatedObject for consistency with AXCoreObject and AccessibilityObject.
​https://bugs.webkit.org/show_bug.cgi?id=203913

Reviewed by Chris Fleizach.

No new tests needed, no new functionality.

• Renamed AXIsolatedTreeNode as AXIsolatedObject.
• This makes the naming consistent with AXCoreObject and AccessibilityObject.
• Some code cleanup in WebAccessibilityObjectWrapperBase.h.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::createIsolatedAccessibilityTreeHierarchy):
(WebCore::AXObjectCache::generateIsolatedAccessibilityTree):

• accessibility/AXObjectCache.h:
• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::nodeInTreeForID):
(WebCore::AXIsolatedTree::nodeForID const):
(WebCore::AXIsolatedTree::focusedUIElement):
(WebCore::AXIsolatedTree::rootNode):
(WebCore::AXIsolatedTree::setRoot):
(WebCore::AXIsolatedTree::appendNodeChanges):
(WebCore::AXIsolatedTree::applyPendingChanges):

• accessibility/isolatedtree/AXIsolatedTree.h:
• accessibility/isolatedtree/AXIsolatedTreeNode.cpp:

(WebCore::AXIsolatedObject::AXIsolatedObject):
(WebCore::AXIsolatedObject::create):
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::setProperty):
(WebCore::AXIsolatedObject::appendChild):
(WebCore::AXIsolatedObject::setParent):
(WebCore::AXIsolatedObject::setTreeIdentifier):
(WebCore::AXIsolatedObject::children):
(WebCore::AXIsolatedObject::focusedUIElement const):
(WebCore::AXIsolatedObject::parentObjectUnignored const):
(WebCore::AXIsolatedObject::accessibilityHitTest const):
(WebCore::AXIsolatedObject::tree const):
(WebCore::AXIsolatedObject::rectAttributeValue const):
(WebCore::AXIsolatedObject::doubleAttributeValue const):
(WebCore::AXIsolatedObject::unsignedAttributeValue const):
(WebCore::AXIsolatedObject::boolAttributeValue const):
(WebCore::AXIsolatedObject::stringAttributeValue const):
(WebCore::AXIsolatedObject::intAttributeValue const):
(WebCore::AXIsolatedObject::updateBackingStore):
(WebCore::AXIsolatedTreeNode::AXIsolatedTreeNode): Deleted.
(WebCore::AXIsolatedTreeNode::create): Deleted.
(WebCore::AXIsolatedTreeNode::initializeAttributeData): Deleted.
(WebCore::AXIsolatedTreeNode::setProperty): Deleted.
(WebCore::AXIsolatedTreeNode::appendChild): Deleted.
(WebCore::AXIsolatedTreeNode::setParent): Deleted.
(WebCore::AXIsolatedTreeNode::setTreeIdentifier): Deleted.
(WebCore::AXIsolatedTreeNode::children): Deleted.
(WebCore::AXIsolatedTreeNode::focusedUIElement const): Deleted.
(WebCore::AXIsolatedTreeNode::parentObjectUnignored const): Deleted.
(WebCore::AXIsolatedTreeNode::accessibilityHitTest const): Deleted.
(WebCore::AXIsolatedTreeNode::tree const): Deleted.
(WebCore::AXIsolatedTreeNode::rectAttributeValue const): Deleted.
(WebCore::AXIsolatedTreeNode::doubleAttributeValue const): Deleted.
(WebCore::AXIsolatedTreeNode::unsignedAttributeValue const): Deleted.
(WebCore::AXIsolatedTreeNode::boolAttributeValue const): Deleted.
(WebCore::AXIsolatedTreeNode::stringAttributeValue const): Deleted.
(WebCore::AXIsolatedTreeNode::intAttributeValue const): Deleted.
(WebCore::AXIsolatedTreeNode::updateBackingStore): Deleted.

• accessibility/isolatedtree/AXIsolatedTreeNode.h:
• accessibility/mac/WebAccessibilityObjectWrapperBase.h:

5:21 AM Changeset in webkit [252181] by Andres Gonzalez

• 12 edits in trunk/Source/WebCore

Implement AXIsolatedTreeNode::roleDescription.
​https://bugs.webkit.org/show_bug.cgi?id=203863
<rdar://problem/56934443>

Reviewed by Chris Fleizach.

No new tests needed, no new functionality.

AccessibilityObjectWrapper cannot call any of the AX.*Text functions to
retrieve localized role descriptions, because when running on the
secondary thread, those AtomStrings are not accessible. Moreover, some
of the special cases require access to DOM objects that are not
available in the secondary thread. Therefore, added
AXCoreObject::rolePlatformDescription that runs in the main thread to
initialize the corresponding attribute in AXIsolatedTreeNode.
rolePlatformString, createPlatformRoleMap, roleToPlatformString,
ariaLandmarkRoleDescription, are helper functions. The platform
functions allow to customize the behavior of roleDescription in each
platform. The platform overrides are implemented for mac. Other
platforms are pending.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::rolePlatformString const):
(WebCore::AccessibilityObject::rolePlatformDescription const):
(WebCore::AccessibilityObject::ariaLandmarkRoleDescription const):
(WebCore::AccessibilityObject::roleDescription const):
(WebCore::Accessibility::createPlatformRoleMap):
(WebCore::Accessibility::roleToPlatformString):

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityObjectInterface.h:
• accessibility/isolatedtree/AXIsolatedTreeNode.cpp:

(WebCore::AXIsolatedTreeNode::initializeAttributeData):

• accessibility/isolatedtree/AXIsolatedTreeNode.h:
• accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::rolePlatformString const):
(WebCore::AccessibilityObject::rolePlatformDescription const):
(WebCore::Accessibility::createPlatformRoleMap):

• accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase accessibilityObject]):
(-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]): Implementation moved to AccessibilityObject.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper role]): Special cases moved to rolePlatformString.
(-[WebAccessibilityObjectWrapper roleDescription]):
(createAccessibilityRoleMap): Deleted, became Accessibility::createPlatformRoleMap.
(roleValueToNSString): Deleted, became Accessibility::roleToPlatformString.

• platform/LocalizedStrings.cpp:

(WebCore::AXARIAContentGroupText):
(WebCore::AXHorizontalRuleDescriptionText):
(WebCore::AXMarkText):

• platform/LocalizedStrings.h:
• platform/cocoa/LocalizedStringsCocoa.mm:

(WebCore::AXARIAContentGroupText): Deleted, moved to LocalizedStrings.cpp.
(WebCore::AXHorizontalRuleDescriptionText): Deleted, moved to LocalizedStrings.cpp.
(WebCore::AXMarkText): Deleted, moved to LocalizedStrings.cpp.

4:09 AM Changeset in webkit [252180] by Carlos Garcia Campos

• 6 edits in trunk

WebDriver: correctly handle errors when focusing element before sending key events
​https://bugs.webkit.org/show_bug.cgi?id=203945

Reviewed by Carlos Alberto Lopez Perez.

Source/WebDriver:

We are throwing an exception that is not correctly handled.

Fixes: imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_not_a_focusable_element

imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_display_none
imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_visibility_hidden
imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_hidden
imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_disabled

• Session.cpp:

(WebDriver::Session::elementSendKeys): Raise ElementNotInteractable error when element is not focusable.

Source/WebKit:

Handle ElementNotInteractable JavaScript exception to generate the appropriate Automation error.

• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):

WebDriverTests:

Remove expectations for tests that are now passing.

• TestExpectations.json:

1:52 AM Changeset in webkit [252179] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Indentation in ThreadGlobalData.h is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=203895

Patch by Chris Lord <Chris Lord> on 2019-11-07
Reviewed by Žan Doberšek.

No new tests -- no change in behavior.

• platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::ThreadGlobalData::cachedResourceRequestInitiators):
(WebCore::ThreadGlobalData::ThreadGlobalData::eventNames):
(WebCore::ThreadGlobalData::ThreadGlobalData::threadTimers):
(WebCore::ThreadGlobalData::ThreadGlobalData::qualifiedNameCache):
(WebCore::ThreadGlobalData::ThreadGlobalData::cachedConverterICU):
(WebCore::ThreadGlobalData::ThreadGlobalData::currentState const):
(WebCore::ThreadGlobalData::ThreadGlobalData::setCurrentState):
(WebCore::ThreadGlobalData::ThreadGlobalData::isInRemoveAllEventListeners const):
(WebCore::ThreadGlobalData::ThreadGlobalData::setIsInRemoveAllEventListeners):

12:06 AM Changeset in webkit [252178] by svillar@igalia.com

• 3 edits in trunk/Source/WebCore

VRDisplay should not prevent entering the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=203105

Reviewed by Chris Dumez.

VRDisplay schedules asynchronous execution of events using the WindowEventLoop instead of
synchronously firing them. WindowEventLoop does correctly suspend while in cache.

Apart from that suspend()/resume() were implemented by forcing m_scriptedAnimationController
to suspend the VR request animation frame machinery while in cache.

Last but not least, stopPresenting() is now also called on suspension.

No new tests were added as there is no testing machinery for WebVR so far. It's unclear how
this unreleased feature will evolve as it's being replaced by WebXR.

• Modules/webvr/VRDisplay.cpp:

(WebCore::VRDisplay::dispatchVRDisplayEventInWindowEventLoop):
(WebCore::VRDisplay::platformDisplayConnected): Use dispatchVRDisplayEventInWindowEventLoop.
(WebCore::VRDisplay::platformDisplayDisconnected): Ditto.
(WebCore::VRDisplay::platformDisplayMounted): Ditto.
(WebCore::VRDisplay::platformDisplayUnmounted): Ditto.
(WebCore::VRDisplay::suspend): Added.
(WebCore::VRDisplay::resume): Added.
(WebCore::VRDisplay::stop): Call stopPresenting().
(WebCore::VRDisplay::shouldPreventEnteringBackForwardCache_DEPRECATED const): Deleted.

• Modules/webvr/VRDisplay.h:

Nov 6, 2019:

11:27 PM Changeset in webkit [252177] by mark.lam@apple.com

• 10 edits in trunk/Source

Remove remnants of support code for an upwards growing stack.
​https://bugs.webkit.org/show_bug.cgi?id=203942

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

• runtime/VM.cpp:

(JSC::VM::updateStackLimits):
(JSC::VM::committedStackByteCount):

• runtime/VM.h:

(JSC::VM::isSafeToRecurse const):

• runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):

• runtime/VMInlines.h:

(JSC::VM::ensureStackCapacityFor):

• yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::isSafeToRecurse const):

Source/WTF:

We haven't supported an upwards growing stack in years, and a lot of code has
since been written specifically with only a downwards growing stack in mind (e.g.
the LLInt, the JITs). Also, all our currently supported platforms use a downward
growing stack.

We should remove the remnants of support code for an upwards growing stack. The
presence of that code is deceptive in that it conveys support for an upwards
growing stack where this hasn't been the case in years.

• wtf/StackBounds.cpp:

(WTF::StackBounds::newThreadStackBounds):
(WTF::StackBounds::currentThreadStackBoundsInternal):
(WTF::StackBounds::stackDirection): Deleted.
(WTF::testStackDirection2): Deleted.
(WTF::testStackDirection): Deleted.

• wtf/StackBounds.h:

(WTF::StackBounds::size const):
(WTF::StackBounds::contains const):
(WTF::StackBounds::recursionLimit const):
(WTF::StackBounds::StackBounds):
(WTF::StackBounds::isGrowingDownwards const):
(WTF::StackBounds::checkConsistency const):
(WTF::StackBounds::isGrowingDownward const): Deleted.

• wtf/StackStats.cpp:

(WTF::StackStats::CheckPoint::CheckPoint):
(WTF::StackStats::CheckPoint::~CheckPoint):
(WTF::StackStats::probe):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):

11:21 PM Changeset in webkit [252176] by Devin Rousso

• 3 edits in trunk/Source/WebCore

Remove unimplemented property error log in when getting a property value from a computed style
​https://bugs.webkit.org/show_bug.cgi?id=203943

Reviewed by Simon Fraser.

In r251581, the list of computed CSS properties was changed to be autogenerated from 'CSSProperties.json'.
One issue that arose from this was that -webkit-text-decorations-in-effect was no longer part of the
CSSComputedStyleDeclaration, which caused a number of editing tests to fail, as that property is used
for holding internal state related to various editing commands (e.g. document.execCommand(...)). In
order to get around this, ComputedStyleExtractor::copyProperties() was modified to instead copy all CSS
properties, regardless of whether they're part of the set of computed CSS properties. Unfortunately, this
had a side effect of triggering a longstanding LOG_ERROR (added in r6178) when attempting to retrieve
the value of certain CSS properties (e.g. -internal-text-autosizing-status).

Since this code path can be triggered by JavaScript (e.g. getComputedStyle(node).getPropertyCSSValue("...")),
it doesn't add much benefit to have this log, especially since the code itself is already annotated with
comments/FIXMEs for CSS properties that don't have a computed value.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
(WebCore::logUnimplementedPropertyID): Deleted.

• css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::svgPropertyValue):

11:03 PM Changeset in webkit [252175] by commit-queue@webkit.org

• 13 edits
  1 move
  2 adds in trunk/Source

AX: WKWebView does not shift Accessibility Focus for Catalyst (203798)
​https://bugs.webkit.org/show_bug.cgi?id=203798

Patch by Eric Liang <​ericliang@apple.com> on 2019-11-06
Reviewed by Chris Fleizach.

Source/WebCore:

Changed to use the new cocoa directory instead of macOS only

• accessibility/mac/AXObjectCacheMac.mm:
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

Source/WebCore/PAL:

Changed the path of NSAccessibilitySPI from Mac to Cocoa

• PAL.xcodeproj/project.pbxproj:
• pal/spi/cocoa/NSAccessibilitySPI.h: Renamed from Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h.

Source/WebKit:

Added the code to register/unregister remote UI Process identifier on the host app.
This is used so that the host app can appear as the sender for notifications sent from its web processes. Unfortunately this has to be done in WebKit: in accessibility bundles the swizzled code is not called because of bundle loading time.
Added AppKit softlink for Mac catalyst.

• SourcesCocoa.txt:
• UIProcess/Cocoa/WebViewImpl.mm:
• UIProcess/ios/AppKitSoftLink.h: Added.
• UIProcess/ios/AppKitSoftLink.mm: Added.
• UIProcess/ios/ViewGestureControllerIOS.mm:

(-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):

• UIProcess/ios/WKContentView.mm:

(-[WKContentView _updateRemoteAccessibilityRegistration:]):
(-[WKContentView _accessibilityRegisterUIProcessTokens]):
(-[WKContentView _processDidExit]):

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
• WebProcess/WebPage/mac/WebPageMac.mm:
• WebProcess/cocoa/WebProcessCocoa.mm:

10:37 PM Changeset in webkit [252174] by Keith Rollin

• 43 edits in trunk/Source/WebKit

Update availability annotations to match the macOS 10.15 and iOS 13.0 GM SDKs
​https://bugs.webkit.org/show_bug.cgi?id=202243
<rdar://problem/55720747>

Reviewed by Brent Fulgham.

Changed WK_MAC_TBA and WK_IOS_TBA to 10.15 and 13.0, respectively, in
all declarations that appear in the GM SDKs.

• Configurations/WebKit.xcconfig:
• Shared/API/Cocoa/WKMain.h:
• UIProcess/API/Cocoa/NSAttributedString.h:
• UIProcess/API/Cocoa/WKContextMenuElementInfo.h:
• UIProcess/API/Cocoa/WKError.h:
• UIProcess/API/Cocoa/WKErrorPrivate.h:
• UIProcess/API/Cocoa/WKNavigation.h:
• UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
• UIProcess/API/Cocoa/WKNavigationDelegate.h:
• UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
• UIProcess/API/Cocoa/WKNavigationResponsePrivate.h:
• UIProcess/API/Cocoa/WKPreferences.h:
• UIProcess/API/Cocoa/WKPreferencesPrivate.h:
• UIProcess/API/Cocoa/WKPreviewActionItem.h:
• UIProcess/API/Cocoa/WKPreviewActionItemIdentifiers.h:
• UIProcess/API/Cocoa/WKPreviewElementInfo.h:
• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
• UIProcess/API/Cocoa/WKSnapshotConfiguration.h:
• UIProcess/API/Cocoa/WKUIDelegate.h:
• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/API/Cocoa/WKURLSchemeTaskPrivate.h:
• UIProcess/API/Cocoa/WKWebViewConfiguration.h:
• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/Cocoa/WKWebpagePreferences.h:
• UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/API/Cocoa/_WKActivatedElementInfo.h:
• UIProcess/API/Cocoa/_WKAutomationSessionDelegate.h:
• UIProcess/API/Cocoa/_WKContentRuleListAction.h:
• UIProcess/API/Cocoa/_WKCustomHeaderFields.h:
• UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
• UIProcess/API/Cocoa/_WKElementAction.h:
• UIProcess/API/Cocoa/_WKInspectorWindow.h:
• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
• UIProcess/API/Cocoa/_WKTextInputContext.h:
• UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h:
• UIProcess/API/Cocoa/_WKWebsitePolicies.h:
• UIProcess/_WKTouchEventGenerator.h:
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:

8:06 PM Changeset in webkit [252173] by Alan Coon

• 7 edits in tags/Safari-609.1.9.2/Source

Versioning.

8:05 PM Changeset in webkit [252172] by Antti Koivisto

• 7 edits in trunk

REGRESSION: [ iOS ] ( r251015 ) Layout Test fast/text/whitespace/pre-wrap-overflow-selection.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=203366
<rdar://problem/56580680>

Reviewed by Simon Fraser.

Source/WebKit:

WKBundlePageForceRepaint may fail to do synchronous layer flush if there is a pending layer flush in-flight and waiting
for completion message from UI process. Layer flush also flushes pending editor state so that doesn't get done either.
This may cause randomness in test results.

In this case the randomness is the switch between simple and complex line layout, triggered by editor state flush. The results
between line layout paths are observably identical but produce slightly different render tree dumps.

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageFlushPendingEditorStateUpdate):

• WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Add a function for forcing editor state flush, called from the test runner dump() function.

Tools:

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):

LayoutTests:

• platform/ios/TestExpectations:

8:03 PM Changeset in webkit [252171] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Unreviewed, fix watchOS build after r252011.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::startBackgroundActivityForFullscreenInput):

8:03 PM Changeset in webkit [252170] by Alan Coon

• 1 copy in tags/Safari-609.1.9.2

New tag.

7:36 PM Changeset in webkit [252169] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Change the UIWebView layer border colors to more strongly differentiate them from WKWebView's colors
​https://bugs.webkit.org/show_bug.cgi?id=203940
rdar://problem/56708548

Reviewed by Tim Horton, Wenson Hsieh.

Change layer border colors (which also affect the repaint counter) in UIWebView to use
a chartreuse color, so it's easy to tell at a glance whether an app is using the deprecated
UIWebView.

• platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::colorForGridTileBorder const):

6:53 PM Changeset in webkit [252168] by Nikita Vasilyev

• 11 edits in trunk

Web Inspector: Display color picker for p3 colors
​https://bugs.webkit.org/show_bug.cgi?id=203436
<rdar://problem/56635062>

Reviewed by Brian Burg.

Source/WebInspectorUI:

For p3 colors, display ColorSquare with display-p3 gamut.
Continue showing ColorSquare with sRGB gamut by default.

• UserInterface/Base/Setting.js:
• UserInterface/Models/Color.js:

(WI.Color):
(WI.Color.rgb2hsv):
(WI.Color.hsv2rgb.fraction):
(WI.Color.hsv2rgb):
(WI.Color.prototype.get hsla):
(WI.Color.prototype.isKeyword):

• UserInterface/Views/ColorPicker.css:

(.color-picker > .hue):
(@media (color-gamut: p3)):
(.color-picker.gamut-p3 > .hue):

• UserInterface/Views/ColorPicker.js:

(WI.ColorPicker.prototype._updateColor):
(WI.ColorPicker.prototype._updateOpacitySlider):
(WI.ColorPicker.prototype._handleFormatChange):
Introduce gamut parameter. Previously, the only available gamut was sRGB.

• UserInterface/Views/ColorSquare.css:

(.color-square > .crosshair):
Update the crosshair style to look better for both light and dark backgrounds.

• UserInterface/Views/ColorSquare.js:

(WI.ColorSquare):
(WI.ColorSquare.prototype.get tintedColor):
(WI.ColorSquare.prototype.set tintedColor):
(WI.ColorSquare.prototype._setCrosshairPosition):
(WI.ColorSquare.prototype._updateBaseColor):
(WI.ColorSquare.prototype._updateCrosshairBackground):

• UserInterface/Views/InlineSwatch.js:

Make p3 color picker a preview (e.g. STP-only) feature.

LayoutTests:

Add tests for WI.Color.rgb2hsv and WI.Color.hsv2rgb.

• inspector/model/color-expected.txt:
• inspector/model/color.html:

6:42 PM Changeset in webkit [252167] by commit-queue@webkit.org

• 2 edits in trunk/Websites/bugs.webkit.org

Support CSS Dark Mode for PrettyDiff.rb.
​https://bugs.webkit.org/show_bug.cgi?id=203874.

Patch by James Savage <James Savage> on 2019-11-06
Reviewed by Tim Horton.

• PrettyPatch/PrettyPatch.rb: Modify CSS to support dark mode. I used

CSS variables in places where colors were shared, but otherwise provided
alternate style rules individually. Some colors looked fine in both
appearances, and those I left with only their light definition.

6:28 PM Changeset in webkit [252166] by Fujii Hironori

• 16 edits in trunk

WEBCORE_TESTSUPPORT_EXPORT should be used only for WebCoreTestSupport, not for WebCore
​https://bugs.webkit.org/show_bug.cgi?id=203876

Reviewed by Ross Kirsling.

Source/WebCore:

WEBCORE_TESTSUPPORT_EXPORT shouldn't be used for WebCore. It is
only for WebCoreTestSupport module.

WebCoreTestSupport symbols don't need to export on Windows because
it is a static library on it. WEBCORE_TESTSUPPORT_EXPORT should be
empty.

No behavioral changes.

• Modules/encryptedmedia/MediaKeyEncryptionScheme.idl:
• Modules/encryptedmedia/MediaKeySessionType.idl:
• Modules/encryptedmedia/MediaKeysRequirement.idl:
• Modules/mediastream/NavigatorMediaDevices.h:
• bindings/scripts/test/JS/JSTestNode.h:
• bindings/scripts/test/TestNode.idl:
• workers/service/context/ServiceWorkerThreadProxy.h:

Replaced wrongly marked WEBCORE_TESTSUPPORT_EXPORT with WEBCORE_EXPORT.

• testing/js/WebCoreTestSupportPrefix.h: Define WEBCORE_TESTSUPPORT_EXPORT empty.
• WebCorePrefix.h: Removed WEBCORE_TESTSUPPORT_EXPORT definition.

Source/WebKit:

• config.h: Removed WEBCORE_TESTSUPPORT_EXPORT definition because it shouldn't be used in WebKit.

Tools:

• TestWebKitAPI/win/TestWebKitAPIPrefix.h:
• WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
• WebKitTestRunner/WebKitTestRunnerPrefix.h:

Define WEBCORE_TESTSUPPORT_EXPORT emtpy.

6:04 PM Changeset in webkit [252165] by Fujii Hironori

• 3 edits in trunk/Tools

[Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport
​https://bugs.webkit.org/show_bug.cgi?id=203879

Reviewed by Ross Kirsling.

After r252086, WinCairo DumpRenderTree.exe and
WebKitTestRunner.exe can't start because they are linked with
WinCairoRequirements DLLs unexpectedly.

DumpRenderTree.exe and WebKitTestRunner.exe are just wrapper
programs. They shouldn't link with WinCairoRequirements libs.

• DumpRenderTree/PlatformWin.cmake: Set DumpRenderTree_LIBRARIES only shlwapi.
• WebKitTestRunner/PlatformWin.cmake: Set WebKitTestRunner_LIBRARIES only shlwapi.

5:55 PM Changeset in webkit [252164] by aakash_jain@apple.com

• 3 edits in trunk/LayoutTests

REGRESSION: r252121 introduced new webgl/ failures
​https://bugs.webkit.org/show_bug.cgi?id=203908

Unreviewed test gardening to quell the bots.

Patch by Justin Fan <Justin Fan> on 2019-11-06

• TestExpectations:
• platform/ios/TestExpectations:

5:48 PM Changeset in webkit [252163] by Kate Cheney

• 2 edits in trunk/Tools

Update entry in contributors.json to fix commit privileges.

• Scripts/webkitpy/common/config/contributors.json:

5:22 PM Changeset in webkit [252162] by Tadeu Zagallo

• 2 edits in trunk/Source/JavaScriptCore

[WebAssembly] BBQPlan should retain Wasm::CodeBlock when compiling a single function
​https://bugs.webkit.org/show_bug.cgi?id=203924

Reviewed by Filip Pizlo.

• wasm/WasmBBQPlan.h:

4:39 PM Changeset in webkit [252161] by Simon Fraser

• 17 edits
  2 adds in trunk

Box-shadow spread radius does not transition or animate correctly with CSS Transitions & Animations
​https://bugs.webkit.org/show_bug.cgi?id=202489

Reviewed by Zalan Bujtas.
Source/WebCore:

Fix box-shadow offset and spread to support subpixel values, and make the rendering subpixel-aware.
This also makes animation of shadow spread and offset be smoother on Retina displays.

Also make ShadowStyle an enum class.

Test: fast/box-shadow/hidpi-box-shadow.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForShadow):
(WebCore::ComputedStyleExtractor::valueForFilter):

• css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength const):

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::shadowForBlending):

• platform/animation/AnimationUtilities.h:

(WebCore::blend):

• platform/graphics/RoundedRect.h:
• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):

• rendering/RenderBoxModelObject.cpp:

(WebCore::applyBoxShadowForBackground):
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground const):
(WebCore::areaCastingShadowInHole):
(WebCore::RenderBoxModelObject::paintBoxShadow):
Move the snapping until after we've adjusted rects for offset and spread. The "extraOffset"
computation makes the snapping a little more complex; we have to snap before and after applying
shadowOffset, and give to GraphicsContext the delta between the snapped values.

• rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations):

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::getShadowExtent const):
(WebCore::RenderStyle::getShadowInsetExtent const):
(WebCore::RenderStyle::getShadowHorizontalExtent const):
(WebCore::RenderStyle::getShadowVerticalExtent const):

• rendering/style/ShadowData.cpp:

(WebCore::ShadowData::ShadowData):
(WebCore::calculateShadowExtent):
(WebCore::ShadowData::adjustRectForShadow const):

• rendering/style/ShadowData.h:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x const):
(WebCore::ShadowData::y const):
(WebCore::ShadowData::location const):
(WebCore::ShadowData::paintingExtent const):
(WebCore::ShadowData::spread const):

• style/StyleBuilderCustom.h:

(WebCore::Style::BuilderCustom::applyTextOrBoxShadowValue):

LayoutTests:

• fast/box-shadow/hidpi-box-shadow-expected.html: Added.
• fast/box-shadow/hidpi-box-shadow.html: Added.

4:29 PM Changeset in webkit [252160] by mark.lam@apple.com

• 4 edits
  1 add in trunk

JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut() should fire its watchpoint as the last step.
​https://bugs.webkit.org/show_bug.cgi?id=203867
<rdar://problem/56813514>

Reviewed by Saam Barati.

JSTests:

• stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js: Added.

Source/JavaScriptCore:

JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut() should make all
the array structures SlowPut before firing the watchpoint. Otherwise, the
concurrent JIT may think it's grabbing the slow put version of the structure, but
is actually grabbing the non-SlowPut version because it happened to beat the
mutator in a race to read the structure before the mutator makes it SlowPut.

Also removed some assertions in DFGSpeculativeJIT.cpp that are vulnerable to races
between when the mutator makes all array structures SlowPut and when it fires the
HavingABadTime watchpoint. The FTL equivalent did not have these assertions.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileNewArray):
(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut):

4:12 PM Changeset in webkit [252159] by Alan Coon

• 8 edits in tags/Safari-609.1.10/Source/WebKit

Cherry-pick r252155. rdar://problem/56957850

Unreviewed, rolling out r251907.

Causes white flashing in some cases <rdar://problem/56957850>

Reverted changeset:

"Take down the gesture snapshot early when the back/forward
cache is not leveraged"
​https://bugs.webkit.org/show_bug.cgi?id=203713
​https://trac.webkit.org/changeset/251907

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:00 PM Changeset in webkit [252158] by commit-queue@webkit.org

• 5 edits in trunk

Unreviewed, rolling out r251940.
​https://bugs.webkit.org/show_bug.cgi?id=203920

"it introduced test262 failures" (Requested by rkirsling on
#webkit).

Reverted changeset:

"HasProperty result of Proxy in prototype chain is
ignored"
​https://bugs.webkit.org/show_bug.cgi?id=203560
​https://trac.webkit.org/changeset/251940

3:57 PM Changeset in webkit [252157] by ysuzuki@apple.com

• 2 edits in trunk/Source/bmalloc

Unreviewed, roll-out r251268 due to RAMification regression
​https://bugs.webkit.org/show_bug.cgi?id=203121

The code was the bug, but it would be possible that this bug accidentally makes our policy better.
We should clean up to make this bug's behavior default. And we should look for a bit larger interval here.

• bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::threadRunLoop):

3:56 PM Changeset in webkit [252156] by jer.noble@apple.com

• 3 edits
  2 adds in trunk

Screen locks while watching previously-muted-then-unmuted video
​https://bugs.webkit.org/show_bug.cgi?id=203906
<rdar://problem/55821375>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-unmuted-after-play-holds-sleep-assertion.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setMuted):

LayoutTests:

• media/video-unmuted-after-play-holds-sleep-assertion-expected.txt: Added.
• media/video-unmuted-after-play-holds-sleep-assertion.html: Added.

3:53 PM Changeset in webkit [252155] by Chris Dumez

• 8 edits in trunk/Source/WebKit

Unreviewed, rolling out r251907.

Causes white flashing in some cases <rdar://problem/56957850>

Reverted changeset:

"Take down the gesture snapshot early when the back/forward
cache is not leveraged"
​https://bugs.webkit.org/show_bug.cgi?id=203713
​https://trac.webkit.org/changeset/251907

3:36 PM Changeset in webkit [252154] by Alan Coon

• 1 copy in tags/Safari-608.4.9.0.2

Tag Safari-608.4.9.0.2.

3:03 PM Changeset in webkit [252153] by dbates@webkit.org

• 22 edits
  3 deletes in trunk/LayoutTests

Update SameSite tests for new semantics for empty and invalid SameSite attribute
​https://bugs.webkit.org/show_bug.cgi?id=203755
<rdar://problem/50816282>

Reviewed by Brent Fulgham.

Update the tests and test expectations following CFNetwork change <rdar://problem/42290578> as we
now only recognize SameSite=Strict and SameSite=Lax. That is, we no longer treat SameSite= or
SameSite=<some garbage value> as SameSite=Strict.

MacOS Mojave does not have the fix for <rdar://problem/42290578> and so we land expected failure results.

• http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt:
• http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt:
• http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt:
• http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt:
• http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt:
• http/tests/cookies/same-site/popup-cross-site-post.html:
• http/tests/cookies/same-site/popup-cross-site.html:
• http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect.html:
• http/tests/cookies/same-site/resources/fetch-after-navigating-iframe-in-cross-origin-page.php:
• http/tests/cookies/same-site/resources/fetch-after-top-level-cross-origin-redirect.php:
• http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-from-cross-origin-page.php:
• http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.php:
• http/tests/cookies/same-site/resources/fetch-in-cross-origin-service-worker.html:
• platform/ios-12/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
• platform/mac-mojave/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt:
• platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt:
• platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt:
• platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt:
• platform/mac-mojave/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt:
• platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-expected.txt:
• platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-post-expected.txt:
• platform/mac-mojave/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt:
• platform/mac/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.

2:42 PM Changeset in webkit [252152] by Keith Rollin

• 9 edits in trunk/Tools

Unreviewed build fix: fix TestWebKitAPI in macCatalyst, tvOS, and
watchOS builds by conditionalizing some code on HAVE_UIWEBVIEW and
HAVE_PDFKIT. Follow-up to r251976.

• TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
• TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
• TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm:
• TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm:
• TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
• TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
• TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
• TestWebKitAPI/config.h:

2:38 PM Changeset in webkit [252151] by Oriol Brufau

• 2 edits in trunk/Source/WebCore

Keep None value at the end of the ListStyleType enum
​https://bugs.webkit.org/show_bug.cgi?id=203883

Reviewed by Manuel Rego Casasnovas.

Bug 203837 added a String value at the end of the ListStyleType enum.
This patch moves it before None, in order to keep None at the end.

• rendering/style/RenderStyleConstants.h:

2:21 PM Changeset in webkit [252150] by aakash_jain@apple.com

• 2 edits in trunk/Tools

All EWS status-bubbles shows #1 on security patches when patch is uploaded with webkit-patch --no-review
​https://bugs.webkit.org/show_bug.cgi?id=203903

Reviewed by David Kilzer.

• BuildSlaveSupport/ews-app/ews/fetcher.py:

(BugzillaPatchFetcher.fetch):

2:21 PM Changeset in webkit [252149] by Truitt Savell

• 14 edits
  20 copies
  21 adds in trunk/LayoutTests

Unreviewed, rolling out r252138.

Caused 8 http/tests/cookies/same-site/ to fail

Reverted changeset:

"Update SameSite tests for new semantics for empty and invalid
SameSite attribute"
​https://bugs.webkit.org/show_bug.cgi?id=203755
​https://trac.webkit.org/changeset/252138

2:17 PM Changeset in webkit [252148] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews] Increase timeout for svn-apply
​https://bugs.webkit.org/show_bug.cgi?id=203909

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

1:49 PM Changeset in webkit [252147] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Layout tests in media/modern-media-controls/pip-placard are designed for MacOS only
​https://bugs.webkit.org/show_bug.cgi?id=203859

Patch by Peng Liu <Peng Liu> on 2019-11-06
Reviewed by Eric Carlson.

• platform/ios/TestExpectations:

1:45 PM Changeset in webkit [252146] by timothy@apple.com

• 2 edits in trunk/LayoutTests

[ Mac Debug WK1 ] REGRESSION (r251262?): fast/scrolling/latching/scroll-select-bottom-test.html is a Flaky Failure
​https://bugs.webkit.org/show_bug.cgi?id=203176
rdar://problem/56425901

Unreviewed test gardening.

This hasn't been flaky since r251565 when a related r251261 regression/bug was fixed.
I was also able to run it locally against r252065 a total of 1,100 times with no failures.

• platform/mac-wk1/TestExpectations: Removed scroll-select-bottom-test.html.

1:18 PM Changeset in webkit [252145] by Andres Gonzalez

• 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Adding status field to my contributors.json entry.

1:06 PM Changeset in webkit [252144] by Alan Coon

• 7 edits in branches/safari-608.4.9.0-branch/Source

Versioning.

1:02 PM Changeset in webkit [252143] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][MarginCollapsing] Add Line::isConsideredEmpty
​https://bugs.webkit.org/show_bug.cgi?id=203800
<rdar://problem/56854192>

Reviewed by Antti Koivisto.

​https://www.w3.org/TR/CSS22/visuren.html#inline-formatting
Line boxes that contain no text, no preserved white space, no inline elements with non-zero margins, padding, or borders,
and no other in-flow content (such as images, inline blocks or inline tables), and do not end with a preserved newline
must be treated as zero-height line boxes for the purposes of determining the positions of any elements inside of them,
and must be treated as not existing for any other purpose.

Note that it does not necessarily mean visually non-empty line
<span style="font-size: 0px">this is still considered non-empty</span>

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough const):

• layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::appendNonBreakableSpace):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendNonReplacedInlineBox):
(WebCore::Layout::Line::appendReplacedInlineBox):
(WebCore::Layout::Line::appendLineBreak):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::isConsideredEmpty const):
(WebCore::Layout::LineBox::setIsConsideredNonEmpty):

12:42 PM Changeset in webkit [252142] by dino@apple.com

• 2 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] IOSurfaceSurfaceCGL has format and internalFormat flipped
​https://bugs.webkit.org/show_bug.cgi?id=203911
<rdar://problem/56954291>

Reviewed by Simon Fraser.

Fix a typo where internalFormat and format are used in the
wrong order. The table of formats also had them backwards.

• src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.cpp:

(rx::IOSurfaceSurfaceCGL::bindTexImage):

12:14 PM Changeset in webkit [252141] by Chris Dumez

• 5 edits in trunk/Source/WebKit

Make sure we never end up with NetworkDataTaskCocoa TaskIdentifier conflicts
​https://bugs.webkit.org/show_bug.cgi?id=203902

Reviewed by Antti Koivisto.

Consolidate the all the code related to data task registration / lookup / unregistration
in NetworkSessionCocoa and add a utility method (dataTaskMap()) to decide which data
task map to use. This makes it less error-prone and unlikely that someone would update
part of the code and fail to update the rest accordingly.

I also converted the debug assertions into release ones so that we crash in case of
id confusion instead of having a very bad and hard to diagnose bug like Bug 201822.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa):

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::dataTaskForIdentifier):
(WebKit::NetworkSessionCocoa::registerDataTask):
(WebKit::NetworkSessionCocoa::unregisterDataTask):

9:37 AM Changeset in webkit [252140] by dbates@webkit.org

• 4 edits in trunk/LayoutTests

REGRESSION [ PHP ][ iOS ]: Two http/tests/cookies/same-site/set-first-party-* Tests are Failing
​https://bugs.webkit.org/show_bug.cgi?id=203567
<rdar://problem/56708500>

Reviewed by Youenn Fablet.

A callable must be passed by string in PHP. Any other way seems to be non-standard and your
mileage may vary.

• http/tests/cookies/resources/cookie-utilities.php:
• http/tests/cookies/resources/cookie-utility.php:
• platform/ios-wk2/TestExpectations:

9:36 AM Changeset in webkit [252139] by dbates@webkit.org

• 4 edits in trunk/LayoutTests

http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html is a Flakey Failure
​https://bugs.webkit.org/show_bug.cgi?id=198924
<rdar://problem/51811010>

Reviewed by Brent Fulgham.

JavaScript alert() cannot be called from a Web Worker. Use postMessage() instead to post "PASS"
to the worker's owner document. The tests don't actually make use of this posted message, but
fixing the code to use postMessage() may come in handy for future tests.

• http/tests/security/contentSecurityPolicy/resources/worker.php:
• http/tests/security/contentSecurityPolicy/worker-script-src.html:
• http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html:

9:34 AM Changeset in webkit [252138] by dbates@webkit.org

• 14 edits
  4 deletes in trunk/LayoutTests

Update SameSite tests for new semantics for empty and invalid SameSite attribute
​https://bugs.webkit.org/show_bug.cgi?id=203755
<rdar://problem/50816282>

Reviewed by Brent Fulgham.

Update the tests and test expectations following CFNetwork change <rdar://problem/42290578> as we
now only recognize SameSite=Strict and SameSite=Lax. That is, we no longer treat SameSite= or
SameSite=<some garbage value> as SameSite=Strict.

• http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt:
• http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt:
• http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt:
• http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt:
• http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt:
• http/tests/cookies/same-site/popup-cross-site-post.html:
• http/tests/cookies/same-site/popup-cross-site.html:
• http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect.html:
• http/tests/cookies/same-site/resources/fetch-after-navigating-iframe-in-cross-origin-page.php:
• http/tests/cookies/same-site/resources/fetch-after-top-level-cross-origin-redirect.php:
• http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-from-cross-origin-page.php:
• http/tests/cookies/same-site/resources/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.php:
• http/tests/cookies/same-site/resources/fetch-in-cross-origin-service-worker.html:
• platform/ios-12/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
• platform/ios-12/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
• platform/ios/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
• platform/mac-mojave/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
• platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
• platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/mac-mojave/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
• platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
• platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
• platform/mac-mojave/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
• platform/mac/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.

9:30 AM WebKitGTK/AddingNewWebKit2API edited by yurys@chromium.org

Update links from Source/WebKit2/UIProcess to Source/WebKit/UIProcess (diff)

9:05 AM Changeset in webkit [252137] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Add watchlist category for BuildSlaveSupport
​https://bugs.webkit.org/show_bug.cgi?id=203900

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/common/config/watchlist:

5:16 AM WebKitGTK/2.26.x edited by Adrian Perez de Castro

(diff)

5:13 AM Changeset in webkit [252136] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

[Cairo] Cairo graphics backend uses ImageBuffer::copyImage just to access native image buffer handles
​https://bugs.webkit.org/show_bug.cgi?id=203884

Patch by Chris Lord <Chris Lord> on 2019-11-06
Reviewed by Carlos Garcia Campos.

The Cairo graphics backend uses ImageBuffer::copyImage(DontCopyBackingStore) frequently just to access
the native image pointer. This makes several functions unusable off-main-thread, so add an accessor
function to avoid doing this.

No new tests -- no change in behavior.

• platform/graphics/ImageBuffer.h:
• platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawShadowLayerBuffer):
(WebCore::Cairo::drawShadowImage):
(WebCore::Cairo::fillShadowBuffer):

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clipToImageBuffer):

• platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::clipToImageBuffer):

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::nativeImage const):

2:34 AM Changeset in webkit [252135] by commit-queue@webkit.org

• 3 edits in trunk/Tools

[GTK][WPE] Add libfdk-aac-dev to the install-dependencies script
​https://bugs.webkit.org/show_bug.cgi?id=203812

Patch by Philippe Normand <​philn@igalia.com> on 2019-11-06
Reviewed by Carlos Garcia Campos.

• gtk/install-dependencies:
• wpe/install-dependencies:

1:39 AM Changeset in webkit [252134] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

REGRESSION(r249428): [GStreamer] VP9 video rendered green
​https://bugs.webkit.org/show_bug.cgi?id=201422
<rdar://problem/55945741>

Patch by Philippe Normand <​philn@igalia.com> on 2019-11-06
Reviewed by Carlos Garcia Campos.

Enable the texture upload GStreamer meta code path. Until
GStreamer 1.16.2 this workaround is needed to fix VP9 (vp9dec)
rendering. For downstream users cherry-picking the corresponding
GStreamer patch[0], an environment variable can be set to bypass
the reintroduced slow color conversion: $WEBKIT_GST_NO_RGBA_CONVERSION.

[0] ​https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/commit/8d32de090554cf29fe359f83aa46000ba658a693

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSinkGL):

1:27 AM Changeset in webkit [252133] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.26.2

WebKitGTK 2.26.2

1:26 AM Changeset in webkit [252132] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.26

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.26.2 release

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.26.2.

1:26 AM Changeset in webkit [252131] by Carlos Garcia Campos

• 11 edits in releases/WebKitGTK/webkit-2.26/Source/WebKit

Merge r251423 - [GTK] C++ comments used in C header files
​https://bugs.webkit.org/show_bug.cgi?id=203191

Reviewed by Žan Doberšek.

• UIProcess/API/gtk/WebKitAutocleanups.h:
• UIProcess/API/gtk/WebKitDefines.h:
• UIProcess/API/gtk/WebKitForwardDeclarations.h:
• UIProcess/API/gtk/WebKitWebViewBase.h:
• UIProcess/API/wpe/WebKitAutocleanups.h:
• UIProcess/API/wpe/WebKitDefines.h:
• WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.h:
• WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h:
• WebProcess/InjectedBundle/API/wpe/WebKitWebEditor.h:
• WebProcess/InjectedBundle/API/wpe/WebKitWebExtensionAutocleanups.h:

1:26 AM Changeset in webkit [252130] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.26/Source/WebKit

Merge r251363 - [GTK] Objects category in emoji picker is empty
​https://bugs.webkit.org/show_bug.cgi?id=203189

Reviewed by Adrian Perez de Castro.

There's a typo in the first emopi name of objects section.

• UIProcess/API/gtk/WebKitEmojiChooser.cpp:

(webkitEmojiChooserSetupEmojiSections): uted speaker -> muted speaker

1:26 AM Changeset in webkit [252129] by Carlos Garcia Campos

• 7 edits in releases/WebKitGTK/webkit-2.26/Source

Merge r251122 - [GTK] White pages in AC mode: Cannot get default EGL display: EGL_BAD_PARAMETER
​https://bugs.webkit.org/show_bug.cgi?id=202362

Reviewed by Carlos Alberto Lopez Perez.

Source/WebCore:

The problem is that PlatformDisplayLibWPE::initialize() is failing to initialize the EGL display for some
reason. We need to understand why, but we should also handle the case of failing to initialize the EGL display
and simply disable accelerated compositing mode to avoid white pages and crashes in websites using WebGL. This
patch doesn't actually fix the bug, it just handles the EGL display initialization failure.

• platform/graphics/PlatformDisplay.cpp:

(WebCore::PlatformDisplay::~PlatformDisplay): Set s_sharedDisplayForCompositing to nullptr when the shared
display for compositing is destroyed.

• platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:

(WebCore::PlatformDisplayLibWPE::initialize): Return false when EGL display initialization fails.

• platform/graphics/libwpe/PlatformDisplayLibWPE.h:

Source/WebKit:

• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::updatePreferences): Disable accelerated compositing mode when we failed
to reate the shared display for compositing.

• WebProcess/glib/WebProcessGLib.cpp:

(WebKit::WebProcess::platformInitializeWebProcess): Destroy the wpe display when initialization fails.

1:26 AM Changeset in webkit [252128] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.26/Source/WebKit

Merge r250707 - [GTK] WebAutomation: make setWindowRect synchronous
​https://bugs.webkit.org/show_bug.cgi?id=202530

Reviewed by Carlos Alberto Lopez Perez.

Move/resize window is asynchronous in GTK, but automation expects it to be synchronous so that get window rect
after setting it always returns the value set. Use a nested run loop to wait for the configure events after the
move/resize.

• UIProcess/API/glib/WebKitUIClient.cpp:

(UIClient::windowConfigureEventCallback):
(UIClient::setWindowFrameTimerFired):

12:28 AM Changeset in webkit [252127] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

There is no need to clean the content type header of a request if it is null
​https://bugs.webkit.org/show_bug.cgi?id=203853

Reviewed by Geoffrey Garen.

No change of behavior.

• loader/CrossOriginAccessControl.cpp:

(WebCore::cleanHTTPRequestHeadersForAccessControl):
Stop early if content type is null so that we do not log an error that is not a real error.

12:06 AM Changeset in webkit [252126] by Carlos Garcia Campos

• 18 edits
  8 adds in trunk

[GTK] Implement support for Pointer Lock API
​https://bugs.webkit.org/show_bug.cgi?id=202956

Reviewed by Carlos Alberto Lopez Perez.

.:

Enable Pointer Lock for GTK port.

• Source/cmake/OptionsGTK.cmake:

Source/WebKit:

Add platform specific implementation of Pointer Lock for the GTK port.

• PlatformGTK.cmake: Generate code for pointer-constraints and relative-pointer Wayland protocols.
• Shared/NativeWebMouseEvent.h: Add optional mouse movement delta.
• Shared/gtk/NativeWebMouseEventGtk.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent): Pass movement delta to WebEventFactory::createWebMouseEvent().

• Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebMouseEvent): Initialize deltaX and deltaY for motion events using the received delta.

• Shared/gtk/WebEventFactory.h: Add optional mouse movement delta.
• SourcesGTK.txt: Add new files to compilation.
• UIProcess/API/glib/WebKitUIClient.cpp: Add implementation for requestPointerLock and didLosePointerLock.
• UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewRequestPointerLock): Call webkitWebViewBaseRequestPointerLock().
(webkitWebViewDidLosePointerLock): Call webkitWebViewBaseDidLosePointerLock().

• UIProcess/API/glib/WebKitWebViewPrivate.h:
• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDispose): Unlock the pointer and release the PointerLockManager.
(webkitWebViewBaseHandleMouseEvent): Initialize the mouse movement delta for motion events and save the current event.
(webkitWebViewBaseMotionNotifyEvent): Let PointerLockManager handle motion events while pointer is locked.
(webkitWebViewBaseRequestPointerLock): Create a PointerLockManager and request it to lock the pointer.
(webkitWebViewBaseDidLosePointerLock): Request PointerLockManager to unlock the pointer.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/gtk/PointerLockManager.cpp: Added.

(WebKit::PointerLockManager::create):
(WebKit::PointerLockManager::PointerLockManager):
(WebKit::PointerLockManager::~PointerLockManager):
(WebKit::PointerLockManager::lock):
(WebKit::PointerLockManager::unlock):
(WebKit::PointerLockManager::handleMotion):

• UIProcess/gtk/PointerLockManager.h: Added.

(WebKit::PointerLockManager::didReceiveMotionEvent):

• UIProcess/gtk/PointerLockManagerWayland.cpp: Added.

(WebKit::PointerLockManagerWayland::PointerLockManagerWayland):
(WebKit::PointerLockManagerWayland::~PointerLockManagerWayland):
(WebKit::PointerLockManagerWayland::lock):
(WebKit::PointerLockManagerWayland::unlock):

• UIProcess/gtk/PointerLockManagerWayland.h: Added.
• UIProcess/gtk/PointerLockManagerX11.cpp: Added.

(WebKit::PointerLockManagerX11::PointerLockManagerX11):
(WebKit::PointerLockManagerX11::didReceiveMotionEvent):

• UIProcess/gtk/PointerLockManagerX11.h: Added.

Tools:

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::getGDKKeySymForKeyRef): Handle escape key.

LayoutTests:

Unskip Pointer Lock tests and update expectations for tests still failing.

• platform/gtk/TestExpectations:
• platform/gtk/pointer-lock/mouse-event-delivery-expected.txt: Added.