Timeline

Nov 9, 2019:

11:12 PM Changeset in webkit [252312] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

iOS: fast/events/scroll-subframe-in-rendering-update.html always fails
​https://bugs.webkit.org/show_bug.cgi?id=204045

Reviewed by Alexey Proskuryakov.

Add a failing test expectation for now while we investigate how to fix the test.

• platform/ios/TestExpectations:

7:30 PM Changeset in webkit [252311] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

iOS: fast/events/scroll-subframe-in-rendering-update.html always fails
​https://bugs.webkit.org/show_bug.cgi?id=204045

Reviewed by Alexey Proskuryakov.

Disable the frame flattening to make the test work on iOS.

• fast/events/scroll-subframe-in-rendering-update.html:

3:35 PM Changeset in webkit [252310] by Tadeu Zagallo

• 9 edits
  1 add in trunk/Source/JavaScriptCore

[WebAssembly] Improve bytecode dumping
​https://bugs.webkit.org/show_bug.cgi?id=204051

Reviewed by Keith Miller.

This patch improves the bytecode dumping for Wasm by:

• Adding a new option that dumps only the Wasm bytecode. It can be quite hard to find the Wasm bytecode in the middle of a ton of JS bytecode dumps.
• Adding a header with name of the function and stats, similar to the JS dump.
• Using Wasm types to properly print constants, and including the type in constants table at the end of the dump.

Here's an example of the updated bytecode dump:

<?>.wasm-function[26] : (I32) -> [I32]
wasm size: 4 bytes
bytecode: 6 instructions (0 16-bit instructions, 0 32-bit instructions); 14 bytes; 1 parameter(s); 18 local(s); 22 callee register(s)
[ 0] enter
[ 1] mov loc18, null(const0)
[ 4] mov loc20, loc4
[ 7] mov loc19, loc20
[ 10] mov loc4, loc19
[ 13] ret

Constants:

const0 : Anyref = null

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/BytecodeDumper.cpp:

(JSC::Wasm::BytecodeDumper::dumpBlock):
(JSC::Wasm::BytecodeDumper::dumpConstants):
(JSC::Wasm::BytecodeDumper::constantName const):
(JSC::Wasm::BytecodeDumper::formatConstant const):

• bytecode/BytecodeDumper.h:

(JSC::BytecodeDumper::~BytecodeDumper):

• runtime/OptionsList.h:
• wasm/WasmFunctionCodeBlock.cpp:
• wasm/WasmFunctionCodeBlock.h:

(JSC::Wasm::FunctionCodeBlock::functionIndex const):
(JSC::Wasm::FunctionCodeBlock::numVars const):
(JSC::Wasm::FunctionCodeBlock::numCalleeLocals const):
(JSC::Wasm::FunctionCodeBlock::numArguments const):
(JSC::Wasm::FunctionCodeBlock::constantTypes const):
(JSC::Wasm::FunctionCodeBlock::constants const):
(JSC::Wasm::FunctionCodeBlock::instructions const):
(JSC::Wasm::FunctionCodeBlock::getConstantType const):

• wasm/WasmGeneratorTraits.h: Added.
• wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::addConstant):

• wasm/WasmLLIntPlan.cpp:

(JSC::Wasm::LLIntPlan::didCompleteCompilation):

12:32 PM WebKitGoalsfor2020 edited by mjs@apple.com

(diff)

12:14 PM Changeset in webkit [252309] by dino@apple.com

• 7 edits
  2 adds in trunk

Clicky Orbing support.apple.com categories shows a PNG instead of the web page preview, tapping loads image asset only instead of web page
​https://bugs.webkit.org/show_bug.cgi?id=204037
<rdar://55614939>

Reviewed by Simon Fraser.

Source/WebKit:

When Safari adopted the ContextMenu API they began providing a PreviewViewController that
showed the image rather than the link, for the case of <a><img></a>.

This could be fixed in Safari, but I noticed that we actually tell the delegate that the
type of the activated element is an image, which is why they treat it as such. It's not
clear that because the image also has a link attached, a client should defer to the link.

Instead, I think it makes more sense to identify this as a link, because that is the more
important information in this API.

While here I also changed the logic to make sure we call the API if both the API and SPI
are available.

New ContextMenus and WKRequestActivatedElementInfo API tests.

• UIProcess/API/Cocoa/_WKActivatedElementInfo.mm: Identify as a link if you have a link.

(-[_WKActivatedElementInfo _initWithInteractionInformationAtPosition:userInfo:]):

• UIProcess/ios/WKContentViewInteraction.mm: Look for the API before the SPI.

(-[WKContentView continueContextMenuInteraction:]):

Tools:

New tests for a link wrapping an image, and the ordering of API and SPI.

Rename these tests so that they are much easier to filter on the command line.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:

(TEST):
(-[TestContextMenuAPIBeforeSPIUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
(-[TestContextMenuAPIBeforeSPIUIDelegate _webView:contextMenuConfigurationForElement:completionHandler:]):
(-[TestContextMenuAPIBeforeSPIUIDelegate webView:contextMenuWillPresentForElement:]):

• TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/image.html: Added.
• TestWebKitAPI/Tests/WebKitCocoa/link-with-image.html: Added.

9:09 AM Changeset in webkit [252308] by Antti Koivisto

• 19 edits
  1 copy
  1 add in trunk/Source/WebCore

Move style adjustment code out of StyleResolver and into a class of its own
​https://bugs.webkit.org/show_bug.cgi?id=204041

Reviewed by Zalan Bujtas.

Introduce Style::Adjuster.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::addIntrinsicMargins): Deleted.
(WebCore::equivalentBlockDisplay): Deleted.
(WebCore::doesNotInheritTextDecoration): Deleted.
(WebCore::isScrollableOverflow): Deleted.
(WebCore::hasEffectiveDisplayNoneForDisplayContents): Deleted.
(WebCore::adjustDisplayContentsStyle): Deleted.
(WebCore::StyleResolver::adjustSVGElementStyle): Deleted.
(WebCore::computeEffectiveTouchActions): Deleted.
(WebCore::hasTextChild): Deleted.
(WebCore::StyleResolver::adjustRenderStyleForTextAutosizing): Deleted.
(WebCore::StyleResolver::adjustRenderStyle): Deleted.
(WebCore::StyleResolver::adjustRenderStyleForSiteSpecificQuirks): Deleted.

• css/StyleResolver.h:
• page/Page.cpp:

(WebCore::Page::recomputeTextAutoSizingInAllFrames):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):

None of this code uses the StyleResolver argument so remove it.

(WebCore::RenderTheme::adjustCheckboxStyle const):
(WebCore::RenderTheme::adjustRadioStyle const):
(WebCore::RenderTheme::adjustButtonStyle const):
(WebCore::RenderTheme::adjustInnerSpinButtonStyle const):
(WebCore::RenderTheme::adjustTextFieldStyle const):
(WebCore::RenderTheme::adjustTextAreaStyle const):
(WebCore::RenderTheme::adjustMenuListStyle const):
(WebCore::RenderTheme::adjustMeterStyle const):
(WebCore::RenderTheme::adjustCapsLockIndicatorStyle const):
(WebCore::RenderTheme::adjustAttachmentStyle const):
(WebCore::RenderTheme::adjustListButtonStyle const):
(WebCore::RenderTheme::adjustProgressBarStyle const):
(WebCore::RenderTheme::adjustMenuListButtonStyle const):
(WebCore::RenderTheme::adjustMediaControlStyle const):
(WebCore::RenderTheme::adjustSliderTrackStyle const):
(WebCore::RenderTheme::adjustSliderThumbStyle const):
(WebCore::RenderTheme::adjustSearchFieldStyle const):
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle const):
(WebCore::RenderTheme::adjustSearchFieldDecorationPartStyle const):
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationPartStyle const):
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle const):

• rendering/RenderTheme.h:

(WebCore::RenderTheme::adjustApplePayButtonStyle const):

• rendering/RenderThemeCocoa.h:
• rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::adjustApplePayButtonStyle const):

• rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::adjustButtonStyle const):
(WebCore::RenderThemeGtk::adjustMenuListStyle const):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle const):
(WebCore::RenderThemeGtk::adjustTextFieldStyle const):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle const):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationPartStyle const):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle const):
(WebCore::RenderThemeGtk::adjustListButtonStyle const):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle const):
(WebCore::RenderThemeGtk::adjustSliderTrackStyle const):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle const):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle const):
(WebCore::RenderThemeGtk::adjustProgressBarStyle const):

• rendering/RenderThemeGtk.h:
• rendering/RenderThemeIOS.h:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::adjustCheckboxStyle const):
(WebCore::RenderThemeIOS::adjustRadioStyle const):
(WebCore::RenderThemeIOS::adjustMenuListButtonStyle const):
(WebCore::RenderThemeIOS::adjustSliderTrackStyle const):
(WebCore::RenderThemeIOS::adjustSearchFieldStyle const):
(WebCore::RenderThemeIOS::adjustButtonStyle const):

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::setFontFromControlSize const):
(WebCore::RenderThemeMac::adjustListButtonStyle const):
(WebCore::RenderThemeMac::adjustTextFieldStyle const):
(WebCore::RenderThemeMac::adjustTextAreaStyle const):
(WebCore::RenderThemeMac::adjustProgressBarStyle const):
(WebCore::RenderThemeMac::adjustMenuListStyle const):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle const):
(WebCore::RenderThemeMac::adjustSliderTrackStyle const):
(WebCore::RenderThemeMac::adjustSliderThumbStyle const):
(WebCore::RenderThemeMac::adjustSearchFieldStyle const):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle const):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationPartStyle const):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationPartStyle const):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle const):

• style/StyleAdjuster.cpp: Added.

(WebCore::Style::Adjuster::Adjuster):
(WebCore::Style::addIntrinsicMargins):
(WebCore::Style::equivalentBlockDisplay):
(WebCore::Style::isAtShadowBoundary):
(WebCore::Style::doesNotInheritTextDecoration):
(WebCore::Style::isScrollableOverflow):
(WebCore::Style::computeEffectiveTouchActions):
(WebCore::Style::Adjuster::adjust const):
(WebCore::Style::hasEffectiveDisplayNoneForDisplayContents):
(WebCore::Style::Adjuster::adjustDisplayContentsStyle const):
(WebCore::Style::Adjuster::adjustSVGElementStyle):
(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):
(WebCore::Style::hasTextChild):
(WebCore::Style::Adjuster::adjustForTextAutosizing):

• style/StyleAdjuster.h: Added.
• svg/SVGElement.cpp:

(WebCore::SVGElement::resolveCustomStyle):

3:05 AM Changeset in webkit [252307] by graouts@webkit.org

• 2 edits in trunk/Source/WebCore

[Web Animations] Optimize animation resolution to not re-compute whether effects only contain accelerated animation properties
​https://bugs.webkit.org/show_bug.cgi?id=204009

Reviewed by Dean Jackson.

A KeyframeEffect already exposes whether it only affects CSS properties that can be accelerated, so use this information instead
of iterating over an effect's animated properties during resolution to get at the same information.

No tests or changes to existed test expectations as this should not yield any change in behavior.

• dom/Element.cpp:

(WebCore::Element::applyKeyframeEffects):

Nov 8, 2019:

11:05 PM Changeset in webkit [252306] by Tadeu Zagallo

• 6 edits in trunk/Source/JavaScriptCore

[WebAssembly] LLIntGenerator should not retain VirtualRegisters used for constants
​https://bugs.webkit.org/show_bug.cgi?id=204028

Reviewed by Yusuke Suzuki.

The LLIntGenerator was keeping track of which RegisterIDs contained constants in order to materialize
the OSR entry data, since constants were not included in the OSR entry buffer. This was originally done
by adding the registers that contained constants to a vector and never reusing them. This is bad because
the bytecode generator reclaims registers by popping unused registers from the end of the vector and
stops as soon as it finds a used register. As it turns out, constants *should* be included in the buffer,
so we don't need to worry about whether registers contain constants and we can just stop retaining the
registers. An assertion was added to doOSREntry to ensure that the size of the scratch buffer matches the
size of the values to be written, which was not true before.
Additionally, add m_constantMap to LLIntGenerator to avoid adding duplicate constants to code blocks.

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/BytecodeGeneratorBase.h:
• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addLoop):

• wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::addConstant):
(JSC::Wasm::LLIntGenerator::addLoop):

• wasm/WasmOperations.cpp:

(JSC::Wasm::doOSREntry):

10:36 PM WebKitGoalsfor2020 edited by mjs@apple.com

(diff)

10:34 PM WebKitGoalsfor2020 edited by mjs@apple.com

(diff)

10:27 PM Changeset in webkit [252305] by yurys@chromium.org

• 3 edits
  2 adds in trunk/LayoutTests

New test inspector-protocol/page/archive.html added in r154828 fails on EFL, Qt, GTK
​https://bugs.webkit.org/show_bug.cgi?id=120682

Reviewed by Devin Rousso.

Generate custom expectations for inspector-protocol/page/archive.html on the platforms
where Page.archive is not supported yet.

• inspector/page/archive.html: 'Not supported' is a valid response on some platforms.
• platform/gtk/TestExpectations:
• platform/gtk/inspector/page/archive-expected.txt: Added.

8:09 PM Changeset in webkit [252304] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix debug JSC tests failures due to missing exception check
​https://bugs.webkit.org/show_bug.cgi?id=203936

• tools/JSDollarVM.cpp:

(JSC::functionCallWithStackSize):

8:06 PM Changeset in webkit [252303] by beidson@apple.com

• 21 edits
  2 copies
  4 adds in trunk

WKWebView Find-in-page API.
<rdar://problem/46971112> and ​https://bugs.webkit.org/show_bug.cgi?id=203872

Reviewed by Tim Horton.

Source/WebKit:

Covered by API tests.

• Promote _findString:
• Add a completion handler for it.

• SourcesCocoa.txt:

• UIProcess/API/Cocoa/WKFindConfiguration.h: Added.
• UIProcess/API/Cocoa/WKFindConfiguration.mm: Added.

(-[WKFindConfiguration init]):
(-[WKFindConfiguration copyWithZone:]):

• UIProcess/API/Cocoa/WKFindResult.h: Added.
• UIProcess/API/Cocoa/WKFindResult.mm: Added.

(-[WKFindResult init]):
(-[WKFindResult _initWithMatchFound:]):
(-[WKFindResult copyWithZone:]):

• UIProcess/API/Cocoa/WKFindResultInternal.h: Added.

• UIProcess/API/Cocoa/WKWebView.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(toFindOptions):
(-[WKWebView findString:withConfiguration:completionHandler:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

• UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.h:
• UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.mm:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findString):
(WebKit::WebPageProxy::findStringCallback):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:

• WebKit.xcodeproj/project.pbxproj:

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):

• WebProcess/WebPage/FindController.h:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findString):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/FindInPageAPI.mm: Added.

(TEST):

• TestWebKitAPI/cocoa/TestWKWebView.h:
• TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView selectionRangeHasStartOffset:endOffset:]):

7:45 PM Changeset in webkit [252302] by ysuzuki@apple.com

• 34 edits
  2 moves in trunk/Source/JavaScriptCore

[JSC] Rename LargeAllocation to PreciseAllocation
​https://bugs.webkit.org/show_bug.cgi?id=204040

Reviewed by Keith Miller.

After r252298, LargeAllocation is also used for small allocations.
This patch renames from LargeAllocation to PreciseAllocation since it reflects the behavior.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• heap/CellContainer.cpp:

(JSC::CellContainer::isNewlyAllocated const):

• heap/CellContainer.h:

(JSC::CellContainer::CellContainer):
(JSC::CellContainer::isMarkedBlock const):
(JSC::CellContainer::isPreciseAllocation const):
(JSC::CellContainer::preciseAllocation const):
(JSC::CellContainer::isLargeAllocation const): Deleted.
(JSC::CellContainer::largeAllocation const): Deleted.

• heap/CellContainerInlines.h:

(JSC::CellContainer::vm const):
(JSC::CellContainer::isMarked const):
(JSC::CellContainer::noteMarked):
(JSC::CellContainer::assertValidCell const):
(JSC::CellContainer::cellSize const):
(JSC::CellContainer::weakSet const):
(JSC::CellContainer::aboutToMark):
(JSC::CellContainer::areMarksStale const):

• heap/CompleteSubspace.cpp:

(JSC::CompleteSubspace::tryAllocateSlow):
(JSC::CompleteSubspace::reallocatePreciseAllocationNonVirtual):
(JSC::CompleteSubspace::reallocateLargeAllocationNonVirtual): Deleted.

• heap/CompleteSubspace.h:
• heap/Heap.cpp:

(JSC::Heap::sweepInFinalize):

• heap/HeapCell.cpp:

(JSC::HeapCell::isLive):

• heap/HeapCell.h:
• heap/HeapCellInlines.h:

(JSC::HeapCell::isPreciseAllocation const):
(JSC::HeapCell::cellContainer const):
(JSC::HeapCell::preciseAllocation const):
(JSC::HeapCell::vm const):
(JSC::HeapCell::cellSize const):
(JSC::HeapCell::cellAttributes const):
(JSC::HeapCell::subspace const):
(JSC::HeapCell::isLargeAllocation const): Deleted.
(JSC::HeapCell::largeAllocation const): Deleted.

• heap/HeapInlines.h:

(JSC::Heap::isMarked):
(JSC::Heap::testAndSetMarked):

• heap/HeapUtil.h:

(JSC::HeapUtil::findGCObjectPointersForMarking):
(JSC::HeapUtil::isPointerGCObjectJSCell):
(JSC::HeapUtil::isValueGCObject):

• heap/IsoAlignedMemoryAllocator.cpp:

(JSC::IsoAlignedMemoryAllocator::tryReallocateMemory):

• heap/IsoCellSetInlines.h:

(JSC::IsoCellSet::add):
(JSC::IsoCellSet::remove):
(JSC::IsoCellSet::contains const):
(JSC::IsoCellSet::forEachMarkedCell):
(JSC::IsoCellSet::forEachMarkedCellInParallel):
(JSC::IsoCellSet::forEachLiveCell):

• heap/IsoSubspace.cpp:

(JSC::IsoSubspace::tryAllocateFromLowerTier):
(JSC::IsoSubspace::sweepLowerTierCell):
(JSC::IsoSubspace::destroyLowerTierFreeList):

• heap/IsoSubspace.h:
• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::freeMemory):
(JSC::MarkedSpace::lastChanceToFinalize):
(JSC::MarkedSpace::sweepPreciseAllocations):
(JSC::MarkedSpace::prepareForAllocation):
(JSC::MarkedSpace::enablePreciseAllocationTracking):
(JSC::MarkedSpace::prepareForConservativeScan):
(JSC::MarkedSpace::prepareForMarking):
(JSC::MarkedSpace::resumeAllocating):
(JSC::MarkedSpace::isPagedOut):
(JSC::MarkedSpace::beginMarking):
(JSC::MarkedSpace::endMarking):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::size):
(JSC::MarkedSpace::sweepLargeAllocations): Deleted.
(JSC::MarkedSpace::enableLargeAllocationTracking): Deleted.

• heap/MarkedSpace.h:

(JSC::MarkedSpace:: const):
(JSC::MarkedSpace::preciseAllocationsNurseryOffset const):
(JSC::MarkedSpace::preciseAllocationsOffsetForThisCollection const):
(JSC::MarkedSpace::preciseAllocationsForThisCollectionBegin const):
(JSC::MarkedSpace::preciseAllocationsForThisCollectionEnd const):
(JSC::MarkedSpace::preciseAllocationsForThisCollectionSize const):
(JSC::MarkedSpace::largeAllocationsNurseryOffset const): Deleted.
(JSC::MarkedSpace::largeAllocationsOffsetForThisCollection const): Deleted.
(JSC::MarkedSpace::largeAllocationsForThisCollectionBegin const): Deleted.
(JSC::MarkedSpace::largeAllocationsForThisCollectionEnd const): Deleted.
(JSC::MarkedSpace::largeAllocationsForThisCollectionSize const): Deleted.

• heap/MarkedSpaceInlines.h:

(JSC::MarkedSpace::forEachLiveCell):
(JSC::MarkedSpace::forEachDeadCell):

• heap/PreciseAllocation.cpp: Renamed from Source/JavaScriptCore/heap/LargeAllocation.cpp.

(JSC::isAlignedForPreciseAllocation):
(JSC::PreciseAllocation::tryCreate):
(JSC::PreciseAllocation::tryReallocate):
(JSC::PreciseAllocation::createForLowerTier):
(JSC::PreciseAllocation::reuseForLowerTier):
(JSC::PreciseAllocation::PreciseAllocation):
(JSC::PreciseAllocation::~PreciseAllocation):
(JSC::PreciseAllocation::lastChanceToFinalize):
(JSC::PreciseAllocation::shrink):
(JSC::PreciseAllocation::visitWeakSet):
(JSC::PreciseAllocation::reapWeakSet):
(JSC::PreciseAllocation::flip):
(JSC::PreciseAllocation::isEmpty):
(JSC::PreciseAllocation::sweep):
(JSC::PreciseAllocation::destroy):
(JSC::PreciseAllocation::dump const):
(JSC::PreciseAllocation::assertValidCell const):

• heap/PreciseAllocation.h: Renamed from Source/JavaScriptCore/heap/LargeAllocation.h.

(JSC::PreciseAllocation::fromCell):
(JSC::PreciseAllocation::isPreciseAllocation):
(JSC::PreciseAllocation::headerSize):
(JSC::PreciseAllocation::basePointer const):

• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendHiddenSlowImpl):
(JSC::SlotVisitor::appendToMarkStack):

• heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::appendUnbarriered):
(JSC::SlotVisitor::appendHiddenUnbarriered):

• heap/Subspace.h:
• heap/SubspaceInlines.h:

(JSC::Subspace::forEachPreciseAllocation):
(JSC::Subspace::forEachMarkedCell):
(JSC::Subspace::forEachMarkedCellInParallel):
(JSC::Subspace::forEachLiveCell):
(JSC::Subspace::forEachLargeAllocation): Deleted.

• heap/WeakBlock.cpp:

(JSC::WeakBlock::visit):

• heap/WeakSet.cpp:

(JSC::WeakSet::sweep):

• llint/LowLevelInterpreter.asm:
• runtime/ButterflyInlines.h:

(JSC::Butterfly::reallocArrayRightIfPossible):

• runtime/OptionsList.h:
• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::SamplingProfiler):

• tools/VMInspector.cpp:

(JSC::VMInspector::isInHeap):

• tools/VMInspectorInlines.h:

(JSC::VMInspector::verifyCell):

7:29 PM Changeset in webkit [252301] by Chris Dumez

• 6 edits in trunk/Source/WebCore

Add back/forward cache quirk for Vimeo.com
​https://bugs.webkit.org/show_bug.cgi?id=204025
<rdar://problem/56996057>

Reviewed by Antti Koivisto.

Vimeo.com used to bypass the back/forward cache by serving "Cache-Control: no-store" over HTTPS.
We started caching such content in r250437 but the vimeo.com content unfortunately is not currently compatible
because it changes the opacity of its body to 0 when navigating away and fails to restore the original opacity
when coming back from the back/forward cache (e.g. in 'pageshow' event handler).

To address the issue, this patch introduces a quirk to restore pre-r250437 on Vimeo.com, until they get
a chance to fix their content.

• history/BackForwardCache.cpp:

(WebCore::canCacheFrame):

• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::siteSpecificQuirkKey):

• page/DiagnosticLoggingKeys.h:
• page/Quirks.cpp:

(WebCore::Quirks::shouldBypassBackForwardCache const):

• page/Quirks.h:

7:02 PM Changeset in webkit [252300] by youenn@apple.com

• 5 edits in trunk/Source/WebCore

SWServerWorker in redundant state do not need to process messages from the context process
​https://bugs.webkit.org/show_bug.cgi?id=204019

Reviewed by Chris Dumez.

When a service worker is marked as redundant in network process, it might still receive some messages like didFinishActivation or didFinishInstall.
In that state, we do not need to process these messages.
Did some refactoring to directly pass the service worker to the job queue.
This makes it clear the registration and service worker are the correct ones.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::didFinishInstall):
Pass the worker instead of its identifier.

• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::didFinishInstall):
Now that we are given the service worker, get its registration directly.

• workers/service/server/SWServerJobQueue.h:
• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::didFinishInstall):
Exit early in redundant state.
(WebCore::SWServerWorker::didFinishActivation):
Exit early in redundant state.

6:44 PM Changeset in webkit [252299] by youenn@apple.com

• 5 edits in trunk

XMLHttpRequestUpload should be exposed in dedicated workers
​https://bugs.webkit.org/show_bug.cgi?id=203901

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt:
• web-platform-tests/xhr/idlharness.any.worker-expected.txt:

Source/WebCore:

Covered by rebased test.

• xml/XMLHttpRequestUpload.idl:

5:37 PM Changeset in webkit [252298] by ysuzuki@apple.com

• 28 edits in trunk/Source/JavaScriptCore

[JSC] Make IsoSubspace scalable
​https://bugs.webkit.org/show_bug.cgi?id=201908

Reviewed by Keith Miller.

This patch introduces lower-tier into IsoSubspace so that we can avoid allocating MarkedBlock
if a certain type of object is not allocated so many. This optimization allows us apply IsoSubspace
more aggressively to various types of objects without introducing memory regression even if such a
type of object is allocated so frequently.

We use LargeAllocation for these lower-tier objects. Each IsoSubspace holds up to 8 lower-tier objects
allocated via LargeAllocation. We use this special LargeAllocation when we tend to allocate small # of cells
for this type. Specifically, what we are doing right now is, (1) first, try to allocate in an existing
MarkedBlock (there won't be one to start), and (2) then, try to allocate in LargeAllocation, and if we cannot
allocate lower-tier objects, (3) finally we allocate a new MarkedBlock. Once this LargeAllocation is allocated
to a certain type, we do not deallocate it until VM is destroyed, so that we can keep IsoSubspace's
characteristics: once an address is assigned to a certain type, we continue using this address only for this type.

To introduce this optimization, we need to remove an restriction that no callee cells can be a LargeAllocation.
This also turns out that SamplingProfiler's isValueGCObject is heavily relies on that all the callee is small-sized.
isValueGCObject relies on the thing that MarkedSpace::m_largeAllocations is sorted. But this is not true since
this vector is sorted only when conservative scan happens. And further, this vector is only partially sorted: we
sort only an eden part part of this vector. So we cannot use this vector to implement isValueGCObject in the sampling
profiler. Instead we register HeapCell address into a hash-set in MarkedSpace. Since we do not need to find a pointer
that is pointing at the middle of the JSCell in sampling profiler, just registering cell address is enough. And we
maintain this hash-set only when sampling profiler is enabled to save memory in major cases.

We also fix the code that is relying on that JSString is always allocated in MarkedBlock. And we also fix PackedCellPtr's
assumption that CodeBlock is always allocated in MarkedBlock.

We also make sizeof(LargeAllocation) small since it is now used for non-large allocations.

JetStream2 and Speedometer2 are neutral. RAMification shows 0.6% progression on iOS devices.

• heap/BlockDirectory.cpp:

(JSC::BlockDirectory::BlockDirectory):

• heap/BlockDirectory.h:
• heap/BlockDirectoryInlines.h:

(JSC::BlockDirectory::tryAllocateFromLowerTier):

• heap/CompleteSubspace.cpp:

(JSC::CompleteSubspace::allocatorForSlow):
(JSC::CompleteSubspace::tryAllocateSlow):
(JSC::CompleteSubspace::reallocateLargeAllocationNonVirtual):

• heap/Heap.cpp:

(JSC::Heap::dumpHeapStatisticsAtVMDestruction):
(JSC::Heap::addCoreConstraints):

• heap/HeapUtil.h:

(JSC::HeapUtil::isPointerGCObjectJSCell):
(JSC::HeapUtil::isValueGCObject):

• heap/IsoAlignedMemoryAllocator.cpp:

(JSC::IsoAlignedMemoryAllocator::tryAllocateMemory):
(JSC::IsoAlignedMemoryAllocator::freeMemory):
(JSC::IsoAlignedMemoryAllocator::tryReallocateMemory):

• heap/IsoCellSet.cpp:

(JSC::IsoCellSet::~IsoCellSet):

• heap/IsoCellSet.h:
• heap/IsoCellSetInlines.h:

(JSC::IsoCellSet::add):
(JSC::IsoCellSet::remove):
(JSC::IsoCellSet::contains const):
(JSC::IsoCellSet::forEachMarkedCell):
(JSC::IsoCellSet::forEachMarkedCellInParallel):
(JSC::IsoCellSet::forEachLiveCell):
(JSC::IsoCellSet::sweepLowerTierCell):

• heap/IsoSubspace.cpp:

(JSC::IsoSubspace::IsoSubspace):
(JSC::IsoSubspace::tryAllocateFromLowerTier):
(JSC::IsoSubspace::sweepLowerTierCell):

• heap/IsoSubspace.h:
• heap/LargeAllocation.cpp:

(JSC::LargeAllocation::tryReallocate):
(JSC::LargeAllocation::createForLowerTier):
(JSC::LargeAllocation::reuseForLowerTier):
(JSC::LargeAllocation::LargeAllocation):

• heap/LargeAllocation.h:

(JSC::LargeAllocation::lowerTierIndex const):
(JSC::LargeAllocation::isLowerTier const):

• heap/LocalAllocator.cpp:

(JSC::LocalAllocator::allocateSlowCase):

• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::Handle):
(JSC::MarkedBlock::Handle::stopAllocating):

• heap/MarkedBlock.h:

(JSC::MarkedBlock::Handle::forEachCell):

• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::freeMemory):
(JSC::MarkedSpace::lastChanceToFinalize):
(JSC::MarkedSpace::sweepLargeAllocations):
(JSC::MarkedSpace::enableLargeAllocationTracking):

• heap/MarkedSpace.h:

(JSC::MarkedSpace:: const):

• heap/PackedCellPtr.h:

(JSC::PackedCellPtr::PackedCellPtr):

• heap/Subspace.h:
• heap/WeakSet.cpp:

(JSC::WeakSet::~WeakSet):
(JSC::WeakSet::findAllocator):
(JSC::WeakSet::addAllocator):

• heap/WeakSet.h:

(JSC::WeakSet::WeakSet):
(JSC::WeakSet::resetAllocator):
(JSC::WeakSet::container const): Deleted.
(JSC::WeakSet::setContainer): Deleted.

• heap/WeakSetInlines.h:

(JSC::WeakSet::allocate):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

• runtime/JSCallee.cpp:

(JSC::JSCallee::JSCallee):

• runtime/JSString.h:
• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::releaseStackTraces):
(JSC::SamplingProfiler::stackTracesAsJSON):
(JSC::SamplingProfiler::reportTopFunctions):
(JSC::SamplingProfiler::reportTopBytecodes):

• runtime/SamplingProfiler.h:

5:09 PM Changeset in webkit [252297] by jiewen_tan@apple.com

• 4 edits in trunk/Source

[WebAuthn] Add quirk needed to support legacy Google NFC Titan security keys
​https://bugs.webkit.org/show_bug.cgi?id=204024
<rdar://problem/56962320>

Reviewed by Brent Fulgham.

Source/WebCore:

Covered by manual tests.

• Modules/webauthn/fido/FidoConstants.h:

Source/WebKit:

Some legacy U2F keys such as Google T1 Titan don't understand the FIDO applet command. Instead,
they are configured to only have the FIDO applet. Therefore, when the above command fails, we
use U2F_VERSION command to double check if the connected tag can actually speak U2F, indicating
we are interacting with one of these legacy keys.

• UIProcess/WebAuthentication/Cocoa/NfcConnection.mm:

(WebKit::fido::compareVersion):
(WebKit::fido::trySelectFidoApplet):
(WebKit::NfcConnection::transact const):
(WebKit::NfcConnection::didDetectTags):

4:52 PM Changeset in webkit [252296] by Alan Coon

• 2 edits in tags/Safari-609.1.10.1/Tools

Cherry-pick r252061. rdar://problem/55854631

TestWebKitAPI.WebKit.DocumentEditingContext is failing on iPad
​https://bugs.webkit.org/show_bug.cgi?id=203828
<rdar://problem/55854631>

Reviewed by Myles Maxfield.

Specify both a font size and line height when using Ahem as per [1]. Otherwise, text may be
rendered inconsistently. Plus, disable text-autosizing and fix viewport to make test result
consistent on both iPhone and iPad.

[1] <​https://web-platform-tests.org/writing-tests/ahem.html>

• TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: (applyStyle): Remove unused style for <iframe>s and fix up parameter name to conform to style guide. (applyAhemStyle): Set -webkit-text-size-adjust to 100% to disable auto-sizing. Fix viewport width and initial scale to ensure the result is the same on both iPhone and iPad. Also remove unused style for <iframe>s and renamed parameter name to conform to style guide. (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:52 PM Changeset in webkit [252295] by Alan Coon

• 5 edits
  2 adds in tags/Safari-609.1.10.1/Tools

Cherry-pick r252023. rdar://problem/55854631

Add Googletest assertion support for CGRect and NSRect
​https://bugs.webkit.org/show_bug.cgi?id=203817

Reviewed by Myles C. Maxfield.

Add operator== and operator<< overloads for CGRect and NSRect so that these types can be
passed to EXPECT_EQ() and other Googletest assertions.

To make use of these overloads Cocoa tests should include #import "TestCocoa.h" instead of
"Test.h". TestCocoa.h imports Test.h. With these overloads an assertion like this:

EXPECT_EQ(CGRectMake(0, 0, 23, 24), rects[0].CGRectValue);

will produce output like this when it fails:

Expected equality of these values:

CGRectMake(138, 0, 23, 24)

Which is: (origin = (x = 138, y = 0), size = (width = 23, height = 24))

rects.firstObject.CGRectValue

Which is: (origin = (x = 96, y = 0), size = (width = 16, height = 17))

• TestWebKitAPI/SourcesCocoa.txt:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add source files.

• TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Write in terms of EXPECT_EQ() now that it just works when passed CGRects.

• TestWebKitAPI/cocoa/TestCocoa.h: Added.
• TestWebKitAPI/cocoa/TestCocoa.mm: Added. (ostreamRectCommon): (operator<<): (operator==):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:52 PM Changeset in webkit [252294] by Alan Coon

• 10 edits
  2 copies
  5 moves
  48 adds
  3 deletes in tags/Safari-609.1.10.1

Cherry-pick r252202. rdar://problem/56270900

Web Inspector: REGRESSION(r250087): inspector/model/remote-object.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=202934
<rdar://problem/56270900>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

In r250087, the inspector injected script was changed so that remote objects actually
iterate the keys of an array and generate a property descriptor for each. While this worked
fine (and was performant) for fetching remote objects, this was not efficient when creating
object previews, as that path wouldn't be limited by any sort of fetchCount, meaning that
a descriptor for every index would be created even though only the first 10 would be used.

Refactor the inspector injected script code so that both the fetch and preview paths only
examine exactly the number of properties desired instead of considering all of them and then
slicing to fit.

• inspector/InjectedScriptSource.js: (InjectedScript.prototype._getProperties): (InjectedScript.prototype._forEachPropertyDescriptor): Added. (InjectedScript.prototype._forEachPropertyDescriptor.createFakeValueDescriptor): Added. (InjectedScript.prototype._forEachPropertyDescriptor.processDescriptor): Added. (InjectedScript.prototype._forEachPropertyDescriptor.processProperty): Added. (RemoteObject.prototype._generatePreview): (RemoteObject.prototype._appendPropertyPreview): Added. (RemoteObject.prototype._appendPropertyPreview.appendPreview): Added. (InjectedScript.prototype._propertyDescriptors): Deleted. (InjectedScript.prototype._propertyDescriptors.processProperties): Deleted. (InjectedScript.prototype._propertyDescriptors.arrayIndexPropertyNames): Deleted. (RemoteObject.prototype._appendPropertyPreviews): Deleted.

Source/WebInspectorUI:

• UserInterface/Views/ObjectTreeView.js: (WI.ObjectTreeView.addShowMoreIfNeeded): Drive-by: ensure that the indeterminate progress spinner is added after the last button.

LayoutTests:

Split inspector/model/remote-object.html into separate tests for each type of object being
tested, as well as specialized tests for extremely large values. This allows us to better
know which specific expression can cause a timeout.

• inspector/model/remote-object.html: Removed.
• inspector/model/remote-object-expected.txt: Removed.
• platform/mac-wk1/inspector/model/remote-object-expected.txt: Removed.

• inspector/model/remote-object/array.html: Added.
• inspector/model/remote-object/array-expected.txt: Added.
• inspector/model/remote-object/array-large.html: Added.
• inspector/model/remote-object/array-large-expected.txt: Added.
• inspector/model/remote-object/boolean.html: Added.
• inspector/model/remote-object/boolean-expected.txt: Added.
• inspector/model/remote-object/class.html: Added.
• inspector/model/remote-object/class-expected.txt: Added.
• inspector/model/remote-object/date.html: Added.
• inspector/model/remote-object/date-expected.txt: Added.
• inspector/model/remote-object/error.html: Added.
• inspector/model/remote-object/error-expected.txt: Added.
• inspector/model/remote-object/function.html: Added.
• inspector/model/remote-object/function-expected.txt: Added.
• inspector/model/remote-object/immutable.html: Added.
• inspector/model/remote-object/immutable-expected.txt: Added.
• inspector/model/remote-object/iterator.html: Added.
• inspector/model/remote-object/iterator-expected.txt: Added.
• inspector/model/remote-object/iterator-large.html: Added.
• inspector/model/remote-object/iterator-large-expected.txt: Added.
• inspector/model/remote-object/map.html: Added.
• inspector/model/remote-object/map-expected.txt: Added.
• inspector/model/remote-object/map-large.html: Added.
• inspector/model/remote-object/map-large-expected.txt: Added.
• inspector/model/remote-object/null.html: Added.
• inspector/model/remote-object/null-expected.txt: Added.
• inspector/model/remote-object/number.html: Added.
• inspector/model/remote-object/number-expected.txt: Added.
• platform/mac-wk1/inspector/number-expected.txt: Added.
• inspector/model/remote-object/object.html: Added.
• inspector/model/remote-object/object-expected.txt: Added.
• inspector/model/remote-object/object-large.html: Added.
• inspector/model/remote-object/object-large-expected.txt: Added.
• inspector/model/remote-object/promise.html: Added.
• inspector/model/remote-object/promise-expected.txt: Added.
• inspector/model/remote-object/regexp.html: Added.
• inspector/model/remote-object/regexp-expected.txt: Added.
• inspector/model/remote-object/set.html: Added.
• inspector/model/remote-object/set-expected.txt: Added.
• inspector/model/remote-object/set-large.html: Added.
• inspector/model/remote-object/set-large-expected.txt: Added.
• inspector/model/remote-object/string.html: Added.
• inspector/model/remote-object/string-expected.txt: Added.
• inspector/model/remote-object/string-large.html: Added.
• inspector/model/remote-object/string-large-expected.txt: Added.
• inspector/model/remote-object/undefined.html: Added.
• inspector/model/remote-object/undefined-expected.txt: Added.

• inspector/model/remote-object/dom.html: Renamed from LayoutTests/inspector/model/remote-object-dom.html.
• inspector/model/remote-object/dom-expected.txt: Renamed from LayoutTests/inspector/model/remote-object-dom-expected.txt.
• inspector/model/remote-object/iterators-mutated.html: Renamed from LayoutTests/inspector/model/remote-object-mutated-iterators.html.
• inspector/model/remote-object/iterators-mutated-expected.txt: Renamed from LayoutTests/inspector/model/remote-object-mutated-iterators-expected.txt.

• inspector/model/remote-object/resources/remote-object-utilities.js: Renamed from LayoutTests/inspector/model/resources/remote-object-utilities.js.

• inspector/runtime/getDisplayableProperties.html:
• inspector/runtime/getDisplayableProperties-expected.txt:
• inspector/runtime/getProperties.html:
• inspector/runtime/getProperties-expected.txt: Drive-by: fix assertion for when the __proto__ is included if fetchStart is 0.

• TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:52 PM Changeset in webkit [252293] by Alan Coon

• 2 edits in tags/Safari-609.1.10.1/Source/WebKit

Cherry-pick r252183. rdar://problem/54769320

ASSERTION FAILED: m_clientCounts.contains(contextId) in WebKit::VideoFullscreenManagerProxy::removeClientForContext(uint64_t)
​https://bugs.webkit.org/show_bug.cgi?id=203918

Patch by Peng Liu <Peng Liu> on 2019-11-07
Reviewed by Jer Noble.

Postpone the transition to exit fullscreen of a video element
before the previous transition of fullscreen mode change is completed.

Fix a flakey layout test (media/video-autoplay.html). No new test is needed.

• WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:52 PM Changeset in webkit [252292] by Alan Coon

• 7 edits in tags/Safari-609.1.10.1

Cherry-pick r252172. rdar://problem/56580680

REGRESSION: [ iOS ] ( r251015 ) Layout Test fast/text/whitespace/pre-wrap-overflow-selection.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=203366
<rdar://problem/56580680>

Reviewed by Simon Fraser.

Source/WebKit:

WKBundlePageForceRepaint may fail to do synchronous layer flush if there is a pending layer flush in-flight and waiting
for completion message from UI process. Layer flush also flushes pending editor state so that doesn't get done either.
This may cause randomness in test results.

In this case the randomness is the switch between simple and complex line layout, triggered by editor state flush. The results
between line layout paths are observably identical but produce slightly different render tree dumps.

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageFlushPendingEditorStateUpdate):
• WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Add a function for forcing editor state flush, called from the test runner dump() function.

Tools:

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):

LayoutTests:

• platform/ios/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:52 PM Changeset in webkit [252291] by Alan Coon

• 2 edits in tags/Safari-609.1.10.1/Source/bmalloc

Cherry-pick r252157. rdar://problem/56761470

Unreviewed, roll-out r251268 due to RAMification regression
​https://bugs.webkit.org/show_bug.cgi?id=203121

The code was the bug, but it would be possible that this bug accidentally makes our policy better.
We should clean up to make this bug's behavior default. And we should look for a bit larger interval here.

• bmalloc/Scavenger.cpp: (bmalloc::Scavenger::threadRunLoop):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:52 PM Changeset in webkit [252290] by Alan Coon

• 3 edits
  2 adds in tags/Safari-609.1.10.1

Cherry-pick r252156. rdar://problem/55821375

Screen locks while watching previously-muted-then-unmuted video
​https://bugs.webkit.org/show_bug.cgi?id=203906
<rdar://problem/55821375>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-unmuted-after-play-holds-sleep-assertion.html

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted):

LayoutTests:

• media/video-unmuted-after-play-holds-sleep-assertion-expected.txt: Added.
• media/video-unmuted-after-play-holds-sleep-assertion.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:52 PM Changeset in webkit [252289] by Alan Coon

• 2 edits in tags/Safari-609.1.10.1/LayoutTests

Cherry-pick r252146. rdar://problem/56425901

[ Mac Debug WK1 ] REGRESSION (r251262?): fast/scrolling/latching/scroll-select-bottom-test.html is a Flaky Failure
​https://bugs.webkit.org/show_bug.cgi?id=203176
rdar://problem/56425901

Unreviewed test gardening.

This hasn't been flaky since r251565 when a related r251261 regression/bug was fixed.
I was also able to run it locally against r252065 a total of 1,100 times with no failures.

• platform/mac-wk1/TestExpectations: Removed scroll-select-bottom-test.html.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:52 PM Changeset in webkit [252288] by Alan Coon

• 10 edits in tags/Safari-609.1.10.1/Source

Cherry-pick r252124. rdar://problem/56524251

WTF::RunLoop should not depend on isMainThread() idiom.
​https://bugs.webkit.org/show_bug.cgi?id=203873
<rdar://problem/56524251>

Reviewed by Saam Barati, Ryosuke Niwa, and Devin Rousso.

Source/JavaScriptCore:

• inspector/JSGlobalObjectScriptDebugServer.cpp: (Inspector::JSGlobalObjectScriptDebugServer::runLoopMode):
• inspector/JSGlobalObjectScriptDebugServer.h:
• inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm: (Inspector::RemoteTargetInitializeGlobalQueue): (Inspector::RemoteConnectionToTarget::setupRunLoop): (Inspector::RemoteConnectionToTarget::teardownRunLoop):

Source/WTF:

The isMainThread() idiom is only meaningful for WebCore. It is less meaningful
for JSC since a VM instance can be entered from multiple threads, as long as only
one thread enters it at any time. Hence, the concept of a main thread doesn't
make sense at the JSC level.

Since r251036, we started using a WTF::String to represent the RunLoop mode.
This caused problems for JSC clients when USE(CF) since it necessitated the use of
StringWrapperCFAllocator to track the life cycle of the CFStringRef generated from
the WTF::String.

To fix this problem, we should restore the original behavior of using CFStringRefs
as the RunLoop mode token.

• wtf/RunLoop.h: (WTF::RunLoop::cycle): Deleted.
• wtf/cf/RunLoopCF.cpp: (WTF::RunLoop::cycle):
• wtf/generic/RunLoopGeneric.cpp: (WTF::RunLoop::cycle):
• wtf/glib/RunLoopGLib.cpp: (WTF::RunLoop::cycle):
• wtf/win/RunLoopWin.cpp: (WTF::RunLoop::cycle):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:52 PM Changeset in webkit [252287] by Alan Coon

• 5 edits in tags/Safari-609.1.10.1

Cherry-pick r252116. rdar://problem/55490308

Temporarily turn off NSURLSession isolation
​https://bugs.webkit.org/show_bug.cgi?id=201822

Reviewed by Chris Dumez.

Source/WebKit:

Existing tests skipped.

Re-enabling it is tracked in rdar://problem/56921584.

• NetworkProcess/cache/NetworkCacheStorage.h:

Bumps the version to force a clean cache.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):

Skips setting needsIsolatedSession.

LayoutTests:

Re-enabling it is tracked in rdar://problem/56921584.

• platform/wk2/TestExpectations:

Skipped the associated tests.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:51 PM Changeset in webkit [252286] by Alan Coon

• 3 edits in tags/Safari-609.1.10.1/Source/WebCore

Cherry-pick r252077. rdar://problem/56891110

Adding logging to diagnose crashes resulting from provisional document loader unexpectedly being nullptr
​https://bugs.webkit.org/show_bug.cgi?id=203837

Reviewed by Geoffrey Garen.

Added various logging for DocumentLoader and FrameLoader to figure out why
FrameLoader::m_provisionalDocumentLoader can be nullptr in some cases.

• loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::willSendRequest):
• loader/FrameLoader.cpp: (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::clearProvisionalLoadForPolicyCheck): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::stopForBackForwardCache): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:51 PM Changeset in webkit [252285] by Alan Coon

• 4 edits
  2 adds in tags/Safari-609.1.10.1

Cherry-pick r252070. rdar://problem/56559648

Content can disappear with a combination of <video> with controls and clipping
​https://bugs.webkit.org/show_bug.cgi?id=203834
Source/WebCore:

rdar://problem/56559648

Reviewed by Zalan Bujtas.

<video> with controls triggered a bug where a backing-sharing layer also claimed
that it didn't need any backing store. RenderLayerCompositor::requiresOwnBackingStore()
could early-return with 'false' if a layer had an indirect compositing reason of "Clipping",
while also backing-sharing. We need to check for backing-sharing first.

Test: compositing/shared-backing/clipping-and-shared-backing.html

• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::setBackingSharingLayers):
• rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresOwnBackingStore const):

LayoutTests:

Reviewed by Zalan Bujtas.

• compositing/shared-backing/clipping-and-shared-backing-expected.html: Added.
• compositing/shared-backing/clipping-and-shared-backing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:51 PM Changeset in webkit [252284] by Alan Coon

• 2 edits in tags/Safari-609.1.10.1/Source/WebCore

Cherry-pick r252059. rdar://problem/56889717

http/tests/media/track-in-band-hls-metadata.html sometimes crashes after r251626
​https://bugs.webkit.org/show_bug.cgi?id=203849
<rdar://problem/56889717>

Reviewed by Youenn Fablet.

No new tests, fixes existing test.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (-[WebCoreAVFMovieObserver metadataOutput:didOutputTimedMetadataGroups:fromPlayerItemTrack:]): Return early if m_player has been cleared. (-[WebCoreAVFMovieObserver metadataCollector:didCollectDateRangeMetadataGroups:indexesOfNewGroups:indexesOfModifiedGroups:]): Ditto.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:51 PM Changeset in webkit [252283] by Alan Coon

• 3 edits in tags/Safari-609.1.10.1/LayoutTests

Cherry-pick r252051. rdar://problem/56080440

[iOS] Update fast/forms/ios/file-upload-panel.html test and results
​https://bugs.webkit.org/show_bug.cgi?id=203823
<rdar://problem/56080440>

Reviewed by Youenn Fablet.

• fast/forms/ios/file-upload-panel-expected.txt:
• fast/forms/ios/file-upload-panel.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:51 PM Changeset in webkit [252282] by Alan Coon

• 2 edits in tags/Safari-609.1.10.1/LayoutTests

Cherry-pick r252042. rdar://problem/56123067

[iOS] LayoutTest fast/events/touch/ios/double-tap-for-double-click3.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=203835
<rdar://problem/56123067>

Unable to reproduce. Inserting a double-tap-delay between the events usually fixes these problems.

Reviewed by Wenson Hsieh.

• fast/events/touch/ios/double-tap-for-double-click3.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:51 PM Changeset in webkit [252281] by Alan Coon

• 2 edits in tags/Safari-609.1.10.1/LayoutTests

Cherry-pick r252041. rdar://problem/55664976

[iOS] fast/events/touch/ios/content-observation/click-event-suppression-on-content-change.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=203838
<rdar://problem/55664976>

Reviewed by Wenson Hsieh.

Unable to reproduce. Replace the magic 50ms timeouts with the more robust UIHelper.waitForDoubleTapDelay().

• fast/events/touch/ios/content-observation/click-event-suppression-on-content-change.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:51 PM Changeset in webkit [252280] by Alan Coon

• 4 edits in tags/Safari-609.1.10.1/Source/WebCore

Cherry-pick r252022. rdar://problem/56550488

REGRESSION (r248750): Drop-down menu for Walgreens 2FA unresponsive to touch
​https://bugs.webkit.org/show_bug.cgi?id=203821
<rdar://problem/56550488>

Reviewed by Zalan Bujtas.

The dropdown in question in the Walgreens app uses UIWebView. In this report, tapping the dropdown menu (which
installs DOMTimers upon touchstart) no longer dispatches a click event. This reproduces in WebKit1, but not in
WebKit2.

After r248750, we no longer transition from IndeterminateChange to NoChange before calling out to the client
layer to report a deferred content observation change (in legacy WebKit, this is a call to the delegate method
-webView:didObserveDeferredContentChange:forFrame:).

In WebKit2, logic in WebPage::handleSyntheticClick handles indeterminate content changes after dispatching
mousemove by starting a fixed 32ms content observation timer, after the end of which we transition from
indeterminate to either NoChange or VisibilityChange, and call out to the client. This logic is absent in
WebKitLegacy, where we directly report the current content observation state to the client.

As such, the content change is still indeterminate when we finally call out to the client layer in the runloop
after dispatching the mousemove event in EventHandler::mouseMoved(). Client code in UIKit does not expect this,
and assumes that the given WKContentChange must either be NoChange or VisibilityChange; thus, it handles
indeterminate change as VisibilityChange and does not dispatch a click.

This legacy-WebKit-specific call to didFinishContentChangeObserving is intended to act as a failsafe to stop
content observation after mousemove, if any active timers scheduled during touchstart have already finished
executing. To fix this bug, instead of calling out to WebChromeClient::didFinishContentChangeObserving directly,
add a new method to ContentChangeObserver to inform it that a mousemove event has been handled; here, we call
notifyClientIfNeeded, which will transition the content change state from indeterminate to NoChange if needed
before calling out to the client.

No new test, because we don't have any mechanism for simulating user interaction in UIWebView (and inventing one
at this stage would have diminishing returns at best).

• page/ios/ContentChangeObserver.cpp: (WebCore::ContentChangeObserver::willNotProceedWithFixedObservationTimeWindow): (WebCore::ContentChangeObserver::adjustObservedState):
• page/ios/ContentChangeObserver.h:
• page/ios/EventHandlerIOS.mm: (WebCore::EventHandler::mouseMoved):

Replace the call to WebChromeClient::didFinishContentChangeObserving with a ContentChangeObserver method that
turns around and calls into notifyClientIfNeeded, via ContentChangeObserver::adjustObservedState.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:51 PM Changeset in webkit [252279] by Alan Coon

• 2 edits in tags/Safari-609.1.10.1/Source/JavaScriptCore

Cherry-pick r252006. rdar://problem/56840002

Surpress ASAN in SamplingProfiler's FrameWalker::resetAtMachineFrame().
​https://bugs.webkit.org/show_bug.cgi?id=203819
<rdar://problem/56840002>

Reviewed by Saam Barati.

• runtime/SamplingProfiler.cpp: (JSC::FrameWalker::resetAtMachineFrame):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@252006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:51 PM Changeset in webkit [252278] by Alan Coon

• 2 edits in tags/Safari-609.1.10.1/Source/WebCore

Cherry-pick r251992. rdar://problem/56648063

enumerateDevices() doesn't return correct list of devices after device was changed by user in a system preferences
​https://bugs.webkit.org/show_bug.cgi?id=203407
<rdar://problem/56648063>

Reviewed by Youenn Fablet.

Tested manually as this doesn't reproduce with mock capture devices.

• platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp: (WebCore::CoreAudioCaptureDeviceManager::coreAudioCaptureDevices): Refresh the list of capture devices when the default input device changes. (WebCore::CoreAudioCaptureDeviceManager::refreshAudioCaptureDevices): Assert if not called on the main thread.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@251992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:51 PM Changeset in webkit [252277] by Alan Coon

• 7 edits
  1 add in tags/Safari-609.1.10.1

Cherry-pick r251978. rdar://problem/56840003

LLIntGenerator should not allocate temporaries in between variables
​https://bugs.webkit.org/show_bug.cgi?id=203787

Reviewed by Yusuke Suzuki.

JSTests:

• wasm/stress/local-ref.js: Added.

Source/JavaScriptCore:

The BytecodeGenerator requires that all variables must be allocated contiguously, before any
temporaries are allocated. Currently, we might end up allocating a temporary to materialize
the null constant to initialize locals of type Anyref/Funcref. Fix it by keeping track of the
locals that need to be initialized and adding a new callback to notify when we have finished
parsing locals. Only then we perform the delayed initialization of local refs.

• wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::didFinishParsingLocals):
• wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::didFinishParsingLocals):
• wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser<Context>::parse):
• wasm/WasmLLIntGenerator.cpp: (JSC::Wasm::LLIntGenerator::addLocal): (JSC::Wasm::LLIntGenerator::didFinishParsingLocals):
• wasm/WasmValidate.cpp: (JSC::Wasm::Validate::didFinishParsingLocals):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@251978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:39 PM Changeset in webkit [252276] by commit-queue@webkit.org

• 11 edits
  20 moves
  3 adds in trunk

Entering/Exiting Picture-in-Picture mode through webkitSetPresentationMode() does not fire events (enterpictureinpicture and leavepictureinpicture) defined in the spec
​https://bugs.webkit.org/show_bug.cgi?id=203989

Patch by Peng Liu <Peng Liu> on 2019-11-08
Reviewed by Eric Carlson.

Source/WebCore:

Instantiate a HTMLVideoElementPictureInPicture object when we create a new video element
so that the events defined in the spec will be fired no matter which interface is used
to enter/exit the Picture-in-Picture mode.

Test: media/picture-in-picture/picture-in-picture-events.html

• Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp:

(WebCore::HTMLVideoElementPictureInPicture::providePictureInPictureTo):

• Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h:
• WebCore.xcodeproj/project.pbxproj:
• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

LayoutTests:

Move all layout tests for Picture-in-Picture to folder media/picture-in-picture.
Add a layout test to verify the events defined in the spec are fired when we call the webkit prefixed API.
Update TestExpectations files since webkit.org/b/203614 has been fixed.

• TestExpectations:
• media/picture-in-picture/picture-in-picture-api-element-attributes-expected.txt: Renamed from LayoutTests/media/picture-in-picture-api-element-attributes-expected.txt.
• media/picture-in-picture/picture-in-picture-api-element-attributes.html: Renamed from LayoutTests/media/picture-in-picture-api-element-attributes.html.
• media/picture-in-picture/picture-in-picture-api-enter-pip-1-expected.txt: Renamed from LayoutTests/media/picture-in-picture-api-enter-pip-1-expected.txt.
• media/picture-in-picture/picture-in-picture-api-enter-pip-1.html: Renamed from LayoutTests/media/picture-in-picture-api-enter-pip-1.html.
• media/picture-in-picture/picture-in-picture-api-enter-pip-2-expected.txt: Renamed from LayoutTests/media/picture-in-picture-api-enter-pip-2-expected.txt.
• media/picture-in-picture/picture-in-picture-api-enter-pip-2.html: Renamed from LayoutTests/media/picture-in-picture-api-enter-pip-2.html.
• media/picture-in-picture/picture-in-picture-api-enter-pip-3-expected.txt: Renamed from LayoutTests/media/picture-in-picture-api-enter-pip-3-expected.txt.
• media/picture-in-picture/picture-in-picture-api-enter-pip-3.html: Renamed from LayoutTests/media/picture-in-picture-api-enter-pip-3.html.
• media/picture-in-picture/picture-in-picture-api-enter-pip-4-expected.txt: Renamed from LayoutTests/media/picture-in-picture-api-enter-pip-4-expected.txt.
• media/picture-in-picture/picture-in-picture-api-enter-pip-4.html: Renamed from LayoutTests/media/picture-in-picture-api-enter-pip-4.html.
• media/picture-in-picture/picture-in-picture-api-events-expected.txt: Renamed from LayoutTests/media/picture-in-picture-api-pip-events-expected.txt.
• media/picture-in-picture/picture-in-picture-api-events.html: Renamed from LayoutTests/media/picture-in-picture-api-pip-events.html.
• media/picture-in-picture/picture-in-picture-api-exit-pip-1-expected.txt: Renamed from LayoutTests/media/picture-in-picture-api-exit-pip-1-expected.txt.
• media/picture-in-picture/picture-in-picture-api-exit-pip-1.html: Renamed from LayoutTests/media/picture-in-picture-api-exit-pip-1.html.
• media/picture-in-picture/picture-in-picture-api-exit-pip-2-expected.txt: Renamed from LayoutTests/media/picture-in-picture-api-exit-pip-2-expected.txt.
• media/picture-in-picture/picture-in-picture-api-exit-pip-2.html: Renamed from LayoutTests/media/picture-in-picture-api-exit-pip-2.html.
• media/picture-in-picture/picture-in-picture-api-pip-window-expected.txt: Renamed from LayoutTests/media/picture-in-picture-api-pip-window-expected.txt.
• media/picture-in-picture/picture-in-picture-api-pip-window.html: Renamed from LayoutTests/media/picture-in-picture-api-pip-window.html.
• media/picture-in-picture/picture-in-picture-events-expected.txt: Added.
• media/picture-in-picture/picture-in-picture-events.html: Added.
• media/picture-in-picture/picture-in-picture-interruption-expected.txt: Renamed from LayoutTests/media/picture-in-picture-interruption-expected.txt.
• media/picture-in-picture/picture-in-picture-interruption.html: Renamed from LayoutTests/media/picture-in-picture-interruption.html.
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/ipad/TestExpectations:
• platform/mac-wk2/TestExpectations:

4:32 PM Changeset in webkit [252275] by Jonathan Bedard

• 2 edits in trunk/Tools

Simulators having trouble launching apps after booting
<rdar://problem/57032042>

Unreviewed infrastructure fix.

• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess._start): Temporarily increase timeout to help out bots.

4:20 PM Changeset in webkit [252274] by Jonathan Bedard

• 22 edits in trunk/Source/WebKit

Unreviewed, rolling out r252260.

Breaks half of API tests

Reverted changeset:

"Make DownloadID an ObjectIdentifier"
​https://bugs.webkit.org/show_bug.cgi?id=203962
​https://trac.webkit.org/changeset/252260

4:11 PM Changeset in webkit [252273] by Matt Lewis

• 46 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r252229.

This caused internal failures.

Reverted changeset:

"Split ArithProfile into a Unary and a Binary version"
​https://bugs.webkit.org/show_bug.cgi?id=202832
​https://trac.webkit.org/changeset/252229

4:10 PM WPE/Releasing edited by Adrian Perez de Castro

(diff)

4:03 PM Changeset in webkit [252272] by Jonathan Bedard

• 4 edits
  4 adds in trunk/Tools

results.webkit.org: List failing tests for criteria
​https://bugs.webkit.org/show_bug.cgi?id=203905

Rubber-stamped by Aakash Jain.

• resultsdbpy/resultsdbpy/controller/api_routes.py:

(APIRoutes.init): Add FailureController and /failures endpoint.

• resultsdbpy/resultsdbpy/controller/failure_controller.py: Added.

(FailureController): Added FailureController object to drive /failure endpoint.
(FailureController.init):
(FailureController.failures): Return a json list of failures for a range.

• resultsdbpy/resultsdbpy/controller/failure_controller_unittest.py: Added.

(FailureControllerTest): Test the /failure API.
(FailureControllerTest.setup_webserver):
(FailureControllerTest.test_failures_collapsed):
(FailureControllerTest.test_unexpected_failures_collapsed):
(FailureControllerTest.test_failures):
(FailureControllerTest.test_unexpected_failures):
(FailureControllerTest.test_failure_by_time):

• resultsdbpy/resultsdbpy/model/failure_context.py: Added.

(FailureContext): Database access to tables recording test failures.
(FailureContext.TestFailuresBase):
(FailureContext.TestFailuresBase.unpack):
(FailureContext.TestFailuresByCommit): Save test failures sorted by commit.
(FailureContext.TestFailuresByStartTime): Save test failures sorted by start time.
(FailureContext.UnexpectedTestFailuresByCommit): Save unexpected test failures
sorted by commit.
(FailureContext.UnexpectedTestFailuresByStartTime): Save unexpected test failures
sorted by commit.
(FailureContext.init):
(FailureContext.register): Register test failures to each of the 4 tables for an upload.
(FailureContext._failures): Return a list of test failures from a table.
(FailureContext.failures_by_commit): Return a list of test failures from a table sorted
by commit.
(FailureContext.failures_by_start_time): Return a list of test failures from a table
sorted by commit.

• resultsdbpy/resultsdbpy/model/failure_context_unittest.py: Added.

(FailureContextTest):
(FailureContextTest.init_database):
(FailureContextTest.test_failures_collapsed):
(FailureContextTest.test_unexpected_failures_collapsed):
(FailureContextTest.test_failures):
(FailureContextTest.test_unexpected_failures):

• resultsdbpy/resultsdbpy/model/model.py:

(Model.init):

• resultsdbpy/resultsdbpy/view/templates/documentation.html: Add documentation

for the /failure endpoint.

3:40 PM Changeset in webkit [252271] by Kocsen Chung

• 7 edits in tags/Safari-609.1.10/Source

Revert Versioning.

3:34 PM Changeset in webkit [252270] by Alan Coon

• 1 delete in tags/Safari-609.1.10.0

Delete tag.

3:28 PM Changeset in webkit [252269] by Alan Coon

• 7 edits in tags/Safari-609.1.10.0.1/Source

Versioning.

3:26 PM Changeset in webkit [252268] by Alan Coon

• 1 copy in tags/Safari-609.1.10.0.1

New tag.

3:18 PM Changeset in webkit [252267] by Alan Coon

• 7 edits in tags/Safari-609.1.10.0/Source

Versioning.

3:15 PM Changeset in webkit [252266] by Alan Coon

• 1 copy in tags/Safari-609.1.10.0

New tag.

3:03 PM Changeset in webkit [252265] by Kocsen Chung

• 7 edits in tags/Safari-609.1.10/Source

Versioning.

3:01 PM Changeset in webkit [252264] by Antti Koivisto

• 3 edits in trunk/Source/WebKit

Use separate cache directory for development WebKit on Mac
​https://bugs.webkit.org/show_bug.cgi?id=204015

Reviewed by Youenn Fablet.

Replace the NetworkCache::lastStableVersion scheme with a completely separate directory.
This way potential bugs in development WebKit can't end up affecting system WebKit cache.
This also removes the need to keep lastStableVersion updated.

• NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::makeCachePath):

Add '/Development' to cache path if this is not system WebKit.

(WebKit::NetworkCache::Storage::open):
(WebKit::NetworkCache::Storage::deleteOldVersions):

No need to avoid deleting lastStableVersion anymore.

• NetworkProcess/cache/NetworkCacheStorage.h:

2:10 PM Changeset in webkit [252263] by Chris Dumez

• 24 edits in trunk

Make DeferredPromise behave nicely with regards to the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=203976

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Add template parameter to JSC::Strong to indicate that the destructor should grab the JS lock.
Normally, the callers are in charge of grabbing the lock but this is not always feasible.
In particular, in this patch, I capture a JSC::Strong in a lambda. If the document gets destroyed
before the lambda has run, the lambda will get destroyed and it will destroy the captured JSC::Strong
as a result.

• heap/Handle.h:
• heap/Strong.h:

(JSC::Strong::clear):

• heap/StrongInlines.h:

(JSC::shouldStrongDestructorGrabLock>::Strong):
(JSC::shouldStrongDestructorGrabLock>::set):

Source/WebCore:

Previously, DeferredPromise would ignore requests to fulfill the promise if
reject/resolve/settle got called while the promise's script execution context
is suspended in the back/forward cache. This is really never the right thing to
do though because this means the promise will never be fulfilled if the user
ever goes back to this page.

To address the issue, DeferredPromise now schedules a task on the event loop if
it gets fulfilled while its script execution context is suspended. As a result,
the promise will properly get fulfilled if the document ever comes out of the
back/forward cache and developers using DeferredPromise do not have to worry
about suspension.

Now that DeferredPromise properly deals with suspended documents, this patch also
reverts changes I made recently in code using DeferredPromise. I had made them
queue a task on the event loop before fulfilling the promise, which did not match
their specification and is no longer needed.

Note that capturing the Strong<> in the lambda is correct here because we want
the resolution value to survive until either:

1. The task is processed by the event loop and the promise is resolved.
2. The back/forward cache entry containing this document is destroyed

Note that we do not leak here because when the back/forward cache's CachedFrame
gets destroyed, it will call Document::prepareForDestruction(), which will call
WindowEventLoop::stop() and destroys all pending tasks associated with this
document. This will therefore destroy the Strong captured in the task.

No new tests, covered by existing back/forward cache tests.

• Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::doSequentialMatch):
(WebCore::DOMCacheStorage::match):
(WebCore::DOMCacheStorage::has):
(WebCore::DOMCacheStorage::open):
(WebCore::DOMCacheStorage::doOpen):
(WebCore::DOMCacheStorage::remove):
(WebCore::DOMCacheStorage::doRemove):
(WebCore::DOMCacheStorage::keys):

• Modules/cache/DOMCacheStorage.h:
• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::blobLoadingSucceeded):
(WebCore::FetchBodyOwner::blobLoadingFailed):
(WebCore::FetchBodyOwner::blobChunk):

• Modules/fetch/FetchBodyOwner.h:
• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow):
(WebCore::UserMediaRequest::deny):

• WebCore.xcodeproj/project.pbxproj:
• bindings/IDLTypes.h:
• bindings/js/JSDOMGuardedObject.h:
• bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):
(WebCore::DeferredPromise::whenSettled):
(WebCore::DeferredPromise::reject):

• bindings/js/JSDOMPromiseDeferred.h:

(WebCore::DeferredPromise::resolve):
(WebCore::DeferredPromise::resolveWithNewlyCreated):
(WebCore::DeferredPromise::resolveCallbackValueWithNewlyCreated):
(WebCore::DeferredPromise::reject):
(WebCore::DeferredPromise::resolveWithCallback):
(WebCore::DeferredPromise::rejectWithCallback):
(WebCore::DeferredPromise::shouldIgnoreRequestToFulfill const):

• css/FontFaceSet.cpp:

(WebCore::FontFaceSet::didFirstLayout):
(WebCore::FontFaceSet::completedLoading):
(WebCore::FontFaceSet::faceFinished):

• dom/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::activeDOMObjectsAreSuspended const):
(WebCore::ActiveDOMCallback::activeDOMObjectAreStopped const):

• dom/ActiveDOMCallback.h:
• dom/Element.h:
• dom/ScriptExecutionContext.h:
• page/DOMWindow.h:
• page/RemoteDOMWindow.h:

LayoutTests:

Rebaseline test where ordering has changed slightly due to not queueing a task anymore before
resolving the promise. This restores pre-r251746 behavior.

• fast/mediastream/MediaDevices-getUserMedia-expected.txt:

1:43 PM Changeset in webkit [252262] by Truitt Savell

• 4 edits in trunk/LayoutTests

Update expectations for 3 fast/events/ios/key-events-comprehensive tests
​https://bugs.webkit.org/show_bug.cgi?id=204020

Unreviewed test gardening

• fast/events/ios/key-events-comprehensive/key-events-meta-control-expected.txt:
• fast/events/ios/key-events-comprehensive/key-events-meta-option-expected.txt:
• fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt:

1:35 PM Changeset in webkit [252261] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS] [iOS] Add logging and telemetry to mach lookup rules
​https://bugs.webkit.org/show_bug.cgi?id=203999

Reviewed by Brent Fulgham.

Add logging and telemetry to help determine if mach lookups to a set of services can be denied in the WebContent process.

No new tests, since this only adds logging and telemetry.

• WebProcess/com.apple.WebProcess.sb.in:

1:34 PM Changeset in webkit [252260] by achristensen@apple.com

• 22 edits in trunk/Source/WebKit

Make DownloadID an ObjectIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=203962

Reviewed by Youenn Fablet.

Also deprecate the unused WKDownloadGetID because this identifier is internal.

• NetworkProcess/Downloads/Download.cpp:

(WebKit::Download::Download):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):
(WebKit::Download::messageSenderDestinationID const):

• NetworkProcess/Downloads/DownloadID.h:

(WebKit::DownloadID::DownloadID): Deleted.
(WebKit::DownloadID::operator== const): Deleted.
(WebKit::DownloadID::operator!= const): Deleted.
(WebKit::DownloadID::downloadID const): Deleted.
(IPC::ArgumentCoder<WebKit::DownloadID>::encode): Deleted.
(IPC::ArgumentCoder<WebKit::DownloadID>::decode): Deleted.
(WTF::DownloadIDHash::hash): Deleted.
(WTF::DownloadIDHash::equal): Deleted.
(WTF::HashTraits<WebKit::DownloadID>::emptyValue): Deleted.
(WTF::HashTraits<WebKit::DownloadID>::constructDeletedValue): Deleted.
(WTF::HashTraits<WebKit::DownloadID>::isDeletedValue): Deleted.

• NetworkProcess/Downloads/DownloadMonitor.cpp:

(WebKit::DownloadMonitor::applicationWillEnterForeground):
(WebKit::DownloadMonitor::applicationDidEnterBackground):
(WebKit::DownloadMonitor::timerFired):

• NetworkProcess/Downloads/PendingDownload.cpp:

(WebKit::PendingDownload::messageSenderDestinationID const):

• NetworkProcess/Downloads/PendingDownload.h:
• NetworkProcess/NetworkDataTask.h:

(WebKit::NetworkDataTask::setPendingDownloadID):
(WebKit::NetworkDataTask::isDownload const):

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::pendingDownloadCanceled):
(WebKit::NetworkProcess::findPendingDownloadLocation):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::convertToDownload):

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didFinishDownloadingToURL:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:]):
(WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

• Scripts/webkit/messages.py:
• Shared/Authentication/AuthenticationManager.h:
• UIProcess/API/C/WKDownload.cpp:

(WKDownloadGetID):

• UIProcess/API/C/WKDownload.h:
• UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::DownloadProxy):
(WebKit::generateDownloadID): Deleted.

• UIProcess/Downloads/DownloadProxy.h:
• UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::createDownloadProxy):
(WebKit::DownloadProxyMap::downloadFinished):
(WebKit::DownloadProxyMap::invalidate):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::startDownload):
(WebKit::WebFrame::convertMainResourceLoadToDownload):

• WebProcess/WebPage/WebFrame.h:
• WebProcess/WebPage/WebPage.h:

1:26 PM Changeset in webkit [252259] by achristensen@apple.com

• 13 edits in trunk

Fix flaky tests in http/tests/cache/disk-cache
​https://bugs.webkit.org/show_bug.cgi?id=203822

Reviewed by Youenn Fablet.

Source/WebKit:

Right now tests that set the cache model do so using a race condition. I think this will fix the flakyness we've observed.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setCacheModelSynchronouslyForTesting):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetCacheModelSynchronouslyForTesting):

• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setCacheModelSynchronouslyForTesting):

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setCacheModelSynchronouslyForTesting):

• UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::setCacheModel):

• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

1:16 PM Changeset in webkit [252258] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Revert some changes accidentally committed with r252257
​https://bugs.webkit.org/show_bug.cgi?id=202178

• UIProcess/API/C/WKContextPrivate.h:

1:14 PM Changeset in webkit [252257] by achristensen@apple.com

• 5 edits in trunk/Source/WebKit

Move schemes for SchemeRegistry from WebProcessPool to LegacyGlobalSettings
​https://bugs.webkit.org/show_bug.cgi?id=202178

Reviewed by Youenn Fablet.

The current users of the SPI to set these only have one WebProcessPool, so they intend these settings to be global.
Moving them to LegacyGlobalSettings allows me to make a NetworkProcessProxy without a WebProcessPool and not regress existing functionality.
I move only the four sets of schemes needed to launch a NetworkProcess to remove the dependency the NetworkProcess has on the WebProcessPool.

• UIProcess/LegacyGlobalSettings.h:

(WebKit::LegacyGlobalSettings::schemesToRegisterAsSecure):
(WebKit::LegacyGlobalSettings::registerURLSchemeAsSecure):
(WebKit::LegacyGlobalSettings::schemesToRegisterAsBypassingContentSecurityPolicy):
(WebKit::LegacyGlobalSettings::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebKit::LegacyGlobalSettings::schemesToRegisterAsLocal):
(WebKit::LegacyGlobalSettings::registerURLSchemeAsLocal):
(WebKit::LegacyGlobalSettings::schemesToRegisterAsNoAccess):
(WebKit::LegacyGlobalSettings::registerURLSchemeAsNoAccess):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::registerURLSchemeAsSecure):
(WebKit::WebProcessPool::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebKit::WebProcessPool::registerURLSchemeAsLocal):
(WebKit::WebProcessPool::registerURLSchemeAsNoAccess):

• UIProcess/WebProcessPool.h:

1:11 PM Changeset in webkit [252256] by ysuzuki@apple.com

• 8 edits in trunk/Source/JavaScriptCore

[JSC] Use LinkTimeConstants and make some properties lazy
​https://bugs.webkit.org/show_bug.cgi?id=203795

Reviewed by Keith Miller.

This patch makes Map and Set lazily initialized in JSGlobalObject by leveraging link-time-constant. @Set was accessed from
builtin-JS. So we cannot make it lazily-allocated. But now we have link-time-constant mechanism that makes such accesses
lazily-initialized. We use this to make Set lazily-allocated.

And, instead of JSGlobalObject's last sequence of initialization, we initialize watchpoint in MapPrototype::finishCreation
and SetPrototype::finishCreation. This allows us to make Map and Set lazily-allocated. We also refactor NumberPrototype to
align to this model.

• runtime/ArrayPrototype.cpp:

(JSC::speciesWatchpointIsValid):

• runtime/JSGlobalObject.cpp:

(JSC::setupAdaptiveWatchpoint):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::tryInstallArraySpeciesWatchpoint):
(JSC::JSGlobalObject::installNumberPrototypeWatchpoint):
(JSC::JSGlobalObject::installMapPrototypeWatchpoint):
(JSC::JSGlobalObject::installSetPrototypeWatchpoint):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::numberProtoToStringFunction const):
(JSC::JSGlobalObject::mapPrototype const):
(JSC::JSGlobalObject::jsSetPrototype const):
(JSC::JSGlobalObject::numberObjectStructure const):
(JSC::JSGlobalObject::mapStructure const): Deleted.

• runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):

• runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::finishCreation):

• runtime/NumberPrototype.h:
• runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):

1:10 PM Changeset in webkit [252255] by Antti Koivisto

• 11 edits in trunk/Source/WebCore

StyleResolver state should store user agent appearance style as RenderStyle
​https://bugs.webkit.org/show_bug.cgi?id=204008

Reviewed by Zalan Bujtas.

Generate and pass around user agent style as RenderStyle for apperance computation instead
of awkwardly passing around separate property values.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::State::cacheBorderAndBackground): Deleted.

• css/StyleResolver.h:

(WebCore::StyleResolver::element const):
(WebCore::StyleResolver::State::userAgentAppearanceStyle const):
(WebCore::StyleResolver::State::setUserAgentAppearanceStyle):
(WebCore::StyleResolver::element): Deleted.
(WebCore::StyleResolver::State::hasUAAppearance const): Deleted.
(WebCore::StyleResolver::State::borderData const): Deleted.
(WebCore::StyleResolver::State::backgroundData const): Deleted.
(WebCore::StyleResolver::State::backgroundColor const): Deleted.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::isControlStyled const):

• rendering/RenderTheme.h:
• rendering/RenderThemeIOS.h:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::isControlStyled const):

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::isControlStyled const):

• style/StyleBuilder.cpp:

(WebCore::Style::Builder::Builder):

Allow providing style separately from StyleResolver state.

• style/StyleBuilder.h:

12:50 PM Changeset in webkit [252254] by dbates@webkit.org

• 8 edits in trunk/Source

Add WebKit Legacy SPI to retrieve editable elements in rect
​https://bugs.webkit.org/show_bug.cgi?id=204006
<rdar://problem/57024093>

Reviewed by Wenson Hsieh.

Source/WebCore:

Extract code to retrieve the editable elements inside a specified rect from WebKit
to WebCore so that it can be shared by both Modern WebKit and Legacy WebKit.

• page/Page.cpp:

(WebCore::isEditableTextInputElement):
(WebCore::Page::editableElementsInRect const):

• page/Page.h:

Source/WebKit:

Write WebPage::textInputContextsInRect() in terms of Page::editableElementsInRect().
Also make use of Element::clientRect() instead of elementRectInRootViewCoordinates(),
which duplicates what the former does.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::textInputContextsInRect): Write in terms of Page::editableElementsInRect().
(WebKit::WebPage::contextForElement const): Use Element::clientRect() which does what
elementRectInRootViewCoordinates() does.
(WebKit::elementRectInRootViewCoordinates): Deleted.
(WebKit::isEditableTextInputElement): Deleted.

Source/WebKitLegacy/mac:

Add SPI to retrieve all the editable elements in a rect.

• WebView/WebView.mm:

(-[WebView _editableElementsInRect:]): Added.

• WebView/WebViewPrivate.h:

12:40 PM Changeset in webkit [252253] by graouts@webkit.org

• 15 edits
  2 adds in trunk/Source/WebCore

[Web Animations] Use a keyframe effect stack to resolve animations on an element
​https://bugs.webkit.org/show_bug.cgi?id=204010

Reviewed by Dean Jackson.

Until now, when resolving animations for an element, we would call animationsForElement() during each resolution which
means doing several hash table lookups to locate the various classes of animations for that given element, sorting each
of those animations and inserting them into a new Vector.

We now use a KeyframeEffectStack which keeps a list of KeyframeEffect objects that apply to a given target, provided the
effect also has a valid animation and that animation has a valid timeline, all pre-conditions for that effect to produce
an animated value. Any time one of those pre-conditions change, we update the membership of that effect in the stack.
The KeyframeEffectStack is a new member of ElementRareData.

Now, each time we resolve an animation for an element, we iterate over the KeyframeEffect objects returned by calling
sortEffects() on the KeyframeEffectStack which will sort the stack's effects only if a new effect had been added since
the last iteration, which means that simple animations that are not mutated will require sorting of the stack just once,
and the addition of several animations in a single animation frame will require sorting just once as well.

It was also found while doing this work that Style::TreeResolver::createAnimatedElementUpdate would call RenderStyle::clonePtr()
for any element that was part of a document containing a timeline, regardless of whether that element had any animations. Now
we check whether that element's KeyframeEffectStack contains any effects prior to cloning the style.

No tests or changes to existed test expectations as this should not yield any change in behavior.

• Sources.txt: Add the new KeyframeEffectStack.
• WebCore.xcodeproj/project.pbxproj:
• animation/AnimationEffect.h:

(WebCore::AnimationEffect::setAnimation):

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::removeAnimation):
(WebCore::AnimationTimeline::updateCSSAnimationsForElement): Since we need to know the order of CSS @keyframes rules listed in animation-name
when sorting effects, we must compile the ordered list of those @keyframe rules as we update CSS animations for an element and store it on its
KeyframeEffectStack.

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::resolveAnimationsForElement): Deleted. Replaced by Element::applyKeyframeEffects().

• animation/DocumentTimeline.h:
• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::animationTimelineDidChange):
(WebCore::KeyframeEffect::setAnimation):
(WebCore::KeyframeEffect::setTarget):

• animation/KeyframeEffect.h:
• animation/KeyframeEffectStack.cpp: Added.

(WebCore::KeyframeEffectStack::KeyframeEffectStack):
(WebCore::KeyframeEffectStack::~KeyframeEffectStack):
(WebCore::KeyframeEffectStack::addEffect):
(WebCore::KeyframeEffectStack::removeEffect):
(WebCore::KeyframeEffectStack::sortedEffects):
(WebCore::KeyframeEffectStack::ensureEffectsAreSorted):
(WebCore::KeyframeEffectStack::setCSSAnimationNames):

• animation/KeyframeEffectStack.h: Added.

(WebCore::KeyframeEffectStack::hasEffects const):

• animation/WebAnimation.cpp:

(WebCore::WebAnimation::setTimelineInternal):
(WebCore::WebAnimation::persist):

• dom/Element.cpp:

(WebCore::Element::ensureKeyframeEffectStack):
(WebCore::Element::hasKeyframeEffects const):
(WebCore::Element::applyKeyframeEffects):

• dom/Element.h:
• dom/ElementRareData.cpp:
• dom/ElementRareData.h:

(WebCore::ElementRareData::keyframeEffectStack):
(WebCore::ElementRareData::setKeyframeEffectStack):

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

12:00 PM Changeset in webkit [252252] by Alan Coon

• 7 edits in tags/Safari-609.1.9.4/Source

Versioning.

11:59 AM Changeset in webkit [252251] by Alan Coon

• 1 copy in tags/Safari-609.1.9.4

New tag.

11:55 AM Changeset in webkit [252250] by dino@apple.com

• 19 edits in trunk/Source/ThirdParty/ANGLE/src

Add ANGLE backend for iOS device
​https://bugs.webkit.org/show_bug.cgi?id=202159
<rdar://57000166>

Build fixes for Mac Catalyst, tvOS and watchOS.

• src/common/PackedEnums.cpp:

(egl_gl::EGLTextureTargetToTextureType):

• src/common/platform.h:
• src/gpu_info_util/SystemInfo_ios.cpp:
• src/gpu_info_util/SystemInfo_macos.cpp:
• src/libANGLE/Display.cpp:
• src/libANGLE/formatutils.cpp:

(gl::BuildInternalFormatInfoMap):

• src/libANGLE/renderer/gl/cgl/DeviceCGL.cpp:
• src/libANGLE/renderer/gl/cgl/DisplayCGL.mm:
• src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.cpp:
• src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.cpp:
• src/libANGLE/renderer/gl/cgl/RendererCGL.cpp:
• src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm:
• src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:
• src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:
• src/libANGLE/renderer/gl/eagl/PbufferSurfaceEAGL.cpp:
• src/libANGLE/renderer/gl/eagl/RendererEAGL.cpp:
• src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm:
• src/libANGLE/renderer/gl/renderergl_utils.cpp:

(rx::nativegl_gl::GenerateCaps):

• src/libANGLE/validationES2.cpp:

(gl::ValidateFramebufferTexture2D):

11:54 AM Changeset in webkit [252249] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Clicking on EWS status-bubble should open the results in new tab
​https://bugs.webkit.org/show_bug.cgi?id=204012

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:

11:44 AM Changeset in webkit [252248] by jiewen_tan@apple.com

• 5 edits in trunk

[WebAuthn] Return NotAllowedError immediately for UI cancellations
​https://bugs.webkit.org/show_bug.cgi?id=203937
<rdar://problem/56962420>

Reviewed by Brent Fulgham.

Source/WebKit:

NotAllowedError representing UI cancellations should be returned to sites
immediately such that sites could show appropriate error page immediately.

Covered by existing tests.

• UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::cancelRequest):
(WebKit::AuthenticatorManager::clearState):
(WebKit::AuthenticatorManager::resetState): Deleted.

• UIProcess/WebAuthentication/AuthenticatorManager.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(TestWebKitAPI::TEST):

11:37 AM Changeset in webkit [252247] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Remove invalid assertion in DFG's compileNewArray().
​https://bugs.webkit.org/show_bug.cgi?id=204002
<rdar://problem/56973531>

Reviewed by Robin Morisset.

The assertion is in an if clause conditional on !globalObject->isHavingABadTime().
The assertion tests the IndexingType of a structure returned by
arrayStructureForIndexingTypeDuringAllocation().

However, the structures returned by arrayStructureForIndexingTypeDuringAllocation()
may have started transitioning to their SlowPut variant because the mutator will
be imminently firing the HavingABadTime watchpoint, but haven't done so yet.
In a race, the DFG may see the SlowPut variants of the structures before
isHavingABadTime() returns true. Hence, the assertion is invalid.

Note that the FTL does not have this assertion.

This issue is already tested by stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewArray):

11:11 AM Changeset in webkit [252246] by dino@apple.com

• 2 edits in trunk/Source/ThirdParty/ANGLE

Add ANGLE backend for iOS device
​https://bugs.webkit.org/show_bug.cgi?id=202159
<rdar://57000166>

Build fix. Don't include IOSurface.h on iOS (public SDK doesn't have it).

• src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:

10:58 AM Changeset in webkit [252245] by dino@apple.com

• 24 edits
  1 move
  16 adds in trunk/Source

Add ANGLE backend for iOS device
​https://bugs.webkit.org/show_bug.cgi?id=202159
<rdar://57000166>

Reviewed by Myles Maxfield.

Source/ThirdParty/ANGLE:

Add an OpenGLES backend over EAGL for iOS to ANGLE.

This is basically a copy of all the files in
libANGLE/renderer/gl/cgl into libANGLE/renderer/gl/eagl, then with
modifications to make it work on iOS's OpenGL ES. Most notably,
some format enums and the manner in which you bind an IOSurface to
a GL texture are different.

This introduces a few places where we have to do a compile time
switch for iOS, some of which might actually be applicable to
other OpenGL ES backends.

The biggest missing piece is support for the iOS simulator. At the moment
this backend relies on an IOSurface binding as a rendering target.
But the iOS Simulator does not have the required ability to have a
GL ES texture backed by an IOSurface.

The WindowSurfaceEAGL code is incomplete, but was not necessary
in order to get WebGL operational. And even if you are using ANGLE
directly, you can have the client code render into a CALayer without
going through the WindowSurface.

• ANGLE.xcodeproj/project.pbxproj:
• include/EGL/eglext_angle.h:
• src/common/PackedEnums.cpp:

(egl_gl::EGLTextureTargetToTextureType):

• src/common/platform.h:
• src/gpu_info_util/SystemInfo_ios.cpp: Added.

(angle::GetSystemInfo):

• src/gpu_info_util/SystemInfo_macos.cpp: Renamed from Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_mac.cpp.

(angle::GetSystemInfo):

• src/libANGLE/Caps.h:
• src/libANGLE/Display.cpp:
• src/libANGLE/formatutils.cpp:

(gl::BuildInternalFormatInfoMap):

• src/libANGLE/renderer/gl/cgl/DeviceCGL.cpp:
• src/libANGLE/renderer/gl/cgl/DisplayCGL.mm:
• src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.cpp:

(rx::IOSurfaceSurfaceCGL::bindTexImage):

• src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.cpp:
• src/libANGLE/renderer/gl/cgl/RendererCGL.cpp:
• src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm:
• src/libANGLE/renderer/gl/eagl/ContextEAGL.cpp: Added.

(rx::ContextEAGL::ContextEAGL):

• src/libANGLE/renderer/gl/eagl/ContextEAGL.h: Added.
• src/libANGLE/renderer/gl/eagl/DeviceEAGL.cpp: Added.

(rx::DeviceEAGL::DeviceEAGL):
(rx::DeviceEAGL::~DeviceEAGL):
(rx::DeviceEAGL::initialize):
(rx::DeviceEAGL::getAttribute):
(rx::DeviceEAGL::getType):
(rx::DeviceEAGL::generateExtensions const):

• src/libANGLE/renderer/gl/eagl/DeviceEAGL.h: Added.
• src/libANGLE/renderer/gl/eagl/DisplayEAGL.h: Added.
• src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm: Added.

(rx::FunctionsGLEAGL::FunctionsGLEAGL):
(rx::DisplayEAGL::DisplayEAGL):
(rx::DisplayEAGL::~DisplayEAGL):
(rx::DisplayEAGL::initialize):
(rx::DisplayEAGL::terminate):
(rx::DisplayEAGL::createWindowSurface):
(rx::DisplayEAGL::createPbufferSurface):
(rx::DisplayEAGL::createPbufferFromClientBuffer):
(rx::DisplayEAGL::createPixmapSurface):
(rx::DisplayEAGL::createContext):
(rx::DisplayEAGL::createDevice):
(rx::DisplayEAGL::generateConfigs):
(rx::DisplayEAGL::testDeviceLost):
(rx::DisplayEAGL::restoreLostDevice):
(rx::DisplayEAGL::isValidNativeWindow const):
(rx::DisplayEAGL::validateClientBuffer const):
(rx::DisplayEAGL::getVendorString const):
(rx::DisplayEAGL::getEAGLContext const):
(rx::DisplayEAGL::getEAGLPixelFormat const):
(rx::DisplayEAGL::generateExtensions const):
(rx::DisplayEAGL::generateCaps const):
(rx::DisplayEAGL::waitClient):
(rx::DisplayEAGL::waitNative):
(rx::DisplayEAGL::getMaxSupportedESVersion const):
(rx::DisplayEAGL::makeCurrentSurfaceless):
(rx::WorkerContextEAGL::WorkerContextEAGL):
(rx::WorkerContextEAGL::~WorkerContextEAGL):
(rx::WorkerContextEAGL::makeCurrent):
(rx::WorkerContextEAGL::unmakeCurrent):
(rx::DisplayEAGL::createWorkerContext):
(rx::DisplayEAGL::initializeFrontendFeatures const):
(rx::DisplayEAGL::populateFeatureList):

• src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.h: Added.
• src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm: Copied from Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.cpp.

(rx::IOSurfaceSurfaceEAGL::IOSurfaceSurfaceEAGL):
(rx::IOSurfaceSurfaceEAGL::~IOSurfaceSurfaceEAGL):
(rx::IOSurfaceSurfaceEAGL::initialize):
(rx::IOSurfaceSurfaceEAGL::makeCurrent):
(rx::IOSurfaceSurfaceEAGL::unMakeCurrent):
(rx::IOSurfaceSurfaceEAGL::swap):
(rx::IOSurfaceSurfaceEAGL::postSubBuffer):
(rx::IOSurfaceSurfaceEAGL::querySurfacePointerANGLE):
(rx::IOSurfaceSurfaceEAGL::bindTexImage):
(rx::IOSurfaceSurfaceEAGL::releaseTexImage):
(rx::IOSurfaceSurfaceEAGL::setSwapInterval):
(rx::IOSurfaceSurfaceEAGL::getWidth const):
(rx::IOSurfaceSurfaceEAGL::getHeight const):
(rx::IOSurfaceSurfaceEAGL::isPostSubBufferSupported const):
(rx::IOSurfaceSurfaceEAGL::getSwapBehavior const):
(rx::IOSurfaceSurfaceEAGL::validateAttributes):
(rx::IOSurfaceFramebuffer::IOSurfaceFramebuffer):
(rx::IOSurfaceSurfaceEAGL::createDefaultFramebuffer):
(rx::IOSurfaceSurfaceEAGL::initializeAlphaChannel):
(rx::IOSurfaceSurfaceEAGL::hasEmulatedAlphaChannel const):

• src/libANGLE/renderer/gl/eagl/PbufferSurfaceEAGL.cpp: Copied from Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.cpp.

(rx::PbufferSurfaceEAGL::PbufferSurfaceEAGL):
(rx::PbufferSurfaceEAGL::~PbufferSurfaceEAGL):
(rx::PbufferSurfaceEAGL::initialize):
(rx::PbufferSurfaceEAGL::makeCurrent):
(rx::PbufferSurfaceEAGL::swap):
(rx::PbufferSurfaceEAGL::postSubBuffer):
(rx::PbufferSurfaceEAGL::querySurfacePointerANGLE):
(rx::PbufferSurfaceEAGL::bindTexImage):
(rx::PbufferSurfaceEAGL::releaseTexImage):
(rx::PbufferSurfaceEAGL::setSwapInterval):
(rx::PbufferSurfaceEAGL::getWidth const):
(rx::PbufferSurfaceEAGL::getHeight const):
(rx::PbufferSurfaceEAGL::isPostSubBufferSupported const):
(rx::PbufferSurfaceEAGL::getSwapBehavior const):
(rx::PbufferSurfaceEAGL::createDefaultFramebuffer):

• src/libANGLE/renderer/gl/eagl/PbufferSurfaceEAGL.h: Added.
• src/libANGLE/renderer/gl/eagl/RendererEAGL.cpp: Added.

(rx::RendererEAGL::RendererEAGL):
(rx::RendererEAGL::~RendererEAGL):
(rx::RendererEAGL::createWorkerContext):

• src/libANGLE/renderer/gl/eagl/RendererEAGL.h: Added.
• src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.h: Added.
• src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm: Copied from Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm.

(-[WebSwapLayer initWithSharedState:withContext:withFunctions:]):
(-[WebSwapLayer display]):
(rx::WindowSurfaceEAGL::WindowSurfaceEAGL):
(rx::WindowSurfaceEAGL::~WindowSurfaceEAGL):
(rx::WindowSurfaceEAGL::initialize):
(rx::WindowSurfaceEAGL::makeCurrent):
(rx::WindowSurfaceEAGL::swap):
(rx::WindowSurfaceEAGL::postSubBuffer):
(rx::WindowSurfaceEAGL::querySurfacePointerANGLE):
(rx::WindowSurfaceEAGL::bindTexImage):
(rx::WindowSurfaceEAGL::releaseTexImage):
(rx::WindowSurfaceEAGL::setSwapInterval):
(rx::WindowSurfaceEAGL::getWidth const):
(rx::WindowSurfaceEAGL::getHeight const):
(rx::WindowSurfaceEAGL::isPostSubBufferSupported const):
(rx::WindowSurfaceEAGL::getSwapBehavior const):
(rx::WindowSurfaceEAGL::createDefaultFramebuffer):

• src/libANGLE/renderer/gl/renderergl_utils.cpp:

(rx::nativegl_gl::GenerateCaps):

• src/libANGLE/validationES2.cpp:

(gl::ValidateFramebufferTexture2D):

• src/libGLESv2/entry_points_egl_ext.cpp:

Source/WebCore:

Use the ANGLE for iOS backend.

Mostly this was just moving some code around so that it would compile
on iOS when USE(ANGLE) is true. The actual code to render WebGL is
similar between macOS and iOS - both now using a CALayer with
a set of IOSurfaces that are used as swap textures.

The main difference is that macOS (OpenGL) binds to TEXTURE_RECTANGLE,
and iOS (OpenGL ES) binds to the regular TEXTURE_2D.

The remaining missing piece is getting video textures into ANGLE
efficiently (without leaving the GPU). We can ask CoreVideo
to give us raw GL textures, but with ANGLE we no longer have direct access
to the underlying OpenGL context.

This is not enabled in the builds yet, so no tests. However, when
enabled it will be tested against the official WebGL conformance suite.

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::validateVertexAttributes):

• platform/cocoa/CoreVideoSoftLink.cpp:
• platform/cocoa/CoreVideoSoftLink.h:
• platform/graphics/GraphicsContext3D.h:
• platform/graphics/angle/GraphicsContext3DANGLE.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):

• platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::allocateIOSurfaceBackingStore):
(WebCore::GraphicsContext3D::updateFramebufferTextureBackingStoreFromLayer):

• platform/graphics/cocoa/WebGLLayer.h:
• platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer initWithGraphicsContext3D:]):
(-[WebGLLayer display]):
(-[WebGLLayer setEGLDisplay:config:]):
(-[WebGLLayer allocateIOSurfaceBackingStoreWithSize:usingAlpha:]):
(-[WebGLLayer bindFramebufferToNextAvailableSurface]):
(-[WebGLLayer setEGLDisplay:andConfig:]): Deleted.

• platform/graphics/cv/TextureCacheCV.mm:

(WebCore::TextureCacheCV::textureFromImage):

• platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::copyVideoTextureToPlatformTexture):

• platform/graphics/opengl/TemporaryOpenGLSetting.cpp:
• platform/graphics/opengl/TemporaryOpenGLSetting.h:

10:53 AM Changeset in webkit [252244] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews] Prioritize builders over testers when a bot is shared over multiple queues
​https://bugs.webkit.org/show_bug.cgi?id=204007

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/loadConfig.py:

(loadBuilderConfig):
(prioritizeBuilders): Method to prioritize builder queues over tester queues.

10:37 AM Changeset in webkit [252243] by Ross Kirsling

• 2 edits in trunk/Source/JavaScriptCore

[PlayStation][JSC] Unreviewed build fix.

• shell/playstation/TestShell.cpp:

10:24 AM Changeset in webkit [252242] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Regression r252209: Layout Test fast/workers/worker-close-more.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=203995
<rdar://problem/57020558>

Reviewed by Ryosuke Niwa.

We should not dispatch events on a MessagePort objects in a WorkerGlobalScope which is
closing (i.e. WorkerGlobalScope.close() has been called).

No new tests, covered by fast/workers/worker-close-more.html.

• dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchEvent):

10:08 AM Changeset in webkit [252241] by guijemont@igalia.com

• 2 edits in trunk/JSTests

Temporarily skip another broken test on MIPS due to OSR exit to LLInt
​https://bugs.webkit.org/show_bug.cgi?id=204003

Unreviewed gardening.

• stress/global-import-function-should-return-a-promise-when-clearing-exceptions.js:

10:06 AM Changeset in webkit [252240] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Picture-in-Picture events are not fired when enter/exit the Picture-in-Picture mode through modern media controls
​https://bugs.webkit.org/show_bug.cgi?id=203933

Patch by Peng Liu <Peng Liu> on 2019-11-08
Reviewed by Eric Carlson.

Covered by existing layout test cases. No new test is required.

• Modules/modern-media-controls/media/pip-support.js:

(PiPSupport.prototype.buttonWasPressed):

• Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp:

(WebCore::HTMLVideoElementPictureInPicture::didEnterPictureInPicture):
(WebCore::HTMLVideoElementPictureInPicture::didExitPictureInPicture):

8:58 AM Changeset in webkit [252239] by mark.lam@apple.com

• 11 edits
  2 adds in trunk

Add a stack overflow check in Yarr::ByteCompiler::emitDisjunction().
​https://bugs.webkit.org/show_bug.cgi?id=203936
<rdar://problem/56624724>

Reviewed by Saam Barati.

JSTests:

This issue originally manifested as incorrect-exception-assertion-in-operationRegExpExecNonGlobalOrSticky.js
failing on iOS devices due to its smaller stack. We adapted the original test
here using $vm.callWithStackSize() to reproduce the issue on x86_64 though it
has a much larger physical stack to work with. This new test will crash while
stepping on the guard page beyond the end of the stack if the fix is not applied.

• stress/stack-overflow-in-yarr-byteCompile.js: Added.

Source/JavaScriptCore:

Basically, any functions below Yarr::ByteCompiler::compile() that recurses need
to check if it's safe to recurse before doing so. This patch adds the stack
checks in Yarr::ByteCompiler::compile() because it is the entry point to this
sub-system, and Yarr::ByteCompiler::emitDisjunction() because it is the only
function that recurses. All other functions called below compile() are either
leaf functions or have shallow stack usage. Hence, their stack needs are covered
by the DefaultReservedZone, and they do not need stack checks.

This patch also does the following:

1. Added $vm.callWithStackSize() which can be used to call a test function near the end of the physical stack. This enables is to simulate the smaller stack size of more resource constrained devices.

$vm.callWithStackSize() uses inline asm to adjust the stack pointer and
does the callback via the JIT probe trampoline.

2. Added the --disableOptionsFreezingForTesting to the jsc shell to make it possible to disable freezing of JSC options. $vm.callWithStackSize() relies on this to modify the VM's stack limits.

3. Removed the inline modifier on VM::updateStackLimits() so that we can call it from $vm.callWithStackSize() as well. It is not a performance critical function and is rarely called.

4. Added a JSDollarVMHelper class that other parts of the system can declare as a friend. This gives $vm a backdoor into the private functions and fields of classes for its debugging work. In this patch, we're only using it to access VM::updateVMStackLimits().

• jsc.cpp:

(CommandLine::parseArguments):

• runtime/VM.cpp:

(JSC::VM::updateStackLimits):

• runtime/VM.h:
• tools/JSDollarVM.cpp:

(JSC::JSDollarVMHelper::JSDollarVMHelper):
(JSC::JSDollarVMHelper::vmStackStart):
(JSC::JSDollarVMHelper::vmStackLimit):
(JSC::JSDollarVMHelper::vmSoftStackLimit):
(JSC::JSDollarVMHelper::updateVMStackLimits):
(JSC::callWithStackSizeProbeFunction):
(JSC::functionCallWithStackSize):
(JSC::JSDollarVM::finishCreation):
(IGNORE_WARNINGS_BEGIN): Deleted.

• yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::emitDisjunction):
(JSC::Yarr::ByteCompiler::isSafeToRecurse):

Source/WTF:

1. Add a StackCheck utility class so that we don't have to keep reinventing this every time we need to add stack checking somewhere.
2. Rename some arguments and constants in StackBounds to be more descriptive of what they actually are.

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/StackBounds.h:

(WTF::StackBounds::recursionLimit const):

• wtf/StackCheck.h: Added.

(WTF::StackCheck::StackCheck):
(WTF::StackCheck::isSafeToRecurse):

7:09 AM Changeset in webkit [252238] by Carlos Garcia Campos

• 7 edits in trunk

WebDriver: implement get page source command
​https://bugs.webkit.org/show_bug.cgi?id=180399

Reviewed by Carlos Alberto Lopez Perez.

Source/WebDriver:

• Session.cpp:

(WebDriver::Session::getPageSource):

• Session.h:
• WebDriverService.cpp:

(WebDriver::WebDriverService::getPageSource):

• WebDriverService.h:

WebDriverTests:

Unskip tests that are now passing.

• TestExpectations.json:

7:04 AM Changeset in webkit [252237] by Alan Coon

• 1 copy in tags/Safari-609.1.9.3

New tag.

7:02 AM Changeset in webkit [252236] by Alan Coon

• 7 edits in tags/Safari-609.1.9.2/Source

Versioning.

2:53 AM Changeset in webkit [252235] by achristensen@apple.com

• 2 edits in trunk/Tools

Build fix for platforms without WebRTC's SSL after r252185
​https://bugs.webkit.org/show_bug.cgi?id=203934

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

The new test uses TLS with the HTTPS proxy. Don't compile it if we can't compile it.

2:23 AM WPE/Releasing created by alex

2:08 AM WPE edited by alex

(diff)

1:19 AM Changeset in webkit [252234] by Carlos Garcia Campos

• 14 edits
  3 adds in trunk

[GTK] Add pointer lock permission request API
​https://bugs.webkit.org/show_bug.cgi?id=203896

Reviewed by Adrian Perez de Castro.

Source/WebKit:

Add a WebKitPointerLockPermissionRequest class to handle pointer lock permissions.

• PlatformGTK.cmake:
• SourcesGTK.txt:
• UIProcess/API/glib/WebKitPointerLockPermissionRequest.cpp: Added.

(webkitPointerLockPermissionRequestAllow):
(webkitPointerLockPermissionRequestDeny):
(webkit_permission_request_interface_init):
(webkitPointerLockPermissionRequestDispose):
(webkit_pointer_lock_permission_request_class_init):
(webkitPointerLockPermissionRequestCreate):
(webkitPointerLockPermissionRequestDidLosePointerLock):

• UIProcess/API/glib/WebKitPointerLockPermissionRequestPrivate.h: Added.
• UIProcess/API/glib/WebKitUIClient.cpp:

(UIClient::~UIClient):

• UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewPermissionRequest):
(webkitWebViewDenyPointerLockRequest):

• UIProcess/API/glib/WebKitWebViewPrivate.h:
• UIProcess/API/gtk/WebKitPointerLockPermissionRequest.h: Added.
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
• UIProcess/API/gtk/docs/webkit2gtk-4.0.types:
• UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
• UIProcess/API/gtk/webkit2.h:

Tools:

Handle pointer lock permission requests in MiniBrowser and add a new tests case to check the new API.

• MiniBrowser/gtk/BrowserTab.c:

(pointerLockMessageTimeoutCallback):
(decidePermissionRequest):
(browserTabFinalize):
(browserTabConstructed):

• TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:

(testWebViewPointerLockPermissionRequest):
(beforeAll):

1:09 AM Changeset in webkit [252233] by Carlos Garcia Campos

• 6 edits
  2 adds in trunk

'Strikethrough' editing command reported as 'formatUnderline'
​https://bugs.webkit.org/show_bug.cgi?id=203944

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Add an EditAction for strikeThrough command.

Test: fast/events/input-events-strikethrough-type.html

• editing/EditAction.cpp:

(WebCore::undoRedoLabel): Handle StrikeThrough action.

• editing/EditAction.h:
• editing/EditCommand.cpp:

(WebCore::inputTypeNameForEditingAction): Ditto.

• editing/EditorCommand.cpp:

(WebCore::executeStrikethrough): Use StrikeThrough action instead of Underline.

LayoutTests:

• fast/events/input-events-strikethrough-type-expected.txt: Added.
• fast/events/input-events-strikethrough-type.html: Added.