Timeline

Dec 13, 2019:

10:37 PM Changeset in webkit [253521] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Nullptr crash if SVG element if element parent becomes document node
​https://bugs.webkit.org/show_bug.cgi?id=205217

Patch by Sunny He <​sunny_he@apple.com> on 2019-12-13
Reviewed by Ryosuke Niwa.

Test: svg/dom/replaceChild-document-crash.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::layoutOverflowRectForPropagation const):

• rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

8:34 PM Changeset in webkit [253520] by ysuzuki@apple.com

• 23 edits
  3 adds
  2 deletes in trunk

[JSC] Remove JSFixedArray, and use JSImmutableButterfly instead
​https://bugs.webkit.org/show_bug.cgi?id=204402

Reviewed by Mark Lam.

JSTests:

• stress/new-array-with-spread-cow-double.js: Added.

(shouldBe):
(shouldBeArray):
(test):

• stress/new-array-with-spread-cow-int.js: Added.

(shouldBe):
(shouldBeArray):
(test):

• stress/new-array-with-spread-cow.js: Added.

(shouldBe):
(shouldBeArray):
(test):

Source/JavaScriptCore:

This patch removes JSFixedArray, and use JSImmutableButterfly instead. JSFixedArray can be replaced by
JSImmutableButterfly with Contiguous shape. And further, we can create an array from JSImmutableButterfly
generated by Spread node in NewArrayBufferWithSpread.

Currently, we are always creating contiguous JSImmutableButterfly from Spread. If it takes contiguous CoW
array, we can reuse JSImmutableButterfly of the input. But if it is CoW and not contiguous shape (like,
CopyOnWriteArrayWithInt32), we create a JSImmutableButterfly and copy it to this new butterfly. We can
extend it to accept non-contiguous JSImmutableButterfly in the future.

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• bytecompiler/BytecodeGenerator.cpp:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:
• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSpread):
(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):
(JSC::DFG::SpeculativeJIT::compileObjectKeys):

• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileSpread):
(JSC::FTL::DFG::LowerDFGToB3::toButterfly):

• ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

• interpreter/Interpreter.cpp:

(JSC::sizeOfVarargs):
(JSC::loadVarargs):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/JSCast.h:
• runtime/JSFixedArray.cpp: Removed.
• runtime/JSFixedArray.h: Removed.
• runtime/JSImmutableButterfly.h:

(JSC::JSImmutableButterfly::createFromArray):
(JSC::JSImmutableButterfly::offsetOfPublicLength):
(JSC::JSImmutableButterfly::offsetOfVectorLength):

• runtime/JSType.cpp:

(WTF::printInternal):

• runtime/JSType.h:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

7:12 PM Changeset in webkit [253519] by beidson@apple.com

• 33 edits in trunk/Source

Refactor ScriptController's proliferation of ExceptionDetails*.
​https://bugs.webkit.org/show_bug.cgi?id=205151

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Refactor, no behavior change).

There's so many ExceptionDetails* null pointers being passed around in the ScriptController
family of functions.

Let's make it a little more explicit which callers get exceptions and which don't.

• Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::ensureReplacementScriptInjected):

• bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorldIgnoringException):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluateIgnoringException):
(WebCore::ScriptController::executeScriptInWorldIgnoringException):
(WebCore::ScriptController::executeScriptInWorld):
(WebCore::ScriptController::executeUserAgentScriptInWorld):
(WebCore::ScriptController::executeScriptIgnoringException):
(WebCore::ScriptController::executeIfJavaScriptURL):
(WebCore::ScriptController::evaluate): Deleted.
(WebCore::ScriptController::executeScript): Deleted.

• bindings/js/ScriptController.h:

• contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):

• dom/Document.cpp:

(WebCore::Document::ensurePlugInsInjectedScript):

• dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeClassicScript):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):

• inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):

• inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):

• loader/ContentFilter.cpp:

(WebCore::ContentFilter::didDecide):

• page/Frame.cpp:

(WebCore::Frame::injectUserScriptImmediately):

• xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

Source/WebKit:

• UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _evaluateJavaScript:forceUserGesture:completionHandler:]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::runJavaScriptInMainFrameScriptWorld):
(WebKit::WebPageProxy::runJavaScriptInFrame):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performJavaScriptURLRequest):

• WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.cpp:

(WebKit::WebInspectorFrontendAPIDispatcher::evaluateOrQueueExpression):
(WebKit::WebInspectorFrontendAPIDispatcher::evaluateQueuedExpressions):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScript):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):

• WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

• WebView/WebView.mm:

(-[WebView aeDescByEvaluatingJavaScriptFromString:]):

Source/WebKitLegacy/win:

• Plugins/PluginView.cpp:

(WebCore::PluginView::performRequest):

• WebFrame.cpp:

(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

• WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

6:10 PM Changeset in webkit [253518] by Wenson Hsieh

• 2 edits in trunk/Tools

Unreviewed, fix the macCatalyst build after r253486

Replace the #elif with an #else, so that the codepath is compiled on non-iOS (but iOS-family) platforms such as
watchOS and macCatalyst.

• TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:

(readMarkupFromPasteboard):

6:08 PM Changeset in webkit [253517] by sbarati@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Structure should have a bloom filter of seen identifiers
​https://bugs.webkit.org/show_bug.cgi?id=205182

Reviewed by Yusuke Suzuki and Tadeu Zagallo.

This patch adds a bloom filter of seen identifiers to Structure. This usually allows
us to quickly determine if a Structure *has not* seen a particular property. Based
on some logging I added in JetStream2 and Speedometer2, 70% of calls to Structure::get
result in us returning invalidOffset (e.g, the property does not exist). This patch
allows that path to be even faster. This bloom filter is just modeling what goes inside
Structure's property table. For that reason, we don't need to consider things inside
the static property table. We reason about the static property table inside JSObject's
property lookup.

This patch appears to be a 0.5% progression on Speedometer2.

• runtime/Structure.cpp:

(JSC::Structure::Structure):

• runtime/Structure.h:
• runtime/StructureInlines.h:

(JSC::Structure::get):
(JSC::Structure::add):

5:52 PM Changeset in webkit [253516] by eric.carlson@apple.com

• 16 edits in trunk/Source

Add remote media player message to load and play
​https://bugs.webkit.org/show_bug.cgi?id=205220
<rdar://problem/57927486>

Reviewed by Jer Noble.
Source/WebCore:

No new tests. Tested manually because it is not possible to test on a bot yet.

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::loadWithNextMediaEngine): Call the new method prepareForPlayback
instead of making four calls to set properties on a new player.

• platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::load): Add a load variant that takes a URL,
contentType, and keySystem.
(WebCore::MediaPlayerPrivateInterface::prepareForPlayback):

Source/WebKit:

Add WP -> GPU process messages: PrepareForPlayback, Load, CancelLoad, Play, Pause,
SetVolume, and SetMuted
Add GPUP -> WP message: PlaybackStateChanged

• GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::RemoteMediaPlayerManagerProxy):
(WebKit::RemoteMediaPlayerManagerProxy::createMediaPlayer):
(WebKit::RemoteMediaPlayerManagerProxy::deleteMediaPlayer):
(WebKit::RemoteMediaPlayerManagerProxy::prepareForPlayback):
(WebKit::RemoteMediaPlayerManagerProxy::load):
(WebKit::RemoteMediaPlayerManagerProxy::cancelLoad):
(WebKit::RemoteMediaPlayerManagerProxy::play):
(WebKit::RemoteMediaPlayerManagerProxy::pause):
(WebKit::RemoteMediaPlayerManagerProxy::setVolume):
(WebKit::RemoteMediaPlayerManagerProxy::setMuted):
(WebKit::RemoteMediaPlayerManagerProxy::logChannel const):

• GPUProcess/media/RemoteMediaPlayerManagerProxy.h:

(WebKit::RemoteMediaPlayerManagerProxy::gpuConnectionToWebProcess const):
(WebKit::RemoteMediaPlayerManagerProxy::webProcessConnection const): Deleted.

• GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::RemoteMediaPlayerProxy):
(WebKit::RemoteMediaPlayerProxy::load):
(WebKit::RemoteMediaPlayerProxy::prepareForPlayback):
(WebKit::RemoteMediaPlayerProxy::cancelLoad):
(WebKit::RemoteMediaPlayerProxy::play):
(WebKit::RemoteMediaPlayerProxy::pause):
(WebKit::RemoteMediaPlayerProxy::setVolume):
(WebKit::RemoteMediaPlayerProxy::setMuted):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerNetworkStateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerReadyStateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerVolumeChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMuteChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerTimeChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerDurationChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRateChanged):

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::didReceiveMessage):

• WebProcess/GPU/GPUProcessConnection.h:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::prepareForPlayback):
(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote::load):
(WebKit::MediaPlayerPrivateRemote::cancelLoad):
(WebKit::MediaPlayerPrivateRemote::play):
(WebKit::MediaPlayerPrivateRemote::pause):
(WebKit::MediaPlayerPrivateRemote::setVolumeDouble):
(WebKit::MediaPlayerPrivateRemote::setMuted):
(WebKit::MediaPlayerPrivateRemote::muteChanged):
(WebKit::MediaPlayerPrivateRemote::timeChanged):
(WebKit::MediaPlayerPrivateRemote::playbackStateChanged):
(WebKit::MediaPlayerPrivateRemote::paused const): Deleted.

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::RemoteMediaPlayerManager::RemoteMediaPlayerManager):
(WebKit::RemoteMediaPlayerManager::~RemoteMediaPlayerManager):
(WebKit::RemoteMediaPlayerManager::playbackStateChanged):

• WebProcess/GPU/media/RemoteMediaPlayerManager.h:

(WebKit::RemoteMediaPlayerManager::didReceiveMessageFromWebProcess):

• WebProcess/GPU/media/RemoteMediaPlayerManager.messages.in:

5:51 PM Changeset in webkit [253515] by mark.lam@apple.com

• 3 edits
  1 add in trunk

Fix bad exception assertion in ExceptionHelpers.cpp's createError().
​https://bugs.webkit.org/show_bug.cgi?id=205230
<rdar://problem/57875688>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/test-exception-assert-in-ExceptionHelpers-createError.js: Added.

Source/JavaScriptCore:

The code in createError() was doing the following:

String valueDescription = errorDescriptionForValue(globalObject, value);

EXCEPTION_ASSERT(scope.exception()

!!valueDescription);

if (!valueDescription) {

scope.clearException();
return createOutOfMemoryError(globalObject);

}

If errorDescriptionForValue() throws an exception, then we expect the
valueDescription string to be null so that we can throw an OutOfMemoryError.
However, errorDescriptionForValue() can detect an imminent overflow in String
length and just return a null string without throwing an exception which fails
the above assertion.

The fix is to simply do an explicit exception check in addition to the null string
check and remove the assertion.

• runtime/ExceptionHelpers.cpp:

(JSC::createError):

5:39 PM Changeset in webkit [253514] by Chris Dumez

• 3 edits in trunk/Source/WebKit

[macOS] Swipe gesture snapshot stays too long if provisional load has not started yet when endSwipeGesture() is called
​https://bugs.webkit.org/show_bug.cgi?id=205206

Reviewed by Tim Horton.

Swipe gesture snapshot stays too long if provisional load has not started yet when endSwipeGesture() is called on macOS.
This is because the SnapshotRemovalTracker::eventOccurred() calls get ignored while the SnapshotRemovalTracker is paused
and the SnapshotRemovalTracker only gets unpaused once the provisional load has started. The idea is that we should ignore
any events from a previous navigation. However, the SwipeGestureEnd event is a UI-side event fired by the
ViewGestureController itself, so there is reason to ignore it. Since we ask the WebContent process to do the load in
willEndSwipeGesture(), it is possible that the provisional load has not started yet by the time endSwipeGesture() is
called. In such case, the SwipeGestureEnd event would get ignored and we would keep the snapshot until the timeout.

• UIProcess/ViewGestureController.cpp:

(WebKit::stopWaitingForEvent):
(WebKit::ViewGestureController::SnapshotRemovalTracker::eventOccurred):
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::SnapshotRemovalTracker::stopWaitingForEvent): Deleted.

• UIProcess/ViewGestureController.h:

5:36 PM Changeset in webkit [253513] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

ANGLE: fix blending with alpha:false context
​https://bugs.webkit.org/show_bug.cgi?id=205218

Fixes WebGL conformance test context-hidden-alpha.html.

Patch by James Darpinian <James Darpinian> on 2019-12-13
Reviewed by Alex Christensen.

• platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer allocateIOSurfaceBackingStoreWithSize:usingAlpha:]):

Specify internalformat GL_RGB instead of GL_BGRA_EXT when alpha is disabled.

5:20 PM Changeset in webkit [253512] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Add an option to run_webkit_tests.py to enable all GPU process related features and choose the additional expectations
​https://bugs.webkit.org/show_bug.cgi?id=205214

The option also specifies the result-report-flavor.

Patch by Peng Liu <Peng Liu> on 2019-12-13
Reviewed by Tim Horton.

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

5:20 PM Changeset in webkit [253511] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed 32-bit build fix: explicitly cast the bitrate to an int when creating a JSON
object for logging purposes.

• platform/mediacapabilities/MediaCapabilitiesLogging.cpp:

(WebCore::toJSONObject):

5:10 PM Changeset in webkit [253510] by Alan Coon

• 1 copy in tags/Safari-609.1.11.4

Tag Safari-609.1.11.4.

5:08 PM Changeset in webkit [253509] by Alan Coon

• 7 edits in branches/safari-609.1.11.4-branch/Source

Versioning.

5:05 PM Changeset in webkit [253508] by Alan Coon

• 1 edit in tags/Safari-609.1.12/Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm

Unreviewed build fix. rdar://problem/57925932

4:56 PM Changeset in webkit [253507] by Alan Coon

• 1 copy in branches/safari-609.1.11.4-branch

New branch.

4:56 PM Changeset in webkit [253506] by dino@apple.com

• 1 edit in trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig

Build fix for WebCoreTestSupport.

• Configurations/WebCoreTestSupport.xcconfig:

4:35 PM CommitterTips edited by Alexey Shvayka

Add webkit-changes mailing list (diff)

4:33 PM Changeset in webkit [253505] by Alan Coon

• 1 copy in tags/Safari-609.1.11.3

Tag Safari-609.1.11.3.

3:42 PM Changeset in webkit [253504] by Alan Coon

• 18 edits
  1 delete in tags/Safari-609.1.12/Source

Apply patch. rdar://problem/57925932

3:30 PM Changeset in webkit [253503] by Alexey Shvayka

• 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

• Scripts/webkitpy/common/config/contributors.json:

3:13 PM Changeset in webkit [253502] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

Add MESSAGE_CHECK() for selectedIndex in Messages::WebPageProxy::ShowPopupMenu
<​https://webkit.org/b/205177>
<rdar://problem/57337872>

Reviewed by Chris Dumez.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu): Add MESSAGE_CHECK() to
validate the selectedIndex parameter, which must be -1 to
select no items, or a valid zero-based index into items.

2:38 PM Changeset in webkit [253501] by commit-queue@webkit.org

• 5 edits in trunk

Allow cross-origin requests to WKURLSchemeHandlers
​https://bugs.webkit.org/show_bug.cgi?id=205198
<rdar://problem/57897836>

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-12-13
Reviewed by Brady Eidson.

Source/WebKit:

Covered by an API test.

• UIProcess/API/Cocoa/WKURLSchemeTask.h:

Document the requirements for cross-origin requests.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::registerURLSchemeHandler):
When we register a scheme handler, allow cross origin resources for that scheme.
This will make the check in DocumentThreadableLoader::checkURLSchemeAsCORSEnabled allow the request to get to the WKURLSchemeHandler.
The resposne must still have CORS header fields in order for the data to get to the web content, like CORS with HTTP.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

Verify that a cross origin request is received by the WKURLSchemeHandler. It was not before.
Verify that loading will fail unless there are CORS headers in the response.

2:37 PM Changeset in webkit [253500] by sbarati@apple.com

• 5 edits in trunk/Source

Add a Heap::finalize function that takes WTF::Function<void()>
​https://bugs.webkit.org/show_bug.cgi?id=205211

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• heap/Heap.cpp:

(JSC::Heap::addFinalizer):
(JSC::Heap::FinalizerOwner::finalize):

• heap/Heap.h:

Source/WTF:

• wtf/Function.h:

(WTF::Function<Out):

2:35 PM Changeset in webkit [253499] by dino@apple.com

• 6 edits in trunk/Source

MacCatalyst build of libANGLE is installed in the incorrect location
​https://bugs.webkit.org/show_bug.cgi?id=205219
<rdar://problem/57713353>

Reviewed by Simon Fraser.

Source/ThirdParty/ANGLE:

Rename libANGLE.dylib into libANGLE-shared.dylib, so we can
avoid accidentally trying to link to the libANGLE.a that was
removed recently (but still exists in the SDK for now).

Also, make sure that we install into the correct location for
a Catalyst build.

• ANGLE.xcodeproj/project.pbxproj:
• Configurations/ANGLE.xcconfig:
• Configurations/Base.xcconfig:

Source/WebCore:

The location that WebCore was looking for embedded libraries was
incorrect for Catalyst builds. We never noticed because until now
there were no embedded libraries, and local builds all go into
the same location so this would only happen on Production builds.

Also, libANGLE became libANGLE-shared.

• Configurations/WebCore.xcconfig: Link with libANGLE's new name, and

look in the correct directory.

1:46 PM Changeset in webkit [253498] by mmaxfield@apple.com

• 3 edits
  2 adds in trunk

[watchOS] Apple.com is rendered in Times New Roman
​https://bugs.webkit.org/show_bug.cgi?id=205179
<rdar://problem/57233936>

Reviewed by Tim Horton.

Source/WebCore:

We should just make watchOS use the same font lookup attributes as iOS and macOS.

Test: fast/text/smiley-local-font-src.html

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontDatabase::fontForPostScriptName):

LayoutTests:

• fast/text/smiley-local-font-src-expected.html: Added.
• fast/text/smiley-local-font-src.html: Added.

1:36 PM Changeset in webkit [253497] by Chris Dumez

• 59 edits
  2 copies in trunk

Implement PostMessageOptions for postMessage
​https://bugs.webkit.org/show_bug.cgi?id=191028

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that we have more passes.

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
• web-platform-tests/html/browsers/windows/document-access/document_access_parent_access.tentative-expected.txt:
• web-platform-tests/service-workers/service-worker/clients-matchall-frozen.https-expected.txt:
• web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt:
• web-platform-tests/webmessaging/message-channels/dictionary-transferrable-expected.txt:
• web-platform-tests/webmessaging/message-channels/user-activation.tentative-expected.txt:
• web-platform-tests/webmessaging/postMessage_MessagePorts_xsite.sub.window-expected.txt:
• web-platform-tests/webmessaging/with-options/host-specific-origin-expected.txt:
• web-platform-tests/webmessaging/with-options/message-channel-transferable-expected.txt:
• web-platform-tests/webmessaging/with-options/no-target-origin-expected.txt:
• web-platform-tests/webmessaging/with-options/null-transfer-expected.txt:
• web-platform-tests/webmessaging/with-options/one-arg-expected.txt:
• web-platform-tests/webmessaging/with-options/slash-origin-expected.txt:
• web-platform-tests/webmessaging/with-options/undefined-transferable-expected.txt:
• web-platform-tests/webmessaging/with-options/unknown-parameter-expected.txt:
• web-platform-tests/webmessaging/without-ports/008-expected.txt:
• web-platform-tests/webmessaging/worker_postMessage_user_activation.tentative-expected.txt:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-dictionary-expected.txt:
• web-platform-tests/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-null-expected.txt:

Source/WebCore:

Implement PostMessageOptions dictionary parameter for postMessage:

• ​https://github.com/whatwg/html/issues/3799
• ​https://github.com/w3c/ServiceWorker/pull/1344

Blink and Gecko already support this.

No new tests, rebaselined existing tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Headers.cmake:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):

• dom/MessagePort.h:
• dom/MessagePort.idl:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

• page/DOMWindow.h:

(WebCore::WindowPostMessageOptions::WindowPostMessageOptions):

• page/DOMWindow.idl:
• page/PostMessageOptions.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.idl.

(WebCore::PostMessageOptions::PostMessageOptions):

• page/PostMessageOptions.idl: Copied from Source/WebCore/workers/service/ServiceWorkerClient.idl.
• workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::postMessage):

• workers/DedicatedWorkerGlobalScope.h:
• workers/DedicatedWorkerGlobalScope.idl:
• workers/Worker.cpp:

(WebCore::Worker::postMessage):

• workers/Worker.h:
• workers/Worker.idl:
• workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

• workers/service/ServiceWorker.h:
• workers/service/ServiceWorker.idl:
• workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::postMessage):

• workers/service/ServiceWorkerClient.h:
• workers/service/ServiceWorkerClient.idl:

LayoutTests:

Update a few existing tests due to the behavior change.

• TestExpectations:
• fast/dom/Window/post-message-crash.html:
• fast/events/message-port-multi-expected.txt:
• fast/events/resources/message-port-multi.js:
• fast/workers/resources/worker-context-thread-multi-port.js:
• fast/workers/resources/worker-multi-port.js:
• fast/workers/worker-multi-port-expected.txt:
• http/tests/security/postMessage/target-origin-expected.txt:
• platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

1:31 PM Changeset in webkit [253496] by cturner@igalia.com

• 2 edits in trunk/LayoutTests

[GStreamer][EME] Update expectation for media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html
​https://bugs.webkit.org/show_bug.cgi?id=205215

Unreviewed gardening.

• platform/gtk/TestExpectations: Update bug URL to new failure reason.

1:22 PM Changeset in webkit [253495] by Wenson Hsieh

• 7 edits in trunk/Source

Implement encoding/decoding for DisplayList::DrawNativeImage
​https://bugs.webkit.org/show_bug.cgi?id=205200

Reviewed by Simon Fraser.

Source/WebCore:

Implements basic encoding and decoding for the DrawNativeImage drawing item, such that it can be sent and
replayed in the GPU process. See WebKit ChangeLogs for more details. Eventually, we should avoid calling into
drawNativeImage in the web process altogether, but for now, both DrawNativeImage and DrawImage drawing items
rely on drawing native images into ImageBuffers. See: <​https://webkit.org/b/205213>.

• platform/graphics/NativeImage.h:

Add a NativeImageHandle wrapper around a NativeImagePtr to make it simpler to decode and encode NativeImagePtrs
using << and >> operators.

• platform/graphics/displaylists/DisplayListItems.cpp:
• platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawNativeImage::encode const):
(WebCore::DisplayList::DrawNativeImage::decode):
(WebCore::DisplayList::Item::encode const):
(WebCore::DisplayList::Item::decode):

Source/WebKit:

Add helper functions to encode and decode NativeImagePtr (RetainPtr<CGImageRef> on Cocoa platforms). This
mirrors the implementation of encoding and decoding for WebCore::Image, which create and draws into
ShareableBitmap, and send a handle to the data over IPC.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeImage):
(IPC::decodeImage):
(IPC::encodeNativeImage):
(IPC::decodeNativeImage):

Additionally make Image and NativeImagePtr encoding and decoding helpers fail quickly in the case where the
ShareableBitmap failed to create a graphics context by having the encoder indicate whether a graphics context
was created, and having the decoder fail if the graphics context could not be created.

(IPC::encodeOptionalNativeImage):
(IPC::decodeOptionalNativeImage):
(IPC::ArgumentCoder<NativeImageHandle>::encode):
(IPC::ArgumentCoder<NativeImageHandle>::decode):

• Shared/WebCoreArgumentCoders.h:

12:49 PM Changeset in webkit [253494] by youenn@apple.com

• 11 edits in trunk

Add support for WebIDL set-like forEach
​https://bugs.webkit.org/show_bug.cgi?id=204847

Reviewed by Chris Dumez.

Source/WebCore:

Add support to setlike forEach as done for maplike.
Covered by rebased binding tests and updated layout test.

• bindings/js/JSDOMBindingInternals.js:

(forEachWrapper):

• bindings/js/JSDOMMapLike.cpp:

(WebCore::forwardForEachCallToBackingMap):

• bindings/js/JSDOMSetLike.cpp:

(WebCore::DOMSetAdapter::clear):
(WebCore::forwardForEachCallToBackingSet):

• bindings/js/JSDOMSetLike.h:

(WebCore::DOMSetAdapter::add):
(WebCore::getAndInitializeBackingSet):
(WebCore::forwardSizeToSetLike):
(WebCore::forwardEntriesToSetLike):
(WebCore::forwardKeysToSetLike):
(WebCore::forwardValuesToSetLike):
(WebCore::forwardForEachToSetLike):
(WebCore::forwardClearToSetLike):
(WebCore::forwardHasToSetLike):
(WebCore::forwardAddToSetLike):
(WebCore::forwardDeleteToSetLike):

• bindings/scripts/IDLParser.pm:

(parseSetLikeProperties):

• bindings/scripts/test/JS/JSReadOnlySetLike.cpp:

(WebCore::jsReadOnlySetLikePrototypeFunctionForEachBody):
(WebCore::jsReadOnlySetLikePrototypeFunctionForEach):

• bindings/scripts/test/JS/JSSetLike.cpp:

(WebCore::jsSetLikePrototypeFunctionForEachBody):
(WebCore::jsSetLikePrototypeFunctionForEach):

LayoutTests:

• js/dom/maplike.html:
• js/dom/setlike.html:

12:38 PM Changeset in webkit [253493] by Chris Dumez

• 10 edits in trunk

REGRESSION: (r251677) imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=205164
<rdar://problem/57879042>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that they are passing.

• web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3-expected.txt:
• web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-expected.txt:

Source/WebCore:

Submitting a form should cancel any pending navigation scheduled by a previous submission of this form:

• ​https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#form-submission-algorithm (step 22.3)

No new tests, rebaselined existing tests.

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::submit):

• html/HTMLFormElement.h:
• loader/FormSubmission.h:

(WebCore::FormSubmission::cancel):
(WebCore::FormSubmission::wasCancelled const):

• loader/NavigationScheduler.cpp:

LayoutTests:

Unskip test that should no longer be flaky.

• platform/mac/TestExpectations:

11:37 AM Changeset in webkit [253492] by Alan Coon

• 2 edits in tags/Safari-609.1.12/Source/ThirdParty/ANGLE

Revert r253333. rdar://problem/57713353

11:37 AM Changeset in webkit [253491] by Alan Coon

• 2 edits in tags/Safari-609.1.12/Source/ThirdParty/ANGLE

Revert r253383. rdar://problem/57713353

11:31 AM Changeset in webkit [253490] by Devin Rousso

• 4 edits in trunk/Tools

Teach prepare-ChangeLog about JavaScript async functions
​https://bugs.webkit.org/show_bug.cgi?id=205195

Reviewed by Jonathan Bedard.

• Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_javascript):

• Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:

(AsyncFuncClass): Added.
(AsyncFuncClass.async staticAsync): Added.
(AsyncFuncClass.prototype.async methodAsync): Added.
(AsyncFuncClass.prototype.async get getAsync): Added.
(AsyncFuncClass.prototype.async set setAsync): Added.
(async asyncFunc1): Added.

• Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:

11:18 AM Changeset in webkit [253489] by wilander@apple.com

• 5 edits
  3 adds in trunk

IsLoggedIn: Abstract data type for IsLoggedIn state
​https://bugs.webkit.org/show_bug.cgi?id=205041
<rdar://problem/56723904>

Reviewed by Chris Dumez.

Source/WebCore:

New API tests added.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• page/LoggedInStatus.cpp: Added.

(WebCore::LoggedInStatus::create):
(WebCore::LoggedInStatus::LoggedInStatus):
(WebCore::LoggedInStatus::setTimeToLive):
(WebCore::LoggedInStatus::hasExpired const):
(WebCore::LoggedInStatus::expiry const):

• page/LoggedInStatus.h: Added.

(WebCore::LoggedInStatus::registrableDomain const):
(WebCore::LoggedInStatus::username const):
(WebCore::LoggedInStatus::credentialTokenType const):
(WebCore::LoggedInStatus::authenticationType const):
(WebCore::LoggedInStatus::loggedInTime const):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/LoggedInStatus.cpp: Added.

(TestWebKitAPI::TEST):

11:07 AM Changeset in webkit [253488] by pvollan@apple.com

• 11 edits
  4 adds in trunk

[iOS] Deny mach lookup access to "*.apple-extension-service" in the WebContent process
​https://bugs.webkit.org/show_bug.cgi?id=205134
<rdar://problem/56984257>

Reviewed by Brent Fulgham.

Source/WebCore:

Add method to Internals checking mach lookup access to a given XPC service name.

Test: fast/sandbox/ios/sandbox-mach-lookup.html

• testing/Internals.cpp:

(WebCore::Internals::hasSandboxMachLookupAccessToXPCServiceName):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

Remove mach lookup access to "*.apple-extension-service" in the sandbox.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

Source/WTF:

Add enum value for the XPC service name filter type.

• wtf/spi/darwin/SandboxSPI.h:

LayoutTests:

Add test for mach lookup access to "*.apple-extension-service".

• TestExpectations:
• fast/sandbox: Added.
• fast/sandbox/ios: Added.
• fast/sandbox/ios/sandbox-mach-lookup-expected.txt: Added.
• fast/sandbox/ios/sandbox-mach-lookup.html: Added.
• platform/ios-device-wk2/TestExpectations:

10:58 AM Changeset in webkit [253487] by youenn@apple.com

• 7 edits in trunk

Help debugging flaky http/tests/cache-storage/page-cache-domcachestorage-pending-promise.html
​https://bugs.webkit.org/show_bug.cgi?id=205209

Reviewed by Chris Dumez.

Source/WebKit:

Add a bunch of asserts that no pending activity is happening in the Cache Storage backend is happening
when querying the backend representation, which is a debug tool.
No change of behavior.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::representation):

• NetworkProcess/cache/CacheStorageEngineCache.h:

(WebKit::CacheStorage::Cache::hasPendingOpeningCallbacks const):

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::appendRepresentation const):

LayoutTests:

In case of error, query the cache representation.
This will help debugging the flaky tests and ensure that no pending activity is happening in error cases.

• http/tests/cache-storage/page-cache-domcache-pending-promise.html:
• http/tests/cache-storage/page-cache-domcachestorage-pending-promise.html:

10:39 AM Changeset in webkit [253486] by Wenson Hsieh

• 14 edits
  4 adds in trunk

[Clipboard API] Sanitize HTML and image data written using clipboard.write
​https://bugs.webkit.org/show_bug.cgi?id=205188
<rdar://problem/57612968>

Reviewed by Darin Adler.

Source/WebCore:

Sanitizes HTML ("text/html") and image ("image/png") content when writing to the platform pasteboard using the
clipboard API. See below for more details.

Tests: editing/async-clipboard/sanitize-when-reading-markup.html

editing/async-clipboard/sanitize-when-writing-image.html
ClipboardTests.WriteSanitizedMarkup

• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:

(WebCore::ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::sanitizeDataIfNeeded):

Add a new helper method to sanitize m_data after loading finishes, but before invoking the completion handler
to notify the data source about the clipboard data. Currently, we support writing "text/plain", "text/uri-list",
"text/html" and "image/png"; we sanitize HTML by stripping away hidden content such as comments, script, and
event listeners, and sanitize image data by painting it into a new graphics context and re-encoding the rendered
contents as an image.

(WebCore::ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::invokeCompletionHandler):

• Modules/async-clipboard/ClipboardItemBindingsDataSource.h:
• platform/PlatformPasteboard.h:
• platform/cocoa/PasteboardCocoa.mm:

(WebCore::cocoaTypeToImageType):

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::platformPasteboardTypeForSafeTypeForDOMToReadAndWrite):

Adjust these helpers to map "image/png" to the platform PNG type on iOS ("public.png"). The extra
IncludeImageTypes argument was added to avoid considering "image/png" a web-safe type for writing and reading
when exercising DataTransfer APIs, which currently don't support reading the "image/png" MIME type. In the
future, we should consider adding support for image sanitization when using DataTransfer.setData or
DataTransferItemList.add, and then remove this flag.

(WebCore::createItemProviderRegistrationList):

• platform/mac/LegacyNSPasteboardTypes.h:

Add an entry for legacyPNGPasteboardType on macOS, and replace one use of it in PasteboardCocoa.mm.

(WebCore::legacyPNGPasteboardType):

• platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::platformPasteboardTypeForSafeTypeForDOMToReadAndWrite):

Likewise, map "image/png" to legacyPNGPasteboardType() on macOS, which was added above.

(WebCore::createPasteboardItem):

Tools:

Adds an API test to verify that the markup written to the platform pasteboard on macOS and iOS is sanitized, and
does not contain hidden content, such as script elements.

• TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:

(-[TestWKWebView writeString:toClipboardWithType:]):
(readMarkupFromPasteboard):

• TestWebKitAPI/Tests/WebKitCocoa/clipboard.html:

LayoutTests:

• editing/async-clipboard/sanitize-when-reading-markup-expected.txt: Added.
• editing/async-clipboard/sanitize-when-reading-markup.html: Added.

Add a test to verify that markup is sanitized when copying and pasting across different security origins.

• editing/async-clipboard/sanitize-when-writing-image-expected.txt: Added.
• editing/async-clipboard/sanitize-when-writing-image.html: Added.

Add a test to verify that "image/png" data is sanitized, and one or more written image data that cannot be
decoded results in the promise being rejected.

• platform/mac-wk1/TestExpectations:
• platform/win/TestExpectations:

10:35 AM Changeset in webkit [253485] by Simon Fraser

• 4 edits in trunk/Source/WebKit

Minor WKWebView.mm code rearrangement
​https://bugs.webkit.org/show_bug.cgi?id=205129

Reviewed by Tim Horton.

Throw in some more #pragma marks and move some functions around, with the goal of
having the implementation order mostly follow header order, and grouping related functions.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pageForTesting]):
(-[WKWebView _page]):
(-[WKWebView urlSchemeHandlerForURLScheme:]):
(+[WKWebView handlesURLScheme:]):
(-[WKWebView _resolutionForShareSheetImmediateCompletionForTesting]):
(-[WKWebView createPDFWithConfiguration:completionHandler:]):
(-[WKWebView createWebArchiveDataWithCompletionHandler:]):
(toFindOptions):
(-[WKWebView findString:withConfiguration:completionHandler:]):
(-[WKWebView setMediaType:]):
(-[WKWebView mediaType]):
(-[WKWebView layoutSubviews]):
(-[WKWebView scrollView]):
(-[WKWebView _isShowingVideoPictureInPicture]):
(-[WKWebView _mayAutomaticallyShowVideoPictureInPicture]):
(-[WKWebView _incrementFocusPreservationCount]):
(-[WKWebView _decrementFocusPreservationCount]):
(-[WKWebView _resetFocusPreservationCount]):
(-[WKWebView _isRetainingActiveFocusedState]):
(-[WKWebView _effectiveAppearanceIsDark]):
(-[WKWebView _effectiveUserInterfaceLevelIsElevated]):
(-[WKWebView _shouldAvoidResizingWhenInputViewBoundsChange]):
(-[WKWebView _dragInteractionPolicy]):
(-[WKWebView _setDragInteractionPolicy:]):
(-[WKWebView _populateArchivedSubviews:]):
(-[WKWebView _isBackground]):
(-[WKWebView _setShouldSuppressFirstResponderChanges:]):
(-[WKWebView _retainActiveFocusedState]):
(-[WKWebView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
(-[WKWebView _snapshotLayerContentsForBackForwardListItem:]):
(-[WKWebView _dataDetectionResults]):
(-[WKWebView _accessibilityRetrieveSpeakSelectionContent]):
(-[WKWebView _accessibilityDidGetSpeakSelectionContent:]):
(-[WKWebView _viewportSizeForCSSViewportUnits]):
(-[WKWebView _setViewportSizeForCSSViewportUnits:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.mm: Unified sources build fix (seen while doing other stuff).

10:13 AM Changeset in webkit [253484] by Kate Cheney

• 22 edits
  8 adds in trunk

Create WebKit API calls for ITP Data
​https://bugs.webkit.org/show_bug.cgi?id=204932
<rdar://problem/57632753>

Reviewed by Alex Christensen.

Source/WebKit:

This patch exposes ITP data captured in the network process through the
Objective C API using two new classes: _WKResourceLoadStatisticsFirstParty
and _WKResourceLoadStatisticsThirdParty.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
• NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ensureThirdPartyDataForSpecificFirstPartyDomain):
(WebKit::getThirdPartyDataForSpecificFirstPartyDomains):
(WebKit::ResourceLoadStatisticsMemoryStore::aggregatedThirdPartyData const):

• NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
• NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:

Updated mentions of ThirdPartyData to include the
WebResourceLoadStatisticsStore:: class specifier after relocating
ThirdPartyData.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::aggregatedThirdPartyData):

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:

Updated the data to be sent via completion handler from
WebResourceLoadStatisticsStore so that calls to
aggregatedThirdPartyData() are happening on a background thread.

• Shared/API/APIObject.h:
• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

• UIProcess/API/APIResourceLoadStatisticsFirstParty.h: Added.
• UIProcess/API/APIResourceLoadStatisticsThirdParty.h: Added.
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _getResourceLoadStatisticsDataSummary:]):

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h: Added.
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.mm: Added.

(-[_WKResourceLoadStatisticsFirstParty dealloc]):
(-[_WKResourceLoadStatisticsFirstParty firstPartyDomain]):
(-[_WKResourceLoadStatisticsFirstParty storageAccess]):
(-[_WKResourceLoadStatisticsFirstParty _apiObject]):

• UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstPartyInternal.h: Added.
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h: Added.
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm: Added.

(-[_WKResourceLoadStatisticsThirdParty dealloc]):
(-[_WKResourceLoadStatisticsThirdParty thirdPartyDomain]):
(-[_WKResourceLoadStatisticsThirdParty underFirstParties]):
(-[_WKResourceLoadStatisticsThirdParty _apiObject]):

• UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdPartyInternal.h: Added.

_WKResourceLoadStatisticsFirstParty and _WKResourceLoadStatisticsThirdParty
represent first and third party domains respectively which hold ITP
data and are strongly typed to ensure the correct data is being
exposed via API. The function and parameter names for storage access
specify "third party" because each WKITPFirstParty holds data relevent
to a specific third party and storage access would not make sense in
just a first party context.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::getResourceLoadStatisticsDataSummary):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getResourceLoadStatisticsDataSummary):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):

• UIProcess/WebsiteData/WebsiteDataStore.h:
• WebKit.xcodeproj/project.pbxproj:

Tools:

Added a test to check that the ITP data summary was being properly
aggregated and sent to the UIProcess, and to make sure the API works
as expected. Added interface declarations to the file to allow for
use of the _WKResourceLoadStatisticsFirstParty and
_WKResourceLoadStatisticsThirdParty classes without having
to import the header files.

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(TEST):

9:53 AM Changeset in webkit [253483] by Chris Dumez

• 8 edits in trunk

Behavior of GetOwnProperty for cross-origin windows is not spec-compliant
​https://bugs.webkit.org/show_bug.cgi?id=205184

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

Source/WebCore:

Behavior of GetOwnProperty for cross-origin windows is not spec-compliant:

• ​https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)

We should be able to return frames by name, even if their name conflict with the name of a
same-origin window property (e.g. "close"). Previously, we would throw a SecurityError in
this case.

No new tests, rebaselined existing test.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):

LayoutTests:

• http/tests/security/document-all-expected.txt:

The test is accessing the "alert" property on a cross-origin window. We used to throw a SecurityError,
but we now return a Window object since there is a Window whose name is "alert". The test still passes
as it is not able to call alert() cross-origin.

• http/tests/security/xss-DENIED-window-name-navigator-expected.txt:
• http/tests/security/xss-DENIED-window-name-navigator.html:

Update test to use console.log() to print the result instead of alert() since alert() is not allowed
in a sandbox iframe. I updated the expectation so that top.navigator returns the window with the
name "navigator" instead of undefined, as per the behavior change in this patch. I have verified that
our behavior on this test is consistent with Firefox and Chrome.

9:49 AM Changeset in webkit [253482] by eric.carlson@apple.com

• 34 edits
  1 copy
  12 adds in trunk/Source

Add infrastructure needed for playing media player in the GPU process
​https://bugs.webkit.org/show_bug.cgi?id=205094
<rdar://problem/57815393>

Reviewed by Youenn Fablet.

Source/WebCore:

No new tests, no functional change yet.

• WebCore.xcodeproj/project.pbxproj:
• platform/ContentType.h:

(WebCore::ContentType::encode const):
(WebCore::ContentType::decode):

• platform/graphics/MediaPlayer.cpp:

(WebCore::nullLogger):
(WebCore::nullContentTypeVector):
(WebCore::mutableInstalledMediaEnginesVector):
(WebCore::registerRemotePlayerCallback):
(WebCore::RemoteMediaPlayerSupport::setRegisterRemotePlayerCallback):
(WebCore::buildMediaEnginesVector):
(WebCore::installedMediaEngines):
(WebCore::addMediaEngine):
(WebCore::MediaPlayer::mediaEngine):
(WebCore::bestMediaEngineForSupportParameters):
(WebCore::MediaPlayer::nextMediaEngine):
(WebCore::MediaPlayer::create):
(WebCore::MediaPlayer::MediaPlayer):
(WebCore::MediaPlayer::nextBestMediaEngine):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::getSupportedTypes):
(WebCore::MediaPlayer::originsInMediaCache):
(WebCore::MediaPlayer::clearMediaCache):
(WebCore::MediaPlayer::clearMediaCacheForOrigins):
(WebCore::MediaPlayer::supportsKeySystem):
(WebCore::MediaPlayer::networkStateChanged):
(WebCore::nextMediaEngine): Deleted.
(WebCore::MediaPlayer::nextBestMediaEngine const): Deleted.

• platform/graphics/MediaPlayer.h:

(WebCore::MediaEngineSupportParameters::encode const):
(WebCore::MediaEngineSupportParameters::decode):
(WebCore::MediaPlayerFactory::~MediaPlayerFactory):
(WebCore::MediaPlayerFactory::originsInMediaCache const):
(WebCore::MediaPlayerFactory::clearMediaCache const):
(WebCore::MediaPlayerFactory::clearMediaCacheForOrigins const):
(WebCore::MediaPlayerFactory::supportsKeySystem const):
(WebCore::MediaPlayer::setVideoFullscreenLayer): Deleted.
(WebCore::MediaPlayer::size const): Deleted.
(WebCore::MediaPlayer::invalidTime): Deleted.
(WebCore::MediaPlayer::platformVolumeConfigurationRequired const): Deleted.
(WebCore::MediaPlayer::contentMIMEType const): Deleted.
(WebCore::MediaPlayer::contentTypeCodecs const): Deleted.
(WebCore::MediaPlayer::contentMIMETypeWasInferredFromExtension const): Deleted.
(WebCore::MediaPlayer::mediaPlayerLogIdentifier): Deleted.
(WebCore::MediaPlayer::renderingCanBeAccelerated const): Deleted.
(WebCore::MediaPlayer::renderingModeChanged const): Deleted.
(WebCore::MediaPlayer::acceleratedCompositingEnabled): Deleted.
(WebCore::MediaPlayer::activeSourceBuffersChanged): Deleted.
(WebCore::MediaPlayer::playerContentBoxRect const): Deleted.
(WebCore::MediaPlayer::playerContentsScale const): Deleted.
(WebCore::MediaPlayer::shouldUsePersistentCache const): Deleted.
(WebCore::MediaPlayer::mediaCacheDirectory const): Deleted.
(WebCore::MediaPlayer::isVideoPlayer const): Deleted.
(WebCore::MediaPlayer::mediaEngineUpdated): Deleted.
(WebCore::MediaPlayer::isLooping const): Deleted.
(WebCore::MediaPlayer::requestInstallMissingPlugins): Deleted.
(WebCore::MediaPlayer::client const): Deleted.

• platform/graphics/MediaPlayerEngineIdentifiers.h: Copied from Source/WebCore/platform/ContentType.h.

(WebCore::MediaPlayerEngineIdentifiers::avFoundationEngineIdentifier):
(WebCore::MediaPlayerEngineIdentifiers::avFoundationMSEEngineIdentifier):
(WebCore::MediaPlayerEngineIdentifiers::avFoundationMediaStreamEngineIdentifier):
(WebCore::MediaPlayerEngineIdentifiers::GStreamerMediaEngineIdentifier):
(WebCore::MediaPlayerEngineIdentifiers::GStreamerMSEMediaEngineIdentifier):
(WebCore::MediaPlayerEngineIdentifiers::holePunchMediaEngineIdentifier):
(WebCore::MediaPlayerEngineIdentifiers::MediaFoundationMediaEngineIdentifier):

• platform/graphics/PlatformTimeRanges.h:

(WebCore::PlatformTimeRanges::PlatformTimeRanges): Deleted.
(WebCore::PlatformTimeRanges::length const): Deleted.
(WebCore::PlatformTimeRanges::Range::Range): Deleted.
(WebCore::PlatformTimeRanges::Range::isPointInRange const): Deleted.
(WebCore::PlatformTimeRanges::Range::isOverlappingRange const): Deleted.
(WebCore::PlatformTimeRanges::Range::isContiguousWithRange const): Deleted.
(WebCore::PlatformTimeRanges::Range::unionWithOverlappingOrContiguousRange const): Deleted.
(WebCore::PlatformTimeRanges::Range::isBeforeRange const): Deleted.

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::registerMediaEngine):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::registerMediaEngine):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::registerMediaEngine):

• platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:

(WebCore::MediaPlayerPrivateHolePunch::registerMediaEngine):

• platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::registerMediaEngine):

• platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::registerMediaEngine):

Source/WebKit:

• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::didReceiveMessage):
(WebKit::GPUConnectionToWebProcess::didReceiveSyncMessage):

• GPUProcess/GPUConnectionToWebProcess.h:
• GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp: Added.

(WebKit::nullLogger):
(WebKit::RemoteMediaPlayerManagerProxy::PlayerProxy::PlayerProxy):
(WebKit::RemoteMediaPlayerManagerProxy::PlayerProxy::~PlayerProxy):
(WebKit::RemoteMediaPlayerManagerProxy::RemoteMediaPlayerManagerProxy):
(WebKit::RemoteMediaPlayerManagerProxy::~RemoteMediaPlayerManagerProxy):
(WebKit::RemoteMediaPlayerManagerProxy::createMediaPlayer):
(WebKit::RemoteMediaPlayerManagerProxy::getSupportedTypes):
(WebKit::RemoteMediaPlayerManagerProxy::supportsType):
(WebKit::RemoteMediaPlayerManagerProxy::originsInMediaCache):
(WebKit::RemoteMediaPlayerManagerProxy::clearMediaCache):
(WebKit::RemoteMediaPlayerManagerProxy::clearMediaCacheForOrigins):
(WebKit::RemoteMediaPlayerManagerProxy::supportsKeySystem):

• GPUProcess/media/RemoteMediaPlayerManagerProxy.h: Added.

(WebKit::RemoteMediaPlayerManagerProxy::webProcessConnection const):
(WebKit::RemoteMediaPlayerManagerProxy::didReceiveMessageFromWebProcess):
(WebKit::RemoteMediaPlayerManagerProxy::didReceiveSyncMessageFromWebProcess):

• GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in: Added.
• Scripts/webkit/messages.py:
• Sources.txt:
• SourcesCocoa.txt:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: Added.

(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
(WebKit::MediaPlayerPrivateRemote::~MediaPlayerPrivateRemote):
(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote::load):
(WebKit::MediaPlayerPrivateRemote::load):
(WebKit::MediaPlayerPrivateRemote::cancelLoad):
(WebKit::MediaPlayerPrivateRemote::prepareToPlay):
(WebKit::MediaPlayerPrivateRemote::platformLayer const):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenLayer):
(WebKit::MediaPlayerPrivateRemote::updateVideoFullscreenInlineImage):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrame):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenGravity):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenMode):
(WebKit::MediaPlayerPrivateRemote::videoFullscreenStandbyChanged):
(WebKit::MediaPlayerPrivateRemote::accessLog const):
(WebKit::MediaPlayerPrivateRemote::errorLog const):
(WebKit::MediaPlayerPrivateRemote::platformErrorCode const):
(WebKit::MediaPlayerPrivateRemote::play):
(WebKit::MediaPlayerPrivateRemote::pause):
(WebKit::MediaPlayerPrivateRemote::setBufferingPolicy):
(WebKit::MediaPlayerPrivateRemote::supportsPictureInPicture const):
(WebKit::MediaPlayerPrivateRemote::supportsFullscreen const):
(WebKit::MediaPlayerPrivateRemote::supportsScanning const):
(WebKit::MediaPlayerPrivateRemote::requiresImmediateCompositing const):
(WebKit::MediaPlayerPrivateRemote::canSaveMediaData const):
(WebKit::MediaPlayerPrivateRemote::naturalSize const):
(WebKit::MediaPlayerPrivateRemote::hasVideo const):
(WebKit::MediaPlayerPrivateRemote::hasAudio const):
(WebKit::MediaPlayerPrivateRemote::setVisible):
(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote::durationMediaTime const):
(WebKit::MediaPlayerPrivateRemote::currentMediaTime const):
(WebKit::MediaPlayerPrivateRemote::getStartDate const):
(WebKit::MediaPlayerPrivateRemote::seek):
(WebKit::MediaPlayerPrivateRemote::seekWithTolerance):
(WebKit::MediaPlayerPrivateRemote::seeking const):
(WebKit::MediaPlayerPrivateRemote::startTime const):
(WebKit::MediaPlayerPrivateRemote::setRateDouble):
(WebKit::MediaPlayerPrivateRemote::rate const):
(WebKit::MediaPlayerPrivateRemote::setPreservesPitch):
(WebKit::MediaPlayerPrivateRemote::paused const):
(WebKit::MediaPlayerPrivateRemote::setVolumeDouble):
(WebKit::MediaPlayerPrivateRemote::setMuted):
(WebKit::MediaPlayerPrivateRemote::hasClosedCaptions const):
(WebKit::MediaPlayerPrivateRemote::setClosedCaptionsVisible):
(WebKit::MediaPlayerPrivateRemote::maxFastForwardRate const):
(WebKit::MediaPlayerPrivateRemote::minFastReverseRate const):
(WebKit::MediaPlayerPrivateRemote::networkState const):
(WebKit::MediaPlayerPrivateRemote::readyState const):
(WebKit::MediaPlayerPrivateRemote::seekable const):
(WebKit::MediaPlayerPrivateRemote::buffered const):
(WebKit::MediaPlayerPrivateRemote::maxMediaTimeSeekable const):
(WebKit::MediaPlayerPrivateRemote::minMediaTimeSeekable const):
(WebKit::MediaPlayerPrivateRemote::seekableTimeRangesLastModifiedTime const):
(WebKit::MediaPlayerPrivateRemote::liveUpdateInterval const):
(WebKit::MediaPlayerPrivateRemote::totalBytes const):
(WebKit::MediaPlayerPrivateRemote::didLoadingProgress const):
(WebKit::MediaPlayerPrivateRemote::setSize):
(WebKit::MediaPlayerPrivateRemote::paint):
(WebKit::MediaPlayerPrivateRemote::paintCurrentFrameInContext):
(WebKit::MediaPlayerPrivateRemote::copyVideoTextureToPlatformTexture):
(WebKit::MediaPlayerPrivateRemote::nativeImageForCurrentTime):
(WebKit::MediaPlayerPrivateRemote::setPreload):
(WebKit::MediaPlayerPrivateRemote::hasAvailableVideoFrame const):
(WebKit::MediaPlayerPrivateRemote::canLoadPoster const):
(WebKit::MediaPlayerPrivateRemote::setPoster):
(WebKit::MediaPlayerPrivateRemote::enterFullscreen):
(WebKit::MediaPlayerPrivateRemote::exitFullscreen):
(WebKit::MediaPlayerPrivateRemote::wirelessPlaybackTargetName const):
(WebKit::MediaPlayerPrivateRemote::wirelessPlaybackTargetType const):
(WebKit::MediaPlayerPrivateRemote::wirelessVideoPlaybackDisabled const):
(WebKit::MediaPlayerPrivateRemote::setWirelessVideoPlaybackDisabled):
(WebKit::MediaPlayerPrivateRemote::canPlayToWirelessPlaybackTarget const):
(WebKit::MediaPlayerPrivateRemote::isCurrentPlaybackTargetWireless const):
(WebKit::MediaPlayerPrivateRemote::setWirelessPlaybackTarget):
(WebKit::MediaPlayerPrivateRemote::setShouldPlayToPlaybackTarget):
(WebKit::MediaPlayerPrivateRemote::canEnterFullscreen const):
(WebKit::MediaPlayerPrivateRemote::supportsAcceleratedRendering const):
(WebKit::MediaPlayerPrivateRemote::acceleratedRenderingStateChanged):
(WebKit::MediaPlayerPrivateRemote::shouldMaintainAspectRatio const):
(WebKit::MediaPlayerPrivateRemote::setShouldMaintainAspectRatio):
(WebKit::MediaPlayerPrivateRemote::hasSingleSecurityOrigin const):
(WebKit::MediaPlayerPrivateRemote::didPassCORSAccessCheck const):
(WebKit::MediaPlayerPrivateRemote::wouldTaintOrigin const):
(WebKit::MediaPlayerPrivateRemote::movieLoadType const):
(WebKit::MediaPlayerPrivateRemote::prepareForRendering):
(WebKit::MediaPlayerPrivateRemote::mediaTimeForTimeValue const):
(WebKit::MediaPlayerPrivateRemote::maximumDurationToCacheMediaTime const):
(WebKit::MediaPlayerPrivateRemote::decodedFrameCount const):
(WebKit::MediaPlayerPrivateRemote::droppedFrameCount const):
(WebKit::MediaPlayerPrivateRemote::audioDecodedByteCount const):
(WebKit::MediaPlayerPrivateRemote::videoDecodedByteCount const):
(WebKit::MediaPlayerPrivateRemote::setPrivateBrowsingMode):
(WebKit::MediaPlayerPrivateRemote::engineDescription const):
(WebKit::MediaPlayerPrivateRemote::audioSourceProvider):
(WebKit::MediaPlayerPrivateRemote::createSession):
(WebKit::MediaPlayerPrivateRemote::setCDMSession):
(WebKit::MediaPlayerPrivateRemote::keyAdded):
(WebKit::MediaPlayerPrivateRemote::cdmInstanceAttached):
(WebKit::MediaPlayerPrivateRemote::cdmInstanceDetached):
(WebKit::MediaPlayerPrivateRemote::attemptToDecryptWithInstance):
(WebKit::MediaPlayerPrivateRemote::waitingForKey const):
(WebKit::MediaPlayerPrivateRemote::requiresTextTrackRepresentation const):
(WebKit::MediaPlayerPrivateRemote::setTextTrackRepresentation):
(WebKit::MediaPlayerPrivateRemote::syncTextTrackBounds):
(WebKit::MediaPlayerPrivateRemote::tracksChanged):
(WebKit::MediaPlayerPrivateRemote::simulateAudioInterruption):
(WebKit::MediaPlayerPrivateRemote::beginSimulatedHDCPError):
(WebKit::MediaPlayerPrivateRemote::endSimulatedHDCPError):
(WebKit::MediaPlayerPrivateRemote::languageOfPrimaryAudioTrack const):
(WebKit::MediaPlayerPrivateRemote::extraMemoryCost const):
(WebKit::MediaPlayerPrivateRemote::fileSize const):
(WebKit::MediaPlayerPrivateRemote::ended const):
(WebKit::MediaPlayerPrivateRemote::videoPlaybackQualityMetrics):
(WebKit::MediaPlayerPrivateRemote::notifyTrackModeChanged):
(WebKit::MediaPlayerPrivateRemote::notifyActiveSourceBuffersChanged):
(WebKit::MediaPlayerPrivateRemote::setShouldDisableSleep):
(WebKit::MediaPlayerPrivateRemote::applicationWillResignActive):
(WebKit::MediaPlayerPrivateRemote::applicationDidBecomeActive):
(WebKit::MediaPlayerPrivateRemote::performTaskAtMediaTime):
(WebKit::MediaPlayerPrivateRemote::shouldIgnoreIntrinsicSize):
(WebKit::MediaPlayerPrivateRemote::logChannel const):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h: Added.
• WebProcess/GPU/media/MediaPlayerPrivateRemoteIdentifier.h: Added.
• WebProcess/GPU/media/RemoteMediaPlayerManager.cpp: Added.

(WebKit::MediaPlayerRemoteFactory::MediaPlayerRemoteFactory):
(WebKit::RemoteMediaPlayerManager::RemoteMediaPlayerManager):
(WebKit::RemoteMediaPlayerManager::~RemoteMediaPlayerManager):
(WebKit::RemoteMediaPlayerManager::supplementName):
(WebKit::RemoteMediaPlayerManager::initialize):
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):
(WebKit::RemoteMediaPlayerManager::getSupportedTypes):
(WebKit::RemoteMediaPlayerManager::supportsTypeAndCodecs):
(WebKit::RemoteMediaPlayerManager::supportsKeySystem):
(WebKit::RemoteMediaPlayerManager::originsInMediaCache):
(WebKit::RemoteMediaPlayerManager::clearMediaCache):
(WebKit::RemoteMediaPlayerManager::clearMediaCacheForOrigins):
(WebKit::RemoteMediaPlayerManager::networkStateChanged):
(WebKit::RemoteMediaPlayerManager::updatePreferences):
(WebKit::RemoteMediaPlayerManager::gpuProcessConnection const):

• WebProcess/GPU/media/RemoteMediaPlayerManager.h: Added.
• WebProcess/GPU/media/RemoteMediaPlayerManager.messages.in: Added.
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

• WebProcess/WebProcess.cpp:

9:37 AM Changeset in webkit [253481] by cathiechen

• 2 edits in trunk/Source/WebCore

Fixed compile error in BaseAudioSharedUnit.h
​https://bugs.webkit.org/show_bug.cgi?id=205205

Need to include some headers and put "#pragma once" in front.

Unreviewed, fixed compile error.

• platform/mediastream/mac/BaseAudioSharedUnit.h:

9:10 AM Changeset in webkit [253480] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/text/simple-line-with-br.html
​https://bugs.webkit.org/show_bug.cgi?id=205207
<rdar://problem/57913504>

Reviewed by Antti Koivisto.

Apply ​https://www.w3.org/TR/css-text-3/#white-space-property's matrix to end-of-the-line whitespace.
(Keep white-space: mormal no-wrap pre-wrap and pre-line content)

• layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::shouldKeepEndOfLineWhitespace):
(WebCore::Layout::LineBreaker::breakingContextForInlineContent):
(WebCore::Layout::LineBreaker::Content::isVisuallyEmptyWhitespaceContentOnly const):
(WebCore::Layout::isTrailingWhitespaceWithPreWrap): Deleted.

• layout/inlineformatting/InlineLineBreaker.h:
• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::InlineItemRun::isTrimmableWhitespace const):

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::placeInlineItem):

9:01 AM Changeset in webkit [253479] by clopez@igalia.com

• 3 edits in trunk/LayoutTests

Fix some errors on the TestExpectations files.

Unreviewed gardening.

• TestExpectations: Add missing expectation.
• platform/gtk/TestExpectations: Remove repeated entries

8:42 AM Changeset in webkit [253478] by Devin Rousso

• 3 edits in trunk/Tools

Prefix CSS selectors with all applicable CSS groupings when generating a ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=205196

Reviewed by Jonathan Bedard.

• Scripts/prepare-ChangeLog:

(get_selector_line_ranges_for_css):

• Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:

8:29 AM Changeset in webkit [253477] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, address flakiness of fast/scrolling/ios/scroll-event-from-scrollTo.html

• fast/scrolling/ios/scroll-event-from-scrollTo.html:

8:24 AM Changeset in webkit [253476] by Chris Dumez

• 3 edits in trunk/LayoutTests

Unreviewed, rebaseline a couple of iOS swiping tests after r253450

• platform/ios/swipe/main-frame-pinning-requirement-expected.txt:
• platform/ios/swipe/pushState-cached-back-swipe-expected.txt:

8:23 AM Changeset in webkit [253475] by commit-queue@webkit.org

• 11 edits in trunk/Source

[GTK] WebKitGTK build hangs on g-ir-scanner
​https://bugs.webkit.org/show_bug.cgi?id=204715

This patch fixes the static initialization order problem
introduced by Bug 204503.

The patch replaces the static data members with statics that
are constructed only upon first access (i.e., the 'construct
on first use' idiom).

Patch by Jim Mason <​jmason@ibinx.com> on 2019-12-13
Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

• inspector/remote/RemoteInspector.h:
• inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::messageHandlers):

• inspector/remote/glib/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::messageHandlers):
(Inspector::RemoteInspectorServer::incomingConnectionCallback):

• inspector/remote/glib/RemoteInspectorServer.h:

Source/WebDriver:

• SessionHost.h:
• glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::messageHandlers):
(WebDriver::SessionHost::connectToBrowser):

Source/WebKit:

• UIProcess/glib/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorClient::messageHandlers):
(WebKit::RemoteInspectorClient::RemoteInspectorClient):

• UIProcess/glib/RemoteInspectorClient.h:

8:22 AM Changeset in webkit [253474] by commit-queue@webkit.org

• 14 edits in trunk

Implement OffscreenCanvas.convertToBlob
​https://bugs.webkit.org/show_bug.cgi?id=202573

Patch by Chris Lord <Chris Lord> on 2019-12-13
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update with fixed worker tests and SecurityError checks. See wpe
issues #20694 and #20698.

• web-platform-tests/offscreen-canvas/convert-to-blob/offscreencanvas.convert.to.blob-expected.txt:
• web-platform-tests/offscreen-canvas/convert-to-blob/offscreencanvas.convert.to.blob.html:
• web-platform-tests/offscreen-canvas/convert-to-blob/offscreencanvas.convert.to.blob.w-expected.txt:
• web-platform-tests/offscreen-canvas/convert-to-blob/offscreencanvas.convert.to.blob.w.html:

Source/WebCore:

Implement OffscreenCanvas.convertToBlob. This also involves making
isSupportedImageMIMETypeForEncoding safe to use off the main thread,
and implementing OffscreenCanvas.securityOrigin.

No new tests, these changes fix existing tests.

• html/OffscreenCanvas.cpp:

(WebCore::toEncodingMimeType):
(WebCore::qualityFromDouble):
(WebCore::OffscreenCanvas::convertToBlob):
(WebCore::OffscreenCanvas::securityOrigin const):

• html/OffscreenCanvas.h:
• html/OffscreenCanvas.idl:
• platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::createMIMETypeRegistryThreadGlobalData):
(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):

• platform/MIMETypeRegistry.h:

(WebCore::MIMETypeRegistryThreadGlobalData::MIMETypeRegistryThreadGlobalData):
(WebCore::MIMETypeRegistryThreadGlobalData::supportedImageMIMETypesForEncoding const):

• platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::mimeTypeRegistryThreadGlobalData):

• platform/ThreadGlobalData.h:
• workers/WorkerGlobalScope.h:

8:19 AM Changeset in webkit [253473] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Make DOMCacheStorage::retrieveCaches take a CompletionHandler
​https://bugs.webkit.org/show_bug.cgi?id=205204

Patch by youenn fablet <​youenn@apple.com> on 2019-12-13
Reviewed by Chris Dumez.

Covered by existing tests.

• Modules/cache/DOMCacheEngine.cpp:

(WebCore::DOMCacheEngine::errorToException):
This will improve logging and will make sure we do not crash in debug in case of stopped error.

• Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::retrieveCaches):
Use of a completion handler to make sure we answer the caller, even with an error case.

• Modules/cache/DOMCacheStorage.h:

8:16 AM Changeset in webkit [253472] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, skip several SharedWorkers tests as we do not support this feature.

• TestExpectations:

8:02 AM Changeset in webkit [253471] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] The AGX compiler service is incorrectly listed as a global name in sandbox
​https://bugs.webkit.org/show_bug.cgi?id=205189

Reviewed by Brent Fulgham.

It should be a XPC service name.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

7:18 AM Changeset in webkit [253470] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[HarfBuzz] WebKitWebProcess crashes when displaying a KaTeX formula
​https://bugs.webkit.org/show_bug.cgi?id=204689

Reviewed by Carlos Alberto Lopez Perez.

We are creating and caching an hb_font_t for the given FontPlatformData's FT_Face, but the face is not
referenced so it is destroyed eventually while the hb_font_t is still alive. We need to keep a reference of the
FT_Face while the hb_font_t is alive.

• platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::createOpenTypeMathHarfBuzzFont const): Create the hb_face_t with
hb_ft_face_create_referenced() instead of hb_ft_face_create_cached().

6:32 AM Changeset in webkit [253469] by ajuma@chromium.org

• 3 edits
  2 adds in trunk

Crash in RenderLayerBacking::updateCompositedBounds from using cleared WeakPtr from m_backingSharingLayers
​https://bugs.webkit.org/show_bug.cgi?id=204648

Reviewed by Simon Fraser.

Source/WebCore:

RenderLayerBacking's clearBackingSharingProviders clears layers'
backingSharingProviders unconditionally, even when a layer's
backingSharingProvider is some other RenderLayerBacking's owning
layer. This leaves the layer in a state where its backingProviderLayer
is null, even though it appears in the other RenderLayerBacking's
m_backingSharingLayers, which leads to a crash if this layer is destroyed
and the other RenderLayerBacking tries to use its pointer to this
layer.

Avoid this inconsistency by making clearBackingSharingProviders check
whether a layer's backingSharingProvider is the current RenderLayerBacking's
owner, before clearing it.

Test: compositing/shared-backing/move-sharing-child.html

• rendering/RenderLayerBacking.cpp:

(WebCore::clearBackingSharingLayerProviders):
(WebCore::RenderLayerBacking::setBackingSharingLayers):
(WebCore::RenderLayerBacking::clearBackingSharingLayers):

LayoutTests:

• compositing/shared-backing/move-sharing-child-expected.txt: Added.
• compositing/shared-backing/move-sharing-child.html: Added.

5:47 AM Changeset in webkit [253468] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/text/simple-line-with-multiple-renderers.html
​https://bugs.webkit.org/show_bug.cgi?id=205193
<rdar://problem/57900709>

Reviewed by Antti Koivisto.

Use LazyLineBreakIterator to find out if 2 (visually)adjacent non-whitespace inline items are
on a soft breaking opportunity.

• layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::endsWithBreakingOpportunity):
(WebCore::Layout::LineBreaker::Content::isAtContentBoundary):

• layout/inlineformatting/InlineTextItem.cpp:

(WebCore::Layout::moveToNextBreakablePosition):

• layout/inlineformatting/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::findNextBreakablePosition):

• layout/inlineformatting/text/TextUtil.h:

2:54 AM Changeset in webkit [253467] by Carlos Garcia Campos

• 6 edits in trunk

[GTK] Several tests crashing after r247898 "Reorganize UIScriptController into platform-specific subclasses"
​https://bugs.webkit.org/show_bug.cgi?id=200534

Reviewed by Alejandro G. Castro.

Tools:

Add implementation of several UIScriptController virtual methods to avoid crashes.

• WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::addToWindow):
(WTR::PlatformWebView::removeFromWindow):

• WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:

(WTR::UIScriptControllerGtk::doAsyncTask):
(WTR::UIScriptControllerGtk::setContinuousSpellCheckingEnabled):
(WTR::UIScriptControllerGtk::copyText):
(WTR::UIScriptControllerGtk::dismissMenu):
(WTR::UIScriptControllerGtk::isShowingMenu const):
(WTR::UIScriptControllerGtk::activateAtPoint):
(WTR::UIScriptControllerGtk::activateDataListSuggestion):
(WTR::UIScriptControllerGtk::simulateAccessibilitySettingsChangeNotification):
(WTR::UIScriptControllerGtk::removeViewFromWindow):
(WTR::UIScriptControllerGtk::addViewToWindow):

• WebKitTestRunner/gtk/UIScriptControllerGtk.h:

LayoutTests:

Update expectations.

• platform/gtk/TestExpectations:

12:40 AM Changeset in webkit [253466] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Uninitialized variables in RenderLayer
​https://bugs.webkit.org/show_bug.cgi?id=205165

Reviewed by Simon Fraser.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer): Initialize m_isNormalFlowOnly and m_isCSSStackingContext.

Dec 12, 2019:

10:06 PM Changeset in webkit [253465] by Simon Fraser

• 51 edits
  1 copy
  6 adds in trunk

Move WKWebView code related to testing to new files, with new private "for testing" headers.
​https://bugs.webkit.org/show_bug.cgi?id=205021

Reviewed by Tim Horton.
Source/WebKit:

Move testing-only SPI to new private headers to discourage first parties from using
them by mistake. Move test-only code to new files to reduce the size of WKWebView.mm.

• SourcesCocoa.txt:
• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _internalDoAfterNextPresentationUpdate:withoutWaitingForPainting:withoutWaitingForAnimatedResize:]):
(-[WKWebView _prepareForImmediateActionAnimation]):
(-[WKWebView _cancelImmediateActionAnimation]):
(-[WKWebView _completeImmediateActionAnimation]):
(-[WKWebView _useSystemAppearance]):
(-[WKWebView _setUseSystemAppearance:]):
(-[WKWebView _pageRefForTransitionToWKWebView]):
(-[WKWebView _canChangeFrameLayout:]):
(-[WKWebView _tryToSwipeWithEvent:ignoringPinnedState:]):
(-[WKWebView _ignoresNonWheelEvents]):
(-[WKWebView _setIgnoresNonWheelEvents:]):
(-[WKWebView _hasActiveVideoForControlsManager]):
(-[WKWebView _dismissContentRelativeChildWindows]):
(-[WKWebView _gestureEventWasNotHandledByWebCore:]):
(-[WKWebView _disableFrameSizeUpdates]):
(-[WKWebView _enableFrameSizeUpdates]):
(-[WKWebView _beginDeferringViewInWindowChanges]):
(-[WKWebView _endDeferringViewInWindowChanges]):
(-[WKWebView _endDeferringViewInWindowChangesSync]):
(-[WKWebView _fullScreenPlaceholderView]):
(-[WKWebView _fullScreenWindow]):
(-[WKWebView _underlayColor]):
(-[WKWebView _setUnderlayColor:]):
(-[WKWebView _setCustomSwipeViews:]):
(-[WKWebView _setCustomSwipeViewsTopContentInset:]):
(-[WKWebView _setDidMoveSwipeSnapshotCallback:]):
(-[WKWebView _setFrame:andScrollBy:]):
(-[WKWebView _setTotalHeightOfBanners:]):
(-[WKWebView _totalHeightOfBanners]):
(-[WKWebView _setFont:sender:]):
(-[WKWebView _setFontSize:sender:]):
(-[WKWebView _setTextColor:sender:]):
(-[WKWebView inputAccessoryView]):
(-[WKWebView inputView]):
(-[WKWebView _requestActivatedElementAtPosition:completionBlock:]):
(-[WKWebView _contentVisibleRect]):
(-[WKWebView _convertPointFromContentsToView:]):
(-[WKWebView _convertPointFromViewToContents:]):
(-[WKWebView didStartFormControlInteraction]):
(-[WKWebView didEndFormControlInteraction]):
(-[WKWebView _uiTextCaretRect]):
(-[WKWebView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):
(-[WKWebView _accessibilityStoreSelection]):
(-[WKWebView _accessibilityClearSelection]):
(-[WKWebView _contentViewIsFirstResponder]):
(-[WKWebView _inspector]):
(-[WKWebView _mainFrame]):
(-[WKWebView _isEditable]):
(-[WKWebView _setEditable:]):
(-[WKWebView _executeEditCommand:argument:completion:]):
(-[WKWebView _textManipulationDelegate]):
(-[WKWebView _setTextManipulationDelegate:]):
(-[WKWebView _startTextManipulationsWithConfiguration:completion:]):
(-[WKWebView _completeTextManipulation:completion:]):
(-[WKWebView _takeFindStringFromSelection:]):
(+[WKWebView _stringForFind]):
(+[WKWebView _setStringForFind:]):
(-[WKWebView _remoteObjectRegistry]):
(-[WKWebView _handle]):
(-[WKWebView _observedRenderingProgressEvents]):
(-[WKWebView _historyDelegate]):
(-[WKWebView _setHistoryDelegate:]):
(-[WKWebView _updateMediaPlaybackControlsManager]):
(-[WKWebView _canTogglePictureInPicture]):
(-[WKWebView _isPictureInPictureActive]):
(-[WKWebView _togglePictureInPicture]):
(-[WKWebView _closeAllMediaPresentations]):
(-[WKWebView _stopMediaCapture]):
(-[WKWebView _stopAllMediaPlayback]):
(-[WKWebView _suspendAllMediaPlayback]):
(-[WKWebView _resumeAllMediaPlayback]):
(-[WKWebView _unreachableURL]):
(-[WKWebView _mainFrameURL]):
(-[WKWebView _loadAlternateHTMLString:baseURL:forUnreachableURL:]):
(-[WKWebView _loadData:MIMEType:characterEncodingName:baseURL:userData:]):
(-[WKWebView _loadRequest:shouldOpenExternalURLs:]):
(-[WKWebView _certificateChain]):
(-[WKWebView _committedURL]):
(-[WKWebView _MIMEType]):
(-[WKWebView _userAgent]):
(-[WKWebView _applicationNameForUserAgent]):
(-[WKWebView _setApplicationNameForUserAgent:]):
(-[WKWebView _customUserAgent]):
(-[WKWebView _setCustomUserAgent:]):
(-[WKWebView _setUserContentExtensionsEnabled:]):
(-[WKWebView _userContentExtensionsEnabled]):
(-[WKWebView _webProcessIdentifier]):
(-[WKWebView _provisionalWebProcessIdentifier]):
(-[WKWebView _killWebContentProcess]):
(-[WKWebView _safeBrowsingWarning]):
(-[WKWebView _reloadWithoutContentBlockers]):
(-[WKWebView _reloadExpiredOnly]):
(-[WKWebView _killWebContentProcessAndResetState]):
(-[WKWebView _convertRectFromRootViewCoordinates:]):
(-[WKWebView _convertRectToRootViewCoordinates:]):
(-[WKWebView _requestTextInputContextsInRect:completionHandler:]):
(-[WKWebView _focusTextInputContext:completionHandler:]):
(-[WKWebView _takePDFSnapshotWithConfiguration:completionHandler:]):
(-[WKWebView _setShouldSuppressFirstResponderChanges:]):
(-[WKWebView _retainActiveFocusedState]):
(-[WKWebView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
(-[WKWebView _snapshotLayerContentsForBackForwardListItem:]):
(-[WKWebView _dataDetectionResults]):
(-[WKWebView _accessibilityRetrieveSpeakSelectionContent]):
(-[WKWebView _accessibilityDidGetSpeakSelectionContent:]):
(-[WKWebView inputAssistantItem]):
(-[WKWebView _sessionStateData]):
(-[WKWebView _sessionState]):
(-[WKWebView _sessionStateWithFilter:]):
(-[WKWebView _restoreFromSessionStateData:]):
(-[WKWebView _restoreSessionState:andNavigate:]):
(-[WKWebView _close]):
(-[WKWebView _insertAttachmentWithFilename:contentType:data:options:completion:]):
(-[WKWebView _insertAttachmentWithFileWrapper:contentType:options:completion:]):
(-[WKWebView _insertAttachmentWithFileWrapper:contentType:completion:]):
(-[WKWebView _attachmentForIdentifier:]):
(-[WKWebView _simulateDeviceOrientationChangeWithAlpha:beta:gamma:]):
(+[WKWebView _handlesSafeBrowsing]):
(-[WKWebView _showSafeBrowsingWarningWithTitle:warning:details:completionHandler:]):
(-[WKWebView _showSafeBrowsingWarningWithURL:title:warning:details:completionHandler:]):
(+[WKWebView _confirmMalwareSentinel]):
(+[WKWebView _visitUnsafeWebsiteSentinel]):
(-[WKWebView _isJITEnabled:]):
(-[WKWebView _evaluateJavaScriptWithoutUserGesture:completionHandler:]):
(-[WKWebView _updateWebsitePolicies:]):
(-[WKWebView _allowsRemoteInspection]):
(-[WKWebView _setAllowsRemoteInspection:]):
(-[WKWebView _remoteInspectionNameOverride]):
(-[WKWebView _setRemoteInspectionNameOverride:]):
(-[WKWebView _addsVisitedLinks]):
(-[WKWebView _setAddsVisitedLinks:]):
(-[WKWebView _networkRequestsInProgress]):
(layoutMilestones):
(-[WKWebView _setObservedRenderingProgressEvents:]):
(-[WKWebView _getMainResourceDataWithCompletionHandler:]):
(-[WKWebView _getWebArchiveDataWithCompletionHandler:]):
(-[WKWebView _getContentsAsStringWithCompletionHandler:]):
(-[WKWebView _getContentsAsAttributedStringWithCompletionHandler:]):
(-[WKWebView _getApplicationManifestWithCompletionHandler:]):
(-[WKWebView _paginationMode]):
(-[WKWebView _setPaginationMode:]):
(-[WKWebView _paginationBehavesLikeColumns]):
(-[WKWebView _setPaginationBehavesLikeColumns:]):
(-[WKWebView _pageLength]):
(-[WKWebView _setPageLength:]):
(-[WKWebView _gapBetweenPages]):
(-[WKWebView _setGapBetweenPages:]):
(-[WKWebView _paginationLineGridEnabled]):
(-[WKWebView _setPaginationLineGridEnabled:]):
(-[WKWebView _pageCount]):
(-[WKWebView _supportsTextZoom]):
(-[WKWebView _textZoomFactor]):
(-[WKWebView _setTextZoomFactor:]):
(-[WKWebView setPageZoom:]):
(-[WKWebView pageZoom]):
(-[WKWebView _pageZoomFactor]):
(-[WKWebView _setPageZoomFactor:]):
(-[WKWebView _diagnosticLoggingDelegate]):
(-[WKWebView _setDiagnosticLoggingDelegate:]):
(-[WKWebView _findDelegate]):
(-[WKWebView _setFindDelegate:]):
(toFindOptions):
(-[WKWebView _countStringMatches:options:maxCount:]):
(-[WKWebView _findString:options:maxCount:]):
(-[WKWebView _hideFindUI]):
(-[WKWebView _saveBackForwardSnapshotForItem:]):
(-[WKWebView _inputDelegate]):
(-[WKWebView _setInputDelegate:]):
(-[WKWebView _isDisplayingStandaloneImageDocument]):
(-[WKWebView _isDisplayingStandaloneMediaDocument]):
(-[WKWebView _isPlayingAudio]):
(-[WKWebView _isShowingNavigationGestureSnapshot]):
(-[WKWebView _layoutMode]):
(-[WKWebView _setLayoutMode:]):
(-[WKWebView _fixedLayoutSize]):
(-[WKWebView _setFixedLayoutSize:]):
(-[WKWebView _setBackgroundExtendsBeyondPage:]):
(-[WKWebView _backgroundExtendsBeyondPage]):
(-[WKWebView _viewScale]):
(-[WKWebView _setViewScale:]):
(-[WKWebView _setMinimumEffectiveDeviceWidth:]):
(-[WKWebView _minimumEffectiveDeviceWidth]):
(-[WKWebView _setScrollPerformanceDataCollectionEnabled:]):
(-[WKWebView _scrollPerformanceDataCollectionEnabled]):
(-[WKWebView _scrollPerformanceData]):
(-[WKWebView _allowsMediaDocumentInlinePlayback]):
(-[WKWebView _setAllowsMediaDocumentInlinePlayback:]):
(-[WKWebView _webProcessIsResponsive]):
(-[WKWebView _setFullscreenDelegate:]):
(-[WKWebView _fullscreenDelegate]):
(-[WKWebView _isInFullscreen]):
(-[WKWebView _mediaCaptureState]):
(-[WKWebView _setMediaCaptureEnabled:]):
(-[WKWebView _mediaCaptureEnabled]):
(-[WKWebView _setPageMuted:]):
(-[WKWebView _removeDataDetectedLinks:]):
(-[WKWebView _doAfterNextPresentationUpdate:]):
(-[WKWebView _doAfterNextPresentationUpdateWithoutWaitingForPainting:]):
(-[WKWebView _doAfterNextStablePresentationUpdate:]):
(-[WKWebView _detectDataWithTypes:completionHandler:]):
(-[WKWebView removeFromSuperview]):
(-[WKWebView _minimumLayoutSizeOverride]):
(-[WKWebView _setViewLayoutSizeOverride:]):
(-[WKWebView _obscuredInsets]):
(-[WKWebView _setObscuredInsets:]):
(-[WKWebView _obscuredInsetEdgesAffectedBySafeArea]):
(-[WKWebView _setObscuredInsetEdgesAffectedBySafeArea:]):
(-[WKWebView _unobscuredSafeAreaInsets]):
(-[WKWebView _setUnobscuredSafeAreaInsets:]):
(-[WKWebView _safeAreaShouldAffectObscuredInsets]):
(-[WKWebView _setInterfaceOrientationOverride:]):
(-[WKWebView _interfaceOrientationOverride]):
(-[WKWebView _clearInterfaceOrientationOverride]):
(-[WKWebView _maximumUnobscuredSizeOverride]):
(-[WKWebView _setMaximumUnobscuredSizeOverride:]):
(-[WKWebView _setAllowsViewportShrinkToFit:]):
(-[WKWebView _allowsViewportShrinkToFit]):
(-[WKWebView _beginInteractiveObscuredInsetsChange]):
(-[WKWebView _endInteractiveObscuredInsetsChange]):
(-[WKWebView _hideContentUntilNextUpdate]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):
(-[WKWebView _resizeWhileHidingContentWithUpdates:]):
(-[WKWebView _setOverlaidAccessoryViewsInset:]):
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:maximumUnobscuredSizeOverride:]):
(-[WKWebView _clearOverrideLayoutParameters]):
(viewportArgumentsFromDictionary):
(-[WKWebView _overrideViewportWithArguments:]):
(-[WKWebView _viewForFindUI]):
(-[WKWebView _isDisplayingPDF]):
(-[WKWebView _dataForDisplayedPDF]):
(-[WKWebView _suggestedFilenameForDisplayedPDF]):
(-[WKWebView _webViewPrintFormatter]):
(toUserInterfaceLayoutDirection):
(-[WKWebView setSemanticContentAttribute:]):
(-[WKWebView _drawsBackground]):
(-[WKWebView _setDrawsBackground:]):
(-[WKWebView _backgroundColor]):
(-[WKWebView _setBackgroundColor:]):
(-[WKWebView _setDrawsTransparentBackground:]):
(-[WKWebView _inspectorAttachmentView]):
(-[WKWebView _setInspectorAttachmentView:]):
(-[WKWebView _setOverlayScrollbarStyle:]):
(-[WKWebView _overlayScrollbarStyle]):
(-[WKWebView _windowOcclusionDetectionEnabled]):
(-[WKWebView _setWindowOcclusionDetectionEnabled:]):
(-[WKWebView shareSheetDidDismiss:]):
(-[WKWebView _setOverrideDeviceScaleFactor:]):
(-[WKWebView _overrideDeviceScaleFactor]):
(-[WKWebView _setTopContentInset:]):
(-[WKWebView _topContentInset]):
(-[WKWebView _pageExtendedBackgroundColor]):
(-[WKWebView _pinnedState]):
(-[WKWebView _rubberBandingEnabled]):
(-[WKWebView _setRubberBandingEnabled:]):
(-[WKWebView _immediateActionAnimationControllerForHitTestResult:withType:userData:]):
(-[WKWebView _setAutomaticallyAdjustsContentInsets:]):
(-[WKWebView _automaticallyAdjustsContentInsets]):
(-[WKWebView _minimumLayoutWidth]):
(-[WKWebView _setMinimumLayoutWidth:]):
(-[WKWebView _shouldExpandContentToViewHeightForAutoLayout]):
(-[WKWebView _setShouldExpandContentToViewHeightForAutoLayout:]):
(-[WKWebView _alwaysShowsHorizontalScroller]):
(-[WKWebView _setAlwaysShowsHorizontalScroller:]):
(-[WKWebView _alwaysShowsVerticalScroller]):
(-[WKWebView _setAlwaysShowsVerticalScroller:]):
(-[WKWebView _printOperationWithPrintInfo:]):
(-[WKWebView _printOperationWithPrintInfo:forFrame:]):
(-[WKWebView setUserInterfaceLayoutDirection:]):
(-[WKWebView _wantsMediaPlaybackControlsView]):
(-[WKWebView _setWantsMediaPlaybackControlsView:]):
(-[WKWebView _mediaPlaybackControlsView]):
(-[WKWebView _addMediaPlaybackControlsView:]):
(-[WKWebView _removeMediaPlaybackControlsView]):
(-[WKWebView _prepareForMoveToWindow:completionHandler:]):
(-[WKWebView _setThumbnailView:]):
(-[WKWebView _thumbnailView]):
(-[WKWebView _setIgnoresAllEvents:]):
(-[WKWebView _ignoresAllEvents]):
(-[WKWebView _spellCheckerDocumentTag]):
(-[WKWebView _setContinuousSpellCheckingEnabledForTesting:]): Deleted.
(-[WKWebView _contentsOfUserInterfaceItem:]): Deleted.
(-[WKWebView _setDeviceOrientationUserPermissionHandlerForTesting:]): Deleted.
(-[WKWebView keyboardAccessoryBarNext]): Deleted.
(-[WKWebView keyboardAccessoryBarPrevious]): Deleted.
(-[WKWebView applyAutocorrection:toString:withCompletionHandler:]): Deleted.
(-[WKWebView dismissFormAccessoryView]): Deleted.
(-[WKWebView _dismissFilePicker]): Deleted.
(-[WKWebView setTimePickerValueToHour:minute:]): Deleted.
(-[WKWebView selectFormAccessoryPickerRow:]): Deleted.
(-[WKWebView selectFormPopoverTitle]): Deleted.
(-[WKWebView textContentTypeForTesting]): Deleted.
(-[WKWebView formInputLabel]): Deleted.
(-[WKWebView _didShowContextMenu]): Deleted.
(-[WKWebView _didDismissContextMenu]): Deleted.
(-[WKWebView _inputViewBounds]): Deleted.
(-[WKWebView _uiTextSelectionRects]): Deleted.
(-[WKWebView _scrollingTreeAsText]): Deleted.
(-[WKWebView _stableStateOverride]): Deleted.
(-[WKWebView _propertiesOfLayerWithID:]): Deleted.
(-[WKWebView _doAfterResettingSingleTapGesture:]): Deleted.
(-[WKWebView _doAfterReceivingEditDragSnapshotForTesting:]): Deleted.
(-[WKWebView _requestControlledElementID]): Deleted.
(-[WKWebView _handleControlledElementIDResponse:]): Deleted.
(-[WKWebView _handleAcceptedCandidate:]): Deleted.
(-[WKWebView _didHandleAcceptedCandidate]): Deleted.
(-[WKWebView _didUpdateCandidateListVisibility:]): Deleted.
(-[WKWebView _forceRequestCandidates]): Deleted.
(-[WKWebView _shouldRequestCandidates]): Deleted.
(-[WKWebView _insertText:replacementRange:]): Deleted.
(-[WKWebView _candidateRect]): Deleted.
(-[WKWebView viewDidChangeEffectiveAppearance]): Deleted.
(-[WKWebView _setHeaderBannerHeight:]): Deleted.
(-[WKWebView _setFooterBannerHeight:]): Deleted.
(-[WKWebView _doAfterProcessingAllPendingMouseEvents:]): Deleted.
(-[WKWebView _activeMenu]): Deleted.
(-[WKWebView _requestActiveNowPlayingSessionInfo:]): Deleted.
(-[WKWebView _setPageScale:withOrigin:]): Deleted.
(-[WKWebView _pageScale]): Deleted.
(-[WKWebView _scrollingUpdatesDisabledForTesting]): Deleted.
(-[WKWebView _setScrollingUpdatesDisabledForTesting:]): Deleted.
(-[WKWebView _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeForTesting:]): Deleted.
(-[WKWebView _doAfterNextVisibleContentRectUpdate:]): Deleted.
(-[WKWebView _disableBackForwardSnapshotVolatilityForTesting]): Deleted.
(-[WKWebView _dragCaretRect]): Deleted.
(-[WKWebView _simulateLongPressActionAtLocation:]): Deleted.
(-[WKWebView _simulateTextEntered:]): Deleted.
(-[WKWebView _dynamicUserInterfaceTraitDidChange]): Deleted.
(-[WKWebView _beginBackSwipeForTesting]): Deleted.
(-[WKWebView _completeBackSwipeForTesting]): Deleted.
(-[WKWebView _setDefersLoadingForTesting:]): Deleted.
(-[WKWebView _setShareSheetCompletesImmediatelyWithResolutionForTesting:]): Deleted.
(-[WKWebView _hasInspectorFrontend]): Deleted.
(-[WKWebView _processWillSuspendImminentlyForTesting]): Deleted.
(-[WKWebView _processDidResumeForTesting]): Deleted.
(-[WKWebView _setAssertionStateForTesting:]): Deleted.
(-[WKWebView _hasServiceWorkerBackgroundActivityForTesting]): Deleted.
(-[WKWebView _hasServiceWorkerForegroundActivityForTesting]): Deleted.
(-[WKWebView _denyNextUserMediaRequest]): Deleted.
(-[WKWebView _triggerSystemPreviewActionOnElement:document:page:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h: Added.
• UIProcess/API/Cocoa/WKWebViewTesting.mm: Added.

(-[WKWebView _setPageScale:withOrigin:]):
(-[WKWebView _pageScale]):
(-[WKWebView _setContinuousSpellCheckingEnabledForTesting:]):
(-[WKWebView _contentsOfUserInterfaceItem:]):
(-[WKWebView _requestActiveNowPlayingSessionInfo:]):
(-[WKWebView _scrollingUpdatesDisabledForTesting]):
(-[WKWebView _setScrollingUpdatesDisabledForTesting:]):
(-[WKWebView _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeForTesting:]):
(-[WKWebView _doAfterNextVisibleContentRectUpdate:]):
(-[WKWebView _disableBackForwardSnapshotVolatilityForTesting]):
(-[WKWebView _beginBackSwipeForTesting]):
(-[WKWebView _completeBackSwipeForTesting]):
(-[WKWebView _setDefersLoadingForTesting:]):
(-[WKWebView _setShareSheetCompletesImmediatelyWithResolutionForTesting:]):
(-[WKWebView _hasInspectorFrontend]):
(-[WKWebView _processWillSuspendImminentlyForTesting]):
(-[WKWebView _processDidResumeForTesting]):
(-[WKWebView _setAssertionStateForTesting:]):
(-[WKWebView _hasServiceWorkerBackgroundActivityForTesting]):
(-[WKWebView _hasServiceWorkerForegroundActivityForTesting]):
(-[WKWebView _denyNextUserMediaRequest]):

• UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h: Added.
• UIProcess/API/ios/WKWebViewTestingIOS.mm: Added.

(-[WKWebView keyboardAccessoryBarNext]):
(-[WKWebView keyboardAccessoryBarPrevious]):
(-[WKWebView applyAutocorrection:toString:withCompletionHandler:]):
(-[WKWebView dismissFormAccessoryView]):
(-[WKWebView _dismissFilePicker]):
(-[WKWebView setTimePickerValueToHour:minute:]):
(-[WKWebView selectFormAccessoryPickerRow:]):
(-[WKWebView selectFormPopoverTitle]):
(-[WKWebView textContentTypeForTesting]):
(-[WKWebView formInputLabel]):
(-[WKWebView _didShowContextMenu]):
(-[WKWebView _didDismissContextMenu]):
(-[WKWebView _inputViewBounds]):
(-[WKWebView _uiTextSelectionRects]):
(-[WKWebView _scrollingTreeAsText]):
(-[WKWebView _stableStateOverride]):
(-[WKWebView _propertiesOfLayerWithID:]):
(-[WKWebView _doAfterResettingSingleTapGesture:]):
(-[WKWebView _doAfterReceivingEditDragSnapshotForTesting:]):
(-[WKWebView _dragCaretRect]):
(-[WKWebView _simulateLongPressActionAtLocation:]):
(-[WKWebView _simulateTextEntered:]):
(-[WKWebView _dynamicUserInterfaceTraitDidChange]):
(-[WKWebView _triggerSystemPreviewActionOnElement:document:page:]):
(-[WKWebView _setDeviceOrientationUserPermissionHandlerForTesting:]):

• UIProcess/API/mac/WKWebViewPrivateForTestingMac.h: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm.
• UIProcess/API/mac/WKWebViewTestingMac.mm: Added.

(-[WKWebView _requestControlledElementID]):
(-[WKWebView _handleControlledElementIDResponse:]):
(-[WKWebView _handleAcceptedCandidate:]):
(-[WKWebView _didHandleAcceptedCandidate]):
(-[WKWebView _didUpdateCandidateListVisibility:]):
(-[WKWebView _forceRequestCandidates]):
(-[WKWebView _shouldRequestCandidates]):
(-[WKWebView _insertText:replacementRange:]):
(-[WKWebView _candidateRect]):
(-[WKWebView viewDidChangeEffectiveAppearance]):
(-[WKWebView _setHeaderBannerHeight:]):
(-[WKWebView _setFooterBannerHeight:]):
(-[WKWebView _doAfterProcessingAllPendingMouseEvents:]):
(-[WKWebView _activeMenu]):

• UIProcess/Cocoa/PageClientImplCocoa.mm:
• UIProcess/ios/PageClientImplIOS.mm:
• UIProcess/ios/WKContentViewInteraction.mm:
• UIProcess/ios/WKMouseGestureRecognizer.h:
• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
• UIProcess/mac/PageClientImplMac.mm:
• UIProcess/mac/WKFullScreenWindowController.h:
• WebKit.xcodeproj/project.pbxproj:

Tools:

Move testing-only SPI to new private headers to discourage first parties from using
them by mistake. Move test-only code to new files to reduce the size of WKWebView.mm.

• MiniBrowser/mac/WK2BrowserWindowController.m:
• TestWebKitAPI/EditingTestHarness.mm:
• TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
• TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
• TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm:
• TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
• TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
• TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
• TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
• TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
• TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCandidateTests.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFirstResponderTests.mm:
• TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
• TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
• TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
• TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
• TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
• TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
• TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
• WebKitTestRunner/cocoa/TestControllerCocoa.mm:
• WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
• WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
• WebKitTestRunner/ios/TestControllerIOS.mm:
• WebKitTestRunner/ios/UIScriptControllerIOS.mm:
• WebKitTestRunner/mac/UIScriptControllerMac.mm:

9:46 PM Changeset in webkit [253464] by jh718.park@samsung.com

• 3 edits in trunk/Source/WebCore

Unreviewed. Fix the build warnings below since r253353.
warning: unused parameter 'foo' [-Wunused-parameter]

Also, remove unnecessary tab spaces from Internals.h.

No new tests, no new behavioral changes.

Patch by Joonghun Park <​jh718.park@samsung.com> on 2019-12-12

• testing/Internals.cpp:

(WebCore::Internals::hasSandboxMachLookupAccessToGlobalName):

• testing/Internals.h:

8:01 PM Changeset in webkit [253463] by rniwa@webkit.org

• 4 edits in trunk/Source/WebCore

Protect lifetime of frame and frameView objects
​https://bugs.webkit.org/show_bug.cgi?id=205128

Patch by Jack Lee <Jack Lee> on 2019-12-12
Reviewed by Ryosuke Niwa.

Could not write a reproducible test case for this.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::focus):

• page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::focusDocumentView):

• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::focusDocumentView):

6:13 PM Changeset in webkit [253462] by Jonathan Bedard

• 3 edits in trunk/Tools

Python 3: Support serial webkitpy.common tests
​https://bugs.webkit.org/show_bug.cgi?id=205162

Reviewed by Stephanie Lewis.

• Scripts/webkitpy/common/system/executive.py:

(Executive.running_pids): Processess are encoded as bytes.

• Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.serial_test_run_in_parallel): Use Python 3 compatible print statements.

5:57 PM Changeset in webkit [253461] by ysuzuki@apple.com

• 15 edits in trunk/Source/JavaScriptCore

[JSC] Puts fixed-sized cells into IsoSubspace more
​https://bugs.webkit.org/show_bug.cgi?id=205183

Reviewed by Saam Barati.

This patch puts many of fixed-sized cells into IsoSubspace.

• Exception
• JSPropertyNameEnumerator
• RegExp
• StructureChain
• MapBucket
• JSMapIterator
• ScopedArgumentsTable
• SetBucket
• JSSetIterator
• JSScriptFetchParameters
• JSScriptFetcher
• JSSourceCode
• JSTemplateObjectDescriptor

• runtime/Exception.h:
• runtime/HashMapImpl.h:

(JSC::HashMapBucket::selectStructure): Deleted.
(JSC::HashMapBucket::info): Deleted.
(JSC::HashMapBucket::createStructure): Deleted.
(JSC::HashMapBucket::create): Deleted.
(JSC::HashMapBucket::createSentinel): Deleted.
(JSC::HashMapBucket::HashMapBucket): Deleted.
(JSC::HashMapBucket::setNext): Deleted.
(JSC::HashMapBucket::setPrev): Deleted.
(JSC::HashMapBucket::setKey): Deleted.
(JSC::HashMapBucket::setValue): Deleted.
(JSC::HashMapBucket::key const): Deleted.
(JSC::HashMapBucket::value const): Deleted.
(JSC::HashMapBucket::next const): Deleted.
(JSC::HashMapBucket::prev const): Deleted.
(JSC::HashMapBucket::deleted const): Deleted.
(JSC::HashMapBucket::makeDeleted): Deleted.
(JSC::HashMapBucket::offsetOfKey): Deleted.
(JSC::HashMapBucket::offsetOfValue): Deleted.
(JSC::HashMapBucket::offsetOfNext): Deleted.
(JSC::HashMapBucket::extractValue): Deleted.

• runtime/JSMapIterator.h:
• runtime/JSPropertyNameEnumerator.h:
• runtime/JSScriptFetchParameters.h:
• runtime/JSScriptFetcher.h:
• runtime/JSSetIterator.h:
• runtime/JSSourceCode.h:
• runtime/JSTemplateObjectDescriptor.h:
• runtime/RegExp.h:
• runtime/ScopedArgumentsTable.h:
• runtime/StructureChain.h:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

5:53 PM Changeset in webkit [253460] by ysuzuki@apple.com

• 4 edits in trunk

[JSC] Wasm init-expr should reject mutable globals
​https://bugs.webkit.org/show_bug.cgi?id=205191

Reviewed by Mark Lam.

JSTests:

• wasm/js-api/global-error.js:

(assert.throws.new.WebAssembly.Module.bin):
(new.WebAssembly.Module): Deleted.
(assert.throws): Deleted.
(new.Number): Deleted.

Source/JavaScriptCore:

For init-expr, expr must be a constant[1]. Constant expr, which is defined in Wasm spec, requires that, if the expr is GetGlobal,
global's mutability is immutable. Previously our imported globals are always immutable, so we are using ASSERT instead of checking
mutability in WasmSectionParser. But now, we have ability to import mutable globals. We should check mutability when parsing init-expr.
We do not have this check previously, which leads to spec-correctness issue that we can initialize globals/elements/data-segments
with snapshot values of mutable globals (this is safe, but this is not spec-compliant, and it is not reasonable semantics), while
such an attempt should be rejected when compiling Wasm modules.

This patch adds necessary checks.

[1]: ​https://webassembly.github.io/spec/core/valid/instructions.html#valid-constant

• wasm/WasmSectionParser.cpp:

(JSC::Wasm::SectionParser::parseInitExpr):

5:49 PM Changeset in webkit [253459] by Fujii Hironori

• 3 edits in trunk/Tools

webkit-patch print-expectations fails to format TestExpectationLine with DumpJSConsoleLogInStdErr
​https://bugs.webkit.org/show_bug.cgi?id=194283

Reviewed by Youenn Fablet.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser): Add DumpJSConsoleLogInStdErr to TestExpectationParser._expectation_tokens.

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

Added a tokenize test and round tip test for DumpJSConsoleLogInStdErr.

5:11 PM Changeset in webkit [253458] by mark.lam@apple.com

• 7 edits
  1 add in trunk

Fix missing exception in JSValue::toWTFStringSlowCase().
​https://bugs.webkit.org/show_bug.cgi?id=205176
<rdar://problem/57871899>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/missing-exception-check-in-JSValue-toWTFStringSlowCase.js: Added.

Source/JavaScriptCore:

Also fix all the new exception check failures that fall out of change.
Also replaced some ASSERTs with EXCEPTION_ASSERT so that we can run the exception
check validation on a release build.

• dfg/DFGOperations.cpp:
• jsc.cpp:

(dumpException):

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPush):

• runtime/ExceptionHelpers.cpp:

(JSC::createError):

• runtime/JSCJSValue.cpp:

(JSC::JSValue::toWTFStringSlowCase const):

5:09 PM Changeset in webkit [253457] by Chris Dumez

• 25 edits
  15 adds
  101 deletes in trunk/LayoutTests

Re-sync service-workers web-platform-tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=205181

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Resync service-workers web-platform-tests from upstream 178762b6fce688979.

• web-platform-tests/service-workers/*: Updated

LayoutTests:

• tests-options.json:

4:53 PM Changeset in webkit [253456] by Chris Dumez

• 1 edit
  10 adds in trunk/LayoutTests/imported/w3c

Unreviewed, land missing baselines from r253453.

• web-platform-tests/workers/SharedWorker-MessageEvent-source.any-expected.txt: Added.
• web-platform-tests/workers/SharedWorker-MessageEvent-source.any.worker-expected.txt: Added.
• web-platform-tests/workers/SharedWorker-replace-EventHandler.any-expected.txt: Added.
• web-platform-tests/workers/SharedWorker-replace-EventHandler.any.worker-expected.txt: Added.
• web-platform-tests/workers/examples/onconnect.any-expected.txt: Added.
• web-platform-tests/workers/examples/onconnect.any.worker-expected.txt: Added.
• web-platform-tests/workers/semantics/interface-objects/003.any-expected.txt: Added.
• web-platform-tests/workers/semantics/interface-objects/003.any.worker-expected.txt: Added.
• web-platform-tests/workers/semantics/interface-objects/004.any-expected.txt: Added.
• web-platform-tests/workers/semantics/interface-objects/004.any.worker-expected.txt: Added.

4:48 PM Changeset in webkit [253455] by jer.noble@apple.com

• 4 edits
  2 adds in trunk/Source/WebCore

Add logging for MediaCapabilities.decodeInfo()
​https://bugs.webkit.org/show_bug.cgi?id=205172

Reviewed by Eric Carlson.

Add logging for decodingInfo() that can emit string versions of both the input
MediaConfiguration and the output MediaCapabilitiesInfo objects.

• Modules/mediacapabilities/MediaCapabilities.cpp:

(WebCore::MediaCapabilities::decodingInfo):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/mediacapabilities/MediaCapabilitiesLogging.cpp: Added.

(WebCore::toJSONObject):
(WebCore::toJSONString):
(WTF::LogArgument<WebCore::VideoConfiguration>::toString):
(WTF::LogArgument<WebCore::AudioConfiguration>::toString):
(WTF::LogArgument<WebCore::MediaConfiguration>::toString):
(WTF::LogArgument<WebCore::MediaDecodingConfiguration>::toString):
(WTF::LogArgument<WebCore::MediaEncodingConfiguration>::toString):
(WTF::LogArgument<WebCore::MediaCapabilitiesInfo>::toString):
(WTF::LogArgument<WebCore::MediaCapabilitiesDecodingInfo>::toString):
(WTF::LogArgument<WebCore::MediaCapabilitiesEncodingInfo>::toString):
(WTF::LogArgument<WebCore::ColorGamut>::toString):
(WTF::LogArgument<WebCore::HdrMetadataType>::toString):
(WTF::LogArgument<WebCore::TransferFunction>::toString):
(WTF::LogArgument<WebCore::MediaDecodingType>::toString):
(WTF::LogArgument<WebCore::MediaEncodingType>::toString):

• platform/mediacapabilities/MediaCapabilitiesLogging.h: Added.

4:26 PM Changeset in webkit [253454] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] Add sandbox telemetry to mach lookup rules in the WebContent process
​https://bugs.webkit.org/show_bug.cgi?id=205175

Reviewed by Brent Fulgham.

We have already added telemetry to many mach lookup rules, but some were missing telemetry.

No new tests, no behavior change.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

4:20 PM Changeset in webkit [253453] by Chris Dumez

• 22 edits
  60 adds
  4 deletes in trunk/LayoutTests

Re-sync workers web-platform-tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=205180

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Re-sync workers web-platform-tests from upstream 178762b6fce688979e261f3ac8.

• web-platform-tests/workers/*: Updated.

LayoutTests:

• TestExpectations:

4:10 PM Changeset in webkit [253452] by sihui_liu@apple.com

• 16 edits
  1 move in trunk/Source/WebKit

IndexedDB: make WebIDBServer a MessageReceiver to replace WebIDBConnection
​https://bugs.webkit.org/show_bug.cgi?id=205145

Reviewed by Alex Christensen.

Work towards <rdar://problem/56908496>. Move message handling from WebIDBConnectionToClient to WebIDBServer.

Also, WebIDBConnectionClient now is owned by WebIDBServer instead of NetworkConnectionToWebProcess.

No behavior change.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::WebIDBConnectionToClient):
(WebKit::WebIDBConnectionToClient::messageSenderConnection const):
(WebKit::WebIDBConnectionToClient::idbServer): Deleted.
(WebKit::WebIDBConnectionToClient::disconnectedFromWebProcess): Deleted.
(WebKit::WebIDBConnectionToClient::deleteDatabase): Deleted.
(WebKit::WebIDBConnectionToClient::openDatabase): Deleted.
(WebKit::WebIDBConnectionToClient::abortTransaction): Deleted.
(WebKit::WebIDBConnectionToClient::commitTransaction): Deleted.
(WebKit::WebIDBConnectionToClient::didFinishHandlingVersionChangeTransaction): Deleted.
(WebKit::WebIDBConnectionToClient::createObjectStore): Deleted.
(WebKit::WebIDBConnectionToClient::deleteObjectStore): Deleted.
(WebKit::WebIDBConnectionToClient::renameObjectStore): Deleted.
(WebKit::WebIDBConnectionToClient::clearObjectStore): Deleted.
(WebKit::WebIDBConnectionToClient::createIndex): Deleted.
(WebKit::WebIDBConnectionToClient::deleteIndex): Deleted.
(WebKit::WebIDBConnectionToClient::renameIndex): Deleted.
(WebKit::WebIDBConnectionToClient::putOrAdd): Deleted.
(WebKit::WebIDBConnectionToClient::getRecord): Deleted.
(WebKit::WebIDBConnectionToClient::getAllRecords): Deleted.
(WebKit::WebIDBConnectionToClient::getCount): Deleted.
(WebKit::WebIDBConnectionToClient::deleteRecord): Deleted.
(WebKit::WebIDBConnectionToClient::openCursor): Deleted.
(WebKit::WebIDBConnectionToClient::iterateCursor): Deleted.
(WebKit::WebIDBConnectionToClient::establishTransaction): Deleted.
(WebKit::WebIDBConnectionToClient::databaseConnectionPendingClose): Deleted.
(WebKit::WebIDBConnectionToClient::databaseConnectionClosed): Deleted.
(WebKit::WebIDBConnectionToClient::abortOpenAndUpgradeNeeded): Deleted.
(WebKit::WebIDBConnectionToClient::didFireVersionChangeEvent): Deleted.
(WebKit::WebIDBConnectionToClient::openDBRequestCancelled): Deleted.
(WebKit::WebIDBConnectionToClient::confirmDidCloseFromServer): Deleted.
(WebKit::WebIDBConnectionToClient::getAllDatabaseNames): Deleted.

• NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
• NetworkProcess/IndexedDB/WebIDBServer.cpp:

(WebKit::WebIDBServer::getAllDatabaseNames):
(WebKit::WebIDBServer::addConnection):
(WebKit::WebIDBServer::removeConnection):

• NetworkProcess/IndexedDB/WebIDBServer.h:
• NetworkProcess/IndexedDB/WebIDBServer.messages.in: Renamed from Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in.
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::findNetworkActivityTracker):
(WebKit::NetworkConnectionToWebProcess::establishIDBConnectionToServer): Deleted.
NetworkConnectionToWebProcess::establishIDBConnectionToServer was used to ensure WebIDBConnectionToCilent member
exists in NetworkConnectionToWebProcess. Now WebIDBConnectionToCilent is created in
WebIDBServer::addConnection(when NetworkConnectionToWebProcess is created), so we don't need the message to do
initialization.

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
(WebKit::NetworkProcess::connectionToWebProcessClosed):

• NetworkProcess/NetworkProcess.h:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):
(WebKit::WebIDBConnectionToServer::deleteDatabase):
(WebKit::WebIDBConnectionToServer::openDatabase):
(WebKit::WebIDBConnectionToServer::abortTransaction):
(WebKit::WebIDBConnectionToServer::commitTransaction):
(WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToServer::createObjectStore):
(WebKit::WebIDBConnectionToServer::deleteObjectStore):
(WebKit::WebIDBConnectionToServer::renameObjectStore):
(WebKit::WebIDBConnectionToServer::clearObjectStore):
(WebKit::WebIDBConnectionToServer::createIndex):
(WebKit::WebIDBConnectionToServer::deleteIndex):
(WebKit::WebIDBConnectionToServer::renameIndex):
(WebKit::WebIDBConnectionToServer::putOrAdd):
(WebKit::WebIDBConnectionToServer::getRecord):
(WebKit::WebIDBConnectionToServer::getAllRecords):
(WebKit::WebIDBConnectionToServer::getCount):
(WebKit::WebIDBConnectionToServer::deleteRecord):
(WebKit::WebIDBConnectionToServer::openCursor):
(WebKit::WebIDBConnectionToServer::iterateCursor):
(WebKit::WebIDBConnectionToServer::establishTransaction):
(WebKit::WebIDBConnectionToServer::databaseConnectionPendingClose):
(WebKit::WebIDBConnectionToServer::databaseConnectionClosed):
(WebKit::WebIDBConnectionToServer::abortOpenAndUpgradeNeeded):
(WebKit::WebIDBConnectionToServer::didFireVersionChangeEvent):
(WebKit::WebIDBConnectionToServer::openDBRequestCancelled):
(WebKit::WebIDBConnectionToServer::confirmDidCloseFromServer):
(WebKit::WebIDBConnectionToServer::getAllDatabaseNames):

4:02 PM Changeset in webkit [253451] by Chris Dumez

• 14 edits
  4 copies
  52 adds in trunk/LayoutTests

Re-sync webmessaging web-platform-tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=205178

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Re-sync webmessaging web-platform-tests from upstream ab28e18f067f17a.

• web-platform-tests/webmessaging/*: Updated

LayoutTests:

• TestExpectations:

3:53 PM Changeset in webkit [253450] by Chris Dumez

• 5 edits in trunk

Regression(r253394) swipe/basic-cached-back-swipe.html is timing out on iOS
​https://bugs.webkit.org/show_bug.cgi?id=205173

Reviewed by Tim Horton.

Source/WebKit:

Test test was calling beginSimulatedSwipeInDirectionForTesting / completeSimulatedSwipeInDirectionForTesting
on the ViewGestureController. This was causing beginSwipeGesture() and endSwipeGesture() but not
willEndSwipeGesture(). This was causing the timeout since willEndSwipeGesture() now actually triggers the
load.

This patch also gets rid of the SnapshotRemovalTracker::SwipeAnimationEnd. We don't really need it since
we already wait for SnapshotRemovalTracker::RepaintAfterNavigation and we won't repaint until the swipe
animation is over (due to the layer tree being frozen during the swipe animation). The SwipeAnimationEnd
was causing trouble because the provisional load may not have started yet by the time endSwipeGesture()
is called, which means that the call to eventOccurred(SwipeAnimationEnd) would get ignored because the
SnapshotRemovalTracker is still paused (it gets unpaused when the provisional load actually starts).

• UIProcess/ViewGestureController.h:
• UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::willEndSwipeGesture):
(WebKit::ViewGestureController::endSwipeGesture):

LayoutTests:

• platform/ios/swipe/basic-cached-back-swipe-expected.txt:

3:42 PM Changeset in webkit [253449] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit

NetworkDataTaskCocoa and NetworkSessionCocoa should use public methods instead of being friends
​https://bugs.webkit.org/show_bug.cgi?id=204242

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-12-12
Reviewed by Chris Dumez.

This makes them stay good abstractions, and probably could make a good meme about not having any friends.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::applySniffingPoliciesAndBindRequestToInferfaceIfNeeded):

• NetworkProcess/cocoa/NetworkSessionCocoa.h:

3:35 PM Changeset in webkit [253448] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, try to address flakiness of http/tests/cache-storage/page-cache-domcache-pending-promise.html on EWS

• http/tests/cache-storage/page-cache-domcache-pending-promise.html:

3:29 PM Changeset in webkit [253447] by Alan Coon

• 2 edits in tags/Safari-609.1.12/Source/ThirdParty/ANGLE

Cherry-pick r253383. rdar://problem/57713353

Produce a dummy libANGLE.a file to fool Apple's build test infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=205068
<rdar://problem/57713353>

Unreviewed followup to apply the script to Mac Catalyst builds.

Note that this phase can be removed in a few days when Apple's Test
Platform realises it doesn't need libANGLE.a any more.

• ANGLE.xcodeproj/project.pbxproj:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@253383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:29 PM Changeset in webkit [253446] by Alan Coon

• 2 edits in tags/Safari-609.1.12/Source/ThirdParty/ANGLE

Cherry-pick r253333. rdar://problem/57713353

Produce a dummy libANGLE.a file to fool Apple's build test infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=205068
<rdar://problem/57713353>

Reviewed by Alex Christensen.

Create a dummy libANGLE.a file until our infrastructure realises it
doesn't need that file any more. Hopefully the fact that it isn't
really a static library, but just a text file, is ok.

• ANGLE.xcodeproj/project.pbxproj: Add a new shell script phase that creates a dummy file.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@253333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:09 PM Changeset in webkit [253445] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r172814): Don't export inline SQLiteDatabase::disableThreadingChecks() method
<​https://webkit.org/b/205140>

Reviewed by Alex Christensen.

• platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::disableThreadingChecks):
Remove WEBCORE_EXPORT macro from inline method. This only seems
to occur on Release builds with compiler optimizations disabled.

1:46 PM Changeset in webkit [253444] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Don't assert in HTTPServer::respondToRequests when connections fail
​https://bugs.webkit.org/show_bug.cgi?id=205072
<rdar://problem/57718266>

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-12-12
Reviewed by Alexey Proskuryakov.

We have records that this assertion is being hit, but it's probably when things are being torn down after the test passes.
If someone actually has a connection failure that breaks a test, we'll notice elsewhere.

• TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::respondToRequests):

1:33 PM Changeset in webkit [253443] by ysuzuki@apple.com

• 99 edits in trunk/Source

[JSC] Lock-down JSGlobalObject and derived classes in IsoSubspace
​https://bugs.webkit.org/show_bug.cgi?id=205108

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch puts JSGlobalLexicalEnvironment and JSGlobalObject (and its derived classes including JSDOMWindow etc.) in IsoSubspace.
We were using addFinalizer feature to call destructors for these objects since they do not inherit JSDestructibleObject. But now
each derived classes has its IsoSubspace. So we do not need to use finalizer feature: just setting specialized HeapCellType works.

• API/JSAPIGlobalObject.h:
• API/JSCallbackObject.cpp:
• API/glib/JSAPIWrapperGlobalObject.cpp:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/SuperSampler.h:
• heap/CellAttributes.h:
• heap/FreeList.h:
• heap/IsoHeapCellType.cpp:

(JSC::IsoHeapCellType::IsoHeapCellType):

• heap/IsoHeapCellType.h:
• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::setIsFreeListed): Deleted.

• heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::Handle::setIsFreeListed):

• jsc.cpp:

(GlobalObject::create): Deleted.
(GlobalObject::createStructure): Deleted.
(GlobalObject::javaScriptRuntimeFlags): Deleted.
(GlobalObject::finishCreation): Deleted.
(GlobalObject::addFunction): Deleted.

• runtime/JSGlobalLexicalEnvironment.h:
• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::subspaceFor):

• runtime/JSSegmentedVariableObject.cpp:

(JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):
(JSC::JSSegmentedVariableObject::finishCreation):
(JSC::JSSegmentedVariableObject::destroy): Deleted.

• runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::subspaceFor):
(JSC::JSSegmentedVariableObject::classInfo const): Deleted.

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:
• testRegExp.cpp:

(GlobalObject::create): Deleted.
(GlobalObject::createStructure): Deleted.
(GlobalObject::finishCreation): Deleted.

Source/WebCore:

We put derived classes of JSGlobalObject in IsoSubspace in WebCore side too.

• bindings/js/JSDOMGlobalObject.h:
• bindings/js/JSDOMWindowBase.h:
• bindings/js/JSDOMWrapper.cpp:

(WebCore::globalObjectOutputConstraintSubspaceFor): Deleted.

• bindings/js/JSDOMWrapper.h:
• bindings/js/JSRemoteDOMWindowBase.h:
• bindings/js/JSWindowProxy.h:
• bindings/js/JSWorkerGlobalScopeBase.h:

(WebCore::JSWorkerGlobalScopeBase::subspaceFor):

• bindings/js/JSWorkletGlobalScopeBase.h:

(WebCore::JSWorkletGlobalScopeBase::subspaceFor):

• bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::JSVMClientData):

• bindings/js/WebCoreJSClientData.h:

(WebCore::JSVMClientData::subspaceForJSDOMWindow):
(WebCore::JSVMClientData::subspaceForJSDedicatedWorkerGlobalScope):
(WebCore::JSVMClientData::subspaceForJSRemoteDOMWindow):
(WebCore::JSVMClientData::subspaceForJSWorkerGlobalScope):
(WebCore::JSVMClientData::subspaceForJSServiceWorkerGlobalScope):
(WebCore::JSVMClientData::subspaceForJSPaintWorkletGlobalScope):
(WebCore::JSVMClientData::subspaceForJSWorkletGlobalScope):
(WebCore::JSVMClientData::forEachOutputConstraintSpace):
(WebCore::JSVMClientData::globalObjectOutputConstraintSpace): Deleted.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GeneratePrototypeDeclaration):

• bindings/scripts/test/JS/JSInterfaceName.cpp:
• bindings/scripts/test/JS/JSMapLike.cpp:
• bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
• bindings/scripts/test/JS/JSReadOnlySetLike.cpp:
• bindings/scripts/test/JS/JSSetLike.cpp:
• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
• bindings/scripts/test/JS/JSTestCEReactions.cpp:
• bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
• bindings/scripts/test/JS/JSTestCallTracer.cpp:
• bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
• bindings/scripts/test/JS/JSTestDOMJIT.cpp:
• bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
• bindings/scripts/test/JS/JSTestEnabledForContext.cpp:
• bindings/scripts/test/JS/JSTestEventConstructor.cpp:
• bindings/scripts/test/JS/JSTestEventTarget.cpp:
• bindings/scripts/test/JS/JSTestException.cpp:
• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
• bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::JSTestGlobalObject::subspaceForImpl):

• bindings/scripts/test/JS/JSTestGlobalObject.h:

(WebCore::JSTestGlobalObject::subspaceFor):

• bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
• bindings/scripts/test/JS/JSTestIterable.cpp:
• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
• bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
• bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
• bindings/scripts/test/JS/JSTestNode.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
• bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
• bindings/scripts/test/JS/JSTestPluginInterface.cpp:
• bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
• bindings/scripts/test/JS/JSTestSerialization.cpp:
• bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:
• bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
• bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/JS/JSTestStringifier.cpp:
• bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
• bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
• bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
• bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
• bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
• bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
• bindings/scripts/test/JS/JSTestTypedefs.cpp:
• bridge/runtime_method.h:

1:32 PM Changeset in webkit [253442] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Paint seemingly blank runs (0 width, result of negative letter-spacing)
​https://bugs.webkit.org/show_bug.cgi?id=205114
<rdar://problem/57837165>

Reviewed by Antti Koivisto.

Let's not intersect the run's rect with the damaged area when we don't yet have any paint
overflow information (This should rather use the line box set to identify the line range to paint.)

• layout/displaytree/DisplayInlineContent.cpp:

(WebCore::Display:: const):

11:19 AM Changeset in webkit [253441] by mark.lam@apple.com

• 3 edits
  1 add in trunk

Fix missing exception check in JSON Stringifier's gap function.
​https://bugs.webkit.org/show_bug.cgi?id=205171
<rdar://problem/57871842>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/missing-exception-check-in-json-stringifier-gap.js: Added.

Source/JavaScriptCore:

• runtime/JSONObject.cpp:

(JSC::gap):

11:09 AM Changeset in webkit [253440] by pvollan@apple.com

• 12 edits in trunk

[iOS] Deny mach lookup access to content filter service in the WebContent sandbox
​https://bugs.webkit.org/show_bug.cgi?id=205077

Reviewed by Brent Fulgham.

Source/WebCore:

Add a global flag to ParentalControlsContentFilter to indicate whether the Web content filter extension has
been consumed. If the flag has been set, there is no need to check [WebFilterEvaluator isManagedSession],
since the flag will tell if filtering is required.

The API test ContentFiltering.LazilyLoadPlatformFrameworks has been modified to pass after this change.

• WebCore.xcodeproj/project.pbxproj:
• platform/cocoa/ParentalControlsContentFilter.h:
• platform/cocoa/ParentalControlsContentFilter.mm:

(WebCore::ParentalControlsContentFilter::enabled):
(WebCore::ParentalControlsContentFilter::setHasConsumedSandboxExtension):

Source/WebKit:

Mach lookup access to the content filter service in the WebContent process is only needed if
[WebFilterEvaluator isManagedSession] evaluates to true. If this is the case, issue the needed
mach lookup sandbox extension to the WebContent process, where it will be consumed.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

With this patch, the WebContentAnalysis framework will not be loaded in the WebContent process unless
[WebFilterEvaluator isManagedSession] returns YES. Swizzle this method to return YES in the UI process.

• TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:

(isManagedSession):
(TEST):

10:45 AM Changeset in webkit [253439] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKitLegacy/mac

REGRESSION (r229930, r231063): WebKitLegacy.xcconfig overwrites OTHER_CFLAGS, OTHER_CPLUSPLUSFLAGS and OTHER_LDFLAGS from Base.xcconfig
<​https://webkit.org/b/205144>

Reviewed by Alexey Proskuryakov.

• Configurations/WebKitLegacy.xcconfig:

(OTHER_CFLAGS): Add back $(inherited) to fix the bug.
(OTHER_CFLAGS_COCOA_TOUCH): Add variable to hold value.
(OTHER_CFLAGS_COCOA_TOUCH_YES): Remove unused $(inherited).
(OTHER_CFLAGS_COCOA_TOUCH_NO): Ditto.
(OTHER_CPLUSPLUSFLAGS): Add back $(inherited) to fix the
bug, and don't assume $(OTHER_CFLAGS) is identical to this.
(OTHER_LDFLAGS): Add back $(inherited) to fix the bug.

10:35 AM Changeset in webkit [253438] by Alan Coon

• 7 edits in branches/safari-609.1.11.3-branch/Source

Versioning.

10:33 AM Changeset in webkit [253437] by yurys@chromium.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Error: Can't make a ContentView for an unknown representedObject of type: CallFrame
​https://bugs.webkit.org/show_bug.cgi?id=204823

Reviewed by Devin Rousso.

If no type is stored in the cookie matching by type should fail.

• UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie.treeElementMatchesCookie):
(WI.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):

10:33 AM Changeset in webkit [253436] by Chris Dumez

• 4 edits in trunk/LayoutTests

window.AudioContext / window.OfflineAudioContext should not be enumerable
​https://bugs.webkit.org/show_bug.cgi?id=205163

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

LayoutTests:

• resources/testharnessreport.js:

10:27 AM Changeset in webkit [253435] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/text/whitespace/023.html
​https://bugs.webkit.org/show_bug.cgi?id=205170
<rdar://problem/57881365>

Reviewed by Antti Koivisto.

Do not try to find expansion opportunities in content with preserved whitespace.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::ContinousContent::ContinousContent):
(WebCore::Layout::LineBuilder::ContinousContent::append):
(WebCore::Layout::LineBuilder::ContinousContent::close):

10:26 AM Changeset in webkit [253434] by Truitt Savell

• 2 edits in trunk/LayoutTests

REGRESSION: [Mac wk1] imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html is a flakey failure
​https://bugs.webkit.org/show_bug.cgi?id=205168

Unreviewed test gardneing

• platform/mac-wk1/TestExpectations:

10:24 AM Changeset in webkit [253433] by Alan Coon

• 1 copy in branches/safari-609.1.11.3-branch

New branch.

10:07 AM Changeset in webkit [253432] by mark.lam@apple.com

• 6 edits
  1 add in trunk

DFG and FTL expects String.prototype to not qualify for StringObjectUse.
​https://bugs.webkit.org/show_bug.cgi?id=205147
<rdar://problem/57748888>

Reviewed by Saam Barati.

JSTests:

• stress/ftl-expects-string-prototype-to-not-be-StringObjectUse.js: Added.

Source/JavaScriptCore:

Currently, String.prototype's JSType is StringObjectType.

However, in the compiler, there are a few places that expect that the
String.prototype value to not qualify as StringObjectUse. These places are:

1. SpeculatedType.cpp's speculationFromClassInfo() will speculate SpecObjectOther for the StringPrototype object.
2. DFGFixupPhase.cpp's addCheckStructureForOriginalStringObjectUse() only emits a CheckStructure against globalObject->stringObjectStructure(). It does not check against String.prototype's structure.

To resolve this discrepancy, we can either do:

1. change String.prototype's JSType to something else.
2. fix the places in the compiler to accept String.prototype as StringObjectUse.

(a) is trivial and cheap to do. (b) is doable but will result in less optimal
compiled code. Since passing String.prototype as a StringObject is expected to
be a rare thing in JS code, it's not worth incurring the cost for (b). In this
patch, we apply (a) to fix the discrepancy.

Also added a specialization case to FOR_EACH_JS_DYNAMIC_CAST_JS_TYPE_OVERLOAD
for jsDynamicCast<StringObject> for completeness.

• runtime/JSCast.h:
• runtime/JSType.cpp:

(WTF::printInternal):

• runtime/JSType.h:
• runtime/StringPrototype.h:

9:51 AM Changeset in webkit [253431] by Patrick Griffis

• 8 edits in trunk

[SOUP] Use new API for strict secure cookies
​https://bugs.webkit.org/show_bug.cgi?id=169356

Reviewed by Michael Catanzaro.

Source/WebCore:

The new soup API implements this spec:

​https://tools.ietf.org/html/draft-ietf-httpbis-cookie-alone-01

• platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::setCookiesFromDOM const):
(WebCore::NetworkStorageSession::setCookies):

Tools:

Update libsoup to fix a secure cookie test

• gtk/jhbuild.modules:
• wpe/jhbuild.modules:

LayoutTests:

Remove expected failures for secure cookie tests

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

9:49 AM Changeset in webkit [253430] by don.olmstead@sony.com

• 4 edits in trunk

[CMake] Add LibPSL::LibPSL target
​https://bugs.webkit.org/show_bug.cgi?id=205149

Reviewed by Michael Catanzaro.

.:

Add a LibPSL target into the FindLibPSL module.

• Source/cmake/FindLibPSL.cmake:

Source/WebCore:

Use LibPSL target.

• platform/Curl.cmake:

9:25 AM Changeset in webkit [253429] by Truitt Savell

• 2 edits in trunk/LayoutTests

REGRESSION: (r251677) imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3.html is a flakey failure
​https://bugs.webkit.org/show_bug.cgi?id=205164

Unreviewed test gardening

• platform/mac/TestExpectations:

7:48 AM Changeset in webkit [253428] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/text/whitespace/simple-line-layout-tab-position.html
​https://bugs.webkit.org/show_bug.cgi?id=205160
<rdar://problem/57876474>

Reviewed by Antti Koivisto.

Use the content box (and not the border box) as the start position when measuring text and also include
the not-yet committed content.
e.g. <pre style="padding: 100px;">text[tab character]</pre>
When we measure the width of the [tab] character, the start position input to the text measuring is

1. relative to the content box (0px vs 100px)
2. includes the [text] not-yet committed content width

This patch also ensures that we only fast-path the collapsible whitespace characters.

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::placeInlineItem):

• layout/inlineformatting/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::width):

7:18 AM Changeset in webkit [253427] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

REGRESSION(r252979): Avoid unnecessary work when searching for the flow when constructing line layout iteratorAvoid unnecessary work when searching for the flow when constructing line layout iterator
​https://bugs.webkit.org/show_bug.cgi?id=205155
<rdar://problem/57846936>

Reviewed by Zalan Bujtas.

We unecessarily searched the ancestor chain flow the RenderFlow. We can avoid this
for now since we know only candidate it the direct parent.

• rendering/line/LineLayoutTraversal.cpp:

(WebCore::LineLayoutTraversal::lineLayoutSystemFlowForRenderer):
(WebCore::LineLayoutTraversal::firstTextBoxFor):
(WebCore::LineLayoutTraversal::firstTextBoxInTextOrderFor):
(WebCore::LineLayoutTraversal::elementBoxFor):
(WebCore::LineLayoutTraversal::flowForText): Deleted.

6:22 AM Changeset in webkit [253426] by youenn@apple.com

• 3 edits in trunk/Source/WebCore

Roll-out part of revision 253275 related to rotation handling
​https://bugs.webkit.org/show_bug.cgi?id=205156

Unreviewed.

These changes only work for a remote source, not a local one.
Roll-them out until we have a proper fix.

• platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::m_source):
(WebCore::RealtimeVideoSource::sourceSettingsChanged):

• platform/mediastream/RealtimeVideoSource.h:

3:05 AM Changeset in webkit [253425] by Carlos Garcia Campos

• 4 edits
  1 add in trunk/Source

WebDriver: tests is_element_enabled/enabled.py::test_fieldset_disabled_descendant are failing
​https://bugs.webkit.org/show_bug.cgi?id=204700

Reviewed by Carlos Alberto Lopez Perez.

Source/WebDriver:

Fixes: imported/w3c/webdriver/tests/is_element_enabled/enabled.py::test_fieldset_disabled_descendant[button]

imported/w3c/webdriver/tests/is_element_enabled/enabled.py::test_fieldset_disabled_descendant[input]
imported/w3c/webdriver/tests/is_element_enabled/enabled.py::test_fieldset_disabled_descendant[select]
imported/w3c/webdriver/tests/is_element_enabled/enabled.py::test_fieldset_disabled_descendant[textarea]

• CMakeLists.txt: Add ElementEnabled.js to compilation.
• Session.cpp:

(WebDriver::Session::isElementEnabled): Use ElementEnabled atom instead.

Source/WebKit:

Add ElementEnabled atom to easily implement is element enabled command.

• UIProcess/Automation/atoms/ElementEnabled.js: Added.

(isEnabled.isDisabledAttributeSupported):
(isEnabled.findParent):
(isEnabled):

1:49 AM Changeset in webkit [253424] by Fujii Hironori

• 2 edits in trunk/LayoutTests

Unreviewed test gardening for WinCairo

• platform/wincairo/TestExpectations: Unskip fast/text.

1:36 AM Changeset in webkit [253423] by ysuzuki@apple.com

• 32 edits
  2 copies in trunk/Source/JavaScriptCore

[JSC] IsoHeapCellType should have destroy function member instead of specializing template function
​https://bugs.webkit.org/show_bug.cgi?id=205152

Reviewed by Saam Barati.

We were specializing MarkedBlock::Handle::specializedSweep in 5 different ways for each IsoSubspace-ed cell.
This bloats binary. Instead of specializing it with CellType, we specialize it with one functor, which invokes
function pointer held by IsoHeapCellType. This requires one indirect function call per cell. But this is OK since,

1. We were using JSDestructibleObject's cell->classInfo->methodTable.destroy function call to dispatch destruction, before IsoSubspace replaces them with IsoHeapCellType-based destruction. Compared to that, the new one is still saving one pointer chasing basically (classInfo dereference, we assume cell deference is no cost since it will be done anyway).
2. We still keep JSString's destroy function inlining by using IsoInlinedHeapCellType. This is important since it is critical to performance and we had JSStringHeapCellType before we replaced it with IsoHeapCellType. But IsoInlinedHeapCellType specialization is for only one class so generated binary size is the same to the old code using JSStringHeapCellType.

This saves 480KB binary-size in JavaScriptCore. And more importantly, after this patch, adding IsoSubspace
will not bloat code, so we can simply put things into IsoSubspace.

This patch also removes using namespace JSC; in global code in JavaScriptCore except for API codes, since
it starts causing build failure due to unified builds: API defines JSType enum in a global scope, which is
different from our JSC::JSType. If we do using namespace JSC; in a global scope, it can lead to ambiguity of
looking up.

• API/JSHeapFinalizerPrivate.cpp:

(JSContextGroupAddHeapFinalizer):
(JSContextGroupRemoveHeapFinalizer):

• API/JSHeapFinalizerPrivate.h:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• assembler/AbstractMacroAssembler.cpp:
• bindings/ScriptFunctionCall.cpp:
• bindings/ScriptObject.cpp:
• bindings/ScriptValue.cpp:
• heap/IsoHeapCellType.cpp: Copied from Source/JavaScriptCore/assembler/AbstractMacroAssembler.cpp.

(JSC::IsoHeapCellType::finishSweep):
(JSC::IsoHeapCellType::destroy):

• heap/IsoHeapCellType.h:
• heap/IsoInlinedHeapCellType.h: Copied from Source/JavaScriptCore/heap/IsoHeapCellType.h.
• heap/MutatorState.cpp:
• heap/Synchronousness.cpp:
• inspector/InjectedScriptHost.cpp:
• inspector/InjectedScriptManager.cpp:
• inspector/JSGlobalObjectConsoleClient.cpp:
• inspector/JSGlobalObjectInspectorController.cpp:
• inspector/JSGlobalObjectScriptDebugServer.cpp:
• inspector/JSInjectedScriptHost.cpp:
• inspector/JSInjectedScriptHostPrototype.cpp:
• inspector/JSJavaScriptCallFrame.cpp:
• inspector/JSJavaScriptCallFramePrototype.cpp:
• inspector/JavaScriptCallFrame.cpp:
• inspector/PerGlobalObjectWrapperWorld.cpp:
• inspector/ScriptCallStackFactory.cpp:
• inspector/ScriptDebugServer.cpp:
• inspector/agents/InspectorHeapAgent.cpp:
• inspector/agents/InspectorScriptProfilerAgent.cpp:
• inspector/agents/JSGlobalObjectAuditAgent.cpp:
• inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
• inspector/agents/JSGlobalObjectRuntimeAgent.cpp:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

12:48 AM Changeset in webkit [253422] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Remove debug ASSERT in PeerConnectionBackend
​https://bugs.webkit.org/show_bug.cgi?id=205061

Reviewed by Eric Carlson.

Remove two wrong debug asserts.
Move the isClosed check just before resolving/rejecting the promise since at resume time, a lot might happen,
including closing the peer connection.
Covered by tests no longer crashing.

• Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::PeerConnectionBackend::createOfferFailed):
(WebCore::PeerConnectionBackend::createAnswerSucceeded):
(WebCore::PeerConnectionBackend::createAnswerFailed):
(WebCore::PeerConnectionBackend::setLocalDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setLocalDescriptionFailed):
(WebCore::PeerConnectionBackend::setRemoteDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setRemoteDescriptionFailed):
(WebCore::PeerConnectionBackend::addIceCandidateSucceeded):
(WebCore::PeerConnectionBackend::addIceCandidateFailed):

12:24 AM Changeset in webkit [253421] by Devin Rousso

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r251227): Uncaught Exception: undefined is not an object (evaluating 'target.DOMAgent.setInspectModeEnabled')
​https://bugs.webkit.org/show_bug.cgi?id=205148

Reviewed by Joseph Pecoraro.

• UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.setElementSelectionEnabled):
If there are no targets available yet (WI.targetsAvailable()), then wait for targets to
be available (WI.whenTargetsAvailable()) before performing the intended logic, as the
InspectorFrontendAPI only waits for the backend connection to be established before
dispatching, meaning that there may not be a page target yet. Other InspectorFrontendAPI
functions don't need to be changed because they don't cause commands to be invoked.

• UserInterface/Controllers/DOMManager.js:

(WI.DOMManager.prototype.set inspectModeEnabled):
Drive-by: don't assume that inspect mode is disabled if an error is thrown.

• UserInterface/Base/Main.js:

Drive-by: remove duplicate function WI._toggleInspectMode as it already exists.