Timeline
Dec 30, 2019:
- 9:41 PM Changeset in webkit [253956] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, build fix after r253904
https://bugs.webkit.org/show_bug.cgi?id=205553
- bytecompiler/BytecodeGeneratorBaseInlines.h:
(JSC::BytecodeGeneratorBase<Traits>::alignWideOpcode16):
(JSC::BytecodeGeneratorBase<Traits>::alignWideOpcode32):
- 3:53 PM Changeset in webkit [253955] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r253896): [GTK][WPE] Broke the build with GCC-7
https://bugs.webkit.org/show_bug.cgi?id=205649
Reviewed by Mark Lam.
Add WTF_INTERNAL macro to explicitly adjust the symbol visibility.
- llint/LLIntSlowPaths.h:
- 3:43 PM Changeset in webkit [253954] by
-
- 2 edits in trunk/Tools
[GTK][WPE] OpenJPEG missing in install dependencies script
https://bugs.webkit.org/show_bug.cgi?id=205647
Reviewed by Adrian Perez de Castro.
- gtk/install-dependencies: Add OpenJPEG-2 package to the list.
- 2:16 PM Changeset in webkit [253953] by
-
- 1 edit in trunk/Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp
Build fix for iOS simulator.
- platform/mediastream/mac/BaseAudioSharedUnit.cpp:
- 12:52 PM Changeset in webkit [253952] by
-
- 15 edits2 adds in trunk
Create media mime type cache base class to reduce duplicate code
https://bugs.webkit.org/show_bug.cgi?id=205632
<rdar://problem/58233565>
Reviewed by Jer Noble.
No new tests, no functional change.
AVStreamDataParserMIMETypeCache and AVAssetMIMETypeCache have a lot of very similar code,
so create MIMETypeCache as a base class. Also move most of the logic from
MediaPlayerPrivateMediaSourceAVFObjC::supportsType and MediaPlayerPrivateAVFoundationObjC::supportsType
in the caches.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::isSupportedImageVideoOrSVGMIMEType): Call supportsContainerType.
- platform/graphics/MIMETypeCache.cpp: Added.
(WebCore::MIMETypeCache::supportedTypes):
(WebCore::MIMETypeCache::supportsContainerType):
(WebCore::MIMETypeCache::canDecodeType):
(WebCore::MIMETypeCache::canDecodeTypePrivate):
(WebCore::MIMETypeCache::setSupportedTypes):
(WebCore::MIMETypeCache::addSupportedType):
(WebCore::MIMETypeCache::staticContainerTypeList):
- platform/graphics/MIMETypeCache.h: Added.
(WebCore::MIMETypeCache::isUnsupportedType):
(WebCore::MIMETypeCache::isAvailable const):
(WebCore::MIMETypeCache::canDecodeTypeInternal):
(WebCore::MIMETypeCache::initializeCache):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaEngineSupportParameters::encode const): Drive-by fix - add missing variable.
- platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.h:
- platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:
(WebCore::AVAssetMIMETypeCache::isAvailable const):
(WebCore::AVAssetMIMETypeCache::canDecodeTypeInternal):
(WebCore::AVAssetMIMETypeCache::isUnsupportedType):
(WebCore::AVAssetMIMETypeCache::staticContainerTypeList):
(WebCore::AVAssetMIMETypeCache::initializeCache):
(WebCore::AVAssetMIMETypeCache::setSupportedTypes): Moved to base class.
(WebCore::AVAssetMIMETypeCache::types): Moved to base class as supportedTypes.
(WebCore::AVAssetMIMETypeCache::supportsContentType): Renamed supportsContainerType.
(WebCore::AVAssetMIMETypeCache::canDecodeType): Moved to base class.
(WebCore::AVAssetMIMETypeCache::loadMIMETypes): Deleted.
- platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.h:
- platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:
(WebCore::AVStreamDataParserMIMETypeCache::canDecodeTypeInternal):
(WebCore::AVStreamDataParserMIMETypeCache::initializeCache):
(WebCore::AVStreamDataParserMIMETypeCache::types): Moved to base class as supportedTypes.
(WebCore::AVStreamDataParserMIMETypeCache::supportsContentType): Renamed supportsContainerType.
(WebCore::AVStreamDataParserMIMETypeCache::canDecodeType): Moved to base class.
(WebCore::AVStreamDataParserMIMETypeCache::loadMIMETypes): Deleted.
- platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.h:
- platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(WebCore::ImageDecoderAVFObjC::supportsContainerType): Renamed from supportsContentType.
(WebCore::ImageDecoderAVFObjC::canDecodeType):
(WebCore::ImageDecoderAVFObjC::supportsContentType): Deleted.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::getSupportedTypes):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::getSupportedTypes):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):
- 12:46 PM Changeset in webkit [253951] by
-
- 3 edits in trunk/Source/WebCore
[LFC][Integration] Do not apply trailing whitespace quirk when content is right aligned.
https://bugs.webkit.org/show_bug.cgi?id=205634
<rdar://problem/58234523>
Reviewed by Antti Koivisto.
Apparently we don't always need this quirk. See SimpleLineLayout::createLineRuns.
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::removeTrailingCollapsibleContent):
- layout/inlineformatting/InlineLineBuilder.h:
(WebCore::Layout::LineBuilder::isTextAlignRight const):
- 12:23 PM Changeset in webkit [253950] by
-
- 25 edits2 adds in trunk
Add WKWebView SPI to evaluate a function with arguments
https://bugs.webkit.org/show_bug.cgi?id=205239
Reviewed by Alex Christensen.
Source/WebCore:
Covered by new API tests.
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ExceptionDetails.h:
- bindings/js/RunJavaScriptParameters.h: Added.
(WebCore::RunJavaScriptParameters::RunJavaScriptParameters):
(WebCore::RunJavaScriptParameters::encode const):
(WebCore::RunJavaScriptParameters::decode):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorldIgnoringException):
(WebCore::ScriptController::executeScriptInWorld):
(WebCore::ScriptController::callInWorld):
(WebCore::ScriptController::executeUserAgentScriptInWorld):
(WebCore::ScriptController::executeUserAgentScriptInWorldInternal):
(WebCore::ScriptController::executeAsynchronousUserAgentScriptInWorld):
- bindings/js/ScriptController.h:
XPathGrammar changes completely unrelated to the functionality of this patch,
but because of our poor #include hygiene these were necessary to keep linuxes building.
- xml/XPathGrammar.cpp:
- xml/XPathGrammar.y:
Source/WebKit:
- Shared/API/APISerializedScriptValue.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame):
- UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:
(API::sharedContext):
(API::SerializedScriptValue::deserialize):
(API::SerializedScriptValue::wireBytesFromNSObject):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView evaluateJavaScript:completionHandler:]):
(validateArgument):
(-[WKWebView _evaluateJavaScript:asAsyncFunction:withArguments:forceUserGesture:completionHandler:]):
(-[WKWebView _callAsyncFunction:withArguments:completionHandler:]):
(-[WKWebView _evaluateJavaScriptWithoutUserGesture:completionHandler:]):
(-[WKWebView _evaluateJavaScript:forceUserGesture:completionHandler:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/glib/WebKitWebView.cpp:
(webkit_web_view_run_javascript):
(webkit_web_view_run_javascript_in_world):
(resourcesStreamReadCallback):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::runJavaScriptInMainFrameScriptWorld):
- UIProcess/WebPageProxy.h:
- UIProcess/socket/RemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::runScript):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScript):
(WebKit::WebPage::runJavaScriptInMainFrameScriptWorld):
(WebKit::WebPage::runJavaScriptInFrame):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm: Added.
(TestWebKitAPI::TEST):
- TestWebKitAPI/cocoa/TestWKWebView.h:
- TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
- 12:16 PM Changeset in webkit [253949] by
-
- 5 edits in trunk/Source/WebCore
Style invalidation cleanups
https://bugs.webkit.org/show_bug.cgi?id=205644
Reviewed by Zalan Bujtas.
Move more of the invalidation code from Style::Scope to Style::Invalidator.
- style/StyleInvalidator.cpp:
(WebCore::Style::Invalidator::invalidateStyle):
(WebCore::Style::Invalidator::invalidateAllStyle):
(WebCore::Style::Invalidator::invalidateHostAndSlottedStyleIfNeeded):
- style/StyleInvalidator.h:
- style/StyleScope.cpp:
(WebCore::Style::Scope::analyzeStyleSheetChange):
Return StyleSheetChange struct.
(WebCore::Style::Scope::updateActiveStyleSheets):
(WebCore::Style::Scope::invalidateStyleAfterStyleSheetChange):
Use StyleSheetChange to invalidate the style.
(WebCore::Style::Scope::updateResolver):
(WebCore::Style::Scope::scheduleUpdate):
(WebCore::Style::Scope::evaluateMediaQueries):
(WebCore::Style::invalidateHostAndSlottedStyleIfNeeded): Deleted.
- style/StyleScope.h:
(WebCore::Style::Scope::document):
(WebCore::Style::Scope::shadowRoot const):
(WebCore::Style::Scope::shadowRoot):
- 10:25 AM Changeset in webkit [253948] by
-
- 6 edits in trunk/Source/WebCore
[LFC][IFC] Fix imported/w3c/web-platform-tests/css/css-text/white-space/white-space-wrap-after-nowrap-001.html
https://bugs.webkit.org/show_bug.cgi?id=205633
<rdar://problem/58234239>
Reviewed by Antti Koivisto.
When the LineBreaker comes back with Action::Revert (meaning that the line
needs to be reverted back to an earlier line wrap opportunity), call LineBuilder::revert and
close the line.
- layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::LineBreaker::tryWrappingInlineContent const): Return push when the current content can be wrapped.
(WebCore::Layout::ContinousContent::ContinousContent):
(WebCore::Layout::ContinousContent::lastWrapOpportunityIndex const): Fix the last position logic.
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::revert):
(WebCore::Layout::LineBuilder::collectHangingContent):
- layout/inlineformatting/InlineLineBuilder.h:
- layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::endsWithSoftWrapOpportunity):
(WebCore::Layout::LineLayoutContext::layoutLine):
(WebCore::Layout::LineLayoutContext::tryAddingFloatItems):
(WebCore::Layout::LineLayoutContext::tryAddingInlineItems):
(WebCore::Layout::LineLayoutContext::addFloatItems): Deleted.
(WebCore::Layout::LineLayoutContext::checkForLineWrapAndCommit): Deleted.
- layout/inlineformatting/LineLayoutContext.h:
- 9:17 AM Changeset in webkit [253947] by
-
- 2 edits in trunk/Tools
[GTK][WPE] Report number of total tests run and failed in API test runner like run-api-tests does
https://bugs.webkit.org/show_bug.cgi?id=205608
Reviewed by Carlos Garcia Campos.
Calculate the total number of tests (including subtests) executed
and report it at the end of the step in the same format than run-api-tests does.
- glib/api_test_runner.py:
(TestRunner._run_test_glib): Pass the list of skipped tests instead of calculating it here to avoid calculating it twice.
(TestRunner._get_tests_from_google_test_suite): Ditto.
(TestRunner._run_google_test_suite): Ditto.
(TestRunner._run_test): Ditto.
(TestRunner.run_tests):
(TestRunner.run_tests.number_of_tests):
(TestRunner.run_tests.report):
- 9:10 AM Changeset in webkit [253946] by
-
- 14 edits8 adds in trunk
Ignore URL host for schemes that are not using host information
https://bugs.webkit.org/show_bug.cgi?id=205157
Source/WebCore:
rdar://problem/57825963
Reviewed by Darin Adler.
Tests: http/tests/local/file-url-host.html
http/tests/security/about-url-host.html
http/tests/security/data-url-host.html
http/tests/security/javascript-url-host.html
Whenever setting the document URL, remove the host information if its scheme is not supposed to have a host.
This is done for file, data and about schemes.
Add internals APIs to test this.
- dom/Document.cpp:
(WebCore::Document::setURL):
- page/DOMWindow.h:
- page/Location.h:
- page/Location.idl:
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::shouldIgnoreHost):
- page/SecurityOrigin.h:
- testing/Internals.cpp:
(WebCore::Internals::windowLocationHost):
- testing/Internals.h:
- testing/Internals.idl:
Source/WTF:
<rdar://problem/57825963>
Reviewed by Darin Adler.
- wtf/URL.cpp:
(WTF::URL::removeHostAndPort):
- wtf/URL.h:
LayoutTests:
Reviewed by Darin Adler.
- http/tests/local/file-url-host-expected.txt: Added.
- http/tests/local/file-url-host.html: Added.
- http/tests/security/about-url-host-expected.txt: Added.
- http/tests/security/about-url-host.html: Added.
- http/tests/security/data-url-host-expected.txt: Added.
- http/tests/security/data-url-host.html: Added.
- http/tests/security/javascript-url-host-expected.txt: Added.
- http/tests/security/javascript-url-host.html: Added.
- 9:01 AM Changeset in webkit [253945] by
-
- 2 edits in trunk/Tools
[GTK][WPE] support output of results in json format in API test runner.
https://bugs.webkit.org/show_bug.cgi?id=205579
Reviewed by Carlos Garcia Campos.
Write the results of the tests in json format when the option --json-output
is passed to run-gtk-tests or run-wpe-tests. Use the same format than mac's
run-api-tests.
- glib/api_test_runner.py:
(TestRunner.run_tests):
(TestRunner.run_tests.generate_test_list_for_json_output):
(TestRunner):
(add_options):
- 6:45 AM Changeset in webkit [253944] by
-
- 4 edits1 add in trunk/Source/ThirdParty/libwebrtc
Do not build yasm for iOS and iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=205556
<rdar://problem/58159497>
Reviewed by Eric Carlson.
We want to stop compiling yasm for iOS/iOS simulator but we do not have a good way to do so right now.
Instead, compile a dummy main_noop.c for iOS/iOS simulator and build the executable with it.
This executable wil anyway not be used on these platforms.
- Configurations/yasm.xcconfig:
- Source/third_party/yasm/main_noop.c: Added.
(main):
- libwebrtc.xcodeproj/project.pbxproj:
Dec 29, 2019:
- 9:36 PM Changeset in webkit [253943] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] Remove WTF::loadLoadFence from JSFunction::rareData()
https://bugs.webkit.org/show_bug.cgi?id=205625
Reviewed by Mark Lam.
WTF::loadLoadFence() is not necessary when loading FunctionRareData from JSFunction since we ensured that stored FunctionRareData
is already baked by emitting WTF::storeStoreFence().
- runtime/JSFunction.h:
(JSC::JSFunction::rareData const):
(JSC::JSFunction::rareData): Deleted.
- runtime/JSFunctionInlines.h:
(JSC::JSFunction::hasReifiedLength const):
(JSC::JSFunction::hasReifiedName const):
(JSC::JSFunction::areNameAndLengthOriginal):
(JSC::JSFunction::ensureRareDataAndAllocationProfile):
- 8:43 PM Changeset in webkit [253942] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, build fix after r253938
https://bugs.webkit.org/show_bug.cgi?id=205629
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::revert):
- 4:35 PM Changeset in webkit [253941] by
-
- 15 edits in trunk/Source
Tweak the format and comment in the code to support media in GPU process
https://bugs.webkit.org/show_bug.cgi?id=205631
Patch by Peng Liu <Peng Liu> on 2019-12-29
Reviewed by Eric Carlson.
No new tests, no functional change.
Source/WebCore:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::platformLayer const):
(WebCore::MediaPlayerPrivateInterface::timedMetadata const):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata):
Source/WebKit:
- GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::logChannel const):
- GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
- WebProcess/GPU/GPUProcessConnectionInfo.h:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
- WebProcess/GPU/media/MediaPlayerPrivateRemoteIdentifier.h:
- WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:
- WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
- WebProcess/GPU/media/RemoteMediaPlayerManager.messages.in:
- WebProcess/GPU/media/RemoteMediaPlayerState.h:
- 1:55 PM Changeset in webkit [253940] by
-
- 5 edits in trunk/Source
Cleanup media IPC encoders
https://bugs.webkit.org/show_bug.cgi?id=205630
<rdar://problem/58232173>
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests, no functional change.
- platform/graphics/MediaPlayer.h:
(WebCore::MediaEngineSupportParameters::decode):
Source/WebKit:
- GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
(WebKit::RemoteMediaPlayerProxyConfiguration::decode):
- WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:
(WebKit::RemoteMediaPlayerConfiguration::decode):
- 1:43 PM Changeset in webkit [253939] by
-
- 35 edits2 adds2 deletes in trunk
[WebGL] Add a pure virtual base class for GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=205604
Reviewed by Sam Weinig.
Source/WebCore:
This is the first step in a series of patches to allow multiple versions
of GraphicsContext3D to exist, each using a different backend rendering
system. I've added a GraphicsContext3DBase class (that will eventually
be named GraphicsContext3D) holding all the WebGL entry points as well
as some common helper functions.
I also took the chance to move some enums into enum classes, which
makes it more obvious where things come from. I also removed some
unused interfaces: WebGLRenderingContextErrorMessageCallback and
WebGLRenderingContextLostMessageCallback.
The existing GraphicsContext3D now inherits from the base class,
but is otherwise nearly identical. The next step will be to make
different instances rather than the mix of #if macros we have now.
The virtual functions are marked "override" for now, but will become
"final" in the instances.
There should be no change in functionality.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::cacheActiveAttribLocations):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::destroyGraphicsContext3D):
(WebCore::WebGLRenderingContextBase::getActiveAttrib):
(WebCore::WebGLRenderingContextBase::getActiveUniform):
(WebCore::WebGLRenderingContextBase::getContextAttributes):
(WebCore::WebGLRenderingContextBase::getUniformLocation):
(WebCore::WebGLRenderingContextBase::texImage2DImpl):
(WebCore::WebGLRenderingContextBase::texSubImage2DImpl):
(WebCore::WebGLRenderingContextBase::texSubImage2D):
(WebCore::WebGLRenderingContextBase::texImage2D):
(WebCore::WebGLRenderingContextBase::isTexInternalFormatColorBufferCombinationValid):
(WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback): Deleted.
(WebCore::WebGLRenderingContextErrorMessageCallback::WebGLRenderingContextErrorMessageCallback): Deleted.
- html/canvas/WebGLRenderingContextBase.h:
- platform/graphics/FormatConverter.cpp:
(WebCore::uint8_t>):
(WebCore::float>):
(WebCore::uint16_t>):
(WebCore::FormatConverter::convert):
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::ImageExtractor):
(WebCore::GraphicsContext3D::extractImageData):
(WebCore::GraphicsContext3D::extractTextureData):
(WebCore::TexelBytesForFormat):
(WebCore::GraphicsContext3D::packPixels):
(WebCore::GraphicsContext3D::getClearBitsByAttachmentType): Deleted.
(WebCore::GraphicsContext3D::getClearBitsByFormat): Deleted.
(WebCore::GraphicsContext3D::getChannelBitsByFormat): Deleted.
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::ImageExtractor::imageHtmlDomSource):
(WebCore::GraphicsContext3D::platformGraphicsContext3D const): Deleted.
(WebCore::GraphicsContext3D::platformTexture const): Deleted.
(WebCore::GraphicsContext3D::platformLayer const): Deleted.
(WebCore::GraphicsContext3D::hasAlpha): Deleted.
(WebCore::GraphicsContext3D::hasColor): Deleted.
(WebCore::GraphicsContext3D::srcFormatComesFromDOMElementOrImageData): Deleted.
- platform/graphics/GraphicsTypes3D.h:
- platform/graphics/angle/GraphicsContext3DANGLE.cpp:
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::attachDepthAndStencilBufferIfNeeded):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::validateDepthStencil):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::getContextAttributes): Deleted.
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::getSourceDataFormat):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/cocoa/GraphicsContext3DCocoa.mm:
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::createShared):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::setRenderbufferStorageFromDrawable):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::checkGPUStatus):
(WebCore::GraphicsContext3D::presentRenderbuffer):
(WebCore::GraphicsContext3D::texImageIOSurface2D):
(WebCore::GraphicsContext3D::allocateIOSurfaceBackingStore):
(WebCore::GraphicsContext3D::updateCGLContext):
(WebCore::GraphicsContext3D::screenDidChange):
(WebCore::GraphicsContext3D::setContextLostCallback): Deleted.
(WebCore::GraphicsContext3D::setErrorMessageCallback): Deleted.
- platform/graphics/cocoa/WebGLLayer.mm:
(-[WebGLLayer initWithGraphicsContext3D:]):
(-[WebGLLayer copyImageSnapshotWithColorSpace:]):
(-[WebGLLayer bindFramebufferToNextAvailableSurface]):
- platform/graphics/cv/TextureCacheCV.mm:
(WebCore::TextureCacheCV::create):
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::attachDepthAndStencilBufferIfNeeded):
(WebCore::GraphicsContext3D::readPixels):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::validateDepthStencil):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::getContextAttributes): Deleted.
LayoutTests:
Remove a test that has existing coverage in the WebGL test suite.
- fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
- fast/canvas/webgl/framebuffer-object-attachment.html: Removed.
- 11:33 AM Changeset in webkit [253938] by
-
- 3 edits in trunk/Source/WebCore
[LFC][IFC] Implement LineBuilder::revert
https://bugs.webkit.org/show_bug.cgi?id=205629
<rdar://problem/58231425>
Reviewed by Antti Koivisto.
LineBuilder::revert simply removes trailing runs, shrinks the line and rebuilds the collapsible content.
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::HangingContent::width const):
(WebCore::Layout::HangingContent::isConditional const):
(WebCore::Layout::HangingContent::setIsConditional):
(WebCore::Layout::HangingContent::expand):
(WebCore::Layout::HangingContent::reset):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::revert):
(WebCore::Layout::LineBuilder::alignHorizontally):
(WebCore::Layout::LineBuilder::collectHangingContent):
- layout/inlineformatting/InlineLineBuilder.h:
(WebCore::Layout::LineBuilder::InlineItemRun::operator== const):
(WebCore::Layout::LineBuilder::InlineItemRun::operator!= const):
(WebCore::Layout::LineBuilder::HangingContent::width const): Deleted. Remove m_hangingContent so that revert does not need to deal with it.
(WebCore::Layout::LineBuilder::HangingContent::isConditional const): Deleted.
(WebCore::Layout::LineBuilder::HangingContent::setIsConditional): Deleted.
(WebCore::Layout::LineBuilder::HangingContent::expand): Deleted.
(WebCore::Layout::LineBuilder::HangingContent::reset): Deleted.
- 10:28 AM Changeset in webkit [253937] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Add LineBreaker::Result::Revert to indicate an earlier line wrap opportunity
https://bugs.webkit.org/show_bug.cgi?id=205623
<rdar://problem/58228339>
Reviewed by Antti Koivisto.
See webkit.org/b/205613 for more info.
- layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::LineBreaker::Result::Result):
(WebCore::Layout::LineBreaker::tryWrappingInlineContent const):
- layout/inlineformatting/InlineLineBreaker.h:
- layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::LineLayoutContext::checkForLineWrapAndCommit):
- 9:38 AM Changeset in webkit [253936] by
-
- 2 edits in trunk/Source/WebCore
Make RuleSet refcounted
https://bugs.webkit.org/show_bug.cgi?id=205628
<rdar://problem/58231798>
Unreviewed folloup.
- style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::loadFullDefaultStyle):
Use deref instead of delete.
- 9:18 AM Changeset in webkit [253935] by
-
- 10 edits in trunk/Source/WebCore
Make RuleSet refcounted
https://bugs.webkit.org/show_bug.cgi?id=205628
Reviewed by Zalan Bujtas.
For safety, and to support shared ownership.
Also convert a bunch of places that use raw RuleSet pointers to use Ref/RefPtr instead.
- style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::collectMatchingAuthorRules):
(WebCore::Style::ElementRuleCollector::collectSlottedPseudoElementRulesForSlot):
(WebCore::Style::ElementRuleCollector::matchUserRules):
- style/ElementRuleCollector.h:
- style/RuleSet.cpp:
(WebCore::Style::RuleSet::evaluteDynamicMediaQueryRules):
- style/RuleSet.h:
(WebCore::Style::RuleSet::create):
(WebCore::Style::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair): Deleted.
- style/StyleInvalidator.cpp:
(WebCore::Style::Invalidator::Invalidator):
(WebCore::Style::Invalidator::collectRuleInformation):
(WebCore::Style::Invalidator::invalidateIfNeeded):
(WebCore::Style::Invalidator::addToMatchElementRuleSets):
- style/StyleInvalidator.h:
- style/StyleScopeRuleSets.cpp:
(WebCore::Style::ScopeRuleSets::ScopeRuleSets):
(WebCore::Style::ScopeRuleSets::updateUserAgentMediaQueryStyleIfNeeded const):
(WebCore::Style::ScopeRuleSets::initializeUserStyle):
(WebCore::Style::makeRuleSet):
(WebCore::Style::ScopeRuleSets::resetAuthorStyle):
(WebCore::Style::ensureInvalidationRuleSets):
- style/StyleScopeRuleSets.h:
(WebCore::Style::ScopeRuleSets::authorStyle const):
- style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::loadFullDefaultStyle):
(WebCore::Style::UserAgentStyle::loadSimpleDefaultStyle):
- 7:59 AM Changeset in webkit [253934] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Move soft wrap opportunity code out of LineBreaker
https://bugs.webkit.org/show_bug.cgi?id=205621
<rdar://problem/58227670>
Reviewed by Antti Koivisto.
Let's not mix soft and line wrap opportunity logic.
- layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::ContinousContent::runs const):
(WebCore::Layout::ContinousContent::isEmpty const):
(WebCore::Layout::ContinousContent::size const):
(WebCore::Layout::ContinousContent::width const):
(WebCore::Layout::ContinousContent::nonCollapsibleWidth const):
(WebCore::Layout::ContinousContent::hasTrailingCollapsibleContent const):
(WebCore::Layout::ContinousContent::isTrailingContentFullyCollapsible const):
(WebCore::Layout::LineBreaker::wrapTextContent const):
(WebCore::Layout::ContinousContent::ContinousContent):
(WebCore::Layout::ContinousContent::hasTextContentOnly const):
(WebCore::Layout::ContinousContent::isVisuallyEmptyWhitespaceContentOnly const):
(WebCore::Layout::ContinousContent::firstTextRunIndex const):
(WebCore::Layout::ContinousContent::lastContentRunIndex const):
(WebCore::Layout::ContinousContent::hasNonContentRunsOnly const):
(WebCore::Layout::ContinousContent::lastWrapOpportunityIndex const):
(WebCore::Layout::ContinousContent::TrailingCollapsibleContent::reset):
(WebCore::Layout::endsWithSoftWrapOpportunity): Deleted.
(WebCore::Layout::isAtSoftWrapOpportunity): Deleted.
(WebCore::Layout::LineBreaker::nextWrapOpportunity): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::ContinousContent): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::hasTextContentOnly const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::isVisuallyEmptyWhitespaceContentOnly const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::firstTextRunIndex const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::lastContentRunIndex const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::hasNonContentRunsOnly const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::lastWrapOpportunityIndex const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::TrailingCollapsibleContent::reset): Deleted.
- layout/inlineformatting/InlineLineBreaker.h:
(WebCore::Layout::LineBreaker::ContinousContent::runs const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::isEmpty const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::size const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::width const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::nonCollapsibleWidth const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::hasTrailingCollapsibleContent const): Deleted.
(WebCore::Layout::LineBreaker::ContinousContent::isTrailingContentFullyCollapsible const): Deleted.
- layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::endsWithSoftWrapOpportunity):
(WebCore::Layout::isAtSoftWrapOpportunity):
(WebCore::Layout::nextWrapOpportunity):
(WebCore::Layout::LineLayoutContext::nextContentForLine):
