Context Navigation

← Previous Period
Next Period →

Timeline

Jan 4, 2020:

9:09 PM Changeset in webkit [254037] by Alexey Shvayka

4 edits in trunk

JSON.parse should initialize wrapper object with DefineOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=205767

Reviewed by Darin Adler.

JSTests:

test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This patch makes JSON.parse use DefineOwnProperty instead of Set to initialize wrapper object,
aligning JSC with the spec (step 7.c of https://tc39.es/ecma262/#sec-json.parse) and other engines.
Performing Set was observable by a setter on Object.prototype (with empty String key).
Also removes two extra exceptions checks.

runtime/JSONObject.cpp:

(JSC::Stringifier::stringify):
(JSC::Walker::walk):

2:35 PM Changeset in webkit [254036] by dino@apple.com

13 edits in trunk/Source

Add support for iOS Simulator to ANGLE backend for WebGL
https://bugs.webkit.org/show_bug.cgi?id=205618

Source/ThirdParty/ANGLE:

Extend EGL_ANGLE_iosurface_client_buffer extension to require use
of TEXTURE_2D target on iOS, and to provide read/write usage hints
for the pbuffer created from the IOSurface.

Emulate missing [EAGLContext texImageIOSurface:...] via texture
upload in eglBindTexImage and readback in eglReleaseTexImage.

These changes will be upstreamed in
https://bugs.chromium.org/p/angleproject/issues/detail?id=4256 .

Patch by Kenneth Russell <kbr@chromium.org> on 2020-01-04
Reviewed by Dean Jackson.

extensions/EGL_ANGLE_iosurface_client_buffer.txt:
include/EGL/eglext_angle.h:
src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:

(rx::DisplayEAGL::initialize):

src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.h:
src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:

(rx::IOSurfaceSurfaceEAGL::IOSurfaceSurfaceEAGL):
(rx::IOSurfaceSurfaceEAGL::bindTexImage):
(rx::IOSurfaceSurfaceEAGL::releaseTexImage):
(rx::IOSurfaceSurfaceEAGL::validateAttributes):
(rx::IOSurfaceSurfaceEAGL::createDefaultFramebuffer):
(rx::IOSurfaceSurfaceEAGL::getIOSurfaceLockOptions const):

src/libANGLE/validationEGL.cpp:

(egl::ValidateCreatePbufferFromClientBuffer):

Source/WebCore:

Refactor use of EGL_ANGLE_iosurface_client_buffer extension to
uniformly use rectangular textures on macOS, and 2D textures on
iOS, including the simulator. This should make the on-device iOS
code paths more correct as well.

Pass usage hints, only affecting the iOS Simulator, when creating
all pbuffers from IOSurfaces.

This patch does not turn on ANGLE for the iOS Simulator yet; that
will be done in a follow-on patch after more testing.

Covered by the preexisting WebGL conformance suite in the layout
tests.

Patch by Kenneth Russell <kbr@chromium.org> on 2020-01-04
Reviewed by Dean Jackson.

platform/graphics/GraphicsContext3DBase.h:
platform/graphics/angle/GraphicsContext3DANGLE.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):

platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer display]):
(-[WebGLLayer allocateIOSurfaceBackingStoreWithSize:usingAlpha:]):
(-[WebGLLayer bindFramebufferToNextAvailableSurface]):

platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::attachIOSurfaceToTexture):
(WebCore::VideoTextureCopierCV::copyImageToPlatformTexture):

2:31 PM Changeset in webkit [254035] by dino@apple.com

2 edits in trunk/LayoutTests

REGRESSION: [ Mac ] webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205756
<rdar://problem/58309241>

Marking this as Pass Failure.

platform/mac/TestExpectations:

11:07 AM Changeset in webkit [254034] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Adopt updated MouseEvent initializer
https://bugs.webkit.org/show_bug.cgi?id=205765

Patch by Luming Yin <luming_yin@apple.com> on 2020-01-04
Reviewed by Wenson Hsieh.

Adopt updated MouseEvent initializer to fix the iOS build.

dom/ios/MouseEventIOS.cpp:

(WebCore::MouseEvent::create):

dom/ios/PointerEventIOS.cpp:

(WebCore::PointerEvent::PointerEvent):

10:23 AM Changeset in webkit [254033] by Keith Rollin

2 edits in trunk/Source/WebKit

Reformat WebPage logging
https://bugs.webkit.org/show_bug.cgi?id=205705
<rdar://problem/58288704>

Reviewed by Alex Christensen.

Update the format used by WebPage in its RELEASE_LOG logging. Use the
format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:

So, for example:

becomes:

No new tests - no added or changed functionality.

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_overriddenMediaType):
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::freezeLayerTree):
(WebKit::WebPage::unfreezeLayerTree):
(WebKit::WebPage::markLayersVolatile):
(WebKit::WebPage::cancelMarkLayersVolatile):
(WebKit::WebPage::touchEventSync):

6:54 AM Changeset in webkit [254032] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC][IFC] LineBuilder::ContinuousContent::append should return void
https://bugs.webkit.org/show_bug.cgi?id=205760
<rdar://problem/58309948>

Reviewed by Antti Koivisto.

Introduce ContinuousContent::isEligible to make merging logic more clear.

layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::LineBreaker::isContentWrappingAllowed const):
(WebCore::Layout::LineBreaker::shouldKeepEndOfLineWhitespace const):
(WebCore::Layout::LineBreaker::shouldWrapInlineContent):
(WebCore::Layout::LineBreaker::tryWrappingInlineContent const):
(WebCore::Layout::ContinuousContent::ContinuousContent):
(WebCore::Layout::ContinuousContent::hasTextContentOnly const):
(WebCore::Layout::ContinuousContent::isVisuallyEmptyWhitespaceContentOnly const):
(WebCore::Layout::ContinuousContent::firstTextRunIndex const):
(WebCore::Layout::ContinuousContent::lastContentRunIndex const):
(WebCore::Layout::ContinuousContent::hasNonContentRunsOnly const):
(WebCore::Layout::ContinuousContent::lastWrapOpportunityIndex const):
(WebCore::Layout::ContinuousContent::TrailingCollapsibleContent::reset):
(WebCore::Layout::ContinousContent::runs const): Deleted.
(WebCore::Layout::ContinousContent::isEmpty const): Deleted.
(WebCore::Layout::ContinousContent::size const): Deleted.
(WebCore::Layout::ContinousContent::width const): Deleted.
(WebCore::Layout::ContinousContent::nonCollapsibleWidth const): Deleted.
(WebCore::Layout::ContinousContent::hasTrailingCollapsibleContent const): Deleted.
(WebCore::Layout::ContinousContent::isTrailingContentFullyCollapsible const): Deleted.
(WebCore::Layout::ContinousContent::ContinousContent): Deleted.
(WebCore::Layout::ContinousContent::hasTextContentOnly const): Deleted.
(WebCore::Layout::ContinousContent::isVisuallyEmptyWhitespaceContentOnly const): Deleted.
(WebCore::Layout::ContinousContent::firstTextRunIndex const): Deleted.
(WebCore::Layout::ContinousContent::lastContentRunIndex const): Deleted.
(WebCore::Layout::ContinousContent::hasNonContentRunsOnly const): Deleted.
(WebCore::Layout::ContinousContent::lastWrapOpportunityIndex const): Deleted.
(WebCore::Layout::ContinousContent::TrailingCollapsibleContent::reset): Deleted.

layout/inlineformatting/InlineLineBreaker.h:
layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::ContinuousContent::isContinuous):
(WebCore::Layout::LineBuilder::ContinuousContent::canBeExpanded):
(WebCore::Layout::LineBuilder::ContinuousContent::ContinuousContent):
(WebCore::Layout::LineBuilder::ContinuousContent::append):
(WebCore::Layout::LineBuilder::ContinuousContent::close):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::ContinousContent::canBeExpanded): Deleted.
(WebCore::Layout::LineBuilder::ContinousContent::canBeMerged const): Deleted.
(WebCore::Layout::LineBuilder::ContinousContent::ContinousContent): Deleted.
(WebCore::Layout::LineBuilder::ContinousContent::append): Deleted.
(WebCore::Layout::LineBuilder::ContinousContent::close): Deleted.

layout/inlineformatting/InlineLineBuilder.h:

Jan 3, 2020:

11:57 PM Changeset in webkit [254031] by commit-queue@webkit.org

12 edits
1 add in trunk

Make text track loading set same-origin fallback flag
https://bugs.webkit.org/show_bug.cgi?id=205744

Patch by Rob Buis <rbuis@igalia.com> on 2020-01-03
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Adjust test result to new behavior for text track loading.

web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/cloneNode-expected.txt:
web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-data-url-expected.txt:
web-platform-tests/service-workers/service-worker/webvtt-cross-origin.https-expected.txt:

Source/WebCore:

Make text track loading set same-origin fallback flag,
which changes text track loading to be same-origin
when the crossorigin attribute is not specified.

The new behavior matches that of Chrome and Firefox.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:create-a-potential-cors-request

Tests: http/tests/security/text-track-crossorigin.html

loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

LayoutTests:

Adjusts test to same-origin fallback behavior for text track
loading by using CORS.

http/tests/security/contentSecurityPolicy/resources/track.php: Added.
http/tests/security/contentSecurityPolicy/track-redirect-allowed.html:
http/tests/security/contentSecurityPolicy/track-redirect-allowed2.html:
http/tests/security/contentSecurityPolicy/track-redirect-blocked.html:
http/tests/security/text-track-crossorigin-expected.txt:
http/tests/security/text-track-crossorigin.html:

11:28 PM Changeset in webkit [254030] by sihui_liu@apple.com

4 edits in trunk/Source/WebCore

IndexedDB: delete index records with ID and IndexKey instead of value in SQLiteIDBackingStore
https://bugs.webkit.org/show_bug.cgi?id=205413

Reviewed by Alex Christensen.

Since we have created an index on key in the IndexRecords table, we should do the deletion by its key, because
looking up a record by index column(s) should be faster than non-index column(s).

This change makes PerformanceTests/IndexedDB/basic/index-cursor-delete.html about 100% faster.

No behavior change.

Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteOneIndexRecord):

Modules/indexeddb/server/SQLiteIDBBackingStore.h:
Modules/indexeddb/shared/IDBDatabaseInfo.h:

(WebCore::IDBDatabaseInfo::objectStoreMap const):

11:05 PM Changeset in webkit [254029] by Chris Dumez

35 edits
3 adds in trunk

Add support for DragEvent
https://bugs.webkit.org/show_bug.cgi?id=205758

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt:

Source/WebCore:

Add support for DragEvent:

https://html.spec.whatwg.org/multipage/dnd.html#the-dragevent-interface

Both Blink and Gecko support it. In WebKit, we had no DragEvent and we had added the
dataTransfer attribute to MouseEvent instead.

No new tests, updated / rebaselined existing tests.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::createEvent):

dom/DragEvent.cpp: Added.

(WebCore::DragEvent::create):
(WebCore::DragEvent::createForBindings):
(WebCore::DragEvent::DragEvent):
(WebCore::DragEvent::eventInterface const):

dom/DragEvent.h: Added.

(WebCore::DragEvent::dataTransfer const):

dom/DragEvent.idl: Added.
dom/EventNames.in:
dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::initMouseEvent):

dom/MouseEvent.h:
dom/MouseEvent.idl:
dom/SimulatedClick.cpp:
dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):

Source/WebKit:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):

Source/WebKitLegacy/ios:

WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

Source/WebKitLegacy/mac:

WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

LayoutTests:

Extend test coverage.

editing/pasteboard/can-read-in-dragstart-event-expected.txt:
editing/pasteboard/can-read-in-dragstart-event.html:
editing/pasteboard/data-transfer-is-unique-for-dragenter-and-dragleave-expected.txt:
editing/pasteboard/data-transfer-is-unique-for-dragenter-and-dragleave.html:
fast/events/constructors/mouse-event-constructor-expected.txt:
fast/events/constructors/mouse-event-constructor.html:
fast/events/init-events-expected.txt:
fast/events/init-events.html:
platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

7:01 PM Changeset in webkit [254028] by sihui_liu@apple.com

2 edits in trunk/Source/WebCore

Crash in com.apple.WebKit.Networking at UniqueIDBDatabase::performCurrentOpenOperation
https://bugs.webkit.org/show_bug.cgi?id=205742

Reviewed by Maciej Stachowiak.

m_databaseInfo may not be set in performCurrentOpenOperation if there is an error in opening backing store, so
we should make an early return to avoid access to m_databaseInfo in this case.

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):

6:44 PM Changeset in webkit [254027] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

IconLoadingClient::getLoadDecisionForIcon() leaks an Objective-C block
https://bugs.webkit.org/show_bug.cgi?id=205750
<rdar://problem/57981723>

Patch by Garrett Davidson <garrett_davidson@apple.com> on 2020-01-03
Reviewed by Wenson Hsieh.

Replace a Block_copy with makeBlockPtr to prevent leaking the ObjC block.

UIProcess/Cocoa/IconLoadingDelegate.mm:

(WebKit::IconLoadingDelegate::IconLoadingClient::getLoadDecisionForIcon):

6:15 PM Changeset in webkit [254026] by stephan.szabo@sony.com

4 edits in trunk/Source/WebCore

[WinCairo] Fixing build after "Add a pure virtual base class for GraphicsContext3D"
https://bugs.webkit.org/show_bug.cgi?id=205743

Reviewed by Don Olmstead.

No new tests, build fix.

platform/graphics/GraphicsContext3DBase.h: Undefine NO_ERROR on win
platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:

Move functions showing up as undefined out of #ifdef block

platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:

Fix some accesses to m_attrs to use contextAttributes()

5:58 PM Changeset in webkit [254025] by timothy_horton@apple.com

9 edits in trunk/Source/WebKit

Crashes under -[WKWebView _addUpdateVisibleContentRectPreCommitHandler]_block_invoke
https://bugs.webkit.org/show_bug.cgi?id=205749
<rdar://problem/56433624>

Reviewed by Simon Fraser.

Implement a speculative fix for a common crash. We believe that this is due to
a mechanism UIKit uses to bounce -dealloc (in our case, of WKWebView and/or WKContentView)
to the main thread when the last reference is dropped on a background thread.
At that point, deallocation has already begun, -retain cannot revive the object,
but -dealloc has not yet been called (because of the nature of this mechanism).

To avoid this, make PageClientImpl -> WKContentView and WKContentView -> WKWebView
weak instead of raw references. This way, we won't even get to _addUpdateVisibleContentRectPreCommitHandler
with a deallocating WKWebView, nor try (and fail) to retain it for later use in the block.

UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::didPerformDictionaryLookup):
(WebKit::PageClientImpl::createValidationBubble):
(WebKit::PageClientImpl::createDataListSuggestionsDropdown):
(WebKit::PageClientImpl::createDrawingView):

UIProcess/ios/WKContentView.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
(-[WKContentView webView]):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:contentInsets:unobscuredRectInScrollViewCoordinates:obscuredInsets:unobscuredSafeAreaInsets:inputViewBounds:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]):
(-[WKContentView _didCommitLayerTree:]):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView _updateLongPressAndHighlightLongPressGestures]):
(-[WKContentView endEditingAndUpdateFocusAppearanceWithReason:]):
(-[WKContentView gestureRecognizerMayPinchToZoomWebView:]):
(-[WKContentView _showAttachmentSheet]):
(-[WKContentView _actionForLongPressFromPositionInformation:]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView pointIsNearMarkedText:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView _stylusSingleTapRecognized:]):
(-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]):
(-[WKContentView _updateInteractionTintColor]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView accessibilityRetrieveSpeakSelectionContent]):
(-[WKContentView requestRectsToEvadeForSelectionCommandsWithCompletionHandler:]):
(-[WKContentView accessoryAutoFill]):
(-[WKContentView _updateAccessory]):
(-[WKContentView _didChangeWebViewEditability]):
(-[WKContentView insertTextSuggestion:]):
(-[WKContentView isScrollableForKeyboardScrollViewAnimator:]):
(-[WKContentView keyboardScrollViewAnimator:distanceForIncrement:inDirection:]):
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
(-[WKContentView addFocusedFormControlOverlay]):
(-[WKContentView presentViewControllerForCurrentFocusedElement]):
(-[WKContentView dismissAllInputViewControllers:]):
(-[WKContentView _showShareSheet:inRect:completionHandler:]):
(-[WKContentView actionSheetAssistant:shareElementWithURL:rect:]):
(-[WKContentView actionSheetAssistant:showCustomSheetForElement:]):
(-[WKContentView dataDetectionContextForPositionInformation:]):
(-[WKContentView actionSheetAssistant:getAlternateURLForImage:completion:]):
(-[WKContentView _didChangeDragInteractionPolicy]):
(-[WKContentView dragLiftDelay]):
(-[WKContentView setupDragAndDropInteractions]):
(-[WKContentView _didPerformDragOperation:]):
(-[WKContentView _dragDestinationActionForDropSession:]):
(-[WKContentView _itemsForBeginningOrAddingToSessionWithRegistrationLists:stagedDragSource:]):
(-[WKContentView _handleDropByInsertingImagePlaceholders:session:]):
(-[WKContentView _dragInteraction:dataOwnerForSession:]):
(-[WKContentView dragInteraction:previewForLiftingItem:session:]):
(-[WKContentView dragInteraction:sessionWillBegin:]):
(-[WKContentView dragInteraction:session:didEndWithOperation:]):
(-[WKContentView dragInteraction:previewForCancellingItem:withDefault:]):
(-[WKContentView _dropInteraction:dataOwnerForSession:]):
(-[WKContentView dropInteraction:sessionDidUpdate:]):
(-[WKContentView dropInteraction:performDrop:]):
(-[WKContentView dismissQuickboardViewControllerAndRevealFocusedFormOverlayIfNecessary:]):
(-[WKContentView viewController:inputContextViewHeightForSize:]):
(-[WKContentView inputContextViewForViewController:]):
(-[WKContentView _registerPreview]):
(-[WKContentView assignLegacyDataForContextMenuInteraction]):
(-[WKContentView _contextMenuInteraction:configurationForMenuAtLocation:completion:]):
(-[WKContentView continueContextMenuInteraction:]):
(-[WKContentView _createTargetedPreviewIfPossible]):
(-[WKContentView contextMenuInteraction:willDisplayMenuForConfiguration:animator:]):
(-[WKContentView contextMenuInteraction:willPerformPreviewActionForMenuWithConfiguration:animator:]):
(-[WKContentView contextMenuInteraction:willEndForConfiguration:animator:]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):
(-[WKContentView _previewItemController:commitPreview:]):
(-[WKContentView _previewItemController:didDismissPreview:committing:]):

5:03 PM Changeset in webkit [254024] by timothy_horton@apple.com

2 edits in trunk/Tools

REGRESSION: 150+ flaky failures on some bots (color mismatches)
https://bugs.webkit.org/show_bug.cgi?id=205755
<rdar://problem/58248136>

Reviewed by Simon Fraser.

DumpRenderTree/mac/LayoutTestHelper.m:

(colorProfileURLForDisplay):
(displayUUIDStrings):
Use CGGetOnlineDisplayList instead of CGGetActiveDisplayList; we want
all attached displays, even if they are sleeping.

4:34 PM Changeset in webkit [254023] by ysuzuki@apple.com

15 edits in trunk/Source/JavaScriptCore

[JSC] MarkedBlock::Handle and BlockDirectory should be shrunk
https://bugs.webkit.org/show_bug.cgi?id=205712

Reviewed by Mark Lam.

This patch shrinks MarkedBlock::Handle and BlockDirectory by leveraging the fact that Vector's size and capacity is unsigned.
In these data structures, we use size_t to hold a index, but this can be converted to unsigned since we guarantee that this
never exceeds unsigned since these numbers are derived from Vector's size / capacity, or index inside MarkedBlock (which is up
to 64KB in some architectures). MarkedBlock::Handle is allocated per MarkedBlock, and in Gmail, it takes 1MB. We can save
some bytes just using unsigned. In addition, this patch removes m_prev and m_next fields in MarkedBlock::Handle since
it is never used.

heap/AtomIndices.h:
heap/BlockDirectory.cpp:

(JSC::BlockDirectory::findBlockForAllocation):
(JSC::BlockDirectory::addBlock):

heap/IsoCellSet.cpp:

(JSC::IsoCellSet::addSlow):
(JSC::IsoCellSet::didResizeBits):
(JSC::IsoCellSet::didRemoveBlock):

heap/IsoCellSet.h:
heap/IsoCellSetInlines.h:

(JSC::IsoCellSet::forEachMarkedCell):
(JSC::IsoCellSet::forEachMarkedCellInParallel):
(JSC::IsoCellSet::forEachLiveCell):

heap/IsoSubspace.cpp:

(JSC::IsoSubspace::didResizeBits):
(JSC::IsoSubspace::didRemoveBlock):

heap/IsoSubspace.h:
heap/LocalAllocator.h:
heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::didAddToDirectory):
(JSC::MarkedBlock::Handle::didRemoveFromDirectory):

heap/MarkedBlock.h:

(JSC::MarkedBlock::Handle::index const):

heap/Subspace.cpp:

(JSC::Subspace::didResizeBits):
(JSC::Subspace::didRemoveBlock):

heap/Subspace.h:

4:29 PM Changeset in webkit [254022] by Chris Dumez

7 edits in trunk

dom/nodes/Document-createElement-namespace.html WPT test is failing
https://bugs.webkit.org/show_bug.cgi?id=205748

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:

Source/WebCore:

dom/nodes/Document-createElement-namespace.html WPT test was failing in WebKit but passing in Blink
and Gecko. The issue was that the MIME type passed to DOMParser.parseFromString() would always be
resolved to "application/xml", no matter which XML MIME type was provided as input (e.g. "text/xml").

No new tests, rebaselined existing test.

dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

LayoutTests:

Unskip test as it does not appear to be flaky locally.

TestExpectations:

4:28 PM Changeset in webkit [254021] by Chris Dumez

4 edits in trunk

Document.createAttribute() should take in a localName, not a qualifiedName
https://bugs.webkit.org/show_bug.cgi?id=205752

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing. This test was failing in WebKit but passing
in Blink & Gecko.

web-platform-tests/dom/nodes/Document-createAttribute-expected.txt:

Source/WebCore:

Document.createAttribute() should take in a localName, not a qualifiedName:

https://dom.spec.whatwg.org/#dom-document-createattribute

Our behavior does not match the DOM specification or other browser engines.

No new tests, rebaselined existing test.

dom/Document.cpp:

(WebCore::Document::createAttribute):

4:13 PM Changeset in webkit [254020] by Truitt Savell

2 edits in trunk/LayoutTests

REGRESSION: [ Mac ] webgl/1.0.3/conformance/textures/texture-upload-size.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=205757

Unreviewed test gardening.

platform/mac/TestExpectations:

3:25 PM Changeset in webkit [254019] by commit-queue@webkit.org

11 edits in trunk

Update the RemoteMediaPlayerManagerProxy::Load XPC message to provide the updated RemoteMediaPlayerConfiguration to the web process
https://bugs.webkit.org/show_bug.cgi?id=205740

Patch by Peng Liu <Peng Liu> on 2020-01-03
Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing tests.

platform/graphics/MediaPlayer.cpp:

Source/WebKit:

GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::load):

GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::load):

GPUProcess/media/RemoteMediaPlayerProxy.h:
WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote::load):

LayoutTests:

gpu-process/TestExpectations:

3:22 PM Changeset in webkit [254018] by Chris Dumez

4 edits in trunk

Align Range.intersectsNode() with the DOM specification
https://bugs.webkit.org/show_bug.cgi?id=205745

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

web-platform-tests/dom/ranges/Range-intersectsNode-2-expected.txt:

Source/WebCore:

Align Range.intersectsNode() with the DOM specification:

https://dom.spec.whatwg.org/#dom-range-intersectsnode

This also aligns our behavior with Chrome 79 and Firefox 71.

No new tests, rebaselined existing test.

dom/Range.cpp:

(WebCore::Range::intersectsNode const):

3:21 PM Changeset in webkit [254017] by keith_miller@apple.com

242 edits
209 adds in trunk

Update test262 tests to commit 157b18d
https://bugs.webkit.org/show_bug.cgi?id=205741

Reviewed by Yusuke Suzuki.

JSTests:

test262/expectations.yaml:
test262/harness/deepEqual.js:

(assert.deepEqual):
(assert.deepEqual.format):
(deepEqual):
(compareEquality):
(compareIf):
(tryCompareStrictEquality):
(tryCompareTypeOfEquality):
(tryCompareToStringTagEquality):
(isOptional):
(compareOptionality):
(isPrimitiveEquatable):
(comparePrimitiveEquality):
(isNaNEquatable):
(compareNaNEquality):
(isObjectEquatable):
(compareObjectEquality):
(isBoxed):
(isValueOfEquatable):
(compareValueOfEquality):
(isToStringEquatable):
(compareToStringEquality):
(isArrayLikeEquatable):
(isStructurallyEquatable):
(isIterableEquatable):
(compareIteratorEquality):
(compareIterableEquality):
(cacheComparison):
(fail):
(setCache):
(getCache):
(assert.deepEqual._compare):

test262/latest-changes-summary.txt:
test262/test/built-ins/AggregateError: Added.
test262/test/built-ins/AggregateError/errors-iterabletolist-failures.js: Added.

(case1.get Symbol):
(case2.get Symbol):
(case3.Symbol.iterator):
(case4.Symbol.iterator):
(case5.Symbol.iterator):
(case6.Symbol.iterator.return.get next):
(case6.Symbol.iterator):
(case7.Symbol.iterator.return.get next):
(case7.Symbol.iterator):
(case8.Symbol.iterator):
(case9.Symbol.iterator):
(case10.Symbol.iterator):
(case11.Symbol.iterator.return.next.return.get done):
(case11.Symbol.iterator):

test262/test/built-ins/AggregateError/errors-iterabletolist.js: Added.

(case1.Symbol.iterator.return.next.return.get value):
(case1.Symbol.iterator):

test262/test/built-ins/AggregateError/length.js: Added.
test262/test/built-ins/AggregateError/message-method-prop-cast.js: Added.

(toString):

test262/test/built-ins/AggregateError/message-method-prop.js: Added.
test262/test/built-ins/AggregateError/message-tostring-abrupt-symbol.js: Added.

(case2.Symbol.toPrimitive):
(case2.toString):
(case2.valueOf):

test262/test/built-ins/AggregateError/message-tostring-abrupt.js: Added.

(case1.Symbol.toPrimitive):
(case1.toString):
(case1.valueOf):
(case2.toString):
(case2.valueOf):
(case3.valueOf):

test262/test/built-ins/AggregateError/message-undefined-no-prop.js: Added.
test262/test/built-ins/AggregateError/name.js: Added.
test262/test/built-ins/AggregateError/newtarget-proto-custom.js: Added.

(newt.new.Proxy):
(newt.new.Proxy.get if):

test262/test/built-ins/AggregateError/newtarget-proto-fallback.js: Added.

(ctor):
(const.value.of.values.get t):

test262/test/built-ins/AggregateError/newtarget-proto.js: Added.
test262/test/built-ins/AggregateError/prop-desc.js: Added.
test262/test/built-ins/AggregateError/proto.js: Added.
test262/test/built-ins/AggregateError/prototype: Added.
test262/test/built-ins/AggregateError/prototype/constructor.js: Added.
test262/test/built-ins/AggregateError/prototype/errors: Added.
test262/test/built-ins/AggregateError/prototype/errors/invoked-as-accessor.js: Added.
test262/test/built-ins/AggregateError/prototype/errors/invoked-as-func.js: Added.
test262/test/built-ins/AggregateError/prototype/errors/length.js: Added.
test262/test/built-ins/AggregateError/prototype/errors/name.js: Added.
test262/test/built-ins/AggregateError/prototype/errors/prop-desc.js: Added.
test262/test/built-ins/AggregateError/prototype/errors/return-from-iterable-errors.js: Added.

(errors.Symbol.iterator.return.next.return.get value):
(errors.Symbol.iterator):

test262/test/built-ins/AggregateError/prototype/errors/return-new-array-from-list.js: Added.
test262/test/built-ins/AggregateError/prototype/errors/this-has-no-typedarrayname-internal.js: Added.
test262/test/built-ins/AggregateError/prototype/errors/this-is-not-object.js: Added.
test262/test/built-ins/AggregateError/prototype/message.js: Added.
test262/test/built-ins/AggregateError/prototype/name.js: Added.
test262/test/built-ins/AggregateError/prototype/prop-desc.js: Added.
test262/test/built-ins/AggregateError/prototype/proto.js: Added.
test262/test/built-ins/Array/prototype/copyWithin/coerced-values-start-change-start.js: Added.

(longDenseArray):
(shorten):

test262/test/built-ins/Array/prototype/copyWithin/coerced-values-start-change-target.js: Added.

(longDenseArray):
(shorten):

test262/test/built-ins/Array/prototype/flatMap/this-value-ctor-object-species-bad-throws.js:
test262/test/built-ins/Atomics/add/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

test262/test/built-ins/Atomics/and/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

test262/test/built-ins/Atomics/compareExchange/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

test262/test/built-ins/Atomics/exchange/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

test262/test/built-ins/Atomics/or/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

test262/test/built-ins/Atomics/store/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

test262/test/built-ins/Atomics/sub/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

test262/test/built-ins/Error/prototype/toString/invalid-receiver.js: Added.

(Symbol.forEach):

test262/test/built-ins/Error/prototype/toString/undefined-props.js: Added.
test262/test/built-ins/FinalizationGroup/prototype/cleanupSome/cleanup-prevented-with-unregister.js:

(emptyCells):
(emptyCells.then):

test262/test/built-ins/FinalizationGroup/prototype/cleanupSome/cleanup-throws-in-callback.js: Added.

(fg.new.FinalizationGroup):
(callback):
(emptyCells):
(emptyCells.then):

test262/test/built-ins/FinalizationGroup/prototype/register/holdings-same-as-target.js:
test262/test/built-ins/FinalizationGroup/prototype/register/return-undefined-register-itself.js:
test262/test/built-ins/FinalizationGroup/prototype/register/unregisterToken-same-as-holdings-and-target.js:
test262/test/built-ins/FinalizationGroup/prototype/unregister/unregister-cleaned-up-cell.js: Added.

(fg.new.FinalizationGroup):
(emptyCells):
(emptyCells.then):

test262/test/built-ins/FinalizationGroup/target-not-callable-throws.js:
test262/test/built-ins/JSON/parse/reviver-array-get-prop-from-prototype.js: Added.
test262/test/built-ins/JSON/parse/reviver-array-non-configurable-prop-create.js: Added.
test262/test/built-ins/JSON/parse/reviver-array-non-configurable-prop-delete.js: Added.
test262/test/built-ins/JSON/parse/reviver-call-order.js: Added.
test262/test/built-ins/JSON/parse/reviver-object-get-prop-from-prototype.js: Added.
test262/test/built-ins/JSON/parse/reviver-object-non-configurable-prop-create.js: Added.
test262/test/built-ins/JSON/parse/reviver-object-non-configurable-prop-delete.js: Added.
test262/test/built-ins/JSON/parse/reviver-wrapper.js: Added.
test262/test/built-ins/JSON/stringify/property-order.js: Added.
test262/test/built-ins/Object/entries/return-order.js: Added.
test262/test/built-ins/Object/freeze/throws-when-false.js: Added.

(preventExtensions):

test262/test/built-ins/Object/getOwnPropertyNames/proxy-invariant-absent-not-configurable-symbol-key.js: Added.

(ownKeys):

test262/test/built-ins/Object/getOwnPropertyNames/proxy-invariant-duplicate-symbol-entry.js: Added.

(ownKeys):

test262/test/built-ins/Object/getOwnPropertyNames/proxy-invariant-not-extensible-absent-symbol-key.js: Added.

(ownKeys):

test262/test/built-ins/Object/getOwnPropertyNames/proxy-invariant-not-extensible-extra-symbol-key.js: Added.

(ownKeys):

test262/test/built-ins/Object/getOwnPropertySymbols/length.js:
test262/test/built-ins/Object/getOwnPropertySymbols/name.js:
test262/test/built-ins/Object/getOwnPropertySymbols/object-contains-symbol-property-with-description.js:
test262/test/built-ins/Object/getOwnPropertySymbols/object-contains-symbol-property-without-description.js:
test262/test/built-ins/Object/getOwnPropertySymbols/proxy-invariant-absent-not-configurable-string-key.js: Added.

(ownKeys):

test262/test/built-ins/Object/getOwnPropertySymbols/proxy-invariant-duplicate-string-entry.js: Added.

(ownKeys):

test262/test/built-ins/Object/getOwnPropertySymbols/proxy-invariant-not-extensible-absent-string-key.js: Added.

(ownKeys):

test262/test/built-ins/Object/getOwnPropertySymbols/proxy-invariant-not-extensible-extra-string-key.js: Added.

(ownKeys):

test262/test/built-ins/Object/keys/proxy-non-enumerable-prop-invariant-2.js:
test262/test/built-ins/Object/keys/proxy-non-enumerable-prop-invariant-3.js: Added.

(ownKeys):

test262/test/built-ins/Object/keys/return-order.js: Added.
test262/test/built-ins/Object/preventExtensions/throws-when-false.js: Added.

(preventExtensions):

test262/test/built-ins/Object/prototype/isPrototypeOf/arg-is-proxy.js: Added.

(handler.allowProxyTraps.getPrototypeOf):

test262/test/built-ins/Object/prototype/isPrototypeOf/builtin.js: Added.
test262/test/built-ins/Object/prototype/isPrototypeOf/length.js: Added.
test262/test/built-ins/Object/prototype/isPrototypeOf/name.js:
test262/test/built-ins/Object/prototype/isPrototypeOf/null-this-and-object-arg-throws.js: Added.
test262/test/built-ins/Object/prototype/isPrototypeOf/null-this-and-primitive-arg-returns-false.js: Added.
test262/test/built-ins/Object/prototype/isPrototypeOf/this-value-is-in-prototype-chain-of-arg.js: Added.

(USER_FACTORY.this.getName):
(USER_FACTORY):
(this.getGrade):
(FORCEDUSER_FACTORY):

test262/test/built-ins/Object/prototype/isPrototypeOf/undefined-this-and-object-arg-throws.js: Added.
test262/test/built-ins/Object/prototype/isPrototypeOf/undefined-this-and-primitive-arg-returns-false.js: Added.
test262/test/built-ins/Object/seal/throws-when-false.js: Added.

(preventExtensions):

test262/test/built-ins/Object/values/return-order.js: Added.
test262/test/built-ins/Proxy/has/call-in-prototype-index.js: Added.

(handler.allowProxyTraps.has):

test262/test/built-ins/Proxy/has/call-in-prototype.js:
test262/test/built-ins/Proxy/ownKeys/call-parameters-object-keys.js:

(handler.ownKeys):

test262/test/built-ins/Proxy/set/call-parameters-prototype-index.js: Added.
test262/test/built-ins/Reflect/preventExtensions/target-is-not-object-throws.js:
test262/test/built-ins/RegExp/match-indices/indices-array-element.js:
test262/test/built-ins/RegExp/match-indices/indices-array-matched.js:
test262/test/built-ins/RegExp/match-indices/indices-array-non-unicode-match.js:
test262/test/built-ins/RegExp/match-indices/indices-array-properties.js:
test262/test/built-ins/RegExp/match-indices/indices-array-unicode-match.js:
test262/test/built-ins/RegExp/match-indices/indices-array-unicode-property-names.js:
test262/test/built-ins/RegExp/match-indices/indices-array-unmatched.js:
test262/test/built-ins/RegExp/match-indices/indices-array.js:
test262/test/built-ins/RegExp/match-indices/indices-groups-object-unmatched.js:
test262/test/built-ins/RegExp/match-indices/indices-groups-object.js:
test262/test/built-ins/RegExp/match-indices/indices-groups-properties.js:
test262/test/built-ins/RegExp/match-indices/indices-property.js:
test262/test/built-ins/String/prototype/replaceAll: Added.
test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024-0x0024.js: Added.
test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024-0x0026.js: Added.
test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024-0x0027.js: Added.
test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024-0x003C.js: Added.
test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024-0x0060.js: Added.
test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024.js: Added.
test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024N.js: Added.
test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024NN.js: Added.
test262/test/built-ins/String/prototype/replaceAll/length.js: Added.
test262/test/built-ins/String/prototype/replaceAll/name.js: Added.
test262/test/built-ins/String/prototype/replaceAll/replaceAll.js: Added.
test262/test/built-ins/String/prototype/replaceAll/replaceValue-call-abrupt.js: Added.

(custom):

test262/test/built-ins/String/prototype/replaceAll/replaceValue-call-each-match-position.js: Added.

(t):
(replaceValue):

test262/test/built-ins/String/prototype/replaceAll/replaceValue-call-matching-empty.js: Added.

(t):
(replaceValue):

test262/test/built-ins/String/prototype/replaceAll/replaceValue-call-skip-no-match.js: Added.

(replaceValue):

test262/test/built-ins/String/prototype/replaceAll/replaceValue-call-tostring-abrupt.js: Added.

(custom):
(symbol):

test262/test/built-ins/String/prototype/replaceAll/replaceValue-fn-skip-toString.js: Added.

(replaceValue):
(value):

test262/test/built-ins/String/prototype/replaceAll/replaceValue-tostring-abrupt.js: Added.

(thisValue.toString):
(searchValue.toString):
(replaceValue.toString):

test262/test/built-ins/String/prototype/replaceAll/replaceValue-value-replaces-string.js: Added.
test262/test/built-ins/String/prototype/replaceAll/replaceValue-value-tostring.js: Added.

(replaceValue.Symbol.toPrimitive):
(replaceValue.toString):
(replaceValue.valueOf):

test262/test/built-ins/String/prototype/replaceAll/searchValue-empty-string-this-empty-string.js: Added.
test262/test/built-ins/String/prototype/replaceAll/searchValue-empty-string.js: Added.
test262/test/built-ins/String/prototype/replaceAll/searchValue-flags-no-g-throws.js: Added.

(poison.toString):

test262/test/built-ins/String/prototype/replaceAll/searchValue-flags-null-undefined-throws.js: Added.

(poison.toString):
(searchValue.get flags):

test262/test/built-ins/String/prototype/replaceAll/searchValue-flags-toString-abrupt.js: Added.

(poison.toString):
(searchValue.toString):
(searchValue.flags.toString):

test262/test/built-ins/String/prototype/replaceAll/searchValue-get-flags-abrupt.js: Added.

(searchValue.get flags):
(poison.toString):

test262/test/built-ins/String/prototype/replaceAll/searchValue-isRegExp-abrupt.js: Added.

(searchValue.get Symbol):
(searchValue.toString):
(poison.toString):

test262/test/built-ins/String/prototype/replaceAll/searchValue-replace-method-abrupt.js: Added.

(poison.toString):
(searchValue.get Symbol):
(searchValue.toString):

test262/test/built-ins/String/prototype/replaceAll/searchValue-replacer-RegExp-call-fn.js: Added.

(RE.prototype.Symbol.replace):
(RE.prototype.toString):
(RE):
(const.t):
(getFn.return.replaceValueFn):
(getFn):

test262/test/built-ins/String/prototype/replaceAll/searchValue-replacer-RegExp-call.js: Added.

(RE.prototype.Symbol.replace):
(RE.prototype.toString):
(RE):

test262/test/built-ins/String/prototype/replaceAll/searchValue-replacer-before-tostring.js: Added.

(value):
(poison.toString):

test262/test/built-ins/String/prototype/replaceAll/searchValue-replacer-call-abrupt.js: Added.

(poison.toString):
(searchValue.Symbol.replace):
(searchValue.toString):

test262/test/built-ins/String/prototype/replaceAll/searchValue-replacer-call.js: Added.

(value):

test262/test/built-ins/String/prototype/replaceAll/searchValue-tostring-abrupt.js: Added.

(poison.toString):
(thisValue.toString):
(searchValue.toString):

test262/test/built-ins/String/prototype/replaceAll/searchValue-tostring-regexp.js: Added.
test262/test/built-ins/String/prototype/replaceAll/this-is-null-throws.js: Added.
test262/test/built-ins/String/prototype/replaceAll/this-is-undefined-throws.js: Added.
test262/test/built-ins/String/prototype/replaceAll/this-tostring-abrupt.js: Added.

(poison.toString):
(thisValue.toString):
(searchValue.toString):

test262/test/built-ins/String/prototype/replaceAll/this-tostring.js: Added.

(thisValue.Symbol.toPrimitive):
(thisValue.toString):
(thisValue.valueOf):

test262/test/built-ins/TypedArray/from/mapfn-is-not-callable.js:
test262/test/built-ins/TypedArray/prototype/slice/BigInt/speciesctor-get-species-custom-ctor-length-throws.js:

(testWithBigIntTypedArrayConstructors):

test262/test/built-ins/TypedArray/prototype/slice/BigInt/speciesctor-get-species-custom-ctor-length.js:

(testWithBigIntTypedArrayConstructors):

test262/test/built-ins/TypedArray/prototype/slice/speciesctor-get-species-custom-ctor-length-throws.js:

(testWithTypedArrayConstructors):

test262/test/built-ins/TypedArray/prototype/slice/speciesctor-get-species-custom-ctor-length.js:

(testWithTypedArrayConstructors):

test262/test/built-ins/TypedArrayConstructors/from/nan-conversion.js:
test262/test/built-ins/TypedArrayConstructors/from/new-instance-from-zero.js:
test262/test/built-ins/TypedArrayConstructors/of/BigInt/inherited.js:

(testWithBigIntTypedArrayConstructors):

test262/test/built-ins/TypedArrayConstructors/of/inherited.js:

(testWithTypedArrayConstructors):

test262/test/built-ins/WeakRef/prototype-from-newtarget-abrupt.js:
test262/test/harness/deepEqual-array.js:
test262/test/harness/deepEqual-circular.js:
test262/test/harness/deepEqual-deep.js:
test262/test/harness/deepEqual-mapset.js:
test262/test/harness/deepEqual-object.js:
test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-dateStyle.js: Added.
test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-default.js: Added.

(locales.forEach):

test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-timeStyle.js: Added.
test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle.js:
test262/test/intl402/DisplayNames: Added.
test262/test/intl402/DisplayNames/ctor-custom-get-prototype-poison-throws.js: Added.

(custom.new.Proxy.new.Function.get if):
(custom.new.Proxy.new.Function):

test262/test/intl402/DisplayNames/ctor-custom-prototype.js: Added.
test262/test/intl402/DisplayNames/ctor-default-prototype.js: Added.
test262/test/intl402/DisplayNames/instance-extensible.js: Added.
test262/test/intl402/DisplayNames/length.js: Added.
test262/test/intl402/DisplayNames/locales-invalid-throws.js: Added.
test262/test/intl402/DisplayNames/locales-length-poison-throws.js: Added.
test262/test/intl402/DisplayNames/locales-length-tolength-throws.js: Added.

(locales.length.valueOf):
(locales.length.Symbol.toPrimitive):
(locales.length.toString):

test262/test/intl402/DisplayNames/locales-symbol-length.js: Added.
test262/test/intl402/DisplayNames/name.js: Added.
test262/test/intl402/DisplayNames/options-fallback-abrupt-throws.js: Added.
test262/test/intl402/DisplayNames/options-fallback-invalid-throws.js: Added.
test262/test/intl402/DisplayNames/options-fallback-toString-abrupt-throws.js: Added.

(options.fallback.toString):
(options.fallback.valueOf):
(options.fallback.Symbol.toPrimitive):

test262/test/intl402/DisplayNames/options-fallback-valid.js: Added.
test262/test/intl402/DisplayNames/options-localeMatcher-abrupt-throws.js: Added.
test262/test/intl402/DisplayNames/options-localeMatcher-invalid-throws.js: Added.
test262/test/intl402/DisplayNames/options-localeMatcher-toString-abrupt-throws.js: Added.

(options.localeMatcher.toString):
(options.localeMatcher.valueOf):
(options.localeMatcher.Symbol.toPrimitive):

test262/test/intl402/DisplayNames/options-localeMatcher-valid.js: Added.
test262/test/intl402/DisplayNames/options-null-throws.js: Added.
test262/test/intl402/DisplayNames/options-random-properties-unchecked.js: Added.
test262/test/intl402/DisplayNames/options-style-abrupt-throws.js: Added.
test262/test/intl402/DisplayNames/options-style-invalid-throws.js: Added.
test262/test/intl402/DisplayNames/options-style-toString-abrupt-throws.js: Added.

(options.style.toString):
(options.style.valueOf):
(options.style.Symbol.toPrimitive):

test262/test/intl402/DisplayNames/options-style-valid.js: Added.
test262/test/intl402/DisplayNames/options-type-abrupt-throws.js: Added.
test262/test/intl402/DisplayNames/options-type-invalid-throws.js: Added.
test262/test/intl402/DisplayNames/options-type-toString-abrupt-throws.js: Added.

(options.type.toString):
(options.type.valueOf):
(options.type.Symbol.toPrimitive):

test262/test/intl402/DisplayNames/options-type-valid.js: Added.
test262/test/intl402/DisplayNames/prop-desc.js: Added.
test262/test/intl402/DisplayNames/proto-from-ctor-realm.js: Added.
test262/test/intl402/DisplayNames/proto.js: Added.
test262/test/intl402/DisplayNames/prototype: Added.
test262/test/intl402/DisplayNames/prototype/Symbol.toStringTag.js: Added.
test262/test/intl402/DisplayNames/prototype/prop-desc.js: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions/default-option-values.js: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions/length.js: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions/name.js: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions/option-fallback.js: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions/option-style.js: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions/option-type.js: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions/prop-desc.js: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions/return-object.js: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions/this-not-object-throws.js: Added.
test262/test/intl402/DisplayNames/prototype/resolvedOptions/this-object-lacks-internal-throws.js: Added.
test262/test/intl402/DisplayNames/undefined-newtarget-throws.js: Added.
test262/test/language/destructuring/binding/syntax/property-list-single-name-bindings.js:
test262/test/language/expressions/addition/bigint-and-number.js:
test262/test/language/expressions/addition/bigint-arithmetic.js:
test262/test/language/expressions/addition/bigint-errors.js:
test262/test/language/expressions/addition/bigint-toprimitive.js:
test262/test/language/expressions/addition/bigint-wrapped-values.js:
test262/test/language/expressions/arrow-function/eval-var-scope-syntax-err.js: Added.

(f.a.eval):

test262/test/language/expressions/arrow-function/scope-param-elem-var-close.js:
test262/test/language/expressions/arrow-function/scope-param-elem-var-open.js:
test262/test/language/expressions/arrow-function/scope-param-rest-elem-var-close.js:
test262/test/language/expressions/arrow-function/scope-param-rest-elem-var-open.js:
test262/test/language/expressions/async-arrow-function/eval-var-scope-syntax-err.js: Added.

(f.async a):
(SyntaxError.then):

test262/test/language/expressions/async-function/named-eval-var-scope-syntax-err.js: Added.

(f.async f):
(f):

test262/test/language/expressions/async-function/nameless-eval-var-scope-syntax-err.js: Added.
test262/test/language/expressions/async-generator/eval-var-scope-syntax-err.js: Added.
test262/test/language/expressions/async-generator/named-eval-var-scope-syntax-err.js: Added.

(f.async g):
(f):

test262/test/language/expressions/bitwise-and/bigint-and-number.js:
test262/test/language/expressions/bitwise-and/bigint-errors.js:
test262/test/language/expressions/bitwise-and/bigint-non-primitive.js:
test262/test/language/expressions/bitwise-and/bigint-toprimitive.js:
test262/test/language/expressions/bitwise-and/bigint-wrapped-values.js:
test262/test/language/expressions/bitwise-not/bigint-non-primitive.js:
test262/test/language/expressions/bitwise-or/bigint-and-number.js:
test262/test/language/expressions/bitwise-or/bigint-errors.js:
test262/test/language/expressions/bitwise-or/bigint-non-primitive.js:
test262/test/language/expressions/bitwise-or/bigint-toprimitive.js:
test262/test/language/expressions/bitwise-or/bigint-wrapped-values.js:
test262/test/language/expressions/bitwise-xor/bigint-and-number.js:
test262/test/language/expressions/bitwise-xor/bigint-errors.js:
test262/test/language/expressions/bitwise-xor/bigint-non-primitive.js:
test262/test/language/expressions/bitwise-xor/bigint-toprimitive.js:
test262/test/language/expressions/bitwise-xor/bigint-wrapped-values.js:
test262/test/language/expressions/class/async-gen-method-static/eval-var-scope-syntax-err.js: Added.

(C):

test262/test/language/expressions/class/async-gen-method/eval-var-scope-syntax-err.js: Added.

(C):

test262/test/language/expressions/class/async-method-static/eval-var-scope-syntax-err.js: Added.

(C):
(then):

test262/test/language/expressions/class/async-method/eval-var-scope-syntax-err.js: Added.

(C):
(SyntaxError.then):

test262/test/language/expressions/class/elements/syntax/early-errors/grammar-private-field-optional-chaining.js: Added.

(C.prototype.access):

test262/test/language/expressions/class/gen-method-static/eval-var-scope-syntax-err.js: Added.

(C):

test262/test/language/expressions/class/gen-method/eval-var-scope-syntax-err.js: Added.

(C):

test262/test/language/expressions/class/method-static/eval-var-scope-syntax-err.js: Added.

(C):

test262/test/language/expressions/class/method/eval-var-scope-syntax-err.js: Added.

(C):

test262/test/language/expressions/coalesce/cannot-chain-head-with-logical-and.js:
test262/test/language/expressions/coalesce/cannot-chain-head-with-logical-or.js:
test262/test/language/expressions/coalesce/cannot-chain-tail-with-logical-and.js:
test262/test/language/expressions/coalesce/cannot-chain-tail-with-logical-or.js:
test262/test/language/expressions/delete/super-property.js:

(C):

test262/test/language/expressions/division/bigint-and-number.js:
test262/test/language/expressions/division/bigint-arithmetic.js:
test262/test/language/expressions/division/bigint-complex-infinity.js:
test262/test/language/expressions/division/bigint-errors.js:
test262/test/language/expressions/division/bigint-toprimitive.js:
test262/test/language/expressions/division/bigint-wrapped-values.js:
test262/test/language/expressions/does-not-equals/bigint-and-bigint.js:
test262/test/language/expressions/does-not-equals/bigint-and-boolean.js:
test262/test/language/expressions/does-not-equals/bigint-and-incomparable-primitive.js:
test262/test/language/expressions/does-not-equals/bigint-and-non-finite.js:
test262/test/language/expressions/does-not-equals/bigint-and-number-extremes.js:
test262/test/language/expressions/does-not-equals/bigint-and-number.js:
test262/test/language/expressions/does-not-equals/bigint-and-object.js:
test262/test/language/expressions/does-not-equals/bigint-and-string.js:
test262/test/language/expressions/equals/bigint-and-bigint.js:
test262/test/language/expressions/equals/bigint-and-boolean.js:
test262/test/language/expressions/equals/bigint-and-incomparable-primitive.js:
test262/test/language/expressions/equals/bigint-and-non-finite.js:
test262/test/language/expressions/equals/bigint-and-number-extremes.js:
test262/test/language/expressions/equals/bigint-and-number.js:
test262/test/language/expressions/equals/bigint-and-object.js:
test262/test/language/expressions/equals/bigint-and-string.js:
test262/test/language/expressions/exponentiation/bigint-and-number.js:
test262/test/language/expressions/exponentiation/bigint-arithmetic.js:
test262/test/language/expressions/exponentiation/bigint-errors.js:
test262/test/language/expressions/exponentiation/bigint-negative-exponent-throws.js:
test262/test/language/expressions/exponentiation/bigint-toprimitive.js:
test262/test/language/expressions/exponentiation/bigint-wrapped-values.js:
test262/test/language/expressions/exponentiation/bigint-zero-base-zero-exponent.js:
test262/test/language/expressions/function/eval-var-scope-syntax-err.js: Added.

(f):

test262/test/language/expressions/function/scope-param-elem-var-close.js:
test262/test/language/expressions/function/scope-param-elem-var-open.js:
test262/test/language/expressions/function/scope-param-rest-elem-var-close.js:
test262/test/language/expressions/function/scope-param-rest-elem-var-open.js:
test262/test/language/expressions/generators/eval-var-scope-syntax-err.js: Added.

(f):

test262/test/language/expressions/generators/scope-param-elem-var-close.js:
test262/test/language/expressions/generators/scope-param-elem-var-open.js:
test262/test/language/expressions/generators/scope-param-rest-elem-var-close.js:
test262/test/language/expressions/generators/scope-param-rest-elem-var-open.js:
test262/test/language/expressions/greater-than-or-equal/bigint-and-bigint.js:
test262/test/language/expressions/greater-than-or-equal/bigint-and-incomparable-string.js:
test262/test/language/expressions/greater-than-or-equal/bigint-and-non-finite.js:
test262/test/language/expressions/greater-than-or-equal/bigint-and-number-extremes.js:
test262/test/language/expressions/greater-than-or-equal/bigint-and-number.js:
test262/test/language/expressions/greater-than-or-equal/bigint-and-string.js:
test262/test/language/expressions/greater-than/bigint-and-bigint.js:
test262/test/language/expressions/greater-than/bigint-and-boolean.js:
test262/test/language/expressions/greater-than/bigint-and-incomparable-string.js:
test262/test/language/expressions/greater-than/bigint-and-non-finite.js:
test262/test/language/expressions/greater-than/bigint-and-number-extremes.js:
test262/test/language/expressions/greater-than/bigint-and-number.js:
test262/test/language/expressions/greater-than/bigint-and-symbol.js:
test262/test/language/expressions/left-shift/bigint-and-number.js:
test262/test/language/expressions/left-shift/bigint-errors.js:
test262/test/language/expressions/left-shift/bigint-non-primitive.js:
test262/test/language/expressions/left-shift/bigint-toprimitive.js:
test262/test/language/expressions/left-shift/bigint-wrapped-values.js:
test262/test/language/expressions/less-than-or-equal/bigint-and-bigint.js:
test262/test/language/expressions/less-than-or-equal/bigint-and-incomparable-string.js:
test262/test/language/expressions/less-than-or-equal/bigint-and-non-finite.js:
test262/test/language/expressions/less-than-or-equal/bigint-and-number-extremes.js:
test262/test/language/expressions/less-than-or-equal/bigint-and-number.js:
test262/test/language/expressions/less-than-or-equal/bigint-and-string.js:
test262/test/language/expressions/less-than/bigint-and-bigint.js:
test262/test/language/expressions/less-than/bigint-and-boolean.js:
test262/test/language/expressions/less-than/bigint-and-incomparable-string.js:
test262/test/language/expressions/less-than/bigint-and-non-finite.js:
test262/test/language/expressions/less-than/bigint-and-number-extremes.js:
test262/test/language/expressions/less-than/bigint-and-number.js:
test262/test/language/expressions/modulus/bigint-and-number.js:
test262/test/language/expressions/modulus/bigint-arithmetic.js:
test262/test/language/expressions/modulus/bigint-errors.js:
test262/test/language/expressions/modulus/bigint-modulo-zero.js:
test262/test/language/expressions/modulus/bigint-toprimitive.js:
test262/test/language/expressions/modulus/bigint-wrapped-values.js:
test262/test/language/expressions/multiplication/bigint-and-number.js:
test262/test/language/expressions/multiplication/bigint-arithmetic.js:
test262/test/language/expressions/multiplication/bigint-errors.js:
test262/test/language/expressions/multiplication/bigint-toprimitive.js:
test262/test/language/expressions/multiplication/bigint-wrapped-values.js:
test262/test/language/expressions/object/method-definition/async-gen-meth-eval-var-scope-syntax-err.js: Added.

(obj.async method):

test262/test/language/expressions/object/method-definition/async-meth-eval-var-scope-syntax-err.js: Added.

(obj.async method):
(SyntaxError.then):

test262/test/language/expressions/object/method-definition/gen-meth-eval-var-scope-syntax-err.js: Added.

(obj.method.a.eval):

test262/test/language/expressions/object/method-definition/meth-eval-var-scope-syntax-err.js: Added.

(obj.method.a.eval):

test262/test/language/expressions/object/scope-gen-meth-param-elem-var-close.js:
test262/test/language/expressions/object/scope-gen-meth-param-elem-var-open.js:
test262/test/language/expressions/object/scope-gen-meth-param-rest-elem-var-close.js:
test262/test/language/expressions/object/scope-gen-meth-param-rest-elem-var-open.js:
test262/test/language/expressions/object/scope-meth-param-elem-var-close.js:
test262/test/language/expressions/object/scope-meth-param-elem-var-open.js:
test262/test/language/expressions/object/scope-meth-param-rest-elem-var-close.js:
test262/test/language/expressions/object/scope-meth-param-rest-elem-var-open.js:
test262/test/language/expressions/optional-chaining/iteration-statement-do.js: Added.
test262/test/language/expressions/optional-chaining/iteration-statement-for-await-of.js: Added.

(const.obj.iterable.Symbol.asyncIterator):
(async checkAssertions):

test262/test/language/expressions/optional-chaining/iteration-statement-for-in.js: Added.
test262/test/language/expressions/optional-chaining/iteration-statement-for-of-type-error.js: Added.
test262/test/language/expressions/optional-chaining/iteration-statement-for.js: Added.

(const.obj3.get a):

test262/test/language/expressions/optional-chaining/iteration-statement-while.js: Added.
test262/test/language/expressions/optional-chaining/new-target-optional-call.js: Added.

(const.newTargetContext):
(Base):
(Foo):

test262/test/language/expressions/optional-chaining/optional-call-preserves-this.js: Added.

(const.a.b):

test262/test/language/expressions/optional-chaining/super-property-optional-call.js: Added.

(Base.prototype.method):
(Base):
(Foo.prototype.method):
(Foo):

test262/test/language/expressions/right-shift/bigint-and-number.js:
test262/test/language/expressions/right-shift/bigint-errors.js:
test262/test/language/expressions/right-shift/bigint-non-primitive.js:
test262/test/language/expressions/right-shift/bigint-toprimitive.js:
test262/test/language/expressions/right-shift/bigint-wrapped-values.js:
test262/test/language/expressions/strict-does-not-equals/bigint-and-bigint.js:
test262/test/language/expressions/strict-does-not-equals/bigint-and-boolean.js:
test262/test/language/expressions/strict-does-not-equals/bigint-and-incomparable-primitive.js:
test262/test/language/expressions/strict-does-not-equals/bigint-and-non-finite.js:
test262/test/language/expressions/strict-does-not-equals/bigint-and-number-extremes.js:
test262/test/language/expressions/strict-does-not-equals/bigint-and-number.js:
test262/test/language/expressions/strict-does-not-equals/bigint-and-object.js:
test262/test/language/expressions/strict-does-not-equals/bigint-and-string.js:
test262/test/language/expressions/strict-equals/bigint-and-bigint.js:
test262/test/language/expressions/strict-equals/bigint-and-boolean.js:
test262/test/language/expressions/strict-equals/bigint-and-incomparable-primitive.js:
test262/test/language/expressions/strict-equals/bigint-and-non-finite.js:
test262/test/language/expressions/strict-equals/bigint-and-number-extremes.js:
test262/test/language/expressions/strict-equals/bigint-and-number.js:
test262/test/language/expressions/strict-equals/bigint-and-object.js:
test262/test/language/expressions/strict-equals/bigint-and-string.js:
test262/test/language/expressions/subtraction/bigint-and-number.js:
test262/test/language/expressions/subtraction/bigint-arithmetic.js:
test262/test/language/expressions/subtraction/bigint-errors.js:
test262/test/language/expressions/subtraction/bigint-toprimitive.js:
test262/test/language/expressions/subtraction/bigint-wrapped-values.js:
test262/test/language/expressions/typeof/proxy.js: Added.

(assert.sameValue.typeof.new.Proxy):
(const.rp2.Proxy.revocable):

test262/test/language/expressions/unary-minus/bigint-non-primitive.js:
test262/test/language/expressions/unary-plus/bigint-throws.js:
test262/test/language/expressions/unsigned-right-shift/bigint-and-number.js:
test262/test/language/expressions/unsigned-right-shift/bigint-errors.js:
test262/test/language/expressions/unsigned-right-shift/bigint-non-primitive.js:
test262/test/language/expressions/unsigned-right-shift/bigint-toprimitive.js:
test262/test/language/expressions/unsigned-right-shift/bigint-wrapped-values.js:
test262/test/language/function-code/eval-param-env-with-computed-key.js:
test262/test/language/function-code/eval-param-env-with-prop-initializer.js:
test262/test/language/statements/async-function/eval-var-scope-syntax-err.js: Added.

(async f):
(SyntaxError.then):

test262/test/language/statements/async-generator/eval-var-scope-syntax-err.js: Added.

(async f):

test262/test/language/statements/class/async-gen-method-static/eval-var-scope-syntax-err.js: Added.

(C.async method):
(C):

test262/test/language/statements/class/async-gen-method/eval-var-scope-syntax-err.js: Added.

(C.prototype.async method):
(C):

test262/test/language/statements/class/async-method-static/eval-var-scope-syntax-err.js: Added.

(C.async method):
(C):
(SyntaxError.then):

test262/test/language/statements/class/async-method/eval-var-scope-syntax-err.js: Added.

(C.prototype.async method):
(C):
(SyntaxError.then):

test262/test/language/statements/class/definition/constructable-but-no-prototype.js:
test262/test/language/statements/class/definition/constructor-strict-by-default.js:
test262/test/language/statements/class/definition/getters-restricted-ids.js:
test262/test/language/statements/class/definition/implicit-constructor.js:
test262/test/language/statements/class/definition/invalid-extends.js:
test262/test/language/statements/class/definition/methods-named-eval-arguments.js:
test262/test/language/statements/class/definition/prototype-getter.js:
test262/test/language/statements/class/definition/prototype-property.js:
test262/test/language/statements/class/definition/setters-restricted-ids.js:
test262/test/language/statements/class/definition/side-effects-in-extends.js:
test262/test/language/statements/class/definition/side-effects-in-property-define.js:
test262/test/language/statements/class/definition/this-access-restriction-2.js:
test262/test/language/statements/class/definition/this-access-restriction.js:
test262/test/language/statements/class/definition/this-check-ordering.js:
test262/test/language/statements/class/elements/syntax/early-errors/grammar-private-field-optional-chaining.js: Added.

(C.prototype.access):
(C):

test262/test/language/statements/class/gen-method-static/eval-var-scope-syntax-err.js: Added.

(C.method):
(C):

test262/test/language/statements/class/gen-method/eval-var-scope-syntax-err.js: Added.

(C.prototype.method):
(C):

test262/test/language/statements/class/method-static/eval-var-scope-syntax-err.js: Added.

(C.method):
(C):

test262/test/language/statements/class/method/eval-var-scope-syntax-err.js: Added.

(C.prototype.method):
(C):

test262/test/language/statements/class/name-binding/basic.js:
test262/test/language/statements/class/subclass/binding.js:
test262/test/language/statements/class/subclass/builtin-objects/RegExp/lastIndex.js:
test262/test/language/statements/class/subclass/builtin-objects/String/length.js:
test262/test/language/statements/class/subclass/builtin-objects/WeakMap/regular-subclassing.js:
test262/test/language/statements/class/subclass/builtin-objects/WeakMap/super-must-be-called.js:
test262/test/language/statements/class/subclass/builtin-objects/WeakSet/regular-subclassing.js:
test262/test/language/statements/class/subclass/builtin-objects/WeakSet/super-must-be-called.js:
test262/test/language/statements/class/subclass/builtins.js:
test262/test/language/statements/class/subclass/default-constructor-spread-override.js:
test262/test/language/statements/for-in/identifier-let-allowed-as-lefthandside-expression-not-strict.js:
test262/test/language/statements/for-in/order-enumerable-shadowed.js: Added.
test262/test/language/statements/for-in/order-property-added.js: Added.
test262/test/language/statements/for-in/order-property-on-prototype.js: Added.
test262/test/language/statements/for-in/order-simple-object.js: Added.
test262/test/language/statements/function/eval-var-scope-syntax-err.js: Added.

(f):

test262/test/language/statements/function/scope-param-elem-var-close.js:
test262/test/language/statements/function/scope-param-elem-var-open.js:
test262/test/language/statements/function/scope-param-rest-elem-var-close.js:
test262/test/language/statements/function/scope-param-rest-elem-var-open.js:
test262/test/language/statements/generators/eval-var-scope-syntax-err.js: Added.

(f):

test262/test/language/statements/generators/scope-param-elem-var-close.js:
test262/test/language/statements/generators/scope-param-elem-var-open.js:
test262/test/language/statements/generators/scope-param-rest-elem-var-close.js:
test262/test/language/statements/generators/scope-param-rest-elem-var-open.js:
test262/test262-Revision.txt:

Tools:

Using --save and --latest-import should update expectations rather than overwrite.

Scripts/test262/Runner.pm:

(main):

3:05 PM Changeset in webkit [254016] by Chris Dumez

5 edits in trunk

dispatchEvent() should not clear the event's isTrusted flag when it returns early
https://bugs.webkit.org/show_bug.cgi?id=205731

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

web-platform-tests/dom/events/Event-dispatch-redispatch-expected.txt:

Source/WebCore:

dispatchEvent() should not clear the event's isTrusted flag when it returns early:

https://dom.spec.whatwg.org/#dom-eventtarget-dispatchevent

No new tests, rebaselined existing test.

dom/EventTarget.cpp:

(WebCore::EventTarget::dispatchEventForBindings):

2:30 PM Changeset in webkit [254015] by aestes@apple.com

9 edits in trunk/Source

[Apple Pay] Provide a better error message when Apple Pay blocks user agent script evaluation
https://bugs.webkit.org/show_bug.cgi?id=205730
<rdar://problem/55573484>

Reviewed by Brady Eidson.

Source/WebCore:

Covered by existing API tests.

Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::shouldAllowUserAgentScripts const):

Modules/applepay/PaymentCoordinator.h:
Modules/applepay/PaymentCoordinatorClient.h:

(WebCore::PaymentCoordinatorClient::userAgentScriptsBlockedErrorMessage const):

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::executeUserAgentScriptInWorldInternal):
(WebCore::ScriptController::shouldAllowUserAgentScripts const):

bindings/js/ScriptController.h:

Source/WebKit:

WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::userAgentScriptsBlockedErrorMessage const):

WebProcess/ApplePay/WebPaymentCoordinator.h:

2:18 PM Changeset in webkit [254014] by dino@apple.com

77 edits in trunk

[WebGL] Enable ANGLE by default for Cocoa platforms (except simulator)
https://bugs.webkit.org/show_bug.cgi?id=205483
<rdar://problem/58097701>

Reverting this from trunk (was r253926) due to the number of
flakey tests and failures.

Source/WTF:

wtf/Platform.h:

LayoutTests:

fast/canvas/webgl/array-bounds-clamping-expected.txt:
fast/canvas/webgl/array-bounds-clamping.html:
fast/canvas/webgl/copy-tex-image-and-sub-image-2d-bad-input-expected.txt:
fast/canvas/webgl/draw-elements-out-of-bounds-uint-index-expected.txt:
fast/canvas/webgl/drawElements-empty-vertex-data-expected.txt:
fast/canvas/webgl/oes-texture-half-float-uint16-expected.txt: Removed.
fast/canvas/webgl/oes-texture-half-float-uint16.html: Removed.
fast/canvas/webgl/readPixels-float-expected.txt:
fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies-expected.txt:
fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies.html:
fast/canvas/webgl/vertexAttribPointer-with-bad-offset-expected.txt:
fast/canvas/webgl/webgl-drawarrays-crash-2-expected.txt:
fast/canvas/webgl/webgl-drawarrays-crash-expected.txt:
fast/canvas/webgl/webgl2-texture-upload-enums-expected.txt:
platform/gtk/TestExpectations:
platform/ios-simulator/TestExpectations:
platform/ios/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac/TestExpectations:
webgl/1.0.3/conformance/context/context-lost-restored-expected.txt:
webgl/1.0.3/conformance/extensions/oes-texture-float-expected.txt:
webgl/1.0.3/conformance/extensions/oes-texture-half-float-expected.txt:
webgl/1.0.3/conformance/glsl/misc/shader-struct-scope-expected.txt:
webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words-expected.txt:
webgl/1.0.3/conformance/glsl/misc/shaders-with-invariance-expected.txt:
webgl/1.0.3/conformance/glsl/misc/shaders-with-name-conflicts-expected.txt:
webgl/1.0.3/conformance/misc/webgl-specific-expected.txt:
webgl/1.0.3/conformance/rendering/point-no-attributes-expected.txt:
webgl/1.0.3/conformance/textures/texture-copying-feedback-loops-expected.txt:
webgl/2.0.0/conformance/context/context-lost-restored-expected.txt:
webgl/2.0.0/conformance/extensions/ext-sRGB-expected.txt:
webgl/2.0.0/conformance/extensions/oes-texture-float-expected.txt:
webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt:
webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt:
webgl/2.0.0/conformance/extensions/webgl-depth-texture-expected.txt:
webgl/2.0.0/conformance/extensions/webgl-draw-buffers-framebuffer-unsupported-expected.txt:
webgl/2.0.0/conformance/glsl/misc/shader-struct-scope-expected.txt:
webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt:
webgl/2.0.0/conformance/glsl/misc/shaders-with-name-conflicts-expected.txt:
webgl/2.0.0/conformance/limits/gl-line-width-expected.txt:
webgl/2.0.0/conformance/misc/webgl-specific-expected.txt:
webgl/2.0.0/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002-expected.txt:
webgl/2.0.0/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003-expected.txt:
webgl/2.0.0/conformance/reading/read-pixels-test-expected.txt:
webgl/2.0.0/conformance/rendering/point-no-attributes-expected.txt:
webgl/2.0.0/conformance/textures/misc/cube-incomplete-fbo-expected.txt:
webgl/2.0.0/conformance/textures/misc/texture-copying-feedback-loops-expected.txt:
webgl/2.0.0/conformance2/buffers/get-buffer-sub-data-expected.txt:
webgl/2.0.0/conformance2/buffers/one-large-uniform-buffer-expected.txt:
webgl/2.0.0/conformance2/context/context-attributes-depth-stencil-antialias-obeyed-expected.txt:
webgl/2.0.0/conformance2/extensions/ext-color-buffer-float-expected.txt:
webgl/2.0.0/conformance2/extensions/promoted-extensions-expected.txt:
webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader-expected.txt:
webgl/2.0.0/conformance2/glsl3/shader-linking-expected.txt:
webgl/2.0.0/conformance2/glsl3/shader-with-invalid-characters-expected.txt:
webgl/2.0.0/conformance2/glsl3/shader-with-mis-matching-uniform-block-expected.txt:
webgl/2.0.0/conformance2/glsl3/valid-invariant-expected.txt:
webgl/2.0.0/conformance2/rendering/attrib-type-match-expected.txt:
webgl/2.0.0/conformance2/rendering/blitframebuffer-stencil-only-expected.txt:
webgl/2.0.0/conformance2/rendering/blitframebuffer-test-expected.txt:
webgl/2.0.0/conformance2/rendering/clear-func-buffer-type-match-expected.txt:
webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer-expected.txt:
webgl/2.0.0/conformance2/rendering/clipping-wide-points-expected.txt:
webgl/2.0.0/conformance2/rendering/framebuffer-unsupported-expected.txt:
webgl/2.0.0/conformance2/rendering/fs-color-type-mismatch-color-buffer-type-expected.txt:
webgl/2.0.0/conformance2/rendering/instanced-arrays-expected.txt:
webgl/2.0.0/conformance2/rendering/instanced-rendering-bug-expected.txt:
webgl/2.0.0/conformance2/rendering/rendering-sampling-feedback-loop-expected.txt:
webgl/2.0.0/conformance2/state/gl-get-calls-expected.txt:
webgl/2.0.0/conformance2/textures/misc/copy-texture-image-expected.txt:
webgl/2.0.0/conformance2/textures/misc/tex-image-with-bad-args-expected.txt:
webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels-expected.txt:
webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt:
webgl/2.0.0/conformance2/textures/misc/tex-storage-2d-expected.txt:
webgl/2.0.0/conformance2/textures/misc/texture-npot-expected.txt:
webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object-expected.txt:

2:16 PM Changeset in webkit [254013] by aboya@igalia.com

1 edit
1 add in trunk/LayoutTests/imported/w3c

Unreviewed, add missing expectation file.
https://bugs.webkit.org/show_bug.cgi?id=205728

web-platform-tests/media-source/mediasource-h264-play-starved-expected.txt: Added.

1:54 PM Changeset in webkit [254012] by dino@apple.com

2 edits in trunk/Source/WebKit

Provide pid to crashing service worker process and GPU process
https://bugs.webkit.org/show_bug.cgi?id=205564
<rdar://problem/58300321>

Build fix for TestWebKitAPI.

UIProcess/API/C/WKContext.h:

12:52 PM Changeset in webkit [254011] by Kocsen Chung

8 edits in branches/safari-609.1.13-branch/Source

Versioning.

12:04 PM Changeset in webkit [254010] by ysuzuki@apple.com

34 edits in trunk/Source

Put more WebCore/WebKit JS objects into IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=205711

Reviewed by Keith Miller.

Source/WebCore:

This patch puts more JS objects into IsoSubspace, mainly focusing on JS objects defined manually (not using CodeGeneratorJS.pm).

No behavior change.

bindings/js/JSDOMBuiltinConstructor.h:

(WebCore::JSDOMBuiltinConstructor::JSDOMBuiltinConstructor): Deleted.
(WebCore::JSDOMBuiltinConstructor::initializeProperties): Deleted.

bindings/js/JSDOMBuiltinConstructorBase.cpp:

(WebCore::JSDOMBuiltinConstructorBase::subspaceForImpl):

bindings/js/JSDOMBuiltinConstructorBase.h:

(WebCore::JSDOMBuiltinConstructorBase::subspaceFor):

bindings/js/JSDOMConstructor.h:

(WebCore::JSDOMConstructor::JSDOMConstructor): Deleted.
(WebCore::JSDOMConstructor::initializeProperties): Deleted.

bindings/js/JSDOMConstructorBase.cpp:

(WebCore::JSDOMConstructorBase::subspaceForImpl):

bindings/js/JSDOMConstructorBase.h:

(WebCore::JSDOMConstructorBase::subspaceFor):

bindings/js/JSDOMConstructorNotConstructable.h:

(WebCore::JSDOMConstructorNotConstructable::JSDOMConstructorNotConstructable): Deleted.
(WebCore::JSDOMConstructorNotConstructable::initializeProperties): Deleted.
(WebCore::JSDOMConstructorNotConstructable::callThrowTypeError): Deleted.
(WebCore::JSDOMConstructorNotConstructable::getCallData): Deleted.

bindings/js/JSDOMIterator.h:

(WebCore::JSDOMIteratorPrototype::create): Deleted.
(WebCore::JSDOMIteratorPrototype::createStructure): Deleted.
(WebCore::JSDOMIteratorPrototype::JSDOMIteratorPrototype): Deleted.

bindings/js/JSDOMNamedConstructor.h:

(WebCore::JSDOMNamedConstructor::JSDOMNamedConstructor): Deleted.
(WebCore::JSDOMNamedConstructor::initializeProperties): Deleted.

bindings/js/JSDOMWindowProperties.cpp:

(WebCore::JSDOMWindowProperties::subspaceForImpl):

bindings/js/JSDOMWindowProperties.h:

(WebCore::JSDOMWindowProperties::create): Deleted.
(WebCore::JSDOMWindowProperties::createStructure): Deleted.
(WebCore::JSDOMWindowProperties::JSDOMWindowProperties): Deleted.

bindings/js/JSWindowProxy.cpp:

(WebCore::JSWindowProxy::subspaceForImpl):

bindings/js/JSWindowProxy.h:
bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::JSVMClientData):

bindings/js/WebCoreJSClientData.h:

(WebCore::JSVMClientData::domBuiltinConstructorSpace):
(WebCore::JSVMClientData::domConstructorSpace):
(WebCore::JSVMClientData::domWindowPropertiesSpace):
(WebCore::JSVMClientData::runtimeArraySpace):
(WebCore::JSVMClientData::runtimeObjectSpace):
(WebCore::JSVMClientData::windowProxySpace):

bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create): Deleted.
(JSC::Bindings::CRuntimeObject::createStructure): Deleted.

bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::getMethod):
(JSC::Bindings::CRuntimeMethod::create): Deleted.
(JSC::Bindings::CRuntimeMethod::createStructure): Deleted.
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod): Deleted.
(JSC::Bindings::CRuntimeMethod::finishCreation): Deleted.

bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create): Deleted.
(JSC::Bindings::ObjCRuntimeObject::createStructure): Deleted.

bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::create): Deleted.
(ObjCRuntimeMethod::createStructure): Deleted.
(ObjCRuntimeMethod::ObjCRuntimeMethod): Deleted.
(ObjCRuntimeMethod::finishCreation): Deleted.

bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create): Deleted.
(JSC::Bindings::ObjcFallbackObjectImp::propertyName const): Deleted.
(JSC::Bindings::ObjcFallbackObjectImp::createPrototype): Deleted.
(JSC::Bindings::ObjcFallbackObjectImp::createStructure): Deleted.

bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::subspaceForImpl):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::subspaceForImpl):

bridge/runtime_array.h:

(JSC::RuntimeArray::create): Deleted.
(JSC::RuntimeArray::getLength const): Deleted.
(JSC::RuntimeArray::getConcreteArray const): Deleted.
(JSC::RuntimeArray::createPrototype): Deleted.
(JSC::RuntimeArray::createStructure): Deleted.

bridge/runtime_method.cpp:

(JSC::RuntimeMethod::RuntimeMethod):

bridge/runtime_method.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::subspaceForImpl):

bridge/runtime_object.h:

Source/WebKit:

WebProcess/Plugins/Netscape/JSNPMethod.h:
WebProcess/Plugins/Netscape/JSNPObject.h:

Source/WebKitLegacy/mac:

Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::getMethod):
(WebKit::ProxyRuntimeMethod::create): Deleted.
(WebKit::ProxyRuntimeMethod::createStructure): Deleted.
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): Deleted.
(WebKit::ProxyRuntimeMethod::finishCreation): Deleted.

Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create): Deleted.
(WebKit::ProxyRuntimeObject::createStructure): Deleted.

11:49 AM WebKitGTK/2.26.x edited by Michael Catanzaro

Propose r250743 (diff)

11:04 AM Changeset in webkit [254009] by Simon Fraser

9 edits
9 copies
1 move
18 adds in trunk

Add some shared schemes to the WebKit.xcworkspace
https://bugs.webkit.org/show_bug.cgi?id=205698

Reviewed by Tim Horton.
.:

Make WebKit.xcworkspace show the following schemes by default:

Also remove the MobileMiniBrowserUITests scheme.

WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

Source/JavaScriptCore:

Make WebKit.xcworkspace show the following schemes by default:

Also remove the MobileMiniBrowserUITests scheme.

JavaScriptCore.xcodeproj/xcshareddata/xcschemes/JavaScriptCore.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

Source/WebCore:

Make WebKit.xcworkspace show the following schemes by default:

Also remove the MobileMiniBrowserUITests scheme.

WebCore.xcodeproj/xcshareddata/xcschemes/WebCore.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

Source/WebKit:

Make WebKit.xcworkspace show the following schemes by default:

Also remove the MobileMiniBrowserUITests scheme.

WebKit.xcodeproj/xcshareddata/xcschemes/WebKit.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

Source/WebKitLegacy:

Make WebKit.xcworkspace show the following schemes by default:

Also remove the MobileMiniBrowserUITests scheme.

WebKitLegacy.xcodeproj/xcshareddata/xcschemes/WebKitLegacy.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

Source/WTF:

Make WebKit.xcworkspace show the following schemes by default:

Also remove the MobileMiniBrowserUITests scheme.

WTF.xcodeproj/xcshareddata/xcschemes/WTF.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

Tools:

Make WebKit.xcworkspace show the following schemes by default:

Also remove the MobileMiniBrowserUITests scheme.

DumpRenderTree/DumpRenderTree.xcodeproj/xcshareddata/xcschemes/DumpRenderTree.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
MiniBrowser/MiniBrowser.xcodeproj/xcshareddata/xcschemes/MiniBrowser.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowser.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
WebKitTestRunner/WebKitTestRunner.xcodeproj/xcshareddata/xcschemes/WebKitTestRunner.xcscheme: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

10:35 AM Changeset in webkit [254008] by Wenson Hsieh

2 edits in trunk/LayoutTests

highlight/highlight-world-leak.html frequently times out
https://bugs.webkit.org/show_bug.cgi?id=205643
<rdar://problem/58263350>

Reviewed by Megan Gardner.

The main logic in this test is executed inside a load event handler to a subframe, which is set in a script
element. However, in the case where the subframe finishes loading before we execute the inline script, the test
will never run, since the load event handler won't be called again.

Fix this by waiting for the load event of the page instead.

highlight/highlight-world-leak.html:

10:22 AM Changeset in webkit [254007] by youenn@apple.com

4 edits in trunk

REGRESSION: [iOS 13] webrtc/datachannel/mdns-ice-candidates.html is failing
https://bugs.webkit.org/show_bug.cgi?id=201900
<rdar://problem/55466061>

Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.

Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::registerMDNSName):
Fix message typo (missing space).

LayoutTests:

platform/ios/TestExpectations:

Reenable test.

10:04 AM Changeset in webkit [254006] by youenn@apple.com

11 edits in trunk

Provide pid to crashing service worker process and GPU process
https://bugs.webkit.org/show_bug.cgi?id=205564

Reviewed by Alex Christensen.

Source/WebKit:

No change of behavior, we provide pids to the WKContext callbacks.

UIProcess/API/C/WKContext.h:
UIProcess/API/C/WKContextPrivate.h:
UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::gpuProcessCrashed):

UIProcess/WebContextClient.cpp:

(WebKit::WebContextClient::serviceWorkerProcessDidCrash):
(WebKit::WebContextClient::gpuProcessDidCrash):

UIProcess/WebContextClient.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::serviceWorkerProcessCrashed):
(WebKit::WebProcessPool::gpuProcessCrashed):

UIProcess/WebProcessPool.h:

Tools:

Exposing the pid allows WebKitTestRunner to provide better information.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::serviceWorkerProcessDidCrash):
(WTR::TestController::gpuProcessDidCrash):

WebKitTestRunner/TestController.h:

9:50 AM Changeset in webkit [254005] by commit-queue@webkit.org

10 edits in trunk

Deprecate _WKWebsitePolicies
https://bugs.webkit.org/show_bug.cgi?id=205539

Patch by Alex Christensen <achristensen@webkit.org> on 2020-01-03
Reviewed by Wenson Hsieh.

Source/WebKit:

Its last use was removed in rdar://problem/58064847
but we need to keep it in WebKit until the next Safari release
to keep Safari working with built versions of open source WebKit with run-safari.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateWebsitePolicies:]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/_WKWebsitePolicies.h:
UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

(-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
(-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.

TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[ContentBlockingWebsitePoliciesDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(TEST):
(-[AutoplayPoliciesDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[AsyncAutoplayPoliciesDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
(-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
(-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[WebsitePoliciesWebsiteDataStoreDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
(-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
(-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
(-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.
(-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.
(-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.

9:40 AM Changeset in webkit [254004] by youenn@apple.com

4 edits in trunk

NetworkResourceLoader::didFinishWithRedirectResponse should not assume the load is coming from network
https://bugs.webkit.org/show_bug.cgi?id=205715

Reviewed by Alex Christensen.

Source/WebKit:

Covered by updated test.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFinishWithRedirectResponse):
If redirection is coming from cache, the load is not null.
We just need to use the request URL since the redirection mode is manual.

LayoutTests:

http/wpt/prefetch/link-prefetch-main-resource-redirect.html:

9:29 AM Changeset in webkit [254003] by Chris Dumez

2 edits in trunk/Source/WebKit

Unreviewed, drop new assertion added in r253984 which hits on OpenSource bots

Shared/ios/DependencyProcessAssertionIOS.mm:

(WebKit::DependencyProcessAssertion::DependencyProcessAssertion):

9:24 AM Changeset in webkit [254002] by Chris Dumez

3 edits in trunk/Source

Improve release logging in ServiceWorkerFetchTask
https://bugs.webkit.org/show_bug.cgi?id=205692

Reviewed by Youenn Fablet.

Improve release logging in ServiceWorkerFetchTask to facilitate debugging.

NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::~ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::start):
(WebKit::ServiceWorkerFetchTask::contextClosed):
(WebKit::ServiceWorkerFetchTask::startFetch):
(WebKit::ServiceWorkerFetchTask::didReceiveRedirectResponse):
(WebKit::ServiceWorkerFetchTask::didReceiveResponse):
(WebKit::ServiceWorkerFetchTask::didFinish):
(WebKit::ServiceWorkerFetchTask::didFail):
(WebKit::ServiceWorkerFetchTask::didNotHandle):
(WebKit::ServiceWorkerFetchTask::cannotHandle):
(WebKit::ServiceWorkerFetchTask::cancelFromClient):
(WebKit::ServiceWorkerFetchTask::continueDidReceiveFetchResponse):
(WebKit::ServiceWorkerFetchTask::continueFetchTaskWith):
(WebKit::ServiceWorkerFetchTask::timeoutTimerFired):
(WebKit::ServiceWorkerFetchTask::softUpdateIfNeeded):

8:58 AM Changeset in webkit [254001] by Chris Dumez

15 edits in trunk

Align XPathEvaluator.createNSResolver() / XPathResult.snapshotItem() with the specification
https://bugs.webkit.org/show_bug.cgi?id=205699

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaselined existing test now that more checks are passing.

web-platform-tests/dom/idlharness.window-expected.txt:

Source/WebCore:

Align XPathEvaluator.createNSResolver() / XPathResult.snapshotItem() with the specification and
other browsers (tested Chrome 79 and Firefox 71). In particular, their parameter should not be
optional (or nullable).

No new tests, rebaselined existing test.

dom/Document.cpp:

(WebCore::Document::createNSResolver):

dom/Document.h:
dom/Document.idl:
xml/NativeXPathNSResolver.cpp:

(WebCore::NativeXPathNSResolver::NativeXPathNSResolver):
(WebCore::NativeXPathNSResolver::lookupNamespaceURI):

xml/NativeXPathNSResolver.h:

(WebCore::NativeXPathNSResolver::create):

xml/XPathEvaluator.cpp:

(WebCore::XPathEvaluator::createNSResolver):

xml/XPathEvaluator.h:
xml/XPathEvaluator.idl:
xml/XPathResult.idl:

Source/WebKitLegacy/mac:

DOM/DOMDocument.mm:

(-[DOMDocument createNSResolver:]):

8:19 AM Changeset in webkit [254000] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

Implement "create a potential-CORS request"
https://bugs.webkit.org/show_bug.cgi?id=205326

Patch by Rob Buis <rbuis@igalia.com> on 2020-01-03
Reviewed by Youenn Fablet.

Implement "create a potential-CORS request" [1] and
remove deprecatedSetAsPotentiallyCrossOrigin. Add a
same-origin fallback flag that can be used by clients
of createPotentialAccessControlRequest in the future.

No new tests, no functional change.

bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestScriptWithCache const):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

html/parser/HTMLResourcePreloader.cpp:

(WebCore::PreloadRequest::resourceRequest):

loader/CrossOriginAccessControl.cpp:

(WebCore::createPotentialAccessControlRequest):

loader/CrossOriginAccessControl.h:
loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource):

loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::deprecatedSetAsPotentiallyCrossOrigin): Deleted.

loader/cache/CachedResourceRequest.h:

8:03 AM Changeset in webkit [253999] by Antti Koivisto

3 edits in trunk/Source/WebCore

[LFC][Integration] Enable text-transform:capitalize
https://bugs.webkit.org/show_bug.cgi?id=205721

Reviewed by Zalan Bujtas.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::canUseFor):

Enable.

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::applyTextTransform): Deleted.

No need to do anything, RenderText::text() has already applied text transform.

7:58 AM Changeset in webkit [253998] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/ruby/ruby-justification.html
https://bugs.webkit.org/show_bug.cgi?id=205708
<rdar://problem/58290264>

Reviewed by Antti Koivisto.

Fix last (content) run's trailing expansion behavior.
Pass in float to TextRun instead of LayoutUnit to avoid losing precision.

layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::justifyRuns const):

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):

7:42 AM Changeset in webkit [253997] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/parser/entities-in-html.html
https://bugs.webkit.org/show_bug.cgi?id=205710
<rdar://problem/58290731>

Reviewed by Antti Koivisto.

layout/inlineformatting/InlineTextItem.cpp:

(WebCore::Layout::isWhitespaceCharacter):

6:17 AM Changeset in webkit [253996] by cathiechen

18 edits
16 adds
1 delete in trunk/LayoutTests

Import WPT test cases for apect-ratio generated from attribute width and height
https://bugs.webkit.org/show_bug.cgi?id=205678

Reviewed by Manuel Rego Casasnovas

LayoutTests/imported/w3c:

Import web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/ from WPT.
Also import web-platform-tests/media/ which is needed by video-aspect-ratio.html.
Update video_loop_base-expected.txt, resize-during-playback-expected.txt and wpt-server-http.sub-expected.txt
which include resources in web-platform-tests/media/.

resources/import-expectations.json:
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/align.html:
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/canvas-aspect-ratio-expected.txt:
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/canvas-aspect-ratio.html:
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/content-aspect-ratio-expected.txt: Added.
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/content-aspect-ratio.html: Added.
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio-expected.txt:
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio.html:
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-no-alt-replaced.html:
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-replaced-box-while-loading.html:
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio-expected.txt:
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html:
web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/w3c-import.log:
web-platform-tests/html/semantics/embedded-content/media-elements/video_loop_base-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-video-element/resize-during-playback-expected.txt:
web-platform-tests/infrastructure/server/wpt-server-http.sub-expected.txt:
web-platform-tests/media/1x1-green.png: Added.
web-platform-tests/media/2x2-green.mp4: Added.
web-platform-tests/media/2x2-green.ogv: Added.
web-platform-tests/media/400x300-red-resize-200x150-green.mp4: Added.
web-platform-tests/media/400x300-red-resize-200x150-green.webm: Added.
web-platform-tests/media/META.yml: Added.
web-platform-tests/media/OWNERS: Removed.
web-platform-tests/media/counting.mp4: Added.
web-platform-tests/media/counting.ogv: Added.
web-platform-tests/media/foo-no-cors.vtt: Added.
web-platform-tests/media/sound_0.mp3: Added.
web-platform-tests/media/sound_0.oga: Added.
web-platform-tests/media/test.mp4: Added.
web-platform-tests/media/test.ogv: Added.
web-platform-tests/media/video.ogv: Added.
web-platform-tests/media/w3c-import.log:

LayoutTests:

video-aspect-ratio.html passes the test after importing web-platform-tests/media/

TestExpectations:

5:56 AM Changeset in webkit [253995] by aboya@igalia.com

3 edits
4 adds in trunk

[GStreamer][MSE] Player stalling too soon
https://bugs.webkit.org/show_bug.cgi?id=205117

Reviewed by Xabier Rodriguez-Calvar.

LayoutTests/imported/w3c:

Added the testcase used to report the bug, cleaned and adapted for
WPT.

web-platform-tests/media-source/mediasource-h264-play-starved.html: Added.
web-platform-tests/media-source/mp4/h264-starvation-init.mp4: Added.
web-platform-tests/media-source/mp4/h264-starvation-media.mp4: Added.

Tools:

Backported patch to jhbuild.

Small modifications were necessary to make it apply on 1.16.1.

gstreamer/jhbuild.modules:
gstreamer/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Added.

2:06 AM Changeset in webkit [253994] by sbarati@apple.com

3 edits
1 add in trunk

B3::ReduceLoopStrength should not do range based iteration on a vector it's mutating
https://bugs.webkit.org/show_bug.cgi?id=205703
<rdar://problem/56459483>

Reviewed by Mark Lam.

JSTests:

stress/dont-range-based-iterate-vector-that-is-mutated.js: Added.

(foo):

Source/JavaScriptCore:

B3::ReduceLoopStrength had code that did:
`
for (BasicBlock* pred : loopPostfooter->predecessors())

This is wrong, since it's doing a range based iteration over the vector it is
mutating. The fix is to just do:
`
while (loopPostfooter->predecessors().size())

b3/B3ReduceLoopStrength.cpp:

(JSC::B3::ReduceLoopStrength::reduceByteCopyLoopsToMemcpy):

1:57 AM Changeset in webkit [253993] by youenn@apple.com

2 edits in trunk/Source/WebKit

Fix non-libwebrtc builds after r253957
https://bugs.webkit.org/show_bug.cgi?id=205714

Unreviewed.

GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:

Move the includes inside the compilation guard.

1:41 AM Changeset in webkit [253992] by commit-queue@webkit.org

4 edits
2 adds in trunk

Patch by Rob Buis <rbuis@igalia.com> on 2020-01-03
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Import test for various type attribute values for rel=stylesheet link elements.

web-platform-tests/html/semantics/document-metadata/the-link-element/link-type-attribute-expected.html: Added.
web-platform-tests/html/semantics/document-metadata/the-link-element/link-type-attribute.html: Added.
web-platform-tests/html/semantics/document-metadata/the-link-element/w3c-import.log:

Source/WebCore:

If the UA does not support the given MIME type for the given link
relationship, then the UA should not fetch and process the linked
resource [1].

The behavior matches Chrome and Firefox.

[1] https://html.spec.whatwg.org/multipage/semantics.html#processing-the-type-attribute

Test: imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-type-attribute.html

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

1:20 AM Changeset in webkit [253991] by sbarati@apple.com

5 edits
1 add in trunk

AI rule for PutById can only observe transitions when it watches the condition
https://bugs.webkit.org/show_bug.cgi?id=205697
<rdar://problem/56814254>

Reviewed by Yusuke Suzuki.

JSTests:

stress/only-transition-structures-for-put-by-id-in-AI-if-watchable.js: Added.

Source/JavaScriptCore:

There was a bug in AI where we were capturing a PutByIdStatus and
emitting a structure transition in AI state based on the variants inside this
PutByIdStatus. This, in principal, is a valid static analysis to perform.
However, we can only do this if we ensure that the snapshot we have in the
PutByIdStatus holds at runtime. We can do this by watching the property conditions
for the various variants. AI forgot to watch these conditions. This patch fixes that.
In practice, this also means we need to be slightly more strict about stating to
AI when we transition since some object property conditions aren't watchable, and need
to be verified at runtime via structure checks. This is ok in practice, since
we'll emit the code to do that inside constant folding (constant folding was
already doing this), which will continue to report the precise transition in
the abstract state.

dfg/DFGAbstractInterpreter.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed