Context Navigation

← Previous Period
Next Period →

Timeline

Jan 12, 2020:

11:33 PM Changeset in webkit [254422] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Remove CorePDF linkage in WebKit
https://bugs.webkit.org/show_bug.cgi?id=206103
<rdar://problem/58490563>

Reviewed by Wenson Hsieh.

Configurations/WebKit.xcconfig:

7:40 PM Changeset in webkit [254421] by Alan Bujtas

7 edits in trunk

Text-indent with percentage value should resolve against the available width
https://bugs.webkit.org/show_bug.cgi?id=206155
<rdar://problem/58514882>

Reviewed by Antti Koivisto.

Source/WebCore:

https://www.w3.org/TR/css-text-3/#text-indent-property
"<percentage> Gives the amount of the indent as a percentage of the block container’s own logical width"

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::textIndentOffset const):

LayoutTests:

platform/mac/css1/text_properties/text_indent-expected.txt:
platform/mac/css2.1/t1601-c547-indent-01-d-expected.txt:

7:12 PM Changeset in webkit [254420] by ysuzuki@apple.com

19 edits in trunk

[JSC] Use internal object field mechanism to implement JSStringIterator
https://bugs.webkit.org/show_bug.cgi?id=206144

Reviewed by Ross Kirsling.

JSTests:

stress/string-iterators.js:
stress/tailCallForwardArguments.js:

(putFuncToPrivateName.createBuiltin):
(createTailCallForwardingFuncWith):

Source/JavaScriptCore:

This patch uses internal object field mechanism to implement JSStringIterator,
and we also put JSStringIterator into IsoSubspace.

builtins/BuiltinNames.h:
builtins/StringIteratorPrototype.js:

(next):

bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

bytecode/BytecodeIntrinsicRegistry.h:
bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitIsStringIterator):

bytecompiler/NodesCodegen.cpp:

(JSC::stringIteratorInternalFieldIndex):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_getStringIteratorInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putStringIteratorInternalField):

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::getInternalProperties):

runtime/JSCast.h:
runtime/JSStringIterator.cpp:

(JSC::JSStringIterator::finishCreation):
(JSC::JSStringIterator::clone):
(JSC::JSStringIterator::visitChildren):
(JSC::JSStringIterator::iteratedValue const): Deleted.

runtime/JSStringIterator.h:
runtime/JSType.cpp:

(WTF::printInternal):

runtime/JSType.h:
runtime/StringPrototype.cpp:

(JSC::stringProtoFuncIterator):

runtime/VM.cpp:
runtime/VM.h:

7:10 PM Changeset in webkit [254419] by ysuzuki@apple.com

12 edits in trunk/Source/JavaScriptCore

[JSC] Remove IsDone from JSArrayIterator
https://bugs.webkit.org/show_bug.cgi?id=206140

Reviewed by Keith Miller.

We can store -1 in Index field to represent whether the iterator is closed.
While this patch does not change the allocation size of JSArrayIterator, this style can
shrink the size of JSStringIterator when we implement it in the same style.

We also rename iterationKindKeyValue to iterationKindEntries.

builtins/ArrayIteratorPrototype.js:

(globalPrivate.arrayIteratorNextHelper):

builtins/MapIteratorPrototype.js:

(globalPrivate.mapIteratorNext):

builtins/MapPrototype.js:

(entries):

builtins/SetIteratorPrototype.js:

(globalPrivate.setIteratorNext):

builtins/SetPrototype.js:

(entries):

bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

bytecode/BytecodeIntrinsicRegistry.h:
bytecompiler/NodesCodegen.cpp:

(JSC::arrayIteratorInternalFieldIndex):

inspector/JSInjectedScriptHost.cpp:

(Inspector::cloneArrayIteratorObject):

runtime/JSArrayIterator.cpp:

(JSC::JSArrayIterator::finishCreation):

runtime/JSArrayIterator.h:

5:18 PM Changeset in webkit [254418] by ysuzuki@apple.com

13 edits in trunk/Source/JavaScriptCore

[JSC] Consistently use "var" in builtin JS
https://bugs.webkit.org/show_bug.cgi?id=206157

Reviewed by Mark Lam.

let / const requires additional bytecode to make it Empty initialized for now.
For builtin JS, we would like to keep it as efficient and compact as we can
so we should use var consistently.

builtins/ArrayPrototype.js:

(sort.stringComparator):
(sort.compactSparse):
(sort.compactSlow):
(sort.compact):
(sort.merge):
(sort.mergeSort):
(sort.bucketSort):
(sort.comparatorSort):
(sort.stringSort):
(sort):
(globalPrivate.concatSlowPath):
(concat):

builtins/FunctionPrototype.js:

(call):
(overriddenName.string_appeared_here.symbolHasInstance):

builtins/GlobalOperations.js:

(globalPrivate.copyDataProperties):
(globalPrivate.copyDataPropertiesNoExclusions):

builtins/IteratorHelpers.js:

(performIteration):

builtins/ModuleLoader.js:

(async loadModule):
(async loadAndEvaluateModule):
(async requestImportModule):
(dependencyKeysIfEvaluated):

builtins/ObjectConstructor.js:

(fromEntries):

builtins/PromisePrototype.js:

(finally):
(valueThunk):
(globalPrivate.getThenFinally):
(thrower):
(globalPrivate.getCatchFinally):
(const.valueThunk): Deleted.
(const.thrower): Deleted.

builtins/RegExpPrototype.js:

(globalPrivate.advanceStringIndex):
(globalPrivate.regExpExec):
(globalPrivate.hasObservableSideEffectsForRegExpMatch):
(globalPrivate.matchSlow):
(overriddenName.string_appeared_here.match):
(overriddenName.string_appeared_here.matchAll):
(getSubstitution):
(overriddenName.string_appeared_here.replace):
(overriddenName.string_appeared_here.search):
(globalPrivate.hasObservableSideEffectsForRegExpSplit):
(overriddenName.string_appeared_here.split):
(intrinsic.RegExpTestIntrinsic.test):

builtins/RegExpStringIteratorPrototype.js:

(next):

builtins/StringPrototype.js:

(match):
(matchAll):
(globalPrivate.hasObservableSideEffectsForStringReplace):
(intrinsic.StringPrototypeReplaceIntrinsic.replace):
(globalPrivate.createHTML):

builtins/TypedArrayConstructor.js:

(of):
(from):

builtins/TypedArrayPrototype.js:

(globalPrivate.typedArraySpeciesConstructor):
(globalPrivate.typedArrayClampArgumentToStartOrEnd):
(fill):
(find):
(subarray):

4:21 PM Changeset in webkit [254417] by weinig@apple.com

4 edits
1 copy in trunk/Source/WTF

Platform.h is out of control Part 2: Split WTF_OS_* macro definitions out of Platform.h and into a new OS.h
https://bugs.webkit.org/show_bug.cgi?id=206138

Reviewed by Anders Carlsson.

As a another step towards cleaning up Platform.h, split out OS related
macros into their own file.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/OS.h: Copied from Source/WTF/wtf/Platform.h.
wtf/Platform.h:

2:42 PM Changeset in webkit [254416] by ysuzuki@apple.com

6 edits in trunk/Source

[WebCore] Reorganize JSType in WebCore to offer more bits to JSC
https://bugs.webkit.org/show_bug.cgi?id=206141

Reviewed by Keith Miller.

Source/JavaScriptCore:

runtime/JSType.h:

Source/WebCore:

This patch reorganize JSType a bit to offer more bits to JSC. Then JSC can use JSType for types easily.

bindings/js/JSDOMWrapper.h:
bindings/js/JSElementCustom.h:

(JSC::JSCastingHelpers::InheritsTraits<WebCore::JSElement>::inherits):

domjit/DOMJITHelpers.h:

(WebCore::DOMJIT::branchIfElement):
(WebCore::DOMJIT::branchIfNotElement):

1:30 PM Changeset in webkit [254415] by mmaxfield@apple.com

2 edits in trunk/LayoutTests

REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043

Make iOS bots green until they can be updated.

Unreviewed.

platform/ios/TestExpectations:

11:10 AM Changeset in webkit [254414] by Darin Adler

5 edits in trunk/Source/WebCore

Remove unneeded MemoryIDBBackingStore::create
https://bugs.webkit.org/show_bug.cgi?id=205512

Reviewed by Youenn Fablet.

Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::createBackingStore): Call makeUnique
instead of MemoryIDBBackingStore::create.

Modules/indexeddb/server/MemoryCursor.cpp: Removed unneeded include

of MemoryIDBBackingStore.h.

Modules/indexeddb/server/MemoryIDBBackingStore.cpp: Fixed a comment

and replaced a global variable with a constant.
(WebCore::IDBServer::MemoryIDBBackingStore::create): Deleted.

Modules/indexeddb/server/MemoryIDBBackingStore.h: Made the class

final, made more of the member functions private, and moved a couple
function members out from in between the data members.

Jan 11, 2020:

11:44 PM Changeset in webkit [254413] by mmaxfield@apple.com

2 edits in trunk/Source/WTF

REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043

Unreviewed.

Fix build.

wtf/cocoa/LanguageCocoa.mm:

(WTF::canMinimizeLanguages):

11:16 PM Changeset in webkit [254412] by mmaxfield@apple.com

22 edits in trunk

REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043

Unreviewed.

Addressing additional review comments.

Source/WTF:

wtf/cocoa/LanguageCocoa.mm:

(WTF::canMinimizeLanguages):

LayoutTests:

fast/text/international/system-language/navigator-language/navigator-language-en-GB.html:
fast/text/international/system-language/navigator-language/navigator-language-en-US.html:
fast/text/international/system-language/navigator-language/navigator-language-en.html:
fast/text/international/system-language/navigator-language/navigator-language-es-419.html:
fast/text/international/system-language/navigator-language/navigator-language-es-ES.html:
fast/text/international/system-language/navigator-language/navigator-language-es-MX.html:
fast/text/international/system-language/navigator-language/navigator-language-es.html:
fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html:
fast/text/international/system-language/navigator-language/navigator-language-fr.html:
fast/text/international/system-language/navigator-language/navigator-language-hi.html:
fast/text/international/system-language/navigator-language/navigator-language-ja.html:
fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html:
fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html:
fast/text/international/system-language/navigator-language/navigator-language-ru.html:
fast/text/international/system-language/navigator-language/navigator-language-zh-HK.html:
fast/text/international/system-language/navigator-language/navigator-language-zh-Hans.html:
fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK.html:
fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html:
fast/text/international/system-language/navigator-language/navigator-language-zh-TW.html:

10:57 PM Changeset in webkit [254411] by mmaxfield@apple.com

2 edits in trunk/Source/WTF

Fix internal Apple builds after r254389
https://bugs.webkit.org/show_bug.cgi?id=206135

Rubber stamped by Zalan Bujtas.

wtf/spi/cocoa/NSLocaleSPI.h:

8:21 PM Changeset in webkit [254410] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC] Introduce the concept of independent formatting context
https://bugs.webkit.org/show_bug.cgi?id=206137
<rdar://problem/58508015>

Reviewed by Sam Weinig.

At this point it is just about absolute positioned block level boxes since we don't support the "contain" property.
https://www.w3.org/TR/css-display-3/#independent-formatting-context

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesFormattingContext const):
(WebCore::Layout::Box::establishesIndependentFormattingContext const):

layout/layouttree/LayoutBox.h:

5:46 PM Changeset in webkit [254409] by achristensen@apple.com

23 edits in trunk

Expose frame information on _WKResourceLoadInfo
https://bugs.webkit.org/show_bug.cgi?id=206104
<rdar://problem/57132290>

Reviewed by Dean Jackson.

Source/WebCore:

Covered by API tests.

page/FrameIdentifier.h:

(WebCore::frameIdentifierFromID): Deleted.

Source/WebKit:

NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

NetworkProcess/NetworkResourceLoadParameters.h:
NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::resourceLoadInfo):

Shared/API/Cocoa/_WKFrameHandle.h:
Shared/API/Cocoa/_WKFrameHandle.mm:

(-[_WKFrameHandle frameID]):
(-[_WKFrameHandle initWithCoder:]):
(-[_WKFrameHandle encodeWithCoder:]):
(-[_WKFrameHandle _frameID]): Deleted.

Shared/API/Cocoa/_WKFrameHandleInternal.h:
Shared/ResourceLoadInfo.h:

(WebKit::ResourceLoadInfo::encode const):
(WebKit::ResourceLoadInfo::decode):

UIProcess/API/APIResourceLoadInfo.h:
UIProcess/API/Cocoa/_WKInspector.mm:

(-[_WKInspector showMainResourceForFrame:]):

UIProcess/API/Cocoa/_WKResourceLoadInfo.h:
UIProcess/API/Cocoa/_WKResourceLoadInfo.mm:

(-[_WKResourceLoadInfo frame]):
(-[_WKResourceLoadInfo parentFrame]):

UIProcess/API/mac/WKWebViewMac.mm:

(-[WKWebView _canChangeFrameLayout:]):
(-[WKWebView _printOperationWithPrintInfo:forFrame:]):

UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm:

(-[WKReloadFrameErrorRecoveryAttempter attemptRecovery]):

UIProcess/ios/WKContentView.mm:

(-[WKContentView _wk_pageCountForPrintFormatter:]):

WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::evaluateJavaScriptCallback):

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(+[WKWebProcessPlugInFrame lookUpFrameFromHandle:]):

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::addParametersFromFrame):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::startPingLoad):

WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::installServiceWorker):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:

(TEST):

5:25 PM Changeset in webkit [254408] by ysuzuki@apple.com

8 edits in trunk

[WebCore] Fix crash in module loader due to change in fragment reservation
https://bugs.webkit.org/show_bug.cgi?id=206125

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

web-platform-tests/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url-expected.txt:

Source/WebCore:

At some point, CachedResource::url() starts returning URL without fragment.
However, this was invariant in ScriptModuleLoader, so one of WPT test is crashing.

We save source URL so that we preserve fragment information.
Still we need to have fragment information after the redirect to fix a bug filed in [1].

[1]: https://bugs.webkit.org/show_bug.cgi?id=205294

bindings/js/CachedModuleScriptLoader.cpp:

(WebCore::CachedModuleScriptLoader::load):

bindings/js/CachedModuleScriptLoader.h:
bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::notifyFinished):

LayoutTests:

TestExpectations:

4:49 PM Changeset in webkit [254407] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC] isOkToAccessDisplayBox should return false on formatting context root access.
https://bugs.webkit.org/show_bug.cgi?id=206123
<rdar://problem/58500267>

Reviewed by Antti Koivisto.

From now on any geometry access outside of the formatting context without a valid reason is considered an escape.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):

4:29 PM Changeset in webkit [254406] by commit-queue@webkit.org

7 edits
2 adds in trunk

Support image-set() standard syntax
https://bugs.webkit.org/show_bug.cgi?id=160934
<rdar://problem/27891501>

Patch by Noam Rosenthal <Noam Rosenthal> on 2020-01-11
Source/WebCore:

Reviewed by Simon Fraser.

Inside image-set, image URLs can use regular quotes, not necessarily with url().
See https://drafts.csswg.org/css-images-4/#image-set-notation

Test: fast/hidpi/image-set-as-background-quotes.html

css/parser/CSSPropertyParserHelpers.cpp:

Update CSS parser to allow raw strings as URLs inside image-set.

(WebCore::CSSPropertyParserHelpers::consumeUrlOrStringAsStringView):
(WebCore::CSSPropertyParserHelpers::consumeImageSet):

LayoutTests:

Reviewed by Dean Jackson.

fast/css/image-set-parsing-invalid.html:
fast/css/image-set-parsing.html:

Update parsing to include raw strings

fast/hidpi/image-set-as-background-quotes-expected.html: Added.
fast/hidpi/image-set-as-background-quotes.html: Added.

Added ref-test for image-set without url().

4:16 PM Changeset in webkit [254405] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC] BlockFormattingContext::verticalPositionWithMargin should take VerticalConstraints
https://bugs.webkit.org/show_bug.cgi?id=206122
<rdar://problem/58500207>

Reviewed by Antti Koivisto.

This prevents verticalPositionWithMargin from reading geometry outside of the formatting context.

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForAncestors):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFormattingRoot):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFloatClear):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::verticalPositionWithMargin const):

layout/blockformatting/BlockFormattingContext.h:

4:05 PM Changeset in webkit [254404] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][BFC] BlockFormattingContext::computeEstimatedVerticalPositionForAncestors should take ConstraintsPair<HorizontalConstraints>
https://bugs.webkit.org/show_bug.cgi?id=206121
<rdar://problem/58499492>

Reviewed by Antti Koivisto.

This prevents computeEstimatedVerticalPositionForAncestors from reading geometry outside of the formatting context.

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForAncestors):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFormattingRoot):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFloatClear):

layout/blockformatting/BlockFormattingContext.h:

4:03 PM Changeset in webkit [254403] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC] Introduce BlockFormattingContext::ConstraintsPair
https://bugs.webkit.org/show_bug.cgi?id=206119
<rdar://problem/58498745>

Reviewed by Antti Koivisto.

This is in preparation for passing rootHorizontalConstraints all the way to BlockFormattingContext::computeEstimatedVerticalPosition().

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::ConstraintsPair<T>::ConstraintsPair):
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):

layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::ConstraintsPair::operator* const):
(WebCore::Layout::BlockFormattingContext::ConstraintsPair::root const):

3:47 PM Changeset in webkit [254402] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Visually collapse hanging pre-wrap content.
https://bugs.webkit.org/show_bug.cgi?id=206133
<rdar://problem/58505750>

Reviewed by Antti Koivisto.

This change is to comply with other rendering engines when it comes to visually collapsing hanging pre-wrap content.

https://www.w3.org/TR/css-text-3/#white-space-phase-2
"If white-space is set to pre-wrap, the UA must (unconditionally) hang this sequence, unless the sequence
is followed by a forced line break, in which case it must conditionally hang the sequence is instead.
It _may_ also visually collapse the character advance widths of any that would otherwise overflow."

layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::visuallyCollapsePreWrapOverflowContent):

layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::InlineItemRun::adjustLogicalWidth):

10:07 AM Changeset in webkit [254401] by weinig@apple.com

4 edits
1 copy in trunk/Source/WTF

Platform.h is out of control Part 1: Split WTF_CPU_* macro definitions out of Platform.h and into a new CPU.h
https://bugs.webkit.org/show_bug.cgi?id=206124

Reviewed by Anders Carlsson.

As a step towards cleaning up Platform.h, split out CPU related
macros into their own file.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/CPU.h: Copied from Source/WTF/wtf/Platform.h.
wtf/Platform.h:

9:42 AM Changeset in webkit [254400] by dino@apple.com

9 edits in trunk

[WebGL] Clarify USE_OPENGL_ES_3
https://bugs.webkit.org/show_bug.cgi?id=206081
<rdar://problem/58486798>

Reviewed by Simon Fraser.

Make it clear that USE_ANGLE | USE_OPENGL | USE_OPENGL_ES are exclusive,
and that the availability of OpenGL ES 3 is a separate query.

Source/cmake/OptionsFTW.cmake:
Source/cmake/OptionsWPE.cmake:
Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

Source/WTF:

wtf/Platform.h:

9:31 AM Changeset in webkit [254399] by cathiechen

13 edits
2 deletes in trunk/LayoutTests

Import WPT test cases for 2dcontext/imagebitmap
https://bugs.webkit.org/show_bug.cgi?id=205908

Reviewed by Manuel Rego Casasnovas

LayoutTests/imported/w3c:

web-platform-tests/2dcontext/imagebitmap/canvas-createImageBitmap-video-resize-expected.txt:
web-platform-tests/2dcontext/imagebitmap/canvas-createImageBitmap-video-resize.html:
web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt:
web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable.html:
web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt:
web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html:
web-platform-tests/2dcontext/imagebitmap/no-coop-coep.https.window.html: Removed.
web-platform-tests/2dcontext/imagebitmap/no-coop-coep.https.window.js: Removed.
web-platform-tests/2dcontext/imagebitmap/w3c-import.log:

LayoutTests:

Update the expected files.

platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt:

9:02 AM Changeset in webkit [254398] by Antti Koivisto

3 edits in trunk/LayoutTests

[LFC][Integration] fast/text/simple-lines-float.html should be about simple line layout only
https://bugs.webkit.org/show_bug.cgi?id=206129

Reviewed by Zalan Bujtas.

Explicitly disable LFC in this SLL feature test.

fast/text/simple-lines-float-expected.html:
fast/text/simple-lines-float.html:

6:57 AM Changeset in webkit [254397] by Kate Cheney

11 edits in trunk

Add correct grandfathering functionality to the ITP database backend
https://bugs.webkit.org/show_bug.cgi?id=205844
<rdar://problem/58360450>

Reviewed by John Wilander.

Source/WebKit:

This patch adds functionality for grandfathering statistics upon
creation of a new ITP database file. The memory store relies on
the presence of the ITP plist to indicate whether the data should
be grandfathered. Since the database does not use a plist, this patch
adds a boolean variable to track whether the database file previously
existed or not to indicate when to grandfather.

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::openITPDatabase):

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:

The boolean variable m_isNewResourceLoadStatisticDatabaseFile is set
to true if the database file did not previously exist, indicating ITP
is being used for the first time and data should be grandfathered.

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::populateMemoryStoreFromDisk):
This is where the grandfathering happens. The call to logTestingEvent
is for API testing purposes only.

(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):
If a scheduleClearInMemoryAndPersistent is called, the plist is
deleted, and data will be grandfathered upon recreation. To mimic
this, the ITP database store is cleared and becomes "new" again, so
the boolean is set to true.

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetIsITPDatabaseEnabled):
(WKPreferencesGetIsITPDatabaseEnabled):

UIProcess/API/C/WKPreferencesRef.h:
UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _isITPDatabaseEnabled]):

UIProcess/API/Cocoa/WKPreferencesPrivate.h:

In order to properly run the grandfathering
API tests, the 'isITPDatabaseEnabled' boolean needs to be exposed from
Web Preferences.

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

The API tests rely on the ITP database flag being set correctly. Since
being on-by-default, the ITP database flag does not show up in the
user defaults menu if enabled. This patch fixes this by first checking
to see if the value is in the defaults menu, otherwise returning the
default preferences value. This ensures the preferences value matches
the actual store being initialized.

Tools:

In order to test both the ITP database and memory stores, this patch
had to restructure the grandfathering API tests.

If the test is for the database backend (ends in *Database), it will
check if the default store matches. If so, it continues on with the
normal test. If not, it has to use an API call to reconstruct the
new store and ensure the grandfathering still happens. Vice versa for
the memory store tests.