⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 16, 2020:

8:35 PM Changeset in webkit [256722] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[GTK] More debug build timeouts gardening
​https://bugs.webkit.org/show_bug.cgi?id=207831

Unreviewed test gardening.

  • platform/gtk/TestExpectations:
8:31 PM Changeset in webkit [256721] by Peng Liu
  • 4 edits
    1 delete in trunk/Source/WebCore

Remove class VideoLayerManager since it is not used
​https://bugs.webkit.org/show_bug.cgi?id=207800

Reviewed by Eric Carlson.

No behavior change.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/VideoLayerManager.h: Removed.
  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:

(WebCore::VideoLayerManagerObjC::VideoLayerManagerObjC):

6:49 PM Changeset in webkit [256720] by Fujii Hironori
  • 12 edits in trunk

Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
​https://bugs.webkit.org/show_bug.cgi?id=207746

Reviewed by Don Olmstead.

Source/JavaScriptCore:

  • runtime/JSExportMacros.h:

Source/WebCore:

  • platform/PlatformExportMacros.h:

Source/WebCore/PAL:

Removed unused PAL_TESTSUPPORT_EXPORT.

  • pal/ExportMacros.h:

Source/WebKit:

  • WebProcess/win/WebProcessWin.cpp:

(loadResourceIntoBuffer): Removed WTF_EXPORT. loadResourceIntoBuffer is used from WebCore which is in same DLL.

Source/WTF:

I removed WTF_EXPORT from function declarations in r256420 (Bug 207453).
WTF_EXPORT is still used mostly in *ExportMacros.h. However, there is no
difference between WTF_EXPORT and WTF_EXPORT_DECLARATION.

Removed WTF_EXPORT and WTF_IMPORT by replacing them with
WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION

Removed unused WTF_HIDDEN.

Defined WTF_EXPORT_DECLARATION, WTF_IMPORT_DECLARATION and WTF_HIDDEN_DECLARATION empty
in case of !USE(EXPORT_MACROS) to simplify *ExportMacros.h.

  • wtf/ExportMacros.h:

Tools:

  • MiniBrowser/win/stdafx.h:
6:11 PM Changeset in webkit [256719] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

Log WebSocket failure in case of network crash
​https://bugs.webkit.org/show_bug.cgi?id=207801

Reviewed by Darin Adler.

Covered by http/tests/websocket/tests/hybi/network-process-crash-error.html.

  • WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::didReceiveMessageError):
(WebKit::WebSocketChannel::networkProcessCrashed):
Add a console log message in case of error coming from network process.

6:06 PM Changeset in webkit [256718] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove nonArgGPR1 for ARMv7 and ARM64 (unused)
​https://bugs.webkit.org/show_bug.cgi?id=207753

Patch by Paulo Matos <Paulo Matos> on 2020-02-16
Reviewed by Darin Adler.

Cleanup commit - nonArgGPR1 is unused for both ARMv7
and ARM64.

  • jit/GPRInfo.h:
5:54 PM Changeset in webkit [256717] by ap@apple.com
  • 4 edits in trunk/LayoutTests

[ Mac wk2 ] fast/events/keydown-1.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=154297
​https://bugs.webkit.org/show_bug.cgi?id=207785
<rdar://problem/59469424>

Reviewed by Wenson Hsieh.

  • fast/events/keydown-1.html: Attempt to deflake by using onload instead of a 200 ms timer.
  • platform/mac-wk1/TestExpectations: Removed flaky expectation.
  • platform/mac-wk2/TestExpectations: Removed flaky expectation. Also corrected a

conflict that was landed in r256656 today.

5:41 PM Changeset in webkit [256716] by Alexey Shvayka
  • 32 edits
    2 adds
    1 delete in trunk

Implement EventTarget constructor
​https://bugs.webkit.org/show_bug.cgi?id=174313

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/WebIDL/ecmascript-binding/constructors-expected.txt:
  • web-platform-tests/dom/events/Event-subclasses-constructors-expected.txt:
  • web-platform-tests/dom/events/EventTarget-constructible.any-expected.txt:
  • web-platform-tests/dom/events/EventTarget-constructible.any.worker-expected.txt:
  • web-platform-tests/dom/events/event-global-extra.window-expected.txt:
  • web-platform-tests/dom/idlharness.any.worker-expected.txt:
  • web-platform-tests/dom/idlharness.window-expected.txt:

Source/WebCore:

Currently, EventTarget can't be directly constructed or be subclassed in JavaScript.
The spec for EventTarget was updated (​https://github.com/whatwg/dom/pull/467) to allow
constructing and subclassing EventTarget. This feature was shipped in Chrome 64 and Firefox 59.

This patch introduces EventTargetConcrete class, a user-constructable version of EventTarget,
exposed as "EventTarget" to JavaScript. We don't use EventTarget directly because it is an abstract
class and making it non-abstract is unfavorable due to size increase of EventTarget and all of its
subclasses with code that is mostly unnecessary for them, resulting in a performance decrease.

To prevent definition of specific to EventTargetConcrete toJS and toJSNewlyCreated functions,
we don't define EventTargetConcrete interface type, but rather tweak make_event_factory.pl to
default to base interface (like it does for Event).

To allow subclassing of all DOM constructors, non-custom ones replace structures of newly created
wrapper objects with ones returned by InternalFunction::createSubclassStructure. Per WebIDL spec [1],
setSubclassStructureIfNeeded helper uses realm of newTarget for default prototypes.

This approach was chosen because a) detecting Construct with callFrame->newTarget() is
unreliable outside constructor, and b) passing newTarget down to createWrapper via
toJSNewlyCreated is quite awkward and would result in massive code change.

[1] ​https://heycam.github.io/webidl/#internally-create-a-new-object-implementing-the-interface
(step 3.3.2)

Tests: fast/dom/dom-constructors.html

imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/constructors.html
imported/w3c/web-platform-tests/dom/events/Event-subclasses-constructors.html
imported/w3c/web-platform-tests/dom/events/EventTarget-constructible.any.html
imported/w3c/web-platform-tests/dom/idlharness.window.html

  • Headers.cmake:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWrapperCache.h:

(WebCore::setSubclassStructureIfNeeded):

  • bindings/js/JSEventTargetCustom.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

  • bindings/scripts/InFilesCompiler.pm:

(generateInterfacesHeader):

  • bindings/scripts/test/JS/*: Adjust bindings expectations.
  • dom/EventTarget.cpp:

(WebCore::EventTarget::create):

  • dom/EventTarget.h:
  • dom/EventTarget.idl:
  • dom/EventTargetConcrete.cpp: Added.
  • dom/EventTargetConcrete.h: Added.
  • dom/make_event_factory.pl:

(generateImplementation):

LayoutTests:

  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • platform/ios/imported/w3c/web-platform-tests/dom/events/Event-subclasses-constructors-expected.txt: Removed.
5:35 PM Changeset in webkit [256715] by beidson@apple.com
  • 29 edits in trunk

Expose "allowsContentJavaScript" on WKWebpagePreferences
<rdar://problem/51534967> and ​https://bugs.webkit.org/show_bug.cgi?id=207427

Reviewed by Darin Adler.

Source/WebCore:

Covered by new API tests.

  • dom/Document.cpp:

(WebCore::Document::allowsContentJavaScript const):

  • dom/Document.h:
  • dom/ScriptableDocumentParser.cpp:

(WebCore::ScriptableDocumentParser::ScriptableDocumentParser):

  • loader/FrameLoaderClient.h:
  • loader/FrameLoaderTypes.h:
  • page/Settings.yaml:
  • xml/XMLHttpRequest.cpp: Make sure the context document is set BEFORE we parse the document contents.

Source/WebKit:

This utiizes the pre-existing WebCore::Settings::setScriptMarkupEnabled() mechanism.

This also deprecates the global "disable JavaScript" WKPreference as it doesn't make much sense anymore.

  • Shared/WebsitePoliciesData.cpp:

(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):

  • Shared/WebsitePoliciesData.h:
  • UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::data):

  • UIProcess/API/APIWebsitePolicies.h:
  • UIProcess/API/Cocoa/WKPreferences.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences encodeWithCoder:]):
(-[WKPreferences initWithCoder:]):
(-[WKPreferences javaScriptEnabled]):
(-[WKPreferences setJavaScriptEnabled:]):

  • UIProcess/API/Cocoa/WKWebpagePreferences.h:
  • UIProcess/API/Cocoa/WKWebpagePreferences.mm:

(-[WKWebpagePreferences setAllowsContentJavaScript:]):
(-[WKWebpagePreferences allowsContentJavaScript]):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::allowsContentJavaScriptFromMostRecentNavigation const):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::didReceivePolicyDecision):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateWebsitePolicies):
(WebKit::WebPage::createDocumentLoader):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::allowsContentJavaScriptFromMostRecentNavigation const):
(WebKit::WebPage::setAllowsContentJavaScriptFromMostRecentNavigation):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(TEST):
(-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.

  • TestWebKitAPI/cocoa/TestNavigationDelegate.h:
  • TestWebKitAPI/cocoa/TestNavigationDelegate.mm:

(-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
(-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
(-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.

  • TestWebKitAPI/cocoa/TestWKWebView.h:
  • TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[WKWebView synchronouslyLoadHTMLString:preferences:]):

1:47 PM Changeset in webkit [256714] by Wenson Hsieh
  • 1 edit
    2 adds in trunk/LayoutTests

Add a layout test for <rdar://problem/59090510>
​https://bugs.webkit.org/show_bug.cgi?id=207824

Reviewed by Anders Carlsson.

Add a layout test to verify that tapping near the caret rect in a focused input field still dispatches a click
event and brings up the keyboard.

  • fast/events/ios/click-in-autofocused-input-when-tapping-near-caret-expected.txt: Added.
  • fast/events/ios/click-in-autofocused-input-when-tapping-near-caret.html: Added.
12:58 PM Changeset in webkit [256713] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Fix a typo and some merge conflict markers that
were checked in a few days ago.

  • platform/mac-wk2/TestExpectations:
7:43 AM Changeset in webkit [256712] by Alan Bujtas
  • 103 edits in trunk/LayoutTests

[LFC] Enable LFC regression testing on fast/block/block-only
​https://bugs.webkit.org/show_bug.cgi?id=207825
<rdar://problem/59491089>

Reviewed by Antti Koivisto.

This helps to catch full LFC regressions while working on the integration part.

  • fast/block/block-only/abs-pos-with-border-padding-and-float-child-expected.html:
  • fast/block/block-only/abs-pos-with-border-padding-and-float-child.html:
  • fast/block/block-only/absolute-auto-with-sibling-margin-bottom.html:
  • fast/block/block-only/absolute-height-stretch.html:
  • fast/block/block-only/absolute-left-auto.html:
  • fast/block/block-only/absolute-left-right-top-bottom-auto.html:
  • fast/block/block-only/absolute-nested.html:
  • fast/block/block-only/absolute-nested2.html:
  • fast/block/block-only/absolute-position-left-right-margin.html:
  • fast/block/block-only/absolute-position-min-max-height.html:
  • fast/block/block-only/absolute-position-min-max-width.html:
  • fast/block/block-only/absolute-position-when-containing-block-is-not-in-the-formatting-context.html:
  • fast/block/block-only/absolute-position-when-containing-block-is-not-in-the-formatting-context2.html:
  • fast/block/block-only/absolute-position-with-margin-auto-simple-expected.html:
  • fast/block/block-only/absolute-position-with-margin-auto-simple.html:
  • fast/block/block-only/absolute-position-with-margin-auto-simple2-expected.html:
  • fast/block/block-only/absolute-position-with-margin-auto-simple2.html:
  • fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding-expected.html:
  • fast/block/block-only/absolute-positioned-min-max-percentage-with-parent-padding.html:
  • fast/block/block-only/absolute-simple.html:
  • fast/block/block-only/absolute-width-shrink-to-fit.html:
  • fast/block/block-only/absolute-width-stretch.html:
  • fast/block/block-only/absolute-with-static-block-position-nested.html:
  • fast/block/block-only/almost-intruding-left-float-simple.html:
  • fast/block/block-only/block-replaced-with-vertical-margins-expected.html:
  • fast/block/block-only/block-replaced-with-vertical-margins.html:
  • fast/block/block-only/body-height-with-auto-html-height-quirk.html:
  • fast/block/block-only/body-height-with-auto-html-height-quirk2.html:
  • fast/block/block-only/body-height-with-non-auto-html-height-quirk.html:
  • fast/block/block-only/body-height-with-non-auto-html-height-quirk2.html:
  • fast/block/block-only/border-simple.html:
  • fast/block/block-only/box-sizing-inflow-out-of-flow-simple.html:
  • fast/block/block-only/collapsed-margin-with-min-height.html:
  • fast/block/block-only/collapsed-through-siblings.html:
  • fast/block/block-only/collapsed-through-with-parent.html:
  • fast/block/block-only/fixed-nested.html:
  • fast/block/block-only/float-and-siblings-with-margins.html:
  • fast/block/block-only/float-avoider-multiple-roots.html:
  • fast/block/block-only/float-avoider-simple-left.html:
  • fast/block/block-only/float-avoider-simple-right.html:
  • fast/block/block-only/float-avoider-with-margins.html:
  • fast/block/block-only/float-left-when-container-has-padding-margin.html:
  • fast/block/block-only/float-min-max-height.html:
  • fast/block/block-only/float-min-max-width.html:
  • fast/block/block-only/floating-and-next-previous-inflow-with-margin-with-no-border.html:
  • fast/block/block-only/floating-and-next-previous-inflow-with-margin.html:
  • fast/block/block-only/floating-box-clear-both-simple.html:
  • fast/block/block-only/floating-box-clear-right-simple.html:
  • fast/block/block-only/floating-box-left-and-right-multiple-with-top-offset.html:
  • fast/block/block-only/floating-box-left-and-right-multiple.html:
  • fast/block/block-only/floating-box-right-simple.html:
  • fast/block/block-only/floating-box-with-clear-siblings.html:
  • fast/block/block-only/floating-box-with-clear-simple.html:
  • fast/block/block-only/floating-box-with-new-formatting-context.html:
  • fast/block/block-only/floating-box-with-relative-positioned-sibling.html:
  • fast/block/block-only/floating-left-and-right-with-clearance.html:
  • fast/block/block-only/floating-left-right-simple.html:
  • fast/block/block-only/floating-left-right-with-all-margins.html:
  • fast/block/block-only/floating-lefts-and-rights-simple.html:
  • fast/block/block-only/floating-multiple-lefts-in-body.html:
  • fast/block/block-only/floating-multiple-lefts-multiple-lines.html:
  • fast/block/block-only/floating-multiple-lefts.html:
  • fast/block/block-only/floating-with-new-block-formatting-context.html:
  • fast/block/block-only/floats-and-block-formatting-roots-expected.html:
  • fast/block/block-only/floats-and-block-formatting-roots.html:
  • fast/block/block-only/inflow-min-max-height.html:
  • fast/block/block-only/inflow-min-max-width.html:
  • fast/block/block-only/margin-collapse-bottom-bottom.html:
  • fast/block/block-only/margin-collapse-bottom-nested.html:
  • fast/block/block-only/margin-collapse-first-last-are-floating.html:
  • fast/block/block-only/margin-collapse-simple.html:
  • fast/block/block-only/margin-collapse-top-nested.html:
  • fast/block/block-only/margin-collapse-when-child-has-padding-border.html:
  • fast/block/block-only/margin-collapse-with-block-formatting-context.html:
  • fast/block/block-only/margin-collapse-with-block-formatting-context2.html:
  • fast/block/block-only/margin-collapse-with-clearance.html:
  • fast/block/block-only/margin-left-right-sizing-out-of-flow.html:
  • fast/block/block-only/margin-left-right-sizing.html:
  • fast/block/block-only/margin-propagation-simple-content-height.html:
  • fast/block/block-only/margin-sibling-collapse-propagated.html:
  • fast/block/block-only/margin-simple.html:
  • fast/block/block-only/min-max-and-preferred-width-simple-expected.html:
  • fast/block/block-only/min-max-and-preferred-width-simple.html:
  • fast/block/block-only/min-max-height-percentage.html:
  • fast/block/block-only/negative-margin-simple.html:
  • fast/block/block-only/non-auto-top-bottom-height-with-auto-margins.html:
  • fast/block/block-only/non-auto-top-bottom-height-with-margins.html:
  • fast/block/block-only/non-auto-top-bottom-left-right-widht-height-out-of-flow.html:
  • fast/block/block-only/out-of-flow-is-never-float-box-expected.html:
  • fast/block/block-only/out-of-flow-is-never-float-box.html:
  • fast/block/block-only/out-of-flow-with-containing-block-border-padding.html:
  • fast/block/block-only/padding-nested.html:
  • fast/block/block-only/padding-simple.html:
  • fast/block/block-only/relative-auto-with-parent-offset.html:
  • fast/block/block-only/relative-auto.html:
  • fast/block/block-only/relative-bottom.html:
  • fast/block/block-only/relative-position-when-containing-block-is-not-in-the-formatting-context.html:
  • fast/block/block-only/relative-right.html:
  • fast/block/block-only/relative-siblings.html:
  • fast/block/block-only/relative-simple.html:
  • fast/block/block-only/replaced-intrinsic-width-simple-expected.html:
  • fast/block/block-only/replaced-intrinsic-width-simple.html:
7:38 AM Changeset in webkit [256711] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][Float] Simplify BlockFormattingContext::usedAvailableWidthForFloatAvoider
​https://bugs.webkit.org/show_bug.cgi?id=207823
<rdar://problem/59490669>

Reviewed by Antti Koivisto.

The containing block of this float avoider is either a non-avoider or a formatting context root avoider,
so we don't have to map the left position (and now LFC passes fast/block/block-only again).

  • layout/FormattingContext.cpp:

(WebCore::Layout::mapHorizontalPositionToAncestor): Deleted.
(WebCore::Layout::FormattingContext::mapTopToFormattingContextRoot const): Deleted.
(WebCore::Layout::FormattingContext::mapLeftToFormattingContextRoot const): Deleted.
(WebCore::Layout::FormattingContext::mapRightToFormattingContextRoot const): Deleted.

  • layout/FormattingContext.h:
  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):

7:23 AM Changeset in webkit [256710] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][BFC] Formatting context roots position their own relative children
​https://bugs.webkit.org/show_bug.cgi?id=207822
<rdar://problem/59490353>

Reviewed by Antti Koivisto.

Since FCs are responsible for positioning their relative positioned children, we
don't have to do it as part of the final positioning.

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):

  • layout/blockformatting/BlockFormattingContext.h:
7:18 AM Changeset in webkit [256709] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC] A box establishing an independent formatting context is not a float avoider
​https://bugs.webkit.org/show_bug.cgi?id=207820
<rdar://problem/59490056>

Reviewed by Antti Koivisto.

Since the independent formatting context does not inherit the parent's floating context,
the box's content essentially ignores the floats and the box itself does not avoid them either
(aka its position is independent of the floats in the same context).

  • layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isFloatAvoider const):

7:14 AM Changeset in webkit [256708] by Alan Bujtas
  • 6 edits in trunk/Source/WebCore

[LFC][Floats] FloatingContext::positionForFloat needs the horizontal constrains
​https://bugs.webkit.org/show_bug.cgi?id=207818
<rdar://problem/59489777>

Reviewed by Antti Koivisto.

We need to access the containing block's geometry (horizontal constraints) to align a floating positioned
box in an empty floating context.

  • layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):

7:09 AM Changeset in webkit [256707] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][BFC] Fix horizontal/verticalConstraintsForAncestor in BlockFormattingContext::precomputeVerticalPositionForAncestors
​https://bugs.webkit.org/show_bug.cgi?id=207817
<rdar://problem/59489735>

Reviewed by Antti Koivisto.

horizontalConstraintsForAncestor/verticalConstraintsForAncestor should return the constraints (containing block's content box width etc)
of the ancestor.

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForAncestors):

Feb 15, 2020:

2:20 PM Changeset in webkit [256706] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[GStreamer] Build failure with Clang/libc++ due to missing WallTime→float for std::isnan()
​https://bugs.webkit.org/show_bug.cgi?id=207757

Unreviewed build fix.

No new tests needed.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(CachedResourceStreamingClient::dataReceived): Add std:: namespace to overloaded
std::isnan() function call to ensure that the overloaded version for WTF::WallTime
is used.

2:02 PM Changeset in webkit [256705] by Adrian Perez de Castro
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix for non-unified builds.

No new tests needed.

  • animation/AnimationEventBase.cpp: Add missing include.
  • animation/DeclarativeAnimation.cpp: Ditto.
2:01 PM Changeset in webkit [256704] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][BFC] ConstraintsPair is only needed for the pre-computed vertical position
​https://bugs.webkit.org/show_bug.cgi?id=207814
<rdar://problem/59485612>

Reviewed by Antti Koivisto.

After r256099 (Pre-compute vertical position only when we really need it), ConstraintsPair<> is only
needed in few functions.

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):

  • layout/blockformatting/BlockFormattingContext.h:
1:30 PM WebKitGTK/2.26.x edited by Adrian Perez de Castro
(diff)
1:29 PM WebKitGTK/2.28.x edited by Adrian Perez de Castro
(diff)
1:26 PM WebKitGTK/2.26.x edited by Adrian Perez de Castro
(diff)
1:24 PM Changeset in webkit [256703] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

[Geoclue] Avoid usage of provider in callbacks after it has been destroyed
​https://bugs.webkit.org/show_bug.cgi?id=207420

GeoclueGeolocationProvider was making non-cancelable g_dbus_proxy_call(s) with
bare |this| pointer.

Patch by Pavel Feldman <​pavel.feldman@gmail.com> on 2020-02-15
Reviewed by Carlos Garcia Campos.

  • UIProcess/geoclue/GeoclueGeolocationProvider.cpp:

(WebKit::GeoclueGeolocationProvider::start):
(WebKit::GeoclueGeolocationProvider::stop):
(WebKit::GeoclueGeolocationProvider::setupManager):
(WebKit::GeoclueGeolocationProvider::createClient):
(WebKit::GeoclueGeolocationProvider::startClient):
(WebKit::GeoclueGeolocationProvider::didFail):

  • UIProcess/geoclue/GeoclueGeolocationProvider.h:
7:17 AM Changeset in webkit [256702] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

[LFC] Introduce OutOfFlowHorizontalConstraints
​https://bugs.webkit.org/show_bug.cgi?id=207805
<rdar://problem/59482286>

Reviewed by Antti Koivisto.

Borders and paddings are resolved against the containing block's content box as if the box was an in-flow box.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::horizontalConstraintsForOutOfFlow):

  • layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):

  • layout/LayoutUnits.h:
  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

6:15 AM Changeset in webkit [256701] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][IFC] Anonymous inline boxes/line break boxes do not generate Display::Boxes
​https://bugs.webkit.org/show_bug.cgi?id=207802
<rdar://problem/59480138>

Reviewed by Antti Koivisto.

  1. Painting should not expect a Display::Box per Layout::Box.
  2. Do not generate empty Display::Boxes for anonymous inline text boxes/line breaks.
  • layout/FormattingState.cpp:

(WebCore::Layout::FormattingState::displayBox):

  • layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintSubtree):
(WebCore::Display::collectPaintRootsAndContentRect):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

Note: See TracTimeline for information about the timeline view.