⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 19, 2020:

10:41 PM Changeset in webkit [257046] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

ASSERTION FAILED: roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in WebCore::RenderGeometryMap::mapToContainer
​https://bugs.webkit.org/show_bug.cgi?id=151030
<rdar://problem/27711142>

Patch by Jack Lee <Jack Lee> on 2020-02-19
Reviewed by Darin Adler.

Track if m_accumulatedOffset ever becomes saturated, and if so, do not assert on unexpected rendererMappedResult.

Source/WebCore:

Test: fast/layers/geometry-map-saturated-offset-assert.html

  • platform/graphics/LayoutSize.h:

(WebCore::LayoutSize::mightBeSaturated const):

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToContainer const):
(WebCore::RenderGeometryMap::stepInserted):
(WebCore::RenderGeometryMap::stepRemoved):

  • rendering/RenderGeometryMap.h:

LayoutTests:

  • fast/layers/geometry-map-saturated-offset-assert-expected.txt: Added.
  • fast/layers/geometry-map-saturated-offset-assert.html: Added.
10:25 PM Changeset in webkit [257045] by Chris Dumez
  • 6 edits in trunk/Source/WebKit

Regression(r246188) WebProcess is launched too eagerly when [WKWebView _restoreSessionState] is called
​https://bugs.webkit.org/show_bug.cgi?id=207908

Reviewed by Darin Adler.

Since r246188, the WebProcess is launched eagerly when [WKWebView _restoreSessionState] is called. This is bad
for performance because we are unable to leverage the process cache at this point (since we don't know which
domain will be loaded).

This patch thus reverts r246188 and fixes what r246188 was trying to address in a different way. If the process
was not launched yet when restoreSessionState() is called, the session state properly gets sent to the WebProcess
after launch, via the WebPageCreationParameters. What was missing at that point was that the session state was
restore by an API Request. To fix this, we now pass an extra itemStatesWereRestoredByAPIRequest flag in
WebPageCreationParameters.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::restoreFromSessionState):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_overriddenMediaType):

10:24 PM Changeset in webkit [257044] by commit-queue@webkit.org
  • 4 edits
    1 move in trunk/Source

Unreviewed, rolling out r257029.
​https://bugs.webkit.org/show_bug.cgi?id=207996

Doesn't fix the issue (Requested by ap on #webkit).

Reverted changeset:

"[iOS] Rename NSUserDefaultsSPI.h"
​https://bugs.webkit.org/show_bug.cgi?id=207977
​https://trac.webkit.org/changeset/257029

10:19 PM Changeset in webkit [257043] by Jon Davis
  • 2 edits in trunk/Source/WebInspectorUI

Fixed object trees using the wrong theme of type icon
​https://bugs.webkit.org/show_bug.cgi?id=207980

Reviewed by Darin Adler.

  • UserInterface/Views/ObjectTreePropertyTreeElement.css:

(.object-tree-property.boolean > .icon):
(.object-tree-property.function > .icon):
(.object-tree-property.number > .icon):
(.object-tree-property.bigint > .icon):
(.object-tree-property.object > .icon):
(.object-tree-property.object.null > .icon):
(.object-tree-property.object.node > .icon):
(.object-tree-property.regex > .icon):
(.object-tree-property.string > .icon):
(.object-tree-property.symbol > .icon):
(.object-tree-property.accessor > .icon,):
(.object-tree-property.had-error > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.boolean > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.function > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.number > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.bigint > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.object > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.object.null > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.object.node > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.regex > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.string > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.symbol > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.accessor > .icon,):
(@media (prefers-color-scheme: dark) .object-tree-property.had-error > .icon):

10:11 PM Changeset in webkit [257042] by BJ Burg
  • 2 edits in trunk/Source/WebKit

Web Automation: Automation.setWindowFrameOfBrowsingContext should accept negative x and y-origin values
​https://bugs.webkit.org/show_bug.cgi?id=207974
<rdar://problem/59606705>

Reviewed by Darin Adler.

According to the spec, negative origin values are supported:

​https://w3c.github.io/webdriver/#set-window-rect

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):

10:08 PM Changeset in webkit [257041] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Resources larger than 10MB are not stored in the disk cache
​https://bugs.webkit.org/show_bug.cgi?id=207967
<rdar://problem/59572084>

Reviewed by Darin Adler.

This patch makes two policy changes to our disk cache:

  1. The capacity of the disk cache is now doubled. Based on available disk space, it could previously use up to 500MB of disk space. The limit is now 1GB.
  2. The per cache-entry limit is raised from 10MB to 1/8 of the disk cache capacity (so up to 128MB based on new maximum capacity).
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveBuffer):

  • Shared/CacheModel.cpp:

(WebKit::calculateURLCacheSizes):

9:36 PM Changeset in webkit [257040] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit

Use consistent capitalization and spacing in process-related feature names
​https://bugs.webkit.org/show_bug.cgi?id=207989

Reviewed by Zalan Bujtas.

No new tests, we don't test feature flag names.

  • Shared/WebPreferences.yaml: Adjust some feature names and descriptions.
7:51 PM Changeset in webkit [257039] by youenn@apple.com
  • 32 edits in trunk

Add support for AudioSession handling in GPUProcess for capture
​https://bugs.webkit.org/show_bug.cgi?id=207950

Reviewed by Eric Carlson.

Source/WebCore:

Add a dedicated interface for handling audio capture in session manager.
This was previoulsy PlatformMediaSessionClient, but this one is more related to audio/video rendering.
Use this new interface for MediaStreamTrack capture sources.
The session manager now owns a WeakHashSet of capture sources to compute the correct AudioSession category.

Modernize the code, for instance use an enum class for MediaType to remove some debug asserts.
Add a new PlatformMediaSessionManager::create that is used for sharedManager.

Remove the direct use of PlatformMediaSessionManager::sharedManager from classes that can be used outside of WebProcess.
This includes BaseAudioSharedUnit, for which we add a audioUnitWillStart callback
so that we compute the right AudioSession category before starting the capture.

Covered by existing tests and debug assertions to check for AudioSession category computation.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::configureTrackRendering):
(WebCore::MediaStreamTrack::isCapturingAudio const):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/webaudio/AudioContext.h:
  • html/HTMLAudioElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::shouldDisableSleep const):
(WebCore::HTMLMediaElement::mediaType const):
(WebCore::HTMLMediaElement::presentationType const):

  • html/HTMLVideoElement.h:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canShowControlsManager const):

  • html/MediaElementSession.h:
  • platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::PlatformMediaSession):
(WebCore::PlatformMediaSession::activeAudioSessionRequired const):

  • platform/audio/PlatformMediaSession.h:
  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::sharedPlatformMediaSessionManager):
(WebCore::PlatformMediaSessionManager::sharedManager):
(WebCore::PlatformMediaSessionManager::sharedManagerIfExists):
(WebCore::PlatformMediaSessionManager::create):
(WebCore::indexFromMediaType):
(WebCore::PlatformMediaSessionManager::resetRestrictions):
(WebCore::PlatformMediaSessionManager::has const):
(WebCore::PlatformMediaSessionManager::count const):
(WebCore::PlatformMediaSessionManager::countActiveAudioCaptureSources):
(WebCore::PlatformMediaSessionManager::addRestriction):
(WebCore::PlatformMediaSessionManager::removeRestriction):
(WebCore::PlatformMediaSessionManager::restrictions):
(WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback):
(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground):
(WebCore::PlatformMediaSessionManager::sessionIsPlayingToWirelessPlaybackTargetChanged):
(WebCore::PlatformMediaSessionManager::addAudioCaptureSource):
(WebCore::PlatformMediaSessionManager::removeAudioCaptureSource):

  • platform/audio/PlatformMediaSessionManager.h:
  • platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(PlatformMediaSessionManager::create):
(MediaSessionManagerCocoa::updateSessionState):

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::PlatformMediaSessionManager::create):
(WebCore::MediaSessionManageriOS::resetRestrictions):

  • platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::audioUnitWillStart):

  • platform/mediastream/MediaStreamTrackPrivate.h:
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/BaseAudioSharedUnit.cpp:

(WebCore::BaseAudioSharedUnit::startUnit):

  • platform/mediastream/mac/BaseAudioSharedUnit.h:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::audioUnitWillStart):

  • platform/mediastream/mac/CoreAudioCaptureSource.h:
  • testing/Internals.cpp:

(WebCore::mediaTypeFromString):
(WebCore::Internals::setMediaSessionRestrictions):
(WebCore::Internals::mediaSessionRestrictions const):

Source/WebKit:

Create a session manager for the GPUConnectionToWebProcess.
Pass it to any audio capture source proxy.
For UIProcesss audio capture, we still use the shared manager.

  • GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::sessionManager):

  • GPUProcess/GPUConnectionToWebProcess.h:
  • GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::setMockCaptureDevicesEnabled):

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::SourceProxy::SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::~SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManagerProxy::clone):

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
  • UIProcess/WebProcessProxy.cpp:

LayoutTests:

  • platform/ios/TestExpectations:
7:48 PM Changeset in webkit [257038] by Alan Coon
  • 15 edits in branches/safari-609-branch

Apply patch. rdar://problem/59611912

7:48 PM Changeset in webkit [257037] by Alan Coon
  • 17 edits in branches/safari-609-branch/Source/WebCore

Apply patch. rdar://problem/59611915

7:36 PM Changeset in webkit [257036] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Fix crash when Node::normalize() triggers mutation event that modifies child order
​https://bugs.webkit.org/show_bug.cgi?id=207875
<rdar://58976682>

Patch by Sunny He <​sunny_he@apple.com> on 2020-02-19
Reviewed by Ryosuke Niwa.

When Node::normalize() merges two text nodes, it calls appendData
before textNodesMerged. If there is a mutator event registered, it
will fire on the call to appendData, potentially changing the child
order and causing a nullptr crash due to incorrect sibling pointers.
Reverse the order of these calls to ensure order gets correctly
updated.

Source/WebCore:

Test: fast/dom/Node/normalize-mutation-event.html

  • dom/Node.cpp:

(WebCore::Node::normalize):

LayoutTests:

  • fast/dom/Node/normalize-mutation-event-expected.txt: Added.
  • fast/dom/Node/normalize-mutation-event.html: Added.
7:25 PM Changeset in webkit [257035] by Diego Pino Garcia
  • 73 edits in trunk/LayoutTests

[GTK][WPE] Gardening, update baselines of websocket tests
​https://bugs.webkit.org/show_bug.cgi?id=207947

Unreviewed gardening.

  • platform/gtk/http/tests/websocket/tests/hybi/broken-utf8-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/error-event-ready-state-non-existent-url-with-server-responding-404-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-error-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-invalid-http-version-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-accept-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-extensions-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-protocol-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-status-line-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-null-char-in-status-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/imported/blink/permessage-deflate-invalid-parameter-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/invalid-continuation-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/invalid-encode-length-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/invalid-masked-frames-from-server-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/long-control-frame-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/long-invalid-header-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/too-long-payload-expected.txt:
  • platform/gtk/http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/broken-utf8-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/error-event-ready-state-non-existent-url-with-server-responding-404-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-error-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-invalid-http-version-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-accept-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-extensions-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-protocol-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-status-line-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-null-char-in-status-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/imported/blink/permessage-deflate-invalid-parameter-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/invalid-continuation-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/invalid-encode-length-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/invalid-masked-frames-from-server-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/long-control-frame-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/long-invalid-header-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/too-long-payload-expected.txt:
  • platform/wpe/http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
7:01 PM Changeset in webkit [257034] by Ross Kirsling
  • 4 edits
    1 add in trunk

Computed Properties with increment sometimes produces incorrect results
​https://bugs.webkit.org/show_bug.cgi?id=170934

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/computed-property-increment.js: Added.
  • test262/expectations.yaml: Mark two test cases as passing.

Source/JavaScriptCore:

When the key and value of a computed property each have side effects, the eval order should be key-before-value.
Not only have we had this backwards, we've also been giving them both the same target register.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitPutConstantProperty):

7:00 PM Changeset in webkit [257033] by Alan Coon
  • 4 edits in branches/safari-609-branch/Source/JavaScriptCore

Apply patch. rdar://problem/59611919

6:59 PM Changeset in webkit [257032] by Alan Coon
  • 2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r257013. rdar://problem/59614282

Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
​https://bugs.webkit.org/show_bug.cgi?id=207973

Reviewed by Chris Dumez.

Use RefPtr to store Frame*.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:59 PM Changeset in webkit [257031] by Alan Coon
  • 9 edits
    2 adds in branches/safari-609-branch

Cherry-pick r256859. rdar://problem/59576018

[macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=207899
<rdar://problem/55658207>

Reviewed by Tim Horton and Simon Fraser.

Source/WebCore:

Mitigates a null pointer crash in ServicesOverlayController::buildPotentialHighlightsIfNeeded(), wherein the
focused frame may not have a FrameView when the ServicesOverlayController's selection invalidation timer fires.
This is possible if, while being focused, the newly focused subframe is unparented and reparented, which causes
it to momentarily have a null view. During this time, if a selection change had occurred earlier in the runloop,
it will schedule the page overlay controller invalidation timer, which will fire and discover that the currently
focused frame no longer has a FrameView.

Test: editing/selection/selection-change-in-disconnected-frame-crash.html

  • page/mac/ServicesOverlayController.mm: (WebCore::ServicesOverlayController::buildSelectionHighlight):

Source/WebKit:

Add another missing null check on iOS, for the case where FrameView is null.

  • WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::platformEditorState const):

Tools:

Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.

  • WebKitTestRunner/TestController.cpp: (WTR::updateTestOptionsFromTestHeader):
  • WebKitTestRunner/TestOptions.h: (WTR::TestOptions::hasSameInitializationOptions const):
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView):

LayoutTests:

Add a new layout test to verify that we don't crash under this circumstance.

  • editing/selection/selection-change-in-disconnected-frame-crash-expected.txt: Added.
  • editing/selection/selection-change-in-disconnected-frame-crash.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:59 PM Changeset in webkit [257030] by Alan Coon
  • 2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r256790. rdar://problem/59576023

Data detectors do not trigger on macCatalyst
​https://bugs.webkit.org/show_bug.cgi?id=207860
<rdar://problem/59038913>

Reviewed by Tim Horton.

The lookup gesture which run data detection needs touch information to function. Allow touches to be sent to the gesture.

  • UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView gestureRecognizer:shouldReceiveTouch:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:43 PM Changeset in webkit [257029] by pvollan@apple.com
  • 4 edits
    1 move in trunk/Source

[iOS] Rename NSUserDefaultsSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=207977
<rdar://problem/59609174>
Source/WebCore/PAL:

Reviewed by Brent Fulgham.

  • PAL.xcodeproj/project.pbxproj:
  • pal/spi/cocoa/NSUserDefaultsSPI.h: Removed.
  • pal/spi/cocoa/UserDefaultsSPI.h: Copied from Source/WebCore/PAL/pal/spi/cocoa/NSUserDefaultsSPI.h.

Source/WebKit:

Reviewed by Brent Fulgham.

No new tests, no behavior change.

  • UIProcess/Cocoa/PreferenceObserver.h:
6:33 PM Changeset in webkit [257028] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.0.2

Tag Safari-609.1.20.0.2.

6:31 PM Changeset in webkit [257027] by Alan Coon
  • 1 edit in branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp

Unreviewed build fix.

6:29 PM Changeset in webkit [257026] by Alan Coon
  • 8 edits in branches/safari-609.1.20.0-branch/Source

Versioning.

6:12 PM Changeset in webkit [257025] by ysuzuki@apple.com
  • 2 edits in trunk/Source/WebKit

NetworkCache should use 4KB threshold for mmap-ed files instead of 16KB
​https://bugs.webkit.org/show_bug.cgi?id=207882

Reviewed by Alex Christensen.

We found that a lot of Vectors in Membuster is holding resource content. This is because we have 16KB threshold for mmap-ed files.
If a file is smaller than 16KB, it is copied to Vector instead. But this is costly in terms of memory. If we use mmap-ed files,
it becomes named-pages instead of anonymous-pages. File-backed non-dirty named-pages have a lot of benefit.

  1. The application is offering a hint that pages are file-backed. This means that OS can purge them at any time since the content can be recovered from the disk. This is cheaper than swapping / compressing anonymous pages since just discarding works.
  2. The application is offering a hint that pages have spatial locality. Purging pages in one named-pages region is better compared to purging the same # of anonymous pages randomly. Anonymous pages are split by malloc implementation and access pattern of pages in one VA is random. On the other hand, named-pages are accessed together because it is file, and file typically has sequential locality. And recovery of named pages are also cheap compared to anonymous pages since OS can prefetch pages once access happens because of sequential locality of files. This tendency makes OS like purging named pages instead of anonymous pages. In WebKit use case, this works perfectly. CachedResource typically has decoded content. So typically WebProcess does not access SharedBuffer after the content is decoded.

This patch reduces the threshold from 16KB to page size (4KB in macOS, 16KB in iOS). This is pre-2015 behavior.
This offers 2.56% progression with 98% probability in Membuster.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::maximumInlineBodySize):
(WebKit::NetworkCache::estimateRecordsSize):
(WebKit::NetworkCache::Storage::shouldStoreBodyAsBlob):

6:09 PM Changeset in webkit [257024] by Fujii Hironori
  • 7 edits in trunk/Tools

[Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
​https://bugs.webkit.org/show_bug.cgi?id=207749

Reviewed by Ross Kirsling.

Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.

  • MiniBrowser/win/MainWindow.cpp:

(MainWindow::createToolbar):
(MainWindow::WndProc):
(MainWindow::setDefaultURLToCurrentURL):
(MainWindow::goHome): Added.
(MainWindow::onURLBarEnter):

  • MiniBrowser/win/MainWindow.h:
  • MiniBrowser/win/MiniBrowserLib.rc:
  • MiniBrowser/win/MiniBrowserLibResource.h:
  • MiniBrowser/win/MiniBrowserReplace.h:
  • MiniBrowser/win/WinMain.cpp:

(wWinMain):

5:55 PM Changeset in webkit [257023] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.0.1

Tag Safari-609.1.20.0.1.

5:54 PM Changeset in webkit [257022] by Alan Coon
  • 1 delete in tags/Safari-609.1.20.0.1

Delete tag.

5:52 PM Changeset in webkit [257021] by Alan Coon
  • 18 edits in branches/safari-609.1.20.0-branch

Apply patch. rdar://problem/59465474

5:52 PM Changeset in webkit [257020] by Alan Coon
  • 26 edits in branches/safari-609.1.20.0-branch

Cherry-pick r256632. rdar://problem/59478906

NetworkLoadMetrics should be shared by multiple ResourceResponse instances
​https://bugs.webkit.org/show_bug.cgi?id=207747

Reviewed by Keith Miller.

Source/WebCore:

ResourceResponse is value data, and it is copied multiple times in various places, (1) to create a new ResourceResponse
which has slightly different fields, or (1) to hold ResourceResponse even after loading finishes. For example, DocumentLoader
has Vector<ResourceResponse> to replay response dispatching in the case of loading from BackForwardCache. The problem is
that ResourceResponse is very large: 440 bytes.

While we sometimes copy ResourceResponse to modify some part of it, NetworkLoadMetrics is immutable. It is set when response is created,
and is never changed. And NetworkLoadMetrics is large: sizeof(NetworkLoadMetrics) is 184 bytes. Given that we have multiple
copies of ResourceResponse in WebCore, we should share NetworkLoadMetrics by them.

This patch puts Box<NetworkLoadMetrics> in ResourceResponse to share it with all copied ResourceResponses. We do not make NetworkLoadMetrics
RefCounted<> for now since some legit data structures embed NetworkLoadMetrics. This patch adds ArgumentCoder for Box so that we
can encode / decode Box<NetworkLoadMetrics> in ResourceResponse in IPC. To ensure NetworkLoadMetrics in ResourceResponse immutable,
we add ResourceResponse::setDeprecatedNetworkLoadMetrics instead of modifying NetworkLoadMetrics already created in ResourceResponse.

We also attempt to compact ResourceResponse more by using bit-fields. And removing m_isValid field in ParsedContentRange since
this can be represented by the different field. These changes make sizeof(ResourceResponse) from 440 to 248.

No behavior change.

  • inspector/agents/InspectorNetworkAgent.cpp: (WebCore::InspectorNetworkAgent::buildObjectForTiming): (WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
  • inspector/agents/InspectorNetworkAgent.h:
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading):
  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::domainLookupStart const): (WebCore::PerformanceTiming::domainLookupEnd const): (WebCore::PerformanceTiming::connectStart const): (WebCore::PerformanceTiming::connectEnd const): (WebCore::PerformanceTiming::secureConnectionStart const): (WebCore::PerformanceTiming::requestStart const): (WebCore::PerformanceTiming::responseStart const):
  • platform/network/NetworkLoadMetrics.h:
  • platform/network/ParsedContentRange.cpp: (WebCore::areContentRangeValuesValid): (WebCore::parseContentRange): (WebCore::ParsedContentRange::ParsedContentRange): (WebCore::ParsedContentRange::headerValue const):
  • platform/network/ParsedContentRange.h: (WebCore::ParsedContentRange::isValid const): (WebCore::ParsedContentRange::invalidValue): (WebCore::ParsedContentRange::MarkableTraits::isEmptyValue): (WebCore::ParsedContentRange::MarkableTraits::emptyValue): (WebCore::ParsedContentRange::ParsedContentRange): Deleted.
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::crossThreadData const): (WebCore::ResourceResponseBase::fromCrossThreadData): (WebCore::ResourceResponseBase::compare):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::deprecatedNetworkLoadMetricsOrNull const): (WebCore::ResourceResponseBase::setDeprecatedNetworkLoadMetrics): (WebCore::ResourceResponseBase::encode const): (WebCore::ResourceResponseBase::decode): (WebCore::ResourceResponseBase::deprecatedNetworkLoadMetrics const): Deleted.
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/cocoa/NetworkLoadMetrics.mm: (WebCore::copyTimingData):
  • platform/network/curl/CurlResourceHandleDelegate.cpp: (WebCore::CurlResourceHandleDelegate::curlDidReceiveResponse):
  • platform/network/curl/ResourceResponse.h:
  • platform/network/curl/ResourceResponseCurl.cpp: (WebCore::ResourceResponse::setDeprecatedNetworkLoadMetrics): Deleted.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::getConnectionTimingData):
  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):

Source/WebKit:

Add ArgumentCoder support for Box<T>.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
  • NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):
  • Platform/IPC/ArgumentCoders.h: (IPC::ArgumentCoder<Box<T>>::encode): (IPC::ArgumentCoder<Box<T>>::decode):

Tools:

  • TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [257019] by Alan Coon
  • 17 edits
    2 copies in branches/safari-609.1.20.0-branch/Source/WebCore

Cherry-pick r256610. rdar://problem/59478918

[Web Animations] Make all animation event types inherit from the same base class
​https://bugs.webkit.org/show_bug.cgi?id=207629

Reviewed by Simon Fraser.

Currently we dispatch events CSS Transitions and CSS Animations events using a dedicated event queue on DeclarativeAnimation, while the events
added by the Web Animations specification (of type AnimationPlaybackEvent) are dispatched using a shared queue on the DocumentTimeline that is
processed during the "update animations and send events procedure". The Web Animations specification dictates that all events should be dispatched
during that procedure, which includes sorting of such events based on their timeline time and associated animation relative composite order.

In this patch, we prepare the work towards spec compliance for animation events dispatch by making all event types (AnimationPlaybackEvent,
TransitionEvent and AnimationEvent) inherit from a single AnimationEventBase interface. This will allow DocumentTimeline to enqueue, sort and
dispatch all such events with a single queue in a future patch.

Due to CSSAnimationController, we must make the "timeline time" and "animation" parameters optional. When we drop support for CSSAnimationController
we'll be able to enforce stronger requirements for these.

No new test since this should not introduce any behavior change.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/AnimationEventBase.cpp: Added. (WebCore::AnimationEventBase::AnimationEventBase):
  • animation/AnimationEventBase.h: Added. (WebCore::AnimationEventBase::create): (WebCore::AnimationEventBase::isAnimationPlaybackEvent const): (WebCore::AnimationEventBase::isAnimationEvent const): (WebCore::AnimationEventBase::isTransitionEvent const): (WebCore::AnimationEventBase::timelineTime const): (WebCore::AnimationEventBase::animation const):
  • animation/AnimationPlaybackEvent.cpp: (WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent): (WebCore::AnimationPlaybackEvent::bindingsTimelineTime const):
  • animation/AnimationPlaybackEvent.h:
  • animation/CSSAnimation.cpp: (WebCore::CSSAnimation::createEvent):
  • animation/CSSAnimation.h:
  • animation/CSSTransition.cpp: (WebCore::CSSTransition::createEvent):
  • animation/CSSTransition.h:
  • animation/DeclarativeAnimation.cpp: (WebCore::DeclarativeAnimation::enqueueDOMEvent):
  • animation/DeclarativeAnimation.h:
  • animation/WebAnimation.cpp: (WebCore::WebAnimation::enqueueAnimationPlaybackEvent):
  • dom/AnimationEvent.cpp: (WebCore::AnimationEvent::AnimationEvent):
  • dom/AnimationEvent.h:
  • dom/TransitionEvent.cpp: (WebCore::TransitionEvent::TransitionEvent):
  • dom/TransitionEvent.h:
  • page/animation/CSSAnimationController.cpp: (WebCore::CSSAnimationControllerPrivate::fireEventsAndUpdateStyle):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [257018] by Alan Coon
  • 4 edits
    2 adds in branches/safari-609.1.20.0-branch

Cherry-pick r256513. rdar://problem/59446986

REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side
​https://bugs.webkit.org/show_bug.cgi?id=207674
rdar://problem/59404866

Reviewed by Antti Koivisto.

Source/WebCore:

Remove the early return in ScrollingStateScrollingNode::setRequestedScrollData(); comparing
with the last m_requestedScrollData is wrong, because requested scroll positions are not "state"
in the scrolling tree, they are requests to scroll. Ideally, they would be represented in some
different way in the scrolling tree.

Test: fast/scrolling/programmatic-scroll-to-zero-zero.html

  • page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::setRequestedScrollData):

LayoutTests:

Test that does a programmatic scroll to 0,0, does a user scroll, then a second programmatic scroll to 0,0,
which is expected to work.

  • fast/scrolling/programmatic-scroll-to-zero-zero-expected.html: Added.
  • fast/scrolling/programmatic-scroll-to-zero-zero.html: Added.
  • platform/ios/TestExpectations: Skip the new test on iOS (it relies on eventSender) and sort the grouping.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [257017] by Alan Coon
  • 2 edits in branches/safari-609.1.20.0-branch/LayoutTests

Cherry-pick r256435. rdar://problem/59446986

REGRESSION: (256400) tiled-drawing/scrolling/fixed/fixed-during-rubberband.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=207631

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [257016] by Alan Coon
  • 3 edits in branches/safari-609.1.20.0-branch/Source/WebCore

Cherry-pick r256400. rdar://problem/59446986

Unreviewed, partial rollout of r255037.
<rdar://problem/59240559>

  • page/scrolling/cocoa/ScrollingTreeFixedNode.mm: (WebCore::ScrollingTreeFixedNode::applyLayerPositions):
  • page/scrolling/cocoa/ScrollingTreeStickyNode.mm: (WebCore::ScrollingTreeStickyNode::computeLayerPosition const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [257015] by Alan Coon
  • 29 edits
    4 copies
    6 adds in branches/safari-609.1.20.0-branch

Cherry-pick r256191. rdar://problem/59447003

Disallow setting base URL to a data or JavaScript URL
​https://bugs.webkit.org/show_bug.cgi?id=207136

Source/WebCore:

Reviewed by Brent Fulgham.

Inspired by <​https://bugs.chromium.org/p/chromium/issues/detail?id=679318>.

Block setting the base URL to a data URL or JavaScript URL as such usage is questionable.
This makes WebKit match the behavior of Chrome and Firefox and is in the spirit of the
discussion in <​https://github.com/whatwg/html/issues/2249>.

On Mac and iOS, this restriction is applied only to apps linked against a future SDK to
avoid breaking shipped apps.

For all other ports, this restriction is enabled by default.

Tests: fast/url/relative2.html

fast/url/segments-from-data-url2.html
http/tests/security/allowed-base-url-data-url-via-setting.html
http/tests/security/denied-base-url-data-url.html
http/tests/security/denied-base-url-javascript-url.html

  • dom/Document.cpp: (WebCore::Document::processBaseElement): Condition updating the parsed base URL on whether is has an allowed scheme, if restrictions are enabled. Otherwise, do what we do now. If the scheme is disallowed then log a message to the console to explain this to web developers.
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::TokenPreloadScanner::scan): Pass whether to apply restrictons to the base URL to updatePredictedBaseURL(). This depends on whether the setting is enabled or not. (WebCore::TokenPreloadScanner::updatePredictedBaseURL): Modifed to take a boolean as to whether to apply restrictions. If restrictions are not to be applied do what we do now. Otherwise, only do what we do now if the scheme for the predicated base URL is allowed.
  • html/parser/HTMLPreloadScanner.h:
  • page/SecurityPolicy.cpp: (WebCore::SecurityPolicy::isBaseURLSchemeAllowed): Added.
  • page/SecurityPolicy.h:
  • page/Settings.yaml: Add a setting to toggle restrictions on the base URL scheme.

Source/WebKit:

Reviewed by Brent Fulgham.

Apply base URL restrictions to apps linked to a future WebKit to avoid breaking existing apps.

  • Shared/WebPreferences.yaml:
  • UIProcess/API/Cocoa/WKWebView.mm: (shouldRestrictBaseURLSchemes): Added. (-[WKWebView _setupPageConfiguration:]): Update settings.
  • UIProcess/Cocoa/VersionChecks.h:

Source/WebKitLegacy/mac:

Reviewed by Brent Fulgham.

Apply base URL restrictions to apps linked to a future WebKit to avoid breaking existing apps.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (shouldRestrictBaseURLSchemes): Added. (-[WebView _commonInitializationWithFrameName:groupName:]): Update settings.

Source/WTF:

Reviewed by Brent Fulgham.

Add some more macro definitions.

  • wtf/spi/darwin/dyldSPI.h:

LayoutTests:

RReviewed by Brent Fulgham.

Add some tests. Update others to toggle the setting to apply or unapply the new behavior.

The test denied-base-url-javascript-url.html is derived from the test base-url-javascript.html,
included in <​https://chromium.googlesource.com/chromium/src.git/+/c133efa0b915430701930b76a7cfe35608b9a403>.

  • fast/url/relative-expected.txt:
  • fast/url/relative.html:
  • fast/url/relative2-expected.txt: Copied from LayoutTests/fast/url/relative-expected.txt.
  • fast/url/relative2.html: Copied from LayoutTests/fast/url/relative.html.
  • fast/url/resources/utilities.js: (setShouldEllipsizeFileURLPaths): Added. Toggles ellipsizing the path portion of a file URL to simplify matching. Otherwise, file URLs could be machine-specific. (canonicalizedPathname): Added. (segments): Modified to optionally call canonicalizedPathname. (canonicalize): Ditto.
  • fast/url/segments-from-data-url-expected.txt:
  • fast/url/segments-from-data-url.html:
  • fast/url/segments-from-data-url2-expected.txt: Copied from LayoutTests/fast/url/segments-from-data-url-expected.txt.
  • fast/url/segments-from-data-url2.html: Copied from LayoutTests/fast/url/segments-from-data-url.html.
  • fetch/fetch-url-serialization-expected.txt:
  • http/tests/plugins/navigation-during-load-embed.html:
  • http/tests/plugins/navigation-during-load.html:
  • http/tests/security/allowed-base-url-data-url-via-setting-expected.txt: Added.
  • http/tests/security/allowed-base-url-data-url-via-setting.html: Added.
  • http/tests/security/denied-base-url-data-url-expected.txt: Added.
  • http/tests/security/denied-base-url-data-url.html: Added.
  • http/tests/security/denied-base-url-javascript-url-expected.txt: Added.
  • http/tests/security/denied-base-url-javascript-url.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:51 PM Changeset in webkit [257014] by Alan Coon
  • 43 edits
    5 adds in branches/safari-609.1.20.0-branch

Cherry-pick r255037. rdar://problem/59446986

Fixed elements no longer stay fixed with elastic overscroll
​https://bugs.webkit.org/show_bug.cgi?id=206227
rdar://problem/58707084

Reviewed by Antti Koivisto.
Source/WebCore:

Intended behavior on iOS and macOS is for position:fixed and sticky elements to maintain
their position relative to the view bounds when rubber-banding ("overscrolling"). This broke
some time back. This change restores the correct behavior with the call to layoutViewportRespectingRubberBanding()
in ScrollingTreeFixedNode::applyLayerPositions() and ScrollingTreeStickyNode::computeLayerPosition().
layoutViewportRespectingRubberBanding() computes a layout viewport without clamping.

The rest of the changes are to support testing. internals.unconstrainedScrollTo()
didn't work for main frame scrolling because of scroll position clamping in various places,
so propagate ScrollClamping in more places (and replace the redundant ScrollPositionClamp with ScrollClamping).

"requested scroll position" updates now carry along both clamping and "is programmatic" data, wrapped in a struct
which is passed around the scrolling tree. This allows us to not clamp the scroll position (for testing) in more places.

Internals::unconstrainedScrollTo() needs one weird hack to trigger a layout (and thus a scrolling tree commit),
because the layout is normally triggered by a layout viewport change, but when rubber-banding we clamp the layoutViewport
used for layout, so those layouts are never triggered.

Tests: tiled-drawing/scrolling/fixed/fixed-during-rubberband.html

tiled-drawing/scrolling/sticky/sticky-during-rubberband.html

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.cpp: (WebCore::Element::scrollTo):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo const):
  • page/FrameView.cpp: (WebCore::FrameView::setScrollPosition): (WebCore::FrameView::requestScrollPositionUpdate):
  • page/FrameView.h:
  • page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
  • page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::setRequestedScrollData): (WebCore::ScrollingStateScrollingNode::dumpProperties const): (WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition): Deleted.
  • page/scrolling/ScrollingStateScrollingNode.h: (WebCore::RequestedScrollData::operator== const): (WebCore::ScrollingStateScrollingNode::requestedScrollData const): (WebCore::ScrollingStateScrollingNode::requestedScrollPosition const): Deleted. (WebCore::ScrollingStateScrollingNode::requestedScrollPositionRepresentsProgrammaticScroll const): Deleted.
  • page/scrolling/ScrollingTree.h: (WebCore::ScrollingTree::scrollingTreeNodeRequestsScroll):
  • page/scrolling/ScrollingTreeFrameScrollingNode.cpp: (WebCore::ScrollingTreeFrameScrollingNode::layoutViewportForScrollPosition const): (WebCore::ScrollingTreeFrameScrollingNode::layoutViewportRespectingRubberBanding const):
  • page/scrolling/ScrollingTreeFrameScrollingNode.h:
  • page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::commitStateAfterChildren): (WebCore::ScrollingTreeScrollingNode::adjustedScrollPosition const): (WebCore::ScrollingTreeScrollingNode::scrollBy): (WebCore::ScrollingTreeScrollingNode::scrollTo): (WebCore::ScrollingTreeScrollingNode::wasScrolledByDelegatedScrolling):
  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/cocoa/ScrollingTreeFixedNode.mm: (WebCore::ScrollingTreeFixedNode::applyLayerPositions):
  • page/scrolling/cocoa/ScrollingTreeStickyNode.mm: (WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm: (WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateAfterChildren): (WebCore::ScrollingTreeFrameScrollingNodeMac::adjustedScrollPosition const):
  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm: (WebCore::ScrollingTreeOverflowScrollingNodeMac::commitStateAfterChildren): (WebCore::ScrollingTreeOverflowScrollingNodeMac::adjustedScrollPosition const):
  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::immediateScrollByWithoutContentEdgeConstraints):
  • platform/ScrollTypes.cpp: Added. (WebCore::operator<<):
  • platform/ScrollTypes.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::setContentsScrollPosition): (WebCore::ScrollView::setScrollPosition):
  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::setScrollOffsetFromAnimation):
  • platform/ScrollableArea.h: (WebCore::ScrollableArea::requestScrollPositionUpdate):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
  • testing/Internals.cpp: (WebCore::Internals::unconstrainedScrollTo):

Source/WebKit:

Intended behavior on iOS and macOS is for position:fixed and sticky elements to maintain
their position relative to the view bounds when rubber-banding ("overscrolling"). This broke
some time back. This change restores the correct behavior with the call to layoutViewportRespectingRubberBanding()
in ScrollingTreeFixedNode::applyLayerPositions() and ScrollingTreeStickyNode::computeLayerPosition().
layoutViewportRespectingRubberBanding() computes a layout viewport without clamping.

The rest of the changes are to support testing. internals.unconstrainedScrollTo()
didn't work for main frame scrolling because of scroll position clamping in various places,
so propagate ScrollClamping in more places (and replace the redundant ScrollPositionClamp with ScrollClamping).

"requested scroll position" updates now carry along both clamping and "is programmatic" data, wrapped in a struct
which is passed around the scrolling tree. This allows us to not clamp the scroll position (for testing) in more places.

  • Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp: (ArgumentCoder<ScrollingStateScrollingNode>::encode): (ArgumentCoder<ScrollingStateScrollingNode>::decode): (ArgumentCoder<RequestedScrollData>::encode): (ArgumentCoder<RequestedScrollData>::decode): (WebKit::dump):
  • UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeRequestsScroll):
  • UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
  • UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp: (WebKit::RemoteScrollingTree::scrollingTreeNodeRequestsScroll):
  • UIProcess/RemoteLayerTree/RemoteScrollingTree.h:
  • UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm: (WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::commitStateAfterChildren):
  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: (WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateAfterChildren):

LayoutTests:

  • tiled-drawing/scrolling/fixed/fixed-during-rubberband-expected.html: Added.
  • tiled-drawing/scrolling/fixed/fixed-during-rubberband.html: Added.
  • tiled-drawing/scrolling/sticky/sticky-during-rubberband-expected.html: Added.
  • tiled-drawing/scrolling/sticky/sticky-during-rubberband.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@255037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:50 PM Changeset in webkit [257013] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit

Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
​https://bugs.webkit.org/show_bug.cgi?id=207973

Reviewed by Chris Dumez.

Use RefPtr to store Frame*.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):

5:27 PM Changeset in webkit [257012] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

[ Mac ] imported/w3c/web-platform-tests/service-workers/service-worker/resource-timing.sub.https.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=207978

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:26 PM Changeset in webkit [257011] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.1.1

Tag Safari-609.1.20.1.1.

5:26 PM Changeset in webkit [257010] by Alan Coon
  • 1 delete in tags/Safari-609.1.20.1.1

Delete tag.

5:24 PM Changeset in webkit [257009] by Alan Coon
  • 1 edit in branches/safari-609.1.20.1-branch/Source/WebKit/Shared/WebPreferences.yaml

Unreviewed build fix. rdar://problem/59576820

5:12 PM Changeset in webkit [257008] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Avoid preconnecting to custom URL schemes
​https://bugs.webkit.org/show_bug.cgi?id=207964

Patch by Ben Nham <Ben Nham> on 2020-02-19
Reviewed by Ryosuke Niwa.

This makes NetworkProcess::preconnectTo not preconnect to custom URL schemes. This matches
the existing behavior in NetworkConnectionToWebProcess::preconnectTo.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::preconnectTo):

5:12 PM Changeset in webkit [257007] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.101.1

Tag Safari-609.1.20.101.1.

5:07 PM Changeset in webkit [257006] by Alan Coon
  • 8 edits in branches/safari-609.1.20.101-branch/Source

Versioning.

5:01 PM Changeset in webkit [257005] by Russell Epstein
  • 1 copy in tags/Safari-609.1.20.1.1

Tag Safari-609.1.20.1.1.

4:59 PM Changeset in webkit [257004] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.0.1

Tag Safari-609.1.20.0.1.

4:57 PM Changeset in webkit [257003] by Peng Liu
  • 5 edits in trunk

Fix check-webkit-style errors related to AVFoundationSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=207834

Reviewed by Daniel Bates.

Source/WebCore:

No new tests, no functional change.

Revert the change in r256770 regarding the headers ordering.

  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

Tools:

Revert the change in r256770 regarding the headers ordering.
Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_include_line):

4:55 PM Changeset in webkit [257002] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.100.1

Tag Safari-609.1.20.100.1.

4:49 PM Changeset in webkit [257001] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][Integration] Do not try to lay out a formatting context unless there's some content in it
​https://bugs.webkit.org/show_bug.cgi?id=207956
<rdar://problem/59455700>

Reviewed by Simon Fraser.

LineLayout::layout() normally don't get called when the block level box has not children (canUse() returns false for such cases), but we are probably missing some invalidation here
so we end up with an "empty" formatting context.

  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::layout):

4:49 PM Changeset in webkit [257000] by Russell Epstein
  • 8 edits in branches/safari-609.1.20.100-branch/Source

Versioning.

4:48 PM Changeset in webkit [256999] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[First paint] Introduce FrameView::m_firstVisuallyNonEmptyLayoutMilestoneIsPending
​https://bugs.webkit.org/show_bug.cgi?id=207966
<rdar://problem/59606528>

Reviewed by Simon Fraser.

This is in preparation for decoupling the "content is qualified as visually non-empty" check and layout, when
the check happens soon after style recalc/render tree building and we need to wait until after layout to
issue the milestone.

  • page/FrameView.cpp:

(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):

  • page/FrameView.h:
4:45 PM Changeset in webkit [256998] by Alan Coon
  • 1 delete in tags/Safari-609.1.20.0.1

Delete tag.

4:41 PM Changeset in webkit [256997] by Alan Coon
  • 17 edits in branches/safari-609.1.20.0-branch/Source/WebCore

Revert r256989. rdar://problem/59298138

4:41 PM Changeset in webkit [256996] by Alan Coon
  • 4 edits in branches/safari-609.1.20.0-branch/Source/JavaScriptCore

Revert r256988. rdar://problem/59478911

4:41 PM Changeset in webkit [256995] by Alan Coon
  • 13 edits in branches/safari-609.1.20.0-branch

Revert r256963. rdar://problem/59478837

4:40 PM Changeset in webkit [256994] by Kocsen Chung
  • 1 copy in branches/safari-609.1.20.101-branch

New branch.

4:37 PM Changeset in webkit [256993] by Kocsen Chung
  • 1 copy in branches/safari-609.1.20.100-branch

New branch.

4:29 PM Changeset in webkit [256992] by Alan Coon
  • 15 edits in branches/safari-609.1.20.1-branch/Source/JavaScriptCore

Apply patch. rdar://problem/59576803

4:29 PM Changeset in webkit [256991] by Alan Coon
  • 1 edit in branches/safari-609.1.20.1-branch/Source/JavaScriptCore/runtime/OptionsList.h

Apply patch. rdar://problem/59576777

3:59 PM Changeset in webkit [256990] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.0.1

Tag Safari-609.1.20.0.1.

3:56 PM Changeset in webkit [256989] by Alan Coon
  • 17 edits in branches/safari-609.1.20.0-branch/Source/WebCore

Apply patch. rdar://problem/59298138

3:54 PM Changeset in webkit [256988] by Alan Coon
  • 4 edits in branches/safari-609.1.20.0-branch/Source/JavaScriptCore

Apply patch. rdar://problem/59478911

3:45 PM Changeset in webkit [256987] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

[ Mac ] css3/selectors3/xml/css3-modsel-d1.xml is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=207971

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:39 PM Changeset in webkit [256986] by Russell Epstein
  • 18 edits in branches/safari-609.1.20.1-branch

Apply patch. rdar://problem/59576808

3:39 PM Changeset in webkit [256985] by Russell Epstein
  • 34 edits
    2 adds in branches/safari-609.1.20.1-branch/Source

Apply patch. rdar://problem/59576778

3:38 PM Changeset in webkit [256984] by Russell Epstein
  • 2 edits in branches/safari-609.1.20.1-branch/Source/WebCore

Cherry-pick r256584. rdar://problem/59576819

MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo()
​https://bugs.webkit.org/show_bug.cgi?id=207733
<rdar://problem/59441647>

Reviewed by Maciej Stachowiak.

  • platform/mac/PlatformScreenMac.mm: (WebCore::setShouldOverrideScreenSupportsHighDynamicRange):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:38 PM Changeset in webkit [256983] by Russell Epstein
  • 11 edits in branches/safari-609.1.20.1-branch/Source

Cherry-pick r255881. rdar://problem/59576819

Adopt MTOverrideShouldPlayHDRVideo()
​https://bugs.webkit.org/show_bug.cgi?id=207275
<rdar://problem/58837093>

Reviewed by Eric Carlson.

Source/WebCore:

  • platform/PlatformScreen.h:
  • platform/mac/PlatformScreenMac.mm: (WebCore::setShouldOverrideScreenSupportsHighDynamicRange):

Source/WebCore/PAL:

  • pal/cocoa/MediaToolboxSoftLink.cpp:
  • pal/cocoa/MediaToolboxSoftLink.h:

Source/WebKit:

The WebProcess sandbox can block access to the services necessary for MediaToolbox to determine whether
the current display is capable of displaying HDR. Rather than opening up the sandbox, provide the information
gathered by the UIProcess by way of MTOverrideShouldPlayHDRVideo().

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::windowScreenDidChange): (WebKit::WebPage::displayID const):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::setScreenProperties): Deleted.
  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::setScreenProperties): (WebKit::WebProcess::updatePageScreenProperties):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@255881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:38 PM Changeset in webkit [256982] by Russell Epstein
  • 2 edits in branches/safari-609.1.20.1-branch/Source/JavaScriptCore

Cherry-pick r256898. rdar://problem/59576798

Unreviewed build fix.

  • jit/JITThunks.cpp: (JSC::JITThunks::hostFunctionStub):

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-609-branch@256898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:38 PM Changeset in webkit [256981] by Russell Epstein
  • 3 edits in branches/safari-609.1.20.1-branch/JSTests

Cherry-pick r256698. rdar://problem/59576809

Unreviewed: fix broken tests added in r256665
​https://bugs.webkit.org/show_bug.cgi?id=207727

Our inline WAT doesn't seem to like named blocks/branch targets.

  • wasm/regress/llint-callee-saves-with-fast-memory.js:
  • wasm/regress/llint-callee-saves-without-fast-memory.js:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:38 PM Changeset in webkit [256980] by Russell Epstein
  • 9 edits
    2 adds in branches/safari-609.1.20.1-branch

Cherry-pick r256665. rdar://problem/59576809

[WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention.
​https://bugs.webkit.org/show_bug.cgi?id=207727

JSTests:

Reviewed by Mark Lam.

  • wasm/regress/llint-callee-saves-with-fast-memory.js: Added.
  • wasm/regress/llint-callee-saves-without-fast-memory.js: Added.

Source/JavaScriptCore:

Reviewed by Mark Lam.

The Wasm JIT has unusual calling conventions, which were further complicated by the addition
of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly
saving and restoring the callee save registers used for the memory base and size). Here's a summary
of the calling convention:

  • When entering Wasm from JS, the wrapper must:
    • Preserve the base and size when entering LLInt regardless of the mode. (Prior to this patch we only preserved the base in Signaling mode)
    • Preserve the memory base in either mode, and the size for BoundsChecking.
  • Both tiers must preserve every *other* register they use. e.g. the LLInt must preserve PB and wasmInstance, but must *not* preserve memoryBase and memorySize.
  • Changes to memoryBase and memorySize are visible to the caller. This means that:
    • Intra-module calls can assume these registers are up-to-date even if the memory was resized. The only exception here is if the LLInt calls a signaling JIT, in which case the JIT will not update the size register, since it won't be using it.
    • Inter-module and JS calls require the caller to reload these registers. These calls may result in memory changes (e.g. the callee may call memory.grow).
    • A Signaling JIT caller must be aware that the LLInt may trash the size register, since it always bounds checks.
  • llint/WebAssembly.asm:
  • wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::addCall):
  • wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::addCall):
  • wasm/WasmCallee.cpp: (JSC::Wasm::LLIntCallee::calleeSaveRegisters):
  • wasm/WasmCallingConvention.h:
  • wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation):
  • wasm/WasmMemoryInformation.cpp: (JSC::Wasm::PinnedRegisterInfo::get): (JSC::Wasm::getPinnedRegisters): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:38 PM Changeset in webkit [256979] by Russell Epstein
  • 4 edits in branches/safari-609.1.20.1-branch

Cherry-pick r256432. rdar://problem/59576791

WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
​https://bugs.webkit.org/show_bug.cgi?id=207537

Reviewed by Chris Dumez.

Source/WebKit:

Covered by added API test.

  • NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::registerServiceWorkerClient): Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:38 PM Changeset in webkit [256978] by Russell Epstein
  • 4 edits in branches/safari-609.1.20.1-branch

Cherry-pick r256383. rdar://problem/59576791

Unreviewed, rolling out r256314.
​https://bugs.webkit.org/show_bug.cgi?id=207594

It is breaking an API test (Requested by youenn on #webkit).

Reverted changeset:

"WebSWServerConnection::registerServiceWorkerClient is not
sending IPC message to UIProcess when it should"
​https://bugs.webkit.org/show_bug.cgi?id=207537
​https://trac.webkit.org/changeset/256314

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:38 PM Changeset in webkit [256977] by Russell Epstein
  • 9 edits
    1 add in branches/safari-609.1.20.1-branch

Cherry-pick r256779. rdar://problem/59576798

[JSC] JITThunk should be HashSet<Weak<NativeExecutable>> with appropriate GC weakness handling
​https://bugs.webkit.org/show_bug.cgi?id=207715

Reviewed by Darin Adler.

JSTests:

  • stress/stress-jitthunks.js: Added. (let.set newGlobal): (set catch):

Source/JavaScriptCore:

This patch refines JITThunks GC-aware Weak hash map for NativeExecutable. Previously, we have
HashMap<std::tuple<TaggedNativeFunction, TaggedNativeFunction, String>, Weak<NativeExecutable>> table.
But this is not good because the first tuple's information is already in NativeExecutable.
But we were using this design since Weak<NativeExecutable> can be nullified because of Weak<>. If this
happens, we could have invalid Entry in HashMap which does not have corresponding values. This will
cause crash when rehasing requires hash code for this entry.

But this HashMap is very bad in terms of memory usage. Each entry has 32 bytes, and this table gets enough
large. We identified that this table is consuming much memory in Membuster. So it is worth designing
carefully crafted data structure which only holds Weak<NativeExecutable> by leveraging the deep interaction
with our GC implementation.

This patch implements new design of JITThunks, which uses HashSet<Weak<NativeExecutable>> and carefully crafted
HashTraits / KeyTraits to handle Weak<> well.

  1. Each Weak should have finalizer, and this finalizer should remove dead Weak<NativeExecutable> from HashSet.

This is ensuring that all the keys in HashSet is, even if Weak<> is saying it is Dead, it still has an way
to access content of NativeExecutable if the content is not a JS objects. For example, we can get function
pointer from dead Weak<NativeExecutable> if it is not yet finalized. Since we remove all finalized Weak<>
from the table, this finalizer mechanism allows us to access function pointers etc. from Weak<NativeExecutable>
so long as it is held in this table.

  1. Getting NativeExecutable* from JITThunks should have special protocol.

When getting NativeExecutable* from JITThunks, we do the following,

  1. First, we check we have an Entry in JITThunks. If it does not exist, we should insert it anyway.

1.1. If it exists, we should check whether this Weak<NativeExecutable> is dead or not. It is possible that

dead one is still in the table because "dead" does not mean that it is "finalized". Until finalizing happens (and
it can be delayed by incremental-sweeper), Weak<NativeExecutable> can be dead but still accessible. So the table
is still holding dead one. If we get dead one, we should insert a new one.

1.2. If it is not dead, we return it.

  1. Second, we create a new NativeExecutable and insert it. In that case, it is possible that the table already has Weak<NativeExecutable>, but it is dead. In that case, we need to explicitly replace it with newly created one since old one is holding old content. If we replaced, finalizer of Weak<> will not be invoked since it immediately deallocates Weak<>. So, it does not happen that this newly inserted NativeExecutable* is removed by the finalizer registered by the old Weak<>.

This change makes memory usage of JITThunks table 1/4.

  • heap/Weak.cpp: (JSC::weakClearSlowCase):
  • heap/Weak.h: (JSC::Weak::Weak): (JSC::Weak::isHashTableEmptyValue const): (JSC::Weak::unsafeImpl const): (WTF::HashTraits<JSC::Weak<T>>::isEmptyValue):
  • heap/WeakInlines.h: (JSC::Weak<T>::Weak):
  • jit/JITThunks.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::WeakNativeExecutableHash::hash): (JSC::JITThunks::WeakNativeExecutableHash::equal): (JSC::JITThunks::HostKeySearcher::hash): (JSC::JITThunks::HostKeySearcher::equal): (JSC::JITThunks::NativeExecutableTranslator::hash): (JSC::JITThunks::NativeExecutableTranslator::equal): (JSC::JITThunks::NativeExecutableTranslator::translate): (JSC::JITThunks::finalize): (JSC::JITThunks::hostFunctionStub): (JSC::JITThunks::clearHostFunctionStubs): Deleted.
  • jit/JITThunks.h:
  • runtime/NativeExecutable.h:
  • tools/JSDollarVM.cpp: (JSC::functionGCSweepAsynchronously): (JSC::functionCreateEmptyFunctionWithName): (JSC::JSDollarVM::finishCreation):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:38 PM Changeset in webkit [256976] by Russell Epstein
  • 3 edits
    1 add in branches/safari-609.1.20.1-branch

Cherry-pick r256766. rdar://problem/59576813

[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
​https://bugs.webkit.org/show_bug.cgi?id=207849

Reviewed by Mark Lam.

JSTests:

  • wasm/regress/regress-256665.js: Added. (f):

Source/JavaScriptCore:

When generating the call IC, we should select the callee saves using BoundsChecking mode in order
to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
register when calling the Wasm LLInt through the call IC.

  • wasm/js/WebAssemblyFunction.cpp: (JSC::WebAssemblyFunction::calleeSaves const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:38 PM Changeset in webkit [256975] by Russell Epstein
  • 26 edits in branches/safari-609.1.20.1-branch

Cherry-pick r256632. rdar://problem/59576783

NetworkLoadMetrics should be shared by multiple ResourceResponse instances
​https://bugs.webkit.org/show_bug.cgi?id=207747

Reviewed by Keith Miller.

Source/WebCore:

ResourceResponse is value data, and it is copied multiple times in various places, (1) to create a new ResourceResponse
which has slightly different fields, or (1) to hold ResourceResponse even after loading finishes. For example, DocumentLoader
has Vector<ResourceResponse> to replay response dispatching in the case of loading from BackForwardCache. The problem is
that ResourceResponse is very large: 440 bytes.

While we sometimes copy ResourceResponse to modify some part of it, NetworkLoadMetrics is immutable. It is set when response is created,
and is never changed. And NetworkLoadMetrics is large: sizeof(NetworkLoadMetrics) is 184 bytes. Given that we have multiple
copies of ResourceResponse in WebCore, we should share NetworkLoadMetrics by them.

This patch puts Box<NetworkLoadMetrics> in ResourceResponse to share it with all copied ResourceResponses. We do not make NetworkLoadMetrics
RefCounted<> for now since some legit data structures embed NetworkLoadMetrics. This patch adds ArgumentCoder for Box so that we
can encode / decode Box<NetworkLoadMetrics> in ResourceResponse in IPC. To ensure NetworkLoadMetrics in ResourceResponse immutable,
we add ResourceResponse::setDeprecatedNetworkLoadMetrics instead of modifying NetworkLoadMetrics already created in ResourceResponse.

We also attempt to compact ResourceResponse more by using bit-fields. And removing m_isValid field in ParsedContentRange since
this can be represented by the different field. These changes make sizeof(ResourceResponse) from 440 to 248.

No behavior change.

  • inspector/agents/InspectorNetworkAgent.cpp: (WebCore::InspectorNetworkAgent::buildObjectForTiming): (WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
  • inspector/agents/InspectorNetworkAgent.h:
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading):
  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::domainLookupStart const): (WebCore::PerformanceTiming::domainLookupEnd const): (WebCore::PerformanceTiming::connectStart const): (WebCore::PerformanceTiming::connectEnd const): (WebCore::PerformanceTiming::secureConnectionStart const): (WebCore::PerformanceTiming::requestStart const): (WebCore::PerformanceTiming::responseStart const):
  • platform/network/NetworkLoadMetrics.h:
  • platform/network/ParsedContentRange.cpp: (WebCore::areContentRangeValuesValid): (WebCore::parseContentRange): (WebCore::ParsedContentRange::ParsedContentRange): (WebCore::ParsedContentRange::headerValue const):
  • platform/network/ParsedContentRange.h: (WebCore::ParsedContentRange::isValid const): (WebCore::ParsedContentRange::invalidValue): (WebCore::ParsedContentRange::MarkableTraits::isEmptyValue): (WebCore::ParsedContentRange::MarkableTraits::emptyValue): (WebCore::ParsedContentRange::ParsedContentRange): Deleted.
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::crossThreadData const): (WebCore::ResourceResponseBase::fromCrossThreadData): (WebCore::ResourceResponseBase::compare):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::deprecatedNetworkLoadMetricsOrNull const): (WebCore::ResourceResponseBase::setDeprecatedNetworkLoadMetrics): (WebCore::ResourceResponseBase::encode const): (WebCore::ResourceResponseBase::decode): (WebCore::ResourceResponseBase::deprecatedNetworkLoadMetrics const): Deleted.
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/cocoa/NetworkLoadMetrics.mm: (WebCore::copyTimingData):
  • platform/network/curl/CurlResourceHandleDelegate.cpp: (WebCore::CurlResourceHandleDelegate::curlDidReceiveResponse):
  • platform/network/curl/ResourceResponse.h:
  • platform/network/curl/ResourceResponseCurl.cpp: (WebCore::ResourceResponse::setDeprecatedNetworkLoadMetrics): Deleted.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::getConnectionTimingData):
  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):

Source/WebKit:

Add ArgumentCoder support for Box<T>.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
  • NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):
  • Platform/IPC/ArgumentCoders.h: (IPC::ArgumentCoder<Box<T>>::encode): (IPC::ArgumentCoder<Box<T>>::decode):

Tools:

  • TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:37 PM Changeset in webkit [256974] by Russell Epstein
  • 17 edits
    2 copies in branches/safari-609.1.20.1-branch/Source/WebCore

Cherry-pick r256610. rdar://problem/59576806

[Web Animations] Make all animation event types inherit from the same base class
​https://bugs.webkit.org/show_bug.cgi?id=207629

Reviewed by Simon Fraser.

Currently we dispatch events CSS Transitions and CSS Animations events using a dedicated event queue on DeclarativeAnimation, while the events
added by the Web Animations specification (of type AnimationPlaybackEvent) are dispatched using a shared queue on the DocumentTimeline that is
processed during the "update animations and send events procedure". The Web Animations specification dictates that all events should be dispatched
during that procedure, which includes sorting of such events based on their timeline time and associated animation relative composite order.

In this patch, we prepare the work towards spec compliance for animation events dispatch by making all event types (AnimationPlaybackEvent,
TransitionEvent and AnimationEvent) inherit from a single AnimationEventBase interface. This will allow DocumentTimeline to enqueue, sort and
dispatch all such events with a single queue in a future patch.

Due to CSSAnimationController, we must make the "timeline time" and "animation" parameters optional. When we drop support for CSSAnimationController
we'll be able to enforce stronger requirements for these.

No new test since this should not introduce any behavior change.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/AnimationEventBase.cpp: Added. (WebCore::AnimationEventBase::AnimationEventBase):
  • animation/AnimationEventBase.h: Added. (WebCore::AnimationEventBase::create): (WebCore::AnimationEventBase::isAnimationPlaybackEvent const): (WebCore::AnimationEventBase::isAnimationEvent const): (WebCore::AnimationEventBase::isTransitionEvent const): (WebCore::AnimationEventBase::timelineTime const): (WebCore::AnimationEventBase::animation const):
  • animation/AnimationPlaybackEvent.cpp: (WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent): (WebCore::AnimationPlaybackEvent::bindingsTimelineTime const):
  • animation/AnimationPlaybackEvent.h:
  • animation/CSSAnimation.cpp: (WebCore::CSSAnimation::createEvent):
  • animation/CSSAnimation.h:
  • animation/CSSTransition.cpp: (WebCore::CSSTransition::createEvent):
  • animation/CSSTransition.h:
  • animation/DeclarativeAnimation.cpp: (WebCore::DeclarativeAnimation::enqueueDOMEvent):
  • animation/DeclarativeAnimation.h:
  • animation/WebAnimation.cpp: (WebCore::WebAnimation::enqueueAnimationPlaybackEvent):
  • dom/AnimationEvent.cpp: (WebCore::AnimationEvent::AnimationEvent):
  • dom/AnimationEvent.h:
  • dom/TransitionEvent.cpp: (WebCore::TransitionEvent::TransitionEvent):
  • dom/TransitionEvent.h:
  • page/animation/CSSAnimationController.cpp: (WebCore::CSSAnimationControllerPrivate::fireEventsAndUpdateStyle):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:37 PM Changeset in webkit [256973] by Russell Epstein
  • 4 edits
    2 adds in branches/safari-609.1.20.1-branch

Cherry-pick r256513. rdar://problem/59576794

REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side
​https://bugs.webkit.org/show_bug.cgi?id=207674
rdar://problem/59404866

Reviewed by Antti Koivisto.

Source/WebCore:

Remove the early return in ScrollingStateScrollingNode::setRequestedScrollData(); comparing
with the last m_requestedScrollData is wrong, because requested scroll positions are not "state"
in the scrolling tree, they are requests to scroll. Ideally, they would be represented in some
different way in the scrolling tree.

Test: fast/scrolling/programmatic-scroll-to-zero-zero.html

  • page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::setRequestedScrollData):

LayoutTests:

Test that does a programmatic scroll to 0,0, does a user scroll, then a second programmatic scroll to 0,0,
which is expected to work.

  • fast/scrolling/programmatic-scroll-to-zero-zero-expected.html: Added.
  • fast/scrolling/programmatic-scroll-to-zero-zero.html: Added.
  • platform/ios/TestExpectations: Skip the new test on iOS (it relies on eventSender) and sort the grouping.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:37 PM Changeset in webkit [256972] by Russell Epstein
  • 2 edits in branches/safari-609.1.20.1-branch/Source/WebKit

Cherry-pick r256426. rdar://problem/59576790

[ Mac Debug wk2 ] ASSERTION FAILED: m_wasConstructedOnMainThread == isMainThread()
​https://bugs.webkit.org/show_bug.cgi?id=207509
<rdar://problem/59325466>

Reviewed by Chris Dumez.

Covered by existing tests.

  • NetworkProcess/cache/CacheStorageEngine.cpp: (WebKit::CacheStorage::Engine::writeSizeFile): Make sure completion handler is always called on the main thread. Minor refactoring to make things more efficient.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:37 PM Changeset in webkit [256971] by Russell Epstein
  • 3 edits in branches/safari-609.1.20.1-branch/Source/WebCore

Cherry-pick r256400. rdar://problem/59576794

Unreviewed, partial rollout of r255037.
<rdar://problem/59240559>

  • page/scrolling/cocoa/ScrollingTreeFixedNode.mm: (WebCore::ScrollingTreeFixedNode::applyLayerPositions):
  • page/scrolling/cocoa/ScrollingTreeStickyNode.mm: (WebCore::ScrollingTreeStickyNode::computeLayerPosition const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:37 PM Changeset in webkit [256970] by Russell Epstein
  • 4 edits in branches/safari-609.1.20.1-branch

Cherry-pick r256314. rdar://problem/59576791

WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
​https://bugs.webkit.org/show_bug.cgi?id=207537

Reviewed by Chris Dumez.

Source/WebKit:

Covered by added API test.

  • NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::registerServiceWorkerClient): Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:37 PM Changeset in webkit [256969] by Russell Epstein
  • 29 edits
    4 copies
    6 adds in branches/safari-609.1.20.1-branch

Cherry-pick r256191. rdar://problem/59576820

Disallow setting base URL to a data or JavaScript URL
​https://bugs.webkit.org/show_bug.cgi?id=207136

Source/WebCore:

Reviewed by Brent Fulgham.

Inspired by <​https://bugs.chromium.org/p/chromium/issues/detail?id=679318>.

Block setting the base URL to a data URL or JavaScript URL as such usage is questionable.
This makes WebKit match the behavior of Chrome and Firefox and is in the spirit of the
discussion in <​https://github.com/whatwg/html/issues/2249>.

On Mac and iOS, this restriction is applied only to apps linked against a future SDK to
avoid breaking shipped apps.

For all other ports, this restriction is enabled by default.

Tests: fast/url/relative2.html

fast/url/segments-from-data-url2.html
http/tests/security/allowed-base-url-data-url-via-setting.html
http/tests/security/denied-base-url-data-url.html
http/tests/security/denied-base-url-javascript-url.html

  • dom/Document.cpp: (WebCore::Document::processBaseElement): Condition updating the parsed base URL on whether is has an allowed scheme, if restrictions are enabled. Otherwise, do what we do now. If the scheme is disallowed then log a message to the console to explain this to web developers.
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::TokenPreloadScanner::scan): Pass whether to apply restrictons to the base URL to updatePredictedBaseURL(). This depends on whether the setting is enabled or not. (WebCore::TokenPreloadScanner::updatePredictedBaseURL): Modifed to take a boolean as to whether to apply restrictions. If restrictions are not to be applied do what we do now. Otherwise, only do what we do now if the scheme for the predicated base URL is allowed.
  • html/parser/HTMLPreloadScanner.h:
  • page/SecurityPolicy.cpp: (WebCore::SecurityPolicy::isBaseURLSchemeAllowed): Added.
  • page/SecurityPolicy.h:
  • page/Settings.yaml: Add a setting to toggle restrictions on the base URL scheme.

Source/WebKit:

Reviewed by Brent Fulgham.

Apply base URL restrictions to apps linked to a future WebKit to avoid breaking existing apps.

  • Shared/WebPreferences.yaml:
  • UIProcess/API/Cocoa/WKWebView.mm: (shouldRestrictBaseURLSchemes): Added. (-[WKWebView _setupPageConfiguration:]): Update settings.
  • UIProcess/Cocoa/VersionChecks.h:

Source/WebKitLegacy/mac:

Reviewed by Brent Fulgham.

Apply base URL restrictions to apps linked to a future WebKit to avoid breaking existing apps.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (shouldRestrictBaseURLSchemes): Added. (-[WebView _commonInitializationWithFrameName:groupName:]): Update settings.

Source/WTF:

Reviewed by Brent Fulgham.

Add some more macro definitions.

  • wtf/spi/darwin/dyldSPI.h:

LayoutTests:

RReviewed by Brent Fulgham.

Add some tests. Update others to toggle the setting to apply or unapply the new behavior.

The test denied-base-url-javascript-url.html is derived from the test base-url-javascript.html,
included in <​https://chromium.googlesource.com/chromium/src.git/+/c133efa0b915430701930b76a7cfe35608b9a403>.

  • fast/url/relative-expected.txt:
  • fast/url/relative.html:
  • fast/url/relative2-expected.txt: Copied from LayoutTests/fast/url/relative-expected.txt.
  • fast/url/relative2.html: Copied from LayoutTests/fast/url/relative.html.
  • fast/url/resources/utilities.js: (setShouldEllipsizeFileURLPaths): Added. Toggles ellipsizing the path portion of a file URL to simplify matching. Otherwise, file URLs could be machine-specific. (canonicalizedPathname): Added. (segments): Modified to optionally call canonicalizedPathname. (canonicalize): Ditto.
  • fast/url/segments-from-data-url-expected.txt:
  • fast/url/segments-from-data-url.html:
  • fast/url/segments-from-data-url2-expected.txt: Copied from LayoutTests/fast/url/segments-from-data-url-expected.txt.
  • fast/url/segments-from-data-url2.html: Copied from LayoutTests/fast/url/segments-from-data-url.html.
  • fetch/fetch-url-serialization-expected.txt:
  • http/tests/plugins/navigation-during-load-embed.html:
  • http/tests/plugins/navigation-during-load.html:
  • http/tests/security/allowed-base-url-data-url-via-setting-expected.txt: Added.
  • http/tests/security/allowed-base-url-data-url-via-setting.html: Added.
  • http/tests/security/denied-base-url-data-url-expected.txt: Added.
  • http/tests/security/denied-base-url-data-url.html: Added.
  • http/tests/security/denied-base-url-javascript-url-expected.txt: Added.
  • http/tests/security/denied-base-url-javascript-url.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:37 PM Changeset in webkit [256968] by Russell Epstein
  • 44 edits
    5 adds in branches/safari-609.1.20.1-branch

Cherry-pick r255037. rdar://problem/59576794

Fixed elements no longer stay fixed with elastic overscroll
​https://bugs.webkit.org/show_bug.cgi?id=206227
rdar://problem/58707084

Reviewed by Antti Koivisto.
Source/WebCore:

Intended behavior on iOS and macOS is for position:fixed and sticky elements to maintain
their position relative to the view bounds when rubber-banding ("overscrolling"). This broke
some time back. This change restores the correct behavior with the call to layoutViewportRespectingRubberBanding()
in ScrollingTreeFixedNode::applyLayerPositions() and ScrollingTreeStickyNode::computeLayerPosition().
layoutViewportRespectingRubberBanding() computes a layout viewport without clamping.

The rest of the changes are to support testing. internals.unconstrainedScrollTo()
didn't work for main frame scrolling because of scroll position clamping in various places,
so propagate ScrollClamping in more places (and replace the redundant ScrollPositionClamp with ScrollClamping).

"requested scroll position" updates now carry along both clamping and "is programmatic" data, wrapped in a struct
which is passed around the scrolling tree. This allows us to not clamp the scroll position (for testing) in more places.

Internals::unconstrainedScrollTo() needs one weird hack to trigger a layout (and thus a scrolling tree commit),
because the layout is normally triggered by a layout viewport change, but when rubber-banding we clamp the layoutViewport
used for layout, so those layouts are never triggered.

Tests: tiled-drawing/scrolling/fixed/fixed-during-rubberband.html

tiled-drawing/scrolling/sticky/sticky-during-rubberband.html

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.cpp: (WebCore::Element::scrollTo):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo const):
  • page/FrameView.cpp: (WebCore::FrameView::setScrollPosition): (WebCore::FrameView::requestScrollPositionUpdate):
  • page/FrameView.h:
  • page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
  • page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::setRequestedScrollData): (WebCore::ScrollingStateScrollingNode::dumpProperties const): (WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition): Deleted.
  • page/scrolling/ScrollingStateScrollingNode.h: (WebCore::RequestedScrollData::operator== const): (WebCore::ScrollingStateScrollingNode::requestedScrollData const): (WebCore::ScrollingStateScrollingNode::requestedScrollPosition const): Deleted. (WebCore::ScrollingStateScrollingNode::requestedScrollPositionRepresentsProgrammaticScroll const): Deleted.
  • page/scrolling/ScrollingTree.h: (WebCore::ScrollingTree::scrollingTreeNodeRequestsScroll):
  • page/scrolling/ScrollingTreeFrameScrollingNode.cpp: (WebCore::ScrollingTreeFrameScrollingNode::layoutViewportForScrollPosition const): (WebCore::ScrollingTreeFrameScrollingNode::layoutViewportRespectingRubberBanding const):
  • page/scrolling/ScrollingTreeFrameScrollingNode.h:
  • page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::commitStateAfterChildren): (WebCore::ScrollingTreeScrollingNode::adjustedScrollPosition const): (WebCore::ScrollingTreeScrollingNode::scrollBy): (WebCore::ScrollingTreeScrollingNode::scrollTo): (WebCore::ScrollingTreeScrollingNode::wasScrolledByDelegatedScrolling):
  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/cocoa/ScrollingTreeFixedNode.mm: (WebCore::ScrollingTreeFixedNode::applyLayerPositions):
  • page/scrolling/cocoa/ScrollingTreeStickyNode.mm: (WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm: (WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateAfterChildren): (WebCore::ScrollingTreeFrameScrollingNodeMac::adjustedScrollPosition const):
  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm: (WebCore::ScrollingTreeOverflowScrollingNodeMac::commitStateAfterChildren): (WebCore::ScrollingTreeOverflowScrollingNodeMac::adjustedScrollPosition const):
  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::immediateScrollByWithoutContentEdgeConstraints):
  • platform/ScrollTypes.cpp: Added. (WebCore::operator<<):
  • platform/ScrollTypes.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::setContentsScrollPosition): (WebCore::ScrollView::setScrollPosition):
  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::setScrollOffsetFromAnimation):
  • platform/ScrollableArea.h: (WebCore::ScrollableArea::requestScrollPositionUpdate):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
  • testing/Internals.cpp: (WebCore::Internals::unconstrainedScrollTo):

Source/WebKit:

Intended behavior on iOS and macOS is for position:fixed and sticky elements to maintain
their position relative to the view bounds when rubber-banding ("overscrolling"). This broke
some time back. This change restores the correct behavior with the call to layoutViewportRespectingRubberBanding()
in ScrollingTreeFixedNode::applyLayerPositions() and ScrollingTreeStickyNode::computeLayerPosition().
layoutViewportRespectingRubberBanding() computes a layout viewport without clamping.

The rest of the changes are to support testing. internals.unconstrainedScrollTo()
didn't work for main frame scrolling because of scroll position clamping in various places,
so propagate ScrollClamping in more places (and replace the redundant ScrollPositionClamp with ScrollClamping).

"requested scroll position" updates now carry along both clamping and "is programmatic" data, wrapped in a struct
which is passed around the scrolling tree. This allows us to not clamp the scroll position (for testing) in more places.

  • Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp: (ArgumentCoder<ScrollingStateScrollingNode>::encode): (ArgumentCoder<ScrollingStateScrollingNode>::decode): (ArgumentCoder<RequestedScrollData>::encode): (ArgumentCoder<RequestedScrollData>::decode): (WebKit::dump):
  • UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeRequestsScroll):
  • UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
  • UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp: (WebKit::RemoteScrollingTree::scrollingTreeNodeRequestsScroll):
  • UIProcess/RemoteLayerTree/RemoteScrollingTree.h:
  • UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm: (WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::commitStateAfterChildren):
  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: (WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateAfterChildren):

LayoutTests:

  • tiled-drawing/scrolling/fixed/fixed-during-rubberband-expected.html: Added.
  • tiled-drawing/scrolling/fixed/fixed-during-rubberband.html: Added.
  • tiled-drawing/scrolling/sticky/sticky-during-rubberband-expected.html: Added.
  • tiled-drawing/scrolling/sticky/sticky-during-rubberband.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@255037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:33 PM Changeset in webkit [256967] by Chris Dumez
  • 10 edits in trunk/Source/WebKit

Regression(r247567) HTTP Disk cache capacity is no longer set
​https://bugs.webkit.org/show_bug.cgi?id=207959
<rdar://problem/59603972>

Reviewed by Alex Christensen.

NetworkProcess::initializeNetworkProcess() was setting the cache model, which
would iterate over all network sessions to update their network cache capacity.
The issue was that network sessions were not constructed yet at this point.
When the network session(s) would get created later on, they would construct
their NetworkCache and it would use the default capacity (i.e.
std::numeric_limits<size_t>::max()).

To make this safer, I have moved the capacity computation to the Cache::open()
method and now pass the capacity when constructing the network cache storage.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::setCacheModelSynchronouslyForTesting):
(WebKit::NetworkProcess::setCacheModel):

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::cacheModel const):

  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::initialize):

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::computeCapacity):
(WebKit::NetworkCache::Cache::open):
(WebKit::NetworkCache::Cache::capacity const):
(WebKit::NetworkCache::Cache::updateCapacity):
(WebKit::NetworkCache::Cache::setCapacity): Deleted.

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::open):
(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::setCapacity):

  • NetworkProcess/cache/NetworkCacheStorage.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setCacheModel):

3:24 PM Changeset in webkit [256966] by Lauro Moura
  • 3 edits in trunk/LayoutTests

[GTK] More media tests gardening
​https://bugs.webkit.org/show_bug.cgi?id=207965

Unreviewed test gardening.

  • platform/gtk-wayland/TestExpectations:
  • platform/gtk/TestExpectations:
3:14 PM Changeset in webkit [256965] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Flaky Test: editing/spelling/spellcheck-attribute.html
​https://bugs.webkit.org/show_bug.cgi?id=206178

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations: Mark test as flaky on Mojave so

since the commit queue bots keep hitting it.

3:09 PM Changeset in webkit [256964] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.2.2

Tag Safari-609.1.20.2.2.

3:08 PM Changeset in webkit [256963] by Alan Coon
  • 13 edits in branches/safari-609.1.20.0-branch

Apply patch. rdar://problem/59478837

3:08 PM Changeset in webkit [256962] by Alan Coon
  • 2 edits in branches/safari-609.1.20.0-branch/Source/JavaScriptCore

Cherry-pick r256898. rdar://problem/59551695

Unreviewed build fix.

  • jit/JITThunks.cpp: (JSC::JITThunks::hostFunctionStub):

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-609-branch@256898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:08 PM Changeset in webkit [256961] by Alan Coon
  • 9 edits
    1 add in branches/safari-609.1.20.0-branch

Cherry-pick r256779. rdar://problem/59551695

[JSC] JITThunk should be HashSet<Weak<NativeExecutable>> with appropriate GC weakness handling
​https://bugs.webkit.org/show_bug.cgi?id=207715

Reviewed by Darin Adler.

JSTests:

  • stress/stress-jitthunks.js: Added. (let.set newGlobal): (set catch):

Source/JavaScriptCore:

This patch refines JITThunks GC-aware Weak hash map for NativeExecutable. Previously, we have
HashMap<std::tuple<TaggedNativeFunction, TaggedNativeFunction, String>, Weak<NativeExecutable>> table.
But this is not good because the first tuple's information is already in NativeExecutable.
But we were using this design since Weak<NativeExecutable> can be nullified because of Weak<>. If this
happens, we could have invalid Entry in HashMap which does not have corresponding values. This will
cause crash when rehasing requires hash code for this entry.

But this HashMap is very bad in terms of memory usage. Each entry has 32 bytes, and this table gets enough
large. We identified that this table is consuming much memory in Membuster. So it is worth designing
carefully crafted data structure which only holds Weak<NativeExecutable> by leveraging the deep interaction
with our GC implementation.

This patch implements new design of JITThunks, which uses HashSet<Weak<NativeExecutable>> and carefully crafted
HashTraits / KeyTraits to handle Weak<> well.

  1. Each Weak should have finalizer, and this finalizer should remove dead Weak<NativeExecutable> from HashSet.

This is ensuring that all the keys in HashSet is, even if Weak<> is saying it is Dead, it still has an way
to access content of NativeExecutable if the content is not a JS objects. For example, we can get function
pointer from dead Weak<NativeExecutable> if it is not yet finalized. Since we remove all finalized Weak<>
from the table, this finalizer mechanism allows us to access function pointers etc. from Weak<NativeExecutable>
so long as it is held in this table.

  1. Getting NativeExecutable* from JITThunks should have special protocol.

When getting NativeExecutable* from JITThunks, we do the following,

  1. First, we check we have an Entry in JITThunks. If it does not exist, we should insert it anyway.

1.1. If it exists, we should check whether this Weak<NativeExecutable> is dead or not. It is possible that

dead one is still in the table because "dead" does not mean that it is "finalized". Until finalizing happens (and
it can be delayed by incremental-sweeper), Weak<NativeExecutable> can be dead but still accessible. So the table
is still holding dead one. If we get dead one, we should insert a new one.

1.2. If it is not dead, we return it.

  1. Second, we create a new NativeExecutable and insert it. In that case, it is possible that the table already has Weak<NativeExecutable>, but it is dead. In that case, we need to explicitly replace it with newly created one since old one is holding old content. If we replaced, finalizer of Weak<> will not be invoked since it immediately deallocates Weak<>. So, it does not happen that this newly inserted NativeExecutable* is removed by the finalizer registered by the old Weak<>.

This change makes memory usage of JITThunks table 1/4.

  • heap/Weak.cpp: (JSC::weakClearSlowCase):
  • heap/Weak.h: (JSC::Weak::Weak): (JSC::Weak::isHashTableEmptyValue const): (JSC::Weak::unsafeImpl const): (WTF::HashTraits<JSC::Weak<T>>::isEmptyValue):
  • heap/WeakInlines.h: (JSC::Weak<T>::Weak):
  • jit/JITThunks.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::WeakNativeExecutableHash::hash): (JSC::JITThunks::WeakNativeExecutableHash::equal): (JSC::JITThunks::HostKeySearcher::hash): (JSC::JITThunks::HostKeySearcher::equal): (JSC::JITThunks::NativeExecutableTranslator::hash): (JSC::JITThunks::NativeExecutableTranslator::equal): (JSC::JITThunks::NativeExecutableTranslator::translate): (JSC::JITThunks::finalize): (JSC::JITThunks::hostFunctionStub): (JSC::JITThunks::clearHostFunctionStubs): Deleted.
  • jit/JITThunks.h:
  • runtime/NativeExecutable.h:
  • tools/JSDollarVM.cpp: (JSC::functionGCSweepAsynchronously): (JSC::functionCreateEmptyFunctionWithName): (JSC::JSDollarVM::finishCreation):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [256960] by Alan Coon
  • 3 edits
    1 add in branches/safari-609.1.20.0-branch

Cherry-pick r256766. rdar://problem/59551706

[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
​https://bugs.webkit.org/show_bug.cgi?id=207849

Reviewed by Mark Lam.

JSTests:

  • wasm/regress/regress-256665.js: Added. (f):

Source/JavaScriptCore:

When generating the call IC, we should select the callee saves using BoundsChecking mode in order
to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
register when calling the Wasm LLInt through the call IC.

  • wasm/js/WebAssemblyFunction.cpp: (JSC::WebAssemblyFunction::calleeSaves const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [256959] by Alan Coon
  • 3 edits in branches/safari-609.1.20.0-branch/JSTests

Cherry-pick r256698. rdar://problem/59551715

Unreviewed: fix broken tests added in r256665
​https://bugs.webkit.org/show_bug.cgi?id=207727

Our inline WAT doesn't seem to like named blocks/branch targets.

  • wasm/regress/llint-callee-saves-with-fast-memory.js:
  • wasm/regress/llint-callee-saves-without-fast-memory.js:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [256958] by Alan Coon
  • 9 edits
    2 adds in branches/safari-609.1.20.0-branch

Cherry-pick r256665. rdar://problem/59551715

[WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention.
​https://bugs.webkit.org/show_bug.cgi?id=207727

JSTests:

Reviewed by Mark Lam.

  • wasm/regress/llint-callee-saves-with-fast-memory.js: Added.
  • wasm/regress/llint-callee-saves-without-fast-memory.js: Added.

Source/JavaScriptCore:

Reviewed by Mark Lam.

The Wasm JIT has unusual calling conventions, which were further complicated by the addition
of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly
saving and restoring the callee save registers used for the memory base and size). Here's a summary
of the calling convention:

  • When entering Wasm from JS, the wrapper must:
    • Preserve the base and size when entering LLInt regardless of the mode. (Prior to this patch we only preserved the base in Signaling mode)
    • Preserve the memory base in either mode, and the size for BoundsChecking.
  • Both tiers must preserve every *other* register they use. e.g. the LLInt must preserve PB and wasmInstance, but must *not* preserve memoryBase and memorySize.
  • Changes to memoryBase and memorySize are visible to the caller. This means that:
    • Intra-module calls can assume these registers are up-to-date even if the memory was resized. The only exception here is if the LLInt calls a signaling JIT, in which case the JIT will not update the size register, since it won't be using it.
    • Inter-module and JS calls require the caller to reload these registers. These calls may result in memory changes (e.g. the callee may call memory.grow).
    • A Signaling JIT caller must be aware that the LLInt may trash the size register, since it always bounds checks.
  • llint/WebAssembly.asm:
  • wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::addCall):
  • wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::addCall):
  • wasm/WasmCallee.cpp: (JSC::Wasm::LLIntCallee::calleeSaveRegisters):
  • wasm/WasmCallingConvention.h:
  • wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation):
  • wasm/WasmMemoryInformation.cpp: (JSC::Wasm::PinnedRegisterInfo::get): (JSC::Wasm::getPinnedRegisters): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [256957] by Alan Coon
  • 4 edits in branches/safari-609.1.20.0-branch

Cherry-pick r256432. rdar://problem/59446974

WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
​https://bugs.webkit.org/show_bug.cgi?id=207537

Reviewed by Chris Dumez.

Source/WebKit:

Covered by added API test.

  • NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::registerServiceWorkerClient): Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [256956] by Alan Coon
  • 2 edits in branches/safari-609.1.20.0-branch/Source/WebKit

Cherry-pick r256426. rdar://problem/59447008

[ Mac Debug wk2 ] ASSERTION FAILED: m_wasConstructedOnMainThread == isMainThread()
​https://bugs.webkit.org/show_bug.cgi?id=207509
<rdar://problem/59325466>

Reviewed by Chris Dumez.

Covered by existing tests.

  • NetworkProcess/cache/CacheStorageEngine.cpp: (WebKit::CacheStorage::Engine::writeSizeFile): Make sure completion handler is always called on the main thread. Minor refactoring to make things more efficient.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [256955] by Alan Coon
  • 4 edits in branches/safari-609.1.20.0-branch

Cherry-pick r256383. rdar://problem/59446974

Unreviewed, rolling out r256314.
​https://bugs.webkit.org/show_bug.cgi?id=207594

It is breaking an API test (Requested by youenn on #webkit).

Reverted changeset:

"WebSWServerConnection::registerServiceWorkerClient is not
sending IPC message to UIProcess when it should"
​https://bugs.webkit.org/show_bug.cgi?id=207537
​https://trac.webkit.org/changeset/256314

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [256954] by Alan Coon
  • 4 edits in branches/safari-609.1.20.0-branch

Cherry-pick r256314. rdar://problem/59446974

WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
​https://bugs.webkit.org/show_bug.cgi?id=207537

Reviewed by Chris Dumez.

Source/WebKit:

Covered by added API test.

  • NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::registerServiceWorkerClient): Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [256953] by Alan Coon
  • 1 edit in branches/safari-609.1.20.0-branch/Source/JavaScriptCore/runtime/OptionsList.h

Apply patch. rdar://problem/59447266

3:07 PM Changeset in webkit [256952] by Alan Coon
  • 34 edits
    2 adds in branches/safari-609.1.20.0-branch/Source

Apply patch. rdar://problem/59447004

3:07 PM Changeset in webkit [256951] by Alan Coon
  • 15 edits in branches/safari-609.1.20.0-branch/Source/JavaScriptCore

Apply patch. rdar://problem/59446991

2:19 PM Changeset in webkit [256950] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

[ Mac wk2 ] accessibility/mac/aria-menu-item-selected-notification.html is flaky timing out.
​https://bugs.webkit.org/show_bug.cgi?id=207962

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:10 PM Changeset in webkit [256949] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

[mac debug] Regression: http/tests/websocket/tests/hybi/workers/worker-reload.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=207940
<rdar://problem/59592000>

Reviewed by Chris Dumez.

Covered by debug asserts.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
Pass registrable domain instead of URL.
Isolate copy the domain before hopping to main thread for extra protection.

2:02 PM Changeset in webkit [256948] by dbates@webkit.org
  • 6 edits in trunk/Source/WebKitLegacy

[iOS][LegacyWebKit] Override EditorClient::shouldRevealCurrentSelectionAfterInsertion()
​https://bugs.webkit.org/show_bug.cgi?id=207955
<rdar://problem/59602916>

Reviewed by Wenson Hsieh.

Source/WebKitLegacy/ios:

Adds a stub function for -shouldRevealCurrentSelectionAfterInsertion that returns YES,
to keep our current behavior.

  • DefaultDelegates/WebDefaultUIKitDelegate.m:

(-[WebDefaultUIKitDelegate shouldRevealCurrentSelectionAfterInsertion]): Added.

  • WebView/WebUIKitDelegate.h:

Source/WebKitLegacy/mac:

Wire up EditorClient::shouldRevealCurrentSelectionAfterInsertion() in Legacy WebKit. This
allows Legacy WebKit clients to toggle whether the current selection is revealed after
an insertion, which they may want to do to achieve a desired UI effect.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldRevealCurrentSelectionAfterInsertion const): Added. Ask the _UIKitDelegateForwarder
if it responds to -shouldRevealCurrentSelectionAfterInsertion. If it does then return its
response. Otherwise, return true to do what we do now: reveal the current selection after
an insertion.

1:54 PM Changeset in webkit [256947] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[GTK] Layout Test media/track/audio-track.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=134573

Unreviewed test gardening.

This test has not timeout (on its own) since r180689 (Feb 2015) other
than 4 timeouts on a bot hiccup up to r2545640 with other media tests.
Updating its expectation to reflect the new behavior affected by
bug198830.

  • platform/gtk/TestExpectations:
1:43 PM Changeset in webkit [256946] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.3.2

Tag Safari-609.1.20.3.2.

1:42 PM Changeset in webkit [256945] by Alan Coon
  • 29 edits
    4 copies
    6 adds in branches/safari-609.1.20.3-branch

Cherry-pick r256191. rdar://problem/59576822

Disallow setting base URL to a data or JavaScript URL
​https://bugs.webkit.org/show_bug.cgi?id=207136

Source/WebCore:

Reviewed by Brent Fulgham.

Inspired by <​https://bugs.chromium.org/p/chromium/issues/detail?id=679318>.

Block setting the base URL to a data URL or JavaScript URL as such usage is questionable.
This makes WebKit match the behavior of Chrome and Firefox and is in the spirit of the
discussion in <​https://github.com/whatwg/html/issues/2249>.

On Mac and iOS, this restriction is applied only to apps linked against a future SDK to
avoid breaking shipped apps.

For all other ports, this restriction is enabled by default.

Tests: fast/url/relative2.html

fast/url/segments-from-data-url2.html
http/tests/security/allowed-base-url-data-url-via-setting.html
http/tests/security/denied-base-url-data-url.html
http/tests/security/denied-base-url-javascript-url.html

  • dom/Document.cpp: (WebCore::Document::processBaseElement): Condition updating the parsed base URL on whether is has an allowed scheme, if restrictions are enabled. Otherwise, do what we do now. If the scheme is disallowed then log a message to the console to explain this to web developers.
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::TokenPreloadScanner::scan): Pass whether to apply restrictons to the base URL to updatePredictedBaseURL(). This depends on whether the setting is enabled or not. (WebCore::TokenPreloadScanner::updatePredictedBaseURL): Modifed to take a boolean as to whether to apply restrictions. If restrictions are not to be applied do what we do now. Otherwise, only do what we do now if the scheme for the predicated base URL is allowed.
  • html/parser/HTMLPreloadScanner.h:
  • page/SecurityPolicy.cpp: (WebCore::SecurityPolicy::isBaseURLSchemeAllowed): Added.
  • page/SecurityPolicy.h:
  • page/Settings.yaml: Add a setting to toggle restrictions on the base URL scheme.

Source/WebKit:

Reviewed by Brent Fulgham.

Apply base URL restrictions to apps linked to a future WebKit to avoid breaking existing apps.

  • Shared/WebPreferences.yaml:
  • UIProcess/API/Cocoa/WKWebView.mm: (shouldRestrictBaseURLSchemes): Added. (-[WKWebView _setupPageConfiguration:]): Update settings.
  • UIProcess/Cocoa/VersionChecks.h:

Source/WebKitLegacy/mac:

Reviewed by Brent Fulgham.

Apply base URL restrictions to apps linked to a future WebKit to avoid breaking existing apps.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (shouldRestrictBaseURLSchemes): Added. (-[WebView _commonInitializationWithFrameName:groupName:]): Update settings.

Source/WTF:

Reviewed by Brent Fulgham.

Add some more macro definitions.

  • wtf/spi/darwin/dyldSPI.h:

LayoutTests:

RReviewed by Brent Fulgham.

Add some tests. Update others to toggle the setting to apply or unapply the new behavior.

The test denied-base-url-javascript-url.html is derived from the test base-url-javascript.html,
included in <​https://chromium.googlesource.com/chromium/src.git/+/c133efa0b915430701930b76a7cfe35608b9a403>.

  • fast/url/relative-expected.txt:
  • fast/url/relative.html:
  • fast/url/relative2-expected.txt: Copied from LayoutTests/fast/url/relative-expected.txt.
  • fast/url/relative2.html: Copied from LayoutTests/fast/url/relative.html.
  • fast/url/resources/utilities.js: (setShouldEllipsizeFileURLPaths): Added. Toggles ellipsizing the path portion of a file URL to simplify matching. Otherwise, file URLs could be machine-specific. (canonicalizedPathname): Added. (segments): Modified to optionally call canonicalizedPathname. (canonicalize): Ditto.
  • fast/url/segments-from-data-url-expected.txt:
  • fast/url/segments-from-data-url.html:
  • fast/url/segments-from-data-url2-expected.txt: Copied from LayoutTests/fast/url/segments-from-data-url-expected.txt.
  • fast/url/segments-from-data-url2.html: Copied from LayoutTests/fast/url/segments-from-data-url.html.
  • fetch/fetch-url-serialization-expected.txt:
  • http/tests/plugins/navigation-during-load-embed.html:
  • http/tests/plugins/navigation-during-load.html:
  • http/tests/security/allowed-base-url-data-url-via-setting-expected.txt: Added.
  • http/tests/security/allowed-base-url-data-url-via-setting.html: Added.
  • http/tests/security/denied-base-url-data-url-expected.txt: Added.
  • http/tests/security/denied-base-url-data-url.html: Added.
  • http/tests/security/denied-base-url-javascript-url-expected.txt: Added.
  • http/tests/security/denied-base-url-javascript-url.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:40 PM Changeset in webkit [256944] by Russell Epstein
  • 8 edits in branches/safari-609.1.20.1-branch/Source

Versioning.

1:34 PM Changeset in webkit [256943] by Alan Coon
  • 8 edits in branches/safari-609.1.20.3-branch/Source

Versioning.

1:31 PM Changeset in webkit [256942] by Alan Coon
  • 4 edits
    1 add in branches/safari-609.1.20.2-branch

Cherry-pick r256225. rdar://problem/59446983

[watchOS] Notification listener is never unregistered
​https://bugs.webkit.org/show_bug.cgi?id=207459
Source/WebKit:

<rdar://problem/58923393>

Reviewed by Maciej Stachowiak.

On watchOS, the backlight changed notification is registered in WebProcessPool::registerNotificationObservers(),
but not unregistered in WebProcessPool::unregisterNotificationObservers().

API test: WebKit.BacklightLevelNotificationCrash

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::unregisterNotificationObservers):

Tools:

Reviewed by Maciej Stachowiak.

Add a test which tests that posting a backlight level change notification will not cause a crash.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added. (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:23 PM Changeset in webkit [256941] by keith_miller@apple.com
  • 6 edits in trunk

Disable Wasm reference types by default
​https://bugs.webkit.org/show_bug.cgi?id=207952

Reviewed by Mark Lam.

JSTests:

  • wasm/stress/immutable-globals.js:
  • wasm/stress/local-ref.js:
  • wasm/stress/mutable-globals.js:

Source/JavaScriptCore:

  • runtime/OptionsList.h:
1:22 PM Changeset in webkit [256940] by Alan Coon
  • 8 edits in branches/safari-609.1.20.2-branch/Source

Versioning.

1:08 PM Changeset in webkit [256939] by Alan Coon
  • 8 edits in branches/safari-609.1.20.0-branch/Source

Versioning.

12:56 PM Changeset in webkit [256938] by Alan Coon
  • 1 copy in branches/safari-609.1.20.1-branch

New branch.

12:56 PM Changeset in webkit [256937] by Alan Coon
  • 1 copy in branches/safari-609.1.20.0-branch

New branch.

12:54 PM Changeset in webkit [256936] by youenn@apple.com
  • 8 edits in trunk/Source/WebCore

Remove PlatformMediaSession::characteristics()
​https://bugs.webkit.org/show_bug.cgi?id=207926

Reviewed by Eric Carlson.

No change of behavior, removing no longer used code.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::characteristics const): Deleted.

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/webaudio/AudioContext.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::characteristics const): Deleted.

  • html/HTMLMediaElement.h:
  • platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::characteristics const): Deleted.

  • platform/audio/PlatformMediaSession.h:

(WebCore::PlatformMediaSessionClient::displayType const):

12:39 PM Changeset in webkit [256935] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

[iOS] fast/dom/focus-shift-crash.html and editing/selection/selection-change-in-disconnected-frame-crash.html crash after r256864
​https://bugs.webkit.org/show_bug.cgi?id=207939

Reviewed by Tim Horton.

Fix two layout tests that began to crash after r256864 due to a missing null check for EditorClient.
To make this conditional a bit easier to read, pull out each case where we should avoid calling
didChangeSelection() into a separate early return. The EditorClient may be null on iOS in the case where the
Frame has been detached from its Page.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateSelectionAppearance):

12:22 PM Changeset in webkit [256934] by Kate Cheney
  • 12 edits
    1 add in trunk/Source/WebKit

WebPageProxy::PolicyDecisionSender should send a struct instead of many parameters
​https://bugs.webkit.org/show_bug.cgi?id=207936
<rdar://problem/59590676>

Reviewed by Alex Christensen.

  • Shared/PolicyDecision.h: Added.

(WebKit::PolicyDecision::encode const):
(WebKit::PolicyDecision::decode):

  • UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionSync):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::PolicyDecisionSender::send):
(WebKit::WebPageProxy::PolicyDecisionSender::identifier):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSyncShared):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponseShared):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::didReceivePolicyDecision):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceivePolicyDecision):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
12:04 PM Changeset in webkit [256933] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

[iOS] Safari sometimes crashes under ViewGestureController::beginSwipeGesture
​https://bugs.webkit.org/show_bug.cgi?id=207929
<rdar://problem/59493326>

Reviewed by Tim Horton.

Make ViewGestureController::beginSwipeGesture robust in the case where the target back/forward item no longer
exists. This means that a back/forward target item existed when UIKit called into us in canSwipeInDirection, but
this item was removed by the time beginSwipeGesture is called.

A couple of conditions could make this possible, such as handling incoming synchronous IPC in the UI process
that could change the back/forward list before sending outgoing IPC to the web process; alternately, an SPI
client could be overriding -_webViewDidBeginNavigationGesture: to run some logic that removes the would-be
target back/forward item.

To protect against these scenarios, null-check targetItem before attempting to dereference it; if it is null,
then reset some state that might've been set as a result of beginning the swipe (that is, m_activeGestureType
and m_currentGestureID) and then immediately bail before attempting to install the snapshot view and proceed
with the swipe.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

12:01 PM Changeset in webkit [256932] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Disable the process cache when process-per-tab is disabled in the debug menu
​https://bugs.webkit.org/show_bug.cgi?id=207949
<rdar://problem/57094837>

Reviewed by Geoffrey Garen.

Disable the process cache when process-per-tab is disabled in the debug menu. The process cache is a
process-swap-on-navigation optimization and process-swap-on-navigation is already disabled when
process-per-tab is disabled. The process cache is not useful with such configuration and actually
leads to crashes too.

  • UIProcess/WebProcessCache.cpp:

(WebKit::WebProcessCache::updateCapacity):

11:57 AM Changeset in webkit [256931] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

[ Mac wk2 ] http/tests/inspector/network/har/har-page.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=207954

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:46 AM Changeset in webkit [256930] by stephan.szabo@sony.com
  • 2 edits in trunk/Source/JavaScriptCore

[PlayStation] Get jsc test wrappers using find_package
​https://bugs.webkit.org/show_bug.cgi?id=207914

Reviewed by Ross Kirsling.

  • shell/PlatformPlayStation.cmake:
11:36 AM Changeset in webkit [256929] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

[ Mac wk2 Release ] fast/scrolling/latching/scroll-iframe-in-overflow.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=207953

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:30 AM Changeset in webkit [256928] by Alan Bujtas
  • 5 edits
    2 adds in trunk

[LFC][Floats] FloatingContext::constraints should be able to handle empty candidate ranges (points)
​https://bugs.webkit.org/show_bug.cgi?id=207937
<rdar://problem/59591109>

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/floats-shrinking-line-simple.html

Handle the case when the incoming vertical range is empty (line is empty).

  • layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::constraints const):

  • layout/floats/FloatingContext.h:
  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):

LayoutTests:

  • fast/layoutformattingcontext/floats-shrinking-line-simple-expected.html: Added.
  • fast/layoutformattingcontext/floats-shrinking-line-simple.html: Added.
11:04 AM Changeset in webkit [256927] by Alan Coon
  • 1 copy in tags/Safari-610.1.3.4

Tag Safari-610.1.3.4.

10:54 AM Changeset in webkit [256926] by Alan Coon
  • 8 edits in branches/safari-610.1.3-branch/Source

Versioning.

10:36 AM Changeset in webkit [256925] by Brent Fulgham
  • 5 edits in trunk/Source

Re-disable top-level data URL navigations
​https://bugs.webkit.org/show_bug.cgi?id=207917
<rdar://problem/59568037>

Reviewed by Darin Adler.

Source/WebCore:

Calls to WKPage and WKWebView API used to load data and strings directly should be recognized by
the loading code as being from client API calls. This brings these API behaviors into alignment
with similar API for loading URLs and URLRequests directly. This change also allows us to enforce
stricter handling of Data URLs, and to remove the need to explicitly permit top-level data URL
navigation when client APIs are used.

Tested by TestWebKitAPI Navigation tests.

  • page/Settings.yaml:

Source/WebKit:

In Bug 207719 we allowed top-level navigations to data URLs by default. This
patch updates client loading API calls so that we can go back to a default
block of these loads without breaking WebKit clients.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadDataImpl): Recognize direct data loads started from client API.

  • WebProcess/WebPage/WebPage.h:
10:15 AM Changeset in webkit [256924] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][IFC] Anonymous inline text box container is not the only type of anonymous containers
​https://bugs.webkit.org/show_bug.cgi?id=207945
<rdar://problem/59592411>

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/anonymous-inline-container-simple.html

We construct anonymous inline containers for certain features like first-letter.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::nextInlineLevelBoxToLayout):
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):

LayoutTests:

  • fast/layoutformattingcontext/anonymous-inline-container-simple-expected.html: Added.
  • fast/layoutformattingcontext/anonymous-inline-container-simple.html: Added.
9:59 AM Changeset in webkit [256923] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skip lazy iframe load test
​https://bugs.webkit.org/show_bug.cgi?id=207946

Patch by Rob Buis <​rbuis@igalia.com> on 2020-02-19
Reviewed by Frédéric Wang.

The WPT test html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub.html
should have been skipped in ​https://trac.webkit.org/changeset/256916/webkit.

8:57 AM Changeset in webkit [256922] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

REGRESSION: (r256805?) [ Mojave wk2 Release ] webrtc/video-replace-muted-track.html is flaky timing out.
​https://bugs.webkit.org/show_bug.cgi?id=207941

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:57 AM Changeset in webkit [256921] by Megan Gardner
  • 6 edits in trunk/Source

Ensure that contenteditable carets on macCatalyst are the right color, especially in Dark Mode
​https://bugs.webkit.org/show_bug.cgi?id=207789
<rdar://problem/59429715>

Reviewed by Tim Horton.

Source/WebCore:

Factor out caret color calculation to be used in WebPageIOS.

Fixes EditorStateTests.CaretColorInContentEditable.

  • editing/FrameSelection.cpp:

(WebCore::CaretBase::computeCaretColor):
(WebCore::CaretBase::paintCaret const):

  • editing/FrameSelection.h:

Source/WebKit:

Because UIKit only uses label color for the caret in macCatalyst,
we need skip text input traits and send the correctly calculated color
to UIKit.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView insertionPointColor]):
(-[WKContentView getInteractionTintColor]):
(-[WKContentView _updateInteractionTintColor]):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):

8:37 AM Changeset in webkit [256920] by Jonathan Bedard
  • 3 edits in trunk/Tools

results.webkit.org: Correctly report JSC tests for windows
​https://bugs.webkit.org/show_bug.cgi?id=207910

Rubber-stamped by Aakash Jain.

  • Scripts/run-javascriptcore-tests:

(configurationForUpload): Give Windows a version name.

  • Scripts/webkitdirs.pm:

(determineWinVersion): Correctly parse Windows 10 version numbers, conform to
Version dictionary.

8:33 AM Changeset in webkit [256919] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

REGRESSION: (r256842?) [ Mac wk2 ] http/wpt/crypto/derive-hmac-key-crash.any.html is flaky crashing.
​https://bugs.webkit.org/show_bug.cgi?id=207938

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:31 AM Changeset in webkit [256918] by Chris Dumez
  • 8 edits in trunk

Unreviewed, fix assertions in storage access API layout tests after r256882.

Source/WebCore:

  • dom/DocumentStorageAccess.idl:

Only expose the storage access API operations to the Web when the corresponding setting is
enabled instead of relying on an assertion.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
Stop disabling the storage access API since the API is enabled by default.

Tools:

Drop dead testRunner code to toggle storage access API feature.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

4:50 AM Changeset in webkit [256917] by Philippe Normand
  • 2 edits in trunk

[GTK][WPE] Set ccache as compiler launcher, add opt-in sccache support
​https://bugs.webkit.org/show_bug.cgi?id=207838

Reviewed by Carlos Alberto Lopez Perez.

This change allows for more granular control over the compiler
launcher configuration. The build host should no longer need to
set ccache symbolic links. Additionally optional support for
sccache is added, enabled when the WEBKIT_USE_SCCACHE environment
variable is set to YES.

  • Source/cmake/WebKitCCache.cmake:
2:37 AM Changeset in webkit [256916] by commit-queue@webkit.org
  • 17 edits in trunk/LayoutTests

Main implementation for lazy image loading
​https://bugs.webkit.org/show_bug.cgi?id=200764

Patch by Rob Buis <​rbuis@igalia.com> on 2020-02-19
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

When updating WPT tests in a lost minute change I forgot to add webkit-test-runner headers.
Remaining failures are tracked in ​https://bugs.webkit.org/show_bug.cgi?id=207902 and
​https://bugs.webkit.org/show_bug.cgi?id=207901.

  • web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-2.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied-iframe.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/original-base-url-applied.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/original-crossorigin-applied.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub.html:

LayoutTests:

Update test expectations to skip
image-loading-lazy-in-cross-origin-ifame-001.sub.html and
image-loading-lazy-in-cross-origin-ifame-002.sub.html.

  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
2:32 AM Changeset in webkit [256915] by alex
  • 2 edits in trunk/LayoutTests

REGRESSION(r188639): Several inspector tests timeout because they are slow after r188639
​https://bugs.webkit.org/show_bug.cgi?id=149916

Unreviewed GTK gardening. Add some more tests as Pass Slow for the inspector bug.

  • platform/gtk/TestExpectations:
1:25 AM Changeset in webkit [256914] by cathiechen
  • 2 edits in trunk/Source/WebKit

Enable AspectRatioOfImgFromWidthAndHeightEnabled by default
​https://bugs.webkit.org/show_bug.cgi?id=207880

Reviewed by Frédéric Wang.

  • Shared/WebPreferences.yaml:

Feb 18, 2020:

10:56 PM Changeset in webkit [256913] by zandobersek@gmail.com
  • 6 edits in trunk

[WPE] Support 2D axis, smooth-motion events
​https://bugs.webkit.org/show_bug.cgi?id=207881

Reviewed by Carlos Garcia Campos.

Source/WebKit:

WPE's WebEventFactory should also handle axis events that are capable
of providing information about axis change in both dimensions. In case
of smooth motion, the delta values should be preserved and not
transformed into line-steps.

Similarly, the ScrollGestureController should also adopt the 2D axis
event type, producing smooth-motion events when dispatching handling
a scroll gesture.

The changes are guarded and only enabled when building against at least
libwpe 1.5.0 since that's when the new API was added.

  • Shared/libwpe/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

  • UIProcess/API/wpe/ScrollGestureController.cpp:

(WebKit::ScrollGestureController::handleEvent):

  • UIProcess/API/wpe/ScrollGestureController.h:

(WebKit::ScrollGestureController::axisEvent):

Tools:

  • wpe/jhbuild.modules: Bump to a newer libwpe commit.
10:44 PM Changeset in webkit [256912] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit

Set User-Agent in preconnect requests
​https://bugs.webkit.org/show_bug.cgi?id=207777

Patch by Ben Nham <Ben Nham> on 2020-02-18
Reviewed by Chris Dumez.

When using an HTTPS proxy, CFNetwork will not reuse a preconnected socket if the User-Agent
on the preconnect request doesn't match the User-Agent of the actual request
(<rdar://problem/59434166>). To work around this, this sets the User-Agent on preconnect
requests.

In addition, this patch moves the preconnect request from WebPage::loadRequest in the
WebProcess to WebPageProxy::loadRequest in the UIProcess. This is because there can be
long sync IPCs that last >100 ms that occur before WebProcess::loadRequest even starts,
e.g. ​https://bugs.webkit.org/show_bug.cgi?id=203165.

By making both changes, we see a ~2% improvement in PLT5 times.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::preconnectTo):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::preconnectTo):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::preconnectTo):

  • UIProcess/WebPageProxy.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::preconnectTo):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadRequest):

9:42 PM Changeset in webkit [256911] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

Rename ScrollView::styleDidChange to styleAndRenderTreeDidChange
​https://bugs.webkit.org/show_bug.cgi?id=207921

Reviewed by Simon Fraser.

When ScrollView::styleDidChange is called we actually finished updating the render tree as well.

  • dom/Document.cpp:

(WebCore::Document::resolveStyle):

  • page/FrameView.cpp:

(WebCore::FrameView::styleAndRenderTreeDidChange):
(WebCore::FrameView::styleDidChange): Deleted.

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::styleAndRenderTreeDidChange):
(WebCore::ScrollView::styleDidChange): Deleted.

  • platform/ScrollView.h:
  • rendering/RenderView.cpp: FrameView::styleDidChange gets called by the Document.

(WebCore::RenderView::styleDidChange): Deleted.

  • rendering/RenderView.h:
9:37 PM Changeset in webkit [256910] by keith_miller@apple.com
  • 11 edits
    1 copy
    1 add in trunk/Source

Add an os_log PrintStream
​https://bugs.webkit.org/show_bug.cgi?id=207898

Reviewed by Mark Lam.

Source/JavaScriptCore:

Add jsc option to write dataLogs to os_log.

  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/OptionsList.h:

Source/WTF:

When debugging on iOS writing to a file can be hard (thanks
Sandboxing!) so logging our dataLogs to os_log would make things
easier. This patch adds a new subclass of PrintStream,
OSLogPrintStream, that converts our file writes to
os_log. Unfortunately, os_log doesn't buffer writes so
OSLogPrintStream needs to do its own buffering. e.g. if you call
dataLogLn("some text with a ", number, " and a ", string);
os_log will log that as 5 separate logs.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/DataLog.cpp:

(WTF::setDataFile):

  • wtf/DataLog.h:
  • wtf/OSLogPrintStream.cpp: Added.

(WTF::OSLogPrintStream::OSLogPrintStream):
(WTF::OSLogPrintStream::~OSLogPrintStream):
(WTF::OSLogPrintStream::open):
(WTF::OSLogPrintStream::vprintf):

  • wtf/OSLogPrintStream.h: Copied from Source/WTF/wtf/DataLog.h.
  • wtf/PrintStream.cpp:

(WTF::printExpectedCStringHelper):
(WTF::printInternal):

  • wtf/text/CString.cpp:

(WTF::CString::grow):

  • wtf/text/CString.h:
9:20 PM Changeset in webkit [256909] by Lauro Moura
  • 3 edits in trunk/LayoutTests

[GTK] Gardening release build crashes
​https://bugs.webkit.org/show_bug.cgi?id=207928

Unreviewed test gardening.

  • platform/gtk-wayland/TestExpectations:
  • platform/gtk/TestExpectations:
9:17 PM Changeset in webkit [256908] by Kocsen Chung
  • 1 copy in tags/Safari-610.1.3.3

Tag Safari-610.1.3.3.

9:14 PM Changeset in webkit [256907] by Kocsen Chung
  • 62 edits in branches/safari-610.1.3-branch/Source

Cherry-pick r256791. rdar://problem/59577979

getVTablePointer() should return a const void*.
​https://bugs.webkit.org/show_bug.cgi?id=207871
<rdar://problem/59525721>

Reviewed by Yusuke Suzuki.

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation):
  • bindings/scripts/test/JS/JSInterfaceName.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSMapLike.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSReadOnlyMapLike.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSReadOnlySetLike.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSSetLike.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestCEReactions.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestCallTracer.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestEnabledBySetting.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestEnabledForContext.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestEventTarget.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestException.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestGlobalObject.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestIterable.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNode.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestPluginInterface.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestSerialization.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestTypedefs.cpp: (WebCore::toJSNewlyCreated):

Source/WTF:

  • wtf/PointerPreparations.h: (WTF::getVTablePointer):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:11 PM Changeset in webkit [256906] by Kocsen Chung
  • 8 edits in branches/safari-610.1.3-branch/Source

Versioning.

8:57 PM Changeset in webkit [256905] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

ASSERTION FAILED: !m_embeddedObjectsToUpdate->contains(nullptr) in WebCore::FrameView::updateEmbeddedObjects
​https://bugs.webkit.org/show_bug.cgi?id=191532
<rdar://problem/46151555>

Patch by Jack Lee <Jack Lee> on 2020-02-18
Reviewed by Darin Adler.

Add reentrancy protection for FrameView::updateEmbeddedObjects().
Move the common code in renderWidgetLoadingPlugin() to inherited class, HTMLPlugInElement.

Source/WebCore:

Test: fast/text/textCombine-update-embeddedObj-assert.html

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::renderWidgetLoadingPlugin const):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetLoadingPlugin const):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderWidgetLoadingPlugin const): Deleted.

  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::renderWidgetLoadingPlugin const):

  • html/HTMLPlugInElement.h:
  • page/FrameView.cpp:

(WebCore::FrameView::updateEmbeddedObjects):

  • page/FrameView.h:

LayoutTests:

  • fast/text/textCombine-update-embeddedObj-assert-expected.txt: Added.
  • fast/text/textCombine-update-embeddedObj-assert.html: Added.
8:50 PM Changeset in webkit [256904] by youenn@apple.com
  • 7 edits in trunk/Source/WebCore

Reduce use of PlatformMediaSessionManager::sharedManager()
​https://bugs.webkit.org/show_bug.cgi?id=207924

Reviewed by Eric Carlson.

The plan is to be able to have PlatformMediaSession in GPU process which might have different managers,
typically a manager per connection to web process.
For that reason, reduce the use of the sharedManager to classes that can only live in WebProcess.
No change of behavior.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::MediaElementSession):
(WebCore::MediaElementSession::clientDataBufferingTimerFired):
(WebCore::MediaElementSession::setHasPlaybackTargetAvailabilityListeners):

  • platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::create):
(WebCore::PlatformMediaSession::PlatformMediaSession):
(WebCore::PlatformMediaSession::~PlatformMediaSession):
(WebCore::PlatformMediaSession::setState):
(WebCore::PlatformMediaSession::clientWillBeginPlayback):
(WebCore::PlatformMediaSession::processClientWillPausePlayback):
(WebCore::PlatformMediaSession::stopSession):
(WebCore::PlatformMediaSession::isPlayingToWirelessPlaybackTargetChanged):
(WebCore::PlatformMediaSession::canProduceAudioChanged):
(WebCore::PlatformMediaSession::clientCharacteristicsChanged):
(WebCore::PlatformMediaSession::manager):

  • platform/audio/PlatformMediaSession.h:
  • platform/audio/PlatformMediaSessionManager.h:
8:15 PM Changeset in webkit [256903] by Wenson Hsieh
  • 6 edits in trunk

REGRESSION (r256093): fast/events/touch/ios/block-without-overflow-scroll.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=207919
<rdar://problem/59565344>

Reviewed by Tim Horton.

Source/WebCore:

Three iOS-specific layout tests began to fail after r256093, since they currently depend on a particular
ordering when iterating over elements in a hash map. Instead of just rebaselining these tests, we can make them
more robust against similar changes in the future by forcing a deterministic order when printing out synchronous
touch event regions for testing.

I arbitrarily chose to sort the keys (which are touch event type names) in alphabetical order.

  • page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::dumpProperties const):

LayoutTests:

Rebaseline some layout tests after changing the order in which synchronous touch event regions are dumped when
calling internals.scrollingStateTreeAsText().

  • fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt:
  • fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt:
  • fast/events/touch/ios/block-without-overflow-scroll-scrolling-state-expected.txt:
7:53 PM Changeset in webkit [256902] by Lauro Moura
  • 2 edits in trunk/Source/WebKit

[WebKit] Avoid segfault if editor client is null
​https://bugs.webkit.org/show_bug.cgi?id=207925

Reviewed by Darin Adler.

Missing check was causing crashes running
editing/selection/selection-change-in-disconnected-frame-crash.html in
Mojave, iOS and GTK bots.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):

7:38 PM Changeset in webkit [256901] by youenn@apple.com
  • 7 edits in trunk/Source/WebCore

PlatformMediaSessionClient::processingUserGestureForMedia is not needed
​https://bugs.webkit.org/show_bug.cgi?id=207922

Reviewed by Eric Carlson.

All code relies on the document and the virtual method is never used so remove it.
No change of behavior.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::processingUserGestureForMedia const): Deleted.

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::processingUserGestureForMedia const): Deleted.

  • Modules/webaudio/AudioContext.h:
  • html/HTMLMediaElement.h:
  • platform/audio/PlatformMediaSession.h:
7:26 PM Changeset in webkit [256900] by youenn@apple.com
  • 16 edits in trunk/Source

SWServer::claim should check for the service worker to be active
​https://bugs.webkit.org/show_bug.cgi?id=207739
<rdar://problem/45441129>

Reviewed by Alex Christensen.

Source/WebCore:

claim is only working for service workers that are active.
But there might be a time when a service worker is active in its web process but redundant in networking process.
Thus, we need to move the check from WebProcess to NetworkProcess.

  • workers/service/ServiceWorkerClients.cpp:

(WebCore::ServiceWorkerClients::claim):

  • workers/service/context/SWContextManager.h:
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::claim):

  • workers/service/server/SWServer.h:
  • workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::claim):

  • workers/service/server/SWServerToContextConnection.h:
  • workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::claim): Deleted.

  • workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::isActive const):

Source/WebKit:

Use Async Reply to remove the need for a map and passing integers around.

  • NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::claimCompleted): Deleted.

  • NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
  • NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
  • WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::claim):
(WebKit::WebSWContextManagerConnection::claimCompleted): Deleted.

  • WebProcess/Storage/WebSWContextManagerConnection.h:
  • WebProcess/Storage/WebSWContextManagerConnection.messages.in:
6:38 PM Changeset in webkit [256899] by Alan Coon
  • 18 edits in branches/safari-609-branch

Apply patch. rdar://problem/59465474

6:10 PM Changeset in webkit [256898] by Simon Fraser
  • 2 edits in branches/safari-609-branch/Source/JavaScriptCore

Unreviewed build fix.

  • jit/JITThunks.cpp:

(JSC::JITThunks::hostFunctionStub):

5:34 PM Changeset in webkit [256897] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Changed results due to ANGLE use
​https://bugs.webkit.org/show_bug.cgi?id=207858

Unreviewed test gardening.

Remove conflict markers that were accidentally added as part of r256880,
remove duplicated expectation for a test, and move the expectations to the same
file as the rest of the ANGLE related failures.

  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
5:29 PM Changeset in webkit [256896] by Alan Coon
  • 29 edits
    4 copies
    6 adds in branches/safari-609-branch

Cherry-pick r256191. rdar://problem/59447003

Disallow setting base URL to a data or JavaScript URL
​https://bugs.webkit.org/show_bug.cgi?id=207136

Source/WebCore:

Reviewed by Brent Fulgham.

Inspired by <​https://bugs.chromium.org/p/chromium/issues/detail?id=679318>.

Block setting the base URL to a data URL or JavaScript URL as such usage is questionable.
This makes WebKit match the behavior of Chrome and Firefox and is in the spirit of the
discussion in <​https://github.com/whatwg/html/issues/2249>.

On Mac and iOS, this restriction is applied only to apps linked against a future SDK to
avoid breaking shipped apps.

For all other ports, this restriction is enabled by default.

Tests: fast/url/relative2.html

fast/url/segments-from-data-url2.html
http/tests/security/allowed-base-url-data-url-via-setting.html
http/tests/security/denied-base-url-data-url.html
http/tests/security/denied-base-url-javascript-url.html

  • dom/Document.cpp: (WebCore::Document::processBaseElement): Condition updating the parsed base URL on whether is has an allowed scheme, if restrictions are enabled. Otherwise, do what we do now. If the scheme is disallowed then log a message to the console to explain this to web developers.
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::TokenPreloadScanner::scan): Pass whether to apply restrictons to the base URL to updatePredictedBaseURL(). This depends on whether the setting is enabled or not. (WebCore::TokenPreloadScanner::updatePredictedBaseURL): Modifed to take a boolean as to whether to apply restrictions. If restrictions are not to be applied do what we do now. Otherwise, only do what we do now if the scheme for the predicated base URL is allowed.
  • html/parser/HTMLPreloadScanner.h:
  • page/SecurityPolicy.cpp: (WebCore::SecurityPolicy::isBaseURLSchemeAllowed): Added.
  • page/SecurityPolicy.h:
  • page/Settings.yaml: Add a setting to toggle restrictions on the base URL scheme.

Source/WebKit:

Reviewed by Brent Fulgham.

Apply base URL restrictions to apps linked to a future WebKit to avoid breaking existing apps.

  • Shared/WebPreferences.yaml:
  • UIProcess/API/Cocoa/WKWebView.mm: (shouldRestrictBaseURLSchemes): Added. (-[WKWebView _setupPageConfiguration:]): Update settings.
  • UIProcess/Cocoa/VersionChecks.h:

Source/WebKitLegacy/mac:

Reviewed by Brent Fulgham.

Apply base URL restrictions to apps linked to a future WebKit to avoid breaking existing apps.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (shouldRestrictBaseURLSchemes): Added. (-[WebView _commonInitializationWithFrameName:groupName:]): Update settings.

Source/WTF:

Reviewed by Brent Fulgham.

Add some more macro definitions.

  • wtf/spi/darwin/dyldSPI.h:

LayoutTests:

RReviewed by Brent Fulgham.

Add some tests. Update others to toggle the setting to apply or unapply the new behavior.

The test denied-base-url-javascript-url.html is derived from the test base-url-javascript.html,
included in <​https://chromium.googlesource.com/chromium/src.git/+/c133efa0b915430701930b76a7cfe35608b9a403>.

  • fast/url/relative-expected.txt:
  • fast/url/relative.html:
  • fast/url/relative2-expected.txt: Copied from LayoutTests/fast/url/relative-expected.txt.
  • fast/url/relative2.html: Copied from LayoutTests/fast/url/relative.html.
  • fast/url/resources/utilities.js: (setShouldEllipsizeFileURLPaths): Added. Toggles ellipsizing the path portion of a file URL to simplify matching. Otherwise, file URLs could be machine-specific. (canonicalizedPathname): Added. (segments): Modified to optionally call canonicalizedPathname. (canonicalize): Ditto.
  • fast/url/segments-from-data-url-expected.txt:
  • fast/url/segments-from-data-url.html:
  • fast/url/segments-from-data-url2-expected.txt: Copied from LayoutTests/fast/url/segments-from-data-url-expected.txt.
  • fast/url/segments-from-data-url2.html: Copied from LayoutTests/fast/url/segments-from-data-url.html.
  • fetch/fetch-url-serialization-expected.txt:
  • http/tests/plugins/navigation-during-load-embed.html:
  • http/tests/plugins/navigation-during-load.html:
  • http/tests/security/allowed-base-url-data-url-via-setting-expected.txt: Added.
  • http/tests/security/allowed-base-url-data-url-via-setting.html: Added.
  • http/tests/security/denied-base-url-data-url-expected.txt: Added.
  • http/tests/security/denied-base-url-data-url.html: Added.
  • http/tests/security/denied-base-url-javascript-url-expected.txt: Added.
  • http/tests/security/denied-base-url-javascript-url.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:23 PM Changeset in webkit [256895] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][IFC] Replaced elements can also establish formatting contexts.
​https://bugs.webkit.org/show_bug.cgi?id=207923
<rdar://problem/59571203>

Reviewed by Simon Fraser.

Source/WebCore:

While replaced boxes (leaf boxes) can also establish formatting contexts (e.g. style="inline-block"), we
only need to construct formatting context objects for the root's descendants (and not for the root itself).

Test: fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

LayoutTests:

  • fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple-expected.html: Added.
  • fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html: Added.
5:16 PM Changeset in webkit [256894] by Ryan Haddad
  • 6 edits in trunk/Tools

Unreviewed, rolling out r256851.

Broke internal bots

Reverted changeset:

"Stub repositories fail to upload some results due to missing
head svn revision"
​https://bugs.webkit.org/show_bug.cgi?id=207684
​https://trac.webkit.org/changeset/256851

5:14 PM Changeset in webkit [256893] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.3.1

Tag Safari-609.1.20.3.1.

5:12 PM Changeset in webkit [256892] by commit-queue@webkit.org
  • 27 edits
    1 copy
    3 moves
    16 adds
    6 deletes in trunk/Source

Allow different back-ends for ImageBuffer
​https://bugs.webkit.org/show_bug.cgi?id=207048

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-02-18
Reviewed by Tim Horton.

Source/WebCore:

ImageBuffer will be re-factored to decouple the platform specifics and
the back-end details from the interface "ImageBuffer".

A class hierarchy for the ImageBufferBackend will added to allow code
sharing and to split the code according to the platform and the back-end
details.

ImageBuffer will be kept interface with the rest of the code but different
back-ends will be created. ConcreteImageBuffer is a template class which
inherits ImageBuffer and will act as a bridge to the concrete
ImageBufferBackend.

Based on the RenderingMode, a ConcreteImageBuffer<BackendType> will
be created. Instead of checking the renderingMode in many places of the
code and instead of and using preprocessor directives, all these decisions
will be made in the concrete ImageBufferBackend.

This re-factoring will allow creating new types of ImageBuffers backed by
new ImageBufferBackends. These new ImageBufferBackends will implement
DisplayList drawing and synchronize remote rendering.

  • Headers.cmake:
  • PlatformAppleWin.cmake:
  • PlatformFTW.cmake:
  • PlatformMac.cmake:
  • PlatformWin.cmake:
  • Sources.txt:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • html/CanvasBase.cpp:

(WebCore::CanvasBase::setImageBuffer const):

  • platform/Cairo.cmake:
  • platform/SourcesCairo.txt:
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::nativeImageForCurrentFrameRespectingOrientation):

  • platform/graphics/ConcreteImageBuffer.h: Added.

(WebCore::ConcreteImageBuffer::create):
(WebCore::ConcreteImageBuffer::ConcreteImageBuffer):
(WebCore::ConcreteImageBuffer::ensureBackend const):
(WebCore::ConcreteImageBuffer::putImageData):

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::create):
(WebCore::ImageBuffer::createCompatibleBuffer):
(WebCore::ImageBuffer::sizeNeedsClamping):
(WebCore::ImageBuffer::compatibleBufferSize):
(WebCore::ImageBuffer::sinkIntoNativeImage):
(WebCore::ImageBuffer::sinkIntoImage):
(WebCore::ImageBuffer::drawConsuming):
(WebCore::ImageBuffer::toBGRAData const): Deleted.
(WebCore::ImageBuffer::transformColorSpace): Deleted.
(WebCore::ImageBuffer::genericConvertToLuminanceMask): Deleted.
(WebCore::ImageBuffer::convertToLuminanceMask): Deleted.
(WebCore::ImageBuffer::platformLayer const): Deleted.
(WebCore::ImageBuffer::copyToPlatformTexture): Deleted.
(WebCore::ImageBuffer::memoryCost const): Deleted.
(WebCore::ImageBuffer::externalMemoryCost const): Deleted.

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::drawConsuming):
(WebCore::ImageBuffer::putImageData):
(): Deleted.
(WebCore::ImageBuffer::internalSize const): Deleted.
(WebCore::ImageBuffer::logicalSize const): Deleted.
(WebCore::ImageBuffer::resolutionScale const): Deleted.
(WebCore::ImageBuffer::baseTransform const): Deleted.

  • platform/graphics/ImageBufferBackend.cpp: Added.

(WebCore::ImageBufferBackend::ImageBufferBackend):
(WebCore::ImageBufferBackend::calculateBackendSize):
(WebCore::ImageBufferBackend::sinkIntoNativeImage):
(WebCore::ImageBufferBackend::sinkIntoImage):
(WebCore::ImageBufferBackend::drawConsuming):
(WebCore::ImageBufferBackend::convertToLuminanceMask):
(WebCore::ImageBufferBackend::toBGRAData const):
(WebCore::copyPremultipliedToPremultiplied):
(WebCore::copyPremultipliedToUnpremultiplied):
(WebCore::copyUnpremultipliedToPremultiplied):
(WebCore::copyFunctor):
(WebCore::ImageBufferBackend::copyImagePixels const):
(WebCore::ImageBufferBackend::getImageData const):
(WebCore::ImageBufferBackend::putImageData):

  • platform/graphics/ImageBufferBackend.h: Added.

(WebCore::ImageBufferBackend::flushContext):
(WebCore::ImageBufferBackend::logicalSize const):
(WebCore::ImageBufferBackend::backendSize const):
(WebCore::ImageBufferBackend::resolutionScale const):
(WebCore::ImageBufferBackend::colorSpace const):
(WebCore::ImageBufferBackend::baseTransform const):
(WebCore::ImageBufferBackend::memoryCost const):
(WebCore::ImageBufferBackend::externalMemoryCost const):
(WebCore::ImageBufferBackend::transformColorSpace):
(WebCore::ImageBufferBackend::platformLayer const):
(WebCore::ImageBufferBackend::copyToPlatformTexture const):
(WebCore::ImageBufferBackend::bytesPerRow const):
(WebCore::ImageBufferBackend::backendColorFormat const):
(WebCore::ImageBufferBackend::toBackendCoordinates const):
(WebCore::ImageBufferBackend::logicalRect const):
(WebCore::ImageBufferBackend::backendRect const):

  • platform/graphics/PlatformImageBuffer.h: Added.
  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::drawShadowBuffer):

  • platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawShadowLayerBuffer):
(WebCore::Cairo::drawShadowImage):
(WebCore::Cairo::fillShadowBuffer):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clipToImageBuffer):

  • platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::clipToImageBuffer):

  • platform/graphics/cairo/ImageBufferCairo.cpp: Removed.
  • platform/graphics/cairo/ImageBufferCairoBackend.cpp: Added.

(WebCore::ImageBufferCairoBackend::copyImage const):
(WebCore::ImageBufferCairoBackend::draw):
(WebCore::ImageBufferCairoBackend::drawPattern):
(WebCore::ImageBufferCairoBackend::transformColorSpace):
(WebCore::ImageBufferCairoBackend::toDataURL const):
(WebCore::ImageBufferCairoBackend::toData const):

  • platform/graphics/cairo/ImageBufferCairoBackend.h: Added.

(WebCore::ImageBufferCairoBackend::platformTransformColorSpace):

  • platform/graphics/cairo/ImageBufferCairoGLSurfaceBackend.cpp: Added.

(WebCore::clearSurface):
(WebCore::ImageBufferCairoGLSurfaceBackend::create):
(WebCore::ImageBufferCairoGLSurfaceBackend::ImageBufferCairoGLSurfaceBackend):
(WebCore::ImageBufferCairoGLSurfaceBackend::~ImageBufferCairoGLSurfaceBackend):
(WebCore::ImageBuffer::platformLayer const):
(WebCore::ImageBufferCairoGLSurfaceBackend::copyToPlatformTexture):
(WebCore::ImageBufferCairoGLSurfaceBackend::createCompositorBuffer):
(WebCore::ImageBufferCairoGLSurfaceBackend::swapBuffersIfNeeded):
(WebCore::ImageBufferCairoGLSurfaceBackend::paintToTextureMapper):

  • platform/graphics/cairo/ImageBufferCairoGLSurfaceBackend.h: Added.
  • platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp: Added.

(WebCore::ImageBufferCairoImageSurfaceBackend::create):
(WebCore::ImageBufferCairoImageSurfaceBackend::ImageBufferCairoImageSurfaceBackend):
(WebCore::ImageBufferCairoImageSurfaceBackend::platformTransformColorSpace):

  • platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.h: Added.
  • platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp: Added.

(WebCore::ImageBufferCairoSurfaceBackend::ImageBufferCairoSurfaceBackend):
(WebCore::ImageBufferCairoSurfaceBackend::context const):
(WebCore::ImageBufferCairoSurfaceBackend::bytesPerRow const):
(WebCore::ImageBufferCairoSurfaceBackend::copyNativeImage const):
(WebCore::ImageBufferCairoSurfaceBackend::cairoSurfaceCoerceToImage const):
(WebCore::ImageBufferCairoSurfaceBackend::toBGRAData const):
(WebCore::ImageBufferCairoSurfaceBackend::getImageData const):
(WebCore::ImageBufferCairoSurfaceBackend::putImageData):

  • platform/graphics/cairo/ImageBufferCairoSurfaceBackend.h: Added.
  • platform/graphics/cg/ImageBufferCG.cpp: Removed.
  • platform/graphics/cg/ImageBufferCGBackend.cpp: Added.

(WebCore::ImageBufferCGBackend::contextColorSpace):
(WebCore::ImageBufferCGBackend::setupContext):
(WebCore::createCroppedImageIfNecessary):
(WebCore::createBitmapImageAfterScalingIfNeeded):
(WebCore::ImageBufferCGBackend::copyImage const):
(WebCore::ImageBufferCGBackend::sinkIntoImage):
(WebCore::ImageBufferCGBackend::draw):
(WebCore::ImageBufferCGBackend::drawPattern):
(WebCore::ImageBufferCGBackend::baseTransform const):
(WebCore::ImageBufferCGBackend::toCFData const):
(WebCore::ImageBufferCGBackend::toData const):
(WebCore::ImageBufferCGBackend::toDataURL const):
(WebCore::makeVImageBuffer):
(WebCore::copyImagePixelsAccelerated):
(WebCore::ImageBufferCGBackend::copyImagePixels const):

  • platform/graphics/cg/ImageBufferCGBackend.h: Added.
  • platform/graphics/cg/ImageBufferCGBitmapBackend.cpp: Added.

(WebCore::ImageBufferCGBitmapBackend::create):
(WebCore::ImageBufferCGBitmapBackend::ImageBufferCGBitmapBackend):
(WebCore::ImageBufferCGBitmapBackend::context const):
(WebCore::ImageBufferCGBitmapBackend::copyNativeImage const):
(WebCore::ImageBufferCGBitmapBackend::toBGRAData const):
(WebCore::ImageBufferCGBitmapBackend::getImageData const):
(WebCore::ImageBufferCGBitmapBackend::putImageData):

  • platform/graphics/cg/ImageBufferCGBitmapBackend.h: Added.
  • platform/graphics/cg/ImageBufferDataCG.cpp: Removed.
  • platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp: Added.

(WebCore::ImageBufferIOSurfaceBackend::calculateBackendSize):
(WebCore::ImageBufferIOSurfaceBackend::contextColorSpace):
(WebCore::ImageBufferIOSurfaceBackend::create):
(WebCore::ImageBufferIOSurfaceBackend::ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::context const):
(WebCore::ImageBufferIOSurfaceBackend::flushContext):
(WebCore::ImageBufferIOSurfaceBackend::memoryCost const):
(WebCore::ImageBufferIOSurfaceBackend::externalMemoryCost const):
(WebCore::ImageBufferIOSurfaceBackend::bytesPerRow const):
(WebCore::ImageBufferIOSurfaceBackend::backendColorFormat const):
(WebCore::ImageBufferIOSurfaceBackend::copyNativeImage const):
(WebCore::ImageBufferIOSurfaceBackend::sinkIntoNativeImage):
(WebCore::ImageBufferIOSurfaceBackend::drawConsuming):
(WebCore::ImageBufferIOSurfaceBackend::toBGRAData const):
(WebCore::ImageBufferIOSurfaceBackend::getImageData const):
(WebCore::ImageBufferIOSurfaceBackend::putImageData):

  • platform/graphics/cg/ImageBufferIOSurfaceBackend.h: Added.
  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):

  • platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::createFromImageBuffer): Deleted.

  • platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

(WebCore::GraphicsContextGLOpenGL::paintRenderingResultsToCanvas):

  • platform/graphics/win/ImageBufferDataDirect2D.cpp: Removed.
  • platform/graphics/win/ImageBufferDataDirect2D.h: Removed.
  • platform/graphics/win/ImageBufferDirect2D.cpp: Removed.
  • platform/graphics/win/ImageBufferDirect2DBackend.cpp: Added.

(WebCore::ImageBufferDirect2DBackend::create):
(WebCore::ImageBufferDirect2DBackend::ImageBufferDirect2DBackend):
(WebCore::ImageBufferDirect2DBackend::context const):
(WebCore::ImageBufferDirect2DBackend::flushContext):
(WebCore::ImageBufferDirect2DBackend::copyNativeImage const):
(WebCore::createCroppedImageIfNecessary):
(WebCore::createBitmapImageAfterScalingIfNeeded):
(WebCore::ImageBufferDirect2DBackend::copyImage const):
(WebCore::ImageBufferDirect2DBackend::sinkIntoImage):
(WebCore::ImageBufferDirect2DBackend::compatibleBitmap):
(WebCore::ImageBufferDirect2DBackend::draw):
(WebCore::ImageBufferDirect2DBackend::drawPattern):
(WebCore::ImageBufferDirect2DBackend::toDataURL const):
(WebCore::ImageBufferDirect2DBackend::toData const):
(WebCore::ImageBufferDirect2DBackend::toBGRAData const):
(WebCore::ImageBufferDirect2DBackend::getImageData const):
(WebCore::ImageBufferDirect2DBackend::putImageData):

  • platform/graphics/win/ImageBufferDirect2DBackend.h: Added.
  • platform/mediastream/gstreamer/MockGStreamerVideoCaptureSource.cpp:

(WebCore::WrappedMockRealtimeVideoSource::updateSampleBuffer):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::bufferForeground):

Source/WebKit:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSelectionSnapshot const):

5:12 PM Changeset in webkit [256891] by Alan Coon
  • 1 copy in tags/Safari-609.1.20.2.1

Tag Safari-609.1.20.2.1.

5:06 PM Changeset in webkit [256890] by youenn@apple.com
  • 8 edits in trunk/Source/WebKit

Add support for WebInspector WebSocket handshake in the new WebSocket code path
​https://bugs.webkit.org/show_bug.cgi?id=207913

Reviewed by Alex Christensen.

Whenever creating the WebSocketTask, pass the request actually used for handshake to the WebProcess.
Whenever being connected, pass the request actually used for handshake to the WebProcess.
In case of failure before the web socket is connected, we send the response if we can get a non null from the task.

  • NetworkProcess/NetworkSocketChannel.cpp:

(WebKit::NetworkSocketChannel::didSendHandshakeRequest):
(WebKit::NetworkSocketChannel::didReceiveHandshakeResponse):

  • NetworkProcess/NetworkSocketChannel.h:
  • NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::WebSocketTask):
(WebKit::WebSocketTask::didConnect):

  • WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::connect):
(WebKit::WebSocketChannel::didConnect):
(WebKit::WebSocketChannel::didSendHandshakeRequest):
(WebKit::WebSocketChannel::didReceiveHandshakeResponse):

  • WebProcess/Network/WebSocketChannel.h:
  • WebProcess/Network/WebSocketChannel.messages.in:
4:49 PM Changeset in webkit [256889] by Fujii Hironori
  • 7 edits in trunk/Tools

[Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
​https://bugs.webkit.org/show_bug.cgi?id=207883

Reviewed by Ross Kirsling.

Unlike other mouse buttons, 4th and 5th mouse buttons are
processed differently. Clicking them dispatches WM_XBUTTONDOWN and
WM_XBUTTONUP events to the window under the mouse cursor.
Unhandled WM_XBUTTONUP events are automatically converted to
WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
parent window.
<​https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>

Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
handled.

  • MiniBrowser/win/BrowserWindow.h:
  • MiniBrowser/win/MainWindow.cpp:

(MainWindow::WndProc):

  • MiniBrowser/win/WebKitBrowserWindow.cpp:

(WebKitBrowserWindow::navigateForwardOrBackward):

  • MiniBrowser/win/WebKitBrowserWindow.h:
  • MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:

(WebKitLegacyBrowserWindow::navigateForwardOrBackward):

  • MiniBrowser/win/WebKitLegacyBrowserWindow.h:
4:48 PM Changeset in webkit [256888] by Russell Epstein
  • 9 edits
    1 add in branches/safari-609-branch

Cherry-pick r256779. rdar://problem/59551695

[JSC] JITThunk should be HashSet<Weak<NativeExecutable>> with appropriate GC weakness handling
​https://bugs.webkit.org/show_bug.cgi?id=207715

Reviewed by Darin Adler.

JSTests:

  • stress/stress-jitthunks.js: Added. (let.set newGlobal): (set catch):

Source/JavaScriptCore:

This patch refines JITThunks GC-aware Weak hash map for NativeExecutable. Previously, we have
HashMap<std::tuple<TaggedNativeFunction, TaggedNativeFunction, String>, Weak<NativeExecutable>> table.
But this is not good because the first tuple's information is already in NativeExecutable.
But we were using this design since Weak<NativeExecutable> can be nullified because of Weak<>. If this
happens, we could have invalid Entry in HashMap which does not have corresponding values. This will
cause crash when rehasing requires hash code for this entry.

But this HashMap is very bad in terms of memory usage. Each entry has 32 bytes, and this table gets enough
large. We identified that this table is consuming much memory in Membuster. So it is worth designing
carefully crafted data structure which only holds Weak<NativeExecutable> by leveraging the deep interaction
with our GC implementation.

This patch implements new design of JITThunks, which uses HashSet<Weak<NativeExecutable>> and carefully crafted
HashTraits / KeyTraits to handle Weak<> well.

  1. Each Weak should have finalizer, and this finalizer should remove dead Weak<NativeExecutable> from HashSet.

This is ensuring that all the keys in HashSet is, even if Weak<> is saying it is Dead, it still has an way
to access content of NativeExecutable if the content is not a JS objects. For example, we can get function
pointer from dead Weak<NativeExecutable> if it is not yet finalized. Since we remove all finalized Weak<>
from the table, this finalizer mechanism allows us to access function pointers etc. from Weak<NativeExecutable>
so long as it is held in this table.

  1. Getting NativeExecutable* from JITThunks should have special protocol.

When getting NativeExecutable* from JITThunks, we do the following,

  1. First, we check we have an Entry in JITThunks. If it does not exist, we should insert it anyway.

1.1. If it exists, we should check whether this Weak<NativeExecutable> is dead or not. It is possible that

dead one is still in the table because "dead" does not mean that it is "finalized". Until finalizing happens (and
it can be delayed by incremental-sweeper), Weak<NativeExecutable> can be dead but still accessible. So the table
is still holding dead one. If we get dead one, we should insert a new one.

1.2. If it is not dead, we return it.

  1. Second, we create a new NativeExecutable and insert it. In that case, it is possible that the table already has Weak<NativeExecutable>, but it is dead. In that case, we need to explicitly replace it with newly created one since old one is holding old content. If we replaced, finalizer of Weak<> will not be invoked since it immediately deallocates Weak<>. So, it does not happen that this newly inserted NativeExecutable* is removed by the finalizer registered by the old Weak<>.

This change makes memory usage of JITThunks table 1/4.

  • heap/Weak.cpp: (JSC::weakClearSlowCase):
  • heap/Weak.h: (JSC::Weak::Weak): (JSC::Weak::isHashTableEmptyValue const): (JSC::Weak::unsafeImpl const): (WTF::HashTraits<JSC::Weak<T>>::isEmptyValue):
  • heap/WeakInlines.h: (JSC::Weak<T>::Weak):
  • jit/JITThunks.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::WeakNativeExecutableHash::hash): (JSC::JITThunks::WeakNativeExecutableHash::equal): (JSC::JITThunks::HostKeySearcher::hash): (JSC::JITThunks::HostKeySearcher::equal): (JSC::JITThunks::NativeExecutableTranslator::hash): (JSC::JITThunks::NativeExecutableTranslator::equal): (JSC::JITThunks::NativeExecutableTranslator::translate): (JSC::JITThunks::finalize): (JSC::JITThunks::hostFunctionStub): (JSC::JITThunks::clearHostFunctionStubs): Deleted.
  • jit/JITThunks.h:
  • runtime/NativeExecutable.h:
  • tools/JSDollarVM.cpp: (JSC::functionGCSweepAsynchronously): (JSC::functionCreateEmptyFunctionWithName): (JSC::JSDollarVM::finishCreation):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:48 PM Changeset in webkit [256887] by Russell Epstein
  • 3 edits
    1 add in branches/safari-609-branch

Cherry-pick r256766. rdar://problem/59551706

[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
​https://bugs.webkit.org/show_bug.cgi?id=207849

Reviewed by Mark Lam.

JSTests:

  • wasm/regress/regress-256665.js: Added. (f):

Source/JavaScriptCore:

When generating the call IC, we should select the callee saves using BoundsChecking mode in order
to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
register when calling the Wasm LLInt through the call IC.

  • wasm/js/WebAssemblyFunction.cpp: (JSC::WebAssemblyFunction::calleeSaves const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:47 PM Changeset in webkit [256886] by Russell Epstein
  • 3 edits in branches/safari-609-branch/JSTests

Cherry-pick r256698. rdar://problem/59551715

Unreviewed: fix broken tests added in r256665
​https://bugs.webkit.org/show_bug.cgi?id=207727

Our inline WAT doesn't seem to like named blocks/branch targets.

  • wasm/regress/llint-callee-saves-with-fast-memory.js:
  • wasm/regress/llint-callee-saves-without-fast-memory.js:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:47 PM Changeset in webkit [256885] by Russell Epstein
  • 9 edits
    2 adds in branches/safari-609-branch

Cherry-pick r256665. rdar://problem/59551715

[WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention.
​https://bugs.webkit.org/show_bug.cgi?id=207727

JSTests:

Reviewed by Mark Lam.

  • wasm/regress/llint-callee-saves-with-fast-memory.js: Added.
  • wasm/regress/llint-callee-saves-without-fast-memory.js: Added.

Source/JavaScriptCore:

Reviewed by Mark Lam.

The Wasm JIT has unusual calling conventions, which were further complicated by the addition
of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly
saving and restoring the callee save registers used for the memory base and size). Here's a summary
of the calling convention:

  • When entering Wasm from JS, the wrapper must:
    • Preserve the base and size when entering LLInt regardless of the mode. (Prior to this patch we only preserved the base in Signaling mode)
    • Preserve the memory base in either mode, and the size for BoundsChecking.
  • Both tiers must preserve every *other* register they use. e.g. the LLInt must preserve PB and wasmInstance, but must *not* preserve memoryBase and memorySize.
  • Changes to memoryBase and memorySize are visible to the caller. This means that:
    • Intra-module calls can assume these registers are up-to-date even if the memory was resized. The only exception here is if the LLInt calls a signaling JIT, in which case the JIT will not update the size register, since it won't be using it.
    • Inter-module and JS calls require the caller to reload these registers. These calls may result in memory changes (e.g. the callee may call memory.grow).
    • A Signaling JIT caller must be aware that the LLInt may trash the size register, since it always bounds checks.
  • llint/WebAssembly.asm:
  • wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::addCall):
  • wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::addCall):
  • wasm/WasmCallee.cpp: (JSC::Wasm::LLIntCallee::calleeSaveRegisters):
  • wasm/WasmCallingConvention.h:
  • wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation):
  • wasm/WasmMemoryInformation.cpp: (JSC::Wasm::PinnedRegisterInfo::get): (JSC::Wasm::getPinnedRegisters): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:47 PM Changeset in webkit [256884] by Russell Epstein
  • 8 edits in branches/safari-609-branch/Source

Versioning.

4:31 PM Changeset in webkit [256883] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[First paint] Remove elementOverflowRectIsLargerThanThreshold check in qualifiesAsVisuallyNonEmpty
​https://bugs.webkit.org/show_bug.cgi?id=207907
<rdar://problem/59562169>

Reviewed by Geoffrey Garen.

This is in preparation for being able to qualify for visually non-empty content without looking at geometry.
This check was added long ago, initially with a 200px value which got reduced to 48px to reduce painting latency on google search result page.
At this point a 48px threshold does not make too much sense.

  • page/FrameView.cpp:

(WebCore::FrameView::qualifiesAsSignificantRenderedText const):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
(WebCore::elementOverflowRectIsLargerThanThreshold): Deleted.

4:21 PM Changeset in webkit [256882] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Do not eagerly launch WebProcess when WKPagePostMessageToInjectedBundle() is called
​https://bugs.webkit.org/show_bug.cgi?id=207905

Reviewed by Alex Christensen.

Do not eagerly launch WebProcess when WKPagePostMessageToInjectedBundle() is called. It is bad for
performance as we cannot leverage the process cache if we don't know the domain of the site that
will be loaded.

Instead we now queue those injected bundle messages until we really need to launch the process.

No new tests, WebKitTestRunner extensively relies on this private API already, and was the
reason we did the eager process launch in the first place (​https://trac.webkit.org/changeset/243156).

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::launchProcess):

  • UIProcess/WebPageProxy.h:
4:13 PM Changeset in webkit [256881] by Chris Dumez
  • 6 edits in trunk/Source/WebKit

Drop getSandboxExtensionsForBlobFiles() as it is dead code
​https://bugs.webkit.org/show_bug.cgi?id=207909
<rdar://problem/59562180>

Reviewed by Per Arne Vollan.

  • NetworkProcess/NetworkProcess.cpp:
  • NetworkProcess/NetworkProcess.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.messages.in:
4:10 PM Changeset in webkit [256880] by Jacob Uphoff
  • 2 edits in trunk/LayoutTests

Changed results due to ANGLE use
​https://bugs.webkit.org/show_bug.cgi?id=207858

Unreviewed test gardening

  • platform/ios-wk2/TestExpectations: updating expectations for 2 more tests that surfaced as failures.
4:01 PM Changeset in webkit [256879] by Alan Coon
  • 3 edits in branches/safari-609.1.20.2-branch/Source/WebCore

Revert r256689. rdar://problem/59478731

4:01 PM Changeset in webkit [256878] by Alan Coon
  • 2 edits in branches/safari-609.1.20.2-branch/Source/JavaScriptCore

Revert r256690. rdar://problem/59478994

4:01 PM Changeset in webkit [256877] by Alan Coon
  • 16 edits in branches/safari-609.1.20.2-branch/Source

Revert r256691. rdar://problem/59478881

4:01 PM Changeset in webkit [256876] by Alan Coon
  • 5 edits in branches/safari-609.1.20.2-branch/Source

Revert r256692. rdar://problem/59478929

4:01 PM Changeset in webkit [256875] by Alan Coon
  • 2 edits in branches/safari-609.1.20.2-branch/Source/WebCore

Revert r256696. rdar://problem/59478734

4:01 PM Changeset in webkit [256874] by Alan Coon
  • 2 edits in branches/safari-609.1.20.2-branch/Source/WebCore

Revert r256746. rdar://problem/59478731

3:53 PM Changeset in webkit [256873] by Alan Coon
  • 3 edits in branches/safari-609.1.20.3-branch/Source/WebCore

Revert r256689. rdar://problem/59478731

3:53 PM Changeset in webkit [256872] by Alan Coon
  • 2 edits in branches/safari-609.1.20.3-branch/Source/JavaScriptCore

Revert r256690. rdar://problem/59478994

3:53 PM Changeset in webkit [256871] by Alan Coon
  • 16 edits in branches/safari-609.1.20.3-branch/Source

Revert r256691. rdar://problem/59478881

3:52 PM Changeset in webkit [256870] by Alan Coon
  • 5 edits in branches/safari-609.1.20.3-branch/Source

Revert r256692. rdar://problem/59478929

3:52 PM Changeset in webkit [256869] by Alan Coon
  • 2 edits in branches/safari-609.1.20.3-branch/Source/WebCore

Revert r256696. rdar://problem/59478734

3:52 PM Changeset in webkit [256868] by Alan Coon
  • 2 edits in branches/safari-609.1.20.3-branch/Source/WebCore

Revert r256746. rdar://problem/59478731

3:48 PM Changeset in webkit [256867] by achristensen@apple.com
  • 6 edits in trunk

Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
​https://bugs.webkit.org/show_bug.cgi?id=207912
<rdar://problem/59556922>

Reviewed by Brian Weinstein.

Source/WebKit:

This expands on r158806. There's no reason not to support all NSNumber types, so I did.
Covered by API tests.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeInvocationArguments):
(-[WKRemoteObjectEncoder encodeValueOfObjCType:at:]):
(-[WKRemoteObjectDecoder decodeValueOfObjCType:at:]):
(decodeInvocationArguments):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
  • TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:

(-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):

3:31 PM Changeset in webkit [256866] by Alan Coon
  • 8 edits in branches/safari-609.1.20.2-branch/Source

Versioning.

3:31 PM Changeset in webkit [256865] by Alan Coon
  • 8 edits in branches/safari-609.1.20.3-branch/Source

Versioning.

3:27 PM Changeset in webkit [256864] by dbates@webkit.org
  • 17 edits in trunk/Source

Ask the EditorClient whether to reveal the current selection after insertion
​https://bugs.webkit.org/show_bug.cgi?id=207866
<rdar://problem/59553028>

Reviewed by Wenson Hsieh.

Source/WebCore:

Adds a new EditorClient function shouldRevealCurrentSelectionAfterInsertion() that returns whether
the client wants the engine to reveal the current selection after insertion. The default implementation
always returns true. On iOS it returns the result of WebPage::shouldRevealCurrentSelectionAfterInsertion().

  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent): Call EditorClient::shouldRevealCurrentSelectionAfterInsertion().
If it returns false then skip the code to reveal the current selection: the UI process will call back
into WebPage::setShouldRevealCurrentSelectionAfterInsertion() when it is ready to reveal the current
selection. Otherwise, do what we do now.

  • editing/Editor.h:
  • page/EditorClient.h:

(WebCore::EditorClient::shouldRevealCurrentSelectionAfterInsertion const): Added.

  • page/Page.cpp:

(WebCore::Page::revealCurrentSelection): Added.

  • page/Page.h:

Source/WebKit:

On iOS, adds a new WebPage message SetShouldRevealCurrentSelectionAfterInsertion that the
UI process can send to toggle whether the current selection should be revealed after a
text insertion.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setWaitingForPostLayoutEditorStateUpdateAfterFocusingElement):

  • UIProcess/ios/WKContentViewInteraction.h:

Add some declarations for some functions that I need to make the corresponding Apple Internal fix in <rdar://problem/57608794>.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
If we are not going to zoom to reveal the focused element immediately then call WebPage::setWaitingForPostLayoutEditorStateUpdateAfterFocusingElement(true)
so that we schedule a -_didUpdateEditorState callback on the next editor state update so that we can call
-_zoomToRevealFocusedElement.
(-[WKContentView _elementDidBlur]): Call WebPage::setWaitingForPostLayoutEditorStateUpdateAfterFocusingElement(false)
to unschedule an existing -_didUpdateEditorState callback.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::elementDidFocus):
(WebKit::WebPageProxy::elementDidBlur):
Move the setting of m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement from here to
-_elementDidFocus and _elementDidBlur when an element is focused or blurred, respectively.

(WebKit::WebPageProxy::setShouldRevealCurrentSelectionAfterInsertion): Added.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:

(WebKit::WebEditorClient::shouldRevealCurrentSelectionAfterInsertion const): Added.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const): Mark the editor state as ignoring selection changes if EditorClient::shouldRevealCurrentSelectionAfterInsertion()
returns false.
(WebKit::WebPage::didCommitLoad): Reset state.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::shouldRevealCurrentSelectionAfterInsertion const):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateSelectionAppearance): Do not send an update if EditorClient::shouldRevealCurrentSelectionAfterInsertion()
returns false.
(WebKit::WebPage::setShouldRevealCurrentSelectionAfterInsertion): Added. Update state, if needed. If passed
false, then reveal the current selection just as we would have done after an insertion and schedule a full
editor state update (i.e. an update after layout is performed). The latter will trigger the UI process on iOS
to zoom to reveal the newly focused element.

3:18 PM Changeset in webkit [256863] by Russell Epstein
  • 1 edit in branches/safari-609-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp

Unreviewed build fix.

3:18 PM Changeset in webkit [256862] by Russell Epstein
  • 28 edits
    10 deletes in branches/safari-609-branch

Revert "Cherry-pick r256191. rdar://problem/59447003"

This reverts commit r256796.

3:16 PM Changeset in webkit [256861] by Alan Coon
  • 1 copy in branches/safari-609.1.20.3-branch

New branch.

3:16 PM Changeset in webkit [256860] by Alan Coon
  • 1 copy in branches/safari-609.1.20.2-branch

New branch.

3:15 PM Changeset in webkit [256859] by Wenson Hsieh
  • 9 edits
    2 adds in trunk

[macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=207899
<rdar://problem/55658207>

Reviewed by Tim Horton and Simon Fraser.

Source/WebCore:

Mitigates a null pointer crash in ServicesOverlayController::buildPotentialHighlightsIfNeeded(), wherein the
focused frame may not have a FrameView when the ServicesOverlayController's selection invalidation timer fires.
This is possible if, while being focused, the newly focused subframe is unparented and reparented, which causes
it to momentarily have a null view. During this time, if a selection change had occurred earlier in the runloop,
it will schedule the page overlay controller invalidation timer, which will fire and discover that the currently
focused frame no longer has a FrameView.

Test: editing/selection/selection-change-in-disconnected-frame-crash.html

  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::buildSelectionHighlight):

Source/WebKit:

Add another missing null check on iOS, for the case where FrameView is null.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):

Tools:

Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.

  • WebKitTestRunner/TestController.cpp:

(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):

LayoutTests:

Add a new layout test to verify that we don't crash under this circumstance.

  • editing/selection/selection-change-in-disconnected-frame-crash-expected.txt: Added.
  • editing/selection/selection-change-in-disconnected-frame-crash.html: Added.
3:11 PM Changeset in webkit [256858] by Alan Coon
  • 1 copy in tags/Safari-609.1.20

Tag Safari-609.1.20.

3:09 PM Changeset in webkit [256857] by youenn@apple.com
  • 3 edits in trunk/Source/WebKit

NetworkDataTask should not expect its session wrapper to be always live
​https://bugs.webkit.org/show_bug.cgi?id=207903
rdar://problem/59291486

Reviewed by Alex Christensen.

NetworkDataTaskCocoa should take a weak pointer to its session wrapper.
If the session wrapper is still valid, then we can remove the task from the session wrapper map.
We cannot guarantee session wrapper is valid since NetworkDataTask is ref counted.

  • NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa):

2:52 PM Changeset in webkit [256856] by Peng Liu
  • 3 edits in trunk/Source/WebCore

MediaSource.isTypeSupported() says "video/mp4;codecs=\"avc3.42C015\"" is not supported, but it is
​https://bugs.webkit.org/show_bug.cgi?id=207622

Reviewed by Eric Carlson.

Revert the behavior change of MediaPlayerPrivateMediaSourceAVFObjC::supportsType() in r253952.

  • platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:

(WebCore::AVAssetMIMETypeCache::canDecodeExtendedType):

2:41 PM Changeset in webkit [256855] by Alan Coon
  • 1 copy in tags/Safari-610.1.3.2

Tag Safari-610.1.3.2.

2:31 PM Changeset in webkit [256854] by Alan Coon
  • 8 edits in branches/safari-610.1.3-branch/Source

Versioning.

1:58 PM Changeset in webkit [256853] by Antti Koivisto
  • 8 edits in trunk/Source

[macOS] Don't fire timers when there is a pending rendering update
​https://bugs.webkit.org/show_bug.cgi?id=207889

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • dom/WindowEventLoop.cpp:

(WebCore::WindowEventLoop::breakToAllowRenderingUpdate):

Add the exported interface to WindowEventLoop as the future direction is to do everything via it.
For now it just calls into ThreadTimers rather than doing anything with the event loop itself.

  • dom/WindowEventLoop.h:
  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::sharedTimerFiredInternal):
(WebCore::ThreadTimers::breakFireLoopForRenderingUpdate):

If we are in a firing timer set a flag so that no more timers are fired during the current runloop cycle.

  • platform/ThreadTimers.h:

Source/WebKit:

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scheduleRenderingUpdateRunLoopObserver):

Ensure the event loop cycles to reach the runloop observer as fast as possible.

1:45 PM Changeset in webkit [256852] by Alan Coon
  • 8 edits in trunk/Source

Versioning.

12:17 PM Changeset in webkit [256851] by Matt Lewis
  • 6 edits in trunk/Tools

Stub repositories fail to upload some results due to missing head svn revision
​https://bugs.webkit.org/show_bug.cgi?id=207684

Reviewed by Jonathan Bedard.

  • Scripts/webkitpy/api_tests/run_api_tests.py:

(main): Added initializing the scm to the host object.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
it in line with modern code.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main): Added inializing the scm to the host object.

  • Scripts/webkitpy/port/base.py:

(Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
from using mock SCMs and more

  • Scripts/webkitpy/test/main.py:

(main): Removed the forced movement up the systems tree, initialized the SCM on the host object,
and converted the webkit_root variable to the SCM checkout root.
(Tester._run_tests):

12:09 PM Changeset in webkit [256850] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix order (in MIPS) under which CS-registers are saved/restored
​https://bugs.webkit.org/show_bug.cgi?id=207752

Patch by Paulo Matos <Paulo Matos> on 2020-02-18
Reviewed by Keith Miller.

This has been causing several segfaults on MIPS with JIT enabled
because during an OSR to baseline, the order in which LLInt was
saving the registers was not in sync with the way baseline was
restoring them.

  • llint/LowLevelInterpreter.asm:
12:06 PM Changeset in webkit [256849] by Alan Coon
  • 62 edits in branches/safari-610.1.4-branch/Source

Cherry-pick r256791. rdar://problem/59554260

getVTablePointer() should return a const void*.
​https://bugs.webkit.org/show_bug.cgi?id=207871
<rdar://problem/59525721>

Reviewed by Yusuke Suzuki.

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation):
  • bindings/scripts/test/JS/JSInterfaceName.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSMapLike.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSReadOnlyMapLike.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSReadOnlySetLike.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSSetLike.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestCEReactions.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestCallTracer.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestEnabledBySetting.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestEnabledForContext.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestEventTarget.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestException.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestGlobalObject.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestIterable.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestNode.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestPluginInterface.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestSerialization.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifier.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp: (WebCore::toJSNewlyCreated):
  • bindings/scripts/test/JS/JSTestTypedefs.cpp: (WebCore::toJSNewlyCreated):

Source/WTF:

  • wtf/PointerPreparations.h: (WTF::getVTablePointer):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:06 PM Changeset in webkit [256848] by Alan Coon
  • 2 edits in branches/safari-610.1.4-branch/Source/WebKit

Cherry-pick r256740. rdar://problem/59527003

[iOS] Add telemetry with backtrace for specific rules
​https://bugs.webkit.org/show_bug.cgi?id=207494

Reviewed by Brent Fulgham.

For specific sandbox mach lookup rules in the WebContent process, add telemetry with backtrace.

No new tests, no behavior change.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:01 PM Changeset in webkit [256847] by Chris Dumez
  • 3 edits in trunk/LayoutTests

[WK1] Flaky Test: http/tests/cookies/document-cookie-during-iframe-parsing.html
​https://bugs.webkit.org/show_bug.cgi?id=207895
<rdar://problem/59558164>

Unreviewed, mark test as flaky on WK1 only as the WK2 bots appear to be fine.

12:01 PM Changeset in webkit [256846] by Ross Kirsling
  • 7 edits
    1 add in trunk

[JSC] Computed function properties compute their keys twice
​https://bugs.webkit.org/show_bug.cgi?id=207297

Reviewed by Keith Miller.

JSTests:

  • stress/computed-property-key-side-effects.js: Added.
  • test262/expectations.yaml: Mark 6 test cases as passing.

Source/JavaScriptCore:

If a pseudo-String is used as the key of a computed function property,
any side effects from resolving the string value occur in duplicate.

The cause has two parts:

  • We aren't ensuring that the string value is resolved before doing SetFunctionName and PutByVal.
  • Our implementation of SetFunctionName (​https://tc39.es/ecma262/#sec-setfunctionname) calls toString on a non-symbol argument, instead of assuming the type is a string.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::shouldSetFunctionName): Added.
(JSC::BytecodeGenerator::emitSetFunctionName): Added.
(JSC::BytecodeGenerator::emitSetFunctionNameIfNeededImpl): Deleted.
(JSC::BytecodeGenerator::emitSetFunctionNameIfNeeded): Deleted.

  • bytecompiler/BytecodeGenerator.h:

Split the "if needed" logic out into its own function.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):
(JSC::PropertyListNode::emitPutConstantProperty):
(JSC::DefineFieldNode::emitBytecode):
Never emit OpSetFunctionName for a name of unknown type.
(But also, don't perform a needless ToPropertyKey for non-function computed property keys.)

  • runtime/JSFunction.cpp:

(JSC::JSFunction::setFunctionName):
Don't call toString, assert isString.

11:55 AM Changeset in webkit [256845] by achristensen@apple.com
  • 11 edits in trunk/Source/WebKit

Unreviewed, rolling out r254873.
​https://bugs.webkit.org/show_bug.cgi?id=205751

This is reverting r254081 which is effectively re-landing part of r254873 that was reverted
supposing that would be related to the fix for rdar://problem/59136037 but it was not.
Re-landing this is a step towards rdar://problem/56027111

Reverted changeset:

"Revert suppressesConnectionTerminationOnSystemChange part of
r254081"
​https://bugs.webkit.org/show_bug.cgi?id=205751
​https://trac.webkit.org/changeset/254873

11:42 AM Changeset in webkit [256844] by youenn@apple.com
  • 13 edits
    1 move in trunk/Source/WebCore

Remove PlatformMediaSessionClient dependency on Document
​https://bugs.webkit.org/show_bug.cgi?id=207892

Reviewed by Eric Carlson.

Move DocumentIdentifier to Platform folder.
Use DocumentIdentifier instead of Document in PlatformMediaSession/Manager.
No change of behavior.

  • Headers.cmake:
  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::hostingDocumentIdentifier const):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::hostingDocumentIdentifier const):
(WebCore::AudioContext::hostingDocument const): Deleted.

  • Modules/webaudio/AudioContext.h:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::stopAllMediaPlayback):
(WebCore::Document::suspendAllMediaPlayback):
(WebCore::Document::resumeAllMediaPlayback):
(WebCore::Document::suspendAllMediaBuffering):
(WebCore::Document::resumeAllMediaBuffering):

  • html/HTMLMediaElement.h:
  • platform/DocumentIdentifier.h: Renamed from Source/WebCore/dom/DocumentIdentifier.h.
  • platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::PlatformMediaSession):

  • platform/audio/PlatformMediaSession.h:
  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::stopAllMediaPlaybackForDocument):
(WebCore::PlatformMediaSessionManager::suspendAllMediaPlaybackForDocument):
(WebCore::PlatformMediaSessionManager::resumeAllMediaPlaybackForDocument):
(WebCore::PlatformMediaSessionManager::suspendAllMediaBufferingForDocument):
(WebCore::PlatformMediaSessionManager::resumeAllMediaBufferingForDocument):
(WebCore::PlatformMediaSessionManager::sessionsMatching const):
(WebCore::PlatformMediaSessionManager::forEachDocumentSession):

  • platform/audio/PlatformMediaSessionManager.h:
11:41 AM Changeset in webkit [256843] by Alan Coon
  • 8 edits in branches/safari-610.1.4-branch/Source

Versioning.

11:24 AM Changeset in webkit [256842] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Flaky Test: http/tests/cookies/document-cookie-during-iframe-parsing.html
​https://bugs.webkit.org/show_bug.cgi?id=207895

Unreviewed, mark the test as flaky while I work with the CFNetwork team to resolve this.

10:58 AM Changeset in webkit [256841] by youenn@apple.com
  • 4 edits in trunk/LayoutTests

REGRESSION (256034): http/tests/media/media-stream/get-display-media-prompt.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=207893
<rdar://problem/59551315>

Reviewed by Eric Carlson.

After 256034, we are allowing { audio: true } for getDisplayMedia.
Update the test accordingly, and make it easier to debug by resetting the number of getDisplayMedia prompt for each test
so that they are more indepedent.

  • http/tests/media/media-stream/get-display-media-prompt-expected.txt:
  • http/tests/media/media-stream/get-display-media-prompt.html:
  • platform/mac-wk2/TestExpectations:
10:39 AM Changeset in webkit [256840] by Alan Bujtas
  • 8 edits
    2 adds in trunk

[LFC][Quirk] Add additional escape reason to cover the case when body needs access to both the body and the ICB geometry
​https://bugs.webkit.org/show_bug.cgi?id=207869
<rdar://problem/59531225>

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html

When the body is stretched all the way to the ICB, we have to read both the document box's and the ICB's geometry.
This patch also refactors Quirks::stretchedInFlowHeight a bit to decouple the document and the body cases.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):

  • layout/FormattingContext.h:
  • layout/blockformatting/BlockFormattingContext.h:
  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):

  • layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::needsStretching const):
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):

LayoutTests:

  • fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport-expected.txt: Added.
  • fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html: Added.
  • platform/ios-wk2/TestExpectations:
10:27 AM Changeset in webkit [256839] by pvollan@apple.com
  • 11 edits
    3 adds in trunk

Move [UIDevice currentDevice] calls to UI process
​https://bugs.webkit.org/show_bug.cgi?id=204320

Reviewed by Darin Adler.

Source/WebCore:

Calling [UIDevice currentDevice] will cause the runningboard daemon to be accessed. Since this service will be removed from
the WebContent sandbox, these calls should be moved to the UI process. The function exernalDeviceDisplayNameForPlayer in
MediaPlayerPrivateAVFoundationObjC.mm is calling [[PAL::getUIDeviceClass() currentDevice] localizedModel], which should be
moved to the UI process.

API test: WebKit.LocalizedDeviceName

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::exernalDeviceDisplayNameForPlayer):

  • platform/ios/LocalizedDeviceModel.h: Added.
  • platform/ios/LocalizedDeviceModel.mm: Added.

(WebCore::cachedLocalizedDeviceModel):
(WebCore::localizedDeviceModel):
(WebCore::setLocalizedDeviceModel):

Source/WebKit:

Get the localized device name in the UI process, and send it to the WebContent process as part of the
process creation parameters.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.

(TEST):

10:19 AM Changeset in webkit [256838] by youenn@apple.com
  • 15 edits
    1 copy in trunk/Source

Use more ObjectIdentifier in WebRTC MDNS register
​https://bugs.webkit.org/show_bug.cgi?id=207548

Reviewed by Eric Carlson.

Source/WebCore:

Pass document identifiers instead of uint64_t to mdns register.
No change of behavior.

  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::registerMDNSName):

  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::suspend):

  • platform/mediastream/libwebrtc/LibWebRTCProvider.h:

Source/WebKit:

Use ObjectIdentifier for MDNSRegister for more type and IPC safety.
Update MDNSRegister to also use DocumentIdentifier where more appropriate.

  • NetworkProcess/webrtc/NetworkMDNSRegister.cpp:

(WebKit::PendingRegistrationRequest::PendingRegistrationRequest):
(WebKit::NetworkMDNSRegister::registerMDNSName):
(): Deleted.

  • NetworkProcess/webrtc/NetworkMDNSRegister.h:
  • NetworkProcess/webrtc/NetworkMDNSRegister.messages.in:
  • Scripts/webkit/messages.py:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Network/webrtc/LibWebRTCProvider.cpp:

(WebKit::LibWebRTCProvider::unregisterMDNSNames):
(WebKit::LibWebRTCProvider::registerMDNSName):

  • WebProcess/Network/webrtc/LibWebRTCProvider.h:
  • WebProcess/Network/webrtc/WebMDNSRegister.cpp:

(WebKit::WebMDNSRegister::finishedRegisteringMDNSName):
(WebKit::WebMDNSRegister::unregisterMDNSNames):
(WebKit::WebMDNSRegister::registerMDNSName):

  • WebProcess/Network/webrtc/WebMDNSRegister.h:

(): Deleted.

  • WebProcess/Network/webrtc/WebMDNSRegister.messages.in:
10:09 AM Changeset in webkit [256837] by Kate Cheney
  • 6 edits
    2 adds in trunk

Web socket loads should be captured for logging per-page prevalent domains
​https://bugs.webkit.org/show_bug.cgi?id=207840
<rdar://problem/59511746>

Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html

Captures a domain connection via WebSocket to check if it should be
logged as a prevalent resource.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

LayoutTests:

Resource load statistics is only supported on mac and iOS, we should
skip this on other platforms.

  • http/tests/websocket/web-socket-loads-captured-in-per-page-domains-expected.txt: Added.
  • http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html: Added.
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
9:46 AM Changeset in webkit [256836] by dino@apple.com
  • 116 edits in trunk/LayoutTests

[WebGL] Update WebGL2 results with ANGLE backend
​https://bugs.webkit.org/show_bug.cgi?id=207872

Reviewed by Myles Maxfield.

Now that ANGLE is on by default, update a bunch of expected results.
Note that any possible regressions are tracked in:
​https://bugs.webkit.org/show_bug.cgi?id=207858

  • webgl/2.0.0/conformance/context/context-lost-restored-expected.txt:
  • webgl/2.0.0/conformance/extensions/ext-sRGB-expected.txt:
  • webgl/2.0.0/conformance/extensions/oes-texture-float-expected.txt:
  • webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt:
  • webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt:
  • webgl/2.0.0/conformance/extensions/webgl-depth-texture-expected.txt:
  • webgl/2.0.0/conformance/extensions/webgl-draw-buffers-expected.txt:
  • webgl/2.0.0/conformance/extensions/webgl-draw-buffers-framebuffer-unsupported-expected.txt:
  • webgl/2.0.0/conformance/glsl/misc/shader-struct-scope-expected.txt:
  • webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt:
  • webgl/2.0.0/conformance/glsl/misc/shaders-with-name-conflicts-expected.txt:
  • webgl/2.0.0/conformance/limits/gl-line-width-expected.txt:
  • webgl/2.0.0/conformance/misc/object-deletion-behaviour-expected.txt:
  • webgl/2.0.0/conformance/misc/webgl-specific-expected.txt:
  • webgl/2.0.0/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002-expected.txt:
  • webgl/2.0.0/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003-expected.txt:
  • webgl/2.0.0/conformance/programs/program-test-expected.txt:
  • webgl/2.0.0/conformance/reading/read-pixels-test-expected.txt:
  • webgl/2.0.0/conformance/renderbuffers/feedback-loop-expected.txt:
  • webgl/2.0.0/conformance/rendering/point-no-attributes-expected.txt:
  • webgl/2.0.0/conformance/state/gl-object-get-calls-expected.txt:
  • webgl/2.0.0/conformance/textures/misc/cube-incomplete-fbo-expected.txt:
  • webgl/2.0.0/conformance/textures/misc/texture-copying-feedback-loops-expected.txt:
  • webgl/2.0.0/conformance2/attribs/gl-vertexattribipointer-expected.txt:
  • webgl/2.0.0/conformance2/attribs/gl-vertexattribipointer-offsets-expected.txt:
  • webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt:
  • webgl/2.0.0/conformance2/buffers/buffer-copying-contents-expected.txt:
  • webgl/2.0.0/conformance2/buffers/buffer-data-and-buffer-sub-data-sub-source-expected.txt:
  • webgl/2.0.0/conformance2/buffers/buffer-type-restrictions-expected.txt:
  • webgl/2.0.0/conformance2/buffers/get-buffer-sub-data-expected.txt:
  • webgl/2.0.0/conformance2/buffers/one-large-uniform-buffer-expected.txt:
  • webgl/2.0.0/conformance2/context/context-attributes-depth-stencil-antialias-obeyed-expected.txt:
  • webgl/2.0.0/conformance2/extensions/ext-color-buffer-float-expected.txt:
  • webgl/2.0.0/conformance2/extensions/promoted-extensions-expected.txt:
  • webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader-expected.txt:
  • webgl/2.0.0/conformance2/glsl3/shader-linking-expected.txt:
  • webgl/2.0.0/conformance2/glsl3/shader-with-invalid-characters-expected.txt:
  • webgl/2.0.0/conformance2/glsl3/shader-with-mis-matching-uniform-block-expected.txt:
  • webgl/2.0.0/conformance2/glsl3/valid-invariant-expected.txt:
  • webgl/2.0.0/conformance2/misc/expando-loss-2-expected.txt:
  • webgl/2.0.0/conformance2/misc/instanceof-test-expected.txt:
  • webgl/2.0.0/conformance2/misc/object-deletion-behaviour-2-expected.txt:
  • webgl/2.0.0/conformance2/query/query-expected.txt:
  • webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt:
  • webgl/2.0.0/conformance2/reading/read-pixels-pack-parameters-expected.txt:
  • webgl/2.0.0/conformance2/renderbuffers/invalidate-framebuffer-expected.txt:
  • webgl/2.0.0/conformance2/renderbuffers/multisample-with-full-sample-counts-expected.txt:
  • webgl/2.0.0/conformance2/renderbuffers/multisampled-renderbuffer-initialization-expected.txt:
  • webgl/2.0.0/conformance2/rendering/attrib-type-match-expected.txt:
  • webgl/2.0.0/conformance2/rendering/blitframebuffer-stencil-only-expected.txt:
  • webgl/2.0.0/conformance2/rendering/blitframebuffer-test-expected.txt:
  • webgl/2.0.0/conformance2/rendering/canvas-resizing-with-pbo-bound-expected.txt:
  • webgl/2.0.0/conformance2/rendering/clear-func-buffer-type-match-expected.txt:
  • webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer-expected.txt:
  • webgl/2.0.0/conformance2/rendering/clipping-wide-points-expected.txt:
  • webgl/2.0.0/conformance2/rendering/framebuffer-unsupported-expected.txt:
  • webgl/2.0.0/conformance2/rendering/fs-color-type-mismatch-color-buffer-type-expected.txt:
  • webgl/2.0.0/conformance2/rendering/instanced-arrays-expected.txt:
  • webgl/2.0.0/conformance2/rendering/instanced-rendering-bug-expected.txt:
  • webgl/2.0.0/conformance2/rendering/rendering-sampling-feedback-loop-expected.txt:
  • webgl/2.0.0/conformance2/rendering/rgb-format-support-expected.txt:
  • webgl/2.0.0/conformance2/state/gl-get-calls-expected.txt:
  • webgl/2.0.0/conformance2/state/gl-object-get-calls-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba16f-rgba-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba16f-rgba-half_float-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba32f-rgba-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-srgb8-rgb-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba16f-rgba-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba16f-rgba-half_float-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba32f-rgba-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba4-rgba-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba4-rgba-unsigned_short_4_4_4_4-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba8-rgba-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-srgb8-rgb-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r11f_g11f_b10f-rgb-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r11f_g11f_b10f-rgb-half_float-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r8-red-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r8ui-red_integer-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/active-3d-texture-bug-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/copy-texture-image-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/tex-image-with-bad-args-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/tex-storage-2d-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/texture-npot-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-r11f_g11f_b10f-rgb-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-r11f_g11f_b10f-rgb-half_float-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-r16f-red-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-r16f-red-half_float-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-r32f-red-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-rg16f-rg-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-rg16f-rg-half_float-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-rg32f-rg-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-rg8-rg-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-rg8ui-rg_integer-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/video/tex-2d-rgb5_a1-rgba-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-r16f-red-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-r16f-red-half_float-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-r32f-red-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-r8ui-red_integer-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-rg16f-rg-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-rg16f-rg-half_float-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-rg32f-rg-float-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-rg8-rg-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-rg8ui-rg_integer-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/textures/webgl_canvas/tex-2d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
  • webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object-expected.txt:
  • webgl/TestExpectations:
9:32 AM Changeset in webkit [256835] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

REGRESSION: (r256784?) [ iOS wk2 ] fast/canvas/webgl/oes-vertex-array-object.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=207896

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
9:24 AM Changeset in webkit [256834] by Simon Fraser
  • 37 edits
    1 move in trunk

Move from "layer flush" terminology to "rendering update"
​https://bugs.webkit.org/show_bug.cgi?id=207870

Reviewed by Tim Horton.
Source/WebCore:

Rename various functions and member variables to move away from the legacy "layer flush"
terminology and instead use "rendering update", matching Page::updateRendering(). The fact
that we have layers is an implementation detail.

Change LayerFlushThrottlingState to be an OptionSet<>.

  • Headers.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::shouldScheduleLayout):

  • loader/EmptyClients.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::renderingUpdateThrottlingIsActive const):
(WebCore::ChromeClient::adjustRenderUpdateThrottling):
(WebCore::ChromeClient::layerFlushThrottlingIsActive const): Deleted.
(WebCore::ChromeClient::adjustLayerFlushThrottling): Deleted.

  • page/FrameView.cpp:

(WebCore::determineLayerFlushThrottleState):
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::updateLayerFlushThrottling):

  • page/RenderingUpdateScheduler.cpp:

(WebCore::RenderingUpdateScheduler::scheduleImmediateRenderingUpdate):

  • page/RenderingUpdateThrottleState.h: Renamed from Source/WebCore/page/LayerFlushThrottleState.h.

Source/WebKit:

Rename various functions and member variables to move away from the legacy "layer flush"
terminology and instead use "rendering update", matching Page::updateRendering(). The fact
that we have layers is an implementation detail.

Change LayerFlushThrottlingState to be an OptionSet<>.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scheduleRenderingUpdate):
(WebKit::WebChromeClient::adjustRenderUpdateThrottling):
(WebKit::WebChromeClient::renderingUpdateThrottlingIsActive const):
(WebKit::WebChromeClient::scheduleCompositingLayerFlush): Deleted.
(WebKit::WebChromeClient::adjustLayerFlushThrottling): Deleted.
(WebKit::WebChromeClient::layerFlushThrottlingIsActive const): Deleted.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::renderingUpdateThrottlingIsActive const):
(WebKit::DrawingArea::adjustRenderUpdateThrottling):
(WebKit::DrawingArea::layerFlushThrottlingIsActive const): Deleted.
(WebKit::DrawingArea::adjustLayerFlushThrottling): Deleted.

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h:

(WebKit::RemoteLayerTreeContext::setNextFlushIsForImmediatePaint):
(WebKit::RemoteLayerTreeContext::nextFlushIsForImmediatePaint const):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm:

(WebKit::RemoteLayerTreeDisplayRefreshMonitor::requestRefreshCallback):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
(WebKit::RemoteLayerTreeDrawingArea::updateGeometry):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::forceRepaint):
(WebKit::RemoteLayerTreeDrawingArea::setExposedContentRect):
(WebKit::RemoteLayerTreeDrawingArea::scheduleImmediateRenderingUpdate):
(WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleRenderingUpdate):
(WebKit::RemoteLayerTreeDrawingArea::adjustRenderUpdateThrottling):
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
(WebKit::RemoteLayerTreeDrawingArea::activityStateDidChange):
(WebKit::RemoteLayerTreeDrawingArea::addTransactionCallbackID):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlushImmediately): Deleted.
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush): Deleted.
(WebKit::RemoteLayerTreeDrawingArea::adjustLayerFlushThrottling): Deleted.
(WebKit::RemoteLayerTreeDrawingArea::flushLayers): Deleted.

  • WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scheduleFullEditorStateUpdate):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::forceRepaint):
(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::scheduleRenderingUpdate):
(WebKit::TiledCoreAnimationDrawingArea::scheduleImmediateRenderingUpdate):
(WebKit::TiledCoreAnimationDrawingArea::attachViewOverlayGraphicsLayer):
(WebKit::TiledCoreAnimationDrawingArea::setShouldScaleViewToFitDocument):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
(WebKit::TiledCoreAnimationDrawingArea::addTransactionCallbackID):
(WebKit::TiledCoreAnimationDrawingArea::updateRendering):
(WebKit::TiledCoreAnimationDrawingArea::suspendPainting):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):
(WebKit::TiledCoreAnimationDrawingArea::updateRenderingRunLoopCallback):
(WebKit::TiledCoreAnimationDrawingArea::invalidateRenderingUpdateRunLoopObserver):
(WebKit::TiledCoreAnimationDrawingArea::scheduleRenderingUpdateRunLoopObserver):
(WebKit::TiledCoreAnimationDrawingArea::adjustRenderUpdateThrottling):
(WebKit::TiledCoreAnimationDrawingArea::renderingUpdateThrottlingIsActive const):
(WebKit::TiledCoreAnimationDrawingArea::startRenderThrottlingTimer):
(WebKit::TiledCoreAnimationDrawingArea::renderThrottlingTimerFired):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlush): Deleted.
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlushImmediately): Deleted.
(WebKit::TiledCoreAnimationDrawingArea::flushLayers): Deleted.
(WebKit::TiledCoreAnimationDrawingArea::layerFlushRunLoopCallback): Deleted.
(WebKit::TiledCoreAnimationDrawingArea::invalidateLayerFlushRunLoopObserver): Deleted.
(WebKit::TiledCoreAnimationDrawingArea::scheduleLayerFlushRunLoopObserver): Deleted.
(WebKit::TiledCoreAnimationDrawingArea::adjustLayerFlushThrottling): Deleted.
(WebKit::TiledCoreAnimationDrawingArea::layerFlushThrottlingIsActive const): Deleted.
(WebKit::TiledCoreAnimationDrawingArea::startLayerFlushThrottlingTimer): Deleted.
(WebKit::TiledCoreAnimationDrawingArea::layerFlushThrottlingTimerFired): Deleted.

Source/WebKitLegacy/mac:

Rename various functions and member variables to move away from the legacy "layer flush"
terminology and instead use "rendering update", matching Page::updateRendering(). The fact
that we have layers is an implementation detail.

Change LayerFlushThrottlingState to be an OptionSet<>.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scheduleRenderingUpdate):
(WebChromeClient::scheduleCompositingLayerFlush): Deleted.

  • WebView/WebView.mm:

(-[WebView _scheduleUpdateRendering]):
(-[WebView _scheduleCompositingLayerFlush]): Deleted.

  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:

Source/WTF:

  • wtf/SystemTracing.h:

Tools:

Rename various functions and member variables to move away from the legacy "layer flush"
terminology and instead use "rendering update", matching Page::updateRendering(). The fact
that we have layers is an implementation detail.

Change LayerFlushThrottlingState to be an OptionSet<>.

  • Tracing/SystemTracePoints.plist:
9:11 AM Changeset in webkit [256833] by dbates@webkit.org
  • 10 edits in trunk/Source/WebKit

Rename dispatchDidReceiveEditorStateAfterFocus() to dispatchDidUpdateEditorState() to better describe its purpose
​https://bugs.webkit.org/show_bug.cgi?id=207865

Reviewed by Wenson Hsieh.

Although the iOS implementation bails out unless it was called after WebPageProxy::elementDidFocus()
this platform-independent function is actually invoked whenever the UI process receives either
an editor state update or a layer tree commit. Renaming this function to better describe its multi-
function purpose, which is to allow the UI process a chance to run post-editor update logic.

  • UIProcess/PageClient.h:
  • UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didUpdateEditorState):
(WebKit::PageClientImpl::didReceiveEditorStateUpdateAfterFocus): Deleted.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _didUpdateEditorState]):
(-[WKContentView _didReceiveEditorStateUpdateAfterFocus]): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::dispatchDidUpdateEditorState):
(WebKit::WebPageProxy::dispatchDidReceiveEditorStateAfterFocus): Deleted.

9:06 AM Changeset in webkit [256832] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

[ Mac wk2 ] http/wpt/beacon/beacon-quota.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=207894

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:00 AM Changeset in webkit [256831] by Chris Dumez
  • 3 edits
    2 adds in trunk

ASSERT_NOT_REACHED() under WebPageProxy::suspendCurrentPageIfPossible()
​https://bugs.webkit.org/show_bug.cgi?id=207868
<rdar://problem/59464606>

Reviewed by John Wilander.

Source/WebCore:

Test: http/tests/navigation/process-swap-on-client-side-redirect-private.html

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateForSameDocumentNavigation):
Methods in HistoryController avoids updating visited links and calling updateGlobalHistory()
on the FrameLoaderClient when in an ephemeral session. However, updateForSameDocumentNavigation()
was returning early in ephemeral sessions, which was overly aggressive and bypasses things we
really need to do, like updating the current HistoryItem's url.

LayoutTests:

Add layout test that was hitting the assertion before my change.

  • http/tests/navigation/process-swap-on-client-side-redirect-private-expected.txt: Added.
  • http/tests/navigation/process-swap-on-client-side-redirect-private.html: Added.
8:38 AM Changeset in webkit [256830] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

REGRESSION: (r254092?) [ Mac wk1 ] imported/w3c/web-platform-tests/css/css-position/fixed-z-index-blend.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=207891

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
8:02 AM Changeset in webkit [256829] by Alan Bujtas
  • 4 edits
    2 adds in trunk

[LFC][IFC] Add missing float check in inline line layout
​https://bugs.webkit.org/show_bug.cgi?id=207878
<rdar://problem/59537467>

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/float-in-inline-context-simple.html

Make sure float content gets laid out as well.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

  • layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::isAtSoftWrapOpportunity):
(WebCore::Layout::nextWrapOpportunity):

LayoutTests:

  • fast/layoutformattingcontext/float-in-inline-context-simple-expected.html: Added.
  • fast/layoutformattingcontext/float-in-inline-context-simple.html: Added.
7:55 AM Changeset in webkit [256828] by Jacob Uphoff
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r256804.

This broke 50+ media tests on mac debug

Reverted changeset:

"MediaSource.isTypeSupported() says
"video/mp4;codecs=\"avc3.42C015\"" is not supported, but it
is"
​https://bugs.webkit.org/show_bug.cgi?id=207622
​https://trac.webkit.org/changeset/256804

6:57 AM Changeset in webkit [256827] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][TreeBuilding] Take createLineBreakBox's return value
​https://bugs.webkit.org/show_bug.cgi?id=207879
<rdar://problem/59537585>

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/br-in-inline-content-simple.html

  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createLayoutBox):

LayoutTests:

  • fast/layoutformattingcontext/br-in-inline-content-simple-expected.html: Added.
  • fast/layoutformattingcontext/br-in-inline-content-simple.html: Added.
6:47 AM Changeset in webkit [256826] by Oriol Brufau
  • 3 edits in trunk/Source/WebCore

[css-grid] Improve performance of track sizing algorithm for spanning items
​https://bugs.webkit.org/show_bug.cgi?id=207852

Reviewed by Javier Fernandez.

Calculating the used sizing function for a track is not a very expensive
operation, but it's not trivial either, and the track sizing algorithm
needs to access sizing functions all over the place. This ends up having
a performance cost, especially for spanning items.

Intrinsic contributions from items that span a single track are handled
in a simpler way than when the span is greater than 1. In the former
case, SizeTrackToFitNonSpanningItem only calculates the track sizing
function of each track once per each item in that track. But in the
latter case we not only calculate the track sizing function of multiple
tracks per item, we also repeat this 5 times in order to handle the
various TrackSizeComputationPhase.

Therefore, to increase performance, this patch caches the used track
sizing functions in the tracks themselves.

This is a port of these Chromium patches:

Chromium has a auto-grid-lots-of-spanning-data perf test. In WebKit, its
performance improves by 40% with this patch.

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrack::setCachedTrackSize):
(WebCore::GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem):
(WebCore::GridTrackSizingAlgorithm::spanningItemCrossesFlexibleSizedTracks const):
(WebCore::GridTrackSizingAlgorithm::increaseSizesToAccommodateSpanningItems):
(WebCore::GridTrackSizingAlgorithm::estimatedGridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::isIntrinsicSizedGridArea const):
(WebCore::GridTrackSizingAlgorithm::calculateGridTrackSize const):
(WebCore::GridTrackSizingAlgorithm::computeFlexFactorUnitSize const):
(WebCore::GridTrackSizingAlgorithm::computeFlexSizedTracksGrowth const):
(WebCore::GridTrackSizingAlgorithm::findFrUnitSize const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::normalizedFlexFraction):
(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const):
(WebCore::GridTrackSizingAlgorithm::initializeTrackSizes):
(WebCore::GridTrackSizingAlgorithm::tracksAreWiderThanMinTrackBreadth const):

  • rendering/GridTrackSizingAlgorithm.h:

(WebCore::GridTrack::cachedTrackSize const):

6:15 AM Changeset in webkit [256825] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[ARM] Build failure on arm due to invalid use of incomplete type 'class WebCore::ImageData' in FEBlendNEON.h
​https://bugs.webkit.org/show_bug.cgi?id=207885

Patch by Chris Lord <Chris Lord> on 2020-02-18
Reviewed by Carlos Alberto Lopez Perez.

No new tests, no functional change.

  • platform/graphics/cpu/arm/filters/FEBlendNEON.h:
3:13 AM Changeset in webkit [256824] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[WPE] Add support for rendering progress bars
​https://bugs.webkit.org/show_bug.cgi?id=207688

Reviewed by Adrian Perez de Castro.

  • platform/wpe/RenderThemeWPE.cpp:

(WebCore::RenderThemeWPE::animationRepeatIntervalForProgressBar const):
(WebCore::RenderThemeWPE::animationDurationForProgressBar const):
(WebCore::RenderThemeWPE::progressBarRectForBounds const):
(WebCore::RenderThemeWPE::paintProgressBar):

  • platform/wpe/RenderThemeWPE.h:
2:48 AM Changeset in webkit [256823] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[WPE] Add support for rendering spin buttons
​https://bugs.webkit.org/show_bug.cgi?id=207686

Reviewed by Adrian Perez de Castro.

  • platform/wpe/RenderThemeWPE.cpp:

(WebCore::RenderThemeWPE::popupInternalPaddingBox const): Rename arrowSize as menuListButtonArrowSize.
(WebCore::RenderThemeWPE::paintMenuList): Use ThemeWPE::paintArrow().

  • platform/wpe/ThemeWPE.cpp:

(WebCore::ThemeWPE::paintArrow): Moved from RenderThemeWPE and added direction parameter.
(WebCore::ThemeWPE::controlSize const): Set size of spin buttons.
(WebCore::ThemeWPE::paint): Call paintSpinButton() for spin buttons.
(WebCore::ThemeWPE::paintSpinButton): Paint the buttons.

  • platform/wpe/ThemeWPE.h:
1:31 AM Changeset in webkit [256822] by commit-queue@webkit.org
  • 29 edits in trunk/Source/WebCore

Make ImageBuffer::getImageData() and putImageData() return and take ImageData
​https://bugs.webkit.org/show_bug.cgi?id=206621

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-02-18
Reviewed by Tim Horton.

-- Combine ImageBuffer::getUnmultipliedImageData() and getPremultipliedImageData()

in one function and name it getImageData();

-- Make getImageData() returns a RefPtr<ImageData> since the canvas code

used to encapsulate the returned the returned Uint8ClampedArray into
an ImageData and send it to JavaScriptCore.

-- Rename ImageBuffer::putByteArray() to ImageBuffer::putImageData() and

make it take an ImageData since the byte array has to be associated
with an IntSize and separating them does not look a good design.

-- Remove the enum ImageBuffer::CoordinateSystem. All the callers need to

pass rectangles and sizes in logical coordinates. The ImageData has to
be scaled according to the ImgeBuffer::resolutionScale().

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpImageBitmap):
(WebCore::CloneDeserializer::readImageBitmap):

  • html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::getImageData const):
(WebCore::CanvasRenderingContext2DBase::putImageData):

  • html/canvas/CanvasRenderingContext2DBase.h:
  • page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::convertToLuminanceMask):
(WebCore::ImageBuffer::transformColorSpace): Deleted.
Move this function to ImageBufferCairo.cpp.

(WebCore::ImageBuffer::genericConvertToLuminanceMask): Deleted.
convertToLuminanceMask() and genericConvertToLuminanceMask() are not
overridden by any platform. So delete genericConvertToLuminanceMask() and
move its body to convertToLuminanceMask().

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::drawConsuming):
(WebCore::ImageBuffer::putImageData):
Make the private functions be public and remove the friend classes.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurShadowBuffer):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::transformColorSpace):
(WebCore::getData):
(WebCore::ImageBuffer::getImageData const):
(WebCore::ImageBuffer::putImageData):
(WebCore::getImageData): Deleted.
(WebCore::logicalUnit): Deleted.
(WebCore::backingStoreUnit): Deleted.
(WebCore::ImageBuffer::getUnmultipliedImageData const): Deleted.
(WebCore::ImageBuffer::getPremultipliedImageData const): Deleted.
(WebCore::ImageBuffer::putByteArray): Deleted.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::getImageData const):
(WebCore::ImageBuffer::putImageData):
(WebCore::ImageBuffer::toCFData const):
(WebCore::ImageBuffer::getUnmultipliedImageData const): Deleted.
(WebCore::ImageBuffer::getPremultipliedImageData const): Deleted.
(WebCore::ImageBuffer::putByteArray): Deleted.

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

  • platform/graphics/cg/ImageBufferDataCG.h:

All the rectangles and sizes have to be passed in logical coordinates. To
deal with the pixels' data we need to scale them by the resolutionScale().

  • platform/graphics/cpu/arm/filters/FEBlendNEON.h:

(WebCore::FEBlend::platformApplySoftware):

  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware):

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

  • platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):
This was the only place which was passing a rectangle in a the back-end
coordinates along with BackingStoreCoordinateSystem. Instead we can pass
the rectangle in logical coordinates and then use ImageData::size() since
it must be scaled with resolutionScale() when the ImageData is created.

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplySoftware):

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware):

  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::forceValidPreMultipliedPixels):
(WebCore::FilterEffect::imageBufferResult):
(WebCore::FilterEffect::copyUnmultipliedResult):
(WebCore::FilterEffect::copyPremultipliedResult):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):

  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/win/ImageBufferDataDirect2D.cpp:

(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

  • platform/graphics/win/ImageBufferDataDirect2D.h:
  • platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::getImageData const):
(WebCore::ImageBuffer::putImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData const): Deleted.
(WebCore::ImageBuffer::getPremultipliedImageData const): Deleted.
(WebCore::ImageBuffer::putByteArray): Deleted.

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

Note: See TracTimeline for information about the timeline view.