Timeline

Mar 4, 2020:

11:57 PM Changeset in webkit [257907] by mark.lam@apple.com

• 9 edits
  1 add in trunk

Handle an out of memory error while constructing the BytecodeGenerator.
​https://bugs.webkit.org/show_bug.cgi?id=208622
<rdar://problem/59341136>

Reviewed by Saam Barati.

JSTests:

• stress/out-of-memory-while-constructing-BytecodeGenerator.js: Added.

Source/JavaScriptCore:

Added the ability to handle out of memory errors encountered during the
construction of the BytecodeGenerator. Currently, we only use this for the
case where we fail to instantiate a ScopedArgumentsTable.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):

• bytecompiler/BytecodeGeneratorBase.h:
• runtime/ScopedArgumentsTable.cpp:

(JSC::ScopedArgumentsTable::tryCreate):

• runtime/ScopedArgumentsTable.h:
• runtime/SymbolTable.h:

Source/WTF:

• wtf/CagedUniquePtr.h:

(WTF::CagedUniquePtr::tryCreate):

11:50 PM Changeset in webkit [257906] by basuke.suzuki@sony.com

• 1 edit
  2 adds in trunk/Tools

[MSVC] Add .natvis support of WebKit types
​https://bugs.webkit.org/show_bug.cgi?id=193119

Reviewed by Don Olmstead.

To help the WebKit developer while debugging, this file defines how
WebKit types are displayed in debugger of Visual Studio.
Very limited set of WebKit types, but it changes the world.

• VisualStudio/WebKit.natvis: Added.

11:18 PM Changeset in webkit [257905] by ysuzuki@apple.com

• 142 edits in trunk/Source/WebCore

Put all generated JSCells in WebCore into IsoSubspace
​https://bugs.webkit.org/show_bug.cgi?id=205107

Reviewed by Saam Barati.

This patch automatically generates IsoSubspace per WebCore DOM object type.
In preprocess-idls.pl, we collect all the DOM object types and generate DOMIsoSubspaces class,
which contains all the necessary IsoSubspaces. And it is held by WebCoreJSClientData.

CodeGeneratorJS.pm starts putting subspaceFor and subspaceForImpl for each JS DOM wrapper classes.
And we dynamically create IsoSubspace and set it to WebCoreJSClientData's DOMIsoSubspaces. At the same
time, we register IsoSubspace to m_outputConstraintSpaces if the class has output constraits callback.

• CMakeLists.txt:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• WebCoreMacros.cmake:
• bindings/js/JSDOMWrapper.cpp:

(WebCore::outputConstraintSubspaceFor): Deleted.

• bindings/js/JSDOMWrapper.h:
• bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::JSVMClientData):

• bindings/js/WebCoreJSClientData.h:

(WebCore::JSVMClientData::forEachOutputConstraintSpace):
(WebCore::JSVMClientData::subspaces):
(WebCore::JSVMClientData::outputConstraintSpace): Deleted.
(WebCore::JSVMClientData::subspaceForJSDOMWindow): Deleted.
(WebCore::JSVMClientData::subspaceForJSDedicatedWorkerGlobalScope): Deleted.
(WebCore::JSVMClientData::subspaceForJSRemoteDOMWindow): Deleted.
(WebCore::JSVMClientData::subspaceForJSWorkerGlobalScope): Deleted.
(WebCore::JSVMClientData::subspaceForJSServiceWorkerGlobalScope): Deleted.
(WebCore::JSVMClientData::subspaceForJSPaintWorkletGlobalScope): Deleted.
(WebCore::JSVMClientData::subspaceForJSWorkletGlobalScope): Deleted.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

• bindings/scripts/generate-bindings-all.pl:
• bindings/scripts/preprocess-idls.pl:
• bindings/scripts/test/JS/JSInterfaceName.cpp:

(WebCore::JSInterfaceName::subspaceForImpl):

• bindings/scripts/test/JS/JSInterfaceName.h:

(WebCore::JSInterfaceName::subspaceFor):

• bindings/scripts/test/JS/JSMapLike.cpp:

(WebCore::JSMapLike::subspaceForImpl):

• bindings/scripts/test/JS/JSMapLike.h:

(WebCore::JSMapLike::subspaceFor):

• bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:

(WebCore::JSReadOnlyMapLike::subspaceForImpl):

• bindings/scripts/test/JS/JSReadOnlyMapLike.h:

(WebCore::JSReadOnlyMapLike::subspaceFor):

• bindings/scripts/test/JS/JSReadOnlySetLike.cpp:

(WebCore::JSReadOnlySetLike::subspaceForImpl):

• bindings/scripts/test/JS/JSReadOnlySetLike.h:

(WebCore::JSReadOnlySetLike::subspaceFor):

• bindings/scripts/test/JS/JSSetLike.cpp:

(WebCore::JSSetLike::subspaceForImpl):

• bindings/scripts/test/JS/JSSetLike.h:

(WebCore::JSSetLike::subspaceFor):

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObject::subspaceForImpl):

• bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(WebCore::JSTestActiveDOMObject::subspaceFor):

• bindings/scripts/test/JS/JSTestCEReactions.cpp:

(WebCore::JSTestCEReactions::subspaceForImpl):

• bindings/scripts/test/JS/JSTestCEReactions.h:

(WebCore::JSTestCEReactions::subspaceFor):

• bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:

(WebCore::JSTestCEReactionsStringifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestCEReactionsStringifier.h:

(WebCore::JSTestCEReactionsStringifier::subspaceFor):

• bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::JSTestCallTracer::subspaceForImpl):

• bindings/scripts/test/JS/JSTestCallTracer.h:

(WebCore::JSTestCallTracer::subspaceFor):

• bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::JSTestClassWithJSBuiltinConstructor::subspaceForImpl):

• bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h:

(WebCore::JSTestClassWithJSBuiltinConstructor::subspaceFor):

• bindings/scripts/test/JS/JSTestDOMJIT.cpp:

(WebCore::JSTestDOMJIT::subspaceForImpl):

• bindings/scripts/test/JS/JSTestDOMJIT.h:

(WebCore::JSTestDOMJIT::subspaceFor):

• bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::JSTestEnabledBySetting::subspaceForImpl):

• bindings/scripts/test/JS/JSTestEnabledBySetting.h:

(WebCore::JSTestEnabledBySetting::subspaceFor):

• bindings/scripts/test/JS/JSTestEnabledForContext.cpp:

(WebCore::JSTestEnabledForContext::subspaceForImpl):

• bindings/scripts/test/JS/JSTestEnabledForContext.h:

(WebCore::JSTestEnabledForContext::subspaceFor):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::subspaceForImpl):

• bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::subspaceFor):

• bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::subspaceForImpl):

• bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::subspaceFor):

• bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::subspaceForImpl):

• bindings/scripts/test/JS/JSTestException.h:

(WebCore::JSTestException::subspaceFor):

• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachable::subspaceForImpl):

• bindings/scripts/test/JS/JSTestGenerateIsReachable.h:

(WebCore::JSTestGenerateIsReachable::subspaceFor):

• bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::JSTestGlobalObject::subspaceForImpl):

• bindings/scripts/test/JS/JSTestGlobalObject.h:

(WebCore::JSTestGlobalObject::subspaceFor):

• bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:

(WebCore::JSTestIndexedSetterNoIdentifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h:

(WebCore::JSTestIndexedSetterNoIdentifier::subspaceFor):

• bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:

(WebCore::JSTestIndexedSetterThrowingException::subspaceForImpl):

• bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h:

(WebCore::JSTestIndexedSetterThrowingException::subspaceFor):

• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:

(WebCore::JSTestIndexedSetterWithIdentifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h:

(WebCore::JSTestIndexedSetterWithIdentifier::subspaceFor):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::subspaceForImpl):

• bindings/scripts/test/JS/JSTestInterface.h:
• bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:

(WebCore::JSTestInterfaceLeadingUnderscore::subspaceForImpl):

• bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.h:

(WebCore::JSTestInterfaceLeadingUnderscore::subspaceFor):

• bindings/scripts/test/JS/JSTestIterable.cpp:

(WebCore::JSTestIterable::subspaceForImpl):

• bindings/scripts/test/JS/JSTestIterable.h:

(WebCore::JSTestIterable::subspaceFor):

• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructor::subspaceForImpl):

• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:

(WebCore::JSTestJSBuiltinConstructor::subspaceFor):

• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::subspaceForImpl):

• bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:

(WebCore::JSTestNamedAndIndexedSetterNoIdentifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h:

(WebCore::JSTestNamedAndIndexedSetterNoIdentifier::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:

(WebCore::JSTestNamedAndIndexedSetterThrowingException::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h:

(WebCore::JSTestNamedAndIndexedSetterThrowingException::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:

(WebCore::JSTestNamedAndIndexedSetterWithIdentifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h:

(WebCore::JSTestNamedAndIndexedSetterWithIdentifier::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:

(WebCore::JSTestNamedDeleterNoIdentifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h:

(WebCore::JSTestNamedDeleterNoIdentifier::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:

(WebCore::JSTestNamedDeleterThrowingException::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h:

(WebCore::JSTestNamedDeleterThrowingException::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:

(WebCore::JSTestNamedDeleterWithIdentifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h:

(WebCore::JSTestNamedDeleterWithIdentifier::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:

(WebCore::JSTestNamedDeleterWithIndexedGetter::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h:

(WebCore::JSTestNamedDeleterWithIndexedGetter::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:

(WebCore::JSTestNamedGetterCallWith::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedGetterCallWith.h:

(WebCore::JSTestNamedGetterCallWith::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:

(WebCore::JSTestNamedGetterNoIdentifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h:

(WebCore::JSTestNamedGetterNoIdentifier::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:

(WebCore::JSTestNamedGetterWithIdentifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h:

(WebCore::JSTestNamedGetterWithIdentifier::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:

(WebCore::JSTestNamedSetterNoIdentifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h:

(WebCore::JSTestNamedSetterNoIdentifier::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:

(WebCore::JSTestNamedSetterThrowingException::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h:

(WebCore::JSTestNamedSetterThrowingException::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:

(WebCore::JSTestNamedSetterWithIdentifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h:

(WebCore::JSTestNamedSetterWithIdentifier::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:

(WebCore::JSTestNamedSetterWithIndexedGetter::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h:

(WebCore::JSTestNamedSetterWithIndexedGetter::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:

(WebCore::JSTestNamedSetterWithIndexedGetterAndSetter::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h:

(WebCore::JSTestNamedSetterWithIndexedGetterAndSetter::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:

(WebCore::JSTestNamedSetterWithOverrideBuiltins::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h:

(WebCore::JSTestNamedSetterWithOverrideBuiltins::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:

(WebCore::JSTestNamedSetterWithUnforgableProperties::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h:

(WebCore::JSTestNamedSetterWithUnforgableProperties::subspaceFor):

• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:

(WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h:

(WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins::subspaceFor):

• bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNode::subspaceForImpl):

• bindings/scripts/test/JS/JSTestNode.h:
• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::subspaceForImpl):

• bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::subspaceFor):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructors::subspaceForImpl):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.h:

(WebCore::JSTestOverloadedConstructors::subspaceFor):

• bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::JSTestOverloadedConstructorsWithSequence::subspaceForImpl):

• bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.h:

(WebCore::JSTestOverloadedConstructorsWithSequence::subspaceFor):

• bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltins::subspaceForImpl):

• bindings/scripts/test/JS/JSTestOverrideBuiltins.h:

(WebCore::JSTestOverrideBuiltins::subspaceFor):

• bindings/scripts/test/JS/JSTestPluginInterface.cpp:

(WebCore::JSTestPluginInterface::subspaceForImpl):

• bindings/scripts/test/JS/JSTestPluginInterface.h:

(WebCore::JSTestPluginInterface::subspaceFor):

• bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:

(WebCore::JSTestPromiseRejectionEvent::subspaceForImpl):

• bindings/scripts/test/JS/JSTestPromiseRejectionEvent.h:

(WebCore::JSTestPromiseRejectionEvent::subspaceFor):

• bindings/scripts/test/JS/JSTestSerialization.cpp:

(WebCore::JSTestSerialization::subspaceForImpl):

• bindings/scripts/test/JS/JSTestSerialization.h:

(WebCore::JSTestSerialization::subspaceFor):

• bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:

(WebCore::JSTestSerializationIndirectInheritance::subspaceForImpl):

• bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.h:

(WebCore::JSTestSerializationIndirectInheritance::subspaceFor):

• bindings/scripts/test/JS/JSTestSerializationInherit.cpp:

(WebCore::JSTestSerializationInherit::subspaceForImpl):

• bindings/scripts/test/JS/JSTestSerializationInherit.h:

(WebCore::JSTestSerializationInherit::subspaceFor):

• bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:

(WebCore::JSTestSerializationInheritFinal::subspaceForImpl):

• bindings/scripts/test/JS/JSTestSerializationInheritFinal.h:

(WebCore::JSTestSerializationInheritFinal::subspaceFor):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::subspaceForImpl):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::subspaceFor):

• bindings/scripts/test/JS/JSTestStringifier.cpp:

(WebCore::JSTestStringifier::subspaceForImpl):

• bindings/scripts/test/JS/JSTestStringifier.h:

(WebCore::JSTestStringifier::subspaceFor):

• bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:

(WebCore::JSTestStringifierAnonymousOperation::subspaceForImpl):

• bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.h:

(WebCore::JSTestStringifierAnonymousOperation::subspaceFor):

• bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:

(WebCore::JSTestStringifierNamedOperation::subspaceForImpl):

• bindings/scripts/test/JS/JSTestStringifierNamedOperation.h:

(WebCore::JSTestStringifierNamedOperation::subspaceFor):

• bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:

(WebCore::JSTestStringifierOperationImplementedAs::subspaceForImpl):

• bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.h:

(WebCore::JSTestStringifierOperationImplementedAs::subspaceFor):

• bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:

(WebCore::JSTestStringifierOperationNamedToString::subspaceForImpl):

• bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.h:

(WebCore::JSTestStringifierOperationNamedToString::subspaceFor):

• bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:

(WebCore::JSTestStringifierReadOnlyAttribute::subspaceForImpl):

• bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.h:

(WebCore::JSTestStringifierReadOnlyAttribute::subspaceFor):

• bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:

(WebCore::JSTestStringifierReadWriteAttribute::subspaceForImpl):

• bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.h:

(WebCore::JSTestStringifierReadWriteAttribute::subspaceFor):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefs::subspaceForImpl):

• bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore::JSTestTypedefs::subspaceFor):

11:06 PM Changeset in webkit [257904] by Chris Dumez

• 2 edits in trunk/Source/WebKit

WebsiteDataStore methods often create process pools and launch network processes unnecessarily
​https://bugs.webkit.org/show_bug.cgi?id=208619

Reviewed by Alex Christensen.

These methods were potentially creating a temporary WebProcessPool object and launching a network
process only to go change something in memory in the network process. Since the newly created
WebProcessPool is temporary, it gets destroyed as soon as we get out of the for loop and the
network go away too. Therefore, the information in memory of the new network process would not
survive. Those methods should never be created a process pool and this patch fixes this.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setMaxStatisticsEntries):
(WebKit::WebsiteDataStore::setPruneEntriesDownTo):
(WebKit::WebsiteDataStore::setGrandfatheringTime):
(WebKit::WebsiteDataStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::WebsiteDataStore::setPrevalentResource):
(WebKit::WebsiteDataStore::setVeryPrevalentResource):
(WebKit::WebsiteDataStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebsiteDataStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebsiteDataStore::setIsRunningResourceLoadStatisticsTest):
(WebKit::WebsiteDataStore::setNotifyPagesWhenTelemetryWasCaptured):
(WebKit::WebsiteDataStore::getAllStorageAccessEntries):
(WebKit::WebsiteDataStore::setTimeToLiveUserInteraction):
(WebKit::WebsiteDataStore::setCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebsiteDataStore::clearResourceLoadStatisticsInWebProcesses):

11:00 PM Changeset in webkit [257903] by Andres Gonzalez

• 4 edits in trunk/Source/WebCore

Fix for test accessibility/mac/aria-liveregions-addedelement.html in IsolatedTree mode.
​https://bugs.webkit.org/show_bug.cgi?id=208624

Reviewed by Chris Fleizach.

Test: accessibility/mac/aria-liveregions-addedelement.html

LayoutTests can request the focused element before they call any method
in the WebAccessibilityObjectWrapper through AccessibilityController::focusedElement,
and thus the focused element may be amongst the pending appends of the
IsolatedTree. This change sets the focused element in the isolated
treee during generation, so it can be returned to the AccessibilityController
even if no WebAccessibilityObjectWrapper calls have been made.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::generateIsolatedTree):

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::focusedUIElement):
(WebCore::AXIsolatedTree::setFocusedNode):

• accessibility/isolatedtree/AXIsolatedTree.h:

10:38 PM Changeset in webkit [257902] by Simon Fraser

• 5 edits in trunk/Source

Make m_slowRepaintObjects a WeakHashSet
​https://bugs.webkit.org/show_bug.cgi?id=208623

Reviewed by Ryosuke Niwa.

Source/WebCore:

Use WeakHashSet<> for m_slowRepaintObjects, rather than a HashSet of raw pointers.

• page/FrameView.cpp:

(WebCore::FrameView::didDestroyRenderTree):
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::repaintSlowRepaintObjects):

• page/FrameView.h:

Source/WebKit:

Fix namespace errors triggered by FrameView include changes.

• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::visitedLinkStore):
(API::PageConfiguration::setVisitedLinkStore):

9:50 PM Changeset in webkit [257901] by sihui_liu@apple.com

• 3 edits in trunk/Source/WebCore

Remove unused variable m_allUniqueIDBDatabases in IDBServer
​https://bugs.webkit.org/show_bug.cgi?id=208613

Reviewed by Chris Dumez.

• Modules/indexeddb/server/IDBServer.h:

(WebCore::IDBServer::IDBServer::addDatabase): Deleted.
(WebCore::IDBServer::IDBServer::removeDatabase): Deleted.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):

9:26 PM Changeset in webkit [257900] by beidson@apple.com

• 5 edits in trunk/Source

Lay initial groundwork for new PDF loading model
​https://bugs.webkit.org/show_bug.cgi?id=208599

Reviewed by Alex Christensen.

Source/WebKit:

First piece of adopting some new platform PDF APIs.
Disabled by default even on platforms that support it.
No behavior change for shipping configs.

• WebProcess/Plugins/PDF/PDFPlugin.h:
• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):
(WebKit::dataProviderGetBytesAtPositionCallback):
(WebKit::dataProviderGetByteRangesCallback):
(WebKit::dataProviderReleaseInfoCallback):
(WebKit::PDFPlugin::threadEntry):
(WebKit::PDFPlugin::unconditionalCompleteRangeRequest):
(WebKit::PDFPlugin::getResourceBytesAtPosition):
(WebKit::PDFPlugin::adoptBackgroundThreadDocument):
(WebKit::PDFPlugin::pdfDocumentDidLoad):
(WebKit::PDFPlugin::installPDFDocument):
(WebKit::PDFPlugin::manualStreamDidReceiveData):
(WebKit::PDFPlugin::attemptToUnlockPDF):
(WebKit::PDFPlugin::calculateSizes):
(WebKit::PDFPlugin::handleMouseEvent):
(WebKit::PDFPlugin::saveToPDF):
(WebKit::PDFPlugin::openWithNativeApplication):
(WebKit::PDFPlugin::countFindMatches):
(WebKit::PDFPlugin::nextMatchForString):

Source/WTF:

• wtf/PlatformHave.h:

7:46 PM Changeset in webkit [257899] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[VNE layout] Move visually non-empty content reporting to RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=208606
<rdar://problem/60056951>

Reviewed by Simon Fraser.

Move the VNE reporting logic from the c'tors to the RenderTreeBuilder.

• rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):

• rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::RenderHTMLCanvas):

• rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):

• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::attach):
(WebCore::RenderTreeBuilder::attachInternal):
(WebCore::RenderTreeBuilder::attachIgnoringContinuation):
(WebCore::RenderTreeBuilder::reportVisuallyNonEmptyContent):

• rendering/updating/RenderTreeBuilder.h:
• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::createRenderer):
(WebCore::RenderTreeUpdater::createTextRenderer):

7:33 PM Changeset in webkit [257898] by Wenson Hsieh

• 6 edits in trunk

Add system trace points around display list replay
​https://bugs.webkit.org/show_bug.cgi?id=208616

Reviewed by Simon Fraser.

Source/WebCore:

Surround DisplayList::Replayer::replay with trace points.

• platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::replay):

Source/WTF:

Add DisplayListReplayStart and DisplayListReplayEnd.

• wtf/SystemTracing.h:

Tools:

Add a new "Display list replay" trace point.

• Tracing/SystemTracePoints.plist:

7:33 PM Changeset in webkit [257897] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

Crash in SVGElement::removeEventListener with symbol element
​https://bugs.webkit.org/show_bug.cgi?id=207920

Patch by Doug Kelly <Doug Kelly> on 2020-03-04
Reviewed by Ryosuke Niwa.

Source/WebCore:

Resolves a crash in SVGElement::removeEventListener by only attaching the events to the window if the SVG element is both the outermost
SVG element, in addition to ensuring the SVG element is attached to the tree. The symbol element's behavior when referenced by a use
tag actually creates an svg tag instead, so the SVGSVGElement's special behavior for copying attributes is vital.

Note that Chrome and Firefox have a similar behavior for detached SVG elements as to what this change creates: in both other browsers,
onerror is not fired for a detached svg element, and in Firefox, onresize is not fired for a detached svg element (it is however fired
in Chrome).

Tests: fast/events/detached-svg-parent-window-events.html

fast/events/onerror-svg-symbol.html

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::parseAttribute):

LayoutTests:

• fast/events/detached-svg-parent-window-events-expected.txt: Added.
• fast/events/detached-svg-parent-window-events.html: Added.
• fast/events/onerror-svg-symbol-expected.txt: Added.
• fast/events/onerror-svg-symbol.html: Added.

7:28 PM Changeset in webkit [257896] by Andres Gonzalez

• 3 edits in trunk/Source/WebCore

Fix for crash in AXIsolatedObject::fillChildrenVectorForProperty.
​https://bugs.webkit.org/show_bug.cgi?id=208618

Reviewed by Chris Fleizach.

Reserve capacity of WTF::Vector before using it since constructor
doesn't do it.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::fillChildrenVectorForProperty const):

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::objectsForIDs const):

7:14 PM Changeset in webkit [257895] by zhifei_fang@apple.com

• 2 edits in trunk/Websites/perf.webkit.org

Test-freshness page table heaer misplaced
Some platform name is too long
​https://bugs.webkit.org/show_bug.cgi?id=208617

Reviewed by Ryosuke Niwa.

• public/v3/pages/test-freshness-page.js:

(TestFreshnessPage.cssTemplate):

6:35 PM Changeset in webkit [257894] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WebDriver] Update screenshot/user_prompt expectations.

They were marked as FAIL in r239824 due to upstream w3c tests not handling
dialogs correctly and this handling not being in the spec.

The correct handling was added to wpt in
​https://github.com/web-platform-tests/wpt/pull/17563, imported to webkit
in r252358, and have been passing since in the GTK test bot.

Also were added to the spec in ​https://github.com/w3c/webdriver/commit/32165846

Unreviewed test gardening.

• TestExpectations.json:

6:04 PM Changeset in webkit [257893] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Construct fewer unnecessary temporary WebProcessPool objects in WebsiteDataStore implementation
​https://bugs.webkit.org/show_bug.cgi?id=208610

Reviewed by Alex Christensen.

A lot of methods in WebsiteDataStore were calling ensureProcessPools() and then it a loop do something
if the pool already has a network process. When you construct a new process pool, the pool has initially
no network process. As a result, this code should be using processPools() instead of ensureProcessPools()
to avoid unnecessarily constructing a temporary WebProcessPool object.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::dumpResourceLoadStatistics):
(WebKit::WebsiteDataStore::isPrevalentResource):
(WebKit::WebsiteDataStore::isGrandfathered):
(WebKit::WebsiteDataStore::setPrevalentResourceForDebugMode):
(WebKit::WebsiteDataStore::isVeryPrevalentResource):
(WebKit::WebsiteDataStore::setVeryPrevalentResource):
(WebKit::WebsiteDataStore::setSubframeUnderTopFrameDomain):
(WebKit::WebsiteDataStore::isRegisteredAsSubFrameUnder):
(WebKit::WebsiteDataStore::setSubresourceUnderTopFrameDomain):
(WebKit::WebsiteDataStore::isRegisteredAsSubresourceUnder):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectTo):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectTo):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebsiteDataStore::isRegisteredAsRedirectingTo):
(WebKit::WebsiteDataStore::clearPrevalentResource):
(WebKit::WebsiteDataStore::resetParametersToDefaultValues):
(WebKit::WebsiteDataStore::submitTelemetry):
(WebKit::WebsiteDataStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):
(WebKit::WebsiteDataStore::scheduleCookieBlockingUpdate):
(WebKit::WebsiteDataStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebsiteDataStore::setLastSeen):
(WebKit::WebsiteDataStore::mergeStatisticForTesting):
(WebKit::WebsiteDataStore::logUserInteraction):
(WebKit::WebsiteDataStore::hasHadUserInteraction):
(WebKit::WebsiteDataStore::isRelationshipOnlyInDatabaseOnce):
(WebKit::WebsiteDataStore::clearUserInteraction):
(WebKit::WebsiteDataStore::setGrandfathered):
(WebKit::WebsiteDataStore::setUseITPDatabase):
(WebKit::WebsiteDataStore::setCrossSiteLoadWithLinkDecorationForTesting):
(WebKit::WebsiteDataStore::resetCrossSiteLoadsWithLinkDecorationForTesting):
(WebKit::WebsiteDataStore::deleteCookiesForTesting):
(WebKit::WebsiteDataStore::hasLocalStorageForTesting const):
(WebKit::WebsiteDataStore::hasIsolatedSessionForTesting const):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldDowngradeReferrerForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldBlockThirdPartyCookiesForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsFirstPartyWebsiteDataRemovalModeForTesting):
(WebKit::WebsiteDataStore::resetCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::isResourceLoadStatisticsEphemeral const):
(WebKit::WebsiteDataStore::getLocalStorageDetails):
(WebKit::WebsiteDataStore::resetQuota):
(WebKit::WebsiteDataStore::hasAppBoundSession const):
(WebKit::WebsiteDataStore::setInAppBrowserPrivacyEnabled):

5:13 PM Changeset in webkit [257892] by achristensen@apple.com

• 7 edits
  1 add in trunk

Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
​https://bugs.webkit.org/show_bug.cgi?id=208615
<rdar://problem/59406743>

Reviewed by Alex Christensen.

Source/WebKit:

globalObjectIsAvailableForFrame is often used for initialization code for a content world.
If we evaluate JavaScript in a content world as the first thing we do in that world,
globalObjectIsAvailableForFrame hadn't been called, so things were not initialized.
So call it when evaluating JavaScript if we create the world to evaluate in.

Covered by new API tests.

• WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::addContentWorld):

• WebProcess/UserContent/WebUserContentController.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInFrameInScriptWorld):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.

(-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):

• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:

(TEST):
Also make a test written in bug 206310 actually run code.

5:02 PM Changeset in webkit [257891] by jiewen_tan@apple.com

• 2 edits in trunk/Source/WebKit

Unreviewed, a build fix after r257877

• UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:

(WebKit::LocalConnection::verifyUser const):
Restricts LAOptionPasscodeTitle to iOS for now.

3:31 PM Changeset in webkit [257890] by Kocsen Chung

• 1 copy in tags/Safari-609.1.20.4.4

Tag Safari-609.1.20.4.4.

3:30 PM Changeset in webkit [257889] by aakash_jain@apple.com

• 4 edits in trunk/Tools

[build.webkit.org] Remove leaks queue
​https://bugs.webkit.org/show_bug.cgi?id=208580

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

3:28 PM Changeset in webkit [257888] by Chris Dumez

• 15 edits in trunk/Source

Adopt new and improved CFNetwork SPI for cookie change notifications
​https://bugs.webkit.org/show_bug.cgi?id=208594
<rdar://problem/60053313>

Reviewed by Alex Christensen.

Source/WebCore:

Adopt new and improved CFNetwork SPI for cookie change notifications. Notifications are now per domain
and the domain matches one of the domains we listen for cookie changes on.

This also fixes a bug where httpOnly cookies would be sent to the WebContent processes in cookie change
notifications, even though the WebProcesses are not interested in those.

• platform/network/NetworkStorageSession.h:
• platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::registerCookieChangeListenersIfNecessary):

Source/WebCore/PAL:

Add new CFNetwork SPI.

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

Adopt new and improved CFNetwork SPI for cookie change notifications. Notifications are now per domain
and the domain matches one of the domains we listen for cookie changes on.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::cookiesDeleted):
(WebKit::NetworkConnectionToWebProcess::allCookiesDeleted):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::cookiesDeleted):
(WebKit::NetworkProcessConnection::allCookiesDeleted):

• WebProcess/Network/NetworkProcessConnection.h:
• WebProcess/Network/NetworkProcessConnection.messages.in:
• WebProcess/WebPage/WebCookieCache.cpp:

(WebKit::WebCookieCache::cookiesDeleted):
(WebKit::WebCookieCache::allCookiesDeleted):

• WebProcess/WebPage/WebCookieCache.h:
• WebProcess/WebPage/WebCookieJar.cpp:

(WebKit::WebCookieJar::cookiesDeleted):
(WebKit::WebCookieJar::allCookiesDeleted):

• WebProcess/WebPage/WebCookieJar.h:

3:28 PM Changeset in webkit [257887] by Kocsen Chung

• 3 edits in branches/safari-610.1.6-branch/Source/WebKit

Cherry-pick r257879. rdar://problem/60057110

Partially revert r256756, since it introduced bugs related to Accessibility.
<rdar://problem/60005574>

Unreviewed partial revert of r256756.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:27 PM Changeset in webkit [257886] by Kocsen Chung

• 10 edits in branches/safari-610.1.6-branch/Source

Cherry-pick r257875. rdar://problem/60057110

[Cocoa] Add enable flag to disable direct mode for preferences
​https://bugs.webkit.org/show_bug.cgi?id=208588

Reviewed by Brent Fulgham.

Source/WebKit:

Add an enable flag for this feature so it can be toggled, and turn it off.

No new tests, since this patch is reverting to previous behavior covered by existing tests.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: (WebKit::XPCServiceMain):
• Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions): (WebKit::WebProcessPool::platformInitializeWebProcess):
• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
• WebProcess/com.apple.WebProcess.sb.in:

Source/WTF:

• wtf/PlatformEnable.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:21 PM Changeset in webkit [257885] by Kocsen Chung

• 1 copy in tags/Safari-610.1.5.3

Tag Safari-610.1.5.3.

3:19 PM Changeset in webkit [257884] by Kocsen Chung

• 10 edits in branches/safari-610.1.5-branch/Source

Cherry-pick r257875. rdar://problem/60055569

[Cocoa] Add enable flag to disable direct mode for preferences
​https://bugs.webkit.org/show_bug.cgi?id=208588

Reviewed by Brent Fulgham.

Source/WebKit:

Add an enable flag for this feature so it can be toggled, and turn it off.

No new tests, since this patch is reverting to previous behavior covered by existing tests.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: (WebKit::XPCServiceMain):
• Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions): (WebKit::WebProcessPool::platformInitializeWebProcess):
• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
• WebProcess/com.apple.WebProcess.sb.in:

Source/WTF:

• wtf/PlatformEnable.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:19 PM Changeset in webkit [257883] by Kocsen Chung

• 3 edits in branches/safari-610.1.5-branch/Source/WebKit

Cherry-pick r257879. rdar://problem/60055569

Partially revert r256756, since it introduced bugs related to Accessibility.
<rdar://problem/60005574>

Unreviewed partial revert of r256756.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:18 PM Changeset in webkit [257882] by achristensen@apple.com

• 13 edits in trunk

Add SPI to evaluate JavaScript in an iframe
​https://bugs.webkit.org/show_bug.cgi?id=208605

Reviewed by Brady Eidson.

Source/WebCore:

Covered by new API tests.

• bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
Remove a now-invalid assertion that was firing during my test.
API::ContentWorld::defaultClientWorld creates a world with no name and type Type::User.
I'm surprised this wasn't hit before.

Source/WebKit:

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView evaluateJavaScript:completionHandler:]):
(-[WKWebView evaluateJavaScript:inContentWorld:completionHandler:]):
(-[WKWebView callAsyncJavaScript:arguments:inContentWorld:completionHandler:]):
(-[WKWebView _evaluateJavaScript:asAsyncFunction:withArguments:forceUserGesture:inFrame:inWorld:completionHandler:]):
(-[WKWebView _evaluateJavaScriptWithoutUserGesture:completionHandler:]):
(-[WKWebView _callAsyncJavaScript:arguments:inFrame:inContentWorld:completionHandler:]):
(-[WKWebView _evaluateJavaScript:inFrame:inContentWorld:completionHandler:]):
(-[WKWebView _evaluateJavaScript:asAsyncFunction:withArguments:forceUserGesture:completionHandler:inWorld:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::runJavaScriptInFrameInScriptWorld):
(WebKit::WebPageProxy::runJavaScriptInMainFrameScriptWorld): Deleted.
(WebKit::WebPageProxy::runJavaScriptInFrame): Deleted.

• UIProcess/WebPageProxy.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInFrameInScriptWorld):
(WebKit::WebPage::runJavaScriptInMainFrameScriptWorld): Deleted.
(WebKit::WebPage::runJavaScriptInFrame): Deleted.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

3:10 PM Changeset in webkit [257881] by Kocsen Chung

• 8 edits in branches/safari-610.1.5-branch/Source

Versioning.

3:09 PM Changeset in webkit [257880] by Alan Bujtas

• 2 edits in trunk/LayoutTests

[ Mac wk2 Debug ] fast/layoutformattingcontext/block-only/replaced-intrinsic-width-simple.html is crashing.
​https://bugs.webkit.org/show_bug.cgi?id=208598
<rdar://problem/60054452>

Unreviewed test gardening.

This is LFC failure only. Unrelated to first paint. Skip it for now.

• platform/mac-wk2/TestExpectations:

2:03 PM Changeset in webkit [257879] by pvollan@apple.com

• 3 edits in trunk/Source/WebKit

Partially revert r256756, since it introduced bugs related to Accessibility.
<rdar://problem/60005574>

Unreviewed partial revert of r256756.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebProcess/com.apple.WebProcess.sb.in:

1:56 PM Changeset in webkit [257878] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

REGRESSION: (r257840?) [ Mac wk2 Debug ] fast/layoutformattingcontext/block-only/replaced-intrinsic-width-simple.html is crashing.
​https://bugs.webkit.org/show_bug.cgi?id=208598

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:42 PM Changeset in webkit [257877] by jiewen_tan@apple.com

• 28 edits
  1 delete in trunk

[WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
​https://bugs.webkit.org/show_bug.cgi?id=208533
<rdar://problem/60010184>

Reviewed by Alex Christensen.

Source/WebCore:

Covered by new tests within existing test files.

• en.lproj/Localizable.strings:
• platform/LocalizedStrings.cpp:

(WebCore::touchIDPromptTitle):
(WebCore::biometricFallbackPromptTitle):

• platform/LocalizedStrings.h:

Adds localized strings to support the customized LocalAuthentication dialog.

Source/WebKit:

This patch implements the above SPI to replace -[_WKWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:].
The original SPI is designed on the premise that Safari is going to highly customize the LocalAuthentication UI, and that is not happening
anymore. Therefore, WebKit takes back the invocation of LocalAuthentication and offer a new SPI to tell clients when WebKit is about to
show LocalAuthentication UI. Clients then have the trigger to pull at their pleasure.

This patch implements all plumbings to replace the SPI. Besides that, this patch also:
1) enhances the LocalConnection::verifyUser with a slightly customized LocalAuthentication dialog;
2) adds the SPI used above into the SPI header;
3) makes _WKWebAuthenticationPanelDelegate.transports as a NSSet instead of a NSArray;
4) lets LocalService::isAvailable return false if Apple attestation is not available.

• Platform/spi/Cocoa/LocalAuthenticationSPI.h:
• UIProcess/API/APIWebAuthenticationPanelClient.h:

(API::WebAuthenticationPanelClient::decidePolicyForLocalAuthenticator const):
(API::WebAuthenticationPanelClient::verifyUser const): Deleted.

• UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
• UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(-[_WKWebAuthenticationPanel transports]):

• UIProcess/WebAuthentication/Authenticator.h:
• UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::decidePolicyForLocalAuthenticator):
(WebKit::AuthenticatorManager::verifyUser): Deleted.

• UIProcess/WebAuthentication/AuthenticatorManager.h:
• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.h:
• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticator::makeCredential):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterDecidePolicy):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
(WebKit::LocalAuthenticator::getAssertion):
(WebKit::LocalAuthenticator::continueGetAssertionAfterResponseSelected):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserConsented): Deleted.
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserConsented): Deleted.

• UIProcess/WebAuthentication/Cocoa/LocalConnection.h:
• UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:

(WebKit::LocalConnection::verifyUser const):
(WebKit::LocalConnection::isUnlocked const): Deleted.

• UIProcess/WebAuthentication/Cocoa/LocalService.mm:

(WebKit::LocalService::isAvailable):

• UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.h:
• UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:

(WebKit::WebAuthenticationPanelClient::WebAuthenticationPanelClient):
(WebKit::localAuthenticatorPolicy):
(WebKit::WebAuthenticationPanelClient::decidePolicyForLocalAuthenticator const):
(WebKit::WebAuthenticationPanelClient::verifyUser const): Deleted.

• UIProcess/WebAuthentication/Mock/MockLocalConnection.h:
• UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:

(WebKit::MockLocalConnection::verifyUser const):
(WebKit::MockLocalConnection::isUnlocked const): Deleted.

• UIProcess/WebAuthentication/WebAuthenticationFlags.h:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
(TestWebKitAPI::TEST):
(-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.

• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.

1:35 PM Changeset in webkit [257876] by achristensen@apple.com

• 4 edits in trunk

callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
​https://bugs.webkit.org/show_bug.cgi?id=208593

Reviewed by Brady Eidson.

Source/WebKit:

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _evaluateJavaScript:asAsyncFunction:withArguments:forceUserGesture:completionHandler:inWorld:]):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:

(TestWebKitAPI::TEST):

1:26 PM Changeset in webkit [257875] by pvollan@apple.com

• 10 edits in trunk/Source

[Cocoa] Add enable flag to disable direct mode for preferences
​https://bugs.webkit.org/show_bug.cgi?id=208588

Reviewed by Brent Fulgham.

Source/WebKit:

Add an enable flag for this feature so it can be toggled, and turn it off.

No new tests, since this patch is reverting to previous behavior covered by existing tests.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceMain):

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions):
(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

• WebProcess/com.apple.WebProcess.sb.in:

Source/WTF:

• wtf/PlatformEnable.h:

1:17 PM Changeset in webkit [257874] by Fujii Hironori

• 2 edits in trunk/Source/WebKit

Unreviewed build fix for WinCairo
​https://bugs.webkit.org/show_bug.cgi?id=208591

• Shared/FrameTreeNodeData.h: Replaced #import with #include.

12:47 PM Changeset in webkit [257873] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: the execution context picker is shown on pages with only one execution context if there are internal execution contexts
​https://bugs.webkit.org/show_bug.cgi?id=208502

Reviewed by Timothy Hatcher.

• UserInterface/Views/QuickConsole.js:

(WI.QuickConsole.prototype._updateActiveExecutionContextDisplay):
(WI.QuickConsole.prototype._handleEngineeringShowInternalExecutionContextsSettingChanged):

12:35 PM Changeset in webkit [257872] by achristensen@apple.com

• 25 edits
  6 adds in trunk

WKWebView's frames accessor should return a traversable type
​https://bugs.webkit.org/show_bug.cgi?id=208591

Reviewed by Brady Eidson.

Source/WebKit:

Rather than return an array of information that can technically be used to reconstruct a tree,
let's just return the root of a tree. This introduces _WKFrameTreeNode which inherits from WKFrameInfo.
Covered by API tests.

• Shared/API/APIObject.h:
• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

• Shared/FrameInfoData.cpp:

(WebKit::FrameInfoData::encode const):
(WebKit::FrameInfoData::decode):

• Shared/FrameInfoData.h:
• Shared/FrameTreeNodeData.h: Added.

(WebKit::FrameTreeNodeData::encode const):
(WebKit::FrameTreeNodeData::decode):

• Sources.txt:
• SourcesCocoa.txt:
• UIProcess/API/APIFrameInfo.cpp:

(API::FrameInfo::parentFrameHandle const): Deleted.
(API::FrameInfo::childFrameHandles const): Deleted.

• UIProcess/API/APIFrameInfo.h:
• UIProcess/API/APIFrameTreeNode.cpp: Added.

(API::FrameTreeNode::handle const):

• UIProcess/API/APIFrameTreeNode.h: Added.
• UIProcess/API/Cocoa/WKFrameInfo.mm:

(-[WKFrameInfo _parentFrameHandle]): Deleted.
(-[WKFrameInfo _childFrameHandles]): Deleted.

• UIProcess/API/Cocoa/WKFrameInfoPrivate.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frames:]):
(-[WKWebView _allFrames:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/Cocoa/_WKFrameTreeNode.h: Added.
• UIProcess/API/Cocoa/_WKFrameTreeNode.mm: Added.

(-[_WKFrameTreeNode dealloc]):
(-[_WKFrameTreeNode isMainFrame]):
(-[_WKFrameTreeNode request]):
(-[_WKFrameTreeNode securityOrigin]):
(-[_WKFrameTreeNode webView]):
(-[_WKFrameTreeNode childFrames]):
(-[_WKFrameTreeNode copyWithZone:]):
(-[_WKFrameTreeNode _handle]):
(-[_WKFrameTreeNode _apiObject]):

• UIProcess/API/Cocoa/_WKFrameTreeNodeInternal.h: Added.
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getAllFrames):

• UIProcess/WebPageProxy.h:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::info const):
(WebKit::WebFrame::childFrameIDs const): Deleted.

• WebProcess/WebPage/WebFrame.h:

(WebKit::WebFrame::frameID const):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::frameTreeNodeData):
(WebKit::WebPage::getAllFrames):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

12:26 PM Changeset in webkit [257871] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(?): Elements: unable to edit a tag name more than once
​https://bugs.webkit.org/show_bug.cgi?id=208586

Reviewed by Timothy Hatcher.

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._insertInLastAttributePosition):
When inserting a new attribute, don't wipe out the existing DOM structure, which is required
in order for tag name editing to work (specifically having a .html-tag-name node).

12:05 PM Changeset in webkit [257870] by graouts@webkit.org

• 13 edits in trunk

Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=208575
<rdar://problem/59773690>

Reviewed by Brady Eidson.

Source/WebCore:

Add a new Optional<PageIdentifier> member to UserStyleSheet which indicates whether the UserStyleSheet is supposed
to be injected for all WKWebViews, or only a specific top-level WKWebView associated with a Page with the give ID.

In ExtensionStyleSheets::updateInjectedStyleSheetCache(), UserStyleSheets with a specified pageID are ignored. Instead,
we now also consider CSSStyleSheets listed in the new m_pageSpecificStyleSheets which contains page-specific stylesheets
to be injected for the associated Document.

The new Page::injectUserStyleSheet() method allows the addition of a UserStyleSheet on its documents' ExtensionStyleSheets,
and will call this method either for the main frame's Document, or all Documents, depending on the UserStyleSheet's configuration.

Finally, these new targeted UserStyleSheets can be removed via Page::removeInjectedUserStyleSheet() and
ExtensionStyleSheets::removePageSpecificUserStyleSheet().

• dom/ExtensionStyleSheets.cpp:

(WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache const):
(WebCore::ExtensionStyleSheets::injectPageSpecificUserStyleSheet):
(WebCore::ExtensionStyleSheets::removePageSpecificUserStyleSheet):
(WebCore::ExtensionStyleSheets::detachFromDocument):

• dom/ExtensionStyleSheets.h:
• page/Page.cpp:

(WebCore::Page::injectUserStyleSheet):
(WebCore::Page::removeInjectedUserStyleSheet):

• page/Page.h:
• page/UserStyleSheet.h:

(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::pageID const):

Source/WebKit:

Since WebCore adds a new Optional<PageIdentifier> member to UserStyleSheet, we now encode that member to be preserved
across UI and Web processes.

Using this new member, WebUserContentController now determines that a UserStyleSheet meant to target a specific page
was added in addUserStyleSheetInternal(), finds the matching WebPage, and calls injectUserStyleSheet() on its backing Page
object. Conversely, WebUserContentController::removeUserStyleSheetInternal() will call into Page::removeInjectedUserStyleSheet().

Finally, we offer a new initializer on _WKUserStyleSheet to target a specific WKWebView, and its page's ID will be set on the
backing UserStyleSheet.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<UserStyleSheet>::encode):
(IPC::ArgumentCoder<UserStyleSheet>::decode):

• UIProcess/API/Cocoa/_WKUserStyleSheet.h:
• UIProcess/API/Cocoa/_WKUserStyleSheet.mm:

(-[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]):

• WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::addUserStyleSheetInternal):
(WebKit::WebUserContentController::removeUserStyleSheetInternal):

Tools:

Add new tests for the new SPI which check:

1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the specified WKWebView alone,
2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
3. that a WKWebView-specific _WKUserStyleSheet can be removed,
4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
6. and that the same test also works with PSON enabled.

• TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:

11:56 AM Changeset in webkit [257869] by Jason_Lawrence

• 3 edits in trunk/LayoutTests

[ iOS and Mac wk2 Debug ] fast/events/beforeunload-prompt.html is flaky crashing.
​https://bugs.webkit.org/show_bug.cgi?id=208590

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

11:43 AM Changeset in webkit [257868] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ iOS ] scrollingcoordinator/ios/fixed-frame-overflow-swipe.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=208587

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

11:42 AM Changeset in webkit [257867] by jer.noble@apple.com

• 29 edits
  9 copies
  17 adds in trunk/Source

[GPUP] Implement Modern EME API in the GPU Process
​https://bugs.webkit.org/show_bug.cgi?id=208090

Reviewed by Eric Carlson.

Source/WebCore:

Add export macros to CDMFactory::registeredFactories().

• platform/encryptedmedia/CDMFactory.h:

Source/WebKit:

Add support for RemoteCDMFactory, RemateCDM, RemoteCDMInstance, RemoteCDMInstanceSession, and all
of their associated Proxy objects.

Allow the existing CDMFactory machinery to work normally when the GPU process is disabled,
by making initialization of the CDM factories contingent upon the "use GPU" setting.

• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::cdmFactoryProxy):
(WebKit::GPUConnectionToWebProcess::didReceiveMessage):
(WebKit::GPUConnectionToWebProcess::didReceiveSyncMessage):

• GPUProcess/GPUConnectionToWebProcess.h:
• GPUProcess/media/RemoteCDMFactoryProxy.cpp: Added.

(WebKit::RemoteCDMFactoryProxy::RemoteCDMFactoryProxy):
(WebKit::factoryForKeySystem):
(WebKit::RemoteCDMFactoryProxy::createCDM):
(WebKit::RemoteCDMFactoryProxy::supportsKeySystem):
(WebKit::RemoteCDMFactoryProxy::didReceiveCDMMessage):
(WebKit::RemoteCDMFactoryProxy::didReceiveCDMInstanceMessage):
(WebKit::RemoteCDMFactoryProxy::didReceiveCDMInstanceSessionMessage):
(WebKit::RemoteCDMFactoryProxy::didReceiveSyncCDMMessage):
(WebKit::RemoteCDMFactoryProxy::didReceiveSyncCDMInstanceMessage):
(WebKit::RemoteCDMFactoryProxy::didReceiveSyncCDMInstanceSessionMessage):
(WebKit::RemoteCDMFactoryProxy::addProxy):
(WebKit::RemoteCDMFactoryProxy::removeProxy):
(WebKit::RemoteCDMFactoryProxy::addInstance):
(WebKit::RemoteCDMFactoryProxy::removeInstance):
(WebKit::RemoteCDMFactoryProxy::getInstance):
(WebKit::RemoteCDMFactoryProxy::addSession):
(WebKit::RemoteCDMFactoryProxy::removeSession):

• GPUProcess/media/RemoteCDMFactoryProxy.h: Added.
• GPUProcess/media/RemoteCDMFactoryProxy.messages.in: Added.
• GPUProcess/media/RemoteCDMInstanceProxy.cpp: Added.

(WebKit::RemoteCDMInstanceProxy::create):
(WebKit::RemoteCDMInstanceProxy::RemoteCDMInstanceProxy):
(WebKit::RemoteCDMInstanceProxy::initializeWithConfiguration):
(WebKit::RemoteCDMInstanceProxy::setServerCertificate):
(WebKit::RemoteCDMInstanceProxy::setStorageDirectory):
(WebKit::RemoteCDMInstanceProxy::createSession):

• GPUProcess/media/RemoteCDMInstanceProxy.h: Added.

(WebKit::RemoteCDMInstanceProxy::configuration const):
(WebKit::RemoteCDMInstanceProxy::instance):

• GPUProcess/media/RemoteCDMInstanceProxy.messages.in: Added.
• GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp: Added.

(WebKit::RemoteCDMInstanceSessionProxy::create):
(WebKit::RemoteCDMInstanceSessionProxy::RemoteCDMInstanceSessionProxy):
(WebKit::RemoteCDMInstanceSessionProxy::~RemoteCDMInstanceSessionProxy):
(WebKit::RemoteCDMInstanceSessionProxy::requestLicense):
(WebKit::RemoteCDMInstanceSessionProxy::updateLicense):
(WebKit::RemoteCDMInstanceSessionProxy::loadSession):
(WebKit::RemoteCDMInstanceSessionProxy::closeSession):
(WebKit::RemoteCDMInstanceSessionProxy::removeSessionData):
(WebKit::RemoteCDMInstanceSessionProxy::storeRecordOfKeyUsage):
(WebKit::RemoteCDMInstanceSessionProxy::updateKeyStatuses):
(WebKit::RemoteCDMInstanceSessionProxy::sendMessage):
(WebKit::RemoteCDMInstanceSessionProxy::sessionIdChanged):

• GPUProcess/media/RemoteCDMInstanceSessionProxy.h: Added.
• GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in: Added.
• GPUProcess/media/RemoteCDMProxy.cpp: Added.

(WebKit::RemoteCDMProxy::create):
(WebKit::RemoteCDMProxy::RemoteCDMProxy):
(WebKit::RemoteCDMProxy::supportsInitData):
(WebKit::RemoteCDMProxy::sanitizeResponse):
(WebKit::RemoteCDMProxy::sanitizeSessionId):
(WebKit::RemoteCDMProxy::getSupportedConfiguration):
(WebKit::RemoteCDMProxy::createInstance):
(WebKit::RemoteCDMProxy::loadAndInitialize):

• GPUProcess/media/RemoteCDMProxy.h: Added.

(WebKit::RemoteCDMProxy::configuration const):
(WebKit::RemoteCDMProxy::factory const):

• GPUProcess/media/RemoteCDMProxy.messages.in: Added.
• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::mediaPlayerInitializationDataEncountered):
(WebKit::RemoteMediaPlayerProxy::cdmInstanceAttached):
(WebKit::RemoteMediaPlayerProxy::cdmInstanceDetached):
(WebKit::RemoteMediaPlayerProxy::attemptToDecryptWithInstance):
(WebKit::RemoteMediaPlayerProxy::setShouldContinueAfterKeyNeeded):

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<WebCore::CDMInstanceSession::Message>::encode):
(IPC::ArgumentCoder<WebCore::CDMInstanceSession::Message>::decode):
(IPC::ArgumentCoder<WebCore::CDMInstanceSession::KeyStatusVector>::encode):
(IPC::ArgumentCoder<WebCore::CDMInstanceSession::KeyStatusVector>::decode):

• Shared/WebCoreArgumentCoders.h:
• Sources.txt:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::didReceiveMessage):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::cdmInstanceAttached):
(WebKit::MediaPlayerPrivateRemote::cdmInstanceDetached):
(WebKit::MediaPlayerPrivateRemote::attemptToDecryptWithInstance):
(WebKit::MediaPlayerPrivateRemote::initializationDataEncountered):
(WebKit::MediaPlayerPrivateRemote::setShouldContinueAfterKeyNeeded):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
• WebProcess/GPU/media/RemoteCDM.cpp: Added.

(WebKit::RemoteCDM::create):
(WebKit::RemoteCDM::RemoteCDM):
(WebKit::RemoteCDM::getSupportedConfiguration):
(WebKit::RemoteCDM::supportsConfiguration const):
(WebKit::RemoteCDM::supportsConfigurationWithRestrictions const):
(WebKit::RemoteCDM::supportsSessionTypeWithConfiguration const):
(WebKit::RemoteCDM::supportsInitData const):
(WebKit::RemoteCDM::distinctiveIdentifiersRequirement const):
(WebKit::RemoteCDM::persistentStateRequirement const):
(WebKit::RemoteCDM::distinctiveIdentifiersAreUniquePerOriginAndClearable const):
(WebKit::RemoteCDM::createInstance):
(WebKit::RemoteCDM::loadAndInitialize):
(WebKit::RemoteCDM::sanitizeResponse const):
(WebKit::RemoteCDM::sanitizeSessionId const):

• WebProcess/GPU/media/RemoteCDM.h: Added.
• WebProcess/GPU/media/RemoteCDMConfiguration.h: Added.

(WebKit::RemoteCDMConfiguration::encode const):
(WebKit::RemoteCDMConfiguration::decode):

• WebProcess/GPU/media/RemoteCDMFactory.cpp: Added.

(WebKit::RemoteCDMFactory::RemoteCDMFactory):
(WebKit::RemoteCDMFactory::updatePreferences):
(WebKit::RemoteCDMFactory::supplementName):
(WebKit::RemoteCDMFactory::gpuProcessConnection):
(WebKit::RemoteCDMFactory::supportsKeySystem):
(WebKit::RemoteCDMFactory::createCDM):
(WebKit::RemoteCDMFactory::addSession):
(WebKit::RemoteCDMFactory::removeSession):
(WebKit::RemoteCDMFactory::didReceiveSessionMessage):

• WebProcess/GPU/media/RemoteCDMFactory.h: Added.
• WebProcess/GPU/media/RemoteCDMIdentifier.h: Added.
• WebProcess/GPU/media/RemoteCDMInstance.cpp: Added.

(WebKit::RemoteCDMInstance::create):
(WebKit::RemoteCDMInstance::RemoteCDMInstance):
(WebKit::RemoteCDMInstance::initializeWithConfiguration):
(WebKit::RemoteCDMInstance::setServerCertificate):
(WebKit::RemoteCDMInstance::setStorageDirectory):
(WebKit::RemoteCDMInstance::createSession):

• WebProcess/GPU/media/RemoteCDMInstance.h: Added.
• WebProcess/GPU/media/RemoteCDMInstanceConfiguration.h: Added.

(WebKit::RemoteCDMInstanceConfiguration::encode const):
(WebKit::RemoteCDMInstanceConfiguration::decode):

• WebProcess/GPU/media/RemoteCDMInstanceIdentifier.h: Added.
• WebProcess/GPU/media/RemoteCDMInstanceSession.cpp: Added.

(WebKit::RemoteCDMInstanceSession::create):
(WebKit::RemoteCDMInstanceSession::RemoteCDMInstanceSession):
(WebKit::RemoteCDMInstanceSession::requestLicense):
(WebKit::RemoteCDMInstanceSession::updateLicense):
(WebKit::RemoteCDMInstanceSession::loadSession):
(WebKit::RemoteCDMInstanceSession::closeSession):
(WebKit::RemoteCDMInstanceSession::removeSessionData):
(WebKit::RemoteCDMInstanceSession::storeRecordOfKeyUsage):
(WebKit::RemoteCDMInstanceSession::updateKeyStatuses):
(WebKit::RemoteCDMInstanceSession::sendMessage):
(WebKit::RemoteCDMInstanceSession::sessionIdChanged):

• WebProcess/GPU/media/RemoteCDMInstanceSession.h: Added.
• WebProcess/GPU/media/RemoteCDMInstanceSession.messages.in: Added.
• WebProcess/GPU/media/RemoteCDMInstanceSessionIdentifier.h: Added.
• WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

• WebProcess/WebProcess.cpp:

11:35 AM Changeset in webkit [257866] by sihui_liu@apple.com

• 2 edits in trunk/Source/WebKit

Assertion failed: !m_function in CompletionHandler::~CompletionHandler()
​https://bugs.webkit.org/show_bug.cgi?id=208457

Reviewed by Chris Dumez.

Ensure completion handler is called in WebsiteDataStore::getResourceLoadStatisticsDataSummary.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):

11:29 AM Changeset in webkit [257865] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ iOS ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-removetrack.https.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=208585

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

11:22 AM Changeset in webkit [257864] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ Mac wk2 ] fast/scrolling/scroll-animator-overlay-scrollbars-clicked.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=208584

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

11:18 AM Changeset in webkit [257863] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=206934#add_comment

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

11:04 AM Changeset in webkit [257862] by Ben Nham

• 15 edits in trunk/Source

Remove initial layout throttler
​https://bugs.webkit.org/show_bug.cgi?id=208285

Reviewed by Antti Koivisto.

Source/WebCore:

This removes a throttle that can prevent us from laying out during the first 250 ms of page
load. This throttle is generally not effective (many pages have JS that force a sync layout
before the first 250 ms of loading) and is also extremely outdated (the comment says the
interval is too high for dual G5s). We already have too many throttles in too many places,
so let's remove this one.

• dom/Document.cpp:

(WebCore::Document::implicitClose):
(WebCore::Document::shouldScheduleLayout const):
(WebCore::Document::isLayoutTimerActive const):
(WebCore::Document::shouldScheduleLayout): Deleted.
(WebCore::Document::isLayoutTimerActive): Deleted.
(WebCore::Document::minimumLayoutDelay): Deleted.
(WebCore::Document::timeSinceDocumentCreation const): Deleted.

• dom/Document.h:

(WebCore::Document::parsing const):
(WebCore::Document::timeSinceDocumentCreation const):

• page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layout):
(WebCore::FrameViewLayoutContext::reset):
(WebCore::FrameViewLayoutContext::scheduleLayout):
(WebCore::FrameViewLayoutContext::unscheduleLayout):
(WebCore::FrameViewLayoutContext::scheduleSubtreeLayout):

• page/FrameViewLayoutContext.h:
• page/SettingsBase.cpp:

(WebCore::SettingsBase::SettingsBase):
(WebCore::SettingsBase::setLayoutInterval): Deleted.

• page/SettingsBase.h:

(WebCore::SettingsBase::layoutInterval const): Deleted.

Source/WebKit:

• Shared/WebPreferences.yaml:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences _setLayoutInterval:]): Deleted.
(-[WebPreferences _layoutInterval]): Deleted.

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

10:55 AM Changeset in webkit [257861] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ iOS ] http/wpt/service-workers/server-trust-evaluation.https.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=208582

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

10:45 AM Changeset in webkit [257860] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ iOS ] http/wpt/service-workers/skipFetchEvent.https.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=208581

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

10:35 AM Changeset in webkit [257859] by Ryan Haddad

• 3 edits in trunk/Tools

[macOS] test-lldb-webkit failing on debug bots
​https://bugs.webkit.org/show_bug.cgi?id=208545

Reviewed by Jonathan Bedard.

The lldb-webkit-test step must pass in the build configuration as an
argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
binary that is downloaded with the rest of the build products. Without this
argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
regardless of their actual build configuration.

• BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.

• Scripts/test-lldb-webkit:

(LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.

10:23 AM Changeset in webkit [257858] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews] Add build step to create local git commit for commit-queue (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=208539

Unreviewed follow-up fix.

• BuildSlaveSupport/ews-build/steps.py:

10:21 AM Changeset in webkit [257857] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

REGRESSION (r257839): two fast/forms/textarea are failing after commit r257839
​https://bugs.webkit.org/show_bug.cgi?id=208576

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

10:21 AM Changeset in webkit [257856] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

JSC 32bits broken in debug mode by r257399
​https://bugs.webkit.org/show_bug.cgi?id=208439

Patch by Paulo Matos <Paulo Matos> on 2020-03-04
Reviewed by Carlos Alberto Lopez Perez.

Use uses() method call instead of gpr() on assert to that it
works for both 64 and 32 bits.

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

10:21 AM Changeset in webkit [257855] by Chris Dumez

• 3 edits in trunk/Source/WebKit

Drop WebsiteDataStore::processPools()'s ensureAPoolExists optional parameter and add a ensureProcessPools() method instead
​https://bugs.webkit.org/show_bug.cgi?id=208546

Reviewed by Sam Weinig.

Drop WebsiteDataStore::processPools()'s ensureAPoolExists optional parameter and add a ensureProcessPools()
method instead. This was error-prone and we are a lot of code creating process pools unnecessarily as a
result.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::processPoolForCookieStorageOperations):
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::setMaxStatisticsEntries):
(WebKit::WebsiteDataStore::setPruneEntriesDownTo):
(WebKit::WebsiteDataStore::setGrandfatheringTime):
(WebKit::WebsiteDataStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::WebsiteDataStore::dumpResourceLoadStatistics):
(WebKit::WebsiteDataStore::isPrevalentResource):
(WebKit::WebsiteDataStore::isGrandfathered):
(WebKit::WebsiteDataStore::setPrevalentResource):
(WebKit::WebsiteDataStore::setPrevalentResourceForDebugMode):
(WebKit::WebsiteDataStore::isVeryPrevalentResource):
(WebKit::WebsiteDataStore::setVeryPrevalentResource):
(WebKit::WebsiteDataStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebsiteDataStore::setSubframeUnderTopFrameDomain):
(WebKit::WebsiteDataStore::isRegisteredAsSubFrameUnder):
(WebKit::WebsiteDataStore::setSubresourceUnderTopFrameDomain):
(WebKit::WebsiteDataStore::isRegisteredAsSubresourceUnder):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectTo):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectTo):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebsiteDataStore::isRegisteredAsRedirectingTo):
(WebKit::WebsiteDataStore::clearPrevalentResource):
(WebKit::WebsiteDataStore::resetParametersToDefaultValues):
(WebKit::WebsiteDataStore::submitTelemetry):
(WebKit::WebsiteDataStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):
(WebKit::WebsiteDataStore::scheduleCookieBlockingUpdate):
(WebKit::WebsiteDataStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebsiteDataStore::setLastSeen):
(WebKit::WebsiteDataStore::mergeStatisticForTesting):
(WebKit::WebsiteDataStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebsiteDataStore::setIsRunningResourceLoadStatisticsTest):
(WebKit::WebsiteDataStore::setNotifyPagesWhenTelemetryWasCaptured):
(WebKit::WebsiteDataStore::setTimeToLiveUserInteraction):
(WebKit::WebsiteDataStore::logUserInteraction):
(WebKit::WebsiteDataStore::hasHadUserInteraction):
(WebKit::WebsiteDataStore::isRelationshipOnlyInDatabaseOnce):
(WebKit::WebsiteDataStore::clearUserInteraction):
(WebKit::WebsiteDataStore::setGrandfathered):
(WebKit::WebsiteDataStore::setUseITPDatabase):
(WebKit::WebsiteDataStore::setCrossSiteLoadWithLinkDecorationForTesting):
(WebKit::WebsiteDataStore::resetCrossSiteLoadsWithLinkDecorationForTesting):
(WebKit::WebsiteDataStore::deleteCookiesForTesting):
(WebKit::WebsiteDataStore::hasLocalStorageForTesting const):
(WebKit::WebsiteDataStore::hasIsolatedSessionForTesting const):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldDowngradeReferrerForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldBlockThirdPartyCookiesForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsFirstPartyWebsiteDataRemovalModeForTesting):
(WebKit::WebsiteDataStore::setCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::resetCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::processPools const):
(WebKit::WebsiteDataStore::ensureProcessPools const):
(WebKit::WebsiteDataStore::plugins const):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
(WebKit::WebsiteDataStore::setStatisticsTestingCallback):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebsiteDataStore::isResourceLoadStatisticsEphemeral const):
(WebKit::WebsiteDataStore::clearResourceLoadStatisticsInWebProcesses):
(WebKit::WebsiteDataStore::getLocalStorageDetails):
(WebKit::WebsiteDataStore::resetQuota):
(WebKit::WebsiteDataStore::hasAppBoundSession const):
(WebKit::WebsiteDataStore::setInAppBrowserPrivacyEnabled):

• UIProcess/WebsiteData/WebsiteDataStore.h:

10:07 AM Changeset in webkit [257854] by dbates@webkit.org

• 2 edits in trunk/Tools

Should use -bounds instead of -frame in RequestTextInputContext.mm tests
​https://bugs.webkit.org/show_bug.cgi?id=208565

Reviewed by Wenson Hsieh.

Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
of its frame as a means to find all the editable elements in the visible content area
of the web view.

Coincidentally this makes no difference to the test results right now because the web view
happens to be located at the origin (0, 0) in the window. However if in the future the
web view would be located at some other point then the tests may fail because the rectangle
passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
rectangle for the visible content area.

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:

(TEST):

10:06 AM Changeset in webkit [257853] by dbates@webkit.org

• 2 edits in trunk/Tools

Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
​https://bugs.webkit.org/show_bug.cgi?id=208564

Reviewed by Alex Christensen.

Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
to make it easy to run just these tests.

Currently, the tests are organized under the test case name WebKit. This means you need to
pass run-api-tests the name of each sub-test as there is no easy way to run them all without
also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
so that a person can run just these test using:

run-api-tests --debug TestWebKitAPI.RequestTextInputContext

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:

(TEST):

10:05 AM Changeset in webkit [257852] by dbates@webkit.org

• 4 edits in trunk/Source/WebKit

Implement WKTextSelectionRect in terms of WebCore::SelectionRect and WKTextRange in terms of WKTextSelectionRect
​https://bugs.webkit.org/show_bug.cgi?id=208563

Reviewed by Alex Christensen.

It is a layering violation that WebKit2 includes a header from WebKit. Implement
WKTextSelectionRect in terms of WebCore::SelectionRect as a step towards fixing this.
Also avoid the WebCore::SelectionRect -> WebSelectionRect -> WKTextSelectionRect
dance that WKTextRange does so that -[WKTextRange selectionRectsForRange] returns
an array of WKTextSelectionRects by writing WKTextRange in terms of NSArray<WKTextSelectionRect *>*.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _uiTextSelectionRects]):
(-[WKContentView selectedTextRange]):
(-[WKContentView selectionRectsForRange:]):

• UIProcess/ios/WKTextSelectionRect.h:
• UIProcess/ios/WKTextSelectionRect.mm:

(-[WKTextSelectionRect initWithSelectionRect:]):
(-[WKTextSelectionRect rect]):
(-[WKTextSelectionRect writingDirection]):
(-[WKTextSelectionRect containsStart]):
(-[WKTextSelectionRect containsEnd]):
(-[WKTextSelectionRect isVertical]):
(-[WKTextSelectionRect initWithWebRect:]): Deleted.
(-[WKTextSelectionRect dealloc]): Deleted.
(+[WKTextSelectionRect textSelectionRectsWithWebRects:]): Deleted.

10:04 AM Changeset in webkit [257851] by dbates@webkit.org

• 4 edits
  2 adds in trunk/Source/WebKit

Move WKTextSelectionRect into its own file
​https://bugs.webkit.org/show_bug.cgi?id=208561

Reviewed by Alex Christensen.

WKTextSelectionRect is currently defined in WKContentViewInteraction.mm. Separate it
out into its own file to improve project organization and de-clutter WKContentViewInteraction.mm.

• SourcesCocoa.txt:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKTextSelectionRect initWithWebRect:]): Deleted.
(-[WKTextSelectionRect dealloc]): Deleted.
(+[WKTextSelectionRect textSelectionRectsWithWebRects:]): Deleted.
(-[WKTextSelectionRect rect]): Deleted.
(-[WKTextSelectionRect writingDirection]): Deleted.
(-[WKTextSelectionRect range]): Deleted.
(-[WKTextSelectionRect containsStart]): Deleted.
(-[WKTextSelectionRect containsEnd]): Deleted.
(-[WKTextSelectionRect isVertical]): Deleted.

• UIProcess/ios/WKTextSelectionRect.h: Added.
• UIProcess/ios/WKTextSelectionRect.mm: Added.

(-[WKTextSelectionRect initWithWebRect:]):
(-[WKTextSelectionRect dealloc]):
(+[WKTextSelectionRect textSelectionRectsWithWebRects:]):
(-[WKTextSelectionRect rect]):
(-[WKTextSelectionRect writingDirection]):
(-[WKTextSelectionRect range]):
(-[WKTextSelectionRect containsStart]):
(-[WKTextSelectionRect containsEnd]):
(-[WKTextSelectionRect isVertical]):

• WebKit.xcodeproj/project.pbxproj:

9:55 AM Changeset in webkit [257850] by Alan Bujtas

• 3 edits in trunk/LayoutTests

Unreviewed test gardening after r257764.

• TestExpectations:
• platform/win/TestExpectations:

9:53 AM Changeset in webkit [257849] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

REGRESSION (r257840?) [ Mac wk2 Release ] fast/hidpi/image-srcset-relative-svg-canvas.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=208577

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:40 AM Changeset in webkit [257848] by aakash_jain@apple.com

• 4 edits in trunk/Tools

[ews] Add build step to create local git commit for commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=208539

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(CreateLocalGITCommit): Build step to create local git commit.
(CreateLocalGITCommit.start):
(CreateLocalGITCommit.getResultSummary): Set custom failure message.

• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
• BuildSlaveSupport/ews-build/factories.py:

8:53 AM Changeset in webkit [257847] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ Mac ] mathml/scripts-removeChild.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=208574

Unreviewed test gardening.

• platform/mac/TestExpectations:

8:34 AM Changeset in webkit [257846] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Avoid full style resolution on Element::focus()
​https://bugs.webkit.org/show_bug.cgi?id=208504
<rdar://problem/60035288>

Unreviewed followup.

• dom/Element.cpp:

(WebCore::Element::resolveComputedStyle):
(WebCore::Element::isVisibleWithoutResolvingFullStyle const):

Emilio spotted that this neeeds to be a composed ancestor walk to match resolveComputedStyle.

8:31 AM Changeset in webkit [257845] by youenn@apple.com

• 4 edits in trunk/Source/WebKit

WebChromeClient::createImageBuffer should not create a connection to GPU Process if page does not want remote rendering
​https://bugs.webkit.org/show_bug.cgi?id=208567
rdar://problem/60020229

Reviewed by Wenson Hsieh.

Manually tested.

• WebProcess/GPU/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::createImageBuffer):
Minor refactoring to directly take a ShouldAccelerate instead of a RenderingMode.

• WebProcess/GPU/graphics/RemoteRenderingBackend.h:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createImageBuffer const):
In case page does not want to do remote rendering, do not create a remote image buffer.
Instead, return null and let the caller create a local image buffer.

8:17 AM Changeset in webkit [257844] by Simon Fraser

• 11 edits in trunk

(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=207948

Reviewed by Zalan Bujtas.

Source/WebCore:

It was possible for WheelEventTestMonitor to fire the callback before receiving any wheel events, if
no deferral reasons happened before the timer fires. Let's require at least one deferral.

There was no deferral for main-thread iframe wheel event handling, so add that so that tests that
slow-scroll iframes work.

Should de-flake fast/scrolling/programmatic-scroll-to-zero-zero.html and maybe other tests.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

• page/WheelEventTestMonitor.cpp:

(WebCore::WheelEventTestMonitor::clearAllTestDeferrals):
(WebCore::WheelEventTestMonitor::deferForReason):
(WebCore::WheelEventTestMonitor::triggerTestTimerFired):
(WebCore::operator<<):

• page/WheelEventTestMonitor.h:

(WebCore::WheelEventTestMonitorCompletionDeferrer::WheelEventTestMonitorCompletionDeferrer):
(WebCore::WheelEventTestMonitorCompletionDeferrer::~WheelEventTestMonitorCompletionDeferrer):

Tools:

EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
so that it receives the wheel events.

• DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):

• DumpRenderTree/win/EventSender.cpp:

(mouseScrollBy):

LayoutTests:

Remove line for fast/scrolling/programmatic-scroll-to-zero-zero.html.
Skip two Windows tests that, for unknown reasons, no longer get any scrolling
triggers.

• platform/mac-wk2/TestExpectations:
• platform/win/TestExpectations:

8:15 AM Changeset in webkit [257843] by Kocsen Chung

• 1 edit in branches/safari-610.1.6-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.h

Apply Patch. rdar://problem/60019706.

7:52 AM Changeset in webkit [257842] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ iOS ] webrtc/video-replace-track.html has been flaky failing on iOS
​https://bugs.webkit.org/show_bug.cgi?id=208573

Unreviewed test gardening

• platform/ios-wk2/TestExpectations:

7:19 AM Changeset in webkit [257841] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][IFC] Display::Run::TextContent::expand(unsigned) is called with the value of -1.
​https://bugs.webkit.org/show_bug.cgi?id=208558
<rdar://problem/60026658>

Reviewed by Antti Koivisto.

• layout/displaytree/DisplayRun.h:

(WebCore::Display::Run::TextContent::shrink):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::Run::removeTrailingWhitespace):

6:53 AM Changeset in webkit [257840] by Alan Bujtas

• 19 edits in trunk

[First paint] Going from visually empty to non-empty should immediately trigger layer unfreezing
​https://bugs.webkit.org/show_bug.cgi?id=208385
<rdar://problem/59895900>

Reviewed by Antti Koivisto.
Source/WebCore:

Now that VNE check and layout are decoupled, we should also decouple the VNE layout milestone and
layer unfreezing.
In many cases a style change does not initiate synchronous layout (see Document::updateStyleIfNeeded) which
potentially delays the first paint. This patch ensure that we unfreeze the layer tree and issue paint soon after
the style change produced a VNE content.

• loader/EmptyFrameLoaderClient.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::didReachVisuallyNonEmptyState):

• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• page/FrameView.cpp:

(WebCore::FrameView::styleAndRenderTreeDidChange):
(WebCore::FrameView::checkAndDispatchDidReachVisuallyNonEmptyState):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const): Deleted.

• page/FrameView.h:

Source/WebKit:

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
(WebKit::WebFrameLoaderClient::dispatchDidReachVisuallyNonEmptyState):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCompletePageTransition):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::resetIdempotentTextAutosizingIfNeeded): We don't have this case anymore.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scheduleRenderingUpdate):

LayoutTests:

• fast/scrolling/scroll-animator-overlay-scrollbars-clicked-expected.txt:
• fast/scrolling/scroll-animator-overlay-scrollbars-clicked.html:
• fast/scrolling/scroll-animator-overlay-scrollbars-hovered-expected.txt:
• fast/scrolling/scroll-animator-overlay-scrollbars-hovered.html:

4:11 AM Changeset in webkit [257839] by Antti Koivisto

• 15 edits
  2 adds in trunk

Avoid full style resolution on Element::focus()
​https://bugs.webkit.org/show_bug.cgi?id=208504

Reviewed by Zalan Bujtas.

Source/WebCore:

Element::focus() currently triggers full style resolution both before (to compute element visibility)
and after (for no particular reason).

Resolving style can be costly if there are further DOM mutations that end up invalidating it again.
This patch adds a cheaper single-element way to computing visibility and uses it for focus().

This appears to be 3-4% Speedometer progression.

Test: fast/forms/focus-after-visibility-change.html

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):

AX code assumes renderers have exist for focused element so ensure style is up to date.

• dom/Document.cpp:

(WebCore::Document::setFocusedElement):

Remove style resolution.

• dom/Element.cpp:

(WebCore::Element::isFocusable const):

Use isVisibleWithoutResolvingFullStyle helper.

(WebCore::Element::focus):

Avoid style resolution if the element is in a subtree that doesn't have renderers yet.

(WebCore::Element::resolveComputedStyle):

Add a mode where we bail out when we figure out we are in display:none subtree.

(WebCore::Element::hasValidStyle const):

See if we already have valid style.

(WebCore::Element::isVisibleWithoutResolvingFullStyle const):

Use computed style mechanism for subtrees that have no renderers yet.

(WebCore::Element::computedStyle):

• dom/Element.h:
• html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::isFocusable const):

Use isVisibleWithoutResolvingFullStyle here too.

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):

Update style after explicit focus() calls to keep the existing behavior.

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setRangeText):

Ensure the renderer is created.

• html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::forwardEvent):

Remove unneeded renderer test.

LayoutTests:

• fast/events/keypress-removed-node-expected.txt:
• fast/events/keypress-removed-node.html:

Modify the test so it is not sensitive to non-rendered whitespace changes
(caused by timing of render tree updates).

• fast/forms/autofocus-input-css-style-change.html:

Read the <input autofocus> :focus style in rAF as focusing happens asynchronously. This matches other browsers.

• fast/forms/focus-after-visibility-change-expected.txt: Added.
• fast/forms/focus-after-visibility-change.html: Added.

Add a simple test for visibility style change after renderer has already be created.

3:47 AM Changeset in webkit [257838] by Andres Gonzalez

• 2 edits in trunk/Tools

REGRESSION (r257739): two fast/events/autoscroll test have started to fail
​https://bugs.webkit.org/show_bug.cgi?id=208520
<rdar://problem/60000214>

Reviewed by Chris Fleizach.

Calling InjectedBundle::singleton().page()->page() in the constructor
of the AccessibilityController is having this side effect on iOS.
So #if to MAC where it's actually being used.

• WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::AccessibilityController):

12:56 AM Changeset in webkit [257837] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebCore

[GTK][WPE] Use restore view icon for exit fullscreen button in media controls
​https://bugs.webkit.org/show_bug.cgi?id=208511

Reviewed by Xabier Rodriguez-Calvar.

We currently use view fullscreen for both entering and leaving.

• Modules/mediacontrols/mediaControlsAdwaita.css:

(video::-webkit-media-controls-fullscreen-button.exit):
(audio::-webkit-media-controls-fullscreen-button,): Deleted.
(audio::-webkit-media-controls-fullscreen-button.hidden,): Deleted.

• Modules/mediacontrols/mediaControlsAdwaita.js:

(Controller.prototype.handleFullscreenChange):

12:54 AM Changeset in webkit [257836] by Carlos Garcia Campos

• 4 edits in trunk

[GTK][WPE] Stop adding volume-box class to volume box element
​https://bugs.webkit.org/show_bug.cgi?id=208510

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The class was removed in r257705 because it's not used by our css.

• Modules/mediacontrols/mediaControlsAdwaita.js:

(Controller.prototype.createControls):

LayoutTests:

Update expectations of http/tests/media/hls/video-controls-live-stream.html.

• platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt:

Mar 3, 2020:

10:31 PM Changeset in webkit [257835] by Devin Rousso

• 38 edits in trunk/Source

Web Inspector: re-add InspectorFrontendHost support for moving the inspected window
​https://bugs.webkit.org/show_bug.cgi?id=208555

Reviewed by Timothy Hatcher.

Partially revert r257759, as the design changed enough such that this code is still useful.

Source/WebCore:

Allow the Web Inspector frontend to ask the containing app (via InspectorFrontendClient)
whether it supports the given docking configuration.

• inspector/InspectorFrontendHost.idl:
• inspector/InspectorFrontendHost.h:
• inspector/InspectorFrontendHost.cpp:

(WebCore::dockSideFromString): Added.
(WebCore::InspectorFrontendHost::supportsDockSide): Added.
(WebCore::InspectorFrontendHost::requestSetDockSide):
(WebCore::InspectorFrontendHost::startWindowDrag): Added.
(WebCore::InspectorFrontendHost::moveWindowBy const): Added.

• inspector/InspectorFrontendClient.h:

• inspector/InspectorFrontendClientLocal.cpp:
• inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::moveWindowBy): Added.

• testing/Internals.cpp:

(WebCore::InspectorStubFrontend::supportsDockSide): Added.

Source/WebInspectorUI:

• UserInterface/Base/Main.js:

(WI.loaded):
(WI.updateDockedState):
(WI.resizeDockedFrameMouseDown): Added.
(WI.moveUndockedWindowMouseDown): Added.
(WI.dockedConfigurationSupportsSplitContentBrowser):
(WI._windowFocused):
(WI._windowBlurred):
(WI._updateDockNavigationItems):
(WI._handleDockedResizerMouseDown):
(WI._handleUndockedTitleAreaMouseDown):
(WI._updateTabBarDividers):
(WI.setLayoutDirection):
Don't create tab bar navigation items for the various docking configurations if the platform
doesn't support that particular configuration.

• UserInterface/Views/TabBar.js:

(WI.TabBar):
(WI.TabBar.get horizontalPadding):
(WI.TabBar.prototype._handleMouseDown):
(WI.TabBar.prototype._handleTabContainerMouseDown): Added.
(WI.TabBar.prototype._handleTabContainerClick): Added.
(WI.TabBar.prototype._handleTabContainerMouseLeave): Added.
(WI.TabBar.prototype._handleTabContainerContextMenu): Added.
(WI.TabBar.prototype._handleClick): Deleted.
(WI.TabBar.prototype._handleMouseLeave): Deleted.
(WI.TabBar.prototype._handleContextMenu): Deleted.

• UserInterface/Views/TabBar.css:

(body.docked.bottom .tab-bar > .tabs > .flexible-space):
Dragging on empty space in the tab bar should adjust Web Inspector's bottom docked height.

• UserInterface/Views/TabBarItem.js:

(WI.TabBarItem.get horizontalMargin):

Source/WebKit:

Allow the Web Inspector frontend to ask the containing app (via InspectorFrontendClient)
whether it supports the given docking configuration.

• WebProcess/Inspector/WebInspectorUI.h:
• WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::startWindowDrag): Added.
(WebKit::WebInspectorUI::moveWindowBy): Added.
(WebKit::WebInspectorUI::supportsDockSide): Added.
(WebKit::WebInspectorUI::requestSetDockSide):
(WebKit::WebInspectorUI::setDockSide):

• UIProcess/Inspector/WebInspectorProxy.messages.in:
• UIProcess/Inspector/WebInspectorProxy.h:
• UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::startWindowDrag): Added.
(WebKit::WebInspectorProxy::platformStartWindowDrag): Added.

• UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformStartWindowDrag): Added.

• UIProcess/Inspector/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformStartWindowDrag): Added.

• UIProcess/Inspector/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformStartWindowDrag): Added.

• WebProcess/Inspector/RemoteWebInspectorUI.h:
• WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::startWindowDrag): Added.
(WebKit::RemoteWebInspectorUI::moveWindowBy): Added.
(WebKit::RemoteWebInspectorUI::supportsDockSide): Added.

• UIProcess/Inspector/RemoteWebInspectorProxy.messages.in:
• UIProcess/Inspector/RemoteWebInspectorProxy.h:
• UIProcess/Inspector/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::startWindowDrag): Added.
(WebKit::RemoteWebInspectorProxy::platformStartWindowDrag): Added.

• UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp:

(WebKit::RemoteWebInspectorProxy::platformStartWindowDrag): Added.

• UIProcess/Inspector/mac/RemoteWebInspectorProxyMac.mm:

(WebKit::RemoteWebInspectorProxy::platformStartWindowDrag): Added.

• UIProcess/Inspector/win/RemoteWebInspectorProxyWin.cpp:

(WebKit::RemoteWebInspectorProxy::platformStartWindowDrag): Added.

Source/WebKitLegacy/ios:

Allow the Web Inspector frontend to ask the containing app (via InspectorFrontendClient)
whether it supports the given docking configuration.

• WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorFrontendClient::supportsDockSide): Added.
(WebInspectorFrontendClient::startWindowDrag): Added.

Source/WebKitLegacy/mac:

Allow the Web Inspector frontend to ask the containing app (via InspectorFrontendClient)
whether it supports the given docking configuration.

• WebCoreSupport/WebInspectorClient.h:
• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::startWindowDrag): Added.
(WebInspectorFrontendClient::supportsDockSide): Added.

Source/WebKitLegacy/win:

Allow the Web Inspector frontend to ask the containing app (via InspectorFrontendClient)
whether it supports the given docking configuration.

• WebCoreSupport/WebInspectorClient.h:
• WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::supportsDockSide): Added.

10:03 PM Changeset in webkit [257834] by achristensen@apple.com

• 8 edits in trunk

Add SPI _WKResourceLoadInfo.loadedFromCache
​https://bugs.webkit.org/show_bug.cgi?id=208554

Reviewed by Wenson Hsieh.

Source/WebKit:

This exposes a boolean value indicating whether the resource was loaded from a cache based on the response source.
This is needed for rdar://problem/57132290

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::resourceLoadInfo):

• Shared/ResourceLoadInfo.h:

(WebKit::ResourceLoadInfo::encode const):
(WebKit::ResourceLoadInfo::decode):

• UIProcess/API/APIResourceLoadInfo.h:
• UIProcess/API/Cocoa/_WKResourceLoadInfo.h:
• UIProcess/API/Cocoa/_WKResourceLoadInfo.mm:

(-[_WKResourceLoadInfo loadedFromCache]):
(-[_WKResourceLoadInfo initWithCoder:]):
(-[_WKResourceLoadInfo encodeWithCoder:]):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:

(TEST):

9:40 PM Changeset in webkit [257833] by Devin Rousso

• 2 edits in trunk/Source/WebCore

Web Inspector: set both the page's and the window's appearance when modifying the frontend forced appearance in the case that the frontend is docked
​https://bugs.webkit.org/show_bug.cgi?id=208557

Reviewed by Timothy Hatcher.

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setForcedAppearance):
InspectorFrontendClient::setForcedAppearance only has an effect when Web Inspector is
detached/undocked, meaning that changing the Appearance in the Settings Tab when docked has
no effect. In addition to notifying the InspectorFrontendClient, we should also call
Page::setUseDarkAppearanceOverride so that if Web Inspector is docked, the apperance
changes. The Web Inspector frontend page's apperance would normally change to match the
appearance of the window, but when Web Inspector is docked there is no window.

9:33 PM Changeset in webkit [257832] by Kocsen Chung

• 2 edits in branches/safari-609.1.20.4-branch/Source/WebKitLegacy/win

Cherry-pick r257802. rdar://problem/60009752

[Win] API header file has USE macro
​https://bugs.webkit.org/show_bug.cgi?id=208534

Reviewed by Brent Fulgham.

USE macros should not be used in API header files.

• WebKitCOMAPI.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:30 PM Changeset in webkit [257831] by Kocsen Chung

• 8 edits in branches/safari-609.1.20.4-branch/Source

Versioning.

9:22 PM Changeset in webkit [257830] by rniwa@webkit.org

• 17 edits in trunk

Batch observations and completions of text manipulations
​https://bugs.webkit.org/show_bug.cgi?id=208406

Reviewed by Wenson Hsieh.

Source/WebCore:

This patch updates TextManipulationController to notify and replace multiple paragraphs at once.

To allow some form of parallelism for the client application to process items while WebContent's main thread
is finding paragraphs, we notify the client every 128 items.

Tests: TestWebKitAPI.TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback: Added.

TestWebKitAPI.TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph: Added.
TestWebKitAPI.TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce: Added.
TestWebKitAPI.TextManipulation.CompleteTextManipulationShouldBatchItemCallback: Added.
TestWebKitAPI.TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated: Added.
TestWebKitAPI.TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail: Added.

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::startObservingParagraphs):
(WebCore::TextManipulationController::scheduleObservartionUpdate):
(WebCore::TextManipulationController::addItem): Added.
(WebCore::TextManipulationController::flushPendingItemsForCallback): Added.
(WebCore::TextManipulationController::completeManipulation): Apply each ManipulationItem changes and return
an array for ManipulationFailure for those that failed.
(WebCore::TextManipulationController::replace):

• editing/TextManipulationController.h:

(WebCore::TextManipulationController::ManipulationItem): Added.
(WebCore::TextManipulationController::ManipulationFailureType): Renamed from ManipulationResult.
(WebCore::TextManipulationController::ManipulationFailure): Added.
(WebCore::TextManipulationController::ManipulationItemData): Renamed from ManipulationItem.
(WebCore::TextManipulationController::ManipulationItem::encode const): Added.
(WebCore::TextManipulationController::ManipulationItem::decode): Added.
(WebCore::TextManipulationController::ManipulationFailure::encode const): Added.
(WebCore::TextManipulationController::ManipulationFailure::decode): Added.

Source/WebKit:

Update WKWebView's SPI for text manipulations to batch observations and replacements of multiple paragraphs
at once instead of observing and replacing one paragraph at a time.

_WKTextManipulationDelegate now has a new callback, didFindTextManipulationItems, which gets an array of
_WKTextManipulationItem instead of a single _WKTextManipulationItem like didFindTextManipulationItem,
and WKWebView's _completeTextManipulationForItems replaces multiple paragraphs at once, and gives an array
of NSError for each _WKTextManipulationItem that failed to replace the respective content.

Tests: TestWebKitAPI.TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback: Added.

TestWebKitAPI.TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph: Added.
TestWebKitAPI.TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce: Added.
TestWebKitAPI.TextManipulation.CompleteTextManipulationShouldBatchItemCallback: Added.
TestWebKitAPI.TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated: Added.
TestWebKitAPI.TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail: Added.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _startTextManipulationsWithConfiguration:completion:]):
(coreTextManipulationItemIdentifierFromString): Added.
(coreTextManipulationTokenIdentifierFromString): Added.
(-[WKWebView _completeTextManipulation:completion:]): Updated to work with the new TextManipulationController
interface.
(makeFailureSetForAllTextManipulationItems): Added.
(wkTextManipulationErrors): Added.
(-[WKWebView _completeTextManipulationForItems:completion:]): Added. This is the new SPI.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/Cocoa/_WKTextManipulationDelegate.h:
• UIProcess/API/Cocoa/_WKTextManipulationItem.h:

(_WKTextManipulationItemErrorDomain): Added.
(_WKTextManipulationItemErrorCode): Added.
(_WKTextManipulationItemErrorItemKey): Added.

• UIProcess/API/Cocoa/_WKTextManipulationItem.mm:
• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::startTextManipulations):
(WebKit::WebPage::completeTextManipulation): Updated per TextManipulationController interface change.
To avoid having to duplicate the code to create a vector of ManipulationFailure, this function's completion
handler has a boolean indicating that all replacements had failed.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Tools:

Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
multiple paragraphs at once.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
(-[TextManipulationDelegate items]):
(-[LegacyTextManipulationDelegate init]):
(-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
(TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
(TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
(TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
(TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
(TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
(TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.

9:18 PM Changeset in webkit [257829] by Kocsen Chung

• 5 edits in branches/safari-610.1.6-branch/Source

Cherry-pick r257779. rdar://problem/60019706

Rename USE(GPU_PROCESS) to ENABLE(GPU_PROCESS_FOR_WEBRTC)
​https://bugs.webkit.org/show_bug.cgi?id=208505

Reviewed by Eric Carlson.

Source/WebKit:

• Shared/WebPreferencesDefaultValues.h:

Source/WTF:

Rename macro since the name is misleading.
Disable GPU_PROCESS_FOR_WEBRTC for iOS except simulator for now.

• wtf/PlatformEnable.h:
• wtf/PlatformEnableCocoa.h:
• wtf/PlatformUse.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:13 PM Changeset in webkit [257828] by pvollan@apple.com

• 14 edits
  1 add in trunk

[Cocoa] Mapping from MIME type to UTI type should be done in the UI process
​https://bugs.webkit.org/show_bug.cgi?id=208415

Reviewed by Brent Fulgham.

Source/WebCore:

This is currently done in the WebContent process, but since this is using a system service which will be closed,
this mapping should be moved to the UI process. The UI process will create this mapping for a set of mime types,
and send it to the WebContent process.

API test: WebKit.UTIFromMIMEType

• platform/network/mac/UTIUtilities.h:
• platform/network/mac/UTIUtilities.mm:

(WebCore::mapUTIFromMIMEType):
(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::cacheUTIFromMimeType):
(WebCore::UTIFromMIMEType):
(WebCore::mimeTypes):
(WebCore::createUTIFromMIMETypeMap):
(WebCore::setUTIFromMIMETypeMap):

• testing/Internals.cpp:

(WebCore::Internals::getUTIFromMIMEType):

• testing/Internals.mm:

(WebCore::Internals::getUTIFromMIMEType):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

Send the mapping between MIME types and UTI types to the WebContent process as part of the Web
process creation parameters.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.

(TEST):

9:00 PM Changeset in webkit [257827] by Kocsen Chung

• 2 edits in branches/safari-610.1.6-branch/Source/WebCore

Cherry-pick r257783. rdar://problem/60024770

Regression (CookieCache) Unable to log into Hulu.com
​https://bugs.webkit.org/show_bug.cgi?id=208517
<rdar://problem/59973630>

Reviewed by Geoffrey Garen.

Even though we are listening for notifications for 'www.hulu.com', CFNetwork sends us a notification for host
'secure.hulu.com' when a load to secure.hulu.com sets a cookie for domain '.hulu.com'. Because the host did
not match one if our map of observers, we would ignore the cookie notification and our cookie cache would get
out of sync. To temporarily address the issue (until a better fix is made, likely on CFNetwork side), WebKit
now matches registrable domains instead of hosts.

• platform/network/cocoa/NetworkStorageSessionCocoa.mm: (WebCore::NetworkStorageSession::registerCookieChangeListenersIfNecessary):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:00 PM Changeset in webkit [257826] by Kocsen Chung

• 2 edits in branches/safari-610.1.6-branch/Source/WebCore

Cherry-pick r257776. rdar://problem/60024732

Regression(r257354) Crash when trying on watch video on apple.com
​https://bugs.webkit.org/show_bug.cgi?id=208487
<rdar://problem/59967385>

Reviewed by Eric Carlson.

Use WebCore::Cookie's code to convert to a NSHTTPCookie instead of using toNSHTTPCookie()
which was not quite right, especially after r257354.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): (WebCore::toNSHTTPCookie): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:00 PM Changeset in webkit [257825] by Kocsen Chung

• 7 edits
  1 add in branches/safari-610.1.6-branch

Cherry-pick r257728. rdar://problem/60024647

Delete by val caching does not keep the subscript alive
​https://bugs.webkit.org/show_bug.cgi?id=208393

Reviewed by Yusuke Suzuki.

JSTests:

• stress/delete-property-ic-stress.js: Added.

Source/JavaScriptCore:

Before, the provided test case crashed with asan because we did not keep deleteByVal
subscripts alive. This patch changes CacheableIdentifier to make this mistake harder
to make again, by making the constructor calls more explicit when CacheableIdentifier
will not keep an Identifier alive.

• jit/JITOperations.cpp:
• jit/Repatch.cpp: (JSC::tryCachePutByID): (JSC::tryCacheDeleteBy): (JSC::repatchDeleteBy): (JSC::tryCacheInByID): (JSC::tryCacheInstanceOf): (JSC::tryCacheDelBy): Deleted. (JSC::repatchDelBy): Deleted.
• jit/Repatch.h:
• runtime/CacheableIdentifier.h:
• runtime/CacheableIdentifierInlines.h: (JSC::CacheableIdentifier::createFromIdentifierOwnedByCodeBlock): (JSC::CacheableIdentifier::createFromCell):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:00 PM Changeset in webkit [257824] by Kocsen Chung

• 4 edits in branches/safari-610.1.6-branch

Cherry-pick r257716. rdar://problem/60019586

maps.google.com is not loading properly, screen flickers when zooming
​https://bugs.webkit.org/show_bug.cgi?id=208331
<rdar://problem/59790757>

Reviewed by Antoine Quint.

Source/WebCore:

When using ANGLE, we don't need the GL_ANGLE_depth_texture extension.
We were mistakenly checking for it and deciding to not allow
combined depth+stencil framebuffer attachments.

Test: webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
(now passes on iOS)

• html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::setupFlags):

LayoutTests:

• platform/ios/TestExpectations: remove failing expectation for: webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:00 PM Changeset in webkit [257823] by Kocsen Chung

• 2 edits in branches/safari-610.1.6-branch/Source/WebKitLegacy/win

Cherry-pick r257684. rdar://problem/60019893

Fix the Windows build after r257645.

• WebView.cpp: (WebView::setAcceleratedCompositing):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:57 PM Changeset in webkit [257822] by rniwa@webkit.org

• 1 edit in trunk/LayoutTests/ChangeLog

Fix a typo in the previous commit.

8:48 PM Changeset in webkit [257821] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

REGRESSION(iOS): editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html is always timing out
​https://bugs.webkit.org/show_bug.cgi?id=208556

Reviewed by Wenson Hsieh.

Wait for the dobule tap delay between the initial tap and the second tap on the editable region
so that the second tap would result in a selection change instead of both taps to be recognized
as a single dobule tap.

• editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html:

7:49 PM Changeset in webkit [257820] by Wenson Hsieh

• 5 edits in trunk/Source/WebCore

Path::m_path should be a RetainPtr<CGMutablePathRef> on platforms that use CoreGraphics
​https://bugs.webkit.org/show_bug.cgi?id=208492

Reviewed by Simon Fraser and Said Abou-Hallawa.

Make m_path a RetainPtr<CGMutablePathRef> on platforms that use CoreGraphics. This allows us to remove all the
manual retaining and releasing on m_path that currently resides in PathCG.cpp. See below for more details.
There should be no change in behavior.

• platform/graphics/Path.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

Add adoptCF when constructing the WebCore::Path from the newly created CGMutablePathRef.

(WebCore::PlatformCALayerCocoa::shapePath const):

• platform/graphics/cg/PathCG.cpp:

(WebCore::Path::Path):

Instead of taking a RetainPtr<CGMutablePathRef> and leaking the pointer, change this to take an rvalue reference
and WTFMove it directly into m_path.

(WebCore::Path::ensurePlatformPath):
(WebCore::Path::contains const):
(WebCore::Path::transform):
(WebCore::Path::boundingRect const):
(WebCore::Path::fastBoundingRect const):
(WebCore::Path::addPath):
(WebCore::Path::clear):
(WebCore::Path::isEmpty const):
(WebCore::Path::currentPoint const):
(WebCore::Path::apply const):

Change m_path to m_path.get() and add adoptCFs, as needed. Remove explicit calls to CFRelease and
CFRetain.

(WebCore::Path::~Path): Deleted.

Just use the default destructor, now that there's no longer a need to explicitly call CFRelease on m_path.

• platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformPathForGlyph const):

Since the Path constructor now takes RetainPtr<CGMutablePathRef>&&, use move semantics when creating the new
WebCore::Path from the RetainPtr.

6:35 PM Changeset in webkit [257819] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit

Refine Swift API for WKWebView JavaScript methods
​https://bugs.webkit.org/show_bug.cgi?id=208483

Patch by James Savage <James Savage> on 2020-03-03
Reviewed by Sam Weinig.

Refine these interfaces for Swift and to align with our desired API.

• UIProcess/API/Cocoa/WKContentWorld.h: This doesn't need to be refined

for Swift, we can just rename it here.

• UIProcess/API/Cocoa/WKWebView.h: This does need refinement.

6:34 PM Changeset in webkit [257818] by achristensen@apple.com

• 13 edits in trunk

Add response to _WKResourceLoadDelegate didCompleteWithError callback
​https://bugs.webkit.org/show_bug.cgi?id=208553

Reviewed by Simon Fraser.

Source/WebKit:

New functionality verified by API test.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFailLoading):

• UIProcess/API/APIResourceLoadClient.h:
• UIProcess/API/Cocoa/_WKResourceLoadDelegate.h:
• UIProcess/Cocoa/ResourceLoadDelegate.h:
• UIProcess/Cocoa/ResourceLoadDelegate.mm:

(WebKit::ResourceLoadDelegate::setDelegate):
(WebKit::ResourceLoadDelegate::ResourceLoadClient::didCompleteWithError const):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::resourceLoadDidCompleteWithError):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:

(-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
(TEST):
(-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.

6:28 PM Changeset in webkit [257817] by beidson@apple.com

• 2 edits in trunk/Tools

API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=198795

Reviewed by Chris Dumez.

This test appears to no longer be flaky.

Let's re-enable it.

• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):

5:55 PM Changeset in webkit [257816] by achristensen@apple.com

• 11 edits in trunk

Requests sent to _WKResourceLoadDelegate should include HTTPBody
​https://bugs.webkit.org/show_bug.cgi?id=208550

Reviewed by Tim Hatcher.

Source/WebCore:

Covered by API tests.

• platform/network/FormData.h:

Expose lengthInBytes to be used in a check capping the size of included body data.
This will prevent exteremely large HTTP bodies from being serialized.

Source/WebKit:

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::startNetworkLoad):

• UIProcess/Cocoa/ResourceLoadDelegate.mm:

(WebKit::ResourceLoadDelegate::ResourceLoadClient::didSendRequest const):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::resourceLoadDidSendRequest):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:

(TEST):

• TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::respondToRequests):
HTTPServer now looks for Content-Length in its request.
If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.

4:50 PM Changeset in webkit [257815] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ iOS ] http/tests/navigation/process-swap-on-client-side-redirect-private.html is flaky timing out
​https://bugs.webkit.org/show_bug.cgi?id=208547

Unreviewed test gardening

• platform/ios-wk2/TestExpectations:

4:30 PM Changeset in webkit [257814] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ iOS ] fast/hidpi/filters-and-image-buffer-resolution.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=208543

Unreviewed test gardening

• platform/ios-wk2/TestExpectations:

4:30 PM Changeset in webkit [257813] by commit-queue@webkit.org

• 3 edits in trunk

[Curl] Add TLS debugging feature to log encryption keys
​https://bugs.webkit.org/show_bug.cgi?id=208192
<rdar://problem/59900616>

Patch by Fujii Hironori <​fujii.hironori@gmail.com> on 2020-03-03
Reviewed by Don Olmstead.

• Source/cmake/OptionsPlayStation.cmake:
• Source/cmake/OptionsWin.cmake:

Changed the default ENABLE_TLS_DEBUG to OFF.

4:18 PM Changeset in webkit [257812] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Refactor FixedVMPoolExecutableAllocator to not have member functions which are really just helper functions
​https://bugs.webkit.org/show_bug.cgi?id=208537

Reviewed by Mark Lam.

There were a few member functions in FixedVMPoolExecutableAllocator that were
essentially helper functions. I've factored them out, and made FixedVMPoolExecutableAllocator
call them directly. This refactoring is needed when I implement the 1GB
executable pool on arm64 since the implementation of that will create split
implementations of something like FixedVMPoolExecutableAllocator.

• jit/ExecutableAllocator.cpp:

(JSC::jitWriteThunkGenerator):
(JSC::genericWriteToJITRegion):
(JSC::initializeSeparatedWXHeaps):
(JSC::initializeJITPageReservation):
(JSC::ExecutableAllocator::isValid const):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutableAllocator::memoryPressureMultiplier):
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::isValidExecutableMemory):
(JSC::ExecutableAllocator::getLock const):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::dumpProfile):
(JSC::startOfFixedExecutableMemoryPoolImpl):
(JSC::endOfFixedExecutableMemoryPoolImpl):
(JSC::isJITPC):

4:06 PM Changeset in webkit [257811] by Alan Bujtas

• 6 edits in trunk

[Internals] Introduce Internals::updateLayoutAndStyleRecursively
​https://bugs.webkit.org/show_bug.cgi?id=208536
<rdar://problem/60012372>

Reviewed by Simon Fraser.

Source/WebCore:

It's been a common practice to call document.body.offsetHeight/Width to force style update and layout.
However in certain cases (see Hyatt's optimization on lazy offsetHeight/Width computation in Document::updateLayoutIfDimensionsOutOfDate)
this call can leave the tree partially dirty.

This behavior leads to flakiness, especially when the test checks against Internals::layoutCount.

• testing/Internals.cpp:

(WebCore::Internals::updateLayoutAndStyleRecursively):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• fast/images/animated-gif-no-layout.html:

3:54 PM Changeset in webkit [257810] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: the background of the navigation items in the tab bar doesn't match when unfocusing the window
​https://bugs.webkit.org/show_bug.cgi?id=208538

Reviewed by Timothy Hatcher.

• UserInterface/Views/TabBar.css:

(body[dir=ltr]:not(.docked) .tab-bar > .tabs > .item:nth-child(n + 3 of :not(.hidden)), body[dir=ltr]:not(.docked) .tab-bar > .tabs:not(.hide-border-start) > .item:nth-child(2 of :not(.hidden)), body[dir=ltr]:not(.docked) .tab-bar > .tabs.dragging-tab > .item.selected, body[dir=rtl]:not(.docked) .tab-bar > .tabs:not(.hide-border-end) > .item:nth-last-child(1 of :not(.hidden))): Added.
(body[dir=ltr]:not(.docked) .tab-bar > .tabs:not(.hide-border-end) > .item:nth-last-child(1 of :not(.hidden)), body[dir=rtl]:not(.docked) .tab-bar > .tabs > .item:nth-child(n + 3 of :not(.hidden)), body[dir=rtl]:not(.docked) .tab-bar > .tabs:not(.hide-border-start) > .item:nth-child(2 of :not(.hidden)), body[dir=rtl]:not(.docked) .tab-bar > .tabs.dragging-tab > .item.selected): Added.
(body[dir=ltr]:not(.docked) .tab-bar > .tabs > .item:not(:first-child), body[dir=ltr]:not(.docked) .tab-bar > .tabs:not(.hide-border-start) > .item:first-child, body[dir=ltr]:not(.docked) .tab-bar > .tabs.dragging-tab > .item.selected, body[dir=rtl]:not(.docked) .tab-bar > .tabs:not(.hide-border-end) > .item:last-child): Deleted.
(body[dir=ltr]:not(.docked) .tab-bar > .tabs:not(.hide-border-end) > .item:last-child, body[dir=rtl]:not(.docked) .tab-bar > .tabs > .item:not(:first-child), body[dir=rtl]:not(.docked) .tab-bar > .tabs:not(.hide-border-start) > .item:first-child, body[dir=rtl]:not(.docked) .tab-bar > .tabs.dragging-tab > .item.selected): Deleted.
Use nth-child and nth-last-child instead of :first-child and :last-child now that
there are .flexible-space elements alongside tab bar items.

(@media (prefers-color-scheme: dark) .tab-bar):
(@media (prefers-color-scheme: dark) body:not(.docked) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body.docked .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:not(.docked):matches(.window-inactive, .window-docked-inactive) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:matches(.window-inactive, .window-docked-inactive) .tab-bar): Deleted.
Ensure completely separate styles for background-color and background-image when .docked
vs when :not(.docked) so that they don't "bleed" into eachother.

(body:not(.docked):matches(.window-inactive, .window-docked-inactive) .tab-bar):
(body.docked:matches(.window-inactive, .window-docked-inactive) .tab-bar):
(.tab-bar > .navigation-bar > .item.group > .item):
(.tab-bar > .navigation-bar > .item.group > .item:nth-child(1 of :not(.hidden))):
(.tab-bar > .navigation-bar > .item.group > .item:nth-last-child(1 of :not(.hidden))):
(body:not(.docked):matches(.window-inactive, .window-docked-inactive) .tab-bar > .tabs > .item):
(body:not(.docked):matches(.window-inactive, .window-docked-inactive) .tab-bar > .tabs > .item:not(.disabled).selected):
(.tab-bar > .tabs.static-layout > :matches(.flexible-space, .item)):
(.tab-bar > .tabs.animating.inserting-tab > .item.being-inserted):
(body:not(.docked):matches(.window-inactive, .window-docked-inactive) .tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, body:not(.docked):matches(.window-inactive, .window-docked-inactive) .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), body:not(.docked):matches(.window-inactive, .window-docked-inactive) .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected):
(@media (prefers-color-scheme: dark) body:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected):
(@media (prefers-color-scheme: dark) body:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover):
(@media (prefers-color-scheme: dark) body:not(.docked):matches(.window-inactive, .window-docked-inactive) .tab-bar > .tabs > .item):
(@media (prefers-color-scheme: dark) body:not(.docked):matches(.window-inactive, .window-docked-inactive) .tab-bar > .tabs > .item:not(.disabled).selected):
Drive-by: remove as many !important as possible to make future modification simpler.

3:47 PM Changeset in webkit [257809] by Ross Kirsling

• 2 edits
  2 adds in trunk/Source/JavaScriptCore

Introduce JSRemoteInspectorServerStart API for socket-based RWI.
​https://bugs.webkit.org/show_bug.cgi?id=208349

Reviewed by Joseph Pecoraro.

• API/JSRemoteInspectorServer.cpp: Added.

(JSRemoteInspectorServerStart):

• API/JSRemoteInspectorServer.h: Added.
• CMakeLists.txt:

3:33 PM Changeset in webkit [257808] by Ross Kirsling

• 3 edits in trunk/Source/WebKit

Unreviewed. Fix WinCairo build following r257801.

• UIProcess/Inspector/win/RemoteWebInspectorProxyWin.cpp:

(WebKit::RemoteWebInspectorProxy::platformSetForcedAppearance):

• UIProcess/Inspector/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformSetForcedAppearance):

3:10 PM Changeset in webkit [257807] by Alan Coon

• 1 copy in tags/Safari-610.1.5.2

Tag Safari-610.1.5.2.

3:06 PM Changeset in webkit [257806] by achristensen@apple.com

• 8 edits in trunk

Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
​https://bugs.webkit.org/show_bug.cgi?id=208522

Reviewed by Brian Weinstein.

Source/WebKit:

Covered by API tests.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::resourceLoadInfo):

• Shared/ResourceLoadInfo.h:

(WebKit::ResourceLoadInfo::encode const):
(WebKit::ResourceLoadInfo::decode):

• UIProcess/API/APIResourceLoadInfo.h:
• UIProcess/API/Cocoa/_WKResourceLoadInfo.h:
• UIProcess/API/Cocoa/_WKResourceLoadInfo.mm:

(-[_WKResourceLoadInfo originalURL]):
(-[_WKResourceLoadInfo initWithCoder:]):
(-[_WKResourceLoadInfo encodeWithCoder:]):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:

(TEST):

3:02 PM Changeset in webkit [257805] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[CG] Change the UTI of the "WebP" image to be "com.google.webp"
​https://bugs.webkit.org/show_bug.cgi?id=208038

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-03-03
Reviewed by Simon Fraser.

This is to conform with CGImageSourceGetType().

• platform/graphics/cg/UTIRegistry.cpp:

(WebCore::defaultSupportedImageTypes):
Make sure CG supports the suggested UTI before considering it is actually
supported.

2:49 PM Changeset in webkit [257804] by Alan Coon

• 8 edits in branches/safari-610.1.5-branch/Source

Versioning.

2:20 PM Changeset in webkit [257803] by aakash_jain@apple.com

• 2 edits in trunk/Tools

commit-queue should update working directory and reapply patch just before commiting
​https://bugs.webkit.org/show_bug.cgi?id=208521

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/factories.py:

2:19 PM Changeset in webkit [257802] by pvollan@apple.com

• 2 edits in trunk/Source/WebKitLegacy/win

[Win] API header file has USE macro
​https://bugs.webkit.org/show_bug.cgi?id=208534

Reviewed by Brent Fulgham.

USE macros should not be used in API header files.

• WebKitCOMAPI.h:

2:11 PM Changeset in webkit [257801] by Devin Rousso

• 29 edits in trunk/Source

Web Inspector: setting the frontend appearance doesn't update the window when undocked
​https://bugs.webkit.org/show_bug.cgi?id=208503

Reviewed by Timothy Hatcher.

Notify the UIProcess when setting the forced appearance so platforms that support dark mode
are able to run native code to adjust the appearance of the undocked window.

Source/WebCore:

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setForcedAppearance):
Call through to the InspectorFrontendClient to change the forced appearance.

• inspector/InspectorFrontendClient.h:

(WebCore::InspectorFrontendHost::Appearance): Added.
Add an enum class Appearance so that multiple copies of the same string comparison logic
isn't needed.

• testing/Internals.cpp:

(WebCore::InspectorStubFrontend::setForcedAppearance): Added.

Source/WebKit:

• WebProcess/Inspector/WebInspectorUI.h:
• WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::setForcedAppearance): Added.

• UIProcess/Inspector/WebInspectorProxy.messages.in:
• UIProcess/Inspector/WebInspectorProxy.h:
• UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::setForcedAppearance): Added.
(WebKit::WebInspectorProxy::platformSetForcedAppearance): Added.

• UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformSetForcedAppearance): Added.

• UIProcess/Inspector/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateFrontendWindow): Added.
(WebKit::WebInspectorProxy::platformSetForcedAppearance): Added.
(WebKit::WebInspectorProxy::applyForcedAppearance): Added.

• UIProcess/Inspector/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformSetForcedAppearance): Added.

• WebProcess/Inspector/RemoteWebInspectorUI.h:
• WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::setForcedAppearance): Added.

• UIProcess/Inspector/RemoteWebInspectorProxy.messages.in:
• UIProcess/Inspector/RemoteWebInspectorProxy.h:
• UIProcess/Inspector/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::setForcedAppearance): Added.
(WebKit::RemoteWebInspectorProxy::platformSetForcedAppearance): Added.

• UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp:

(WebKit::RemoteWebInspectorProxy::platformSetForcedAppearance): Added.

• UIProcess/Inspector/mac/RemoteWebInspectorProxyMac.mm:

(WebKit::RemoteWebInspectorProxy::platformSetForcedAppearance): Added.

• UIProcess/Inspector/win/RemoteWebInspectorProxyWin.cpp:

(WebKit::RemoteWebInspectorProxy::platformSetForcedAppearance): Added.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorFrontendClient::setForcedAppearance): Added.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebInspectorClient.h:
• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::setForcedAppearance): Added.

Source/WebKitLegacy/win:

• WebCoreSupport/WebInspectorClient.h:
• WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::setForcedAppearance): Added.

1:42 PM Changeset in webkit [257800] by Megan Gardner

• 2 edits in trunk/Source/WTF

Build Fix
​https://bugs.webkit.org/show_bug.cgi?id=208530

Reviewed by Wenson Hsieh.

• wtf/PlatformHave.h:

1:24 PM Changeset in webkit [257799] by Justin Fan

• 53 edits in trunk

[WebGL2] Implement texImage2D(TexImageSource) for RGBA/RGBA/UNSIGNED_BYTE ImageElements
​https://bugs.webkit.org/show_bug.cgi?id=208486

Reviewed by Dean Jackson.

Source/WebCore:

Partial implementation of WebGL 2 texImage2D(TexImageSource).

Covered by webgl/2.0.0/conformance2/textures/svg_image directory of tests, especially for RGBA/RGBA/UNSIGNED_BYTE.

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::texImage2D): Enable.

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::isRGBFormat):
(WebCore::WebGLRenderingContextBase::texImageSource2D): Handle both WebGL and WebGL 2 versions of TexImage2D(TexImageSource).
(WebCore::WebGLRenderingContextBase::texImage2DImpl):
(WebCore::WebGLRenderingContextBase::texSubImage2D):
(WebCore::WebGLRenderingContextBase::texSubImage2DBase): Disable WebGL1-only validation check.
(WebCore::WebGLRenderingContextBase::texImage2D):

• html/canvas/WebGLRenderingContextBase.h:
• platform/graphics/opengl/GraphicsContextGLOpenGL.cpp: Prevent crashing for HALF_FLOAT textures.

LayoutTests:

Partial implementation of WebGL 2 texImage2D(TexImageSource). Update affected results, mostly partial progressions.

• TestExpectations: Unskip svg_image texture tests that test the ImageElement pathway.
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r11f_g11f_b10f-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r11f_g11f_b10f-rgb-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r16f-red-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r16f-red-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r32f-red-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r8-red-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r8ui-red_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rg16f-rg-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rg16f-rg-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rg32f-rg-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rg8-rg-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rg8ui-rg_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb16f-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb16f-rgb-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb32f-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb565-rgb-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb565-rgb-unsigned_short_5_6_5-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb5_a1-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb5_a1-rgba-unsigned_short_5_5_5_1-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb8-rgb-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb9_e5-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb9_e5-rgb-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba16f-rgba-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba16f-rgba-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba32f-rgba-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba4-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba4-rgba-unsigned_short_4_4_4_4-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba8-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-srgb8-rgb-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r16f-red-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r16f-red-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r32f-red-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r8-red-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r8ui-red_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg16f-rg-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg16f-rg-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg32f-rg-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg8-rg-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg8ui-rg_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:

1:19 PM Changeset in webkit [257798] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ macOS ] svg/custom/textPath-change-id-pattern.svg is flakey failing
​https://bugs.webkit.org/show_bug.cgi?id=208532

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

1:12 PM Changeset in webkit [257797] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] Add entitlement for message filtering
​https://bugs.webkit.org/show_bug.cgi?id=208526
<rdar://problem/58885485>

Reviewed by Brent Fulgham.

On iOS, an entitlement is needed to enable message filtering.

• Scripts/process-entitlements.sh:

1:08 PM Changeset in webkit [257796] by Matt Lewis

• 5 edits in trunk/Tools

Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
​https://bugs.webkit.org/show_bug.cgi?id=208485

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/common/checkout/scm/stub_repository.py:

(StubRepository.init): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
that we don't have to recreate the variables that are already created.

• Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using

from each module, rather than making extra imports that we don't need.
(StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
and not part of the host.
(StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
(StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
(StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
(StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
(StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
(StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
(StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.

• Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:

(SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
if we were geting any value at all
(SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
sure we aren't gabking the wrong key:value pair

• Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that

come with the MockHosts and MockHost inherits from MockSystemHost.
(PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
(test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
to the various upload steps.

12:24 PM Changeset in webkit [257795] by basuke.suzuki@sony.com

• 3 edits in trunk/Source/JavaScriptCore

[WinCairo][PlayStation] Add interface to get listening port of RemoteInspectorServer
​https://bugs.webkit.org/show_bug.cgi?id=208391

Reviewed by Don Olmstead.

When passing zero as a port argument, system will pick an available port for it.
Without this method, client cannot get which port is listening.

• inspector/remote/socket/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::start):
(Inspector::RemoteInspectorServer::getPort):

• inspector/remote/socket/RemoteInspectorServer.h:

12:08 PM Changeset in webkit [257794] by aakash_jain@apple.com

• 4 edits in trunk/Tools

[ews] Add build step to find list of modified changelogs
​https://bugs.webkit.org/show_bug.cgi?id=208514

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/factories.py:
• BuildSlaveSupport/ews-build/steps.py:

(FindModifiedChangeLogs): Build step to find modified ChangeLogs.
(FindModifiedChangeLogs.start): Initialize log observer.
(FindModifiedChangeLogs.getResultSummary): Set custom failure message.
(FindModifiedChangeLogs.evaluateCommand):
(FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
(FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
(FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.

• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.

11:52 AM Changeset in webkit [257793] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ macOS ] legacy-animation-engine/animations/play-state-start-paused.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=208527

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

11:44 AM Changeset in webkit [257792] by Ryan Haddad

• 2 edits in trunk/Tools

[iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
​https://bugs.webkit.org/show_bug.cgi?id=208451

Unreviewed test gardening.

• TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.

11:41 AM Changeset in webkit [257791] by Jon Davis

• 1 edit
  142 deletes in trunk/Source/WebInspectorUI

Removed old raster icons for object types and resources
​https://bugs.webkit.org/show_bug.cgi?id=208458

Reviewed by Devin Rousso.

• UserInterface/Images/ApplicationCache.png: Removed.
• UserInterface/Images/ApplicationCache@2x.png: Removed.
• UserInterface/Images/ApplicationCacheManifest.png: Removed.
• UserInterface/Images/ApplicationCacheManifest@2x.png: Removed.
• UserInterface/Images/Assertion.svg: Removed.
• UserInterface/Images/AuditTestCase.svg: Removed.
• UserInterface/Images/AuditTestCaseResult.svg: Removed.
• UserInterface/Images/AuditTestGroup.svg: Removed.
• UserInterface/Images/AuditTestGroupResult.svg: Removed.
• UserInterface/Images/CPUInstrument.svg: Removed.
• UserInterface/Images/CallTrees.svg: Removed.
• UserInterface/Images/ClippingCSS.png: Removed.
• UserInterface/Images/​ClippingCSS@2x.png: Removed.
• UserInterface/Images/ClippingCSSLarge.png: Removed.
• UserInterface/Images/​ClippingCSSLarge@2x.png: Removed.
• UserInterface/Images/ClippingGeneric.png: Removed.
• UserInterface/Images/ClippingGeneric@2x.png: Removed.
• UserInterface/Images/ClippingGenericLarge.png: Removed.
• UserInterface/Images/ClippingGenericLarge@2x.png: Removed.
• UserInterface/Images/ClippingJS.png: Removed.
• UserInterface/Images/​ClippingJS@2x.png: Removed.
• UserInterface/Images/ClippingJSLarge.png: Removed.
• UserInterface/Images/​ClippingJSLarge@2x.png: Removed.
• UserInterface/Images/Cookie.png: Removed.
• UserInterface/Images/Cookie@2x.png: Removed.
• UserInterface/Images/DOMBreakpointAttributeModified.svg: Removed.
• UserInterface/Images/DOMBreakpointNodeRemoved.svg: Removed.
• UserInterface/Images/DOMBreakpointSubtreeModified.svg: Removed.
• UserInterface/Images/DOMCharacterData.svg: Removed.
• UserInterface/Images/DOMComment.svg: Removed.
• UserInterface/Images/DOMDocument.svg: Removed.
• UserInterface/Images/DOMDocumentType.svg: Removed.
• UserInterface/Images/DOMElement.svg: Removed.
• UserInterface/Images/DOMNode.svg: Removed.
• UserInterface/Images/DOMTextNode.svg: Removed.
• UserInterface/Images/Database.png: Removed.
• UserInterface/Images/Database@2x.png: Removed.
• UserInterface/Images/DatabaseTable.png: Removed.
• UserInterface/Images/DatabaseTable@2x.png: Removed.
• UserInterface/Images/DebuggerStatement.svg: Removed.
• UserInterface/Images/DocumentCSS.png: Removed.
• UserInterface/Images/​DocumentCSS@2x.png: Removed.
• UserInterface/Images/DocumentCSSLarge.png: Removed.
• UserInterface/Images/​DocumentCSSLarge@2x.png: Removed.
• UserInterface/Images/DocumentFont.png: Removed.
• UserInterface/Images/DocumentFont@2x.png: Removed.
• UserInterface/Images/DocumentFontLarge.png: Removed.
• UserInterface/Images/DocumentFontLarge@2x.png: Removed.
• UserInterface/Images/DocumentGL.png: Removed.
• UserInterface/Images/​DocumentGL@2x.png: Removed.
• UserInterface/Images/DocumentGeneric.png: Removed.
• UserInterface/Images/DocumentGeneric@2x.png: Removed.
• UserInterface/Images/DocumentGenericLarge.png: Removed.
• UserInterface/Images/DocumentGenericLarge@2x.png: Removed.
• UserInterface/Images/DocumentImage.png: Removed.
• UserInterface/Images/DocumentImage@2x.png: Removed.
• UserInterface/Images/DocumentImageLarge.png: Removed.
• UserInterface/Images/DocumentImageLarge@2x.png: Removed.
• UserInterface/Images/DocumentJS.png: Removed.
• UserInterface/Images/​DocumentJS@2x.png: Removed.
• UserInterface/Images/DocumentJSLarge.png: Removed.
• UserInterface/Images/​DocumentJSLarge@2x.png: Removed.
• UserInterface/Images/DocumentMarkup.png: Removed.
• UserInterface/Images/DocumentMarkup@2x.png: Removed.
• UserInterface/Images/DocumentMarkupLarge.png: Removed.
• UserInterface/Images/DocumentMarkupLarge@2x.png: Removed.
• UserInterface/Images/EventBreakpointAnimationFrame.svg: Removed.
• UserInterface/Images/EventBreakpointInterval.svg: Removed.
• UserInterface/Images/EventBreakpointListener.svg: Removed.
• UserInterface/Images/EventBreakpointTimeout.svg: Removed.
• UserInterface/Images/EventListener.svg: Removed.
• UserInterface/Images/Events.svg: Removed.
• UserInterface/Images/Exception.svg: Removed.
• UserInterface/Images/FolderGeneric.png: Removed.
• UserInterface/Images/FolderGeneric@2x.png: Removed.
• UserInterface/Images/Function.svg: Removed.
• UserInterface/Images/HeapAllocationsInstrument.svg: Removed.
• UserInterface/Images/HeapSnapshot.svg: Removed.
• UserInterface/Images/HeapSnapshotDiff.svg: Removed.
• UserInterface/Images/HeapSnapshotInstances.svg: Removed.
• UserInterface/Images/HeapSnapshotObjectGraph.svg: Removed.
• UserInterface/Images/HeapSnapshotSelected.svg: Removed.
• UserInterface/Images/HeapSnapshotSummary.svg: Removed.
• UserInterface/Images/LayoutInstrument.svg: Removed.
• UserInterface/Images/LocalStorage.png: Removed.
• UserInterface/Images/LocalStorage@2x.png: Removed.
• UserInterface/Images/MediaInstrument.svg: Removed.
• UserInterface/Images/MemoryInstrument.svg: Removed.
• UserInterface/Images/Microtask.svg: Removed.
• UserInterface/Images/Native.svg: Removed.
• UserInterface/Images/NetworkInstrument.svg: Removed.
• UserInterface/Images/Object.svg: Removed.
• UserInterface/Images/PausedBreakpoint.svg: Removed.
• UserInterface/Images/Program.svg: Removed.
• UserInterface/Images/PseudoElement.svg: Removed.
• UserInterface/Images/Range.svg: Removed.
• UserInterface/Images/RangeLarge.svg: Removed.
• UserInterface/Images/Reflection.svg: Removed.
• UserInterface/Images/RenderingFrame.svg: Removed.
• UserInterface/Images/RenderingFramesInstrument.svg: Removed.
• UserInterface/Images/Request.svg: Removed.
• UserInterface/Images/Response.svg: Removed.
• UserInterface/Images/ScriptsInstrument.svg: Removed.
• UserInterface/Images/SessionStorage.png: Removed.
• UserInterface/Images/SessionStorage@2x.png: Removed.
• UserInterface/Images/Source.svg: Removed.
• UserInterface/Images/StyleRuleInheritedElement.svg: Removed.
• UserInterface/Images/TailDeletedFunction.svg: Removed.
• UserInterface/Images/Thread.svg: Removed.
• UserInterface/Images/TimelineRecordAPI.svg: Removed.
• UserInterface/Images/TimelineRecordAnimationFrame.svg: Removed.
• UserInterface/Images/TimelineRecordCSSAnimation.svg: Removed.
• UserInterface/Images/TimelineRecordCSSTransition.svg: Removed.
• UserInterface/Images/TimelineRecordComposite.svg: Removed.
• UserInterface/Images/TimelineRecordConsoleProfile.svg: Removed.
• UserInterface/Images/TimelineRecordEvent.svg: Removed.
• UserInterface/Images/TimelineRecordGarbageCollection.svg: Removed.
• UserInterface/Images/TimelineRecordLayout.svg: Removed.
• UserInterface/Images/TimelineRecordMediaElement.svg: Removed.
• UserInterface/Images/TimelineRecordPaint.svg: Removed.
• UserInterface/Images/TimelineRecordProbeSampled.svg: Removed.
• UserInterface/Images/TimelineRecordScriptEvaluated.svg: Removed.
• UserInterface/Images/TimelineRecordStyle.svg: Removed.
• UserInterface/Images/TimelineRecordTimer.svg: Removed.
• UserInterface/Images/TypeBigInt.svg: Removed.
• UserInterface/Images/TypeBoolean.svg: Removed.
• UserInterface/Images/TypeNull.svg: Removed.
• UserInterface/Images/TypeNumber.svg: Removed.
• UserInterface/Images/TypeObject.svg: Removed.
• UserInterface/Images/TypeRegex.svg: Removed.
• UserInterface/Images/TypeString.svg: Removed.
• UserInterface/Images/TypeSymbol.svg: Removed.
• UserInterface/Images/TypeUndefined.svg: Removed.
• UserInterface/Images/URLBreakpoint.svg: Removed.
• UserInterface/Images/WebSocket.png: Removed.
• UserInterface/Images/WebSocket@2x.png: Removed.
• UserInterface/Images/WebSocketLarge.png: Removed.
• UserInterface/Images/WebSocketLarge@2x.png: Removed.
• UserInterface/Images/WorkerScript.png: Removed.
• UserInterface/Images/WorkerScript@2x.png: Removed.
• UserInterface/Images/WorkerScriptLarge.png: Removed.
• UserInterface/Images/WorkerScriptLarge@2x.png: Removed.

11:30 AM Changeset in webkit [257790] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ macOS ] webgl/2.0.0/conformance/extensions/webgl-draw-buffers.html has been timing out ever since it was introduced.
​https://bugs.webkit.org/show_bug.cgi?id=208524

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

11:17 AM Changeset in webkit [257789] by Wenson Hsieh

• 3 edits in trunk/Source/WebCore

Address post-commit feedback after r257732
​https://bugs.webkit.org/show_bug.cgi?id=208265

Reviewed by Darin Adler.

Remove the private initializeOrCopyPlatformPathIfNeeded() helper,
and move its logic into ensurePlatformPath().

• platform/graphics/Path.h:
• platform/graphics/cg/PathCG.cpp:

(WebCore::Path::ensurePlatformPath):
(WebCore::Path::initializeOrCopyPlatformPathIfNeeded): Deleted.

11:16 AM Changeset in webkit [257788] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ iOS wk2 ] http/tests/security/cookies/third-party-cookie-blocking-redirect.html is flaky timing out.
​https://bugs.webkit.org/show_bug.cgi?id=208525

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

11:10 AM Changeset in webkit [257787] by Alan Coon

• 4 edits in branches/safari-610.1.6-branch

Cherry-pick r257694. rdar://problem/59957329

Unreviewed, rolling out r257618.

This allegedly causes Safari to crash when closing a window
(see rdar://problem/59922725).

Reverted changeset:

"UIProcess crash after using _prepareForMoveToWindow, then
deallocating the WKWebView before moving to the window"
​https://bugs.webkit.org/show_bug.cgi?id=208365
​https://trac.webkit.org/changeset/257618

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:06 AM Changeset in webkit [257786] by Alan Coon

• 1 copy in branches/safari-610.1.6-branch

New branch.

10:21 AM Changeset in webkit [257785] by commit-queue@webkit.org

• 29 edits in trunk

Adopt HTTP Alternative Services Storage
​https://bugs.webkit.org/show_bug.cgi?id=208387

Patch by Jiten Mehta <​jmehta@apple.com> on 2020-03-03
Reviewed by Alex Christensen.

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

Covered by a new API test which verifies that data is written to the correct directory.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteWebsiteDataForRegistrableDomains):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::getHostNamesWithAlternativeServices):
(WebKit::NetworkProcess::deleteAlternativeServicesForHostNames):
(WebKit::NetworkProcess::clearAlternativeServices):

• Shared/WebsiteData/WebsiteData.cpp:

(WebKit::WebsiteData::ownerProcess):

• Shared/WebsiteData/WebsiteDataType.h:
• UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:

(dataTypesToString):

• UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:

(WebKit::toWebsiteDataType):
(WebKit::toWKWebsiteDataTypes):

• UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore _allWebsiteDataTypesIncludingPrivate]):

• UIProcess/WebsiteData/WebsiteDataRecord.cpp:

(WebKit::WebsiteDataRecord::addAlternativeServicesHostname):

• UIProcess/WebsiteData/WebsiteDataRecord.h:

Source/WTF:

• wtf/PlatformHave.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(checkUntilEntryFound):
(TEST):

10:17 AM Changeset in webkit [257784] by ysuzuki@apple.com

• 9 edits
  1 add in trunk

[JSC] @hasOwnLengthProperty returns wrong value if "length" is attempted to be modified
​https://bugs.webkit.org/show_bug.cgi?id=208497
<rdar://problem/59913544>

Reviewed by Mark Lam.

JSTests:

• stress/function-length-update.js: Added.

(shouldBe):
(userFunction):
(userFunction2):

Source/JavaScriptCore:

When "length" of JSFunction is attempted to be modified, we put a flag. And @hasOwnLengthProperty
does not correctly use this flag to return a value for the fast path. This affects on "length"
property of bound functions. For example,

function userFunction(a) { }
userFunction.length = 20; This field is read-only. So, it is not changed.
userFunction.bind().length; Should be 1, but it returns 0.

1. We rename m_hasModifiedLength to m_hasModifiedLengthForNonHostFunction and m_hasModifiedName to m_hasModifiedNameForNonHostFunction since we are not tracking these states for host-functions which can eagerly initialize them.
2. We rename areNameAndLengthOriginal to canAssumeNameAndLengthAreOriginal to allow it to return "false" for host functions. If it returns true, we go to the fast path.
3. Correctly use canAssumeNameAndLengthAreOriginal information in @hasOwnLengthProperty.

• runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::FunctionRareData):

• runtime/FunctionRareData.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):

• runtime/JSFunction.h:
• runtime/JSFunctionInlines.h:

(JSC::JSFunction::canAssumeNameAndLengthAreOriginal):
(JSC::JSFunction::areNameAndLengthOriginal): Deleted.

• runtime/JSGlobalObject.cpp:

(JSC::hasOwnLengthProperty):

• tools/JSDollarVM.cpp:

(JSC::functionHasOwnLengthProperty):

10:11 AM Changeset in webkit [257783] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Regression (CookieCache) Unable to log into Hulu.com
​https://bugs.webkit.org/show_bug.cgi?id=208517
<rdar://problem/59973630>

Reviewed by Geoffrey Garen.

Even though we are listening for notifications for 'www.hulu.com', CFNetwork sends us a notification for host
'secure.hulu.com' when a load to secure.hulu.com sets a cookie for domain '.hulu.com'. Because the host did
not match one if our map of observers, we would ignore the cookie notification and our cookie cache would get
out of sync. To temporarily address the issue (until a better fix is made, likely on CFNetwork side), WebKit
now matches registrable domains instead of hosts.

• platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::registerCookieChangeListenersIfNecessary):

9:49 AM Changeset in webkit [257782] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ Catalina ] webanimations/accelerated-animation-slot-invalidation.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=208519

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:25 AM Changeset in webkit [257781] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ Mac wk1 Debug ] legacy-animation-engine/animations/animation-direction-reverse.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=208518

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

9:08 AM Changeset in webkit [257780] by Kate Cheney

• 23 edits
  3 adds in trunk

Check for navigation to app-bound domain during script evaluation
​https://bugs.webkit.org/show_bug.cgi?id=208319
<rdar://problem/57569321>

Reviewed by Brent Fulgham.

Source/WebCore:

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::executeScriptInWorld):

• loader/FrameLoaderClient.h:
• page/Frame.cpp:

(WebCore::Frame::injectUserScriptImmediately):

Source/WebKit:

Much of this patch is passing around a new parameter,
m_hasNavigatedAwayFromAppBoundDomain, to the Web Content Process to
indicate conditions for script evaluation.

• Shared/LoadParameters.cpp:

(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):

• Shared/LoadParameters.h:
• Shared/PolicyDecision.h:

(WebKit::PolicyDecision::encode const):
(WebKit::PolicyDecision::decode):

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _inAppBrowserPrivacyEnabled]):
(-[WKPreferences _setInAppBrowserPrivacyEnabled:]):

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setIsNavigatingToAppBoundDomain:completionHandler:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::loadData):
(WebKit::ProvisionalPageProxy::loadRequest):
(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionSync):

• UIProcess/ProvisionalPageProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadDataWithNavigationShared):
(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain):
(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomainTesting):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSyncShared):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::hasNavigatedAwayFromAppBoundDomain const):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::hasNavigatedAwayFromAppBoundDomain):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadRequest):
(WebKit::WebPage::loadDataImpl):
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadAlternateHTML):
(WebKit::WebPage::didReceivePolicyDecision):
(WebKit::WebPage::runJavaScript):
(WebKit::WebPage::setIsNavigatingToAppBoundDomainTesting):
A new call to manually set isNavigatingToAppBoundDomain to mimic
test cases in which a webView switches between app-bound and
non-app-bound domains.

(WebKit::WebPage::setIsNavigatingToAppBoundDomain): Deleted.
Moved to header file because its setting a private variable.

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::setIsNavigatingToAppBoundDomain):
(WebKit::WebPage::hasNavigatedAwayFromAppBoundDomain const):
(WebKit::WebPage::setHasNavigatedAwayFromAppBoundDomain):

• WebProcess/WebPage/WebPage.messages.in:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.

(-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
• TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.

8:44 AM Changeset in webkit [257779] by youenn@apple.com

• 6 edits in trunk/Source

Rename USE(GPU_PROCESS) to ENABLE(GPU_PROCESS_FOR_WEBRTC)
​https://bugs.webkit.org/show_bug.cgi?id=208505

Reviewed by Eric Carlson.

Source/WebKit:

• Shared/WebPreferencesDefaultValues.h:

Source/WTF:

Rename macro since the name is misleading.
Disable GPU_PROCESS_FOR_WEBRTC for iOS except simulator for now.

• wtf/PlatformEnable.h:
• wtf/PlatformEnableCocoa.h:
• wtf/PlatformUse.h:

7:28 AM Changeset in webkit [257778] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GTK][WPE] Fix current time and duration formatting in media controls
​https://bugs.webkit.org/show_bug.cgi?id=208442

Reviewed by Xabier Rodriguez-Calvar.

We are always using mm:ss or hh:mm:ss for current time and duration. We should use different amount of digits
depending on the duration (m:ss, mm:ss, h:mm:ss or hh:mm:ss).

• Modules/mediacontrols/mediaControlsAdwaita.js:

(Controller.prototype.updateDuration): Set the amount of digits for current duration.
(Controller.prototype.prependZeroIfNeeded): Helper to prepend 0 for values less than 10.
(Controller.prototype.formatTime): Format the time depending on the number of digits required.

7:18 AM Changeset in webkit [257777] by commit-queue@webkit.org

• 14 edits
  1 delete in trunk

Unreviewed, rolling out r257754.
​https://bugs.webkit.org/show_bug.cgi?id=208513

Introduced API test failure (Requested by perarne on #webkit).

Reverted changeset:

"[Cocoa] Mapping from MIME type to UTI type should be done in
the UI process"
​https://bugs.webkit.org/show_bug.cgi?id=208415
​https://trac.webkit.org/changeset/257754

6:07 AM Changeset in webkit [257776] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Regression(r257354) Crash when trying on watch video on apple.com
​https://bugs.webkit.org/show_bug.cgi?id=208487
<rdar://problem/59967385>

Reviewed by Eric Carlson.

Use WebCore::Cookie's code to convert to a NSHTTPCookie instead of using toNSHTTPCookie()
which was not quite right, especially after r257354.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::toNSHTTPCookie): Deleted.

6:05 AM Changeset in webkit [257775] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GTK] Use -webkit-system-font instead of -webkit-small-control in media controls
​https://bugs.webkit.org/show_bug.cgi?id=208509

Reviewed by Xabier Rodriguez-Calvar.

For consistency with the system font.

• Modules/mediacontrols/mediaControlsAdwaita.css:

(audio::-webkit-media-controls-current-time-display,):
(video::-webkit-media-controls-closed-captions-container):

5:33 AM Changeset in webkit [257774] by Carlos Garcia Campos

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaseline media/video-controls-no-scripting.html after r257705

• platform/gtk/media/video-controls-no-scripting-expected.txt:

5:19 AM Changeset in webkit [257773] by Carlos Garcia Campos

• 2 edits
  1 delete in trunk/LayoutTests

Unreviewed gardeing. Update expectations of media/video-controls-toggling.html after r257771

I forgot to update the expected file after the changes in media/video-controls-toggling.html.

• media/video-controls-toggling-expected.txt:
• platform/gtk/media/video-controls-toggling-expected.txt: Removed.

5:16 AM Changeset in webkit [257772] by Diego Pino Garcia

• 2 edits in trunk/Tools

REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
​https://bugs.webkit.org/show_bug.cgi?id=208506

Reviewed by Carlos Garcia Campos.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::platformAdjustContext): Remove unnecessary code.

5:13 AM Changeset in webkit [257771] by Carlos Garcia Campos

• 2 edits in trunk/LayoutTests

Test media/video-controls-toggling.html is failing for GTK since r257299
​https://bugs.webkit.org/show_bug.cgi?id=208507

Reviewed by Xabier Rodriguez-Calvar.

This has started to fail for GTK since we switched to use adwaita media controls, but I think this was passing
by coincidence. The test itself is wrong and that's probably the reason why it fails in the other platforms
too. The test expects that the changes that happen after removing the controls attribute from video element are
sync, but they aren't because a mutation observer is used by media controls script. Then, it assumes that panel
display property is set to none after controls attribute is removed, but we are actually removing the media
controls tree from the DOM in that case so the panel is null at that point. This worked in GTK before because
all those checks that were supposed to happen after removing the controls were done before the
handleControlsChange() was called.

• media/video-controls-toggling.html: Check that panel is null after controls attribute is removed from video

element in the next run loop iteration.

1:26 AM Changeset in webkit [257770] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.28

Merge r257466 - [JSC][MIPS] Adding support to Checkpoints
​https://bugs.webkit.org/show_bug.cgi?id=208196

Reviewed by Yusuke Suzuki.

JSTests:

• microbenchmarks/memcpy-typed-loop.js:

Source/JavaScriptCore:

This patch is adding changes to properly support OSR to
checkpoints on MIPS. It required fixes on JIT probe and some
adjustment on Offlineasm to correct generate $gp load when executing
checkpoint_osr_exit_from_inlined_call_trampoline.

• assembler/MacroAssemblerMIPS.cpp:

Probe trampoline needs to allocate 16 bytes for 4 arguments to
properly follow C calling conventions. This space is used by callee
when the JSC is compiled with -O0 flags
(Check "DEFAULT C CALLING CONVENTION (O32)" section on
​https://www.mips.com/downloads/mips32-instruction-set-quick-reference-v1-01).

• llint/LowLevelInterpreter.asm:

As we need to do on ARMv7, 64-bits arguments needs to be passed in
register pairs $a1:$a0 or $a3:$a2 (little-endian mode). Since $a0
contais CallFrame*, we need to pass EncodedJSValue on $a3:$a2
pair.

• offlineasm/mips.rb:

Following the same reason for return locations on OSR to LLInt, we
need to adjust $gp using $ra instead of $t9 on
checkpoint_osr_exit_from_inlined_call_trampoline, given it is only
reachable through ret operations. For detailed explanation, check
ChangeLog of ​https://trac.webkit.org/changeset/252713.

1:21 AM Changeset in webkit [257769] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GTK][WPE] Fix JavaScript exception when removing media controls
​https://bugs.webkit.org/show_bug.cgi?id=208444

Reviewed by Xabier Rodriguez-Calvar.

• Modules/mediacontrols/mediaControlsAdwaita.js:

(Controller.prototype.hideCaptionMenu): Return early if there's no caption menu to hide.

1:20 AM Changeset in webkit [257768] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

REGRESSION(r257299): [GTK] media controls current time label is disabled for live streams
​https://bugs.webkit.org/show_bug.cgi?id=208443

Reviewed by Xabier Rodriguez-Calvar.

Remove the no-duration class from currentTime element when we know it's a live stream.

• Modules/mediacontrols/mediaControlsAdwaita.js:

(Controller.prototype.updateTime):