Timeline

Mar 15, 2020:

7:58 PM Changeset in webkit [258486] by Fujii Hironori

• 4 edits in trunk

KeyedDecoderGeneric fails to allocate Vector while decoding broken data
​https://bugs.webkit.org/show_bug.cgi?id=207324

Reviewed by Darin Adler.

Source/WebCore:

There were three crash bugs in it.

KeyedDecoderGeneric was trying to allocate a buffer without
ensuring the size wouldn't exceed the decoding data size by using
bufferIsLargeEnoughToContain.

It was trying to push an itme into the top dictionary of emtpy
m_dictionaryStack when EndObject tag would appear without the
preceding BeginObject tag.

It was trying to push an item into the top array of empty
m_arrayStack when EndArray tag would appear without the preceding
BeginArray tag.

Tests: TestWebKitAPI: KeyedCoding.DecodeRandomData

• platform/generic/KeyedDecoderGeneric.cpp:

(WebCore::readString):
(WebCore::KeyedDecoderGeneric::KeyedDecoderGeneric):
Check bufferIsLargeEnoughToContain(size) before allocating a Vector with size.
Check if m_dictionaryStack and m_arrayStack are empty.

Tools:

• TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:

(TestWebKitAPI::generateRandomData): Added.
(TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.

7:33 PM Changeset in webkit [258485] by Lauro Moura

• 4 edits in trunk/LayoutTests

WPE gardening.

Updated a test baseline with new message after changed from
js-test-pre to js-test.

Unreviewed test gardening.

• platform/gtk/TestExpectations: Updated an expectation with new bug

number.

• platform/wpe/TestExpectations:
• platform/wpe/fast/frames/sandboxed-iframe-navigation-allowed-expected.txt:

7:08 PM Changeset in webkit [258484] by commit-queue@webkit.org

• 3 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] Source/ThirdParty/ANGLE/src/common/utilities.cpp:10: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
​https://bugs.webkit.org/show_bug.cgi?id=209014

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-15
Reviewed by Darin Adler.

Silence compiler warning.

• changes.diff:
• src/common/utilities.cpp:

6:41 PM Changeset in webkit [258483] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: implicitly-declared ‘egl::AttributeMap& egl::AttributeMap::operator=(const egl::AttributeMap&)’ is deprecated [-Wdeprecated-copy]
​https://bugs.webkit.org/show_bug.cgi?id=209015

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-15
Reviewed by Darin Adler.

Suppress compiler warning. If this were WebKit code, I might take the time to fix it, but
with third-party code it's probably best to just turn off warnings that upstream is not
using.

• CMakeLists.txt:

6:17 PM Changeset in webkit [258482] by Chris Dumez

• 6 edits in trunk/Source/WebCore

[DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions::enableBackForwardCache
​https://bugs.webkit.org/show_bug.cgi?id=207481
<rdar://problem/59331661>

Reviewed by Darin Adler.

Add a support for a new excludeFromInternalSetting option in Settings.yaml and use it for
'usesBackForwardCache' setting. This means that script will no longer be able to toggle
this particular setting via internals.settings JS API. Tests wanting to turn on the
back / forward cache are supposed to use the following:
<!-- webkit-test-runner [ enableBackForwardCache=true ] -->

Using internals.settings JS API to turn on the back/forward cache would not work well
with WebKit2 because of process-swap-on-navigation. Support for it in WK1 / DRT was
causing flakiness because of a conflict between the 2 ways of enabling the setting.

• Scripts/GenerateSettings.rb:
• Scripts/SettingsTemplates/InternalSettingsGenerated.cpp.erb:
• Scripts/SettingsTemplates/InternalSettingsGenerated.h.erb:
• Scripts/SettingsTemplates/InternalSettingsGenerated.idl.erb:
• page/Settings.yaml:

2:28 PM Changeset in webkit [258481] by aakash_jain@apple.com

• 2 edits in trunk/LayoutTests

Regression r258439: quicklook/multi-sheet-numbers-09.html is failing consistently on iOS
​https://bugs.webkit.org/show_bug.cgi?id=209128

Partially revert r258439.

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

8:33 AM Changeset in webkit [258480] by Alan Bujtas

• 6 edits
  2 adds in trunk

[LFC][TFC] Add basic column span support for content box width
​https://bugs.webkit.org/show_bug.cgi?id=209120
<rdar://problem/60463424>

Reviewed by Antti Koivisto.

Source/WebCore:

Take the column spanning into account when computing the content width for the table cell.
[content box width = column width(1) + column width(2) + .. + column width(spanning value) + ((spanning value - 1) * horizontal spacing)]

Test: fast/layoutformattingcontext/table-colspan-simple.html

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::layoutTableCellBox):
(WebCore::Layout::TableFormattingContext::positionTableCells):

• layout/tableformatting/TableFormattingContext.h:
• layout/tableformatting/TableGrid.cpp:

(WebCore::Layout::TableGrid::appendCell):

• layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::CellInfo::startColumn const):
(WebCore::Layout::TableGrid::CellInfo::endColumn const):
(WebCore::Layout::TableGrid::CellInfo::startRow const):
(WebCore::Layout::TableGrid::CellInfo::endRow const):
(WebCore::Layout::TableGrid::CellInfo::columnSpan const):
(WebCore::Layout::TableGrid::CellInfo::rowSpan const):

LayoutTests:

• fast/layoutformattingcontext/table-colspan-simple-expected.html: Added.
• fast/layoutformattingcontext/table-colspan-simple.html: Added.

3:51 AM Changeset in webkit [258479] by ysuzuki@apple.com

• 4 edits in trunk/Source/JavaScriptCore

reportZappedCellAndCrash should handle PreciseAllocation in IsoSubspace
​https://bugs.webkit.org/show_bug.cgi?id=209042

Reviewed by Mark Lam.

This patch adds support of PreciseAllocation cells to reportZappedCellAndCrash, since now it is frequently used
as a lower-tier cells in IsoSubspace.

• heap/IsoSubspace.h:
• heap/IsoSubspaceInlines.h:

(JSC::IsoSubspace::forEachLowerTierFreeListedPreciseAllocation):

• runtime/JSCell.cpp:

(JSC::reportZappedCellAndCrash):

3:16 AM Changeset in webkit [258478] by ysuzuki@apple.com

• 37 edits
  2 adds in trunk

Should not use variable-length-array (VLA)
​https://bugs.webkit.org/show_bug.cgi?id=209043

Reviewed by Mark Lam.

PerformanceTests:

• MediaTime/Configurations/Base.xcconfig:

Source/bmalloc:

• Configurations/Base.xcconfig:

Source/JavaScriptCore:

This patch disables variable-length-array (VLA). If this feature uses user-input, user can
control the stack height consumed by C++ code. This patch avoids using VLA. To achieve that,

1. We set -Wvla warning option to trigger warnings if it is used.
2. Introduce MarkedJSValueRefArray for API. This replaces JSValueRef arguments[variableLength] use case. MarkedJSValueRefArray registers itself to JSC GC so that GC can mark it as a strong root.

• API/JSContext.mm:

(+[JSContext currentArguments]):

• API/JSValue.mm:

(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):

• API/MarkedJSValueRefArray.cpp: Added.

(JSC::MarkedJSValueRefArray::MarkedJSValueRefArray):
(JSC::MarkedJSValueRefArray::~MarkedJSValueRefArray):
(JSC::MarkedJSValueRefArray::visitAggregate):

• API/MarkedJSValueRefArray.h: Added.
• API/tests/minidom.c:

(print):

• API/tests/testapi.cpp:

(TestAPI::markedJSValueArrayAndGC):
(testCAPIViaCpp):

• Configurations/Base.xcconfig:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• heap/Heap.cpp:

(JSC::Heap::addCoreConstraints):
(JSC::Heap::addMarkedJSValueRefArray):

• heap/Heap.h:
• heap/MarkedSpace.h:

(JSC::MarkedSpace::activeWeakSetsBegin): Deleted.
(JSC::MarkedSpace::activeWeakSetsEnd): Deleted.
(JSC::MarkedSpace::newActiveWeakSetsBegin): Deleted.
(JSC::MarkedSpace::newActiveWeakSetsEnd): Deleted.

• runtime/ArgList.h:

Source/WebCore:

• Configurations/Base.xcconfig:
• crypto/mac/SerializedCryptoKeyWrapMac.mm:

(WebCore::wrapSerializedCryptoKey):
(WebCore::unwrapSerializedCryptoKey):

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getInternalformatParameter):

• platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:

(WebCore::CoreAudioCaptureDeviceManager::refreshAudioCaptureDevices):

• platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:

(WebCore::updateDisplayID):
(WebCore::ScreenDisplayCaptureSourceMac::screenCaptureDevices):

Source/WebCore/PAL:

• Configurations/Base.xcconfig:

Source/WebInspectorUI:

• Configurations/Base.xcconfig:

Source/WebKit:

• Configurations/Base.xcconfig:
• UIProcess/_WKTouchEventGenerator.mm:

(-[_WKTouchEventGenerator touchDown:touchCount:]):
(-[_WKTouchEventGenerator liftUp:touchCount:]):
(-[_WKTouchEventGenerator moveToPoints:touchCount:duration:]):

Source/WebKitLegacy/mac:

• Configurations/Base.xcconfig:

Source/WTF:

• Configurations/Base.xcconfig:
• wtf/UUID.cpp:

(WTF::bootSessionUUIDString):

Tools:

• ContentExtensionTester/Configurations/Base.xcconfig:
• lldb/lldbWebKitTester/Configurations/Base.xcconfig:

Mar 14, 2020:

8:40 PM Changeset in webkit [258477] by beidson@apple.com

• 3 edits in trunk/Source/WebKit

Fix the "deliver cached ranges" logic in PDFPlugin (and other small cleanups)
​https://bugs.webkit.org/show_bug.cgi?id=209097

Reviewed by Tim Hatcher.

Streaming in data always appended to the buffer instead of first growing the buffer.
This wasn't noticed earlier because we often did not grow the buffer for successful range request completion.
But now we often do!

So this cleans that all up.

At the same time it revealed other interactions with PDFKit that force us to handle data requests on the main
thread after the document load is complete - Which is fine!

• WebProcess/Plugins/PDF/PDFPlugin.h:
• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::dataProviderGetBytesAtPositionCallback): If on the main thread (and the document load is complete)

handle the request directly!

(WebKit::PDFPlugin::getResourceBytesAtPositionMainThread):
(WebKit::PDFPlugin::ByteRangeRequest::completeWithAccumulatedData):
(WebKit::PDFPlugin::ensureDataBufferLength):
(WebKit::PDFPlugin::didFail):
(WebKit::PDFPlugin::maybeClearHighLatencyDataProviderFlag):
(WebKit::PDFPlugin::documentDataDidFinishLoading):
(WebKit::PDFPlugin::installPDFDocument):
(WebKit::PDFPlugin::manualStreamDidReceiveData): Grow the buffer instead of append.

5:14 PM Changeset in webkit [258476] by Brent Fulgham

• 8 edits in trunk/Source

Add missing checks needed for AppBound Quirk
​https://bugs.webkit.org/show_bug.cgi?id=209117
<rdar://problem/60460097>

Reviewed by John Wilander.

The checks for the 'NeedsInAppBrowserPrivacyQuirks' flag added in r258101 was incomplete.
Source/WebCore:

Two additional call sites need to check the state of the flag.

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::executeScriptInWorld): Add missing check for the quirk.

• loader/FrameLoaderClient.h: Add new API for the 'NeedsInAppBrowserPrivacyQuirks'

debug flag.

• page/Frame.cpp:

(WebCore::Frame::injectUserScriptImmediately): Ditto.

Source/WebKit:

These changes let the WebFrameLoaderClient report the quirk state to WebCore code.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.

3:59 PM Changeset in webkit [258475] by Darin Adler

• 20 edits in trunk/Source

Change all return values in TextIterator header from live ranges to SimpleRange
​https://bugs.webkit.org/show_bug.cgi?id=208906

Reviewed by Antti Koivisto.

Source/WebCore:

This is another step in moving off of live ranges for WebKit internals.

• Change return values of remaining functions that were returning live ranges in the TextIterator header to return SimpleRange.
• Change some arguments from live ranges to SimpleRange.
• At some call sites, use createLiveRange to convert the SimpleRange into a live range (for now), but at others update the code to use SimpleRange.
• Renamed a version of findPlainText that returns a boolean to containsPlainText.
• Convert call sites that were using createLiveRange just to use the Range::startPosition and Range::endPosition functions to instead use a new overload of the createLegacyEditingPosition function that can be used with SimpleRange::start and SimpleRange::end because it takes a BoundaryPoint.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rangeMatchesTextNearRange): Return Optional<SimpleRange>
and take SimpleRange argument.
(WebCore::AXObjectCache::previousBoundary): Updated since
SimplifiedBackwardsTextIterator::range now returns SimpleRange.

• accessibility/AXObjectCache.h: Updated for the above.

• accessibility/AccessibilityObjectInterface.h:

(WebCore::AXCoreObject::containsText const): Updated for name change.
Now containsPlainText instead of findPlainText.

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
Use createLegacyEditingPosition instead of createLiveRange.
(-[WebAccessibilityObjectWrapper rangeFromMarkers:withText:]): Use createLiveRange.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
Use createLegacyEditingPosition instead of createLiveRange.

• dom/Position.cpp:

(WebCore::createLegacyEditingPosition): Added an overload that takes a BoundaryPoint.

• dom/Position.h: Updated for the above, also removed unneeded includes and forward

declarations.

• editing/Editing.cpp:

(WebCore::visiblePositionForIndexUsingCharacterIterator): Updated since
CharacterIterator::range is now a SimpleRange, use createLegacyEditingPosition.

• editing/Editor.cpp:

(WebCore::Editor::advanceToNextMisspelling): Updated since CharacterIterator::range
is now a SimpleRange.
(WebCore::Editor::rangeOfString): Updated since findPlainText now returns a
SimpleRange; use createLiveRange.
(WebCore::Editor::countMatchesForText): Ditto.

• editing/TextIterator.cpp:

(WebCore::SimplifiedBackwardsTextIterator::range const): Return a SimpleRange.
(WebCore::CharacterIterator::range const): Ditto.
(WebCore::characterSubrange): Updated since CharacterIterator::range returns
a SimpleRange. Use createLiveRange.
(WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator): Cut down
code here by initializing data members in the class definition.
(WebCore::BackwardsCharacterIterator::range const): Return a SimpleRange.
(WebCore::WordAwareIterator::WordAwareIterator): Cut down code here by
initializing data members in the class definition.
(WebCore::hasAnyPlainText): Take a SimpleRange, use createLiveRange.
(WebCore::plainTextUsingBackwardsTextIteratorForTesting): Take a SimpleRange,
use createLiveRange.
(WebCore::collapsedToBoundary): Take and return a SimpleRange.
(WebCore::findPlainTextMatches): Take a SimpleRange, use createLiveRange.
(WebCore::rangeForMatch): Take and return a SimpleRange.
(WebCore::findClosestPlainText): Ditto.
(WebCore::findPlainText): Ditto.
(WebCore::containsPlainText): Renamed from findPlainText since this returns
a boolean, not a found location of some text.

• editing/TextIterator.h: Updated for the above. Also changed some data

members to use unsigned for offsets rather than int.

• editing/TextManipulationController.cpp:

(WebCore::ParagraphContentIterator::startPosition): Use
createLegacyEditingPosition instead of createLiveRange.
(WebCore::ParagraphContentIterator::endPosition): Ditto.

• editing/VisiblePosition.h: Added a forward declaration here since Position.h

no longer forward declares it.

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::appendTrailingWhitespace): Updated since
CharacterIterator::range is now a SimpleRange, use createLegacyEditingPosition.

• editing/VisibleUnits.cpp:

(WebCore::previousBoundary): Ditto.
(WebCore::nextBoundary): Ditto.

• testing/Internals.cpp:

(WebCore::Internals::rangeOfStringNearLocation): Updated since
findClosestPlainText now returns a SimpleRange, use createLiveRange.

Source/WebKit:

• WebProcess/WebPage/Cocoa/WebPageCocoa.mm: Removed unneeded include of

TextIterator.h.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeNearPositionMatchesText): Removed unused originalRange argument,
changed return type to Optional<SimpleRange> since findClosestPlainText now
returns a SimpleRange.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Updated since
rangeNearPositionMatchesText now returns Optional<SimpleRange>, use createLiveRange.
(WebKit::WebPage::requestDocumentEditingContext): Updated since
CharacterIterator::range returns SimpleRange, use createLiveRange.

3:17 PM Changeset in webkit [258474] by beidson@apple.com

• 3 edits in trunk/Source/WebKit

Gather PDF scripts to run on a background thread.
​https://bugs.webkit.org/show_bug.cgi?id=209063

Reviewed by Geoff Garen.

In incremental loading mode, gathering document scripts will sometimes require PDFKit/CG
to lock and wait on data loads from our data provider.

So if we gather them on the main thread, we will hang the main thread and therefore deadlock
with our data provider thread/queue.

So let's gather those scripts on a background thread!

• WebProcess/Plugins/PDF/PDFPlugin.h:
• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::threadEntry):
(WebKit::PDFPlugin::ByteRangeRequest::completeWithAccumulatedData):
(WebKit::PDFPlugin::documentDataDidFinishLoading):
(WebKit::PDFPlugin::installPDFDocument):
(WebKit::PDFPlugin::streamDidFinishLoading):
(WebKit::PDFPlugin::manualStreamDidFinishLoading):
(WebKit::PDFPlugin::tryRunScriptsInPDFDocument): Only actually gathers scripts to execute if there

is a m_pdfDocument and the entire document data finished loading.

(WebKit::PDFPlugin::pdfDocumentDidLoad): Deleted.
(WebKit::PDFPlugin::runScriptsInPDFDocument): Deleted.

3:04 PM Changeset in webkit [258473] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][TFC] Fill in the gaps with anonymous table cell boxes
​https://bugs.webkit.org/show_bug.cgi?id=209114
<rdar://problem/60458806>

Reviewed by Antti Koivisto.

Source/WebCore:

17.5 Visual layout of table contents
A "missing cell" is a cell in the row/column grid that is not
occupied by an element or pseudo-element. Missing cells are rendered
as if an anonymous table-cell box occupied their position in the grid.
(​https://www.w3.org/TR/CSS22/tables.html)

This helps to keep TableGrid an actual grid.

Test: fast/layoutformattingcontext/table-missing-cells-simple.html

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::buildTableStructure):

LayoutTests:

• fast/layoutformattingcontext/table-missing-cells-simple-expected.html: Added.
• fast/layoutformattingcontext/table-missing-cells-simple.html: Added.

12:53 PM Changeset in webkit [258472] by Adrian Perez de Castro

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.26

Merge r257720 - ASSERT(m_column != unsetColumnIndex) in RenderTable::cellBefore
​https://bugs.webkit.org/show_bug.cgi?id=208397

Patch by Doug Kelly <Doug Kelly> on 2020-03-02
Reviewed by Zalan Bujtas.

Source/WebCore:

When inserting a cell into a table row which is not visible, this can lead to attempting to compute the repaint
rects during tree building. Instead, mark the layer as dirty using dirtyVisibleContentStatus(), and the visibility
will be recomputed at a later time.

Test: fast/table/insert-cell-invisible-parent.html

• rendering/RenderElement.cpp:

(WebCore::RenderElement::insertedIntoTree):

LayoutTests:

• fast/table/insert-cell-invisible-parent-expected.txt: Added.
• fast/table/insert-cell-invisible-parent.html: Added.

12:53 PM Changeset in webkit [258471] by Adrian Perez de Castro

• 3 edits
  4 adds in releases/WebKitGTK/webkit-2.26

Merge r257897 - Crash in SVGElement::removeEventListener with symbol element
​https://bugs.webkit.org/show_bug.cgi?id=207920

Patch by Doug Kelly <Doug Kelly> on 2020-03-04
Reviewed by Ryosuke Niwa.

Source/WebCore:

Resolves a crash in SVGElement::removeEventListener by only attaching the events to the window if the SVG element is both the outermost
SVG element, in addition to ensuring the SVG element is attached to the tree. The symbol element's behavior when referenced by a use
tag actually creates an svg tag instead, so the SVGSVGElement's special behavior for copying attributes is vital.

Note that Chrome and Firefox have a similar behavior for detached SVG elements as to what this change creates: in both other browsers,
onerror is not fired for a detached svg element, and in Firefox, onresize is not fired for a detached svg element (it is however fired
in Chrome).

Tests: fast/events/detached-svg-parent-window-events.html

fast/events/onerror-svg-symbol.html

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::parseAttribute):

LayoutTests:

• fast/events/detached-svg-parent-window-events-expected.txt: Added.
• fast/events/detached-svg-parent-window-events.html: Added.
• fast/events/onerror-svg-symbol-expected.txt: Added.
• fast/events/onerror-svg-symbol.html: Added.

12:52 PM Changeset in webkit [258470] by Adrian Perez de Castro

• 2 edits in releases/WebKitGTK/webkit-2.26/Source/bmalloc

Merge r258142 - Build failure on ppc64le if unix is undefined
​https://bugs.webkit.org/show_bug.cgi?id=207906

Patch by Mike Gorse <​mgorse@suse.com> on 2020-03-09
Reviewed by Yusuke Suzuki.

• bmalloc/BPlatform.h: Check for unix along with unix.

12:19 PM Changeset in webkit [258469] by Peng Liu

• 10 edits
  2 deletes in trunk

Cleanup RenderMediaControls.cpp and RenderMediaControlElements.cpp
​https://bugs.webkit.org/show_bug.cgi?id=209008

Reviewed by Daniel Bates.

Source/WebCore:

Merge RenderMediaControls.[h|cpp] and RenderMediaControlElements.[h|cpp].
Remove class RenderMediaVolumeSliderContainer because we can use RenderBlockFlow
to render MediaControlTextTrackContainerElement.

No new tests, no functional change.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• html/shadow/MediaControlElementTypes.cpp:
• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createElementRenderer):

• rendering/RenderMediaControlElements.cpp: Removed.
• rendering/RenderMediaControlElements.h: Removed.
• rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
(WebCore::RenderMediaControlTimelineContainer::RenderMediaControlTimelineContainer):
(WebCore::RenderMediaControlTimelineContainer::layout):

• rendering/RenderMediaControls.h:
• rendering/RenderThemeMac.mm:

LayoutTests:

Remove unused code in a test.

• media/track/track-cue-rendering-rtl.html:

12:01 PM Changeset in webkit [258468] by dbates@webkit.org

• 3 edits in trunk/Source/WebCore

Share HitTestResult::addNodeToListBasedTestResult() impl for LayoutRect and FloatRect overloads
​https://bugs.webkit.org/show_bug.cgi?id=209107

Reviewed by Brady Eidson.

Remove code duplication for adding a node to the result set.

• rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToListBasedTestResultCommon): Added.
(WebCore::HitTestResult::addNodeToListBasedTestResult): Write in terms of addNodeToListBasedTestResultCommon().

• rendering/HitTestResult.h:

9:10 AM Changeset in webkit [258467] by commit-queue@webkit.org

• 2 edits in trunk

[CMake] Warning when ccache is not installed
​https://bugs.webkit.org/show_bug.cgi?id=208952

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-14
Reviewed by Daniel Bates.

Change the warning when ccache is not installed to a status message. We shouldn't be
printing warnings except when there is an actual problem.

• Source/cmake/WebKitCCache.cmake:

5:57 AM Changeset in webkit [258466] by Alan Bujtas

• 3 edits
  2 adds in trunk

[Tree building] Reset the fragmented flow status before calling child.willBeRemovedFromTree.
​https://bugs.webkit.org/show_bug.cgi?id=209100
<rdar://problem/60434672>

Reviewed by Simon Fraser.

Source/WebCore:

::willBeRemovedFromTree() assumes all the cleanup has happened and it's the final step before calling d'tor.
It clears m_fragmentList that resetFragmentedFlowStateOnRemoval() later checks for consistency (m_fragmentList.contains(fragment)).

Test: fast/multicol/reparent-fragment-flow-content.html

• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::detachFromRenderElement):

LayoutTests:

• fast/multicol/reparent-fragment-flow-content-expected.txt: Added.
• fast/multicol/reparent-fragment-flow-content.html: Added.

3:22 AM Changeset in webkit [258465] by commit-queue@webkit.org

• 10 edits in trunk

Set Origin header value to null rather than omitting it
​https://bugs.webkit.org/show_bug.cgi?id=186030

Patch by Rob Buis <​rbuis@igalia.com> on 2020-03-14
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update improved test result.

• web-platform-tests/fetch/origin/assorted.window-expected.txt:

Source/WebCore:

For every redirect, addHTTPOriginIfNeeded should be called to
make sure that the tainted origin logic is applied [1, Step 10] and
thus the request after redirect has the correct Origin header.

Make AppleWin treat 308 redirects like 307 and so keeping http
methods across redirects. This is similar to
​https://bugs.webkit.org/show_bug.cgi?id=154348.

[1] ​https://fetch.spec.whatwg.org/#concept-http-network-or-cache-fetch

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::addHTTPOriginIfNeeded):

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):

• platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegate::createResourceRequest):

LayoutTests:

Update improved test result.

• http/tests/security/cors-post-redirect-307-expected.txt:
• http/tests/security/cors-post-redirect-307-pson-expected.txt:
• http/tests/security/cors-post-redirect-308-expected.txt:

12:15 AM Changeset in webkit [258464] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Call SVGTRefElement::buildPendingResource in SVGElement::didFinishInsertingNode
​https://bugs.webkit.org/show_bug.cgi?id=208981

Reviewed by Antti Koivisto.

This patch moves the call to SVGTRefElement::buildPendingResource from SVGElement::insertedIntoAncestor
to SVGElement::didFinishInsertingNode.

• svg/SVGElement.cpp:

(WebCore::SVGElement::insertedIntoAncestor): Return true when the element has a pending resource ID.
(WebCore::SVGElement::didFinishInsertingNode): Added. Calls buildPendingResourcesIfNeeded.

• svg/SVGElement.h:

12:03 AM Changeset in webkit [258463] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix windows build by making configSizeToProtect stay 4KB.

• runtime/JSCConfig.h: