Timeline

Mar 23, 2020:

10:05 PM Changeset in webkit [258908] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Safari jetsams with repeated drawImage/getImageData
​https://bugs.webkit.org/show_bug.cgi?id=207957

Reviewed by Tim Horton.

SubimageCacheWithTimer used a DeferrableOneShotTimer to clear itself, but if content
adds an entry to the cache on every frame (as might content drawing video frames into a canvas)
then the cache was never cleared. Nor was it cleared via a memory warning.

Fix by tracking cache entries by age, and using a repeating timer to prune old images
from the cache. Also hook up the cache to the memory pressure handler, which clears it.

Reduce the timer frequency from 1s to 500ms, since that was observed to reduce the memory use
on the provided testcase from ~600M to ~350M, making jetsam less likely.

Rename m_images to m_imageCounts to make its role clearer.

• page/cocoa/MemoryReleaseCocoa.mm:

(WebCore::platformReleaseMemory):

• platform/graphics/cg/SubimageCacheWithTimer.cpp:

(WebCore::SubimageCacheWithTimer::clear):
(WebCore::SubimageCacheAdder::translate):
(WebCore::SubimageCacheWithTimer::SubimageCacheWithTimer):
(WebCore::SubimageCacheWithTimer::pruneCacheTimerFired):
(WebCore::SubimageCacheWithTimer::prune):
(WebCore::SubimageCacheWithTimer::subimage):
(WebCore::SubimageCacheWithTimer::clearImageAndSubimages):
(WebCore::SubimageCacheWithTimer::clearAll):
(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired): Deleted.

• platform/graphics/cg/SubimageCacheWithTimer.h:

9:51 PM Changeset in webkit [258907] by stephan.szabo@sony.com

• 2 edits in trunk/Source/WebCore

[WinCairo][PlayStation] Failure to build with ENABLE_XSLT=OFF
​https://bugs.webkit.org/show_bug.cgi?id=209454

Reviewed by Ross Kirsling.

No new tests, build fix.

• xml/parser/XMLDocumentParserLibxml2.cpp:

9:48 PM Changeset in webkit [258906] by Alan Bujtas

• 8 edits
  2 copies in trunk

becu.org: Placeholder text "Search" is cut off
​https://bugs.webkit.org/show_bug.cgi?id=209447
<rdar://problem/45951728>

Reviewed by Simon Fraser.

Source/WebCore:

'line-height: initial' ensures that that the placeholder text is visible and properly positioned when the input itself has
incompatible values. This is also what Chrome has in their UA stylesheet.

Test: fast/forms/placeholder-content-line-height.html

• css/html.css:

(input::placeholder):

LayoutTests:

• fast/forms/placeholder-content-center-expected.html:
• fast/forms/placeholder-content-center.html:
• fast/forms/placeholder-content-line-height-expected.html: Copied from LayoutTests/fast/forms/placeholder-content-center-expected.html.
• fast/forms/placeholder-content-line-height.html: Copied from LayoutTests/fast/forms/placeholder-content-center.html.

9:17 PM Changeset in webkit [258905] by Simon Fraser

• 4 edits in trunk

[mac-wk1] fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=209427

Reviewed by Wenson Hsieh.
Source/WebCore:

In WebKit1, arrow-key scrolls are instantaneous, so scrolling is complete before the test
registers the 'monitor wheel events' callback. However, nothing triggers a subsequent rendering
update, so the test never completes.

Fix by having WheelEventTestMonitor::setTestCallbackAndStartMonitoring() trigger a rendering
update.

• page/WheelEventTestMonitor.cpp:

(WebCore::WheelEventTestMonitor::setTestCallbackAndStartMonitoring):

Tools:

0 => NULL

• DumpRenderTree/mac/DumpRenderTree.mm:

(invalidateAnyPreviousWaitToDumpWatchdog):

9:09 PM Changeset in webkit [258904] by Alan Bujtas

• 13 edits in trunk/Source/WebCore

[LFC] Layout::Box::initialContainingBlock() should return const InitialContainingBlock&
​https://bugs.webkit.org/show_bug.cgi?id=209406
<rdar://problem/60749715>

Reviewed by Antti Koivisto.

Use is<InitialContainingBlock> where applicable.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):
(WebCore::Layout::FormattingContext::collectOutOfFlowDescendantsIfNeeded):

• layout/FormattingContextQuirks.cpp:

(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):

• layout/blockformatting/BlockFormattingContextQuirks.cpp:
• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::absoluteDisplayBox):

• layout/invalidation/InvalidationState.cpp:

(WebCore::Layout::InvalidationState::markNeedsUpdate):

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesBlockFormattingContext const):
(WebCore::Layout::Box::containingBlock const):
(WebCore::Layout::Box::formattingContextRoot const):
(WebCore::Layout::Box::initialContainingBlock const):
(WebCore::Layout::Box::isInFormattingContextOf const):
(WebCore::Layout::Box::isOverflowVisible const):

• layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isInitialContainingBlock const):
(WebCore::Layout::Box::isInlineTextBox const):
(WebCore::Layout::Box::isLineBreakBox const):
(WebCore::Layout::Box::isReplacedBox const):

• layout/layouttree/LayoutInitialContainingBlock.cpp:

(WebCore::Layout::InitialContainingBlock::InitialContainingBlock):

• layout/layouttree/LayoutInlineTextBox.cpp:

(WebCore::Layout::InlineTextBox::InlineTextBox):

• layout/layouttree/LayoutLineBreakBox.cpp:

(WebCore::Layout::LineBreakBox::LineBreakBox):

• layout/layouttree/LayoutReplacedBox.cpp:

(WebCore::Layout::ReplacedBox::ReplacedBox):

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutBox):

8:40 PM Changeset in webkit [258903] by Simon Fraser

• 2 edits in trunk/LayoutTests

[ Mac wk2 ] tiled-drawing/scrolling/scroll-iframe-latched-selects.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209283

Unreviewed test gardening.

The test needs to call monitorWheelEvents() before each gesture.

• tiled-drawing/scrolling/scroll-iframe-latched-selects.html:

8:20 PM Changeset in webkit [258902] by ddkilzer@apple.com

• 3 edits in trunk/Source/WebKit

IPC::Decoder::decodeFixedLengthData() should be marked WARN_UNUSED_RETURN
<​https://webkit.org/b/209448>
<rdar://problem/60797998>

Reviewed by Chris Dumez.

• Platform/IPC/ArgumentCoders.h:

(struct VectorArgumentCoder::decode):

• Check the return value of Decoder::decodeFixedLengthData().
• Platform/IPC/Decoder.h:

(IPC::Decoder::decodeFixedLengthData): Add WARN_UNUSED_RETURN.

8:02 PM Changeset in webkit [258901] by keith_miller@apple.com

• 8 edits in trunk/Source/JavaScriptCore

HasIndexedProperty should know about sane chain
​https://bugs.webkit.org/show_bug.cgi?id=209457

Reviewed by Saam Barati.

This patch makes it so HasIndexedProperty is aware of
sane chain. This is useful because, most of the time we do an
indexed in it is on an array. If the array has a sane chain (i.e.
no indexed properties on it's prototypes and has the default
prototype chain) then we can just test for the index being a hole.

Note, we could also just convert OOB indices into false but that
should happen in another patch.
​https://bugs.webkit.org/show_bug.cgi?id=209456

I didn't add any tests because it turns out we already have a ton.
I know this because I broke most of them repeatedly... >.>

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::setSaneChainIfPossible):
(JSC::DFG::FixupPhase::convertToHasIndexedProperty):

• dfg/DFGNodeType.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileHasIndexedProperty):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):
(JSC::FTL::DFG::LowerDFGToB3::speculateAndJump):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::isEmpty):

7:44 PM Changeset in webkit [258900] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r257791): event breakpoint icon should be [E]
​https://bugs.webkit.org/show_bug.cgi?id=209434

Reviewed by Timothy Hatcher.

• UserInterface/Images/TypeIcons.svg:

• UserInterface/Views/PathComponentIcons.css:

(.snapshot-list-icon .icon):
(@media (prefers-color-scheme: dark) .snapshot-list-icon .icon):
Drive-by: make a separate "HeapSnapshotList" target so that it won't be affected if "Events"

is ever changed.

7:38 PM Changeset in webkit [258899] by Justin Fan

• 4 edits in trunk/Source/WebCore

[ Mac wk2 Debug ] webgpu/whlsl/vector-compare.html is flaky crashing.
​https://bugs.webkit.org/show_bug.cgi?id=209024

Reviewed by Myles C. Maxfield.

Prevent GPUBindGroup destructor from accidentally dereferencing GPUBindGroupAllocator too many times
if the owning GPUDevice has already been destroyed. A GPUBindGroupAllocator should reset whenever its
spawned GPUBindGroups are all cleaned up.

Covered by existing tests.

• platform/graphics/gpu/GPUBindGroupAllocator.h:
• platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm:

(WebCore::GPUBindGroupAllocator::allocateAndSetEncoders):
(WebCore::GPUBindGroupAllocator::tryReset):

• platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm:

(WebCore::GPUBindGroup::~GPUBindGroup):

7:22 PM Changeset in webkit [258898] by Devin Rousso

• 4 edits in trunk/Source/WebInspectorUI

REGRESSION(r257759, r258623): Web Inspector: Settings icon sometimes placed below the tab bar
​https://bugs.webkit.org/show_bug.cgi?id=208603
<rdar://problem/60108967>

Reviewed by Timothy Hatcher.

• UserInterface/Views/TabBar.js:

(WI.TabBar.prototype.layout):
If the total width of all WI.GeneralTabBarItem is not an integer, it needs to be rounded
when compared to the width of the container WI.TabBar. This is be necessary because CSS
often rounds to the nearest pixel, meaning that 99.5px would actually render as 100px,
whereas 99.4px would render as 99px.

• UserInterface/Views/TabBar.css:

(body:not(.docked) .tab-bar > .tabs:not(.calculate-width) > .item:not(.pinned)): Added.
(.tab-bar > .tabs.calculate-width > .item:not(.pinned)): Added.
(body:not(.docked) .tab-bar > .tabs > .item:not(.pinned)): Deleted.
(.tab-bar > .tabs.calculate-width > .item): Deleted.
When undocked, force all WI.GeneralTabBarItem to take up as little width as possible when
resizing so that if there isn't enough room for all of them, any that flex-wrap won't be
incorrectly perceived as needing a much larger width.

• UserInterface/Debug/Bootstrap.css:

(.tab-bar > .navigation-bar .inspect-inspector):
Ensure that the "inspect inspector" navigation item has an integer pixel width.

7:05 PM Changeset in webkit [258897] by dino@apple.com

• 2 edits in trunk/Tools

webkitpy Git class must expose the repository URL
​https://bugs.webkit.org/show_bug.cgi?id=209439
<rdar://problem/60792668>

Reviewed by Simon Fraser.

Some internal tools were relying on the svn_url() method
that was changed/removed in r258164. Add a replacement.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git.svn_repository_url):

6:56 PM Changeset in webkit [258896] by Wenson Hsieh

• 14 edits in trunk/Source

Remove the unused method PasteboardStrategy::uniqueName()
​https://bugs.webkit.org/show_bug.cgi?id=209452

Reviewed by Tim Horton.

Source/WebCore:

This was introduced in <​https://trac.webkit.org/r107844>, where it was used in the implementation of
Editor::newGeneralClipboard. However, this was subsequently removed in <​https://trac.webkit.org/r150351>.

No change in behavior.

• platform/PasteboardStrategy.h:
• platform/PlatformPasteboard.h:
• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::uniqueName): Deleted.

• platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::uniqueName): Deleted.

Source/WebKit:

See WebCore/ChangeLog for more detail.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::getPasteboardUniqueName): Deleted.

• UIProcess/WebPasteboardProxy.h:
• UIProcess/WebPasteboardProxy.messages.in:
• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::uniqueName): Deleted.

• WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

See WebCore/ChangeLog for more detail.

• WebCoreSupport/WebPlatformStrategies.h:
• WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::uniqueName): Deleted.

6:40 PM Changeset in webkit [258895] by Said Abou-Hallawa

• 2 edits in trunk/LayoutTests

Layout Test imported/w3c/web-platform-tests/hr-time/test_cross_frame_start.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=196944

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

Remove flaky expectation for the test.

6:31 PM Changeset in webkit [258894] by commit-queue@webkit.org

• 12 edits in trunk

Unreviewed, reverting r258891.
​https://bugs.webkit.org/show_bug.cgi?id=209459

Introduced layout test failures (Requested by perarne on
#webkit).

Reverted changeset:

"[Cocoa] Deny access to database mapping service"
​https://bugs.webkit.org/show_bug.cgi?id=209339
​https://trac.webkit.org/changeset/258891

6:22 PM Changeset in webkit [258893] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Fix memory leak introduced in r257726
​https://bugs.webkit.org/show_bug.cgi?id=208399

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-03-23
Reviewed by John Wilander.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::websiteDataStore):
We were leaking page configurations.

5:42 PM Changeset in webkit [258892] by ddkilzer@apple.com

• 2 edits in trunk/LayoutTests

[Win] http/tests/misc/last-modified-parsing.html always fails on Windows EWS
<​https://webkit.org/b/209455>

Unreviewed test gardening.

• platform/win/TestExpectations:

5:15 PM Changeset in webkit [258891] by pvollan@apple.com

• 12 edits in trunk

[Cocoa] Deny access to database mapping service
​https://bugs.webkit.org/show_bug.cgi?id=209339
Source/WebKit:

<rdar://problem/56966010>

Reviewed by Brent Fulgham.

In order for the WebContent process to not have permantent access to the database mapping service,
this patch creates an extension for the service in the UI process, sends it to the WebContent
process, where it is consumed. Then, an API call is made which will map the database, and next the
WebContent process will revoke the extension. The WebContent process has then mapped the database,
and access to the database mapping service is no longer needed.

Tested by: fast/sandbox/ios/sandbox-mach-lookup.html

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

• WebProcess/com.apple.WebProcess.sb.in:

Source/WTF:

<rdar://problem/56966010>

Reviewed by Brent Fulgham.

Disable the use of UTTypeRecord swizzling, since this is not needed with the new approach
of denying the database mapping service in this patch.

• wtf/PlatformUse.h:

LayoutTests:

Reviewed by Brent Fulgham.

• fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
• fast/sandbox/ios/sandbox-mach-lookup.html:

5:06 PM Changeset in webkit [258890] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Add console message when legacy TLS is used
​https://bugs.webkit.org/show_bug.cgi?id=209444

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-03-23
Reviewed by Darin Adler.

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveResponse):

4:48 PM Changeset in webkit [258889] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ iOS wk2 Debug ] fast/text/control-characters/visible-control-characters-1.html is flaky crashing.
​https://bugs.webkit.org/show_bug.cgi?id=209450

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

4:42 PM Changeset in webkit [258888] by Megan Gardner

• 2 edits in trunk/Source/WebKit

Removed FIXME comment for work that had already been done.

• UIProcess/ios/WKSyntheticTapGestureRecognizer.mm:

(-[WKSyntheticTapGestureRecognizer touchesEnded:withEvent:]):

4:28 PM Changeset in webkit [258887] by ysuzuki@apple.com

• 9 edits
  1 add in trunk

[JSC] Caller of Delete IC should emit write-barrier onto owner
​https://bugs.webkit.org/show_bug.cgi?id=209392
<rdar://problem/60683173>

Reviewed by Saam Barati.

JSTests:

• stress/delete-ic-requires-write-barrier.js: Added.

(foo):

Source/JavaScriptCore:

DeleteIC can change Structure of the owner cell in the fast path. However it is not emitting write-barrier,
while we are writing a Structure cell id into a JSObject's header.
In this patch,

1. Emit write-barrier in baseline. Be careful about when emitting write-barrier since it clobbers registers.
2. DFG and FTL recognize DeleteById / DeleteByVal in DFGStoreBarrierInsertionPhase.
3. DFGStoreBarrierInsertionPhase only accepts nodes which base is speculated as a Cell. Current DeleteById / DeleteByVal can have UntypedUse base value, but we miss emitting write-barrier DeleteById / DeleteByVal with UntypedUse in the fast path. In this patch, we optimize DeleteById / DeleteByVal only when we speculate child1 as a cell. We can take the further steps after fixing this bug, e.g. (1) accepting UntypedUse in store-barrier-insertion[1] or (2) emitting write-barrier if child1's speculation is UntypedUse. For now, we fix the bug by taking a generic path when child1 is not speculated as a cell. And we can optimize it in a separate change[2].

This is following the design of PutIC.
Currently, we use ShouldFilterBase for emitWriteBarrier. But we could use UnconditionalWriteBarrier here since
we already filter non-cells in Baseline's hot path. I filed it as a separate bug in [3].

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=209396
[2]: ​https://bugs.webkit.org/show_bug.cgi?id=209397
[3]: ​https://bugs.webkit.org/show_bug.cgi?id=209395

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileDeleteById):
(JSC::DFG::SpeculativeJIT::compileDeleteByVal):

• dfg/DFGStoreBarrierInsertionPhase.cpp:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileDeleteById):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteByVal):

• jit/JIT.h:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_del_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitWriteBarrier):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_put_by_id):

4:21 PM Changeset in webkit [258886] by Alan Coon

• 1 copy in tags/Safari-610.1.7.3.1

Tag Safari-610.1.7.3.1.

4:18 PM Changeset in webkit [258885] by Jason_Lawrence

• 3 edits in trunk/LayoutTests

[ Mac Debug and iOS ] imported/w3c/web-platform-tests/navigation-timing/test_timing_attributes_order.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209446

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac/TestExpectations:

4:00 PM Changeset in webkit [258884] by wilander@apple.com

• 30 edits
  3 adds in trunk

Add the capability to change all of a website's cookies to SameSite=Strict
​https://bugs.webkit.org/show_bug.cgi?id=209369
<rdar://problem/60710690>

Reviewed by Alex Christensen and David Kilzer.

Source/WebCore:

Test: http/tests/resourceLoadStatistics/set-all-cookies-to-same-site-strict.html

• platform/network/NetworkStorageSession.cpp:

(WebCore::NetworkStorageSession::setAllCookiesToSameSiteStrict):

Stub function for non-Cocoa platforms.

• platform/network/NetworkStorageSession.h:
• platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::setAllCookiesToSameSiteStrict):

• testing/Internals.h:

Added code to expose SameSite=None and path properties of cookies.
However, they don't seem to carry over so I'll have to revisit the
internal workings.

Source/WebKit:

These changes add test infrastructure to run function
WebCore::NetworkStorageSession::setAllCookiesToSameSiteStrict() in the
network process.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setToSameSiteStrictCookiesForTesting):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetResourceLoadStatisticsToSameSiteStrictCookiesForTesting):

• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::setToSameSiteStrictCookiesForTesting):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setResourceLoadStatisticsToSameSiteStrictCookiesForTesting):

• UIProcess/WebsiteData/WebsiteDataStore.h:

Source/WTF:

• wtf/PlatformHave.h:

Adds HAVE_CFNETWORK_SAMESITE_COOKIE_API for macOS Catalina and up,
iOS 13 and up, Catalyst, watchOS, and Apple TV.

Tools:

These changes add TestRunner function statisticsSetToSameSiteStrictCookies().

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::statisticsSetToSameSiteStrictCookies):
(WTR::TestRunner::statisticsCallDidSetToSameSiteStrictCookiesCallback):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::setStatisticsToSameSiteStrictCookies):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didSetToSameSiteStrictCookies):

• WebKitTestRunner/TestInvocation.h:

LayoutTests:

• http/tests/resourceLoadStatistics/resources/set-all-kinds-of-cookies.php: Added.
• http/tests/resourceLoadStatistics/set-all-cookies-to-same-site-strict-expected.txt: Added.
• http/tests/resourceLoadStatistics/set-all-cookies-to-same-site-strict.html: Added.
• platform/ios/TestExpectations:

Marked http/tests/resourceLoadStatistics/set-all-cookies-to-same-site-strict.html
as Pass.

• platform/mac-wk2/TestExpectations:

Marked http/tests/resourceLoadStatistics/set-all-cookies-to-same-site-strict.html
as Pass for Catalina+.

• platform/wk2/TestExpectations:

Skipped http/tests/resourceLoadStatistics/set-all-cookies-to-same-site-strict.html
since it's only available on macOS Catalina and up and the functionality is not
implemented on non-Cocoa platforms.

3:59 PM Changeset in webkit [258883] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[WPE][GTK] Allow distributors to brand user agent
​https://bugs.webkit.org/show_bug.cgi?id=162611

Unreviewed, un-break my previous commit.

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-23

• platform/glib/UserAgentGLib.cpp:

(WebCore::standardUserAgent):

3:53 PM Changeset in webkit [258882] by Simon Fraser

• 4 edits in trunk/Source/WebCore

[iOS WK2] compositing/overflow/dynamic-composited-scrolling-status.html asserts
​https://bugs.webkit.org/show_bug.cgi?id=209440
<rdar://problem/60705261>

Reviewed by Wenson Hsieh.

nonFastScrollableRectsForTesting() needs to eagerly update event regions after r258528,
as we do for touchEventRectsForEventForTesting().

Also renamed the function so it's clear that it's for testing only.

• page/Page.cpp:

(WebCore::Page::nonFastScrollableRectsForTesting):
(WebCore::Page::nonFastScrollableRects): Deleted.

• page/Page.h:
• testing/Internals.cpp:

(WebCore::Internals::nonFastScrollableRects const):

3:48 PM Changeset in webkit [258881] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ Mac wk1 Debug ] http/tests/css/shared-stylesheet-mutation-preconstruct.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209442

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:44 PM Changeset in webkit [258880] by dino@apple.com

• 4 edits in trunk

Set important EGL context attributes
​https://bugs.webkit.org/show_bug.cgi?id=208724

Patch by James Darpinian <James Darpinian> on 2020-03-06
Reviewed by Dean Jackson.

Re-landing after r258875.

These EGL context attributes are important to make ANGLE's validation correct for
WebGL contexts. ROBUST_RESOURCE_INITIALIZATION is especially important; the lack
of it may be a root cause of some of the test flakiness we have seen. With this
change WebKit's EGL context attributes now match Chromium's for ANGLE/WebGL
contexts.

• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):

3:14 PM Changeset in webkit [258879] by Nikos Mouchtaris

• 2 edits in trunk/Tools

Uneviewed, added myself to contributors.json.

• Scripts/webkitpy/common/config/contributors.json:

2:59 PM Changeset in webkit [258878] by Alan Bujtas

• 2 edits in trunk/LayoutTests

[Win] Unreviewed test gardening.

• platform/win/TestExpectations:

2:50 PM Changeset in webkit [258877] by commit-queue@webkit.org

• 5 edits in trunk

[GTK] Allow distributors to brand user agent
​https://bugs.webkit.org/show_bug.cgi?id=162611

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-23
Reviewed by Adrian Perez de Castro.

.:

Add build option for inserting distributor branding into the user agent string.

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

Source/WebCore:

• platform/glib/UserAgentGLib.cpp:

(WebCore::buildUserAgentString):

2:28 PM Changeset in webkit [258876] by Alan Coon

• 8 edits in branches/safari-610.1.7.3-branch/Source

Versioning.

2:28 PM Changeset in webkit [258875] by dino@apple.com

• 11 edits in trunk

[WebGL] Skip vertexAttrib0 simulation when using ANGLE
​https://bugs.webkit.org/show_bug.cgi?id=209416
<rdar://problem/60765734>

Reviewed by Antoine Quint.

Source/WebCore:

When using ANGLE as a backend, we do not need to simulate a
missing vertexAttrib0 at the WebGL layer, since ANGLE will
handle it for us.

This causes a couple of tests to begin passing (they were marked as
failures). It also allows us to re-land r258025, which was rolled
out in r258226.

• html/canvas/WebGL2RenderingContext.cpp: Wrap any code that does vertexAttrib0

simulation in a !USE(ANGLE).
(WebCore::WebGL2RenderingContext::initializeVertexArrayObjects):

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::initializeVertexArrayObjects):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::~WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::disableVertexAttribArray):
(WebCore::WebGLRenderingContextBase::validateDrawArrays):
(WebCore::WebGLRenderingContextBase::validateDrawElements):
(WebCore::WebGLRenderingContextBase::drawArrays):
(WebCore::WebGLRenderingContextBase::drawElements):
(WebCore::WebGLRenderingContextBase::getActiveUniform):
(WebCore::WebGLRenderingContextBase::getVertexAttrib):
(WebCore::WebGLRenderingContextBase::vertexAttribfImpl):
(WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):

• html/canvas/WebGLRenderingContextBase.h:
• html/canvas/WebGLVertexArrayObjectBase.cpp:

(WebCore::WebGLVertexArrayObjectBase::unbindBuffer):

LayoutTests:

Remove the console logging that is no longer output when using ANGLE.
Remove failing expectations for some tests.

• fast/canvas/webgl/index-validation-with-subsequent-draws-expected.txt:
• fast/canvas/webgl/out-of-bounds-simulated-vertexAttrib0-drawArrays-expected.txt:
• platform/mac/TestExpectations:

2:09 PM Changeset in webkit [258874] by ysuzuki@apple.com

• 9 edits
  1 add in trunk

[JSC] DFG OSR exit cannot find StructureStubInfo for put_by_val if CodeBlock is once converved from Baseline to LLInt
​https://bugs.webkit.org/show_bug.cgi?id=209327
<rdar://problem/60631061>

Reviewed by Saam Barati.

JSTests:

• stress/osr-exit-attempts-to-find-stubinfo-which-is-cleared-by-previous-baseline-to-llint-conversion.js: Added.

(setter):
(foo):

Source/JavaScriptCore:

DFG compiles op_put_by_val as PutById and inlines SetterCall only when DFG found StructureStubInfo for this op_put_by_val.
However, it is still possible that DFG OSR exit cannot find StructureStubInfo for SetterCall generated by op_put_by_val.
Let's consider the following scenario.

1. Baseline CodeBlock (A) is compiled.
2. (A) gets DFG (B).
3. Since (A) collects enough information for put_by_val, (B) can get StructureStubInfo from (A) and compile it as inlined Setter call.
4. (A)'s JITData is destroyed since it is not executed. Then, (A) becomes LLInt.
5. The CodeBlock inlining (A) gets OSR exit. So (A) is executed and (A) eventually gets Baseline CodeBlock again.
6. (B) gets OSR exit. (B) attempts to search for StructureStubInfo in (A) for PutById (originally, put_by_val). But it does not exist since (A)'s JITData is cleared once.

We should just link to doneTarget of ByValInfo when the SetterCall is generated by op_put_by_val. ByValInfo and its doneTarget always exists per op_put_by_val.

• bytecode/ByValInfo.h:

(JSC::ByValInfo::ByValInfo):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::findByValInfo):

• bytecode/CodeBlock.h:
• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::callerReturnPC):

• jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileHasIndexedProperty):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileHasIndexedProperty):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByVal):
(JSC::JIT::privateCompilePutByValWithCachedId):

2:00 PM Changeset in webkit [258873] by dbates@webkit.org

• 10 edits
  1 add in trunk

Support inserting text or dictation alternative by simulating keyboard input
​https://bugs.webkit.org/show_bug.cgi?id=209380
<rdar://problem/59445102>

Reviewed by Darin Adler.

Source/WebKit:

As a workaround for sites the implement their own editing system (e.g. facebook.com)
add a new insertion option that makes the insertion having a passing resemblance
of a person typing. The resemblance is achieved by dispatching DOM events with type
"keydown", "keyup", and "change".

• Shared/Cocoa/InsertTextOptions.cpp:

(IPC::ArgumentCoder<WebKit::InsertTextOptions>::encode):
(IPC::ArgumentCoder<WebKit::InsertTextOptions>::decode):
Encode and decode the new option.

• Shared/Cocoa/InsertTextOptions.h: Default the new option, shouldSimulateKeyboardInput,

to false to keep our current behavior.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _shouldSimulateKeyboardInputOnTextInsertion]): Added. Returns NO when
building without USE(TEXT_INTERACTION_ADDITIONS) to keep the current behavior.

(-[WKContentView insertText:]):
(-[WKContentView insertText:alternatives:style:]):
Set the shouldSimulateKeyboardInput option.

• WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::insertDictatedTextAsync):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::insertTextAsync):
If shouldSimulateKeyboardInput is false then do what we do now. Otherwise, dispatch a DOM event
of type "keydown" and perform the insertion. Then dispatch DOM events of type "keyup" and "change".

Tools:

Add tests to ensure that DOM events are dispatched on insertion when shouldSimulateKeyboardInput
is enabled.

I also added a convenience assertion function, EXPECT_NS_EQUAL, that can
compare NSObjects so long as they implement -isEqual and -description. I
make use of this to compare the actual array of fired DOM events types to
an expected array.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

(TestWebKitAPI::shouldSimulateKeyboardInputOnTextInsertionOverride):
(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/TestCocoa.h:

(TestWebKitAPI::Util::assertNSObjectsAreEqual): Added.
(EXPECT_NS_EQUAL): Added.

• TestWebKitAPI/ios/insert-text.html: Added.

1:53 PM Changeset in webkit [258872] by Alan Coon

• 8 edits in branches/safari-609-branch/Source

Versioning.

1:50 PM Changeset in webkit [258871] by Darin Adler

• 36 edits in trunk

Change TextIterator::rangeLength to not require a live range
​https://bugs.webkit.org/show_bug.cgi?id=209207

Reviewed by Antti Koivisto.

Source/WebCore:

• Renamed TextIterator::rangeLength to characterCount.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rangeMatchesTextNearRange): Use characterCount.
(WebCore::resetNodeAndOffsetForReplacedNode): Ditto.
(WebCore::AXObjectCache::nextCharacterOffset): Ditto.

• accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Ditto.

• accessibility/atk/WebKitAccessibleHyperlink.cpp:

(rangeLengthForObject): Ditto.

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Ditto.

• dom/SimpleRange.h: Export another constructor.

• editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::applyAlternativeTextToRange):
Use characterCount.

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle): Ditto.

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphs): Ditto.

• editing/Editing.cpp:

(WebCore::indexForVisiblePosition): Ditto.

• editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::rangeLength const): Ditto.
(WebCore::TextCheckingParagraph::offsetTo const): Ditto.
(WebCore::TextCheckingParagraph::checkingStart const): Ditto.
(WebCore::TextCheckingParagraph::checkingEnd const): Ditto.
(WebCore::TextCheckingParagraph::checkingLength const): Ditto.
(WebCore::TextCheckingParagraph::automaticReplacementStart const): Ditto.
(WebCore::TextCheckingParagraph::automaticReplacementLength const): Ditto.
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): Ditto.
(WebCore::TextCheckingHelper::isUngrammatical const): Ditto.

• editing/TextIterator.cpp:

(WebCore::TextIterator::rangeLength): Deleted.
(WebCore::characterCount): Like the baove but the argument is SimpleRange
and return is CharacterCount. Even though each individual node is limited
to 32-bit size, ranges covering multiple nodes could have a count of
characters that exceeds 32 bits, so CharacterCount is size_t.
(WebCore::TextIterator::getLocationAndLengthFromRange): Use characterCount.

• editing/TextIterator.h: Added characterCount function,

CharacterCount and CharacterRange types. Removed TextIterator::rangeLength.
Added FIXME comments about the next steps.

• editing/VisiblePosition.cpp:

(WebCore::makeBoundaryPoint): Added.

• editing/VisiblePosition.h: Added makeBoundaryPoint. Also removed

extraneous forward declarations and moved some function bodies out of the
class definition.

• editing/VisibleUnits.cpp:

(WebCore::distanceBetweenPositions): Changed return type to ptrdiff_t.
Use characterCount.

• editing/VisibleUnits.h: Updated for the above.

• editing/cocoa/DataDetection.mm:

(WebCore::detectItemAtPositionWithRange): Use characterCount.

• editing/cocoa/DictionaryLookup.mm:

(WebCore::DictionaryLookup::rangeForSelection): Ditto.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Ditto.

• editing/ios/DictationCommandIOS.cpp:

(WebCore::DictationCommandIOS::doApply): Ditto.

• editing/mac/DictionaryLookupLegacy.mm:

(WebCore::DictionaryLookup::rangeForSelection): Ditto.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Ditto.

• page/EventHandler.cpp:

(WebCore::textDistance): Ditto.

Source/WebKit:

• Shared/EditingRange.cpp:

(WebKit::EditingRange::toRange): Use characterCount.

• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::insertionPointFromCurrentSelection): Changed return type to
CharacterCount and use characterCount.
(WebKit::WebEditorClient::supportsGlobalSelection): Tweaked #if.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::targetFrameForEditing): Use characterCount.

• WebProcess/WebPage/glib/WebPageGLib.cpp:

(WebKit::WebPage::platformEditorState const): Ditto.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeNearPositionMatchesText): Ditto.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformEditorState const): Ditto.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.mm:

(insertionPointFromCurrentSelection): Use characterCount.
(WebEditorClient::requestCandidatesForSelection): Ditto.

• WebView/WebFrame.mm:

(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]): Ditto.

LayoutTests:

• editing/mac/spelling/autocorrection-contraction-expected.txt: Update these expected

results because of changes to delegate callbacks. The test is still passing and this
change is only in the legacy WebKit case (there is a separate result for modern WebKit).
This seems to be a progression, not evidence of a bug.

1:19 PM Changeset in webkit [258870] by Russell Epstein

• 16 edits
  2 adds in branches/safari-609-branch/Source

[Cocoa] Push applicationSDKVersion() down from WebCore into WTF
​https://bugs.webkit.org/show_bug.cgi?id=209030

Reviewed by Simon Fraser.

Source/JavaScriptCore:

dyld_get_program_sdk_version() gives you the wrong answer in the Web Process (or at least
not the answer you actually want). There are already facilities for the UI Process to tell
the Web Process what the real value is, but those functions are currently in WebCore,
which is inaccessible to WTF. This patch is in preparation for
​https://bugs.webkit.org/show_bug.cgi?id=208969 which needs to know this information in WTF.

I also found a few places which were calling dyld_get_program_sdk_version() in JavaScriptCore
and WebCore (which is wrong because those libraries exist in the Web Process), and have fixed
them up to use applicationSDKVersion() instead.

• API/JSWrapperMap.mm:

(supportsInitMethodConstructors):

Source/WebCore:

• html/HTMLObjectElement.cpp:
• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback const):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):

• platform/RuntimeApplicationChecks.h:
• platform/Timer.cpp:

(WebCore::shouldSuppressThreadSafetyCheck):

• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::applicationSDKVersionOverride): Deleted.
(WebCore::setApplicationSDKVersion): Deleted.
(WebCore::applicationSDKVersion): Deleted.

Source/WebKit:

• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCSSOMViewScrollingAPIEnabled):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/PlatformMac.cmake:
• wtf/cocoa/RuntimeApplicationChecksCocoa.cpp: Added.
• wtf/cocoa/RuntimeApplicationChecksCocoa.h: Added.

(WTF::applicationSDKVersionOverride):
(WTF::setApplicationSDKVersion):
(WTF::applicationSDKVersion):

12:46 PM Changeset in webkit [258869] by youenn@apple.com

• 33 edits in trunk/Source

Rename blankURL to aboutBlankURL
​https://bugs.webkit.org/show_bug.cgi?id=209344

Reviewed by Darin Adler.

Source/WebCore:

No change of behavior.

• dom/Document.cpp:

(WebCore::Document::setURL):
(WebCore::Document::completeURL const):
(WebCore::Document::ensureTemplateDocument):

• dom/Document.h:

(WebCore::Document::urlForBindings const):

• dom/InlineStyleSheetOwner.cpp:

(WebCore::parserContextForElement):

• dom/Node.cpp:

(WebCore::Node::baseURI const):

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::WebContentReader::readWebArchive):

• editing/markup.cpp:

(WebCore::createFragmentFromMarkup):

• html/DOMURL.cpp:

(WebCore::DOMURL::create):

• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::openURL):
(WebCore::HTMLFrameElementBase::location const):

• html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterFormToken):
(WebCore::XSSAuditor::filterInputToken):
(WebCore::XSSAuditor::filterButtonToken):
(WebCore::XSSAuditor::isLikelySafeResource):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::maybeLoadEmpty):

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::serverRedirectSourceForHistory const):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadWithDocumentLoader):

• loader/HistoryController.cpp:

(WebCore::HistoryController::currentItemShouldBeReplaced const):
(WebCore::HistoryController::initializeItem):

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestFrame):

• loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createFromSelection):

• page/Location.cpp:

(WebCore::Location::url const):

• page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::shouldInheritSecurityOriginFromOwner):

• platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::markupToCFHTML):

• svg/SVGImageLoader.cpp:

(WebCore::SVGImageLoader::sourceURI const):

Source/WebKit:

• UIProcess/API/C/WKPage.cpp:

(WKPageLoadPlainTextStringWithUserData):

• UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupAddUserStyleSheet):
(WKPageGroupAddUserScript):

• UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_load_plain_text):

• UIProcess/Inspector/WebPageDebuggable.cpp:

(WebKit::WebPageDebuggable::url const):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadDataWithNavigationShared):
(WebKit::WebPageProxy::loadWebArchiveData):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadData):
(WebKit::WebPage::loadAlternateHTML):
(WebKit::WebPage::dumpHistoryForTesting):
(WebKit::WebPage::addUserScript):
(WebKit::WebPage::addUserStyleSheet):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::updateGlobalHistory):

• WebView/WebFrame.mm:

(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

Source/WTF:

Rename blankURL to aboutBlankURL and allow using it without WTF:: prefix.

• wtf/URL.cpp:

(WTF::aboutBlankURL):
(WTF::blankURL): Deleted.

• wtf/URL.h:

12:33 PM Changeset in webkit [258868] by youenn@apple.com

• 4 edits
  1 delete in trunk/Source/WebCore

Remove DOMCache::m_records
​https://bugs.webkit.org/show_bug.cgi?id=209425

Reviewed by Alex Christensen.

We do not need to keep references of FetchRequest and FetchResponse since we clone them before exposing them.
For that reason, remove m_records and directly use records given from the CacheStorageConnection.
Minor refactoring to modernize/improve code readability.

This is a first step towards a future refactoring that will reduce the sending of records from network process to web process
based on the request parameters: record filtering will be done in network process instead of web process.

No change of behavior.

• Modules/cache/DOMCache.cpp:

(WebCore::createResponse):
(WebCore::DOMCache::doMatch):
(WebCore::DOMCache::cloneResponses):
(WebCore::DOMCache::matchAll):
(WebCore::createRequest):
(WebCore::DOMCache::keys):
(WebCore::DOMCache::retrieveRecords):
(WebCore::DOMCache::queryCache):
(WebCore::DOMCache::queryCacheWithTargetStorage):
(WebCore::DOMCache::batchDeleteOperation):
(WebCore::DOMCache::batchPutOperation):
(WebCore::copyRequestRef): Deleted.
(WebCore::queryCacheMatch): Deleted.
(WebCore::DOMCache::updateRecords): Deleted.

• Modules/cache/DOMCache.h:

12:32 PM Changeset in webkit [258867] by Alan Coon

• 1 copy in branches/safari-610.1.7.3-branch

New branch.

12:31 PM Changeset in webkit [258866] by commit-queue@webkit.org

• 12 edits in trunk

XMLHttpRequest: getAllResponseHeaders() sorting
​https://bugs.webkit.org/show_bug.cgi?id=200565

Patch by Rob Buis <​rbuis@igalia.com> on 2020-03-23
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved test result.

• web-platform-tests/xhr/getallresponseheaders-expected.txt:

Source/WebCore:

Sort headers using the ASCII-uppercase header name as key but use ASCII-lowercase header
names in the string result.

Nehavior matches Firefox and Chrome.

Test: imported/web-platform-tests/xhr/getallresponseheaders.htm

[1] ​https://xhr.spec.whatwg.org/#dom-xmlhttprequest-getallresponseheaders

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::getAllResponseHeaders const):

Source/WTF:

Add a new manipulator that can efficiently convert
Strings to lower or upper ASCII.

• wtf/text/StringConcatenate.h:

(WTF::lowercase):
(WTF::uppercase):

• wtf/text/StringView.cpp:

(WTF::getCharactersWithASCIICaseInternal):
(WTF::StringView::getCharactersWithASCIICase const):

• wtf/text/StringView.h:

LayoutTests:

Update improved test results.

• platform/ios/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt:
• platform/mac-highsierra/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt:
• platform/mac-mojave/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt:

12:05 PM Changeset in webkit [258865] by Ross Kirsling

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed, address Yusuke's feedback on r258801.

• builtins/RegExpPrototype.js:

(globalPrivate.hasObservableSideEffectsForRegExpSplit):

• bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_tryGetById):

11:49 AM Changeset in webkit [258864] by Truitt Savell

• 13 edits in trunk/Source/WebCore

Unreviewed, reverting r258847.

Broke testing on Mac Debug with an Assert

Reverted changeset:

"[LFC] Layout::Box::initialContainingBlock() should return
const InitialContainingBlock&"
​https://bugs.webkit.org/show_bug.cgi?id=209406
​https://trac.webkit.org/changeset/258847

11:47 AM Changeset in webkit [258863] by Kate Cheney

• 5 edits in trunk

Add checks for app-bound navigations when evaluating user style sheets
​https://bugs.webkit.org/show_bug.cgi?id=209368
<rdar://problem/60204230>

Reviewed by Brent Fulgham.

Source/WebCore:

• page/Page.cpp:

(WebCore::Page::injectUserStyleSheet):
If the style sheet is for a specific WebView, it will have a pageID
and we can check for app-bound navigation in the page object.

• style/StyleScopeRuleSets.cpp:

(WebCore::Style::ScopeRuleSets::initializeUserStyle):
If the user style sheet is being applied to all WebViews, we can check for
for a page's existence and navigation state here before the style sheet is
updated.

Tools:

Tested cases based on those in UserContentController.mm.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
(expectScriptEvaluatesToColor):
(TEST):

11:40 AM Changeset in webkit [258862] by achristensen@apple.com

• 20 edits in trunk

Add SPI to move localStorage to a different domain
​https://bugs.webkit.org/show_bug.cgi?id=209260
<rdar://problem/60285683>

Reviewed by Brady Eidson.

Source/WebKit:

Covered by an API test.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::renameDomainInWebsiteData):
(WebKit::NetworkProcess::getLocalStorageOriginDetails):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/WebStorage/LocalStorageNamespace.cpp:

(WebKit::LocalStorageNamespace::renameDomain):

• NetworkProcess/WebStorage/LocalStorageNamespace.h:
• NetworkProcess/WebStorage/StorageArea.cpp:

(WebKit::StorageArea::close):

• NetworkProcess/WebStorage/StorageArea.h:
• NetworkProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::renameDomain):

• NetworkProcess/WebStorage/StorageManager.h:
• NetworkProcess/WebStorage/StorageManagerSet.cpp:

(WebKit::StorageManagerSet::renameDomain):

• NetworkProcess/WebStorage/StorageManagerSet.h:
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _renameDomain:to:forDataOfTypes:completionHandler:]):

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::renameDomainInWebsiteData):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::renameDomainInWebsiteData):

• UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

11:23 AM Changeset in webkit [258861] by Ross Kirsling

• 5 edits in trunk

Catch parameters must not be lexically redeclared
​https://bugs.webkit.org/show_bug.cgi?id=208976

Reviewed by Keith Miller.

JSTests:

• test262/expectations.yaml:

Mark four test cases as passing.

Source/JavaScriptCore:

From ​https://tc39.es/ecma262/#sec-try-statement-static-semantics-early-errors:

Catch : catch ( CatchParameter ) Block

It is a Syntax Error if any element of the BoundNames of CatchParameter
also occurs in the LexicallyDeclaredNames of Block.

In other words, let/const/class/function declarations in the immediate catch block scope
must not shadow catch parameters.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseTryStatement):
(JSC::Parser<LexerType>::parseBlockStatement):

• parser/Parser.h:

(JSC::Scope::Scope):
(JSC::Scope::setIsCatchBlockScope): Added.
(JSC::Scope::isCatchBlockScope): Added.
(JSC::Parser::declareVariable):
(JSC::Parser::declareFunction):

11:10 AM Changeset in webkit [258860] by youenn@apple.com

• 2 edits in trunk/Tools

Disable TestWebKitAPI.ProcessSwap.GetUserMediaCaptureState if getUserMedia is not supported
​https://bugs.webkit.org/show_bug.cgi?id=209428

Reviewed by Jonathan Bedard.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

11:01 AM Changeset in webkit [258859] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

Fixing merge conflict

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

10:50 AM Changeset in webkit [258858] by graouts@webkit.org

• 4 edits in trunk/Source

DocumentTimeline / CSSTransition objects are leaking on CNN.com
​https://bugs.webkit.org/show_bug.cgi?id=208069
<rdar://problem/59680143>

Reviewed by Darin Adler.

Integrating post-commit review feedback from Darin.

Source/WebCore:

• testing/Internals.cpp:

(WebCore::Internals::animationWithIdExists const):

Source/WTF:

• wtf/ListHashSet.h:

(WTF::=):

10:49 AM WebKitGTK/2.28.x edited by clopez@igalia.com

(diff)

10:34 AM Changeset in webkit [258857] by commit-queue@webkit.org

• 7 edits in trunk/Source

REGRESSION(r249808): [GTK] Crash in JSC Config::permanentlyFreeze() on architecture ppc64el
​https://bugs.webkit.org/show_bug.cgi?id=209236

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-23
Reviewed by Mark Lam.

Source/JavaScriptCore:

• heap/MarkedBlock.h: Use new CeilingOnPageSize.
• runtime/JSCConfig.cpp:

(JSC::Config::permanentlyFreeze): Use pageSize instead of vmPageSize.

• runtime/JSCConfig.h: Use new CeilingOnPageSize.

Source/WTF:

Add new CeilingOnPageSize constants, for use in JSC, in order to centralize our compile-time
page size guessing into one place. Improve the implementation of pageSize() to
RELEASE_ASSERT() when CeilingOnPageSize is wrong, so we can detect and fix it if so. (It
will be even easier to detect if we change RELEASE_ASSERT_WITH_MESSAGE() to actually print
its message in release builds.) Change pageSize() to use sysconf(_SC_PAGESIZE), which is
specified by POSIX, instead of getpagesize(), which is nonstandard.

• wtf/PageBlock.cpp:

(WTF::systemPageSize):
(WTF::pageSize):

• wtf/PageBlock.h:

10:00 AM Changeset in webkit [258856] by Russell Epstein

• 5 edits
  2 adds in branches/safari-609-branch

Cherry-pick r258799. rdar://problem/60756681

Content-Type & Nosniff Ignored on XML External Entity Resources
<​https://webkit.org/b/191171>
<rdar://problem/45763222>

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml

• platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::isXMLEntityMIMEType): Add.
• platform/MIMETypeRegistry.h: (WebCore::MIMETypeRegistry::isXMLEntityMIMEType): Add.
• Checks for XML external entity MIME types.

• xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::externalEntityMimeTypeAllowedByNosniff): Add.
• Checks whether the MIME type is valid based on the presence of the "X-Content-Type-Options: nosniff" header. (WebCore::openFunc):
• Drop the contents of the resource that was returned and print an error message to the Web Inspector console if externalEntityMimeTypeAllowedByNosniff() says the MIME type is not allowed.

LayoutTests:

• http/tests/security/contentTypeOptions/nosniff-xml-external-entity-expected.txt: Add.
• http/tests/security/contentTypeOptions/nosniff-xml-external-entity.xhtml: Add.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@258799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:00 AM Changeset in webkit [258855] by Russell Epstein

• 5 edits in branches/safari-609-branch

Cherry-pick r258741. rdar://problem/60756641

Sanitize suggested download filename received from web process
​https://bugs.webkit.org/show_bug.cgi?id=209300
<rdar://problem/59487723>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-03-19
Reviewed by Chris Dumez.

Source/WebKit:

• UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync):

LayoutTests:

• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash-expected.txt:
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@258741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:00 AM Changeset in webkit [258854] by Russell Epstein

• 3 edits
  2 adds in branches/safari-609-branch

Cherry-pick r258711. rdar://problem/60756645

Source/WebCore:
AX: VO and safari: can't press the play button
​https://bugs.webkit.org/show_bug.cgi?id=209249

Reviewed by Darin Adler.

Test: accessibility/ios-simulator/has-touch-event-listener-with-shadow.html

If a node is in a shadowRoot, going up the node parent tree will stop and not check the entire tree for touch event listeners
and a touch event won't be dispatched. We need to change to use the parentInComposedTree instead to go up the chain.

• accessibility/ios/AccessibilityObjectIOS.mm: (WebCore::AccessibilityObject::hasTouchEventListener const):

LayoutTests:
AX: VO and safari: caan't press the play button
​https://bugs.webkit.org/show_bug.cgi?id=209249

Reviewed by Darin Adler.

• accessibility/ios-simulator/has-touch-event-listener-with-shadow-expected.txt: Added.
• accessibility/ios-simulator/has-touch-event-listener-with-shadow.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@258711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:00 AM Changeset in webkit [258853] by Russell Epstein

• 2 edits in branches/safari-609-branch/Source/WTF

Cherry-pick r258658. rdar://problem/60756680

REGRESSION(r254389): Cordova throws an exception because it expects a hyphen inside navigator.locale
​https://bugs.webkit.org/show_bug.cgi?id=208969
<rdar://problem/59845517>

Reviewed by Darin Adler.

We want to thwart fingerprinting by minimizing the list of locales, but we also don't want to break existing apps.
We can achieve both by a linked-on-or-after check.

• wtf/cocoa/LanguageCocoa.mm: (WTF::canMinimizeLanguages):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@258658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:52 AM Changeset in webkit [258852] by graouts@webkit.org

• 2 edits in trunk/LayoutTests

[Win] http/wpt/css/css-animations/start-animation-001.html is failing on Windows EWS
​https://bugs.webkit.org/show_bug.cgi?id=209426

Unreviewed test gardening.

• platform/win/TestExpectations:

9:52 AM Changeset in webkit [258851] by Russell Epstein

• 3 edits in branches/safari-609-branch/Source/WebKit

Apply patch. rdar://problem/60756683

9:51 AM Changeset in webkit [258850] by Chris Dumez

• 13 edits in trunk

Port window.postMessage to the HTML event loop
​https://bugs.webkit.org/show_bug.cgi?id=209359

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline test now that the logging ordering is slightly different.

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

Source/WebCore:

Port window.postMessage to the HTML event loop instead of using a 0-timer.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willPostMessageImpl):
(WebCore::InspectorInstrumentation::didPostMessageImpl):
(WebCore::InspectorInstrumentation::didFailPostMessageImpl):
(WebCore::InspectorInstrumentation::willDispatchPostMessageImpl):
(WebCore::InspectorInstrumentation::didDispatchPostMessageImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willPostMessage):
(WebCore::InspectorInstrumentation::didPostMessage):
(WebCore::InspectorInstrumentation::didFailPostMessage):
(WebCore::InspectorInstrumentation::willDispatchPostMessage):
(WebCore::InspectorInstrumentation::didDispatchPostMessage):

• inspector/agents/WebDebuggerAgent.cpp:

(WebCore::WebDebuggerAgent::willPostMessage):
(WebCore::WebDebuggerAgent::didPostMessage):
(WebCore::WebDebuggerAgent::didFailPostMessage):
(WebCore::WebDebuggerAgent::willDispatchPostMessage):
(WebCore::WebDebuggerAgent::didDispatchPostMessage):
(WebCore::WebDebuggerAgent::didClearAsyncStackTraceData):

• inspector/agents/WebDebuggerAgent.h:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):
(WebCore::PostMessageTimer::PostMessageTimer): Deleted.
(WebCore::PostMessageTimer::event): Deleted.
(WebCore::PostMessageTimer::targetOrigin const): Deleted.
(WebCore::PostMessageTimer::stackTrace const): Deleted.
(WebCore::DOMWindow::postMessageTimerFired): Deleted.

• page/DOMWindow.h:

LayoutTests:

Update tests so that it does not run postMessage tests in parallel on the 2 different-origin iframes,
since the ordering would not be guaranteed and it would cause flakiness.

• http/tests/security/postMessage/resources/recv.js:

(recv):

• http/tests/security/postMessage/target-origin-expected.txt:
• http/tests/security/postMessage/target-origin.html:

9:43 AM Changeset in webkit [258849] by Russell Epstein

• 2 edits in branches/safari-609-branch/Source/WebKit

Apply patch. rdar://problem/60555343

Cherry-pick r258565. rdar://problem/60555343

2020-03-17 David Kilzer <​ddkilzer@apple.com>

REGRESSION (r258334): WebPasteboardProxy::setPasteboardBufferForType should allow zero-size buffers
<​https://webkit.org/b/209167>
<rdar://problem/60516302>

Reviewed by Geoffrey Garen.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::setPasteboardBufferForType):
• Remove check for zero-size buffer to match WebPageProxy::dataSelectionForPasteboard().

9:15 AM Changeset in webkit [258848] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: this._springEditor.removeListeners is not a function. (In 'this._springEditor.removeListeners()', 'this._springEditor.removeListeners' is undefined)
​https://bugs.webkit.org/show_bug.cgi?id=209325

Reviewed by Brian Burg.

• UserInterface/Controllers/CodeMirrorSpringEditingController.js:

(WI.CodeMirrorSpringEditingController.prototype.popoverDidDismiss): Deleted.

9:08 AM Changeset in webkit [258847] by Alan Bujtas

• 13 edits in trunk/Source/WebCore

[LFC] Layout::Box::initialContainingBlock() should return const InitialContainingBlock&
​https://bugs.webkit.org/show_bug.cgi?id=209406
<rdar://problem/60749715>

Reviewed by Antti Koivisto.

Use is<InitialContainingBlock> where applicable.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):
(WebCore::Layout::FormattingContext::collectOutOfFlowDescendantsIfNeeded):

• layout/FormattingContextQuirks.cpp:

(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):

• layout/blockformatting/BlockFormattingContextQuirks.cpp:
• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::absoluteDisplayBox):

• layout/invalidation/InvalidationState.cpp:

(WebCore::Layout::InvalidationState::markNeedsUpdate):

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesBlockFormattingContext const):
(WebCore::Layout::Box::containingBlock const):
(WebCore::Layout::Box::formattingContextRoot const):
(WebCore::Layout::Box::initialContainingBlock const):
(WebCore::Layout::Box::isInFormattingContextOf const):
(WebCore::Layout::Box::isOverflowVisible const):

• layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isInitialContainingBlock const):
(WebCore::Layout::Box::isInlineTextBox const):
(WebCore::Layout::Box::isLineBreakBox const):
(WebCore::Layout::Box::isReplacedBox const):

• layout/layouttree/LayoutInitialContainingBlock.cpp:

(WebCore::Layout::InitialContainingBlock::InitialContainingBlock):

• layout/layouttree/LayoutInlineTextBox.cpp:

(WebCore::Layout::InlineTextBox::InlineTextBox):

• layout/layouttree/LayoutLineBreakBox.cpp:

(WebCore::Layout::LineBreakBox::LineBreakBox):

• layout/layouttree/LayoutReplacedBox.cpp:

(WebCore::Layout::ReplacedBox::ReplacedBox):

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutBox):

8:38 AM Changeset in webkit [258846] by jer.noble@apple.com

• 4 edits in trunk/Source/WebCore

[MSE] Handle the case where AVStreamDataParser packages sync and non-sync samples together in a CMSampleBufferRef.
​https://bugs.webkit.org/show_bug.cgi?id=209365
<rdar://problem/60625209>

Reviewed by Eric Carlson.

AVStreamDataParser will package together muliple samples into a single CMSampleBufferRef for efficiency's sake. When
this occurs, it may include sync and non-sync samples together into the same CMSampleBufferRef, which is problematic
as we consider a CMSampleBufferRef to be "sync" only when every sample inside the buffer is also sync.

To handle this scenario, when receiving a CMSampleBufferRef from AVStreamDataParser, first check whether that buffer
is "homogeneous", meaning every sample within the buffer has the same effective MediaSample flags. Then, if the buffer
is not homogenous, break the buffer into muliple homogenious CMSampleBufferRefs. Then, each of those resulting buffers
is passed up to SourceBuffer as a MediaSample individually.

• platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::isCMSampleBufferAttachmentRandomAccess):
(WebCore::isCMSampleBufferRandomAccess):
(WebCore::isCMSampleBufferAttachmentNonDisplaying):
(WebCore::isCMSampleBufferNonDisplaying):
(WebCore::MediaSampleAVFObjC::flags const):
(WebCore::MediaSampleAVFObjC::isHomogeneous const):
(WebCore::MediaSampleAVFObjC::divideIntoHomogeneousSamples):

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame):

8:35 AM Changeset in webkit [258845] by pvollan@apple.com

• 5 edits in trunk

[iOS] Deny mach lookup access to icon services
​https://bugs.webkit.org/show_bug.cgi?id=209340

Reviewed by Brent Fulgham.

Source/WebKit:

Tested by fast/sandbox/ios/sandbox-mach-lookup.html

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

• fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
• fast/sandbox/ios/sandbox-mach-lookup.html:

8:27 AM Changeset in webkit [258844] by aboya@igalia.com

• 4 edits in trunk/Source/WebCore

[MSE][GStreamer] Clean and explain first sample PTS hack
​https://bugs.webkit.org/show_bug.cgi?id=209335

Reviewed by Philippe Normand.

MediaSample::applyPtsOffset() had a rather confusing name, so it has
been changed to something more descriptive of its actual function:
extendToTheBeginning().

Also, its only argument has been removed, as it's always zero.

An explanation of the hack has also been added.

This patch introduces no behavior changes.

• platform/graphics/gstreamer/MediaSampleGStreamer.cpp:

(WebCore::MediaSampleGStreamer::extendToTheBeginning):
(WebCore::MediaSampleGStreamer::applyPtsOffset): Deleted.

• platform/graphics/gstreamer/MediaSampleGStreamer.h:
• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::appsinkNewSample):

8:25 AM Changeset in webkit [258843] by Alan Bujtas

• 7 edits
  1 delete in trunk/Source/WebCore

[LFC] Remove unused LayoutAncestorIterator class
​https://bugs.webkit.org/show_bug.cgi?id=209401
<rdar://problem/60743144>

Reviewed by Sam Weinig.

• WebCore.xcodeproj/project.pbxproj:
• layout/blockformatting/BlockFormattingContextGeometry.cpp:
• layout/displaytree/DisplayPainter.cpp:
• layout/layouttree/LayoutAncestorIterator.h: Removed.
• layout/layouttree/LayoutChildIterator.h:

(WebCore::Layout::LayoutChildIteratorAdapter<T>::last const): Deleted.

• layout/layouttree/LayoutIterator.h:

(WebCore::Layout::LayoutBoxTraversal::nextSkippingChildren): Deleted.
(WebCore::Layout::Traversal::lastChild): Deleted.
(WebCore::Layout::Traversal::previousSibling): Deleted.
(WebCore::Layout::Traversal::findAncestorOfType): Deleted.
(WebCore::Layout::LayoutIterator<T>::traversePreviousSibling): Deleted.
(WebCore::Layout::LayoutIterator<T>::traverseAncestor): Deleted.

• layout/layouttree/LayoutTreeBuilder.cpp:

7:41 AM Changeset in webkit [258842] by graouts@webkit.org

• 8 edits in trunk/Source/WebCore

[Web Animations] Refactor cancelDeclarativeAnimationsForElement and willDestroyRendererForElement on AnimationTimeline
​https://bugs.webkit.org/show_bug.cgi?id=209423

Reviewed by Antti Koivisto.

The methods cancelDeclarativeAnimationsForElement and willDestroyRendererForElement on AnimationTimeline did the same
thing save for the argument passed to WebAnimation::cancel(). We now refactor those two methods into a single
cancelDeclarativeAnimationsForElement method with an argument to set whether cancelation should be silent.
As a result, we also change WebAnimation::cancel() to have a single flavor instead of one without an argument and one
with the silent argument.

No test because there is no change in visible behavior.

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::elementWasRemoved):
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement):
(WebCore::AnimationTimeline::willDestroyRendererForElement): Deleted.

• animation/AnimationTimeline.h:
• animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::cancel):

• animation/DeclarativeAnimation.h:
• animation/WebAnimation.cpp:
• animation/WebAnimation.h:
• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::tearDownRenderers):

7:38 AM Changeset in webkit [258841] by Jacob Uphoff

• 12 edits in trunk

Unreviewed, reverting r258803.

This revision caused many layout tests and 10 API tests to
start failing/crashing

Reverted changeset:

"[Cocoa] Deny access to database mapping service"
​https://bugs.webkit.org/show_bug.cgi?id=209339
​https://trac.webkit.org/changeset/258803

7:35 AM Changeset in webkit [258840] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

AudioTrackPrivateMediaStream recovers from a muted track very late
​https://bugs.webkit.org/show_bug.cgi?id=209411

Reviewed by Eric Carlson.

In case of a muted track, the AudioSampleDataSource is not pushed any new sample.
When unmuting the tracks, pulled samples will be zeroes for some time until the newly pushed samples are used.
To fix this, we pause the audio player whenever muted/disabled/ended and restart playing when unmuted/enabled.
Manually tested.

• platform/mediastream/AudioTrackPrivateMediaStream.cpp:

(WebCore::AudioTrackPrivateMediaStream::updateRendererMutedState):

7:33 AM Changeset in webkit [258839] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

AudioMediaStreamTrackRendererCocoa does not recover from AudioSession interruption
​https://bugs.webkit.org/show_bug.cgi?id=209412

Reviewed by Eric Carlson.

In case there is an AudioSession interruption, like the app is in the background
and another app starts to play audio, AudioMediaStreamTrackRendererCocoa will not restart playing audio.
Fix this by clearing the AudioUnit when starting since the renderer is paused during the interruption.
This ensures resuming from the interruption in a clean state.

Manually tested.

• platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:

(WebCore::AudioMediaStreamTrackRendererCocoa::start):

7:26 AM Changeset in webkit [258838] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

RemoteAudioSession should listen to GPUProcess messages
​https://bugs.webkit.org/show_bug.cgi?id=209422

Reviewed by Eric Carlson.

Make sure RemoteAudioSession is registered as a listener to GPUProcess messages.

• WebProcess/GPU/media/RemoteAudioSession.cpp:

(WebKit::RemoteAudioSession::RemoteAudioSession):
(WebKit::RemoteAudioSession::~RemoteAudioSession):

7:24 AM Changeset in webkit [258837] by youenn@apple.com

• 5 edits in trunk

MediaDevices::refreshDevices should take device type into account
​https://bugs.webkit.org/show_bug.cgi?id=209417
<rdar://problem/60521332>

Reviewed by Eric Carlson.

Source/WebCore:

Now that we set deviceId to the empty string when media capture is not granted,
we can have two devices with the same ID. We also need to handle the device type.

• Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::refreshDevices):

LayoutTests:

• fast/mediastream/media-device-info-expected.txt:
• fast/mediastream/media-device-info.html:

7:22 AM Changeset in webkit [258836] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC] Box::establishesBlockFormattingContext should check isInitialContainingBlock
​https://bugs.webkit.org/show_bug.cgi?id=209390
<rdar://problem/60735021>

Reviewed by Antti Koivisto.

It's more correct to call isInitialContainingBlock() to check if the current box is the ICB.

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesBlockFormattingContext const):
(WebCore::Layout::Box::initialContainingBlock const):

6:33 AM Changeset in webkit [258835] by Pablo Saavedra

• 2 edits in trunk/Source/WebKit

[GTK][WPE] Check the cgroups memory limits (v1 and v2) to calculate the systemMemoryUsedAsPercentage() in the MemoryPressureMonitor
​https://bugs.webkit.org/show_bug.cgi?id=209186

Reviewed by Carlos Alberto Lopez Perez.

Modifies the systemMemoryUsedAsPercentage() function adding the logic
to read the memory limits and the current memory used in the cgroup
associated to the WebKit process:

• memory.memsw.usage_in_bytes (or memory.memsw.max in cgroupV2): current usage for memory+Swap
• memory.limit_in_bytes (or memory.current in cgroupV2): limit of memory usage
• memory.memsw.limit_in_bytes (or memory.max in cgroupV2): limit of memory+Swap usage

In case of the WK processes are associated to a cgroup with memory
controller, the function reads the memory.limit_in_bytes or
the memory.memsw.limit_in_bytes and the and memory.usage_in_bytes
from the cgroup mount point and calculates the percentage of
memory used.

In other cases (no cgroup memory controller associated or limits
higher than the real memory available), the function will return the
percentage based on the real memory available and real total memory
in the system.

The logic supports supports both cgroupV1 and cgroupV2

• UIProcess/linux/MemoryPressureMonitor.cpp:

(WebKit::getMemoryTotalWithCgroup):
(WebKit::getMemoryUsageWithCgroup):
(WebKit::getCgroupController):
(WebKit::systemMemoryUsedAsPercentage):

5:41 AM Changeset in webkit [258834] by graouts@webkit.org

• 6 edits in trunk/Source/WebCore

[Web Animations] ElementAnimationRareData is created too frequently
​https://bugs.webkit.org/show_bug.cgi?id=209415

Reviewed by Antti Koivisto.

The various accessors on Element to access transitions and animations will ensure there is a backing
ElementAnimationRareData object. However, in a lot of cases, such as when we consider whether CSS
Transitions should be created, updated or removed under AnimationTimeline::updateCSSTransitionsForElement(),
we end up not needing to actually access the data structures on ElementAnimationRareData.

We now make the various methods on Element to access transitions and animations const T* and add ensure*()
methods to access the collections for modification. We also add methods to query whether there are running or
completed transitions at all or for a given property.

No test because there is no change in visible behavior.

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationWasAddedToElement):
(WebCore::AnimationTimeline::animationWasRemovedFromElement):
(WebCore::AnimationTimeline::removeDeclarativeAnimationFromListsForOwningElement):
(WebCore::AnimationTimeline::animationsForElement const):
(WebCore::AnimationTimeline::willDestroyRendererForElement):
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement):
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
(WebCore::AnimationTimeline::updateCSSTransitionsForElement):

• animation/AnimationTimeline.h:
• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::transitionDidComplete):

• dom/Element.cpp:

(WebCore::Element::webAnimations const):
(WebCore::Element::cssAnimations const):
(WebCore::Element::transitions const):
(WebCore::Element::hasCompletedTransitionsForProperty const):
(WebCore::Element::hasRunningTransitionsForProperty const):
(WebCore::Element::hasRunningTransitions const):
(WebCore::Element::ensureWebAnimations):
(WebCore::Element::ensureCSSAnimations):
(WebCore::Element::ensureTransitions):
(WebCore::Element::ensureCompletedTransitionsByProperty):
(WebCore::Element::ensureRunningTransitionsByProperty):
(WebCore::Element::webAnimations): Deleted.
(WebCore::Element::cssAnimations): Deleted.
(WebCore::Element::transitions): Deleted.
(WebCore::Element::completedTransitionsByProperty): Deleted.
(WebCore::Element::runningTransitionsByProperty): Deleted.

• dom/Element.h:

5:22 AM Changeset in webkit [258833] by Philippe Normand

• 3 edits in trunk

[GTK][WPE] Disable systemd logging by default

Rubber-stamped by Žan Doberšek.

The logAlways logs are filling the journal way too fast currently,
specially on EWS running tests and buildbots. For the time being
disable logging until we figure out a better way to handle this.

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

4:03 AM Changeset in webkit [258832] by cturner@igalia.com

• 3 edits in trunk/Source/WebCore

[GStreamer] Fail gracefully in the absence of a WebVTT encoder.
​https://bugs.webkit.org/show_bug.cgi?id=209290

Reviewed by Philippe Normand.

Covered by existing tests.

• platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer): Gets rid of "plugin not found"
errors. It's not an error to have potentially broken AAC decoders,
but it's nice to give a clear warning.

• platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkit_text_combiner_class_init):
(webkitTextCombinerNew): Check for the "subenc" *plugin*. This
check indirectly tells us the "webvttenc" *element* will exist.

3:57 AM Changeset in webkit [258831] by commit-queue@webkit.org

• 5 edits in trunk/Source

[WPE] AsyncScrolling: horizontal scrolling is inverted
​https://bugs.webkit.org/show_bug.cgi?id=208638

Source/WebCore:

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-03-23
Reviewed by Adrian Perez de Castro.

Scrolling down should scroll to the right and up to the left..

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent): Invert also the x axis.

• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent): Ditto.

Source/WebKit:

Patch by Chris Lord <Chris Lord> on 2020-03-23
Reviewed by Adrian Perez de Castro.

• UIProcess/API/wpe/ScrollGestureController.cpp:

(WebKit::ScrollGestureController::handleEvent):

3:49 AM Changeset in webkit [258830] by Chris Lord

• 2 edits in trunk/Tools

Add missing committer status to Chris Lord in contributors.json

Unreviewed

• Scripts/webkitpy/common/config/contributors.json:

3:16 AM Changeset in webkit [258829] by youenn@apple.com

• 6 edits in trunk/Source

Explicitly activate the new DrawingAreaProxy on PSON navigation
​https://bugs.webkit.org/show_bug.cgi?id=209232

Reviewed by Antti Koivisto.

Delay tree unfreezing for provisional pages until the main frame load is committed.
At that point, UIProcess is made aware and is doing the process swap.
We can thus unfreeze the tree so that UIProcess starts getting DrawAreaProxy messages.

This allows UIProcess to start listening to DrawAreaProxy messages at the time of doing process swapping in WebPageProxy.

• UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::startReceivingMessages):

• UIProcess/DrawingAreaProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setDrawingArea):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCompletePageTransition):
(WebKit::WebPage::didCommitLoad):

2:48 AM Changeset in webkit [258828] by youenn@apple.com

• 5 edits in trunk

StringView::startsWith and String::startsWith do not treat null strings the same
​https://bugs.webkit.org/show_bug.cgi?id=209273

Reviewed by Darin Adler.

Source/WTF:

Align StringImpl with StringView and make startsWith return true if prefix is null.

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::startsWith const):

Tools:

• TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

2:05 AM Changeset in webkit [258827] by graouts@webkit.org

• 6 edits in trunk/Source/WebCore

[Web Animations] Fix the typo for ElementAnimationRareData::completedTransitionByProperty()
​https://bugs.webkit.org/show_bug.cgi?id=209413

Reviewed by Antti Koivisto.

There can be several completed transitions by property, so renaming this property to completedTransitionsByProperty.

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::removeDeclarativeAnimationFromListsForOwningElement):
(WebCore::AnimationTimeline::updateCSSTransitionsForElement):

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::transitionDidComplete):

• animation/ElementAnimationRareData.h:

(WebCore::ElementAnimationRareData::completedTransitionsByProperty):
(WebCore::ElementAnimationRareData::completedTransitionByProperty): Deleted.

• dom/Element.cpp:

(WebCore::Element::completedTransitionsByProperty):
(WebCore::Element::completedTransitionByProperty): Deleted.

• dom/Element.h:

1:17 AM Changeset in webkit [258826] by graouts@webkit.org

• 12 edits
  3 adds in trunk

DocumentTimeline / CSSTransition objects are leaking on CNN.com
​https://bugs.webkit.org/show_bug.cgi?id=208069
<rdar://problem/59680143>

Reviewed by Simon Fraser, Geoffrey Garen and Darin Adler.

Source/WebCore:

Test: webanimations/leak-css-animation.html

We add a test feature that lets use query the availability of a given WebAnimation by its "id" property in the WebAnimation::instances list.
We also fix some build issues that appeared with a change in UnifiedSources order.

• animation/ElementAnimationRareData.cpp:

(WebCore::ElementAnimationRareData::setAnimationsCreatedByMarkup):

• animation/ElementAnimationRareData.h:

(WebCore::ElementAnimationRareData::setAnimationsCreatedByMarkup): Deleted.

• animation/WebAnimation.h:
• testing/Internals.cpp:

(WebCore::Internals::animationWithIdExists const):

• testing/Internals.h:
• testing/Internals.idl:

Source/WTF:

If a CSSAnimation is set on an element using the animation-name CSS property, and later removed, it will leak due to the ListHashSet<RefPtr<CSSAnimation>>
(aka CSSAnimationCollection) member on ElementAnimationRareData being replaced to the new list, but the old list not being cleared from its members.

We fix the ListHashSet assignment operator to use swap ensuring previously held items are cleared.

• wtf/ListHashSet.h:

(WTF::=):

Tools:

Add a test that checks that a ListHashSet containing RefPtr<> types correctly calls the destructor for those items when the assignment operator is used.

• TestWebKitAPI/Tests/WTF/ListHashSet.cpp:

(TestWebKitAPI::ListHashSetReferencedItem::create):
(TestWebKitAPI::ListHashSetReferencedItem::ListHashSetReferencedItem):
(TestWebKitAPI::ListHashSetReferencedItem::~ListHashSetReferencedItem):
(TestWebKitAPI::FakeElementAnimationRareData::FakeElementAnimationRareData):
(TestWebKitAPI::FakeElementAnimationRareData::~FakeElementAnimationRareData):
(TestWebKitAPI::FakeElementAnimationRareData::collection):
(TestWebKitAPI::FakeElementAnimationRareData::setCollection):
(TestWebKitAPI::TEST):

LayoutTests:

Add a test that checks that setting a CSSAnimation on an element, waiting a frame, and removing it will not leak that CSSAnimation.

• webanimations/leak-css-animation-expected.txt: Added.
• webanimations/leak-css-animation.html: Added.
• webanimations/resources/css-animation-leak-iframe.html: Added.

Mar 22, 2020:

9:57 PM Changeset in webkit [258825] by ysuzuki@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Unreviewed, rename keepAlive to ensureStillAliveHere
​https://bugs.webkit.org/show_bug.cgi?id=209398

Based on Geoff and Mark's feedback, renaming keepAlive to ensureStillAliveHere
to make the effect of keepAlive clear.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileArraySlice):
(JSC::FTL::DFG::LowerDFGToB3::ensureStillAliveHere):
(JSC::FTL::DFG::LowerDFGToB3::keepAlive): Deleted.

• heap/HeapCell.cpp:

(JSC::ensureStillAliveHere):
(JSC::keepAlive): Deleted.

• heap/HeapCell.h:

(JSC::ensureStillAliveHere):
(JSC::HeapCell::use const):
(JSC::keepAlive): Deleted.

• runtime/JSCJSValue.cpp:

(JSC::ensureStillAliveHere):
(JSC::keepAlive): Deleted.

• runtime/JSCJSValue.h:

(JSC::ensureStillAliveHere):
(JSC::keepAlive): Deleted.

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):

5:40 PM Changeset in webkit [258824] by ysuzuki@apple.com

• 4 edits in trunk/Source/JavaScriptCore

[JSC] Add JSC::keepAlive(JSValue)
​https://bugs.webkit.org/show_bug.cgi?id=209398

Reviewed by Mark Lam.

Add JSC::keepAlive(JSValue). This is useful to make some JSValue variable alive from GC.

• heap/HeapCell.cpp:
• runtime/JSCJSValue.cpp:

(JSC::keepAlive):

• runtime/JSCJSValue.h:

(JSC::keepAlive):

3:57 PM Changeset in webkit [258823] by commit-queue@webkit.org

• 5 edits in trunk

[ Mac ] imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209239
<rdar://problem/60591358>

Patch by Antoine Quint <Antoine Quint> on 2020-03-22
Reviewed by Simon Fraser.

Source/WebCore:

This test was made flaky by r257417, the initial fix for webkit.org/b/208069. A new, appropriate fix for that bug is in the works. In the
meantime we revert r257417 in this patch.

The reason this test became flaky is that it features the following code:

animB.timeline = new DocumentTimeline({

originTime:

document.timeline.currentTime - 100 * MS_PER_SEC - animB.startTime,

});

In this case the only reference to the created DocumentTimeline is through animB.timeline. But because r257417 made the timeline reference from
WebAnimation a weak reference, in some cases, if GC kicks in, the timeline would be dereferenced and the test would fail. We restore that relationship
to its previous state, which is a strong reference.

• animation/WebAnimation.cpp:

(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::setTimelineInternal):
(WebCore::WebAnimation::enqueueAnimationEvent):
(WebCore::WebAnimation::acceleratedStateDidChange):
(WebCore::WebAnimation::timeline const): Deleted.

• animation/WebAnimation.h:

(WebCore::WebAnimation::timeline const):

LayoutTests:

• platform/mac/TestExpectations:

1:33 PM Changeset in webkit [258822] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK][WPE] Gardening, update TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=209404

Unreviewed gardening.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

12:29 PM Changeset in webkit [258821] by Wenson Hsieh

• 4 edits in trunk/Source/WebKit

Adopt -[UIWindowScene interfaceOrientation] when determining device orientation
​https://bugs.webkit.org/show_bug.cgi?id=209372
<rdar://problem/60491857>

Reviewed by Darin Adler.

Currently, for WebKit clients that have adopted the UIScene lifecycle (and also do not set an interface
orientation override, like MobileSafari does), device orientation APIs will always report that the device is in
portrait mode, regardless of the actual device orientation. This is because our current mechanism for tracking
device orientation asks the shared UIApplication for its -statusBarOrientation. This is hard-coded to always
return UIInterfaceOrientationPortrait for apps that adopt the UIScene lifecycle, and will additionally trigger a
simulated crash, explaining that it is invalid for any scene-based app to call -statusBarOrientation.

To fix this, we adjust the deviceOrientation helper in WKWebViewIOS.mm to work for scene-based apps. See below
for more details.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/API/ios/WKWebViewIOS.h:
• UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _setupScrollAndContentViews]):

Change call sites of deviceOrientation() to be [self _deviceOrientation] instead.

(-[WKWebView _deviceOrientation]):

Replace deviceOrientation() with a _deviceOrientation helper method on WKWebView. For non-scene-based
apps, this new helper method does not change any behavior, and continues to go through UIApplication. However,
for scene-based apps, we instead ask the web view's window's UIWindowScene for its interface orientation.

Importantly, this means that if a WKWebView is not parented, it doesn't have a valid device orientation (i.e.
the orientation is UIInterfaceOrientationUnknown). As such, a newly created WKWebView that is unparented will
start out with no orientation; it's only upon moving the view into a window that it is able to determine the
device orientation. To ensure this, we add logic to -didMoveToWindow to recompute device orientation and
dispatch an update if needed.

To avoid sending unnecessary updates, if a WKWebView is unparented, we wait until it's parented again to send
the new device orientation.

(-[WKWebView didMoveToWindow]):
(-[WKWebView _windowDidRotate:]):
(deviceOrientation): Deleted.

See -[WKWebView _deviceOrientation] above.

10:41 AM Changeset in webkit [258820] by Alan Bujtas

• 9 edits
  2 copies in trunk/Source/WebCore

[LFC] Introduce InitialContainingBox class
​https://bugs.webkit.org/show_bug.cgi?id=209399
<rdar://problem/60741767>

Reviewed by Antti Koivisto.

ICB is the top level containing block. This helps to make sure we don't accidentally call parent() on the ICB.
This is also a preparation for "const Box& Layout::Box::parent()".

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::BoxTree):
(): Deleted.

• layout/integration/LayoutIntegrationBoxTree.h:

(WebCore::LayoutIntegration::BoxTree::rootLayoutBox const):
(WebCore::LayoutIntegration::BoxTree::rootLayoutBox):

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isInitialContainingBlock const): Deleted.

• layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isInitialContainingBlock const):

• layout/layouttree/LayoutContainerBox.h:
• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::buildLayoutTree):

7:02 AM Changeset in webkit [258819] by Alan Bujtas

• 16 edits in trunk/Source/WebCore

[LFC] Layout::Box::containingBlock should return a const ContainerBox&
​https://bugs.webkit.org/show_bug.cgi?id=209381
<rdar://problem/60732278>

Reviewed by Antti Koivisto.

Layout tree is immutable during layout, so every box should be able to return a valid containing block (except the ICB).
(This patch also removes the unused isDescendantOf() function and renames isDescendantOfFormattingRoot to isInFormattingContextOf).

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::isHeightAuto):
(WebCore::Layout::FormattingContext::Geometry::computedHeightValue const):
(WebCore::Layout::FormattingContext::Geometry::staticVerticalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::staticHorizontalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset const):

• layout/FormattingContextQuirks.cpp:

(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):

• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForAncestors):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForBoxAndAncestors):
(WebCore::Layout::BlockFormattingContext::verticalPositionWithMargin const):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin const):

• layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
(WebCore::Layout::initialContainingBlock): Deleted.

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough const):

• layout/blockformatting/PrecomputedBlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedPositiveNegativeValues const):

• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::absoluteDisplayBox):

• layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
(WebCore::Layout::FloatingContext::absoluteDisplayBoxCoordinates const):
(WebCore::Layout::FloatingContext::mapToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapTopToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToFloatingStateRoot const):

• layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::bottom const):
(WebCore::Layout::FloatingState::top const):

• layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::FloatItem::isInFormattingContextOf const):
(WebCore::Layout::FloatingState::FloatItem::isDescendantOfFormattingRoot const): Deleted.

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::containingBlock const):
(WebCore::Layout::Box::formattingContextRoot const):
(WebCore::Layout::Box::isInFormattingContextOf const):
(WebCore::Layout::Box::isDescendantOf const): Deleted.
(WebCore::Layout::Box::isContainingBlockDescendantOf const): Deleted.

• layout/layouttree/LayoutBox.h:

12:42 AM Changeset in webkit [258818] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: Right side of assignment cannot be destructured (at QuickConsole.js:358:30)
​https://bugs.webkit.org/show_bug.cgi?id=209388

Reviewed by Joseph Pecoraro.

• UserInterface/Views/QuickConsole.js:

(WI.QuickConsole.prototype._handleFramePageExecutionContextChanged):