Timeline

Apr 17, 2020:

8:04 PM Changeset in webkit [260306] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKitLegacy/mac

[iOS WK1] -[_WebSafeForwarder asyncForwarder] uses non-static dispatch_once_t predicate
<​https://webkit.org/b/210625>

Reviewed by Daniel Bates.

Remove use of dispatch_once to initialize
_WebSafeForwarder._asyncForwarder, and modernize both
_WebSafeForwarder and _WebSafeAsyncForwarder classes.

• WebView/WebView.mm:

(@interface _WebSafeAsyncForwarder):

• Make _forwarder weak. It can't be strong or a retain cycle would be created between this object and _WebSafeForwarder.
• Change return type from id to instancetype for -[_WebSafeAsyncForwarder initWithForwarder:].

(@interface _WebSafeForwarder):

• Make _target weak and rename from target.
• Make _defaultTarget weak and rename from defaultTarget.
• Rename _asyncForwarder from asyncForwarder.
• Delete unused asyncForwarderPred.
• Replace -asyncForwarder method declaration with a @property definition.

(-[_WebSafeForwarder initWithTarget:defaultTarget:]):

• Update for instance variable renames.
• Iniitalize _asyncForwarder here. There are (at most) eight _WebSafeForwarder objects created per WebView, so creating this object in the constructor seems reasonable.

(-[_WebSafeForwarder asyncForwarder:]):

• Delete this method (and use of dispatch_once, fixing the bug). Replace with @synthesize statement.

(-[_WebSafeForwarder dealloc:]):

• Update for instance variable renames, and assign nil to all instance variables.

(-[_WebSafeForwarder forwardInvocation:]):
(-[_WebSafeForwarder respondsToSelector:]):
(-[_WebSafeForwarder methodSignatureForSelector:]):

• Update for instance variable renames.

(-[_WebSafeForwarder initWithForwarder:]):

• Change return type from id to instancetype.

6:37 PM Changeset in webkit [260305] by Simon Fraser

• 45 edits in trunk

Group overflow controls layers into a single container layer
​https://bugs.webkit.org/show_bug.cgi?id=210675

Reviewed by Zalan Bujtas.

Source/WebCore:

Overflow control layers are going to change z-order in a future change. To make this
easier, group the overflow controls layer into their own container layer.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDebugIndicators):
(WebCore::RenderLayerBacking::updateGeometry): Size the overflow controls layer using paddingBoxRectIncludingScrollbar().
(WebCore::RenderLayerBacking::updateInternalHierarchy): New parenting.
(WebCore::RenderLayerBacking::updateOverflowControlsLayers): Some refactoring with a nice lambda.
(WebCore::RenderLayerBacking::positionOverflowControlsLayers): Lovely lambda here. Nice.

• rendering/RenderLayerBacking.h:

LayoutTests:

Rebaselines.

• compositing/clipping/border-radius-async-overflow-clipping-layer-expected.txt:
• compositing/layer-creation/absolute-in-async-overflow-scroll-expected.txt:
• compositing/layer-creation/clipping-scope/nested-scroller-overlap-expected.txt:
• compositing/layer-creation/clipping-scope/overlap-constrained-inside-scroller-expected.txt:
• compositing/layer-creation/clipping-scope/overlap-constrained-inside-stacking-context-scroller-expected.txt:
• compositing/layer-creation/clipping-scope/scroller-with-negative-z-children-expected.txt:
• compositing/layer-creation/clipping-scope/shared-layers-in-scroller-expected.txt:
• compositing/overflow/overflow-auto-with-touch-expected.txt:
• compositing/overflow/overflow-overlay-with-touch-expected.txt:
• compositing/overflow/overflow-scrollbar-layer-positions-expected.txt:
• compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
• compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt:
• compositing/overflow/textarea-scroll-touch-expected.txt:
• compositing/repaint/scroller-with-foreground-layer-repaints-expected.txt:
• compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt:
• compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-clipped-by-scroll-expected.txt:
• compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-expected.txt:
• compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-nested-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-for-negative-z-in-scroller-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-clip-to-hidden-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-clip-to-visible-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-gain-clipping-layer-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-in-clipped-expected.txt:
• compositing/scrolling/async-overflow-scrolling/layer-in-overflow-lose-clipping-layer-expected.txt:
• compositing/scrolling/async-overflow-scrolling/visibility-hidden-scrollers-expected.txt:
• compositing/scrolling/overflow-scrolling-layers-are-self-painting-expected.txt:
• compositing/shared-backing/overflow-scroll/absolute-in-stacking-relative-in-scroller-expected.txt:
• compositing/shared-backing/overflow-scroll/composited-absolute-in-absolute-in-relative-in-scroller-expected.txt:
• compositing/shared-backing/overflow-scroll/nested-absolute-with-clipping-in-stacking-overflow-expected.txt:
• compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness-expected.txt:
• compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-clipping-expected.txt:
• compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-relative-clipping-expected.txt:
• compositing/shared-backing/overflow-scroll/relative-in-div-in-overflow-scroll-expected.txt:
• compositing/shared-backing/overflow-scroll/scrolled-contents-has-painted-content-expected.txt:
• fast/scrolling/mac/event-region-scrolled-contents-layer-expected.txt:
• platform/mac-wk1/compositing/clipping/border-radius-async-overflow-clipping-layer-expected.txt:
• platform/mac/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt:
• tiled-drawing/scrolling/overflow/overflow-scrolled-down-tile-coverage-expected.txt:
• tiled-drawing/scrolling/overflow/overflow-scrolled-up-tile-coverage-expected.txt:
• tiled-drawing/scrolling/overflow/overflow-tile-coverage-expected.txt:

6:26 PM Changeset in webkit [260304] by mmaxfield@apple.com

• 2 edits in trunk/LayoutTests

[Cocoa] Password obscuring dots drawn with the system font are too small
​https://bugs.webkit.org/show_bug.cgi?id=209692

Reviewed by Darin Adler.

Addressing post-review comments.

• platform/mac/TestExpectations:

5:54 PM Changeset in webkit [260303] by Kate Cheney

• 31 edits in trunk

Enable service workers for app-bound domains
​https://bugs.webkit.org/show_bug.cgi?id=210451
<rdar://problem/61479474>

Reviewed by Brent Fulgham.

Source/WebCore:

SWServer now retrieves the app-bound domains from the UI Process and
only continues with the load if the proper entitlement is present
or the load is coming from an app-bound domain.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::addRegistrationFromStore):
(WebCore::SWServer::SWServer):
(WebCore::SWServer::validateRegistrationDomain):
(WebCore::SWServer::scheduleJob):

• workers/service/server/SWServer.h:

Source/WebKit:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::createFetchTask):
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::swConnection):
(WebKit::NetworkConnectionToWebProcess::isServiceWorkerAllowed const): Deleted.

• NetworkProcess/NetworkConnectionToWebProcess.h:

Removed ASSERTS and service worker entitlement checks which are now done along with app-bound
domain checks in SWServer.cpp.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::addWebsiteDataStore):
Remove the check for parentProcessHasServiceWorkerEntitlement() before
adding a serviceWorkerSession. This doesn't do anything except add an
entry to a map, and simplifies the case where we need a session for
app-bound instances which should have service workers but have no entitlement.

Pass the entitlement and a new callback to request app-bound domains
from the UI Process to the SWServer. This will make sure the server
checks for the entitlement or list of app-bound domains before completing a load.

(WebKit::NetworkProcess::registerSWServerConnection):
Remove unnecessary ASSERT for entitlement.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/ios/NetworkProcessIOS.mm:

(WebKit::NetworkProcess::parentProcessHasServiceWorkerEntitlement const):
(WebKit::NetworkProcess::disableServiceWorkerEntitlement):
(WebKit::NetworkProcess::clearServiceWorkerEntitlementOverride):
In order to test this thoroughly, TestWebKitAPI needed a way to
temporarily disable the service worker entitlement. This function
overrides the check for the entitlement if the bool is set, disabling
the entitlement.

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:

WebPage needs to know if it is app-bound when created so it can update
the service worker preferences key accordingly.

• Shared/WebPreferences.yaml:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _serviceWorkerEntitlementDisabledForTesting]):
(-[WKPreferences _setServiceWorkerEntitlementDisabledForTesting:]):

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Disable entitlement for testing.

• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy const):

• UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::limitsNavigationsToAppBoundDomains const):
(API::PageConfiguration::setLimitsNavigationsToAppBoundDomains):
(API::PageConfiguration::limitsNavigationToAppBoundDomains const): Deleted.
(API::PageConfiguration::setLimitsNavigationToAppBoundDomains): Deleted.
(-[WKWebViewConfiguration limitsNavigationsToAppBoundDomains]):
(-[WKWebViewConfiguration setLimitsNavigationsToAppBoundDomains:]):
(-[WKWebViewConfiguration limitsNavigationToAppBoundDomains]): Deleted.
(-[WKWebViewConfiguration setLimitsNavigationToAppBoundDomains:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

Inconsistent naming (Navigation vs Navigations).

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setupPageConfiguration:]):
Check for entitlement or app-bound webview.

(-[WKWebView _serviceWorkersEnabled:]):
(-[WKWebView _clearServiceWorkerEntitlementOverride:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

Testing SPIs.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getAppBoundDomains):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:

Sends the app-bound domains to the Network Process.

• UIProcess/WebPageProxy.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):
(WebKit::m_limitsNavigationToAppBoundDomains): Deleted.
Naming inconsistency.

(WebKit::WebPageProxy::disableServiceWorkerEntitlementInNetworkProcess):
(WebKit::WebPageProxy::clearServiceWorkerEntitlementOverride):

• UIProcess/WebPageProxy.h:

Disable entitlement for testing.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_isNavigatingToAppBoundDomain):
Set this parameter in the constructor so it will be accurate when
updating preferences.

(WebKit::WebPage::updatePreferences):

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::clearServiceWorkerEntitlementOverride):

• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::parentProcessHasServiceWorkerEntitlement const):
(WebKit::WebPage::disableServiceWorkerEntitlement):
(WebKit::WebPage::clearServiceWorkerEntitlementOverride):
Disable entitlement for testing.

Tools:

Adds 2 test cases to make sure service workers behave properly on
app bound domains, and that the APIs are not available on non-app
bound domains.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(-[SWInAppBrowserPrivacyMessageHandler userContentController:didReceiveScriptMessage:]):

4:40 PM Changeset in webkit [260302] by achristensen@apple.com

• 7 edits in trunk

NetworkSessionCocoa should request client certificate only once per host/port
​https://bugs.webkit.org/show_bug.cgi?id=210626
<rdar://problem/60340449>

Reviewed by Geoffrey Garen.

Source/WebKit:

NSURLSession creates more than one TCP connection to a server when using HTTP 1.1.
Each TCP connection with TLS generates a didReceiveChallenge to do the server trust evaluation of the certificate chain.
If the server requests a client certificate in the TLS handshake, it also generates a didReceiveChallenge to request client
certificates as well. This is an implementation detail of our networking. We should not actually ask the WKNavigationDelegate
for client certificates more than once per host/port. We should remember the credential and give it to NSURLSession immediately
if we have used this credential in the past for a task that has received bytes (either a response or a redirect). If the TLS
handshake fails, we should not reuse that same certificate automatically.

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(WebKit::NetworkSessionCocoa::clientCertificateSuggestedForHost):
(WebKit::NetworkSessionCocoa::taskReceivedBytes):
(WebKit::NetworkSessionCocoa::taskFailed):
(WebKit::NetworkSessionCocoa::successfulClientCertificateForHost const):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:

(TestWebKitAPI::clientCertServerWithCertVerifier):
(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/HTTPServer.h:

(TestWebKitAPI::HTTPServer::HTTPResponse::HTTPResponse):

• TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::HTTPServer):

4:30 PM Changeset in webkit [260301] by dino@apple.com

• 6 edits in trunk/Source/WebCore

[WebGL] Confirm there are no errors when setting up framebuffers
​https://bugs.webkit.org/show_bug.cgi?id=210632
<rdar://problem/61916680>

Reviewed by Simon Fraser.

We're seeing crashes on macOS inside GraphicsContextGL::reshape().
Specifically when we submit work at the end of the function via
glFlush.

At the moment the cause is a mystery, because we should bail out
before then if the multisample renderbuffer was not complete. In
the hope that it helps somewhat, add a call to glGetError to double
check that there isn't anything horribly wrong before we talk to
the GPU.

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::WebGL2RenderingContext): If the underlying
GCGL context was marked as "LOST" during initialization, skip the rest of our
initialization.

• html/canvas/WebGLRenderingContext.cpp: Ditto.

(WebCore::WebGLRenderingContext::WebGLRenderingContext):

• html/canvas/WebGLRenderingContextBase.cpp: Ditto.

(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):

• platform/graphics/angle/GraphicsContextGLANGLE.cpp: Check for a GL error during

setup and, if there is one, skip directly into a LOST state.
(WebCore::GraphicsContextGLOpenGL::reshape):

• platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

(WebCore::GraphicsContextGLOpenGL::reshape):

4:13 PM Changeset in webkit [260300] by Alan Coon

• 1 copy in tags/Safari-609.2.7.1

Tag Safari-609.2.7.1.

4:06 PM Changeset in webkit [260299] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

Bug 210646: REGRESSION (r260112): createArchiveList() leaks malloc memory on early returns due to an error
<​https://webkit.org/b/210646>
<rdar://problem/61928031>

Reviewed by Darin Adler.

• Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::createArchiveList):

• Move early returns for protocolProperties, protocolProperties and mimeType above memory allocation to fix the memory leak.

4:05 PM Changeset in webkit [260298] by ddkilzer@apple.com

• 2 edits in trunk/Tools

Bug 210645: REGRESSION (r211095): [iOS] TestRunnerWKWebView leaks @property accessibilitySpeakSelectionContent
<​https://webkit.org/b/210645>
<rdar://problem/61927607>

Reviewed by Chris Fleizach.

• WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView dealloc]):

• Release accessibilitySpeakSelectionContent in -dealloc.

4:01 PM Changeset in webkit [260297] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r260279.
​https://bugs.webkit.org/show_bug.cgi?id=210678

Throwing error would be more efficient, having a generic code
is still worth doing (Requested by yusukesuzuki on #webkit).

Reverted changeset:

"[JSC] We do not need to have exit-check for Map/Set iterator
functions"
​https://bugs.webkit.org/show_bug.cgi?id=210667
​https://trac.webkit.org/changeset/260279

4:01 PM Changeset in webkit [260296] by Alan Coon

• 8 edits in branches/safari-609.2.7-branch/Source

Versioning.

3:55 PM Changeset in webkit [260295] by beidson@apple.com

• 17 edits in trunk

Pass sandbox extensions for back/forward list navigations after the policy is decided at process-swap time.
<rdar://problem/59535167> and ​https://bugs.webkit.org/show_bug.cgi?id=210623

Reviewed by Geoff Garen.

Source/WebKit:

Covered by almost all existing tests, and a new API test.

Instead of granting a sandbox extension when updating the back/forward cursor for a pending
back/forward list traversal, do so after the client decides the policy.
(Which is also along with a process swap in interesting cases)

• Shared/PolicyDecision.h:

(WebKit::PolicyDecision::encode const):
(WebKit::PolicyDecision::decode):

• Shared/WebPageCreationParameters.h:

• UIProcess/API/APINavigation.cpp:

(API::Navigation::Navigation):

• UIProcess/API/APINavigation.h:

(API::Navigation::create):
(API::Navigation::reloadItem const):

• UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::backForwardGoToItem):

• UIProcess/ProvisionalPageProxy.h:

• UIProcess/WebNavigationState.cpp:

(WebKit::WebNavigationState::createReloadNavigation):

• UIProcess/WebNavigationState.h:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::launchProcessForReload):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::receivedPolicyDecision):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::receivedPolicyDecision):

• UIProcess/WebPageProxy.messages.in:

• WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::goToItem):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::didReceivePolicyDecision):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

3:45 PM Changeset in webkit [260294] by Alan Coon

• 1 copy in branches/safari-609.2.7-branch

New branch.

3:41 PM Changeset in webkit [260293] by Peng Liu

• 4 edits in trunk/Source/WebCore

Cleanup the macros for video fullscreen and picture-in-picture
​https://bugs.webkit.org/show_bug.cgi?id=210638

Reviewed by Eric Carlson.

A follow-up patch to fix build failures of r260259.

• platform/ios/VideoFullscreenInterfaceAVKit.h:
• platform/ios/VideoFullscreenInterfaceAVKit.mm:
• platform/ios/WebVideoFullscreenControllerAVKit.mm:

3:35 PM Changeset in webkit [260292] by Russell Epstein

• 1 copy in tags/Safari-610.1.10

Tag Safari-610.1.10.

3:33 PM Changeset in webkit [260291] by Devin Rousso

• 12 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r242018): using RegExp.prototype.test with a global RegExp will ignore one potential match after each successful match
​https://bugs.webkit.org/show_bug.cgi?id=210671

Reviewed by Timothy Hatcher.

• UserInterface/Base/SearchUtilities.js:

(WI.SearchUtilities.searchRegExpForString):
(WI.SearchUtilities.filterRegExpForString):
(WI.SearchUtilities._regExpForString):
(WI.SearchUtilities.regExpForString): Deleted.
Many uses of WI.SearchUtilities.regExpForString use the returned RegExp multiple times,
expecting each use to be done in isolation from every other use (e.g. filtering). In these
cases, the global flag g should not be set on the RegExp, as otherwise it will keep a
state of the last matched index, thereby breaking this isolation. As such, it is necessary
to split WI.SearchUtilities.regExpForString into two versions, one for each use case.

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._highlightSearchResults):

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.performSearch):

• UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._perfomSearchOnKeyValuePairs):

• UserInterface/Views/ResourceSecurityContentView.js:

(WI.ResourceSecurityContentView.prototype._perfomSearchOnKeyValuePairs):

• UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype.performSearch.forEachMatch):
Use WI.SearchUtilities.searchRegExpForString as these views expect the search to maintain
its current position throughout the contents of the view.

• UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype._updateFilter):

• UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:

(WI.IndexedDatabaseObjectStoreContentView.prototype.dataGridMatchNodeAgainstCustomFilters):

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._urlFilterDidChange):

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.customPerformSearch.searchResultCallback):

• UserInterface/Views/TextEditor.js:

(WI.TextEditor.prototype.performSearch):
Use WI.SearchUtilities.filterRegExpForString as these views expect each search to be done
in isolation from every other search (e.g. filtering).

3:08 PM Changeset in webkit [260290] by ddkilzer@apple.com

• 5 edits in trunk/Source

REGRESSION (r234105): [iOS] WKColorButton leaks a UIColor
<​https://webkit.org/b/210658>
<rdar://problem/61938137>

Reviewed by Darin Adler.

Source/WebCore:

• html/ColorInputType.cpp:

(WebCore::ColorInputType::isKeyboardFocusable const):

• page/Chrome.cpp:

(WebCore::Chrome::createColorChooser):

• Drive-by fix of unreachable code on PLATFORM(IOS_FAMILY).

Source/WebKit:

• UIProcess/ios/forms/WKFormColorPicker.mm:

(-[WKColorButton dealloc]): Add.

• Release _color instance variable to fix leak.

2:48 PM Changeset in webkit [260289] by sbarati@apple.com

• 8 edits
  1 add in trunk

GetTypedArrayByteOffset is broken on arm64e
​https://bugs.webkit.org/show_bug.cgi?id=210631

Reviewed by Mark Lam.

JSTests:

• stress/byte-offset-on-wasteful-neutered-arm64e.js: Added.

(foo):
(assert):
(transferArrayBuffer.array.buffer):

Source/JavaScriptCore:

The vector of JSArrayBufferView is signed even when null on arm64e. However, we were
comparing against zero, which is wrong. This patch changes it so we do the right thing
and instead compare against whatever constant (ptr=nullptr,size=0) signs as.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetTypedArrayByteOffset):

• runtime/CagedBarrierPtr.h:

(JSC::CagedBarrierPtr::rawBits const):

• runtime/JSArrayBufferView.h:

(JSC::JSArrayBufferView::nullVectorPtr):

Source/WTF:

• wtf/CagedPtr.h:

(WTF::CagedPtr::rawBits const):

2:34 PM Changeset in webkit [260288] by Alan Coon

• 4 edits
  1 add in branches/safari-609-branch

Cherry-pick r260278. rdar://problem/61950220

Bring Fullscreen API + alert() behavior from iOS to macOS
​https://bugs.webkit.org/show_bug.cgi?id=210662

Reviewed by Eric Carlson.

Source/WebKit:

When a page is showing an alert(), all non-synchronous messages will be blocked until the sync XPC for alert()
ends. And when exiting fullscreen, we block completing the fullscreen exit animation until a repaint XPC completes.
So a page that is showing an alert() will never fully exit element fullscreen mode.

On iOS, we fixed this behavior by exiting fullscreen mode whenever the page shows an alert() or prompt(). We should
bring this behavior to macOS as well.

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm: Added. (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:34 PM Changeset in webkit [260287] by Alan Coon

• 2 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r260246. rdar://problem/61943700

offlineasm is generating the wrong load/store for the "orh" instruction.
​https://bugs.webkit.org/show_bug.cgi?id=210639
<rdar://problem/21501876>

Reviewed by Robin Morisset.

For example, on ARM64E, the "orh" instruction was generating the following:

"\tldr w17, [x1, #0]\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919
"\torr w17, w17, #64\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919
"\tstr w17, [x1, #0]\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919

i.e. a 32-bit load, followed by a 32-bit OR, followed by a 32-bit store.

Instead, it should be generating the following:

"\tldrh w17, [x1, #0]\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919
"\torr w17, w17, #64\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919
"\tstrh w17, [x1, #0]\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919

i.e. a 16-bit load, followed by a 32-bit OR, followed by a 16-bit store.

This bug also affects ARM64, ARMv7, and MIPS (basically any backend that uses
riscLowerMisplacedAddresses() from rise.rb). It does not affect x86, x86_64, and
C_LOOP (which was written based on x86).

• offlineasm/risc.rb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:34 PM Changeset in webkit [260286] by Alan Coon

• 3 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r260180. rdar://problem/61943707

[JSC] Use ensureStillAliveHere in FTL when content of storage should be kept alive
​https://bugs.webkit.org/show_bug.cgi?id=210583
<rdar://problem/61831515>

Reviewed by Mark Lam.

The content of Butterfly / ArrayStorage is kept alive only when the owner JSCell is alive.
This means that we should keep the owner JSCell alive if we are loading content of storage
which includes JSCells. This patch inserts ensureStillAliveHere in FTL to ensure this invariant.

• ftl/FTLJITCode.cpp: (JSC::FTL::JITCode::~JITCode): Found that we get crash with dumpDisassembly if FTL::JITCode is destroyed while it fails to generate code while testing this.
• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileGetByVal): (JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf): (JSC::FTL::DFG::LowerDFGToB3::compileArrayPop): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharCodeAt): (JSC::FTL::DFG::LowerDFGToB3::compileStringCodePointAt): (JSC::FTL::DFG::LowerDFGToB3::compileGetByOffset): (JSC::FTL::DFG::LowerDFGToB3::compileMultiGetByOffset):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:34 PM Changeset in webkit [260285] by Alan Coon

• 2 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r259572. rdar://problem/61943713

[JSC] Put ensureStillAliveHere for Integer TypedArrays in GetByVal
​https://bugs.webkit.org/show_bug.cgi?id=210047

Reviewed by Mark Lam.

While r258381 puts ensureStillAliveHere in FTL to keep base alive for float/double TypedArrays,
we need to do the same thing for integer TypedArrays too. This patch places it.

• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@259572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:29 PM Changeset in webkit [260284] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] Deny iokit open access of unused class in the WebContent sandbox
​https://bugs.webkit.org/show_bug.cgi?id=210669

Reviewed by Brent Fulgham.

Telemetry shows that iokit open access of an iokit class can be removed from the WebContent sandbox.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

2:20 PM Changeset in webkit [260283] by Chris Dumez

• 17 edits in trunk/Source/WebKit

[iOS] Refactor WebKit uploads process assertion logic to minimize chances of leaking them
​https://bugs.webkit.org/show_bug.cgi?id=210664
<rdar://problem/61751982>

Reviewed by Geoff Garen.

To minimize chances of leaking "WebKit uploads" process assertion, the following refactoring
was done:

1. WebKit upload assertions are now held by NetworkProcessProxy instead of the WebProcessPool. This makes more sense since uploads are tied to a particular network process. In base of a network process crash, we would not want those assertions to persist for example.
2. Store all upload assertions (UIProcess + NetworkProcess + WebProcesses) into a single UploadActivity data structure that can easily be cleared. Make sure we clear it on network process crash.
3. No longer on the WebProcess to send IPC whenever its has pending uploads or not. Instead, have the network process send such IPC. This makes more sense, especially now that all webkit upload process assertions are now stored on NetworkProcessProxy. It also makes it so that we deal properly with WebProcess crashes. In case of a WebProcess crash, its connection to the network process will get closed. NetworkConnectionToWebProcess::didClose() gets called and causes all NetworkResourceLoader objects for this connection to get destroyed. As a result, the network process will properly notify the UIProcess that this process no longer has any upload in progress.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::hasUploadStateChanged):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkResourceLoadMap.cpp:

(WebKit::NetworkResourceLoadMap::NetworkResourceLoadMap):
(WebKit::NetworkResourceLoadMap::~NetworkResourceLoadMap):
(WebKit::NetworkResourceLoadMap::add):
(WebKit::NetworkResourceLoadMap::clear):
(WebKit::NetworkResourceLoadMap::take):
(WebKit::NetworkResourceLoadMap::setHasUpload):

• NetworkProcess/NetworkResourceLoadMap.h:

(WebKit::NetworkResourceLoadMap::hasUpload const):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::setWebProcessHasUploads):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/ProcessAssertion.cpp:

(WebKit::ProcessAssertion::ProcessAssertion):

• UIProcess/ProcessAssertion.h:

(WebKit::ProcessAssertion::pid const):

• UIProcess/WebProcessPool.cpp:
• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessPool.messages.in:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):

• UIProcess/WebProcessProxy.h:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::remove):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):

• WebProcess/Network/WebLoaderStrategy.h:

2:19 PM Changeset in webkit [260282] by Brent Fulgham

• 2 edits in trunk/Tools

Unreviewed build fix after r260269.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(TEST): Correct argument order.

2:13 PM Changeset in webkit [260281] by Ryan Haddad

• 2 edits in branches/safari-609-branch/Tools

Cherry-pick r258385. rdar://problem/61948294

Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
​https://bugs.webkit.org/show_bug.cgi?id=209038

Reviewed by Keith Miller.

This allows us to automatically pull in some tests that are in non open sourced Apple
checkouts.

• Scripts/run-javascriptcore-tests: (runJSCStressTests):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@258385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:05 PM Changeset in webkit [260280] by Alan Coon

• 8 edits in branches/safari-609-branch/Source

Versioning.

2:03 PM Changeset in webkit [260279] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] We do not need to have exit-check for Map/Set iterator functions
​https://bugs.webkit.org/show_bug.cgi?id=210667

Reviewed by Michael Saboff.

If the intrinsic's DFG node does not support general cases, we should check exit-frequency to avoid exit-recompile loop.
However, Map/Set iterator creation functions (values, keys, entries) always require Map / Set types. And throwing an error
when this is not met. So, the current DFG nodes for these intrinsic supports all the cases except for the case throwing an
error, and error will exit anyway. So we do not need to have this exit-frequency guard here.

This path is already tested by map-iterator-check-before-fail.js / set-iterator-check-before-fail.js.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

1:41 PM Changeset in webkit [260278] by jer.noble@apple.com

• 4 edits
  1 add in trunk

Bring Fullscreen API + alert() behavior from iOS to macOS
​https://bugs.webkit.org/show_bug.cgi?id=210662

Reviewed by Eric Carlson.

Source/WebKit:

When a page is showing an alert(), all non-synchronous messages will be blocked until the sync XPC for alert()
ends. And when exiting fullscreen, we block completing the fullscreen exit animation until a repaint XPC completes.
So a page that is showing an alert() will never fully exit element fullscreen mode.

On iOS, we fixed this behavior by exiting fullscreen mode whenever the page shows an alert() or prompt(). We should
bring this behavior to macOS as well.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm: Added.

(TestWebKitAPI::TEST):

1:15 PM Changeset in webkit [260277] by don.olmstead@sony.com

• 20 edits
  1 add in trunk

[CMake] Add WebKit::WebCore target
​https://bugs.webkit.org/show_bug.cgi?id=210445

Reviewed by Michael Catanzaro.

.:

Add a target file for internal Apple Windows builds.

• Source/cmake/target/WebCore.cmake: Added.

Source/WebCore:

Add a WebKit::WebCore target. Remove the WebCoreHeaderInterface target since
the WebKit::WebCore target is functionaly the same.

• CMakeLists.txt:

Source/WebKit:

Use the WebKit::WebCore target within the WebKit target.

• CMakeLists.txt:
• PlatformGTK.cmake:
• PlatformWPE.cmake:
• PlatformWin.cmake:

Source/WebKitLegacy:

Use the WebKit::WebCore target within WebKitLegacy.

• CMakeLists.txt:
• PlatformFTW.cmake:
• PlatformWin.cmake:

Tools:

Use the WebKit::WebCore target within tests and developer tools.

• DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
• MiniBrowser/wpe/CMakeLists.txt:
• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/PlatformGTK.cmake:
• TestWebKitAPI/PlatformWPE.cmake:
• TestWebKitAPI/PlatformWin.cmake:
• TestWebKitAPI/glib/CMakeLists.txt:

1:04 PM Changeset in webkit [260276] by Simon Fraser

• 3 edits in trunk/Source/WebKit

Turn async frame and overflow scrolling on by default on macOS
​https://bugs.webkit.org/show_bug.cgi?id=210661
rdar://problem/60420037

Reviewed by Tim Horton.

Flip the plist value and the default value for macOS which is outside of the feature flag #ifdef.

Testing keeps async overflow scrolling off by default, so this should not affect testing.

This only impacts WebKit2.

• FeatureFlags/WebKit.plist:
• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultAsyncFrameAndOverflowScrollingEnabled):

12:46 PM Changeset in webkit [260275] by Devin Rousso

• 8 edits
  1 move in trunk

Rename NullishEq / NULLISHEQUAL to CoalesceEq / COALESCEEQUAL to match the spec
​https://bugs.webkit.org/show_bug.cgi?id=210663

Reviewed by Ross Kirsling.

JSTests:

• stress/logical-assignment-operator-coalesce.js: Renamed from stress/logical-assignment-operator-nullish.js.

Source/JavaScriptCore:

• bytecompiler/NodesCodegen.cpp:

(JSC::emitShortCircuitAssignment):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::makeAssignNode):

• parser/Lexer.cpp:

(JSC::Lexer<T>::lexWithoutClearingLineTerminator):

• parser/Nodes.h:
• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseAssignmentExpression):

• parser/ParserTokens.h:

12:32 PM Changeset in webkit [260274] by Ryan Haddad

• 9 edits
  8 deletes in trunk

Unreviewed, reverting r260245.

The tests added with this change are frequently failing on
macOS bots.

Reverted changeset:

"Safari doesn't apply frameRate limit when request stream from
Camera"
​https://bugs.webkit.org/show_bug.cgi?id=210186
​https://trac.webkit.org/changeset/260245

12:31 PM Changeset in webkit [260273] by Devin Rousso

• 28 edits
  6 adds in trunk

Implement Promise.any and AggregateError
​https://bugs.webkit.org/show_bug.cgi?id=202566

Reviewed by Yusuke Suzuki.

JSTests:

• test262/config.yaml:
• test262/expectations.yaml:

Source/JavaScriptCore:

Promise.any resolves when any of the given promises resolve, but only rejects if _all_
of the given promises reject. In order to support aggregating all of the reason values
for all of the rejections, a new error type AggregateError is introduced which has an
get errors that returns an aggregated array of the reason values.

• builtins/PromiseConstructor.js:

(all.newResolveElement):
(allSettled.newResolveRejectElements):
(any): Added.
(any.newRejectElement): Added.

• runtime/JSPromiseConstructor.cpp:

• builtins/BuiltinNames.h:
• bytecode/LinkTimeConstant.h:
• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::errorStructure const):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::initializeAggregateErrorConstructor): Added.
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
Expose @AggregateError for builtins.

• runtime/AggregateError.h: Added.

(JSC::AggregateError::destroy):
(JSC::AggregateError::subspaceFor):
(JSC::AggregateError::createStructure):
(JSC::AggregateError::create):
(JSC::AggregateError::errors const):

• runtime/AggregateError.cpp: Added.

(JSC::AggregateError::AggregateError):
(JSC::AggregateError::visitChildren):
(JSC::AggregateError::create):
(JSC::AggregateError::finishCreation):

• runtime/AggregateErrorPrototype.h: Added.
• runtime/AggregateErrorPrototype.cpp: Added.

(JSC::AggregateErrorPrototype::AggregateErrorPrototype):
(JSC::AggregateErrorPrototype::finishCreation):
(JSC::aggregateErrorPrototypeAccessorErrors):

• runtime/AggregateErrorConstructor.h: Added.
• runtime/AggregateErrorConstructor.cpp: Added.

(JSC::callAggregateErrorConstructor):
(JSC::constructAggregateErrorConstructor):
(JSC::AggregateErrorConstructor::AggregateErrorConstructor):
(JSC::AggregateErrorConstructor::finishCreation):

• runtime/ErrorType.h:
• runtime/ErrorType.cpp:

(JSC::errorTypeName):

• runtime/VM.h:
• runtime/VM.cpp:

(JSC::VM::VM):
Make an IsoSubspace for AggregateError as it has a different size than ErrorInstance.

• runtime/ErrorInstance.h:

(JSC::ErrorInstance::create):

• runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::finishCreation):

• wasm/js/JSWebAssemblyCompileError.cpp:

(JSC::JSWebAssemblyCompileError::create):

• wasm/js/JSWebAssemblyLinkError.cpp:

(JSC::JSWebAssemblyLinkError::create):

• wasm/js/JSWebAssemblyRuntimeError.cpp:

(JSC::JSWebAssemblyRuntimeError::create):
Assign to ErrorInstance member variables inside ErrorInstance::finishCreation instead of
inside ErrorInstance::create so that subclasses don't have to do the work as well.

• runtime/Error.cpp:

(JSC::createError):

• runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::createStructure):

• runtime/NativeErrorPrototype.h:

(JSC::NativeErrorPrototype::createStructure):
Drive-by: fix incorrect usage of ErrorInstanceType since ErrorPrototype does not inherit

from ErrorInstance (and therefore neither does NativeErrorPrototype).

• runtime/ArgList.h:

Add WTF_MAKE_NONMOVABLE to MarkedArgumentBuffer.

• Sources.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebInspectorUI:

• UserInterface/Models/IssueMessage.js:

Mark AggregateError as a WI.IssueMessage.Type.SemanticIssue.

12:26 PM Changeset in webkit [260272] by Ryan Haddad

• 2 edits in trunk/LayoutTests

REGRESSION (r259463): [ Mojave Debug ] http/tests/IndexedDB/collect-IDB-objects.https.html is flaky failing and timing out
​https://bugs.webkit.org/show_bug.cgi?id=210219

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations: Test transitioned from timeout -> failure.

12:10 PM Changeset in webkit [260271] by pvollan@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix.

• platform/cocoa/AGXCompilerService.cpp:

11:55 AM Changeset in webkit [260270] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

REGRESSION ( r254044 ): [ Win ] css1/box_properties/padding_left.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=207480

Unreviewed test gardening.

Adjusted this test expectation and others in the Windows category with lint alerts.

• platform/win/TestExpectations:

11:35 AM Changeset in webkit [260269] by graouts@webkit.org

• 2 edits in trunk/Tools

Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled
​https://bugs.webkit.org/show_bug.cgi?id=210606

Unreviewed build fix after r260261.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(TEST):

11:22 AM Changeset in webkit [260268] by Russell Epstein

• 1 copy in tags/Safari-609.2.7

Tag Safari-609.2.7.

11:06 AM Changeset in webkit [260267] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

Layout Test fast/text/variations/ipc2.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=189550

Unreviewed test gardening.

• platform/win/TestExpectations:

11:04 AM Changeset in webkit [260266] by Alan Coon

• 539 edits
  19 adds
  160 deletes in branches/safari-610.1.10-branch/Source/ThirdParty/ANGLE

Revert r259589. rdar://problem/61942180

10:57 AM Changeset in webkit [260265] by Ross Kirsling

• 16 edits in trunk/Source/JavaScriptCore

Clean up some Intl classes following the ICU upgrade
​https://bugs.webkit.org/show_bug.cgi?id=210637

Reviewed by Yusuke Suzuki.

In r259606, I removed the compile-time guards for {DateTimeFormat, NumberFormat}.prototype.formatToParts,
but I forgot to move the method setup back to the lookup table.

This patch addresses that and prunes various other unnecessary includes and forward declarations.

• runtime/IntlCollator.h:
• runtime/IntlCollatorConstructor.h:
• runtime/IntlDateTimeFormat.h:
• runtime/IntlDateTimeFormatConstructor.h:
• runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototype::create):
(JSC::IntlDateTimeFormatPrototype::finishCreation):

• runtime/IntlDateTimeFormatPrototype.h:
• runtime/IntlNumberFormat.h:
• runtime/IntlNumberFormatConstructor.h:
• runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototype::create):
(JSC::IntlNumberFormatPrototype::finishCreation):

• runtime/IntlNumberFormatPrototype.h:
• runtime/IntlObject.h:
• runtime/IntlPluralRules.h:
• runtime/IntlPluralRulesConstructor.h:
• runtime/IntlPluralRulesPrototype.cpp:

(JSC::IntlPluralRulesPrototype::create):
(JSC::IntlPluralRulesPrototype::finishCreation):

• runtime/IntlPluralRulesPrototype.h:

10:56 AM Changeset in webkit [260264] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ macOS ] inspector/runtime/getCollectionEntries.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=207642

Unreviewed test gardening.

Removed duplicate expectations.

• platform/mac/TestExpectations:

10:44 AM Changeset in webkit [260263] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] Add telemetry to some mach lookup sandbox extensions
​https://bugs.webkit.org/show_bug.cgi?id=210657

Reviewed by Darin Adler.

Add telemetry in order to learn more about how some of the mach lookup extensions are being used in the WebContent process on iOS.

No new tests, since this patch does not change any behavior.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

10:43 AM Changeset in webkit [260262] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[Web Animations] Update WPT tests related to Web Animations and remove imported Mozilla tests
​https://bugs.webkit.org/show_bug.cgi?id=203291

Unreviewed test gardening.

Removed duplicate test expectations.

• platform/ios/TestExpectations:

10:24 AM Changeset in webkit [260261] by graouts@webkit.org

• 7 edits in trunk/Source/WebCore

Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled
​https://bugs.webkit.org/show_bug.cgi?id=210606

Reviewed by Antti Koivisto and Daniel Bates.

There is no need to insert style rules related to media controls in the UA stylesheet when Modern Media Controls are enabled.
There is one rule from mediaControlsApple.css for the default sizing of <audio> that makes sense broadly for content on the Web
so we move that to html.css. We also set the background-color property for media documents in html.css.

• Modules/mediacontrols/mediaControlsApple.css:

(audio): Deleted.
(body:-webkit-full-page-media): Deleted.

• Modules/mediacontrols/mediaControlsiOS.css:

(body:-webkit-full-page-media): Deleted.

• Modules/modern-media-controls/controls/media-document.css:

(:host(.media-document)):

• css/html.css:

(body:-webkit-full-page-media):
(audio):

• css/mediaControls.css:

(body:-webkit-full-page-media): Deleted.

• style/UserAgentStyle.cpp:

(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

10:17 AM Changeset in webkit [260260] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Validate socket in NetworkRTCProvider::wrapNewTCPConnection
​https://bugs.webkit.org/show_bug.cgi?id=210594

Reviewed by Eric Carlson.

• NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::wrapNewTCPConnection):
Add a null check in case the identifier does not relate to an existing pending socket.

10:13 AM Changeset in webkit [260259] by Peng Liu

• 33 edits in trunk/Source

Cleanup the macros for video fullscreen and picture-in-picture
​https://bugs.webkit.org/show_bug.cgi?id=210638

Reviewed by Eric Carlson.

Source/WebCore:

Replace some "#if PLATFORM(IOS_FAMILY) and all "#if (PLATFORM(IOS_FAMILY) && HAVE(AVKIT))

(PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))"

(PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))"

with "#if ENABLE(VIDEO_PRESENTATION_MODE)".

No new tests, no functional change.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaEngineWasUpdated):
(WebCore::HTMLMediaElement::setVideoFullscreenStandby):

• html/HTMLMediaElement.h:
• html/HTMLVideoElement.cpp:
• html/HTMLVideoElement.h:
• platform/PictureInPictureSupport.h:
• platform/cocoa/VideoFullscreenChangeObserver.h:
• platform/cocoa/VideoFullscreenModel.h:
• platform/cocoa/VideoFullscreenModelVideoElement.h:
• platform/cocoa/VideoFullscreenModelVideoElement.mm:
• platform/graphics/MediaPlayer.cpp:
• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h:
• platform/ios/VideoFullscreenInterfaceAVKit.mm:

(WebCore::supportsPictureInPicture):

Source/WebKit:

Replace some "#if PLATFORM(IOS_FAMILY) and all "#if (PLATFORM(IOS_FAMILY) && HAVE(AVKIT))

(PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))"

(PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))"

with "#if ENABLE(VIDEO_PRESENTATION_MODE)".

• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenGravity):
(WebKit::RemoteMediaPlayerProxy::updateVideoFullscreenInlineImage):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenMode):
(WebKit::RemoteMediaPlayerProxy::videoFullscreenStandbyChanged):

• UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
• UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in:
• UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didAttachToRunningProcess):
(WebKit::WebPageProxy::viewDidLeaveWindow):
(WebKit::WebPageProxy::exitFullscreenImmediately):

• UIProcess/WebPageProxy.h:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:
• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):

• WebProcess/WebPage/WebPage.h:
• WebProcess/cocoa/VideoFullscreenManager.h:
• WebProcess/cocoa/VideoFullscreenManager.messages.in:
• WebProcess/cocoa/VideoFullscreenManager.mm:

Source/WTF:

Add macro ENABLE_VIDEO_PRESENTATION_MODE.

• wtf/PlatformEnable.h:

10:01 AM Changeset in webkit [260258] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][TFC] Resolve the minimum width for overlapping spanner columns
​https://bugs.webkit.org/show_bug.cgi?id=210654

Reviewed by Antti Koivisto.

The extra horizontal space distribution is based on the columns' minimum widths.
In case of column spanners, first we need to distribute the spanner's minimum
width across the columns using the non-spanning minimum widths as the distribution ratio.
When there's no non-spanning minimum width for a column (all rows have column spanners for tbis particular column)
the minimum width gets distributed equally across the spanned columns. This distribution starts with the shortest columns spans
so that we can use these resolved column widths to compute the wider ones.

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace):

9:36 AM Changeset in webkit [260257] by Claudio Saavedra

• 2 edits in trunk/Source/WTF

[GTK][WPE] Bump dependencies minimum required version in Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=210651

Reviewed by Adrian Perez de Castro.

Bring the minimum required version in Platform.h in sync with the actual
minimal required version. This ensures that deprecated APIs used bring up
compilation warnings.

• wtf/Platform.h:

9:24 AM Changeset in webkit [260256] by Jason_Lawrence

• 2 edits in trunk/LayoutTests/imported/w3c

REGRESSION: (r260243) [ Mac and iOS ] imported/w3c/web-platform-tests/css/cssom-view/MediaQueryList-addListener-handleEvent.html fails.
​https://bugs.webkit.org/show_bug.cgi?id=210655

Unreviewed test gardening.

• web-platform-tests/css/cssom-view/MediaQueryList-addListener-handleEvent-expected.txt:

8:50 AM Changeset in webkit [260255] by Claudio Saavedra

• 9 edits in trunk

[GTK] Update for GdkKeymap API changes
​https://bugs.webkit.org/show_bug.cgi?id=210642

Reviewed by Adrian Perez de Castro.

No new tests needed.

gdk_keymap_get_default() is deprecated in GTK+ 3.22, so use
gdk_keymap_get_for_display() instead. Since in GTK4 this method is
removed to gdk_display_get_keymap(), add a helper to
GtkVersioning.h to avoid cluttering with ifdefs all over the
place.

Source/WebCore:

• platform/gtk/GtkVersioning.h:

(gdk_keymap_get_for_display):

• platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::modifiersContainCapsLock):

Source/WebKit:

• UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::doKeyStrokeEvent):

Tools:

• TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:

(WebViewTest::keyStroke):

• TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::doKeyStroke):

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::keyDown):

8:49 AM WebKitGTK/2.28.x edited by Michael Catanzaro

(diff)

8:47 AM Changeset in webkit [260254] by graouts@webkit.org

• 6 edits in trunk

Allow the UserStyleLevel to be set through _WKUserStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=210653
<rdar://problem/60506645>

Reviewed by Tim Horton.

Source/WebKit:

Add a new _WKUserStyleLevel enum such that we may provide the specificity level of the backing UserStyleSheet, represented by the UserStyleLevel enum in WebCore.

• UIProcess/API/Cocoa/_WKUserStyleSheet.h:
• UIProcess/API/Cocoa/_WKUserStyleSheet.mm:

(-[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:level:userContentWorld:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:baseURL:level:userContentWorld:]):
(-[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]): Deleted.

• UIProcess/API/Cocoa/_WKUserStyleSheetInternal.h:

(API::toWebCoreUserStyleLevel):

Tools:

Add new tests for the "level" parameter when creating a _WKUserStyleSheet.

• TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:

(TEST):

8:41 AM Changeset in webkit [260253] by commit-queue@webkit.org

• 2 edits in trunk/JSTests

Reduce test iterations for stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js on mips
​https://bugs.webkit.org/show_bug.cgi?id=210641

Patch by Paulo Matos <Paulo Matos> on 2020-04-17
Reviewed by Yusuke Suzuki.

Reduce test iteration count on mips for which the current value is too high.

• stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:

8:24 AM Changeset in webkit [260252] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[GTK][X11] REGRESSION(r259944): Wrong position of select popup menu in X11
​https://bugs.webkit.org/show_bug.cgi?id=210603

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-04-17
Reviewed by Michael Catanzaro.

gdk_window_move_to_rect expects the given rectangle in coordinates relative to the top-left corner of the window
that the popup window is transient for. We were using screen coordinates.

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Translate widget coordinates to window coordinates before passing
the rectangle to gdk_window_move_to_rect().

8:02 AM Changeset in webkit [260251] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r256756): -[WKUserDefaults initWithSuiteName:]: Instance variable used while 'self' is not set to the result of '[(super or self) init...]'
<​https://webkit.org/b/210647>
<rdar://problem/61928289>

Reviewed by Anders Carlsson.

• UIProcess/Cocoa/PreferenceObserver.mm:

(-[WKUserDefaults initWithSuiteName:]):

• Call [self initWithSuite:] and set self to fix the clang static analyzer warning.
• Fix camelCase of suitename parameter.

7:57 AM Changeset in webkit [260250] by ddkilzer@apple.com

• 2 edits in trunk/Tools

REGRESSION (r162729): [iOS] WebKitTestRunner over-releases UITextField in WTR::PlatformWebView::removeChromeInputField()
<​https://webkit.org/b/210643>
<rdar://problem/61927190>

Reviewed by Wenson Hsieh.

• WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::removeChromeInputField):

• Remove unnecessary -release.

7:46 AM Changeset in webkit [260249] by Oriol Brufau

• 27 edits in trunk

Revert "[css-grid] Exclude implicit grid tracks from the resolved value"
​https://bugs.webkit.org/show_bug.cgi?id=210617

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

WPT tests are not reverted for now, just updating the expectations.

• web-platform-tests/css/css-grid/grid-definition/grid-inline-support-flexible-lengths-001-expected.txt:
• web-platform-tests/css/css-grid/grid-definition/grid-inline-support-grid-template-columns-rows-001-expected.txt:
• web-platform-tests/css/css-grid/grid-definition/grid-inline-support-named-grid-lines-001-expected.txt:
• web-platform-tests/css/css-grid/grid-definition/grid-inline-support-repeat-001-expected.txt:
• web-platform-tests/css/css-grid/grid-definition/grid-inline-template-columns-rows-resolved-values-001-expected.txt:
• web-platform-tests/css/css-grid/grid-definition/grid-support-flexible-lengths-001-expected.txt:
• web-platform-tests/css/css-grid/grid-definition/grid-support-grid-template-columns-rows-001-expected.txt:
• web-platform-tests/css/css-grid/grid-definition/grid-support-named-grid-lines-001-expected.txt:
• web-platform-tests/css/css-grid/grid-definition/grid-support-repeat-001-expected.txt:
• web-platform-tests/css/css-grid/grid-definition/grid-template-columns-rows-resolved-values-001-expected.txt:
• web-platform-tests/css/css-grid/grid-layout-properties-expected.txt:
• web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-withcontent-expected.txt:
• web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-withcontent-expected.txt:

Source/WebCore:

Revert r254561 since it appears to be breaking site authoring tools
which were relying on the previous behaviour.

Tests: fast/css-grid-layout/grid-auto-columns-rows-get-set.html

fast/css-grid-layout/grid-columns-rows-get-set.html
fast/css-grid-layout/grid-template-shorthand-get-set.html
fast/css-grid-layout/mark-as-infinitely-growable.html
fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks.html
fast/css-grid-layout/negative-growth-share-as-infinity-crash.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-inline-support-flexible-lengths-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-inline-support-grid-template-columns-rows-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-inline-support-named-grid-lines-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-inline-support-repeat-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-inline-template-columns-rows-resolved-values-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-support-flexible-lengths-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-support-grid-template-columns-rows-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-support-named-grid-lines-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-support-repeat-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-template-columns-rows-resolved-values-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-withcontent.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-withcontent.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackList):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::trackSizesForComputedStyle const):

LayoutTests:

Revert r254561 since it appears to be breaking site authoring tools
which were relying on the previous behaviour.

• fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt:
• fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
• fast/css-grid-layout/grid-columns-rows-get-set.html:
• fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt:
• fast/css-grid-layout/grid-template-shorthand-get-set.html:
• fast/css-grid-layout/mark-as-infinitely-growable.html:
• fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks-expected.txt:
• fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks.html:
• fast/css-grid-layout/negative-growth-share-as-infinity-crash.html:

7:41 AM Changeset in webkit [260248] by ysuzuki@apple.com

• 3 edits
  2 adds in trunk

[JSC] Map/Set iterator creation functions should fail with BadType etc. before executing insertChecks
​https://bugs.webkit.org/show_bug.cgi?id=210649
<rdar://problem/61925452>

Reviewed by Mark Lam.

JSTests:

• stress/map-iterator-check-before-fail.js: Added.

(test):

• stress/set-iterator-check-before-fail.js: Added.

(set new):
(set var):

Source/JavaScriptCore:

Since insertChecks adds some DFG nodes, we should determine whether this intrinsic handling is OK or not before executing insertChecks.
Otherwise, we will hit an assertion with !didInsertChecks.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

7:40 AM Changeset in webkit [260247] by pvollan@apple.com

• 22 edits
  3 adds in trunk

[iOS] Deny iokit open access to graphics related classes
​https://bugs.webkit.org/show_bug.cgi?id=210616

Reviewed by Darin Adler.

Source/WebCore:

Deny iokit open access to graphics related classes in the WebContent process on iOS, but issue
extensions for these for some devices which still need access to them.

API test: WebKit.IOKitOpenSandboxAccessForDeviceWithAGXCompilerService

• WebCore.xcodeproj/project.pbxproj:
• platform/cocoa/AGXCompilerService.cpp: Added.

(WebCore::setDeviceHasAGXCompilerServiceForTesting):
(WebCore::deviceHasAGXCompilerService):

• platform/cocoa/AGXCompilerService.h: Added.
• testing/Internals.cpp:

(WebCore::Internals::hasSandboxIOKitOpenAccessToClass):

• testing/Internals.h:
• testing/Internals.idl:
• testing/Internals.mm:

(WebCore::Internals::hasSandboxIOKitOpenAccessToClass):

Source/WebKit:

Deny iokit open access to graphics related classes in the WebContent process on iOS, but issue
extensions for these for some devices which still need access to them.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::SandboxExtensionImpl::sandboxExtensionForType):
(WebKit::SandboxExtension::createHandleForIOKitClassExtension):

• Shared/SandboxExtension.h:
• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
• UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _setDeviceHasAGXCompilerServiceForTesting]):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::deviceHasAGXCompilerService): Deleted.

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setDeviceHasAGXCompilerServiceForTesting const):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

• wtf/spi/darwin/SandboxSPI.h:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm: Added.

(TEST):

7:38 AM Changeset in webkit [260246] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

offlineasm is generating the wrong load/store for the "orh" instruction.
​https://bugs.webkit.org/show_bug.cgi?id=210639
<rdar://problem/21501876>

Reviewed by Robin Morisset.

For example, on ARM64E, the "orh" instruction was generating the following:

"\tldr w17, [x1, #0]\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919
"\torr w17, w17, #64\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919
"\tstr w17, [x1, #0]\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919

i.e. a 32-bit load, followed by a 32-bit OR, followed by a 32-bit store.

Instead, it should be generating the following:

"\tldrh w17, [x1, #0]\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919
"\torr w17, w17, #64\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919
"\tstrh w17, [x1, #0]\n" JavaScriptCore/llint/LowLevelInterpreter64.asm:919

i.e. a 16-bit load, followed by a 32-bit OR, followed by a 16-bit store.

This bug also affects ARM64, ARMv7, and MIPS (basically any backend that uses
riscLowerMisplacedAddresses() from rise.rb). It does not affect x86, x86_64, and
C_LOOP (which was written based on x86).

• offlineasm/risc.rb:

7:22 AM Changeset in webkit [260245] by youenn@apple.com

• 9 edits
  8 adds in trunk

Safari doesn't apply frameRate limit when request stream from Camera
​https://bugs.webkit.org/show_bug.cgi?id=210186
<rdar://problem/61452794>

Reviewed by Eric Carlson.

Source/WebCore:

Add support to RealtimeVideoSource to decimate the video samples based on the observed frame rate of its capture source.
This allows supporting two tracks using the same capture device, one track being low frame rate and the other one high frame rate.

Clean-up refactoring to make RealtimeVideoSource directly inherit from RealtimeVideoCaptureSource.
Migrate size and format of frame adaptation from RealtimeVideoCaptureSource to RealtimeVideoSource.
Fix mock capture source to update its frame rate when asked by applyConstraints.

Tests: fast/mediastream/mediastreamtrack-video-frameRate-clone-decreasing.html

fast/mediastream/mediastreamtrack-video-frameRate-clone-increasing.html
fast/mediastream/mediastreamtrack-video-frameRate-decreasing.html
fast/mediastream/mediastreamtrack-video-frameRate-increasing.html

• platform/mediastream/RealtimeVideoCaptureSource.cpp:

(WebCore::RealtimeVideoCaptureSource::dispatchMediaSampleToObservers):
(WebCore::RealtimeVideoCaptureSource::clientUpdatedSizeAndFrameRate):

• platform/mediastream/RealtimeVideoCaptureSource.h:

(WebCore::RealtimeVideoCaptureSource::observedFrameRate const):

• platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::RealtimeVideoSource):
(WebCore::m_source):
(WebCore::RealtimeVideoSource::adaptVideoSample):
(WebCore::RealtimeVideoSource::videoSampleAvailable):

• platform/mediastream/RealtimeVideoSource.h:
• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::setFrameRateWithPreset):

• testing/Internals.cpp:

(WebCore::Internals::observeMediaStreamTrack):

LayoutTests:

• fast/mediastream/mediastreamtrack-video-frameRate-clone-decreasing-expected.txt: Added.
• fast/mediastream/mediastreamtrack-video-frameRate-clone-decreasing.html: Added.
• fast/mediastream/mediastreamtrack-video-frameRate-clone-increasing-expected.txt: Added.
• fast/mediastream/mediastreamtrack-video-frameRate-clone-increasing.html: Added.
• fast/mediastream/mediastreamtrack-video-framerate-decreasing-expected.txt: added.
• fast/mediastream/mediastreamtrack-video-framerate-decreasing.html: added.
• fast/mediastream/mediastreamtrack-video-framerate-increasing-expected.txt: added.
• fast/mediastream/mediastreamtrack-video-framerate-increasing.html: added.
• webrtc/routines.js:

6:36 AM WebKitGTK/Gardening/Howto edited by Lauro Moura

Update flakiness dashboard link (diff)

5:53 AM Changeset in webkit [260244] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

[GTK] UI process crash when entering compositing mode when WPE_RENDERER is enabled
​https://bugs.webkit.org/show_bug.cgi?id=209118

Reviewed by Michael Catanzaro.

Check if EGL_WL_bind_wayland_display extension is available when using WPE_RENDERER, since we don't suport the
SHM interface.

• UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:

(WebKit::AcceleratedBackingStoreWayland::checkRequirements): Return false if EGL_WL_bind_wayland_display is not present.

3:16 AM Changeset in webkit [260243] by Alexey Shvayka

• 31 edits
  3 adds
  5 deletes in trunk

MediaQueryList should extend EventTarget
​https://bugs.webkit.org/show_bug.cgi?id=203288

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/css/cssom-view/MediaQueryList-addListener-handleEvent-expected.txt:
• web-platform-tests/css/cssom-view/MediaQueryList-addListener-removeListener-expected.txt:
• web-platform-tests/css/cssom-view/MediaQueryList-extends-EventTarget-expected.txt:
• web-platform-tests/css/cssom-view/MediaQueryList-extends-EventTarget-interop-expected.txt:
• web-platform-tests/css/cssom-view/MediaQueryListEvent-expected.txt:
• web-platform-tests/css/cssom-view/idlharness-expected.txt:
• web-platform-tests/css/cssom-view/matchMedia-expected.txt:

Source/WebCore:

Initially, CSSOM View Module specification [1] had a custom callback mechanism with addListener() and removeListener(),
and the callback was invoked with the associated MediaQueryList as argument.

Now the normal event mechanism [2] is used instead. For backwards compatibility, addListener() and removeListener()
methods are basically aliases for addEventListener() and removeEventListener(), respectively, and the "change" event
masquerades as a MediaQueryList.

This patch implements new event mechanism, aligning WebKit with Blink and SpiderMonkey, and also fixes
a few minor spec incompatibilities: mandatory listener argument, "handleEvent" support, and listeners call order.

[1]: ​https://www.w3.org/TR/2011/WD-cssom-view-20110804/#mediaquerylist
[2]: ​https://www.w3.org/TR/cssom-view-1/#mediaquerylist

Tests: fast/media/media-query-list-07.html

web-platform-tests/css/cssom-view/MediaQueryList-addListener-handleEvent.html
web-platform-tests/css/cssom-view/MediaQueryList-addListener-removeListener.html
web-platform-tests/css/cssom-view/MediaQueryList-extends-EventTarget.html
web-platform-tests/css/cssom-view/MediaQueryList-extends-EventTarget-interop.html
web-platform-tests/css/cssom-view/MediaQueryListEvent.html
web-platform-tests/css/cssom-view/idlharness.html
web-platform-tests/css/cssom-view/matchMedia.html

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• bindings/scripts/test/JS/*: Updated.
• css/MediaQueryList.cpp:

(WebCore::MediaQueryList::MediaQueryList):
(WebCore::MediaQueryList::create):
(WebCore::MediaQueryList::~MediaQueryList):
(WebCore::MediaQueryList::addListener):
(WebCore::MediaQueryList::removeListener):

• css/MediaQueryList.h:
• css/MediaQueryList.idl:
• css/MediaQueryListEvent.cpp: Added.

(WebCore::MediaQueryListEvent::MediaQueryListEvent):

• css/MediaQueryListEvent.h: Added.
• css/MediaQueryListEvent.idl: Added.
• css/MediaQueryListListener.h: Removed.
• css/MediaQueryListListener.idl: Removed.
• css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::documentDestroyed):
(WebCore::MediaQueryMatcher::addMediaQueryList):
(WebCore::MediaQueryMatcher::removeMediaQueryList):
(WebCore::MediaQueryMatcher::matchMedia):
(WebCore::MediaQueryMatcher::evaluateAll):
(WebCore::MediaQueryMatcher::addListener): Deleted.
(WebCore::MediaQueryMatcher::removeListener): Deleted.

• css/MediaQueryMatcher.h:
• dom/EventNames.in:
• dom/EventTarget.h:

(WebCore::EventTarget::removeEventListener):

• dom/EventTargetFactory.in:

Source/WebInspectorUI:

• UserInterface/Models/NativeFunctionParameters.js:

LayoutTests:

• TestExpectations:
• fast/media/media-query-list-07-expected.txt:
• fast/media/media-query-list-07.html:

2:35 AM Changeset in webkit [260242] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebCore

Unreviewed build fix after r260123

No new tests needed.

• platform/gtk/CursorGtk.cpp:

(WebCore::createCustomCursor): Pass missing pixel buffer data pointer to gdk_memory_texture_new().

1:40 AM Changeset in webkit [260241] by youenn@apple.com

• 10 edits in trunk/Source

Make use of WeakHashSet for MediaStreamTrackPrivate and RealtimeMediaSource observers
​https://bugs.webkit.org/show_bug.cgi?id=210492

Reviewed by Geoffrey Garen.

Source/WebCore:

We are making use of WeakHashSet to improve the robustness of the code.
For that purpose we use the new WeakHashSet::forEach method.
No change of behavior.

• Modules/mediarecorder/MediaRecorder.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
• platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::forEachObserver const):

• platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::forEachObserver):
(WebCore::MediaStreamTrackPrivate::addObserver):
(WebCore::MediaStreamTrackPrivate::removeObserver):
(WebCore::MediaStreamTrackPrivate::forEachObserver const): Deleted.

• platform/mediastream/MediaStreamTrackPrivate.h:

(WebCore::MediaStreamTrackPrivate::hasObserver const): Deleted.

• platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::addAudioSampleObserver):
(WebCore::RealtimeMediaSource::removeAudioSampleObserver):
(WebCore::RealtimeMediaSource::addObserver):
(WebCore::RealtimeMediaSource::removeObserver):
(WebCore::RealtimeMediaSource::forEachObserver):
(WebCore::RealtimeMediaSource::notifyMutedObservers):
(WebCore::RealtimeMediaSource::requestToEnd):
(WebCore::RealtimeMediaSource::forEachObserver const): Deleted.
(WebCore::RealtimeMediaSource::notifyMutedObservers const): Deleted.

• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/RealtimeOutgoingVideoSource.h:

Source/WTF:

• wtf/WeakHashSet.h:

1:37 AM Changeset in webkit [260240] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak SDK] Not fully hooked in BuildSlaveSupport
​https://bugs.webkit.org/show_bug.cgi?id=210548

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-04-17
Reviewed by Carlos Alberto Lopez Perez.

• Scripts/webkitdirs.pm:

(determineBaseProductDir): Flatpak SDK builds use a dedicated product directory per port.

12:52 AM Changeset in webkit [260239] by commit-queue@webkit.org

• 17 edits in trunk/Source

Move allowPlugins to FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=205876

Patch by Rob Buis <​rbuis@igalia.com> on 2020-04-17
Reviewed by Darin Adler.

Source/WebCore:

Move allowPlugins to FrameLoader to reduce
pointer dereferences and lessen dependency
on SubframeLoader. Also rename to
arePluginsEnabled since the method is asking
the Setting with the same name.

• dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::rendererIsEverNeeded):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::arePluginsEnabled):

• loader/FrameLoader.h:
• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::createJavaAppletWidget):
(WebCore::SubframeLoader::allowPlugins): Deleted.

• loader/SubframeLoader.h:
• plugins/DOMMimeType.cpp:

(WebCore::DOMMimeType::enabledPlugin const):

Source/WebKit:

Adapt to API change.

• WebProcess/Plugins/WebPluginInfoProvider.cpp:

(WebKit::WebPluginInfoProvider::pluginInfo):
(WebKit::WebPluginInfoProvider::populatePluginCache):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::objectContentType):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):
(WebKit::WebPage::canShowMIMEType const):

Source/WebKitLegacy/mac:

Adapt to API change.

• WebCoreSupport/WebPluginInfoProvider.mm:

(WebPluginInfoProvider::pluginInfo):

• WebView/WebFrame.mm:

(-[WebFrame _canProvideDocumentSource]):

Source/WebKitLegacy/win:

Adapt to API change.

• WebView.cpp:

(WebView::canShowMIMEType):

12:35 AM Changeset in webkit [260238] by commit-queue@webkit.org

• 5 edits in trunk

Fix an integer overflow in WebCrypto AES-CTR Mac implementation, which may detect a false loop
​https://bugs.webkit.org/show_bug.cgi?id=210540

Source/WebCore:

(1 << counterLength) causes an integer overflow, and the undefined behavior.
The longest valid counterLength on 64 bit machine is 63,
and the literal 1 is considered as 32-bit signed integer.
Left shifting 1 beyond or to sign-bit is undefined behavior in C++ spec.

• ​https://en.cppreference.com/w/cpp/language/integer_literal
• ​https://en.cppreference.com/w/cpp/language/operator_arithmetic#Bitwise_shift_operators

This issue is originally found in ​https://bugs.webkit.org/show_bug.cgi?id=208186#c2

Patch by Tomoki Imai <Tomoki Imai> on 2020-04-17
Reviewed by Jiewen Tan.

Test: crypto/subtle/aes-ctr-import-key-encrypt.html

• crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:

(WebCore::transformAES_CTR):

LayoutTests:

Patch by Tomoki Imai <Tomoki Imai> on 2020-04-17
Reviewed by Jiewen Tan.

Added more AES-CTR tests for AesCtrParams.length larger than 32.

• crypto/subtle/aes-ctr-import-key-encrypt-expected.txt:
• crypto/subtle/aes-ctr-import-key-encrypt.html:

Apr 16, 2020:

9:57 PM Changeset in webkit [260237] by Ross Kirsling

• 5 edits in trunk

REGRESSION(r259480): Two new failing i18n tests
​https://bugs.webkit.org/show_bug.cgi?id=210605

Reviewed by Darin Adler.

JSTests:

• stress/date-toLocaleString.js:

Tests shouldn't rely on system default time zone.

Source/JavaScriptCore:

• runtime/IntlDateTimeFormat.cpp:

(JSC::isUTCEquivalent):
(JSC::defaultTimeZone):
(JSC::canonicalizeTimeZoneName):
The default time zone needs to be canonicalized too.

• runtime/IntlObject.cpp:

(JSC::canonicalLangTag):
(JSC::resolveLocale):
Deal with some odd ""_s cases from my previous patch.
(Drive-by fix inspired by Darin's comments on this one.)

9:34 PM Changeset in webkit [260236] by Lauro Moura

• 2 edits in trunk/Tools

[GTK] A couple of API tests are flaky failing on X11.

Unreviewed test gardening.

• TestWebKitAPI/glib/TestExpectations.json:

9:08 PM Changeset in webkit [260235] by Peng Liu

• 2 edits in trunk/Source/WebKit

Cleanup the usage of ENABLE_FULLSCREEN_API
​https://bugs.webkit.org/show_bug.cgi?id=210630

Reviewed by Daniel Bates.

Replace "#if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API" with
"#if ENABLE(FULLSCREEN_API)".

No new tests, no functional change

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetFullScreenClient):
(WKBundlePageWillEnterFullScreen):
(WKBundlePageDidEnterFullScreen):
(WKBundlePageWillExitFullScreen):
(WKBundlePageDidExitFullScreen):

6:55 PM Changeset in webkit [260234] by Simon Fraser

• 4 edits
  2 adds in trunk

Scrolling-tree hit-testing is off by top content inset
​https://bugs.webkit.org/show_bug.cgi?id=210629
<rdar://problem/61848883>

Reviewed by Tim Horton.

Source/WebCore:

r259936 added a point conversion from the superlayer of the root content layer,
to fix RTL, but this also pulled in top content inset, which we don't want.

Instead, do the RTL fix by factoring in scroll origin.

Test: fast/scrolling/mac/async-scroll-overflow-top-inset.html

• page/scrolling/ScrollingTreeScrollingNode.h:
• page/scrolling/mac/ScrollingTreeMac.mm:

(ScrollingTreeMac::scrollingNodeForPoint):

LayoutTests:

Test for scroller hit-testing with top content inset.

• fast/scrolling/mac/async-scroll-overflow-top-inset-expected.txt: Added.
• fast/scrolling/mac/async-scroll-overflow-top-inset.html: Added.

6:13 PM Changeset in webkit [260233] by Kate Cheney

• 2 edits in trunk/Source/WebKit

Distinguish between an empty WKAppBoundDomains array and a missing entry
​https://bugs.webkit.org/show_bug.cgi?id=210628
<rdar://problem/61909669>

Reviewed by Brent Fulgham.

Currently we treat a missing WKAppBoundDomains key the same as an empty
key, which is incorrect. Having the key present, even with no entries,
should opt an app into app-bound domain behavior.

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::initializeAppBoundDomains):
(WebKit::WebsiteDataStore::beginAppBoundDomainCheck):

6:09 PM Changeset in webkit [260232] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

Add a new 'limitNavigationsToAppBoundDomains' property to WKWebViewConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=210620
<rdar://problem/61903225>

Reviewed by Andy Estes.

Follow-up fix. The property exposed by WKWebViewConfiguration should not
use a local BOOL; it simply exposes the APIPageConfiguration value.

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration limitsNavigationToAppBoundDomains]):
(-[WKWebViewConfiguration setLimitsNavigationToAppBoundDomains:]):
(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]):

5:53 PM Changeset in webkit [260231] by Brent Fulgham

• 7 edits in trunk/Source/WebKit

Switch NetworkProcess and NetworkProcessProxy messages to use CallbackID class
​https://bugs.webkit.org/show_bug.cgi?id=210566
<rdar://problem/61791784>

Reviewed by David Kilzer.

Instead of using the raw uint64_t type to represent callbacks, use the purpose
built WebKit::CallbackID type.

Tested by existing cases.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcessProxy::didFetchWebsiteData):
(WebKit::NetworkProcessProxy::didDeleteWebsiteData):
(WebKit::NetworkProcessProxy::didDeleteWebsiteDataForOrigins):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:

5:21 PM Changeset in webkit [260230] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit

Try to fix the macCatalyst build

• UIProcess/ios/WKActionSheetAssistant.h:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(uiImageForImage):
(createTargetedPreview):
(createFallbackTargetedPreview):
(-[WKContentView _createTargetedContextMenuHintPreviewIfPossible]):

5:17 PM Changeset in webkit [260229] by ddkilzer@apple.com

• 3 edits in trunk/Source/WebKit

Re-land: [IPC Hardening] MachMessage::create() should use checked arithmetic
<​https://webkit.org/b/210572>
<rdar://problem/61729947>

Reviewed by Chris Dumez.

• Platform/IPC/cocoa/ConnectionCocoa.mm:

(IPC::Connection::sendOutgoingMessage):

• Add nullptr check since MachMessage::create() can return an empty std::unique_ptr<> now.
• Platform/IPC/cocoa/MachMessage.cpp:

(IPC::MachMessage::create):

• Use CheckedSize to compute the buffer size.

5:05 PM Changeset in webkit [260228] by Brent Fulgham

• 7 edits in trunk/Source/WebKit

Add a new 'limitNavigationsToAppBoundDomains' property to WKWebViewConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=210620
<rdar://problem/61903225>

Reviewed by Andy Estes.

Provide a way for Developers to opt-in to AppBound domains through a new WKWebViewConfiguration
property.

This patch only creates the property and exposes the flag to the APIPageConfiguration and
WebPageProxy. A separate patch will take action based on its value.

• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy const):

• UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::limitsNavigationToAppBoundDomains const):
(API::PageConfiguration::setLimitsNavigationToAppBoundDomains):

• UIProcess/API/Cocoa/WKWebViewConfiguration.h:
• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration limitsNavigationToAppBoundDomains]):
(-[WKWebViewConfiguration setLimitsNavigationToAppBoundDomains:]):
(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]): Keep the new property in
sync with this internal flag.

• UIProcess/WebPageProxy.cpp:

(WebKit::m_limitsNavigationToAppBoundDomains):

• UIProcess/WebPageProxy.h:

4:50 PM Changeset in webkit [260227] by svillar@igalia.com

• 10 edits in trunk/Source

Unreviewed build fix for non unified builds.

Source/JavaScriptCore:

• dfg/DFGOperations.cpp: Added missing includes.

Source/WebCore:

• html/OffscreenCanvas.cpp: Added missing include.
• html/canvas/CanvasRenderingContext2DBase.cpp: Ditto.
• layout/tableformatting/TableFormattingContextGeometry.cpp: Ditto.
• workers/WorkerAnimationController.cpp:

(WebCore::WorkerAnimationController::requestAnimationFrame): Added namespace.

• workers/WorkerAnimationController.h: Added missing include.

Source/WebKit:

• NetworkProcess/webrtc/LibWebRTCSocketClient.cpp: Added missing include.

4:30 PM Changeset in webkit [260226] by ysuzuki@apple.com

• 2 edits in trunk/JSTests

Unreviewed, reduce # of iteration since this test is timed out in slow devices
​https://bugs.webkit.org/show_bug.cgi?id=210023

• stress/map-iteration-oas.js:

4:23 PM Changeset in webkit [260225] by dbates@webkit.org

• 7 edits in trunk

Remove unused -_focusTextInputContext
​https://bugs.webkit.org/show_bug.cgi?id=210619

Reviewed by Darin Adler.

Source/WebKit:

While this function was in the "SPI" header, there is no software at Apple that was using
this funciton and I will assume no non-Apple software was using it either.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _focusTextInputContext:completionHandler:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:

Tools:

Remove test now that the SPI was removed.

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:

(-[TestWKWebView synchronouslyFocusTextInputContext:]): Deleted.

4:05 PM Changeset in webkit [260224] by Simon Fraser

• 6 edits
  2 adds in trunk

A slow-starting swipe always latches on the root node
​https://bugs.webkit.org/show_bug.cgi?id=210618

Reviewed by Tim Horton.

Source/WebCore:

If the first event in a wheel event gesture had zero delta, scrolling thread logic would
always latch on the root node and the rest of the gesture would scroll the document.

Fix by not latching for events with zero delta.

Test: scrollingcoordinator/mac/latching/zero-delta-began-should-not-latch.html

• page/scrolling/ScrollingTreeLatchingController.cpp:

(WebCore::ScrollingTreeLatchingController::nodeDidHandleEvent):

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::canScrollWithWheelEvent const):
(WebCore::ScrollingTreeScrollingNode::eventCanScrollContents const):
(WebCore::ScrollingTreeScrollingNode::scrollLimitReached const): Deleted.

• page/scrolling/ScrollingTreeScrollingNode.h:
• platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::shouldConsiderLatching const): FIXME comment. Ideally this would
check delta() that that's too scarey at the moment.

LayoutTests:

• scrollingcoordinator/mac/latching/zero-delta-began-should-not-latch-expected.txt: Added.
• scrollingcoordinator/mac/latching/zero-delta-began-should-not-latch.html: Added.

3:35 PM Changeset in webkit [260223] by mark.lam@apple.com

• 9 edits in trunk/Source/JavaScriptCore

[Re-landing] Use more PAC diversity for JIT probe code.
​https://bugs.webkit.org/show_bug.cgi?id=210252
<rdar://problem/54490367>

Reviewed by Keith Miller.

Introducing new PtrTags:

JITProbePtrTag - for the client probe function.
JITProbeTrampolinePtrTag - for calling the ctiMasmProbeTrampoline.
JITProbeExecutorPtrTag - for calling the probe executor.

Currently, this is only the Probe::executeProbe().

JITProbeStackInitializationFunctionPtrTag - for calling the optional stack

initialization function that the client probe function may set.

We'll now use these in the JIT probe mechanism instead of adopting the default
CFunctionPtrTag.

Fixed an assert in MacroAssemblerARM64.cpp which does not apply to non ARM64E
builds.

• assembler/MacroAssembler.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerPrinter.h:

(JSC::MacroAssembler::print):

• assembler/ProbeContext.h:
• runtime/JSCPtrTag.h:
• tools/JSDollarVM.cpp:

(JSC::callWithStackSizeProbeFunction):

• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::emitLoopTierUpCheck):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::emitLoopTierUpCheck):

2:40 PM Changeset in webkit [260222] by mark.lam@apple.com

• 9 edits in trunk/Source/JavaScriptCore

Rolling out r259897: Causing crashes on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=210252

Not reviewed.

• assembler/MacroAssembler.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerPrinter.h:

(JSC::MacroAssembler::print):

• assembler/ProbeContext.h:
• runtime/JSCPtrTag.h:
• tools/JSDollarVM.cpp:

(JSC::callWithStackSizeProbeFunction):

• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::emitLoopTierUpCheck):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::emitLoopTierUpCheck):

1:54 PM Changeset in webkit [260221] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[macOS] Switch unused IOKit classes from allow-with-report to deny-with-report
​https://bugs.webkit.org/show_bug.cgi?id=210136
<rdar://problem/61403216>

Reviewed by Per Arne Vollan.

After tracking telemetry for several weeks, we can now safely switch the default state
of a number of IOKit classes from 'allow with telemetry' to 'deny with telemetry'.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

1:42 PM Changeset in webkit [260220] by ysuzuki@apple.com

• 1 edit
  8 adds in trunk/Tools

Add slack-aware WKR implementation
​https://bugs.webkit.org/show_bug.cgi?id=210425

Reviewed by Alexey Proskuryakov.

This patch adds new WKR implementation, which is posting changes to #changes in WebKit slack.
Currently, we are polling git.webkit.org's feed once a minute. The more efficient way to implement
this bot is introducing post-commit hook, but for now, this polling strategy just works.

• WKR/.gitignore: Added.
• WKR/ReadMe.md: Added.
• WKR/WKR.mjs: Added.
• WKR/data/.gitignore: Added.
• WKR/package-lock.json: Added.
• WKR/package.json: Added.

1:41 PM Changeset in webkit [260219] by Russell Epstein

• 2 edits in branches/safari-610.1.10-branch/Source/WebKit

Cherry-pick r260218. rdar://problem/61897737

Fix the iOS build when building without EDITABLE_REGION after r260192
(​https://bugs.webkit.org/show_bug.cgi?id=210398)

Have -_mayContainEditableElementsInRect compile-time conditionally call WebKit::mayContainEditableElementsInRect().
If ENABLE(EDITABLE_REGION) is not enabled then return NO.

• UIProcess/API/ios/WKWebViewTestingIOS.mm: (-[WKWebView _mayContainEditableElementsInRect:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:38 PM Changeset in webkit [260218] by dbates@webkit.org

• 2 edits in trunk/Source/WebKit

Fix the iOS build when building without EDITABLE_REGION after r260192
(​https://bugs.webkit.org/show_bug.cgi?id=210398)

Have -_mayContainEditableElementsInRect compile-time conditionally call WebKit::mayContainEditableElementsInRect().
If ENABLE(EDITABLE_REGION) is not enabled then return NO.

• UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _mayContainEditableElementsInRect:]):

1:27 PM Changeset in webkit [260217] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build-fix after r260182; guard call to fullscreenManager() for ports which do not
ENABLE(FULLSCREEN_API).

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::updateMediaUsageIfChanged):

1:13 PM Changeset in webkit [260216] by ddkilzer@apple.com

• 3 edits in trunk/Source/WebKit

Rollout: [IPC Hardening] MachMessage::create() should use checked arithmetic
<​https://webkit.org/b/210572>
<rdar://problem/61729947>

Unreviewed rollout of r260160.

Appears to have caused 8 API test failures on iOS.

• Platform/IPC/cocoa/ConnectionCocoa.mm:

(IPC::Connection::sendOutgoingMessage):

• Platform/IPC/cocoa/MachMessage.cpp:

(IPC::MachMessage::create):

1:02 PM Changeset in webkit [260215] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

REGRESSION(r260081) Broke iOS PLT due to InjectedBundle initialization (edit)
​https://bugs.webkit.org/show_bug.cgi?id=210582
<rdar://problem/61838584>

Reviewed by Darin Adler.

The changes in r260081 began enforcing NSSecureCoding best practices, triggering
a bug in InjectedBundleMac.mm, which is used by iOS as well.

This patch does the following:

1. Delays parameter decoding until we use the appropriate InjectedBundle mechanism for expressing the valid classes to use in the Unarchiver.
2. Removes a temporary workaround needed to get PLT running on iOS again.

This patch also moves the check of the CFBundleGetFunctionPointerForName slightly earlier
so we can use a single function pointer check, and only invoke the parameter decoding
if we are using the C API.

If not, we delay parameter decoding until we have constructed the WKWebProcessPlugIn
object so we can consume it's 'additionalClassesForParameterCoder' before calling
its initialization method.

• WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::decodeBundleParameters): Remove temporary workaround
needed to get PLT working again. Instead of using a debug assert, return as
a decoding failure if the resulting object is not an NSDictionary.
(WebKit::InjectedBundle::initialize): Delay decoding the bundle parameters on
iOS until the Plugin's additionalClassesForParameterCoder method can be called.

12:48 PM Changeset in webkit [260214] by dbates@webkit.org

• 13 edits in trunk

[iOS] Add a way to focus a text input and place a caret
​https://bugs.webkit.org/show_bug.cgi?id=210611
<rdar://problem/61893062>

Reviewed by Darin Adler.

Source/WebKit:

Add some IPI that will be used by code in WebKitAdditions to focus a text input context
and place the caret in it. This will replace the existing -focusTextInput SPI, which I
will remove in a subsequent commit.

• UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
• UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _requestTextInputContextsInRect:completionHandler:]): Fix up code style
of signature while I am here.
(-[WKWebView _focusTextInputContext:placeCaretAt:completionHandler:]): Added.

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _isTextInputContextFocused:]): Added.
(-[WKContentView _focusTextInputContext:placeCaretAt:completionHandler:]): Added.
(-[WKContentView _requestTextInputContextsInRect:completionHandler:]): Fix up code style
of signature while I am here.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::focusTextInputContextAndPlaceCaret):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::focusTextInputContext): Use auto now that elementForContext() returns a RefPtr.
(WebKit::WebPage::elementForContext const): Have it return a RefPtr instead of a raw
pointer so callers don't have to remember to take out a ref of otherwise be mindful
of the element's lifetime.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::removeTextPlaceholder): Use auto now that elementForContext() returns a RefPtr.
(WebKit::WebPage::requestDocumentEditingContext): Ditto.
(WebKit::WebPage::focusTextInputContextAndPlaceCaret): Added.

Tools:

Add some tests.

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:

(-[TestWKWebView synchronouslyFocusTextInputContext:placeCaretAt:]): Added.
(webViewLoadHTMLStringAndWaitForAllFramesToPaint): Use the bundle's TestWebKitAPI.resources directory
as the base URL so that we have a valid file URL. Some of the tests will then
call -_setAllowUniversalAccessFromFileURLs to allow the main frame access to
the unique-origin child frame contents.
(TEST):

12:44 PM Changeset in webkit [260213] by Russell Epstein

• 3 edits in branches/safari-610.1.10-branch/Source/WebKit

Cherry-pick r260120. rdar://problem/61899305

Unreviewed, reverting r259891.

Causes significant iOS MotionMark regression

Reverted changeset:

"Switch unused IOKit classes from allow-with-report to deny-
with-report"
​https://bugs.webkit.org/show_bug.cgi?id=210136
​https://trac.webkit.org/changeset/259891

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:31 PM Changeset in webkit [260212] by Russell Epstein

• 4 edits in branches/safari-610.1.10-branch

Cherry-pick r260193. rdar://problem/61897737

REGRESSION (r259762): Should always hit test for editable elements if the WKWebView is fully editable
​https://bugs.webkit.org/show_bug.cgi?id=210558
<rdar://problem/61798347>

Reviewed by Wenson Hsieh.

Source/WebKit:

If the entire WKWebView is marked editable (via SPI -[WKWebView _setEditable]) then
always ask the web process to hit test the page because every element is considered
editable.

• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _requestTextInputContextsInRect:completionHandler:]):

Tools:

Add a test.

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:31 PM Changeset in webkit [260211] by Russell Epstein

• 17 edits in branches/safari-610.1.10-branch

Cherry-pick r260192. rdar://problem/61897737

Move -_requestTextInputContextsInRect to WKContentView to simplify implementation
​https://bugs.webkit.org/show_bug.cgi?id=210398
<rdar://problem/61656931>

Reviewed by Darin Adler.

Source/WebKit:

-_requestTextInputContextsInRect is not needed on Mac, but supporting it complicates
its implementation: it has to deal with coordinate space differences due to differences
in what is the root view on Mac and iOS + it has to know about iOS's custom content views.
While this function was in the "SPI" header, there is no software at Apple that was using
these outside of WebKit, and I will assume no non-Apple software was using them either.
Moving this function to WKContentView lets me simplify the implementation.

• Platform/spi/ios/UIKitSPI.h: Add more forward declarations.
• UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _convertRectFromRootViewCoordinates:]): Deleted. (-[WKWebView _convertRectToRootViewCoordinates:]): Deleted. (-[WKWebView _mayContainEditableElementsInRect:]): Deleted; moved to WKWebViewTestingIOS.mm. (-[WKWebView _requestTextInputContextsInRect:completionHandler:]): Deleted; moved to WKContentViewInteraction.mm.
• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
• UIProcess/API/ios/WKWebViewTestingIOS.mm: (-[WKWebView _requestTextInputContextsInRect:completionHandler:]): Added. Turns around and calls the function of the same name on the WKContentView. It takes care to convert the specified rect from WKWebView coordinates to WKContentView coordinates and fixes up the bounding rects for the returned contexts to be in WKWebView coordinates. This keeps existings tests passing as mekes using this function intuitive since callers specify and get rects in WKWebView coordinates. (-[WKWebView _requestDocumentContext:completionHandler:]): Added. (-[WKWebView _adjustSelectionWithDelta:completionHandler:]): Added. (-[WKWebView _mayContainEditableElementsInRect:]): Moved from WKWebView.mm.
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _requestTextInputContextsInRect:completionHandler:]): Moved from WKWebView.mm and simplified.

Source/WTF:

Add a convenience function to create an NSArray from a WTF::Vector with a transform function.
The tranform function can either return a RetainPtr or an id.

• wtf/cocoa/VectorCocoa.h: (WTF::createNSArray): Added.

Tools:

Update test now that -_requestTextInputContextsInRect has moved from WKWebView to WKContentView.
I expose new testing-only WKWebView SPI to access it on the content view.

• TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: (-[TestWKWebView synchronouslyRequestDocumentContext:]): Added; due to category name change. (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]): Added; due to category name change.
• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: (-[WKWebView synchronouslyRequestTextInputContextsInRect:]): Deleted; due to category name change. (-[WKWebView synchronouslyFocusTextInputContext:]): Deleted; due to category name change.
• WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptControllerIOS::mayContainEditableElementsInRect): Convert from content coordinates to WKWebView coordinates now that -_mayContainEditableElementsInRect expects it.

LayoutTests:

Update test and expected results now that UIScriptController.mayContainEditableElementsInRect()
expects the passed rect to be in content coordinates.

I replaced one sub-test of a rect pre-scroll with another that tests the location
of a rect that will have editable elements after scroll. The purpose of that sub-test
hasn't changed, but it now makes the sub-tests' rects symmetric for before and after
scroll. I also added debug() statements to demarcate the before scroll and after scroll
sub-tests in the results to make it easier to understand what this test file is testing.

• editing/editable-region/hit-test-fixed-expected.txt:
• editing/editable-region/hit-test-fixed.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:31 PM Changeset in webkit [260210] by Russell Epstein

• 4 edits in branches/safari-610.1.10-branch/Source/WebKit

Cherry-pick r260186. rdar://problem/61897760

REGRESSION (r259898): WebKit-based Books views are all blank
​https://bugs.webkit.org/show_bug.cgi?id=210590
<rdar://problem/61791109>

Reviewed by Chris Dumez.

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::enterAcceleratedCompositingWithRootLayer): (WebKit::WebViewImpl::setAcceleratedCompositingRootLayer): (WebKit::WebViewImpl::setAcceleratedCompositingRootLayerAfterFlush): Deleted.
• UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::enterAcceleratedCompositingMode): (WebKit::PageClientImpl::didFirstLayerFlush): The changes to setAcceleratedCompositingRootLayer in r259898 proved to be wrong in a second way (the first being fixed in r260104): when setAcceleratedCompositingRootLayer is called from updateAcceleratedCompositingMode, because the layer hosting mode changed (Books appears to use app-hosted layers), it incorrectly identified the root layer change as a process swap, resulting in the correct layer never being unhidden.

This is enough mistakes that I'm going to try a different approach:
put setAcceleratedCompositingRootLayer back to the way it was before, where
it immediately updates the layer without any smarts, remove
setAcceleratedCompositingRootLayerAfterFlush, because it's no longer necessary,
and add enterAcceleratedCompositingWithRootLayer, which is specifically only
called in the case where DrawingArea will for-sure send us a follow-up
(didFirstLayerFlush) that will unhide the root layer.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:27 PM Changeset in webkit [260209] by Claudio Saavedra

• 3 edits in trunk/Source/WebCore

[GTK] Deprecation-guards fixes
​https://bugs.webkit.org/show_bug.cgi?id=210600

Reviewed by Adrian Perez de Castro.

No new tests needed.

• platform/gtk/RenderThemeGadget.cpp:

(WebCore::RenderThemeGadget::backgroundColor const): Add missing
deprecation guards for deprecated GtkStyleContext API.

• platform/gtk/ThemeGtk.cpp:

(WebCore::ThemeGtk::ensurePlatformColors const): Switch to WK
deprecation guards from glib ones.

11:59 AM Changeset in webkit [260208] by Alan Coon

• 8 edits in branches/safari-609-branch/Source

Versioning.

11:42 AM Changeset in webkit [260207] by Jack Lee

• 4 edits
  2 adds in trunk

ASSERTION FAILED: candidate.isCandidate() in WebCore::canonicalizeCandidate
​https://bugs.webkit.org/show_bug.cgi?id=130844
<rdar://59535009>

Reviewed by Geoffrey Garen.

Source/WebCore:

Call Position::isCandidate() in PositionIterator::isCandidate so behavior of
candidate search become identical in both classes.

Test: editing/inserting/insert-in-br.html

• dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate const):

LayoutTests:

• editing/inserting/insert-in-br-expected.txt: Added.
• editing/inserting/insert-in-br.html: Added.

Added a regression test for the crash.

• editing/inserting/insert-list-in-table-cell-07-expected.txt:

Update node tree in expected text file due to behavior change in function
PositionIterator::isCandidate. The visual result remains the same.

11:38 AM Changeset in webkit [260206] by Ryan Haddad

• 4 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r259621. rdar://problem/59461792

[Cocoa] REGRESSION(r254389): fast/text/international/system-language/declarative-language.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=208023
<rdar://problem/59461792>

Reviewed by Simon Fraser.

minimizedLanguagesFromLanguages() is supposed to minimize the language list;
that's its whole raison d'être

• fast/text/international/system-language/declarative-language-expected.txt:
• fast/text/international/system-language/declarative-language.html:
• platform/mac/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@259621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:38 AM Changeset in webkit [260205] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Remove outdated comment from FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=210607

Patch by Rob Buis <​rbuis@igalia.com> on 2020-04-16
Reviewed by Darin Adler.

Remove comment from FrameLoader that is not valid/important anymore because
addExtraFieldsToRequest does not set the Origin header since r259036.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadDifferentDocumentItem):

11:38 AM Changeset in webkit [260204] by Ryan Haddad

• 2 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r257821. rdar://problem/61408640

REGRESSION(iOS): editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html is always timing out
​https://bugs.webkit.org/show_bug.cgi?id=208556

Reviewed by Wenson Hsieh.

Wait for the dobule tap delay between the initial tap and the second tap on the editable region
so that the second tap would result in a selection change instead of both taps to be recognized
as a single dobule tap.

• editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:37 AM Changeset in webkit [260203] by Chris Fleizach

• 3 edits
  2 adds in trunk

AX: Need method for setting selected range from NSRange
​https://bugs.webkit.org/show_bug.cgi?id=210593

Reviewed by Darin Adler.

Source/WebCore:

Allow setSelection to work outside of text controls.

Test: accessibility/ios-simulator/non-textcontrol-set-selection.html

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilitySetSelectedTextRange:]):

LayoutTests:

• accessibility/ios-simulator/non-textcontrol-set-selection-expected.txt: Added.
• accessibility/ios-simulator/non-textcontrol-set-selection.html: Added.

11:30 AM Changeset in webkit [260202] by dbates@webkit.org

• 2 edits in trunk/Source/WTF

Clean up VectorCocoa createNSArray overloads and add documentation for createNSArray taking a map function
​https://bugs.webkit.org/show_bug.cgi?id=210610

Reviewed by Darin Adler.

Remove unnecessary local variable. Rename "map" type in createNSArray function for clarity
and add documentation for createNSArray function that takes a map function.

I was tempted, but decided not to write the createNSArray function that does not take a
map function in terms of the one that did. With the "right" optimization settings the
compiler should emit the same code, but I didn't verify this. So, I didn't do it.

While I am here, update makeVector() to call shrinkToFit() to reduce the memory footprint
of the returned vector should it end of having less entries, due to filtering, than its
initial capacity.

• wtf/cocoa/VectorCocoa.h:

(WTF::createNSArray): See above description.
(WTF::makeVector): Shrink to fit before returning the vector. See above for more details.

11:11 AM Changeset in webkit [260201] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

[macOS] Update ScreenTime as playback state changes
​https://bugs.webkit.org/show_bug.cgi?id=210518
<rdar://problem/61181092>

Reviewed by Eric Carlson.

Follow up to r260182; Pass a WeakPtr into our task queue in sessionWillEndPlayback rather than a bare pointer.

• platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::sessionWillEndPlayback):

11:06 AM Changeset in webkit [260200] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Use safeRoundPage() instead of round_page() in SharedMemory
​https://bugs.webkit.org/show_bug.cgi?id=210608
<rdar://problem/60600443>

Reviewed by Geoffrey Garen.

Use new safeRoundPage() instead of round_page() in SharedMemory, to deal safely with overflows.

• Platform/cocoa/SharedMemoryCocoa.cpp:

(WebKit::SharedMemory::allocate):
(WebKit::makeMemoryEntry):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):

11:04 AM Changeset in webkit [260199] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Captured ThreadedScrollingTree should check its m_scrollingCoordinator before calling its methods
​https://bugs.webkit.org/show_bug.cgi?id=210570

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-04-16
Reviewed by Simon Fraser.

m_scrollingCoordinator may be nullified before asynchronously calling its
method scheduleUpdateScrollPositionAfterAsyncScroll(). Check if it is
not null before calling this method.

• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):

10:44 AM Changeset in webkit [260198] by Alan Coon

• 2 edits in branches/safari-609-branch/Source/WTF

Cherry-pick r259980. rdar://problem/61888315

Follow-up: WTF::Persistence::Coder and WTF::Persistence::Decoder should use WARN_UNUSED_RETURN
<​https://webkit.org/b/210238>
<rdar://problem/61491575>

Changes based on feedback from Alex Christensen and Darin Adler:

• Remove WARN_UNUSED_RETURN from methods returning Optional<>.
• Place WARN_UNUSED_RETURN consistently before the return type.

• wtf/persistence/PersistentDecoder.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@259980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:44 AM Changeset in webkit [260197] by Alan Coon

• 6 edits in branches/safari-609-branch/Source

Cherry-pick r259814. rdar://problem/61888315

WTF::Persistence::Coder and WTF::Persistence::Decoder should use WARN_UNUSED_RETURN
<​https://webkit.org/b/210238>
<rdar://problem/61491575>

Reviewed by Darin Adler.

Source/WebKit:

• NetworkProcess/cache/NetworkCacheEntry.cpp: (WebKit::NetworkCache::Entry::decodeStorageRecord):
• Add missing return value check for decode.decode().

Source/WTF:

• wtf/persistence/PersistentCoders.cpp: (WTF::Persistence::decodeStringText):
• Add WARN_UNUSED_RETURN.

• wtf/persistence/PersistentCoders.h: (WTF::Persistence::Coder<Optional<T>>::decode): (WTF::Persistence::Coder<Seconds>::decode): (WTF::Persistence::Coder<WallTime>::decode):
• Add WARN_UNUSED_RETURN.
• Add missing return value check for decode.decodeFixedLengthData().

• wtf/persistence/PersistentDecoder.h: (WTF::Persistence::Decoder::decode): (WTF::Persistence::Decoder::decodeEnum): (WTF::Persistence::Decoder::bufferIsLargeEnoughToContain const):
• Add WARN_UNUSED_RETURN.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@259814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:39 AM Changeset in webkit [260196] by Alan Bujtas

• 3 edits
  2 adds in trunk

Crash in IndefiniteSizeStrategy::recomputeUsedFlexFractionIfNeeded when min-size can not be resolved
​https://bugs.webkit.org/show_bug.cgi?id=210584
<rdar://problem/56685237>

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

Use the initial value of 0 when the min-height can't be resolved.

Test: fast/css-grid-layout/crash-when-min-height-cant-be-resolved.html

• rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::IndefiniteSizeStrategy::recomputeUsedFlexFractionIfNeeded const):

LayoutTests:

• fast/css-grid-layout/crash-when-min-height-cant-be-resolved-expected.txt: Added.
• fast/css-grid-layout/crash-when-min-height-cant-be-resolved.html: Added.

10:30 AM Changeset in webkit [260195] by Adrian Perez de Castro

• 15 edits in trunk/Source

Non-unified build fixes mid April 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=210599

Unreviewed build fix.

Source/WebCore:

No new tests needed.

• bindings/js/JSNavigatorCustom.cpp: Add missing JavaScriptCore/JSCJSValue.h header.

(WebCore::JSNavigator::getUserMedia): Prefix with the JSC:: namespace where needed.

• dom/ShadowRoot.cpp: Add missing WebAnimation.h header.
• dom/SimpleRange.cpp: Add missing NodeTraversal.h header.
• editing/RemoveNodePreservingChildrenCommand.cpp: Add missing Editing.h header.
• page/MemoryRelease.cpp: Add missing JavaScriptCore/VM.h header.
• page/PageConfiguration.cpp: Add missing UserContentURLPattern.h header.
• page/scrolling/ScrollingTree.h: Add missing EventTrackingRegions.h header.
• page/scrolling/ScrollingTreeLatchingController.cpp: Add missing Logging.h header.
• page/scrolling/ScrollingTreeLatchingController.h: Add missing ScrollTypes.h header,

and forward declaration for WebCore::PlatformWheelEvent.

• workers/service/server/SWServerJobQueue.cpp: Add missing Logging.h header.

Source/WebKit:

• UIProcess/DeviceIdHashSaltStorage.cpp: Add missing Logging.h header.
• UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformSetForcedAppearance): Add missing WebCore:: namespace
prefix.

• UIProcess/linux/MemoryPressureMonitor.h: Add missing wtf/text/CString.h header.

9:59 AM Changeset in webkit [260194] by Alan Coon

• 1 edit in branches/safari-609-branch/Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm

Unreviewed build fix. rdar://problem/61853298

Attempted resolution of: use of undeclared identifier 'isInBounds'; did you mean 'WTF::isInBounds'?

9:52 AM Changeset in webkit [260193] by dbates@webkit.org

• 4 edits in trunk

REGRESSION (r259762): Should always hit test for editable elements if the WKWebView is fully editable
​https://bugs.webkit.org/show_bug.cgi?id=210558
<rdar://problem/61798347>

Reviewed by Wenson Hsieh.

Source/WebKit:

If the entire WKWebView is marked editable (via SPI -[WKWebView _setEditable]) then
always ask the web process to hit test the page because every element is considered
editable.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _requestTextInputContextsInRect:completionHandler:]):

Tools:

Add a test.

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:

(TEST):

9:47 AM Changeset in webkit [260192] by dbates@webkit.org

• 17 edits in trunk

Move -_requestTextInputContextsInRect to WKContentView to simplify implementation
​https://bugs.webkit.org/show_bug.cgi?id=210398
<rdar://problem/61656931>

Reviewed by Darin Adler.

Source/WebKit:

-_requestTextInputContextsInRect is not needed on Mac, but supporting it complicates
its implementation: it has to deal with coordinate space differences due to differences
in what is the root view on Mac and iOS + it has to know about iOS's custom content views.
While this function was in the "SPI" header, there is no software at Apple that was using
these outside of WebKit, and I will assume no non-Apple software was using them either.
Moving this function to WKContentView lets me simplify the implementation.

• Platform/spi/ios/UIKitSPI.h: Add more forward declarations.
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _convertRectFromRootViewCoordinates:]): Deleted.
(-[WKWebView _convertRectToRootViewCoordinates:]): Deleted.
(-[WKWebView _mayContainEditableElementsInRect:]): Deleted; moved to WKWebViewTestingIOS.mm.
(-[WKWebView _requestTextInputContextsInRect:completionHandler:]): Deleted; moved to WKContentViewInteraction.mm.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
• UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _requestTextInputContextsInRect:completionHandler:]): Added. Turns around and
calls the function of the same name on the WKContentView. It takes care to convert the specified
rect from WKWebView coordinates to WKContentView coordinates and fixes up the bounding rects
for the returned contexts to be in WKWebView coordinates. This keeps existings tests passing
as mekes using this function intuitive since callers specify and get rects in WKWebView coordinates.
(-[WKWebView _requestDocumentContext:completionHandler:]): Added.
(-[WKWebView _adjustSelectionWithDelta:completionHandler:]): Added.
(-[WKWebView _mayContainEditableElementsInRect:]): Moved from WKWebView.mm.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _requestTextInputContextsInRect:completionHandler:]): Moved from WKWebView.mm and simplified.

Source/WTF:

Add a convenience function to create an NSArray from a WTF::Vector with a transform function.
The tranform function can either return a RetainPtr or an id.

• wtf/cocoa/VectorCocoa.h:

(WTF::createNSArray): Added.

Tools:

Update test now that -_requestTextInputContextsInRect has moved from WKWebView to WKContentView.
I expose new testing-only WKWebView SPI to access it on the content view.

• TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:

(-[TestWKWebView synchronouslyRequestDocumentContext:]): Added; due to category name change.
(-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]): Added; due to category name change.

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:

(-[WKWebView synchronouslyRequestTextInputContextsInRect:]): Deleted; due to category name change.
(-[WKWebView synchronouslyFocusTextInputContext:]): Deleted; due to category name change.

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::mayContainEditableElementsInRect): Convert from content coordinates
to WKWebView coordinates now that -_mayContainEditableElementsInRect expects it.

LayoutTests:

Update test and expected results now that UIScriptController.mayContainEditableElementsInRect()
expects the passed rect to be in content coordinates.

I replaced one sub-test of a rect pre-scroll with another that tests the location
of a rect that will have editable elements after scroll. The purpose of that sub-test
hasn't changed, but it now makes the sub-tests' rects symmetric for before and after
scroll. I also added debug() statements to demarcate the before scroll and after scroll
sub-tests in the results to make it easier to understand what this test file is testing.

• editing/editable-region/hit-test-fixed-expected.txt:
• editing/editable-region/hit-test-fixed.html:

9:25 AM Changeset in webkit [260191] by ddkilzer@apple.com

• 13 edits
  1 copy in trunk/Source/WebKit

[IPC Hardening] Use ObjectIdentifier<> for LegacyCustomProtocol
<​https://webkit.org/b/210580>
<rdar://problem/61791686>

Reviewed by Chris Dumez.

Replace uses of uint64_t with LegacyCustomProtocolID.

• NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:

(WebKit::LegacyCustomProtocolManager::didFailWithError):
(WebKit::LegacyCustomProtocolManager::didLoadData):
(WebKit::LegacyCustomProtocolManager::didReceiveResponse):
(WebKit::LegacyCustomProtocolManager::didFinishLoading):
(WebKit::LegacyCustomProtocolManager::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManager::protocolForID):

• NetworkProcess/CustomProtocols/LegacyCustomProtocolID.h: Add.
• NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp:

(WebKit::LegacyCustomProtocolManager::addCustomProtocol):
(WebKit::LegacyCustomProtocolManager::removeCustomProtocol):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):
(WebKit::generateCustomProtocolID): Delete.

• Replace with LegacyCustomProtocolID::generate().
• NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h:
• NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in:
• Scripts/webkit/messages.py:
• UIProcess/API/APICustomProtocolManagerClient.h:

(API::CustomProtocolManagerClient::startLoading):
(API::CustomProtocolManagerClient::stopLoading):

• UIProcess/Cocoa/LegacyCustomProtocolManagerClient.h:
• UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm:

(-[WKCustomProtocolLoader initWithLegacyCustomProtocolManagerProxy:customProtocolID:request:]):
(WebKit::LegacyCustomProtocolManagerClient::startLoading):
(WebKit::LegacyCustomProtocolManagerClient::stopLoading):

• UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp:

(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):

• UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h:
• Remove unused typedef and instance variable.
• UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• Add LegacyCustomProtocolID.h to project.

8:55 AM Changeset in webkit [260190] by Simon Fraser

• 16 edits
  6 adds in trunk

[Async overflow scrolling] Slow-repaint overflow scroll have force their enclosing scrollers to be slow too
​https://bugs.webkit.org/show_bug.cgi?id=210591

Reviewed by Antti Koivisto.

Source/WebCore:

If an overflow:scroll has background-attachment:fixed in the contents, then both it and all its containing-block
scrolling ancestors have to be slow-scrolling too, because scrolling any of them affects the local geometry
of the fixed backgrounds which paint on scroll.

Implement this by having the scrolling tree do a post-commit pass over the nodes with sync scrolling reasons
(which we collect during the commit phase). For each slow-scrolling node, walk its ancestor chain (via
proxy nodes when necessary) and mark the scrolling node ancestors with the "DescendantScrollersHaveSynchronousScrolling"
reason.

For testing, expose internals.scrollingTreeAsText(), which needs a bit of synchronization via
waitForScrollingTreeCommit() since the commit happens on the scrolling thread.

Tests: scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-non-cb-overflow.html

scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow.html
scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow2.html

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::scrollingStateTreeAsText const):
(WebCore::AsyncScrollingCoordinator::scrollingTreeAsText const):

• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::scrollingStateTreeAsText const):
(WebCore::ScrollingCoordinator::scrollingTreeAsText const):
(WebCore::ScrollingCoordinator::synchronousScrollingReasonsAsText):

• page/scrolling/ScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinatorTypes.h:
• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitTreeState):
(WebCore::ScrollingTree::updateTreeFromStateNodeRecursive):
(WebCore::ScrollingTree::propagateSynchronousScrollingReasons):
(WebCore::ScrollingTree::updateTreeFromStateNode): Deleted.

• page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::waitForScrollingTreeCommit):

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::commitStateAfterChildren):

• page/scrolling/ScrollingTreeScrollingNode.h:
• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::waitForScrollingTreeCommit):

• page/scrolling/ThreadedScrollingTree.h:
• testing/Internals.cpp:

(WebCore::Internals::scrollingTreeAsText const):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-non-cb-overflow-expected.txt: Added.
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-non-cb-overflow.html: Added.
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow-expected.txt: Added.
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow.html: Added.
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow2-expected.txt: Added.
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow2.html: Added.

8:52 AM Changeset in webkit [260189] by graouts@webkit.org

• 3 edits in trunk/LayoutTests

[ Mac wk2 Debug ] media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky timing out.
​https://bugs.webkit.org/show_bug.cgi?id=210349
<rdar://problem/61594098>

Reviewed by Eric Carlson.

This test had several things wrong about it. First, it manually created a MediaController in the test page and set a custom auto-hide delay on it.
However, it would test the proper behavior of the auto-hide behavior on the MediaController created by the media element, querying the state of
the media controls markup within that media element's shadow root. In that world, the auto-hide delay was the default delay, and not the custom
one set on the page-created MediaController.

The cause of the timeout was that the media clip used in this test is barely longer than the auto-hide delay, and it could happen that under slow
conditions, the media would end and the auto-hide timer would never have a chance to fire since it would be canceled due to auto-hide being disabled
when the media is not playing, such as when it ended.

We make this test saner and more realistic by not customizing the auto-hide delay, removing the page MediaController and simply setting "loop" on the
media element such that it never stops playing, givin the auto-hide timer additional time to fire with no risk of it being canceled by the media ending.

• media/modern-media-controls/media-controller/media-controller-auto-hide.html:
• platform/mac-wk2/TestExpectations:

8:45 AM Changeset in webkit [260188] by Kocsen Chung

• 1 copy in tags/Safari-610.1.9.4

Tag Safari-610.1.9.4.

8:34 AM Changeset in webkit [260187] by Kocsen Chung

• 8 edits in branches/safari-610.1.9-branch/Source

Versioning.

8:33 AM Changeset in webkit [260186] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit

REGRESSION (r259898): WebKit-based Books views are all blank
​https://bugs.webkit.org/show_bug.cgi?id=210590
<rdar://problem/61791109>

Reviewed by Chris Dumez.

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::enterAcceleratedCompositingWithRootLayer):
(WebKit::WebViewImpl::setAcceleratedCompositingRootLayer):
(WebKit::WebViewImpl::setAcceleratedCompositingRootLayerAfterFlush): Deleted.

• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::didFirstLayerFlush):
The changes to setAcceleratedCompositingRootLayer in r259898 proved
to be wrong in a second way (the first being fixed in r260104): when
setAcceleratedCompositingRootLayer is called from updateAcceleratedCompositingMode,
because the layer hosting mode changed (Books appears to use app-hosted layers),
it incorrectly identified the root layer change as a process swap, resulting
in the correct layer never being unhidden.

This is enough mistakes that I'm going to try a different approach:
put setAcceleratedCompositingRootLayer back to the way it was before, where
it immediately updates the layer without any smarts, remove
setAcceleratedCompositingRootLayerAfterFlush, because it's no longer necessary,
and add enterAcceleratedCompositingWithRootLayer, which is specifically only
called in the case where DrawingArea will for-sure send us a follow-up
(didFirstLayerFlush) that will unhide the root layer.

7:55 AM Changeset in webkit [260185] by Philippe Normand

• 2 edits in trunk/Tools

Unreviewed, GTK clean build fix after r260132.

• TestWebKitAPI/gtk/main.cpp:

(main): Don't use GtkVersioning here. A dependency on the WebCore
private headers for this single file is overkill.

7:25 AM Changeset in webkit [260184] by Claudio Saavedra

• 3 edits in trunk/Source/WebCore

Clean a couple of unused-parameters warnings
​https://bugs.webkit.org/show_bug.cgi?id=210596

Unreviewed.

No new tests needed.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::wouldTaintOrigin const): Remove
a spurious UNUSED_PARAM() for an actually used parameter.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateSecurityDiscCharacters):

7:07 AM Changeset in webkit [260183] by Diego Pino Garcia

• 2 edits
  1 delete in trunk/LayoutTests

[GTK] Gardening, mark several animations test as failure
​https://bugs.webkit.org/show_bug.cgi?id=210602

Unreviewed gardening.

For some reason these baselines are not making the tests pass in
the EWS GTK-WK2 bot, so I'm removing these GTK baselines added in
r260155 and mark the tests as failing instead.

• platform/gtk/TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target-expected.txt: Removed.

6:36 AM Changeset in webkit [260182] by eric.carlson@apple.com

• 42 edits
  9 adds in trunk

[macOS] Update ScreenTime as playback state changes
​https://bugs.webkit.org/show_bug.cgi?id=210518
<rdar://problem/61181092>

Reviewed by Jer Noble.
Source/WebCore:

Test: media/media-usage-state.html

Pass media element state to the UI process whenever it changes.

• Headers.cmake:
• WebCore.xcodeproj/project.pbxproj:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::mediaSessionUniqueIdentifier const):

• html/HTMLMediaElement.h:
• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::MediaElementSession):
(WebCore::MediaElementSession::~MediaElementSession):
(WebCore::MediaElementSession::updateMediaUsageIfChanged):

• html/MediaElementSession.h:
• page/ChromeClient.h:

(WebCore::ChromeClient::addMediaUsageManagerSession):
(WebCore::ChromeClient::updateMediaUsageManagerSessionState):
(WebCore::ChromeClient::removeMediaUsageManagerSession):

• platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::PlatformMediaSession):

• platform/audio/PlatformMediaSession.h:

(WebCore::PlatformMediaSession::updateMediaUsageIfChanged):
(WebCore::PlatformMediaSession::mediaSessionIdentifier const):

• platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary):

• platform/audio/PlatformMediaSessionManager.h:

(WebCore::PlatformMediaSessionManager::scheduleUpdateSessionStatus):
(WebCore::PlatformMediaSessionManager::sessionDidEndRemoteScrubbing):
(WebCore::PlatformMediaSessionManager::scheduleUpdateNowPlayingInfo): Deleted.

• platform/audio/cocoa/MediaSessionManagerCocoa.h:
• platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::scheduleUpdateSessionStatus):
(WebCore::MediaSessionManagerCocoa::sessionWillBeginPlayback):
(WebCore::MediaSessionManagerCocoa::sessionDidEndRemoteScrubbing):
(WebCore::MediaSessionManagerCocoa::removeSession):
(WebCore::MediaSessionManagerCocoa::sessionWillEndPlayback):
(WebCore::MediaSessionManagerCocoa::clientCharacteristicsChanged):
(WebCore::MediaSessionManagerCocoa::sessionCanProduceAudioChanged):
(WebCore::MediaSessionManagerCocoa::scheduleUpdateNowPlayingInfo): Deleted.

• platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::resetRestrictions):
(WebCore::MediaSessionManageriOS::sessionWillBeginPlayback):

• platform/graphics/MediaUsageInfo.h: Added.

(WebCore::MediaUsageInfo::operator== const):
(WebCore::MediaUsageInfo::operator!= const):
(WebCore::MediaUsageInfo::encode const):
(WebCore::MediaUsageInfo::decode):

• testing/Internals.cpp:

(WebCore::Internals::setMediaElementRestrictions):
(WebCore::Internals::mediaUsageState const):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebCore/PAL:

Soft link the UsageTracking framework.

• PAL.xcodeproj/project.pbxproj:
• pal/cocoa/UsageTrackingSoftLink.h: Added.
• pal/cocoa/UsageTrackingSoftLink.mm: Added.

Source/WebKit:

Add a manager that gets media element state changes, and a Cocoa-specific
implementation that passes that state to ScreenTime.

• Scripts/webkit/messages.py:
• Sources.txt:
• SourcesCocoa.txt:
• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::mediaUsageManager):
(WebKit::WebPageProxy::addMediaUsageManagerSession):
(WebKit::WebPageProxy::updateMediaUsageManagerSessionState):
(WebKit::WebPageProxy::removeMediaUsageManagerSession):

• UIProcess/Media/MediaUsageManager.cpp: Added.

(WebKit::MediaUsageManager::create):
(WebKit::reset):
(WebKit::MediaUsageManager::addMediaSession):
(WebKit::MediaUsageManager::removeMediaSession):
(WebKit::MediaUsageManager::updateMediaUsage):

• UIProcess/Media/MediaUsageManager.h: Added.
• UIProcess/Media/cocoa/MediaUsageManagerCocoa.h: Added.

(WebKit::MediaUsageManagerCocoa::SessionMediaUsage::SessionMediaUsage):

• UIProcess/Media/cocoa/MediaUsageManagerCocoa.mm: Added.

(WebKit::usageTrackingAvailable):
(WebKit::MediaUsageManager::create):
(WebKit::MediaUsageManagerCocoa::~MediaUsageManagerCocoa):
(WebKit::MediaUsageManagerCocoa::reset):
(WebKit::MediaUsageManagerCocoa::addMediaSession):
(WebKit::MediaUsageManagerCocoa::removeMediaSession):
(WebKit::MediaUsageManagerCocoa::updateMediaUsage):

• UIProcess/WebAuthentication/AuthenticatorManager.cpp:
• UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:
• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::addMediaUsageManagerSession):
(WebKit::WebChromeClient::updateMediaUsageManagerSessionState):
(WebKit::WebChromeClient::removeMediaUsageManagerSession):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::addMediaUsageManagerSession):
(WebKit::WebPage::updateMediaUsageManagerSessionState):
(WebKit::WebPage::removeMediaUsageManagerSession):

• WebProcess/WebPage/WebPage.h:

Source/WTF:

Define HAVE_MEDIA_USAGE_FRAMEWORK and ENABLE_MEDIA_USAGE

• wtf/PlatformEnableCocoa.h:
• wtf/PlatformHave.h:

LayoutTests:

• media/media-usage-state-expected.txt: Added.
• media/media-usage-state.html: Added.
• platform/gtk/TestExpectations: Skip new test.
• platform/win/TestExpectations: Ditto.
• platform/wpe/TestExpectations: Ditto.

6:07 AM Changeset in webkit [260181] by ysuzuki@apple.com

• 54 edits
  14 adds in trunk

[JSC] Implement JSMapIterator/JSSetIterator with JSInternalFieldObjectImpl
​https://bugs.webkit.org/show_bug.cgi?id=210023

Reviewed by Keith Miller.

JSTests:

• stress/map-iteration-oas.js: Added.

(shouldBe):
(test):

• stress/map-iterator-creation-fail-dfg.js: Added.

(shouldThrow):
(test2):
(test3):

• stress/map-iterator-creation-fail.js: Added.

(shouldThrow):
(i.shouldThrow):
(test2):
(test3):

• stress/set-iteration-oas.js: Added.

(shouldBe):

• stress/set-iterator-creation-fail-dfg.js: Added.

(shouldThrow):
(set shouldThrow):

• stress/set-iterator-creation-fail.js: Added.

(shouldThrow):
(i.shouldThrow):
(test2):
(test3):

Source/JavaScriptCore:

This patch reimplement JSMapIterator/JSSetIterator with JSInternalFieldObjectImpl.
This makes current JSFinalObject-based Map/SetIterator simple and small.
We generalize NewArrayIterator/PhantomNewArrayIterator to convert them to NewInternalFieldObject/PhantomNewInternalFieldObject
to support JSMapIterator/JSSetIterator too in DFG / FTL. This makes allocation efficient and object-allocation-sinking aware.

• builtins/BuiltinNames.h:
• builtins/MapIteratorPrototype.js:

(globalPrivate.mapIteratorNext):
(next):

• builtins/MapPrototype.js:

(globalPrivate.MapIterator): Deleted.
(values): Deleted.
(keys): Deleted.
(entries): Deleted.

• builtins/SetIteratorPrototype.js:

(globalPrivate.setIteratorNext):
(next):

• builtins/SetPrototype.js:

(globalPrivate.SetIterator): Deleted.
(values): Deleted.
(entries): Deleted.

• bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

• bytecode/BytecodeIntrinsicRegistry.h:
• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitIsMapIterator):
(JSC::BytecodeGenerator::emitIsSetIterator):

• bytecompiler/NodesCodegen.cpp:

(JSC::mapIteratorInternalFieldIndex):
(JSC::setIteratorInternalFieldIndex):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_getMapIteratorInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_getSetIteratorInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putMapIteratorInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putSetIteratorInternalField):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGMayExit.cpp:
• dfg/DFGNode.h:

(JSC::DFG::Node::convertToPhantomNewInternalFieldObject):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::isPhantomAllocation):
(JSC::DFG::Node::convertToPhantomNewArrayIterator): Deleted.

• dfg/DFGNodeType.h:
• dfg/DFGObjectAllocationSinkingPhase.cpp:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewInternalFieldObjectImpl):
(JSC::DFG::SpeculativeJIT::compileNewGenerator):
(JSC::DFG::SpeculativeJIT::compileNewAsyncGenerator):
(JSC::DFG::SpeculativeJIT::compileNewInternalFieldObject):
(JSC::DFG::SpeculativeJIT::compileNewArrayIterator): Deleted.

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGStoreBarrierInsertionPhase.cpp:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileNewInternalFieldObjectImpl):
(JSC::FTL::DFG::LowerDFGToB3::compileNewGenerator):
(JSC::FTL::DFG::LowerDFGToB3::compileNewAsyncGenerator):
(JSC::FTL::DFG::LowerDFGToB3::compileNewInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayIterator): Deleted.

• ftl/FTLOperations.cpp:

(JSC::FTL::operationPopulateObjectInOSR):
(JSC::FTL::operationMaterializeObjectInOSR):

• inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):
(Inspector::cloneMapIteratorObject):
(Inspector::cloneSetIteratorObject):
(Inspector::JSInjectedScriptHost::iteratorEntries):

• runtime/CommonIdentifiers.h:
• runtime/Intrinsic.cpp:

(JSC::intrinsicName):

• runtime/Intrinsic.h:
• runtime/JSArrayIterator.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::mapIteratorPrototype const):
(JSC::JSGlobalObject::setIteratorPrototype const):
(JSC::JSGlobalObject::mapIteratorStructure const):
(JSC::JSGlobalObject::setIteratorStructure const):

• runtime/JSMapIterator.cpp:

(JSC::JSMapIterator::createWithInitialValues):
(JSC::JSMapIterator::finishCreation):
(JSC::JSMapIterator::visitChildren):

• runtime/JSMapIterator.h:
• runtime/JSSetIterator.cpp:

(JSC::JSSetIterator::createWithInitialValues):
(JSC::JSSetIterator::finishCreation):
(JSC::JSSetIterator::visitChildren):

• runtime/JSSetIterator.h:
• runtime/JSType.cpp:

(WTF::printInternal):

• runtime/JSType.h:
• runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::finishCreation):

• runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):
(JSC::createMapIteratorObject):
(JSC::mapProtoFuncValues):
(JSC::mapProtoFuncKeys):
(JSC::mapProtoFuncEntries):

• runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):
(JSC::createSetIteratorObject):
(JSC::setProtoFuncValues):
(JSC::setProtoFuncEntries):

• runtime/VM.cpp:

(JSC::VM::setIteratorStructureSlow): Deleted.
(JSC::VM::mapIteratorStructureSlow): Deleted.

• runtime/VM.h:

(JSC::VM::setIteratorStructure): Deleted.
(JSC::VM::mapIteratorStructure): Deleted.

Source/WebCore:

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):

5:06 AM Changeset in webkit [260180] by ysuzuki@apple.com

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Use ensureStillAliveHere in FTL when content of storage should be kept alive
​https://bugs.webkit.org/show_bug.cgi?id=210583
<rdar://problem/61831515>

Reviewed by Mark Lam.

The content of Butterfly / ArrayStorage is kept alive only when the owner JSCell is alive.
This means that we should keep the owner JSCell alive if we are loading content of storage
which includes JSCells. This patch inserts ensureStillAliveHere in FTL to ensure this invariant.

• ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::~JITCode): Found that we get crash with dumpDisassembly if FTL::JITCode is destroyed while it fails to generate code while testing this.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPop):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharCodeAt):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCodePointAt):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByOffset):
(JSC::FTL::DFG::LowerDFGToB3::compileMultiGetByOffset):

4:46 AM WebKitGTK/2.28.x edited by berto@igalia.com

(diff)

4:46 AM WebKitGTK/2.28.x edited by berto@igalia.com

(diff)

4:45 AM Changeset in webkit [260179] by berto@igalia.com

• 2 edits in trunk/Source/WTF

Unreviewed, set CeilingOnPageSize for MIPS64

This fixes a build failure ("Must set CeilingOnPageSize in
PageBlock.h").

• wtf/PageBlock.h:

4:43 AM Changeset in webkit [260178] by Philippe Normand

• 3 edits in trunk/Source/WebCore

Unreviewed, fix GStreamer build warnings.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::cdmInstanceDetached):

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::handleErrorConditionFromStreamingThread):

4:39 AM Changeset in webkit [260177] by ddkilzer@apple.com

• 5 edits in trunk/Source/WebKit

[IPC hardening] DrawingArea::updateBackingStoreState() is not used on Apple platforms
<​https://webkit.org/b/210585>
<rdar://problem/61802011>

Reviewed by Geoffrey Garen.

• UIProcess/DrawingAreaProxy.h:
• UIProcess/DrawingAreaProxy.messages.in:
• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateBackingStoreState):

• WebProcess/WebPage/DrawingArea.messages.in:

Use USE(COORDINATED_GRAPHICS)

USE(TEXTURE_MAPPER) to

protect code not used on Apple platforms.

4:22 AM Changeset in webkit [260176] by clopez@igalia.com

• 7 edits in trunk

[GTK] MiniBrowser opens new windows too small causing failures on some WPT tests
​https://bugs.webkit.org/show_bug.cgi?id=210206

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Some WPT tests (when executed with the WPT runner via WebDriver)
open new browser windows via JavaScript invoking Window.open()
and then run the test on this new window.
The size of the new window is not specified, and we were failing
to provide a default window size, so it was using the minimum of
100x100 which its just too small for some test that later call
document.elementFromPoint() on some coordinates
that are outside of that size.

To fix that provide the size of the default GTK window to WebCore
if the application sets one via gtk_window_set_default_size().
And if not, then use the size of the previous window.

Also change the way we position the new window to work better when
the system uses more than one monitor. Previously to get the default
coordinates of the new window we were using gdk_display_get_monitor()
with just the first monitor available.
This causes issues in the calculation of the available space when
using several monitors. Instead get the monitor in use by looking
at the current GDK root window.

Tests: TestWebKitAPI/WebKit2Gtk/TestUIClient:/webkit/WebKitWebView/open-window-default-size
and TestWebKitAPI/WebKit2Gtk/TestUIClient:/webkit/WebKitWebView/open-window-no-default-size

• loader/FrameLoader.cpp:

(WebCore::createWindow):

• platform/gtk/PlatformScreenGtk.cpp:

(WebCore::getCurrentScreenMonitor):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

Source/WebKit:

Provide the size of the default window (if is set) when windowRect is called
before the window is shown.

• UIProcess/API/glib/WebKitUIClient.cpp:

Tools:

Add two API test to check that window.open() by default gets a size
request equal to the old window if there is no default window size,
or to the default window if there is a default window size.

A new function helper setCreateNewWebViewsInWindowsWithDefaultSize()
its added to create new webviews in new windows automatically, which
its needed to test the case of having a default window size.

• TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:

(testWebViewWindowProperties):
(testWebViewOpenWindowDefaultSize):
(testWebViewOpenWindowNoDefaultSize):
(beforeAll):

2:19 AM Changeset in webkit [260175] by Carlos Garcia Campos

• 2 edits in trunk

[GTK4] Disable netscape plugins API
​https://bugs.webkit.org/show_bug.cgi?id=210552

Reviewed by Adrian Perez de Castro.

Because GTK4 is the future and NPAPI plugins the past.

• Source/cmake/OptionsGTK.cmake:

12:11 AM Changeset in webkit [260174] by commit-queue@webkit.org

• 8 edits in trunk/Source

TextureMapper renders video element with "object-fit: cover" incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=210544

Patch by Tomoki Imai <Tomoki Imai> on 2020-04-16
Reviewed by Žan Doberšek.

Propagate GraphicsLayer::contentsClippingRect information to TextureMapperLayer
to properly clip the outside of DOM element when the element has "object-fit: cover".

Unfortunately, the test is disabled on WebKitGTK due to bug 177536, bug 163528.
Test: compositing/video/video-object-fit.html

Source/WebCore:

• platform/graphics/nicosia/NicosiaPlatformLayer.h:

(Nicosia::CompositionLayer::flushState):

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelf): Clip using propagated contentsClippingRect when rendering m_contentsLayer.
(WebCore::TextureMapperLayer::setContentsClippingRect):

• platform/graphics/texmap/TextureMapperLayer.h:
• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setContentsClippingRect):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::updateSceneState):