Timeline

Apr 20, 2020:

11:59 PM Changeset in webkit [260416] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Gardening, update expectations after r260356
​https://bugs.webkit.org/show_bug.cgi?id=210786

Unreviewed gardening.

• platform/gtk/TestExpectations:

11:11 PM Changeset in webkit [260415] by Ross Kirsling

• 222 edits in trunk

Classes marked final should not use protected access specifier
​https://bugs.webkit.org/show_bug.cgi?id=210775

Reviewed by Daniel Bates.

Source/JavaScriptCore:

• API/JSAPIValueWrapper.h:
• API/JSCallbackConstructor.h:
• API/JSCallbackObject.h:
• b3/B3ExtractValue.h:
• bytecode/UnlinkedFunctionExecutable.h:
• inspector/JSGlobalObjectConsoleClient.h:
• inspector/JSInjectedScriptHost.h:
• inspector/JSJavaScriptCallFrame.h:
• jsc.cpp:
• runtime/AggregateError.h:
• runtime/AggregateErrorPrototype.h:
• runtime/ArrayConstructor.h:
• runtime/ArrayPrototype.h:
• runtime/AsyncFunctionPrototype.h:
• runtime/AsyncGeneratorFunctionPrototype.h:
• runtime/AtomicsObject.h:
• runtime/BigIntConstructor.h:
• runtime/BigIntObject.h:
• runtime/BigIntPrototype.h:
• runtime/BooleanConstructor.h:
• runtime/BooleanPrototype.h:
• runtime/ConsoleObject.h:
• runtime/DateConstructor.h:
• runtime/DatePrototype.h:
• runtime/ErrorConstructor.h:
• runtime/ErrorPrototype.h:
• runtime/FileBasedFuzzerAgent.h:
• runtime/FunctionPrototype.h:
• runtime/FunctionRareData.h:
• runtime/GeneratorFunctionPrototype.h:
• runtime/GenericTypedArrayView.h:
• runtime/InspectorInstrumentationObject.h:
• runtime/IntlCollator.h:
• runtime/IntlCollatorConstructor.h:
• runtime/IntlCollatorPrototype.h:
• runtime/IntlDateTimeFormat.h:
• runtime/IntlDateTimeFormatConstructor.h:
• runtime/IntlDateTimeFormatPrototype.h:
• runtime/IntlNumberFormat.h:
• runtime/IntlNumberFormatConstructor.h:
• runtime/IntlNumberFormatPrototype.h:
• runtime/IntlPluralRules.h:
• runtime/IntlPluralRulesConstructor.h:
• runtime/IntlPluralRulesPrototype.h:
• runtime/IntlRelativeTimeFormatConstructor.h:
• runtime/IntlRelativeTimeFormatPrototype.h:
• runtime/JSArrayBuffer.h:
• runtime/JSArrayBufferConstructor.h:
• runtime/JSArrayBufferPrototype.h:
• runtime/JSAsyncGenerator.h:
• runtime/JSBoundFunction.h:
• runtime/JSCustomGetterSetterFunction.h:
• runtime/JSDataView.h:
• runtime/JSDataViewPrototype.h:
• runtime/JSGenerator.h:
• runtime/JSGenericTypedArrayView.h:
• runtime/JSGenericTypedArrayViewConstructor.h:
• runtime/JSGenericTypedArrayViewPrototype.h:
• runtime/JSGlobalLexicalEnvironment.h:
• runtime/JSModuleLoader.h:
• runtime/JSModuleNamespaceObject.h:
• runtime/JSNativeStdFunction.h:
• runtime/JSONObject.h:
• runtime/JSObject.h:
• runtime/JSTemplateObjectDescriptor.h:
• runtime/JSTypedArrayViewConstructor.h:
• runtime/JSTypedArrayViewPrototype.h:
• runtime/MathObject.h:
• runtime/NativeExecutable.h:
• runtime/NumberConstructor.h:
• runtime/NumberPrototype.h:
• runtime/ObjectConstructor.h:
• runtime/ObjectPrototype.h:
• runtime/PredictionFileCreatingFuzzerAgent.h:
• runtime/ReflectObject.h:
• runtime/RegExp.h:
• runtime/RegExpConstructor.h:
• runtime/RegExpObject.h:
• runtime/RegExpPrototype.h:
• runtime/StringPrototype.h:
• runtime/Structure.h:
• runtime/Symbol.h:
• runtime/SymbolConstructor.h:
• runtime/SymbolObject.h:
• runtime/SymbolPrototype.h:
• runtime/VMTraps.cpp:
• testRegExp.cpp:
• wasm/WasmBBQPlan.h:
• wasm/WasmLLIntPlan.h:
• wasm/WasmWorklist.cpp:
• wasm/js/JSWebAssembly.h:
• wasm/js/JSWebAssemblyCompileError.h:
• wasm/js/JSWebAssemblyInstance.h:
• wasm/js/JSWebAssemblyLinkError.h:
• wasm/js/JSWebAssemblyRuntimeError.h:
• wasm/js/WebAssemblyCompileErrorConstructor.h:
• wasm/js/WebAssemblyCompileErrorPrototype.h:
• wasm/js/WebAssemblyGlobalConstructor.h:
• wasm/js/WebAssemblyGlobalPrototype.h:
• wasm/js/WebAssemblyInstanceConstructor.h:
• wasm/js/WebAssemblyInstancePrototype.h:
• wasm/js/WebAssemblyLinkErrorConstructor.h:
• wasm/js/WebAssemblyLinkErrorPrototype.h:
• wasm/js/WebAssemblyMemoryConstructor.h:
• wasm/js/WebAssemblyMemoryPrototype.h:
• wasm/js/WebAssemblyModuleConstructor.h:
• wasm/js/WebAssemblyModulePrototype.h:
• wasm/js/WebAssemblyRuntimeErrorConstructor.h:
• wasm/js/WebAssemblyRuntimeErrorPrototype.h:
• wasm/js/WebAssemblyTableConstructor.h:
• wasm/js/WebAssemblyTablePrototype.h:
• wasm/js/WebAssemblyWrapperFunction.h:

Source/WebCore:

• Modules/applepay/ApplePayPaymentMethodSelectedEvent.h:
• Modules/applepay/ApplePayValidateMerchantEvent.h:
• Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h:
• Modules/webaudio/BiquadDSPKernel.h:
• Modules/webaudio/WaveShaperDSPKernel.h:
• Modules/websockets/WebSocketChannel.h:
• Modules/websockets/WorkerThreadableWebSocketChannel.h:
• Modules/webxr/WebXRSession.h:
• Modules/webxr/WebXRSystem.h:
• accessibility/AccessibilityARIAGridCell.h:
• accessibility/AccessibleSetValueEvent.h:
• animation/CSSAnimation.h:
• bindings/js/ReadableStream.h:
• bridge/objc/objc_runtime.h:
• bridge/runtime_array.h:
• css/CSSImageSetValue.h:
• html/HTMLKeygenElement.cpp:
• html/canvas/WebGLBuffer.h:
• html/canvas/WebGLFramebuffer.h:
• html/canvas/WebGLProgram.h:
• html/canvas/WebGLQuery.h:
• html/canvas/WebGLRenderbuffer.h:
• html/canvas/WebGLSampler.h:
• html/canvas/WebGLSync.h:
• html/canvas/WebGLTransformFeedback.h:
• html/canvas/WebGLUniformLocation.h:
• html/shadow/TextControlInnerElements.h:
• inspector/InspectorStyleSheet.h:
• inspector/WebInjectedScriptManager.h:
• loader/cache/CachedCSSStyleSheet.h:
• page/Frame.h:
• page/FrameView.h:
• page/PageConsoleClient.h:
• page/animation/KeyframeAnimation.h:
• page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.h:
• platform/audio/AudioBus.h:
• platform/cocoa/PlaybackSessionModelMediaElement.h:
• platform/graphics/BitmapImage.h:
• platform/graphics/CrossfadeGeneratedImage.h:
• platform/graphics/NamedImageGeneratedImage.h:
• platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
• platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h:
• platform/graphics/ca/win/PlatformCAAnimationWin.h:
• platform/graphics/cg/ImageDecoderCG.h:
• platform/graphics/iso/ISOOriginalFormatBox.h:
• platform/graphics/iso/ISOProtectionSchemeInfoBox.h:
• platform/graphics/iso/ISOSchemeInformationBox.h:
• platform/graphics/iso/ISOSchemeTypeBox.h:
• platform/graphics/iso/ISOTrackEncryptionBox.h:
• platform/graphics/iso/ISOVTTCue.cpp:
• platform/graphics/iso/ISOVTTCue.h:
• platform/graphics/win/ImageDecoderDirect2D.h:
• platform/mediastream/mac/AVCaptureDeviceManager.h:
• platform/mock/mediasource/MockBox.h:
• platform/mock/mediasource/MockSourceBufferPrivate.cpp:
• rendering/RenderFullScreen.h:
• rendering/RenderGrid.h:
• rendering/RenderMultiColumnSet.h:
• rendering/RenderRuby.h:
• rendering/RenderScrollbarPart.h:
• rendering/RenderScrollbarTheme.h:
• rendering/RenderTableCell.h:
• rendering/RenderTableSection.h:
• rendering/RenderThemeIOS.h:
• rendering/RenderView.h:
• rendering/svg/RenderSVGResourceClipper.h:
• svg/SVGTextPathElement.h:
• workers/WorkerConsoleClient.h:
• worklets/Worklet.h:

Source/WebKit:

• Shared/API/APIDictionary.h:
• WebProcess/GPU/media/TextTrackPrivateRemote.h:
• WebProcess/Plugins/Netscape/JSNPMethod.h:
• WebProcess/Plugins/Netscape/JSNPObject.h:

Source/WebKitLegacy:

• WebCoreSupport/WebResourceLoadScheduler.h:

Source/WebKitLegacy/win:

• DefaultDownloadDelegate.h:
• DefaultPolicyDelegate.h:
• MemoryStream.h:
• WebApplicationCache.h:
• WebArchive.h:
• WebBackForwardList.h:
• WebCache.h:
• WebCoreStatistics.h:
• WebDataSource.h:
• WebElementPropertyBag.h:
• WebError.h:
• WebFrame.h:
• WebFramePolicyListener.h:
• WebHTMLRepresentation.h:
• WebHistoryItem.h:
• WebJavaScriptCollector.h:
• WebKitClassFactory.h:
• WebKitStatistics.h:
• WebMutableURLRequest.h:
• WebNotification.h:
• WebNotificationCenter.h:
• WebPreferences.h:
• WebResource.h:
• WebURLAuthenticationChallenge.h:
• WebURLCredential.h:
• WebURLProtectionSpace.h:
• WebURLResponse.h:

Tools:

• DumpRenderTree/win/DefaultPolicyDelegate.h:
• DumpRenderTree/win/UIDelegate.h:

9:51 PM Changeset in webkit [260414] by ysuzuki@apple.com

• 1 edit
  14 adds in trunk/JSTests

[JSC] Import V8 BigInt tests generated by bigint-tester.py
​https://bugs.webkit.org/show_bug.cgi?id=210783

Reviewed by Ross Kirsling.

This patch adds BigInt tests generated by V8 bigint-tester.py, which is modified for JSC use.

• stress/v8-bigint-add.js: Added.
• stress/v8-bigint-and.js: Added.
• stress/v8-bigint-dec.js: Added.
• stress/v8-bigint-div.js: Added.
• stress/v8-bigint-inc.js: Added.
• stress/v8-bigint-mod.js: Added.
• stress/v8-bigint-mul.js: Added.
• stress/v8-bigint-neg.js: Added.
• stress/v8-bigint-not.js: Added.
• stress/v8-bigint-or.js: Added.
• stress/v8-bigint-sar.js: Added.
• stress/v8-bigint-shl.js: Added.
• stress/v8-bigint-sub.js: Added.
• stress/v8-bigint-xor.js: Added.

9:48 PM Changeset in webkit [260413] by timothy_horton@apple.com

• 2 edits in trunk/Source/WTF

Try to fix the build after r260407

• wtf/PlatformHave.h:

9:06 PM Changeset in webkit [260412] by Peng Liu

• 22 edits in trunk

Fix build failures when video fullscreen and picture-in-picture is disabled
​https://bugs.webkit.org/show_bug.cgi?id=210777

Reviewed by Eric Carlson.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Wrap video fullscreen and picture-in-picture related code with "#if ENABLE(VIDEO_PRESENTATION_MODE)".

• Configurations/FeatureDefines.xcconfig:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):

• platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
• platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:

(WebCore::VideoLayerManagerObjC::setVideoLayer):
(WebCore::VideoLayerManagerObjC::requiresTextTrackRepresentation const):
(WebCore::VideoLayerManagerObjC::syncTextTrackBounds):
(WebCore::VideoLayerManagerObjC::setTextTrackRepresentation):

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Wrap video fullscreen and picture-in-picture related code with "#if ENABLE(VIDEO_PRESENTATION_MODE)".

• Configurations/FeatureDefines.xcconfig:
• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenGravity):
(WebKit::RemoteMediaPlayerProxy::updateVideoFullscreenInlineImage):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenMode):
(WebKit::RemoteMediaPlayerProxy::videoFullscreenStandbyChanged):
(WebKit::RemoteMediaPlayerProxy::setBufferingPolicy):

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
• GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:

(WebKit::RemoteMediaPlayerProxy::prepareForPlayback):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::prepareForPlayback):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/PlatformEnable.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

9:04 PM Changeset in webkit [260411] by Ross Kirsling

• 9 edits in trunk/Source/JavaScriptCore

Intl classes shouldn't need an m_initialized* field
​https://bugs.webkit.org/show_bug.cgi?id=210764

Reviewed by Darin Adler.

Existing Intl classes each have a field like m_initializedNumberFormat, but this is unnecessary on two levels:

1. The thing that gets initialized is a unique pointer to an ICU struct, so we can check it directly.
2. Everywhere we're checking this is redundant since we've already done the same check on the prototype side, therefore we can just ASSERT before using said ICU struct.

While we're at it, clean up other stuff like:

• Move stuff that doesn't need to be part of the class to the CPP file (e.g. UFieldPositionIteratorDeleter).
• Merge createCollator into initializeCollator (seems like this is probably the oldest code in this space).

• runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):
(JSC::IntlCollator::compareStrings):
(JSC::IntlCollator::resolvedOptions):
(JSC::IntlCollator::createCollator): Deleted.

• runtime/IntlCollator.h:
• runtime/IntlDateTimeFormat.cpp:

(JSC::UFieldPositionIteratorDeleter::operator() const):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::resolvedOptions):
(JSC::IntlDateTimeFormat::format):
(JSC::partTypeString):
(JSC::IntlDateTimeFormat::formatToParts):
(JSC::IntlDateTimeFormat::UFieldPositionIteratorDeleter::operator() const): Deleted.
(JSC::IntlDateTimeFormat::partTypeString): Deleted.

• runtime/IntlDateTimeFormat.h:
• runtime/IntlNumberFormat.cpp:

(JSC::UFieldPositionIteratorDeleter::operator() const):
(JSC::IntlNumberFormatField::IntlNumberFormatField):
(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::format):
(JSC::IntlNumberFormat::resolvedOptions):
(JSC::partTypeString):
(JSC::IntlNumberFormat::formatToParts):
(JSC::IntlNumberFormat::UFieldPositionIteratorDeleter::operator() const): Deleted.
(JSC::IntlNumberFormat::partTypeString): Deleted.

• runtime/IntlNumberFormat.h:
• runtime/IntlPluralRules.cpp:

(JSC::localeData):
(JSC::IntlPluralRules::initializePluralRules):
(JSC::IntlPluralRules::resolvedOptions):
(JSC::IntlPluralRules::select):
(JSC::IntlPRInternal::localeData): Deleted.

• runtime/IntlPluralRules.h:

8:23 PM Changeset in webkit [260410] by commit-queue@webkit.org

• 18 edits in trunk

SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
​https://bugs.webkit.org/show_bug.cgi?id=210533

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-20
Reviewed by Brady Eidson.

Source/WebKit:

• NetworkProcess/NetworkDataTask.h:

(WebKit::NetworkDataTaskClient::didNegotiateModernTLS):

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didNegotiateModernTLS):

• NetworkProcess/NetworkLoad.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::didNegotiateModernTLS):

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):

• UIProcess/API/APINavigationClient.h:

(API::NavigationClient::didNegotiateModernTLS):

• UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
• UIProcess/Cocoa/NavigationState.h:
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::didNegotiateModernTLS):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didNegotiateModernTLS):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(-[TLSNavigationDelegate waitForDidNegotiateModernTLS]):
(-[TLSNavigationDelegate _webView:didNegotiateModernTLS:]):
(TestWebKitAPI::TEST):

7:52 PM Changeset in webkit [260409] by ysuzuki@apple.com

• 2 edits in trunk/Source/WTF

Add document about WTF malloc-related macros
​https://bugs.webkit.org/show_bug.cgi?id=208367

Reviewed by Anders Carlsson, Simon Fraser, and Darin Adler.

This adds document about WTF malloc-related macros since we have bunch of macros now.

• wtf/FastMalloc.h:

7:36 PM Changeset in webkit [260408] by Kate Cheney

• 5 edits in trunk

App-bound domain behavior should abide by the limitsNavigationsToAppBoundDomains argument in WKWebView configuration
​https://bugs.webkit.org/show_bug.cgi?id=210769
<rdar://problem/62065241>

Reviewed by Brent Fulgham.

Source/WebKit:

Changes app-bound domain behavior to be triggered by the value of
limitsNavigationsToAppBoundDomains, a WebView configuration flag.
If the WebView has this parameter set and is currently navigating to
an app bound domain, then app-bound privileges will be granted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomainAndCheckIfPermitted):
Update this function to return a boolean to indicate whether the
navigation should fail. A failure should occur if a WebView has set
the limitsNavigationsToAppBoundDomains flag and attempts to navigate
away from an app-bound domain.

If the limitsNavigationsToAppBoundDomains value has not been set to
true, maintain non-app bound behavior regardless of whether the domain
is app-bound or not.

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Check the result of setIsNavigatingToAppBoundDomainAndCheckIfPermitted and fail the
navigation if needed, with both RELEASE logging and an appropriate
error message.

(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain): Deleted.

• UIProcess/WebPageProxy.h:

Renamed for clarity.

Tools:

Removes any tests for swapping between app-bound and non app-bound
domains as this behavior is no longer supported.

Sets the limitsNavigationsToAppBoundDomains flag for tests which should
have app-bound behavior to maintain test functionality.

Adds 5 new tests for new behavior.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(TEST):
(-[AppBoundDomainDelegate webView:didFinishNavigation:]):
(-[AppBoundDomainDelegate webView:didFailProvisionalNavigation:withError:]):
(-[AppBoundDomainDelegate waitForDidFinishNavigation]):
(-[AppBoundDomainDelegate waitForDidFailProvisionalNavigationError]):

5:27 PM Changeset in webkit [260407] by Nikos Mouchtaris

• 16 edits
  2 adds in trunk/Source

WK2 Quicklook for attachments
​https://bugs.webkit.org/show_bug.cgi?id=208891

Reviewed by Darin Adler.

Source/WebCore:

Added to HTMLAttachmentElement to have member image representing
QuickLook thumbnail. Added code to render this image on both iOS and Mac.

No new tests. Test will be added after additions to test infrastructure.

• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::updateThumbnailRepresentation):
Allow setting of thumbnail member.

• html/HTMLAttachmentElement.h:
• rendering/RenderThemeIOS.mm:

Added rendering of image member of attachment element.
(WebCore::RenderAttachmentInfo::RenderAttachmentInfo):
(WebCore::paintAttachmentIcon):
(WebCore::RenderThemeIOS::paintAttachment):

• rendering/RenderThemeMac.mm:

(WebCore::paintAttachmentIcon):

Source/WebKit:

Allow attachment elements to render QuickLook thumbnail generated
from contents of the file as its icon, rather than the default
icons associated with each mime type.

• Configurations/WebKit.xcconfig:

Link QuickLook thumbnailing framework.

• UIProcess/API/APIAttachment.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _insertAttachmentWithFileWrapper:contentType:completion:]):

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

Create thumbnail request and add to queue.
(WebKit::convertNSImageToBitmap):
(WebKit::convertUIImageToBitmap):
(WebKit::WebPageProxy::getQLThumbnailForGenerationRequestion):
(WebKit::WebPageProxy::getQLThumbnailForFileWrapper):
(WebKit::WebPageProxy::getQLThumbnailForAttachment):

• UIProcess/QLThumbnailLoad.h: Added.
• UIProcess/QLThumbnailLoad.mm: Added.

Add code to request thumbnail for file data.
(-[WKQLThumbnailQueueManager init]):
(+[WKQLThumbnailQueueManager sharedInstance]):
(-[WKQLThumbnailLoadOperation initWithAttachment:identifier:]):
(-[WKQLThumbnailLoadOperation initWithURL:identifier:]):
(-[WKQLThumbnailLoadOperation start]):
(-[WKQLThumbnailLoadOperation isAsynchronous]):
(-[WKQLThumbnailLoadOperation isExecuting]):
(-[WKQLThumbnailLoadOperation setExecuting:]):
(-[WKQLThumbnailLoadOperation isFinished]):
(-[WKQLThumbnailLoadOperation setFinished:]):

• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateAttachmentIcon):
Set thumbnail of attachment element

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Thumbnail request message.

5:03 PM Changeset in webkit [260406] by Alan Coon

• 2 edits in branches/safari-610.1.11-branch/Source/WebKit

Unreviewed macCatalyst build fix.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::disableServiceWorkerEntitlementInNetworkProcess):
(WebKit::WebPageProxy::clearServiceWorkerEntitlementOverride):

4:08 PM Changeset in webkit [260405] by Kate Cheney

• 2 edits in trunk/Source/WebKit

Unreviewed macCatalyst build fix.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::disableServiceWorkerEntitlementInNetworkProcess):
(WebKit::WebPageProxy::clearServiceWorkerEntitlementOverride):

3:32 PM Changeset in webkit [260404] by ysuzuki@apple.com

• 6 edits in trunk

Add more structure-cloning tests for BigInt
​https://bugs.webkit.org/show_bug.cgi?id=210765

Reviewed by Mark Lam.

Source/WebCore:

This patch adds safe-guard for future JSC primitive extension for structure-cloning.
We throw DataCloneError if we see unknown primitive value, which can happen if JSC
extends primitive value.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpImmediate):
(WebCore::CloneSerializer::dumpIfTerminal):

LayoutTests:

Add more tests for BigInt outside of WPT (they are already tested in WPT, but this adds more tests).

• fast/dom/Window/window-postmessage-clone-expected.txt:
• fast/dom/Window/window-postmessage-clone.html:
• platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:

2:55 PM Changeset in webkit [260403] by Simon Fraser

• 16 edits
  2 adds in trunk

Scrolling with background-attachment: fixed needs to trigger repaints
​https://bugs.webkit.org/show_bug.cgi?id=193893
<rdar://problem/47587017>

Reviewed by Dean Jackson.

Source/WebCore:

When scrolling an overflow scroll which has "background-atttachment:fixed" in the content,
the node will have non-empty synchronous scrolling reasons. In this case we need to
send the scroll to the main thread, and trigger a repaint on scroll.

If handling the wheel event on the scrolling thread determines that the scroll must be sent
to the main thread, EventDispatcher::wheelEvent() does so in the callback function.

To trigger the repaint, RenderLayer::scrollTo() asks the composited layers backing whether
the node has synchronous scrolling reasons; this is implemented by asking the scrolling
coordinator.

Test: scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-repaint.html

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::hasSynchronousScrollingReasons const):

• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::hasSynchronousScrollingReasons const):

• page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::hasSynchronousScrollingReasons const):

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent):

• page/scrolling/ScrollingTreeScrollingNode.h:
• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::currentScrollPositionChanged):

• page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:

(WebCore::ScrollingTreeOverflowScrollingNodeMac::handleWheelEvent): Return SendToMainThread if this node
needs to do synchronous scrolling.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::needsRepaintOnCompositedScroll const):
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):

• rendering/RenderLayerBacking.h:

Source/WebKit:

When scrolling an overflow scroll which has "background-atttachment:fixed" in the content,
the node will have non-empty synchronous scrolling reasons. In this case we need to
send the scroll to the main thread, and trigger a repaint on scroll.

If handling the wheel event on the scrolling thread determines that the scroll must be sent
to the main thread, EventDispatcher::wheelEvent() does so in the callback function.

To trigger the repaint, RenderLayer::scrollTo() asks the composited layers backing whether
the node has synchronous scrolling reasons; this is implemented by asking the scrolling
coordinator.

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

LayoutTests:

• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-repaint-expected.html: Added.
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-repaint.html: Added.

2:45 PM Changeset in webkit [260402] by Megan Gardner

• 14 edits
  2 adds in trunk

Date and Time form controls not showing correct initial values on immediate second invocation.
​https://bugs.webkit.org/show_bug.cgi?id=210613

Reviewed by Wenson Hsieh.

Source/WebKit:

Updating the webprocess with the newly picked time did not update the local store of that data in the
UI process, so when the control was activated a second time, and we skipped the round trip to the
webprocess to get the data we were certian we already had, we did not start the popover in the
correct state. We now update the webprocess and the local UI stored variable at the same time.

Test: fast/forms/ios/time-picker-value-change.html

• UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
• UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView timePickerValueHour]):
(-[WKWebView timePickerValueMinute]):

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView updateValueAsNumberForViewController:]):
(-[WKContentView updateValueForViewController:]):
(-[WKContentView setTimePickerValueToHour:minute:]):
(-[WKContentView timePickerValueHour]):
(-[WKContentView timePickerValueMinute]):

• UIProcess/ios/forms/WKFormInputControl.h:
• UIProcess/ios/forms/WKFormInputControl.mm:

(-[WKDateTimePicker hour]):
(-[WKDateTimePicker minute]):
(-[WKDateTimePicker _dateChangedSetAsNumber]):
(-[WKDateTimePicker _dateChangedSetAsString]):
(-[WKDateTimePicker setHour:minute:]):
(-[WKFormInputControl setTimePickerHour:minute:]):
(-[WKFormInputControl timePickerValueHour]):
(-[WKFormInputControl timePickerValueMinute]):
(-[WKDateTimePopover setHour:minute:]):
(-[WKDateTimePopover hour]):
(-[WKDateTimePopover minute]):

Tools:

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::timePickerValueHour const):
(WTR::UIScriptController::timePickerValueMinute const):

• WebKitTestRunner/ios/UIScriptControllerIOS.h:
• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::timePickerValueHour const):
(WTR::UIScriptControllerIOS::timePickerValueMinute const):

LayoutTests:

• fast/forms/ios/time-picker-value-change-expected.txt: Added.
• fast/forms/ios/time-picker-value-change.html: Added.
• resources/ui-helper.js:

(window.UIHelper.timerPickerValues):

2:42 PM Changeset in webkit [260401] by Alan Coon

• 2 edits in branches/safari-610.1.11-branch/Source/WebKit

Try to fix the macCatalyst build after r260366

• UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:

2:29 PM Changeset in webkit [260400] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Try to fix the macCatalyst build after r260366

• UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:

2:17 PM Changeset in webkit [260399] by clopez@igalia.com

• 3 edits in trunk/LayoutTests

Skip tests related with missing reftest-wait support for imported WPT tests.

Unreviewed gardening.

Also fix a few typos on the bug numbers for the expectations.

• TestExpectations:
• platform/gtk/TestExpectations:

2:14 PM Changeset in webkit [260398] by Russell Epstein

• 1 copy in tags/Safari-609.2.8

Tag Safari-609.2.8.

2:05 PM Changeset in webkit [260397] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

FTL doesn't observe the use kind of CheckIsConstant's child1
​https://bugs.webkit.org/show_bug.cgi?id=210763

Reviewed by Yusuke Suzuki.

Somehow, this didn't get added when I changed CheckIsConstant and didn't show up
when I tested r260377 because I tested in release. Fortunately, the produced
DFG IR will be the same.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCheckIsConstant):

1:38 PM Changeset in webkit [260396] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

MSVC: LayoutUnits.h(248): warning C4245: 'argument': conversion from 'const int' to 'size_t', signed/unsigned mismatch
​https://bugs.webkit.org/show_bug.cgi?id=210592

Reviewed by Zalan Bujtas.

• layout/LayoutUnits.h:

(WTF::HashTraits<WebCore::Layout::SlotPosition>::emptyValue):
(WTF::HashTraits<WebCore::Layout::SlotPosition>::constructDeletedValue):
(WTF::HashTraits<WebCore::Layout::SlotPosition>::isDeletedValue):
Use std::numeric_limits<size_t>::max() for empty and deleted
values instead of WebCore::intMinForLayoutUnit.

1:35 PM Changeset in webkit [260395] by Alan Coon

• 1 copy in branches/safari-610.1.11-branch

New branch.

1:35 PM Changeset in webkit [260394] by Alan Coon

• 1 delete in branches/safari-610.1.11-branch

Delete branch.

1:19 PM Changeset in webkit [260393] by Wenson Hsieh

• 4 edits in trunk

Text manipulation sometimes fails to replace text in title elements
​https://bugs.webkit.org/show_bug.cgi?id=210750
<rdar://problem/61066103>

Reviewed by Tim Horton and Darin Adler.

Source/WebCore:

Internal clients using WebKit text manipulation APIs currently fail to replace text in title and option elements
in the case where text manipulation has been completed with more than one token. These are elements for which we
want to replace the entire text as a single token, even if the text manipulation client ends up breaking the
token into multiple chunks.

To handle this case, pull the title || option check out into a helper function, and consult it when completing
text manipulation in the case where the manipulation data lacks either start or end positions. If
canPerformTextManipulationByReplacingEntireTextContent is true and there are multiple replacement tokens,
allow ourselves to process the replacement by combining the replacement tokens into a space-separated string.

Test: TextManipulation.CompleteTextManipulationShouldReplaceTextContentWithMultipleTokens

• editing/TextManipulationController.cpp:

(WebCore::canPerformTextManipulationByReplacingEntireTextContent):
(WebCore::TextManipulationController::observeParagraphs):
(WebCore::TextManipulationController::replace):

Tools:

Add a new API test to verify that a single title or option element may be replaced with multiple tokens, as long
as all the token identifiers match.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

1:11 PM Changeset in webkit [260392] by Andres Gonzalez

• 2 edits in trunk/Source/WebCore

The rect for the primary screen should be retrieved on the main thread.
​https://bugs.webkit.org/show_bug.cgi?id=210760

Reviewed by Chris Fleizach.

• Call to screenRectForPrimaryScreen is dispatched to main thread.
• This value is cached since it is very unlikely to change in normal

usage and this would avoid hitting the main thread repeatedly.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper primaryScreenHeight]):

1:09 PM Changeset in webkit [260391] by stephan.szabo@sony.com

• 2 edits in trunk/Source/WebKit

Fix build when !ENABLE(RESOURCE_LOAD_STATISTICS)
​https://bugs.webkit.org/show_bug.cgi?id=210757

Reviewed by Ross Kirsling.

Build fix, no new tests

• NetworkProcess/NetworkDataTask.cpp:

Add ENABLE(RESOURCE_LOAD_STATISTICS) around block
using NetworkSession functions only declared when
that is enabled.

1:04 PM Changeset in webkit [260390] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

When SpeculativeLoadManager is destroyed, properly clean up its PendingFrameLoads
​https://bugs.webkit.org/show_bug.cgi?id=210759
<rdar://problem/62056856>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-20
Reviewed by Darin Adler.

Recent work on the resourceLoadStatistics layout tests increased the amount we swap out the WebsiteDataStore.
When this happens, the NetworkSession is eventually destroyed in the NetworkProcess, sometimes when running the next test.
An assertion was firing in the PendingFrameLoad destructor because it hadn't been marked as complete when it was destroyed.
Rather than remove the assertion, when we destroy the SpeculativeLoadManager (which only happens when a WebsiteDataStore
is destroyed) during a speculative pending frame load, just mark the pending frame load as complete because it is being cancelled.
Marking the pending frame load as complete can tell the SpeculativeLoadManager to mutate m_pendingFrameLoads, which we don't want
to do while iterating, so copy the RefPtrs into a Vector first then iterate that to get them all.

This fixes an assertion that was sometimes hit in http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-prevalent-subresource-redirects-database.html
but only after running other tests that had initiated speculative pending frame loads. This was ostensibly started by r260322 but is quite unrelated.

• NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::SpeculativeLoadManager::~SpeculativeLoadManager):

12:56 PM Changeset in webkit [260389] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK][WPE] Gardening, update expectations after r260322
​https://bugs.webkit.org/show_bug.cgi?id=210761

Unreviewed gardening.

• platform/gtk/TestExpectations:

12:44 PM Changeset in webkit [260388] by clopez@igalia.com

• 6 edits in trunk/LayoutTests

Clean and merge test expectations for WPT tests for Intersection Observer v2.

Unreviewed gardening.

Merge the expectations for the tests cross-origin-effects.sub.html
and cross-origin-occlusion.sub.html on the common TestExpectations file.

• TestExpectations:
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:
• platform/wpe/TestExpectations:

12:37 PM Changeset in webkit [260387] by stephan.szabo@sony.com

• 4 edits in trunk

[PlayStation] Fix build after r260277
​https://bugs.webkit.org/show_bug.cgi?id=210756

Reviewed by Don Olmstead.

Source/WebKit:

Build fix, no new tests.

• PlatformPlayStation.cmake:

Tools:

• TestWebKitAPI/PlatformPlayStation.cmake:

12:35 PM Changeset in webkit [260386] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: the filter bar in the navigation sidebar should respect the global search settings
​https://bugs.webkit.org/show_bug.cgi?id=210679

Reviewed by Joseph Pecoraro.

• UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype.updateFilter):

12:21 PM Changeset in webkit [260385] by svillar@igalia.com

• 8 edits
  1 add in trunk

[WebXR] Update WebXRSession and WebXRSystem interfaces
​https://bugs.webkit.org/show_bug.cgi?id=210553

Reviewed by Žan Doberšek.

LayoutTests/imported/w3c:

• web-platform-tests/webxr/idlharness.https.window-expected.txt: Added.

Source/WebCore:

Update WebXRSession and WebXRSystem to the latest changes in the specs.

• Modules/webxr/WebXRSession.idl: Added 3 new events.
• Modules/webxr/WebXRSystem.idl: Interface name is XR not XRSystem.
• bindings/js/WebCoreBuiltinNames.h: Renamed macro.
• dom/EventNames.h: Added 3 new events.

LayoutTests:

• platform/wpe/TestExpectations: Mark idlharness.https.window.html test as Passed.

12:11 PM Changeset in webkit [260384] by ysuzuki@apple.com

• 4 edits in trunk

[JSC] Skip test262 for non-safe-integer range BigIntConstructor
​https://bugs.webkit.org/show_bug.cgi?id=210749

Reviewed by Keith Miller.

JSTests:

We skip test262 test/built-ins/BigInt/constructor-integer.js for now. As it is shown in old test262 JSTests/test262/expectations.yaml,
this test was failing before BigInt flag is enabled. And new BigInt patch changes error message while we are failing in the same way.
While we implemented BigInt, this test is based on spec change introduced[1], and we are not implementing this. So we mark it skipped,
as it is skipped before BigInt is enabled.

[1]: ​https://github.com/tc39/proposal-bigint/pull/138

• test262/config.yaml:

Source/JavaScriptCore:

• runtime/BigIntConstructor.cpp:

(JSC::callBigIntConstructor):

12:10 PM Changeset in webkit [260383] by Darin Adler

• 3 edits in trunk/Source/WTF

REGRESSION (r253987): StringImpl::adopt(Vector&&) copies only half of the characters in the Vector when copying across malloc zones
​https://bugs.webkit.org/show_bug.cgi?id=210736

Reviewed by Yusuke Suzuki.

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::replace): Use copyCharacters instead of memcpy.

• wtf/text/StringImpl.h: Use std::is_same_v instead of std::is_same.

(WTF::StringImpl::StringImpl): Use copyCharacters instead of memcpy.
Also drop C-style cast to cast away const.
(WTF::StringImpl::adopt): Don't even try to adopt across malloc zones.

11:43 AM Changeset in webkit [260382] by Chris Dumez

• 7 edits
  2 adds in trunk

Sending beacons when Fetch KeepAlive feature is disabled crashes the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=210753
<rdar://problem/61896221>

Reviewed by Geoffrey Garen.

Source/WebCore:

Test: http/wpt/beacon/beacon-legacy-code-path.html

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setFetchAPIKeepAliveEnabled):

• testing/InternalSettings.h:
• testing/InternalSettings.idl:

Add internal settings to disable Fetch Keep Alive for layout testing.

Source/WebKit:

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::startPingLoad):
Make sure NetworkResourceLoadParameters's webPageProxyID / webPageID / webFrameID are properly
initialized before sending the IPC or IPC decoding will fail.

LayoutTests:

Add layout test coverage.

• http/wpt/beacon/beacon-legacy-code-path-expected.txt: Added.
• http/wpt/beacon/beacon-legacy-code-path.html: Added.

11:41 AM Changeset in webkit [260381] by ddkilzer@apple.com

• 15 edits
  1 copy in trunk/Source/WebKit

[IPC hardening] Use ObjectIdentifier<> for geolocationID
<​https://webkit.org/b/210680>
<rdar://problem/58892340>

Reviewed by Chris Dumez.

Replace uses of uint64_t with GeolocationIdentifier.

• Scripts/webkit/messages.py:
• UIProcess/GeolocationIdentifier.h: Add.
• UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::createRequest):
(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):

• UIProcess/GeolocationPermissionRequestManagerProxy.h:
• UIProcess/GeolocationPermissionRequestProxy.cpp:

(WebKit::GeolocationPermissionRequestProxy::GeolocationPermissionRequestProxy):

• UIProcess/GeolocationPermissionRequestProxy.h:

(WebKit::GeolocationPermissionRequestProxy::create):

• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::didReceiveGeolocationPermissionDecision):
(WebKit::generateGeolocationID): Delete.

• Replace with GeolocationIdentifier::generate().
• WebProcess/Geolocation/GeolocationPermissionRequestManager.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveGeolocationPermissionDecision):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

11:16 AM Changeset in webkit [260380] by youenn@apple.com

• 11 edits
  2 adds in trunk

MediaPlayerPrivateMediaStreamAVFObjC should start play a newly added audio track if it is playing
​https://bugs.webkit.org/show_bug.cgi?id=210740

Reviewed by Eric Carlson.

Source/WebCore:

Before the patch, MediaPlayerPrivateMediaStreamAVFObjC was not calling play on the audio renderer when the audio renderer
was added after the MediaPlayerPrivateMediaStreamAVFObjC was asked to play.
This patch makes it so that, on configuration of an audio track, it will be asked to play if its MediaPlayerPrivateMediaStreamAVFObjC is playing.
Add internals API to be able to write a test.

Test: fast/mediastream/play-newly-added-audio-track.html

• html/track/AudioTrack.h:
• html/track/AudioTrack.idl:
• platform/graphics/AudioTrackPrivate.h:

(WebCore::AudioTrackPrivate::isBackedByMediaStreamTrack const):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):

• platform/mediastream/AudioTrackPrivateMediaStream.cpp:

(WebCore::AudioTrackPrivateMediaStream::play):

• platform/mediastream/AudioTrackPrivateMediaStream.h:

(isType):

• testing/Internals.cpp:

(WebCore::Internals::isMockRealtimeMediaSourceCenterEnabled):
(WebCore::Internals::shouldAudioTrackPlay):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• fast/mediastream/play-newly-added-audio-track-expected.txt: Added.
• fast/mediastream/play-newly-added-audio-track.html: Added.

11:14 AM Changeset in webkit [260379] by youenn@apple.com

• 9 edits in trunk/Source/WebCore

Use a WeakHashSet to store MediaStreamPrivate observers
​https://bugs.webkit.org/show_bug.cgi?id=210494

Reviewed by Eric Carlson.

Remove observers from the MediaStream and migrate existing client (MediaRecorder) to MediaStreamPrivate::Observer.
Make use of WeakHashSet in MediaStreamPrivate to improve robustness of the code.
Any time the MediaStreamPrivate tracks are modified, observers will be notified.
MediaStream needs now to decide when to send an event when its MediaStreamPrivate notifies of new/deleted tracks,
Modernize a bit the code to use more references.
Covered by existing tests.

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::~MediaRecorder):
(WebCore::MediaRecorder::handleTrackChange):

• Modules/mediarecorder/MediaRecorder.h:
• Modules/mediastream/MediaStream.cpp:

(WebCore::createTrackPrivateVector):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::didAddTrack):
(WebCore::MediaStream::didRemoveTrack):
(WebCore::MediaStream::addTrackFromPlatform):
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::internalTakeTrack):

• Modules/mediastream/MediaStream.h:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::removeRemoteTrack):

• platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::addObserver):
(WebCore::MediaStreamPrivate::removeObserver):
(WebCore::MediaStreamPrivate::forEachObserver):
(WebCore::MediaStreamPrivate::computeActiveState):
(WebCore::MediaStreamPrivate::updateActiveState):
(WebCore::MediaStreamPrivate::addTrack):
(WebCore::MediaStreamPrivate::removeTrack):
(WebCore::MediaStreamPrivate::trackEnded):

• platform/mediastream/MediaStreamPrivate.h:
• testing/Internals.cpp:

(WebCore::Internals::removeMediaStreamTrack):

11:11 AM Changeset in webkit [260378] by Alan Bujtas

• 2 edits in trunk/LayoutTests

fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=210754

Unreviewed test gardening.

Let's not use subframe layout in LFC tests for now.

• fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html:

11:06 AM Changeset in webkit [260377] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Fix CheckIsConstant for non-constant values and checking for empty
​https://bugs.webkit.org/show_bug.cgi?id=210752

Reviewed by Saam Barati.

We need to make sure that we only have one speculated type if our value
is empty.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

11:04 AM Changeset in webkit [260376] by Alan Coon

• 1 copy in branches/safari-610.1.11-branch

New branch.

11:02 AM Changeset in webkit [260375] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: removing a WI.TreeElement in a WI.NavigationSidebar doesn't check if the WI.TreeOutline still matches the current filter
​https://bugs.webkit.org/show_bug.cgi?id=210672

Reviewed by Joseph Pecoraro.

• UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype.createContentTreeOutline):
(WI.NavigationSidebarPanel.prototype.updateFilter):
(WI.NavigationSidebarPanel.prototype._checkForEmptyFilterResults):
(WI.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
(WI.NavigationSidebarPanel.prototype._handleTreeElementRemoved): Added.

10:59 AM Changeset in webkit [260374] by Alan Coon

• 8 edits in trunk/Source

Versioning.

10:48 AM Changeset in webkit [260373] by Chris Dumez

• 6 edits in trunk/Source/WebKit

[iOS] Refactor WebKit media playback process assertion logic to minimize chances of leaking them
​https://bugs.webkit.org/show_bug.cgi?id=210670

Reviewed by Geoffrey Garen.

Refactor WebKit media playback process assertion logic to minimize chances of leaking them. In particular,
the following changes were made:

1. Instead of the WebProcessPool having a HashMap of media playback process assertions for the WebProcess, we now store the assertion on the WebProcessProxy object itself. This is less likely to get out of sync and leak.
2. Add a RefCounter to the WebProcessPool to count WebProcesses that have audible media. Whenever a WebProcess starts or stops playing audible media, it merely grabs a RefCounter token or releases it. The WebProcessPool relies on this counter to decide whether or not to take a media playback assertion on behalf of the UIProcess. Since this is token-based and the token is stored on the WebProcessProxy object, it makes it less likely to leak the assertion.
3. The WebProcessProxy object now has a AudibleMediaActivity data structure wrapping both its media playback assertion and its WebProcessWithAudibleMediaToken that it got from the WebProcessPool. When the WebProcess shuts down (normally or due to crash/termination), we make sure to clear this data structure.
4. Make sure that the WebProcessProxy updates its AudibleMediaActivity whenever a page is removed from the WebProcess.

• UIProcess/WebPageProxy.cpp:
• UIProcess/WebProcessPool.cpp:

(WebKit::m_webProcessWithAudibleMediaCounter):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::webProcessWithAudibleMediaToken const):
(WebKit::WebProcessPool::updateAudibleMediaAssertions):

• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::removeWebPage):
(WebKit::WebProcessProxy::updateAudibleMediaAssertions):

• UIProcess/WebProcessProxy.h:

10:15 AM Changeset in webkit [260372] by Kate Cheney

• 2 edits in trunk/Source/WebKit

<rdar://problem/62059046>

Unreviewed macCatalyst build fix.

• NetworkProcess/NetworkProcess.messages.in:

10:14 AM Changeset in webkit [260371] by Simon Fraser

• 3 edits
  4 adds in trunk

Content disappears on CSS parallax example
​https://bugs.webkit.org/show_bug.cgi?id=210732
Source/WebCore:

<rdar://problem/61997636>

Reviewed by Darin Adler.

If scrolling affects the computation of coverage rect of a TiledBacking, we plumb
that expanded coverage back into TransformState which is maintained during GraphicsLayer flushing,
and it's used to compute coverage rect for descendants.

It's passed into TransformState::setLastPlanarSecondaryQuad(), which has to map it back into
the coordinate system of the last flattening ancestor. However, TransformState::mapQuad()
had a missing return and the quad mapping was wrong. The new code is now the same as
TransformState::mappedPoint() (you can see where the copy/paste error came from).

Test: compositing/tiling/coverage-adjustment-secondary-quad-mapping.html

• platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::mapQuad const):
(WebCore::TransformState::flattenWithTransform):

LayoutTests:

Reviewed by Darin Adler.

• compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt: Added.
• compositing/tiling/coverage-adjustment-secondary-quad-mapping.html: Added.
• platform/ios-wk2/compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt: Added.
• platform/mac-wk1/compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt: Added.

9:54 AM Changeset in webkit [260370] by Russell Epstein

• 3 edits in branches/safari-609-branch

Apply patch. rdar://problem/62062357

9:23 AM Changeset in webkit [260369] by Russell Epstein

• 20 edits in branches/safari-609-branch

Apply patch. rdar://problem/61950472

9:16 AM Changeset in webkit [260368] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][TFC] Add support for border-collapse: collapse.
​https://bugs.webkit.org/show_bug.cgi?id=210747

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-flex-width-border-collapse.html

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::ensureTableGrid):

LayoutTests:

• fast/layoutformattingcontext/table-flex-width-border-collapse.html: Added.

8:53 AM Changeset in webkit [260367] by Wenson Hsieh

• 24 edits
  2 adds
  1 delete in trunk

Oversized caret and selection rects in text fields on ganji.com and netflix.com/login
​https://bugs.webkit.org/show_bug.cgi?id=210622
<rdar://problem/45945636>

Reviewed by Darin Adler.

Source/WebCore:

Currently, selection and caret rects in text fields on some web pages can be excessively tall. This patch makes
a small adjustment to allow the top of the caret or selection rect to snap to the top of the inline box instead
of being at the end of the previous line, in the case where there is no previous inline box.

In the case where we compute the caret rect for an empty renderer (i.e. no children), we make an additional
tweak so that the caret rect's height is based on the computed font height instead of line height, and then we
ensure that the caret is (logically) vertically centered.

See below for more details.

Test: editing/selection/selection-and-caret-do-not-extend-to-line-height.html

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):

Specify ForHitTesting::Yes when asking for selectionTop().

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):

Use FontMetric's height when computing the height of the caret rect, and then center it vertically in the
renderer.

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint):

Specify ForHitTesting::Yes when asking for selectionTop(). See below for more information.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::positionForPoint const):

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop const):

When computing selectionTop(), we currently fall back to using the top of the containing RenderBlockFlow
(blockFlow().borderAndPaddingBefore()) in the case where there is no previous root box. However, this can lead
to selection and caret rects being taller than expected; instead, we can use the max of the selectionTop
(that is, the top of the line box, adjusted for annotations) and the top of the RenderBlockFlow. This has the
effect of allowing the caret and selection to visually snap to the top of a run of text, provided there is not
already a line of text that precedes it. Taking the maximum of the two values ensures that we don't
unintentionally make the selection or caret rects even larger, if the line top is above the top of the block.

Note that we also avoid shrinking the selection and caret rects when hit-testing renderers for positions and
ranges. This allows users to still click and drag to select text in the extra line-height area above a piece of
text, even if the selection is only painted over the text (and not in the region containing the line-height).
This behavior was established in the fix for webkit.org/b/14911, and is covered by the layout test
editing/selection/inline-closest-leaf-child.html.

• rendering/RootInlineBox.h:

Tools:

Rebaseline some expected selection and caret rects in some iOS API tests.

• TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:

(TEST):

• TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:

(TestWebKitAPI::TEST):

LayoutTests:

Rebaseline existing tests, and add a new test to verify that caret and selection rects do not extend to match
the line height in empty and non-empty editable elements, in both horizontal and vertical writing modes.

• editing/selection/ios/absolute-selection-after-scroll-expected.txt:
• editing/selection/ios/absolute-selection-after-scroll.html:
• editing/selection/ios/change-selection-after-tapping-focused-element-expected.txt:
• editing/selection/ios/change-selection-after-tapping-focused-element.html:
• editing/selection/ios/fixed-selection-after-scroll-expected.txt:
• editing/selection/ios/fixed-selection-after-scroll.html:
• editing/selection/ios/selection-after-changing-text-with-callout-menu-expected.txt:
• editing/selection/ios/selection-after-changing-text-with-callout-menu.html:
• editing/selection/ios/selection-handles-after-touch-end-expected.txt:
• editing/selection/ios/update-selection-after-overflow-scroll-expected.txt:
• editing/selection/ios/update-selection-after-overflow-scroll.html:
• editing/selection/selection-and-caret-do-not-extend-to-line-height-expected.txt: Added.
• editing/selection/selection-and-caret-do-not-extend-to-line-height.html: Added.
• fast/repaint/focus-ring-repaint-expected.txt:
• platform/ios/editing/selection/ios/selection-handles-after-touch-end-expected.txt: Removed.

Delete this redundant test expectation.

8:32 AM Changeset in webkit [260366] by Darin Adler

• 471 edits
  2 deletes in trunk

Use #import instead of #include in Objective-C and don't use #pragma once
​https://bugs.webkit.org/show_bug.cgi?id=210724

Reviewed by David Kilzer.

Source/JavaScriptCore:

• API/JSAPIWrapperObject.mm:
• API/JSContext.h:
• API/JSContext.mm:
• API/JSScriptInternal.h:
• API/JSValue.mm:
• API/JSVirtualMachine.mm:
• API/JSVirtualMachinePrivate.h:
• API/JSWrapperMap.mm:
• API/ObjCCallbackFunction.mm:
• API/tests/CurrentThisInsideBlockGetterTest.mm:

More #import, less #pragma once.

Source/WebCore:

• page/cocoa/SettingsBaseCocoa.mm:

(WebCore::sansSerifTraditionalHanFontFamily): Deleted.
(WebCore::sansSerifSimplifiedHanFontFamily): Deleted.
(WebCore::SettingsBase::initializeDefaultFontFamilies): Just use font name
strings directly since there are no conditionals any more.

• Modules/applepay/PaymentRequestValidator.mm:
• Modules/applepay/cocoa/PaymentContactCocoa.mm:
• accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
• accessibility/mac/AXObjectCacheMac.mm:
• accessibility/mac/WebAccessibilityObjectWrapperBase.h:
• accessibility/mac/WebAccessibilityObjectWrapperMac.h:
• bridge/objc/WebScriptObjectPrivate.h:
• bridge/objc/objc_class.mm:
• bridge/testbindings.mm:
• crypto/mac/SerializedCryptoKeyWrapMac.mm:
• editing/cocoa/WebArchiveResourceFromNSAttributedString.h:
• editing/cocoa/WebArchiveResourceWebResourceHandler.h:
• editing/cocoa/WebContentReaderCocoa.mm:
• history/mac/HistoryItemMac.mm:
• loader/cocoa/DiskCacheMonitorCocoa.mm:
• loader/cocoa/SubresourceLoaderCocoa.mm:
• loader/mac/ResourceLoaderMac.mm:
• page/cocoa/MemoryReleaseCocoa.mm:
• page/cocoa/ResourceUsageOverlayCocoa.mm:
• page/cocoa/ResourceUsageThreadCocoa.mm:
• page/ios/WebEventRegion.h:
• page/mac/ChromeMac.mm:
• page/mac/EventHandlerMac.mm:
• page/mac/WheelEventDeltaFilterMac.mm:
• page/scrolling/cocoa/ScrollingStateNode.mm:
• page/scrolling/mac/ScrollingCoordinatorMac.mm:
• page/scrolling/mac/ScrollingMomentumCalculatorMac.mm:
• page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
• page/scrolling/mac/ScrollingThreadMac.mm:
• page/scrolling/mac/ScrollingTreeMac.mm:
• platform/audio/cocoa/MediaSessionManagerCocoa.mm:
• platform/audio/mac/AudioSampleDataSource.mm:
• platform/cocoa/DataDetectorsCoreSoftLink.mm:
• platform/cocoa/PasteboardCocoa.mm:
• platform/cocoa/ScrollSnapAnimatorState.mm:
• platform/cocoa/SystemVersion.mm:
• platform/gamepad/cocoa/GameControllerGamepad.mm:
• platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
• platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
• platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
• platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
• platform/graphics/ca/cocoa/WebSystemBackdropLayer.h:
• platform/graphics/ca/cocoa/WebTiledBackingLayer.h:
• platform/graphics/ca/cocoa/WebVideoContainerLayer.h:
• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
• platform/graphics/cocoa/IOSurfacePoolCocoa.mm:
• platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
• platform/graphics/cocoa/WebGLLayer.h:
• platform/graphics/cocoa/WebGLLayer.mm:
• platform/graphics/cocoa/WebGPULayer.h:
• platform/graphics/cocoa/WebGPULayer.mm:
• platform/graphics/cv/ImageRotationSessionVT.mm:
• platform/graphics/cv/ImageTransferSessionVT.mm:
• platform/graphics/cv/TextureCacheCV.mm:
• platform/graphics/gpu/cocoa/GPUBufferMetal.mm:
• platform/graphics/gpu/cocoa/GPUComputePassEncoderMetal.mm:
• platform/graphics/mac/ComplexTextControllerCoreText.mm:
• platform/graphics/mac/FloatPointMac.mm:
• platform/graphics/mac/FloatSizeMac.mm:
• platform/graphics/mac/IntPointMac.mm:
• platform/graphics/mac/IntSizeMac.mm:
• platform/graphics/mac/WebLayer.h:
• platform/graphics/mac/WebLayer.mm:
• platform/ios/LegacyTileCache.mm:
• platform/ios/LegacyTileGrid.mm:
• platform/ios/LegacyTileGridTile.mm:
• platform/ios/LegacyTileLayer.h:
• platform/ios/LegacyTileLayer.mm:
• platform/ios/LegacyTileLayerPool.mm:
• platform/ios/LocalCurrentTraitCollection.mm:
• platform/ios/LocalizedDeviceModel.mm:
• platform/ios/ScrollbarThemeIOS.mm:
• platform/ios/WebCoreMotionManager.h:
• platform/ios/WebItemProviderPasteboard.mm:
• platform/ios/WebVideoFullscreenControllerAVKit.h:
• platform/mac/LocalCurrentGraphicsContext.mm:
• platform/mac/LocalDefaultSystemAppearance.mm:
• platform/mac/LoggingMac.mm:
• platform/mac/PlatformEventFactoryMac.mm:
• platform/mac/RemoteCommandListenerMac.mm:
• platform/mac/ScrollAnimatorMac.mm:
• platform/mac/SerializedPlatformDataCueMac.mm:
• platform/mac/WebCoreFullScreenPlaceholderView.mm:
• platform/mac/WebCoreFullScreenWarningView.h:
• platform/mac/WebCoreFullScreenWarningView.mm:
• platform/mac/WebCoreFullScreenWindow.h:
• platform/mac/WebCoreObjCExtras.mm:
• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
• platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm:
• platform/mediastream/ios/AVAudioSessionCaptureDevice.mm:
• platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
• platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
• platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm:
• platform/mediastream/mac/RealtimeVideoUtilities.mm:
• platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:
• platform/network/cocoa/CertificateInfoCocoa.mm:
• platform/network/cocoa/WebCoreNSURLSession.h:
• platform/network/mac/BlobDataFileReferenceMac.mm:
• platform/network/mac/CredentialStorageMac.mm:
• platform/network/mac/SynchronousLoaderClient.mm:
• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
• platform/text/cocoa/LocaleCocoa.mm:
• testing/ServiceWorkerInternals.mm:
• testing/cocoa/WebViewVisualIdentificationOverlay.h:

More #import, less #pragma once.

Source/WebCore/PAL:

• pal/cocoa/AppSSOSoftLink.mm:
• pal/cocoa/FileSizeFormatterCocoa.mm:
• pal/cocoa/UsageTrackingSoftLink.mm:
• pal/ios/ManagedConfigurationSoftLink.mm:
• pal/ios/UIKitSoftLink.mm:
• pal/mac/LookupSoftLink.mm:
• pal/spi/cocoa/AVFoundationSPI.h:
• pal/spi/cocoa/AccessibilitySupportSoftLink.cpp:
• pal/spi/cocoa/AppSSOSPI.h:
• pal/spi/cocoa/AuthKitSPI.h:
• pal/spi/cocoa/DataDetectorsCoreSPI.h:
• pal/spi/cocoa/LaunchServicesSPI.h:
• pal/spi/cocoa/NSAccessibilitySPI.h:
• pal/spi/cocoa/NSAttributedStringSPI.h:
• pal/spi/cocoa/NSProgressSPI.h:
• pal/spi/cocoa/NSURLDownloadSPI.h:
• pal/spi/cocoa/NSUserDefaultsSPI.h:
• pal/spi/cocoa/NSXPCConnectionSPI.h:
• pal/spi/cocoa/PassKitSPI.h:
• pal/spi/cocoa/SecKeyProxySPI.h:
• pal/spi/ios/CelestialSPI.h:
• pal/spi/mac/DataDetectorsSPI.h:
• pal/spi/mac/NSColorWellSPI.h:
• pal/spi/mac/NSGraphicsSPI.h:
• pal/spi/mac/NSPopoverColorWellSPI.h:
• pal/spi/mac/NSScrollerImpSPI.h:

More #import, less #pragma once.

Source/WebKit:

• mac/MigrateHeadersFromWebKitLegacy.make: Delete stale MemoryMeasure.h

forwarding header from incremental WebKit builds and ignore when generating
new forwarding headers.

• Platform/foundation/LoggingFoundation.mm:

(WebKit::logLevelString): Use string directly instead of a named constant.

• UIProcess/mac/WebColorPickerMac.h: Mark class final.

• GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
• NetworkProcess/WebStorage/ios/LocalStorageDatabaseTrackerIOS.mm:
• NetworkProcess/cache/NetworkCacheDataCocoa.mm:
• NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
• NetworkProcess/cocoa/NetworkActivityTrackerCocoa.mm:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:
• NetworkProcess/webrtc/NetworkRTCProvider.mm:
• Platform/spi/Cocoa/DeviceManagementSPI.h:
• Platform/spi/Cocoa/LocalAuthenticationSPI.h:
• Platform/spi/Cocoa/NearFieldSPI.h:
• Platform/spi/Cocoa/SafeBrowsingSPI.h:
• Platform/spi/mac/AppKitSPI.h:
• Shared/API/Cocoa/RemoteObjectInvocation.mm:
• Shared/API/Cocoa/WKMain.mm:
• Shared/APIWebArchive.mm:
• Shared/APIWebArchiveResource.mm:
• Shared/Authentication/cocoa/AuthenticationChallengeDispositionCocoa.mm:
• Shared/Cocoa/LoadParametersCocoa.mm:
• Shared/Cocoa/SandboxInitialiationParametersCocoa.mm:
• Shared/Cocoa/WKNSData.mm:
• Shared/DocumentEditingContext.mm:
• Shared/Plugins/mac/PluginSandboxProfile.mm:
• Shared/RemoteLayerTree/WKAnimationDelegate.h:
• Shared/UserInterfaceIdiom.mm:
• Shared/ios/WebIconUtilities.mm:
• Shared/mac/CodeSigning.mm:
• Shared/mac/ColorSpaceData.mm:
• Shared/mac/HangDetectionDisablerMac.mm:
• Shared/mac/PDFKitImports.mm:
• UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm:
• UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm:
• UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:
• UIProcess/API/Cocoa/WKContentRuleList.mm:
• UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:
• UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
• UIProcess/API/Cocoa/WKPreviewActionItemIdentifiers.mm:
• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h:
• UIProcess/API/Cocoa/_WKApplicationManifest.h:
• UIProcess/API/Cocoa/_WKAttachment.h:
• UIProcess/API/Cocoa/_WKResourceLoadInfoInternal.h:
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstPartyInternal.h:
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdPartyInternal.h:
• UIProcess/API/Cocoa/_WKTextManipulationExclusionRule.mm:
• UIProcess/API/Cocoa/_WKUserContentFilter.mm:
• UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponseInternal.h:
• UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h:
• UIProcess/Authentication/mac/WebCredentialMac.mm:
• UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm:
• UIProcess/Cocoa/IconLoadingDelegate.mm:
• UIProcess/Cocoa/MediaUtilities.mm:
• UIProcess/Cocoa/PreferenceObserver.h:
• UIProcess/Cocoa/PreferenceObserver.mm:
• UIProcess/Cocoa/SOAuthorization/NavigationSOAuthorizationSession.mm:
• UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.h:
• UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
• UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.h:
• UIProcess/Cocoa/WKEditCommand.h:
• UIProcess/Cocoa/WKFullKeyboardAccessWatcher.h:
• UIProcess/Cocoa/WebPageProxyCocoa.mm:
• UIProcess/Gamepad/cocoa/UIGamepadProviderCocoa.mm:
• UIProcess/Inspector/mac/WKInspectorViewController.h:
• UIProcess/Inspector/mac/WKInspectorWKWebView.h:
• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
• UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:
• UIProcess/RemoteLayerTree/mac/ScrollerPairMac.mm:
• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
• UIProcess/WebAuthentication/Cocoa/WKNFReaderSessionDelegate.h:
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
• UIProcess/ios/WKDeferringGestureRecognizer.h:
• UIProcess/ios/WKHighlightLongPressGestureRecognizer.h:
• UIProcess/ios/WebDataListSuggestionsDropdownIOS.h:
• UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
• UIProcess/ios/forms/WKDatePickerViewController.h:
• UIProcess/ios/forms/WKDatePickerViewController.mm:
• UIProcess/ios/forms/WKFocusedFormControlView.h:
• UIProcess/ios/forms/WKFocusedFormControlView.mm:
• UIProcess/ios/forms/WKFormColorPicker.mm:
• UIProcess/ios/forms/WKNumberPadViewController.h:
• UIProcess/ios/forms/WKNumberPadViewController.mm:
• UIProcess/ios/forms/WKQuickboardListViewController.h:
• UIProcess/ios/forms/WKQuickboardListViewController.mm:
• UIProcess/ios/forms/WKSelectMenuListViewController.h:
• UIProcess/ios/forms/WKTimePickerViewController.h:
• UIProcess/ios/forms/WKTimePickerViewController.mm:
• UIProcess/ios/fullscreen/WKFullScreenViewController.h:
• UIProcess/ios/fullscreen/WKFullscreenStackView.h:
• UIProcess/ios/fullscreen/WKFullscreenStackView.mm:
• UIProcess/mac/PageClientImplMac.mm:
• UIProcess/mac/WKSharingServicePickerDelegate.h:
• WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
• WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.h:
• WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
• WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.cpp:
• WebProcess/WebPage/WKAccessibilityWebPageObjectIOS.h:
• WebProcess/WebPage/mac/PageBannerMac.mm:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.h:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.h:
• WebProcess/cocoa/WebProcessCocoa.mm:

More #import, less #pragma once.

Source/WebKitLegacy:

• WebKitLegacy.xcodeproj/project.pbxproj: Removed MemoryMeasure.h/mm.

Source/WebKitLegacy/ios:

• Misc/MemoryMeasure.h: Removed.
• Misc/MemoryMeasure.mm: Removed.
• WebKit.iOS.exp: Removed MemoryMeasure symbols.

Source/WebKitLegacy/mac:

• Configurations/WebKitLegacy.xcconfig: Removed MemoryMeasure.h from

EXCLUDED_SOURCE_FILE_NAMES.

• Misc/WebCache.mm:

(+[WebCache emptyInMemoryResources]): Removed invocation of MemoryMeasure.
This is no longer used for anything.

• History/BackForwardList.mm:
• Plugins/Hosted/ProxyRuntimeObject.mm:
• Plugins/Hosted/WebHostedNetscapePluginView.mm:
• WebCoreSupport/SearchPopupMenuMac.mm:
• WebCoreSupport/WebAlternativeTextClient.mm:
• WebCoreSupport/WebSecurityOriginInternal.h:
• WebInspector/WebInspector.mm:
• WebView/WebFramePrivate.h:
• WebView/WebScriptWorld.h:
• WebView/WebView.mm:

More #import, less #pragma once.

Source/WTF:

• wtf/cocoa/Entitlements.mm:
• wtf/cocoa/FileSystemCocoa.mm:
• wtf/cocoa/MainThreadCocoa.mm:
• wtf/cocoa/SystemTracingCocoa.cpp:
• wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
• wtf/mac/SchedulePairMac.mm:
• wtf/text/cocoa/StringCocoa.mm:
• wtf/text/cocoa/TextStreamCocoa.mm:

More #import.

Tools:

• DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
• DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
• DumpRenderTree/mac/AccessibilityCommonMac.h:
• DumpRenderTree/mac/DumpRenderTreeMain.mm:
• TestRunnerShared/cocoa/ClassMethodSwizzler.mm:
• TestRunnerShared/cocoa/InstanceMethodSwizzler.mm:
• TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
• TestRunnerShared/mac/NSPasteboardAdditions.h:
• TestRunnerShared/spi/AppKitTestSPI.h:
• TestRunnerShared/spi/PencilKitTestSPI.h:
• TestWebKitAPI/DataDetectorsCoreSPI.h:
• TestWebKitAPI/EditingTestHarness.h:
• TestWebKitAPI/EditingTestHarness.mm:
• TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
• TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
• TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
• TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
• TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm:
• TestWebKitAPI/Tests/WebKit/AccessibilityRemoteUIApp.mm:
• TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm:
• TestWebKitAPI/Tests/WebKit/Battery.mm:
• TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
• TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
• TestWebKitAPI/Tests/WebKit/FindMatches.mm:
• TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm:
• TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
• TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm:
• TestWebKitAPI/Tests/WebKit/MimeTypes.mm:
• TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
• TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
• TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm:
• TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
• TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
• TestWebKitAPI/Tests/WebKit/ViewportSizeForViewportUnits.mm:
• TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
• TestWebKitAPI/Tests/WebKit/WebFilter.mm:
• TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
• TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
• TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.h:
• TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
• TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter_Bundle.mm:
• TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
• TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
• TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
• TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
• TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CookieAcceptPolicy.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm:
• TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
• TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
• TestWebKitAPI/Tests/WebKitCocoa/DeviceManagementRestrictions.mm:
• TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
• TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FindInPageAPI.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
• TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
• TestWebKitAPI/Tests/WebKitCocoa/JavaScriptDuringNavigation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm:
• TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
• TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
• TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm:
• TestWebKitAPI/Tests/WebKitCocoa/MediaType.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ObservedRenderingProgressEventsAfterCrash.mm:
• TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
• TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PageZoom.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimerDoesntFireEarly.mm:
• TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ShouldGoToBackForwardListItem.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
• TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm:
• TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
• TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h:
• TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm:
• TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
• TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
• TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
• TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
• TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
• TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
• TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
• TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm:
• TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
• TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
• TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm:
• TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
• TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
• TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
• TestWebKitAPI/Tests/ios/SelectionByWord.mm:
• TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
• TestWebKitAPI/Tests/ios/TestInputDelegate.h:
• TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
• TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
• TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
• TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
• TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
• TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm:
• TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
• TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm:
• TestWebKitAPI/Tests/mac/BackForwardList.mm:
• TestWebKitAPI/Tests/mac/BackgroundColor.mm:
• TestWebKitAPI/Tests/mac/CandidateTests.mm:
• TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
• TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
• TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
• TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
• TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
• TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
• TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
• TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
• TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
• TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
• TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
• TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
• TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm:
• TestWebKitAPI/Tests/mac/TypingStyleCrash.mm:
• TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
• TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm:
• TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
• TestWebKitAPI/cocoa/DragAndDropSimulator.h:
• TestWebKitAPI/cocoa/NSItemProviderAdditions.h:
• TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
• TestWebKitAPI/cocoa/TestContextMenuDriver.h:
• TestWebKitAPI/cocoa/TestNavigationDelegate.h:
• TestWebKitAPI/cocoa/TestProtocol.mm:
• TestWebKitAPI/cocoa/TestUIDelegate.h:
• TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
• TestWebKitAPI/ios/PencilKitTestSPI.h:
• TestWebKitAPI/mac/JavaScriptTestMac.mm:
• TestWebKitAPI/mac/NSFontPanelTesting.h:
• TestWebKitAPI/mac/NSFontPanelTesting.mm:
• TestWebKitAPI/mac/OffscreenWindow.h:
• TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
• TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
• TestWebKitAPI/mac/TestDraggingInfo.h:
• TestWebKitAPI/mac/TestFilePromiseReceiver.h:
• TestWebKitAPI/mac/TestFontOptions.h:
• TestWebKitAPI/mac/TestInspectorBar.h:
• TestWebKitAPI/mac/WebKitAgnosticTest.mm:
• WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
• WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
• WebKitTestRunner/mac/PoseAsClass.mm:

More #import, less #pragma once.

8:24 AM Changeset in webkit [260365] by Diego Pino Garcia

• 2 edits in trunk/Tools

[Flatpak SDK] Prevent exception when calling git in a non-git repository
​https://bugs.webkit.org/show_bug.cgi?id=210737

Reviewed by Philippe Normand.

• flatpak/flatpakutils.py:

(WebkitFlatpak.is_branch_build): Return false if command executes in a
non-git repository (i.e SVN).

7:37 AM Changeset in webkit [260364] by youenn@apple.com

• 9 edits
  8 adds in trunk

Safari doesn't apply frameRate limit when request stream from Camera
​https://bugs.webkit.org/show_bug.cgi?id=210186
<rdar://problem/61452794>

Reviewed by Eric Carlson.

Source/WebCore:

Add support to RealtimeVideoSource to decimate the video samples based on the observed frame rate of its capture source.
This allows supporting two tracks using the same capture device, one track being low frame rate and the other one high frame rate.

Clean-up refactoring to make RealtimeVideoSource directly inherit from RealtimeVideoCaptureSource.
Migrate size and format of frame adaptation from RealtimeVideoCaptureSource to RealtimeVideoSource.
Fix mock capture source to update its frame rate when asked by applyConstraints.

Tests: fast/mediastream/mediastreamtrack-video-frameRate-clone-decreasing.html

fast/mediastream/mediastreamtrack-video-frameRate-clone-increasing.html
fast/mediastream/mediastreamtrack-video-frameRate-decreasing.html
fast/mediastream/mediastreamtrack-video-frameRate-increasing.html

• platform/mediastream/RealtimeVideoCaptureSource.cpp:

(WebCore::RealtimeVideoCaptureSource::dispatchMediaSampleToObservers):
(WebCore::RealtimeVideoCaptureSource::clientUpdatedSizeAndFrameRate):

• platform/mediastream/RealtimeVideoCaptureSource.h:

(WebCore::RealtimeVideoCaptureSource::observedFrameRate const):

• platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::RealtimeVideoSource):
(WebCore::m_source):
(WebCore::RealtimeVideoSource::adaptVideoSample):
(WebCore::RealtimeVideoSource::videoSampleAvailable):

• platform/mediastream/RealtimeVideoSource.h:
• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::setFrameRateWithPreset):

• testing/Internals.cpp:

(WebCore::Internals::observeMediaStreamTrack):

LayoutTests:

• fast/mediastream/mediastreamtrack-video-frameRate-clone-decreasing-expected.txt: Added.
• fast/mediastream/mediastreamtrack-video-frameRate-clone-decreasing.html: Added.
• fast/mediastream/mediastreamtrack-video-frameRate-clone-increasing-expected.txt: Added.
• fast/mediastream/mediastreamtrack-video-frameRate-clone-increasing.html: Added.
• fast/mediastream/mediastreamtrack-video-framerate-decreasing-expected.txt: added.
• fast/mediastream/mediastreamtrack-video-framerate-decreasing.html: added.
• fast/mediastream/mediastreamtrack-video-framerate-increasing-expected.txt: added.
• fast/mediastream/mediastreamtrack-video-framerate-increasing.html: added.
• webrtc/routines.js:

5:29 AM Changeset in webkit [260363] by Philippe Normand

• 2 edits in trunk/Tools

[Flatpak SDK] Drive-by fixes
​https://bugs.webkit.org/show_bug.cgi?id=210557

Reviewed by Žan Doberšek.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): Properly format error message.
(WebkitFlatpak.main): Show flatpak update output.

5:10 AM Changeset in webkit [260362] by keith_miller@apple.com

• 2 edits in trunk/JSTests

Unreviewed, revert accidental test changes.

• microbenchmarks/for-of-iterate-array-entries.js:

(foo):

5:01 AM Changeset in webkit [260361] by commit-queue@webkit.org

• 2 edits in trunk/JSTests

[32-bits] stress/for-of-array-different-globals.js is failing
​https://bugs.webkit.org/show_bug.cgi?id=210718

Unreviewed gardening.

Skip test for arm and mips, failing due to r260323

Patch by Paulo Matos <Paulo Matos> on 2020-04-20

• stress/for-of-array-different-globals.js:

4:56 AM Changeset in webkit [260360] by graouts@webkit.org

• 3 edits
  2 adds in trunk

WebAnimations API doesn't properly apply keyframe easings to transforms
​https://bugs.webkit.org/show_bug.cgi?id=210526
<rdar://problem/61800424>

Reviewed by Antti Koivisto.

Source/WebCore:

GraphicsLayerCA has code that determines whether an animation can be accelerated looking at the timing function of its keyframes and excluding
animations that use a steps timing function as one of its values. However, we we would fail to set the timing function on the KeyframeValue for
each keyframe in the KeyframeList we create for a JS-originated animation. We now do this correctly.

Test: webanimations/transform-animation-with-steps-timing-function-not-accelerated.html

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::updateBlendingKeyframes):

LayoutTests:

Add a new test that checks that an animation targeting an accelerted property does not yield an accelerated animation if one of its keyframes contains a steps timing function.

• webanimations/transform-animation-with-steps-timing-function-not-accelerated-expected.txt: Added.
• webanimations/transform-animation-with-steps-timing-function-not-accelerated.html: Added.

3:22 AM Changeset in webkit [260359] by Pablo Saavedra

• 2 edits in trunk/Source/WebKit

[GTK][WPE] lowWatermarkPages() in MemoryPressureMonitor.cpp only searches the "low" value inside the first "Node" section
​https://bugs.webkit.org/show_bug.cgi?id=210345

Reviewed by Adrian Perez de Castro.

• UIProcess/linux/MemoryPressureMonitor.cpp:

(WebKit::lowWatermarkPages):

2:54 AM Changeset in webkit [260358] by ysuzuki@apple.com

• 13 edits in trunk

StructuredClone algorithm should be aware of BigInt
​https://bugs.webkit.org/show_bug.cgi?id=210728

Reviewed by Mark Lam.

LayoutTests/imported/w3c:

• web-platform-tests/IndexedDB/bigint_value-expected.txt:
• web-platform-tests/html/infrastructure/safe-passing-of-structured-data/structured_clone_bigint-expected.txt:

Source/JavaScriptCore:

• CMakeLists.txt:
• runtime/BigIntObject.h:
• runtime/JSBigInt.cpp:

(JSC::JSBigInt::digit): Deleted.
(JSC::JSBigInt::setDigit): Deleted.

• runtime/JSBigInt.h:

(JSC::JSBigInt::digit):
(JSC::JSBigInt::setDigit):

Source/WebCore:

This patch adds structured-cloning for BigInt and BigIntObject.
The logic is adding BigIntTag & BigIntObjectTag. And then we put content of BigInt with length.
And deserialization reads them to reconstruct BigInt or BigIntObject.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpImmediate):
(WebCore::CloneSerializer::dumpBigIntData):
(WebCore::CloneSerializer::dumpBigInt32Data):
(WebCore::CloneSerializer::dumpHeapBigIntData):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readBigInt):
(WebCore::CloneDeserializer::readTerminal):

LayoutTests:

• inspector/model/remote-object/number-expected.txt:
• inspector/model/remote-object/object-expected.txt:

2:20 AM Changeset in webkit [260357] by svillar@igalia.com

• 2 edits in trunk/Tools

[WebXR][WPE] Let XR_RUNTIME_JSON environment variable go through for testing
​https://bugs.webkit.org/show_bug.cgi?id=210738

Reviewed by Žan Doberšek.

The OpenXR loader might be instructed to load a specific runtime by
using the XR_RUNTIME_JSON environment variable. Let it get in for testing.

• Scripts/webkitpy/port/wpe.py:

(WPEPort.setup_environ_for_server): Copy XR_RUNTIME_JSON if set.

1:33 AM Changeset in webkit [260356] by Carlos Garcia Campos

• 21 edits in trunk

[GTK][WPE] Enable resource load statistics
​https://bugs.webkit.org/show_bug.cgi?id=210184

Reviewed by Žan Doberšek.

.:

Enable resource load statistics.

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

Source/WebCore:

• platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::setCookiesFromDOM const): Return early if cookies are blocked and update the
persistent cookies expiration if needed.
(WebCore::NetworkStorageSession::deleteCookiesForHostnames): Implement this when receiving
IncludeHttpOnlyCookies parameter.
(WebCore::NetworkStorageSession::hasCookies const): Implement this.
(WebCore::NetworkStorageSession::getRawCookies const): Honor shouldAskITP parameter.
(WebCore::cookiesForSession): Ditto.
(WebCore::NetworkStorageSession::cookiesForDOM const): Ditto.
(WebCore::NetworkStorageSession::cookieRequestHeaderFieldValue const): Ditto.

Source/WebKit:

• NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::create): Pass page and frame identifiers to the constructor.
(WebKit::NetworkDataTask::isThirdPartyRequest const): Moved from NetworkDataTaskCocoa.mm.
(WebKit::NetworkDataTask::restrictRequestReferrerToOriginIfNeeded): Ditto.

• NetworkProcess/NetworkDataTask.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup): Initialize m_frameID and m_pageID.
(WebKit::NetworkDataTaskSoup::createRequest): Add WasBlockingCookies parameter. Call
restrictRequestReferrerToOriginIfNeeded() and disable cookies in the soup message if cookies should be blocked.
(WebKit::NetworkDataTaskSoup::clearRequest): Reset m_isBlockingCookies.
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Pass WasBlockingCookies to createRequest().

• NetworkProcess/soup/NetworkDataTaskSoup.h:
• UIProcess/API/C/WKPage.cpp:

(WKPageLoadedThirdPartyDomains): Added for tests.
(WKPageClearLoadedThirdPartyDomains): Ditto.

• UIProcess/API/C/WKPagePrivate.h:
• UIProcess/glib/WebsiteDataStoreGLib.cpp:

(WebKit::WebsiteDataStore::defaultResourceLoadStatisticsDirectory): Use lowercase for consistency with other
default directories.

Tools:

Implement TestController::loadedThirdPartyDomains() and TestController::clearLoadedThirdPartyDomains() for
non-cocoa ports.

• WebKitTestRunner/TestController.cpp:

(WTR::LoadedThirdPartyDomainsCallbackContext::LoadedThirdPartyDomainsCallbackContext):
(WTR::loadedThirdPartyDomainsCallback):
(WTR::TestController::loadedThirdPartyDomains):
(WTR::TestController::clearLoadedThirdPartyDomains):

LayoutTests:

Unskip tests that are now passing and add expectations for the two reminaing failures.

• http/tests/resourceLoadStatistics/loaded-registrable-domains-get-reported.html: Use setTimeout in onload

handler to avoid a deadlock due to sync injected bundle messages.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

1:25 AM Changeset in webkit [260355] by ddkilzer@apple.com

• 3 edits in trunk/Tools

check-webkit-style should not complain about missing config.h header in WebKitLegacy source files
<​https://webkit.org/b/210734>

Reviewed by Darin Adler.

• Scripts/webkitpy/style/checkers/cpp.py:

(_NO_CONFIG_H_PATH_PATTERNS):

• Add '^{Source/WebKitLegacy/' to the list.}
• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_primary_header):

• Add test for Source/WebKitLegacy source file.

12:11 AM Changeset in webkit [260354] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r259610): Leak of RBSAssertionInvalidationCallbackType due to missing -dealloc
<​https://webkit.org/b/210711>
<rdar://problem/61993361>

Reviewed by Geoffrey Garen.

• UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKRBSAssertionDelegate dealloc]): Add.

• Release _invalidationCallback to fix the leak.

Apr 19, 2020:

11:32 PM Changeset in webkit [260353] by Simon Fraser

• 6 edits in trunk/Source/WebCore

Use Optional<FloatQuad> in TransformState
​https://bugs.webkit.org/show_bug.cgi?id=144226

Reviewed by Sam Weinig.

Use Optional<> instead of pointers in TransformState, make it loggable, make FloatQuad loggable.

• platform/graphics/FloatQuad.cpp:

(WebCore::operator<<):

• platform/graphics/FloatQuad.h:
• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::computeVisibleAndCoverageRect const):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):

• platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::operator=):
(WebCore::TransformState::mappedSecondaryQuad const):
(WebCore::TransformState::setLastPlanarSecondaryQuad):
(WebCore::TransformState::flattenWithTransform):
(WebCore::operator<<):

• platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::setSecondaryQuad):
(WebCore::TransformState::lastPlanarSecondaryQuad const):
(WebCore::TransformState::isMappingSecondaryQuad const):
(WebCore::TransformState::accumulatedTransform const):

11:30 PM Changeset in webkit [260352] by ysuzuki@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed, skip imported/w3c/web-platform-tests/IndexedDB/structured-clone
​https://bugs.webkit.org/show_bug.cgi?id=210731#c4

Skipping this test based on the following rationales.

1. This test was previously *effectively* skipped because it is including BigInt syntax. This test immediately throws SyntaxError. So nothing in this test was executed before.
2. Now JSC supports BigInt syntax. Then, this test is now executed finally. And crash happens when deserializaing DOMMatrixReadOnly.
3. This is because DOMMatrixReadOnly requires JSDOMGlobalObject since DOMMatrixReadOnly is WebCore object, not JSC object.
4. However, IDBSerializationContext.cpp is using plain JSGlobalObject. This is not correct since it is JSC JSGlobalObject and it does not include DOMMatrix implementations.
5. So, nothing is related to BigInt here.

• TestExpectations:

11:20 PM Changeset in webkit [260351] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Remove unneeded code from FrameLoader::loadURL
​https://bugs.webkit.org/show_bug.cgi?id=210696

Patch by Rob Buis <​rbuis@igalia.com> on 2020-04-19
Reviewed by Darin Adler.

Remove unneeded code from FrameLoader::loadURL, since the only way the load type can be Reload
is if loadFrameRequest set it, and the only way loadFrameRequest can set it is if cachePolicy
is ReloadIgnoringCacheData, so no need to set it again in FrameLoader::loadURL.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):

10:55 PM Changeset in webkit [260350] by beidson@apple.com

• 37 edits
  1 add in trunk

Add WKScriptMessageHandler API that asynchronously responds with a promise.
rdar://problem/57243492 and ​https://bugs.webkit.org/show_bug.cgi?id=206398

Reviewed by Andy Estes.
Source/WebCore:

Covered by new API tests.

Updated for moving an #include into implementation files:

• bindings/js/JSDOMPromiseDeferred.cpp:
• bindings/js/JSDOMPromiseDeferred.h:
• html/HTMLMediaElement.cpp:
• page/DOMWindow.cpp:
• workers/service/ServiceWorkerGlobalScope.cpp:

• page/UserMessageHandler.cpp:

(WebCore::UserMessageHandler::postMessage): Return a promise to be fulfilled by the API client.

• page/UserMessageHandler.h:
• page/UserMessageHandler.idl:
• page/UserMessageHandlerDescriptor.h:

Source/WebKit:

Change webkit.messageHandlers.<name>.postMessage() to return a promise instead of undefined.

Allow for that promise to be resolved by an asynchronous reply block up in the API client.
This is like the spiritual opposite version of [WKWebView callAsyncFunction:...]

And while we're adding a new script message handler variant, we're adding it sandboxed by WKContentWorld.

• Shared/API/APISerializedScriptValue.h:
• UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:

(API::validateObject):
(API::coreValueFromNSObject):
(API::SerializedScriptValue::createFromNSObject):
(API::SerializedScriptValue::wireBytesFromNSObject): Deleted.

• UIProcess/API/Cocoa/WKScriptMessage.h: Now that script message handlers can be per-world, messages declare which world they were posted from.
• UIProcess/API/Cocoa/WKScriptMessage.mm:

(-[WKScriptMessage _initWithBody:webView:frameInfo:name:world:]):
(-[WKScriptMessage world]):
(-[WKScriptMessage _initWithBody:webView:frameInfo:name:]): Deleted.

• UIProcess/API/Cocoa/WKScriptMessageInternal.h:

• UIProcess/API/Cocoa/WKScriptMessageHandlerWithReply.h: Added. Declare the new protocol for a script message handler that can reply to messages asynchronously.

• UIProcess/API/Cocoa/WKUserContentController.h:
• UIProcess/API/Cocoa/WKUserContentController.mm:

(-[WKUserContentController _addScriptMessageHandler:]):
(-[WKUserContentController addScriptMessageHandler:name:]):
(-[WKUserContentController addScriptMessageHandler:contentWorld:name:]):
(-[WKUserContentController addScriptMessageHandlerWithReply:contentWorld:name:]):
(-[WKUserContentController removeScriptMessageHandlerForName:contentWorld:]):
(-[WKUserContentController removeAllScriptMessageHandlersFromContentWorld:]):
(-[WKUserContentController removeAllScriptMessageHandlers]):

• UIProcess/API/Cocoa/WKUserContentControllerInternal.h:
• UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _evaluateJavaScript:asAsyncFunction:withArguments:forceUserGesture:inFrame:inWorld:completionHandler:]):
Update for new shared API::SerializedScriptValue initialization.

• UIProcess/API/glib/WebKitUserContentManager.cpp:
• UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
• UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp:

• UIProcess/UserContent/WebScriptMessageHandler.h:
• UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::removeAllUserMessageHandlers):
(WebKit::WebUserContentControllerProxy::didPostMessage):

• UIProcess/UserContent/WebUserContentControllerProxy.h:
• UIProcess/UserContent/WebUserContentControllerProxy.messages.in:

• WebKit.xcodeproj/project.pbxproj:

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp:

(webkit_dom_dom_window_webkit_message_handlers_post_message):

• WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::removeAllUserScriptMessageHandlers):
(WebKit::WebUserContentController::removeAllUserScriptMessageHandlersForWorlds):

• WebProcess/UserContent/WebUserContentController.h:
• WebProcess/UserContent/WebUserContentController.messages.in:

Source/WTF:

• wtf/CompletionHandler.h:

(WTF::CompletionHandlerWithFinalizer<Out): Add a variant of CompletionHandler that allows for a Finalizer function

to handle cases where the Completion function hasn't been called at destruction time.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:

(TEST):
(webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
(-[AsyncScriptMessageHandler userContentController:didReceiveScriptMessage:replyHandler:]):

10:15 PM Changeset in webkit [260349] by Ross Kirsling

• 25 edits
  1 copy
  6 adds in trunk

[ECMA-402] Intl.RelativeTimeFormat missing in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=209770

Reviewed by Darin Adler.

JSTests:

• stress/intl-relativetimeformat.js: Added.

• test262/config.yaml:

Enable Intl.RelativeTimeFormat feature with flag.

• test262/expectations.yaml:

Mark known failures.
Test for locale validation is not specific to RelativeTimeFormat and should be investigated separately.
Tests for Polish appear to be wrong and should be corrected in test262.

Source/JavaScriptCore:

This patch implements the recent ECMA-402 feature Intl.RelativeTimeFormat.

RelativeTimeFormat has format / formatToParts functions like NumberFormat / DateTimeFormat
and is used to turn a number and unit into a formatted relative time string, e.g.:

new Intl.RelativeTimeFormat('en').format(10, 'day')

'in 10 days'

new Intl.RelativeTimeFormat('en', { numeric: 'auto' }).format(0, 'day')

'today'

Implementation of RelativeTimeFormat#formatToParts makes direct use of NumberFormat#formatToParts,
as the relative time string consists of at most one formatted number with optional literal text on either side.

This feature is runtime-guarded by the useIntlRelativeTimeFormat option.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• runtime/CommonIdentifiers.h:
• runtime/IntlRelativeTimeFormat.cpp: Added.
• runtime/IntlRelativeTimeFormat.h: Added.
• runtime/IntlRelativeTimeFormatConstructor.cpp: Added.
• runtime/IntlRelativeTimeFormatConstructor.h: Added.
• runtime/IntlRelativeTimeFormatPrototype.cpp: Added.
• runtime/IntlRelativeTimeFormatPrototype.h: Added.
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::relativeTimeFormatStructure):

• runtime/OptionsList.h:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

Add feature and runtime option.

• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::formatToParts):

• runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::initializePluralRules):
(JSC::IntlPluralRules::resolvedOptions):
Make "type" a property name.

• runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::resolvedOptions):
(JSC::IntlNumberFormat::formatToPartsInternal):
(JSC::IntlNumberFormat::formatToParts):

• runtime/IntlNumberFormat.h:

Factor out formatToPartsInternal so that RelativeTimeFormat can use it with its own UNumberFormat.
(This logic is too complicated to duplicate; it's because ICU won't split, e.g., "10,000" into parts for us.)

• runtime/IntlObject.cpp:

(JSC::IntlObject::IntlObject):
(JSC::IntlObject::create):
(JSC::IntlObject::finishCreation):
(JSC::intlAvailableLocales):
(JSC::intlCollatorAvailableLocales):
(JSC::isUnicodeLocaleIdentifierType):
(JSC::supportedLocales):
(JSC::intlDateTimeFormatAvailableLocales): Deleted.
(JSC::intlNumberFormatAvailableLocales): Deleted.

• runtime/IntlObject.h:

(JSC::intlDateTimeFormatAvailableLocales):
(JSC::intlNumberFormatAvailableLocales):
(JSC::intlPluralRulesAvailableLocales):
(JSC::intlRelativeTimeFormatAvailableLocales):
Perform three corrections for Intl classes:

1. Collator should be the only class with unique "available locales". [unum|udat]_getAvailable exist but they've deferred to uloc_getAvailable for 20 years.
2. isUnicodeLocaleIdentifierType isn't just alphanum{3,8} but rather alphanum{3,8} (sep alphanum{3,8})*. This is my own mistake from r239941.
3. supportedLocalesOf entries should not be frozen. Changed in ​https://github.com/tc39/ecma402/pull/278.

• tools/JSDollarVM.cpp:

(JSC::functionICUVersion):
(JSC::JSDollarVM::finishCreation):
Add $vm.icuVersion so that we can add per-line skips to stress tests.

Tools:

• Scripts/run-jsc-stress-tests:

Add runIntlRelativeTimeFormatEnabled.

8:46 PM Changeset in webkit [260348] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r244091): Leak of TaskStateChangedCallbackType due to missing -dealloc
<​https://webkit.org/b/210710>
<rdar://problem/61992856>

Reviewed by Darin Adler.

• Shared/Cocoa/ProcessTaskStateObserver.mm:

(-[WKProcessTaskStateObserverDelegate dealloc]): Add.

• Release _taskStateChangedCallback to fix the leak.

7:18 PM Changeset in webkit [260347] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

[IPC hardening] Use MESSAGE_CHECK in WebPageProxy::loadRecentSearches() and WebPageProxy::saveRecentSearches()
<​https://webkit.org/b/210683>
<rdar://problem/59240446>

Reviewed by Geoffrey Garen.

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(MESSAGE_CHECK): Add.
(MESSAGE_CHECK_COMPLETION): Add.
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

• Replace boolean check of const String& with MESSAGE_CHECK.

6:56 PM Changeset in webkit [260346] by ysuzuki@apple.com

• 3 edits in trunk/Source/JavaScriptCore

[JSC] SlowPathCall is not supported by callOperation in Windows
​https://bugs.webkit.org/show_bug.cgi?id=210727

Reviewed by Ross Kirsling.

In Windows, SlowPathCall should be handled by JITSlowPathCall, otherwise, stack is not correctly allocated.

• jit/JITCall.cpp:

(JSC::JIT::emit_op_iterator_open):
(JSC::JIT::emit_op_iterator_next):

• jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

5:59 PM Changeset in webkit [260345] by ysuzuki@apple.com

• 4 edits in trunk/Source

[JSC] Enable BigInt
​https://bugs.webkit.org/show_bug.cgi?id=210726

Reviewed by Mark Lam.

Source/JavaScriptCore:

• runtime/OptionsList.h:

Source/WTF:

• wtf/PlatformUse.h:

4:53 PM Changeset in webkit [260344] by ysuzuki@apple.com

• 5 edits in trunk/Source/JavaScriptCore

[JSC] LLInt slow path call should not have third argument
​https://bugs.webkit.org/show_bug.cgi?id=210721

Reviewed by Mark Lam.

LLInt callSlowPath does not work with third argument in Windows, CLoop etc. LLInt slow-path should not take third argument,
instead, use bytecode.metadata(...) to get metadata.

• jit/JITCall.cpp:

(JSC::JIT::emit_op_iterator_open):
(JSC::JIT::emit_op_iterator_next):

• llint/LowLevelInterpreter64.asm:
• runtime/CommonSlowPaths.cpp:

(JSC::iterator_open_try_fast):
(JSC::SLOW_PATH_DECL):
(JSC::iterator_next_try_fast):
(JSC::iterator_open_try_fast_narrow): Deleted.
(JSC::iterator_open_try_fast_wide16): Deleted.
(JSC::iterator_open_try_fast_wide32): Deleted.
(JSC::iterator_next_try_fast_narrow): Deleted.
(JSC::iterator_next_try_fast_wide16): Deleted.
(JSC::iterator_next_try_fast_wide32): Deleted.

• runtime/CommonSlowPaths.h:

2:18 PM Changeset in webkit [260343] by mark.lam@apple.com

• 6 edits in trunk/Source/JavaScriptCore

Fix missing exception checks and handling in JSC APIs.
​https://bugs.webkit.org/show_bug.cgi?id=210715
<rdar://problem/61599658>

Reviewed by Saam Barati.

• API/APICallbackFunction.h:

(JSC::APICallbackFunction::call):

• We should return early if an exception was thrown. We should not be using the result in any way since we cannot rely on it having any sane value.

(JSC::APICallbackFunction::construct):

• For consistency, also return an undefined here when an exception was thrown.

• API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::construct):
(JSC::JSCallbackObject<Parent>::call):

• Return an undefined if an exception was thrown. Don't return the potentially garbage result value. Who knows what the client code will do with it. Returning an undefined here makes the code more robust.

• API/JSObjectRef.cpp:

(JSObjectGetProperty):
(JSObjectHasPropertyForKey):
(JSObjectGetPropertyForKey):
(JSObjectDeletePropertyForKey):
(JSObjectGetPropertyAtIndex):
(JSObjectDeleteProperty):

• Explicitly return a nullptr if an exception was thrown. The toRef() on the result that follows the exception check may or may not return a nullptr (also see toRef(JSC::VM& vm, JSC::JSValue v) for !CPU(ADDRESS64)).

• API/JSValueRef.cpp:

(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):

• For consistency, make these return false if an exception is thrown.

• API/ObjCCallbackFunction.mm:

(JSC::objCCallbackFunctionCallAsFunction):
(JSC::objCCallbackFunctionCallAsConstructor):
(JSC::ObjCCallbackFunctionImpl::call):

• Add some assertions and return early if an exception was thrown.

11:34 AM Changeset in webkit [260342] by Alan Bujtas

• 4 edits
  2 adds in trunk

[LFC][TFC] Add column spanning support for flexible table width
​https://bugs.webkit.org/show_bug.cgi?id=210713

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-flex-width-colspans.html

This patch slightly changes the extra space distribution logic by using either the minimum or
the maximum width as the base initial width for the columns.

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::computeColumnWidths):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace): Deleted.

• layout/tableformatting/TableFormattingContext.h:

LayoutTests:

• fast/layoutformattingcontext/table-flex-width-colspans-expected.txt: Added.
• fast/layoutformattingcontext/table-flex-width-colspans.html: Added.

11:12 AM Changeset in webkit [260341] by don.olmstead@sony.com

• 4 edits
  3 moves
  2 adds in trunk/Tools

[CMake] Consolidate TestNetscapePlugin build
​https://bugs.webkit.org/show_bug.cgi?id=210691

Reviewed by Fujii Hironori.

The DumpRenderTree CMakeLists.txt contained a definition of TestNetscapePlugIn
which was used for WebKitLegacy ports. The TestNetscapePlugIn directory also had
a CMakeLists.txt used by GTK for its port. The definitions in DumpRenderTree's
CMake are moved into the TestNetscapePlugIn CMake to provide a common definition
for all ports that ENABLE_NETSCAPE_PLUGIN_API.

• DumpRenderTree/CMakeLists.txt:
• DumpRenderTree/PlatformWin.cmake:
• DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
• DumpRenderTree/TestNetscapePlugIn/PlatformGTK.cmake: Added.
• DumpRenderTree/TestNetscapePlugIn/PlatformWin.cmake: Added.
• DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugIn.def: Renamed from Tools/DumpRenderTree/win/TestNetscapePlugin.def.
• DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugIn.rc: Renamed from Tools/DumpRenderTree/win/TestNetscapePlugin.rc.
• DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from Tools/DumpRenderTree/win/resource.h.

11:01 AM Changeset in webkit [260340] by emilio

• 8 edits in trunk

Don't use the inherited custom properties to store environment variables.
​https://bugs.webkit.org/show_bug.cgi?id=210707

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Annotate the progressions.

• web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• web-platform-tests/css/cssom/getComputedStyle-logical-enumeration-expected.txt:

Source/WebCore:

It leaks this implementation detail when enumerating the computed style.

Tests: imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.xhtml

imported/w3c/web-platform-tests/css/cssom/getComputedStyle-logical-enumeration.html

• css/CSSVariableReferenceValue.cpp:

(WebCore::resolveVariableReference):
(WebCore::resolveTokenRange):

• style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

LayoutTests:

• platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

10:56 AM Changeset in webkit [260339] by emilio

• 2 edits in trunk/Tools

Allow to override sccache server port.
​https://bugs.webkit.org/show_bug.cgi?id=210722

Reviewed by Philippe Normand.

This is useful so that sccache can work both inside and outside the sandbox,
without getting confused about flatpak's chroot.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

10:51 AM Changeset in webkit [260338] by Antti Koivisto

• 28 edits
  2 adds
  8 deletes in trunk

[CSS selectors] :is() / :where() should not allow pseudo-elements at parse-time
​https://bugs.webkit.org/show_bug.cgi?id=210701

Reviewed by Anders Carlsson.

Source/WebCore:

​https://drafts.csswg.org/selectors/#matches:

"Pseudo-elements cannot be represented by the matches-any pseudo-class; they are not valid within :is()."

Test: fast/selectors/pseudo-element-in-is-where.html

• css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumePseudo):

LayoutTests:

Remove or update tests for pseudo elements inside :is()/:where().
Also add some :where() rountrip coverage.

• fast/css/css-selector-text-expected.txt:
• fast/css/css-selector-text.html:
• fast/css/css-set-selector-text-expected.txt:
• fast/css/css-set-selector-text.html:
• fast/css/is-specificity-6-expected.html: Removed.
• fast/css/is-specificity-6.html: Removed.
• fast/css/matches-specificity-6-expected.html: Removed.
• fast/css/matches-specificity-6.html: Removed.
• fast/css/parsing-css-allowed-string-characters-expected.txt:
• fast/css/parsing-css-is-1-expected.txt:
• fast/css/parsing-css-is-1.html:
• fast/css/parsing-css-is-2-expected.txt:
• fast/css/parsing-css-is-2.html:
• fast/css/parsing-css-is-3-expected.txt:
• fast/css/parsing-css-is-3.html:
• fast/css/parsing-css-is-4-expected.txt:
• fast/css/parsing-css-is-4.html:
• fast/css/parsing-css-matches-1-expected.txt:
• fast/css/parsing-css-matches-1.html:
• fast/css/parsing-css-matches-2-expected.txt:
• fast/css/parsing-css-matches-2.html:
• fast/css/parsing-css-matches-3-expected.txt:
• fast/css/parsing-css-matches-3.html:
• fast/css/parsing-css-matches-4-expected.txt:
• fast/css/parsing-css-matches-4.html:
• fast/selectors/pseudo-element-in-is-where-expected.html: Added.
• fast/selectors/pseudo-element-in-is-where.html: Added.
• fast/selectors/pseudo-element-inside-is-expected.html: Removed.
• fast/selectors/pseudo-element-inside-is.html: Removed.
• fast/selectors/pseudo-element-inside-matches-expected.html: Removed.
• fast/selectors/pseudo-element-inside-matches.html: Removed.
• fast/selectors/querySelector-is-expected.txt:
• fast/selectors/querySelector-is.html:
• fast/selectors/querySelector-matches-expected.txt:
• fast/selectors/querySelector-matches.html:

10:49 AM Changeset in webkit [260337] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][TFC] Take border spacing into account when distributing column spanners width.
​https://bugs.webkit.org/show_bug.cgi?id=210712

Reviewed by Antti Koivisto.

While distributing the column spanner extra space among individual columns,
the spacing between these columns (set by border-spacing) should be taken into
account and subtract it from the width to distribute.

<table style="border-spacing: 50px"><tr><td colspan=2>long long text</td></tr><tr><td>lo</td><td>xt</td><tr></table>
[long long text]
[lo] [xt]
The individual columns don't require any extra space from the spanner.

• layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::IntrinsicWidthConstraints::operator+=):
(WebCore::Layout::FormattingContext::IntrinsicWidthConstraints::operator-=):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::TableFormattingContext::computedPreferredWidthForColumns):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace):

• layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::horizontalSpacing const):
(WebCore::Layout::TableGrid::totalHorizontalSpacing const): Deleted.

10:24 AM Changeset in webkit [260336] by Darin Adler

• 2 edits in trunk/Tools

REGRESSION (r260334): SpacebarScrolling.cpp (test in TestWebKitAPI) fails to compile because it includes an Objective-C header
​https://bugs.webkit.org/show_bug.cgi?id=210723

Reviewed by Brady Eidson.

• TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp: Instead of including

WKPreferencesPrivate.h, an Objective-C header, include WKPreferencesRefPrivate.h,
the header with the functions this test is trying to use.

6:46 AM Changeset in webkit [260335] by emilio

• 5 edits
  2 adds in trunk

Fix the logic to decide whether a property is enumerated in a computed style declaration.
​https://bugs.webkit.org/show_bug.cgi?id=210695

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Import the test from
​https://github.com/web-platform-tests/wpt/pull/23088. One subtest is
failing, separate bug.

• web-platform-tests/css/cssom/getComputedStyle-logical-enumeration-expected.txt: Added.
• web-platform-tests/css/cssom/getComputedStyle-logical-enumeration.html: Added.

Source/WebCore:

Fix the logic to decide whether a property is enumerated in a computed
style declaration.

Logical properties don't need stylebuilder code, but still should be
generated. Using the specification->category for this seems a bit
hacky, but unclear if it's worse than adding a new flag.

Tests: fast/css/getComputedStyle/computed-style-enumeration.html

imported/w3c/web-platform-tests/css/cssom/getComputedStyle-logical-enumeration.html

• css/makeprop.pl:

(skippedFromComputedStyle):
(isLogical):
(sortWithPrefixedPropertiesLast):