Timeline

Apr 21, 2020:

9:27 PM Changeset in webkit [260502] by Devin Rousso

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r255396): Graphics: viewing a shader program hides the navigation sidebar
​https://bugs.webkit.org/show_bug.cgi?id=210838

Reviewed by Joseph Pecoraro.

• UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel.prototype.canShowRepresentedObject):
Include WI.ShaderProgram in the list of displayable represented objects.

• UserInterface/Base/Main.js:

(WI.tabContentViewClassForRepresentedObject):

• UserInterface/Views/GraphicsTabContentView.js:

(WI.GraphicsTabContentView.prototype.canShowRepresentedObject):
Update the list of represented objects that are displayable by the Graphics Tab.

• UserInterface/Views/GraphicsOverviewContentView.css:

(.content-view.graphics-overview > section > .header):
(.content-view.graphics-overview > section:not(:first-of-type) > .header): Deleted.
Drive-by: add a top border to the first section when overscrolling.

• UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview > .content-view.canvas > .preview > .message-text-view): Added.
Drive-by: ensure that the "No Preview Available" view doesn't overlap the section header.

9:19 PM Changeset in webkit [260501] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for watchOS
​https://bugs.webkit.org/show_bug.cgi?id=210832

If function is not defined, static declaration should not be declared, otherwise, unused-function-error happens.

• jsc.cpp:

9:12 PM Changeset in webkit [260500] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewd, speculative Windows build fix part 2
​https://bugs.webkit.org/show_bug.cgi?id=210834

• runtime/Options.cpp:

(JSC::strncasecmp):

9:07 PM Changeset in webkit [260499] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix windows build failure
​https://bugs.webkit.org/show_bug.cgi?id=210834

• runtime/Options.cpp:

(JSC::strncasecmp):

9:05 PM Changeset in webkit [260498] by Ryan Haddad

• 4 edits in trunk/Source/WebKit

Unreviewed, reverting r260478.

Caused TestWebKitAPI.WKAttachmentTests crashes on Catalina

Reverted changeset:

"Clean up QuickLookThumbnailLoader"
​https://bugs.webkit.org/show_bug.cgi?id=210814
​https://trac.webkit.org/changeset/260478

8:58 PM Changeset in webkit [260497] by Ryan Haddad

• 18 edits in trunk

Unreviewed, reverting r260410.

Caused crashes in Safari

Reverted changeset:

"SPI clients using fastServerTrustEvaluationEnabled need SPI
to inform them of modern TLS negotiation"
​https://bugs.webkit.org/show_bug.cgi?id=210533
​https://trac.webkit.org/changeset/260410

8:53 PM Changeset in webkit [260496] by Ryan Haddad

• 8 edits in trunk/Source/WebKit

Unreviewed, reverting r260475.

New assert caused layout tests to exit early on iOS and macOS

Reverted changeset:

"REGRESSION(r260410) Frequent Network process crashes"
​https://bugs.webkit.org/show_bug.cgi?id=210825
​https://trac.webkit.org/changeset/260475

8:45 PM Changeset in webkit [260495] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GTK] http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=194629

Updating test expectation with correct console message after r260356
enabled resource load statistics for GTK/WPE.

Unreviewed test gardening.

• platform/gtk/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt:

8:39 PM Changeset in webkit [260494] by Lauro Moura

• 3 edits in trunk/LayoutTests

[GTK][WPE] Test gardening.

Unreviewed test gardening.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

8:17 PM Changeset in webkit [260493] by Alan Coon

• 7 edits in branches/safari-609.2.9.0-branch

Apply patch. rdar://problem/62083319

8:13 PM Changeset in webkit [260492] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

IPC::Encoder::reserve() can be private
<​https://webkit.org/b/210833>
<rdar://problem/62124193>

Reviewed by Darin Adler.

• Platform/IPC/Encoder.h:

(IPC::Encoder::reserve):

• Move from public to private.

8:03 PM Changeset in webkit [260491] by cathiechen

• 12 edits
  4 adds in trunk

REGRESSION (r254790): No longer get smooth scrolling on music.apple.com
​https://bugs.webkit.org/show_bug.cgi?id=210634

Reviewed by Darin Adler.

Source/WebCore:

The page uses the access of "scrollBehavior" in CSSStyleDeclaration as the support of scroll-behavior.
If supported, it will use scroll-behavior. Otherwise, it will perform a JS smooth scroll.
Currently, "scrollBehavior" is still available when CSSOMViewSmoothScrolling is off, only the value
"smooth" is invalidated.
In order to fix this, CSSStyleDeclaration will take account of CSSOMViewSmoothScrolling in Settings.
This patch also tries to provide an interface which let flags in Settings can enable/disable a property.
However, it is not complete, for there are some scenarios that Settings isn't accessible. By adding
"settings-flag" to CSSProperties.json, it would be effective to control the property access in CSSStyleDeclaration.

Tests: fast/scrolling/scroll-behavior-invalidate-if-disabled.html

fast/scrolling/scroll-behavior-validate-if-enabled.html

• css/CSSProperties.json:
• css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::getCSSPropertyIDFromJavaScriptPropertyName):
(WebCore::CSSStyleDeclaration::namedItem):
(WebCore::CSSStyleDeclaration::setNamedItem):
(WebCore::CSSStyleDeclaration::supportedPropertyNames const):

• css/makeprop.pl:

(addProperty):

• css/parser/CSSPropertyParser.cpp:

(WebCore::cssPropertyID):

• inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::collectProperties const):

• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getSupportedCSSProperties):

Tools:

Add settings-flag. Add support for CSSOMViewSmoothScrolling on Windows DumpRenderTree.

• DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):

• Scripts/webkitpy/style/checkers/jsonchecker.py:

(JSONCSSPropertiesChecker.check_codegen_properties):

LayoutTests:

"scrollBehavior" is not available in CSSStyleDeclaration if the flag is off.
It's available if the flag is on.

• fast/scrolling/scroll-behavior-invalidate-if-disabled-expected.txt: Added.
• fast/scrolling/scroll-behavior-invalidate-if-disabled.html: Added.
• fast/scrolling/scroll-behavior-validate-if-enabled-expected.txt: Added.
• fast/scrolling/scroll-behavior-validate-if-enabled.html: Added.

7:54 PM Changeset in webkit [260490] by ysuzuki@apple.com

• 10 edits
  2 adds in trunk

[JSC] SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq should expect AnyBigIntUse
​https://bugs.webkit.org/show_bug.cgi?id=210832

Reviewed by Mark Lam.

JSTests:

• stress/heap-and-32-bigint-eq.js: Added.

(shouldBe):

• stress/heap-and-32-bigint-stricteq.js: Added.

(shouldBe):

Source/JavaScriptCore:

SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq will get AnyBigIntUse now. We should use ManualOperandSpeculation
and speculate function to perform speculation check.

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):

• jsc.cpp:

(functionCreateHeapBigInt):
(functionCreateBigInt32):

• runtime/BigIntConstructor.cpp:

(JSC::toBigInt):
(JSC::callBigIntConstructor):

• runtime/BigIntConstructor.h:
• runtime/JSBigInt.h:

7:35 PM Changeset in webkit [260489] by ysuzuki@apple.com

• 8 edits
  3 adds in trunk

Canonicalize JSBigInt generated by structured-cloning by calling rightTrim
​https://bugs.webkit.org/show_bug.cgi?id=210816

Reviewed by Keith Miller and Darin Adler.

Source/JavaScriptCore:

• runtime/JSBigInt.h:

Source/WebCore:

Let's assume that the serialized data is slightly different. JSBigInt's internal representation has various invariants. For example, if JSBigInt is zero, it should have zero length,
and its sign should be false. But there are various ways of representing zero JSBigInt in serialization format. For example, we can set sign = true, length = 0. Current code strongly
assumes that dumped data meets this JSBigInt's internal invariant. This is not good: for example, if we add a new invariant into JSBigInt, already serialized data would not meet this
invariant.
In this patch, we call JSBigInt::rightTrim(VM&) when finishing JSBigInt deserialization. This means that we canonicalize JSBigInt when finishing creation, and this makes this serialization
format free from JSBigInt's internal invariants. This makes JSBigInt serialization/deserialization robust. And we also add lengthInUint64 == 0 path not to call rightTrim when it is zero.
This makes deserialization robust for zero-length & signed corrupted JSBigInt zero.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpBigInt32Data):
(WebCore::CloneDeserializer::readBigInt):

LayoutTests:

Add HeapZero BigInt test.

• fast/dom/Window/window-postmessage-clone-expected.txt:
• fast/dom/Window/window-postmessage-clone.html:
• js/dom/bigint-canonicalization-in-structured-cloning-expected.txt: Added.
• js/dom/bigint-canonicalization-in-structured-cloning.html: Added.
• js/dom/script-tests/bigint-canonicalization-in-structured-cloning.js: Added.
• platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:

7:23 PM Changeset in webkit [260488] by Peng Liu

• 2 edits in trunk/Source/WebCore

platform/mac/media/audio-session-category-audio-autoplay.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=210826

Reviewed by Jer Noble.

For WebKitLegacy, AudioSession::setCategory() needs to set the category when
m_routingArbitrationClient is nullptr. This patch also fixes an error regarding
setupArbitrationOngoing.

• platform/audio/mac/AudioSessionMac.mm:

(WebCore::AudioSession::setCategory):

7:03 PM Changeset in webkit [260487] by stephan.szabo@sony.com

• 2 edits in trunk/Source/WebKit

[PlayStation] Fix GPU Process build for VIDEO_PRESENTATION_MODE changes
​https://bugs.webkit.org/show_bug.cgi?id=210836

Reviewed by Darin Adler.

Build fix, no new tests.

• GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp:

6:54 PM Changeset in webkit [260486] by Peng Liu

• 17 edits in trunk

Fix MACCATALYST build failures
​https://bugs.webkit.org/show_bug.cgi?id=210815

Reviewed by Tim Horton.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, no functional change.

• Configurations/FeatureDefines.xcconfig:
• platform/ios/WebVideoFullscreenControllerAVKit.mm:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _isShowingVideoPictureInPicture]):
(-[WKWebView _mayAutomaticallyShowVideoPictureInPicture]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationDidBecomeActive):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/PlatformEnable.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

6:50 PM Changeset in webkit [260485] by Darin Adler

• 78 edits in trunk

[Cocoa] Use createNSArray in many more places that build NSArray objects from C++ collections
​https://bugs.webkit.org/show_bug.cgi?id=210702

Reviewed by Alex Christensen.

Source/WebCore:

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityFlowToElements]): Use createNSArray.
(-[WebAccessibilityObjectWrapper textRectsFromMarkers:withText:]): Ditto.
(-[WebAccessibilityObjectWrapper rectsForSelectionRects:]): Deleted. Merged into
the method above.

• accessibility/mac/WebAccessibilityObjectWrapperBase.h: Take const references

instead of references when passing Path and FloatRect.

• accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(convertMathPairsToNSArray): Use createNSArray. Also use arrays on the stack
to create NSDictionary rather than using NSMutableDictionary.
(addChildToArray): Deleted.
(convertToNSArray): Uses createNSArray. Rolled addChildToArray in.
(-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]): Take const
reference instead of reference.
(-[WebAccessibilityObjectWrapperBase convertRectToSpace:space:]): Ditto.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
Use createNSArray.

• editing/cocoa/FontAttributesCocoa.mm:

(WebCore::FontAttributes::createDictionary const): Ditto.

• page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot const): Ditto.

• platform/cocoa/SearchPopupMenuCocoa.mm:

(WebCore::saveRecentSearches): Ditto.

• platform/cocoa/SharedBufferCocoa.mm:

(WebCore::SharedBuffer::createNSDataArray const): Ditto.

• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense): Ditto.

• platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

(WebCore::CDMSessionAVContentKeySession::update): Ditto.

• platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::update): Ditto.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Ditto.

• platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:

(WebCore::PlatformCAAnimationCocoa::setValues): Ditto.
(WebCore::PlatformCAAnimationCocoa::setKeyTimes): Ditto.
(WebCore::PlatformCAAnimationCocoa::setTimingFunctions): Ditto.

• platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:

(WebCore::PlatformCAFilters::setFiltersOnLayer): Moved almost the whole
function into a call to createNSArray. Removed the default case from
the switch so we get a warning if we miss any filter operation types.

• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::setSublayers): Use createNSArray.

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write): Ditto.

• platform/ios/PlaybackSessionInterfaceAVKit.mm:

(WebCore::mediaSelectionOptions): Ditto.

• platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::write): Ditto.

• platform/mac/WebPlaybackControlsManager.mm:

(mediaSelectionOptions): Ditto.

• platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::setCookies): Ditto.

• platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Ditto.

• platform/network/cocoa/WebCoreNSURLSession.h:

Use the Objective-C type WebCoreNSURLSessionDataTask in the _dataTasks
set rather than using CFTypeRef.

• platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSession dealloc]): Remove now-unneeded typecast.
(-[WebCoreNSURLSession taskCompleted:]): Ditto.
(-[WebCoreNSURLSession finishTasksAndInvalidate]): Use a more idiomatic
form of capturing strongSelf in a lambda.
(-[WebCoreNSURLSession invalidateAndCancel]): Updated the type on a
local variable and removed now-unneeded typecast.
(-[WebCoreNSURLSession getTasksWithCompletionHandler:]): Use RetainPtr
to cut down on autorelease. Use createNSArray, taking advantage of the
fact that it works on HashSet. Removed now-unneeded typecast.
(-[WebCoreNSURLSession getAllTasksWithCompletionHandler:]): Ditto.
(-[WebCoreNSURLSession dataTaskWithRequest:]): Remove now-unneeded typecast.
(-[WebCoreNSURLSession dataTaskWithURL:]): Ditto.

Source/WebKit:

• Platform/cocoa/PaymentAuthorizationPresenter.mm:

(WebKit::toNSErrors): Use createNSArray and return a RetainPtr to cut down
on autorelease.
(WebKit::toPKShippingMethods): Ditto.
(WebKit::PaymentAuthorizationPresenter::completePaymentSession): Updated for RetainPtr.
(WebKit::PaymentAuthorizationPresenter::completeShippingContactSelection): Ditto.

• Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest): Use createNSArray.
Also removed code to support platforms without -setThumbnailURLs: since we don't
have those any more.

• Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::updateChildren): Use createNSArray.

• UIProcess/API/Cocoa/WKHTTPCookieStore.mm:

(coreCookiesToNSCookies); Ditto.

• UIProcess/API/Cocoa/WKProcessPool.mm:

(+[WKProcessPool _allProcessPoolsForTesting]): Ditto.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _startTextManipulationsWithConfiguration:completion:]): Cut down on
repeated code by adding a lambda to create a _WKTextManipulationItem and by using
createNSArray.
(wkTextManipulationErrors): Use createNSArray. Also tighten up the code that maps
WebCore::TextManipulationController::ManipulationFailureType to the
_WKTextManipulationItemError code.

• UIProcess/API/Cocoa/WKWebpagePreferences.mm:

(-[WKWebpagePreferences _customHeaderFields]): Use createNSArray.

• UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:

(-[WKWebsiteDataRecord _originsStrings]): Ditto.

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _getResourceLoadStatisticsDataSummary:]): Ditto.

• UIProcess/API/Cocoa/_WKDownload.mm:

(-[_WKDownload redirectChain]): Ditto.

• UIProcess/API/Cocoa/_WKFrameTreeNode.mm:

(-[_WKFrameTreeNode childFrames]): Ditto.

• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration additionalReadAccessAllowedURLs]): Ditto.

• UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm:

(-[_WKResourceLoadStatisticsThirdParty underFirstParties]): Ditto.

• UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]): Ditto.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::didChangeBackForwardList): Ditto.

• UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.mm:

(WebKit::RemoteLayerTreeScrollingPerformanceData::data): Ditto.

• UIProcess/ios/DragDropInteractionState.mm:

(WebKit::createTargetedDragPreview): Ditto.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _updateTapHighlight]): Removed uneeded RetainPtr local variable.
Use createNSArray. Refactored to make the "all rectilinear" case more parallel
to the general case.
(-[WKContentView webSelectionRectsForSelectionRects:]): Use createNSArray.
(wkTextSelectionRects): Ditto.
(createTargetedPreview): Ditto.
(-[WKContentView _presentationRectsForPreviewItemController:]): Ditto.

• UIProcess/mac/WKTextFinderClient.mm:

(-[WKTextFinderClient didFindStringMatchesWithRects:didWrapAround:]): Use createNSArray.

• UIProcess/mac/WKTextInputWindowController.mm:

(-[WKTextInputView validAttributesForMarkedText]): Use +[NSArray arrayByAddingObject:].

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(collectIcons): Use createNSArray.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Marked class here
as final. Cut down on local variables a bit. Use createNSArray.

• WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::addAnimationToLayer): Removed unnecessary use of RetainPtr. Use createNSArray.

• WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::WebBackForwardListProxy): Addd a FIXME about
a problem I noticed, unrelated to the rest of the changes.

• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]): Use createNSArray.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::registerWithStateDumper): Ditto.
(WebKit::activePagesOrigins): Ditto.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame selectionRectsForCoreRange:]): Use createNSArray.

Source/WebKitLegacy/mac:

• DOM/DOM.mm:

(kit): Use createNSArray.
(-[DOMNode getPreviewSnapshotImage:andRects:]): Ditto. Also use makeNSArrayElement
to convert FloatRect to an NSValue containing a CGRect, avoiding use of
+[NSValue value:withObjCType:], while working on macOS where +[NSValue valueWithCGRect:]
is not part of API.

• History/WebBackForwardList.mm:

(-[WebBackForwardList dictionaryRepresentation]): Use createNSArray, fewer local
variables, and use constexpr instead of #define.
(-[WebBackForwardList setToMatchDictionaryRepresentation:]): Use adoptNS instead
of explicit release and reference instead of pointer.
(vectorToNSArray): Deleted.
(-[WebBackForwardList backListWithLimit:]): Use createNSArray. Also use RetainPtr for
the "hack" here rather than explicit retain/release calls.
(-[WebBackForwardList forwardListWithLimit:]): Ditto.

• History/WebHistoryItem.mm:

(kit): Added a retain/autorelease pair that is important to have predictable lifetime.
(-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
Added a missing null check.
(-[WebHistoryItem initWithWebCoreHistoryItem:]): Added a FIXME about something I
noticed that is not related to the rest of this patch.
(-[WebHistoryItem children]): Use createNSArray.
(-[WebHistoryItem _redirectURLs]): Ditto.

• Misc/WebCoreStatistics.mm:

(createNSCountedSet): Added. More efficient than the old code because it doesn't
create many NSString objects for each key, but also shared between functions.
(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use createNSCountedSet.
(+[WebCoreStatistics javaScriptObjectTypeCounts]): Ditto.

• Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
Use @[] instead of NSMutableArray

• Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager origins]): Use createNSArray.

• Storage/WebStorageManager.mm:

(-[WebStorageManager origins]): Ditto.

• WebCoreSupport/WebApplicationCache.mm:

(+[WebApplicationCache originsWithCache]): Ditto.

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::updateSpellingUIWithGrammarString): Ditto.

• WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::clearNotifications): Ditto.

• WebView/WebArchive.mm:

(-[WebArchive subresources]): Ditto.
(-[WebArchive subframeArchives]): Ditto.

• WebView/WebDataSource.mm:

(-[WebDataSource subresources]): Ditto.

• WebView/WebFrame.mm:

(-[WebFrame _nodesFromList:]): Deleted. This was not declared in any header and
was also unused.

• WebView/WebFrameView.mm:

(-[WebFrameView initWithFrame:]): Added a FIXME about something I noticed that is
not related to the rest of this patch.

• WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation controlsInForm:]): Use createNSArray.

• WebView/WebHTMLView.mm:

(createMenuItems): Use createNSArray. Also moved up in the file.
(createMenuItem): Removed unneeded local variable.

• WebView/WebView.mm:

(-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
Use createNSArray.

Source/WTF:

• wtf/cocoa/VectorCocoa.h: Improved the createNSArray function template:

1) Skip nil values. This matches what we do with Optional<> in makeVector and

was always my intention; apparently forgot to do it.

2) Instead of taking a const reference argument, take a forwarding reference

and use forwarding when passing collection elements to makeNSArrayElement
or the passed-in function. Can transfer ownership of collection elements
as they are transformed into array elements, which makes sense if the
Objective-C objects are wrappers that take ownership of what's wrapped.

3) Take any collection that works with std::size and a range-based for loop,

no longer requiring a size member function. Includes arrays.

4) Since this now intended for use on collections other than WTF::Vector,

added "using WTF::createNSArray" since argument-dependent lookup won't
find the function template in those cases.

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(activateTestingFonts): Use constexpr and NSString instead of a null-pointer terminated
array for the font names. Use createNSArray.

• DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
Use createNSArray.

• Scripts/webkitpy/style/checkers/cpp.py:

(find_parameter_name_index): Fixed a spelling error.
(_check_parameter_name_against_text): Added a special case to not complain that
parameters named "]" have redundant names. Not obvious to me how to write a test case for
this and how to fix this in a more sensible way, but immediately helpful to not get this
spurious warning.

• WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:

(WTR::activateSystemCoreWebFonts): Use constexpr array instead of NSArray for font names.
(WTR::activateFonts): Use constexpr and NSString instead of a null-pointer terminated
array for the font names. Use createNSArray.

6:46 PM Changeset in webkit [260484] by Matt Lewis

• 2 edits in trunk/Tools

Bindings-test should not depend on current working directory.
​https://bugs.webkit.org/show_bug.cgi?id=210831

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.main):

6:34 PM Changeset in webkit [260483] by Alexey Shvayka

• 5 edits in trunk

The visibilitychange event should bubble
​https://bugs.webkit.org/show_bug.cgi?id=210829

Reviewed by Darin Adler.

Source/WebCore:

This change makes visibilitychange event bubble as per spec [1], aligning WebKit
with Blink and Gecko. Also fixes broken spec link to visibilityState attribute.

[1] ​https://w3c.github.io/page-visibility/#dfn-now-visible-algorithm (step 2)

Test: fast/events/page-visibility-transition-test.html

• dom/Document.cpp:

(WebCore::Document::visibilityStateChanged):
(WebCore::Document::visibilityState const):

LayoutTests:

• fast/events/page-visibility-transition-test-expected.txt:
• fast/events/page-visibility-transition-test.html:

6:28 PM Changeset in webkit [260482] by Simon Fraser

• 7 edits
  3 adds in trunk

Composited layers are misplaced inside RTL overflow scroller with visible scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=210820

Reviewed by Zalan Bujtas.

Source/WebCore:

RenderLayerBacking::computeParentGraphicsLayerRect() used renderBox.paddingBoxRectIncludingScrollbar()
to position layers inside composited overflow scroll, but this is wrong if the RTL left-side
scrollbar takes space.

Fix by making some static functions that we can call from the various places that ask
about box geometry, and using them.

Test: compositing/scrolling/async-overflow-scrolling/position-inside-rtl-overflow.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::overflowClipRect const):
(WebCore::RenderBox::clipRect const):
(WebCore::RenderBox::overflowClipRect): Deleted.
(WebCore::RenderBox::clipRect): Deleted.

• rendering/RenderBox.h:

(WebCore::RenderBox::overflowClipRectForChildLayers const):
(WebCore::RenderBox::overflowClipRectForChildLayers): Deleted.

• rendering/RenderLayerBacking.cpp:

(WebCore::scrollContainerLayerBox):
(WebCore::clippingLayerBox):
(WebCore::overflowControlsHostLayerBox):
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect const):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::clipBox): Deleted.

• rendering/RenderTable.cpp:

(WebCore::RenderTable::overflowClipRect const):
(WebCore::RenderTable::overflowClipRect): Deleted.

• rendering/RenderTable.h:

LayoutTests:

• compositing/scrolling/async-overflow-scrolling/position-inside-rtl-overflow-expected.txt: Added.
• compositing/scrolling/async-overflow-scrolling/position-inside-rtl-overflow.html: Added.
• platform/ios-wk2/compositing/scrolling/async-overflow-scrolling/position-inside-rtl-overflow-expected.txt: Added.

6:27 PM Changeset in webkit [260481] by keith_miller@apple.com

• 3 edits in trunk/Source/JavaScriptCore

JSC's options should be case insensitive
​https://bugs.webkit.org/show_bug.cgi?id=210834

Reviewed by Yusuke Suzuki.

• runtime/Options.cpp:

(JSC::Options::setOptionWithoutAlias):
(JSC::Options::setAliasedOption):

• runtime/OptionsList.h:

5:57 PM Changeset in webkit [260480] by Alan Coon

• 5 edits in branches/safari-609.2.9.1-branch/Source/WebCore

Cherry-pick r260301. rdar://problem/62083309

[WebGL] Confirm there are no errors when setting up framebuffers
​https://bugs.webkit.org/show_bug.cgi?id=210632
<rdar://problem/61916680>

Reviewed by Simon Fraser.

We're seeing crashes on macOS inside GraphicsContextGL::reshape().
Specifically when we submit work at the end of the function via
glFlush.

At the moment the cause is a mystery, because we should bail out
before then if the multisample renderbuffer was not complete. In
the hope that it helps somewhat, add a call to glGetError to double
check that there isn't anything horribly wrong before we talk to
the GPU.

• html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::WebGL2RenderingContext): If the underlying GCGL context was marked as "LOST" during initialization, skip the rest of our initialization.
• html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::WebGLRenderingContext):
• html/canvas/WebGLRenderingContextBase.cpp: Ditto. (WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Check for a GL error during setup and, if there is one, skip directly into a LOST state. (WebCore::GraphicsContext3D::reshape):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:56 PM Changeset in webkit [260479] by Russell Epstein

• 539 edits
  19 adds
  160 deletes in branches/safari-610.1.11-branch/Source/ThirdParty/ANGLE

Revert r259589. rdar://problem/62141646

5:51 PM Changeset in webkit [260478] by ddkilzer@apple.com

• 4 edits in trunk/Source/WebKit

Clean up QuickLookThumbnailLoader
<​https://webkit.org/b/210814>

Reviewed by Darin Adler.

The following items are cleaned up:

• Extract using PlatformImage into QuickLookThumbnailLoader.h, rename to CocoaImage and use to get rid of duplicate code.
• Change id to instancetype for -init methods.
• Add atomic keyword to @property definitions that were using it as the default. (Use of atomic properties is rare in WebKit, so being explicit avoids a scenario where it looks like nonatomic was left off by accident.)
• Change @property definitions to readonly that are never written to outside of QuickLookThumbnailLoader.mm.
• Delete unused @property definitions.
• Change method declarations into read-only @property definitions.
• Re-declare atomic read-only @property definitions in QuickLookThumbnailLoader.h as read-write definitions in QuickLookThumbnailLoader.mm if they are written to.

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::convertPlatformImageToBitmap):

• UIProcess/QuickLookThumbnailLoader.h:
• Rename qlThumbnailGenerationQueue @property to just queue.
• Remove contentType @property. It is not used anywhere. This also fixes a theoretical leak found by the clang static analyzer.
• Remove shouldWrite @property. It is only used within QuickLookThumbnailLoader.mm.
• Change identifier and thumbnail to @property declarations.
• UIProcess/QuickLookThumbnailLoader.mm:
• Change WKQLThumbnailLoadOperation._identifier type from NSMutableString to NSString. There was no reason for it to be mutable.

(-[WKQLThumbnailQueueManager init]):
(-[WKQLThumbnailQueueManager dealloc]):

• Release _queue to fix theoretical leak found by the clang static analyzer.

(-[WKQLThumbnailLoadOperation initWithAttachment:identifier:]):
(-[WKQLThumbnailLoadOperation initWithURL:identifier:]):
(-[WKQLThumbnailLoadOperation start]):

• Rename req to request and use RetainPtr<>.
• Change separate #if macros to #if/#else since only one version of this code can be used at a time.

(-[WKQLThumbnailLoadOperation thumbnail]):

• Use CocoaImage to use one copy of the method.

5:29 PM Changeset in webkit [260477] by Fujii Hironori

• 5 edits
  1 delete in trunk/Source/WTF

[Win] Use generic WorkQueue instead of WorkQueueWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=210785

Reviewed by Darin Adler.

WorkQueueWin was using random threads to execute dispatched
functions. This is not desired for IPC::Connection because it
needs to call CancelIo API in the same thread started aync
ReadFile operations.

Implemented RunLoop::dispatchAfter in RunLoopWin.cpp in order to
use generic WorkQueue.

• wtf/PlatformWin.cmake:
• wtf/RunLoop.h: Added DispatchTimer class for USE(WINDOWS_EVENT_LOOP).

(WTF::RunLoop::DispatchTimer::DispatchTimer):
(WTF::RunLoop::DispatchTimer::setFunction):

• wtf/WorkQueue.h: Removed code for USE(WINDOWS_EVENT_LOOP).
• wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::dispatchAfter): Added.

• wtf/win/WorkQueueWin.cpp: Removed.

5:27 PM Changeset in webkit [260476] by ddkilzer@apple.com

• 4 edits in trunk/Source/WebKit

Fix extra/missing #undef statements
<​https://webkit.org/b/210818>
<rdar://problem/61973329>

Reviewed by Chris Dumez.

• UIProcess/Network/NetworkProcessProxy.cpp:
• Remove #undef MESSAGE_CHECK_URL. It is no longer used.
• UIProcess/WebPageProxy.cpp:
• Add missing #undef MESSAGE_CHECK_COMPLETION.
• Sort #undef in reverse order of #define.
• UIProcess/mac/WebPageProxyMac.mm:
• Add missing #undef MESSAGE_CHECK_WITH_RETURN_VALUE.
• Sort #undef in reverse order of #define.

5:14 PM Changeset in webkit [260475] by Chris Dumez

• 8 edits in trunk/Source/WebKit

REGRESSION(r260410) Frequent Network process crashes
​https://bugs.webkit.org/show_bug.cgi?id=210825

Reviewed by Alex Christensen.

The webPageProxyID in the NetworkProcessProxy::DidNegotiateModernTLS() IPC was invalid because
NetworkProcessProxy::preconnectTo() was failing to initialize NetworkLoadParameters::webPageProxyID.
This patch addresses the issue.

No new tests, added new assertion that would be tripped by existing tests.

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::NetworkLoad):

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::preconnectTo):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::preconnectTo):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::preconnectTo):

5:03 PM Changeset in webkit [260474] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit

PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=210813

Reviewed by Eric Carlson.

Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
because that process is not a UI Application.

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController videoControlsManagerDidChange]):

4:12 PM Changeset in webkit [260473] by Brent Fulgham

• 4 edits in trunk/Source/WebKit

[Cocoa] Don't bother compiling UpdateInfo since it's not used
​https://bugs.webkit.org/show_bug.cgi?id=210819
<rdar://problem/61774766>

Reviewed by Darin Adler.

Since we don't use the UpdateInfo class in Cocoa builds, let's not
bother building it.

• Shared/UpdateInfo.cpp:
• Shared/UpdateInfo.h:
• UIProcess/DrawingAreaProxy.h:

4:01 PM Changeset in webkit [260472] by fpizlo@apple.com

• 3 edits in trunk/Websites/webkit.org

Unreviewed, check in some more files for a blog post.

• blog-files/speculation-in-jsc/clobberize-dependence-graph.graffle:
• blog-files/speculation-in-jsc/clobberize-dependence-graph.svg:

4:00 PM Changeset in webkit [260471] by Darin Adler

• 4 edits
  2 deletes in trunk/LayoutTests

[Mac] Enable color well tests on modern WebKit
​https://bugs.webkit.org/show_bug.cgi?id=210810

Reviewed by Alexey Proskuryakov.

When running tests I was informed of "unexpected passing" for the
test fast/css/pseudo-visited-background-color-on-input.html.
After doing some research, I found that we have tests of color well
that are still disabled on Mac even though we have implemented it
now, just not for legacy WebKit.

Looking at history I see these tests have been passing consistently
on bots. So changed their expectations to Pass, and also un-skipped
some other tests of the same feature that passed for me locally.

• platform/mac-highsierra-wk1/*: Removed.
• platform/mac-highsierra/*: Removed.

• platform/mac-wk1/TestExpectations: Moved expectations here for tests

that we should not run because we don't have color wells enabled.

• platform/mac-wk2/TestExpectations: Moved expectations here

for color well tests that still don't work in modern WebKit because we
need more support for dragging tests.

• platform/mac/TestExpectations: Moved the expections *from* here.

3:55 PM Changeset in webkit [260470] by fpizlo@apple.com

• 1 edit
  2 adds in trunk/Websites/webkit.org

Unreviewed, check in some more files for a blog post.

• blog-files/speculation-in-jsc/clobberize-dependence-graph.graffle: Added.
• blog-files/speculation-in-jsc/clobberize-dependence-graph.svg: Added.

3:53 PM Changeset in webkit [260469] by dbates@webkit.org

• 2 edits in trunk/Tools

Attempt to fix the build after r260449
(​https://bugs.webkit.org/show_bug.cgi?id=210697)

Wrap the C++ methods in namespace TestWebKitAPI so that IPhoneUserInterfaceSwizzler can be
used unqualified.

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:

3:53 PM Changeset in webkit [260468] by Alan Coon

• 1 copy in tags/Safari-610.1.10.2

Tag Safari-610.1.10.2.

3:49 PM Changeset in webkit [260467] by Alan Coon

• 8 edits in branches/safari-610.1.10-branch/Source

Versioning.

3:37 PM Changeset in webkit [260466] by fpizlo@apple.com

• 3 edits in trunk/Websites/webkit.org

Unreviewed, check in some more files for a blog post.

• blog-files/speculation-in-jsc/abstract-heaps.graffle:
• blog-files/speculation-in-jsc/abstract-heaps.svg:

3:33 PM Changeset in webkit [260465] by Alan Coon

• 8 edits in branches/safari-609.2.9.1-branch/Source

Versioning.

3:33 PM Changeset in webkit [260464] by fpizlo@apple.com

• 3 edits in trunk/Websites/webkit.org

Unreviewed, check in some more files for a blog post.

• blog-files/speculation-in-jsc/abstract-heaps.graffle:
• blog-files/speculation-in-jsc/abstract-heaps.svg:

3:27 PM Changeset in webkit [260463] by fpizlo@apple.com

• 1 edit
  2 adds in trunk/Websites/webkit.org

Unreviewed, check in some more files for a blog post.

• blog-files/speculation-in-jsc/abstract-heaps.graffle: Added.
• blog-files/speculation-in-jsc/abstract-heaps.svg: Added.

3:21 PM Changeset in webkit [260462] by Alan Coon

• 8 edits in branches/safari-609.2.9.0-branch/Source

Versioning.

2:50 PM Changeset in webkit [260461] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

One more build fix after r260407

• Configurations/WebKit.xcconfig:

2:47 PM Changeset in webkit [260460] by Alan Coon

• 1 copy in tags/Safari-610.1.10.1

Tag Safari-610.1.10.1.

2:45 PM Changeset in webkit [260459] by Alan Coon

• 3 edits in branches/safari-610.1.10-branch/Source/WebKit

Cherry-pick r260137. rdar://problem/62131504

[iOS] Potential crash under WebProcess::platformInitializeWebProcess
​https://bugs.webkit.org/show_bug.cgi?id=210547

Reviewed by Brent Fulgham.

If the UI process fails to issue an extension to the runningboard service, the WebContent process will crash
while trying to consume this extension.

No new tests, since the test runners are unsandboxed, so issuing the extension will always succeed.

• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):
• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:45 PM Changeset in webkit [260458] by Alan Coon

• 8 edits in branches/safari-610.1.10-branch/Source

Versioning.

2:34 PM Changeset in webkit [260457] by Alan Coon

• 1 copy in branches/safari-609.2.9.3-branch

New branch.

2:34 PM Changeset in webkit [260456] by Alan Coon

• 1 copy in branches/safari-609.2.9.2-branch

New branch.

2:33 PM Changeset in webkit [260455] by Alan Coon

• 1 copy in branches/safari-609.2.9.1-branch

New branch.

2:33 PM Changeset in webkit [260454] by Alan Coon

• 1 copy in branches/safari-609.2.9.0-branch

New branch.

2:22 PM Changeset in webkit [260453] by Chris Dumez

• 10 edits in trunk/Source/WebKit

[iOS] Provide better names for ProcessThrottler process assertions
​https://bugs.webkit.org/show_bug.cgi?id=210808

Reviewed by Geoffrey Garen.

Provide better names for ProcessThrottler process assertions, to facilitate debugging.

• UIProcess/GPU/GPUProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/ProcessAssertion.cpp:

(WebKit::ProcessAssertion::ProcessAssertion):

• UIProcess/ProcessAssertion.h:
• UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::assertionName const):
(WebKit::ProcessThrottler::setAssertionType):

• UIProcess/ProcessThrottler.h:
• UIProcess/ProcessThrottlerClient.h:
• UIProcess/WebProcessProxy.h:
• UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):

1:52 PM Changeset in webkit [260452] by Darin Adler

• 2 edits in trunk/Tools

WTF API test for StringConcatenate failing for internal Apple builds
​https://bugs.webkit.org/show_bug.cgi?id=210812

Reviewed by Brent Fulgham.

• TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:

(TestWebKitAPI::TEST): Add back a case for when UChar is uint16_t.

1:49 PM Changeset in webkit [260451] by Kate Cheney

• 3 edits in trunk/Tools

Move WebKit.WebViewCategory test to InAppBrowserPrivacy.mm
​https://bugs.webkit.org/show_bug.cgi?id=210811
<rdar://problem/60972505>

Reviewed by Alexey Proskuryakov.

This test was added before InAppBrowserPrivacy.mm existed. It should
be moved here so it has access to all setup/cleanup needed by these
tests.

• TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

1:36 PM Changeset in webkit [260450] by Simon Fraser

• 3 edits
  2 adds in trunk

[Async overflow scroll] Overflow that's hidden on one axis is scrollable on that axis
​https://bugs.webkit.org/show_bug.cgi?id=210771
<rdar://problem/62080331>

Reviewed by Tim Horton.

Source/WebCore:

eventCanScrollContents() should check the presence of enabled scrollbars, like
ScrollAnimator::handleWheelEvent() does.

Test: fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::eventCanScrollContents const):

LayoutTests:

• fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis-expected.txt: Added.
• fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html: Added.

1:22 PM Changeset in webkit [260449] by dbates@webkit.org

• 14 edits
  1 move in trunk

[iOS] -_didFinishTextInteractionInTextInputContext should only zoom to reveal focused element if it changed
​https://bugs.webkit.org/show_bug.cgi?id=210697
<rdar://problem/60997530>

Source/WebCore:

Reviewed by Wenson Hsieh.

For now, add a comment about the return value of setFocusedElement: it returns
whether focus was blocked. If focused wasn't blocked then it will return true
even if the element wasn't actually focused. For example, it will return true
for non-focusable elements: <input disabled>.

I was tempted to fix setFocusedElement() to return true when it actually focused
the element or if the element was already focused, but I decided to defer this
until I audit the callers and run some tests.

• dom/Document.h:

Source/WebKit:

Reviewed by Wenson Hsieh.

Add a new state variable to use to track whether -_focusTextInputContext invoked during a
text interaction actually focused an element. Then in -_didFinishTextInteractionInTextInputContext
condition marking the page to reveal the focused element on this state.

• UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
• UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _willBeginTextInteractionInTextInputContext:]): Turn around and call the same
function on the content view.
(-[WKWebView _didFinishTextInteractionInTextInputContext:]): Ditto.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanUpInteraction]): Reset state.
(-[WKContentView _didCommitLoadForMainFrame]): Ditto.
(-[WKContentView _focusTextInputContext:placeCaretAt:completionHandler:]): Update state to
indicate whether the focusd element did change or not. I use bitwise ORing instead of strict
assignment to update it because this function can be called multiple times by an internal
Apple client during a text interaction (e.g. <rdar://problem/59430806>). I thought about
making this a FIXME, but this function is otherwise capable of handling multiple invocations
so I didn't.
(-[WKContentView _willBeginTextInteractionInTextInputContext:]): Reset added state.
(-[WKContentView _didFinishTextInteractionInTextInputContext:]): Check if state was set to
indicate that a focus change happened. If so, do what we do now + reset state. Otherwise,
do everything we do now except for marking the page as needing to reveal the focused element
on the next editor state update.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::focusTextInputContextAndPlaceCaret): Check that the target is focusable
before calling FocusController::setFocusedElement() because it ultimately calls Document::setFocusedElement()
that can return true for a non-focusable element. I added a comment in Document.h to explain
this subtlety. I also decided not to check the return value of FocusController::setFocusedElement().
Instead I am checking the more important condition that the focused element is the target
element. Passing true to visiblePositionInFocusedNodeForPoint() will ultimately assert this
to be true. Note that setFocusedElement() may not have done anything as m_focusedElement
could have already been equal to the target element. This is OK and I still update the
caret position.

Tools:

Reviewed by Wenson Hsieh.

I use the term "assisted" below and in the tests to describe an element that is both DOM
focused and the UI process is showing an input view (like the software keyboard) for it.
For many of the tests I check for a zoom scale change as a way to detect if the page
zoomed to reveal the focused element.

Add some tests for the following cases:

1. Place the caret in a focused field that isn't being assisted.
2. Focusing an assisted element should not scroll the page.
3. Focusing an offscreen read-only element should not change zoom scale.
4. Focusing an offscreen element should change the zoom scale.
5. Calling -_focusTextInputContext on an offscreen element multiple times during a text interaction should change the zoom scale. The purpose of this test is to ensure that later calls that do not focus the element (because it is already focused) don't prevent zooming for the first call that did focus the element.
6. Focusing an offscreen element, defocusing it, disabling it, and focusing it again during a text interaction should not change zoom scale.
7. Focusing an offscreen element, defocusing it, and focusing it again during a text interaction should change zoom scale.
8. Focusing an assisted element during a text interaction should not change zoom scale.
9. Focusing a non-assisted focused element during a text interaction should change zoom scale.

While I am here, I consolidated the RAII helper classes IPhoneUserInterfaceSwizzler and
IPadUserInterfaceSwizzler into a single UserInterfaceSwizzler templated class and defined
the former two as template instances.

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:

(TextInteractionForScope::TextInteractionForScope):
(TextInteractionForScope::~TextInteractionForScope):
Added convenience RAII object to call -_willBeginTextInteractionInTextInputContext
and -_didFinishTextInteractionInTextInputContext.
(TEST): Added.

• TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
• TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
• TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Removed.
• TestWebKitAPI/ios/PreferredContentMode.mm:

(IPhoneUserInterfaceSwizzler::IPhoneUserInterfaceSwizzler): Deleted; movedinto UserInterfaceSwizzler.h.
(IPhoneUserInterfaceSwizzler::phoneUserInterfaceIdiom): Deleted; no longer needed.

• TestWebKitAPI/ios/UserInterfaceSwizzler.h: Renamed from Tools/TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h.

(TestWebKitAPI::UserInterfaceSwizzler::UserInterfaceSwizzler): Formerly named IPadUserInterfaceSwizzler;
repurposed into general purpose template class, consolidating code from PreferredContentMode.mm.
Privately inherits from InstanceMethodSwizzler instead of using composition as that simplifies
the source code a tiny bit.
(TestWebKitAPI::UserInterfaceSwizzler::effectiveUserInterfaceIdiom): Renamed; formerly padUserInterfaceIdiom.

1:21 PM Changeset in webkit [260448] by Andres Gonzalez

• 4 edits in trunk/Source/WebCore

Fix for remoteParentObject and platformWidget not being stored properly in the AXIsolatedObject attributes variant.
​https://bugs.webkit.org/show_bug.cgi?id=210809

Reviewed by Chris Fleizach.

Adding these properties to the AXIsolatedObject attributes variant as
WeakPtr<void*> fails. So they are now cached as member variables.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::platformWidget const):

• accessibility/isolatedtree/AXIsolatedObject.h:

(WebCore::AXIsolatedObject::propertyValue const): Deleted.

• accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:

(WebCore::AXIsolatedObject::initializePlatformProperties):
(WebCore::AXIsolatedObject::remoteParentObject const):

12:18 PM Changeset in webkit [260447] by Alexey Shvayka

• 6 edits in trunk

constructObjectFromPropertyDescriptor() is incorrect with partial descriptors
​https://bugs.webkit.org/show_bug.cgi?id=184629

Reviewed by Ross Kirsling.

JSTests:

• test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

Before this change, constructObjectFromPropertyDescriptor() serialized a value-only descriptor
with nullish m_seenAttributes to {value, writable: false, enumerable: false, configurable: false}
instead of just {value}. This was observable when ordinarySetSlow() was called on a Proxy
receiver with "defineProperty" trap.

This patch makes constructObjectFromPropertyDescriptor() 1:1 with the spec [2], aligning JSC
with V8 and SpiderMonkey, and also cleans up its call sites from handling exceptions and
undefined value returns.

[1]: ​https://tc39.es/ecma262/#sec-ordinarysetwithowndescriptor (step 3.d.iv)
[2]: ​https://tc39.es/ecma262/#sec-frompropertydescriptor

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyDescriptors):

• runtime/ObjectConstructor.h:

(JSC::constructObjectFromPropertyDescriptor):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::performDefineOwnProperty):

11:42 AM Changeset in webkit [260446] by timothy@apple.com

• 4 edits in trunk

Reset m_userScriptsNotified when web process crashes.
​https://bugs.webkit.org/show_bug.cgi?id=210807

Reviewed by Alex Christensen.

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebPageProxy::resetStateAfterProcessExited): Set m_userScriptsNotified to false.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:

(TEST): Test crashing the web process and reloading.

11:17 AM Changeset in webkit [260445] by Simon Fraser

• 6 edits
  4 adds in trunk

Horizontal overflow overlay scrollbar is misplaced in RTL
​https://bugs.webkit.org/show_bug.cgi?id=210673
<rdar://problem/61950751>

Reviewed by Antti Koivisto.
Source/WebCore:

Code for positioning RenderLayer overflow controls (scrollbars and scroll corner)
was scattered across lots of different functions, making it hard to follow,
and prone to bugs.

Fix by making one source of truth, overflowControlsRects(), which computes
rects for the two scrollbars, the "scroll corner" (the square in the corner which
shows, only for non-overlay scrollbars, when both scrollbars or the resize control
is visible), and the resize control which shows when style specifies the "resize" property.

Call this function in all the places that need to know about overflow control
geometry. RenderLayer::hitTestResizerInFragments() is a little tricky because it wants
the resize control relative to the fragment rect; achieve this by computing the position
of the resizer rect relative to the border box, then shifting it into position relative
to the fragment bounds (which include border).

Test: compositing/overflow/rtl-scrollbar-layer-positioning.html

• page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollCornerRect const):
(WebCore::RenderLayer::overflowControlsRects const):
(WebCore::RenderLayer::scrollbarOffset const):
(WebCore::RenderLayer::invalidateScrollbarRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::overflowControlsIntersectRect const):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::isPointInResizeControl const):
(WebCore::RenderLayer::hitTestOverflowControls):
(WebCore::RenderLayer::hitTestResizerInFragments const):
(WebCore::cornerStart): Deleted.
(WebCore::cornerRect): Deleted.
(WebCore::resizerCornerRect): Deleted.
(WebCore::RenderLayer::scrollCornerAndResizerRect const): Deleted.
(WebCore::RenderLayer::rectForHorizontalScrollbar const): Deleted.
(WebCore::RenderLayer::rectForVerticalScrollbar const): Deleted.
(WebCore::RenderLayer::verticalScrollbarStart const): Deleted.
(WebCore::RenderLayer::horizontalScrollbarStart const): Deleted.

• rendering/RenderLayer.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::requiresScrollCornerLayer const):
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
(WebCore::RenderLayerBacking::paintContents):

LayoutTests:

• compositing/overflow/rtl-scrollbar-layer-positioning-expected.txt: Added.
• compositing/overflow/rtl-scrollbar-layer-positioning.html: Added.
• platform/ios-wk2/compositing/overflow/rtl-scrollbar-layer-positioning-expected.txt: Added.
• platform/mac-wk1/compositing/overflow/rtl-scrollbar-layer-positioning-expected.txt: Added.

11:13 AM Changeset in webkit [260444] by aakash_jain@apple.com

• 4 edits in trunk/Tools

[ews] Display error message when submit for EWS analysis button doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=210803

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-app/ews/views/submittoews.py:

(SubmitToEWS.post): Display relevant error message on submit for EWS analysis button failure.

• BuildSlaveSupport/ews-app/ews/fetcher.py:

(BugzillaPatchFetcher.fetch):
(BugzillaPatchFetcher.send_patches_to_buildbot):

• BuildSlaveSupport/ews-app/ews/config.py: Add few more error codes.

11:10 AM Changeset in webkit [260443] by ysuzuki@apple.com

• 1 edit
  1 move in trunk/JSTests

Move value-pow-ai-rule-should-box-the-same-way-as-the-runtime.js to JSTests/stress/
​https://bugs.webkit.org/show_bug.cgi?id=210805

Reviewed by Saam Barati.

r251408 accidentally puts value-pow-ai-rule-should-box-the-same-way-as-the-runtime.js in JSTests/ instead of JSTests/stress/.
This patch fixes that.

• stress/value-pow-ai-rule-should-box-the-same-way-as-the-runtime.js: Renamed from JSTests/value-pow-ai-rule-should-box-the-same-way-as-the-runtime.js.

10:50 AM Changeset in webkit [260442] by Lauro Moura

• 2 edits
  1 delete in trunk/Tools

[GStreamer][JHBuild] Update to 1.16.2
​https://bugs.webkit.org/show_bug.cgi?id=210730

Reviewed by Philippe Normand.

Moving the bots closer to the flatpak SDK versions.

• gstreamer/jhbuild.modules:
• gstreamer/patches/base-0001-glupload-Add-VideoMetas-and-GLSyncMeta-to-the-raw-up.patch: Removed.

10:48 AM Changeset in webkit [260441] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Fix the build

• Configurations/WebKit.xcconfig:

10:30 AM Changeset in webkit [260440] by ddkilzer@apple.com

• 6 edits in trunk/Source/WebKit

[IPC hardening] ShareableResource::create() should validate its parameters
<​https://webkit.org/b/210779>
<rdar://problem/60887693>

Reviewed by Chris Dumez.

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::store):

• NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord const):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didFinishLoadForQuickLookDocumentInMainFrame):

• Handle nullptr returned from ShareableResource::create().

• Shared/ShareableResource.cpp:

(WebKit::ShareableResource::create):

• Change to return RefPtr<>.
• Validate parameters before calling constructor. Return nullptr on failure.

(WebKit::ShareableResource::ShareableResource):

• Remove assert and comment since checks are now done in ShareableResource::create().
• Shared/ShareableResource.h:

(WebKit::ShareableResource::create):

• Change to return RefPtr<>.

10:28 AM Changeset in webkit [260439] by Alan Coon

• 1 copy in tags/Safari-609.2.9

Tag Safari-609.2.9.

10:27 AM Changeset in webkit [260438] by Alan Coon

• 2 edits in branches/safari-609-branch/Source/WebKitLegacy/win

Cherry-pick r257802. rdar://problem/62093679

[Win] API header file has USE macro
​https://bugs.webkit.org/show_bug.cgi?id=208534

Reviewed by Brent Fulgham.

USE macros should not be used in API header files.

• WebKitCOMAPI.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@257802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:25 AM Changeset in webkit [260437] by Alan Coon

• 8 edits in branches/safari-609-branch/Source

Versioning.

10:20 AM Changeset in webkit [260436] by svillar@igalia.com

• 13 edits
  21 deletes in trunk

Unreviewed, reverting r260432.

Broke WPE build

Reverted changeset:

"[WebXR] Test IDLs and stubs"
​https://bugs.webkit.org/show_bug.cgi?id=209859
​https://trac.webkit.org/changeset/260432

10:14 AM Changeset in webkit [260435] by Chris Dumez

• 5 edits in trunk/Source/WebCore

REGRESSION (r256808): “A problem repeatedly occurred” when attempting to load ​https://bungalow.com/listings/bay-area
​https://bugs.webkit.org/show_bug.cgi?id=210801
<rdar://problem/61658940>

Reviewed by Antti Koivisto.

Even though the page uses the 'async' attribute on the mapbox-gl.js script, deferring the execution of this
script gets the page into a bad state, causing it to use a lot of CPU & memory until the process crashes.
Since we don't have any other evidence of breakage from r256808 yet and since r256808 was a massive PLT
progression, I am opting to add a quirk to disable the async script optimization on bungalow.com for now.

• dom/Document.cpp:

(WebCore::Document::shouldDeferAsynchronousScriptsUntilParsingFinishes const):

• page/Quirks.cpp:

(WebCore::Quirks::shouldBypassAsyncScriptDeferring const):

• page/Quirks.h:
• platform/RegistrableDomain.h:

(WebCore::RegistrableDomain::operator== const):

10:10 AM Changeset in webkit [260434] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Check Structure attributes in Object.assign exhaustively
​https://bugs.webkit.org/show_bug.cgi?id=210782
<rdar://problem/62065853>

Reviewed by Mark Lam.

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorAssign):

9:58 AM Changeset in webkit [260433] by ap@apple.com

• 2 edits in trunk/Tools

Correct the path to libclang_rt.asan_iossim_dynamic.dylib in LC_RPATH
​https://bugs.webkit.org/show_bug.cgi?id=210770
rdar://problem/61904541

Reviewed by Alex Christensen.

• asan/asan.xcconfig:

9:30 AM Changeset in webkit [260432] by svillar@igalia.com

• 13 edits
  16 copies
  5 adds in trunk

[WebXR] Test IDLs and stubs
​https://bugs.webkit.org/show_bug.cgi?id=209859

Reviewed by Dean Jackson and Youenn Fablet.

Source/WebCore:

WebXR testing is hard as it might involve interaction with actual
devices. That's why the WebXR testing
API (​https://immersive-web.github.io/webxr-test-api/) was
proposed. In fact, all the current WebXR tests from
web-platform-tests are using that testing API. This new testing
API supplements navigator.xr and is accessed through
navigator.xr.test.

In order not to expose the API to the web we're adding the XRTest
interface to Internals instead. The mapping from internals.xrTest to
navigator.xr.test happens in the WPT code.

We're adding the required IDLs and very basic (mostly empty)
implementations for testing methods. We're adding testing
infrastructure, adding tests make no sense for this change.

• CMakeLists.txt: Added new files.
• DerivedSources.make: Ditto.
• Modules/webxr/NavigatorWebXR.h: Export API to be used in testing code.
• Modules/webxr/WebXRSystem.h: Export ::from and ::xr methods.
• Sources.txt: Added new files.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• bindings/js/WebCoreBuiltinNames.h: Added some new macros.
• testing/FakeXRBoundsPoint.h: Added.
• testing/FakeXRBoundsPoint.idl: Added.
• testing/FakeXRButtonStateInit.h: Added.
• testing/FakeXRButtonStateInit.idl: Added.
• testing/FakeXRInputSourceInit.h: Added.
• testing/FakeXRInputSourceInit.idl: Added.
• testing/FakeXRRigidTransformInit.h: Added.
• testing/FakeXRRigidTransformInit.idl: Added.
• testing/FakeXRViewInit.h: Added.
• testing/FakeXRViewInit.idl: Added.
• testing/Internals.cpp:

(WebCore::Internals::xrTest): Added WebXRTest to Internals.

• testing/Internals.h: Added xrTest() accessor.
• testing/Internals.idl: Added xrTest attribute.
• testing/WebFakeXRDevice.cpp: Added.

(WebCore::WebFakeXRDevice::setViews):
(WebCore::WebFakeXRDevice::disconnect):
(WebCore::WebFakeXRDevice::setViewerOrigin):
(WebCore::WebFakeXRDevice::clearViewerOrigin):
(WebCore::WebFakeXRDevice::simulateVisibilityChange):
(WebCore::WebFakeXRDevice::setBoundsGeometry):
(WebCore::WebFakeXRDevice::setFloorOrigin):
(WebCore::WebFakeXRDevice::clearFloorOrigin):
(WebCore::WebFakeXRDevice::simulateResetPose):
(WebCore::WebFakeXRDevice::simulateInputSourceConnection):

• testing/WebFakeXRDevice.h: Added.
• testing/WebFakeXRDevice.idl: Added.
• testing/WebFakeXRInputController.cpp: Added.

(WebCore::WebFakeXRInputController::setHandedness):
(WebCore::WebFakeXRInputController::setTargetRayMode):
(WebCore::WebFakeXRInputController::setProfiles):
(WebCore::WebFakeXRInputController::setGripOrigin):
(WebCore::WebFakeXRInputController::clearGripOrigin):
(WebCore::WebFakeXRInputController::setPointerOrigin):
(WebCore::WebFakeXRInputController::disconnect):
(WebCore::WebFakeXRInputController::reconnect):
(WebCore::WebFakeXRInputController::startSelection):
(WebCore::WebFakeXRInputController::endSelection):
(WebCore::WebFakeXRInputController::simulateSelect):
(WebCore::WebFakeXRInputController::setSupportedButtons):
(WebCore::WebFakeXRInputController::updateButtonState):

• testing/WebFakeXRInputController.h: Added.
• testing/WebFakeXRInputController.idl: Added.
• testing/WebXRTest.cpp: Added.

(WebCore::WebXRTest::simulateDeviceConnection const):
(WebCore::WebXRTest::simulateUserActivation):
(WebCore::WebXRTest::disconnectAllDevices):

• testing/WebXRTest.h: Added.

(WebCore::WebXRTest::create):

• testing/WebXRTest.idl: Added.
• testing/XRSimulateUserActivationFunction.h: Added.
• testing/XRSimulateUserActivationFunction.idl: Ditto.

LayoutTests:

• platform/wpe/TestExpectations: Added bug number to the passing webxr test.

9:21 AM Changeset in webkit [260431] by cturner@igalia.com

• 3 edits in trunk/Source/WTF

[Clang 10] Fix warning: definition of implicit copy assignment operator for 'PageBlock' is deprecated because it has a user-declared copy constructor
​https://bugs.webkit.org/show_bug.cgi?id=210748

Reviewed by Adrian Perez de Castro.

Recent Clang's will issue a warning if you declare an explicit
copy construction, but leave the compiler to fill in an implicit
assignment operator. I think this is to catch cases where you do
something exciting in an assignment operator/copy constructor and
forget to do the same exciting thing in the other.

• wtf/PageAllocation.h: Import the base's constructor to avoid

defining our own identical one.

• wtf/PageBlock.h: Remove trivial constructor and replace with

member initializers. Remove copy constructor. This looks identical
to what the compiler would generate anyway.

9:12 AM Changeset in webkit [260430] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Gardening of WPT tests for Intersection Observer v2 after r260388

Unreviewed.

• platform/gtk/TestExpectations: Due to the override for Pass/Fail in the folder above

its needed to repeat the Skip expectation here to avoid the Missing result.

9:05 AM Changeset in webkit [260429] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

[Cocoa] Tighten up some more IPC message checks in WebPasteboardProxy
​https://bugs.webkit.org/show_bug.cgi?id=210780
<rdar://problem/62088479>

Reviewed by Alex Christensen.

Adjust some existing IPC message checks in WebPasteboardProxy, and also introduces some new ones. See below for
more details.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::didModifyContentsOfPasteboard):

Move the pasteboardName check here out of didModifyContentsOfPasteboard, and into each call site, such that
we bail and kill the web process before invoking didModifyContentsOfPasteboard in the case where the name is
empty.

(WebKit::WebPasteboardProxy::getPasteboardPathnamesForType):
(WebKit::WebPasteboardProxy::getPasteboardStringForType):
(WebKit::WebPasteboardProxy::getPasteboardStringsForType):
(WebKit::WebPasteboardProxy::getPasteboardBufferForType):
(WebKit::WebPasteboardProxy::addPasteboardTypes):
(WebKit::WebPasteboardProxy::setPasteboardTypes):
(WebKit::WebPasteboardProxy::setPasteboardURL):
(WebKit::WebPasteboardProxy::setPasteboardColor):
(WebKit::WebPasteboardProxy::setPasteboardStringForType):

Add message checks for empty pasteboard types.

(WebKit::WebPasteboardProxy::setPasteboardBufferForType):
(WebKit::WebPasteboardProxy::writeCustomData):
(WebKit::WebPasteboardProxy::readStringFromPasteboard):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
(WebKit::WebPasteboardProxy::writeURLToPasteboard):
(WebKit::WebPasteboardProxy::writeWebContentToPasteboard):
(WebKit::WebPasteboardProxy::writeImageToPasteboard):
(WebKit::WebPasteboardProxy::writeStringToPasteboard):

Add a message check for empty pasteboard types, but only when the string is also empty; this is because iOS
clears pasteboard data by writing an empty pasteboard string and type.

8:51 AM Changeset in webkit [260428] by Diego Pino Garcia

• 2 edits in trunk/Tools

[Flatpak SDK] Keep env variable 'RESULTS_SERVER_API_KEY'
​https://bugs.webkit.org/show_bug.cgi?id=210798

Reviewed by Philippe Normand.

The variable is needed by several bot steps to upload results.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

8:26 AM Changeset in webkit [260427] by Adrian Perez de Castro

• 7 edits
  1 delete in trunk

[GTK][CMake] Make gtk-unix-print a component of FindGTK.cmake
​https://bugs.webkit.org/show_bug.cgi?id=210792

Reviewed by Carlos Garcia Campos.

.:

• Source/cmake/FindGTK.cmake: Support an "unix-print" component.
• Source/cmake/FindGTKUnixPrint.cmake: Removed.
• Source/cmake/OptionsGTK.cmake: Use the "unix-print" component of the GTK find module.

Source/WebKit:

No new tests needed.

• PlatformGTK.cmake: Use the GTK::UnixPrint imported target.

Tools:

• TestWebKitAPI/glib/PlatformGTK.cmake: Use the GTK::UnixPrint imported target.

6:26 AM Changeset in webkit [260426] by Philippe Normand

• 2 edits in trunk/Tools

[Flatpak SDK] Silence git stderr output
​https://bugs.webkit.org/show_bug.cgi?id=210789

Reviewed by Sergio Villar Senin.

• flatpak/flatpakutils.py:

(WebkitFlatpak.is_branch_build): Don't display git errors, usually
emitted when operating on a SVN checkout.

5:31 AM Changeset in webkit [260425] by Claudio Saavedra

• 4 edits in trunk/Source

[GTK4] Adapt to GtkIconTheme API changes
​https://bugs.webkit.org/show_bug.cgi?id=210745

Reviewed by Adrian Perez de Castro.

Source/WebCore:

No new tests needed.

GtkIconTheme changes in GTK and since we're no longer following
the theme we can drop the missing image from the icon theme, so remove
now unnecessary code.

• platform/graphics/gtk/ImageGtk.cpp:

(WebCore::Image::loadPlatformResource): Directly load image from compiled
GResource.
(WebCore::loadResourceSharedBuffer): Deleted.
(WebCore::loadMissingImageIconFromTheme): Deleted.

Source/WTF:

• wtf/glib/GTypedefs.h: Remove unneeded GtkIconInfo definition.

3:33 AM Changeset in webkit [260424] by svillar@igalia.com

• 4 edits in trunk/LayoutTests/imported/w3c

Import latest changes from web-platform-test/webxr/resources to enable testing in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=210788

Reviewed by Žan Doberšek.

We landed in wpt new code in webxr_utils.js to map internal.xrTest to
navigator.xr.test to be able to run WebXR WPT in WebKit. Import those changes
from upstream in order to be able to run the tests.

Apart from that we take the chance to import the latest fixes to the
files in resources/ directory.

• web-platform-tests/webxr/resources/webxr_test_constants.js: Updated.
• web-platform-tests/webxr/resources/webxr_test_constants_fake_world.js:

(createFakeWorld): Ditto.

• web-platform-tests/webxr/resources/webxr_util.js: Map internals.xrTest

to navigator.xr.test for WebKit browsers.
(xr_debug): Updated.
(async xr_session_promise_test): Ditto.
(xr_promise_test): Deleted.

3:31 AM Changeset in webkit [260423] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Exit early in FrameLoader::loadURL when redirecting to another frame
​https://bugs.webkit.org/show_bug.cgi?id=210751

Patch by Rob Buis <​rbuis@igalia.com> on 2020-04-21
Reviewed by Geoffrey Garen.

Exit early in FrameLoader::loadURL when redirecting to another frame, previously we were preparing
request needlessly, doing it twice in case of frame redirecting. Also move some variables to
where they are actually used.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):

• loader/FrameLoader.h:

3:28 AM Changeset in webkit [260422] by commit-queue@webkit.org

• 2 edits in trunk/JSTests

[ARMv7][EWS] stress/check-stack-overflow-before-value-profiling-arguments.js is failing
​https://bugs.webkit.org/show_bug.cgi?id=210720

Unreviewed gardening.

Skip test on arm since it is failing on EWS, causing significant delays.

Patch by Paulo Matos <Paulo Matos> on 2020-04-21

• stress/check-stack-overflow-before-value-profiling-arguments.js:

2:52 AM Changeset in webkit [260421] by commit-queue@webkit.org

• 8 edits in trunk/JSTests

Re-enable previously skipped mips tests
​https://bugs.webkit.org/show_bug.cgi?id=209964

Patch by Paulo Matos <Paulo Matos> on 2020-04-21
Reviewed by Mark Lam.

Followup to r259454 - where we re-enabled a few stress tests for arm.

• stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js:
• stress/dont-range-based-iterate-vector-that-is-mutated.js:
• stress/ensure-code-block-is-not-precise-allocation.js:
• stress/generator-cell-with-type.js:
• stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js:
• stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js:
• stress/toctou-having-a-bad-time-new-array.js:

1:47 AM Changeset in webkit [260420] by Carlos Garcia Campos

• 3 edits
  1 delete in trunk/Source/WebCore

[GTK] Remove PlatformMouseEventGtk
​https://bugs.webkit.org/show_bug.cgi?id=210743

Reviewed by Adrian Perez de Castro.

It's unused, we no longer create PlatformMouseEvent from a GdkEvent since WebKit2.

• SourcesGTK.txt:
• platform/PlatformMouseEvent.h:
• platform/gtk/PlatformMouseEventGtk.cpp: Removed.

1:41 AM Changeset in webkit [260419] by Philippe Normand

• 5 edits in trunk

Source/WebKit:
[CMake] gst-build-backed build fails
​https://bugs.webkit.org/show_bug.cgi?id=210742

Reviewed by Xabier Rodriguez-Calvar.

• PlatformWPE.cmake:

Tools:
[CMake][Flatpak SDK] gst-build-backed build fails
​https://bugs.webkit.org/show_bug.cgi?id=210742

Reviewed by Xabier Rodriguez-Calvar.

Add non-core GStreamer include-dirs necessary for the compilation
of the GStreamer API test. Usually GSTREAMER_INCLUDE_DIRS is
sufficient because on a GStreamer system-wide installation, all
headers are stored in the same root include dir, the same as the
core GStreamer library.

But when building with gst-build, include-dirs are scattered all
over the place.

• TestWebKitAPI/PlatformGTK.cmake:
• TestWebKitAPI/PlatformWPE.cmake:

1:38 AM Changeset in webkit [260418] by Claudio Saavedra

• 2 edits in trunk/Source/WebCore

[GTK4] Fix platform GDK includes
​https://bugs.webkit.org/show_bug.cgi?id=210746

Reviewed by Carlos Garcia Campos.

• platform/graphics/PlatformDisplay.cpp: Wayland, X11, etc.

platform includes changed path, so update accordingly.

12:48 AM Changeset in webkit [260417] by Adrian Perez de Castro

• 13 edits in trunk/Source

Non-unified build fixes late February 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=210767

Unreviewed build fix.

Source/JavaScriptCore:

• dfg/DFGValueRepReductionPhase.cpp: Add missing JSCJSValueInlines.h header.
• jit/JITCall.cpp: Add missing SlowPathCall.h header.
• runtime/AggregateError.cpp: Add missing JSCJSValueInlines.h, JSCellInlines.h, and

JSGlobalObjectInlines.h headers.

• runtime/AggregateErrorConstructor.cpp: Added missing JSCJSValueInlines.h, JSCellInlines.h,

and VMInlines.h headers.

• runtime/AggregateErrorPrototype.cpp: Added missing AggregateError.h, IdentifierInlines.h,

JSCJSValueInlines.h, JSCellInlines.h, JSGlobalObjectInlines.h, and VMInlines.h headers.

• runtime/Intrinsic.h: Added missing wtf/Optional.h header.

Source/WebCore:

No new tests needed.

• css/MediaQueryListEvent.cpp: Add missing wtf/IsoMallocInlines.h header.
• css/MediaQueryMatcher.cpp: Add missing MediaQueryListEvent.h header.
• platform/graphics/FloatQuad.cpp: Add missing wtf/text/TextStream.h header.

Source/WebKit:

• NetworkProcess/NetworkResourceLoadMap.h: Add missing wtf/Function.h header.

Apr 20, 2020:

11:59 PM Changeset in webkit [260416] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Gardening, update expectations after r260356
​https://bugs.webkit.org/show_bug.cgi?id=210786

Unreviewed gardening.

• platform/gtk/TestExpectations:

11:11 PM Changeset in webkit [260415] by Ross Kirsling

• 222 edits in trunk

Classes marked final should not use protected access specifier
​https://bugs.webkit.org/show_bug.cgi?id=210775

Reviewed by Daniel Bates.

Source/JavaScriptCore:

• API/JSAPIValueWrapper.h:
• API/JSCallbackConstructor.h:
• API/JSCallbackObject.h:
• b3/B3ExtractValue.h:
• bytecode/UnlinkedFunctionExecutable.h:
• inspector/JSGlobalObjectConsoleClient.h:
• inspector/JSInjectedScriptHost.h:
• inspector/JSJavaScriptCallFrame.h:
• jsc.cpp:
• runtime/AggregateError.h:
• runtime/AggregateErrorPrototype.h:
• runtime/ArrayConstructor.h:
• runtime/ArrayPrototype.h:
• runtime/AsyncFunctionPrototype.h:
• runtime/AsyncGeneratorFunctionPrototype.h:
• runtime/AtomicsObject.h:
• runtime/BigIntConstructor.h:
• runtime/BigIntObject.h:
• runtime/BigIntPrototype.h:
• runtime/BooleanConstructor.h:
• runtime/BooleanPrototype.h:
• runtime/ConsoleObject.h:
• runtime/DateConstructor.h:
• runtime/DatePrototype.h:
• runtime/ErrorConstructor.h:
• runtime/ErrorPrototype.h:
• runtime/FileBasedFuzzerAgent.h:
• runtime/FunctionPrototype.h:
• runtime/FunctionRareData.h:
• runtime/GeneratorFunctionPrototype.h:
• runtime/GenericTypedArrayView.h:
• runtime/InspectorInstrumentationObject.h:
• runtime/IntlCollator.h:
• runtime/IntlCollatorConstructor.h:
• runtime/IntlCollatorPrototype.h:
• runtime/IntlDateTimeFormat.h:
• runtime/IntlDateTimeFormatConstructor.h:
• runtime/IntlDateTimeFormatPrototype.h:
• runtime/IntlNumberFormat.h:
• runtime/IntlNumberFormatConstructor.h:
• runtime/IntlNumberFormatPrototype.h:
• runtime/IntlPluralRules.h:
• runtime/IntlPluralRulesConstructor.h:
• runtime/IntlPluralRulesPrototype.h:
• runtime/IntlRelativeTimeFormatConstructor.h:
• runtime/IntlRelativeTimeFormatPrototype.h:
• runtime/JSArrayBuffer.h:
• runtime/JSArrayBufferConstructor.h:
• runtime/JSArrayBufferPrototype.h:
• runtime/JSAsyncGenerator.h:
• runtime/JSBoundFunction.h:
• runtime/JSCustomGetterSetterFunction.h:
• runtime/JSDataView.h:
• runtime/JSDataViewPrototype.h:
• runtime/JSGenerator.h:
• runtime/JSGenericTypedArrayView.h:
• runtime/JSGenericTypedArrayViewConstructor.h:
• runtime/JSGenericTypedArrayViewPrototype.h:
• runtime/JSGlobalLexicalEnvironment.h:
• runtime/JSModuleLoader.h:
• runtime/JSModuleNamespaceObject.h:
• runtime/JSNativeStdFunction.h:
• runtime/JSONObject.h:
• runtime/JSObject.h:
• runtime/JSTemplateObjectDescriptor.h:
• runtime/JSTypedArrayViewConstructor.h:
• runtime/JSTypedArrayViewPrototype.h:
• runtime/MathObject.h:
• runtime/NativeExecutable.h:
• runtime/NumberConstructor.h:
• runtime/NumberPrototype.h:
• runtime/ObjectConstructor.h:
• runtime/ObjectPrototype.h:
• runtime/PredictionFileCreatingFuzzerAgent.h:
• runtime/ReflectObject.h:
• runtime/RegExp.h:
• runtime/RegExpConstructor.h:
• runtime/RegExpObject.h:
• runtime/RegExpPrototype.h:
• runtime/StringPrototype.h:
• runtime/Structure.h:
• runtime/Symbol.h:
• runtime/SymbolConstructor.h:
• runtime/SymbolObject.h:
• runtime/SymbolPrototype.h:
• runtime/VMTraps.cpp:
• testRegExp.cpp:
• wasm/WasmBBQPlan.h:
• wasm/WasmLLIntPlan.h:
• wasm/WasmWorklist.cpp:
• wasm/js/JSWebAssembly.h:
• wasm/js/JSWebAssemblyCompileError.h:
• wasm/js/JSWebAssemblyInstance.h:
• wasm/js/JSWebAssemblyLinkError.h:
• wasm/js/JSWebAssemblyRuntimeError.h:
• wasm/js/WebAssemblyCompileErrorConstructor.h:
• wasm/js/WebAssemblyCompileErrorPrototype.h:
• wasm/js/WebAssemblyGlobalConstructor.h:
• wasm/js/WebAssemblyGlobalPrototype.h:
• wasm/js/WebAssemblyInstanceConstructor.h:
• wasm/js/WebAssemblyInstancePrototype.h:
• wasm/js/WebAssemblyLinkErrorConstructor.h:
• wasm/js/WebAssemblyLinkErrorPrototype.h:
• wasm/js/WebAssemblyMemoryConstructor.h:
• wasm/js/WebAssemblyMemoryPrototype.h:
• wasm/js/WebAssemblyModuleConstructor.h:
• wasm/js/WebAssemblyModulePrototype.h:
• wasm/js/WebAssemblyRuntimeErrorConstructor.h:
• wasm/js/WebAssemblyRuntimeErrorPrototype.h:
• wasm/js/WebAssemblyTableConstructor.h:
• wasm/js/WebAssemblyTablePrototype.h:
• wasm/js/WebAssemblyWrapperFunction.h:

Source/WebCore:

• Modules/applepay/ApplePayPaymentMethodSelectedEvent.h:
• Modules/applepay/ApplePayValidateMerchantEvent.h:
• Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h:
• Modules/webaudio/BiquadDSPKernel.h:
• Modules/webaudio/WaveShaperDSPKernel.h:
• Modules/websockets/WebSocketChannel.h:
• Modules/websockets/WorkerThreadableWebSocketChannel.h:
• Modules/webxr/WebXRSession.h:
• Modules/webxr/WebXRSystem.h:
• accessibility/AccessibilityARIAGridCell.h:
• accessibility/AccessibleSetValueEvent.h:
• animation/CSSAnimation.h:
• bindings/js/ReadableStream.h:
• bridge/objc/objc_runtime.h:
• bridge/runtime_array.h:
• css/CSSImageSetValue.h:
• html/HTMLKeygenElement.cpp:
• html/canvas/WebGLBuffer.h:
• html/canvas/WebGLFramebuffer.h:
• html/canvas/WebGLProgram.h:
• html/canvas/WebGLQuery.h:
• html/canvas/WebGLRenderbuffer.h:
• html/canvas/WebGLSampler.h:
• html/canvas/WebGLSync.h:
• html/canvas/WebGLTransformFeedback.h:
• html/canvas/WebGLUniformLocation.h:
• html/shadow/TextControlInnerElements.h:
• inspector/InspectorStyleSheet.h:
• inspector/WebInjectedScriptManager.h:
• loader/cache/CachedCSSStyleSheet.h:
• page/Frame.h:
• page/FrameView.h:
• page/PageConsoleClient.h:
• page/animation/KeyframeAnimation.h:
• page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.h:
• platform/audio/AudioBus.h:
• platform/cocoa/PlaybackSessionModelMediaElement.h:
• platform/graphics/BitmapImage.h:
• platform/graphics/CrossfadeGeneratedImage.h:
• platform/graphics/NamedImageGeneratedImage.h:
• platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
• platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h:
• platform/graphics/ca/win/PlatformCAAnimationWin.h:
• platform/graphics/cg/ImageDecoderCG.h:
• platform/graphics/iso/ISOOriginalFormatBox.h:
• platform/graphics/iso/ISOProtectionSchemeInfoBox.h:
• platform/graphics/iso/ISOSchemeInformationBox.h:
• platform/graphics/iso/ISOSchemeTypeBox.h:
• platform/graphics/iso/ISOTrackEncryptionBox.h:
• platform/graphics/iso/ISOVTTCue.cpp:
• platform/graphics/iso/ISOVTTCue.h:
• platform/graphics/win/ImageDecoderDirect2D.h:
• platform/mediastream/mac/AVCaptureDeviceManager.h:
• platform/mock/mediasource/MockBox.h:
• platform/mock/mediasource/MockSourceBufferPrivate.cpp:
• rendering/RenderFullScreen.h:
• rendering/RenderGrid.h:
• rendering/RenderMultiColumnSet.h:
• rendering/RenderRuby.h:
• rendering/RenderScrollbarPart.h:
• rendering/RenderScrollbarTheme.h:
• rendering/RenderTableCell.h:
• rendering/RenderTableSection.h:
• rendering/RenderThemeIOS.h:
• rendering/RenderView.h:
• rendering/svg/RenderSVGResourceClipper.h:
• svg/SVGTextPathElement.h:
• workers/WorkerConsoleClient.h:
• worklets/Worklet.h:

Source/WebKit:

• Shared/API/APIDictionary.h:
• WebProcess/GPU/media/TextTrackPrivateRemote.h:
• WebProcess/Plugins/Netscape/JSNPMethod.h:
• WebProcess/Plugins/Netscape/JSNPObject.h:

Source/WebKitLegacy:

• WebCoreSupport/WebResourceLoadScheduler.h:

Source/WebKitLegacy/win:

• DefaultDownloadDelegate.h:
• DefaultPolicyDelegate.h:
• MemoryStream.h:
• WebApplicationCache.h:
• WebArchive.h:
• WebBackForwardList.h:
• WebCache.h:
• WebCoreStatistics.h:
• WebDataSource.h:
• WebElementPropertyBag.h:
• WebError.h:
• WebFrame.h:
• WebFramePolicyListener.h:
• WebHTMLRepresentation.h:
• WebHistoryItem.h:
• WebJavaScriptCollector.h:
• WebKitClassFactory.h:
• WebKitStatistics.h:
• WebMutableURLRequest.h:
• WebNotification.h:
• WebNotificationCenter.h:
• WebPreferences.h:
• WebResource.h:
• WebURLAuthenticationChallenge.h:
• WebURLCredential.h:
• WebURLProtectionSpace.h:
• WebURLResponse.h:

Tools:

• DumpRenderTree/win/DefaultPolicyDelegate.h:
• DumpRenderTree/win/UIDelegate.h:

9:51 PM Changeset in webkit [260414] by ysuzuki@apple.com

• 1 edit
  14 adds in trunk/JSTests

[JSC] Import V8 BigInt tests generated by bigint-tester.py
​https://bugs.webkit.org/show_bug.cgi?id=210783

Reviewed by Ross Kirsling.

This patch adds BigInt tests generated by V8 bigint-tester.py, which is modified for JSC use.

• stress/v8-bigint-add.js: Added.
• stress/v8-bigint-and.js: Added.
• stress/v8-bigint-dec.js: Added.
• stress/v8-bigint-div.js: Added.
• stress/v8-bigint-inc.js: Added.
• stress/v8-bigint-mod.js: Added.
• stress/v8-bigint-mul.js: Added.
• stress/v8-bigint-neg.js: Added.
• stress/v8-bigint-not.js: Added.
• stress/v8-bigint-or.js: Added.
• stress/v8-bigint-sar.js: Added.
• stress/v8-bigint-shl.js: Added.
• stress/v8-bigint-sub.js: Added.
• stress/v8-bigint-xor.js: Added.

9:48 PM Changeset in webkit [260413] by timothy_horton@apple.com

• 2 edits in trunk/Source/WTF

Try to fix the build after r260407

• wtf/PlatformHave.h:

9:06 PM Changeset in webkit [260412] by Peng Liu

• 22 edits in trunk

Fix build failures when video fullscreen and picture-in-picture is disabled
​https://bugs.webkit.org/show_bug.cgi?id=210777

Reviewed by Eric Carlson.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Wrap video fullscreen and picture-in-picture related code with "#if ENABLE(VIDEO_PRESENTATION_MODE)".

• Configurations/FeatureDefines.xcconfig:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):

• platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
• platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:

(WebCore::VideoLayerManagerObjC::setVideoLayer):
(WebCore::VideoLayerManagerObjC::requiresTextTrackRepresentation const):
(WebCore::VideoLayerManagerObjC::syncTextTrackBounds):
(WebCore::VideoLayerManagerObjC::setTextTrackRepresentation):

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Wrap video fullscreen and picture-in-picture related code with "#if ENABLE(VIDEO_PRESENTATION_MODE)".

• Configurations/FeatureDefines.xcconfig:
• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenGravity):
(WebKit::RemoteMediaPlayerProxy::updateVideoFullscreenInlineImage):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenMode):
(WebKit::RemoteMediaPlayerProxy::videoFullscreenStandbyChanged):
(WebKit::RemoteMediaPlayerProxy::setBufferingPolicy):

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
• GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:

(WebKit::RemoteMediaPlayerProxy::prepareForPlayback):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::prepareForPlayback):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/PlatformEnable.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

9:04 PM Changeset in webkit [260411] by Ross Kirsling

• 9 edits in trunk/Source/JavaScriptCore

Intl classes shouldn't need an m_initialized* field
​https://bugs.webkit.org/show_bug.cgi?id=210764

Reviewed by Darin Adler.

Existing Intl classes each have a field like m_initializedNumberFormat, but this is unnecessary on two levels:

1. The thing that gets initialized is a unique pointer to an ICU struct, so we can check it directly.
2. Everywhere we're checking this is redundant since we've already done the same check on the prototype side, therefore we can just ASSERT before using said ICU struct.

While we're at it, clean up other stuff like:

• Move stuff that doesn't need to be part of the class to the CPP file (e.g. UFieldPositionIteratorDeleter).
• Merge createCollator into initializeCollator (seems like this is probably the oldest code in this space).

• runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):
(JSC::IntlCollator::compareStrings):
(JSC::IntlCollator::resolvedOptions):
(JSC::IntlCollator::createCollator): Deleted.

• runtime/IntlCollator.h:
• runtime/IntlDateTimeFormat.cpp:

(JSC::UFieldPositionIteratorDeleter::operator() const):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::resolvedOptions):
(JSC::IntlDateTimeFormat::format):
(JSC::partTypeString):
(JSC::IntlDateTimeFormat::formatToParts):
(JSC::IntlDateTimeFormat::UFieldPositionIteratorDeleter::operator() const): Deleted.
(JSC::IntlDateTimeFormat::partTypeString): Deleted.

• runtime/IntlDateTimeFormat.h:
• runtime/IntlNumberFormat.cpp:

(JSC::UFieldPositionIteratorDeleter::operator() const):
(JSC::IntlNumberFormatField::IntlNumberFormatField):
(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::format):
(JSC::IntlNumberFormat::resolvedOptions):
(JSC::partTypeString):
(JSC::IntlNumberFormat::formatToParts):
(JSC::IntlNumberFormat::UFieldPositionIteratorDeleter::operator() const): Deleted.
(JSC::IntlNumberFormat::partTypeString): Deleted.

• runtime/IntlNumberFormat.h:
• runtime/IntlPluralRules.cpp:

(JSC::localeData):
(JSC::IntlPluralRules::initializePluralRules):
(JSC::IntlPluralRules::resolvedOptions):
(JSC::IntlPluralRules::select):
(JSC::IntlPRInternal::localeData): Deleted.

• runtime/IntlPluralRules.h:

8:23 PM Changeset in webkit [260410] by commit-queue@webkit.org

• 18 edits in trunk

SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
​https://bugs.webkit.org/show_bug.cgi?id=210533

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-20
Reviewed by Brady Eidson.

Source/WebKit:

• NetworkProcess/NetworkDataTask.h:

(WebKit::NetworkDataTaskClient::didNegotiateModernTLS):

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didNegotiateModernTLS):

• NetworkProcess/NetworkLoad.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::didNegotiateModernTLS):

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):

• UIProcess/API/APINavigationClient.h:

(API::NavigationClient::didNegotiateModernTLS):

• UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
• UIProcess/Cocoa/NavigationState.h:
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::didNegotiateModernTLS):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didNegotiateModernTLS):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(-[TLSNavigationDelegate waitForDidNegotiateModernTLS]):
(-[TLSNavigationDelegate _webView:didNegotiateModernTLS:]):
(TestWebKitAPI::TEST):

7:52 PM Changeset in webkit [260409] by ysuzuki@apple.com

• 2 edits in trunk/Source/WTF

Add document about WTF malloc-related macros
​https://bugs.webkit.org/show_bug.cgi?id=208367

Reviewed by Anders Carlsson, Simon Fraser, and Darin Adler.

This adds document about WTF malloc-related macros since we have bunch of macros now.

• wtf/FastMalloc.h:

7:36 PM Changeset in webkit [260408] by Kate Cheney

• 5 edits in trunk

App-bound domain behavior should abide by the limitsNavigationsToAppBoundDomains argument in WKWebView configuration
​https://bugs.webkit.org/show_bug.cgi?id=210769
<rdar://problem/62065241>

Reviewed by Brent Fulgham.

Source/WebKit:

Changes app-bound domain behavior to be triggered by the value of
limitsNavigationsToAppBoundDomains, a WebView configuration flag.
If the WebView has this parameter set and is currently navigating to
an app bound domain, then app-bound privileges will be granted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomainAndCheckIfPermitted):
Update this function to return a boolean to indicate whether the
navigation should fail. A failure should occur if a WebView has set
the limitsNavigationsToAppBoundDomains flag and attempts to navigate
away from an app-bound domain.

If the limitsNavigationsToAppBoundDomains value has not been set to
true, maintain non-app bound behavior regardless of whether the domain
is app-bound or not.

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Check the result of setIsNavigatingToAppBoundDomainAndCheckIfPermitted and fail the
navigation if needed, with both RELEASE logging and an appropriate
error message.

(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain): Deleted.

• UIProcess/WebPageProxy.h:

Renamed for clarity.

Tools:

Removes any tests for swapping between app-bound and non app-bound
domains as this behavior is no longer supported.

Sets the limitsNavigationsToAppBoundDomains flag for tests which should
have app-bound behavior to maintain test functionality.

Adds 5 new tests for new behavior.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(TEST):
(-[AppBoundDomainDelegate webView:didFinishNavigation:]):
(-[AppBoundDomainDelegate webView:didFailProvisionalNavigation:withError:]):
(-[AppBoundDomainDelegate waitForDidFinishNavigation]):
(-[AppBoundDomainDelegate waitForDidFailProvisionalNavigationError]):

5:27 PM Changeset in webkit [260407] by Nikos Mouchtaris

• 16 edits
  2 adds in trunk/Source

WK2 Quicklook for attachments
​https://bugs.webkit.org/show_bug.cgi?id=208891

Reviewed by Darin Adler.

Source/WebCore:

Added to HTMLAttachmentElement to have member image representing
QuickLook thumbnail. Added code to render this image on both iOS and Mac.

No new tests. Test will be added after additions to test infrastructure.

• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::updateThumbnailRepresentation):
Allow setting of thumbnail member.

• html/HTMLAttachmentElement.h:
• rendering/RenderThemeIOS.mm:

Added rendering of image member of attachment element.
(WebCore::RenderAttachmentInfo::RenderAttachmentInfo):
(WebCore::paintAttachmentIcon):
(WebCore::RenderThemeIOS::paintAttachment):

• rendering/RenderThemeMac.mm:

(WebCore::paintAttachmentIcon):

Source/WebKit:

Allow attachment elements to render QuickLook thumbnail generated
from contents of the file as its icon, rather than the default
icons associated with each mime type.

• Configurations/WebKit.xcconfig:

Link QuickLook thumbnailing framework.

• UIProcess/API/APIAttachment.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _insertAttachmentWithFileWrapper:contentType:completion:]):

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

Create thumbnail request and add to queue.
(WebKit::convertNSImageToBitmap):
(WebKit::convertUIImageToBitmap):
(WebKit::WebPageProxy::getQLThumbnailForGenerationRequestion):
(WebKit::WebPageProxy::getQLThumbnailForFileWrapper):
(WebKit::WebPageProxy::getQLThumbnailForAttachment):

• UIProcess/QLThumbnailLoad.h: Added.
• UIProcess/QLThumbnailLoad.mm: Added.

Add code to request thumbnail for file data.
(-[WKQLThumbnailQueueManager init]):
(+[WKQLThumbnailQueueManager sharedInstance]):
(-[WKQLThumbnailLoadOperation initWithAttachment:identifier:]):
(-[WKQLThumbnailLoadOperation initWithURL:identifier:]):
(-[WKQLThumbnailLoadOperation start]):
(-[WKQLThumbnailLoadOperation isAsynchronous]):
(-[WKQLThumbnailLoadOperation isExecuting]):
(-[WKQLThumbnailLoadOperation setExecuting:]):
(-[WKQLThumbnailLoadOperation isFinished]):
(-[WKQLThumbnailLoadOperation setFinished:]):

• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateAttachmentIcon):
Set thumbnail of attachment element

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Thumbnail request message.

5:03 PM Changeset in webkit [260406] by Alan Coon

• 2 edits in branches/safari-610.1.11-branch/Source/WebKit

Unreviewed macCatalyst build fix.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::disableServiceWorkerEntitlementInNetworkProcess):
(WebKit::WebPageProxy::clearServiceWorkerEntitlementOverride):

4:08 PM Changeset in webkit [260405] by Kate Cheney

• 2 edits in trunk/Source/WebKit

Unreviewed macCatalyst build fix.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::disableServiceWorkerEntitlementInNetworkProcess):
(WebKit::WebPageProxy::clearServiceWorkerEntitlementOverride):

3:32 PM Changeset in webkit [260404] by ysuzuki@apple.com

• 6 edits in trunk

Add more structure-cloning tests for BigInt
​https://bugs.webkit.org/show_bug.cgi?id=210765

Reviewed by Mark Lam.

Source/WebCore:

This patch adds safe-guard for future JSC primitive extension for structure-cloning.
We throw DataCloneError if we see unknown primitive value, which can happen if JSC
extends primitive value.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpImmediate):
(WebCore::CloneSerializer::dumpIfTerminal):

LayoutTests:

Add more tests for BigInt outside of WPT (they are already tested in WPT, but this adds more tests).

• fast/dom/Window/window-postmessage-clone-expected.txt:
• fast/dom/Window/window-postmessage-clone.html:
• platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:

2:55 PM Changeset in webkit [260403] by Simon Fraser

• 16 edits
  2 adds in trunk

Scrolling with background-attachment: fixed needs to trigger repaints
​https://bugs.webkit.org/show_bug.cgi?id=193893
<rdar://problem/47587017>

Reviewed by Dean Jackson.

Source/WebCore:

When scrolling an overflow scroll which has "background-atttachment:fixed" in the content,
the node will have non-empty synchronous scrolling reasons. In this case we need to
send the scroll to the main thread, and trigger a repaint on scroll.

If handling the wheel event on the scrolling thread determines that the scroll must be sent
to the main thread, EventDispatcher::wheelEvent() does so in the callback function.

To trigger the repaint, RenderLayer::scrollTo() asks the composited layers backing whether
the node has synchronous scrolling reasons; this is implemented by asking the scrolling
coordinator.

Test: scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-repaint.html

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::hasSynchronousScrollingReasons const):

• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::hasSynchronousScrollingReasons const):

• page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::hasSynchronousScrollingReasons const):

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent):

• page/scrolling/ScrollingTreeScrollingNode.h:
• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::currentScrollPositionChanged):

• page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:

(WebCore::ScrollingTreeOverflowScrollingNodeMac::handleWheelEvent): Return SendToMainThread if this node
needs to do synchronous scrolling.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::needsRepaintOnCompositedScroll const):
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):

• rendering/RenderLayerBacking.h:

Source/WebKit:

When scrolling an overflow scroll which has "background-atttachment:fixed" in the content,
the node will have non-empty synchronous scrolling reasons. In this case we need to
send the scroll to the main thread, and trigger a repaint on scroll.

If handling the wheel event on the scrolling thread determines that the scroll must be sent
to the main thread, EventDispatcher::wheelEvent() does so in the callback function.

To trigger the repaint, RenderLayer::scrollTo() asks the composited layers backing whether
the node has synchronous scrolling reasons; this is implemented by asking the scrolling
coordinator.

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

LayoutTests:

• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-repaint-expected.html: Added.
• scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-repaint.html: Added.

2:45 PM Changeset in webkit [260402] by Megan Gardner

• 14 edits
  2 adds in trunk

Date and Time form controls not showing correct initial values on immediate second invocation.
​https://bugs.webkit.org/show_bug.cgi?id=210613

Reviewed by Wenson Hsieh.

Source/WebKit:

Updating the webprocess with the newly picked time did not update the local store of that data in the
UI process, so when the control was activated a second time, and we skipped the round trip to the
webprocess to get the data we were certian we already had, we did not start the popover in the
correct state. We now update the webprocess and the local UI stored variable at the same time.

Test: fast/forms/ios/time-picker-value-change.html

• UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
• UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView timePickerValueHour]):
(-[WKWebView timePickerValueMinute]):

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView updateValueAsNumberForViewController:]):
(-[WKContentView updateValueForViewController:]):
(-[WKContentView setTimePickerValueToHour:minute:]):
(-[WKContentView timePickerValueHour]):
(-[WKContentView timePickerValueMinute]):

• UIProcess/ios/forms/WKFormInputControl.h:
• UIProcess/ios/forms/WKFormInputControl.mm:

(-[WKDateTimePicker hour]):
(-[WKDateTimePicker minute]):
(-[WKDateTimePicker _dateChangedSetAsNumber]):
(-[WKDateTimePicker _dateChangedSetAsString]):
(-[WKDateTimePicker setHour:minute:]):
(-[WKFormInputControl setTimePickerHour:minute:]):
(-[WKFormInputControl timePickerValueHour]):
(-[WKFormInputControl timePickerValueMinute]):
(-[WKDateTimePopover setHour:minute:]):
(-[WKDateTimePopover hour]):
(-[WKDateTimePopover minute]):

Tools:

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::timePickerValueHour const):
(WTR::UIScriptController::timePickerValueMinute const):

• WebKitTestRunner/ios/UIScriptControllerIOS.h:
• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::timePickerValueHour const):
(WTR::UIScriptControllerIOS::timePickerValueMinute const):

LayoutTests:

• fast/forms/ios/time-picker-value-change-expected.txt: Added.
• fast/forms/ios/time-picker-value-change.html: Added.
• resources/ui-helper.js:

(window.UIHelper.timerPickerValues):

2:42 PM Changeset in webkit [260401] by Alan Coon

• 2 edits in branches/safari-610.1.11-branch/Source/WebKit

Try to fix the macCatalyst build after r260366

• UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:

2:29 PM Changeset in webkit [260400] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Try to fix the macCatalyst build after r260366

• UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:

2:17 PM Changeset in webkit [260399] by clopez@igalia.com

• 3 edits in trunk/LayoutTests

Skip tests related with missing reftest-wait support for imported WPT tests.

Unreviewed gardening.

Also fix a few typos on the bug numbers for the expectations.

• TestExpectations:
• platform/gtk/TestExpectations:

2:14 PM Changeset in webkit [260398] by Russell Epstein

• 1 copy in tags/Safari-609.2.8

Tag Safari-609.2.8.

2:05 PM Changeset in webkit [260397] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

FTL doesn't observe the use kind of CheckIsConstant's child1
​https://bugs.webkit.org/show_bug.cgi?id=210763

Reviewed by Yusuke Suzuki.

Somehow, this didn't get added when I changed CheckIsConstant and didn't show up
when I tested r260377 because I tested in release. Fortunately, the produced
DFG IR will be the same.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCheckIsConstant):

1:38 PM Changeset in webkit [260396] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

MSVC: LayoutUnits.h(248): warning C4245: 'argument': conversion from 'const int' to 'size_t', signed/unsigned mismatch
​https://bugs.webkit.org/show_bug.cgi?id=210592

Reviewed by Zalan Bujtas.

• layout/LayoutUnits.h:

(WTF::HashTraits<WebCore::Layout::SlotPosition>::emptyValue):
(WTF::HashTraits<WebCore::Layout::SlotPosition>::constructDeletedValue):
(WTF::HashTraits<WebCore::Layout::SlotPosition>::isDeletedValue):
Use std::numeric_limits<size_t>::max() for empty and deleted
values instead of WebCore::intMinForLayoutUnit.

1:35 PM Changeset in webkit [260395] by Alan Coon

• 1 copy in branches/safari-610.1.11-branch

New branch.

1:35 PM Changeset in webkit [260394] by Alan Coon

• 1 delete in branches/safari-610.1.11-branch

Delete branch.

1:19 PM Changeset in webkit [260393] by Wenson Hsieh

• 4 edits in trunk

Text manipulation sometimes fails to replace text in title elements
​https://bugs.webkit.org/show_bug.cgi?id=210750
<rdar://problem/61066103>

Reviewed by Tim Horton and Darin Adler.

Source/WebCore:

Internal clients using WebKit text manipulation APIs currently fail to replace text in title and option elements
in the case where text manipulation has been completed with more than one token. These are elements for which we
want to replace the entire text as a single token, even if the text manipulation client ends up breaking the
token into multiple chunks.

To handle this case, pull the title || option check out into a helper function, and consult it when completing
text manipulation in the case where the manipulation data lacks either start or end positions. If
canPerformTextManipulationByReplacingEntireTextContent is true and there are multiple replacement tokens,
allow ourselves to process the replacement by combining the replacement tokens into a space-separated string.

Test: TextManipulation.CompleteTextManipulationShouldReplaceTextContentWithMultipleTokens

• editing/TextManipulationController.cpp:

(WebCore::canPerformTextManipulationByReplacingEntireTextContent):
(WebCore::TextManipulationController::observeParagraphs):
(WebCore::TextManipulationController::replace):

Tools:

Add a new API test to verify that a single title or option element may be replaced with multiple tokens, as long
as all the token identifiers match.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

1:11 PM Changeset in webkit [260392] by Andres Gonzalez

• 2 edits in trunk/Source/WebCore

The rect for the primary screen should be retrieved on the main thread.
​https://bugs.webkit.org/show_bug.cgi?id=210760

Reviewed by Chris Fleizach.

• Call to screenRectForPrimaryScreen is dispatched to main thread.
• This value is cached since it is very unlikely to change in normal

usage and this would avoid hitting the main thread repeatedly.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper primaryScreenHeight]):

1:09 PM Changeset in webkit [260391] by stephan.szabo@sony.com

• 2 edits in trunk/Source/WebKit

Fix build when !ENABLE(RESOURCE_LOAD_STATISTICS)
​https://bugs.webkit.org/show_bug.cgi?id=210757

Reviewed by Ross Kirsling.

Build fix, no new tests

• NetworkProcess/NetworkDataTask.cpp:

Add ENABLE(RESOURCE_LOAD_STATISTICS) around block
using NetworkSession functions only declared when
that is enabled.

1:04 PM Changeset in webkit [260390] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

When SpeculativeLoadManager is destroyed, properly clean up its PendingFrameLoads
​https://bugs.webkit.org/show_bug.cgi?id=210759
<rdar://problem/62056856>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-20
Reviewed by Darin Adler.

Recent work on the resourceLoadStatistics layout tests increased the amount we swap out the WebsiteDataStore.
When this happens, the NetworkSession is eventually destroyed in the NetworkProcess, sometimes when running the next test.
An assertion was firing in the PendingFrameLoad destructor because it hadn't been marked as complete when it was destroyed.
Rather than remove the assertion, when we destroy the SpeculativeLoadManager (which only happens when a WebsiteDataStore
is destroyed) during a speculative pending frame load, just mark the pending frame load as complete because it is being cancelled.
Marking the pending frame load as complete can tell the SpeculativeLoadManager to mutate m_pendingFrameLoads, which we don't want
to do while iterating, so copy the RefPtrs into a Vector first then iterate that to get them all.

This fixes an assertion that was sometimes hit in http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-prevalent-subresource-redirects-database.html
but only after running other tests that had initiated speculative pending frame loads. This was ostensibly started by r260322 but is quite unrelated.

• NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::SpeculativeLoadManager::~SpeculativeLoadManager):

12:56 PM Changeset in webkit [260389] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK][WPE] Gardening, update expectations after r260322
​https://bugs.webkit.org/show_bug.cgi?id=210761

Unreviewed gardening.

• platform/gtk/TestExpectations:

12:44 PM Changeset in webkit [260388] by clopez@igalia.com

• 6 edits in trunk/LayoutTests

Clean and merge test expectations for WPT tests for Intersection Observer v2.

Unreviewed gardening.

Merge the expectations for the tests cross-origin-effects.sub.html
and cross-origin-occlusion.sub.html on the common TestExpectations file.

• TestExpectations:
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:
• platform/wpe/TestExpectations:

12:37 PM Changeset in webkit [260387] by stephan.szabo@sony.com

• 4 edits in trunk

[PlayStation] Fix build after r260277
​https://bugs.webkit.org/show_bug.cgi?id=210756

Reviewed by Don Olmstead.

Source/WebKit:

Build fix, no new tests.

• PlatformPlayStation.cmake:

Tools:

• TestWebKitAPI/PlatformPlayStation.cmake:

12:35 PM Changeset in webkit [260386] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: the filter bar in the navigation sidebar should respect the global search settings
​https://bugs.webkit.org/show_bug.cgi?id=210679

Reviewed by Joseph Pecoraro.

• UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype.updateFilter):

12:21 PM Changeset in webkit [260385] by svillar@igalia.com

• 8 edits
  1 add in trunk

[WebXR] Update WebXRSession and WebXRSystem interfaces
​https://bugs.webkit.org/show_bug.cgi?id=210553

Reviewed by Žan Doberšek.

LayoutTests/imported/w3c:

• web-platform-tests/webxr/idlharness.https.window-expected.txt: Added.

Source/WebCore:

Update WebXRSession and WebXRSystem to the latest changes in the specs.

• Modules/webxr/WebXRSession.idl: Added 3 new events.
• Modules/webxr/WebXRSystem.idl: Interface name is XR not XRSystem.
• bindings/js/WebCoreBuiltinNames.h: Renamed macro.
• dom/EventNames.h: Added 3 new events.

LayoutTests:

• platform/wpe/TestExpectations: Mark idlharness.https.window.html test as Passed.

12:11 PM Changeset in webkit [260384] by ysuzuki@apple.com

• 4 edits in trunk

[JSC] Skip test262 for non-safe-integer range BigIntConstructor
​https://bugs.webkit.org/show_bug.cgi?id=210749

Reviewed by Keith Miller.

JSTests:

We skip test262 test/built-ins/BigInt/constructor-integer.js for now. As it is shown in old test262 JSTests/test262/expectations.yaml,
this test was failing before BigInt flag is enabled. And new BigInt patch changes error message while we are failing in the same way.
While we implemented BigInt, this test is based on spec change introduced[1], and we are not implementing this. So we mark it skipped,
as it is skipped before BigInt is enabled.

[1]: ​https://github.com/tc39/proposal-bigint/pull/138

• test262/config.yaml:

Source/JavaScriptCore:

• runtime/BigIntConstructor.cpp:

(JSC::callBigIntConstructor):

12:10 PM Changeset in webkit [260383] by Darin Adler

• 3 edits in trunk/Source/WTF

REGRESSION (r253987): StringImpl::adopt(Vector&&) copies only half of the characters in the Vector when copying across malloc zones
​https://bugs.webkit.org/show_bug.cgi?id=210736

Reviewed by Yusuke Suzuki.

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::replace): Use copyCharacters instead of memcpy.

• wtf/text/StringImpl.h: Use std::is_same_v instead of std::is_same.

(WTF::StringImpl::StringImpl): Use copyCharacters instead of memcpy.
Also drop C-style cast to cast away const.
(WTF::StringImpl::adopt): Don't even try to adopt across malloc zones.

11:43 AM Changeset in webkit [260382] by Chris Dumez

• 7 edits
  2 adds in trunk

Sending beacons when Fetch KeepAlive feature is disabled crashes the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=210753
<rdar://problem/61896221>

Reviewed by Geoffrey Garen.

Source/WebCore:

Test: http/wpt/beacon/beacon-legacy-code-path.html

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setFetchAPIKeepAliveEnabled):

• testing/InternalSettings.h:
• testing/InternalSettings.idl:

Add internal settings to disable Fetch Keep Alive for layout testing.

Source/WebKit:

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::startPingLoad):
Make sure NetworkResourceLoadParameters's webPageProxyID / webPageID / webFrameID are properly
initialized before sending the IPC or IPC decoding will fail.

LayoutTests:

Add layout test coverage.

• http/wpt/beacon/beacon-legacy-code-path-expected.txt: Added.
• http/wpt/beacon/beacon-legacy-code-path.html: Added.

11:41 AM Changeset in webkit [260381] by ddkilzer@apple.com

• 15 edits
  1 copy in trunk/Source/WebKit

[IPC hardening] Use ObjectIdentifier<> for geolocationID
<​https://webkit.org/b/210680>
<rdar://problem/58892340>

Reviewed by Chris Dumez.

Replace uses of uint64_t with GeolocationIdentifier.

• Scripts/webkit/messages.py:
• UIProcess/GeolocationIdentifier.h: Add.
• UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::createRequest):
(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):

• UIProcess/GeolocationPermissionRequestManagerProxy.h:
• UIProcess/GeolocationPermissionRequestProxy.cpp:

(WebKit::GeolocationPermissionRequestProxy::GeolocationPermissionRequestProxy):

• UIProcess/GeolocationPermissionRequestProxy.h:

(WebKit::GeolocationPermissionRequestProxy::create):

• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::didReceiveGeolocationPermissionDecision):
(WebKit::generateGeolocationID): Delete.

• Replace with GeolocationIdentifier::generate().
• WebProcess/Geolocation/GeolocationPermissionRequestManager.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveGeolocationPermissionDecision):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

11:16 AM Changeset in webkit [260380] by youenn@apple.com

• 11 edits
  2 adds in trunk

MediaPlayerPrivateMediaStreamAVFObjC should start play a newly added audio track if it is playing
​https://bugs.webkit.org/show_bug.cgi?id=210740

Reviewed by Eric Carlson.

Source/WebCore:

Before the patch, MediaPlayerPrivateMediaStreamAVFObjC was not calling play on the audio renderer when the audio renderer
was added after the MediaPlayerPrivateMediaStreamAVFObjC was asked to play.
This patch makes it so that, on configuration of an audio track, it will be asked to play if its MediaPlayerPrivateMediaStreamAVFObjC is playing.
Add internals API to be able to write a test.

Test: fast/mediastream/play-newly-added-audio-track.html

• html/track/AudioTrack.h:
• html/track/AudioTrack.idl:
• platform/graphics/AudioTrackPrivate.h:

(WebCore::AudioTrackPrivate::isBackedByMediaStreamTrack const):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):

• platform/mediastream/AudioTrackPrivateMediaStream.cpp:

(WebCore::AudioTrackPrivateMediaStream::play):

• platform/mediastream/AudioTrackPrivateMediaStream.h:

(isType):

• testing/Internals.cpp:

(WebCore::Internals::isMockRealtimeMediaSourceCenterEnabled):
(WebCore::Internals::shouldAudioTrackPlay):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• fast/mediastream/play-newly-added-audio-track-expected.txt: Added.
• fast/mediastream/play-newly-added-audio-track.html: Added.

11:14 AM Changeset in webkit [260379] by youenn@apple.com

• 9 edits in trunk/Source/WebCore

Use a WeakHashSet to store MediaStreamPrivate observers
​https://bugs.webkit.org/show_bug.cgi?id=210494

Reviewed by Eric Carlson.

Remove observers from the MediaStream and migrate existing client (MediaRecorder) to MediaStreamPrivate::Observer.
Make use of WeakHashSet in MediaStreamPrivate to improve robustness of the code.
Any time the MediaStreamPrivate tracks are modified, observers will be notified.
MediaStream needs now to decide when to send an event when its MediaStreamPrivate notifies of new/deleted tracks,
Modernize a bit the code to use more references.
Covered by existing tests.

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::~MediaRecorder):
(WebCore::MediaRecorder::handleTrackChange):

• Modules/mediarecorder/MediaRecorder.h:
• Modules/mediastream/MediaStream.cpp:

(WebCore::createTrackPrivateVector):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::didAddTrack):
(WebCore::MediaStream::didRemoveTrack):
(WebCore::MediaStream::addTrackFromPlatform):
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::internalTakeTrack):

• Modules/mediastream/MediaStream.h:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::removeRemoteTrack):

• platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::addObserver):
(WebCore::MediaStreamPrivate::removeObserver):
(WebCore::MediaStreamPrivate::forEachObserver):
(WebCore::MediaStreamPrivate::computeActiveState):
(WebCore::MediaStreamPrivate::updateActiveState):
(WebCore::MediaStreamPrivate::addTrack):
(WebCore::MediaStreamPrivate::removeTrack):
(WebCore::MediaStreamPrivate::trackEnded):

• platform/mediastream/MediaStreamPrivate.h:
• testing/Internals.cpp:

(WebCore::Internals::removeMediaStreamTrack):

11:11 AM Changeset in webkit [260378] by Alan Bujtas

• 2 edits in trunk/LayoutTests

fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=210754

Unreviewed test gardening.

Let's not use subframe layout in LFC tests for now.

• fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html:

11:06 AM Changeset in webkit [260377] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Fix CheckIsConstant for non-constant values and checking for empty
​https://bugs.webkit.org/show_bug.cgi?id=210752

Reviewed by Saam Barati.

We need to make sure that we only have one speculated type if our value
is empty.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

11:04 AM Changeset in webkit [260376] by Alan Coon

• 1 copy in branches/safari-610.1.11-branch

New branch.

11:02 AM Changeset in webkit [260375] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: removing a WI.TreeElement in a WI.NavigationSidebar doesn't check if the WI.TreeOutline still matches the current filter
​https://bugs.webkit.org/show_bug.cgi?id=210672

Reviewed by Joseph Pecoraro.

• UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype.createContentTreeOutline):
(WI.NavigationSidebarPanel.prototype.updateFilter):
(WI.NavigationSidebarPanel.prototype._checkForEmptyFilterResults):
(WI.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
(WI.NavigationSidebarPanel.prototype._handleTreeElementRemoved): Added.

10:59 AM Changeset in webkit [260374] by Alan Coon

• 8 edits in trunk/Source

Versioning.

10:48 AM Changeset in webkit [260373] by Chris Dumez

• 6 edits in trunk/Source/WebKit

[iOS] Refactor WebKit media playback process assertion logic to minimize chances of leaking them
​https://bugs.webkit.org/show_bug.cgi?id=210670

Reviewed by Geoffrey Garen.

Refactor WebKit media playback process assertion logic to minimize chances of leaking them. In particular,
the following changes were made:

1. Instead of the WebProcessPool having a HashMap of media playback process assertions for the WebProcess, we now store the assertion on the WebProcessProxy object itself. This is less likely to get out of sync and leak.
2. Add a RefCounter to the WebProcessPool to count WebProcesses that have audible media. Whenever a WebProcess starts or stops playing audible media, it merely grabs a RefCounter token or releases it. The WebProcessPool relies on this counter to decide whether or not to take a media playback assertion on behalf of the UIProcess. Since this is token-based and the token is stored on the WebProcessProxy object, it makes it less likely to leak the assertion.
3. The WebProcessProxy object now has a AudibleMediaActivity data structure wrapping both its media playback assertion and its WebProcessWithAudibleMediaToken that it got from the WebProcessPool. When the WebProcess shuts down (normally or due to crash/termination), we make sure to clear this data structure.
4. Make sure that the WebProcessProxy updates its AudibleMediaActivity whenever a page is removed from the WebProcess.

• UIProcess/WebPageProxy.cpp:
• UIProcess/WebProcessPool.cpp:

(WebKit::m_webProcessWithAudibleMediaCounter):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::webProcessWithAudibleMediaToken const):
(WebKit::WebProcessPool::updateAudibleMediaAssertions):

• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::removeWebPage):
(WebKit::WebProcessProxy::updateAudibleMediaAssertions):

• UIProcess/WebProcessProxy.h:

10:15 AM Changeset in webkit [260372] by Kate Cheney

• 2 edits in trunk/Source/WebKit

<rdar://problem/62059046>

Unreviewed macCatalyst build fix.

• NetworkProcess/NetworkProcess.messages.in:

10:14 AM Changeset in webkit [260371] by Simon Fraser

• 3 edits
  4 adds in trunk

Content disappears on CSS parallax example
​https://bugs.webkit.org/show_bug.cgi?id=210732
Source/WebCore:

<rdar://problem/61997636>

Reviewed by Darin Adler.

If scrolling affects the computation of coverage rect of a TiledBacking, we plumb
that expanded coverage back into TransformState which is maintained during GraphicsLayer flushing,
and it's used to compute coverage rect for descendants.

It's passed into TransformState::setLastPlanarSecondaryQuad(), which has to map it back into
the coordinate system of the last flattening ancestor. However, TransformState::mapQuad()
had a missing return and the quad mapping was wrong. The new code is now the same as
TransformState::mappedPoint() (you can see where the copy/paste error came from).

Test: compositing/tiling/coverage-adjustment-secondary-quad-mapping.html

• platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::mapQuad const):
(WebCore::TransformState::flattenWithTransform):

LayoutTests:

Reviewed by Darin Adler.

• compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt: Added.
• compositing/tiling/coverage-adjustment-secondary-quad-mapping.html: Added.
• platform/ios-wk2/compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt: Added.
• platform/mac-wk1/compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt: Added.

9:54 AM Changeset in webkit [260370] by Russell Epstein

• 3 edits in branches/safari-609-branch

Apply patch. rdar://problem/62062357

9:23 AM Changeset in webkit [260369] by Russell Epstein

• 20 edits in branches/safari-609-branch

Apply patch. rdar://problem/61950472

9:16 AM Changeset in webkit [260368] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][TFC] Add support for border-collapse: collapse.
​https://bugs.webkit.org/show_bug.cgi?id=210747

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-flex-width-border-collapse.html

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::ensureTableGrid):

LayoutTests:

• fast/layoutformattingcontext/table-flex-width-border-collapse.html: Added.

8:53 AM Changeset in webkit [260367] by Wenson Hsieh

• 24 edits
  2 adds
  1 delete in trunk

Oversized caret and selection rects in text fields on ganji.com and netflix.com/login
​https://bugs.webkit.org/show_bug.cgi?id=210622
<rdar://problem/45945636>

Reviewed by Darin Adler.

Source/WebCore:

Currently, selection and caret rects in text fields on some web pages can be excessively tall. This patch makes
a small adjustment to allow the top of the caret or selection rect to snap to the top of the inline box instead
of being at the end of the previous line, in the case where there is no previous inline box.

In the case where we compute the caret rect for an empty renderer (i.e. no children), we make an additional
tweak so that the caret rect's height is based on the computed font height instead of line height, and then we
ensure that the caret is (logically) vertically centered.

See below for more details.

Test: editing/selection/selection-and-caret-do-not-extend-to-line-height.html

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):

Specify ForHitTesting::Yes when asking for selectionTop().

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):

Use FontMetric's height when computing the height of the caret rect, and then center it vertically in the
renderer.

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint):

Specify ForHitTesting::Yes when asking for selectionTop(). See below for more information.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::positionForPoint const):

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop const):

When computing selectionTop(), we currently fall back to using the top of the containing RenderBlockFlow
(blockFlow().borderAndPaddingBefore()) in the case where there is no previous root box. However, this can lead
to selection and caret rects being taller than expected; instead, we can use the max of the selectionTop
(that is, the top of the line box, adjusted for annotations) and the top of the RenderBlockFlow. This has the
effect of allowing the caret and selection to visually snap to the top of a run of text, provided there is not
already a line of text that precedes it. Taking the maximum of the two values ensures that we don't
unintentionally make the selection or caret rects even larger, if the line top is above the top of the block.

Note that we also avoid shrinking the selection and caret rects when hit-testing renderers for positions and
ranges. This allows users to still click and drag to select text in the extra line-height area above a piece of
text, even if the selection is only painted over the text (and not in the region containing the line-height).
This behavior was established in the fix for webkit.org/b/14911, and is covered by the layout test
editing/selection/inline-closest-leaf-child.html.

• rendering/RootInlineBox.h:

Tools:

Rebaseline some expected selection and caret rects in some iOS API tests.

• TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:

(TEST):

• TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:

(TestWebKitAPI::TEST):

LayoutTests:

Rebaseline existing tests, and add a new test to verify that caret and selection rects do not extend to match
the line height in empty and non-empty editable elements, in both horizontal and vertical writing modes.

• editing/selection/ios/absolute-selection-after-scroll-expected.txt:
• editing/selection/ios/absolute-selection-after-scroll.html:
• editing/selection/ios/change-selection-after-tapping-focused-element-expected.txt:
• editing/selection/ios/change-selection-after-tapping-focused-element.html:
• editing/selection/ios/fixed-selection-after-scroll-expected.txt:
• editing/selection/ios/fixed-selection-after-scroll.html:
• editing/selection/ios/selection-after-changing-text-with-callout-menu-expected.txt:
• editing/selection/ios/selection-after-changing-text-with-callout-menu.html:
• editing/selection/ios/selection-handles-after-touch-end-expected.txt:
• editing/selection/ios/update-selection-after-overflow-scroll-expected.txt:
• editing/selection/ios/update-selection-after-overflow-scroll.html:
• editing/selection/selection-and-caret-do-not-extend-to-line-height-expected.txt: Added.
• editing/selection/selection-and-caret-do-not-extend-to-line-height.html: Added.
• fast/repaint/focus-ring-repaint-expected.txt:
• platform/ios/editing/selection/ios/selection-handles-after-touch-end-expected.txt: Removed.

Delete this redundant test expectation.

8:32 AM Changeset in webkit [260366] by Darin Adler

• 471 edits
  2 deletes in trunk

Use #import instead of #include in Objective-C and don't use #pragma once
​https://bugs.webkit.org/show_bug.cgi?id=210724

Reviewed by David Kilzer.

Source/JavaScriptCore:

• API/JSAPIWrapperObject.mm:
• API/JSContext.h:
• API/JSContext.mm:
• API/JSScriptInternal.h:
• API/JSValue.mm:
• API/JSVirtualMachine.mm:
• API/JSVirtualMachinePrivate.h:
• API/JSWrapperMap.mm:
• API/ObjCCallbackFunction.mm:
• API/tests/CurrentThisInsideBlockGetterTest.mm:

More #import, less #pragma once.

Source/WebCore:

• page/cocoa/SettingsBaseCocoa.mm:

(WebCore::sansSerifTraditionalHanFontFamily): Deleted.
(WebCore::sansSerifSimplifiedHanFontFamily): Deleted.
(WebCore::SettingsBase::initializeDefaultFontFamilies): Just use font name
strings directly since there are no conditionals any more.

• Modules/applepay/PaymentRequestValidator.mm:
• Modules/applepay/cocoa/PaymentContactCocoa.mm:
• accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
• accessibility/mac/AXObjectCacheMac.mm:
• accessibility/mac/WebAccessibilityObjectWrapperBase.h:
• accessibility/mac/WebAccessibilityObjectWrapperMac.h:
• bridge/objc/WebScriptObjectPrivate.h:
• bridge/objc/objc_class.mm:
• bridge/testbindings.mm:
• crypto/mac/SerializedCryptoKeyWrapMac.mm:
• editing/cocoa/WebArchiveResourceFromNSAttributedString.h:
• editing/cocoa/WebArchiveResourceWebResourceHandler.h:
• editing/cocoa/WebContentReaderCocoa.mm:
• history/mac/HistoryItemMac.mm:
• loader/cocoa/DiskCacheMonitorCocoa.mm:
• loader/cocoa/SubresourceLoaderCocoa.mm:
• loader/mac/ResourceLoaderMac.mm:
• page/cocoa/MemoryReleaseCocoa.mm:
• page/cocoa/ResourceUsageOverlayCocoa.mm:
• page/cocoa/ResourceUsageThreadCocoa.mm:
• page/ios/WebEventRegion.h:
• page/mac/ChromeMac.mm:
• page/mac/EventHandlerMac.mm:
• page/mac/WheelEventDeltaFilterMac.mm:
• page/scrolling/cocoa/ScrollingStateNode.mm:
• page/scrolling/mac/ScrollingCoordinatorMac.mm:
• page/scrolling/mac/ScrollingMomentumCalculatorMac.mm:
• page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
• page/scrolling/mac/ScrollingThreadMac.mm:
• page/scrolling/mac/ScrollingTreeMac.mm:
• platform/audio/cocoa/MediaSessionManagerCocoa.mm:
• platform/audio/mac/AudioSampleDataSource.mm:
• platform/cocoa/DataDetectorsCoreSoftLink.mm:
• platform/cocoa/PasteboardCocoa.mm:
• platform/cocoa/ScrollSnapAnimatorState.mm:
• platform/cocoa/SystemVersion.mm:
• platform/gamepad/cocoa/GameControllerGamepad.mm:
• platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
• platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
• platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
• platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
• platform/graphics/ca/cocoa/WebSystemBackdropLayer.h:
• platform/graphics/ca/cocoa/WebTiledBackingLayer.h:
• platform/graphics/ca/cocoa/WebVideoContainerLayer.h:
• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
• platform/graphics/cocoa/IOSurfacePoolCocoa.mm:
• platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
• platform/graphics/cocoa/WebGLLayer.h:
• platform/graphics/cocoa/WebGLLayer.mm:
• platform/graphics/cocoa/WebGPULayer.h:
• platform/graphics/cocoa/WebGPULayer.mm:
• platform/graphics/cv/ImageRotationSessionVT.mm:
• platform/graphics/cv/ImageTransferSessionVT.mm:
• platform/graphics/cv/TextureCacheCV.mm:
• platform/graphics/gpu/cocoa/GPUBufferMetal.mm:
• platform/graphics/gpu/cocoa/GPUComputePassEncoderMetal.mm:
• platform/graphics/mac/ComplexTextControllerCoreText.mm:
• platform/graphics/mac/FloatPointMac.mm:
• platform/graphics/mac/FloatSizeMac.mm:
• platform/graphics/mac/IntPointMac.mm:
• platform/graphics/mac/IntSizeMac.mm:
• platform/graphics/mac/WebLayer.h:
• platform/graphics/mac/WebLayer.mm:
• platform/ios/LegacyTileCache.mm:
• platform/ios/LegacyTileGrid.mm:
• platform/ios/LegacyTileGridTile.mm:
• platform/ios/LegacyTileLayer.h:
• platform/ios/LegacyTileLayer.mm:
• platform/ios/LegacyTileLayerPool.mm:
• platform/ios/LocalCurrentTraitCollection.mm:
• platform/ios/LocalizedDeviceModel.mm:
• platform/ios/ScrollbarThemeIOS.mm:
• platform/ios/WebCoreMotionManager.h:
• platform/ios/WebItemProviderPasteboard.mm:
• platform/ios/WebVideoFullscreenControllerAVKit.h:
• platform/mac/LocalCurrentGraphicsContext.mm:
• platform/mac/LocalDefaultSystemAppearance.mm:
• platform/mac/LoggingMac.mm:
• platform/mac/PlatformEventFactoryMac.mm:
• platform/mac/RemoteCommandListenerMac.mm:
• platform/mac/ScrollAnimatorMac.mm:
• platform/mac/SerializedPlatformDataCueMac.mm:
• platform/mac/WebCoreFullScreenPlaceholderView.mm:
• platform/mac/WebCoreFullScreenWarningView.h:
• platform/mac/WebCoreFullScreenWarningView.mm:
• platform/mac/WebCoreFullScreenWindow.h:
• platform/mac/WebCoreObjCExtras.mm:
• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
• platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm:
• platform/mediastream/ios/AVAudioSessionCaptureDevice.mm:
• platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
• platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
• platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm:
• platform/mediastream/mac/RealtimeVideoUtilities.mm:
• platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:
• platform/network/cocoa/CertificateInfoCocoa.mm:
• platform/network/cocoa/WebCoreNSURLSession.h:
• platform/network/mac/BlobDataFileReferenceMac.mm:
• platform/network/mac/CredentialStorageMac.mm:
• platform/network/mac/SynchronousLoaderClient.mm:
• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
• platform/text/cocoa/LocaleCocoa.mm:
• testing/ServiceWorkerInternals.mm:
• testing/cocoa/WebViewVisualIdentificationOverlay.h:

More #import, less #pragma once.

Source/WebCore/PAL:

• pal/cocoa/AppSSOSoftLink.mm:
• pal/cocoa/FileSizeFormatterCocoa.mm:
• pal/cocoa/UsageTrackingSoftLink.mm:
• pal/ios/ManagedConfigurationSoftLink.mm:
• pal/ios/UIKitSoftLink.mm:
• pal/mac/LookupSoftLink.mm:
• pal/spi/cocoa/AVFoundationSPI.h:
• pal/spi/cocoa/AccessibilitySupportSoftLink.cpp:
• pal/spi/cocoa/AppSSOSPI.h:
• pal/spi/cocoa/AuthKitSPI.h:
• pal/spi/cocoa/DataDetectorsCoreSPI.h:
• pal/spi/cocoa/LaunchServicesSPI.h:
• pal/spi/cocoa/NSAccessibilitySPI.h:
• pal/spi/cocoa/NSAttributedStringSPI.h:
• pal/spi/cocoa/NSProgressSPI.h:
• pal/spi/cocoa/NSURLDownloadSPI.h:
• pal/spi/cocoa/NSUserDefaultsSPI.h:
• pal/spi/cocoa/NSXPCConnectionSPI.h:
• pal/spi/cocoa/PassKitSPI.h:
• pal/spi/cocoa/SecKeyProxySPI.h:
• pal/spi/ios/CelestialSPI.h:
• pal/spi/mac/DataDetectorsSPI.h:
• pal/spi/mac/NSColorWellSPI.h:
• pal/spi/mac/NSGraphicsSPI.h:
• pal/spi/mac/NSPopoverColorWellSPI.h:
• pal/spi/mac/NSScrollerImpSPI.h:

More #import, less #pragma once.

Source/WebKit:

• mac/MigrateHeadersFromWebKitLegacy.make: Delete stale MemoryMeasure.h

forwarding header from incremental WebKit builds and ignore when generating
new forwarding headers.

• Platform/foundation/LoggingFoundation.mm:

(WebKit::logLevelString): Use string directly instead of a named constant.

• UIProcess/mac/WebColorPickerMac.h: Mark class final.

• GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
• NetworkProcess/WebStorage/ios/LocalStorageDatabaseTrackerIOS.mm:
• NetworkProcess/cache/NetworkCacheDataCocoa.mm:
• NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
• NetworkProcess/cocoa/NetworkActivityTrackerCocoa.mm:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:
• NetworkProcess/webrtc/NetworkRTCProvider.mm:
• Platform/spi/Cocoa/DeviceManagementSPI.h:
• Platform/spi/Cocoa/LocalAuthenticationSPI.h:
• Platform/spi/Cocoa/NearFieldSPI.h:
• Platform/spi/Cocoa/SafeBrowsingSPI.h:
• Platform/spi/mac/AppKitSPI.h:
• Shared/API/Cocoa/RemoteObjectInvocation.mm:
• Shared/API/Cocoa/WKMain.mm:
• Shared/APIWebArchive.mm:
• Shared/APIWebArchiveResource.mm:
• Shared/Authentication/cocoa/AuthenticationChallengeDispositionCocoa.mm:
• Shared/Cocoa/LoadParametersCocoa.mm:
• Shared/Cocoa/SandboxInitialiationParametersCocoa.mm:
• Shared/Cocoa/WKNSData.mm:
• Shared/DocumentEditingContext.mm:
• Shared/Plugins/mac/PluginSandboxProfile.mm:
• Shared/RemoteLayerTree/WKAnimationDelegate.h:
• Shared/UserInterfaceIdiom.mm:
• Shared/ios/WebIconUtilities.mm:
• Shared/mac/CodeSigning.mm:
• Shared/mac/ColorSpaceData.mm:
• Shared/mac/HangDetectionDisablerMac.mm:
• Shared/mac/PDFKitImports.mm:
• UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm:
• UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm:
• UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:
• UIProcess/API/Cocoa/WKContentRuleList.mm:
• UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:
• UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
• UIProcess/API/Cocoa/WKPreviewActionItemIdentifiers.mm:
• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h:
• UIProcess/API/Cocoa/_WKApplicationManifest.h:
• UIProcess/API/Cocoa/_WKAttachment.h:
• UIProcess/API/Cocoa/_WKResourceLoadInfoInternal.h:
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstPartyInternal.h:
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdPartyInternal.h:
• UIProcess/API/Cocoa/_WKTextManipulationExclusionRule.mm:
• UIProcess/API/Cocoa/_WKUserContentFilter.mm:
• UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponseInternal.h:
• UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h:
• UIProcess/Authentication/mac/WebCredentialMac.mm:
• UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm:
• UIProcess/Cocoa/IconLoadingDelegate.mm:
• UIProcess/Cocoa/MediaUtilities.mm:
• UIProcess/Cocoa/PreferenceObserver.h:
• UIProcess/Cocoa/PreferenceObserver.mm:
• UIProcess/Cocoa/SOAuthorization/NavigationSOAuthorizationSession.mm:
• UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.h:
• UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
• UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.h:
• UIProcess/Cocoa/WKEditCommand.h:
• UIProcess/Cocoa/WKFullKeyboardAccessWatcher.h:
• UIProcess/Cocoa/WebPageProxyCocoa.mm:
• UIProcess/Gamepad/cocoa/UIGamepadProviderCocoa.mm:
• UIProcess/Inspector/mac/WKInspectorViewController.h:
• UIProcess/Inspector/mac/WKInspectorWKWebView.h:
• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
• UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:
• UIProcess/RemoteLayerTree/mac/ScrollerPairMac.mm:
• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
• UIProcess/WebAuthentication/Cocoa/WKNFReaderSessionDelegate.h:
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
• UIProcess/ios/WKDeferringGestureRecognizer.h:
• UIProcess/ios/WKHighlightLongPressGestureRecognizer.h:
• UIProcess/ios/WebDataListSuggestionsDropdownIOS.h:
• UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
• UIProcess/ios/forms/WKDatePickerViewController.h:
• UIProcess/ios/forms/WKDatePickerViewController.mm:
• UIProcess/ios/forms/WKFocusedFormControlView.h:
• UIProcess/ios/forms/WKFocusedFormControlView.mm:
• UIProcess/ios/forms/WKFormColorPicker.mm:
• UIProcess/ios/forms/WKNumberPadViewController.h:
• UIProcess/ios/forms/WKNumberPadViewController.mm:
• UIProcess/ios/forms/WKQuickboardListViewController.h:
• UIProcess/ios/forms/WKQuickboardListViewController.mm:
• UIProcess/ios/forms/WKSelectMenuListViewController.h:
• UIProcess/ios/forms/WKTimePickerViewController.h:
• UIProcess/ios/forms/WKTimePickerViewController.mm:
• UIProcess/ios/fullscreen/WKFullScreenViewController.h:
• UIProcess/ios/fullscreen/WKFullscreenStackView.h:
• UIProcess/ios/fullscreen/WKFullscreenStackView.mm:
• UIProcess/mac/PageClientImplMac.mm:
• UIProcess/mac/WKSharingServicePickerDelegate.h:
• WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
• WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.h:
• WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
• WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.cpp:
• WebProcess/WebPage/WKAccessibilityWebPageObjectIOS.h:
• WebProcess/WebPage/mac/PageBannerMac.mm:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.h:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.h:
• WebProcess/cocoa/WebProcessCocoa.mm:

More #import, less #pragma once.

Source/WebKitLegacy:

• WebKitLegacy.xcodeproj/project.pbxproj: Removed MemoryMeasure.h/mm.

Source/WebKitLegacy/ios:

• Misc/MemoryMeasure.h: Removed.
• Misc/MemoryMeasure.mm: Removed.
• WebKit.iOS.exp: Removed MemoryMeasure symbols.

Source/WebKitLegacy/mac:

• Configurations/WebKitLegacy.xcconfig: Removed MemoryMeasure.h from

EXCLUDED_SOURCE_FILE_NAMES.

• Misc/WebCache.mm:

(+[WebCache emptyInMemoryResources]): Removed invocation of MemoryMeasure.
This is no longer used for anything.

• History/BackForwardList.mm:
• Plugins/Hosted/ProxyRuntimeObject.mm:
• Plugins/Hosted/WebHostedNetscapePluginView.mm:
• WebCoreSupport/SearchPopupMenuMac.mm:
• WebCoreSupport/WebAlternativeTextClient.mm:
• WebCoreSupport/WebSecurityOriginInternal.h:
• WebInspector/WebInspector.mm:
• WebView/WebFramePrivate.h:
• WebView/WebScriptWorld.h:
• WebView/WebView.mm:

More #import, less #pragma once.

Source/WTF:

• wtf/cocoa/Entitlements.mm:
• wtf/cocoa/FileSystemCocoa.mm:
• wtf/cocoa/MainThreadCocoa.mm:
• wtf/cocoa/SystemTracingCocoa.cpp:
• wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
• wtf/mac/SchedulePairMac.mm:
• wtf/text/cocoa/StringCocoa.mm:
• wtf/text/cocoa/TextStreamCocoa.mm:

More #import.

Tools:

• DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
• DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
• DumpRenderTree/mac/AccessibilityCommonMac.h:
• DumpRenderTree/mac/DumpRenderTreeMain.mm:
• TestRunnerShared/cocoa/ClassMethodSwizzler.mm:
• TestRunnerShared/cocoa/InstanceMethodSwizzler.mm:
• TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
• TestRunnerShared/mac/NSPasteboardAdditions.h:
• TestRunnerShared/spi/AppKitTestSPI.h:
• TestRunnerShared/spi/PencilKitTestSPI.h:
• TestWebKitAPI/DataDetectorsCoreSPI.h:
• TestWebKitAPI/EditingTestHarness.h:
• TestWebKitAPI/EditingTestHarness.mm:
• TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
• TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
• TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
• TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
• TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm:
• TestWebKitAPI/Tests/WebKit/AccessibilityRemoteUIApp.mm:
• TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm:
• TestWebKitAPI/Tests/WebKit/Battery.mm:
• TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
• TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
• TestWebKitAPI/Tests/WebKit/FindMatches.mm:
• TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm:
• TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
• TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm:
• TestWebKitAPI/Tests/WebKit/MimeTypes.mm:
• TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
• TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
• TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm:
• TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
• TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
• TestWebKitAPI/Tests/WebKit/ViewportSizeForViewportUnits.mm:
• TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
• TestWebKitAPI/Tests/WebKit/WebFilter.mm:
• TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
• TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
• TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.h:
• TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
• TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter_Bundle.mm:
• TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
• TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
• TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
• TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
• TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CookieAcceptPolicy.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
• TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm:
• TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
• TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
• TestWebKitAPI/Tests/WebKitCocoa/DeviceManagementRestrictions.mm:
• TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
• TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FindInPageAPI.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
• TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
• TestWebKitAPI/Tests/WebKitCocoa/JavaScriptDuringNavigation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm:
• TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
• TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
• TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm:
• TestWebKitAPI/Tests/WebKitCocoa/MediaType.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
• TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ObservedRenderingProgressEventsAfterCrash.mm:
• TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
• TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PageZoom.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimerDoesntFireEarly.mm:
• TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ShouldGoToBackForwardListItem.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
• TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm:
• TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
• TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h:
• TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm:
• TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
• TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
• TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
• TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
• TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
• TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
• TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
• TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm:
• TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
• TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
• TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm:
• TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
• TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
• TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
• TestWebKitAPI/Tests/ios/SelectionByWord.mm:
• TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
• TestWebKitAPI/Tests/ios/TestInputDelegate.h:
• TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
• TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
• TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
• TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
• TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
• TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm:
• TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
• TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm:
• TestWebKitAPI/Tests/mac/BackForwardList.mm:
• TestWebKitAPI/Tests/mac/BackgroundColor.mm:
• TestWebKitAPI/Tests/mac/CandidateTests.mm:
• TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
• TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
• TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
• TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
• TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
• TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
• TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
• TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
• TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
• TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
• TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
• TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
• TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm:
• TestWebKitAPI/Tests/mac/TypingStyleCrash.mm:
• TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
• TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm:
• TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
• TestWebKitAPI/cocoa/DragAndDropSimulator.h:
• TestWebKitAPI/cocoa/NSItemProviderAdditions.h:
• TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
• TestWebKitAPI/cocoa/TestContextMenuDriver.h:
• TestWebKitAPI/cocoa/TestNavigationDelegate.h:
• TestWebKitAPI/cocoa/TestProtocol.mm:
• TestWebKitAPI/cocoa/TestUIDelegate.h:
• TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
• TestWebKitAPI/ios/PencilKitTestSPI.h:
• TestWebKitAPI/mac/JavaScriptTestMac.mm:
• TestWebKitAPI/mac/NSFontPanelTesting.h:
• TestWebKitAPI/mac/NSFontPanelTesting.mm:
• TestWebKitAPI/mac/OffscreenWindow.h:
• TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
• TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
• TestWebKitAPI/mac/TestDraggingInfo.h:
• TestWebKitAPI/mac/TestFilePromiseReceiver.h:
• TestWebKitAPI/mac/TestFontOptions.h:
• TestWebKitAPI/mac/TestInspectorBar.h:
• TestWebKitAPI/mac/WebKitAgnosticTest.mm:
• WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
• WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
• WebKitTestRunner/mac/PoseAsClass.mm:

More #import, less #pragma once.

8:24 AM Changeset in webkit [260365] by Diego Pino Garcia

• 2 edits in trunk/Tools

[Flatpak SDK] Prevent exception when calling git in a non-git repository
​https://bugs.webkit.org/show_bug.cgi?id=210737

Reviewed by Philippe Normand.

• flatpak/flatpakutils.py:

(WebkitFlatpak.is_branch_build): Return false if command executes in a
non-git repository (i.e SVN).

7:37 AM Changeset in webkit [260364] by youenn@apple.com

• 9 edits
  8 adds in trunk

Safari doesn't apply frameRate limit when request stream from Camera
​https://bugs.webkit.org/show_bug.cgi?id=210186
<rdar://problem/61452794>

Reviewed by Eric Carlson.

Source/WebCore:

Add support to RealtimeVideoSource to decimate the video samples based on the observed frame rate of its capture source.
This allows supporting two tracks using the same capture device, one track being low frame rate and the other one high frame rate.

Clean-up refactoring to make RealtimeVideoSource directly inherit from RealtimeVideoCaptureSource.
Migrate size and format of frame adaptation from RealtimeVideoCaptureSource to RealtimeVideoSource.
Fix mock capture source to update its frame rate when asked by applyConstraints.

Tests: fast/mediastream/mediastreamtrack-video-frameRate-clone-decreasing.html

fast/mediastream/mediastreamtrack-video-frameRate-clone-increasing.html
fast/mediastream/mediastreamtrack-video-frameRate-decreasing.html
fast/mediastream/mediastreamtrack-video-frameRate-increasing.html

• platform/mediastream/RealtimeVideoCaptureSource.cpp:

(WebCore::RealtimeVideoCaptureSource::dispatchMediaSampleToObservers):
(WebCore::RealtimeVideoCaptureSource::clientUpdatedSizeAndFrameRate):

• platform/mediastream/RealtimeVideoCaptureSource.h:

(WebCore::RealtimeVideoCaptureSource::observedFrameRate const):

• platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::RealtimeVideoSource):
(WebCore::m_source):
(WebCore::RealtimeVideoSource::adaptVideoSample):
(WebCore::RealtimeVideoSource::videoSampleAvailable):

• platform/mediastream/RealtimeVideoSource.h:
• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::setFrameRateWithPreset):

• testing/Internals.cpp:

(WebCore::Internals::observeMediaStreamTrack):

LayoutTests:

• fast/mediastream/mediastreamtrack-video-frameRate-clone-decreasing-expected.txt: Added.
• fast/mediastream/mediastreamtrack-video-frameRate-clone-decreasing.html: Added.
• fast/mediastream/mediastreamtrack-video-frameRate-clone-increasing-expected.txt: Added.
• fast/mediastream/mediastreamtrack-video-frameRate-clone-increasing.html: Added.
• fast/mediastream/mediastreamtrack-video-framerate-decreasing-expected.txt: added.
• fast/mediastream/mediastreamtrack-video-framerate-decreasing.html: added.
• fast/mediastream/mediastreamtrack-video-framerate-increasing-expected.txt: added.
• fast/mediastream/mediastreamtrack-video-framerate-increasing.html: added.
• webrtc/routines.js:

5:29 AM Changeset in webkit [260363] by Philippe Normand

• 2 edits in trunk/Tools

[Flatpak SDK] Drive-by fixes
​https://bugs.webkit.org/show_bug.cgi?id=210557

Reviewed by Žan Doberšek.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): Properly format error message.
(WebkitFlatpak.main): Show flatpak update output.

5:10 AM Changeset in webkit [260362] by keith_miller@apple.com

• 2 edits in trunk/JSTests

Unreviewed, revert accidental test changes.

• microbenchmarks/for-of-iterate-array-entries.js:

(foo):

5:01 AM Changeset in webkit [260361] by commit-queue@webkit.org

• 2 edits in trunk/JSTests

[32-bits] stress/for-of-array-different-globals.js is failing
​https://bugs.webkit.org/show_bug.cgi?id=210718

Unreviewed gardening.

Skip test for arm and mips, failing due to r260323

Patch by Paulo Matos <Paulo Matos> on 2020-04-20

• stress/for-of-array-different-globals.js:

4:56 AM Changeset in webkit [260360] by graouts@webkit.org

• 3 edits
  2 adds in trunk

WebAnimations API doesn't properly apply keyframe easings to transforms
​https://bugs.webkit.org/show_bug.cgi?id=210526
<rdar://problem/61800424>

Reviewed by Antti Koivisto.

Source/WebCore:

GraphicsLayerCA has code that determines whether an animation can be accelerated looking at the timing function of its keyframes and excluding
animations that use a steps timing function as one of its values. However, we we would fail to set the timing function on the KeyframeValue for
each keyframe in the KeyframeList we create for a JS-originated animation. We now do this correctly.

Test: webanimations/transform-animation-with-steps-timing-function-not-accelerated.html

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::updateBlendingKeyframes):

LayoutTests:

Add a new test that checks that an animation targeting an accelerted property does not yield an accelerated animation if one of its keyframes contains a steps timing function.

• webanimations/transform-animation-with-steps-timing-function-not-accelerated-expected.txt: Added.
• webanimations/transform-animation-with-steps-timing-function-not-accelerated.html: Added.

3:22 AM Changeset in webkit [260359] by Pablo Saavedra

• 2 edits in trunk/Source/WebKit

[GTK][WPE] lowWatermarkPages() in MemoryPressureMonitor.cpp only searches the "low" value inside the first "Node" section
​https://bugs.webkit.org/show_bug.cgi?id=210345

Reviewed by Adrian Perez de Castro.

• UIProcess/linux/MemoryPressureMonitor.cpp:

(WebKit::lowWatermarkPages):

2:54 AM Changeset in webkit [260358] by ysuzuki@apple.com

• 13 edits in trunk

StructuredClone algorithm should be aware of BigInt
​https://bugs.webkit.org/show_bug.cgi?id=210728

Reviewed by Mark Lam.

LayoutTests/imported/w3c:

• web-platform-tests/IndexedDB/bigint_value-expected.txt:
• web-platform-tests/html/infrastructure/safe-passing-of-structured-data/structured_clone_bigint-expected.txt:

Source/JavaScriptCore:

• CMakeLists.txt:
• runtime/BigIntObject.h:
• runtime/JSBigInt.cpp:

(JSC::JSBigInt::digit): Deleted.
(JSC::JSBigInt::setDigit): Deleted.

• runtime/JSBigInt.h:

(JSC::JSBigInt::digit):
(JSC::JSBigInt::setDigit):

Source/WebCore:

This patch adds structured-cloning for BigInt and BigIntObject.
The logic is adding BigIntTag & BigIntObjectTag. And then we put content of BigInt with length.
And deserialization reads them to reconstruct BigInt or BigIntObject.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpImmediate):
(WebCore::CloneSerializer::dumpBigIntData):
(WebCore::CloneSerializer::dumpBigInt32Data):
(WebCore::CloneSerializer::dumpHeapBigIntData):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readBigInt):
(WebCore::CloneDeserializer::readTerminal):

LayoutTests:

• inspector/model/remote-object/number-expected.txt:
• inspector/model/remote-object/object-expected.txt:

2:20 AM Changeset in webkit [260357] by svillar@igalia.com

• 2 edits in trunk/Tools

[WebXR][WPE] Let XR_RUNTIME_JSON environment variable go through for testing
​https://bugs.webkit.org/show_bug.cgi?id=210738

Reviewed by Žan Doberšek.

The OpenXR loader might be instructed to load a specific runtime by
using the XR_RUNTIME_JSON environment variable. Let it get in for testing.

• Scripts/webkitpy/port/wpe.py:

(WPEPort.setup_environ_for_server): Copy XR_RUNTIME_JSON if set.

1:33 AM Changeset in webkit [260356] by Carlos Garcia Campos

• 21 edits in trunk

[GTK][WPE] Enable resource load statistics
​https://bugs.webkit.org/show_bug.cgi?id=210184

Reviewed by Žan Doberšek.

.:

Enable resource load statistics.

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

Source/WebCore:

• platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::setCookiesFromDOM const): Return early if cookies are blocked and update the
persistent cookies expiration if needed.
(WebCore::NetworkStorageSession::deleteCookiesForHostnames): Implement this when receiving
IncludeHttpOnlyCookies parameter.
(WebCore::NetworkStorageSession::hasCookies const): Implement this.
(WebCore::NetworkStorageSession::getRawCookies const): Honor shouldAskITP parameter.
(WebCore::cookiesForSession): Ditto.
(WebCore::NetworkStorageSession::cookiesForDOM const): Ditto.
(WebCore::NetworkStorageSession::cookieRequestHeaderFieldValue const): Ditto.

Source/WebKit:

• NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::create): Pass page and frame identifiers to the constructor.
(WebKit::NetworkDataTask::isThirdPartyRequest const): Moved from NetworkDataTaskCocoa.mm.
(WebKit::NetworkDataTask::restrictRequestReferrerToOriginIfNeeded): Ditto.

• NetworkProcess/NetworkDataTask.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup): Initialize m_frameID and m_pageID.
(WebKit::NetworkDataTaskSoup::createRequest): Add WasBlockingCookies parameter. Call
restrictRequestReferrerToOriginIfNeeded() and disable cookies in the soup message if cookies should be blocked.
(WebKit::NetworkDataTaskSoup::clearRequest): Reset m_isBlockingCookies.
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Pass WasBlockingCookies to createRequest().

• NetworkProcess/soup/NetworkDataTaskSoup.h:
• UIProcess/API/C/WKPage.cpp:

(WKPageLoadedThirdPartyDomains): Added for tests.
(WKPageClearLoadedThirdPartyDomains): Ditto.

• UIProcess/API/C/WKPagePrivate.h:
• UIProcess/glib/WebsiteDataStoreGLib.cpp:

(WebKit::WebsiteDataStore::defaultResourceLoadStatisticsDirectory): Use lowercase for consistency with other
default directories.

Tools:

Implement TestController::loadedThirdPartyDomains() and TestController::clearLoadedThirdPartyDomains() for
non-cocoa ports.

• WebKitTestRunner/TestController.cpp:

(WTR::LoadedThirdPartyDomainsCallbackContext::LoadedThirdPartyDomainsCallbackContext):
(WTR::loadedThirdPartyDomainsCallback):
(WTR::TestController::loadedThirdPartyDomains):
(WTR::TestController::clearLoadedThirdPartyDomains):

LayoutTests:

Unskip tests that are now passing and add expectations for the two reminaing failures.

• http/tests/resourceLoadStatistics/loaded-registrable-domains-get-reported.html: Use setTimeout in onload

handler to avoid a deadlock due to sync injected bundle messages.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

1:25 AM Changeset in webkit [260355] by ddkilzer@apple.com

• 3 edits in trunk/Tools

check-webkit-style should not complain about missing config.h header in WebKitLegacy source files
<​https://webkit.org/b/210734>

Reviewed by Darin Adler.

• Scripts/webkitpy/style/checkers/cpp.py:

(_NO_CONFIG_H_PATH_PATTERNS):

• Add '^{Source/WebKitLegacy/' to the list.}
• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_primary_header):

• Add test for Source/WebKitLegacy source file.

12:11 AM Changeset in webkit [260354] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r259610): Leak of RBSAssertionInvalidationCallbackType due to missing -dealloc
<​https://webkit.org/b/210711>
<rdar://problem/61993361>

Reviewed by Geoffrey Garen.

• UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKRBSAssertionDelegate dealloc]): Add.

• Release _invalidationCallback to fix the leak.