Timeline

Apr 25, 2020:

10:07 PM Changeset in webkit [260722] by Ross Kirsling

• 12 edits in trunk/Source

[JSC] isCallable is redundant with isFunction
​https://bugs.webkit.org/show_bug.cgi?id=211037

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

isCallable is only being used in two places and has the same definition as isFunction (aside from out params).
Where CallData is needed, getCallData should be used; where CallData is not needed, isFunction should be used.

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::isCallable const): Deleted.

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::isCallable): Deleted.
Remove isCallable.

• runtime/JSONObject.cpp:

(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
Use getCallData if you need CallData.

• runtime/ExceptionHelpers.cpp:

(JSC::errorDescriptionForValue):

• runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
Don't use getCallData if you don't need CallData.

Source/WebCore:

• bindings/js/JSDOMConvertScheduledAction.h:

(WebCore::Converter<IDLScheduledAction>::convert):

• worklets/PaintWorkletGlobalScope.cpp:

(WebCore::PaintWorkletGlobalScope::registerPaint):
Don't use getCallData if you don't need CallData.

9:57 PM Changeset in webkit [260721] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Fix internal iOS build.
​https://bugs.webkit.org/show_bug.cgi?id=210521

• Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformBeginApplePaySetup):

9:44 PM Changeset in webkit [260720] by ysuzuki@apple.com

• 3 edits
  1 add in trunk

[JSC] Handle BigInt32 INT32_MIN shift amount
​https://bugs.webkit.org/show_bug.cgi?id=211030

Reviewed by Darin Adler.

JSTests:

• stress/bigint-int32-min-shift.js: Added.

(shouldBe):
(shouldThrow):

Source/JavaScriptCore:

Our BigInt shift-operation does not correctly handle INT32_MIN shift amount, and producing a wrong result.
This patch fixes it.

• runtime/Operations.h:

(JSC::shift):

9:09 PM Changeset in webkit [260719] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Build fix.
​https://bugs.webkit.org/show_bug.cgi?id=210521

• Modules/applepay/ApplePaySetupFeature.mm:

8:32 PM Changeset in webkit [260718] by achristensen@apple.com

• 15 edits
  17 adds
  7 deletes in trunk/Source

Move ApplePay code from WebKitAdditions to WebCore and WebKit
​https://bugs.webkit.org/show_bug.cgi?id=210521
Source/WebCore:

I accidentally committed an older version of the patch.
This is the diff between the two to fix the internal build.

Source/WebCore/PAL:

Reviewed by Andy Estes.

• pal/cocoa/PassKitSoftLink.h:
• pal/cocoa/PassKitSoftLink.mm:
• pal/spi/cocoa/PassKitSPI.h:

8:03 PM Changeset in webkit [260717] by achristensen@apple.com

• 39 edits
  17 adds in trunk/Source

Move ApplePay code from WebKitAdditions to WebCore and WebKit
​https://bugs.webkit.org/show_bug.cgi?id=210521

Reviewed by Andy Estes.

Source/WebCore:

Only 4 minor modifications were necessary, as follows:

1. PaymentSetupFeatures's RetainPtr<NSArray<PKPaymentSetupFeature *>> was changed to RetainPtr<NSArray> to work with C++.
2. WebPaymentCoordinatorProxyAdditions messages were moved to WebPaymentCoordinatorProxy, removing the need for the extra message receiver, the Optional<WebPaymentCoordinatorProxyAdditions>, and the finishConstruction.
3. WebMediaSessionManager.cpp's macros that collided with other macros were renamed. This was necessary because of different source unification.
4. PaymentSetupFeatures.h was renamed to ApplePayPaymentSetupFeatures.h to be able to build with PaymentSetupFeatures.h in the SDK.

The rest is just copy and paste.

There isn't a good way to land this without breaking the build without removing the files from WebKitAdditions at the same time,
so I'll do the two at the same time late at night to not cause disruption.

• DerivedSources.make:
• Modules/applepay/ApplePayInstallmentConfiguration.h: Added.
• Modules/applepay/ApplePayInstallmentConfiguration.idl: Added.
• Modules/applepay/ApplePayPayment.h:
• Modules/applepay/ApplePayPayment.idl:
• Modules/applepay/ApplePayPaymentMethod.h:
• Modules/applepay/ApplePayPaymentMethod.idl:
• Modules/applepay/ApplePayPaymentMethodUpdate.h:
• Modules/applepay/ApplePayPaymentMethodUpdate.idl:
• Modules/applepay/ApplePayRequestBase.cpp:

(WebCore::finishConverting):
(WebCore::requiresSupportedNetworks):

• Modules/applepay/ApplePayRequestBase.h:
• Modules/applepay/ApplePaySession.cpp:

(WebCore::finishConverting):

• Modules/applepay/ApplePaySessionPaymentRequest.h:

(WebCore::ApplePaySessionPaymentRequest::installmentConfiguration const):
(WebCore::ApplePaySessionPaymentRequest::setInstallmentConfiguration):

• Modules/applepay/ApplePaySetup.cpp: Added.

(WebCore::shouldDiscloseFeatures):
(WebCore::ApplePaySetup::getSetupFeatures):
(WebCore::ApplePaySetup::begin):
(WebCore::ApplePaySetup::ApplePaySetup):
(WebCore::ApplePaySetup::stop):
(WebCore::ApplePaySetup::suspend):

• Modules/applepay/ApplePaySetup.h: Added.

(WebCore::ApplePaySetup::create):

• Modules/applepay/ApplePaySetup.idl: Added.
• Modules/applepay/ApplePaySetupFeature.h: Added.

(WebCore::ApplePaySetupFeature::create):
(WebCore::ApplePaySetupFeature::platformFeature const):

• Modules/applepay/ApplePaySetupFeature.idl: Added.
• Modules/applepay/ApplePaySetupFeature.mm: Added.

(WebCore::ApplePaySetupFeature::type const):
(WebCore::ApplePaySetupFeature::state const):
(WebCore::ApplePaySetupFeature::supportsInstallments const):
(WebCore::ApplePaySetupFeature::ApplePaySetupFeature):

• Modules/applepay/ApplePaySetupFeatureType.h: Added.
• Modules/applepay/ApplePaySetupFeatureType.idl: Added.
• Modules/applepay/PaymentCoordinatorClient.h:

(WebCore::PaymentCoordinatorClient::getSetupFeatures):
(WebCore::PaymentCoordinatorClient::beginApplePaySetup):
(WebCore::PaymentCoordinatorClient::endApplePaySetup):

• Modules/applepay/PaymentInstallmentConfiguration.h: Added.
• Modules/applepay/PaymentInstallmentConfiguration.mm: Added.

(WebCore::toDecimalNumber):
(WebCore::platformFeatureType):
(WebCore::createPlatformConfiguration):
(WebCore::PaymentInstallmentConfiguration::PaymentInstallmentConfiguration):
(WebCore::PaymentInstallmentConfiguration::platformConfiguration const):

• Modules/applepay/PaymentMethodUpdate.h:
• Modules/applepay/cocoa/PaymentCocoa.mm:

(WebCore::finishConverting):

• Modules/applepay/cocoa/PaymentMethodCocoa.mm:

(WebCore::finishConverting):

• Modules/applepay/cocoa/PaymentMethodUpdateCocoa.mm:

(WebCore::PaymentMethodUpdate::setInstallmentGroupIdentifier):

• Modules/applepay/cocoa/PaymentSessionErrorCocoa.mm:

(WebCore::additionalError):

• Modules/applepay/paymentrequest/ApplePayRequest.idl:
• Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::setMockMediaPlaybackTargetPickerEnabled):
(WebCore::WebMediaSessionManager::setMockMediaPlaybackTargetPickerState):
(WebCore::WebMediaSessionManager::mockMediaPlaybackTargetPickerDismissPopup):
(WebCore::WebMediaSessionManager::addPlaybackTargetPickerClient):
(WebCore::WebMediaSessionManager::removePlaybackTargetPickerClient):
(WebCore::WebMediaSessionManager::removeAllPlaybackTargetPickerClients):
(WebCore::WebMediaSessionManager::showPlaybackTargetPicker):
(WebCore::WebMediaSessionManager::clientStateDidChange):
(WebCore::WebMediaSessionManager::setPlaybackTarget):
(WebCore::WebMediaSessionManager::externalOutputDeviceAvailableDidChange):
(WebCore::WebMediaSessionManager::playbackTargetPickerWasDismissed):
(WebCore::WebMediaSessionManager::configurePlaybackTargetClients):
(WebCore::WebMediaSessionManager::configurePlaybackTargetMonitoring):
(WebCore::WebMediaSessionManager::configureWatchdogTimer):
(WebCore::WebMediaSessionManager::watchdogTimerFired):

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/cocoa/WebCoreAdditions.mm:

Source/WebCore/PAL:

• pal/cocoa/PassKitSoftLink.h:
• pal/cocoa/PassKitSoftLink.mm:
• pal/spi/cocoa/PassKitSPI.h:

Source/WebKit:

• DerivedSources.make:
• Scripts/webkit/messages.py:
• Shared/ApplePay/ApplePayPaymentSetupFeatures.h: Added.

(WebKit::PaymentSetupFeatures::platformFeatures const):

• Shared/ApplePay/ApplePayPaymentSetupFeatures.mm: Added.

(WebKit::PaymentSetupFeatures::PaymentSetupFeatures):
(WebKit::PaymentSetupFeatures::encode const):
(WebKit::PaymentSetupFeatures::decode):
(WebKit::PaymentSetupFeatures::operator Vector<Ref<WebCore::ApplePaySetupFeature>> const):

• Shared/ApplePay/PaymentSetupConfiguration.h: Added.

(WebKit::PaymentSetupConfiguration::platformConfiguration const):

• Shared/ApplePay/PaymentSetupConfiguration.mm: Added.

(WebKit::toPlatformConfiguration):
(WebKit::PaymentSetupConfiguration::PaymentSetupConfiguration):
(WebKit::PaymentSetupConfiguration::encode const):
(WebKit::PaymentSetupConfiguration::decode):

• Shared/ApplePay/WebPaymentCoordinatorProxy.cpp:
• Shared/ApplePay/WebPaymentCoordinatorProxy.h:

(WebKit::WebPaymentCoordinatorProxy::finishConstruction): Deleted.

• Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in:
• Shared/ApplePay/cocoa/PaymentSetupConfiguration.mm: Added.

(WebKitAdditions::toPlatformConfiguration):
(WebKitAdditions::PaymentSetupConfiguration::PaymentSetupConfiguration):
(WebKitAdditions::PaymentSetupConfiguration::encode const):
(WebKitAdditions::PaymentSetupConfiguration::decode):

• Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::finishCreating):
(WebKit::WebPaymentCoordinatorProxy::getSetupFeatures):
(WebKit::WebPaymentCoordinatorProxy::beginApplePaySetup):
(WebKit::WebPaymentCoordinatorProxy::endApplePaySetup):
(WebKit::WebPaymentCoordinatorProxy::platformBeginApplePaySetup):
(WebKit::WebPaymentCoordinatorProxy::platformEndApplePaySetup):

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::finishDecoding):
(IPC::finishEncoding):
(IPC::ArgumentCoder<WebCore::PaymentInstallmentConfiguration>::encode):
(IPC::ArgumentCoder<WebCore::PaymentInstallmentConfiguration>::decode):

• SourcesCocoa.txt:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::getSetupFeatures):
(WebKit::WebPaymentCoordinator::beginApplePaySetup):
(WebKit::WebPaymentCoordinator::endApplePaySetup):

• WebProcess/ApplePay/WebPaymentCoordinator.h:

6:24 PM Changeset in webkit [260716] by Simon Fraser

• 8 edits in trunk/Source/WebCore

Commit the scrolling tree from the main thread
​https://bugs.webkit.org/show_bug.cgi?id=211026
<rdar://problem/62374855>

Reviewed by Darin Adler.

ScrollingCoordinatorMac::commitTreeStateIfNeeded() passed the new state tree to
the scrolling thread which then did the commit (which updates the scrolling tree
from the state tree). However, applyLayerPositions() immediately waited for that
commit to complete, blocking the main thread anyway.

We might as well just commit the scrolling tree on the main thread. ScrollingTree::commitTreeState()
locks m_treeMutex, so this is still safe. Lock contention with the scrolling or event dispatcher
threads should be rare; those threads are both mostly responsive.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::scrollingTreeAsText const):

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitTreeState):

• page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::waitForScrollingTreeCommit): Deleted.

• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::commitTreeState): Deleted.
(WebCore::ThreadedScrollingTree::incrementPendingCommitCount): Deleted.
(WebCore::ThreadedScrollingTree::decrementPendingCommitCount): Deleted.
(WebCore::ThreadedScrollingTree::waitForPendingCommits): Deleted.
(WebCore::ThreadedScrollingTree::waitForScrollingTreeCommit): Deleted.
(WebCore::ThreadedScrollingTree::applyLayerPositions): Deleted.

• page/scrolling/ThreadedScrollingTree.h:
• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::commitTreeStateIfNeeded):

• page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp:

(WebCore::ScrollingCoordinatorNicosia::commitTreeState):

6:01 PM Changeset in webkit [260715] by jh718.park@samsung.com

• 2 edits in trunk/Source/WTF

Unreviewed. Remove the bulid warnings below since r260707.
warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]

• wtf/URL.cpp:

(WTF::URL::setHost):
(WTF::URL::setHostAndPort):
(WTF::URL::setUser):
(WTF::URL::setPassword):

5:31 PM Changeset in webkit [260714] by ysuzuki@apple.com

• 5 edits in trunk/Source/WebCore

Use static initialized Lock instead of LazyNeverDestroyed<Lock>
​https://bugs.webkit.org/show_bug.cgi?id=211010

Reviewed by Mark Lam.

WTF::Lock can be static-initialized, so no need to use LazyNeverDestroyed<Lock>.

• Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::instancesMutex):

• Modules/webgpu/WebGPUPipeline.cpp:

(WebCore::WebGPUPipeline::instancesMutex):

• html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::instancesMutex):

• html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::instancesMutex):

5:13 PM Changeset in webkit [260713] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Gardening, temporarily skip WebInspector tests after r210942 and r260696
​https://bugs.webkit.org/show_bug.cgi?id=211035

Unreviewed gardening.

• platform/gtk/TestExpectations:

5:00 PM Changeset in webkit [260712] by Darin Adler

• 24 edits in trunk

[Cocoa] Deal with another round of Xcode upgrade checks
​https://bugs.webkit.org/show_bug.cgi?id=211027

Reviewed by Alexey Proskuryakov.

Source/bmalloc:

• bmalloc.xcodeproj/project.pbxproj: Bump the upgrade check version.

Add a harmless base localization; this project contains nothing localized.

Source/JavaScriptCore:

• JavaScriptCore.xcodeproj/project.pbxproj: Bump the upgrade check version.

Add a harmless base localization; this project contains nothing localized.

Source/ThirdParty:

• gtest/xcode/gtest.xcodeproj/project.pbxproj: Bump the upgrade check version.

Add a harmless base localization, rename English localization to en,
remove Japanese, French, German; this project contains nothing localized.

Source/ThirdParty/ANGLE:

• ANGLE.xcodeproj/project.pbxproj: Bump the upgrade check version.

Add a harmless base localization, rename English localization to en,
remove Japanese, French, German; this project contains nothing localized.

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj: Bump the upgrade check version.

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj: Bump the upgrade check version.

Source/WebInspectorUI:

• WebInspectorUI.xcodeproj/project.pbxproj: Bump the upgrade check version.

Add a harmless base localization; this project contains nothing localized.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj: Bump the upgrade check version.

Add a base localization.

Source/WebKitLegacy:

• WebKitLegacy.xcodeproj/project.pbxproj: Bump the upgrade check version.

Source/WTF:

• WTF.xcodeproj/project.pbxproj: Bump the upgrade check version.

Add a harmless base localization; this project contains nothing localized.

Tools:

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Bump the upgrade check version.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Bump the upgrade check version.

Add a harmless base localization; this project contains nothing localized. Also let the
script sort the project.

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Bump the upgrade check version.

Add a harmless base localization; this project contains nothing localized. Also let the
script sort the project.

4:56 PM Changeset in webkit [260711] by ysuzuki@apple.com

• 4 edits
  2 adds in trunk

[JSC] Add fast path for BigInt32 left-shift
​https://bugs.webkit.org/show_bug.cgi?id=211029

Reviewed by Saam Barati.

JSTests:

• stress/bigint-left-shift-overflow.js: Added.

(shouldBe):
(leftShift):
(noInline):

• stress/bigint-right-shift-large.js: Added.

(shouldBe):

Source/JavaScriptCore:

Currently, the left-shift operation misses the fast path for BigInt32 <> BigInt32 case. This patch adds it. We also fixes
prediction-propagation for left/right shift to use existing heap prediction instead of polluting the result with SpecBigInt.
This offer 4.5% improvement in microbenchmarks/sunspider-sha1-big-int.js.

• dfg/DFGPredictionPropagationPhase.cpp:
• runtime/Operations.h:

(JSC::shift):

4:47 PM Changeset in webkit [260710] by Ross Kirsling

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed fix for JSC Debug tests following r210853.

• runtime/IntlObject.cpp:

(JSC::canonicalizeLanguageTag):
(JSC::canonicalizeLocaleList):
(JSC::defaultLocale):
Deal with unchecked exception by moving tryGetUtf8 call out of canonicalizeLanguageTag; it's meant to
verify the user input from canonicalizeLocaleList and needn't change the noexcept-ness of defaultLocale.

2:28 PM Changeset in webkit [260709] by commit-queue@webkit.org

• 123 edits in trunk/Source

Prepare to remove automatic URL->String conversion operators
​https://bugs.webkit.org/show_bug.cgi?id=211007

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-25
Reviewed by Darin Adler.

Source/JavaScriptCore:

• API/JSAPIGlobalObject.mm:

(JSC::JSAPIGlobalObject::moduleLoaderResolve):
(JSC::JSAPIGlobalObject::moduleLoaderImportModule):

• API/JSScript.mm:

(validateBytecodeCachePath):
(+[JSScript scriptOfType:memoryMappedFromASCIIFile:withSourceURL:andBytecodeCache:inVirtualMachine:error:]):

• inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::sourceParsed):

• parser/Nodes.h:

(JSC::ScopeNode::sourceURL const):

• runtime/CachedTypes.cpp:

(JSC::CachedSourceProviderShape::encode):

• runtime/Error.cpp:

(JSC::addErrorInfo):

• runtime/ScriptExecutable.h:

(JSC::ScriptExecutable::sourceURL const):

Source/WebCore:

• Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::requestFromInfo):

• Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::urlString const):

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::fetch):

• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

• accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::stringValueForMSAA const):

• bindings/IDLTypes.h:

(WebCore::IDLString::isNullValue):

• bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

• bindings/js/JSDOMConvertStrings.h:

(WebCore::JSConverter<IDLDOMString>::convert):
(WebCore::Converter<IDLUSVString>::convert):
(WebCore::JSConverter<IDLUSVString>::convert):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluateModule):
(WebCore::ScriptController::callInWorld):
(WebCore::ScriptController::executeIfJavaScriptURL):

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):

• css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::updateCursorElement):

• css/CSSImageValue.cpp:

(WebCore::CSSImageValue::customCSSText const):
(WebCore::CSSImageValue::createDeprecatedCSSOMWrapper const):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontFaceSrcURI):

• dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

• dom/ExtensionStyleSheets.cpp:

(WebCore::createExtensionsStyleSheet):

• dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):

• dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestModuleScript):
(WebCore::ScriptElement::executeClassicScript):

• dom/StyledElement.cpp:

(WebCore::StyledElement::styleAttributeChanged):

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::sanitizeMarkupWithArchive):
(WebCore::WebContentReader::readWebArchive):

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::formAction const):

• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::canLoadURL const):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::shouldLoadLink):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectNextSourceChild):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::canLoadURL const):

• html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):

• inspector/InspectorAuditResourcesObject.cpp:

(WebCore::InspectorAuditResourcesObject::getResources):

• inspector/InspectorStyleSheet.cpp:

(WebCore::buildArrayForGroupings):

• inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::responseReceived):

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForCachedResource):
(WebCore::InspectorNetworkAgent::willSendRequest):

• inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

• inspector/agents/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::connectToWorkerInspectorProxy):

• inspector/agents/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::didFailLoading):

• inspector/agents/worker/ServiceWorkerAgent.cpp:

(WebCore::ServiceWorkerAgent::getInitializationInfo):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::subresources const):

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::clientRedirectDestinationForHistory const):
(WebCore::DocumentLoader::serverRedirectDestinationForHistory const):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
(WebCore::createWindow):

• loader/HistoryController.cpp:

(WebCore::HistoryController::currentItemShouldBeReplaced const):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):
(WebCore::LinkLoader::prefetchIfNeeded):

• loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::checkFormForMixedContent const):

• loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::shouldScheduleNavigation const):
(WebCore::NavigationScheduler::scheduleLocationChange):

• loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):

• loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestObject):

• loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

• loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::addResource):
(WebCore::ApplicationCache::resourceForRequest):

• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
(WebCore::ApplicationCacheGroup::didFinishLoadingEntry):
(WebCore::ApplicationCacheGroup::didFailLoadingEntry):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):

• loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
(WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource):

• loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::loadCacheGroup):
(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
(WebCore::ApplicationCacheStorage::findInMemoryCacheGroup const):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
(WebCore::ApplicationCacheStorage::cacheGroupMadeObsolete):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::deleteCacheForOrigin):

• loader/archive/ArchiveResourceCollection.cpp:

(WebCore::ArchiveResourceCollection::addAllResources):
(WebCore::ArchiveResourceCollection::addResource):
(WebCore::ArchiveResourceCollection::archiveResourceForURL):

• loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::checkNotify):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::cachedResource const):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy const):
(WebCore::CachedResourceLoader::notifyFinished):

• loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::didAddClient):
(WebCore::CachedXSLStyleSheet::checkNotify):

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::checkOrEnableIfNeeded const):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):

• page/Location.cpp:

(WebCore::Location::reload):

• page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForProperties):

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::shouldIgnoreHost):

• page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::shouldInheritSecurityOriginFromOwner):
(WebCore::SecurityPolicy::isBaseURLSchemeAllowed):

• page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation const):

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::assetURL const):

• platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::writeBlobToFilePath):

• platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::platformLazyInit):

• storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):

• svg/SVGImageLoader.cpp:

(WebCore::SVGImageLoader::sourceURI const):

• workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously):

• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::scope const):

• workers/service/ServiceWorkerRegistrationKey.cpp:

(WebCore::ServiceWorkerRegistrationKey::hash const):
(WebCore::ServiceWorkerRegistrationKey::isMatching const):

• workers/service/context/ServiceWorkerDebuggable.cpp:

(WebCore::ServiceWorkerDebuggable::ServiceWorkerDebuggable):

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::startScriptFetch):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

Source/WebKit:

• Shared/API/APIError.h:

(API::Error::failingURL const):

• Shared/API/c/WKSharedAPICast.h:

(WebKit::toCopiedURLAPI):

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPagePolicyClient):

• UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:

(WebKit::reportAnErrorURL):

• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::requestUserMediaAuthorizationForFrame):
(WebKit::UIDelegate::UIClient::checkUserMediaPermissionForOrigin):

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::readURLFromPasteboard):

• UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::cancel):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::didExplicitOpenForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::didChangeProvisionalURLForFrameShared):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::createNewPage):

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(-[WKWebProcessPlugInFrame URL]):

• WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::didReceiveResponse):

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::clickedLink):
(WebKit::PDFPlugin::openWithNativeApplication):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performURLRequest):
(WebKit::PluginView::performJavaScriptURLRequest):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::shouldForceUniversalAccessFromLocalURL):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::info const):

• WebProcess/WebStorage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::removeItem):
(WebKit::StorageAreaMap::clear):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::origin):

Source/WebKitLegacy/mac:

• DOM/DOMDocument.mm:

(-[DOMDocument URL]):

• DOM/DOMHTMLAnchorElement.mm:

(-[DOMHTMLAnchorElement href]):

• DOM/DOMHTMLAreaElement.mm:

(-[DOMHTMLAreaElement href]):

• DOM/DOMHTMLEmbedElement.mm:

(-[DOMHTMLEmbedElement src]):

• DOM/DOMHTMLFormElement.mm:

(-[DOMHTMLFormElement action]):

• DOM/DOMHTMLFrameElement.mm:

(-[DOMHTMLFrameElement src]):
(-[DOMHTMLFrameElement location]):

• DOM/DOMHTMLHtmlElement.mm:

(-[DOMHTMLHtmlElement manifest]):

• DOM/DOMHTMLIFrameElement.mm:

(-[DOMHTMLIFrameElement src]):

• DOM/DOMHTMLImageElement.mm:

(-[DOMHTMLImageElement longDesc]):
(-[DOMHTMLImageElement src]):
(-[DOMHTMLImageElement currentSrc]):
(-[DOMHTMLImageElement lowsrc]):

• DOM/DOMHTMLInputElement.mm:

(-[DOMHTMLInputElement src]):

• DOM/DOMHTMLLinkElement.mm:

(-[DOMHTMLLinkElement href]):

• DOM/DOMHTMLMediaElement.mm:

(-[DOMHTMLMediaElement src]):
(-[DOMHTMLMediaElement currentSrc]):

• DOM/DOMHTMLModElement.mm:

(-[DOMHTMLModElement cite]):

• DOM/DOMHTMLObjectElement.mm:

(-[DOMHTMLObjectElement data]):

• DOM/DOMHTMLQuoteElement.mm:

(-[DOMHTMLQuoteElement cite]):

• DOM/DOMHTMLScriptElement.mm:

(-[DOMHTMLScriptElement src]):

• DOM/DOMHTMLVideoElement.mm:

(-[DOMHTMLVideoElement poster]):

• DOM/DOMNode.mm:

(-[DOMNode baseURI]):

• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::updateGlobalHistory):
(WebFrameLoaderClient::setTitle):

• WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _animationControllerForDataDetectedLink]):

• WebView/WebNotification.mm:

(-[WebNotification iconURL]):

• WebView/WebScriptDebugger.mm:

(WebScriptDebugger::sourceParsed):
(toNSURL): Deleted.

Source/WTF:

Too many bugs have been caused by the compiler finding a way to make a String from a URL without being visible in the code.
This does all the easy things to prepare to remove operator String& and operator NSString*.
The hard things will be done in the smaller patch that actually removes them.

• wtf/URL.cpp:

(WTF::URL::protocolIsJavaScript const):

• wtf/URL.h:

12:13 PM Changeset in webkit [260708] by Alan Bujtas

• 4 edits
  2 adds in trunk

[LFC][TFC] Add vertical-align: baseline support
​https://bugs.webkit.org/show_bug.cgi?id=211024

Reviewed by Antti Koivisto.

Source/WebCore:

Adjust the padding with the baseline offset when the cell is baseline aligned (as opposed to the initial value of 'middle').

Test: fast/layoutformattingcontext/table-basic-row-vertical-align-baseline.html

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraVerticalSpace):

• layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::Cell::setBaselineOffset):
(WebCore::Layout::TableGrid::Cell::baselineOffset const):

LayoutTests:

• fast/layoutformattingcontext/table-basic-row-vertical-align-baseline-expected.txt: Added.
• fast/layoutformattingcontext/table-basic-row-vertical-align-baseline.html: Added.

11:01 AM Changeset in webkit [260707] by Darin Adler

• 89 edits in trunk

Move URL to use StringView when returning substrings of the URL
​https://bugs.webkit.org/show_bug.cgi?id=210431

Reviewed by Anders Carlsson.

LayoutTests/imported/w3c:

• web-platform-tests/url/url-setters-expected.txt: Updated expected results for progression in

correct behavior when port numbers are >65535. I didn't originally intend to make this improvement,
but it fell out naturally from the refactoring changes.

Source/WebCore:

• Modules/cache/DOMCacheEngine.cpp:

(WebCore::DOMCacheEngine::matchURLs): Removed unneeded calls to hasQuery.

• Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::initializeWith): Use hasCredentials.

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::redirect): Use hasCredentials.

• Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::isValidURLBasedPaymentMethodIdentifier): Use hasCredentials.

• Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::createYouTubeURL): Take StringView.
(WebCore::queryKeysAndValues): Take StringView.
(WebCore::processAndCreateYouTubeURL): Use auto since URL pieces are
now returned as StringView.
(WebCore::YouTubePluginReplacement::youTubeURLFromAbsoluteURL):
Use StringView and makeString rather than StringBuilder.

• Modules/websockets/WebSocketHandshake.cpp:

(WebCore::resourceName): Use queryWithLeadingQuestionMark.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::internalLinkElement const):
Use StringView.

• dom/Document.cpp:

(WebCore::Document::setURL): Use setHostAndPort.

• dom/Element.cpp:

(WebCore::Element::findAnchorElementForLink): Update since
fragmentIdentifier returns StringView.

• dom/TreeScope.cpp: Added a comment.

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::replaceRichContentWithAttachments): Update since
lastPathComponent returns a StringView. Also got rid of some strange
use of AtomString that was not necessary and used WTFMove more.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::writeImageToPasteboard): Update since
lastPathComponent returns a StringView.

• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::attachmentTitleForDisplay const):
Use makeString instead of StringBuilder, and StringView instead of
String for name and extension values.

• html/HTMLPlugInElement.cpp:

(WebCore::pluginReplacementForType): Update since lastPathComponent
returns a StringView.

• html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseFragments): Update since
fragmentIdentifier returns a StringView.

• html/URLUtils.h: Changed many functions to take a StringView, changed

various other functions to call toString, since the underlying URL
function now returns a StringView. Updated names since "pass" is now
"password".
(WebCore::countASCIIDigits): Added. Replaces unusual function
named parsePortFromStringPosition because we can use StringView now
and so don't need such an unusual function.

• loader/AdClickAttribution.cpp:

(WebCore::AdClickAttribution::parseConversionRequest): Use hasCredentials.
Also removed unnecessary use of ASCIILiteral that hurts performance
a tiny bit.
(WebCore::AdClickAttribution::urlForTesting const): Use makeString
instead of StringBuilder.

• loader/CrossOriginAccessControl.cpp:

(WebCore::validateCrossOriginRedirectionURL): Use hasCredentials.

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest): Use hasCredentials.

• loader/FormSubmission.cpp:

(WebCore::appendMailtoPostFormDataToURL): Update since query returns
StringView.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument): Use equalRespectingNullity on
fragment identifiers to preserve behavior, since at this time
StringView == StringView does not respect nullity, but String == String does.

• loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::createFileURL): Use fileURLWithFileSystemPath.

• loader/appcache/ManifestParser.cpp:

(WebCore::manifestPath): Return a StringView.
(WebCore::parseManifest): Use StringView.

• loader/cache/CachedFont.cpp:

(WebCore::CachedFont::calculateItemInCollection const): Update since
fragmentIdentifer returns a StringView.

• loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::splitFragmentIdentifierFromRequestURL): Ditto.

• page/FrameView.cpp:

(WebCore::FrameView::scrollToFragment): Ditto.
(WebCore::FrameView::scrollToFragmentInternal): Updated log message.

• page/History.cpp:

(WebCore::History::stateObjectAdded): Updated for URL::password name change
and to use the new stringWithoutQueryOrFragmentIdentifier rather than the
old equalIgnoringQueryAndFragment.

• page/Location.cpp:

(WebCore::Location::href const): Use removeCredentials.
(WebCore::Location::port const): Streamlined.
(WebCore::Location::pathname const): Use an ASCIILiteral.
(WebCore::Location::search const): Use queryWithLeadingQuestionMark.
(WebCore::Location::hash const): Use fragmentIdentifierWithLeadingNumberSign.
(WebCore::Location::setPort): Use parseUInt16.

• page/UserContentURLPattern.cpp: Coding style tweaks.

• platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::appendFileExtensionIfNecessary):
Use contains instead of reverseFind to check for a period in the filename.

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::load): Updated since lastPathComponent is a StringView.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::convertToInternalProtocol): Updated to use makeString since
setProtocol takes a StringView.

• platform/network/ResourceHandleInternal.h: Renamed m_pass to m_password

and call password instead of pass.

• platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::removeCredentials): Use removeCredentials.

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection): Updated for m_password
name change.
(WebCore::ResourceHandle::willSendRequest): Updated for m_password and
password name changes.
(WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication): Ditto.

• platform/network/curl/CurlProxySettings.cpp:

(WebCore::CurlProxySettings::setUserPass): Updated for setPassword name change.
(WebCore::createProxyUrl): Use hasCredentials, updated for password name change.

• platform/network/curl/CurlProxySettings.h:

(WebCore::CurlProxySettings::password const): Updated for password name change.

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Updated for
m_password name change.
(WebCore::ResourceHandle::getCredential): Ditto.
(WebCore::ResourceHandle::willSendRequest): Updated for m_password and
password name changes.

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection): Updated for m_password
and setPassword name changes.
(WebCore::ResourceHandle::willSendRequest): Ditto.
(WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication): Ditto.

• platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::createSoupURI const): Updated for password name change.

• platform/network/soup/URLSoup.cpp:

(WebCore::soupURIToURL): Updated for setPassword name change.

• platform/win/PasteboardWin.cpp:

(WebCore::writeURL): Updated since lastPathComponent returns a StringView.
(WebCore::filesystemPathFromUrlOrTitle): Ditto.
(WebCore::Pasteboard::write): Ditto.

• style/StyleBuilderState.cpp:

(WebCore::Style::BuilderState::createFilterOperations): Updated since
fragmentIdentifier returns a StringView.

• workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::port const): Streamlined.
(WebCore::WorkerLocation::pathname const): Use an ASCIILiteral.
(WebCore::WorkerLocation::search const): Use queryWithLeadingQuestionMark.
(WebCore::WorkerLocation::hash const): Use fragmentIdentifierWithLeadingNumberSign.

• workers/service/ServiceWorkerRegistrationKey.cpp:

(WebCore::ServiceWorkerRegistrationKey::ServiceWorkerRegistrationKey):
Updated for hasFragmentIdentifier name change.

• workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::topOriginURL): Simplified code to set port.

• workers/service/server/SWServer.cpp:

(WebCore::originURL): Ditto.

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open): Updated for setPassword name change.

Source/WebKit:

• NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::checkRedirection): Use hasCredentials.
(WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded const):
Remove use of ASCIILiteral for setProtocol.

• NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::NetworkDataTaskCurl): Updated for
password name change.
(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection): Ditto.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Updated
for password name change.
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection): Ditto.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup): Updated for
password name change.
(WebKit::NetworkDataTaskSoup::applyAuthenticationToRequest): Ditto.
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Ditto.
(WebKit::NetworkDataTaskSoup::shouldAllowHSTSPolicySetting const):
Use != to compare hosts, rather than hostsAreEqual.
(WebKit::NetworkDataTaskSoup::shouldAllowHSTSProtocolUpgrade const):

Refactored to use

to match the function above.

• Shared/API/APIURL.h:

(API::URL::host const): Removed validity check; WTF::URL::host
returns null if the URL is invalid.
(API::URL::protocol const): Ditto.
(API::URL::path const): Ditto.
(API::URL::lastPathComponent const): Ditto. Also added toString
since WTF::URL::lastPathComponent now returns a StringView.

• UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::didFinish): Use hasFragmentIdentifier.

• UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::DeviceIdHashSaltStorage::loadStorageFromDisk):
Refactored a bit and use fileURLWithFileSystemPath and
updated since lastPathComponent returns a StringView.

• UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::pathExtension): Updated since lastPathComponent
returns a StringView. Refactored a little.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
Use truncatedForUseAsBase.
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Use != to compare hosts, rather than hostsAreEqual.
(WebKit::WebPageProxy::decidePolicyForNewWindowAction): Ditto.
(WebKit::WebPageProxy::createNewPage): Ditto.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::assumeReadAccessToBaseURL):
Use truncatedForUseAsBase.

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::initializeAppBoundDomains):
Don't use ASCIILiteral for argument to setProtocol.

• WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:

(WebKit::WebMediaKeyStorageManager::getMediaKeyOrigins):
Use fileURLWithFileSystemPath, also refactored a bit.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::installPDFDocument): Updated since
fragmentIdentifier returns a StringView.

• WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle): Streamlined
the implementation a bit.

• WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage):
Updated since lastPathComponent returns a StringView.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebFrameLoaderClient.mm:

(shouldTryAppLink): Compare hosts with == rather than using hostsAreEqual.

• WebView/WebFrame.mm:

(-[WebFrame _documentFragmentForImageData:withRelativeURLPart:andMIMEType:]):
Updated since fakeURLWithRelativePart takes a StringView. Also use RetainPtr
instead of an explicit call to release.

• WebView/WebHTMLView.mm:

(-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
Updated since fakeURLWithRelativePart takes a StringView. No conversion
directly from NSString to StringView, so we have to explicitly use a String.

• WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _defaultAnimationController]): Update
since protocolIs takes a StringView. No conversion directly from
NSString to StringView, so we have to explicitly use a String.

Source/WebKitLegacy/win:

• Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::PluginDatabase): Moved initialization of
m_persistentMetadataCacheIsLoaded to the class definition.
(WebCore::PluginDatabase::MIMETypeForExtension const): Take StringView.
(WebCore::PluginDatabase::findPlugin): Use StringView.

• Plugins/PluginDatabase.h: Changed MIMETypeForExtension to take

a StringView. Took out some unneeded declarations. Initialized
m_persistentMetadataCacheIsLoaded here in the class definition.

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::objectContentType): Use StringView a little more.

• WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle): Streamlined the implementation a bit.
(WebContextMenuClient::lookUpInDictionary): Added "using namespace WebCore".

Source/WTF:

• wtf/URL.cpp: Remove unused CharBuffer type. Remove UCharBuffer

type and write the type explicitly in the 3 places it's used.
Removed the invalidPortNumber constant, since we use Optional
instead of a special port number now.
(WTF::copyASCII): Remove unnecessary special case for empty string.
Tweaked coding style and comment a bit.
(WTF::URL::URL): Streamlined by getting rid of a local variable.
(WTF::shouldTrimFromURL): Tweaked coding style.
(WTF::URL::lastPathComponent const): Return a StringView.
Also, use the pathStart function for clarity.
(WTF::URL::port const): Use a StringView to call parseUInt16.
(WTF::URL::protocolHostAndPort const): Optimized to always allocate
the string in the right size rather than removing characters from it
after creating it.
(WTF::decodeEscapeSequence): Added. Factored out from the function
below to make it a little more readable.
(WTF::decodeEscapeSequencesFromParsedURL): Convert a null StringView
to a null String rather than an empty String, use a stack buffer and
the helper function above, and added some FIXME comments about
encoding handling.
(WTF::URL::user const): Simplified by calling encodedUser.
(WTF::URL::password const): Simplified by calling encodedPassword.
(WTF::URL::encodedUser const): Return a StringView.
(WTF::URL::encodedPassword const): Ditto. Also renamed from encodedPass.
(WTF::URL::fragmentIdentifier const): Ditto.
(WTF::URL::hasFragmentIdentifier const): Moved to header so it can
be inlined.
(WTF::URL::truncatedForUseAsBase const): Renamed from baseAsString.
This function is currently only used with local file URLs and it's
not perfectly clear to me precisely what it is for, hence the name
is not so great.
(WTF::URL::fileSystemPath const): Removed unneeded check for validity
since isLocalFile does that check. Removed unneeded typecast now that
path returns a StringView.
(WTF::defaultPortForProtocolMapForTesting): Deleted.
(WTF::ensureDefaultPortForProtocolMapForTesting): Deleted.
(WTF::registerDefaultPortForProtocolForTesting): Deleted.
(WTF::clearDefaultPortForProtocolMapForTesting): Deleted.
(WTF::defaultPortForProtocol): Deleted.
(WTF::isDefaultPortForProtocol): Deleted.
(WTF::protocolIsInternal): Rewrote to take a StringView. Before it
was written as a template that looked like it supported classes other
than String, but actually would crash if called on a StringView.
(WTF::URL::protocolIs const): Removed unneeded explicit cast to StringView.
(WTF::URL::query const): Return a StringView.
(WTF::URL::path const): Return a StringView, use the pathStart
function for clarity.
(WTF::URL::setProtocol): Use a toStringWithoutCopying to save some
work when making the protocol canonical. Call parse instead of
creating a URLParser here.
(WTF::URL::credentialsEnd const): Added. Helper for various functions
that manipulate the credentials section.
(WTF::URL::setHost): Take StringView. Streamlined the code by using
StringView::contains, by using makeString rather than StringBuilder,
and by calling parse instead of creating a URLParser here.
(WTF::URL::removePort): Deleted, since setPort takes an Optional now.
(WTF::URL::setPort): Take Optional<uint16_t>. Call parse instead of
creating a URLParser here.
(WTF::URL::removeHostAndPort): Deleted. Callers can pass a null
StringView to setHostAndPort instead.
(WTF::URL::setHostAndPort): Take StringView. Don't remove the old
host and port in the nomral case where we end up overwriting the entire
URL at the end of the function anyway. Use parseUInt16 instead of
toIntStrict to check port number for validity, which makes sure we will
reject port numbers larger than 65535. Use makeString instead of
StringBuilder and call parse rather than creating a URLParser here.
(WTF::parse): Added. Helper function for when we create a new string
and want to parse it as the new contents of the URL. Used in almost
every setter function.
(WTF::URL::remove): Added. Helper function for efficiently removing
a piece of the URL string and re-parsing. Used in many setter functions.
(WTF::URL::setUser): Take StringView. Use makeString instead of
StringBuilder, and parse and remove instead of creating a URLParser here.
(WTF::URL::setPassword): Renamed from setPass. Take StringView.
Use makeString instead of StringBuilder, and parse and remove instead of
creating a URLParser here.
(WTF::URL::removeCredientials): Added. Efficiently removes both the
user name and password if either is present.
(WTF::URL::setFragmentIdentifier): Use parse instead of creating
a URL parser here.
(WTF::URL::removeFragmentIdentifier): Removed unnecessary checks for
things already optimized by String::left. Could later consider merging
this in with setFragmentIdentifier, using a null vs. empty distinction,
but not doing that for now.
(WTF::URL::setQuery): Take StringView.
(WTF::URL::setPath): Take StringView.
(WTF::stringWithoutQueryOrFragmentIdentifier): Added.
(WTF::stringWithoutFragmentIdentifier): Added.
(WTF::equalIgnoringFragmentIdentifier): Simplified implementation by
using stringWithoutFragmentIdentifier.
(WTF::equalIgnoringQueryAndFragment): Deleted.
(WTF::hostsAreEqual): Deleted.
(WTF::URL::isMatchingDomain const): Take StringView.
(WTF::protocolIs): Take StringView.
(WTF::URL::protocolIs): Moved to inline in the header.
(WTF::URL::strippedForUseAsReferrer const): Rewrite for efficiency.
(WTF::protocolIsJavaScript): Moved to inline in the header.
(WTF::protocolIsInHTTPFamily): Take StringView.
(WTF::aboutBlankURL): Use ASCIILiteral.
(WTF::aboutSrcDocURL): Use ASCIILiteral.
(WTF::portAllowed): Removed 65535 as a blocked port; wasn't needed.
(WTF::mimeTypeFromDataURL): Take StringView.
(WTF::URL::stringCenterEllipsizedToLength const): Tweaked style.
(WTF::URL::fakeURLWithRelativePart): Take StringView.
(WTF::URL::fileURLWithFileSystemPath): Take StringView..
(WTF::URL::queryWithLeadingQuestionMark const): Added.
(WTF::URL::fragmentIdentifierWithLeadingNumberSign const): Added.
(WTF::URL::hostIsIPAddress): Tweak coding style.

• wtf/URL.h: Made URLTextEncoding destructor protected. Removed

unused forward declaration of URLHash structure. Use WTF_EXPORT_PRIVATE
on functions from URL rather than on the whole class, since the style
checker told me to do that. Moved some inline function bodies out of
the class definition for clarity and to keep the style checker happy.
Updated many arguemnts from String to StringView and return values for
substrings of the URL to StringView. Removed some unused functions and
some obsolete comments.

• wtf/cf/CFURLExtras.cpp:

(WTF::isCFURLSameOrigin): Use hasCredentials.

• wtf/text/StringView.cpp:

(WTF::StringView::endsWith const): Added.
(WTF::parseUInt16): Added.
(WTF::equalRespectingNullity): Added.
(WTF::StringView::contains const): Added overload that takes a
const char* so the call site doesn't have to convert it to a StringView.

• wtf/text/StringView.h: Updated for the additions above.

Also added a default start of 0 to the find function.

• wtf/text/WTFString.cpp:

(WTF::charactersToIntStrict): Removed unneeded explicit template argument.
(WTF::charactersToUIntStrict): Ditto.
(WTF::charactersToInt64Strict): Ditto.
(WTF::charactersToUInt64Strict): Ditto.
(WTF::charactersToIntPtrStrict): Ditto.
(WTF::charactersToInt): Ditto.
(WTF::charactersToUInt): Ditto.
(WTF::charactersToInt64): Ditto.
(WTF::charactersToUInt64): Ditto.
(WTF::charactersToIntPtr): Ditto.

Tools:

• TestWebKitAPI/Tests/WTF/URL.cpp: Removed the test for

equalIgnoringQueryAndFragment since we removed that function.
Updated for rename of URL::password from URL::pass.
Updated arguments to isMatchingDomain to pass literals that can be converted
to StringView rather than ASCIILiteral, which StringView doesn't yet support.

• TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:

(TestWebKitAPI::checkURL): Updated for rename of URL::password from URL::pass.
(TestWebKitAPI::checkRelativeURL): Ditto.
(TestWebKitAPI::checkURLDifferences): Ditto.
(TestWebKitAPI::checkRelativeURLDifferences): Ditto.
(TestWebKitAPI::testUserPassword): Ditto.

10:03 AM Changeset in webkit [260706] by Chris Fleizach

• 3 edits in trunk/Source/WebCore

AX: Improve tracking of Element* pointers in AXObjectCache with WeakHashSet
​https://bugs.webkit.org/show_bug.cgi?id=210879

Reviewed by Daniel Bates.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::filterListForRemoval):
(WebCore::AXObjectCache::performDeferredCacheUpdate):

• accessibility/AXObjectCache.h:

9:08 AM Changeset in webkit [260705] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

[Web Animations] KeyframeEffect should ensure its target remains alive
​https://bugs.webkit.org/show_bug.cgi?id=211019

Patch by Antoine Quint <Antoine Quint> on 2020-04-25
Reviewed by Daniel Bates.

Source/WebCore:

Test: webanimations/keyframe-effect-target-kept-alive.html

Make KeyframeEffect::m_target a RefPtr so that assigning an element to effect.target guarantees that element
is kept alive even if there are no other references to that element.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::setTarget):

• animation/KeyframeEffect.h:

LayoutTests:

Add a test that creates a KeyframeEffect targeting an element with no other reference and trigger
garbage collection to check that the effect's target exists. This test would have failed prior to
this patch's code changes.

• webanimations/keyframe-effect-target-kept-alive-expected.txt: Added.
• webanimations/keyframe-effect-target-kept-alive.html: Added.

8:46 AM Changeset in webkit [260704] by ddkilzer@apple.com

• 7 edits in trunk/Source/WebKit

IPC::Decoder::isInvalid() should be renamed to isValid()
<​https://webkit.org/b/211000>

Reviewed by Darin Adler.

Negative logic is more difficult to reason about than positive
logic.

• Platform/IPC/Connection.cpp:

(IPC::Connection::dispatchMessage):
(IPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(IPC::Connection::dispatchThreadMessageReceiverMessage):
(IPC::Connection::dispatchSyncMessage):

• Platform/IPC/Connection.h:

(IPC::Connection::sendWithAsyncReply):

• Platform/IPC/Decoder.cpp:

(IPC::Decoder::create):

• Platform/IPC/Decoder.h:

(IPC::Decoder::isValid const): Rename from isInvalid()
and invert logic.
(IPC::Decoder::isInvalid const): Rename to isValid().

• Platform/IPC/MessageSender.h:
• UIProcess/AuxiliaryProcessProxy.h:

(WebKit::AuxiliaryProcessProxy::sendWithAsyncReply):

• Change Decoder::isInvalid() to Decoder::isValid() and reverse the Boolean logic.

8:22 AM Changeset in webkit [260703] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][TFC] Cleanup TableFormattingContext::layoutInFlowContent
​https://bugs.webkit.org/show_bug.cgi?id=211023

Reviewed by Sam Weinig.

Move some code to dedicated functions.

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):
(WebCore::Layout::TableFormattingContext::layoutCell):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraVerticalSpace):
(WebCore::Layout::TableFormattingContext::initializeDisplayBoxToBlank const): Deleted.
(WebCore::Layout::TableFormattingContext::setComputedGeometryForRows): Deleted.
(WebCore::Layout::TableFormattingContext::setComputedGeometryForSections): Deleted.

• layout/tableformatting/TableFormattingContext.h:
• layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::cellHeigh const):
(WebCore::Layout::TableFormattingContext::Geometry::computedColumnWidth const):
(WebCore::Layout::TableFormattingContext::Geometry::tableCellHeightAndMargin const): Deleted.

7:46 AM Changeset in webkit [260702] by Diego Pino Garcia

• 3 edits in trunk/Tools

[Flatpak SDK][EWS] Install dependencies step needs configuration as argument
​https://bugs.webkit.org/show_bug.cgi?id=210913

Follow-up on r260560. The same change is needed for EWS bots.

Reviewed by Philippe Normand.

• BuildSlaveSupport/ews-build/steps.py:

(InstallGtkDependencies): Pass 'configuration' value (Release, Debug).
(InstallWpeDependencies): Pass 'configuration' value (Release, Debug).

7:41 AM Changeset in webkit [260701] by Diego Pino Garcia

• 1 edit
  6 adds in trunk/LayoutTests

[GTK] Gardening, emit baselines after r260690
​https://bugs.webkit.org/show_bug.cgi?id=211022

Unreviewed gardening.

• platform/gtk/imported/w3c/web-platform-tests/css/css-animations/animation-base-response-001-expected.txt:

Added after r260690.

• platform/gtk/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any-expected.txt:

Added after r260690.

• platform/gtk/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any.worker-expected.txt:

Added after r260662.

6:50 AM Changeset in webkit [260700] by commit-queue@webkit.org

• 2 edits in trunk/JSTests

Skip stress/butterfly-zero-unused-butterfly-properties.js on MIPS
​https://bugs.webkit.org/show_bug.cgi?id=211016

Unreviewed Gardening.

Patch by Paulo Matos <Paulo Matos> on 2020-04-25

• stress/butterfly-zero-unused-butterfly-properties.js:

5:05 AM Changeset in webkit [260699] by jh718.park@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Remove the build warning below since r260247.
warning: unused parameter ‘foo’ [-Wunused-parameter]

No new tests, no new behaviors.

• testing/Internals.cpp:

(WebCore::Internals::hasSandboxIOKitOpenAccessToClass):

2:23 AM Changeset in webkit [260698] by graouts@webkit.org

• 5 edits in trunk/LayoutTests

Skip legacy media controls tests on macOS and iOS
​https://bugs.webkit.org/show_bug.cgi?id=211015
<rdar://problem/62064255>

Unreviewed test gardening.

• platform/ios/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:
• platform/wk2/TestExpectations:

2:14 AM Changeset in webkit [260697] by Ross Kirsling

• 15 edits
  2 deletes in trunk

[Intl] Locale validation/canonicalization should defer to ICU
​https://bugs.webkit.org/show_bug.cgi?id=210853

Reviewed by Darin Adler.

JSTests:

• stress/intl-collator.js:
• stress/intl-datetimeformat.js:
• stress/intl-numberformat.js:
• stress/intl-object.js:
• stress/intl-pluralrules.js:
• stress/intl-relativetimeformat.js:

Adjust tests, since one of the two fixes in r260151 no longer applies
(and certain sensitivities apply to older ICU versions).

• test262/expectations.yaml:

Mark eight new passes, two new fails, and six changed failures.
It is an unfortunate and baffling truth that the Intl tests of test262 are often not spec tests at all,
but effectively ICU/CLDR regression tests. These are not carrots worth chasing.

Source/JavaScriptCore:

The mappings for locale canonicalization in latest CLDR are sufficiently complex
that it really no longer makes sense not to have ICU do this work for us.

This means the UTS 35 canonicalization desired by ECMA-402 will not be fully achievable until ICU ~67,
but it's better than reaching right into CLDR and pretending that we *are* ICU.
(On this point, we thus align with V8 and diverge from SM.)

Of course, we can still add our own pre-validations / post-canonicalizations if desired.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Scripts/generateIntlCanonicalizeLanguage.py: Removed.
• runtime/IntlObject.cpp:

(JSC::intlAvailableLocales):
(JSC::intlCollatorAvailableLocales):
(JSC::canonicalizeLanguageTag):
(JSC::canonicalizeLocaleList):
(JSC::defaultLocale):
(JSC::removeUnicodeLocaleExtension):
(JSC::addMissingScriptLocales): Deleted. This one was ostensibly a fix for an old ICU bug.
(JSC::privateUseLangTag): Deleted.
(JSC::preferredLanguage): Deleted.
(JSC::preferredRegion): Deleted.
(JSC::canonicalLangTag): Deleted.

• ucd/language-subtag-registry.txt: Removed.

1:56 AM Changeset in webkit [260696] by Diego Pino Garcia

• 4 edits in trunk/Source

Source/WebInspectorUI:
REGRESSION(210942): [GTK][WPE] Unreviewed, EWS build bots fail in compile-webkit step
​https://bugs.webkit.org/show_bug.cgi?id=211014

• CMakeLists.txt: Remove creation of file 'inspector-resources.stamp'.

Source/WebKit:
REGRESSION(210942): [GTK][WPE] EWS build bots fail in compile-webkit step
​https://bugs.webkit.org/show_bug.cgi?id=211014

Make command that generates 'InspectorGResourceBundle.xml' depend on target
WebInspectorUI, instead of file 'inspector-resources.stamp'.

• InspectorGResources.cmake:

1:10 AM Changeset in webkit [260695] by Kocsen Chung

• 8 edits in branches/safari-610.1.11-branch/Source

Versioning.

1:00 AM Changeset in webkit [260694] by Kocsen Chung

• 1 copy in tags/Safari-610.1.11.2

Tag Safari-610.1.11.2.

12:47 AM Changeset in webkit [260693] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Fix internal build by using strcmp instead of using string literal comparison
​https://bugs.webkit.org/show_bug.cgi?id=211011

Reviewed by Keith Miller.

Use strcmp for string literal comparison to expect that this is fully handled by compiler and converted into constant at compile time.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

12:24 AM Changeset in webkit [260692] by mark.lam@apple.com

• 3 edits
  2 adds in trunk

Suppress ASan on DFG::clobberize() to work around an ASan bug.
​https://bugs.webkit.org/show_bug.cgi?id=211012
<rdar://problem/62275430>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

ASan was incorrectly thinking that we're accessing invalid stack memory when we're not.

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

LayoutTests:

Test is courtesy of Fabien Duchene and Pinki Gyanchandani.

• js/suppress-asan-on-clobberize-to-workaround-asan-bug-expected.txt: Added.
• js/suppress-asan-on-clobberize-to-workaround-asan-bug.html: Added.

Apr 24, 2020:

10:04 PM Changeset in webkit [260691] by Diego Pino Garcia

• 2 edits in trunk/Source/WebKit

[WPE][Debug] Unreviewed, fix build after r260063
​https://bugs.webkit.org/show_bug.cgi?id=211009

r260063 removed include of WebProcess.h in WebSocketProvider.cpp,
which broke unified builds in WPE Debug.

• WebProcess/Network/WebSocketProvider.cpp:

9:58 PM Changeset in webkit [260690] by Alexey Shvayka

• 90 edits
  1 move
  43 adds
  1 delete in trunk

Fix WASM Error classes and re-sync wpt/wasm/jsapi from upstream
​https://bugs.webkit.org/show_bug.cgi?id=210980

Reviewed by Keith Miller.

JSTests:

• wasm/modules/js-wasm-cycle.js:
• wasm/modules/wasm-wasm-cycle.js:
• wasm/stress/too-many-locals.js:

LayoutTests/imported/w3c:

web-platform-tests revision: 028bd8650758

• web-platform-tests/wasm/jsapi/*: Updated.

Source/JavaScriptCore:

assert_throws_js() harness, which is extensively used by wpt/wasm/jsapi tests,
was recently updated to assert that passed constructors subclass Error in
spec-perfect way.

With this patch, WebAssembly errors have Error as Prototype of their constructors
and define correct "name" and "message" properties on their prototypes, aligning JSC
with the spec [1], V8 and SpiderMonkey.

[1]: ​https://webassembly.github.io/spec/js-api/#error-objects

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• wasm/js/WebAssemblyCompileErrorPrototype.cpp:

(JSC::WebAssemblyCompileErrorPrototype::finishCreation):

• wasm/js/WebAssemblyLinkErrorPrototype.cpp:

(JSC::WebAssemblyLinkErrorPrototype::finishCreation):

• wasm/js/WebAssemblyRuntimeErrorPrototype.cpp:

(JSC::WebAssemblyRuntimeErrorPrototype::finishCreation):

6:32 PM Changeset in webkit [260689] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

WebPasteboardProxy::getPasteboardStringsForType() and WebPasteboardProxy::readURLFromPasteboard() should check return value of SharedMemory::createHandle()
<​https://webkit.org/b/211002>

Reviewed by Wenson Hsieh.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::getPasteboardBufferForType):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):

• Check result of SharedMemory::createHandle() and return early on failure.

5:52 PM Changeset in webkit [260688] by Alan Coon

• 17 edits in branches/safari-610.1.11-branch

Cherry-pick r260486. rdar://problem/62349885

Fix MACCATALYST build failures
​https://bugs.webkit.org/show_bug.cgi?id=210815

Reviewed by Tim Horton.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, no functional change.

• Configurations/FeatureDefines.xcconfig:
• platform/ios/WebVideoFullscreenControllerAVKit.mm:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _isShowingVideoPictureInPicture]): (-[WKWebView _mayAutomaticallyShowVideoPictureInPicture]):
• UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::applicationDidBecomeActive):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/PlatformEnable.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [260687] by Alan Coon

• 22 edits in branches/safari-610.1.11-branch

Cherry-pick r260412. rdar://problem/62349885

Fix build failures when video fullscreen and picture-in-picture is disabled
​https://bugs.webkit.org/show_bug.cgi?id=210777

Reviewed by Eric Carlson.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Wrap video fullscreen and picture-in-picture related code with "#if ENABLE(VIDEO_PRESENTATION_MODE)".

• Configurations/FeatureDefines.xcconfig:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):
• platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
• platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm: (WebCore::VideoLayerManagerObjC::setVideoLayer): (WebCore::VideoLayerManagerObjC::requiresTextTrackRepresentation const): (WebCore::VideoLayerManagerObjC::syncTextTrackBounds): (WebCore::VideoLayerManagerObjC::setTextTrackRepresentation):

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Wrap video fullscreen and picture-in-picture related code with "#if ENABLE(VIDEO_PRESENTATION_MODE)".

• Configurations/FeatureDefines.xcconfig:
• GPUProcess/media/RemoteMediaPlayerProxy.cpp: (WebKit::RemoteMediaPlayerProxy::setVideoFullscreenGravity): (WebKit::RemoteMediaPlayerProxy::updateVideoFullscreenInlineImage): (WebKit::RemoteMediaPlayerProxy::setVideoFullscreenMode): (WebKit::RemoteMediaPlayerProxy::videoFullscreenStandbyChanged): (WebKit::RemoteMediaPlayerProxy::setBufferingPolicy):
• GPUProcess/media/RemoteMediaPlayerProxy.h:
• GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
• GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm: (WebKit::RemoteMediaPlayerProxy::prepareForPlayback):
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::prepareForPlayback):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/PlatformEnable.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [260686] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.1.11-branch

Cherry-pick r260450. rdar://problem/62350884

[Async overflow scroll] Overflow that's hidden on one axis is scrollable on that axis
​https://bugs.webkit.org/show_bug.cgi?id=210771
<rdar://problem/62080331>

Reviewed by Tim Horton.

Source/WebCore:

eventCanScrollContents() should check the presence of enabled scrollbars, like
ScrollAnimator::handleWheelEvent() does.

Test: fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html

• page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::eventCanScrollContents const):

LayoutTests:

• fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis-expected.txt: Added.
• fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:52 PM Changeset in webkit [260685] by Alan Coon

• 2 edits in branches/safari-610.1.11-branch/Source/WebKit

Cherry-pick r260390. rdar://problem/62351354

When SpeculativeLoadManager is destroyed, properly clean up its PendingFrameLoads
​https://bugs.webkit.org/show_bug.cgi?id=210759
<rdar://problem/62056856>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-20
Reviewed by Darin Adler.

Recent work on the resourceLoadStatistics layout tests increased the amount we swap out the WebsiteDataStore.
When this happens, the NetworkSession is eventually destroyed in the NetworkProcess, sometimes when running the next test.
An assertion was firing in the PendingFrameLoad destructor because it hadn't been marked as complete when it was destroyed.
Rather than remove the assertion, when we destroy the SpeculativeLoadManager (which only happens when a WebsiteDataStore
is destroyed) during a speculative pending frame load, just mark the pending frame load as complete because it is being cancelled.
Marking the pending frame load as complete can tell the SpeculativeLoadManager to mutate m_pendingFrameLoads, which we don't want
to do while iterating, so copy the RefPtrs into a Vector first then iterate that to get them all.

This fixes an assertion that was sometimes hit in http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-prevalent-subresource-redirects-database.html
but only after running other tests that had initiated speculative pending frame loads. This was ostensibly started by r260322 but is quite unrelated.

• NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp: (WebKit::NetworkCache::SpeculativeLoadManager::~SpeculativeLoadManager):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:51 PM Changeset in webkit [260684] by Chris Dumez

• 11 edits in trunk/Source

[iOS] Unable to sign up on twitter.com
​https://bugs.webkit.org/show_bug.cgi?id=211003
<rdar://problem/58804852>

Reviewed by Darin Adler.

Source/WebCore:

This is similar to the bug we had on nytimes.com and that was fixed in
r258767. However, instead of a 'resize' event, it is a 'change' event
on a MediaQueryList that is getting twitter.com in a bad state.

The issue is that when we home out of Safari, SpringBoard takes does
a snapshot sequence at various sizes / orientations and this causes
many JS events to get fired (e.g. 'resize', 'orientationchange',
'change', ...), which can get some sites in a bad state. To address
the issue, we now prevent firing of ALL JS events during the
SpringBoard snapshot, instead of merely preventing the 'resize' ones.

• dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):

• page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

• page/Page.h:

(WebCore::Page::shouldFireEvents const):
(WebCore::Page::setShouldFireEvents):
(WebCore::Page::shouldFireResizeEvents const): Deleted.
(WebCore::Page::setShouldFireResizeEvents): Deleted.

Source/WebKit:

• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKApplicationStateTrackingView.mm:

(-[WKApplicationStateTrackingView _willBeginSnapshotSequence]):
(-[WKApplicationStateTrackingView _didCompleteSnapshotSequence]):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setShouldFireEvents):
(WebKit::WebPage::setShouldFireResizeEvents): Deleted.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

5:34 PM Changeset in webkit [260683] by sbarati@apple.com

• 19 edits
  1 add in trunk

Return BigInt32 whenever we can
​https://bugs.webkit.org/show_bug.cgi?id=210922

Reviewed by Yusuke Suzuki.

JSTests:

• microbenchmarks/sunspider-sha1-big-int.js: Added.

(hex_sha1):
(b64_sha1):
(str_sha1):
(hex_hmac_sha1):
(b64_hmac_sha1):
(str_hmac_sha1):
(bigIntToInt32):
(sha1_vm_test):
(core_sha1):
(sha1_ft):
(sha1_kt):
(core_hmac_sha1):
(safe_add):
(rol):
(str2binb):
(binb2hex):
(binb2b64):
(run):

Source/JavaScriptCore:

This patch makes it so our runtime functions for big int math on heap
big ints converts the result to a big int 32 when possible.

The inspiration for this patch came from converting SunSpider's sha1 benchmark to
using big ints. I found that that original implementation of big int 32
was a ~35% slowdown here. This patch speeds it up by 86% from ToT, and
36% faster than before big int 32 was introduced.

To make this sound in the DFG/FTL, we are currently reporting that all
HeapBigInt math ops return SpecBigInt, instead of SpecHeapBigInt.
However, we want to do better in a follow up. We need some kind of profiling
system where we determine if we should speculate if the result is big int
32, a heap big int, or both:
​https://bugs.webkit.org/show_bug.cgi?id=210982

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueBitNot):
(JSC::DFG::SpeculativeJIT::compileValueBitwiseOp):
(JSC::DFG::SpeculativeJIT::compileValueLShiftOp):
(JSC::DFG::SpeculativeJIT::compileValueBitRShift):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileValueSub):
(JSC::DFG::SpeculativeJIT::compileValueMul):
(JSC::DFG::SpeculativeJIT::compileValueDiv):
(JSC::DFG::SpeculativeJIT::compileValueMod):
(JSC::DFG::SpeculativeJIT::compileValuePow):

• jit/JITOperations.cpp:
• jsc.cpp:

(functionCreateBigInt32):

• runtime/BigIntConstructor.cpp:

(JSC::toBigInt):
(JSC::callBigIntConstructor):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::exponentiateHeap):
(JSC::JSBigInt::multiplyHeap):
(JSC::JSBigInt::divideHeap):
(JSC::JSBigInt::unaryMinusHeap):
(JSC::JSBigInt::remainderHeap):
(JSC::JSBigInt::incHeap):
(JSC::JSBigInt::decHeap):
(JSC::JSBigInt::addHeap):
(JSC::JSBigInt::subHeap):
(JSC::JSBigInt::bitwiseAndHeap):
(JSC::JSBigInt::bitwiseOrHeap):
(JSC::JSBigInt::bitwiseXorHeap):
(JSC::JSBigInt::leftShiftHeap):
(JSC::JSBigInt::signedRightShiftHeap):
(JSC::JSBigInt::bitwiseNotHeap):
(JSC::JSBigInt::absoluteAdd):
(JSC::JSBigInt::absoluteSub):
(JSC::JSBigInt::parseInt):
(JSC::JSBigInt::exponentiate): Deleted.
(JSC::JSBigInt::multiply): Deleted.
(JSC::JSBigInt::divide): Deleted.
(JSC::JSBigInt::unaryMinus): Deleted.
(JSC::JSBigInt::remainder): Deleted.
(JSC::JSBigInt::inc): Deleted.
(JSC::JSBigInt::dec): Deleted.
(JSC::JSBigInt::add): Deleted.
(JSC::JSBigInt::sub): Deleted.
(JSC::JSBigInt::bitwiseAnd): Deleted.
(JSC::JSBigInt::bitwiseOr): Deleted.
(JSC::JSBigInt::bitwiseXor): Deleted.
(JSC::JSBigInt::leftShift): Deleted.
(JSC::JSBigInt::signedRightShift): Deleted.
(JSC::JSBigInt::bitwiseNot): Deleted.

• runtime/JSBigInt.h:
• runtime/JSCJSValue.h:

(JSC::jsBigInt32):

• runtime/JSCJSValueInlines.h:

(JSC::JSValue::JSValue):

• runtime/Operations.cpp:

(JSC::jsAddSlowCase):

• runtime/Operations.h:

(JSC::jsSub):
(JSC::jsMul):
(JSC::jsDiv):
(JSC::jsInc):
(JSC::jsDec):
(JSC::jsBitwiseNot):
(JSC::shift):
(JSC::bitwiseBinaryOp):

Source/WebCore:

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readBigInt):

4:56 PM Changeset in webkit [260682] by ysuzuki@apple.com

• 5 edits in trunk/Source

[WTF] allThreads registration is racy with allThreads unregistration
​https://bugs.webkit.org/show_bug.cgi?id=210995
<rdar://problem/61609690>

Reviewed by Keith Miller.

Source/WebCore:

• page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformCollectCPUData):

Source/WTF:

There is a race between registering a thread to allThreads and unregistering a thread from allThreads.

1. Caller: A new thread is created, but not registering it to allThreads yet.
2. Thread: The thread is running.
3. Thread: The thread finishes its execution before the thread is registered into allThreads.
4. Thread: The thread unregisters itself from allThreads.
5. Caller: Registers the new thread to allThreads after it already finished its execution.
6. The thread is never removed from allThreads.

This patch adds m_didUnregisterFromAllThreads flag to Thread, and add the thread to allThreads only when this flag is false.

Covered by LayoutTests/inspector/cpu-profiler/threads.html.

• wtf/Threading.cpp:

(WTF::Thread::create):
(WTF::Thread::didExit):

• wtf/Threading.h:

(WTF::Thread::Thread):

4:53 PM Changeset in webkit [260681] by jonlee@apple.com

• 2 edits in trunk/PerformanceTests

MotionMark: add link to bug in about page

Unreviewed.

• MotionMark/about.html:

4:35 PM Changeset in webkit [260680] by commit-queue@webkit.org

• 6 edits in trunk

[GTK][WPE][JSCOnly] compile error when -DWTF_CPU_ARM64_CORTEXA53=ON set for arm64
​https://bugs.webkit.org/show_bug.cgi?id=197192

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-04-24
Reviewed by Yusuke Suzuki.

.:

• Source/cmake/OptionsCommon.cmake:

Source/JavaScriptCore:

This workaround is supposed to fix WebKit on old Cortex A53 CPUs, but it has been broken
since 2018, and people would like to use WebKit on modern Cortex A53. If anyone using WebKit
on the original hardware wants to fix and reimplement the workaround, feel free.

• assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::adrp):
(JSC::ARM64Assembler::madd):
(JSC::ARM64Assembler::msub):
(JSC::ARM64Assembler::smaddl):
(JSC::ARM64Assembler::smsubl):
(JSC::ARM64Assembler::umaddl):
(JSC::ARM64Assembler::umsubl):
(JSC::ARM64Assembler::nopCortexA53Fix835769): Deleted.
(JSC::ARM64Assembler::nopCortexA53Fix843419): Deleted.

• offlineasm/arm64.rb:
• offlineasm/instructions.rb:

4:32 PM Changeset in webkit [260679] by commit-queue@webkit.org

• 5 edits in trunk

REGRESSION(260485) Payment requests don't do anything
​https://bugs.webkit.org/show_bug.cgi?id=210997
Source/WTF:

<rdar://problem/62275343>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-24
Reviewed by Darin Adler.

We were giving the PKPaymentRequest an NSArray<NSString *> instead of NSArray<NSURL *>.
This was a problem with all uses of createNSArray with Vector<URL>.
Now it's fixed with a test.

• wtf/URL.h:
• wtf/cocoa/URLCocoa.mm:

(WTF::makeNSArrayElement):
(WTF::makeVectorElement):

Tools:

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-24
Reviewed by Darin Adler.

• TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:

(TestWebKitAPI::TEST):

4:18 PM Changeset in webkit [260678] by Wenson Hsieh

• 4 edits in trunk

Make some more adjustments to TextManipulationController's paragraph boundary heuristic
​https://bugs.webkit.org/show_bug.cgi?id=210993
<rdar://problem/61571299>

Reviewed by Tim Horton.

Source/WebCore:

Adjust the heuristic added in r260583 to account for a few more common scenarios where we currently consider
text as a part of the same paragraph. This can lead to many issues during text manipulation where text is moved
between these elements, when it should not be.

The new scenarios include block and inline-block links, as well as button elements.

Test: TextManipulation.StartTextManipulationTreatsInlineBlockLinksAndButtonsAsParagraphs

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::observeParagraphs):

Additionally rename "paragraph boundary element" to "item boundary element", to avoid colliding with the
existing notion of paragraph boundaries in editing code.

Tools:

Add a new API test with buttons and links styled with display: inline-block;. Additionally, rebaseline an
existing API test that exercises inline-block list items.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

3:49 PM Changeset in webkit [260677] by ddkilzer@apple.com

• 1 edit
  1 delete in trunk/LayoutTests/imported/w3c

REGRESSION (r223327): Remove merge conflict file

• web-platform-tests/webrtc/simplecall.html.orig: Remove.

3:41 PM Changeset in webkit [260676] by Megan Gardner

• 5 edits in trunk/Source

Make LEGACY_PDF_SUPPORT feature flag.
​https://bugs.webkit.org/show_bug.cgi?id=210868
<rdar://problem/62199847>

Reviewed by Tim Horton.

Source/WebKitLegacy/mac:

• WebView/WebFrameView.mm:

(+[WebFrameView _viewTypesAllowImageTypeOmission:]):

• WebView/WebView.mm:

Source/WTF:

• wtf/PlatformHave.h:

3:29 PM Changeset in webkit [260675] by Chris Dumez

• 2 edits in trunk/Tools

[iOS] Always run WKTR's WKWebViews at foreground priority
​https://bugs.webkit.org/show_bug.cgi?id=210991

Reviewed by Keith Miller.

Always run WKTR's WKWebViews at foreground priority. This makes sure that they don't suspend and
run at foreground priority on iOS, even if those views are not visible on screen.
This is an issue to address flakiness on the bots.

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):

2:53 PM Changeset in webkit [260674] by ysuzuki@apple.com

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Fix DataFormatJSBigInt32 missing part
​https://bugs.webkit.org/show_bug.cgi?id=210986

Reviewed by Mark Lam.

Add missing part of DataFormatJSBigInt32 implementation.

• bytecode/DataFormat.h:

(JSC::dataFormatToString):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):

2:51 PM Changeset in webkit [260673] by Alan Coon

• 8 edits in branches/safari-610.1.11-branch/Source

Versioning.

2:45 PM Changeset in webkit [260672] by chris.reid@sony.com

• 14 edits
  3 adds in trunk

[Win] Bundle Inspector Resources in Release builds
​https://bugs.webkit.org/show_bug.cgi?id=210942

Reviewed by Fujii Hironori.

.:

Add ENABLE_WEBINSPECTORUI so the resource copy can be disabled
on platforms without inspector frontends.

• CMakeLists.txt:
• Source/CMakeLists.txt:
• Source/PlatformWin.cmake:
• Source/cmake/OptionsJSCOnly.cmake:
• Source/cmake/OptionsPlayStation.cmake:

Source/WebCore:

• CMakeLists.txt:

Source/WebInspectorUI:

Add CMake files for copying inspector resources

• CMakeLists.txt: Added.
• PlatformGTK.cmake: Added.
• PlatformWin.cmake: Added.

Source/WebKit:

Move CMake logic for the inspector resource copy script to
Source/WebInspectorUI so it can be shared with Win and other platforms.

• InspectorGResources.cmake:
• PlatformWPE.cmake:
• PlatformWin.cmake:

2:42 PM Changeset in webkit [260671] by graouts@webkit.org

• 19 edits in trunk

[Web Animations] Ensure calling Web Animations APIs override future CSS Animations style properties
​https://bugs.webkit.org/show_bug.cgi?id=210988

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark all WPT tests related to Web Animations APIs overrides for CSS Animations as PASS, save for one
failing assertion which is caused by AnimationTimeline::updateCSSAnimations() not updating the animation
when the underlying @keyframes rule changed. This is due to Animation::animationsMatch() not checking on
the actual keyframes, tracked by webkit.org/b/210989.

• web-platform-tests/css/css-animations/AnimationEffect-updateTiming.tentative-expected.txt:
• web-platform-tests/css/css-animations/CSSAnimation-effect.tentative-expected.txt:
• web-platform-tests/css/css-animations/CSSAnimation-pausing.tentative-expected.txt:
• web-platform-tests/css/css-animations/KeyframeEffect-setKeyframes.tentative-expected.txt:

Source/WebCore:

The CSS Animations Level 2 spec specifies how the Web Animations APIs and the CSS Animations style
properties should interact in ​https://drafts.csswg.org/css-animations-2/#animations. This patch
implements the specified behavior and this is reflected by progress on the relevant WPT tests.

The gist of this change is that once a Web Animations API is called on an animation created using
CSS Animations, any changes made to related CSS Animations style properties on the target element
will be ignored so that the overrides applied via the Web Animations API remain in effect.

For instance, calling pause() or play() in a way that changes the playback state of the CSS Animation
will mean that future changes to the CSS animation-play-state property are ignored.

To do this we make more IDL properties and methods use dedicated methods to distinguish between the
bindings entry-point and internal usage of the same methods to integrate the behavior only when the
API itself is being used.

• animation/AnimationEffect.cpp:

(WebCore::AnimationEffect::getBindingsTiming const): Ensure we flush styles when animation.effect.getTiming()
is called.
(WebCore::AnimationEffect::getBindingsComputedTiming const): Ensure we flush styles when
animation.effect.getComputedTiming() is called.
(WebCore::AnimationEffect::bindingsUpdateTiming): Notify the associated CSSAnimation object, if any, when
animation.effect.updateTiming() is called such that the CSSAnimation may apply the relevant overrides.

• animation/AnimationEffect.h:
• animation/AnimationEffect.idl:
• animation/CSSAnimation.cpp:

(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation): Only apply new values of CSS Animations style
properties if there are no overrides for them resulting from calling related Web Animations APIs.
(WebCore::CSSAnimation::bindingsPlay): Mark animation-play-state as overridden if play() is called.
(WebCore::CSSAnimation::bindingsPause): Mark animation-play-state as overridden if pause() is called.
(WebCore::CSSAnimation::setBindingsEffect): Mark all animation style properties, except for animation-name
and animation-play-state as overridden if animation.effect is set.
(WebCore::CSSAnimation::setBindingsStartTime): Mark animation-play-state as overridden if animation.startTime
is set.
(WebCore::CSSAnimation::bindingsReverse): Mark animation-play-state as overridden if reverse() is called.
(WebCore::CSSAnimation::effectTimingWasUpdatedUsingBindings): Mark each CSS property associated with a key
found on the timing object passed to animation.effect.updateTiming() as overridden.
(WebCore::CSSAnimation::effectKeyframesWereSetUsingBindings): Mark animation-timing-function as overridden
if animation.effect.setKeyframes() is called.

• animation/CSSAnimation.h:
• animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::bindingsStartTime const):
(WebCore::DeclarativeAnimation::setBindingsStartTime):
(WebCore::DeclarativeAnimation::startTime const): Deleted.
(WebCore::DeclarativeAnimation::setStartTime): Deleted.

• animation/DeclarativeAnimation.h:
• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::getBindingsKeyframes): Ensure we flush styles when animation.effect.getKeyframes()
is called.
(WebCore::KeyframeEffect::getKeyframes): Only use the CSS-originated animation path if we don't have JS-originated
keyframes.
(WebCore::KeyframeEffect::setBindingsKeyframes): Notify the associated CSSAnimation object, if any, when
animation.effect.setKeyframes() is called such that the CSSAnimation may apply the relevant overrides.
(WebCore::KeyframeEffect::processKeyframes): Correctly return early if part of the processing yields an exception.

• animation/KeyframeEffect.h:
• animation/KeyframeEffect.idl:
• animation/WebAnimation.cpp:

(WebCore::WebAnimation::setBindingsEffect):
(WebCore::WebAnimation::setBindingsStartTime):
(WebCore::WebAnimation::bindingsReverse):

• animation/WebAnimation.h:

(WebCore::WebAnimation::bindingsEffect const):
(WebCore::WebAnimation::bindingsStartTime const):

• animation/WebAnimation.idl:

2:41 PM Changeset in webkit [260670] by Alexey Shvayka

• 15 edits
  24 adds
  1 delete in trunk/LayoutTests/imported/w3c

Re-sync wpt/WebIDL/ecmascript-binding and wpt/custom-elements/htmlconstructor from upstream
​https://bugs.webkit.org/show_bug.cgi?id=210984

Reviewed by Darin Adler.

web-platform-tests revision: 39e9c51041a1

• web-platform-tests/WebIDL/ecmascript-binding/*: Updated.
• web-platform-tests/custom-elements/htmlconstructor/*: Updated.

2:11 PM Changeset in webkit [260669] by Chris Dumez

• 2 edits in trunk/Source/WebCore

ASSERTION FAILED: m_wrapper under HTMLMediaElement::setIsPlayingToWirelessTarget
​https://bugs.webkit.org/show_bug.cgi?id=210983
<rdar://problem/61611994>

Reviewed by Eric Carlson.

The issue was that we were trying to fire a JS event as a result of ActiveDOMObject::stop()
getting called, which is not allowed. To address the issue, we avoid firing the event if
the context is already stopped.

No new tests, already covered by:
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setIsPlayingToWirelessTarget):

2:08 PM Changeset in webkit [260668] by Kate Cheney

• 25 edits
  12 adds in trunk

Removing website data for a domain should delete corresponding ITP entry
​https://bugs.webkit.org/show_bug.cgi?id=210864
<rdar://problem/59473193>

Reviewed by John Wilander.

Source/WebKit:

Tests: http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-link-decoration-database.html

http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-link-decoration.html
http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-mixed-statistics-entries-database.html
http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-mixed-statistics-entries.html
http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-third-party-script-loads-database.html
http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-third-party-script-loads.html

In the database store: deletes domain from the ObservedDomains table
when website data is deleted for that domain. This deletes every
instance of the domainID in the database due to cascading deletions.

In the memory store: deletes every instance of the domain in the
statistics map, which will update the plist.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::removeDataForDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::domainIDExistsInDatabase):
Needed a new function to check for the existence of domainID in any
table. Existing queries rely on the ObservedDomains entry, which means
testing using those could result in a false positive if the domainID
was deleted from ObservedDomains but is floating around in another
table.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
• NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::removeDataForDomain):

• NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
• NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::domainIDExistsInDatabase):
(WebKit::WebResourceLoadStatisticsStore::removeDataForDomain):

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::domainIDExistsInDatabase):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
Pass RegistrableDomains vector to deleteWebsiteDataForOrigins,
captured based on the WebsiteData display name.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreRemoveITPDataForDomain):
(WKWebsiteDataStoreDoesStatisticsDomainIDExistInDatabase):

• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcessProxy::domainIDExistsInDatabase):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::domainIDExistsInDatabase):

• UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

Created 2 new APIs for testing. One to mimic clearing website data
for a domain, and one to check if the domain exists in the database
after a deletion was requested.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::doesStatisticsDomainIDExistInDatabase):
(WTR::TestRunner::domainIDExistsInDatabase): Deleted.

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::doesStatisticsDomainIDExistInDatabase):
(WTR::TestController::domainIDExistsInDatabase): Deleted.

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Inserts values into the ITP database then tests removing the domain's
website data will remove all instances of that domain in the ITP
database.

Database store expectations will reflect the result of the new
domainIDExistsInDatabase function. Memory store tests will use the
dump output which should not include the deleted information.

• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-link-decoration-database-expected.txt: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-link-decoration-database.html: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-link-decoration-expected.txt: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-link-decoration.html: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-mixed-statistics-entries-database-expected.txt: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-mixed-statistics-entries-database.html: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-mixed-statistics-entries-expected.txt: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-mixed-statistics-entries.html: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-third-party-script-loads-database-expected.txt: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-third-party-script-loads-database.html: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-third-party-script-loads-expected.txt: Added.
• http/tests/resourceLoadStatistics/remove-website-data-for-origin-deletes-third-party-script-loads.html: Added.

2:02 PM Changeset in webkit [260667] by ddkilzer@apple.com

• 7 edits
  1 copy in trunk/Source/WebKit

Use CocoaImage platform abstraction for NSImage/UIImage
<​https://webkit.org/b/210974>

Reviewed by Darin Adler.

• Platform/cocoa/CocoaImage.h: Add.
• Define CocoaImage here for cross-platform use. Don't use OBJC_CLASS() here because this is an Objective-C header.
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):

• Combine separate platform-specific methods into one method.
• UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:
• Combine separate platform-specific instance variables into one instance variable.

(-[_WKActivatedElementInfo image]):

• Combine separate methods into one platform-specific method.
• UIProcess/QuickLookThumbnailLoader.h:
• Move cross-platform definition to CocoaImge.h.
• UIProcess/QuickLookThumbnailLoader.mm:
• Drive-by fix of soft-linking header include order.
• WebKit.xcodeproj/project.pbxproj:
• Add CocoaImage.h to the project.
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(-[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]):
(-[WKWebProcessPlugInNodeHandle renderedImageWithOptions:width:]):

• Combine separate platform-specific methods into one method.

1:57 PM Changeset in webkit [260666] by ddkilzer@apple.com

• 4 edits in trunk/Source/WebKit

IPC::Decoder should use create() pattern
<​https://webkit.org/b/210949>
<rdar://problem/62144409>

Reviewed by Geoffrey Garen.

• Platform/IPC/Decoder.cpp:

(IPC::Decoder::create): Add implementation. Returns nullptr if
Decoder constructor returns an invalid object.
(IPC::Decoder::Decoder): Mark invalid if m_buffer is not 64-bit
aligned.
(IPC::Decoder::unwrapForTesting): Switch to Decoder::create().

• Platform/IPC/Decoder.h:

(IPC::Decoder::create): Add declaration.
(IPC::Decoder::Decoder): Make explicit. (Can't be made private
since we use std::unique_ptr<Decoder>.)

• Platform/IPC/cocoa/ConnectionCocoa.mm:

(IPC::createMessageDecoder): Switch to Decoder::create().

1:33 PM Changeset in webkit [260665] by Russell Epstein

• 1 copy in tags/Safari-609.2.9.0.2

Tag Safari-609.2.9.0.2.

1:11 PM Changeset in webkit [260664] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix in Windows
​https://bugs.webkit.org/show_bug.cgi?id=210892

Windows MSVC does not have proper understanding of IGNORE_RETURN_TYPE_WARNINGS_BEGIN.

• runtime/JSBigInt.h:

(JSC::invertBigIntCompareResult):

1:05 PM Changeset in webkit [260663] by timothy_horton@apple.com

• 5 edits in trunk/Source

iPad: "Pocket City" interaction does not work with trackpad
​https://bugs.webkit.org/show_bug.cgi?id=210985
<rdar://problem/62273077>

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isPocketCity):

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView shouldUseMouseGestureRecognizer]):
Add another app to the list who fall back to touch event synthesis until rebuilt.

1:04 PM Changeset in webkit [260662] by graouts@webkit.org

• 37 edits
  18 adds
  1 delete in trunk

Update the css/css-animations WPT tests
​https://bugs.webkit.org/show_bug.cgi?id=210964

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• resources/resource-files.json:
• web-platform-tests/css/css-animations/AnimationEffect-updateTiming.tentative-expected.txt: Added.
• web-platform-tests/css/css-animations/AnimationEffect-updateTiming.tentative.html: Added.
• web-platform-tests/css/css-animations/CSSAnimation-compositeOrder.tentative-expected.txt:
• web-platform-tests/css/css-animations/CSSAnimation-compositeOrder.tentative.html:
• web-platform-tests/css/css-animations/CSSAnimation-effect.tentative-expected.txt:
• web-platform-tests/css/css-animations/CSSAnimation-effect.tentative.html:
• web-platform-tests/css/css-animations/CSSAnimation-finished.tentative.html:
• web-platform-tests/css/css-animations/CSSAnimation-pausing.tentative-expected.txt:
• web-platform-tests/css/css-animations/CSSAnimation-pausing.tentative.html:
• web-platform-tests/css/css-animations/CSSAnimation-ready.tentative.html:
• web-platform-tests/css/css-animations/Document-getAnimations.tentative-expected.txt:
• web-platform-tests/css/css-animations/Document-getAnimations.tentative.html:
• web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt:
• web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html:
• web-platform-tests/css/css-animations/KeyframeEffect-setKeyframes.tentative-expected.txt: Added.
• web-platform-tests/css/css-animations/KeyframeEffect-setKeyframes.tentative.html: Added.
• web-platform-tests/css/css-animations/animation-base-response-001-expected.txt: Added.
• web-platform-tests/css/css-animations/animation-base-response-001.html: Added.
• web-platform-tests/css/css-animations/animation-base-response-002-expected.txt: Added.
• web-platform-tests/css/css-animations/animation-base-response-002.html: Added.
• web-platform-tests/css/css-animations/animation-base-response-003-expected.txt: Added.
• web-platform-tests/css/css-animations/animation-base-response-003.html: Added.
• web-platform-tests/css/css-animations/animation-base-response-004-expected.txt: Added.
• web-platform-tests/css/css-animations/animation-base-response-004.html: Added.
• web-platform-tests/css/css-animations/animation-important-001-expected.txt: Added.
• web-platform-tests/css/css-animations/animation-important-001.html: Added.
• web-platform-tests/css/css-animations/animation-important-002-expected.html: Added.
• web-platform-tests/css/css-animations/animation-important-002.html: Added.
• web-platform-tests/css/css-animations/event-dispatch.tentative.html:
• web-platform-tests/css/css-animations/event-order.tentative-expected.txt:
• web-platform-tests/css/css-animations/event-order.tentative.html:
• web-platform-tests/css/css-animations/historical.html:
• web-platform-tests/css/css-animations/keyframes-remove-documentElement-crash-expected.txt: Removed.
• web-platform-tests/css/css-animations/support/testcommon.js:

(assert_frames_equal):
(assert_frame_lists_equal):

• web-platform-tests/css/css-animations/w3c-import.log:

Source/WebKitLegacy/mac:

Expose the CSSCustomPropertiesAndValues experimental feature such that it may be set in DumpRenderTree.

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(-[WebPreferences CSSCustomPropertiesAndValuesEnabled]):
(-[WebPreferences setCSSCustomPropertiesAndValuesEnabled:]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

Source/WebKitLegacy/win:

Expose the CSSCustomPropertiesAndValues experimental feature such that it may be set in DumpRenderTree.

• Interfaces/IWebPreferencesPrivate.idl:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

• WebPreferences.h:
• WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

Turn on the CSSCustomPropertiesAndValues experimental feature which a new test relies on.

• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

• DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

LayoutTests:

• TestExpectations:
• platform/ios/imported/w3c/web-platform-tests/css/css-animations/animation-base-response-001-expected.txt: Added.

12:58 PM Changeset in webkit [260661] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ Mac wk2 ] http/tests/IndexedDB/storage-limit.https.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209189

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

12:19 PM Changeset in webkit [260660] by ysuzuki@apple.com

• 13 edits
  6 adds in trunk

[JSC] DFG compare should speculate BigInt well
​https://bugs.webkit.org/show_bug.cgi?id=210892

Reviewed by Saam Barati.

JSTests:

• stress/compare-bigint-with-number.js: Added.

(shouldBe):
(result):
(lessThan):
(lessThanEqual):
(greaterThan):
(greaterThanEqual):
(equal):

• stress/compare-bigint-with-string.js: Added.

(shouldBe):
(result):
(lessThan):
(lessThanEqual):
(greaterThan):
(greaterThanEqual):
(equal):

• stress/compare-bigint.js: Added.

(shouldBe):
(result):
(lessThan):
(lessThanEqual):
(greaterThan):
(greaterThanEqual):
(equal):

• stress/compare-bigint32.js: Added.

(shouldBe):
(result):
(lessThan):
(lessThanEqual):
(greaterThan):
(greaterThanEqual):
(equal):

• stress/compare-heap-bigint.js: Added.

(shouldBe):
(result):
(lessThan):
(lessThanEqual):
(greaterThan):
(greaterThanEqual):
(equal):

• stress/dfg-ai-fold-bigint.js: Added.

(shouldBe):
(allAreTrue):
(allAreFalse):
(lessThan):
(lessThanFalse):
(lessThanEqual):
(lessThanEqualFalse):
(greaterThan):
(greaterThanFalse):
(greaterThanEqual):
(greaterThanEqualFalse):
(equal):
(equalFalse):

Source/JavaScriptCore:

Compare operations in DFG does not support BigInt related speculations. As a result, DFG fixup phase emits DoubleRep for operands, and
causes OSR exit. This patch adds BigInt32, HeapBigInt, and AnyBigIntUse support to DFG compare operations to avoid OSR exits.
We also introduce JSBigInt::compareToInt32 to avoid allocating JSBigInt only for comparison, and optimize C++ runtime for JSBigInt comparison.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileValueSub):
(JSC::DFG::SpeculativeJIT::compileValueMul):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::genericJSValueNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare): Deleted.

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileBigInt32Compare):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareEq):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compare):
(JSC::FTL::DFG::LowerDFGToB3::genericJSValueCompare):
(JSC::FTL::DFG::LowerDFGToB3::nonSpeculativeCompare): Deleted.

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::unboxBigInt32):

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::compareToInt32):

• runtime/JSBigInt.h:

(JSC::swapBigIntCompareResult):

• runtime/Operations.h:

(JSC::compareBigInt):
(JSC::compareBigInt32ToOtherPrimitive):
(JSC::bigIntCompare):

11:42 AM Changeset in webkit [260659] by ddkilzer@apple.com

• 3 edits in trunk/Tools

check-webkit-style should recognize *Internal.h and *Private.h as primary headers
<​https://webkit.org/b/210979>

Reviewed by Darin Adler.

• Scripts/webkitpy/style/checkers/cpp.py:

(_classify_include): If a header has an "Internal.h" or a
"Private.h" suffix with the same base name as the source file,
consider it a primary header--the header that comes after
"config.h".

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_classify_include): Add tests.

11:23 AM Changeset in webkit [260658] by commit-queue@webkit.org

• 18 edits in trunk

SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
​https://bugs.webkit.org/show_bug.cgi?id=210533

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-24
Reviewed by Brady Eidson.

Source/WebKit:

• NetworkProcess/NetworkDataTask.h:

(WebKit::NetworkDataTaskClient::didNegotiateModernTLS):

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didNegotiateModernTLS):

• NetworkProcess/NetworkLoad.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::didNegotiateModernTLS):

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):

• UIProcess/API/APINavigationClient.h:

(API::NavigationClient::didNegotiateModernTLS):

• UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
• UIProcess/Cocoa/NavigationState.h:
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::didNegotiateModernTLS):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didNegotiateModernTLS):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(-[TLSNavigationDelegate waitForDidNegotiateModernTLS]):
(-[TLSNavigationDelegate _webView:didNegotiateModernTLS:]):
(TestWebKitAPI::TEST):

11:08 AM Changeset in webkit [260657] by BJ Burg

• 2 edits in trunk/Tools

webkitpy: update autoinstalled mozprocess dependency to 1.1.0 (adds python3 support)
​https://bugs.webkit.org/show_bug.cgi?id=210220
<rdar://problem/58881483>

Reviewed by Anders Carlsson.

• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_mozprocess):

10:58 AM Changeset in webkit [260656] by jonlee@apple.com

• 8 edits in trunk/PerformanceTests

MotionMark: ensure that timestamps are valid during warm up phase of tests
​https://bugs.webkit.org/show_bug.cgi?id=210640

Reviewed by Said Abou-Hallawa.

Ensure that Benchmark._benchmarkStartTimestamp is set during warm up phase.
Otherwise it is NaN, which makes the Benchmark.timestamp invalid, which is
used by tests like Multiply to drive the animation. When the warm up phase
completes, the start timestamp is reset.

Update minor version of benchmark with this bug fix, and include
version changelog in the about page.

For testing, add a parameter that allows for adjusting the length of the
warm up phase. It remains at its current default, 100 ms.

• MotionMark/about.html: Add section of version changelog. Includes links

to webkit.org blog posts.

• MotionMark/developer.html: Add parameter for setting warmup length.

Remove the Kalman filter parameters, since they should always be fixed.

• MotionMark/resources/runner/motionmark.css: Include styles to show

version log.

• MotionMark/resources/runner/motionmark.js: Factor out default options to

a property on window.benchmarkController. Include the default warmup length
of 100 ms.
(window.benchmarkController.startBenchmark): Refactor to use benchmarkDefaultParameters.

• MotionMark/resources/debug-runner/motionmark.js: Ditto.
• MotionMark/resources/strings.js: Update version number.
• MotionMark/tests/resources/main.js:

(_animateLoop): Set _benchmarkTimestamp during the warmup phase. Check the
warmup length. The _benchmarkTimestamp variable remains reset when the test
begins.

10:56 AM Changeset in webkit [260655] by commit-queue@webkit.org

• 6 edits in trunk

[OpenSSL] Implement WebCrypto APIs for HMAC
​https://bugs.webkit.org/show_bug.cgi?id=210902

Patch by Tomoki Imai <Tomoki Imai> on 2020-04-24
Reviewed by Don Olmstead.

Source/WebCore:

Support WebCrypto HMAC sign/verify with OpenSSL.
The design and some functions are inherited from the other ports.

• crypto/openssl/CryptoAlgorithmHMACOpenSSL.cpp:

(WebCore::HMACAlgorithm): Added. Helper function to map CryptoAlgorithmIdentifier to OpenSSL EVP_MD type.
(WebCore::calculateSignature): Added. Helper function to calculate the signature for sign/verify.
(WebCore::CryptoAlgorithmHMAC::platformSign): Implemented, mostly same as the other ports.
(WebCore::CryptoAlgorithmHMAC::platformVerify): Implemented, mostly same as the other ports.

• crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Added CryptoAlgorithmHMAC support.

• crypto/openssl/OpenSSLCryptoUniquePtr.h: Added specialized unique_ptrs for EVP_MD_CTX and EVP_PKEY.

(WebCore::OpenSSLCryptoPtrDeleter<EVP_MD_CTX>::operator() const):
(WebCore::OpenSSLCryptoPtrDeleter<EVP_PKEY>::operator() const):

LayoutTests:

Enabled WebCrypto LayoutTests for HMAC along with the implementation.

• platform/wincairo/TestExpectations:

10:53 AM Changeset in webkit [260654] by Alexey Shvayka

• 5 edits in trunk

Proxy.revocable should not have Construct slot
​https://bugs.webkit.org/show_bug.cgi?id=210959

Reviewed by Darin Adler.

JSTests:

• stress/proxy-revoke.js:
• test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This change removes proxyRevocableConstructorThrowError() since its presence is
observable when, for example, Proxy.revocable is a ProxyTarget itself [1].
Also removes unnecessary newTarget() check in constructProxyObject() and
2 extra ArgList instances.

This patch aligns JSC with the spec [2], V8 and SpiderMonkey.

[1]: ​https://tc39.es/ecma262/#sec-proxycreate (step 7.b)
[2]: ​https://tc39.es/ecma262/#sec-ecmascript-standard-built-in-objects

• runtime/ProxyConstructor.cpp:

(JSC::makeRevocableProxy):
(JSC::ProxyConstructor::finishCreation):
(JSC::constructProxyObject):
(JSC::proxyRevocableConstructorThrowError): Deleted.

10:50 AM Changeset in webkit [260653] by BJ Burg

• 9 edits
  2 adds in trunk/Source

Web Automation: timeout underneath Automation.evaluateJavaScriptFunction in Selenium test frame_switching_tests.py::testShouldNotBeAbleToDoAnythingTheFrameIsDeletedFromUnderUs[Safari]
​https://bugs.webkit.org/show_bug.cgi?id=210162
<rdar://problem/60561009>

Reviewed by Devin Rousso.

Source/WebCore:

• page/DOMWindow.h: Expose DOMWindow::{register, unregister}Observer.

Source/WebKit:

When an iframe is detached from the DOM, it is no longer exposed as a browsing context
and it's not possible to Evaluate JavaScript or perform other commands with it. This
patch adds frame lifecycle monitoring so that pending script evaluations are cancelled
with FrameNotFound as soon as the iframe is detached from the DOM. This change also avoids
running more commands with the frame if it's detached from its DOMWindow and ready to be GC'd.

• Sources.txt:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Automation/WebAutomationDOMWindowObserver.h: Added.
• WebProcess/Automation/WebAutomationDOMWindowObserver.cpp: Added.

(WebKit::WebAutomationDOMWindowObserver::WebAutomationDOMWindowObserver):
(WebKit::WebAutomationDOMWindowObserver::~WebAutomationDOMWindowObserver):
(WebKit::WebAutomationDOMWindowObserver::frame const):
(WebKit::WebAutomationDOMWindowObserver::willDestroyGlobalObjectInCachedFrame):
(WebKit::WebAutomationDOMWindowObserver::willDestroyGlobalObjectInFrame):
(WebKit::WebAutomationDOMWindowObserver::willDetachGlobalObjectFromFrame):
This class is a stripped-down copy of DOMWindowExtension, which is the only other
client of DOMWindow::Observer interface. When a frame is detached, destroyed, or
navigates (global object detached), then call the callback and unregister.

• WebProcess/Automation/WebAutomationSessionProxy.h:
• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::~WebAutomationSessionProxy):
(WebKit::WebAutomationSessionProxy::didClearWindowObjectForFrame):
(WebKit::WebAutomationSessionProxy::willDestroyGlobalObjectForFrame):
(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):
(WebKit::WebAutomationSessionProxy::ensureObserverForFrame): For non-main frames,
ensure we add a frame observer if we are about to evaluate JavaScript upon the frame.
This acts as a watchdog in case the frame becomes detached while waiting for pending
JS evaluations. When a frame is detached, the JS evaluation may or may not complete.

(WebKit::WebAutomationSessionProxy::selectOptionElement): Fix hilarious typo.

• WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.cpp:
• WebProcess/GPU/media/WebMediaStrategy.cpp:

(WebKit::WebMediaStrategy::clearNowPlayingInfo):
(WebKit::WebMediaStrategy::setNowPlayingInfo):
Adding a new file seems to have exposed a few missing includes and namespace qualifiers.
This is due to unified sources chunking.

10:25 AM Changeset in webkit [260652] by commit-queue@webkit.org

• 9 edits
  1 delete in trunk/Source/WebKit

Use sendWithAsyncReply for ShareSheet related messages
​https://bugs.webkit.org/show_bug.cgi?id=210828
<rdar://problem/61800730>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-24
Reviewed by Brent Fulgham.

• Platform/IPC/MessageSender.cpp:

We need to call addAsyncReplyHandler before sendMessage in case this is the first async message from this process.
Otherwise the reply from the first message is dropped sometimes.

• Shared/ShareSheetCallbackID.h: Removed.
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showShareSheet):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::showShareSheet):
(WebKit::nextShareSheetCallbackID): Deleted.
(WebKit::WebPage::didCompleteShareSheet): Deleted.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

10:20 AM Changeset in webkit [260651] by ysuzuki@apple.com

• 3 edits
  1 add in trunk

[JSC] DFG AI for some bitops + BigInt32 should be precise
​https://bugs.webkit.org/show_bug.cgi?id=210956

Reviewed by Keith Miller.

JSTests:

• stress/bigint-bitops.js: Added.

(shouldBe):
(test):

Source/JavaScriptCore:

Use SpecBigInt32 for ValueBitXor, ValueBitAnd, and ValueBitOr since they are always producing BigInt32 and they have inlined implementations in DFG / FTL.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

10:02 AM Changeset in webkit [260650] by commit-queue@webkit.org

• 12 edits
  1 add in trunk/Source

Call STDynamicActivityAttributionPublisher in the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=210772
<rdar://problem/62075201>

Patch by Youenn Fablet <​youenn@apple.com> and Luming Yin <​luming_yin@apple.com> on 2020-04-24
Reviewed by Geoffrey Garen.

Source/WebKit:

Call STDynamicActivityAttributionPublisher in WebProcess to make use of the newly added plist entry.
Use of a sandbox extension to protect this call.

• Configurations/WebKit.xcconfig:
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• Scripts/process-entitlements.sh:
• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:
• WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/InfoPlist.strings: Added.
• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

• wtf/PlatformHave.h:

9:58 AM Changeset in webkit [260649] by Jacob Uphoff

• 2 edits in trunk/LayoutTests

[ Mac wk2 ] tiled-drawing/simple-document-with-margin-tiles.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=207518

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:32 AM Changeset in webkit [260648] by pvollan@apple.com

• 2 edits in trunk

[Win] Fix AppleWin build
​https://bugs.webkit.org/show_bug.cgi?id=210971

Reviewed by Brent Fulgham.

PAL is built as a static library.

• Source/cmake/target/PAL.cmake:

9:22 AM Changeset in webkit [260647] by Alan Bujtas

• 6 edits
  2 adds in trunk

[LFC][TFC] Take first in-flow table-row baseline into account when computing cell baseline
​https://bugs.webkit.org/show_bug.cgi?id=210972

Reviewed by Antti Koivisto.

Source/WebCore:

Check if the cell has a nested table and use its first row as the baseline for the cell (unless there's an IFC before).

Test: fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutCell):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraVerticalSpace):

• layout/tableformatting/TableFormattingContext.h:
• layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):

• layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::Row::setBaselineOffset):
(WebCore::Layout::TableGrid::Row::baselineOffset const):

LayoutTests:

• fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table-expected.txt: Added.
• fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html: Added.

9:20 AM Changeset in webkit [260646] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Nullptr crash in objc_msgSend under WebCore::genericFamily
​https://bugs.webkit.org/show_bug.cgi?id=210911
<rdar://problem/61510208>

Reviewed by Geoffrey Garen.

Speculative fix.

• platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:

(WebCore::genericFamily):

Test that CTFontDescriptorCopyAttribute is really returning CFStringRef.
Also explicitly return String from lambda to clarify lifetimes.

9:11 AM Changeset in webkit [260645] by Adrian Perez de Castro

• 1 copy in releases/WPE WebKit/webkit-2.28.2

WPE WebKit 2.28.2

9:11 AM Changeset in webkit [260644] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.28

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.28.2 release

.:

• Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

• wpe/NEWS: Add release notes for 2.28.2.

8:03 AM Changeset in webkit [260643] by Simon Fraser

• 8 edits in trunk/Source

Move some post-renderingUpdate code into WebCore
​https://bugs.webkit.org/show_bug.cgi?id=210952

Reviewed by Antti Koivisto.

Factor some code called by the various DrawingArea subclasses into Page::finalizeRenderingUpdate(),
with some flags to control behavior that differs between drawing areas.

ScrollingCoordinator::commitTreeStateIfNeeded() is a no-op for RemoteScrollingCoordinator so
it's fine to always call it.

Source/WebCore:

• page/Page.cpp:

(WebCore::Page::passiveTouchEventListenerRectsForTesting):
(WebCore::Page::finalizeRenderingUpdate):

• page/Page.h:

Source/WebKit:

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updateRendering):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::finalizeRenderingUpdate):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateRendering):

7:57 AM Changeset in webkit [260642] by Chris Dumez

• 8 edits in trunk

[iOS] Stop using legacy BKSApplicationStateMonitor
​https://bugs.webkit.org/show_bug.cgi?id=210945

Reviewed by Tim Horton.

Source/WebKit:

Stop using legacy BKSApplicationStateMonitor and use RunningBoard API instead.

• Configurations/WebKit.xcconfig:

Stop linking against ApplicationServices when using iOS 14 SDK now that we are
fully transitioned to RunningBoard.

• Platform/spi/ios/RunningBoardServicesSPI.h:
• UIProcess/ApplicationStateTracker.h:
• UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):
(WebKit::isApplicationForeground):
(WebKit::ApplicationStateTracker::~ApplicationStateTracker):
(WebKit::isBackgroundState): Deleted.

• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isApplicationVisible):

WebKitLibraries:

• WebKitPrivateFrameworkStubs/iOS/13/RunningBoardServices.framework/RunningBoardServices.tbd:

7:22 AM Changeset in webkit [260641] by commit-queue@webkit.org

• 3 edits in trunk/Tools

[GTK][WPE] White-list more GStreamer environment variables in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=210854
<rdar://problem/62238305>

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-04-24
Reviewed by Carlos Alberto Lopez Perez.

Extra variables need to be white-listed when the webkitpy tooling
runs inside a gst-build environment, those variables are needed so
that uninstalled GStreamer plugins are correctly picked up.

Additionally we now correctly white-list the
WEBKIT_GST_USE_PLAYBIN3 env var. USE_PLAYBIN3 shouldn't be used
anymore.

• Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server):

• Scripts/webkitpy/port/wpe.py:

(WPEPort.setup_environ_for_server):

7:12 AM Changeset in webkit [260640] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK][WPE] Gardening, mark fast/css/resize-corner-tracking.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=210969

Unreviewed gardening.

Apparently the test is only failing in GTK and WPE test bots.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

5:14 AM WebKitGTK/2.28.x edited by clopez@igalia.com

(diff)

3:37 AM Changeset in webkit [260639] by commit-queue@webkit.org

• 4 edits in trunk/JSTests

Skip on ARM and MIPS stress/for-of-iterator-open* added at r260585
​https://bugs.webkit.org/show_bug.cgi?id=210961

Unreviewed Gardening.

Patch by Paulo Matos <Paulo Matos> on 2020-04-24

• stress/for-of-iterator-open-osr-at-inlined-return-non-object.js:
• stress/for-of-iterator-open-osr-at-iterator-set-local.js:
• stress/for-of-iterator-open-return-non-object.js:

3:35 AM Changeset in webkit [260638] by youenn@apple.com

• 1 edit
  2 deletes in trunk/LayoutTests

getDisplayMedia is not respecting aspect ratio with max constraints
​https://bugs.webkit.org/show_bug.cgi?id=210858
<rdar://problem/61405434>

Unreviewed.
Remove these tests as it is redundant with getDisplayMedia-max-constraints 1 2 and 3.

• fast/mediastream/getDisplayMedia-max-constraints-expected.txt: Removed.
• fast/mediastream/getDisplayMedia-max-constraints.html: Removed.

2:58 AM Changeset in webkit [260637] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.28.2

WebKitGTK 2.28.2

2:57 AM Changeset in webkit [260636] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.28

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.28.2 release

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.28.2.

2:39 AM WebKitGTK/2.28.x edited by Carlos Garcia Campos

(diff)

2:22 AM Changeset in webkit [260635] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[WPE] Gardening, expected to fail but passing
​https://bugs.webkit.org/show_bug.cgi?id=210960

Unreviewed gardening.

• platform/wpe/TestExpectations:

2:21 AM Changeset in webkit [260634] by Carlos Garcia Campos

• 3 edits
  1 add in releases/WebKitGTK/webkit-2.28

Merge r256766 - [Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
​https://bugs.webkit.org/show_bug.cgi?id=207849

Reviewed by Mark Lam.

JSTests:

• wasm/regress/regress-256665.js: Added.

(f):

Source/JavaScriptCore:

When generating the call IC, we should select the callee saves using BoundsChecking mode in order
to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
register when calling the Wasm LLInt through the call IC.

• wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::calleeSaves const):

2:21 AM Changeset in webkit [260633] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.28/JSTests

Merge r256698 - Unreviewed: fix broken tests added in r256665
​https://bugs.webkit.org/show_bug.cgi?id=207727

Our inline WAT doesn't seem to like named blocks/branch targets.

• wasm/regress/llint-callee-saves-with-fast-memory.js:
• wasm/regress/llint-callee-saves-without-fast-memory.js:

2:20 AM Changeset in webkit [260632] by Carlos Garcia Campos

• 9 edits
  2 adds in releases/WebKitGTK/webkit-2.28

Merge r256665 - [WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention.
​https://bugs.webkit.org/show_bug.cgi?id=207727

JSTests:

Reviewed by Mark Lam.

• wasm/regress/llint-callee-saves-with-fast-memory.js: Added.
• wasm/regress/llint-callee-saves-without-fast-memory.js: Added.

Source/JavaScriptCore:

Reviewed by Mark Lam.

The Wasm JIT has unusual calling conventions, which were further complicated by the addition
of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly
saving and restoring the callee save registers used for the memory base and size). Here's a summary
of the calling convention:

• When entering Wasm from JS, the wrapper must:
  • Preserve the base and size when entering LLInt regardless of the mode. (Prior to this patch we only preserved the base in Signaling mode)
  • Preserve the memory base in either mode, and the size for BoundsChecking.
• Both tiers must preserve every *other* register they use. e.g. the LLInt must preserve PB and wasmInstance, but must *not* preserve memoryBase and memorySize.
• Changes to memoryBase and memorySize are visible to the caller. This means that:
  • Intra-module calls can assume these registers are up-to-date even if the memory was resized. The only exception here is if the LLInt calls a signaling JIT, in which case the JIT will not update the size register, since it won't be using it.
  • Inter-module and JS calls require the caller to reload these registers. These calls may result in memory changes (e.g. the callee may call memory.grow).
  • A Signaling JIT caller must be aware that the LLInt may trash the size register, since it always bounds checks.

• llint/WebAssembly.asm:
• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::addCall):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addCall):

• wasm/WasmCallee.cpp:

(JSC::Wasm::LLIntCallee::calleeSaveRegisters):

• wasm/WasmCallingConvention.h:
• wasm/WasmLLIntPlan.cpp:

(JSC::Wasm::LLIntPlan::didCompleteCompilation):

• wasm/WasmMemoryInformation.cpp:

(JSC::Wasm::PinnedRegisterInfo::get):
(JSC::Wasm::getPinnedRegisters): Deleted.

2:20 AM Changeset in webkit [260631] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit

Merge r260570 - [GTK] Crash in cairo_surface_mark_dirty_rectangle() in accelerated compositing mode under X11
​https://bugs.webkit.org/show_bug.cgi?id=210636

Patch by John Frankish <​john.frankish@outlook.com> on 2020-04-23
Reviewed by Carlos Garcia Campos.

When cairo is configured to use xcb instead of xlib, it might use an image surface attached to the xlib one as
snapshot. In that case a flush is needed to detach that snapshot after we have drawn the surface in the
context.

• UIProcess/gtk/AcceleratedBackingStoreX11.cpp:

(WebKit::AcceleratedBackingStoreX11::paint): Call cairo_surface_flush() after drawing.

2:20 AM Changeset in webkit [260630] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore

Merge r260567 - [GTK] excessive wakeups/polling due to gdk_frame_clock_begin_updating
​https://bugs.webkit.org/show_bug.cgi?id=210561

Reviewed by Žan Doberšek.

The problem is that we are destroying the display refresh monitor from the frame clock update callback, and GTK
schedules another update from the callback itself in some cases, which ends up happening forever. We were
assuming that destroying the window of immediately destroy the frame clock as well, but the paint source idle
keeps a reference of the frame clock. At the end of the source idle callback the source is scheduled again,
taking a new reference. We need to call gdk_frame_clock_end_updating() to ensure the idle is not scheduled
again.

• platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp:

(WebCore::DisplayRefreshMonitorGtk::~DisplayRefreshMonitorGtk): Disconnect the update signal and call
gdk_frame_clock_end_updating().
(WebCore::DisplayRefreshMonitorGtk::requestRefreshCallback): Toplevel window should always have a frame clock,
so remove the early return and add an assert instead.

2:20 AM Changeset in webkit [260629] by Carlos Garcia Campos

• 7 edits in releases/WebKitGTK/webkit-2.28

Merge r260506 - [GStreamer][MSE] Youtube 'live stream'/H264 URLs fail to play, VP8/9 URLs play OK
​https://bugs.webkit.org/show_bug.cgi?id=209119

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The fix consists of removing the initial avoiding of seeking and just
issuing the proper segment instead of seeking (seeks in GStreamer can't
be done before prerolling anyway). Appsrc doesn't make easy to emit our
own custom segment, so what I did was to use a segment fixer probe to
modify the original [0, infinity] segment issued by appsrc and use
a [startTime, stopTime] with proper values depending on the seek target
and rate.

Covered by existing tests.

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::checkShouldDelaySeek): Don't hold seeks on startup, when changing from READY to PAUSED.
(WebCore::MediaPlayerPrivateGStreamerMSE::doSeek): Refactored seek delay condition. Also, don't do a regular
gst_element_seek() for initial seeks, just proceed with a special case in that situation.

• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(initialSeekSegmentFixerProbe): Probe that fixes the segment.
(webKitMediaSrcPrepareInitialSeek): Behave much like a regular seek, but also compute the right GstSegment, install
the segment fixer probe and setReadyForMoreSamples() on the SourceBufferPrivates.

• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.h:

LayoutTests:

Unskipped media/media-source/media-source-seek-redundant-append.html,
which passes now.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

2:20 AM Changeset in webkit [260628] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit

Merge r260252 - [GTK][X11] REGRESSION(r259944): Wrong position of select popup menu in X11
​https://bugs.webkit.org/show_bug.cgi?id=210603

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-04-17
Reviewed by Michael Catanzaro.

gdk_window_move_to_rect expects the given rectangle in coordinates relative to the top-left corner of the window
that the popup window is transient for. We were using screen coordinates.

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Translate widget coordinates to window coordinates before passing
the rectangle to gdk_window_move_to_rect().

2:20 AM Changeset in webkit [260627] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebKit

Merge r260244 - [GTK] UI process crash when entering compositing mode when WPE_RENDERER is enabled
​https://bugs.webkit.org/show_bug.cgi?id=209118

Reviewed by Michael Catanzaro.

Check if EGL_WL_bind_wayland_display extension is available when using WPE_RENDERER, since we don't suport the
SHM interface.

• UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:

(WebKit::AcceleratedBackingStoreWayland::checkRequirements): Return false if EGL_WL_bind_wayland_display is not present.

2:20 AM Changeset in webkit [260626] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.28/Source/WTF

Merge r260179 - Unreviewed, set CeilingOnPageSize for MIPS64

This fixes a build failure ("Must set CeilingOnPageSize in
PageBlock.h").

• wtf/PageBlock.h:

1:27 AM Changeset in webkit [260625] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebCore

Add missing HTMLNames:: namespace prefix to usage of liTag object

Unreviewed build fix.

No new tests needed.

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::observeParagraphs):

12:59 AM Changeset in webkit [260624] by commit-queue@webkit.org

• 5 edits in trunk/LayoutTests

Import fetch/stale-while-revalidate/fetch.html
​https://bugs.webkit.org/show_bug.cgi?id=210905

Patch by Rob Buis <​rbuis@igalia.com> on 2020-04-24
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Import fetch/stale-while-revalidate/fetch.html to try to fix
flakiness (see ​https://bugs.webkit.org/show_bug.cgi?id=207230).

• web-platform-tests/fetch/stale-while-revalidate/fetch.html:

LayoutTests:

This test should not be flaky anymore.

• platform/ios/TestExpectations:
• platform/mac/TestExpectations: