Timeline

Apr 27, 2020:

11:59 PM Changeset in webkit [260811] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK][WebInspector] platformSave broken when running within the Flatpak runtime
​https://bugs.webkit.org/show_bug.cgi?id=209473

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-04-27
Reviewed by Adrian Perez de Castro.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): White-list the user document
folder into the sandbox. This seems needed by the file-chooser
popup, somehow.

11:41 PM Changeset in webkit [260810] by ysuzuki@apple.com

• 10 edits
  1 add in trunk

[JSC] Throw OutOfMemoryError instead of RangeError if BigInt is too big
​https://bugs.webkit.org/show_bug.cgi?id=211111

Reviewed by Saam Barati.

JSTests:

• stress/big-int-constructor-oom.js:

(catch):

• stress/big-int-left-shift-range-error.js:

(assertThrowRangeError):

• stress/big-int-out-of-memory-tests.js:

(catch):

• stress/bigint-exponential-oom.js: Added.

(shouldThrow):

• stress/bigint-int32-min-shift.js:

(shouldThrow):

Source/JavaScriptCore:

Currently, we are throwing a RangeError if we detect that JSBigInt becomes too large. But this is not consistent with our JSString's policy.
We should throw OutOfMemoryError in this case. This also makes DFG simple since DFG allows throwing OutOfMemoryError in any places which node
is even removed.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• runtime/ExceptionHelpers.cpp:

(JSC::throwOutOfMemoryError):

• runtime/ExceptionHelpers.h:
• runtime/JSBigInt.cpp:

(JSC::JSBigInt::tryCreateWithLength):
(JSC::JSBigInt::exponentiateHeap):
(JSC::JSBigInt::leftShiftByAbsolute):
(JSC::JSBigInt::allocateFor):

11:24 PM Changeset in webkit [260809] by sbarati@apple.com

• 8 edits in trunk/Source/JavaScriptCore

BigInt math runtime shouldn't convert BigInt32 input operands to a heap cell when doing math
​https://bugs.webkit.org/show_bug.cgi?id=210978

Reviewed by Yusuke Suzuki.

This patch adds support in the runtime for doing alomst all BigInt math
operations on the inputs either being Int32, HeapBigInt, or a mixing
of both. Before, if we detected a binary operation on an Int32 and a
HeapBigInt, this would lead us to convert the Int32 operand into a HeapBigInt.

This is especially bad because we'd repeat this for all math ops. For example,
if x is a BigInt32, and all rhs are a HeapBigInt, we'd repeatedly convert x
to a HeapBigInt for each operation:
`
x + y
x * y
x - y
x >> y
x << y
etc
`

To teach the runtime how to operate both over a BigInt32 and a HeapBigInt, I
templatized the runtime math operations to work both over BigInt32 and
HeapBigInt wrapper classes that expose the same interface.

This is a ~28% speedup on microbenchmarks/sunspider-sha1-big-int.js

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compare):

• jit/JITOperations.cpp:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/JSBigInt.cpp:

(JSC::HeapBigIntImpl::HeapBigIntImpl):
(JSC::HeapBigIntImpl::isZero):
(JSC::HeapBigIntImpl::sign):
(JSC::HeapBigIntImpl::length):
(JSC::HeapBigIntImpl::digit):
(JSC::HeapBigIntImpl::toHeapBigInt):
(JSC::Int32BigIntImpl::Int32BigIntImpl):
(JSC::Int32BigIntImpl::isZero):
(JSC::Int32BigIntImpl::sign):
(JSC::Int32BigIntImpl::length):
(JSC::Int32BigIntImpl::digit):
(JSC::Int32BigIntImpl::toHeapBigInt):
(JSC::JSBigInt::ImplResult::ImplResult):
(JSC::tryConvertToBigInt32):
(JSC::JSBigInt::inplaceMultiplyAdd):
(JSC::JSBigInt::exponentiateImpl):
(JSC::JSBigInt::exponentiate):
(JSC::JSBigInt::multiplyImpl):
(JSC::JSBigInt::multiply):
(JSC::JSBigInt::divideImpl):
(JSC::JSBigInt::divide):
(JSC::JSBigInt::copy):
(JSC::JSBigInt::unaryMinusImpl):
(JSC::JSBigInt::unaryMinus):
(JSC::JSBigInt::remainderImpl):
(JSC::JSBigInt::remainder):
(JSC::JSBigInt::incImpl):
(JSC::JSBigInt::inc):
(JSC::JSBigInt::decImpl):
(JSC::JSBigInt::dec):
(JSC::JSBigInt::addImpl):
(JSC::JSBigInt::add):
(JSC::JSBigInt::subImpl):
(JSC::JSBigInt::sub):
(JSC::JSBigInt::bitwiseAndImpl):
(JSC::JSBigInt::bitwiseAnd):
(JSC::JSBigInt::bitwiseOrImpl):
(JSC::JSBigInt::bitwiseOr):
(JSC::JSBigInt::bitwiseXorImpl):
(JSC::JSBigInt::bitwiseXor):
(JSC::JSBigInt::leftShiftImpl):
(JSC::JSBigInt::leftShift):
(JSC::JSBigInt::leftShiftSlow):
(JSC::JSBigInt::signedRightShiftImpl):
(JSC::JSBigInt::signedRightShift):
(JSC::JSBigInt::bitwiseNotImpl):
(JSC::JSBigInt::bitwiseNot):
(JSC::JSBigInt::internalMultiplyAdd):
(JSC::JSBigInt::multiplyAccumulate):
(JSC::JSBigInt::absoluteCompare):
(JSC::JSBigInt::compareImpl):
(JSC::JSBigInt::compare):
(JSC::JSBigInt::absoluteAdd):
(JSC::JSBigInt::absoluteSub):
(JSC::JSBigInt::absoluteDivWithDigitDivisor):
(JSC::JSBigInt::absoluteDivWithBigIntDivisor):
(JSC::JSBigInt::absoluteLeftShiftAlwaysCopy):
(JSC::JSBigInt::absoluteBitwiseOp):
(JSC::JSBigInt::absoluteAnd):
(JSC::JSBigInt::absoluteOr):
(JSC::JSBigInt::absoluteAndNot):
(JSC::JSBigInt::absoluteXor):
(JSC::JSBigInt::absoluteAddOne):
(JSC::JSBigInt::absoluteSubOne):
(JSC::JSBigInt::leftShiftByAbsolute):
(JSC::JSBigInt::rightShiftByAbsolute):
(JSC::JSBigInt::rightShiftByMaximum):
(JSC::JSBigInt::toStringGeneric):
(JSC::JSBigInt::toShiftAmount):
(JSC::JSBigInt::exponentiateHeap): Deleted.
(JSC::JSBigInt::multiplyHeap): Deleted.
(JSC::JSBigInt::divideHeap): Deleted.
(JSC::JSBigInt::unaryMinusHeap): Deleted.
(JSC::JSBigInt::remainderHeap): Deleted.
(JSC::JSBigInt::incHeap): Deleted.
(JSC::JSBigInt::decHeap): Deleted.
(JSC::JSBigInt::addHeap): Deleted.
(JSC::JSBigInt::subHeap): Deleted.
(JSC::JSBigInt::bitwiseAndHeap): Deleted.
(JSC::JSBigInt::bitwiseOrHeap): Deleted.
(JSC::JSBigInt::bitwiseXorHeap): Deleted.
(JSC::JSBigInt::leftShiftHeap): Deleted.
(JSC::JSBigInt::signedRightShiftHeap): Deleted.
(JSC::JSBigInt::bitwiseNotHeap): Deleted.
(JSC::JSBigInt::compareToInt32): Deleted.

• runtime/JSBigInt.h:
• runtime/Operations.cpp:

(JSC::jsAddSlowCase):

• runtime/Operations.h:

(JSC::compareBigInt):
(JSC::compareBigInt32ToOtherPrimitive):
(JSC::arithmeticBinaryOp):
(JSC::jsSub):
(JSC::jsMul):
(JSC::jsDiv):
(JSC::jsRemainder):
(JSC::jsPow):
(JSC::jsInc):
(JSC::jsDec):
(JSC::jsBitwiseNot):
(JSC::shift):
(JSC::jsLShift):
(JSC::jsRShift):
(JSC::bitwiseBinaryOp):
(JSC::jsBitwiseAnd):
(JSC::jsBitwiseOr):
(JSC::jsBitwiseXor):

11:22 PM Changeset in webkit [260808] by Simon Fraser

• 8 edits
  2 adds in trunk

Do correct clipping of composited replaced elements with border-radius
​https://bugs.webkit.org/show_bug.cgi?id=211114

Reviewed by Zalan Bujtas.
Source/WebCore:

For replaced elements with composited content (video, WebGL), RenderLayerBacking
incorrectly used the rounded inner border rect to clip the contents. This doesn't match
painted replaced elements, which clip to the inside of the padding box.

Fix by implementing RenderReplaced::roundedContentBoxRect() and calling it from compositing
code. Also add a helper to get the rounded border box rect, and call it in various places.

Test: compositing/clipping/border-radius-on-webgl.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::roundedBorderBoxRect const):

• rendering/RenderBox.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateBackdropFiltersGeometry):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::updateContentsRects):
(WebCore::RenderLayerBacking::resetContentsRect):
(WebCore::RenderLayerBacking::updateChildClippingStrategy):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::updateImageContents):
(WebCore::backgroundRectForBox):

• rendering/RenderLayerBacking.h:
• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::roundedContentBoxRect const):

• rendering/RenderReplaced.h:

LayoutTests:

This test clips out everything but the rounded padding area. None of the red
canvas should show.

• compositing/clipping/border-radius-on-webgl-expected.html: Added.
• compositing/clipping/border-radius-on-webgl.html: Added.

7:47 PM Changeset in webkit [260807] by Devin Rousso

• 6 edits in trunk

Web Inspector: Storage: can see third-party cookies
​https://bugs.webkit.org/show_bug.cgi?id=211092
<rdar://problem/62469078>

Reviewed by Chris Dumez.

Source/WebKit:

Test: http/tests/inspector/page/get-cookies.html

After r259649, Web Inspector no longer incorrectly bails when attempting to get cookies if
the last resource loaded by a given frame does not have cookie access. We also need to check
whether the resource we're attempting to get cookies for is first-party or third-party so as
to reflect the current cookie policy.

• WebProcess/WebPage/WebCookieJar.cpp:

(WebKit::shouldBlockCookies):

LayoutTests:

• http/tests/inspector/page/get-cookies.html:
• http/tests/inspector/page/get-cookies-expected.txt:
• http/tests/inspector/page/resources/set-cookie.php:

6:35 PM Changeset in webkit [260806] by keith_miller@apple.com

• 3 edits in trunk/JSTests

stress/generator-containing-for-of-on-map.js and stress/generator-containing-for-of-on-set.js timing out on debug JSC bot
​https://bugs.webkit.org/show_bug.cgi?id=211095

Reviewed by Yusuke Suzuki.

Let's try making these tests shorter. Eager compilation should still be interesting with the shorter iterations.

• stress/generator-containing-for-of-on-map.js:
• stress/generator-containing-for-of-on-set.js:

6:33 PM Changeset in webkit [260805] by ysuzuki@apple.com

• 8 edits
  1 add in trunk

[JSC] >>> should call ToNumeric
​https://bugs.webkit.org/show_bug.cgi?id=211065

Reviewed by Ross Kirsling.

JSTests:

• stress/bigint-urshift.js: Added.

(shouldBe):
(shouldThrow):

• test262/expectations.yaml:

Source/JavaScriptCore:

While BigInt does not support >>> operator, >>> operator should call ToNumeric (in this case, toBigIntOrInt32) for both before throwing an error.
We call toBigIntOrInt32 for both operands, and throw an error. And after that, casting int32_t to uint32_t to perform >>> operator. This is correct
since the only difference between toUint32 and toInt32 is casting int32_t result to uint32_t.

• dfg/DFGOperations.cpp:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/Operations.h:

(JSC::shift):
(JSC::jsURShift):

6:08 PM Changeset in webkit [260804] by Lauro Moura

• 3 edits in trunk/LayoutTests

[GTK][WPE] Gardening timing out host invalid values test

Unreviewed test gardening.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

5:51 PM Changeset in webkit [260803] by keith_miller@apple.com

• 9 edits in trunk/Source/JavaScriptCore

OSR Exit compiler should know and print the exiting DFG node's index
​https://bugs.webkit.org/show_bug.cgi?id=210998

Reviewed by Mark Lam.

The only interesting thing here is that we set the node to index 0 if there is no node.
AFAICT, we only don't have a node when we are checking arguments.

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::operationCompileOSRExit):

• dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::OSRExitBase):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileInvalidationPoint):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckSubClass):
(JSC::FTL::DFG::LowerDFGToB3::blessSpeculation):

• ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExitDescriptor::emitOSRExit):
(JSC::FTL::OSRExitDescriptor::emitOSRExitLater):
(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
(JSC::FTL::OSRExit::OSRExit):

• ftl/FTLOSRExit.h:
• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

5:35 PM Changeset in webkit [260802] by sbarati@apple.com

• 3 edits in trunk/Source/JavaScriptCore

compilePeepHoleBigInt32Branch needs to handle all conditions
​https://bugs.webkit.org/show_bug.cgi?id=211096
<rdar://problem/62469971>

Reviewed by Yusuke Suzuki.

We were falling through to the generic path for all conditions which
weren't Equal/NotEqual. The generic path does not do speculation, so
it was leading to potential miscompiles because we omitted a type check.
Defining compilePeepHoleBigInt32Branch for other conditions is trivial,
so this patch just implements that.

This failure is caught by microbenchmarks/sunspider-sha1-big-int.js

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBigInt32Branch):

5:29 PM Changeset in webkit [260801] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

Follow-up change after r260798.

Allow iOS to consume the 'com.apple.cfprefsd.agent' endpoint if issued by the UIProcess.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

5:22 PM Changeset in webkit [260800] by commit-queue@webkit.org

• 14 edits
  2 adds in trunk

Timestamps should be the same for all rendering update steps
​https://bugs.webkit.org/show_bug.cgi?id=207153

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-04-27
Reviewed by Simon Fraser.

Source/WebCore:

The HTML 5 event loop sepcs states that timestamps should be the same for
all rendering update steps.

Specs link (step 9):

​https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-processing-model

This patch also fixes some issues in IntersectionObserver.

Test: intersection-observer/intersection-observer-callback-timestamp.html

• dom/Document.cpp:

(WebCore::Document::updateIntersectionObservations):
(WebCore::Document::notifyIntersectionObserversTimerFired): Deleted.

• dom/Document.h:

-- Handle the case when two floats are areEssentiallyEqual().
-- Execute the IntersectionObserver immediately and do not wait until the

next CFRunLoop event since this does not implement the specs.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::freezeNowTimestamp):
(WebCore::DOMWindow::unfreezeNowTimestamp):
(WebCore::DOMWindow::frozenNowTimestamp const):

• page/DOMWindow.h:

Provide a frozen now() timestamp in seconds to be used internally only.

• page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::nowTimestamp const):
Use the frozenNowTimestamp().

• page/Page.cpp:

(WebCore::Page::updateRendering):
Freeze the timestamps while serving the rendering update steps.

LayoutTests:

• animations/animation-callback-timestamp-expected.txt:
• animations/animation-callback-timestamp.html:

Ensure the rAF callback timestamp is less than Performance.now().

• animations/animation-multiple-callbacks-timestamp-expected.txt:
• animations/animation-multiple-callbacks-timestamp.html:

Ensure the rAF callbacks receive the same timestamps.

• intersection-observer/intersection-observer-callback-timestamp-expected.txt: Added.
• intersection-observer/intersection-observer-callback-timestamp.html: Added.

A new test to ensure the IntersectionObsever and the rAF callbacks receive the same timestamps.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk1/TestExpectations:

5:16 PM Changeset in webkit [260799] by Jason_Lawrence

• 9 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r260772.

This commit caused tests to start failing internally.

Reverted changeset:

"OSR Exit compiler should know and print the exiting DFG
node's index"
​https://bugs.webkit.org/show_bug.cgi?id=210998
​https://trac.webkit.org/changeset/260772

5:12 PM Changeset in webkit [260798] by Brent Fulgham

• 9 edits in trunk/Source/WebKit

[MacCatalyst] Dynamic access to accessibility services is incomplete
​https://bugs.webkit.org/show_bug.cgi?id=211100
<rdar://problem/62133491>

Reviewed by Darin Adler.

Testing of MacCatalyst-based apps shows that using dynamic sandbox extensions to support accessibility
features is incomplete. In addition to the 'com.apple.cfprefsd.daemon' process needed on macOS and iOS,
we also need access to 'com.apple.cfprefsd.agent'.

This can only be tested manually in a MacCatlyst build, though existing accessibility tests will
confirm no regressions in iOS and macOS.

The changes are as follows:

1. Change WebProcessCreationParameters::preferencesExtensionHandle to a handle array.
2. Register (and unregister) for the accessibility enabled notification in MacCatalyst.
3. Open a connection 'com.apple.cfprefsd.agent' (in addition to the existing 'com.apple.cfprefsd.daemon') in MacCatalyst builds.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):

• UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::unblockPreferenceServiceIfNeeded):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:
• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::unblockPreferenceService):

• WebProcess/com.apple.WebProcess.sb.in:

4:39 PM Changeset in webkit [260797] by Ryan Haddad

• 2 edits in trunk/LayoutTests

[ macOS/iOS wk2 Debug ] webrtc/datachannel/multiple-connections.html is flaky timing out.
​https://bugs.webkit.org/show_bug.cgi?id=209878

Unreviewed test gardening.

• platform/ios/TestExpectations: Mark the test as slow for iOS, too.

4:32 PM Changeset in webkit [260796] by Jonathan Bedard

• 2 edits in trunk/Tools

results.webkit.org: A suite running multiple times in a commit for a single configuration may pre-empt processing
​https://bugs.webkit.org/show_bug.cgi?id=211094
<rdar://problem/62470170>

Reviewed by Aakash Jain.

Hash collision in processing key when results only differ by upload time.

• resultsdbpy/resultsdbpy/model/upload_context.py:

(UploadContext.process_test_results): Include upload timestamp in the hashed key.

4:06 PM Changeset in webkit [260795] by Russell Epstein

• 6 edits in branches/safari-609.2.9.0-branch/Source/WebKit

Apply patch. rdar://problem/62377357

3:59 PM Changeset in webkit [260794] by Russell Epstein

• 8 edits in branches/safari-609.2.9.0-branch/Source

Versioning.

3:50 PM Changeset in webkit [260793] by Wenson Hsieh

• 6 edits in trunk/Source/WebKit

Prevent WebPasteboardProxy IPC messages from unconditionally requesting pasteboard types
​https://bugs.webkit.org/show_bug.cgi?id=211061
<rdar://problem/62088185>

Reviewed by Tim Horton.

Tighten IPC message handling in WebPasteboardProxy, such that a web content process is unable to arbitrarily
request pasteboard types (and other metadata that depends on pasteboard types, such as the number of files
on the pasteboard).

This extends the mechanisms added in r259151 by distinguishing between allowing the web process to request
type information from the pasteboard, and allowing the web process to request both types and data. In the
case of drag and drop, the former is required by the web process from the moment the drag session enters
the platform web view; however, the latter is required only after a drop is performed.

We utilize this new check, canAccessPasteboardTypes, in seven existing IPC message handlers that either
directly return the list of types, or return metadata from which pasteboard types may be deduced.

See below for more details; covered by existing API and layout tests.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::grantAccessToCurrentTypes):
(WebKit::WebPasteboardProxy::grantAccessToCurrentData):

Split the pasteboard access check into two helpers: one to determine whether the web process is allowed to
request pasteboard types, and another to determine whether the web process is allowed to request pasteboard
data (in addition to types).

(WebKit::WebPasteboardProxy::grantAccess):
(WebKit::WebPasteboardProxy::revokeAccess):

Refactor these to use PasteboardAccessInformation; see below for more details.

(WebKit::WebPasteboardProxy::canAccessPasteboardTypes const):

Return true as long as the accessType is nonnull; this is because either Types or TypesAndData is
sufficient for access to pasteboard types.

(WebKit::WebPasteboardProxy::canAccessPasteboardData const):
(WebKit::WebPasteboardProxy::accessType const):

Add a private helper method to return the access type (nullopt for no access, PasteboardAccessType::Types
for access to types only, and PasteboardAccessType::TypesAndData for access to data in addition to types)
for the given named pasteboard.

(WebKit::WebPasteboardProxy::didModifyContentsOfPasteboard):

Refactor this to use PasteboardAccessInformation.

(WebKit::WebPasteboardProxy::getPasteboardTypes):
(WebKit::WebPasteboardProxy::getPasteboardPathnamesForType):

Adopt canAccessPasteboardTypes here, and update the FIXME to state that we should really be using
canAccessPasteboardData instead. This is blocked on refactoring some more drag and drop code, such
that accessing the list of file names on the pasteboard isn't necessary before the drop is handled.

(WebKit::WebPasteboardProxy::containsURLStringSuitableForLoading):
(WebKit::WebPasteboardProxy::getNumberOfFiles):
(WebKit::WebPasteboardProxy::typesSafeForDOMToReadAndWrite):
(WebKit::WebPasteboardProxy::allPasteboardItemInfo):
(WebKit::WebPasteboardProxy::informationForItemAtIndex):
(WebKit::WebPasteboardProxy::getPasteboardItemsCount):
(WebKit::WebPasteboardProxy::containsStringSafeForDOMToReadForType):

Adopt the canAccessPasteboardTypes check in various places.

(WebKit::WebPasteboardProxy::PasteboardAccessInformation::grantAccess):
(WebKit::WebPasteboardProxy::PasteboardAccessInformation::revokeAccess):
(WebKit::WebPasteboardProxy::PasteboardAccessInformation::accessType const):

Introduce PasteboardAccessInformation, which replaces the current std::pair<uint64_t, WeakHashSet<WebProcessProxy>>
that is used to represent which web processes are allowed to access certain changeCounts, for a given pasteboard name.
Instead of maintaining a changeCount and set of processes, we now maintain a changeCount and list of (process, access
type) pairs. Each item in this list tracks whether the process that has been granted access should be allowed to read
only pasteboard types, or both types and data.

(WebKit::WebPasteboardProxy::revokeAccessToAllData): Deleted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):

When updating the drag session (i.e. as the user drags over the web view), ensure that the web content
process is able to request pasteboard types.

• UIProcess/WebPasteboardProxy.cpp:

(WebKit::WebPasteboardProxy::allPasteboardItemInfo):
(WebKit::WebPasteboardProxy::informationForItemAtIndex):
(WebKit::WebPasteboardProxy::getPasteboardItemsCount):
(WebKit::WebPasteboardProxy::containsStringSafeForDOMToReadForType):
(WebKit::WebPasteboardProxy::containsURLStringSuitableForLoading):

Update these method signatures.

• UIProcess/WebPasteboardProxy.h:
• UIProcess/WebPasteboardProxy.messages.in:

Mark more IPC messages as WantsConnection so that we can use the IPC::Connection argument in the message handlers.

3:42 PM Changeset in webkit [260792] by Simon Fraser

• 2 edits in trunk/LayoutTests

fast/events/wheel-event-outside-body.html sometimes fails
​https://bugs.webkit.org/show_bug.cgi?id=211098

Reviewed by Tim Horton.

Remove the 100ms watchdog timer. We'll just let the test time out if it fails.

• fast/events/wheel-event-outside-body.html:

3:33 PM Changeset in webkit [260791] by achristensen@apple.com

• 6 edits in trunk/Source/WebKit

Stop waiting for a BinarySemaphore on the main thread in the NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=211080
<rdar://problem/62377357>

Reviewed by Darin Adler and Chris Dumez.

There was an out-of-date comment suggesting we needed to use a semaphore, but we've since added these in the destructor:
RELEASE_ASSERT(!m_statisticsStore);
RELEASE_ASSERT(!m_persistentStorage);
This indicates that flushAndDestroyPersistentStore is called before the destructor, at which time it is safe to add a reference to keep it alive.
WebResourceLoadStatisticsStore is also marked as WTF::DestructionThread::Main so this should do everything we need.
We also flush these databases to disk before closing like we did cookies.

In order to keep tests working as they are, I needed to make recreateResourceLoadStatisticStore have a CompletionHandler and have all
WebResourceLoadStatisticsStores share the same queue to serialize background tasks between WebResourceLoadStatisticsStores with and without database stores
sequentially to avoid opening a SQLiteDatabase before the previous WebResourceLoadStatisticsStore had closed it.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::sharedStatisticsQueue):
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::didDestroyNetworkSession):
(WebKit::WebResourceLoadStatisticsStore::flushAndDestroyPersistentStore):
(WebKit::WebResourceLoadStatisticsStore::applicationWillTerminate): Deleted.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didClose):

• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::~NetworkSession):
(WebKit::NetworkSession::destroyResourceLoadStatistics):
(WebKit::NetworkSession::setResourceLoadStatisticsEnabled):
(WebKit::NetworkSession::recreateResourceLoadStatisticStore):

• NetworkProcess/NetworkSession.h:

3:27 PM Changeset in webkit [260790] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Fix tests after r260764
​https://bugs.webkit.org/show_bug.cgi?id=211093

Some tests were asserting in takeAsyncReplyHandler.
Calling addAsyncReplyHandler before sending the message fixes it.

• UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::sendMessage):

3:08 PM Changeset in webkit [260789] by dino@apple.com

• 2 edits in trunk/Source/WebCore

getShaderPrecisionFormat returns the wrong values
​https://bugs.webkit.org/show_bug.cgi?id=211013
<rdar://problem/62378056>

Reviewed by Darin Adler.

Gregg pointed out that our code hardcodes values for
getShaderPrecisionFormat. The fix is simply to call into
the underlying GL function.

Covered by the existing test: webgl/1.0.3/conformance/misc/shader-precision-format.html

However, that just tests minimum values. Devices have different
actual results.

• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::getShaderPrecisionFormat):

2:57 PM Changeset in webkit [260788] by Simon Fraser

• 6 edits in trunk/Source/WebCore

Rename scrollableAreaForScrollLayerID to scrollableAreaForScrollingNodeID
​https://bugs.webkit.org/show_bug.cgi?id=211091

Reviewed by Myles C. Maxfield.

The argument to scrollableAreaForScrollLayerID() is a ScrollingNodeID, not a layerID.

• page/FrameView.cpp:

(WebCore::FrameView::scrollableAreaForScrollingNodeID const):
(WebCore::FrameView::scrollableAreaForScrollLayerID const): Deleted.

• page/FrameView.h:
• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::setActiveScrollSnapIndices):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::scrollableAreaForScrollingNodeID const):
(WebCore::RenderLayerCompositor::scrollableAreaForScrollLayerID const): Deleted.

• rendering/RenderLayerCompositor.h:

2:48 PM Changeset in webkit [260787] by Chris Dumez

• 2 edits in trunk/Source/WebKit

[iOS][WK2] Drop "com.apple.WebKit.DatabaseActivity" UIKit background activity
​https://bugs.webkit.org/show_bug.cgi?id=211084

Reviewed by Geoffrey Garen.

Drop "com.apple.WebKit.DatabaseActivity" UIKit background activity in the UIProcess now that local storage
has been moved to the network process.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setUpSQLiteDatabaseTrackerClient]): Deleted.

2:37 PM Changeset in webkit [260786] by zhifei_fang@apple.com

• 2 edits in trunk/Tools

Add some debug output for run-jsc-stress-tests
​https://bugs.webkit.org/show_bug.cgi?id=210999
<rdar://problem/61353156>

This will help to address where the script get stucked

Reviewed by Jonathan Bedard.

• Scripts/run-jsc-stress-tests:

2:32 PM Changeset in webkit [260785] by Ryan Haddad

• 7 edits in trunk/Source

[Cocoa] stop using out arguments for document attributes when converting to attributed strings
​https://bugs.webkit.org/show_bug.cgi?id=211048

Unreviewed partial revert of r260739 to remove unexpected logging that broke Catalina-Release-WK2-Perf tests.

Source/WebCore:

• platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::policyProperties):

• platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::siteForCookies):

Source/WebKit:

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::updateTaskWithFirstPartyForSameSiteCookies):

Source/WTF:

• wtf/cocoa/URLCocoa.mm:

(WTF::URL::createCFURL const):

2:14 PM Changeset in webkit [260784] by ysuzuki@apple.com

• 5 edits in trunk

[JSC] Add $vm.assertEnabled() to suppress Debug crash expected tests in release+assert build
​https://bugs.webkit.org/show_bug.cgi?id=211089

Reviewed by Keith Miller.

JSTests:

We have ASSERT which only fires when DOM object is wrongly implemented to catch wrong ones.
We are using ASSERT in JSC side since we don't know all the DOM objects are correctly implemented.
If it is not correctly implemented, in Release build, JSC is returning sub-optimal but right results.
But in Debug build, we can catch the wrong ones, which allows us to fix the wrong things while avoiding
catastrophic crashes in release build.

However, the test is assuming that ASSERT is not enabled if it is not Debug build. Release & Debug builds
work, but Release+Assert does not meet this assumption.

So, skip this based on $vm.assertEnabled().

• stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js:

(vm.assertEnabled.putter):
(vm.assertEnabled):
(putter): Deleted.
(not_string.toString): Deleted.

• stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten.js:

(vm.assertEnabled):
(not_string.toString): Deleted.

Source/JavaScriptCore:

Expose ASSERT_ENABLED condition to the shell to control crash expected tests.

• tools/JSDollarVM.cpp:

(JSC::functionAssertEnabled):
(JSC::JSDollarVM::finishCreation):

2:12 PM Changeset in webkit [260783] by Wenson Hsieh

• 4 edits in trunk

Text manipulation should not aggregate text from different navigation anchor elements
​https://bugs.webkit.org/show_bug.cgi?id=211081
<rdar://problem/59553658>

Reviewed by Megan Gardner.

Source/WebCore:

Tweak the item boundary heuristic in TextManipulationController::observeParagraphs to separate text in
links and list items under navigation elements (either nav elements, or elements with the "navigation"
accessibility role) into separate paragraphs.

Also, extend the item boundary rule for button elements to apply to elements with the "button"
accessibility role as well.

Test: TextManipulation.StartTextManipulationTreatsInlineBlockLinksAndButtonsAsParagraphs

TextManipulation.StartTextManipulationTreatsLinksInNavigationElementsAsParagraphs

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::observeParagraphs):

Tools:

Add a new API test, and augment an existing test.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

2:11 PM Changeset in webkit [260782] by Jonathan Bedard

• 9 edits
  2 adds in trunk/Tools

results.webkit.og: Add investigation endpoint
​https://bugs.webkit.org/show_bug.cgi?id=209562

Rubber-stamped by Aakash Jain.

Add an endpoint that allows users to list all test failures given some criteria, and
provide a partial list of failures in the investigation drawer.

• resultsdbpy/resultsdbpy/view/static/js/commit.js:

(CommitTable): Link commit to investigation endpoint.
(_CommitBank.prototype.latest): Populate the CommitBank with the last x commits.
(_CommitBank.prototype.commitsDuringUuid): Renamed commitsDuring.
(_CommitBank.prototype. commitsDuring): Accept a range Uuids instead of a single Uuid.
(_CommitBank.prototype._load): Load a single commit if the before and after uuid match.

• resultsdbpy/resultsdbpy/view/static/js/common.js:

(paramsToQuery): False should be added as a parameter, if provided.
(percentage): Moved from investigate.js.
(elapsedTime): Ditto.

• resultsdbpy/resultsdbpy/view/static/js/configuration.js:

(Configuration.combine): Allow configurations to be combined to a single, more general, configuration.

• resultsdbpy/resultsdbpy/view/static/js/failures.js: Added.

(Failures.prototype.fromEndpoint): Construct a failure object from the failures endpoint.
(Failures.combine): Combine two failure objects together.
(Failures):
(Failures.prototype.toParams): Convert object to parameters for other results database queries.

• resultsdbpy/resultsdbpy/view/static/js/investigate.js:

(elapsed): Used shared time elapsed function.
(percentage): Moved to common.js.
(prioritizedFailures): Return a div with a truncated list of tests which failed.
(resultsForData): Include some number of prioritized test failures based on how many bubbles are
already displayed.
(_InvestigateDrawer.prototype.expand): Dispatch failure request.
(_InvestigateDrawer.prototype.dispatch): Start request to failures endpoint.

• resultsdbpy/resultsdbpy/view/static/js/timeline.js:

(TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add link to investigation endpoint.
(Legend): When search parameters change, we need to re-dispatch failure requests.

• resultsdbpy/resultsdbpy/view/suite_view.py:

(SuiteView._suites_for_investigation): Filter parameters for investigation endpoint.
(SuiteView.investigate): Return investigation endpoint html template.

• resultsdbpy/resultsdbpy/view/templates/investigate.html: Added.

(willFilterExpected): Check if the query parameters indicate that expected failures are to be ignored.
(commitsForRange): Return a list of commits for a uuid range.
(SuiteFailuresView.constructor): Abstraction to hold the investigation data for a single suite.
(SuiteFailuresView.reload): Dispatch requests to the results and failures endpoint to populate
investigation data.
(SuiteFailuresView.select): By default, failures for different configurations are collapsed into a single
view. Allows the user to iterate through each configuration that comprises the view.
(SuiteFailuresView.toString):
(populateRanges): Either convert the provided arguments to a range to search for failures and results
in, or use the most recent commit.
(reload): Force all suite views to re-dispatch results and failures requests.

• resultsdbpy/resultsdbpy/view/templates/suite_results.html: Add space between suite content and

top bar.

• resultsdbpy/resultsdbpy/view/view_routes.py:

(ViewRoutes.init): Add investigate endpoint.

2:04 PM Changeset in webkit [260781] by ddkilzer@apple.com

• 4 edits in trunk/Source/WebKit

REGRESSION (r219050): Remove more code only needed for building with OS X Yosemite
<​https://webkit.org/b/211088>
<rdar://problem/62452487>

Reviewed by Chris Dumez.

• Platform/IPC/cocoa/ConnectionCocoa.mm:

(IPC::Connection::receiveSourceEventHandler):

• Platform/mac/MachUtilities.cpp:

(setMachPortQueueLength):
(machExceptionPort): Deleted.
(setMachExceptionPort): Deleted.

• Platform/mac/MachUtilities.h:
• Delete unused code.

1:56 PM Changeset in webkit [260780] by graouts@webkit.org

• 4 edits in trunk/LayoutTests

[ iOS ] REGRESSION: animations/change-keyframes-name.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=211079
<rdar://problem/61486093>

Reviewed by Simon Fraser.

Rewrite this test to use the new AnimationTest helper that will non-flakily check animated values while an animation is running.

• animations/change-keyframes-name-expected.txt:
• animations/change-keyframes-name.html:
• animations/resources/animation-test.js:

(AnimationTest.prototype.async recordValueAfterRunningFor):

1:54 PM Changeset in webkit [260779] by Alan Coon

• 1 copy in tags/Safari-610.1.11.3

Tag Safari-610.1.11.3.

1:54 PM Changeset in webkit [260778] by Alan Coon

• 1 delete in tags/Safari-610.1.11.3

Delete tag.

1:53 PM Changeset in webkit [260777] by graouts@webkit.org

• 5 edits in trunk/Source

Clean up some useless includes of CSSAnimationController.h
​https://bugs.webkit.org/show_bug.cgi?id=211066

Reviewed by Antti Koivisto.

Source/WebCore:

These files don't actually use any of the CSSAnimationController APIs.

• page/ios/FrameIOS.mm:
• rendering/RenderObject.cpp:

Source/WebKitLegacy/mac:

This file doesn't actually use any of the CSSAnimationController APIs.

• WebView/WebFrame.mm:

1:50 PM Changeset in webkit [260776] by graouts@webkit.org

• 3 edits in trunk/Source/WebKitLegacy/mac

Remove allowsNewCSSAnimationsWhileSuspended and setAllowsNewCSSAnimationsWhileSuspended WebView SPIs
​https://bugs.webkit.org/show_bug.cgi?id=211067

Reviewed by Tim Horton.

There are no known clients for these SPIs.

• WebView/WebView.mm:
• WebView/WebViewPrivate.h:

1:50 PM Changeset in webkit [260775] by Alan Coon

• 2 edits in branches/safari-610.1.11-branch/Source/WebKit

Cherry-pick r260763. rdar://problem/62467013

Unreviewed sandbox compile fix.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:47 PM Changeset in webkit [260774] by graouts@webkit.org

• 23 edits in trunk/Source

Rename CSSAnimationController accessors from animation() to legacyAnimation()
​https://bugs.webkit.org/show_bug.cgi?id=211082

Reviewed by Simon Fraser.

Source/WebCore:

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty):

• dom/Document.cpp:

(WebCore::Document::resolveStyle):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::prepareForDestruction):
(WebCore::Document::implicitClose):
(WebCore::Document::resume):

• dom/Element.cpp:

(WebCore::Element::removedFromAncestor):

• dom/PseudoElement.cpp:

(WebCore::PseudoElement::clearHostElement):

• history/CachedFrame.cpp:

(WebCore::CachedFrame::destroy):

• page/Frame.cpp:

(WebCore::Frame::clearTimers):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):

• page/Frame.h:
• page/FrameView.cpp:

(WebCore::FrameView::didDestroyRenderTree):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

• page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layout):

• page/Page.cpp:

(WebCore::Page::handleLowModePowerChange):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):

• page/animation/CSSAnimationController.cpp:

(WebCore::CSSAnimationControllerPrivate::updateThrottlingState):
(WebCore::CSSAnimationControllerPrivate::suspendAnimations):
(WebCore::CSSAnimationControllerPrivate::resumeAnimations):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::currentTransform const):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::notifyAnimationStarted):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::isRunningTransformAnimation const):

• rendering/RenderObject.h:

(WebCore::RenderObject::legacyAnimation const):
(WebCore::RenderObject::animation const): Deleted.

• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::tearDownRenderers):

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

• testing/Internals.cpp:

(WebCore::Internals::numberOfActiveAnimations const):
(WebCore::Internals::animationsAreSuspended const):
(WebCore::Internals::animationsInterval const):
(WebCore::Internals::suspendAnimations const):
(WebCore::Internals::resumeAnimations const):
(WebCore::Internals::pauseAnimationAtTimeOnElement):
(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):
(WebCore::Internals::pauseTransitionAtTimeOnElement):
(WebCore::Internals::pauseTransitionAtTimeOnPseudoElement):

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

Source/WebKitLegacy/win:

• WebFrame.cpp:

(WebFrame::resumeAnimations):
(WebFrame::suspendAnimations):
(WebFrame::pauseAnimation):
(WebFrame::pauseTransition):
(WebFrame::numberOfActiveAnimations):

1:24 PM Changeset in webkit [260773] by dino@apple.com

• 5 edits
  2 adds in trunk

Temporarily skip GL_DEPTH_COMPONENT32_OES requirement for depth textures on iOS
​https://bugs.webkit.org/show_bug.cgi?id=211055
<rdar://problem/62410499>

Reviewed by Darin Adler.

Source/ThirdParty/ANGLE:

ANGLE requires GL_DEPTH_COMPONENT32_OES be available in order to expose the
depth texture extension. However, this format is not supported on iOS.
Temporarily remove this restriction while investigating other bugs.

This also allows us to see the failing results in
fast/canvas/webgl/webgl-depth-texture.html
webgl/1.0.3/conformance/extensions/webgl-depth-texture.html

• src/libANGLE/Caps.cpp:

(gl::DetermineDepthTextureANGLESupport):
(gl::DetermineDepthTextureOESSupport):

LayoutTests:

Unskip the fast/canvas/webgl/webgl-depth-texture.html now that
the extension is "supported". It has failing results.

• platform/ios/TestExpectations:
• platform/ios/fast/canvas/webgl/webgl-depth-texture-expected.txt: new results.
• platform/ios/webgl/1.0.3/conformance/extensions/webgl-depth-texture-expected.txt: new results.

1:22 PM Changeset in webkit [260772] by keith_miller@apple.com

• 9 edits in trunk/Source/JavaScriptCore

OSR Exit compiler should know and print the exiting DFG node's index
​https://bugs.webkit.org/show_bug.cgi?id=210998

Reviewed by Mark Lam.

The only interesting thing here is that we set the node to index 0 if there is no node.
AFAICT, we only don't have a node when we are checking arguments.

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::operationCompileOSRExit):

• dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::OSRExitBase):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileInvalidationPoint):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckSubClass):
(JSC::FTL::DFG::LowerDFGToB3::blessSpeculation):

• ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExitDescriptor::emitOSRExit):
(JSC::FTL::OSRExitDescriptor::emitOSRExitLater):
(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
(JSC::FTL::OSRExit::OSRExit):

• ftl/FTLOSRExit.h:
• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

1:21 PM Changeset in webkit [260771] by timothy_horton@apple.com

• 3 edits in trunk/Tools

WebKit.ResizeReversePaginatedWebView is failing (21 pages instead of 20)
​https://bugs.webkit.org/show_bug.cgi?id=211001
<rdar://problem/60972357>

Reviewed by Wenson Hsieh.

• TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
• TestWebKitAPI/Tests/WebKit/lots-of-text-vertical-lr.html:

Use Ahem to keep the layout more stable.

1:17 PM Changeset in webkit [260770] by Alan Coon

• 1 copy in tags/Safari-610.1.11.3

Tag Safari-610.1.11.3.

1:01 PM Changeset in webkit [260769] by pvollan@apple.com

• 13 edits
  1 delete in trunk

[Cocoa] After r258891, r255119 can be reverted
​https://bugs.webkit.org/show_bug.cgi?id=211083
Source/WebCore:

<rdar://problem/60714318>

Unreviewed revert of r255119.

Copying a MIME type map from the UI process to the WebContent process on startup is not needed anymore,
since r258891 will map the Launch Services database in the WebContent process.

• platform/MIMETypeRegistry.cpp:

(WebCore::commonMimeTypesMap):
(WebCore::typesForCommonExtension):
(WebCore::overriddenMimeTypesMap): Deleted.

• platform/MIMETypeRegistry.h:
• testing/Internals.cpp:

(WebCore::Internals::mediaMIMETypeForExtension): Deleted.

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

Unreviewed revert of r255119.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Unreviewed revert of r255119.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Removed.

11:16 AM Changeset in webkit [260768] by Brent Fulgham

• 3 edits in trunk/Source/WebKit

Unreviewed MacCatalyst build fix after r260739.

• UIProcess/Cocoa/TextCheckingController.mm:

(WebKit::TextCheckingController::replaceRelativeToSelection):

• WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

10:57 AM Changeset in webkit [260767] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

storage/indexeddb/value-cursor-cycle.html is flaky failing because it incorrectly thinks our JS GC is precise.
​https://bugs.webkit.org/show_bug.cgi?id=210046

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

10:56 AM Changeset in webkit [260766] by Darin Adler

• 2 edits in trunk/Source/WebKit

Another try at fixing the ENABLE(PLATFORM_DRIVEN_TEXT_CHECKING) build

• UIProcess/Cocoa/TextCheckingController.mm: (WebKit::TextCheckingController::replaceRelativeToSelection): Convert an NSAttributedString to a WebCore::AttributedString using argument list syntax.

10:42 AM Changeset in webkit [260765] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Fix assertion after r260709
​https://bugs.webkit.org/show_bug.cgi?id=211007
<rdar://problem/62457303>

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performJavaScriptURLRequest):
Not only did I spell javascript wrong, I should've used the special protocolIsJavaScript() method.

10:13 AM Changeset in webkit [260764] by commit-queue@webkit.org

• 11 edits in trunk/Source/WebKit

Reduce use of WebPageProxy::VoidCallback
​https://bugs.webkit.org/show_bug.cgi?id=210944

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-27
Reviewed by Darin Adler.

Use sendWithAsyncReply and CompletionHandler<void()> instead.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _executeEditCommand:argument:completion:]):

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::becomeFirstResponder):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setInitialFocus):
(WebKit::WebPageProxy::executeEditCommand):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::focusNextFocusedElement):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView pasteWithCompletionHandler:]):
(-[WKContentView moveByOffset:]):
(-[WKContentView _selectPositionAtPoint:stayingWithinFocusedElement:completionHandler:]):
(-[WKContentView selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView moveSelectionAtBoundary:inDirection:completionHandler:]):
(-[WKContentView selectTextWithGranularity:atPoint:completionHandler:]):
(-[WKContentView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
(-[WKContentView accessoryTab:]):
(-[WKContentView executeEditCommandWithCallback:]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::selectTextWithGranularityAtPoint):
(WebKit::WebPageProxy::selectPositionAtBoundaryWithDirection):
(WebKit::WebPageProxy::moveSelectionAtBoundaryWithDirection):
(WebKit::WebPageProxy::selectPositionAtPoint):
(WebKit::WebPageProxy::moveSelectionByOffset):
(WebKit::WebPageProxy::focusNextFocusedElement):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::executeEditCommandWithCallback):
(WebKit::WebPage::setInitialFocus):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::moveSelectionByOffset):
(WebKit::WebPage::selectPositionAtPoint):
(WebKit::WebPage::selectPositionAtBoundaryWithDirection):
(WebKit::WebPage::moveSelectionAtBoundaryWithDirection):
(WebKit::WebPage::selectTextWithGranularityAtPoint):
(WebKit::WebPage::focusNextFocusedElement):

10:05 AM Changeset in webkit [260763] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

Unreviewed sandbox compile fix.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

9:47 AM Changeset in webkit [260762] by Darin Adler

• 2 edits in trunk/Source/WebCore

Improve performance of commonInclusiveAncestor for deeply nested nodes
​https://bugs.webkit.org/show_bug.cgi?id=211078

Reviewed by Antti Koivisto.

• dom/Node.cpp:

(WebCore::depth): Added.
(WebCore::commonInclusiveAncestor): Replaced implementation that walks the
parent chain of the second node repeatedly with one that walks the parent
chain of each node twice.

9:31 AM Changeset in webkit [260761] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r258730): Web Inspector: Sidebar tabs have incorrect tabIndex
​https://bugs.webkit.org/show_bug.cgi?id=211072
<rdar://problem/62445067>

Reviewed by Brian Burg.

Only selected radio button should be focusable. This matches native macOS radio buttons.

• UserInterface/Views/RadioButtonNavigationItem.js:

(WI.RadioButtonNavigationItem.prototype.get tabbable):
This getter was incorrectly returning -1 or 0 instead of a boolean value.

9:18 AM Changeset in webkit [260760] by commit-queue@webkit.org

• 5 edits in trunk

[GTK] ENABLE(OPENGL) remmants...
​https://bugs.webkit.org/show_bug.cgi?id=211077

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-04-27
Reviewed by Adrian Perez de Castro.

ENABLE(OPENGL) was renamed to ENABLE(GRAPHICS_CONTEXT_GL) in
r254064 but not in all the code base...
.:

• Source/cmake/GStreamerDependencies.cmake:
• Source/cmake/OptionsGTK.cmake:

Source/WebKit:

• UIProcess/gtk/HardwareAccelerationManager.cpp:

(WebKit::HardwareAccelerationManager::HardwareAccelerationManager):

9:08 AM Changeset in webkit [260759] by dbates@webkit.org

• 7 edits in trunk

Caret may be placed in the wrong spot for text input context that is a form control
​https://bugs.webkit.org/show_bug.cgi?id=210939
<rdar://problem/61943089>

Reviewed by Darin Adler.

Source/WebCore:

Add a helper function that returns the closest editable position inside an element
for a given point (if any).

• editing/Editing.cpp:

(WebCore::closestEditablePositionInElementForAbsolutePoint): Added.

• editing/Editing.h:

Source/WebKit:

Find the closest editable position in the element for the point using the
newly introduced closestEditablePositionInElementForAbsolutePoint().

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::focusTextInputContextAndPlaceCaret):

Tools:

Add a test.

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:

(TestWebKitAPI::TEST):

9:04 AM Changeset in webkit [260758] by ap@apple.com

• 2 edits in trunk/Tools

Make run-safari --ios-simulator work again
​https://bugs.webkit.org/show_bug.cgi?id=211008

Reviewed by Darin Adler.

While at it, removed all direct uses of device.plist, and all use of Foundation.

• Scripts/webkitdirs.pm: Stopped exporting unused simulator related functions. New

code should be using webkitpy.
(simulatorDeviceFromJSON): Helper function for parsing simctl output.
(iOSSimulatorDevices): Use simctl instead of reading device.plist.
(createiOSSimulatorDevice): Device creation appears to be synchronous, I couldn't
find any reason for waiting and retrying.
(iosSimulatorApplicationsPath): This is part of the actual fix - runtime path built
here was incorrect; switched to one provided by simctl.
(shutDownIOSSimulatorDevice): Added an early return to avoid stderr spew.
(relaunchIOSSimulator): Another part of the actual fix: open Simulator.app before booting the
simulator to have it visible; CurrentDeviceUDID doesn't work.
(iosSimulatorDeviceByUDID): Stop using device.plist.
(runIOSWebKitAppInSimulator): Stop quitting Simulator.app, we only needed to shut down
the device.
(iOSSimulatorDevicesPath): Deleted.
(quitIOSSimulator): Deleted.

8:54 AM Changeset in webkit [260757] by Darin Adler

• 2 edits in trunk/Source/WebKit

Fix ENABLE(PLATFORM_DRIVEN_TEXT_CHECKING) build

• WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h: Change "class AttributedString" to "struct AttributedString".

8:44 AM Changeset in webkit [260756] by dbates@webkit.org

• 2 edits in trunk/Tools

Text interaction tests should ensure view is not scroll instead of looking for a zoom change
​https://bugs.webkit.org/show_bug.cgi?id=211056

Reviewed by Dean Jackson.

For the text interaction sub-tests, override the scroll view's delegate so as to track
whether a scroll occurred or not instead of looking at the zoom scale. As the tests are
written looking at the zoom scale is racy. It is simpler and deterministic to detect
whether the scroll view scrolled.

The purpose of the text interaction sub-tests are to ensure that zooming to reveal
the focused element is suppressed until the interaction completes with a call to
-_didFinishTextInteractionInTextInputContext. I added some more assertions to ensure this.

• TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:

(-[TextInteractionScrollDelegate scrollViewDidScroll:]):
(TestWebKitAPI::TEST):

8:30 AM Changeset in webkit [260755] by aboya@igalia.com

• 6 edits in trunk

[GStreamer] Rework WebKitWebSrc threading
Source/WebCore:

​https://bugs.webkit.org/show_bug.cgi?id=210284

Reviewed by Xabier Rodriguez-Calvar.

WebKitWebSrc as it is in master has a number of race conditions
leading to occasional starvation (due to cancelling the wrong request)
or data corruption (due to pushing data from a cancelled request).

The threading situation wasn't easy to follow, as it wasn't clear
access to what members should be protected by what mutex, in what
circumstances. Also, some parts of the design were also introducing
addicional complexity, such as the first request being sent from the
main thread whereas the rest were being sent from the streaming thread
or basesrc async start.

In response, this patch reworks all the locking in WebKitWebSrc to use
WTF::DataMutex. This ensures all accesses to its (now explicit)
protected members are locked. The two mutexes and condition variables
have been simplified into one, as there was no obvious need or benefit
for two of each in this case.

Requests have been numbered, which allows to safely and atomically
ignore results from cancelled requests, avoiding data corruption
races, and makes following them in debug logs much easier.

The conditions for making and cancelling requests have been simplified
to a simpler and safer model: There is at most only one active request
at anytime, flushes cancel the request, and the first create() call
always makes the new request (both at startup and after a flush).
Debug asserts and notes about the flow of operations during basesrc
seeks have been provided.

As this effort needed a review of the entire WebKitWebSrc, cleanups,
corrections and documentation comments have been provided where
appropriate.

This patch introduces no visible behavior changes, just stability
improvements.

• platform/graphics/gstreamer/GRefPtrGStreamer.h:
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(WebKitWebSrcPrivate::~WebKitWebSrcPrivate):
(webkit_web_src_class_init):
(webkitWebSrcReset):
(webKitWebSrcConstructed):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(webKitWebSrcSetContext):
(webKitWebSrcSendEvent):
(restartLoaderIfNeeded):
(stopLoaderIfNeeded):
(webKitWebSrcCreate):
(webKitWebSrcStart):
(webKitWebSrcMakeRequest):
(webKitWebSrcStop):
(webKitWebSrcGetSize):
(webKitWebSrcIsSeekable):
(webKitWebSrcDoSeek):
(webKitWebSrcQuery):
(webKitWebSrcUnLock):
(webKitWebSrcUnLockStop):
(webKitWebSrcSetUri):
(webKitWebSrcSetMediaPlayer):
(webKitSrcPassedCORSAccessCheck):
(CachedResourceStreamingClient::CachedResourceStreamingClient):
(CachedResourceStreamingClient::checkUpdateBlocksize):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::dataReceived):
(CachedResourceStreamingClient::accessControlCheckFailed):
(CachedResourceStreamingClient::loadFailed):
(CachedResourceStreamingClient::loadFinished):
(webKitSrcWouldTaintOrigin):

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:

LayoutTests:

​https://bugs.webkit.org/show_bug.cgi?id=209811

Reviewed by Xabier Rodriguez-Calvar.

A test improved its status in TestExpectations from the changes made
in this patch.

• platform/gtk/TestExpectations:

8:27 AM Changeset in webkit [260754] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[WPE] about:gpu page is incomplete
​https://bugs.webkit.org/show_bug.cgi?id=211076

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-04-27
Reviewed by Adrian Perez de Castro.

ENABLE(OPENGL) was renamed to ENABLE(GRAPHICS_CONTEXT_GL) in
r254064 but not in all the code base...

• UIProcess/API/glib/WebKitProtocolHandler.cpp:

(WebKit::WebKitProtocolHandler::handleGPU):

8:05 AM Changeset in webkit [260753] by Darin Adler

• 45 edits in trunk/Source

Replace more uses of live ranges with SimpleRange
​https://bugs.webkit.org/show_bug.cgi?id=211058

Reviewed by Antti Koivisto.

Source/WebCore:

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement const): Use SimpleRange.

• dom/BoundaryPoint.h: Moved makeBoundaryPointAfterNodeContents here so it

can be used more places.

• dom/Node.cpp:

(WebCore::commonInclusiveAncestor): Moved the commonAncestorContainer function
here from Range, decided to use the "inclusive ancestor" naming from the
DOM specification, and used RefPtr for the result since it's part of our modern
safer design to always use smart pointers for return values.

• dom/Node.h: Added commonInclusiveAncestor.

• dom/Position.cpp:

(WebCore::commonShadowIncludingAncestor): Call commonInclusiveAncestor.

• dom/Range.cpp:

(WebCore::Range::commonAncestorContainer): Deleted.
(WebCore::Range::isPointInRange): Call commonInclusiveAncestor.
(WebCore::Range::comparePoint const): Ditto.
(WebCore::Range::compareBoundaryPoints): Ditto.
(WebCore::Range::collectSelectionRectsWithoutUnionInteriorLines const): Ditto.

• dom/Range.h:

(WebCore::Range::commonAncestorContainer const): Call commonInclusiveAncestor.

• dom/SimpleRange.cpp:

(WebCore::makeBoundaryPointAfterNodeContents): Moved to BoundaryPoint.h.

• editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::respondToUnappliedSpellCorrection): Use
SimpleRange instead of live range.
(WebCore::AlternativeTextController::respondToUnappliedEditing): Ditto.
(WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand): Ditto.
(WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult): Ditto.

• editing/ChangeListTypeCommand.cpp:

(WebCore::listConversionTypeForSelection): use commonInclusiveAncestor.

• editing/Editing.cpp:

(WebCore::isNodeVisiblyContainedWithin): Take a SimpleRange argument.

• editing/Editing.h: Updated for the above.

• editing/Editor.cpp:

(WebCore::Editor::addRangeToKillRing): Take a SimpleRange argument.
(WebCore::Editor::shouldDetectTelephoneNumbers const): Made this const and
tweaked coding style a bit.
(WebCore::scanForTelephoneNumbers): Moved this, made it a non-member function,
renamed from scanRangeForTelephoneNumbers, use SimpleRange.
(WebCore::extendSelection): Added. Factored out some logic from the function below.
(WebCore::Editor::scanSelectionForTelephoneNumbers): Use SimpleRange. Removed
some unnecessary code that subtracts 1 and then adds 1 again.

• editing/Editor.h: Updated for the above.

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::replace): Use commonInclusiveAncestor.

• editing/VisibleSelection.cpp:

(WebCore::makeSearchRange): Return a SimpleRange.
(WebCore::VisibleSelection::appendTrailingWhitespace): Use SimpleRange.

• editing/WebContentReader.h: Use SimpleRange instead of a live range.

• editing/cocoa/DataDetection.h: Use a struct, DetectedItem, for the return value

from the detection functions. Also changed DataDetectorTypes to an enum class so
it can be forward-declared instead of having to include this header.

• editing/cocoa/DataDetection.mm:

(WebCore::detectItem): Renamed from detectItemAtPositionWithRange. Return the
DetectedItem struct, with a SimpleRange rather than an out argument live range.
(WebCore::DataDetection::detectItemAroundHitTestResult): Ditto.
(WebCore::contains): Added a helper function for testing bits in the
DataDetectorType enum. Later we can make this better using OptionSet.
(WebCore::constructURLStringForResult): Refactored a bit, updated for the new
DataDetectorTypes enum class, and to use CFEqual instead of CFStringCompare.
(WebCore::DataDetection::detectContentInRange): Ditto.

• editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::webContentFromPasteboard): Use SimpleRange.

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::WebContentReader::readPlainText): Updated since context is SimpleRange.

• editing/gtk/EditorGtk.cpp:

(WebCore::createFragmentFromPasteboardData): Use SimpleRange.
(WebCore::Editor::webContentFromPasteboard): Use SimpleRange.

• editing/win/EditorWin.cpp:

(WebCore::Editor::webContentFromPasteboard): Use SimpleRange.

• editing/mac/EditorMac.mm:

(WebCore::Editor::replaceNodeFromPasteboard): Use SimpleRange.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Use SimpleRange.

• page/EventHandler.cpp:

(WebCore::targetNodeForClickEvent): Use commonInclusiveAncestor. Also updated
to return a RefPtr.
(WebCore::EventHandler::handleMouseReleaseEvent): Updated for the above.

• page/Settings.yaml: Changed the default for DataDetectorTypes to be the empty

string rather than a named constant.

• page/SettingsBase.h: Forward-declare DataDetectorTypes instead of including

the DataDetection.h header.

• page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithRange): Take a SimpleRange.
(WebCore::TextIndicator::createWithSelectionInFrame): Ditto.
(WebCore::hasNonInlineOrReplacedElements): Ditto.
(WebCore::selectionRects): Ditto. Also renamed from getSelectionRectsForRange.
(WebCore::styleContainsComplexBackground): Tweaked implementation.
(WebCore::estimatedTextColorsForRange): Take a SimpleRange.
(WebCore::absoluteBoundingRectForRange): Ditto.
(WebCore::estimatedBackgroundColorForRange): Ditto.
(WebCore::containsOnlyWhiteSpaceText): Ditto.
(WebCore::initializeIndicator): Ditto.

• page/TextIndicator.h: Updated for the above.

• page/mac/ServicesOverlayController.h: Use SimpleRange instead of a live

range for highlights.

• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::createForSelection): Take SimpleRange.
(WebCore::ServicesOverlayController::Highlight::createForTelephoneNumber): Ditto.
(WebCore::ServicesOverlayController::Highlight::Highlight): Ditto.
(WebCore::ServicesOverlayController::buildPhoneNumberHighlights): Ditto.
(WebCore::ServicesOverlayController::buildSelectionHighlight): Ditto.
(WebCore::ServicesOverlayController::telephoneNumberRangesForFocusedFrame): Ditto.
(WebCore::ServicesOverlayController::highlightsAreEquivalent): Ditto.
(WebCore::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight): Ditto.
(WebCore::ServicesOverlayController::handleClick): Ditto.

• platform/ios/DragImageIOS.mm:

(WebCore::createDragImageForLink): Use SimpleRange.
(WebCore::createDragImageForSelection): Tweaked a bit.

Source/WebKit:

• Shared/API/Cocoa/WKDataDetectorTypesInternal.h:

(fromWKDataDetectorTypes): Updated since DataDetectorTypes
is now an enum class. Also got rid of special "none" and "all" values.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:

(-[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]): Updated
since DataDetection now takes a SimpleRange.

• WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::computeTextLegibilityScales):
Use SimpleRange.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::detectDataInAllFrames): Ditto.

• WebProcess/WebPage/WebPage.h: Removed unneeded include of DataDetection.h.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performImmediateActionHitTestAtLocation): Use SimpleRange.

Source/WebKitLegacy/mac:

• DOM/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]): Use SimpleRange.

• WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::imageForCurrentSharingServicePickerItem): Ditto.

• WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _animationControllerForDataDetectedText]):
Updated to use DetectedItem and SimpleRange.
(+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
Ditto.

6:10 AM Changeset in webkit [260752] by Carlos Garcia Campos

• 113 edits
  4 copies
  2 moves
  2 adds in trunk

[GTK4] Make it possible to build with GTK4 without errors
​https://bugs.webkit.org/show_bug.cgi?id=210967

Reviewed by Adrian Perez de Castro.

.:

Disable API tests and GObject introspection when building with GTK4.

• Source/cmake/OptionsGTK.cmake:

Source/WebCore:

• platform/PlatformPasteboard.h:
• platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::createDefaultDisplayRefreshMonitor):

• platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp:
• platform/graphics/gtk/DisplayRefreshMonitorGtk.h:
• platform/graphics/gtk/GdkCairoUtilities.cpp:

(WebCore::getDefaultCairoFontOptions):

• platform/gtk/CursorGtk.cpp:

(WebCore::createCustomCursor):

• platform/gtk/DragImageGtk.cpp:

(WebCore::dissolveDragImageToFraction):

• platform/gtk/GRefPtrGtk.cpp:
• platform/gtk/GRefPtrGtk.h:
• platform/gtk/GUniquePtrGtk.h:
• platform/gtk/GtkVersioning.h:

(gdk_event_copy):
(gtk_widget_size_allocate):
(gtk_widget_queue_resize_no_redraw):
(gdk_event_get_state):
(gdk_event_get_coords):
(gdk_event_get_root_coords):
(gdk_event_is_scroll_stop_event):
(gdk_event_get_scroll_direction):
(gdk_event_get_scroll_deltas):
(gdk_event_get_button):

• platform/gtk/PasteboardHelper.cpp:
• platform/gtk/PasteboardHelper.h:
• platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::modifiersContainCapsLock):

• platform/gtk/PlatformPasteboardGtk.cpp:

(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::writeToClipboard):
(WebCore::PlatformPasteboard::readFromClipboard):

• platform/gtk/PlatformScreenGtk.cpp:

(WebCore::getCurrentScreenMonitor):

Source/WebKit:

Add ifdefs when needed to make it possible to complete a build with GTK4. This way we can continue working on
every feature individually and checking it actually works. Move public headers containing API specific to GTK3
and GTK4 into their own gtk3 and gtk4 directory.

• PlatformGTK.cmake:
• Shared/API/glib/WebKitContextMenuItem.cpp:
• Shared/NativeWebKeyboardEvent.h:
• Shared/NativeWebMouseEvent.h:
• Shared/NativeWebWheelEvent.h:
• Shared/glib/WebContextMenuItemGlib.cpp:

(WebKit::WebContextMenuItemGlib::WebContextMenuItemGlib):
(WebKit::WebContextMenuItemGlib::buildActionName const):
(WebKit::WebContextMenuItemGlib::createActionIfNeeded):

• Shared/glib/WebContextMenuItemGlib.h:
• Shared/gtk/NativeWebKeyboardEventGtk.cpp:
• Shared/gtk/NativeWebMouseEventGtk.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

• Shared/gtk/NativeWebTouchEventGtk.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

• Shared/gtk/NativeWebWheelEventGtk.cpp:
• Shared/gtk/WebEventFactory.cpp:

(WebKit::buttonForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

• Shared/gtk/WebEventFactory.h:
• SourcesGTK.txt:
• UIProcess/API/C/WKNativeEvent.h:
• UIProcess/API/glib/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::filterKeyEvent):

• UIProcess/API/glib/InputMethodFilter.h:
• UIProcess/API/glib/WebKitInstallMissingMediaPluginsPermissionRequest.cpp:

(createGstInstallPluginsContext):

• UIProcess/API/glib/WebKitPrivate.cpp:
• UIProcess/API/glib/WebKitUIClient.cpp:

(UIClient::setWindowFrameTimerFired):

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextGetProperty):
(webkitWebContextSetProperty):
(webkit_web_context_class_init):

• UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewRunAsModal):
(webkitWebViewPopulateContextMenu):

• UIProcess/API/gtk/InputMethodFilterGtk.cpp:

(WebKit::InputMethodFilter::platformEventKeyIsKeyPress const):

• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::setCursor):
(WebKit::PageClientImpl::doneWithKeyEvent):
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createDataListSuggestionsDropdown):
(WebKit::PageClientImpl::startDrag):
(WebKit::PageClientImpl::doneWithTouchEvent):
(WebKit::PageClientImpl::wheelEventWasNotHandledByWebCore):

• UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
• UIProcess/API/gtk/WebKitAuthenticationDialog.h:
• UIProcess/API/gtk/WebKitEmojiChooser.cpp:
• UIProcess/API/gtk/WebKitEmojiChooser.h:
• UIProcess/API/gtk/WebKitInputMethodContextGtk.cpp:

(webkit_input_method_context_filter_key_event):

• UIProcess/API/gtk/WebKitInputMethodContextImplGtk.cpp:

(webkitInputMethodContextImplGtkFilterKeyEvent):
(webkitInputMethodContextImplGtkSetClientWindow):

• UIProcess/API/gtk/WebKitPopupMenu.cpp:

(WebKit::WebKitPopupMenu::WebKitPopupMenu):
(WebKit::WebKitPopupMenu::showPopupMenu):
(WebKit::WebKitPopupMenu::hidePopupMenu):
(WebKit::WebKitPopupMenu::cancelTracking):

• UIProcess/API/gtk/WebKitPopupMenu.h:
• UIProcess/API/gtk/WebKitPrintOperation.cpp:
• UIProcess/API/gtk/WebKitScriptDialogGtk.cpp:

(webkitScriptDialogAccept):
(webkitScriptDialogDismiss):
(webkitScriptDialogSetUserInput):

• UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:
• UIProcess/API/gtk/WebKitScriptDialogImpl.h:
• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(ClickCounter::currentClickCountForGdkButtonEvent):
(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate):
(webkitWebViewBaseSetToplevelOnScreenWindow):
(webkitWebViewBaseRealize):
(webkitWebViewBaseContainerForall):
(webkitWebViewBaseDispose):
(webkitWebViewBaseConstructed):
(webkitWebViewBaseSizeAllocate):
(webkitWebViewBaseKeyPressEvent):
(webkitWebViewBaseKeyReleaseEvent):
(webkitWebViewBaseSetEnableBackForwardNavigationGesture):
(webkitWebViewBaseBeginBackSwipeForTesting):
(webkitWebViewBaseCompleteBackSwipeForTesting):
(webkit_web_view_base_class_init):
(webkitWebViewBaseWillSwapWebProcess):
(webkitWebViewBaseDidExitWebProcess):
(webkitWebViewBaseDidRelaunchWebProcess):
(webkitWebViewBaseTakeViewSnapshot):
(webkitWebViewBaseDidStartProvisionalLoadForMainFrame):
(webkitWebViewBaseDidFirstVisuallyNonEmptyLayoutForMainFrame):
(webkitWebViewBaseDidFinishLoadForMainFrame):
(webkitWebViewBaseDidFailLoadForMainFrame):
(webkitWebViewBaseDidSameDocumentNavigationForMainFrame):
(webkitWebViewBaseDidRestoreScrollPosition):
(webkitWebViewBaseShowEmojiChooser):
(webkitWebViewBaseRequestPointerLock):
(webkitWebViewBaseDidLosePointerLock):
(webkitWebViewBaseSynthesizeCompositionKeyPress):

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/API/gtk/WebKitWebViewDialog.cpp:
• UIProcess/API/gtk/WebKitWebViewDialog.h:
• UIProcess/API/gtk/WebKitWebViewGtk.cpp:

(webkitWebViewAuthenticate):
(webkitWebViewScriptDialog):
(webkitWebViewRunFileChooser):
(webkitWebViewMaximizeWindow):
(webkitWebViewMinimizeWindow):
(webkitWebViewRestoreWindow):

• UIProcess/API/gtk3/WebKitContextMenuItem.h: Copied from Source/WebKit/UIProcess/API/gtk/WebKitContextMenuItem.h.
• UIProcess/API/gtk3/WebKitInputMethodContext.h: Copied from Source/WebKit/UIProcess/API/gtk/WebKitInputMethodContext.h.
• UIProcess/API/gtk4/WebKitContextMenuItem.h: Renamed from Source/WebKit/UIProcess/API/gtk/WebKitContextMenuItem.h.
• UIProcess/API/gtk4/WebKitInputMethodContext.h: Renamed from Source/WebKit/UIProcess/API/gtk/WebKitInputMethodContext.h.
• UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):
(WebKit::WebAutomationSession::platformSimulateKeySequence):

• UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp:

(WebKit::RemoteWebInspectorProxy::platformSave):

• UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformSave):

• UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp:

(webkit_inspector_window_init):
(webkitInspectorWindowNew):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::createBackend):

• UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:

(WebKit::AcceleratedBackingStoreWayland::tryEnsureGLContext):
(WebKit::AcceleratedBackingStoreWayland::paint):

• UIProcess/gtk/AcceleratedBackingStoreX11.cpp:

(WebKit::AcceleratedBackingStoreX11::~AcceleratedBackingStoreX11):
(WebKit::AcceleratedBackingStoreX11::update):

• UIProcess/gtk/DragAndDropHandler.cpp:
• UIProcess/gtk/DragAndDropHandler.h:
• UIProcess/gtk/GestureController.cpp:
• UIProcess/gtk/GestureController.h:
• UIProcess/gtk/KeyBindingTranslator.cpp:

(WebKit::KeyBindingTranslator::KeyBindingTranslator):
(WebKit::KeyBindingTranslator::commandsForKeyEvent):

• UIProcess/gtk/KeyBindingTranslator.h:
• UIProcess/gtk/PointerLockManager.cpp:

(WebKit::PointerLockManager::lock):
(WebKit::PointerLockManager::unlock):

• UIProcess/gtk/PointerLockManager.h:
• UIProcess/gtk/PointerLockManagerWayland.cpp:

(WebKit::PointerLockManagerWayland::lock):

• UIProcess/gtk/PointerLockManagerX11.cpp:

(WebKit::PointerLockManagerX11::didReceiveMotionEvent):

• UIProcess/gtk/WebColorPickerGtk.cpp:
• UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::show):
(WebKit::WebContextMenuProxyGtk::showContextMenuWithItems):
(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk):
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):

• UIProcess/gtk/WebContextMenuProxyGtk.h:
• UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:
• UIProcess/gtk/WebDataListSuggestionsDropdownGtk.h:
• UIProcess/gtk/WebPageProxyGtk.cpp:
• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
• UIProcess/gtk/WebPopupMenuProxyGtk.h:
• WebProcess/Plugins/PluginController.h:
• WebProcess/Plugins/PluginView.cpp:
• WebProcess/Plugins/PluginView.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
(WebKit::WebPage::mainFrameDidLayout):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/gtk/AcceleratedSurfaceX11.cpp:

(WebKit::AcceleratedSurfaceX11::AcceleratedSurfaceX11):
(WebKit::AcceleratedSurfaceX11::createPixmap):

• WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::print):

Tools:

• MiniBrowser/gtk/BrowserCellRendererVariant.c:
• MiniBrowser/gtk/BrowserCellRendererVariant.h:
• MiniBrowser/gtk/BrowserDownloadsBar.c:
• MiniBrowser/gtk/BrowserDownloadsBar.h:
• MiniBrowser/gtk/BrowserMain.c: Added.

(browser_main):
(browser_main_quit):

• MiniBrowser/gtk/BrowserMain.h: Added.
• MiniBrowser/gtk/BrowserSearchBar.c:
• MiniBrowser/gtk/BrowserSearchBar.h:
• MiniBrowser/gtk/BrowserSettingsDialog.c:
• MiniBrowser/gtk/BrowserSettingsDialog.h:
• MiniBrowser/gtk/BrowserTab.c:

(browserTabConstructed):
(browser_tab_start_search):
(browser_tab_stop_search):
(browser_tab_enter_fullscreen):
(browser_tab_leave_fullscreen):

• MiniBrowser/gtk/BrowserTab.h:
• MiniBrowser/gtk/BrowserWindow.c:

(webViewURIChanged):
(resetEntryProgress):
(webViewLoadProgressChanged):
(downloadStarted):
(browserWindowUpdateNavigationActions):
(webViewReadyToShow):
(browserWindowUpdateZoomActions):
(webViewZoomLevelChanged):
(updateUriEntryIcon):
(webViewIsLoadingChanged):
(browserWindowFinalize):
(browserWindowSetupEditorToolbar):
(browserWindowSwitchTab):
(browser_window_init):
(browser_window_class_init):
(browser_window_new):
(browser_window_append_view):
(browser_window_set_background_color):
(browser_window_get_or_create_web_view_for_automation):

• MiniBrowser/gtk/CMakeLists.txt:
• MiniBrowser/gtk/main.c:

(main):

• PlatformGTK.cmake:
• Scripts/webkitpy/style/checker.py:
• TestWebKitAPI/glib/PlatformGTK.cmake:

5:55 AM Changeset in webkit [260751] by commit-queue@webkit.org

• 17 edits in trunk/Source

Make loadURLIntoChildFrame private and non-exported
​https://bugs.webkit.org/show_bug.cgi?id=211051

Patch by Rob Buis <​rbuis@igalia.com> on 2020-04-27
Reviewed by Darin Adler.

Source/WebCore:

Make loadURLIntoChildFrame private and non-exported to reduce the amount of public API functions
that start loads. In order to do this loadURLIntoChildFrame is being called from SubframeLoader
and SubframeLoader is made an inner class of FrameLoader. Because this simplifies createFrame (and
makes createFrame behave strictly like its name) url and referrer do not have to be passed.

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin):

• loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::createFrame):

• loader/EmptyFrameLoaderClient.h:
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/SubframeLoader.cpp:

(WebCore::FrameLoader::SubframeLoader::SubframeLoader):
(WebCore::FrameLoader::SubframeLoader::clear):
(WebCore::FrameLoader::SubframeLoader::requestFrame):
(WebCore::FrameLoader::SubframeLoader::resourceWillUsePlugin):
(WebCore::FrameLoader::SubframeLoader::pluginIsLoadable):
(WebCore::FrameLoader::SubframeLoader::requestPlugin):
(WebCore::FrameLoader::SubframeLoader::requestObject):
(WebCore::FrameLoader::SubframeLoader::createJavaAppletWidget):
(WebCore::FrameLoader::SubframeLoader::loadOrRedirectSubframe):
(WebCore::FrameLoader::SubframeLoader::loadSubframe):
(WebCore::FrameLoader::SubframeLoader::shouldUsePlugin):
(WebCore::FrameLoader::SubframeLoader::loadPlugin):
(WebCore::FrameLoader::SubframeLoader::completeURL const):
(WebCore::FrameLoader::SubframeLoader::shouldConvertInvalidURLsToBlank const):
(WebCore::SubframeLoader::SubframeLoader): Deleted.
(WebCore::SubframeLoader::clear): Deleted.
(WebCore::SubframeLoader::requestFrame): Deleted.
(WebCore::SubframeLoader::resourceWillUsePlugin): Deleted.
(WebCore::SubframeLoader::pluginIsLoadable): Deleted.
(WebCore::SubframeLoader::requestPlugin): Deleted.
(WebCore::SubframeLoader::requestObject): Deleted.
(WebCore::SubframeLoader::createJavaAppletWidget): Deleted.
(WebCore::SubframeLoader::loadOrRedirectSubframe): Deleted.
(WebCore::SubframeLoader::loadSubframe): Deleted.
(WebCore::SubframeLoader::shouldUsePlugin): Deleted.
(WebCore::SubframeLoader::loadPlugin): Deleted.
(WebCore::SubframeLoader::completeURL const): Deleted.
(WebCore::SubframeLoader::shouldConvertInvalidURLsToBlank const): Deleted.

• loader/SubframeLoader.h:

(WebCore::SubframeLoader::containsPlugins const): Deleted.

Source/WebKit:

Adapt createFrame to strictly create a subframe and
not load anything.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createFrame):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

Adapt createFrame to strictly create a subframe and
not load anything.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::createFrame):

Source/WebKitLegacy/win:

Adapt createFrame to strictly create a subframe and
not load anything.

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::createFrame):

• WebCoreSupport/WebFrameLoaderClient.h:

4:53 AM WebKitGTK/2.28.x edited by berto@igalia.com

(diff)

4:52 AM Changeset in webkit [260750] by berto@igalia.com

• 2 edits in trunk/Source/WebCore

[GTK] [2.28.0] The Yelp build crashes if DISPLAY is not set
​https://bugs.webkit.org/show_bug.cgi?id=209431

Reviewed by Carlos Garcia Campos.

Don't create a PlatformDisplayLibWPE as a fallback when using
Wayland or X11.

• platform/graphics/PlatformDisplay.cpp:

(WebCore::PlatformDisplay::createPlatformDisplay):

3:45 AM Changeset in webkit [260749] by Claudio Saavedra

• 2 edits in trunk/Source/WebCore

Unreviewed compile-warning fix.

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):

3:24 AM Changeset in webkit [260748] by Diego Pino Garcia

• 2 edits in trunk/Source/WebCore

Unreviewed, GTK LTS build fix after r260744
​https://bugs.webkit.org/show_bug.cgi?id=211069

• bindings/js/JSDOMBuiltinConstructor.h:

(WebCore::JSDOMBuiltinConstructor<JSClass>::getConstructData):

3:00 AM Changeset in webkit [260747] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak SDK] Regenerate toolchains only if new updates were downloaded
​https://bugs.webkit.org/show_bug.cgi?id=210804

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-04-27
Reviewed by Žan Doberšek.

The SDK toolchain archives are now regenerated only if an actual
update was downloaded from the Flatpak repository. Some redundant
flatpak calls were removed as well, such as the GL extension and
Debug reinstalls that were happening during webkit-flatpak
updates.

• flatpak/flatpakutils.py:

(FlatpakObject.flatpak):
(FlatpakRepo.init):
(WebkitFlatpak.main):
(WebkitFlatpak.setup_dev_env):

2:57 AM Changeset in webkit [260746] by commit-queue@webkit.org

• 2 edits in trunk/Tools

unable to build from tot - linux - flatpakutils.py - TypeError: not enough arguments for format string
​https://bugs.webkit.org/show_bug.cgi?id=210941

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-04-27
Reviewed by Žan Doberšek.

• flatpak/flatpakutils.py:

(check_flatpak): Fix error message formating.

2:43 AM Changeset in webkit [260745] by Claudio Saavedra

• 2 edits in trunk/Source/WebCore

[GTK4] GdkRGBA has float members instead of double

Unreviewed warning fix.

• platform/graphics/gtk/ColorGtk.cpp:

(WebCore::Color::operator GdkRGBA const):

2:09 AM Changeset in webkit [260744] by Ross Kirsling

• 108 edits in trunk/Source

[JSC] CallData/ConstructData should include CallType/ConstructType
​https://bugs.webkit.org/show_bug.cgi?id=211059

Reviewed by Darin Adler.

Source/JavaScriptCore:

getCallData/getConstructData return a CallType/ConstructType and have a CallData/ConstructData out param,
and then *both* of these are passed side-by-side to call/construct, which all seems a bit silly.

This patch merges CallType/ConstructType into CallData/ConstructData such that getCallData/getConstructData
no longer need an out param and call/construct require one less overt parameter.

In so doing, it also:

• removes ConstructData entirely as it's an exact duplicate of CallData
• renames enum value Host to Native in alignment with CallData's union

• API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::getConstructData):

• API/JSCallbackConstructor.h:
• API/JSCallbackObject.h:
• API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::getConstructData):
(JSC::JSCallbackObject<Parent>::getCallData):

• API/JSObjectRef.cpp:

(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):

• bindings/ScriptFunctionCall.cpp:

(Deprecated::ScriptFunctionCall::call):

• bindings/ScriptFunctionCall.h:
• dfg/DFGOperations.cpp:
• inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::createInjectedScript):

• inspector/InspectorEnvironment.h:
• interpreter/Interpreter.cpp:

(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):

• interpreter/Interpreter.h:
• jit/JITOperations.cpp:
• jsc.cpp:

(functionDollarAgentReceiveBroadcast):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall):

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):

• runtime/CallData.cpp:

(JSC::call):
(JSC::profiledCall):

• runtime/CallData.h:
• runtime/ClassInfo.h:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/ConstructData.cpp:

(JSC::construct):
(JSC::profiledConstruct):

• runtime/ConstructData.h:

(JSC::construct):
(JSC::profiledConstruct):
(): Deleted.

• runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToJSON):

• runtime/GetterSetter.cpp:

(JSC::callGetter):
(JSC::callSetter):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::getCallData):
(JSC::InternalFunction::getConstructData):

• runtime/InternalFunction.h:
• runtime/IteratorOperations.cpp:

(JSC::iteratorNext):
(JSC::iteratorClose):
(JSC::hasIteratorMethod):
(JSC::iteratorMethod):
(JSC::iteratorForIterable):

• runtime/JSBoundFunction.cpp:

(JSC::boundThisNoArgsFunctionCall):
(JSC::boundFunctionCall):
(JSC::boundThisNoArgsFunctionConstruct):
(JSC::boundFunctionConstruct):

• runtime/JSCJSValue.h:
• runtime/JSCell.cpp:

(JSC::JSCell::getCallData):
(JSC::JSCell::getConstructData):

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::isFunction):
(JSC::JSCell::isConstructor):

• runtime/JSFunction.cpp:

(JSC::JSFunction::getCallData):
(JSC::JSFunction::getConstructData):

• runtime/JSFunction.h:
• runtime/JSInternalPromise.cpp:

(JSC::JSInternalPromise::then):

• runtime/JSMicrotask.cpp:

(JSC::JSMicrotask::run):

• runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::dependencyKeysIfEvaluated):
(JSC::JSModuleLoader::provideFetch):
(JSC::JSModuleLoader::loadAndEvaluateModule):
(JSC::JSModuleLoader::loadModule):
(JSC::JSModuleLoader::linkAndEvaluateModule):
(JSC::JSModuleLoader::requestImportModule):

• runtime/JSONObject.cpp:

(JSC::Stringifier::isCallableReplacer const):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::Walker):
(JSC::Walker::callReviver):
(JSC::JSONProtoFuncParse):

• runtime/JSObject.cpp:

(JSC::ordinarySetSlow):
(JSC::callToPrimitiveFunction):
(JSC::JSObject::hasInstance):
(JSC::JSObject::getMethod):

• runtime/JSObject.h:
• runtime/JSObjectInlines.h:

(JSC::getCallData):
(JSC::getConstructData):

• runtime/JSPromise.cpp:

(JSC::JSPromise::createDeferredData):
(JSC::JSPromise::resolvedPromise):
(JSC::callFunction):

• runtime/MapConstructor.cpp:

(JSC::constructMap):

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToLocaleString):

• runtime/ProxyObject.cpp:

(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::ProxyObject::performHasProperty):
(JSC::ProxyObject::performPut):
(JSC::performProxyCall):
(JSC::ProxyObject::getCallData):
(JSC::performProxyConstruct):
(JSC::ProxyObject::getConstructData):
(JSC::ProxyObject::performDelete):
(JSC::ProxyObject::performPreventExtensions):
(JSC::ProxyObject::performIsExtensible):
(JSC::ProxyObject::performDefineOwnProperty):
(JSC::ProxyObject::performGetOwnPropertyNames):
(JSC::ProxyObject::performSetPrototype):
(JSC::ProxyObject::performGetPrototype):

• runtime/ProxyObject.h:
• runtime/ReflectObject.cpp:

(JSC::reflectObjectConstruct):

• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::processUnverifiedStackTraces):

• runtime/SetConstructor.cpp:

(JSC::constructSet):

• runtime/StringPrototype.cpp:

(JSC::replaceUsingRegExpSearch):
(JSC::operationStringProtoFuncReplaceRegExpEmptyStr):
(JSC::operationStringProtoFuncReplaceRegExpString):
(JSC::replaceUsingStringSearch):

• runtime/VM.cpp:

(JSC::VM::callPromiseRejectionCallback):

• runtime/WeakMapConstructor.cpp:

(JSC::constructWeakMap):

• runtime/WeakSetConstructor.cpp:

(JSC::constructWeakSet):

• tools/JSDollarVM.cpp:

(JSC::callWithStackSizeProbeFunction):

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::evaluate):

• wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::callWebAssemblyWrapperFunction):

Source/WebCore:

• Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::installReplacement):

• bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

• bindings/js/JSCustomElementInterface.cpp:

(WebCore::constructCustomElementSynchronously):
(WebCore::JSCustomElementInterface::upgradeElement):
(WebCore::JSCustomElementInterface::invokeCallback):

• bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

• bindings/js/JSDOMBuiltinConstructor.h:

(WebCore::JSDOMBuiltinConstructor<JSClass>::getConstructData):

• bindings/js/JSDOMBuiltinConstructorBase.cpp:

(WebCore::JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments):

• bindings/js/JSDOMConstructor.h:

(WebCore::JSDOMConstructor<JSClass>::getConstructData):

• bindings/js/JSDOMConstructorBase.cpp:

(WebCore::JSDOMConstructorBase::getCallData):

• bindings/js/JSDOMConstructorBase.h:
• bindings/js/JSDOMConstructorNotConstructable.h:
• bindings/js/JSDOMIterator.h:

(WebCore::iteratorForEach):

• bindings/js/JSDOMMapLike.cpp:

(WebCore::clearBackingMap):
(WebCore::setToBackingMap):
(WebCore::forwardFunctionCallToBackingMap):
(WebCore::forwardForEachCallToBackingMap):

• bindings/js/JSDOMNamedConstructor.h:

(WebCore::JSDOMNamedConstructor<JSClass>::getConstructData):

• bindings/js/JSDOMPromise.cpp:

(WebCore::DOMPromise::whenPromiseIsSettled):

• bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::createRejectedPromiseWithTypeError):

• bindings/js/JSDOMSetLike.cpp:

(WebCore::clearBackingSet):
(WebCore::addToBackingSet):
(WebCore::forwardFunctionCallToBackingSet):
(WebCore::forwardForEachCallToBackingSet):

• bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

• bindings/js/JSExecState.cpp:

(WebCore::functionCallHandlerFromAnyThread):

• bindings/js/JSExecState.h:

(WebCore::JSExecState::call):
(WebCore::JSExecState::profiledCall):

• bindings/js/JSExecStateInstrumentation.h:

(WebCore::JSExecState::instrumentFunction):
(WebCore::JSExecState::instrumentFunctionInternal): Deleted.
(WebCore::JSExecState::instrumentFunctionCall): Deleted.
(WebCore::JSExecState::instrumentFunctionConstruct): Deleted.

• bindings/js/JSNavigatorCustom.cpp:

(WebCore::JSNavigator::getUserMedia):

• bindings/js/JSPluginElementFunctions.cpp:

(WebCore::callPlugin):
(WebCore::pluginElementCustomGetCallData):

• bindings/js/JSPluginElementFunctions.h:
• bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::create):
(WebCore::ReadableStreamInternal::callFunction):
(WebCore::ReadableStream::lock):

• bindings/js/ReadableStreamDefaultController.cpp:

(WebCore::readableStreamCallFunction):

• bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::executeFunctionInContext):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::callInWorld):
(WebCore::ScriptController::executeAsynchronousUserAgentScriptInWorld):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GeneratePluginCall):
(GenerateLegacyCallerDefinitions):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::getCallData):

• bindings/scripts/test/JS/JSTestObj.h:
• bindings/scripts/test/JS/JSTestPluginInterface.cpp:

(WebCore::JSTestPluginInterface::getCallData):

• bindings/scripts/test/JS/JSTestPluginInterface.h:
• bridge/NP_jsobject.cpp:
• bridge/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):

• bridge/objc/objc_runtime.h:
• bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getCallData):

• bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getCallData):
(JSC::Bindings::RuntimeObject::getConstructData):

• bridge/runtime_object.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateCaptionContainer):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):
(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):

• testing/Internals.cpp:

(WebCore::Internals::cloneArrayBuffer):

Source/WebKit:

• WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getCallData):
(WebKit::JSNPObject::getConstructData):

• WebProcess/Plugins/Netscape/JSNPObject.h:
• WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::hasMethod):
(WebKit::NPJSObject::construct):
(WebKit::NPJSObject::invoke):

Source/WebKitLegacy/mac:

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):

Source/WebKitLegacy/win:

• Plugins/PluginPackage.cpp:

(WebCore::NPN_Invoke):

12:40 AM Changeset in webkit [260743] by Diego Pino Garcia

• 14 edits
  3 deletes in trunk

Unreviewed, reverting r260672.

[GTK] WebInspector tests are timing out after r260672

Reverted changeset:

"[Win] Bundle Inspector Resources in Release builds"
​https://bugs.webkit.org/show_bug.cgi?id=210942
​https://trac.webkit.org/changeset/260672

12:37 AM Changeset in webkit [260742] by Diego Pino Garcia

• 2 edits in trunk/Source/WebInspectorUI

Unreviewed, reverting r260728.

Build fix after r260672, no needed since r260672 is also being reverted.

Reverted changeset:

"[Win] Fix windows build with MSBuild after 260672"
​https://bugs.webkit.org/show_bug.cgi?id=211047
​https://trac.webkit.org/changeset/260728

12:35 AM Changeset in webkit [260741] by Diego Pino Garcia

• 4 edits in trunk/Source

Unreviewed, reverting r260696.

Build fix after r260672, no needed since r260672 is also being reverted.

Reverted changeset:

"REGRESSION(210942): [GTK][WPE] Unreviewed, EWS build bots
fail in compile-webkit step"
​https://bugs.webkit.org/show_bug.cgi?id=211014
​https://trac.webkit.org/changeset/260696

12:04 AM Changeset in webkit [260740] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Build failure in WebGL2RenderingContext after r260588
​https://bugs.webkit.org/show_bug.cgi?id=211057

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-04-27
Reviewed by Darin Adler.

Fix non-ANGLE build failure in WebGL2RenderingContext after
r260588.

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::texStorage2D):

Apr 26, 2020:

10:12 PM Changeset in webkit [260739] by Darin Adler

• 42 edits
  1 move
  1 delete in trunk/Source

[Cocoa] stop using out arguments for document attributes when converting to attributed strings
​https://bugs.webkit.org/show_bug.cgi?id=211048

Reviewed by Sam Weinig.

Source/WebCore:

• DerivedSources-input.xcfilelist: Building modified this file automatically. Uploading

the new version.

• WebCore.xcodeproj/project.pbxproj: Added AttributedString.h.
• editing/cocoa/AttributedString.h: Added. Moved this from WebKit, but removed a lot of

inessentials.

• editing/cocoa/DictionaryLookup.mm: Removed unneeded include.
• editing/cocoa/EditorCocoa.mm:

(WebCore::selectionAsAttributedString): Updated for change to the return value of the
attributedString function, and use init instead of initWithString:@"".

• editing/cocoa/HTMLConverter.h: Changed to an Objective-C-only header, omitting things

like #pramga once. Return the AttributedString struct from the functions instead of
using an out argument for document attributes.

• editing/cocoa/HTMLConverter.mm:

(HTMLConverter::convert): Return an AttributedString and drop the out argument.
(WebCore::attributedString): Ditto.
(WebCore::editingAttributedString): Ditto. Also refactor a little bit.

• editing/ios/EditorIOS.mm: Removed unneeded include.
• editing/mac/DictionaryLookupLegacy.mm: Removed unneeded include.

• editing/mac/EditorMac.mm:

(WebCore::Editor::dataSelectionForPasteboard): Updated since attributedString
now returns a structure.

• platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::policyProperties): Use init instead of initWithString:@"".

• platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::siteForCookies): Use init instead of initWithString:@"".

Source/WebKit:

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::updateTaskWithFirstPartyForSameSiteCookies): Use init instead of initWithString:@"".

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::AttributedString>::encode): Moved here from AttributedString.mm.
(IPC::ArgumentCoder<WebCore::AttributedString>::decode): Ditto.

• Shared/DocumentEditingContext.h: Updated to use WebCore::AttributeString.
• Shared/DocumentEditingContext.mm:

(IPC::ArgumentCoder<WebKit::DocumentEditingContext>::decode): Ditto.

• Shared/WebCoreArgumentCoders.h: Added coder for WebCore::AttributedString.

• Shared/mac/AttributedString.h: Removed.
• Shared/mac/AttributedString.mm: Removed.

• SourcesCocoa.txt: Removed AttributedString.mm.

• UIProcess/API/Cocoa/WKWebView.mm: Updated to use WebCore::AttributedString.
• UIProcess/Cocoa/TextCheckingController.mm: Ditto.
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::attributedSubstringForProposedRange): Ditto.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getContentsAsAttributedString): Ditto.

• UIProcess/WebPageProxy.h: Ditto.
• UIProcess/WebPageProxy.messages.in: Ditto.
• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync): Ditto.
(WebKit::WebPageProxy::attributedStringForCharacterRangeCallback): Ditto.

• WebKit.xcodeproj/project.pbxproj: Removed AttributedString.h and AttributedString.mm.

• WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h: Updated to use WebCore::AttributedString.
• WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.messages.in: Ditto.
• WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

(WebKit::TextCheckingControllerProxy::replaceRelativeToSelection): Ditto.
(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions): Ditto.

• WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::dictionaryPopupInfoForRange): Updated since editingAttributedString
returns a struct.
(WebKit::WebPage::getContentsAsAttributedString): Updated to use SimpleRange and
since attributedString returns a struct.

• WebProcess/WebPage/WebPage.h: Updated to use WebCore::AttributedString.
• WebProcess/WebPage/WebPage.messages.in: Ditto.
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestDocumentEditingContext): Ditto.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::attributedSubstringForCharacterRangeAsync): Ditto.
(WebKit::WebPage::handleSelectionServiceClick): Ditto.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebSelectionServiceController.mm:

(WebSelectionServiceController::handleSelectionServiceClick): Updated since
attributedString returns a struct.

• WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): Ditto.
Also use init instead of initWithString:@"".

• WebView/WebHTMLView.mm:

(-[WebHTMLView textStorage]): DItto.
(-[WebHTMLView attributedSubstringFromRange:]): Ditto.
(-[WebHTMLView _attributedStringFromDOMRange:]): Ditto.
(-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]): Ditto.
(-[WebHTMLView attributedString]): Ditto.
(-[WebHTMLView selectedAttributedString]): Ditto.

• WebView/WebImmediateActionController.mm:

(+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
Updated.

Source/WTF:

• wtf/cocoa/URLCocoa.mm:

(WTF::URL::createCFURL const): Use init instead of initWithString:@"". The two are
equivalent in more recent versions of Foundation.

10:07 PM Changeset in webkit [260738] by yoshiaki.jitsukawa@sony.com

• 8 edits
  1 add in trunk

[PlayStation] Enable TestWTF and TestWebCore
​https://bugs.webkit.org/show_bug.cgi?id=208849

Reviewed by Don Olmstead.

.:

• Source/cmake/OptionsPlayStation.cmake:
• Add PLAYSTATION_COPY_SHARED_LIBRARIES() to install dependencies.
• Add -g option for "Release" configuration.
• Drop "RelWithDebInfo" and "MinSizeRel" configuration.

Source/WebCore:

• PlatformPlayStation.cmake:

Add WebCore_CopySharedLibs to install dependencies.

Source/WTF:

• wtf/PlatformPlayStation.cmake:

Add WTF_CopySharedLibs() to install dependencies.

Tools:

• TestWebKitAPI/PlatformPlayStation.cmake:
• TestWebKitAPI/playstation/main.cpp: Added.

(main): Load runtime libraries.

9:05 PM Changeset in webkit [260737] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GTK] Gardening, skipping more inspector tests.

Some inspector tests (like from bug149916) had more specific
expectations than the gtk-global Skip from bug211035 and ended up
being executed. These expectations were not marked as timeout (only
Slow), and this caused the Debug bot to reach the test timeout limit.

As there is already at least three patches involved in this issue,
mark these expectations as Release only, allowing the Debug build to
use the generic expectation from bug2011035.

Unreviewed test gardening.

• platform/gtk/TestExpectations:

6:02 PM Changeset in webkit [260736] by commit-queue@webkit.org

• 21 edits
  1 add in trunk/Source

Rendering update steps should use Seconds for the timestamps
​https://bugs.webkit.org/show_bug.cgi?id=210990

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-04-26
Reviewed by Daniel Bates.

Source/WebCore:

Make DOMWindow::nowTimestamp() return ReducedResolutionSeconds and change
the callers accordingly. ReducedResolutionSeconds is a new type but it's
just an alias of the type Seconds. It indicates that the returned value
is a web-safe seconds.

• Headers.cmake:
• WebCore.xcodeproj/project.pbxproj:
• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::suspendAnimations):
(WebCore::DocumentTimeline::liveCurrentTime const):
(WebCore::DocumentTimeline::cacheCurrentTime):
(WebCore::DocumentTimeline::documentWillUpdateAnimationsAndSendEvents):

• animation/DocumentTimeline.h:
• animation/DocumentTimelinesController.cpp:

(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):

• animation/DocumentTimelinesController.h:
• dom/Document.cpp:

(WebCore::Document::serviceRequestAnimationFrameCallbacks):
(WebCore::Document::updateIntersectionObservations):

• dom/Document.h:
• dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceRequestAnimationFrameCallbacks):
(WebCore::ScriptedAnimationController::scheduleAnimation):

• dom/ScriptedAnimationController.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getVideoPlaybackQuality):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::nowTimestamp const):

• page/DOMWindow.h:
• page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::nowTimestamp const):
(WebCore::IntersectionObserver::createTimestamp const): Deleted.

• page/IntersectionObserver.h:
• page/Page.cpp:

(WebCore::Page::updateRendering):

• page/Performance.cpp:

(WebCore::Performance::now const):
(WebCore::Performance::nowInReducedResolutionSeconds const):

• page/Performance.h:
• page/ReducedResolutionSeconds.h: Added.

Source/WebKit:

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::timestamp const):

5:37 PM Changeset in webkit [260735] by Ross Kirsling

• 8 edits in trunk/Source/JavaScriptCore

[JSC] Clearly distinguish isConstructor from getConstructData
​https://bugs.webkit.org/show_bug.cgi?id=211053

Reviewed by Sam Weinig.

Follow-up to r260722. Remove the isConstructor overload that duplicates getConstructData
and clearly distinguish the usage of these two functions.

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:
• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::isConstructor):
Remove isConstructor overload.

• runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):
Don't use getConstructData if you don't need ConstructData.

• runtime/ReflectObject.cpp:

(JSC::reflectObjectConstruct):
Use getConstructData if you need ConstructData.

• API/JSObjectRef.cpp:

(JSObjectIsFunction):
Use isFunction (leftover spot from last patch).

4:04 PM Changeset in webkit [260734] by ysuzuki@apple.com

• 3 edits in trunk/Tools

Warn when NeverDestroyed<Lock> is used
​https://bugs.webkit.org/show_bug.cgi?id=211054

Reviewed by Darin Adler.

WTF::Lock and WTF::Condition are designed to be constant-initialize compliant. So NeverDestroyed<> for these types are not necessary,
or rather, introducing race condition issue while static Lock doesn't have that issue. This patch adds lint rules which prevent
us from using NeverDestroyed<Lock> and LazyNeverDestroyed<Lock>.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_wtf_never_destroyed):
(check_style):
(CppChecker):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_wtf_never_destroyed):

3:54 PM Changeset in webkit [260733] by Alexey Shvayka

• 5 edits in trunk

Symbol should have Construct internal method
​https://bugs.webkit.org/show_bug.cgi?id=211050

Reviewed by Yusuke Suzuki.

JSTests:

• stress/is-constructor.js:
• test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This change introduces constructSymbol() method, which unconditionally throws
a TypeError, since its presence is observable when, for example, Symbol is a
ProxyTarget itself [1]. Aligns JSC with the spec [2], V8, and SpiderMonkey.

[1]: ​https://tc39.es/ecma262/#sec-proxycreate (step 7.b)
[2]: ​https://tc39.es/ecma262/#constructor

• runtime/SymbolConstructor.cpp:

(JSC::SymbolConstructor::SymbolConstructor):
(JSC::constructSymbol):

2:30 PM Changeset in webkit [260732] by Alexey Shvayka

• 53 edits
  1 add in trunk

InternalFunction::createSubclassStructure should use newTarget's globalObject
​https://bugs.webkit.org/show_bug.cgi?id=202599

Reviewed by Yusuke Suzuki.

JSTests:

• stress/promise-proto-from-ctor-realm.js: Added.
• test262/expectations.yaml: Mark 88 test cases as passing.

LayoutTests/imported/w3c:

• web-platform-tests/WebIDL/ecmascript-binding/constructors-expected.txt:
• web-platform-tests/custom-elements/htmlconstructor/newtarget-expected.txt:
• web-platform-tests/wasm/jsapi/proto-from-ctor-realm-expected.txt:

Source/JavaScriptCore:

If "prototype" of NewTarget is not an object, built-in constructors [1] should acquire
default Prototype from realm of NewTarget, utilizing GetFunctionRealm helper [2].
Before this change, realm of active constructor was used instead. This patch introduces
GetFunctionRealm and aligns all subclassable constructors with the spec, V8, and SpiderMonkey.

This change inlines fast paths checks of InternalFunction::createSubclassStructure() and
simplifies its signature; getFunctionRealm() is invoked in slow paths only.

While a dynamically created function uses NewTarget's realm for its default Prototype
similar to other built-ins, its "prototype" object inherit from ObjectPrototype
of active constructor's realm [3] (just like their scope), making it retain references
to 2 different global objects. To accomodate this behavior, this change introduces
scopeGlobalObject in JSFunction.cpp methods.

Above-mentioned behavior also simplifies creation of JSGenerator and JSAsyncGenerator
instances since NewTarget's realm is irrelevant to them.

IntlCollatorConstructor::collatorStructure() and 6 similar methods are removed:
a) to impose good practice of using newTarget's globalObject;
b) with this change, each of them have 1 call site max;
c) other JSC constructors have no methods alike.

[1]: ​https://tc39.es/ecma262/#sec-map-constructor (step 2)
[2]: ​https://tc39.es/ecma262/#sec-getfunctionrealm
[3]: ​https://tc39.es/ecma262/#sec-createdynamicfunction (steps 23-25)

• dfg/DFGOperations.cpp:
• runtime/AggregateErrorConstructor.cpp:

(JSC::callAggregateErrorConstructor):
(JSC::constructAggregateErrorConstructor):

• runtime/AggregateErrorConstructor.h:
• runtime/AsyncFunctionConstructor.cpp:

(JSC::constructAsyncFunctionConstructor):

• runtime/AsyncGeneratorFunctionConstructor.cpp:

(JSC::constructAsyncGeneratorFunctionConstructor):

• runtime/BooleanConstructor.cpp:

(JSC::constructWithBooleanConstructor):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):
(JSC::createInternalFieldObject):

• runtime/DateConstructor.cpp:

(JSC::constructDate):

• runtime/ErrorConstructor.cpp:

(JSC::constructErrorConstructor):

• runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::createSubclassStructure):
(JSC::getFunctionRealm):
(JSC::InternalFunction::createSubclassStructureSlow): Deleted.

• runtime/InternalFunction.h:

(JSC::InternalFunction::createSubclassStructure): Deleted.

• runtime/IntlCollatorConstructor.cpp:

(JSC::constructIntlCollator):
(JSC::callIntlCollator):

• runtime/IntlCollatorConstructor.h:
• runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::constructIntlDateTimeFormat):
(JSC::callIntlDateTimeFormat):

• runtime/IntlDateTimeFormatConstructor.h:
• runtime/IntlNumberFormatConstructor.cpp:

(JSC::constructIntlNumberFormat):
(JSC::callIntlNumberFormat):

• runtime/IntlNumberFormatConstructor.h:
• runtime/IntlPluralRulesConstructor.cpp:

(JSC::constructIntlPluralRules):

• runtime/IntlPluralRulesConstructor.h:
• runtime/IntlRelativeTimeFormatConstructor.cpp:

(JSC::constructIntlRelativeTimeFormat):

• runtime/IntlRelativeTimeFormatConstructor.h:
• runtime/JSArrayBufferConstructor.cpp:

(JSC::JSGenericArrayBufferConstructor<sharingMode>::constructArrayBuffer):

• runtime/JSFunction.cpp:

(JSC::JSFunction::prototypeForConstruction):
(JSC::JSFunction::getOwnPropertySlot):

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayView):

• runtime/JSGlobalObjectInlines.h:

(JSC::JSGlobalObject::arrayStructureForIndexingTypeDuringAllocation const):

• runtime/MapConstructor.cpp:

(JSC::constructMap):

• runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor<errorType>::constructNativeErrorConstructor):
(JSC::NativeErrorConstructor<errorType>::callNativeErrorConstructor):

• runtime/NativeErrorConstructor.h:
• runtime/NumberConstructor.cpp:

(JSC::constructNumberConstructor):

• runtime/ObjectConstructor.cpp:

(JSC::constructObjectWithNewTarget):

• runtime/RegExpConstructor.cpp:

(JSC::getRegExpStructure):
(JSC::constructRegExp):
(JSC::esSpecRegExpCreate):

• runtime/RegExpConstructor.h:
• runtime/SetConstructor.cpp:

(JSC::constructSet):

• runtime/StringConstructor.cpp:

(JSC::constructWithStringConstructor):

• runtime/WeakMapConstructor.cpp:

(JSC::constructWeakMap):

• runtime/WeakObjectRefConstructor.cpp:

(JSC::constructWeakRef):

• runtime/WeakSetConstructor.cpp:

(JSC::constructWeakSet):

• wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::constructJSWebAssemblyCompileError):

• wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):

• wasm/js/WebAssemblyLinkErrorConstructor.cpp:

(JSC::constructJSWebAssemblyLinkError):

• wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::WebAssemblyModuleConstructor::createModule):

• wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::constructJSWebAssemblyRuntimeError):

Source/WebCore:

Accounts for InternalFunction::createSubclassStructure() signature change and
utilizes getFunctionRealm() helper to handle cross-realm JSBoundFunction and
ProxyObject instances as NewTarget value.

Tests: web-platform-tests/WebIDL/ecmascript-binding/constructors.html

web-platform-tests/custom-elements/htmlconstructor/newtarget.html

• bindings/js/JSDOMWrapperCache.h:

(WebCore::setSubclassStructureIfNeeded):

• bindings/js/JSHTMLElementCustom.cpp:

(WebCore::constructJSHTMLElement):

2:17 PM Changeset in webkit [260731] by ysuzuki@apple.com

• 4 edits in trunk/Source

Use static Lock instead of static NeverDestroyed<Lock>
​https://bugs.webkit.org/show_bug.cgi?id=211036

Reviewed by Darin Adler.

Source/WebCore:

• platform/GenericTaskQueue.cpp:

(WebCore::TaskDispatcher<Timer>::sharedLock):

Source/WTF:

Lock can be static-initialized since it has constexpr constructor. No need to use NeverDestroyed<Lock>.

• wtf/Logger.h:

(WTF::Logger::observerLock):

2:11 PM Changeset in webkit [260730] by ysuzuki@apple.com

• 15 edits
  5 adds in trunk

[JSC] ValueAdd, VaueSub, ValueMul, Inc, Dec should say SpecBigInt32 prediction based on ArithProfile
​https://bugs.webkit.org/show_bug.cgi?id=211038

Reviewed by Filip Pizlo.

JSTests:

• stress/bigint32-add-overflow.js: Added.

(shouldBe):
(add):
(noInline):

• stress/bigint32-dec-overflow.js: Added.

(shouldBe):
(dec):
(noInline):

• stress/bigint32-inc-overflow.js: Added.

(shouldBe):
(inc):
(noInline):

• stress/bigint32-mul-overflow.js: Added.

(shouldBe):
(mul):
(noInline):

• stress/bigint32-sub-overflow.js: Added.

(shouldBe):
(sub):
(noInline):

Source/JavaScriptCore:

This patch adds profile feedback to ValueAdd, ValueSub, ValueMul, Inc, Dec to say SpecBigInt32 prediction.

Our HeapBigInt v.s. BigInt32 strategy is simpler than Double v.s. Int32 strategy: we always
prefer BigInt32 over HeapBigInt. This is because HeapBigInt calculation and conversion require
much higher cost than BigInt32. This tradeoff is largely different from Double v.s. Int32.
So keeping HeapBigInt is simply inefficient when we can use BigInt32.

This means that ArithProfile's feedback is also very simple. If we see HeapBigInt, this means
overflow happens. In DFG, we propagate this information to ValueAdd, ValueSub, and ValueMul nodes
and record it in DFGNodeFlags. And based on this information, we change the prediction and
speculation in prediction propagation and fixup phase.

We change exit reason from Overflow to BigInt32Overflow since Overflow is solely used for Int32 case,
and we have Int52Overflow for Int52 case. We should have BigInt32Overflow for BigInt32 to precisely
record and tell about what happens in DFG as a feedback for the next compilation.

We add BigInt32 speculation for ValueSub. Previously, we missed that in fixup phase and we always
speculate ValueSub with AnyBigIntUse or HeapBigIntUse. Now it can use BigInt32Use.

We also fix Inc / Dec's fixup phase to use BigInt path. Previously, it was always using UntypedUse since
node->child1()->shouldSpeculateUntypedForArithmetic() returns true for BigInt. We fix the ordering of
speculation attempts as it is done in the other places in fixup phase.

This patch offers 7.9% performance improvement in sunspider-sha1-big-int.

ToT Patched

sunspider-sha1-big-int 134.5668+-2.8695 ^{124.6743+-0.7541} definitely 1.0793x faster

• bytecode/ExitKind.cpp:

(JSC::exitKindToString):

• bytecode/ExitKind.h:
• bytecode/SpeculatedType.h:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::binaryArithShouldSpeculateBigInt32):
(JSC::DFG::Graph::unaryArithShouldSpeculateBigInt32):

• dfg/DFGNode.h:

(JSC::DFG::Node::mayHaveBigInt32Result):
(JSC::DFG::Node::mayHaveHeapBigIntResult):
(JSC::DFG::Node::mayHaveBigIntResult):
(JSC::DFG::Node::canSpeculateBigInt32):
(JSC::DFG::Node::canSpeculateInt52):

• dfg/DFGNodeFlags.cpp:

(JSC::DFG::dumpNodeFlags):

• dfg/DFGNodeFlags.h:

(JSC::DFG::nodeMayHaveHeapBigInt):
(JSC::DFG::nodeCanSpeculateBigInt32):

• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileValueSub):
(JSC::DFG::SpeculativeJIT::compileValueMul):
(JSC::DFG::SpeculativeJIT::compileValueDiv):
(JSC::DFG::SpeculativeJIT::speculateHeapBigInt):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMul):
(JSC::FTL::DFG::LowerDFGToB3::compileValueDiv):

1:02 PM Changeset in webkit [260729] by Peng Liu

• 7 edits
  1 delete in trunk/Source

Remove unused class PlaybackSessionInterface
​https://bugs.webkit.org/show_bug.cgi?id=211031

Reviewed by Daniel Bates.

Source/WebCore:

No new tests, no functional changes.

• WebCore.xcodeproj/project.pbxproj:
• platform/cocoa/PlaybackSessionInterface.h: Removed.
• platform/cocoa/PlaybackSessionModelMediaElement.h:
• platform/ios/PlaybackSessionInterfaceAVKit.h:
• platform/mac/PlaybackSessionInterfaceMac.h:

Source/WebKit:

• WebProcess/cocoa/PlaybackSessionManager.h:

12:51 PM Changeset in webkit [260728] by chris.reid@sony.com

• 2 edits in trunk/Source/WebInspectorUI

[Win] Fix windows build with MSBuild after 260672
​https://bugs.webkit.org/show_bug.cgi?id=211047

Unreviewed build fix.

• CMakeLists.txt:

11:55 AM Changeset in webkit [260727] by jh718.park@samsung.com

• 2 edits in trunk/Source/WTF

[WTF] Workaround gcc bug for unsigned bitfield related usual arithmetic conversions
​https://bugs.webkit.org/show_bug.cgi?id=211044

Reviewed by Darin Adler.

• wtf/URL.cpp:

(WTF::URL::setHost):
(WTF::URL::setHostAndPort):
(WTF::URL::setUser):
(WTF::URL::setPassword):

9:34 AM Changeset in webkit [260726] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][TFC] Compute and distribute extra vertical space for rows
​https://bugs.webkit.org/show_bug.cgi?id=211046

Reviewed by Antti Koivisto.

When the table computed height is bigger than the sum of the row heigts, we need to distribute the extra vertical
space among the non-fixed height rows. The distribution is based on the preferred height of those non-fixed rows.

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraVerticalSpace):

8:33 AM Changeset in webkit [260725] by Darin Adler

• 63 edits in trunk/Source

Stop using live ranges in functions that return range of the selection
​https://bugs.webkit.org/show_bug.cgi?id=210396

Reviewed by Sam Weinig.

Source/WebCore:

• Added makeRangeSelectingNode, to create a range that selects a node and all its descendants.
• Improved intersectingNodes so it can now easily be used in a while loop style as well as the range-for loop style. Also made it more robust against tree changes while iterating; it will now always stop at the end of the document.
• Changed functions that work with selection to get a SimpleRange, and then either do all the work without a live range, or call createLiveRange right where it's needed, making it clearer when we can delete that call later as we cut down live ranges even more.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::selectionRange const): Return a SimpleRange
instead of a live range.
(WebCore::AccessibilityObject::findTextRanges const): Use createLiveRange
on the result of selectionRange since this still mostly uses live ranges.

• accessibility/AccessibilityObject.h: Updated for the above.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::documentBasedSelectedTextRange const):
Updated to create a live range only in the one place we need to call a
Range class member function.

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]):
Use createLiveRange here.

• dom/SimpleRange.cpp:

(WebCore::makeRangeSelectingNode): Added. For use when we need to make
a range that selects a node, not just the node's contents.
(WebCore::firstIntersectingNode): Renamed from IntersectingNodeRange::first
since this is now used in the iterator class, not the range class. Also
letting it be a non-member function so we can tweak it without touching
the haeder file.
(WebCore::nodePastLastIntersectingNode): Ditto.
(WebCore::IntersectingNodeIterator::IntersectingNodeIterator): Changed
this constructor to take a SimpleRange. To add the advanceSkippingChildren
feature, had to build the termination condition into the iterator rather
than basing it on the value of the sentinel.
(WebCore::IntersectingNodeIterator::advance): Added. Contains the logic
from the ++ operator, so it can be called in a more straightforward way
when this is being used with a while loop rather than a range-for loop.
(WebCore::IntersectingNodeIterator::advanceSkippingChildren): Added.

• dom/SimpleRange.h: Updated for the changes to IntersectingNodeIterator

and IntersectingNodeRange.

• editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::timerFired): Use createLiveRange.

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::targetRanges const): Use WTFMove in
a place where the old code was copying instead.

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):
Use intersectingNodes to make the function's logic easier to understand.

• editing/Editing.cpp:

(WebCore::visibleImageElementsInRangeWithNonLoadedImages): Changed
the argument type to SimpleRange.

• editing/Editing.h: Updated for the change above.

• editing/EditingStyle.cpp:

(WebCore::EditingStyle::styleAtSelectionStart): Use createLiveRange.

• editing/Editor.cpp:

(WebCore::Editor::selectedRange): Use createLiveRange.
(WebCore::Editor::applyStyleToSelection): Ditto.
(WebCore::Editor::applyParagraphStyleToSelection): Ditto.
(WebCore::Editor::insertTextWithoutSendingTextEvent): Ditto.
(WebCore::Editor::insertLineBreak): Ditto.
(WebCore::Editor::insertParagraphSeparator): Ditto.
(WebCore::Editor::ignoreSpelling): Remove use of live range.
(WebCore::Editor::learnSpelling): Ditto.
(WebCore::Editor::misspelledWordAtCaretOrRange const): Ditto.
(WebCore::Editor::isSelectionUngrammatical): Ditto.
(WebCore::Editor::guessesForMisspelledOrUngrammatical): Ditto.
(WebCore::Editor::markMisspellingsAfterTypingToWord): Use createLiveRange.
(WebCore::Editor::markMisspellingsOrBadGrammar): Ditto.
(WebCore::Editor::markMisspellingsAndBadGrammar): Ditto.
(WebCore::Editor::rangeForPoint): Ditto.
(WebCore::Editor::insertTextPlaceholder): Ditto.
(WebCore::Editor::shouldChangeSelection const): Ditto.
(WebCore::Editor::findString): Ditto.
(WebCore::Editor::rangeOfString): Ditto.
(WebCore::Editor::scanSelectionForTelephoneNumbers): Ditto.
(WebCore::Editor::editorUIUpdateTimerFired): Remove use of live range.
(WebCore::candidateRangeForSelection): Deleted.
(WebCore::Editor::stringForCandidateRequest const): Use createLiveRange
and merged in the logic from candidateRangeForSelection.
(WebCore::Editor::fontForSelection const): Remove use of live range.

• editing/EditorCommand.cpp:

(WebCore::expandSelectionToGranularity): Use createLiveRange.
(WebCore::executeDeleteToMark): Ditto.
(WebCore::executeSelectToMark): Ditto.
(WebCore::valueFormatBlock): Ditto.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::respondToNodeModification): Use createLiveRange.
(WebCore::FrameSelection::shouldDeleteSelection const): Ditto.
(WebCore::FrameSelection::getClippedVisibleTextRectangles const): Do the work
without a live range.
(WebCore::FrameSelection::expandSelectionToElementContainingCaretSelection): Ditto.
(WebCore::FrameSelection::elementRangeContainingCaretSelection const): Changed
to return a SimpleRange rather than a live range. Also removed redundant checks
and renamed locals to streamline the function.
(WebCore::FrameSelection::wordRangeContainingCaretSelection): Return a
SimpleRange instead of a live range.
(WebCore::FrameSelection::rangeByMovingCurrentSelection const): Ditto.
(WebCore::FrameSelection::rangeByExtendingCurrentSelection const): Ditto.
(WebCore::FrameSelection::rangeByAlteringCurrentSelection const): Ditto.

• editing/FrameSelection.h: Removed the toNormalizedRange function, since the

VisibleSelection class has a comment claiming most callers should not call it.
Updated forthe other changes above.

• editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply): Use createLiveRange.

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment): Ditto.

• editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::TextCheckingHelper): Remove use of live range,
changing the type of m_range to SimpleRange.
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): Reduce use
of live range.
(WebCore::TextCheckingHelper::findFirstGrammarDetail const): Use createLiveRange.
(WebCore::TextCheckingHelper::findFirstBadGrammar const): Ditto.
(WebCore::TextCheckingHelper::isUngrammatical const): Remove use of live range.
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange const):
Use createLiveRange.
(WebCore::TextCheckingHelper::unifiedTextCheckerEnabled const): Updated for
different interface to get the document for a SimpleRange.

• editing/TextCheckingHelper.h: Change constructor to take a SimpleRange.

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed): Use createLiveRange.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::firstRange const): Return a SimpleRange.
(WebCore::VisibleSelection::toNormalizedRange const): Ditto.

• editing/VisibleSelection.h: Updated for the above.

• editing/cocoa/DictionaryLookup.mm: Removed an uneeded check of the

selection range against null. Code already guards against null endpoints.

• editing/cocoa/EditorCocoa.mm:

(WebCore::selectionAsAttributedString): Added. Uses the attributedString
function with it's new argument and return value types. There's no longer
a special function for the selection in the HTMLConverter header, so we
put it here instead.
(WebCore::Editor::writeSelectionToPasteboard): Updated to use the function
above and to deal with RetainPtr.
(WebCore::Editor::writeSelection): Ditto.

• editing/cocoa/HTMLConverter.h: Removed attributedStringFromSelection and

attributedStringBetweenStartAndEnd. Renamed attributedStringFromRange to
just attributedString and renamed editingAttributedStringFromRange to
just editingAttributedString. Also renamed IncludeImagesInAttributedString
to just IncludeImages.

• editing/cocoa/HTMLConverter.mm:

(HTMLConverter::HTMLConverter): Use a SimpleRange rther than two Position
arguments to the constructor.
(HTMLConverter::convert): Use RetainPtr for the return value and the
optional out argument.
(WebCore::attributedStringFromSelection): Deleted.
(WebCore::attributedStringBetweenStartAndEnd): Deleted.
(WebCore::attributedString): Renamed the version that takes a range and
made it take a SimpleRange, not a live range.
(WebCore::editingAttributedString): Ditto.

• editing/mac/EditorMac.mm:

(WebCore::Editor::dataSelectionForPasteboard): Updated for changes to
attributedString.

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent const):
Changed to not use live ranges any more.

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
Use createLiveRange.

• page/DOMSelection.cpp:

(WebCore::DOMSelection::getRangeAt): Use createLiveRange.
(WebCore::DOMSelection::addRange): Use Ditto.
(WebCore::DOMSelection::deleteFromDocument): Ditto.

• page/DragController.cpp:

(WebCore::setSelectionToDragCaret): Removed in/out argument that was
used to update a range that was never looked at afterward.
(WebCore::DragController::concludeEditDrag): Use createLiveRange.
(WebCore::DragController::draggableElement const): Ditto.
(WebCore::DragController::startDrag): Ditto.

• page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent): Use createLiveRange.
(WebCore::EventHandler::sendContextMenuEventForKey): Ditto.
(WebCore::EventHandler::didStartDrag): Remove use of live range.

• page/Page.cpp:

(WebCore::Page::findStringMatchingRanges): Use createLiveRange.

• page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithRange): Ditto.
(WebCore::TextIndicator::createWithSelectionInFrame): Ditto.

• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::buildSelectionHighlight):
Use createLiveRange.
(WebCore::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight):
Use createLiveRange.

• rendering/HitTestResult.cpp:

(WebCore::HitTestResult::selectedText const): Remove use of
live range.

Source/WebKit:

• WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::updateGlobalSelection): Remove use of live range.

• WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::dictionaryPopupInfoForRange): Updated for changes
to attributedString functions.
(WebKit::WebPage::getContentsAsAttributedString): Ditto.

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll): Use createLiveRange.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getSelectedRangeAsync): Ditto.
(WebKit::WebPage::currentSelectionAsRange): Ditto.

• WebProcess/WebPage/WebPage.h: Change m_rangeForDropSnapshot

to use a SimpleRange instead of a live range.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::plainTextForContext): Overloaded for SimpleRange and
Optional<SimpleRange> as needed by code below.
(WebKit::plainTextForDisplay): Ditto.
(WebKit::WebPage::getPlatformEditorState const): Use createLiveRange.
(WebKit::WebPage::getSelectionContext): Remove use of live range.
(WebKit::WebPage::didConcludeDrop): Ditto.
(WebKit::WebPage::didConcludeEditDrag): Use createLiveRange.
(WebKit::WebPage::computeAndSendEditDragSnapshot): Ditto.
(WebKit::WebPage::startAutoscrollAtPosition): Remove use of
live range.
(WebKit::WebPage::requestEvasionRectsAboveSelection): Use
createLiveRange.
(WebKit::WebPage::requestDictationContext): Remove use of live range.
(WebKit::WebPage::replaceSelectedText): Use createLiveRange.
(WebKit::WebPage::applyAutocorrectionInternal): Ditto.
(WebKit::WebPage::autocorrectionContext): Remove use of live range.
(WebKit::WebPage::requestDocumentEditingContext): Use createLiveRange.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getPlatformEditorState const): Remove use of
live range.
(WebKit::WebPage::attributedSubstringForCharacterRangeAsync):
Updated for change to HTMLConverter functions.
(WebKit::WebPage::handleSelectionServiceClick): Ditto.
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
Remove use of live range.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame selectionRectsForCoreRange:]): Changed argument type to
not require a live range. Internally, use createLiveRange and also
use a range-for loop.
(-[WebFrame selectionRectsForRange:]): Remove use of live range.
(-[WebFrame selectionRects]): Ditto.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::handleRequestedCandidates): Remove use of live range.

• WebCoreSupport/WebSelectionServiceController.mm:

(WebSelectionServiceController::handleSelectionServiceClick): Ditto.

• WebView/WebFrame.mm:

(-[WebFrame _rangeByAlteringCurrentSelection:direction:granularity:]):
Use createLiveRange.
(-[WebFrame _convertToNSRange:]): Changed to take SimpleRange.
(-[WebFrame _convertDOMRangeToNSRange:]): Updated for the above.
(-[WebFrame _markDOMRange]): Use createLiveRange.
(-[WebFrame _selectionRangeForFirstPoint:secondPoint:]): Ditto.
(-[WebFrame _selectionRangeForPoint:]): Ditto.
(-[WebFrame _selectedNSRange]): Remove use of live range.
(-[WebFrame selectedDOMRange]): Use crateLiveRange.
(-[WebFrame elementRangeContainingCaretSelection]): Ditto.
(-[WebFrame expandSelectionToWordContainingCaretSelection]): Tweaked
coding style a little.
(-[WebFrame expandSelectionToStartOfWordContainingCaretSelection]): Ditto.
(-[WebFrame wordRangeContainingCaretSelection]): Use createLiveRange.
(-[WebFrame rangeByMovingCurrentSelection:]): Ditto.
(-[WebFrame rangeByExtendingCurrentSelection:]): Ditto.
(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:matchStyle:]):
Use createLiveRange.
(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
(-[WebFrame _documentFragmentForText:]): Ditto.

• WebView/WebFrameInternal.h: Updated for changes above.

• WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
Remove use of live range.

• WebView/WebHTMLView.mm:

(-[WebHTMLView _selectedRange]): Use createLiveRange.
(-[WebHTMLView _lookUpInDictionaryFromMenu:]): Remove use of live range.
(-[WebHTMLView markedRange]): Updated for change to _convertToNSRange.
(-[WebHTMLView attributedSubstringFromRange:]): Ditto.
(-[WebHTMLView _attributedStringFromDOMRange:]): Updated for changes to
HTMLConverter.
(-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]): Remove
use of live range.
(-[WebHTMLView attributedString]): Ditto.
(-[WebHTMLView selectedAttributedString]): Ditto.

• WebView/WebImmediateActionController.h: Updated method to take a

SimpleRange instead of a live range.

• WebView/WebImmediateActionController.mm:

(+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
Remove use of live range.

• WebView/WebTextCompletionController.mm:

(-[WebTextCompletionController doCompletion]): Use createLiveRange.

• WebView/WebView.mm:

(-[WebView _didConcludeEditDrag]): Ditto.

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::prepareCandidateWindow): Updated since toNormalizedRange
returns a SimpleRange.
(WebView::onIMERequestCharPosition): Ditto.
(WebView::onIMERequestReconvertString): Ditto.

7:53 AM Changeset in webkit [260724] by Darin Adler

• 13 edits
  1 copy
  1 add
  1 delete in trunk/Source/WebCore

Remove unnecessary inlining and templates for URL decomposition DOM functions
​https://bugs.webkit.org/show_bug.cgi?id=211025

Reviewed by Alex Christensen.

• Headers.cmake: Renamed URLUtils.h to URLDecomposition.h.
• Modules/cache/DOMCacheStorage.cpp: Updated include and using namespace.
• Sources.txt: Added URLDecomposition.cpp.
• WebCore.xcodeproj/project.pbxproj: Added URLDecomposition.cpp and

renamed URLUtils.h to URLDecomposition.h.

• html/DOMURL.h: Removed the WEBCORE_EXPORT on this class. Added final.

Derive from URLDecomposition instead of URLUtils. Changed return type of
href to const&. Moved toJSON here from URLUtils. Added overrides of the
fullURL and setFullURL functions for URLDecomposition.

• html/DOMURL.idl: Removed ImplementationLacksVTable.

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::HTMLAnchorElement): Moved initialization of
boolean data members to the class definition.

• html/HTMLAnchorElement.h: Derive from URLDecomposition instead of

URLUtils. Added overrides of the fullURL and setFullURL functions for
URLDecomposition. Initialize data members here in the class definition.

• html/HTMLMediaElement.cpp: Removed unnecessary include of DOMURL.h.

• html/URLDecomposition.cpp: Added. Contains most of the code from

the URLUtils class template, which no longer needs to be in a header.

• html/URLDecomposition.h: Renamed URLUtils.h to this. It's now an

abstract base class rather than a class template using the curiously
recurring template pattern.

• html/URLSearchParams.h: Forward-declare DOMURL rather than including

the DOMURL.h header.

• html/URLUtils.h: Removed. Renamed to URLDecompostion.h.

• page/DOMWindow.cpp: Removed unneeded include of DOMURL.h.
• testing/Internals.cpp: Added include of DOMURL.h.

12:37 AM Changeset in webkit [260723] by cathiechen

• 2 edits in trunk/Source/WebCore

fast/scrolling/scroll-behavior-invalidate-if-disabled.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=210917

Reviewed by Darin Adler.

The flaky failure is caused by reusing the CSSPropertyInfo value cached propertyInfoCache
after experimental flags changed. Add propertyInfoFromJavaScriptCSSPropertyName
to perform disabled checking after parsing. If the property is disabled, it will return
an invalid CSSPropertyInfo instead.

• css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::getCSSPropertyIDFromJavaScriptPropertyName):
(WebCore::CSSStyleDeclaration::namedItem):
(WebCore::CSSStyleDeclaration::setNamedItem):