Timeline

Apr 29, 2020:

10:30 PM Changeset in webkit [260935] by Noam Rosenthal

• 2 edits in trunk/LayoutTests

[Mac] http/tests/performance/paint-timing/performance-paint-timing-fcp-after-visually-non-empty-for-num-chars.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=211221

Unreviewed test gardening.

• platform/mac/TestExpectations:

Mark as flaky.

9:16 PM Changeset in webkit [260934] by Simon Fraser

• 8 edits in trunk/Tools

Add a MiniBrowser option to inset the web view so it doesn't fill the window
​https://bugs.webkit.org/show_bug.cgi?id=211216

Reviewed by Tim Horton.

Add a menu item, Debug > Inset Web View to MiniBrowser which insets the view from
the edges of the window, making it possible to debug coordinate conversion issues.

The state is stored in Settings, but unlike other Settings this one doesn't
get populated into the Settings menu because it makes more logical sense grouped
with the options to Hide and Remove the web view.

• MiniBrowser/mac/BrowserWindowController.h:
• MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController toggleFullWindowWebView:]):
(-[BrowserWindowController webViewFillsWindow]):
(-[BrowserWindowController setWebViewFillsWindow:]):

• MiniBrowser/mac/MainMenu.xib:
• MiniBrowser/mac/SettingsController.h:
• MiniBrowser/mac/SettingsController.m:

(-[SettingsController initWithMenu:]):
(-[SettingsController webViewFillsWindow]):
(-[SettingsController setWebViewFillsWindow:]):

• MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController validateMenuItem:]):
(-[WK1BrowserWindowController didChangeSettings]):

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController didChangeSettings]):

9:16 PM Changeset in webkit [260933] by Simon Fraser

• 5 edits in trunk/Source

Use initializers in PlatformMouseEvent and WebEvent
​https://bugs.webkit.org/show_bug.cgi?id=211217

Reviewed by Tim Horton.

Source/WebCore:

Use initializers im PlatformMouseEvent.

• platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

Source/WebKit:

Use initializers im WebEvent.

• Shared/WebEvent.h:
• Shared/WebMouseEvent.cpp:

8:03 PM Changeset in webkit [260932] by Brent Fulgham

• 11 edits in trunk/Source/WebKit

Improve SandboxExtension::HandleArray to reduce boilerplate
​https://bugs.webkit.org/show_bug.cgi?id=211103
<rdar://problem/62533632>

Reviewed by Per Arne Vollan.

There are a number of boilerplate patterns needed when using SandboxExtension::HandleArray.
We could make these simpler and less error prone by improving the class.

This patch:

1. Adds convenience methods to create and consume HandleArrays.
2. Updates uses of HandleArray to use the convenience methods.

Tested by existing tests.

• Platform/IPC/FormDataReference.h:

(IPC::FormDataReference::decode):

• Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::SandboxExtension::createHandlesForFiles):
(WebKit::SandboxExtension::createHandlesForMachLookup):
(WebKit::SandboxExtension::consumePermanently):

• Shared/SandboxExtension.h:

(WebKit::createHandlesForFiles):
(WebKit::SandboxExtension::consumePermanently):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::unblockPreferenceServiceIfNeeded):

• UIProcess/WebPageProxy.cpp:
• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPathnamesForType):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::extendSandboxForFilesFromOpenPanel):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::unblockPreferenceService):

8:00 PM Changeset in webkit [260931] by Ross Kirsling

• 13 edits in trunk/Source/JavaScriptCore

Ensure Intl classes don't have naming conflicts with unified builds
​https://bugs.webkit.org/show_bug.cgi?id=211213

Reviewed by Yusuke Suzuki.

Each Intl class usually has an array named relevantExtensionsKeys and a function named localeData.
This can result in redefinition errors when unified builds put two of them into the same translation unit.
Some are already guarding against this with an internal namespace while others are not.

As a uniform approach, this patch makes each localeData function a static method and
puts each relevantExtensionsKeys array (as well as any constants for its indices) into an internal namespace.

Furthermore, since three different classes are defining an identical UFieldPositionIteratorDeleter,
this patch consolidates them into one definition in IntlObject.

• runtime/IntlCollator.cpp:

(JSC::IntlCollator::sortLocaleData): Renamed from JSC::sortLocaleData.
(JSC::IntlCollator::searchLocaleData): Renamed from JSC::searchLocaleData.
(JSC::IntlCollator::initializeCollator):

• runtime/IntlCollator.h:
• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::localeData): Renamed from JSC::IntlDTFInternal::localeData.
(JSC::toDateTimeOptionsAnyDate): Renamed from JSC::IntlDTFInternal::toDateTimeOptionsAnyDate.
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::UFieldPositionIteratorDeleter::operator() const): Deleted.

• runtime/IntlDateTimeFormat.h:
• runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::localeData): Renamed from JSC::IntlNFInternal::localeData.
(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::UFieldPositionIteratorDeleter::operator() const): Deleted.

• runtime/IntlNumberFormat.h:
• runtime/IntlObject.cpp:

(JSC::UFieldPositionIteratorDeleter::operator() const): Added.

• runtime/IntlObject.h:
• runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::localeData): Renamed from JSC::localeData.

• runtime/IntlPluralRules.h:
• runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::localeData): Renamed from JSC::localeData.
(JSC::IntlRelativeTimeFormat::initializeRelativeTimeFormat):
(JSC::UFieldPositionIteratorDeleter::operator() const): Deleted.

• runtime/IntlRelativeTimeFormat.h:

7:47 PM Changeset in webkit [260930] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GTK] Gardening Wayland compositing tests.

Unreviewed test gardening.

• platform/gtk-wayland/TestExpectations:

6:35 PM Changeset in webkit [260929] by Alan Coon

• 2 edits in branches/safari-610.1.11-branch/Source/WebKit

Cherry-pick r260920. rdar://problem/62627737

Unreviewed sandbox compile fix.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:50 PM Changeset in webkit [260928] by Chris Dumez

• 11 edits in trunk

REGRESSION(r260791) Network process fails to suspend promptly
​https://bugs.webkit.org/show_bug.cgi?id=211207
<rdar://problem/62620454>

Reviewed by Alex Christensen.

Source/WebKit:

After r260791, all WebResourceLoadStatisticsStore instances share a single WorkQueue.
As a result, the logic to suspend WebResourceLoadStatisticsStore's WorkQueues in
NetworkProcess::prepareToSuspend() needs to get updated to reflect this.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::suspend):
(WebKit::WebResourceLoadStatisticsStore::resume):

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::resume):

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(TEST):

5:10 PM Changeset in webkit [260927] by Alan Bujtas

• 2 edits in trunk/LayoutTests

[Win] Skip fast/text/text-indent-inside-float.html

Unreviewed test gardening.

• platform/win/TestExpectations:

4:42 PM Changeset in webkit [260926] by Kate Cheney

• 2 edits in trunk/Tools

Add better handling of an uncleared bundle identifier in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=211195
<rdar://problem/62117145>

Reviewed by Alexey Proskuryakov.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

4:37 PM Changeset in webkit [260925] by Alan Coon

• 2 edits in branches/safari-610.1.11-branch/Source/WebKit

Cherry-pick r260904. rdar://problem/62622460

Set _STAttributionDisplayName to iOS WebContent Info plist
​https://bugs.webkit.org/show_bug.cgi?id=210772
<rdar://problem/62075201>

Reviewed by Eric Carlson.

Set _STAttributionDisplayName to 'Website' value.

• WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:37 PM Changeset in webkit [260924] by Alan Coon

• 12 edits
  1 add in branches/safari-610.1.11-branch/Source

Cherry-pick r260650. rdar://problem/62622460

Call STDynamicActivityAttributionPublisher in the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=210772
<rdar://problem/62075201>

Patch by Youenn Fablet <​youenn@apple.com> and Luming Yin <​luming_yin@apple.com> on 2020-04-24
Reviewed by Geoffrey Garen.

Source/WebKit:

Call STDynamicActivityAttributionPublisher in WebProcess to make use of the newly added plist entry.
Use of a sandbox extension to protect this call.

• Configurations/WebKit.xcconfig:
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• Scripts/process-entitlements.sh:
• Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:
• WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/InfoPlist.strings: Added.
• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

• wtf/PlatformHave.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:31 PM Changeset in webkit [260923] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

REGRESSION(r260889): TestContextMenu:/webkit/WebKitWebView/populate-menu no longer passes
​https://bugs.webkit.org/show_bug.cgi?id=211203

Reviewed by Aakash Jain.

No new tests needed.

• UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Attach the correct action
group to the popover widget, instead of a temporary which will always be empty.

4:08 PM Changeset in webkit [260922] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r246395): Leak of ARQuickLookPreviewItem and ARQuickLookWebKitItem in -[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]
<​https://webkit.org/b/211197>
<rdar://problem/62612483>

Reviewed by Darin Adler.

• UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:

(-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):

• Use RetainPtr<> and adoptNS() to fix leaks.

3:45 PM Changeset in webkit [260921] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Remove the debug ASSERT in ImageDecoderAVFObjC::storeSampleBuffer()
​https://bugs.webkit.org/show_bug.cgi?id=211191
<rdar://problem/62542285>

Reviewed by Said Abou-Hallawa.

r259594 added an iterator check and a RELEASE_LOG_ERROR for that check, making this ASSERT superfluous.

• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::storeSampleBuffer):

3:37 PM Changeset in webkit [260920] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

Unreviewed sandbox compile fix.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

3:16 PM Changeset in webkit [260919] by Ross Kirsling

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed follow-up to r260848.
LowerDFGToB3 has its own isFunction which should NOT have been renamed.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCreateThis):
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileIsObjectOrNull):
(JSC::FTL::DFG::LowerDFGToB3::compileIsFunction):
(JSC::FTL::DFG::LowerDFGToB3::buildTypeOf):
(JSC::FTL::DFG::LowerDFGToB3::isFunction): Renamed from isCallable.

3:13 PM Changeset in webkit [260918] by Alan Coon

• 5 edits in branches/safari-610.1.11-branch

Cherry-pick r260408. rdar://problem/62617775

App-bound domain behavior should abide by the limitsNavigationsToAppBoundDomains argument in WKWebView configuration
​https://bugs.webkit.org/show_bug.cgi?id=210769
<rdar://problem/62065241>

Reviewed by Brent Fulgham.

Source/WebKit:

Changes app-bound domain behavior to be triggered by the value of
limitsNavigationsToAppBoundDomains, a WebView configuration flag.
If the WebView has this parameter set and is currently navigating to
an app bound domain, then app-bound privileges will be granted.

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setIsNavigatingToAppBoundDomainAndCheckIfPermitted): Update this function to return a boolean to indicate whether the navigation should fail. A failure should occur if a WebView has set the limitsNavigationsToAppBoundDomains flag and attempts to navigate away from an app-bound domain.

If the limitsNavigationsToAppBoundDomains value has not been set to
true, maintain non-app bound behavior regardless of whether the domain
is app-bound or not.

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Check the result of setIsNavigatingToAppBoundDomainAndCheckIfPermitted and fail the
navigation if needed, with both RELEASE logging and an appropriate
error message.

(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain): Deleted.

• UIProcess/WebPageProxy.h: Renamed for clarity.

Tools:

Removes any tests for swapping between app-bound and non app-bound
domains as this behavior is no longer supported.

Sets the limitsNavigationsToAppBoundDomains flag for tests which should
have app-bound behavior to maintain test functionality.

Adds 5 new tests for new behavior.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: (TEST): (-[AppBoundDomainDelegate webView:didFinishNavigation:]): (-[AppBoundDomainDelegate webView:didFailProvisionalNavigation:withError:]): (-[AppBoundDomainDelegate waitForDidFinishNavigation]): (-[AppBoundDomainDelegate waitForDidFailProvisionalNavigationError]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:57 PM Changeset in webkit [260917] by sbarati@apple.com

• 2 edits in trunk/Tools

build-jsc should quote the value of compile flags it forwards
​https://bugs.webkit.org/show_bug.cgi?id=211204

Reviewed by Mark Lam.

We should quote outgoing compile flags that have an equal in them. Before,
if build-jsc were invoked like:
$ build-jsc --release ARCHS="x86_64 i386"
It'd invoke make like:
$ make release ARCHS=x86_64 i386
leading us to try to build the "i386" target, which doesn't exist.

This patch makes us invoke make like so:
$ make release ARCHS="x86_64 i386"

• Scripts/build-jsc:

(buildMyProject):

2:43 PM Changeset in webkit [260916] by Alan Bujtas

• 2 edits in trunk/LayoutTests

[iOS] Skip fast/text/text-indent-inside-float.html

Unreviewed test gardening.

Apparently float sizing/ahem font produces a different result on iOS.

• platform/ios/TestExpectations:

2:39 PM Changeset in webkit [260915] by Alexey Shvayka

• 4 edits in trunk

AsyncFromSyncIterator methods should not pass absent values
​https://bugs.webkit.org/show_bug.cgi?id=211147

Reviewed by Ross Kirsling.

JSTests:

• test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch implements minor spec change [1] to match async and sync iteration
from the perspective of userland next and return iterator methods.
throw method always receives an argument, yet we align with others to be
consistent and future-proof.

This change is already implemented in SpiderMonkey.

[1]: ​https://github.com/tc39/ecma262/pull/1776

• builtins/AsyncFromSyncIteratorPrototype.js:

2:18 PM Changeset in webkit [260914] by commit-queue@webkit.org

• 7 edits in trunk

Add WKNavigationDelegate API shouldAllowDeprecatedTLS
​https://bugs.webkit.org/show_bug.cgi?id=210981
<rdar://problem/61742976>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-04-29
Reviewed by Geoffrey Garen.

Source/WebKit:

• UIProcess/API/Cocoa/WKNavigationDelegate.h:
• UIProcess/Cocoa/NavigationState.h:
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::shouldAllowLegacyTLS):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(-[TLSNavigationDelegate receivedShouldAllowDeprecatedTLS]):
(-[TLSNavigationDelegate webView:authenticationChallenge:shouldAllowDeprecatedTLS:]):
(TestWebKitAPI::TEST):
(-[TLSNavigationDelegate receivedShouldAllowLegacyTLS]): Deleted.
(-[TLSNavigationDelegate _webView:authenticationChallenge:shouldAllowLegacyTLS:]): Deleted.

• TestWebKitAPI/config.h:

1:39 PM Changeset in webkit [260913] by mark.lam@apple.com

• 4 edits in trunk/Source

Freezing of Gigacage and JSC Configs should be thread safe.
​https://bugs.webkit.org/show_bug.cgi?id=211201
<rdar://problem/62597619>

Reviewed by Yusuke Suzuki.

Source/bmalloc:

• bmalloc/Gigacage.cpp:

(Gigacage::bmalloc::permanentlyFreezeGigacageConfig):

Source/JavaScriptCore:

If a client creates multiple VM instances in different threads concurrently, the
following race can occur:

Config::permanentlyFreeze() contains the following code:

if (!g_jscConfig.isPermanentlyFrozen) Point P1

g_jscConfig.isPermanentlyFrozen = true; Point P2

Let's say there are 2 threads T1 and T2.

1. T1 creates a VM and gets to point P1, and sees that g_jscConfig.isPermanentlyFrozen is not set. T1 is about to execute P2 when it gets pre-empted.

2. T2 creates a VM and gets to point P1, and sees that g_jscConfig.isPermanentlyFrozen is not set. T2 proceeds to point P2 and sets g_jscConfig.isPermanentlyFrozen to true. T2 goes on to freeze the Config and makes it not writable.

3. T1 gets to run again, and proceeds to point P2. T1 tries to set g_jscConfig.isPermanentlyFrozen to true. But because the Config has been frozen against writes, the write to g_jscConfig.isPermanentlyFrozen results in a crash.

This is a classic TOCTOU bug. The fix is simply to ensure that only one thread
can enter Config::permanentlyFreeze() at a time.

Ditto for Gigacage::permanentlyFreezeGigacageConfig().

• runtime/JSCConfig.cpp:

(JSC::Config::permanentlyFreeze):

1:16 PM Changeset in webkit [260912] by Chris Dumez

• 4 edits in trunk/Source/WebKit

[iOS][WK2] Temporarily stop using RunningBoard for the foreground process assertion
​https://bugs.webkit.org/show_bug.cgi?id=211196
<rdar://problem/62535822>

Reviewed by Tim Horton.

Temporarily stop using RunningBoard for the foreground process assertion. On recent iOS builds, there
are issues where this assertion can time out after 30 seconds, even though the process is still
foreground.

• Configurations/WebKit.xcconfig:
• UIProcess/ProcessAssertion.h:
• UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::runningBoardNameForAssertionType):
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::~ProcessAssertion):

1:06 PM Changeset in webkit [260911] by Fujii Hironori

• 2 edits in trunk/Source/WTF

[Win] Deadlock in WTF::Thread::didExit() while WebKitNetworkProcess.exe is exiting
​https://bugs.webkit.org/show_bug.cgi?id=210955

Reviewed by Don Olmstead.

The thread_local object of the main thread is destructed after
Windows terminates other threads. If the terminated thread was
holding a mutex, trying to lock the mutex causes deadlock.

• wtf/win/ThreadingWin.cpp:

(WTF::Thread::ThreadHolder::~ThreadHolder): Do nothing if the
thread is the main thread.

12:38 PM Changeset in webkit [260910] by Simon Fraser

• 7 edits in trunk

Simplify contents clipping layer geometry
​https://bugs.webkit.org/show_bug.cgi?id=211162

Reviewed by Zalan Bujtas.

Source/WebCore:

GraphicsLayerCA uses a contents clipping layer, with an optional shape layer, to support
clipping replaced elements with composited contents, like video and WebGL canvas.

A future patch will use this code path for composited subframes. To achieve this,
we need to host the layers of child GraphicsLayers under m_contentsClippingLayer, but
without the GraphicsLayer client having to do geometry math. We can do this by setting
the bounds origin of m_contentsClippingLayer to adjust for its position relative
to the GraphicsLayer origin.

This patch does that, adjusting the position of the contents layer accordingly.
The shape mask layer also needs adjusting; its position has to be at the layer's
bounds origin, and the shape itself needs to have a zero origin.

Tested by existing tests.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::updateClippingStrategy):
(WebCore::GraphicsLayerCA::updateContentsRects):

LayoutTests:

New content layer positions.

• compositing/video/video-object-fit.html:
• compositing/video/video-object-position-expected.txt:
• platform/ios/compositing/video/video-object-position-expected.txt:
• platform/mac/compositing/video/video-object-fit-expected.txt:

12:12 PM Changeset in webkit [260909] by Wenson Hsieh

• 3 edits in trunk/LayoutTests

editing/selection/ios/selection-handles-after-touch-end.html is failing on iOS 13.4 after r260367
​https://bugs.webkit.org/show_bug.cgi?id=211185
<rdar://problem/62560030>

Reviewed by Tim Horton.

Clean up a test and test expectation after r260367. Before this change, the test was trying to verify
that selection handles didn't show up before ending a long press when selecting text. However, the test
expectation in platform/ios/editing/selection/ios/selection-handles-after-touch-end-expected.txt prior
to r260367, which overrode editing/selection/ios/selection-handles-after-touch-end-expected.txt, was
verifying that selection handles showed up after making the text selection, but before ending the touch.
r260367 removed this redundant test expectation in favor of a single test expectation file in
editing/selection/ios, but did not transfer over the expectation of non-empty grabber rects before
ending the touch. This is because the version of the iOS SDK I was testing against happened to _not_
show selection handles before ending the touch.

In a more recent version of that iOS SDK, selection handles are now shown again before ending the touch,
which matches behavior expected in iOS 13.4 once again. This means that the expectation across both
versions of iOS is, once again, to show selection handles before ending the touch. As such, fix this
failing test by refactoring it to only verify that selection handles are present after ending the touch.
We can also take this opportunity to rewrite parts of the test to use more modern idioms, like the
testing facilities in js-test.js and ui-helper.js.

• editing/selection/ios/selection-handles-after-touch-end-expected.txt:
• editing/selection/ios/selection-handles-after-touch-end.html:

12:01 PM Changeset in webkit [260908] by commit-queue@webkit.org

• 26 edits
  6 copies
  3 adds in trunk

REGRESSION (r256784?): Shadertoy demo no longer works in Safari
​https://bugs.webkit.org/show_bug.cgi?id=210994

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-04-29
Reviewed by Dean Jackson.

Source/WebCore:

Certain Shadertoy examples stopped working with the ANGLE backend
for WebGL because rendering to floating-point render targets was
no longer being enabled implicitly along with the
OES_texture_float extension.

Add support for the WebGL 1.0 extensions
EXT_color_buffer_half_float and WEBGL_color_buffer_float, and the
WebGL 2.0 extension EXT_color_buffer_float. Enable these
implicitly for WebGL 1.0 in the OES_texture_float and
OES_texture_half_float extensions, restoring the previous
functionality.

Translate 32-bit floating point texture formats appropriately for
the ANGLE backend. Fix some failures in previously-skipped
conformance tests. The new code passes the more stringent
top-of-tree WebGL 1.0.4 and 2.0.1 conformance tests related to
floating-point texture renderability, which are not yet in the
WebKit repository.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

• html/canvas/EXTColorBufferFloat.cpp: Copied from Source/WebCore/html/canvas/OESTextureHalfFloat.cpp.

(WebCore::EXTColorBufferFloat::EXTColorBufferFloat):
(WebCore::EXTColorBufferFloat::getName const):
(WebCore::EXTColorBufferFloat::supported):

• html/canvas/EXTColorBufferFloat.h: Copied from Source/WebCore/html/canvas/OESTextureFloat.h.
• html/canvas/EXTColorBufferFloat.idl: Added.
• html/canvas/EXTColorBufferHalfFloat.cpp: Copied from Source/WebCore/html/canvas/OESTextureFloat.cpp.

(WebCore::EXTColorBufferHalfFloat::EXTColorBufferHalfFloat):
(WebCore::EXTColorBufferHalfFloat::getName const):
(WebCore::EXTColorBufferHalfFloat::supported):

• html/canvas/EXTColorBufferHalfFloat.h: Copied from Source/WebCore/html/canvas/OESTextureFloat.h.
• html/canvas/EXTColorBufferHalfFloat.idl: Added.
• html/canvas/OESTextureFloat.cpp:

(WebCore::OESTextureFloat::OESTextureFloat):
(WebCore::OESTextureFloat::supported):

• html/canvas/OESTextureFloat.h:
• html/canvas/OESTextureHalfFloat.cpp:

(WebCore::OESTextureHalfFloat::OESTextureHalfFloat):
(WebCore::OESTextureHalfFloat::supported):

• html/canvas/OESTextureHalfFloat.h:
• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
(WebCore::WebGL2RenderingContext::getParameter):

• html/canvas/WebGLColorBufferFloat.cpp: Copied from Source/WebCore/html/canvas/OESTextureFloat.cpp.

(WebCore::WebGLColorBufferFloat::WebGLColorBufferFloat):
(WebCore::WebGLColorBufferFloat::getName const):
(WebCore::WebGLColorBufferFloat::supported):

• html/canvas/WebGLColorBufferFloat.h: Copied from Source/WebCore/html/canvas/OESTextureFloat.h.
• html/canvas/WebGLColorBufferFloat.idl: Added.
• html/canvas/WebGLExtension.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::getParameter):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::copyTexImage2D):

• html/canvas/WebGLRenderingContextBase.h:
• platform/graphics/angle/ExtensionsGLANGLE.cpp:

(WebCore::ExtensionsGLANGLE::adjustWebGL1TextureInternalFormat):
(WebCore::ExtensionsGLANGLE::texImage2DRobustANGLE):

• platform/graphics/angle/ExtensionsGLANGLE.h:
• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::texImage2DDirect):

LayoutTests:

Update tex-mipmap-levels.html to top-of-tree to fix incorrect test
cases. Rebaseline layout tests which are either now all passing,
or have progressed. Temporarily skip a couple of tests, previously
skipped because of lack of the EXT_color_buffer_float extension,
which are failing because of Bug 211156.

• TestExpectations:
• fast/canvas/webgl/readPixels-float-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/copy-texture-image-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels-expected.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/tex-mipmap-levels.html:

11:53 AM Changeset in webkit [260907] by jer.noble@apple.com

• 2 edits in trunk/Source/WTF

[Mac] Adopt kMTSupportNotification_ShouldPlayHDRVideoChanged notification
​https://bugs.webkit.org/show_bug.cgi?id=211028
<rdar://problem/61173289>

Reviewed by Aakash Jain.

Follow-up test failure fix; correct the debug/non-debug variants of SOFT_LINK_FRAMEWORK_FOR_SOURCE_WITH_EXPORT.

• wtf/win/SoftLinking.h:

11:03 AM Changeset in webkit [260906] by ysuzuki@apple.com

• 3 edits
  1 add in trunk

[JSC] JSStringJoiner is missing BigInt handling
​https://bugs.webkit.org/show_bug.cgi?id=211174

Reviewed by Mark Lam.

JSTests:

• stress/bigint-to-string-in-array.js: Added.

(shouldBe):

Source/JavaScriptCore:

JSStringJoiner missed handling of BigInt (specifically BigInt32) and appending empty string incorrectly.
In debug build, assertion hits. We should support BigInt in JSStringJoiner.

• runtime/JSStringJoiner.h:

(JSC::JSStringJoiner::appendWithoutSideEffects):

10:52 AM Changeset in webkit [260905] by Alan Bujtas

• 4 edits
  2 adds in trunk

Header is blank on ​https://nader.org
​https://bugs.webkit.org/show_bug.cgi?id=205747
<rdar://problem/58305910>

Reviewed by Simon Fraser.

Source/WebCore:

Do not use stale containing block width value while computing preferred width.

Test: fast/text/text-indent-inside-float.html

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):

LayoutTests:

• fast/text/text-indent-inside-float-expected.html: Added.
• fast/text/text-indent-inside-float.html: Added.
• platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:

10:20 AM Changeset in webkit [260904] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Set _STAttributionDisplayName to iOS WebContent Info plist
​https://bugs.webkit.org/show_bug.cgi?id=210772
<rdar://problem/62075201>

Reviewed by Eric Carlson.

Set _STAttributionDisplayName to 'Website' value.

• WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:

10:20 AM Changeset in webkit [260903] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][TFC] Take row span into account when checking for missing cells
​https://bugs.webkit.org/show_bug.cgi?id=211184

Reviewed by Antti Koivisto.

The tree builder looks for missing cells in the table grid and fills in the gaps with empty cells.
This patch takes row spanning into account and make sure we don't end up adding an extra, redundant cell.

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::buildTableStructure):

9:55 AM Changeset in webkit [260902] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Update SWServer.cpp originURL after ​https://trac.webkit.org/changeset/260707
​https://bugs.webkit.org/show_bug.cgi?id=211169

Reviewed by Alex Christensen.

• workers/service/server/SWServer.cpp:

(WebCore::originURL):
No need to dereference port since URL::setPort takes an Optional.

9:50 AM Changeset in webkit [260901] by youenn@apple.com

• 4 edits in trunk/LayoutTests

http/tests/media/media-stream/device-change-event-in-iframe.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=211119
<rdar://problem/62457151>

Reviewed by Eric Carlson.

Make sure duplicate ondevicechange events do not create flakiness.

• http/tests/media/media-stream/device-change-event-in-iframe-expected.txt:
• http/tests/media/media-stream/device-change-event-in-iframe.html:
• http/tests/media/media-stream/resources/device-change-iframe.html:

9:17 AM Changeset in webkit [260900] by Kate Cheney

• 27 edits
  4 adds
  4 deletes in trunk

Refactor layout tests after updates to In-App Browser Privacy
​https://bugs.webkit.org/show_bug.cgi?id=211146
<rdar://problem/62524127>

Reviewed by Brent Fulgham.

Source/WebKit:

Tests: http/tests/in-app-browser-privacy/app-bound-domain-gets-app-bound-session.html

http/tests/in-app-browser-privacy/non-app-bound-domain-does-not-get-app-bound-session.html

Removes setInAppBrowserPrivacyEnabled, which is no longer needed by
layout tests. Setting this in TestOptions is enough.
getWebViewCategory is not needed because this patch deletes the only test
which uses it. Lastly, adds a new function to clear app-bound sessions
now that multiple tests are checking for them.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::clearAppBoundSession):
(WebKit::NetworkProcess::setInAppBrowserPrivacyEnabled): Deleted.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::clearAppBoundSession):
(WebKit::NetworkSession::setInAppBrowserPrivacyEnabled): Deleted.

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::appBoundSession):
(WebKit::NetworkSessionCocoa::clearAppBoundSession):

• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreClearAppBoundSession):
(WKWebsiteDataStoreSetInAppBrowserPrivacyEnabled): Deleted.

• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _getWebViewCategoryFor:completionHandler:]): Deleted.

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::clearAppBoundSession):
(WebKit::NetworkProcessProxy::setInAppBrowserPrivacyEnabled): Deleted.

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::clearAppBoundSession):
(WebKit::WebsiteDataStore::setInAppBrowserPrivacyEnabled): Deleted.

• UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

Removes two unused functions after updating the test cases.
setInAppBrowserPrivacyEnabled is no longer needed, setting this
in TestOptions is enough. getWebViewCategory is not needed because
this patch deletes the only test which uses it.

Adds a function to clear app-bound sessions between tests now that
multiple tests check for them.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::getWebViewCategory): Deleted.
(WTR::TestRunner::callDidReceiveWebViewCategoryCallback): Deleted.
(WTR::TestRunner::setInAppBrowserPrivacyEnabled): Deleted.
(WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback): Deleted.

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::resetStateToConsistentValues):
Move the call to clear the bundle id to happen in
resetStateToConsistentValues to make sure the next test can set the
value if needed (otherwise results in a call to exit(1)).

(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::clearAppBoundSession):
(WTR::TestController::getWebViewCategory): Deleted.
(WTR::TestController::setInAppBrowserPrivacyEnabled): Deleted.

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled): Deleted.
(WTR::TestInvocation::didReceiveWebViewCategory): Deleted.

• WebKitTestRunner/TestInvocation.h:
• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):
App-bound WebViews now require a special configuration argument. This
patch adds logic to enable that using a new TestOption.
(WTR::TestController::getWebViewCategory): Deleted.

LayoutTests:

Updates the test cases in 2 ways:

1. Deletes app-bound-domain.html, which is fully and properly tested

using API tests and is unnecessary here.

2. Splits switch-session-on-navigation-to-app-bound-domain.html into

two separate tests now that navigation between app-bound and
non-app-bound WebViews is not allowed.

• http/tests/in-app-browser-privacy/app-bound-domain-expected.txt: Removed.
• http/tests/in-app-browser-privacy/app-bound-domain-gets-app-bound-session-expected.txt: Added.
• http/tests/in-app-browser-privacy/app-bound-domain-gets-app-bound-session.html: Added.
• http/tests/in-app-browser-privacy/app-bound-domain.html: Removed.
• http/tests/in-app-browser-privacy/non-app-bound-domain-does-not-get-app-bound-session-expected.txt: Added.
• http/tests/in-app-browser-privacy/non-app-bound-domain-does-not-get-app-bound-session.html: Added.
• http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain-expected.txt: Removed.
• http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html: Removed.

9:09 AM Changeset in webkit [260899] by commit-queue@webkit.org

• 10 edits
  7 adds in trunk

[GPUP][GTK] compile GPUProcess in GTK port
​https://bugs.webkit.org/show_bug.cgi?id=208814

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2020-04-29
Reviewed by Don Olmstead.

Enable GPUProcess compilation in WebKitGTK as an experimental
feature

.:

• Source/cmake/OptionsGTK.cmake: sort alphabetically WebKit

options for GTK port and enable GPU_PROCESS if experimental
features option is enabled.

Source/WebKit:

No new tests required.

• GPUProcess/GPUConnectionToWebProcess.cpp: guard

UserMediaCaptureManagerProxy for Cocoa platform only.
(WebKit::GPUConnectionToWebProcess::dispatchMessage): guard
messages from UserMediaCaptureManagerProxy for Cocoa platform,
moving up this guard from video track messages.
(WebKit::GPUConnectionToWebProcess::mediaKeyStorageDirectory):
removed guard for this function of ENCRYPTED_MEDIA leaving only
LEGACY_ENCRYPTED_MEDIA, since it's were it is defined.
(WebKit::GPUConnectionToWebProcess::setOrientationForMediaCapture):
guard the content of this function for Cocoa platform, since it is
calling a UserMediaCaptureManagerProxy object.

• GPUProcess/GPUProcess.cpp: Replace the included header to match

with the used symbols in file.

• GPUProcess/gstreamer/GPUProcessGStreamer.cpp: Added.

(WebKit::GPUProcess::initializeProcess): Empty function.
(WebKit::GPUProcess::initializeProcessName): Empty function.
(WebKit::GPUProcess::initializeSandbox): Empty function.

• GPUProcess/gstreamer/GPUProcessMainGStreamer.cpp: Added.

(WebKit::initializeAuxiliaryProcess<GPUProcess>): New function.
(WebKit::GPUProcessMain): New function.

• GPUProcess/media/RemoteLegacyCDMFactoryProxy.cpp: changed guard

for this file from ENCRYPTED_MEDIA to LEGACY_ENCRYPTED_MEDIA to
match with its header file.

• GPUProcess/media/gstreamer/RemoteMediaPlayerProxyGStreamer.cpp: Added.

(WebKit::RemoteMediaPlayerProxy::prepareForPlayback):
New function that raises noImplemented()
(WebKit::RemoteMediaPlayerProxy::mediaPlayerFirstVideoFrameAvailable):
New function that raises noImplemented()
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged):
New function that raises noImplemented()
(WebKit::RemoteMediaPlayerProxy::enterFullscreen): New function
that raises noImplemented()
(WebKit::RemoteMediaPlayerProxy::exitFullscreen): New function
that raises noImplemented()

• PlatformGTK.cmake: add Platform/generic header directory.
• SourcesGTK.txt: Add the new files and

GPUProcess/media/RemoteAudioDestinationManager.cpp

• WebProcess/GPU/GPUProcessConnection.cpp: guard

UserMediaCaptureManager for Cocoa platform only.
(WebKit::GPUProcessConnection::dispatchMessage): guard messages
from UserMediaCaptureManager for Cocoa platform, moving up this
guard applied also for video track.

• WebProcess/GPU/media/RemoteCDM.cpp: include missing header

GPUProcessConnection.h

• WebProcess/GPU/media/gstreamer/VideoLayerRemoteGStreamer.cpp: Added.

(WebKit::createVideoLayerRemote): New function
that raises noImplemented()

9:06 AM Changeset in webkit [260898] by Alan Bujtas

• 10 edits in trunk/Source/WebCore

[LFC] FormattingContext::constraintsForInFlow/OutOfFlowContent should take const ContainerBox&
​https://bugs.webkit.org/show_bug.cgi?id=211161

Reviewed by Antti Koivisto.

Leaf boxes should not need to compute constraints (as by definition they don't have in/out-of-flow descendants).

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::constraintsForOutOfFlowContent):
(WebCore::Layout::FormattingContext::Geometry::constraintsForInFlowContent):

• layout/FormattingContextQuirks.cpp:

(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForBoxAndAncestors):

• layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):

• layout/blockformatting/PrecomputedBlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedPositiveNegativeValues const):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutCell):

8:25 AM Changeset in webkit [260897] by aakash_jain@apple.com

• 3 edits in trunk/Tools

[ews] Display flaky test names in build summary when ReRunJavaScriptCoreTests passes
​https://bugs.webkit.org/show_bug.cgi?id=210855

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(ReRunJavaScriptCoreTests.evaluateCommand): Display flaky test names in build summary.

• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and removed extra TestReRunJavaScriptCoreTests class.

7:55 AM Changeset in webkit [260896] by jh718.park@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Remove no longer used variable and the build warning below.
warning: unused variable ‘view’ [-Wunused-variable]

No new tests, no new behaviour changes.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):

7:49 AM Changeset in webkit [260895] by Devin Rousso

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: don't immediately attempt to perform a search whenever the find string changes
​https://bugs.webkit.org/show_bug.cgi?id=211164

Reviewed by Timothy Hatcher.

• UserInterface/Base/Main.js:

(WI.updateFindString):
(WI._populateFind):

• UserInterface/Views/ContentBrowser.js:

(WI.ContentBrowser.prototype.handlePopulateFindShortcut):
(WI.ContentBrowser.prototype.handleFindStringUpdated): Deleted.
Only update the searchQuery of the WI.FindBanner and performSearch when the find
next/previous keyboard shortcut is activated, not when the find string is populated/updated,
unless the update came from the populate find keyboard shortcut.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.handlePopulateFindShortcut):
(WI.LogContentView.prototype.handleFindNextShortcut):
(WI.LogContentView.prototype.handleFindPreviousShortcut):
(WI.LogContentView.prototype.highlightPreviousSearchMatch):
(WI.LogContentView.prototype.highlightNextSearchMatch):
(WI.LogContentView.prototype.handleFindStringUpdated): Deleted.
Ensure that the logic for performing a search if the searchQuery of the WI.FindBanner
doesn't match the current WI.findString is also performed when in the split console.

4:47 AM Changeset in webkit [260894] by Claudio Saavedra

• 2 edits in trunk/Source/WebKit

[GTK4] Unreviewed compile-warning fixes

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSetEnableBackForwardNavigationGesture):
(webkitWebViewBaseWillSwapWebProcess):

4:40 AM Changeset in webkit [260893] by Carlos Garcia Campos

• 2 edits in trunk/Tools

Unreviewed. Fix GTK4 build after r260891

• MiniBrowser/gtk/BrowserWindow.c:

4:33 AM Changeset in webkit [260892] by aboya@igalia.com

• 3 edits in trunk/Source/WebCore

PlatformMediaResourceLoader should be destroyed on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=211155

Reviewed by Xabier Rodriguez-Calvar.

PlatformMediaResourceLoader is only safe to use from the main thread.
A tricky detail is this includes its destruction. The same is true for
PlatformMediaResource.

Both classes are ThreadSafeRefCounted<> classes and therefore
WTF::DestructionThread::Main can be used to ensure destruction is run
in the correct thread with no need for additional client code.

• platform/graphics/PlatformMediaResourceLoader.h:
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(WebKitWebSrcPrivate::StreamingMembers::~StreamingMembers):

3:36 AM Changeset in webkit [260891] by Claudio Saavedra

• 7 edits in trunk/Tools

[GTK] Remove deprecated GTK API calls from MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=211171

Reviewed by Carlos Garcia Campos.

In preparation to porting MiniBrowser to GTK4, remove
all deprecated API calls. Also get rid of the --geometry
command-line argument and make it a no-op.

• MiniBrowser/gtk/BrowserDownloadsBar.c:

(browser_downloads_bar_init):
(browser_downloads_bar_new):
(actionButtonClicked):
(browser_download_init):
(downloadFinished):

• MiniBrowser/gtk/BrowserSearchBar.c:

(doSearch):
(searchEntryMenuIconPressedCallback):
(browser_search_bar_init):

• MiniBrowser/gtk/BrowserSettingsDialog.c:

(browser_settings_dialog_init):

• MiniBrowser/gtk/BrowserTab.c:

(createInfoBarQuestionMessage):
(browserTabConstructed):

• MiniBrowser/gtk/BrowserWindow.c:

(browserWindowHistoryItemSelected):
(browserWindowHistoryItemActivated):
(browserWindowCreateBackForwardMenu):
(browserWindowUpdateNavigationMenu):
(backForwardlistChanged):
(updateUriEntryIcon):
(webViewIsLoadingChanged):
(browserWindowSetupEditorToolbarItem):
(browserWindowSetupEditorToolbar):
(browserWindowSwitchTab):
(browserWindowSetupToolbarItem):
(browser_window_init):
(browserWindowUpdateNavigationActions): Deleted.

• MiniBrowser/gtk/main.c:

(main):

3:23 AM Changeset in webkit [260890] by commit-queue@webkit.org

• 20 edits in trunk/Source

Make PolicyChecker an inner class of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=211138

Patch by Rob Buis <​rbuis@igalia.com> on 2020-04-29
Reviewed by Alex Christensen.

Source/WebCore:

PolicyChecker HistoryController an inner class of FrameLoader, this allows us to move some methods
only used by PolicyChecker out of the FrameLoader public API. Because it is not possible to forward declare
an enum class in an inner class, move ShouldContinue out of the PolicyChecker class and rename it
to ShouldContinuePolicyCheck.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):

• loader/FrameLoader.h:
• loader/FrameLoaderTypes.h:
• loader/MediaResourceLoader.cpp:

(WebCore::MediaResource::responseReceived):

• loader/PolicyChecker.cpp:
• loader/PolicyChecker.h:
• platform/graphics/PlatformMediaResourceLoader.h:

(WebCore::PlatformMediaResourceClient::responseReceived):

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::PlatformResourceMediaLoader::responseReceived):

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(CachedResourceStreamingClient::responseReceived):

• platform/network/cocoa/WebCoreNSURLSession.mm:

(WebCore::WebCoreNSURLSessionDataTaskClient::responseReceived):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:completionHandler:]):

Source/WebKit:

Adapt to PolicyChecker::ShouldContinue change.

• GPUProcess/media/RemoteMediaResource.cpp:

(WebKit::RemoteMediaResource::responseReceived):

• GPUProcess/media/RemoteMediaResource.h:
• GPUProcess/media/RemoteMediaResourceManager.cpp:

(WebKit::RemoteMediaResourceManager::responseReceived):

• GPUProcess/media/RemoteMediaResourceManager.h:
• GPUProcess/media/RemoteMediaResourceManager.messages.in:
• Scripts/webkit/messages.py:
• WebProcess/GPU/media/RemoteMediaResourceProxy.cpp:

(WebKit::RemoteMediaResourceProxy::responseReceived):

• WebProcess/GPU/media/RemoteMediaResourceProxy.h:

3:06 AM Changeset in webkit [260889] by Adrian Perez de Castro

• 12 edits in trunk

[GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
​https://bugs.webkit.org/show_bug.cgi?id=170553

Source/WebCore:

Reviewed by Carlos Garcia Campos.

• platform/gtk/GtkVersioning.h: Add replacements for GtkPopover functions which are no longet available in GTK4.

(gtk_popover_menu_new): Added.
(gtk_popover_bind_model): Added.
(gtk_popover_set_relative_to): Added.

Source/WebKit:

Reviewed by Carlos Garcia Campos.

Replace GtkMenuShell with a GtkPopoverMenu for context menus. The former is not available
at all in GTK4, and the later allows for simplifying the positioning code: it is enough
to provide a point in WebKitWebView widget where to place the popup, and GTK takes care
of everything. This removes the custom positioning code (as it is not needed anymore),
which did GdkScreen-relative calculations that GTK4 does not support.

No new tests needed.

• Shared/glib/WebContextMenuItemGlib.h:
• UIProcess/API/glib/WebKitWebView.cpp:

(contextMenuDismissed): Change parameter from GtkMenuShell to GtkMenuShell to GtkWidget.
(webkitWebViewPopulateContextMenu): Connect to the GtkPopover::closed signal instead of
GtkMenuShell::deactivate.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(activeContextMenuClosed): Renamed from activeContextMenuUnmapped(), changed parameter
from GtkMenuShell to GtkWidget, and compare with WebContextMenuProxyGtk::gtkWidget().
(activeContextMenuUnmapped): Renamed to activeContextMenuClosed().
(webkitWebViewBaseSetActiveContextMenuProxy): Connect to the GtkPopover::closed signal
instead of GtkMenuShell::deactivate.
(webkitWebViewBaseGetActiveContextMenuProxy):

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/API/gtk/WebKitWebViewGtk.cpp:
• UIProcess/gtk/WebContextMenuProxyGtk.cpp: Arrange to use GtkPopoverMenu instead of

GtkMenuShell.

• UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::populate):
(WebKit::WebContextMenuProxyGtk::showContextMenuWithItems): Simplify using
m_context.menuLocation() to obtain the location where to make the context menu popup
next to, which allows removing the ::menuPositionFunction() callback as well.
(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk):
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):

• UIProcess/gtk/WebContextMenuProxyGtk.h: Remove declarations for ::menuPositionFunction()

and ::m_popupPosition, which are now unneeded.
(WebKit::WebContextMenuProxyGtk::gtkWidget const): Renamed from ::gtkMenu(), and made it
return a GtkWidget.

Tools:

Minor adaptations needed in the API tests to account for the differences between
GtkMenuShell and GtkPopoverMenu.

Reviewed by Carlos Garcia Campos.

• TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:

(lookupWidgetsWalkChild): Added.
(lookupWidgets): Added.

2:06 AM Changeset in webkit [260888] by commit-queue@webkit.org

• 12 edits
  1 delete in trunk/Source

Unreviewed, reverting r260650.
​https://bugs.webkit.org/show_bug.cgi?id=211172

It is breaking internal bots (Requested by youenn on #webkit).

Reverted changeset:

"Call STDynamicActivityAttributionPublisher in the WebProcess"
​https://bugs.webkit.org/show_bug.cgi?id=210772
​https://trac.webkit.org/changeset/260650

1:23 AM Changeset in webkit [260887] by Devin Rousso

• 6 edits in trunk/Source

Web Inspector: Uncaught Exception: SyntaxError: Unexpected identifier 'E'. Expected either a closing ']' or a ',' following an array element.
​https://bugs.webkit.org/show_bug.cgi?id=211163

Reviewed by Joseph Pecoraro.

Source/WebKit:

• WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::updateFindString):

• WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::updateFindString):
Use the newly exposed JSON::Value::escapeString to ensure that the findString will not
throw a JavaScript exception when placed in the InspectorFrontendAPI call.

Source/WTF:

• wtf/JSONValues.h:
• wtf/JSONValues.cpp:

(WTF::JSONImpl::appendDoubleQuotedString):
(WTF::JSONImpl::Value::escapeString): Added.
Pull out and expose the logic for escaping strings so it can be used elsewhere.

1:14 AM Changeset in webkit [260886] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Switch to audiointerleave
​https://bugs.webkit.org/show_bug.cgi?id=211124

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-04-29
Reviewed by Xabier Rodriguez-Calvar.

The audiointerleave element is a drop-in replacement of
interleave. It should behave a bit better in live.

No new tests, existing webaudio tests cover this change.

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcChangeState):

12:59 AM Changeset in webkit [260885] by svillar@igalia.com

• 2 edits in trunk

Add ccls config file to the list of ignored files
​https://bugs.webkit.org/show_bug.cgi?id=210426

Reviewed by Tim Horton.

• .gitignore: ccls can read configuration options from a .ccls file in

the project root directory. Let's just ignore it.

12:57 AM Changeset in webkit [260884] by svillar@igalia.com

• 14 edits in trunk/Source/WebCore

[WebXR][WPE] Implement XRTest::simulateDeviceConnection()
​https://bugs.webkit.org/show_bug.cgi?id=210912

Reviewed by Dean Jackson.

This API gives tests the ability to spin up a simulated XR device which
is an XR device which from the point of view of the WebXR API behaves
like a normal XR device. These simulated XR devices can be controlled by
the associated FakeXRDevice object.

No new tests as this is machinery required to execute tests when
implementing the WebXR API.

• Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::WebXRSystem): Initialize the default inline device.
(WebCore::WebXRSystem::registerSimulatedXRDeviceForTesting): Add a newly
created simulated XR device to the list of available devices. Update
also the active immersive device and current inline device.
(WebCore::WebXRSystem::unregisterSimulatedXRDeviceForTesting): Remove
all simulated devices from the list of immersive XR devices.

• Modules/webxr/WebXRSystem.h: New DummyInlineDevice which represents

the default inline device which must not provide pose information.

• Modules/webxr/WebXRView.cpp:

(WebCore::WebXRView::WebXRView): Removed some methods that should be
really part of a fake XRView instance.
(WebCore::WebXRView::setProjectionMatrix): Add implementation.
(WebCore::WebXRView::eye const): Deleted.
(WebCore::WebXRView::projectionMatrix const): Deleted.
(WebCore::WebXRView::transform const): Deleted.

• Modules/webxr/WebXRView.h:

(WebCore::WebXRView::eye const): Implemented.
(WebCore::WebXRView::projectionMatrix const): Ditto.
(WebCore::WebXRView::transform const): Ditto.
(WebCore::WebXRView::setEye): Ditto.
(WebCore::WebXRView::setTransform): Ditto.

• Modules/webxr/XRReferenceSpaceType.h: Moved the definitions to PlatformXR.
• platform/xr/PlatformXR.cpp:

(PlatformXR::Instance::nextDeviceId): New method which returns uniquely
defined ids for XR devices.
(PlatformXR::Device::Device):

• platform/xr/PlatformXR.h:

(PlatformXR::Device::id const): New method.
(PlatformXR::Device::supports const): Ditto.
(PlatformXR::Device::setSupportedModes): Ditto.
(PlatformXR::Device::setEnabledFeatures): Ditto.
(PlatformXR::Device::operator== const): Ditto.

• testing/FakeXRViewInit.h: fieldOfView is optional.
• testing/WebFakeXRDevice.cpp:

(WebCore::FakeXRView::setFieldOfView): Implemented.
(WebCore::WebFakeXRDevice::setViews): Ditto.
(WebCore::WebFakeXRDevice::setViewerOrigin): Ditto.
(WebCore::WebFakeXRDevice::clearViewerOrigin): Ditto.
(WebCore::WebFakeXRDevice::setFloorOrigin): Ditoo.
(WebCore::WebFakeXRDevice::clearFloorOrigin): Ditto.
(WebCore::WebFakeXRDevice::parseRigidTransform): Added.
(WebCore::WebFakeXRDevice::parseView): Ditto.

• testing/WebFakeXRDevice.h: Defined FakeXRView class which wraps a

XRView adding some associated data as the field of view and viewport.
Also defined the SimulatedXRDevice which is an PlatformXR::Device with
some additional data useful for testing purpouses.

• testing/WebXRTest.cpp:

(WebCore::WebXRTest::simulateDeviceConnection): Create a new
FakeXRDevice with an associated simulated XR device with the data
provided by a FakeXRDeviceInit.
(WebCore::WebXRTest::disconnectAllDevices): Remove all simulated devices
from the list of immersive devices.

• testing/WebXRTest.h: Call simulateDeviceConnection with ScriptExecutionContext.
• testing/WebXRTest.idl: Ditto.

12:36 AM Changeset in webkit [260883] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Gardening, update expectations after r260815
​https://bugs.webkit.org/show_bug.cgi?id=211168

Unreviewed gardening.

• platform/gtk/TestExpectations:

12:15 AM Changeset in webkit [260882] by sbarati@apple.com

• 16 edits
  1 add in trunk/Source

U_STRING_NOT_TERMINATED_WARNING ICU must be handled when using the output buffer as a C string
​https://bugs.webkit.org/show_bug.cgi?id=211142
<rdar://problem/62530860>

Reviewed by Darin Adler.

Source/JavaScriptCore:

• runtime/IntlDateTimeFormat.cpp:

(JSC::defaultTimeZone):
(JSC::canonicalizeTimeZoneName):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::format):
(JSC::IntlDateTimeFormat::formatToParts):

• runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::format):
(JSC::IntlNumberFormat::formatToParts):

• runtime/IntlObject.cpp:

(JSC::convertICULocaleToBCP47LanguageTag):
(JSC::canonicalizeLanguageTag):

• runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::formatInternal):
(JSC::IntlRelativeTimeFormat::formatToParts):

• runtime/StringPrototype.cpp:

(JSC::toLocaleCase):
(JSC::normalize):

Source/WebCore:

• editing/TextIterator.cpp:

(WebCore::normalizeCharacters):

• platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::decimalSymbol):
(WebCore::LocaleICU::decimalTextAttribute):
(WebCore::getDateFormatPattern):
(WebCore::LocaleICU::createLabelVector):
(WebCore::getFormatForSkeleton):

• platform/text/LocaleToScriptMappingICU.cpp:

(WebCore::localeToScriptCodeForFontSelection):

• platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::decode):
(WebCore::TextCodecICU::encode):

Source/WTF:

Most of our uses of ICU require us to produce a buffer of the correct
length. We often test if the first call to ICU API succeeds, and if it
doesn't, we grow to the required buffer size, and try again. However,
there are a few APIs that we use like this, except that they write their
output to a C string instead of a buffer.

In a couple scenarios when we were producing C strings, we were only testing
for the U_BUFFER_OVERFLOW_ERROR, instead of both U_BUFFER_OVERFLOW_ERROR and
U_STRING_NOT_TERMINATED_WARNING. This patch fixes those bugs. It also
introduces two new helper methods for testing error codes returned by ICU.

• The first is needsToGrowToProduceBuffer, which returns true if we need to

grow the buffer and re-call into ICU to get the result.

• The second is needsToGrowToProduceCString, which returns true if we need to

grow the buffer and re-call into ICU to produce a valid C string.

I've audited all uses of U_BUFFER_OVERFLOW_ERROR and converted them to use one
of the above helper methods instead.

The issues in our handling of U_STRING_NOT_TERMINATED_WARNING were caught on iOS JSC
tests in JSTests/stress/intl-datetimeformat.js

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/text/LineBreakIteratorPoolICU.h:

(WTF::LineBreakIteratorPool::makeLocaleWithBreakKeyword):

• wtf/text/StringView.cpp:

(WTF::normalizedNFC):

• wtf/unicode/icu/ICUHelpers.h: Added.

(WTF::needsToGrowToProduceCString):
(WTF::needsToGrowToProduceBuffer):

12:09 AM Changeset in webkit [260881] by Noam Rosenthal

• 4 edits in trunk/Source

Add StringView::isAllSpecialCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=211150

Source/WebCore:

Reviewed by Darin Adler.

Uses new StringView::isAllSpecialCharacters() instead of creating a StringImpl.

No new tests.

• rendering/TextPainter.cpp:

(WebCore::TextPainter::paintTextOrEmphasisMarks):

Source/WTF:

This enables checking for whitespace-only strings without allocating a StringImpl wrapper.

Reviewed by Darin Adler.

• wtf/text/StringView.h:

(WTF::isSpecialCharacter const):

Apr 28, 2020:

11:41 PM Changeset in webkit [260880] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix 32-bit build.

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::createFrom):
(JSC::Int32BigIntImpl::digit):

11:26 PM Changeset in webkit [260879] by Ryan Haddad

• 2 edits in trunk/LayoutTests

REGRESSION: [ Mac ] webgl/1.0.3/conformance/textures/texture-upload-size.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=205757

Unreviewed test gardening.

Remove flaky expectation since the test has been consistently passing for the past few weeks.

• platform/mac/TestExpectations:

11:23 PM Changeset in webkit [260878] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r260876 and r260877.
​https://bugs.webkit.org/show_bug.cgi?id=211165

Broke build (Requested by yusukesuzuki on #webkit).

Reverted changesets:

"Unreviewed, build fix on watchOS"
​https://bugs.webkit.org/show_bug.cgi?id=210978
​https://trac.webkit.org/changeset/260876

"Unreviewed, speculative build fix on watchOS part 2"
​https://bugs.webkit.org/show_bug.cgi?id=210978
​https://trac.webkit.org/changeset/260877

11:14 PM Changeset in webkit [260877] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, speculative build fix on watchOS part 2
​https://bugs.webkit.org/show_bug.cgi?id=210978

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::createFrom):
(JSC::Int32BigIntImpl::digit):

• runtime/JSBigInt.h:

11:09 PM Changeset in webkit [260876] by ysuzuki@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix on watchOS
​https://bugs.webkit.org/show_bug.cgi?id=210978

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::createFrom):
(JSC::Int32BigIntImpl::digit):

• runtime/JSBigInt.h:

11:04 PM Changeset in webkit [260875] by Ryan Haddad

• 12 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r259880. rdar://problem/62271251

Fix failing legacy CSP tests by converting them to modern tests instead.
​https://bugs.webkit.org/show_bug.cgi?id=210310

Reviewed by Daniel Bates.

Convert these tests from verifying the (now removed) X-WebKit-CSP
header to the modern Content-Security-Policy header. Since we
don't have equivalent tests for the modern CSP header and it's not
very useful to have tons of tests for a feature we no longer
support.

• http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed.html:
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked-expected.txt:
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked.html:
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored.html:
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed.html:
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt:
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked.html:
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked-expected.txt:
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked.html:
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt:
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@259880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:56 PM Changeset in webkit [260874] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Upgrade motionmark1.1.plan to r260656
​https://bugs.webkit.org/show_bug.cgi?id=211143

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-04-28
Reviewed by Darin Adler.

r260656 includes a fix for the Multiply test.

• Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan:

10:53 PM Changeset in webkit [260873] by Ryan Haddad

• 2 edits in trunk/LayoutTests

REGRESSION: [ Mac wk1 ] fast/canvas/webgl/canvas-webgl-page-cache.html is flaky crashing in rx::GetFunctionsGL
​https://bugs.webkit.org/show_bug.cgi?id=208345

Unreviewed test gardening.

Remove flaky expectation since the test has been consistently passing for the past few weeks.

• platform/mac-wk1/TestExpectations:

10:50 PM Changeset in webkit [260872] by Ryan Haddad

• 2 edits in branches/safari-609-branch/LayoutTests

Unreviewed, land test expectations for rdar://62268126

• TestExpectations:

10:43 PM Changeset in webkit [260871] by Ryan Haddad

• 1 edit
  2 adds in branches/safari-609-branch/Tools

Unreviewed, cherry-pick scripts from r259811. rdar://62268126

• BuildSlaveSupport/trigger-crash-log-submission: Added.
• BuildSlaveSupport/wait-for-crash-collection: Added.

10:36 PM Changeset in webkit [260870] by Said Abou-Hallawa

• 2 edits in trunk/Source/WebCore

Rendering update steps should use Seconds for the timestamps
​https://bugs.webkit.org/show_bug.cgi?id=210990

Unreviewed.

serviceRequestAnimationFrameCallbacks() should return rounded milliseconds.
This rounding was removed in r260736. So put it back.

• dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceRequestAnimationFrameCallbacks):

10:29 PM Changeset in webkit [260869] by Carlos Garcia Campos

• 7 edits in trunk/Source

[GTK4] Add support for key events
​https://bugs.webkit.org/show_bug.cgi?id=211128

Reviewed by Adrian Perez de Castro.

Source/WebCore:

• platform/gtk/GtkVersioning.h:

(gdk_event_get_keyval):
(gdk_event_get_keycode):

Source/WebKit:

Handle key-pressed and key-released events using a GtkEventControllerKey. To receive key events the widget needs
to be focused, so also implement GtkWidgetClass::grab_focus and handle enter and leave focus events. GTK4 needs
the widget used by the key bindings translator to be added to a parent to be able to forward key events, so it's
now added as a child internal widget of the WebKitWeViewBase.

• Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent):

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewChildIsInternalWidget):
(webkitWebViewBaseContainerRemove):
(webkitWebViewBaseContainerForall):
(webkitWebViewBaseFocusEnter):
(webkitWebViewBaseFocusLeave):
(webkitWebViewBaseKeyPressed):
(webkitWebViewBaseKeyReleased):
(webkitWebViewBaseGrabFocus):
(webkitWebViewBaseConstructed):
(webkit_web_view_base_class_init):

• UIProcess/gtk/KeyBindingTranslator.cpp:

(WebKit::KeyBindingTranslator::KeyBindingTranslator):
(WebKit::KeyBindingTranslator::~KeyBindingTranslator):
(WebKit::handleCustomKeyBindings):
(WebKit::KeyBindingTranslator::commandsForKeyEvent):

• UIProcess/gtk/KeyBindingTranslator.h:

(WebKit::KeyBindingTranslator::widget const):
(WebKit::KeyBindingTranslator::destroyed):

10:28 PM Changeset in webkit [260868] by Ryan Haddad

• 2 edits in trunk/LayoutTests

storage/indexeddb/value-cursor-cycle.html is flaky failing because it incorrectly thinks our JS GC is precise.
​https://bugs.webkit.org/show_bug.cgi?id=210046

Unreviewed test gardening.

• platform/ios/TestExpectations: Mark test as flaky for iOS, too.

10:26 PM Changeset in webkit [260867] by Ryan Haddad

• 3 edits in trunk/LayoutTests

[ Mac ] storage/indexeddb/result-request-cycle.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=210517

Unreviewed test gardening.

• platform/ios/TestExpectations: Mark test as flaky.
• platform/mac/TestExpectations: Ditto.

10:18 PM Changeset in webkit [260866] by Ryan Haddad

• 3 edits in trunk/LayoutTests

[ iOS wk2 and Mac Debug wk2 ] imported/w3c/web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209295

Unreviewed test gardening.

Remove flaky expectations as the test has been consistently passing.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

10:16 PM Changeset in webkit [260865] by Wenson Hsieh

• 9 edits in trunk

[Text manipulation] Add a userInfo dictionary to _WKTextManipulationToken
​https://bugs.webkit.org/show_bug.cgi?id=211151
<rdar://problem/62329534>

Reviewed by Darin Adler.

Source/WebCore:

Add an extensible mechanism for the text manipulation controller to send additional
metadata for each text manipulation token through to the WebKit client, for debugging
purposes.

Test: TextManipulation.StartTextManipulationExtractsUserInfo

• editing/TextManipulationController.cpp:

(WebCore::tokenInfo):
(WebCore::TextManipulationController::observeParagraphs):

• editing/TextManipulationController.h:

Add TextManipulationTokenInfo, and add an optional TextManipulationTokenInfo member to
TextManipulationToken. For now, just send over the document URL, element tag name, and
the value of the role attribute.

(WebCore::TextManipulationController::ManipulationTokenInfo::encode const):
(WebCore::TextManipulationController::ManipulationTokenInfo::decode):
(WebCore::TextManipulationController::ManipulationToken::encode const):
(WebCore::TextManipulationController::ManipulationToken::decode):

Source/WebKit:

• UIProcess/API/Cocoa/WKWebView.mm:

(createUserInfo):
(-[WKWebView _startTextManipulationsWithConfiguration:completion:]):
(-[WKWebView _completeTextManipulation:completion:]):
(-[WKWebView _completeTextManipulationForItems:completion:]):

• UIProcess/API/Cocoa/_WKTextManipulationToken.h:
• UIProcess/API/Cocoa/_WKTextManipulationToken.mm:

(-[_WKTextManipulationToken setUserInfo:]):
(-[_WKTextManipulationToken userInfo]):

Add a new userInfo dictionary to _WKTextManipulationToken, which contains several named
NSString keys.

(-[_WKTextManipulationToken isEqualToTextManipulationToken:includingContentEquality:]):
(-[_WKTextManipulationToken _descriptionPreservingPrivacy:]):

Tools:

Add a new API test to check the userInfo dictionary on text manipulation tokens.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

9:26 PM Changeset in webkit [260864] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r260407): Over-release of NSGraphicsContext in WebKit::convertPlatformImageToBitmap()
<​https://webkit.org/b/211160>

Reviewed by Darin Adler.

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::convertPlatformImageToBitmap): Use retainPtr() instead
of adoptNS() to fix the over-release.

8:54 PM Changeset in webkit [260863] by ysuzuki@apple.com

• 10 edits
  1 add in trunk

[JSC] BigInt constructor should accept larger integers than safe-integers
​https://bugs.webkit.org/show_bug.cgi?id=210755

Reviewed by Darin Adler.

JSTests:

• stress/big-int-constructor.js:
• stress/large-number-to-bigint.js: Added.

(shouldBe):
(shouldThrow):

• test262/config.yaml:

Source/JavaScriptCore:

While our implementation of BigInt constructor only accepts safe integers, it should accept all integers.
This patch implements it by creating JSBigInt::createFrom(double). We port double bit processing part from
V8 as the same to the other part of JSBigInt.

• runtime/BigIntConstructor.cpp:

(JSC::callBigIntConstructor):

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::createFrom):

• runtime/JSBigInt.h:
• runtime/MathCommon.h:

(JSC::isInteger):
(JSC::isSafeInteger):

• runtime/NumberConstructor.cpp:

(JSC::numberConstructorFuncIsSafeInteger):

• runtime/NumberConstructor.h:

8:13 PM Changeset in webkit [260862] by Simon Fraser

• 3 edits in trunk/Source/WebCore

Update the xcfilelists.

• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:

8:03 PM Changeset in webkit [260861] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

IPC::Decoder::isValid() should just be a nullptr check
<​https://webkit.org/b/211152>
<rdar://problem/62552699>

Reviewed by Darin Adler.

• Platform/IPC/Decoder.h:

(IPC::Decoder::isValid const): Change to nullptr check. I
reviewed the code in Decoder.{cpp,h}, and I didn't see
m_bufferPos being set without a bounds check. Also added
WARN_UNUSED_RETURN to make sure the result is always checked.

7:59 PM Changeset in webkit [260860] by ddkilzer@apple.com

• 3 edits in trunk/Tools

check-webkit-style should suggest CheckedSize for Checked<size_t, RecordOverflow>
<​https://webkit.org/b/211158>

Reviewed by Darin Adler.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_wtf_checked_size): Add checker.
(check_style): Call check_wtf_checked_size() to check.
(CppChecker): Add 'runtime/wtf_checked_size'.

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_wtf_checked_size): Add tests.

5:26 PM Changeset in webkit [260859] by Lauro Moura

• 2 edits in trunk/Tools

[GTK] update-webkitgtk-libs: TypeError: cannot use a string pattern on a bytes-like object
​https://bugs.webkit.org/show_bug.cgi?id=211144

Reviewed by Michael Catanzaro.

Unconditionally decode the output from the 'id' command to make it
work with python3.

Also check if the doc directory exists before passing it to bwrap.
Should avoid errors like these:

bwrap: Can't find source path /run/user/1000/doc: No such file or directory

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

5:12 PM Changeset in webkit [260858] by Simon Fraser

• 3 edits
  2 adds in trunk

REGRESSION (r260808): Backdrops on music.apple.com are offset
​https://bugs.webkit.org/show_bug.cgi?id=211153
Source/WebCore:

<rdar://problem/62543158>

Reviewed by Zalan Bujtas.

The border-radius code path failed to offset the rounded rect by contentOffsetInCompositingLayer().

Test: compositing/filters/backdrop-filter-rect-border-radius.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateBackdropFiltersGeometry):

LayoutTests:

Reviewed by Zalan Bujtas.

• compositing/filters/backdrop-filter-rect-border-radius-expected.html: Added.
• compositing/filters/backdrop-filter-rect-border-radius.html: Added.

5:05 PM Changeset in webkit [260857] by dbates@webkit.org

• 8 edits in trunk/Source/WebKit

Move WebPage::textInputContextsInRect() to WebPageIOS.mm
​https://bugs.webkit.org/show_bug.cgi?id=211136

Reviewed by Eric Carlson.

The function WebPage::textInputContextsInRect is very specific to a client on iOS.
Although it's tempting to keep this cross-platform because its implementation does
not make use of iOS-specific technologies it does a very specific operation, the
result of which is a list of contexts to editable elements on the page. The contexts
provide enough info for the specific iOS client, but not enough to ever be useful
to any other client. Therefore move it to WebPageIOS.mm.

Only Mac and iOS were ever using this function. The former only for testing purposes
that have since been removed.

A side effect of this change is that I also move WebPageProxy::textInputContextsInRect()
from WebPageProxy.cpp to WebPageProxyIOS.mm.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::textInputContextsInRect): Deleted; moved to WebPageProxyIOS.mm.

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::textInputContextsInRect): Moved from WebPageProxy.cpp.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::textInputContextsInRect): Deleted; moved to WebPageIOS.mm.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::textInputContextsInRect): Moved from WebPage.cpp.

5:03 PM Changeset in webkit [260856] by Chris Dumez

• 13 edits
  2 deletes in trunk/Source/WebKit

[iOS][WK2] Drop process assertion logic for holding locked files
​https://bugs.webkit.org/show_bug.cgi?id=206910

Reviewed by Alex Christensen.

Drop process assertion logic for holding locked files as it is causing issues and
should no longer be needed.

The intention of this code was that the Network Process would send a
SetIsHoldingLockedFiles(bool) IPC to the UIProcess whenever there are pending
SQLite transactions and the UIProcess would then take a process assertion on behalf
of the WebProcess (or release it) to prevent / allow suspension.

This approach has some issues:

1. It was noisy in terms of IPC
2. Because it relies on an IPC to the UIProcess to keep running, it was inherently racy
3. We already have logic to deal with suspension in the network / web processes. The UIProcess sends a PrepareForSuspension IPC to its child processes. In turn, those processes will make sure to suspend their database threads to prevent any further database work. The child processes would then respond to the PrepareForSuspension IPC to let the UIProcess know they are ready to suspend. The 2 approaches were conflicting, because after the PrepareForSuspension IPC is sent, the child process could process a transaction and send the SetIsHoldingLockedFiles() IPC to the UIProcess which would incorrectly cancel the suspension.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::m_messagePortChannelRegistry): Deleted.

• NetworkProcess/NetworkProcess.h:
• Shared/WebSQLiteDatabaseTracker.cpp: Removed.
• Shared/WebSQLiteDatabaseTracker.h: Removed.
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::didSetAssertionState):
(WebKit::NetworkProcessProxy::setIsHoldingLockedFiles): Deleted.

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::setIsHoldingLockedFiles): Deleted.

• UIProcess/WebProcessProxy.h:
• UIProcess/WebProcessProxy.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebProcess.cpp:

(WebKit::m_nonVisibleProcessCleanupTimer):
(WebKit::m_webSQLiteDatabaseTracker): Deleted.

• WebProcess/WebProcess.h:

4:37 PM Changeset in webkit [260855] by dbates@webkit.org

• 4 edits in trunk/Source/WebCore

Modernize EndPointsAdjustmentMode enumeration and fix misspelled enumerator
​https://bugs.webkit.org/show_bug.cgi?id=211141

Reviewed by Eric Carlson.

Fix the misspelled enumerator DoNotAdjsutEndpoints. While I am here, make
EndPointsAdjustmentMode an enum class sized as a bool and simplify the naming
of its enumerators now that they have to be qualified. I also re-ordered them
so that DoNotAdjust is the first enumerator (it will have value 0). This doesn't
really matter, but I like it because it makes it so that this enumeration behaves
more like an equivalent boolean should casts be involved.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionByMouseIfDifferent):

• editing/FrameSelection.h:
• page/EventHandler.cpp:

(WebCore::EventHandler::updateSelectionForMouseDrag):

4:35 PM Changeset in webkit [260854] by dbates@webkit.org

• 5 edits in trunk/Source

[WebKitLegacy] Implement -hidePlaceholder and -showPlaceholderIfNecessary in terms of setCanShowPlaceholder()
​https://bugs.webkit.org/show_bug.cgi?id=211139

Reviewed by Simon Fraser.

Source/WebCore:

Remove hidePlaceholder() and showPlaceholderIfNecessary() as they are no longer needed.
Callers should use setCanShowPlaceholder() instead.

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::hidePlaceholder): Deleted.
(WebCore::HTMLTextFormControlElement::showPlaceholderIfNecessary): Deleted.

• html/HTMLTextFormControlElement.h:

Source/WebKitLegacy/mac:

Implement -hidePlaceholder and -showPlaceholderIfNecessary in terms of setCanShowPlaceholder()
because:

1. Unlike -hidePlaceholder and -showPlaceholderIfNecessary, setCanShowPlaceholder() does NOT of reach into the guts of the control and mutate its CSS.

2. Because of (1), it works correctly should future code be written that modifies the structure of the guts or the CSS of the placeholder element (which is inside the guts of the control).

3. Unlike -hidePlaceholder and -showPlaceholderIfNecessary, there is test coverage for setCanShowPlaceholder() to ensure (2).

• DOM/WebDOMOperations.mm:

(-[DOMNode hidePlaceholder]):
(-[DOMNode showPlaceholderIfNecessary]):

3:57 PM Changeset in webkit [260853] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Debug: "Outline focused element" should also outline elements with tabIndex=0
​https://bugs.webkit.org/show_bug.cgi?id=211109

Reviewed by Devin Rousso.

• UserInterface/Debug/Bootstrap.css:

(body.focus-debug [tabindex="0"]):
(body.focus-debug *:focus):

3:42 PM Changeset in webkit [260852] by ChangSeok Oh

• 5 edits in trunk/Source

[GTK] Fix build failures for ANGLE_WEBGL after r259589
​https://bugs.webkit.org/show_bug.cgi?id=211116

Reviewed by Alex Christensen.

Source/ThirdParty/ANGLE:

The ANGLE_WEBGL is broken after ANGLE is updated in r259589. Missing sources
should be added to the build target.

• PlatformGTK.cmake: Add libangle_gl_egl_sources and libangle_gl_egl_dl_sources.

Source/WebCore:

The compiler is unhappy with coverting GCGLint64 (long long int) to GLInt64 (long int).
Passing GCGLuint62 as GLuint64 is a similar issue.

No new tests since no new functionalities.

• platform/graphics/angle/ExtensionsGLANGLE.cpp:

(WebCore::ExtensionsGLANGLE::getInteger64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getInteger64i_vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBufferParameteri64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjecti64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjectui64vRobustANGLE):

• platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp:

(Nicosia::GC3DLayer::swapBuffersIfNeeded): Unaccelerated -> RenderingMode::Unaccelerated

3:34 PM Changeset in webkit [260851] by Noam Rosenthal

• 38 edits
  1 copy
  86 adds in trunk

Implement FCP (first contentful paint)
​https://bugs.webkit.org/show_bug.cgi?id=208499

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Imported paint timing tests that don't require first-paint.

• resources/import-expectations.json:
• web-platform-tests/paint-timing: Added.
• web-platform-tests/paint-timing/fcp-only: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-background-size-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-background-size.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-bg-image-set-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-bg-image-set.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-bg-image-two-steps-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-bg-image-two-steps.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-canvas-context-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-canvas-context.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-gradient-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-gradient.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-invisible-3d-rotate-descendant-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-invisible-3d-rotate-descendant.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-invisible-3d-rotate-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-invisible-3d-rotate.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-invisible-scale-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-invisible-scale-transition-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-invisible-scale-transition.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-invisible-scale.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-invisible-text-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-invisible-text.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-opacity-descendant-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-opacity-descendant.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-opacity-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-opacity.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-out-of-bounds-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-out-of-bounds-translate-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-out-of-bounds-translate.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-out-of-bounds.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-display-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-display.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-image-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-image.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-opacity-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-opacity.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-text-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-text.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-visibility-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-visibility.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-svg-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-svg.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-text-input-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-text-input.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-typographic-pseudo-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-typographic-pseudo.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-video-frame-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-video-frame.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-video-poster-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-video-poster.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-whitespace-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-whitespace.html: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-with-rtl-expected.txt: Added.
• web-platform-tests/paint-timing/fcp-only/fcp-with-rtl.html: Added.
• web-platform-tests/paint-timing/resources: Added.
• web-platform-tests/paint-timing/resources/circle.svg: Added.
• web-platform-tests/paint-timing/resources/circles.png: Added.
• web-platform-tests/paint-timing/resources/subframe-painting.html: Added.
• web-platform-tests/paint-timing/resources/subframe-sending-paint.html: Added.
• web-platform-tests/paint-timing/resources/utils.js: Added.

(waitForAnimationFrames):
(async assertNoFirstContentfulPaint):
(async assertFirstContentfulPaint.return.new.Promise):
(async assertFirstContentfulPaint):
(async test_fcp):

Source/WebCore:

Added the necessary interface, extensions to the performance interface and observer, new runtime flag.
Detecting contentfulness after layout and before actual paint, by running a "dummy" paint, similar to
invalidateControlTints() / invalidateImagesWithAsyncDecodes(). Save the result to the GraphicsContext and then to the document.
This would run for every paint until we detect a contentful one.

Note that it paints the entire frame contents, as FCP is not viewport-dependent.
Also, paint timing is currently disabled for LFC (layout formatting context), and will be dealt with later.

Tests: http/tests/performance/paint-timing/performance-paint-timing-fcp-after-visually-non-empty-for-num-chars.html

http/tests/performance/paint-timing/performance-paint-timing-fcp-after-visually-non-empty-for-style.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-background-size.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-bg-image-set.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-bg-image-two-steps.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-canvas-context.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-gradient.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-invisible-3d-rotate-descendant.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-invisible-3d-rotate.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-invisible-scale-transition.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-invisible-scale.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-invisible-text.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-opacity-descendant.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-opacity.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-out-of-bounds-translate.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-out-of-bounds.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-display.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-image.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-opacity.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-text.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-visibility.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-svg.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-text-input.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-typographic-pseudo.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-video-frame.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-video-poster.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-whitespace.html
imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-with-rtl.html
performance-api/paint-timing/paint-timing-apis.html
performance-api/paint-timing/paint-timing-frames.html
performance-api/paint-timing/paint-timing-with-worker.html
performance-api/paint-timing/performance-observer-first-contentful-paint.html

• CMakeLists.txt:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSPerformanceEntryCustom.cpp:

(WebCore::toJSNewlyCreated):

• bindings/js/WebCoreBuiltinNames.h:

Add PerformancePaintTiming interface. ​https://w3c.github.io/paint-timing/#sec-PerformancePaintTiming

• dom/Document.cpp:
• dom/Document.h:

(WebCore::Document::supportsPaintTiming const):

We only report paint timing for document that can access the top level security origin, to avoid leakage of information to sandboxed iframes.

(WebCore::Document::enqueuePaintTimingEntryIfNeeded):

Enqueue a paint timing entry, according to ​https://w3c.github.io/paint-timing/#sec-reporting-paint-timing

• page/FrameView.cpp:

(WebCore::FrameView::paintContents):

Disable FCP fake-paint in LFC mode.

• page/Page.cpp:

(WebCore::Page::doAfterUpdateRendering):

• page/Performance.cpp:

(WebCore::Performance::getEntries const):
(WebCore::Performance::getEntriesByType const):
(WebCore::Performance::getEntriesByName const):
(WebCore::Performance::reportFirstContentfulPaint):

• page/Performance.h:

Support first-contentful-paint reporting.

• page/PerformanceEntry.cpp:

(WebCore::PerformanceEntry::parseEntryTypeString):

• page/PerformanceEntry.h:

(WebCore::PerformanceEntry::isPaint const):

• page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::supportedEntryTypes):

• page/PerformanceObserver.h:
• page/PerformanceObserver.idl:
• page/PerformancePaintTiming.h: Added.

(isType):

• page/PerformancePaintTiming.idl: Added.

Add paint performance entry type.

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setPaintTimingEnabled):
(WebCore::RuntimeEnabledFeatures::paintTimingEnabled const):

New runtime flag for paint timing.

• platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::detectingContentfulPaint const):
(WebCore::GraphicsContext::setContentfulPaintDetected):
(WebCore::GraphicsContext::contenfulPaintDetected const):

Add a flag in GraphicsContext where different render operations can report if they're contentful.

• rendering/ContentfulPaintChecker.cpp: Added.

(WebCore::ContentfulPaintChecker::qualifiesForContentfulPaint):

• rendering/ContentfulPaintChecker.h: Added.

Run a "dummy" paint of the FrameView, to detect contentful elements.

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

• rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::paintReplaced):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

• rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced):

• rendering/TextPainter.cpp:

(WebCore::TextPainter::paintTextOrEmphasisMarks):

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

Report contentfulness when we reach anything that qualifies as contentful,
based on ​https://w3c.github.io/paint-timing/#contentful.

Source/WebKit:

Add an experimental runtime flag for paint-timing (paintTimingEnabled).

• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPaintTimingEnabled):
(WKPreferencesGetPaintTimingEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::updatePreferencesStore):

LayoutTests:

Added tests for some first-contentful-paint (FCP) use-cases.
Ensure that FCP works well with VNE (first paint delay until contents are visually non-empty).

• platform/win/TestExpectations:
• platform/mac-wk1/TestExpectations:

Disable paint timing for WebKit1.

• TestExpectations:

Disable of the WPT tests.

• http/tests/performance/paint-timing: Added.
• http/tests/performance/paint-timing/performance-paint-timing-fcp-after-visually-non-empty-for-num-chars-expected.txt: Added.
• http/tests/performance/paint-timing/performance-paint-timing-fcp-after-visually-non-empty-for-num-chars.html: Added.

If VNE due to number of characters blocks painting, make sure FCP is reported only after painting is unblocked.

• http/tests/performance/paint-timing/performance-paint-timing-fcp-after-visually-non-empty-for-style-expected.txt: Added.
• http/tests/performance/paint-timing/performance-paint-timing-fcp-after-visually-non-empty-for-style.html: Added.

If a pending stylesheet blocks painting, make sure FCP is reported only after stylesheet has loaded.

• http/tests/performance/paint-timing/resources: Added.
• http/tests/performance/paint-timing/resources/slowscript.php: Added.
• http/tests/performance/paint-timing/resources/slowstyle.php: Added.
• http/tests/performance/paint-timing/resources/style.css: Added.

(body):

• performance-api/paint-timing: Added.
• performance-api/paint-timing/paint-timing-apis-expected.txt: Added.
• performance-api/paint-timing/paint-timing-apis.html: Added.
• performance-api/paint-timing/paint-timing-frames-expected.txt: Added.
• performance-api/paint-timing/paint-timing-frames.html: Added.
• performance-api/paint-timing/paint-timing-with-worker-expected.txt: Added.
• performance-api/paint-timing/paint-timing-with-worker.html: Added.

Test that FCP is not available for cross-origin frames and workers.

• performance-api/paint-timing/performance-observer-first-contentful-paint-expected.txt: Added.
• performance-api/paint-timing/performance-observer-first-contentful-paint.html: Added.

Test that performance observers are called for FCP.

• performance-api/paint-timing/resources: Added.
• performance-api/paint-timing/resources/fcp-subframe.html: Added.
• performance-api/paint-timing/resources/paint-api-utils.js: Added.

(async waitForFCP):

• performance-api/paint-timing/resources/paint-timing-api.js: Added.
• performance-api/paint-timing/resources/worker.html: Added.

3:22 PM Changeset in webkit [260850] by Alan Coon

• 8 edits in branches/safari-610.1.11-branch/Source

Versioning.

2:59 PM Changeset in webkit [260849] by Simon Fraser

• 2 edits in trunk/Source/WebCore

MRMediaRemoteSetNowPlayingApplicationPlaybackStateForOrigin log with no error
​https://bugs.webkit.org/show_bug.cgi?id=211145

Reviewed by Jer Noble.

Don't log when MRMediaRemoteSetNowPlayingApplicationPlaybackStateForOrigin() returns 0.

• platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::setNowPlayingInfo):

2:51 PM Changeset in webkit [260848] by Ross Kirsling

• 43 edits in trunk/Source

[JSC] Align upon the name isCallable instead of isFunction
​https://bugs.webkit.org/show_bug.cgi?id=211140

Reviewed by Darin Adler.

Source/JavaScriptCore:

Follow-up to r260722. Usage is now cleanly separated between isFunction / getCallData,
but the name isCallable is still clearer than isFunction so let's flip that after all.

• API/JSContextRef.cpp:

(JSGlobalContextSetUnhandledRejectionCallback):

• API/JSObjectRef.cpp:

(JSObjectIsFunction):

• dfg/DFGOperations.cpp:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCreateThis):
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileIsObjectOrNull):
(JSC::FTL::DFG::LowerDFGToB3::compileIsFunction):
(JSC::FTL::DFG::LowerDFGToB3::buildTypeOf):
(JSC::FTL::DFG::LowerDFGToB3::isCallable):
(JSC::FTL::DFG::LowerDFGToB3::isFunction): Deleted.

• ftl/FTLOperations.cpp:

(JSC::FTL::operationTypeOfObjectAsTypeofType):

• jsc.cpp:

(functionSetUnhandledRejectionCallback):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/ExceptionHelpers.cpp:

(JSC::errorDescriptionForValue):

• runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

• runtime/InternalFunction.cpp:

(JSC::getFunctionRealm):

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::isCallable const):
(JSC::JSValue::isFunction const): Deleted.

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::isCallable):
(JSC::JSCell::isFunction): Deleted.

• runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):

• runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):

• runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectTypeOrNull):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::structureForTarget):
(JSC::ProxyObject::finishCreation):

• runtime/RuntimeType.cpp:

(JSC::runtimeTypeForValue):

• tools/JSDollarVM.cpp:

(JSC::functionCallWithStackSize):
(JSC::functionFindTypeForExpression):
(JSC::functionReturnTypeFor):
(JSC::functionHasBasicBlockExecuted):
(JSC::functionBasicBlockExecutionCount):

• wasm/WasmInstance.cpp:

(JSC::Wasm::Instance::setFunctionWrapper):

• wasm/WasmOperations.cpp:

(JSC::Wasm::operationIterateResults):
(JSC::Wasm::operationWasmRefFunc):

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):

• wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::WebAssemblyWrapperFunction::finishCreation):

Source/WebCore:

• Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::ensureReplacementScriptInjected):

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::getCustomElementCallback):

• bindings/js/JSDOMConvertCallbacks.h:

(WebCore::Converter<IDLCallbackFunction<T>>::convert):

• bindings/js/JSDOMConvertScheduledAction.h:

(WebCore::Converter<IDLScheduledAction>::convert):

• bindings/js/JSDOMPromise.cpp:

(WebCore::DOMPromise::whenPromiseIsSettled):

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::queueMicrotask):

• bindings/js/JSWorkerGlobalScopeCustom.cpp:

(WebCore::JSWorkerGlobalScope::queueMicrotask):

• bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::pipeTo):
(WebCore::ReadableStream::tee):

• bindings/js/ReadableStreamDefaultController.cpp:

(WebCore::ReadableStreamDefaultController::invoke):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::callInWorld):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateOverloadDispatcher):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):

• testing/Internals.cpp:

(WebCore::Internals::parserMetaData):
(WebCore::Internals::cloneArrayBuffer):

• worklets/PaintWorkletGlobalScope.cpp:

(WebCore::PaintWorkletGlobalScope::registerPaint):

Source/WebKit:

• WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::hasMethod):

2:43 PM Changeset in webkit [260847] by Devin Rousso

• 21 edits in trunk/Source

Web Inspector: find dialog does not populate search string from system find pasteboard
​https://bugs.webkit.org/show_bug.cgi?id=113588
<rdar://problem/19281466>

Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.updateFindString): Added.

• UserInterface/Base/Main.js:

(WI.contentLoaded):
(WI.updateFindString): Added.
(WI._populateFind):
(WI._findNext):
(WI._findPrevious):

• UserInterface/Views/ContentBrowser.js:

(WI.ContentBrowser.prototype.handleFindStringUpdated): Added.
(WI.ContentBrowser.prototype.handlePopulateFindShortcut):
(WI.ContentBrowser.prototype.handleFindNextShortcut):
(WI.ContentBrowser.prototype.handleFindPreviousShortcut):

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.handleFindStringUpdated): Added.
(WI.LogContentView.prototype.handlePopulateFindShortcut):
(WI.LogContentView.prototype.handleFindNextShortcut):
(WI.LogContentView.prototype.handleFindPreviousShortcut):
When the find string gets updated, tell the active view. The findNextKeyboardShortcut and
findPreviousKeyboardShortcut will also update the related WI.FindBanner when invoked if
the current search query does not match the find string.

• UserInterface/Test/Test.js:

(WI.updateFindString): Added.

Source/WebKit:

• UIProcess/Inspector/mac/WKInspectorWKWebView.h:
• UIProcess/Inspector/mac/WKInspectorWKWebView.mm:

(-[WKInspectorWKWebView dealloc]): Added.
(-[WKInspectorWKWebView setInspectorWKWebViewDelegate:]):
(-[WKInspectorWKWebView becomeFirstResponder]): Added.
(-[WKInspectorWKWebView _handleWindowDidBecomeKey:]): Added.

• UIProcess/Inspector/mac/WKInspectorViewController.h:
• UIProcess/Inspector/mac/WKInspectorViewController.mm:

(-[WKInspectorViewController inspectorWKWebViewDidBecomeActive:]): Added.

• UIProcess/Inspector/WebInspectorProxy.h:
• UIProcess/Inspector/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter inspectorViewControllerDidBecomeActive:]): Added.
(WebKit::WebInspectorProxy::didBecomeActive): Added.

• UIProcess/Inspector/RemoteWebInspectorProxy.h:
• UIProcess/Inspector/mac/RemoteWebInspectorProxyMac.mm:

(-[WKRemoteWebInspectorProxyObjCAdapter inspectorWKWebViewDidBecomeActive:]): Added.
(WebKit::RemoteWebInspectorProxy::didBecomeActive): Added.
Add a new delegate call chain that notifies the inspector proxy about when the inspector web
view becomes active, at which point the inspector proxy can get the current find string and
sent it to the inspector page.

• WebProcess/Inspector/WebInspectorUI.messages.in:
• WebProcess/Inspector/WebInspectorUI.h:
• WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::updateFindString): Added.

• WebProcess/Inspector/RemoteWebInspectorUI.messages.in:
• WebProcess/Inspector/RemoteWebInspectorUI.h:
• WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::updateFindString): Added.
Pass along the new find string to the frontend via InspectorFrontendAPI.updateFindString.

2:31 PM Changeset in webkit [260846] by dbates@webkit.org

• 4 edits in trunk/Source/WebKit

Remove unused WebPage::focusTextInputContext()
​https://bugs.webkit.org/show_bug.cgi?id=211135

Reviewed by Anders Carlsson.

I accidentally forgot to remove the WebPage message and WebPage implementation that
backed -_focusTextInputContext when I removed it in r260225. Now the implementation
is unused. Let's remove it.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::focusTextInputContext): Deleted.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

2:15 PM Changeset in webkit [260845] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Rewrite GraphicsLayerCA::updateSublayerList()
​https://bugs.webkit.org/show_bug.cgi?id=211137

Reviewed by Zalan Bujtas.

This function was hard to understand, with aliasing of a layer list to handle
the various configurations. Future patches will add a bit more complexity here.

Rewrite using lambdas, which makes it easier to follow.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateSublayerList):

1:59 PM Changeset in webkit [260844] by chris.reid@sony.com

• 15 edits
  3 adds in trunk

[Win] Bundle Inspector Resources in Release builds
​https://bugs.webkit.org/show_bug.cgi?id=210942

Reviewed by Fujii Hironori.

.:

Add ENABLE_WEBINSPECTORUI so the resource copy can be disabled
on platforms without inspector frontends.

• CMakeLists.txt:
• Source/CMakeLists.txt:
• Source/PlatformWin.cmake:
• Source/cmake/OptionsJSCOnly.cmake:
• Source/cmake/OptionsPlayStation.cmake:

Source/WebCore:

• CMakeLists.txt:

Source/WebInspectorUI:

Add CMake files for copying inspector resources

• CMakeLists.txt: Added.
• PlatformGTK.cmake: Added.
• PlatformWin.cmake: Added.

Source/WebKit:

Move CMake logic for the inspector resource copy script to
Source/WebInspectorUI so it can be shared with Win and other platforms.

• InspectorGResources.cmake:
• PlatformWPE.cmake:
• PlatformWin.cmake:

1:41 PM Changeset in webkit [260843] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Remove downloadAttribute from DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=210493

Patch by Rob Buis <​rbuis@igalia.com> on 2020-04-28
Reviewed by Darin Adler.

Remove downloadAttribute from DocumentLoader since this
can be obtained from the NavigationAction.

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::downloadAttribute const):
(WebCore::DocumentLoader::setDownloadAttribute): Deleted.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::loadPostRequest):

• loader/FrameLoader.h:

12:53 PM Changeset in webkit [260842] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

[MacCatalyst] Add missing symlinks to WebKit.frameworks
<​https://webkit.org/b/211102>
<rdar://problem/62137758>

Reviewed by Brent Fulgham.

• WebKit.xcodeproj/project.pbxproj:

(Make Frameworks Symbolic Link):

• Update logic to run for macOS and macCatalyst builds.
• Add output path.

(Check For Inappropriate Objective-C Class Names):

• Let Xcode have its way with the project file by adding a newline to the end of the script.

(Check For Weak VTables and Externals): Ditto.
(Add XPCServices symlink):

• Update logic to run for macOS and macCatalyst builds.

12:40 PM Changeset in webkit [260841] by Kate Cheney

• 17 edits
  3 adds in trunk

Create a mechanism to add missing ITP Database tables when the schema is updated
​https://bugs.webkit.org/show_bug.cgi?id=211004
<rdar://problem/62261187>

Reviewed by John Wilander.

Source/WebKit:

This patch updates the ITP database to better handle added tables to
the schema. Currently the database store deletes and re-creates the
database when any schema change is encountered. This is simple but
would result in ITP data loss during schema updates, so this patch
searches the schema for missing tables and adds any it finds.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::createTableQueries):
Convert the tables array to a mapping of table names to their
respective CREATE TABLE queries so we can add missing tables on the
fly.
(WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore):
(WebKit::ResourceLoadStatisticsDatabaseStore::openITPDatabase):
Remove call to createSchema() from the constructor. It makes more
sense to base this on whether the file is new as opposed to whether
one table exists.
(WebKit::ResourceLoadStatisticsDatabaseStore::checkForMissingTablesInSchema):
(WebKit::ResourceLoadStatisticsDatabaseStore::migrateDataToNewTablesIfNecessary):
(WebKit::ResourceLoadStatisticsDatabaseStore::addMissingTablesIfNecessary):
Checks for missing tables and adds them using a best-effort approach.
Call createUniqueIndices() to call all CREATE UNIQUE INDEX queries,
even though we may not need them all. It is much simpler than to
associate each query with its table, and it doesn't hurt to call
again.

(WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary):
Add missing tables instead of deleting the old database file. Changed
the function name to reflect this. Deleted a FIXME which this patch
addresses but added a new FIXME for migrating data when adding new
columns, which this patch does not address.
(WebKit::ResourceLoadStatisticsDatabaseStore::isCorrectTableSchema): Deleted.
(WebKit::ResourceLoadStatisticsDatabaseStore::openAndDropOldDatabaseIfNecessary): Deleted.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::statisticsDatabaseHasAllTables):

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::statisticsDatabaseHasAllTables):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _statisticsDatabaseHasAllTables:]):

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::statisticsDatabaseHasAllTables):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::statisticsDatabaseHasAllTables):

• UIProcess/WebsiteData/WebsiteDataStore.h:

Added an SPI call to test that the database schema includes all
tables. This tests the database is not dropped when a new
table is added upon opening the database.

Tools:

Add test case which copies a database schema with a missing table into
the ITP database file, then ensures the pre-seeded data is
migrated over and that the schema now has all tables (including the
previously missing one).

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/missingTopFrameUniqueRedirectSameSiteStrictTableSchema.db: Added.
• TestWebKitAPI/Tests/WebKitCocoa/missingTopFrameUniqueRedirectSameSiteStrictTableSchema.db-shm: Added.
• TestWebKitAPI/Tests/WebKitCocoa/missingTopFrameUniqueRedirectSameSiteStrictTableSchema.db-wal: Added.

12:29 PM Changeset in webkit [260840] by pvollan@apple.com

• 7 edits in trunk

[Cocoa] Global preferences are not accessible in the WebContent process when CFPrefs direct mode is enabled
​https://bugs.webkit.org/show_bug.cgi?id=211075
Source/WebKit:

<rdar://problem/61866711>

Reviewed by Brent Fulgham.

Global preferences in the domain 'kCFPreferencesAnyApplication' are not readable in the WebContent process when CFPrefs direct mode
is enabled. Fix this by transferring a select set of global preferences to the WebContent process on startup.

API test: WebKit.GlobalPreferences

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::setGlobalPreferences):
(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Reviewed by Brent Fulgham.

• TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:

(TEST):

12:18 PM Changeset in webkit [260839] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Classes toggle button has wrong outline on focus
​https://bugs.webkit.org/show_bug.cgi?id=211104
<rdar://problem/62475340>

Reviewed by Devin Rousso.

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle:focus):

• UserInterface/Views/Variables.css:

(:root):

12:07 PM Changeset in webkit [260838] by Peng Liu

• 2 edits in trunk/Source/WebKit

Remove the WebKit.plist for Feature Flags
​https://bugs.webkit.org/show_bug.cgi?id=210534

Unreviewed project file clean-up.

A follow-up patch for r260599. Remove the reference to the WebKit.plist from project.pbxproj.

• WebKit.xcodeproj/project.pbxproj:

12:02 PM Changeset in webkit [260837] by Jonathan Bedard

• 2 edits in trunk/Tools

results.webkit.org: A suite running multiple times in a commit for a single configuration may overwrite upload metadata
​https://bugs.webkit.org/show_bug.cgi?id=211097
<rdar://problem/62474538>

Rubber-stamped by Aakash Jain.

Create a new table for uploads which is indexed by both uuid and timestamp so that uploads which share
a configuration and uuid but not a timestamp do not collide.

• resultsdbpy/resultsdbpy/model/upload_context.py:

(UploadContext):
(UploadContext.UploadsByConfigurationLegacy): Renamed from UploadContext.UploadsByConfiguration.
(UploadContext.UploadsByConfiguration): New database table indexed by both timestamp and uuid.
(UploadContext.UploadsByConfiguration.unpack):
(UploadContext.init):
(UploadContext.find_test_results): Search both versions of the UploadsByConfiguration table.

11:59 AM Changeset in webkit [260836] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Fix iOS API tests after r260790
​https://bugs.webkit.org/show_bug.cgi?id=211093

• UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::sendMessage):
Only call the completion handler once.

11:57 AM Changeset in webkit [260835] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

REGRESSION(r260822): Broke media/track/track-in-band-metadata-display-order.html on Mac
​https://bugs.webkit.org/show_bug.cgi?id=211133

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-04-28
Reviewed by Eric Carlson.

• media/track/track-in-band-metadata-display-order.html: Ensure the caption

display mode is set to forced-only, this is a requirement for the
test.

11:04 AM Changeset in webkit [260834] by ysuzuki@apple.com

• 25 edits
  2 adds in trunk

[JSC] NumberConstructor should accept BigInt
​https://bugs.webkit.org/show_bug.cgi?id=210835

Reviewed by Mark Lam.

JSTests:

• stress/number-constructor-bigint-dfg.js: Added.

(shouldBe):
(convert):

• stress/number-constructor-bigint.js: Added.

(shouldBe):

• test262/expectations.yaml:

Source/JavaScriptCore:

This patch fixes our Number constructor behavior to accept BigInt. According to the spec[1],
Number constructor should accept BigInt and should generate numbers from that.

We port V8's BigInt to double conversion code as we did for the other HeapBigInt runtime functions.

And we introduce CallNumberConstructor DFG node and handle Number constructor call with BigInt correctly
in DFG and FTL. Previously we were emitting ToNumber DFG node for Number constructor. But this is wrong
now since ToNumber does not accept BigInt and throws an error, and Number constructor should not use
ToNumber to implement its implementation. So we should introduce slightly different semantics: CallNumberConstructor
as we introduced CallStringConstructor in addition to ToString DFG node. And we add appropriate BigInt32 path
to emit efficient CallNumberConstructor machine code.

[1]: ​https://tc39.es/ecma262/#sec-number-constructor-number-value

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToNumberOrToNumericOrCallNumberConstructor):
(JSC::DFG::FixupPhase::fixupToNumeric): Deleted.
(JSC::DFG::FixupPhase::fixupToNumber): Deleted.

• dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToNumeric):
(JSC::DFG::SpeculativeJIT::compileCallNumberConstructor):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCallNumberConstructor):

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::decideRounding):
(JSC::JSBigInt::toNumberHeap):

• runtime/JSBigInt.h:
• runtime/NumberConstructor.cpp:

(JSC::constructNumberConstructor):
(JSC::callNumberConstructor):

11:04 AM Changeset in webkit [260833] by Alan Coon

• 1 copy in tags/Safari-609.2.9.0.3

Tag Safari-609.2.9.0.3.

10:04 AM Changeset in webkit [260832] by jer.noble@apple.com

• 9 edits in trunk/Source

[Mac] Adopt kMTSupportNotification_ShouldPlayHDRVideoChanged notification
​https://bugs.webkit.org/show_bug.cgi?id=211028

Reviewed by Eric Carlson.

Source/WebCore/PAL:

Make MediaToolboxSoftLink fully exported from PAL.

• pal/cf/CoreMediaSoftLink.cpp:
• pal/cocoa/MediaToolboxSoftLink.cpp:
• pal/cocoa/MediaToolboxSoftLink.h:

Source/WebKit:

Adopt a new notification which signals that the receiver should re-query for HDR support.

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::webProcessPoolHighDynamicRangeDidChangeCallback):
(WebKit::WebProcessPool::registerHighDynamicRangeChangeCallback):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::registerHighDynamicRangeChangeCallback):
(WebKit::WebProcessPool::initializeNewWebProcess):

• UIProcess/WebProcessPool.h:

9:36 AM Changeset in webkit [260831] by Jack Lee

• 40 edits
  2 adds in trunk

Nullptr crash in EditCommand::EditCommand via CompositeEditCommand::removeNode
​https://bugs.webkit.org/show_bug.cgi?id=207600
<rdar://problem/56969450>

Reviewed by Geoffrey Garen.

Source/WebCore:

Move FrameSelection and Editor objects from Frame to Document so when a document is detached
in nested command executions, the next EditCommand would not fail in constructor.

Test: editing/inserting/insert-list-then-edit-command-crash.html

• dom/Document.cpp:

(WebCore::m_selection):
(WebCore::Document::prepareForDestruction):
(WebCore::m_undoManager): Deleted.

• dom/Document.h:

(WebCore::Document::editor):
(WebCore::Document::editor const):
(WebCore::Document::selection):
(WebCore::Document::selection const):

• dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate const):

• editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::AlternativeTextController):
(WebCore::AlternativeTextController::stopPendingCorrection):
(WebCore::AlternativeTextController::isSpellingMarkerAllowed const):
(WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
(WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
(WebCore::AlternativeTextController::timerFired):
(WebCore::AlternativeTextController::handleAlternativeTextUIResult):
(WebCore::AlternativeTextController::rootViewRectForRange const):
(WebCore::AlternativeTextController::respondToChangedSelection):
(WebCore::AlternativeTextController::respondToAppliedEditing):
(WebCore::AlternativeTextController::respondToUnappliedEditing):
(WebCore::AlternativeTextController::editorClient):
(WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
(WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
(WebCore::AlternativeTextController::alternativeTextClient):
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
(WebCore::AlternativeTextController::insertDictatedText):
(WebCore::AlternativeTextController::applyDictationAlternative):

• editing/AlternativeTextController.h:

(WebCore::AlternativeTextController::UNLESS_ENABLED):

• editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::CompositeEditCommand::willApplyCommand):
(WebCore::CompositeEditCommand::didApplyCommand):
(WebCore::CompositeEditCommand::targetRanges const):
(WebCore::CompositeEditCommand::moveParagraphs):

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::saveTypingStyleState):
(WebCore::DeleteSelectionCommand::mergeParagraphs):
(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
(WebCore::DeleteSelectionCommand::doApply):

• editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand):
(WebCore::EditCommand::isEditingTextAreaOrTextInput const):
(WebCore::EditCommand::postTextStateChangeNotification):
(WebCore::EditCommand::frame): Deleted.
(WebCore::EditCommand::frame const): Deleted.

• editing/EditCommand.h:
• editing/Editing.cpp:

(WebCore::createDefaultParagraphElement):

• editing/EditingStyle.cpp:

(WebCore::StyleChange::StyleChange):

• editing/Editor.cpp:

(WebCore::ClearTextCommand::CreateAndApply):
(WebCore::TemporarySelectionChange::TemporarySelectionChange):
(WebCore::TemporarySelectionChange::~TemporarySelectionChange):
(WebCore::TemporarySelectionChange::setSelection):
(WebCore::Editor::selectionForCommand):
(WebCore::Editor::behavior const):
(WebCore::Editor::client const):
(WebCore::Editor::canEdit const):
(WebCore::Editor::canEditRichly const):
(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canCopy const):
(WebCore::Editor::canPaste const):
(WebCore::Editor::canDelete const):
(WebCore::Editor::shouldSmartDelete):
(WebCore::Editor::deleteWithDirection):
(WebCore::Editor::deleteSelectionWithSmartDelete):
(WebCore::Editor::clearText):
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::selectedRange):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::shouldInsertText const):
(WebCore::Editor::hasBidiSelection const):
(WebCore::Editor::selectionUnorderedListState const):
(WebCore::Editor::selectionOrderedListState const):
(WebCore::Editor::increaseSelectionListLevel):
(WebCore::Editor::increaseSelectionListLevelOrdered):
(WebCore::Editor::increaseSelectionListLevelUnordered):
(WebCore::Editor::decreaseSelectionListLevel):
(WebCore::Editor::findEventTargetFromSelection const):
(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::selectionStartHasStyle const):
(WebCore::Editor::selectionHasStyle const):
(WebCore::Editor::selectionStartCSSPropertyValue):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::Editor):
(WebCore::Editor::clear):
(WebCore::Editor::insertText):
(WebCore::Editor::insertTextForConfirmedComposition):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::paste):
(WebCore::Editor::pasteAsQuotation):
(WebCore::Editor::renderLayerDidScroll):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::baseWritingDirectionForSelectionStart const):
(WebCore::Editor::selectComposition):
(WebCore::SetCompositionScope::SetCompositionScope):
(WebCore::SetCompositionScope::~SetCompositionScope):
(WebCore::Editor::setComposition):
(WebCore::Editor::ignoreSpelling):
(WebCore::Editor::learnSpelling):
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::Editor::misspelledWordAtCaretOrRange const):
(WebCore::Editor::isSelectionUngrammatical):
(WebCore::Editor::guessesForMisspelledWord const):
(WebCore::Editor::guessesForMisspelledOrUngrammatical):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::isSpellCheckingEnabledInFocusedNode const):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::markAndReplaceFor):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
(WebCore::Editor::rangeForPoint):
(WebCore::Editor::revealSelectionAfterEditingOperation):
(WebCore::Editor::setIgnoreSelectionChanges):
(WebCore::Editor::getCompositionSelection const):
(WebCore::Editor::transpose):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::selectedText const):
(WebCore::Editor::selectedTextForDataTransfer const):
(WebCore::Editor::insertTextPlaceholder):
(WebCore::Editor::removeTextPlaceholder):
(WebCore::Editor::shouldChangeSelection const):
(WebCore::Editor::computeAndSetTypingStyle):
(WebCore::Editor::findString):
(WebCore::Editor::countMatchesForText):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::shouldDetectTelephoneNumbers):
(WebCore::Editor::scanSelectionForTelephoneNumbers):
(WebCore::Editor::editorUIUpdateTimerFired):
(WebCore::Editor::selectionStartHasMarkerFor const):
(WebCore::candidateRangeForSelection):
(WebCore::Editor::stringForCandidateRequest const):
(WebCore::Editor::contextRangeForCandidateRequest const):
(WebCore::Editor::fontAttributesAtSelectionStart const):
(WebCore::Editor::notifyClientOfAttachmentUpdates):
(WebCore::Editor::handleAcceptedCandidate):
(WebCore::Editor::unifiedTextCheckerEnabled const):
(WebCore::Editor::toggleOverwriteModeEnabled):
(WebCore::Editor::fontForSelection const):
(WebCore::Editor::canCopyExcludingStandaloneImages const):
(WebCore::Editor::document const): Deleted.

• editing/Editor.h:

(WebCore::TemporarySelectionChange::TemporarySelectionChange):
(WebCore::IgnoreSelectionChangeForScope::IgnoreSelectionChangeForScope):
(WebCore::Editor::document const):

• editing/EditorCommand.cpp:

(WebCore::executeSwapWithMark):
(WebCore::Editor::command):
(WebCore::Editor::Command::Command):
(WebCore::Editor::Command::execute const):

• editing/FrameSelection.cpp:

(WebCore::shouldAlwaysUseDirectionalSelection):
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::rootEditableElementOrDocumentElement const):
(WebCore::FrameSelection::setSelectionByMouseIfDifferent):
(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::setSelection):
(WebCore::updateSelectionByUpdatingLayoutOrStyle):
(WebCore::FrameSelection::setNeedsSelectionUpdate):
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::updateDataDetectorsForSelection):
(WebCore::FrameSelection::positionForPlatform const):
(WebCore::FrameSelection::nextWordPositionForPlatform):
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::prepareForDestruction):
(WebCore::FrameSelection::absoluteCaretBounds):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::FrameSelection::contains const):
(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::isFocusedAndActive const):
(WebCore::shouldStopBlinkingDueToTypingCommand):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::setCaretVisibility):
(WebCore::FrameSelection::setFocusedElementIfNeeded):
(WebCore::FrameSelection::shouldDeleteSelection const):
(WebCore::FrameSelection::selectionBounds const):
(WebCore::FrameSelection::getClippedVisibleTextRectangles const):
(WebCore::FrameSelection::currentForm const):
(WebCore::FrameSelection::revealSelection):
(WebCore::FrameSelection::setSelectionFromNone):
(WebCore::FrameSelection::shouldChangeSelection const):
(WebCore::FrameSelection::setShouldShowBlockCursor):
(WebCore::FrameSelection::appearanceUpdateTimerFired):
(WebCore::FrameSelection::updateAppearanceAfterLayoutOrStyleChange):
(WebCore::FrameSelection::selectRangeOnElement):
(WebCore::FrameSelection::setCaretBlinks):

• editing/FrameSelection.h:
• editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):

• editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

• editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::doApply):

• editing/ReplaceRangeWithTextCommand.cpp:

(WebCore::ReplaceRangeWithTextCommand::doApply):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):

• editing/SetSelectionCommand.cpp:

(WebCore::SetSelectionCommand::doApply):
(WebCore::SetSelectionCommand::doUnapply):

• editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::client const):
(WebCore::SpellChecker::isAsynchronousEnabled const):
(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::didCheck):
(WebCore::SpellChecker::didCheckSucceed):

• editing/SpellChecker.h:
• editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::doApply):

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
(WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping):
(WebCore::TypingCommand::closeTyping):
(WebCore::TypingCommand::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::willAddTypingToOpenCommand):
(WebCore::TypingCommand::typingAddedToOpenCommand):
(WebCore::TypingCommand::insertTextAndNotifyAccessibility):
(WebCore::TypingCommand::insertTextRunWithoutNewlines):
(WebCore::TypingCommand::insertLineBreakAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContentAndNotifyAccessibility):

• editing/TypingCommand.h:
• editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::selectionInHTMLFormat):
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::writeSelection):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::replaceSelectionWithAttributedString):
(WebCore::Editor::webContentFromPasteboard):
(WebCore::Editor::takeFindStringFromSelection):

• editing/gtk/EditorGtk.cpp:

(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::webContentFromPasteboard):

• editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
(WebCore::Editor::removeUnchangeableStyles):
(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::insertDictationPhrases):
(WebCore::Editor::setDictationPhrasesAsChildOfElement):
(WebCore::Editor::setTextAsChildOfElement):
(WebCore::Editor::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):

• editing/libwpe/EditorLibWPE.cpp:

(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::pasteWithPasteboard):

• editing/mac/EditorMac.mm:

(WebCore::Editor::readSelectionFromPasteboard):
(WebCore::Editor::replaceNodeFromPasteboard):
(WebCore::Editor::selectionWillChange):

• editing/win/EditorWin.cpp:

(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::webContentFromPasteboard):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::willTransitionToCommitted):
(WebCore::FrameLoader::closeURL):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::clear):

• page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::requestDOMPasteAccess):
(WebCore::Frame::setPageAndTextZoomFactors):

• page/Frame.h:
• page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithRange):

LayoutTests:

Added a regression test for the crash.

• editing/inserting/insert-list-then-edit-command-crash-expected.txt: Added.
• editing/inserting/insert-list-then-edit-command-crash.html: Added.

Modify the test result. FrameSelection is being destructed along with
document so an additional selection change notification is expected.

• platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt:

9:23 AM Changeset in webkit [260830] by alex

• 2 edits in trunk/LayoutTests

[GTK][WebGL] compositing/clipping/border-radius-on-webgl.html is failing since added
​https://bugs.webkit.org/show_bug.cgi?id=211121

Also removed fast/mediastream/getDisplayMedia-max-constraints.html
from TestExpectations, it was removed from the repository in r260638.

Unreviewed test gardening.

• platform/gtk/TestExpectations:

9:15 AM Changeset in webkit [260829] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[GTK] Unreviewed build fix for Clang 10

• UIProcess/API/gtk/WebKitInputMethodContextImplGtk.cpp:

(webkitInputMethodContextImplGtkGetPreedit): Use the "f" suffix to make constants float to
prevent a narrowing double-to-float narrowing issue which Clang 10 considers an error. This
only happens with GTK4 because GdkRGBA now has float members. Using float constants is fine
with GTK3, because promoting floats to doubles never loses precision.

9:05 AM Changeset in webkit [260828] by Antti Koivisto

• 3 edits
  2 adds in trunk

msn.com: Header flickers when scrolling articles
​https://bugs.webkit.org/show_bug.cgi?id=211126
<rdar://problem/56439177>

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/fixed-with-clip-stability.html

In case of fixed positioned elements the decision to create backing depends on clip rect.
However RenderLayer::localClipRect() tests for backing in call to clippingRootForPainting(). This creates
instability since clipping depends on backing decision, and backing decision depends on clipping.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::localClipRect const):

Specifically the result of clipExceedsBounds test here is affected by computed offsetFromRoot:
"clipRect.contains(cssClipRect)" test fails for zero sized clips with different offsets.

Compute clipExceedsBounds by looking at the clip sizes only and ignoring the position (which should match).

LayoutTests:

• compositing/fixed-with-clip-stability-expected.txt: Added.
• compositing/fixed-with-clip-stability.html: Added.

8:25 AM Changeset in webkit [260827] by Alan Bujtas

• 8 edits in trunk/Source/WebCore

[LFC] Introduce FormattingContext::ConstraintsForOutOfFlowContent
​https://bugs.webkit.org/show_bug.cgi?id=211125

Reviewed by Antti Koivisto.

Horizontal and vertical out-of-flow constraints are always computed and used in pairs.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::constraintsForOutOfFlowContent):
(WebCore::Layout::FormattingContext::Geometry::horizontalConstraintsForOutOfFlow): Deleted.
(WebCore::Layout::FormattingContext::Geometry::verticalConstraintsForOutOfFlow): Deleted.

• layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):

• layout/LayoutUnits.h:
• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

7:54 AM Changeset in webkit [260826] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit

[iOS] Marked text editor state only needs to be set when layout is up-to-date
​https://bugs.webkit.org/show_bug.cgi?id=211087

Patch by Daniel Bates <​dabates@apple.com> on 2020-04-28
Reviewed by Darin Adler.

Organize the code to reflect reality: editor state only has marked text rects if layout is
up-to-date. So, move these fields to from EditorState to EditorState::PostLayoutData.

While I am in this area of the code I also moved the editor state originIdentifierForPasteboard
to the top of the struct as it is aesthetically more pleasing to me to have the post layout
data last. It likely also produces better bit packing though this wasn't my primary motivation.

• Shared/EditorState.cpp:

(WebKit::EditorState::encode const):
(WebKit::EditorState::decode):
(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):
Move encoding and decoding of marked test fields from EditorState to EditorState::PostLayoutData.

(WebKit::operator<<): Fix up code now that marked text fields are in PostLayoutData.

• Shared/EditorState.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView textFirstRect]): Update code now that this data is in the post layout data struct.
(-[WKContentView textLastRect]): Ditto.
(-[WKContentView _updateChangedSelection:]): Ditto.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::convertContentToRootViewSelectionRects): Added.
(WebKit::WebPage::getPlatformEditorState const): Update now that marked text fields are in the
post layout data struct. Simplify the early return as well: only continue if we're not missing post
layout data. If we're missing post layout data then we either do not have a frame view or layout is
not up-to-data. Either way we don't want to do anything. I also stored the FrameView in a Ref<> to
future proof the code should future code cause view detachment and destruction. Note that layout
could cause this, but the code currently covers this case. So, taking a Ref<> is about future proofing.
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Update to use convertContentToRootViewSelectionRects().
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Ditto.
(WebKit::WebPage::requestAutocorrectionData): Use Vector::map() to convert the selection rects to
from content to root view FloatRects.
(WebKit::WebPage::convertSelectionRectsToRootView): Deleted.

7:49 AM Changeset in webkit [260825] by Claudio Saavedra

• 2 edits in trunk/Tools

[Linux] Replace --geometry with --fullscreen when using MiniBrowser for WebDriver tests
​https://bugs.webkit.org/show_bug.cgi?id=211123

Reviewed by Carlos Alberto Lopez Perez.

MiniBrowser's --geometry is on its way out, so use --fullscreen
instead as it does the job.

• Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:

(GTKMiniBrowserDriver.launch_url):

7:44 AM Changeset in webkit [260824] by Alan Bujtas

• 15 edits in trunk/Source/WebCore

[LFC] Introduce FormattingContext::ConstraintsForInFlowContent
​https://bugs.webkit.org/show_bug.cgi?id=211113

Reviewed by Antti Koivisto.

This makes the layoutInFlowContent() related code look simpler.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):

• layout/FormattingContext.h:
• layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):

• layout/blockformatting/BlockFormattingContext.h:
• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::lineLayout):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::layout):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::layoutCell):

• layout/tableformatting/TableFormattingContext.h:

7:34 AM Changeset in webkit [260823] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ Mac wk2 ] tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=207165

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

7:17 AM Changeset in webkit [260822] by Philippe Normand

• 7 edits in trunk

media/track/track-load-error-readyState.html passes only when accompanied by some other tests
​https://bugs.webkit.org/show_bug.cgi?id=210976

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

• testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Reset caption
display mode, which might have been overriden by a previous test.

LayoutTests:

• media/track/track-load-error-readyState-expected.txt:
• media/track/track-load-error-readyState.html: Ensure the caption

display mode is set to automatic, this is a requirement for the
test.

• media/track/track-mode-not-changed-by-new-track-expected.txt:
• media/track/track-mode-not-changed-by-new-track.html: Ditto.

7:14 AM Changeset in webkit [260821] by Philippe Normand

• 2 edits in trunk

[GStreamer][MediaStream] Doesn't build with GStreamer 1.10
​https://bugs.webkit.org/show_bug.cgi?id=210271

Reviewed by Xabier Rodriguez-Calvar.

• Source/cmake/GStreamerChecks.cmake: Require at least GStreamer

1.12 when building with WebRTC/MediaStream enabled.

6:09 AM Changeset in webkit [260820] by pvollan@apple.com

• 11 edits
  2 adds in trunk

[iOS] Fix sandbox violation when uploading a file
​https://bugs.webkit.org/show_bug.cgi?id=210937

Reviewed by Darin Adler.

Source/WebKit:

On iOS, the file chooser needs access to frontboard and icon services in the WebContent process. Create and
consume extensions for these services when choosing files. When done, the extensions should be revoked. This
patch also fixes an out-of-bounds array exception when running the test created for this patch. Additionally,
the function thumbnailSizedImageForImage should return a RetainPtr<UIImage>, since it seems unsafe to not
retain the UIImage after the image context is released in that function.

Test: fast/forms/file/open-file-panel-crash.html

• Shared/ios/WebIconUtilities.h:
• Shared/ios/WebIconUtilities.mm:

(WebKit::thumbnailSizedImageForImage):
(WebKit::fallbackIconForFile):
(WebKit::iconForImageFile):
(WebKit::iconForVideoFile):
(WebKit::iconForFile):

• UIProcess/WebPageProxy.cpp:
• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[_WKFileUploadItem displayImage]):
(-[_WKImageFileUploadItem displayImage]):
(-[_WKVideoFileUploadItem displayImage]):
(-[WKFileUploadPanel documentPicker:didPickDocumentsAtURLs:]):
(-[WKFileUploadPanel imagePickerController:didFinishPickingMediaWithInfo:]):
(-[WKFileUploadPanel imagePickerController:didFinishPickingMultipleMediaWithInfo:]):

• WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::createIconForFiles):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChooseFilesForOpenPanelWithDisplayStringAndIcon):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

LayoutTests:

• fast/forms/file/open-file-panel-crash-expected.txt: Added.
• fast/forms/file/open-file-panel-crash.html: Added.
• platform/win/TestExpectations:

5:27 AM Changeset in webkit [260819] by Carlos Garcia Campos

• 8 edits in trunk

[GTK4] Add support for motion events
​https://bugs.webkit.org/show_bug.cgi?id=211073

Reviewed by Adrian Perez de Castro.

Source/WebKit:

Handle enter, leave and motion events using a GtkEventControllerMotion.

• Shared/NativeWebMouseEvent.h:
• Shared/gtk/NativeWebMouseEventGtk.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

• Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):

• Shared/gtk/WebEventFactory.h:
• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseEnter):
(webkitWebViewBaseMotion):
(webkitWebViewBaseLeave):
(webkitWebViewBaseConstructed):

Tools:

Use the GtkOverlay in GTK4 too so that status label is shown when hovering elements.

• MiniBrowser/gtk/BrowserTab.c:

(browserTabConstructed):

4:57 AM Changeset in webkit [260818] by Adrian Perez de Castro

• 9 edits in trunk/Source

Non-unified build fixes late April 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=211099

Unreviewed build fix.

Source/WebCore:

No new tests needed.

• Modules/cache/DOMCacheStorage.cpp: Sprinkle DOMCacheEngine:: namespace prefixes as needed.

(WebCore::DOMCacheStorage::findCacheOrCreate):
(WebCore::DOMCacheStorage::retrieveCaches):
(WebCore::DOMCacheStorage::doOpen):
(WebCore::DOMCacheStorage::doRemove):

• bindings/js/JSExecStateInstrumentation.h: Ditto for JSC:: namespace prefixes.

(WebCore::JSExecState::instrumentFunction):

• dom/ScriptedAnimationController.h: Add missing ReducedResolutionSeconds.h header.
• editing/TextCheckingHelper.h: Add missing forward declaration for Position.
• html/URLSearchParams.h: Add missing ExceptionOr.h header.

Source/WebKit:

• NetworkProcess/NetworkLoad.cpp: Add mising WebCoreArgumentCoders.h header.
• WebProcess/Automation/WebAutomationDOMWindowObserver.cpp:

(WebKit::WebAutomationDOMWindowObserver::WebAutomationDOMWindowObserver): Add namespace to
WebCore::DOMWindow usage.

4:50 AM Changeset in webkit [260817] by Carlos Garcia Campos

• 6 edits in trunk/Source/WebKit

[GTK4] Add support for scroll events
​https://bugs.webkit.org/show_bug.cgi?id=211045

Reviewed by Adrian Perez de Castro.

Use an event controller to connect to scroll signal and get the GdkEvent.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseHandleWheelEvent):
(webkitWebViewBaseScroll):
(webkitWebViewBaseConstructed):

4:28 AM Changeset in webkit [260816] by Carlos Garcia Campos

• 10 edits in trunk

[GTK4][Wayland] Add support for rendering web view contents
​https://bugs.webkit.org/show_bug.cgi?id=211021

Reviewed by Adrian Perez de Castro.

Source/WebKit:

Implement GtkWidgetClass::snapshot and GtkWidgetClass::measure instead of GtkWidgetClass::draw and
GtkWidgetClass::get_preferred_width|height. Add AcceleratedBackingStore::snapshot() pure virtual to be used with
GTK4 instead of AcceleratedBackingStore::paint(), and implement it for Wayland.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSnapshot): Call AcceleratedBackingStore::snapshot().
(webkitWebViewBaseMeasure): Return the natural width/height for the WebView.
(webkit_web_view_base_class_init): Add implementations for snapshot and measure vfuncs.

• UIProcess/gtk/AcceleratedBackingStore.h:
• UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:

(WebKit::AcceleratedBackingStoreWayland::tryEnsureGLContext): Always try to realize the context here, since that
can fail too.
(WebKit::AcceleratedBackingStoreWayland::tryEnsureTexture): Helper to share the code to prepare the texture.
(WebKit::AcceleratedBackingStoreWayland::downloadTexture): Helper to share the code to download the texture.
(WebKit::AcceleratedBackingStoreWayland::snapshot): Use gtk_snapshot_append_texture().
(WebKit::AcceleratedBackingStoreWayland::paint): Use new helpers.

• UIProcess/gtk/AcceleratedBackingStoreWayland.h:
• UIProcess/gtk/AcceleratedBackingStoreX11.cpp:

(WebKit::AcceleratedBackingStoreX11::snapshot):

• UIProcess/gtk/AcceleratedBackingStoreX11.h:
• UIProcess/gtk/HardwareAccelerationManager.cpp:

(WebKit::HardwareAccelerationManager::HardwareAccelerationManager): Force accelerated compositing mode for GTK4.

Tools:

Set vertical expand of web view to TRUE.

• MiniBrowser/gtk/BrowserTab.c:

(browserTabConstructed):

3:58 AM Changeset in webkit [260815] by cturner@igalia.com

• 2 edits in trunk/Source/WebCore

[EME][CDMProxy] Default initialize m_numDecryptorsWaitingForKey member
​https://bugs.webkit.org/show_bug.cgi?id=210970

Reviewed by Xabier Rodriguez-Calvar.

This was causing non-deterministic reads of the
m_numDecryptorsWaitingForKey member. Sometimes a waiting for key
event would fail to fire and cause test failures. I thought
std::atomic<int> would default initialize to zero, but after
spec-diving I realise now I was wrong about that.

Test: encrypted-media/clearkey-mp4-waiting-for-a-key.https.html

• platform/encryptedmedia/CDMProxy.h:

3:08 AM Changeset in webkit [260814] by youenn@apple.com

• 7 edits
  2 adds in trunk

RTCPeerConnection should not remove its created remote MediaStream objects until getting close
​https://bugs.webkit.org/show_bug.cgi?id=211070

Reviewed by Alex Christensen.

Source/WebCore:

Remove no longer needed code.
This aligns with the spec and Firefox implementation.
Test: webrtc/direction-change.html

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::transceiverBackendFromSender):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:

LayoutTests:

• webrtc/direction-change-expected.txt: Added.
• webrtc/direction-change.html: Added.
• webrtc/routines.js:
• webrtc/video-setDirection-expected.txt:
• webrtc/video-setDirection.html:

2:57 AM Changeset in webkit [260813] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Ensure remote track event gets unmuted after the track event is fired
​https://bugs.webkit.org/show_bug.cgi?id=211071

Reviewed by Alex Christensen.

This code was made obsolete by the setMuted(false) call done just after firing the track event.
Given the setMuted(false) in addPendingTrackEvent was done asynchronously and was triggering firing the muted event asynchronously,
this change should not be observable from JS.

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addPendingTrackEvent):

2:11 AM Changeset in webkit [260812] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

Make HistoryController an inner class of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=211090

Patch by Rob Buis <​rbuis@igalia.com> on 2020-04-28
Reviewed by Darin Adler.

Make HistoryController an inner class of FrameLoader, this allows
us to move some methods only used by HistoryController out of the
FrameLoader public API.

• loader/FrameLoader.h:
• loader/HistoryController.cpp:
• loader/HistoryController.h: