Timeline

May 8, 2020:

10:32 PM Changeset in webkit [261432] by Diego Pino Garcia

• 2 edits
  1 delete in trunk/LayoutTests

[GTK] Gardening, update expectations after revert of r261341 and r261392
​https://bugs.webkit.org/show_bug.cgi?id=211661

Unreviewed gardening.

• platform/gtk/TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/intrinsic_sizes-expected.txt: Removed.

9:17 PM Changeset in webkit [261431] by basuke.suzuki@sony.com

• 2 edits in trunk/Source/WebCore

Fix build error on PlatStation port after r261132
​https://bugs.webkit.org/show_bug.cgi?id=211659

Unreviewed build fix after r261132.

• page/scrolling/ScrollingTreeGestureState.cpp:

6:43 PM Changeset in webkit [261430] by Alexey Shvayka

• 4 edits in trunk

Array.prototype.concat fast path checks should not be observable
​https://bugs.webkit.org/show_bug.cgi?id=211643

Reviewed by Ross Kirsling.

JSTests:

While test262 has complete coverage for @@isConcatSpreadable getters in prototype
chain, Proxy cases are covered by stress/array-concat-fast-spread-proxy.js and
stress/array-concat-spread-proxy.js.

• test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This change utilizes @tryGetByIdWithWellKnownSymbol intrinsic to make
off the spec Symbol.isConcatSpreadable lookups unobservable to userland code,
aligning JSC with V8 and SpiderMonkey.

Since @tryGetById uses PropertySlot::getPureResult(), which returns null
for Proxy Get traps and JS getters (covered by stress/try-get-by-id.js),
we can safely compare its result undefined. Also, this allows us to remove
@isProxyObject check as Proxy argument is never a fast path anyway.

This patch is neutral on microbenchmarks/concat-append-one.js.

• builtins/ArrayPrototype.js:

(concat):

6:21 PM Changeset in webkit [261429] by ddkilzer@apple.com

• 7 edits
  35 deletes in trunk

Remove empty directories from from svn.webkit.org repository
<​https://webkit.org/b/211644>

Reviewed by Darin Adler.

6:13 PM Changeset in webkit [261428] by basuke.suzuki@sony.com

• 14 edits
  1 move in trunk

[WTF] Share Linux's MemoryPressureHandler among other Unix ports
​https://bugs.webkit.org/show_bug.cgi?id=208955

Reviewed by Yusuke Suzuki.

Source/bmalloc:

Added FreeBSD implementation of memoryFootprint().

• bmalloc/AvailableMemory.cpp:

(bmalloc::memoryStatus):

• bmalloc/AvailableMemory.h:

(bmalloc::isUnderMemoryPressure):

• bmalloc/bmalloc.h:

Source/WTF:

Renamed MemoryPressureHandlerLinux to MemoryPressureHandlerUnix and added FreeBSD implementation
of memory status functions. Change PlayStation port to use it from generic implementation.

• wtf/MemoryPressureHandler.cpp:

(WTF::MemoryPressureHandler::MemoryPressureHandler):

• wtf/MemoryPressureHandler.h:
• wtf/PlatformGTK.cmake:
• wtf/PlatformJSCOnly.cmake:
• wtf/PlatformPlayStation.cmake:
• wtf/PlatformWPE.cmake:
• wtf/generic/MemoryFootprintGeneric.cpp:

(WTF::memoryFootprint):

• wtf/unix/MemoryPressureHandlerUnix.cpp: Renamed from Source\WTF\wtf\linux\MemoryPressureHandlerLinux.cpp.

(WTF::processMemoryUsage):

Tools:

Fix unneeded library dependency.

• TestWebKitAPI/CMakeLists.txt:

5:02 PM Changeset in webkit [261427] by Simon Fraser

• 10 edits
  2 adds in trunk

Async overflow scroll: sometimes a <select> becomes non-scrollable
​https://bugs.webkit.org/show_bug.cgi?id=211433
<rdar://problem/62338474>

Reviewed by Dean Jackson.

Source/WebCore:

Scrollable <select>s (RenderListBox) contribute to the non-fast scrollable region, so
wheel events inside them are propagated to the main thread. If the select is scrolled
to the end, the event will propagate to the enclosing scroller, then then FrameView::wheelEvent()
may send it back to the scrolling thread. If the scrolling thread is processing such an event
after the main thread, it should not perform any latching on the main thread.

Test: scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe.html

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::handleWheelEvent):

• page/scrolling/ScrollingTree.h:
• page/scrolling/ScrollingTreeLatchingController.cpp:

(WebCore::ScrollingTreeLatchingController::receivedWheelEvent):
(WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const):
(WebCore::ScrollingTreeLatchingController::nodeDidHandleEvent):
(WebCore::ScrollingTreeLatchingController::clearLatchedNode):

• page/scrolling/ScrollingTreeLatchingController.h:
• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):

• page/scrolling/ThreadedScrollingTree.h:
• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

• platform/PlatformWheelEvent.cpp:

(WebCore::operator<<):

LayoutTests:

• scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe-expected.txt: Added.
• scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe.html: Added.

5:02 PM Changeset in webkit [261426] by Simon Fraser

• 1 edit
  4 adds in trunk/LayoutTests

Overflow scrollers in iframes don't get mouseMovedInContentArea()
​https://bugs.webkit.org/show_bug.cgi?id=211347
<rdar://problem/62784560>

Reviewed by Tim Horton.

Land some tests that were missing from r261382.

• fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered-expected.txt: Added.
• fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered.html: Added.
• fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal-expected.txt: Added.
• fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal.html: Added.

5:00 PM Changeset in webkit [261425] by Ryan Haddad

• 1 edit
  2 adds in trunk/LayoutTests

[LFC][TFC] The fixed logical width should be used as the max width for a cell
​https://bugs.webkit.org/show_bug.cgi?id=211610

Unreviewed test gardening.

Add a baseline for Windows.

• platform/win/fast/layoutformattingcontext/table-simple-with-fixed-widht-and-inline-content-expected.txt: Added.

4:20 PM Changeset in webkit [261424] by Darin Adler

• 8 edits in trunk/Source

Remove now-unneeded HAVE(AVFOUNDATION_LOADER_DELEGATE)
​https://bugs.webkit.org/show_bug.cgi?id=211646

Reviewed by Eric Carlson.

Source/WebCore:

• loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource): Remove check of
HAVE(AVFOUNDATION_LOADER_DELEGATE) in a place where it also checks PLATFORM(MAC).

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

Remove HAVE(AVFOUNDATION_LOADER_DELEGATE) in Cocoa-only code.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Ditto.

(WebCore::globalLoaderDelegateQueue): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest): Ditto.

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Ditto.
• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm: Ditto.

Source/WTF:

• wtf/PlatformHave.h: Don't set HAVE_AVFOUNDATION_LOADER_DELEGATE.

4:11 PM Changeset in webkit [261423] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Regression(r210945): No attachment when sharing to mail
​https://bugs.webkit.org/show_bug.cgi?id=211651
<rdar://problem/63040170>

Reviewed by Tim Horton.

When failing to determine foreground state, the code before r210945 was assuming
'foreground', while the code in r210945 assume 'background'. This causes things
to not render properly when we fail to determine the foreground state.

This patch merely restores pre-r210945 behavior. I will investigate why we are
unable to determinate the host application PID for the MailCompositionService.

• UIProcess/ApplicationStateTracker.mm:

(WebKit::isApplicationForeground):

4:11 PM Changeset in webkit [261422] by commit-queue@webkit.org

• 3 edits
  1 add in trunk

TextureMapper should skip clipping a content layer if it's not needed
​https://bugs.webkit.org/show_bug.cgi?id=210787

Patch by Tomoki Imai <Tomoki Imai> on 2020-05-08
Reviewed by Don Olmstead.

Source/WebCore:

This patch follows up r260174.
We don't need to clip a content layer if the clipping rect contains the content rect.
This patch doesn't change the behavior but saves stencil indices.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelf):

LayoutTests:

This patch follows up r260174 by updating the test expectation.

• platform/gtk/compositing/video/video-object-fit-expected.txt: Added.

3:56 PM Changeset in webkit [261421] by Jonathan Bedard

• 5 edits in trunk/Tools

webkitpy: 'iPhone SE' should match 'iPhone SE 1st generation'
​https://bugs.webkit.org/show_bug.cgi?id=211642
<rdar://problems/62986242>

Rubber-stamped by Aakash Jain.

• Scripts/webkitpy/xcode/device_type.py:

(DeviceType):
(DeviceType.standardized_hardware_type): Strip '1st generation' from models.
(DeviceType.eq): Use standardized hardware type.
(DeviceType.contains): Ditto.
(DeviceType.hash): Ditto.

• Scripts/webkitpy/xcode/device_type_unittest.py:

(DeviceTypeTest):
(DeviceTypeTest.test_generation_matching):

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDeviceManager._get_device_identifier_for_type): Handle case where the requests model does not
end with '(1st generation)', but the simctl model does.

• Scripts/webkitpy/xcode/simulated_device_unittest.py:

3:09 PM Changeset in webkit [261420] by Alan Coon

• 1 copy in tags/Safari-610.1.12

Tag Safari-610.1.12.

3:04 PM Changeset in webkit [261419] by Alan Coon

• 7 edits in branches/safari-610.1.12-branch

Revert r260642. rdar://problem/63037576

2:41 PM Changeset in webkit [261418] by Ryan Haddad

• 2 edits in trunk/Tools

TestWebKitAPI.WebKit.AllowsContentJavaScript fails on iPad simulator
​https://bugs.webkit.org/show_bug.cgi?id=207874

Unreviewed test gardening.

• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:

Disable the test for iOS.

2:21 PM Changeset in webkit [261417] by Darin Adler

• 1 edit
  1 delete in trunk/PerformanceTests

Remove no-longer-used PerformanceTests/StitchMarker
​https://bugs.webkit.org/show_bug.cgi?id=211639

Reviewed by Ryosuke Niwa.

Having this test around can be confusing since it contains old versions
of many WebKit source files, which will show up when searching the source
tree. And since we're not using it, we don't need to keep a copy of it
in the tip of tree in the repository.

• StitchMarker: Removed.

2:16 PM Changeset in webkit [261416] by mmaxfield@apple.com

• 3 edits
  2 adds in trunk

[iOS] Text-style fonts aren't locale-specific
​https://bugs.webkit.org/show_bug.cgi?id=211438
<rdar://problem/51654163>

Reviewed by Sam Weinig.

Source/WebCore:

Simply hook up the locale to the Core Text function.

It turns out that this patch actually has no behavior change,
because this locale is only used for font fallback, but WebKit
does its own font fallback and we already pass the locale into
CTFontCopyDefaultCascadeListForLanguages(). However, for
symmetry with CTFontCreateUIFontWithLanguage() it's a good idea
to just supply it anyway. Just in case.

Test: platform/ios/fast/text/lang-text-style.html

• platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:

(WebCore::SystemFontDatabaseCoreText::createTextStyleFont):

LayoutTests:

This test actually already passes. But it's a good idea to make
sure that it continues to pass in the future.

• platform/ios/fast/text/lang-text-style-expected-mismatch.html: Added.
• platform/ios/fast/text/lang-text-style.html: Added.

2:14 PM Changeset in webkit [261415] by ddkilzer@apple.com

• 3 edits in trunk/Tools

check-webkit-style false positive for [readability/naming/protected] with method declaration
<​https://webkit.org/b/210682>

Reviewed by Darin Adler.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_identifier_name_in_declaration):

• Don't check for invalid protector name if the capitalized protected name is the same as the original protected name, indicating it's a type name.
• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_names):

• Add test cases.

1:57 PM Changeset in webkit [261414] by achristensen@apple.com

• 2 edits in trunk/Tools

Fix build on platforms without network framework.
​https://bugs.webkit.org/show_bug.cgi?id=211603

• TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

Add HAVE(NETWORK_FRAMEWORK) around test that uses network framework.

1:48 PM Changeset in webkit [261413] by commit-queue@webkit.org

• 106 edits in trunk

[WebGL2] Complete new texture upload entry points in WebGL2RenderingContext
​https://bugs.webkit.org/show_bug.cgi?id=208875

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-05-08
Reviewed by Dean Jackson.

Source/WebCore:

Implement the remaining texture upload entry points - mainly for
3D textures - in WebGL2RenderingContext. Add support for uploading
from the pixel unpack buffer.

Refactor the WebGL 2.0 binding points into WebGL2RenderingContext,
where they had previously been in the base class. Refactor
validation code to override the base class where necessary.
Refactor getParameter into WebGLRenderingContextBase and override
it in WebGL2RenderingContext, eliminating duplicate code and
fixing bugs.

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::~WebGL2RenderingContext):
(WebCore::WebGL2RenderingContext::getInt64Parameter):
(WebCore::WebGL2RenderingContext::validateBufferTarget):
(WebCore::WebGL2RenderingContext::validateBufferTargetCompatibility):
(WebCore::WebGL2RenderingContext::validateBufferDataTarget):
(WebCore::WebGL2RenderingContext::validateAndCacheBufferBinding):
(WebCore::WebGL2RenderingContext::validateTexImageBinding):
(WebCore::WebGL2RenderingContext::validateTexture3DBinding):
(WebCore::WebGL2RenderingContext::copyBufferSubData):
(WebCore::WebGL2RenderingContext::bindFramebuffer):
(WebCore::WebGL2RenderingContext::deleteFramebuffer):
(WebCore::WebGL2RenderingContext::getTexParameter):
(WebCore::WebGL2RenderingContext::texStorage2D):
(WebCore::WebGL2RenderingContext::texStorage3D):
(WebCore::WebGL2RenderingContext::texImage2D):
(WebCore::WebGL2RenderingContext::texImage3D):
(WebCore::WebGL2RenderingContext::texSubImage2D):
(WebCore::WebGL2RenderingContext::texSubImage3D):
(WebCore::WebGL2RenderingContext::bindBufferBase):
(WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGL2RenderingContext::validateFramebufferTarget):
(WebCore::WebGL2RenderingContext::getFramebufferBinding):
(WebCore::WebGL2RenderingContext::getReadFramebufferBinding):
(WebCore::WebGL2RenderingContext::restoreCurrentFramebuffer):
(WebCore::WebGL2RenderingContext::getParameter):
(WebCore::WebGL2RenderingContext::uncacheDeletedBuffer):
(WebCore::WebGL2RenderingContext::validateFramebufferFuncParameters): Deleted.

• html/canvas/WebGL2RenderingContext.h:
• html/canvas/WebGLBuffer.cpp:

(WebCore::WebGLBuffer::setTarget):

• html/canvas/WebGLBuffer.h:
• html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::attach):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::isBound const):

• html/canvas/WebGLFramebuffer.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters): Deleted.
(WebCore::WebGLRenderingContext::getParameter): Deleted.

• html/canvas/WebGLRenderingContext.h:
• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::~WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::validateBufferTarget):
(WebCore::WebGLRenderingContextBase::validateBufferDataTarget):
(WebCore::WebGLRenderingContextBase::validateAndCacheBufferBinding):
(WebCore::WebGLRenderingContextBase::bindBuffer):
(WebCore::WebGLRenderingContextBase::bindFramebuffer):
(WebCore::WebGLRenderingContextBase::bindTexture):
(WebCore::WebGLRenderingContextBase::checkFramebufferStatus):
(WebCore::WebGLRenderingContextBase::uncacheDeletedBuffer):
(WebCore::WebGLRenderingContextBase::deleteFramebuffer):
(WebCore::WebGLRenderingContextBase::deleteRenderbuffer):
(WebCore::WebGLRenderingContextBase::deleteTexture):
(WebCore::WebGLRenderingContextBase::framebufferRenderbuffer):
(WebCore::WebGLRenderingContextBase::framebufferTexture2D):
(WebCore::WebGLRenderingContextBase::getParameter):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::copyTexImage2D):
(WebCore::WebGLRenderingContextBase::texParameter):
(WebCore::WebGLRenderingContextBase::getBoundReadFramebufferColorFormat):
(WebCore::WebGLRenderingContextBase::getBoundReadFramebufferWidth):
(WebCore::WebGLRenderingContextBase::getBoundReadFramebufferHeight):
(WebCore::WebGLRenderingContextBase::validateFramebufferTarget):
(WebCore::WebGLRenderingContextBase::getFramebufferBinding):
(WebCore::WebGLRenderingContextBase::getReadFramebufferBinding):
(WebCore::WebGLRenderingContextBase::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContextBase::validateBufferDataParameters):
(WebCore::WebGLRenderingContextBase::setFramebuffer):
(WebCore::WebGLRenderingContextBase::restoreCurrentFramebuffer):
(WebCore::WebGLRenderingContextBase::getInt64Parameter): Deleted.

• html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

All of the 3D texture tests in
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/ and
webgl/2.0.0/conformance2/textures/image_data/ now pass, and
several others progress, including some which now pass completely.
Rebaseline all of these.

Skip webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/
temporarily to reduce the size of these rebaselines, as the
failures are likely caused by non-WebGL browser bugs. Filed Bug
211484 to track re-enabling them.

• TestExpectations:
• platform/mac/webgl/fingerprinting-strings-expected.txt:
• webgl/2.0.0/conformance/state/gl-enable-enum-test-expected.txt:
• webgl/2.0.0/conformance2/buffers/buffer-copying-contents-expected.txt:
• webgl/2.0.0/conformance2/buffers/buffer-copying-restrictions-expected.txt:
• webgl/2.0.0/conformance2/buffers/buffer-type-restrictions-expected.txt:
• webgl/2.0.0/conformance2/buffers/uniform-buffers-expected.txt:
• webgl/2.0.0/conformance2/misc/expando-loss-2-expected.txt:
• webgl/2.0.0/conformance2/misc/getextension-while-pbo-bound-stability-expected.txt:
• webgl/2.0.0/conformance2/misc/object-deletion-behaviour-2-expected.txt:
• webgl/2.0.0/conformance2/misc/views-with-offsets-expected.txt:
• webgl/2.0.0/conformance2/renderbuffers/framebuffer-texture-layer-expected.txt:
• webgl/2.0.0/conformance2/rendering/blitframebuffer-test-expected.txt:
• webgl/2.0.0/conformance2/rendering/canvas-resizing-with-pbo-bound-expected.txt:
• webgl/2.0.0/conformance2/rendering/out-of-bounds-index-buffers-after-copying-expected.txt:
• webgl/2.0.0/conformance2/state/gl-get-calls-expected.txt:
• webgl/2.0.0/conformance2/state/gl-getstring-expected.txt:
• webgl/2.0.0/conformance2/state/gl-object-get-calls-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r11f_g11f_b10f-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r11f_g11f_b10f-rgb-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r16f-red-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r16f-red-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r32f-red-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r8-red-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r8ui-red_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rg16f-rg-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rg16f-rg-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rg32f-rg-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rg8-rg-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rg8ui-rg_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb16f-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb16f-rgb-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb32f-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb565-rgb-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb565-rgb-unsigned_short_5_6_5-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb5_a1-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb5_a1-rgba-unsigned_short_5_5_5_1-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb8-rgb-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb9_e5-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb9_e5-rgb-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba16f-rgba-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba16f-rgba-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba32f-rgba-float-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba4-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba4-rgba-unsigned_short_4_4_4_4-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba8-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-srgb8-rgb-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-r11f_g11f_b10f-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-r11f_g11f_b10f-rgb-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-r16f-red-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-r16f-red-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-r32f-red-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-r8-red-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-r8ui-red_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rg16f-rg-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rg16f-rg-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rg32f-rg-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rg8-rg-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rg8ui-rg_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb16f-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb16f-rgb-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb32f-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb565-rgb-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb565-rgb-unsigned_short_5_6_5-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb5_a1-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb5_a1-rgba-unsigned_short_5_5_5_1-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb8-rgb-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb9_e5-rgb-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgb9_e5-rgb-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba16f-rgba-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba16f-rgba-half_float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba32f-rgba-float-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba4-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba4-rgba-unsigned_short_4_4_4_4-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba8-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-srgb8-rgb-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/image_data/tex-3d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/copy-texture-image-webgl-specific-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/gl-get-tex-parameter-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-image-and-sub-image-with-array-buffer-view-sub-source-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-input-validation-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-storage-2d-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-storage-and-subimage-3d-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-unpack-params-expected.txt:

1:46 PM Changeset in webkit [261412] by Nikos Mouchtaris

• 18 edits
  2 adds in trunk

Implement web-share v2 for files
​https://bugs.webkit.org/show_bug.cgi?id=209265

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

Updated test expectations for new behavior.

• ios-wk2/imported/w3c/web-platform-tests/web-share/canShare-files.https-expected.txt :
• mac-wk2/imported/w3c/web-platform-tests/web-share/canShare-files.https-expected.txt :

Source/WebCore:

Modified existing tests for new behavior.

Added support for handling of files in share/canShare,
and implemented asynchronous reading of data from blobs on
disk into memory.

• WebCore.xcodeproj/project.pbxproj:
• page/Navigator.cpp:

(WebCore::Navigator::canShare):
(WebCore::Navigator::share):
(WebCore::Navigator::finishedLoad):

• page/Navigator.h:
• page/ReadShareDataAsync.cpp: Added.

(WebCore::ReadShareDataAsync::readInternal):
(WebCore::ReadShareDataAsync::ReadShareDataAsync):
(WebCore::ReadShareDataAsync::~ReadShareDataAsync):
(WebCore::ReadShareDataAsync::start):
(WebCore::ReadShareDataAsync::didFinishLoading):
(WebCore::ReadShareDataAsync::didReceiveData):
(WebCore::ReadShareDataAsync::didStartLoading):
(WebCore::ReadShareDataAsync::didFail):

• page/ReadShareDataAsync.hpp: Added.
• page/ShareData.h:

Source/WebKit:

Added support for passing file objects over IPC and
sharing of files to share sheet.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Vector<RawFile>>::encode):
(IPC::ArgumentCoder<Vector<RawFile>>::decode):
(IPC::ArgumentCoder<ShareDataWithParsedURL>::encode):
(IPC::ArgumentCoder<ShareDataWithParsedURL>::decode):

• Shared/WebCoreArgumentCoders.h:
• UIProcess/Cocoa/ShareableFileWrite.h: Added.
• UIProcess/Cocoa/ShareableFileWrite.mm: Added.

(+[WKShareableFileWrite getSharingDirectoryPath]):
(+[WKShareableFileWrite getFileDirectoryForSharing]):
(+[WKShareableFileWrite removeFileDirectoryForSharing]):
(+[WKShareableFileWrite setQuarantineInformationForFilePath:]):
(+[WKShareableFileWrite applyQuarantineSandboxAndDownloadFlagsToFileAtPath:]):
(+[WKShareableFileWrite createFilename:]):
(+[WKShareableFileWrite writeFileToShareableURL:data:]):

• UIProcess/Cocoa/WKShareSheet.mm:

(-[WKShareSheet presentWithParameters:inRect:completionHandler:]):
(-[WKShareSheet _didCompleteWithSuccess:]):

• WebKit.xcodeproj/project.pbxproj:

LayoutTests:

Modified to no longer use url of image.

• fast/web-share/share-with-files.html:

1:43 PM Changeset in webkit [261411] by Brent Fulgham

• 3 edits in trunk/Source/WebKit

Revise sandbox to stop logging some commonly-used properties
​https://bugs.webkit.org/show_bug.cgi?id=211636
<rdar://problem/63014244>

Reviewed by Per Arne Vollan.

Further living on and testing has shown a handful of sysctl entries that are in regular use, and do not need
to be logged or considered for removal. This patch has no change in behavior, just reduces logging.

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:

1:41 PM Changeset in webkit [261410] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

REGRESSION [ iOS ] fast/forms/validationMessage.html is flaky and timing out
​https://bugs.webkit.org/show_bug.cgi?id=206630

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

1:27 PM Changeset in webkit [261409] by Ryan Haddad

• 14 edits
  2 deletes in trunk

Unreviewed, reverting r261341 and r261392.

Caused multiple regression test failures

Reverted changesets:

"Poster set after playback begins should be ignored"
​https://bugs.webkit.org/show_bug.cgi?id=211464
​https://trac.webkit.org/changeset/261341

"REGRESSION(r261341): imported/w3c/web-platform-
tests/html/semantics/embedded-content/the-video-
element/intrinsic_sizes.htm is failing"
​https://bugs.webkit.org/show_bug.cgi?id=211612
​https://trac.webkit.org/changeset/261392

1:20 PM Changeset in webkit [261408] by aakash_jain@apple.com

• 18 edits
  2 deletes in trunk/Tools

Delete old ews client side code
​https://bugs.webkit.org/show_bug.cgi?id=211638

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/common/checkout/changelog_unittest.py:
• Scripts/webkitpy/common/config/urls.py: Removed old ews server url.
• Scripts/webkitpy/common/net/statusserver.py: Removed.
• Scripts/webkitpy/common/net/statusserver_mock.py: Removed.
• Scripts/webkitpy/tool/bot/botinfo.py:
• Scripts/webkitpy/tool/bot/botinfo_unittest.py:
• Scripts/webkitpy/tool/bot/flakytestreporter.py:
• Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
• Scripts/webkitpy/tool/bot/queueengine.py:
• Scripts/webkitpy/tool/bot/queueengine_unittest.py:
• Scripts/webkitpy/tool/commands/earlywarningsystem.py:
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
• Scripts/webkitpy/tool/commands/perfalizer.py:
• Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue._log_from_script_error_for_upload): Deleted.
(AbstractQueue._update_status_for_script_error): Deleted.
(AbstractPatchQueue._update_status): Deleted.
(AbstractPatchQueue._release_work_item): Deleted.
(AbstractPatchQueue._did_pass): Deleted.
(AbstractPatchQueue._did_fail): Deleted.

• Scripts/webkitpy/tool/commands/queues_unittest.py:

(AbstractQueueTest._assert_run_webkit_patch):
(AbstractQueueTest.test_no_iteration_count):
(PatchProcessingQueueTest.test_upload_results_archive_for_patch):
(AbstractQueueTest._assert_log_message): Deleted.
(AbstractQueueTest.test_log_from_script_error_for_upload): Deleted.
(AbstractPatchQueueTest): Deleted.
(NeedsUpdateSequence): Deleted.
(NeedsUpdateSequence._run): Deleted.
(StyleQueueTest): Deleted.
(StyleQueueTest.test_style_queue_with_style_exception): Deleted.

• Scripts/webkitpy/tool/commands/queuestest.py:

(QueuesTest._default_begin_work_queue_logs):
(QueuesTest._default_begin_work_queue_stderr): Deleted.

• Scripts/webkitpy/tool/commands/sheriffbot.py:
• Scripts/webkitpy/tool/main.py:
• Scripts/webkitpy/tool/mocktool.py:

1:10 PM Changeset in webkit [261407] by Chris Dumez

• 10 edits in trunk

Make WKWebViewConfiguration._alwaysRunsAtForegroundPriority an alias for _clientNavigationsRunAtForegroundPriority
​https://bugs.webkit.org/show_bug.cgi?id=211632

Reviewed by Darin Adler.

Make WKWebViewConfiguration._alwaysRunsAtForegroundPriority an alias for _clientNavigationsRunAtForegroundPriority.
_alwaysRunsAtForegroundPriority is a frequent source of process assertion leaks that get blamed on WebKit. Clients
are using this in order to be able to do loads in background views so _clientNavigationsRunAtForegroundPriority
should suffice and is not leak prone since the process assertion is released after the navigation has completed.

• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy const):

• UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::alwaysRunsAtForegroundPriority const): Deleted.
(API::PageConfiguration::setAlwaysRunsAtForegroundPriority): Deleted.

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _alwaysRunsAtForegroundPriority]):
(-[WKWebViewConfiguration _setAlwaysRunsAtForegroundPriority:]):

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::updateThrottleState):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

• UIProcess/WebPageProxy.h:

1:08 PM Changeset in webkit [261406] by Darin Adler

• 1 edit
  2 adds in trunk/LayoutTests

Add a regression test for bug 211541
​https://bugs.webkit.org/show_bug.cgi?id=211635

Reviewed by Geoffrey Garen.

• fast/box-shadow/box-shadow-huge-area-crash-expected.html: Added.
• fast/box-shadow/box-shadow-huge-area-crash.html: Added.

1:05 PM Changeset in webkit [261405] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Revert r260390
​https://bugs.webkit.org/show_bug.cgi?id=210759
<rdar://problem/62608140>

r260390 was intended to stop hitting some assertions in ~PendingFrameLoad, but it seems to have caused a regression.
Reverting it and removing the invalid assertions.

• NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::~PendingFrameLoad):
(WebKit::NetworkCache::SpeculativeLoadManager::~SpeculativeLoadManager):

12:59 PM Changeset in webkit [261404] by jer.noble@apple.com

• 2 edits in trunk/LayoutTests

media/video-zoom.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=211631

Reviewed by Eric Carlson.

Remove the 1.5s early timeout check here; with the additional 150ms per video element timeout elsewhere
in the test, this is short enough to cause flaky failures on busy bots.

• media/video-zoom.html:

12:45 PM Changeset in webkit [261403] by Alan Coon

• 2 edits in branches/safari-610.1.12-branch/Source/WebKit

Revert r260787. rdar://problem/63032130

12:39 PM Changeset in webkit [261402] by commit-queue@webkit.org

• 4 edits in trunk

Limit HTTP referer to 4kb
​https://bugs.webkit.org/show_bug.cgi?id=211603
<rdar://problem/56768823>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-05-08
Reviewed by Chris Dumez.

Source/WebCore:

Use the origin if it's longer, unless the origin is too long.
This matches the behavior of other browsers.
See ​https://bugzilla.mozilla.org/show_bug.cgi?id=1557346

Tested by API tests.

• platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::setHTTPReferrer):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(TEST):

12:11 PM Changeset in webkit [261401] by Ryan Haddad

• 2 edits in branches/safari-609-branch/Tools

Cherry-pick r260484. rdar://problem/62140724

Bindings-test should not depend on current working directory.
​https://bugs.webkit.org/show_bug.cgi?id=210831

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/bindings/main.py: (BindingsTests.main):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:36 AM Changeset in webkit [261400] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN
​https://bugs.webkit.org/show_bug.cgi?id=211539

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-05-08
Reviewed by Simon Fraser.

Corrected the comment.

No new test needed.

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

10:57 AM Changeset in webkit [261399] by commit-queue@webkit.org

• 4 edits in trunk

Fix urlsearchparams-delete.html
​https://bugs.webkit.org/show_bug.cgi?id=211456

Patch by Rob Buis <​rbuis@igalia.com> on 2020-05-08
Reviewed by Daniel Bates.

LayoutTests/imported/w3c:

Update improved test expectation.

• web-platform-tests/url/urlsearchparams-delete-expected.txt:

Source/WebCore:

Step 2 of URLSearchParams.delete algorithm [1] indicates
we should run the update steps, even if no name-value
pairs were removed.

Behavior matches Chrome and Firefox.

[1] ​https://url.spec.whatwg.org/#dom-urlsearchparams-delete

Test: web-platform-tests/url/urlsearchparams-delete.html

• html/URLSearchParams.cpp:

(WebCore::URLSearchParams::remove):

10:57 AM Changeset in webkit [261398] by Wenson Hsieh

• 12 edits
  2 adds in trunk

[iOS] caret appears in the middle of a search field when field is focused on agoda.com
​https://bugs.webkit.org/show_bug.cgi?id=211591
<rdar://problem/60605873>

Reviewed by Antoine Quint.

Source/WebCore:

See WebKit/ChangeLog for more details.

Test: editing/selection/ios/caret-rect-after-animating-focused-text-field.html

• animation/WebAnimation.cpp:

(WebCore::WebAnimation::finishNotificationSteps):

Add plumbing to call out to the WebKit client layer after an animation finishes running.

• dom/Node.h:
• editing/VisibleSelection.h:

WEBCORE_EXPORT a couple of methods.

• page/ChromeClient.h:

(WebCore::ChromeClient::animationDidFinishForElement):

Source/WebKit:

The main search field on the mobile version of this website begins offscreen, with a CSS transform that moves it
to the far right; tapping the button element that (visually) has a search-field-like appearance on the front
page programmatically focuses the real offscreen search field, and animates it onscreen by changing the CSS
transform attribute to remove the x-axis translation.

On iOS, the caret rect is computed and sent to the UI process via editor state updates; however, the editor
state is computed immediately after focusing the input field. As such, the caret rect at this moment is computed
in the middle of the animation, leaving it stuck in an unpredictable location.

To fix this, add plumbing to call into the WebKit client layer when an animation has ended. On iOS, if the
selection is visible (i.e. a ranged selection, or editable caret), then check to see whether the element that
has finished animating contains either endpoint of the selection. If so, then schedule a followup editor state
update to push updated selection information to the UI process.

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::animationDidFinishForElement):

• WebProcess/WebCoreSupport/WebChromeClient.h:

Add a new client hook for when animations end.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::animationDidFinishForElement):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

Add logic to schedule a new editor state update if needed, after an animation ends that might affect either
the start or end of the selection.

(WebKit::WebPage::animationDidFinishForElement):

LayoutTests:

Add a new layout test to verify that the caret view eventually becomes visible when after a focused text field
containing the caret is animated.

• editing/selection/ios/caret-rect-after-animating-focused-text-field-expected.txt: Added.
• editing/selection/ios/caret-rect-after-animating-focused-text-field.html: Added.

10:56 AM Changeset in webkit [261397] by dino@apple.com

• 2 edits in trunk/Tools

Allow run-safari to launch an iPad simulator
​https://bugs.webkit.org/show_bug.cgi?id=211606
<rdar://problem/63002849>

Reviewed by Jon Lee.

Add an "--ipad-simulator" command line option to run-safari.

• Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(determineXcodeSDK): Mark the device idiom depending on the command line argument.
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
(findOrCreateSimulatorForIOSDevice): Create an iPad Pro simulator if requested.

10:53 AM Changeset in webkit [261396] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r260228): Linker warning about limitsNavigationsToAppBoundDomains property overriding instance methods from class
<​https://webkit.org/b/211393>

Reviewed by Brent Fulgham.

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration limitsNavigationsToAppBoundDomains]):
(-[WKWebViewConfiguration setLimitsNavigationsToAppBoundDomains:]):

• Move from WKPrivate category to main category to fix linker warnings.

10:35 AM Changeset in webkit [261395] by Wenson Hsieh

• 11 edits
  2 adds in trunk

Preserve character set information when writing to the pasteboard when copying rich text
​https://bugs.webkit.org/show_bug.cgi?id=211524

Reviewed by Darin Adler.

Source/WebCore:

This patch is a followup to r261247, which introduced a workaround for Cocoa platforms to automatically add a
meta charset when writing HTML data to the platform pasteboard. When copying a rich text selection, we use a
different codepath when sanitizing DOM content - that is, serializePreservingVisualAppearance.

The previous change also introduced an enum, AddMetaCharsetIfNeeded, to limit applying this workaround to only
when we're writing HTML to the clipboard. However, it should be harmless to include this when reading sanitized
HTML as well, so we can also simplify this code by removing the AddMetaCharsetIfNeeded enum (and all of its
uses).

Test: CopyHTML.SanitizationPreservesCharacterSetInSelectedText

• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:

(WebCore::ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::sanitizeDataIfNeeded):

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDataFromItemList):

• editing/MarkupAccumulator.h:

(WebCore::MarkupAccumulator::isAllASCII const):

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::sanitizeMarkupWithArchive):
(WebCore::WebContentReader::readHTML):
(WebCore::WebContentMarkupReader::readHTML):

• editing/markup.cpp:

(WebCore::sanitizeMarkup):
(WebCore::serializePreservingVisualAppearanceInternal):

Move the meta charset workaround from sanitizedMarkupForFragmentInDocument to
serializePreservingVisualAppearanceInternal, such that HTML data written to the pasteboard when copying rich
text can be used to load a web view, without losing the fact that the copied content was UTF-8 encoded.

(WebCore::sanitizedMarkupForFragmentInDocument):

• editing/markup.h:

Tools:

Add a new API test to verify that the HTML data written to the pasteboard when copying a rich text selection
can be converted into an NSAttributedString that contains correctly encoded non-Latin characters.

• TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:

LayoutTests:

Rebaseline several layout tests.

• platform/ios/editing/pasteboard/onpaste-text-html-expected.txt:
• platform/mac/editing/pasteboard/onpaste-text-html-expected.txt: Added.
• platform/mac/fast/events/ondrop-text-html-expected.txt: Added.

10:33 AM Changeset in webkit [261394] by Chris Dumez

• 5 edits in trunk

REGRESSION(r259209) Webview's pending URL is null after restoring session state
​https://bugs.webkit.org/show_bug.cgi?id=211626
<rdar://problem/62992262>

Reviewed by Alex Christensen.

Source/WebKit:

The issue was that WebPageProxy::goToBackForwardItem() would behave differently whether
the page has a running process or not. In particular, when the page did not have a
running process, goToBackForwardItem() would return early and call launchProcessWithItem()
instead. Unlike goToBackForwardItem(), launchProcessWithItem() would fail to set the
pending API request.

To address the issue, I am getting rid of launchProcessWithItem() and merging its logic
into goToBackForwardItem() instead. Both methods shared a lot of code anyway and having
2 separate code paths that may diverge is error prone.

Change is covered by new API test.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::launchProcessWithItem): Deleted.

• UIProcess/WebPageProxy.h:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:

(TestWebKitAPI::TEST):

10:31 AM Changeset in webkit [261393] by don.olmstead@sony.com

• 40 edits in trunk/Source/WTF

[clang-tidy] Run modernize-use-nullptr over WTF
​https://bugs.webkit.org/show_bug.cgi?id=211628

Reviewed by Yusuke Suzuki.

Use the fix option in clang-tidy to ensure nullptr is being used across WTF.

• wtf/Assertions.cpp:
• wtf/BumpPointerAllocator.h:

(WTF::BumpPointerPool::BumpPointerPool):
(WTF::BumpPointerPool::create):
(WTF::BumpPointerAllocator::BumpPointerAllocator):

• wtf/DataLog.cpp:

(WTF::setDataFile):

• wtf/DateMath.cpp:

(WTF::parseES5DatePortion):
(WTF::parseES5TimePortion):

• wtf/FastMalloc.cpp:

(WTF::fastZeroedMalloc):
(WTF::fastStrDup):
(WTF::tryFastZeroedMalloc):
(WTF::isFastMallocEnabled):
(WTF::fastMallocGoodSize):
(WTF::fastAlignedMalloc):
(WTF::tryFastAlignedMalloc):
(WTF::fastAlignedFree):
(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::fastRealloc):
(WTF::tryFastRealloc):
(WTF::releaseFastMallocFreeMemory):
(WTF::releaseFastMallocFreeMemoryForThisThread):
(WTF::fastMallocStatistics):
(WTF::fastMallocSize):
(WTF::fastCommitAlignedMemory):
(WTF::fastDecommitAlignedMemory):
(WTF::fastEnableMiniMode):
(WTF::fastDisableScavenger):
(WTF::fastMallocDumpMallocStats):
(WTF::AvoidRecordingScope::avoidRecordingCount):
(WTF::AvoidRecordingScope::AvoidRecordingScope):
(WTF::AvoidRecordingScope::~AvoidRecordingScope):
(WTF::MallocCallTracker::MallocSiteData::MallocSiteData):
(WTF::MallocCallTracker::singleton):
(WTF::MallocCallTracker::MallocCallTracker):
(WTF::MallocCallTracker::recordMalloc):
(WTF::MallocCallTracker::recordRealloc):
(WTF::MallocCallTracker::recordFree):
(WTF::MallocCallTracker::dumpStats):

• wtf/HashTable.h:

(WTF::KeyTraits>::inlineLookup):
(WTF::KeyTraits>::lookupForWriting):
(WTF::KeyTraits>::fullLookupForWriting):
(WTF::KeyTraits>::add):

• wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::findAndRemoveFreeSpace):

• wtf/ParallelJobsGeneric.cpp:
• wtf/RandomDevice.cpp:

(WTF::RandomDevice::cryptographicallyRandomValues):

• wtf/RawPointer.h:

(WTF::RawPointer::RawPointer):

• wtf/RedBlackTree.h:
• wtf/SHA1.cpp:

(WTF::SHA1::hexDigest):

• wtf/SchedulePair.h:

(WTF::SchedulePair::SchedulePair):

• wtf/StackTrace.cpp:

(WTFGetBacktrace):
(WTF::StackTrace::dump const):

• wtf/StringExtras.h:

(strnstr):

• wtf/Variant.h:
• wtf/Vector.h:

(WTF::VectorBufferBase::deallocateBuffer):
(WTF::VectorBufferBase::releaseBuffer):
(WTF::VectorBufferBase::VectorBufferBase):

• wtf/cf/CFURLExtras.cpp:

(WTF::createCFURLFromBuffer):
(WTF::getURLBytes):

• wtf/cf/CFURLExtras.h:
• wtf/cf/FileSystemCF.cpp:

(WTF::FileSystem::pathAsURL):

• wtf/dtoa/double-conversion.cc:
• wtf/dtoa/utils.h:

(WTF::double_conversion::BufferReference::BufferReference):

• wtf/text/CString.cpp:

(WTF::CString::mutableData):

• wtf/text/CString.h:
• wtf/text/StringBuffer.h:

(WTF::StringBuffer::release):

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::createUninitializedInternal):
(WTF::StringImpl::reallocateInternal):

• wtf/text/StringImpl.h:

(WTF::StringImpl::constructInternal<LChar>):
(WTF::StringImpl::constructInternal<UChar>):
(WTF::StringImpl::characters<LChar> const):
(WTF::StringImpl::characters<UChar> const):
(WTF::find):
(WTF::reverseFindLineTerminator):
(WTF::reverseFind):
(WTF::equalIgnoringNullity):
(WTF::codePointCompare):
(WTF::isSpaceOrNewline):
(WTF::lengthOfNullTerminatedString):
(WTF::StringImplShape::StringImplShape):
(WTF::StringImpl::isolatedCopy const):
(WTF::StringImpl::isAllASCII const):
(WTF::StringImpl::isAllLatin1 const):
(WTF::isAllSpecialCharacters):
(WTF::isSpecialCharacter const):
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::create8BitIfPossible):
(WTF::StringImpl::createSubstringSharingImpl):
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::adopt):
(WTF::StringImpl::cost const):
(WTF::StringImpl::costDuringGC):
(WTF::StringImpl::setIsAtom):
(WTF::StringImpl::setHash const):
(WTF::StringImpl::ref):
(WTF::StringImpl::deref):
(WTF::StringImpl::copyCharacters):
(WTF::StringImpl::at const):
(WTF::StringImpl::allocationSize):
(WTF::StringImpl::maxInternalLength):
(WTF::StringImpl::tailOffset):
(WTF::StringImpl::requiresCopy const):
(WTF::StringImpl::tailPointer const):
(WTF::StringImpl::tailPointer):
(WTF::StringImpl::substringBuffer const):
(WTF::StringImpl::substringBuffer):
(WTF::StringImpl::assertHashIsCorrect const):
(WTF::StringImpl::StaticStringImpl::StaticStringImpl):
(WTF::StringImpl::StaticStringImpl::operator StringImpl&):
(WTF::equalIgnoringASCIICase):
(WTF::startsWithLettersIgnoringASCIICase):
(WTF::equalLettersIgnoringASCIICase):

• wtf/text/TextBreakIterator.cpp:

(WTF::initializeIterator):
(WTF::setContextAwareTextForIterator):
(WTF::openLineBreakIterator):

• wtf/text/TextBreakIterator.h:

(WTF::LazyLineBreakIterator::get):

• wtf/text/WTFString.cpp:

(WTF::charactersToFloat):

• wtf/text/cf/StringImplCF.cpp:

(WTF::StringWrapperCFAllocator::allocate):
(WTF::StringWrapperCFAllocator::create):
(WTF::StringImpl::createCFString):

• wtf/text/icu/UTextProviderLatin1.cpp:

(WTF::uTextLatin1Clone):
(WTF::openLatin1ContextAwareUTextProvider):

• wtf/text/icu/UTextProviderUTF16.cpp:

(WTF::openUTF16ContextAwareUTextProvider):

• wtf/win/FileSystemWin.cpp:

(WTF::FileSystemImpl::makeAllDirectories):
(WTF::FileSystemImpl::storageDirectory):
(WTF::FileSystemImpl::openTemporaryFile):
(WTF::FileSystemImpl::openFile):
(WTF::FileSystemImpl::writeToFile):
(WTF::FileSystemImpl::readFromFile):
(WTF::FileSystemImpl::deleteNonEmptyDirectory):

• wtf/win/LanguageWin.cpp:

(WTF::localeInfo):

• wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

• wtf/win/OSAllocatorWin.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::reserveAndCommit):

• wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::run):
(WTF::RunLoop::iterate):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::cycle):
(WTF::RunLoop::TimerBase::start):

• wtf/win/ThreadingWin.cpp:

(WTF::Thread::establishHandle):

10:30 AM Changeset in webkit [261392] by eric.carlson@apple.com

• 2 edits in trunk/LayoutTests

REGRESSION(r261341): imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm is failing
​https://bugs.webkit.org/show_bug.cgi?id=211612
<rdar://problem/63024081>

Unreviewed test gardening.

• TestExpectations: Mark test as Flakey. A proper fix is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=211630.

10:14 AM Changeset in webkit [261391] by ysuzuki@apple.com

• 9 edits
  1 add in trunk/LayoutTests

Code pattern in GC tests in LayoutTests is broken
​https://bugs.webkit.org/show_bug.cgi?id=211595

Reviewed by Saam Barati.

LayoutTests have several tests which attempt to ensure that document is not leaked. But they are broken since these tests are not correctly
handling conservative GC of JavaScriptCore. These tests are taking a following approach.

1. Allocate *one* iframe doing something inside it.
2. Remove iframe from the parent document to make it released.
3. Repeatedly invoke GC and test whether (1)'s document gets collected.

This is not the right approach. Since JavaScriptCore has conservative GC, it is easily possible that (1)'s pointer value remains in some of
conservative roots: CPU registers, stack etc. And JavaScriptCore conservative GC scans it and keeps it alive. The above approach makes the
test super flaky and any unrelated changes in JavaScriptCore and C compiler can make this test failed.

This is not a problem in practice. Web pages are executing various kind of code and they clobber conservative roots. However, tests in
LayoutTests are too simple to keep it alive accidentally.

The right approach for conservative GC is the following.

1. Allocate *many* iframes doing something inside them with loop. By creating iframes with loop, for every iteration, it is likely that the same CPU registers and stack locations are overwritten by the last created iframe reference. This dramatically reduces the possibility for GC to find these addresses in conservative roots.
2. Remove iframes from the parent document to make them released.
3. Repeatedly invoke GC and test whether *one of (1) iframes* gets collected at least. Theoretically this is still possible that completely unrelated integer value in conservative roots can point to the reference of (1). By allocating many iframes in (1) and testing one of them, we can reduce the possibility of this conflict.

This patch adds testDocumentIsNotLeaked helper function to enforce this pattern. And rewrite broken tests with this helper to make it less-flaky.

• highlight/highlight-world-leak.html:
• http/tests/IndexedDB/collect-IDB-objects.https.html:
• http/tests/media/clearkey/collect-webkit-media-session.html:
• http/tests/media/media-stream/collect-media-devices.https.html:
• http/tests/resources/gc.js: Added.

(window.gc.gcRec):
(window.gc.window.gc):
(nukeArray):
(async testDocumentIsNotLeaked):

• intersection-observer/no-document-leak.html:
• performance-api/performance-observer-no-document-leak.html:
• resources/gc.js:

(nukeArray):
(async testDocumentIsNotLeaked):

• webanimations/leak-document-with-web-animation.html:

10:13 AM Changeset in webkit [261390] by commit-queue@webkit.org

• 6 edits in trunk

WKWebView.title should be safe browsing warning's title during a safe browsing warning
​https://bugs.webkit.org/show_bug.cgi?id=211403

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-05-08
Reviewed by Tim Horton.

Source/WebKit:

Add a new property to PageLoadState, which allows the title to be set underneath it.
That way, once the safe browsing warning is closed, we can update the title to what it would've been,
including any changes that happened while the warning was open.

Covered by an API test. I also manually verified this fixes rdar://problem/56201982

• UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::commitChanges):
(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::didCommitLoad):
(WebKit::PageLoadState::title const):
(WebKit::PageLoadState::setTitleFromSafeBrowsingWarning):

• UIProcess/PageLoadState.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(TEST):

9:55 AM Changeset in webkit [261389] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] Update message filtering rules in the WebContent process' sandbox
​https://bugs.webkit.org/show_bug.cgi?id=211188

Reviewed by Brent Fulgham.

Based on telemetry and local testing, update the message filtering rules in the WebContent process' sandbox on iOS.
Messages that have not been observed being in use should be denied.

No new tests, covered by existing tests.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

9:48 AM Changeset in webkit [261388] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Turn processDidBecomeUnresponsive logging into error logging
​https://bugs.webkit.org/show_bug.cgi?id=211629

Reviewed by Youenn Fablet.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidBecomeUnresponsive):

9:33 AM Changeset in webkit [261387] by pvollan@apple.com

• 4 edits in trunk/Source

[Cocoa] Close connections to Launch Services after revoking extension
​https://bugs.webkit.org/show_bug.cgi?id=211594

Reviewed by Brent Fulgham.

Source/WebCore/PAL:

Declare _LSDService class.

• pal/spi/cocoa/LaunchServicesSPI.h:

Source/WebKit:

In <​https://trac.webkit.org/changeset/258915/webkit>, connections to the Launch Services database mapping
services were denied, by creating a temporary extension. After revoking this extension in the WebContent
process, it is important to close any open connections to Launch Services initiated by the mapping.

No new tests, covered by existing UTI/MIME type tests.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

9:23 AM Changeset in webkit [261386] by Darin Adler

• 2 edits in trunk/Source/WTF

Make callBufferProducingFunction safer to use by adding a compile-time assertion
​https://bugs.webkit.org/show_bug.cgi?id=211599

Reviewed by Ross Kirsling.

• wtf/unicode/icu/ICUHelpers.h:

(WTF::CallBufferProducingFunction::argumentTuple): Add a static_assert that
checks these are just simple types, aside from the Vector for the buffer.
This would have caught the UpconvertedCharacters problem fixed earlier today.

9:17 AM Changeset in webkit [261385] by Andres Gonzalez

• 3 edits in trunk/Source/WebCore

Fix for crashes in LayoutTests in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=211622

Reviewed by Chris Fleizach.

Several LayoutTests.

Return the root from the isolated tree when it is really ready.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rootObject):

Some code cleanup.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::clickPoint):

9:16 AM WebKitEmacsTips edited by Philippe Normand

(diff)

9:03 AM WebKitEmacsTips created by Philippe Normand

8:55 AM WebKitGTK edited by Philippe Normand

(diff)

8:39 AM Changeset in webkit [261384] by don.olmstead@sony.com

• 20 edits in trunk/Source/WTF

WTF headers should compile independently
​https://bugs.webkit.org/show_bug.cgi?id=211608

Reviewed by Yusuke Suzuki.

When a WTF header is included on its own within a source file it should compile.
These issues were found when working on a tooling build for running static
analysis over WTF. Forward declarations were used whenever possible otherwise
an include was used.

Additionally fix some errors found by Clang 10.

• wtf/AggregateLogger.h:
• wtf/CallbackAggregator.h:
• wtf/Dominators.h:
• wtf/HashIterators.h:
• wtf/IndexSparseSet.h:
• wtf/LoggingHashMap.h:
• wtf/LoggingHashTraits.h:
• wtf/RunLoopTimer.h:
• wtf/Stopwatch.h:
• wtf/Threading.h:
• wtf/cf/RunLoopTimerCF.cpp:
• wtf/persistence/PersistentCoder.h:
• wtf/text/LineBreakIteratorPoolICU.h:
• wtf/text/NullTextBreakIterator.h:
• wtf/text/StringOperators.h:
• wtf/text/StringToIntegerConversion.h:
• wtf/text/cf/TextBreakIteratorCF.h:
• wtf/text/icu/TextBreakIteratorICU.h:
• wtf/text/win/WCharStringExtras.h:

8:21 AM Changeset in webkit [261383] by Lauro Moura

• 6 edits
  2 adds in trunk

[GTK][WPE] Create common glib expectation file
​https://bugs.webkit.org/show_bug.cgi?id=211183

Reviewed by Carlos Garcia Campos.

Tools:

• Scripts/webkitpy/port/gtk.py:

(GtkPort._search_paths): Add glib to expectations search path
(GtkPort.test_expectations_file_position): Update test

• Scripts/webkitpy/port/gtk_unittest.py:

(GtkPortTest.test_default_baseline_search_path): Update test
(GtkPortTest.test_port_specific_expectations_files): Update test and
make check-webkit-style happier

• Scripts/webkitpy/port/wpe.py:

(WPEPort._search_paths): Add glib to expectations search path
(WPEPort.test_expectations_file_position): Update test

• Scripts/webkitpy/port/wpe_unittest.py:

(WPEPortTest.test_default_baseline_search_path): Update test
(WPEPortTest.test_port_specific_expectations_files): Update test and
make check-webkit-style happier

LayoutTests:

• platform/glib/TestExpectations: Added.

8:02 AM Changeset in webkit [261382] by Simon Fraser

• 13 edits in trunk

Overflow scrollers in iframes don't get mouseMovedInContentArea()
​https://bugs.webkit.org/show_bug.cgi?id=211347
<rdar://problem/62784560>

Reviewed by Tim Horton.

Source/WebCore:

We never dispatched mouseMovedInContentArea() on ScrollableAreas in subframes, so overlay scrollbar
interactions there were broken. This is because the code ran from EventHandler::mouseMoved(), which
only runs for the main frame.

Instead, move the mouseMovedInContentArea() dispatch down into updateMouseEventTargetNode() which
is run for each subframe. notifyScrollableAreasOfMouseEvents() takes an event name so we only dispatch
for mouseMove events. There's some complexity here related to whether the old and new ScrollableArea
targets are nested; this code doesn't try to do the right thing with nesting, but does handle the mouse
moving between the scrollable main frame and an overflow region.

enclosingScrollableArea() is fixed to return the FrameView. enclosingScrollableLayer() is flawed, as noted
in the RenderLayer.h comment.

Tests: fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered.html

fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal.html

• page/EventHandler.cpp:

(WebCore::EventHandler::enclosingScrollableArea):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::pointerCaptureElementDidChange):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::notifyScrollableAreasOfMouseEvents):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::enclosingScrollableArea): Deleted.
(WebCore::EventHandler::notifyScrollableAreasOfMouseEnterExit): Deleted.

• page/EventHandler.h:
• page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::dispatchSyntheticMouseOut):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::debugDescription const):

• rendering/RenderLayer.h:

LayoutTests:

The ordering of callbacks in the scroll-animator tests changed, but in ways that don't materially
affect behavior. Two new real overlay scrollbar tests.

• fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered-expected.txt: Added.
• fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered.html: Added.
• fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal-expected.txt: Added.
• fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal.html: Added.
• fast/scrolling/scroll-animator-basic-events-expected.txt:
• fast/scrolling/scroll-animator-overlay-scrollbars-clicked-expected.txt:
• fast/scrolling/scroll-animator-overlay-scrollbars-hovered-expected.txt:
• fast/scrolling/scroll-animator-select-list-events-expected.txt:

7:24 AM Changeset in webkit [261381] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

Flaky Test: media/track/track-in-band-metadata-display-order.html
​https://bugs.webkit.org/show_bug.cgi?id=206226

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

7:08 AM Changeset in webkit [261380] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ macOS wk2 ] http/tests/IndexedDB/collect-IDB-objects.https.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=207571

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

7:02 AM Changeset in webkit [261379] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ iOS wk2 ] http/tests/cache-storage/cache-representation.https.html is flaky timing out.
​https://bugs.webkit.org/show_bug.cgi?id=207665

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

7:02 AM Changeset in webkit [261378] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][TFC] The fixed logical width should be used as the max width for a cell
​https://bugs.webkit.org/show_bug.cgi?id=211610

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-with-fixed-widht-and-inline-content.html

• layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::intrinsicWidthConstraintsForCell):

LayoutTests:

• fast/layoutformattingcontext/table-simple-with-fixed-widht-and-inline-content-expected.txt: Added.
• fast/layoutformattingcontext/table-simple-with-fixed-widht-and-inline-content.html: Added.

6:51 AM Changeset in webkit [261377] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

REGRESSION: [ iOS wk2 ] fast/forms/input-text-scroll-left-on-blur.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209812

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

6:46 AM Changeset in webkit [261376] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ Mojave wk1 Release ] platform/mac/media/media-source/videoplaybackquality-decompressionsession.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209866

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

5:42 AM Changeset in webkit [261375] by youenn@apple.com

• 13 edits
  1 copy
  4 adds in trunk/Source

Handle remote audio capture IPC messages in a background thread
​https://bugs.webkit.org/show_bug.cgi?id=211583

Reviewed by Eric Carlson.

Source/WebCore:

• platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:

(WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples):
Add assertion to check that we are not running on the main thread.

Source/WebKit:

We introduce RemoteCaptureSampleManager which is responsible to get remote capture sample IPC messages and treat them from a background thread.
It is currently used to handle audio capture IPC messages.
We move UserMediaCaptureManager::Source in its own file and rename it to RemoteRealtimeMediaSource.

Covered by existing tests.

• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• PlatformMac.cmake:
• SourcesCocoa.txt:
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/cocoa/RemoteCaptureSampleManager.cpp: Added.

(WebKit::RemoteCaptureSampleManager::RemoteCaptureSampleManager):
(WebKit::RemoteCaptureSampleManager::~RemoteCaptureSampleManager):
(WebKit::RemoteCaptureSampleManager::setConnection):
(WebKit::RemoteCaptureSampleManager::addSource):
(WebKit::RemoteCaptureSampleManager::removeSource):
(WebKit::RemoteCaptureSampleManager::dispatchToThread):
(WebKit::RemoteCaptureSampleManager::storageChanged):
(WebKit::RemoteCaptureSampleManager::audioSamplesAvailable):

• WebProcess/cocoa/RemoteCaptureSampleManager.h: Added.
• WebProcess/cocoa/RemoteCaptureSampleManager.messages.in: Added.
• WebProcess/cocoa/RemoteRealtimeMediaSource.cpp: Added.

(WebKit::RemoteRealtimeMediaSource::RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::~RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::whenReady):
(WebKit::RemoteRealtimeMediaSource::didFail):
(WebKit::RemoteRealtimeMediaSource::setAsReady):
(WebKit::RemoteRealtimeMediaSource::clone):
(WebKit::RemoteRealtimeMediaSource::setCapabilities):
(WebKit::RemoteRealtimeMediaSource::setSettings):
(WebKit::RemoteRealtimeMediaSource::remoteAudioSamplesAvailable):
(WebKit::RemoteRealtimeMediaSource::remoteVideoSampleAvailable):
(WebKit::RemoteRealtimeMediaSource::connection):
(WebKit::RemoteRealtimeMediaSource::startProducingData):
(WebKit::RemoteRealtimeMediaSource::stopProducingData):
(WebKit::RemoteRealtimeMediaSource::setShouldApplyRotation):
(WebKit::RemoteRealtimeMediaSource::capabilities):
(WebKit::RemoteRealtimeMediaSource::applyConstraints):
(WebKit::RemoteRealtimeMediaSource::applyConstraintsSucceeded):
(WebKit::RemoteRealtimeMediaSource::applyConstraintsFailed):
(WebKit::RemoteRealtimeMediaSource::hasEnded):
(WebKit::RemoteRealtimeMediaSource::stopBeingObserved):
(WebKit::RemoteRealtimeMediaSource::requestToEnd):

• WebProcess/cocoa/RemoteRealtimeMediaSource.h: Added.

(WebKit::RemoteRealtimeMediaSource::identifier const):
(WebKit::RemoteRealtimeMediaSource::settings const):
(WebKit::RemoteRealtimeMediaSource::setShouldCaptureInGPUProcess):
(WebKit::RemoteRealtimeMediaSource::shouldCaptureInGPUProcess const):

• WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createCaptureSource):
(WebKit::UserMediaCaptureManager::cloneSource):
(WebKit::UserMediaCaptureManager::cloneVideoSource):
(WebKit::UserMediaCaptureManager::AudioFactory::createAudioCaptureSource):
(WebKit::UserMediaCaptureManager::AudioFactory::setShouldCaptureInGPUProcess):
(WebKit::UserMediaCaptureManager::VideoFactory::createVideoCaptureSource):
(WebKit::UserMediaCaptureManager::DisplayFactory::createDisplayCaptureSource):

• WebProcess/cocoa/UserMediaCaptureManager.h:
• WebProcess/cocoa/UserMediaCaptureManager.messages.in:

4:55 AM WebKitGTK/2.28.x edited by aboya@igalia.com

(diff)

4:36 AM Changeset in webkit [261374] by Paulo Matos

• 2 edits in trunk/Tools

Add myself as committer to contributors.json

Patch by Paulo Matos <Paulo Matos> on 2020-05-08

• Scripts/webkitpy/common/config/contributors.json:

3:54 AM Changeset in webkit [261373] by youenn@apple.com

• 20 edits in trunk

Video capture does not get unmuted in case of tab switch on iOS
​https://bugs.webkit.org/show_bug.cgi?id=211509

Reviewed by Eric Carlson.

Source/WebCore:

Remove setInterrupted and related code.
Instead, directly use setMuted(true/false) of the source of capture tracks.
To ensure we validate that the active source is tied to a track of the document,
we add RealtimeSource::isSameAs which handles the case of a RealtimeVideoSource wrapping an AVVideoCaptureSource.
There might be multiple video tracks with each one its RealtimeVideoSource using the same AVVideoCaptureSource.
We mute the AVVideoCaptureSource directly to make sure all linked tracks will get muted/unmuted at the same time.
Tests to be fixed.

• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::isSourceCapturingForDocument):
(WebCore::MediaStreamTrack::updateCaptureAccordingToMutedState):

• Modules/mediastream/MediaStreamTrack.h:
• dom/Document.cpp:

(WebCore::Document::visibilityStateChanged):

• platform/mediastream/RealtimeMediaSource.cpp:
• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/RealtimeMediaSourceCenter.cpp:
• platform/mediastream/RealtimeMediaSourceCenter.h:
• platform/mediastream/RealtimeMediaSourceFactory.h:
• platform/mediastream/RealtimeVideoSource.h:
• platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
• platform/mediastream/mac/CoreAudioCaptureSource.h:
• platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
• platform/mock/MockRealtimeMediaSourceCenter.cpp:

Source/WebKit:

Remove no longer needed code.

• WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::VideoFactory::setActiveSource):

• WebProcess/cocoa/UserMediaCaptureManager.h:

LayoutTests:

• platform/ios/TestExpectations:

Disable GPU process test since we are not able yet to mute/unmute handle multiple video tracks
with different sources as can be done if capture is done out of process.

• platform/ios/mediastream/video-muted-in-background-tab.html:

Update test to ensure the track is producing content.

3:23 AM Changeset in webkit [261372] by Pablo Saavedra

• 2 edits in trunk/JSTests

Unreviewed, reverting r261010.

Test skipped for all ARM. no evidence of this affecting iOS

Reverted changeset:

"Skip on ARM and MIPS stress/array-buffer-view-watchpoint-can-
be-fired-in-really-add-in-dfg.js added after r260990"
​https://bugs.webkit.org/show_bug.cgi?id=211304
​https://trac.webkit.org/changeset/261010

1:52 AM WebKitGTK/2.28.x edited by Philippe Normand

(diff)

1:49 AM WebKitGTK/2.28.x edited by Philippe Normand

(diff)

1:47 AM Changeset in webkit [261371] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

Unreviewed. Fix GTK4 build after r261370

• UIProcess/API/gtk/WebKitScriptDialogGtk.cpp:

(webkitScriptDialogIsUserHandled):

1:21 AM Changeset in webkit [261370] by Lauro Moura

• 6 edits in trunk/Source/WebKit

[WPE][WebDriver] Implement user prompt support
​https://bugs.webkit.org/show_bug.cgi?id=207372

Reviewed by Carlos Garcia Campos.

Provide a default implementation for WebDriver dialog commands.
This implementation will mimic the expected browser behavior of
accepting/dismissing the dialogs, while not exposing any new API.

• UIProcess/API/glib/WebKitScriptDialogPrivate.h:
• Expose new private function to check whether the dialog is using a

default implementation or is handled by the user.

• UIProcess/API/glib/WebKitWebView.cpp:
• Avoid default WebDriver behavior if the dialog is user-handled.

(webkitWebViewSetCurrentScriptDialogUserInput):
(webkitWebViewAcceptCurrentScriptDialog):
(webkitWebViewDismissCurrentScriptDialog):

• UIProcess/API/gtk/WebKitScriptDialogGtk.cpp:

(webkitScriptDialogIsUserHandled):

• Return whether the dialog is user handled.
• UIProcess/API/wpe/WebKitScriptDialogWPE.cpp:
• Added basic behavior for the WebDriver dialog callbacks for WPE.

(webkitScriptDialogAccept):
(webkitScriptDialogDismiss):
(webkitScriptDialogSetUserInput):
(webkitScriptDialogIsUserHandled):

• UIProcess/API/wpe/WebKitWebViewWPE.cpp:

(webkitWebViewScriptDialog):

• Hold a dialog ref if the webview is controlled by automation and ends

up calling the default "script-dialog" event handler.

1:06 AM Changeset in webkit [261369] by Diego Pino Garcia

• 3 edits
  1 add in trunk/LayoutTests

[GTK][WPE] Gardening, update expectations and baselines after r261341
​https://bugs.webkit.org/show_bug.cgi?id=211616

Unreviewed gardening.

• platform/gtk/TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/intrinsic_sizes-expected.txt: Added.
• platform/wpe/TestExpectations:

May 7, 2020:

10:48 PM Changeset in webkit [261368] by Simon Fraser

• 5 edits
  4 adds in trunk

MayBegin wheel event in a <select> doesn't flash the scrollers
​https://bugs.webkit.org/show_bug.cgi?id=211605

Reviewed by Antti Koivisto.

Source/WebCore:

We need to special-case scrollable <select> elements, because they are ScrollableAreas
which are never asynchronously scrolled, so the ScrollingTree never dispatches the handleWheelEventPhase()
which is necessary to flash overlay scrollbars. Scrollable <select> elements are always in the
non-fast scrollable region.

Fix findEnclosingScrollableContainer() to return a ScrollableArea for the "maybegin" and "canceled" events
that have no delta.

Remove some "inline" and make some things references.

Tests: fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered.html

fast/scrolling/mac/scrollbars/select-overlay-scrollbar-reveal.html

• page/EventHandler.cpp:

(WebCore::handleWheelEventPhaseInScrollableArea):
(WebCore::didScrollInScrollableArea):
(WebCore::handleWheelEventInAppropriateEnclosingBox):
(WebCore::shouldGesturesTriggerActive):
(WebCore::EventHandler::eventLoopHandleMouseUp):
(WebCore::EventHandler::eventLoopHandleMouseDragged):

• page/mac/EventHandlerMac.mm:

(WebCore::findEnclosingScrollableContainer):
(WebCore::EventHandler::determineWheelEventTarget):

• testing/Internals.cpp:

(WebCore::Internals::scrollableAreaForNode): Fix to find the ScrollableArea for RenderListBoxes.

LayoutTests:

• fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered-expected.txt: Added.
• fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered.html: Added.
• fast/scrolling/mac/scrollbars/select-overlay-scrollbar-reveal-expected.txt: Added.
• fast/scrolling/mac/scrollbars/select-overlay-scrollbar-reveal.html: Added.

9:23 PM Changeset in webkit [261367] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GTK] Gardening two poster tests and a webgl failure

Unreviewed test gardening.

• platform/gtk/TestExpectations:

7:33 PM Changeset in webkit [261366] by jiewen_tan@apple.com

• 7 edits
  1 add in trunk

[WebAuthn] Roll back newly created credentials if an error occurs
​https://bugs.webkit.org/show_bug.cgi?id=183530
<rdar://problem/43357305>

Reviewed by Brent Fulgham.

Source/WebKit:

We should clean up any newly created credentials if an error occurs before the relying party
registers the identity. Otherwise we are left with a dangling credential.

Covered by API tests.

• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.h:
• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
(WebKit::LocalAuthenticator::receiveException const):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-no-attestation.html: Added.
• TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html:

7:22 PM Changeset in webkit [261365] by sbarati@apple.com

• 2 edits in trunk/Tools

run-javascriptcore-tests with remote should be verbose
​https://bugs.webkit.org/show_bug.cgi?id=211596

Reviewed by Alexey Proskuryakov.

Our iOS testing bots could use this better output.

• Scripts/run-javascriptcore-tests:

(runJSCStressTests):

7:14 PM Changeset in webkit [261364] by Chris Dumez

• 11 edits in trunk/Source

Unreviewed, reverting r261252.

Reland r260684 now that a proper fix has landed in Reader

Reverted changeset:

"REGRESSION (r260684): Reader background is lost after
multitasking"
​https://bugs.webkit.org/show_bug.cgi?id=211533
​https://trac.webkit.org/changeset/261252

6:54 PM Changeset in webkit [261363] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN
​https://bugs.webkit.org/show_bug.cgi?id=211539

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-05-07
Reviewed by Geoffrey Garen.

Source/WebCore:

Removed the RELEASE_ASSERT because its possible for imageData to be null when imageRect size is huge value.

Test: fast/shapes/shape-outside-floats/shape-outside-imagedata-overflow.html

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

LayoutTests:

Added a regression test and enabled it only for WK1.

• TestExpectations:
• fast/shapes/shape-outside-floats/shape-outside-imagedata-overflow-expected.txt: Added.
• fast/shapes/shape-outside-floats/shape-outside-imagedata-overflow.html: Added.
• platform/ios-wk1/TestExpectations:
• platform/mac-wk1/TestExpectations:

6:04 PM Changeset in webkit [261362] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: visible outline after clicking the close X button
​https://bugs.webkit.org/show_bug.cgi?id=211604
<rdar://problem/62998871>

Reviewed by Timothy Hatcher.

Never display focus outline for TreeOutline items.

• UserInterface/Views/TreeOutline.css:

(.tree-outline .item):
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.selected):

5:39 PM Changeset in webkit [261361] by Megan Gardner

• 2 edits in trunk/Source/WebKit

Build Fix for MacCatalyst
​https://bugs.webkit.org/show_bug.cgi?id=211601

Reviewed by Tim Horton.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _removeContextMenuViewIfPossible]):

4:54 PM Changeset in webkit [261360] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Crash under WebKit::XPCServiceMain
​https://bugs.webkit.org/show_bug.cgi?id=211600
<rdar://problem/62875458>

Reviewed by Darin Adler.

Made the following changes:

• Crash under strcmp() could in theory happen if expectedBundleVersion.UTF8String was null, which could happen if expectedBundleVersion was null. I now use higher level String types for the versions, make sure they are not null and use String comparison to compare them.
• Call CRASH() instead of builtin_trap(), to guarantee that we crash with a SIGTRAP (see comment next to CRASH() macro).
• Move CRASH() call to a crashDueWebKitFrameworkVersionMismatch() never inlined function to make it clear when it crashes due to a framework version mismatch and distinguish from proper crashes.

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::crashDueWebKitFrameworkVersionMismatch):
(WebKit::XPCServiceMain):

4:52 PM Changeset in webkit [261359] by Alan Coon

• 12 edits
  8 deletes in branches/safari-610.1.12-branch

Revert r261056. rdar://problem/62937746

4:52 PM Changeset in webkit [261358] by Alan Coon

• 539 edits
  19 adds
  160 deletes in branches/safari-610.1.12-branch/Source/ThirdParty/ANGLE

Cherry-pick r261262. rdar://problem/62998321

Update ANGLE to 2020-03-27
​https://bugs.webkit.org/show_bug.cgi?id=209689

Reverting r259589. It caused
​https://bugs.webkit.org/show_bug.cgi?id=210992

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261357] by Alan Coon

• 2 edits in branches/safari-610.1.12-branch/Source/WebKit

Revert r260390. rdar://problem/62998314

4:50 PM Changeset in webkit [261356] by Alan Coon

• 2 edits in branches/safari-610.1.12-branch/Source/WebInspectorUI

Cherry-pick r261183. rdar://problem/62995520

Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'this.InspectorAgent.initialized')
​https://bugs.webkit.org/show_bug.cgi?id=211434

Reviewed by Joseph Pecoraro.

• UserInterface/Protocol/Target.js: (WI.Target.prototype.initialize): Worker targets don't (and are not expected to) have an Inspector domain.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261355] by Alan Coon

• 22 edits
  2 deletes in branches/safari-610.1.12-branch/Source/WebInspectorUI

Cherry-pick r261108. rdar://problem/62995520

Web Inspector: drop support for iOS 8.*
​https://bugs.webkit.org/show_bug.cgi?id=211312

Reviewed by Daniel Bates.

• UserInterface/Controllers/DOMManager.js: (WI.DOMManager.prototype.highlightSelector):
• UserInterface/Controllers/NetworkManager.js: (WI.NetworkManager.prototype.resourceRequestWillBeSent):
• UserInterface/Controllers/RuntimeManager.js: (WI.RuntimeManager.prototype.initializeTarget): (WI.RuntimeManager.prototype.evaluateInInspectedWindow):
• UserInterface/Controllers/TimelineManager.js: (WI.TimelineManager.defaultTimelineTypes): (WI.TimelineManager.prototype._loadNewRecording):
• UserInterface/Models/DOMNodeStyles.js: (WI.DOMNodeStyles.parseSelectorListPayload):
• UserInterface/Models/FPSInstrument.js: (WI.FPSInstrument): Deleted. (WI.FPSInstrument.supported): Deleted.
• UserInterface/Models/ObjectPreview.js: (WI.ObjectPreview.fromPayload):
• UserInterface/Models/ProfileNode.js: (WI.ProfileNode): (WI.ProfileNode.prototype.get startTime): (WI.ProfileNode.prototype.get endTime): (WI.ProfileNode.prototype.computeCallInfoForTimeRange): (WI.ProfileNode.prototype.get calls): Deleted. (WI.ProfileNode.prototype.computeCallInfoForTimeRange.totalTimeInRange): Deleted.
• UserInterface/Models/Resource.js: (WI.Resource.prototype.get initiatedResources): (WI.Resource.prototype.get originalRequestWillBeSentTimestamp): Deleted.
• UserInterface/Models/ResourceTimingData.js: (WI.ResourceTimingData.fromPayload):
• UserInterface/Models/ScriptTimelineRecord.js: (WI.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeFromPayload):
• UserInterface/Models/TimelineRecording.js: (WI.TimelineRecording): (WI.TimelineRecording.prototype.computeElapsedTime): (WI.TimelineRecording.prototype.setLegacyBaseTimestamp): Deleted.
• UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js: Removed.
• UserInterface/Protocol/RemoteObject.js: (WI.RemoteObject.fromPayload): (WI.RemoteObject.prototype.getDisplayablePropertyDescriptors):
• UserInterface/Protocol/Target.js: (WI.Target.prototype.initialize):
• UserInterface/Views/ObjectTreePropertyTreeElement.js: (WI.ObjectTreePropertyTreeElement.prototype._updateProperties): (WI.ObjectTreePropertyTreeElement):
• UserInterface/Views/ObjectTreeView.js: (WI.ObjectTreeView.prototype._updateProperties):
• UserInterface/Views/ScriptTimelineDataGridNode.js: (WI.ScriptTimelineDataGridNode.prototype.get data):
• UserInterface/Views/SourceCodeTextEditor.js: (WI.SourceCodeTextEditor.prototype._createTypeTokenAnnotator): (WI.SourceCodeTextEditor.prototype._createBasicBlockAnnotator):
• UserInterface/Views/SourcesNavigationSidebarPanel.js: (WI.SourcesNavigationSidebarPanel.prototype._updatePauseReasonSection):
• UserInterface/Views/TimelineOverview.js: (WI.TimelineOverview):
• UserInterface/Views/TimelineTabContentView.js: (WI.TimelineTabContentView): (WI.TimelineTabContentView.prototype.closed): (WI.TimelineTabContentView.prototype.restoreFromCookie):
• Versions/Inspector-iOS-8.0.json: Removed.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261354] by Alan Coon

• 13 edits
  1 add in branches/safari-610.1.12-branch

Cherry-pick r261296. rdar://problem/62995467

Unreviewed, reverting r260769.
​https://bugs.webkit.org/show_bug.cgi?id=211578

Introduced regressions related to sharing (Requested by
perarne on #webkit).

Reverted changeset:

"[Cocoa] After r258891, r255119 can be reverted"
​https://bugs.webkit.org/show_bug.cgi?id=211083
​https://trac.webkit.org/changeset/260769

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261353] by Alan Coon

• 2 edits in branches/safari-610.1.12-branch/Source/WebKit

Cherry-pick r261263. rdar://problem/62995496

Unreviewed, reverting r260689.
​https://bugs.webkit.org/show_bug.cgi?id=211542

"Caused regressions deleting text and filling password fields"
(Requested by ddkilzer on #webkit).

Reverted changeset:

"WebPasteboardProxy::getPasteboardStringsForType() and
WebPasteboardProxy::readURLFromPasteboard() should check
return value of SharedMemory::createHandle()"
​https://bugs.webkit.org/show_bug.cgi?id=211002
​https://trac.webkit.org/changeset/260689

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261352] by Alan Coon

• 11 edits in branches/safari-610.1.12-branch/Source

Cherry-pick r261252. rdar://problem/62995461

REGRESSION (r260684): Reader background is lost after multitasking
​https://bugs.webkit.org/show_bug.cgi?id=211533
<rdar://problem/62941837>

Unreviewed, revert r260684 due to regression.

Source/WebCore:

• dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners):
• page/FrameView.cpp: (WebCore::FrameView::sendResizeEventIfNeeded):
• page/Page.h: (WebCore::Page::shouldFireResizeEvents const): (WebCore::Page::setShouldFireResizeEvents):

Source/WebKit:

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setShouldFireResizeEvents):
• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKApplicationStateTrackingView.mm: (-[WKApplicationStateTrackingView _willBeginSnapshotSequence]): (-[WKApplicationStateTrackingView _didCompleteSnapshotSequence]):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setShouldFireResizeEvents):
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261351] by Alan Coon

• 2 edits in branches/safari-610.1.12-branch/Source/WebCore

Cherry-pick r261245. rdar://problem/62995531

REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange
​https://bugs.webkit.org/show_bug.cgi?id=211523
<rdar://problem/62860203>

Reviewed by Darin Adler.

• page/TextIndicator.cpp: (WebCore::estimatedTextColorsForRange): TextIterator's node() getter can return null. r260753 accidentally refactored away the null check.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261350] by Alan Coon

• 13 edits
  4 adds in branches/safari-610.1.12-branch

Cherry-pick r261147. rdar://problem/62995512

[JSC] DFG NotCellUse is used without considering about BigInt32
​https://bugs.webkit.org/show_bug.cgi?id=211395

Reviewed by Saam Barati.

JSTests:

• stress/non-cell-nor-bigint-should-be-emitted-for-to-number-target-if-bigint-appears.js: Added. (shouldThrow): (test): (i.shouldThrow):
• stress/non-cell-nor-bigint-should-reject-bigint.js: Added. (shouldBe): (test):
• stress/should-not-emit-double-rep-for-bigint.js: Added. (foo):
• stress/urshift-value-to-int32-should-reject-bigint.js: Added. (shouldThrow): (test): (i.shouldThrow):

Source/JavaScriptCore:

When we see CompareXXX(BigInt32, Double), we are emitting CompareXXX(DoubleRep(BigInt:NotCellUse), Double). But this has two problems.

1. We should emit CompareXXX(UntypedUse, UntypedUse) in this case.
2. DoubleRep(NotCellUse) does not support converting BigInt32 to double. Since DoubleRep's semantics is for ToNumber, it should not accept BigInt32 since it should throw an error. However, DoubleRep currently assumes that NotCellUse value can be converted to double without any errors.

To keep DoubleRep's semantics ToNumber, we replace NotCellUse with NotCellNorBigIntUse, which rejects BigInt32. This patch also uses NotCellNorBigIntUse
for ValueToInt32 because of the same reason.

For CompareXXX and CompareEq nodes, we can optimize it if we introduce new DoubleRepAcceptingBigInt32 DFG node which can convert BigInt32 to Double, since
CompareXXX and CompareEq are not requiring toNumber semantics. This should be done in a separate bug ​https://bugs.webkit.org/show_bug.cgi?id=211407.

• bytecode/SpeculatedType.h: (JSC::isNotCellNorBigIntSpeculation):
• dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
• dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::fixIntConvertingEdge): (JSC::DFG::FixupPhase::fixupChecksInBlock):
• dfg/DFGNode.h: (JSC::DFG::Node::shouldSpeculateNotCellNorBigInt):
• dfg/DFGSafeToExecute.h: (JSC::DFG::SafeToExecuteEdge::operator()):
• dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileValueToInt32): (JSC::DFG::SpeculativeJIT::compileDoubleRep): (JSC::DFG::SpeculativeJIT::speculateNotCellNorBigInt): (JSC::DFG::SpeculativeJIT::speculate):
• dfg/DFGSpeculativeJIT.h:
• dfg/DFGUseKind.cpp: (WTF::printInternal):
• dfg/DFGUseKind.h: (JSC::DFG::typeFilterFor): (JSC::DFG::checkMayCrashIfInputIsEmpty):
• ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile):
• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileDoubleRep): (JSC::FTL::DFG::LowerDFGToB3::compileValueToInt32): (JSC::FTL::DFG::LowerDFGToB3::numberOrNotCellNorBigIntToInt32): (JSC::FTL::DFG::LowerDFGToB3::speculate): (JSC::FTL::DFG::LowerDFGToB3::speculateNotCellNorBigInt): (JSC::FTL::DFG::LowerDFGToB3::numberOrNotCellToInt32): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261349] by Alan Coon

• 2 edits in branches/safari-610.1.12-branch/Source/WebKit

Cherry-pick r261146. rdar://problem/62995486

REGRESSION (r260791?): Assert not reached in ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() and ResourceLoadStatisticsDatabaseStore::addMissingTablesIfNecessary()
​https://bugs.webkit.org/show_bug.cgi?id=211305
<rdar://problem/62737871>

Reviewed by Alex Christensen.

This patch adds a busy timeout for the ITP database to allow for
some concurrency flexibility when running many WebKitTestRunner tests, which
recreate the ITP database store very often to test both the memory and
database stores.

With the timeout, an attempt to write to the database when another
thread is holding the lock will keep attempting to insert for 5
seconds as long as the statement execution returns SQLITE_BUSY.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: (WebKit::ResourceLoadStatisticsDatabaseStore::openITPDatabase):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261348] by Alan Coon

• 2 edits in branches/safari-610.1.12-branch/LayoutTests

Cherry-pick r261122. rdar://problem/62995479

REGRESSION (r261109): [ Mac ] inspector/css/getAllStyleSheets.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=211405
<rdar://problem/62863843>

Unreviewed, remove unnecessary call to function that no longer exists.

• inspector/css/getAllStyleSheets.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261347] by Alan Coon

• 2 edits in branches/safari-610.1.12-branch/LayoutTests

Cherry-pick r261121. rdar://problem/62995508

REGRESSION (r261108): [ Mac ] inspector/timeline/timeline-recording.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=211404
<rdar://problem/62863766>

Unreviewed, update test expectation.

• inspector/timeline/timeline-recording-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261346] by Alan Coon

• 2 edits in branches/safari-610.1.12-branch/Source/WebKit

Cherry-pick r261187. rdar://problem/62993016

Check for app-bound domains should confirm WKAppBoundDomains key exists when checking for default app-bound protocols.
​https://bugs.webkit.org/show_bug.cgi?id=211451
<rdar://problem/62715316

Reviewed by Brent Fulgham.

Checks for WKAppBoundDomains key before treating a protocol as
app-bound. This is a regression in expected behavior after making
In-App Browser privacy opt-in based on the presence of the key.

Also moves the check for special protocols inside of the completion handler for
ensureAppBoundDomains to make sure the check for the key has finished.

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::beginAppBoundDomainCheck): Added a comment to clarify why we need to check for both an empty app-bound domains list and the presence of the key for testing purposes.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:50 PM Changeset in webkit [261345] by Alan Coon

• 3 edits in branches/safari-610.1.12-branch/Source/WebKit

Cherry-pick r261140. rdar://problem/62993055

[iOS] Make sure TestController::statisticsResetToConsistentState() does not hang due to process suspension
​https://bugs.webkit.org/show_bug.cgi?id=211421

Reviewed by Maciej Stachowiak.

We have evidence of hangs in TestController::statisticsResetToConsistentState() on iOS and we suspect it
is due to process suspension. To address the issue, this patch updates the IPCs being sent as a result of
a call to statisticsResetToConsistentState() to take a background assertion while waiting for the IPC
response.

• UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::setUseITPDatabase): (WebKit::NetworkProcessProxy::resetCacheMaxAgeCapForPrevalentResources): (WebKit::NetworkProcessProxy::resetParametersToDefaultValues): (WebKit::NetworkProcessProxy::scheduleClearInMemoryAndPersistent): (WebKit::NetworkProcessProxy::resetCrossSiteLoadsWithLinkDecorationForTesting): (WebKit::NetworkProcessProxy::setShouldDowngradeReferrerForTesting): (WebKit::NetworkProcessProxy::setShouldBlockThirdPartyCookiesForTesting): (WebKit::NetworkProcessProxy::setShouldEnbleSameSiteStrictEnforcementForTesting): (WebKit::NetworkProcessProxy::setFirstPartyWebsiteDataRemovalModeForTesting):
• UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::setShouldBlockThirdPartyCookiesForTesting):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:22 PM Changeset in webkit [261344] by Devin Rousso

• 5 edits in trunk

Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'mimeType.endsWith')
​https://bugs.webkit.org/show_bug.cgi?id=211593

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

• UserInterface/Views/ResourceClusterContentView.js:

(WI.ResourceClusterContentView.prototype._normalizeMIMETypeForDOM):

LayoutTests:

• inspector/unit-tests/mimetype-utilities.html:
• inspector/unit-tests/mimetype-utilities-expected.txt:

Add some tests for parseMIMEType.

4:17 PM Changeset in webkit [261343] by youenn@apple.com

• 8 edits in trunk/Source

Remove AudioMediaStreamTrackRenderer::muted
​https://bugs.webkit.org/show_bug.cgi?id=211289

Reviewed by Eric Carlson.

Source/WebCore:

• platform/mediastream/AudioMediaStreamTrackRenderer.h:

muted is unnecessary since we are using start/stop instead.

Source/WebKit:

muted is unnecessary since we are using start/stop instead.

• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
• WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:
• WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h:

4:08 PM Changeset in webkit [261342] by eric.carlson@apple.com

• 3 edits in trunk/Source/WebCore

[macOS] Playhead in Touch Bar continues when loading stalls
​https://bugs.webkit.org/show_bug.cgi?id=211585
<rdar://problem/33893306>

Reviewed by Darin Adler.

• platform/cocoa/PlaybackSessionModelMediaElement.h:
• platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::updateForEventName): Listen for waitingEvent
and canplay events. Don't claim to be playing when stalled.
(WebCore::PlaybackSessionModelMediaElement::isStalled const): New.

4:05 PM Changeset in webkit [261341] by eric.carlson@apple.com

• 12 edits
  2 adds in trunk

Poster set after playback begins should be ignored
​https://bugs.webkit.org/show_bug.cgi?id=211464

Reviewed by Jer Noble.
Source/WebCore:

Redo the poster frame logic to use the show poster flag logic from the spec.

Test: media/video-poster-set-after-playback.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_showPoster.
(WebCore::HTMLMediaElement::prepareForLoad): m_displayMode was removed.
(WebCore::HTMLMediaElement::selectMediaResource): Call setShowPosterFlag.
(WebCore::HTMLMediaElement::loadResource): Remove calls to setDisplayMode and updateDisplayState,
they have been deleted.
(WebCore::HTMLMediaElement::waitForSourceChange): Call setShowPosterFlag. Update spec text.
(WebCore::HTMLMediaElement::noneSupported): Call setShowPosterFlag.
(WebCore::HTMLMediaElement::mediaLoadingFailed): Remove call to updateDisplayState.
(WebCore::HTMLMediaElement::setReadyState): Ditto.
(WebCore::HTMLMediaElement::seekWithTolerance): Call setShowPosterFlag.
(WebCore::HTMLMediaElement::seekTask): Check m_showPoster, not displayMode.
(WebCore::HTMLMediaElement::playInternal): Call setShowPosterFlag.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Don't check displayMode.
(WebCore::HTMLMediaElement::updatePlayState): No more setDisplayMode.
(WebCore::HTMLMediaElement::userCancelledLoad): Call setShowPosterFlag.
(WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): Deleted.

• html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::showPosterFlag const):
(WebCore::HTMLMediaElement::setShowPosterFlag):
(WebCore::HTMLMediaElement::displayMode const): Deleted.
(WebCore::HTMLMediaElement::setDisplayMode): Deleted.
(WebCore::HTMLMediaElement::updateDisplayState): Deleted.

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::didAttachRenderers): No more updateDisplayState.
(WebCore::HTMLVideoElement::parseAttribute): Ditto. Call updateFromElement when poster is removed.
(WebCore::HTMLVideoElement::shouldDisplayPosterImage const): New.
(WebCore::HTMLVideoElement::mediaPlayerFirstVideoFrameAvailable): New, update player and
renderer if the poster isn't supposed to be visible.
(WebCore::HTMLVideoElement::setDisplayMode): Deleted.
(WebCore::HTMLVideoElement::updateDisplayState): Deleted.

• html/HTMLVideoElement.h:

• rendering/RenderVideo.cpp:

(WebCore::RenderVideo::failedToLoadPosterImage const): New.

• rendering/RenderVideo.h:

• testing/Internals.cpp:

(WebCore::Internals::elementShouldDisplayPosterImage const):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• media/video-poster-set-after-playback-expected.txt: Added.
• media/video-poster-set-after-playback.html: Added.

4:01 PM Changeset in webkit [261340] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Sources: Breakpoints status not remembered/restored correctly
​https://bugs.webkit.org/show_bug.cgi?id=211558

Reviewed by Joseph Pecoraro.

• UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager.prototype.initializeTarget):

3:59 PM Changeset in webkit [261339] by Devin Rousso

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Storage: double clicking on a cookie field doesn't start editing it
​https://bugs.webkit.org/show_bug.cgi?id=211598

Reviewed by Timothy Hatcher.

• UserInterface/Views/CookieStorageContentView.js:

(WI.CookieStorageContentView):
(WI.CookieStorageContentView.prototype.tableCellContextMenuClicked):
(WI.CookieStorageContentView.prototype.tablePopulateCell):
(WI.CookieStorageContentView.prototype._showCookiePopover):
(WI.CookieStorageContentView.prototype._handleSetCookieButtonClick):
Add a "dblclick" event listener to each cell that shows a WI.CookiePopover for that cell
and automatically select the current value of that field in the WI.Cookie. Unify the few
different ways to show a WI.CookiePopover.

• UserInterface/Views/CookiePopover.js:

(WI.CookiePopover.prototype.show.createRow):
Provide a way to programmatically trigger the focusing of an editor once shown.

• Localizations/en.lproj/localizedStrings.js:

3:58 PM Changeset in webkit [261338] by Jack Lee

• 2 edits in trunk/Source/WebCore

In Document::willBeRemovedFromFrame, clear FrameSelection before Editor so the selection is removed.
​https://bugs.webkit.org/show_bug.cgi?id=211551

Reviewed by Geoffrey Garen.

Covered by existing tests.

• dom/Document.cpp:

(WebCore::Document::willBeRemovedFromFrame):

2:48 PM Changeset in webkit [261337] by Alan Coon

• 8 edits in trunk/Source

Versioning.

2:44 PM Changeset in webkit [261336] by graouts@webkit.org

• 10 edits in trunk/Source/WebCore

[Web Animations] imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=211232
<rdar://problem/62650227>

Reviewed by Dean Jackson.

The flakiness came from this porting of the test:

animA.finished.then(() => { animB.cancel() });
animB.finished.then(() => { animA.cancel() });

Sometimes, animA and animB would finish in different frames even though they were designed to finish at the
same time. If this happened, animA.finished would resolve and trigger animB.cancel, which then rejected
animB.finished. This happened because animB was attached to a DocumentTimeline created by script which isn't
the main DocumenTimeline accessed via document.timeline. Some curious code would handle syncing of the
various timelines such that they would use a shared timebase. This was in DocumentTimeline::currentTime():

auto& mainDocumentTimeline = m_document->timeline();
if (&mainDocumentTimeline != this) {

if (auto mainDocumentTimelineCurrentTime = mainDocumentTimeline.currentTime())

return *mainDocumentTimelineCurrentTime - m_originTime;

return WTF::nullopt;

}

We now move the currentTime caching at the DocumentTimelinesController level which ensures all DocumentTimeline
objects attached to a given Document use the exact same currentTime(). This prompted some overdue refactoring
where also all the related animation suspension code is moved from DocumentTimeline up to DocumentTimelinesController.

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::detachFromDocument):
(WebCore::DocumentTimeline::suspendAnimations):
(WebCore::DocumentTimeline::resumeAnimations):
(WebCore::DocumentTimeline::animationsAreSuspended const):
(WebCore::DocumentTimeline::currentTime):
(WebCore::DocumentTimeline::scheduleAnimationResolution):
(WebCore::DocumentTimeline::documentWillUpdateAnimationsAndSendEvents):
(WebCore::DocumentTimeline::animationsAreSuspended): Deleted.
(WebCore::DocumentTimeline::liveCurrentTime const): Deleted.
(WebCore::DocumentTimeline::cacheCurrentTime): Deleted.
(WebCore::DocumentTimeline::maybeClearCachedCurrentTime): Deleted.

• animation/DocumentTimeline.h:
• animation/DocumentTimelinesController.cpp:

(WebCore::DocumentTimelinesController::detachFromDocument):
(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):
(WebCore::DocumentTimelinesController::suspendAnimations):
(WebCore::DocumentTimelinesController::resumeAnimations):
(WebCore::DocumentTimelinesController::animationsAreSuspended const):
(WebCore::DocumentTimelinesController::liveCurrentTime const):
(WebCore::DocumentTimelinesController::currentTime):
(WebCore::DocumentTimelinesController::cacheCurrentTime):
(WebCore::DocumentTimelinesController::maybeClearCachedCurrentTime):

• animation/DocumentTimelinesController.h:
• dom/Document.cpp:

(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::resume):

• dom/Document.h:
• page/Frame.cpp:

(WebCore::Frame::clearTimers):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):

• page/Page.cpp:

(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):

• testing/Internals.cpp:

(WebCore::Internals::animationsAreSuspended const):
(WebCore::Internals::suspendAnimations const):
(WebCore::Internals::resumeAnimations const):

2:39 PM Changeset in webkit [261335] by Alan Coon

• 1 copy in branches/safari-610.1.12-branch

New branch.

2:02 PM Changeset in webkit [261334] by Simon Fraser

• 8 edits
  6 adds in trunk

REGRESSION (r252161): Animation of box-shadow with border-radius set is flashy
​https://bugs.webkit.org/show_bug.cgi?id=211530
<rdar://problem/62570229>

Reviewed by Zalan Bujtas.

Source/WebCore:

Drawing inset box shadows with spread was broken, and in some cases generated invalid
rounded rects, causing inset shadows with border-radius to lose the radius.

First, with split inlines, the spread was not getting removed from the excluded edges.
Fix in the includeLogicalLeftEdge/includeLogicalRightEdge clauses, adding shiftXEdgeBy()/shiftYEdgeBy() helpers
to LayoutRect to simplify logic.

Second, when computing the rounded hole rect, we'd use the result of style.getRoundedInnerBorderFor()
but that doesn't take shadow spread into account, so we'd build a rounded rect with a rect that
accounted for spread, but radii computed without. That could result in unrenderable rounded rects.
Fix by calling style.getRoundedInnerBorderFor() a second time if we have spread; this will fix
up the radii for spread.

Tests: fast/box-shadow/inset-box-shadow-fractional-radius.html

fast/box-shadow/inset-shadow-split-inline.html
fast/box-shadow/inset-spread-box-shadow-split-inline.html

• platform/graphics/LayoutRect.h:

(WebCore::LayoutRect::shiftXEdgeBy):
(WebCore::LayoutRect::shiftYEdgeBy):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):

LayoutTests:

Some ref tests for inset shadows with border radius, with spread, and when on
split inlines.

• fast/box-shadow/inset-box-shadow-expected.html:
• fast/box-shadow/inset-box-shadow-fractional-radius-expected.html: Added.
• fast/box-shadow/inset-box-shadow-fractional-radius.html: Added.
• fast/box-shadow/inset-box-shadow.html:
• fast/box-shadow/inset-shadow-split-inline-expected.html: Added.
• fast/box-shadow/inset-shadow-split-inline.html: Added.
• fast/box-shadow/inset-spread-box-shadow-split-inline-expected.html: Added.
• fast/box-shadow/inset-spread-box-shadow-split-inline.html: Added.

1:57 PM Changeset in webkit [261333] by don.olmstead@sony.com

• 39 edits in trunk/Source

Remove unused USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
​https://bugs.webkit.org/show_bug.cgi?id=211582

Reviewed by Fujii Hironori.

After r261264 all ports implemented USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR.

Source/WebCore:

• page/ChromeClient.h:

(WebCore::ChromeClient::createDisplayRefreshMonitor const):

• page/Page.cpp:

(WebCore::Page::windowScreenDidChange):

• page/RenderingUpdateScheduler.cpp:

(WebCore::RenderingUpdateScheduler::RenderingUpdateScheduler):
(WebCore::RenderingUpdateScheduler::adjustRenderingUpdateFrequency):
(WebCore::RenderingUpdateScheduler::scheduleTimedRenderingUpdate):
(WebCore::RenderingUpdateScheduler::windowScreenDidChange):

• page/RenderingUpdateScheduler.h:
• platform/graphics/DisplayRefreshMonitor.cpp:
• platform/graphics/DisplayRefreshMonitor.h:
• platform/graphics/DisplayRefreshMonitorClient.cpp:
• platform/graphics/DisplayRefreshMonitorClient.h:
• platform/graphics/DisplayRefreshMonitorManager.cpp:
• platform/graphics/DisplayRefreshMonitorManager.h:
• platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::GraphicsLayerUpdater):
(WebCore::GraphicsLayerUpdater::scheduleUpdate):
(WebCore::GraphicsLayerUpdater::screenDidChange):
(WebCore::GraphicsLayerUpdater::displayRefreshFired):
(WebCore::GraphicsLayerUpdater::createDisplayRefreshMonitor const):

• platform/graphics/GraphicsLayerUpdater.h:
• platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp:
• platform/graphics/gtk/DisplayRefreshMonitorGtk.h:
• platform/graphics/ios/DisplayRefreshMonitorIOS.h:
• platform/graphics/ios/DisplayRefreshMonitorIOS.mm:
• platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
• platform/graphics/mac/DisplayRefreshMonitorMac.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::createDisplayRefreshMonitor const):

• rendering/RenderLayerCompositor.h:

Source/WebKit:

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::ThreadedCompositor):
(WebKit::m_displayRefreshMonitor):
(WebKit::ThreadedCompositor::invalidate):
(WebKit::ThreadedCompositor::sceneUpdateFinished):
(WebKit::ThreadedCompositor::displayRefreshMonitor):

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createDisplayRefreshMonitor const):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::createDisplayRefreshMonitor):

• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:
• WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::createDisplayRefreshMonitor):

• WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:

(WebKit::LayerTreeHost::deviceOrPageScaleFactorChanged):

• WebProcess/WebPage/DrawingArea.cpp:
• WebProcess/WebPage/DrawingArea.h:
• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h:
• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm:
• WebProcess/WebPage/mac/DrawingAreaMac.cpp:

Source/WTF:

• wtf/PlatformUse.h:

1:15 PM Changeset in webkit [261332] by Jonathan Bedard

• 2 edits in trunk/Tools

webkitpy: Use apple_additions certificate path if available
​https://bugs.webkit.org/show_bug.cgi?id=211584

Rubber-stamped by Aakash Jain

• Scripts/webkitpy/results/upload.py:

(Upload):
(Upload.certificate_chain): Certificate chain to be used, prefer apple_additions
over certifi.
(Upload.upload): Use Upload.certificate_chain().
(Upload.upload_archive): Ditto.

1:15 PM Changeset in webkit [261331] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Simplify preprocessor guards in GCMemoryOperations.h
​https://bugs.webkit.org/show_bug.cgi?id=211588

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-05-07
Reviewed by Darin Adler.

If we adjust the guards a bit, then we don't need to repeat the fallback path.

• heap/GCMemoryOperations.h:

(JSC::gcSafeMemmove):
(JSC::gcSafeZeroMemory):

1:07 PM Changeset in webkit [261330] by Ryan Haddad

• 2 edits in trunk/LayoutTests

[ macOS wk1 ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-text.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=209201

Unreviewed test gardening.

Remove flaky expectation since the test is consistently passing.

• platform/mac-wk1/TestExpectations:

1:04 PM Changeset in webkit [261329] by Ryan Haddad

• 3 edits in trunk/LayoutTests

[ macOS debug ] REGRESSION (r259463): http/tests/media/clearkey/collect-webkit-media-session.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=209989

Unreviewed test gardening.

Remove failure expectations for tests that are now consistently passing.

• platform/mac-wk1/TestExpectations:
• platform/mac-wk2/TestExpectations:

1:03 PM WebKitGTK/2.28.x edited by Michael Catanzaro

(diff)

12:49 PM Changeset in webkit [261328] by mark.lam@apple.com

• 7 edits in trunk/Source

Give the DFG and FTL WorkList threads more stack space on ASAN builds.
​https://bugs.webkit.org/show_bug.cgi?id=211535
<rdar://problem/62947884>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::ThreadBody::ThreadBody):

• Mark the AutomaticThread as ThreadType::Compiler.

Source/WTF:

1. Add the ability to set the ThreadType for AutomaticThreads.
2. Give ThreadType::Compiler (which currently only used for the DFG anf FTL WorkList threads) a larger stack for OS(DARWIN) on ASAN builds.

This is needed because ASAN is a memory hungry beast, and we want the ASAN
builds to get to exercise the same amount of code a regular build will (instead
of failing out early with a stack overflow error).

• wtf/AutomaticThread.cpp:

(WTF::AutomaticThread::AutomaticThread):
(WTF::AutomaticThread::start):

• wtf/AutomaticThread.h:
• wtf/Threading.cpp:

(WTF::stackSize):

• wtf/Threading.h:

12:36 PM Changeset in webkit [261327] by graouts@webkit.org

• 2 edits in trunk/Source/WebCore

Add watchOS media controls assets
​https://bugs.webkit.org/show_bug.cgi?id=211508

Unreviewed. Cleaning up some stray logging.

• WebCore.xcodeproj/project.pbxproj:

12:30 PM Changeset in webkit [261326] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r251875): Crash in JSC::StructureIDTable::get on ppc64le: gcSafeMemcpy broken on JSVALUE64 platforms other than x86_64 and aarch64
​https://bugs.webkit.org/show_bug.cgi?id=210685

Patch by Daniel Kolesa <​daniel@octaforge.org> on 2020-05-07
Reviewed by Michael Catanzaro.

Fix gcSafeMemcpy on non-x86_64/aarch64 64-bit architectures.

We were hitting an incorrect x86_64 assertion on values larger than
mediumCutoff on JSVALUE64 architectures other than x86_64 and aarch64,
as the control flow is wrong.

• heap/GCMemoryOperations.h:

(JSC::gcSafeMemcpy):

12:25 PM Changeset in webkit [261325] by mark.lam@apple.com

• 6 edits in trunk/Source

Add stack checks to the DFG and FTL bytecode parser.
​https://bugs.webkit.org/show_bug.cgi?id=211547
<rdar://problem/62958880>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

Inlining can cause some level of recursion of the DFG bytecode parser. We should
do a stack check at each inlining check before recursing. If a stack overflow
appears to be imminent, then just refuse to inline, and therefore, don't recurse
deeper into the parser.

This issue is more noticeable on ASan debug builds where stack frames can be
humongous.

Removed the SUPPRESS_ASAN on cloberrize() and the associated comment from r260692.
It was a mis-diagnosis. The stack checks are what we need.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleVarargsInlining):
(JSC::DFG::ByteCodeParser::handleInlining):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGGraph.h:

Source/WTF:

Added a StackCheck::Scope RAII object to help verify that the default reserved
zone size is at least adequate for known work loads. If this the StackCheck::Scope
assertions fail, then we either need more stack checks, or the reserved zone size
needs to be increased.

Note that the assertions are usually only on in Debug builds. Ideally, we would
want to measure the reserved zone size with a Release build. To do that, we
can just set VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE to 1 unconditionally in
StackCheck.h and rebuild.

• wtf/StackCheck.h:

(WTF::StackCheck::Scope::Scope):
(WTF::StackCheck::Scope::~Scope):
(WTF::StackCheck::Scope::isSafeToRecurse):
(WTF::StackCheck::StackCheck):

12:12 PM Changeset in webkit [261324] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Unreviewed, reverting r260959.
​https://bugs.webkit.org/show_bug.cgi?id=211587

"Causes MiniBrowser to crash when closing a window" (Requested
by ddkilzer on #webkit).

Reverted changeset:

"REGRESSION (r176862, r210483): Leaks of
BrowserWindowController in MiniBrowser/mac/AppDelegate.m"
​https://bugs.webkit.org/show_bug.cgi?id=211243
​https://trac.webkit.org/changeset/260959

11:55 AM Changeset in webkit [261323] by Darin Adler

• 5 edits in trunk/Source

Add some missing null checks for DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=211544
rdar://62843516

Reviewed by Anders Carlsson.

Source/WebCore:

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): Use some more RefPtr,
and check for null before calling DocumentLoader::responseMIMEType.
Also removed a comment that made no sense, and an assertion that was
there for no reason, left over from some point in history where it
made sense.

• loader/HistoryController.cpp:

(WebCore::FrameLoader::HistoryController::updateForRedirectWithLockedBackForwardList):
Add checks for null before calling urlForHistory and isClientRedirect.

Source/WebKit:

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Add a null check before calling DocumentLoader::response.

11:42 AM Changeset in webkit [261322] by commit-queue@webkit.org

• 3 edits in trunk/Source/ThirdParty/ANGLE

Fix Google Maps rendering corruption in simulator with ANGLE
​https://bugs.webkit.org/show_bug.cgi?id=211398

glReadPixels call needs to respect the row stride of the IOSurface.

Patch by James Darpinian <James Darpinian> on 2020-05-07
Reviewed by Alex Christensen.

• src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.h:
• src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:

(rx::IOSurfaceSurfaceEAGL::IOSurfaceSurfaceEAGL):
(rx::IOSurfaceSurfaceEAGL::releaseTexImage):

11:38 AM Changeset in webkit [261321] by timothy_horton@apple.com

• 1 edit
  3 adds in trunk/LayoutTests

Add a test for REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange
​https://bugs.webkit.org/show_bug.cgi?id=211532

Reviewed by Wenson Hsieh.

• fast/text-indicator/text-indicator-estimated-color-with-implicit-newline-expected.txt: Added.
• fast/text-indicator/text-indicator-estimated-color-with-implicit-newline.html: Added.
• platform/ios/fast/text-indicator/text-indicator-estimated-color-with-implicit-newline-expected.txt: Added.

This test would trigger the null deref fixed in r261245.

11:37 AM Changeset in webkit [261320] by Darin Adler

• 21 edits
  2 copies in trunk

Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code
​https://bugs.webkit.org/show_bug.cgi?id=211525

Reviewed by Anders Carlsson.

Source/WebCore:

• editing/mac/TextUndoInsertionMarkupMac.h: Remove

NSTextInputContext_Private.h usage. Moving to NSTextInputContextSPI.h
instead. Also remove #pragma once since this is an Objective-C-only
header, not for cross-platform use.

• editing/mac/TextUndoInsertionMarkupMac.mm: Above, plus move

NSUndoManager_Private.h to NSUndoManagerSPI.h.

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj: Added NSTextInputContextSPI.h and NSUndoManagerSPI.h.
• pal/PlatformMac.cmake: Ditto.
• pal/spi/mac/NSTextInputContextSPI.h: Added.
• pal/spi/mac/NSUndoManagerSPI.h: Added.

Source/WebKit:

• UIProcess/Cocoa/WebViewImpl.mm: Use NSTextInputContextSPI.h.

(WebKit::WebViewImpl::validAttributesForMarkedText): Removed
USE(INSERTION_UNDO_GROUPING) from the macOS-specific code here.
(WebKit::WebViewImpl::insertText): Ditto.

• UIProcess/PageClient.h: Ditto.
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::registerInsertionUndoGrouping): Deleted.
This function is not needed at all on iOS.

• UIProcess/mac/PageClientImplMac.h: Removed USE(INSERTION_UNDO_GROUPING).
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::registerInsertionUndoGrouping): Ditto.

Source/WebKitLegacy/mac:

• WebView/WebHTMLView.mm: Use NSTextInputContextSPI.h.

(-[WebHTMLView validAttributesForMarkedText]): Removed USE(INSERTION_UNDO_GROUPING).
(-[WebHTMLView insertText:]): Ditto.

Tools:

• DumpRenderTree/mac/TextInputControllerMac.m: Use NSTextInputContextSPI.h.

(-[TextInputController stringWithUndoGroupingInsertion:]): Removed
SUPPORT_INSERTION_UNDO_GROUPING.

• DumpRenderTree/mac/UIScriptControllerMac.mm: Use NSTextInputContextSPI.h.
• TestRunnerShared/spi/AppKitTestSPI.h: Removed

NSTextInputContext_Private.h, clients can use NSTextInputContextSPI.h.

• TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Ditto.
• TestWebKitAPI/Tests/mac/CandidateTests.mm: Use NSTextInputContextSPI.h.
• TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Ditto.

11:24 AM Changeset in webkit [261319] by aakash_jain@apple.com

• 5 edits
  4 deletes in trunk/Tools

Delete code for old commit queue
​https://bugs.webkit.org/show_bug.cgi?id=211581

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/common/config/committervalidator.py: Removed.
• Scripts/webkitpy/common/config/committervalidator_unittest.py: Removed.
• Scripts/webkitpy/tool/bot/commitqueuetask.py: Removed.
• Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Removed.
• Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._upload_results_archive_for_patch):
(CommitQueue): Deleted.

• Scripts/webkitpy/tool/commands/queues_unittest.py:

(NeedsUpdateSequence._run):
(TestCommitQueue): Deleted.
(AlwaysCommitQueueTool): Deleted.
(SecondThoughtsCommitQueue): Deleted.
(CommitQueueTest): Deleted.
(test_did_pass_testing_ews): Deleted.

• Scripts/webkitpy/tool/steps/validatechangelogs.py:
• Scripts/webkitpy/tool/steps/validatereviewer.py:

11:21 AM Changeset in webkit [261318] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[ Mac wk1 ] http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=209154

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

11:12 AM Changeset in webkit [261317] by svillar@igalia.com

• 3 edits
  6 adds in trunk/Source/WebCore

[Conditional=] not working for operations in WebGLRenderingContextBase.idl
​https://bugs.webkit.org/show_bug.cgi?id=211528

Reviewed by Chris Dumez.

When an IDL interface under a given Condition defined an operation with
another Condition the generated source file should guard the operation
with both the Condition from the interface and the one from the
operation. This was working fine for sole interfaces but not for those
who were inheriting from a base one, i.e., it was not working for
supplemental interfaces.

Added a new minimalistic binding test showcasing the problem.

• bindings/scripts/CodeGenerator.pm:

(ProcessSupplementalDependencies): Add Conditionals from both interface and operation.

• bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::jsTestGlobalObjectTestOperationConditionalConstructorGetter): Updated result.
(WebCore::jsTestGlobalObjectTestOperationConditionalConstructor): Ditto.
(WebCore::setJSTestGlobalObjectTestOperationConditionalConstructorSetter): Ditto.
(WebCore::setJSTestGlobalObjectTestOperationConditionalConstructor): Ditto.

• bindings/scripts/test/JS/JSTestOperationBase.cpp: Added.
• bindings/scripts/test/JS/JSTestOperationBase.h: Added.
• bindings/scripts/test/JS/JSTestOperationConditional.cpp: Added.
• bindings/scripts/test/JS/JSTestOperationConditional.h: Added.
• bindings/scripts/test/TestOperationBase.idl: Added.
• bindings/scripts/test/TestOperationConditional.idl: Added.

11:07 AM Changeset in webkit [261316] by Ryan Haddad

• 2 edits in trunk/Tools

Unreviewed, reverting r261286.

Tests are still crashing / failing

Reverted changeset:

"Unskip the test since it should now be passing"
​https://trac.webkit.org/changeset/261286

11:02 AM Changeset in webkit [261315] by Darin Adler

• 3 edits in trunk/Source/JavaScriptCore

REGRESSION (r261257): Lifetime problem with upconverted characters in toLocaleCase
​https://bugs.webkit.org/show_bug.cgi?id=211580
rdar://62980449

Reviewed by Yusuke Suzuki.

The problem comes from the fact that callBufferProducingFunction is moving the same
arguments multiple times. At the moment, this works around the only practical
problem with that, but later it should be fixed in callBufferProducingFunction.

• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat): Work around mistakes in how
callBufferProducingFunction works with arguments by calling get() explicitly on the
result of upconvertedCharacters. Later we could fix callBufferProducingFunction to
be safer, but for now this solves the problem.

• runtime/StringPrototype.cpp:

(JSC::toLocaleCase): Ditto.

11:01 AM Changeset in webkit [261314] by Antti Koivisto

• 7 edits in trunk

[Wheel event region] Include listeners on Window
​https://bugs.webkit.org/show_bug.cgi?id=211577

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/scrolling/mac/wheel-event-listener-region-window.html

• dom/EventTarget.h:
• dom/Node.h:
• style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::computeEventListenerRegionTypes):

Take EventTarget so this can be used with DOMWindow.

• style/StyleAdjuster.h:
• style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

LayoutTests:

• fast/scrolling/mac/wheel-event-listener-region-window-expected.txt: Added.
• fast/scrolling/mac/wheel-event-listener-region-window.html: Added.

11:00 AM Changeset in webkit [261313] by keith_miller@apple.com

• 4 edits
  2 adds in trunk

Fix ArrayMode nodes after r261260
​https://bugs.webkit.org/show_bug.cgi?id=211543

Reviewed by Yusuke Suzuki.

I accidentally ran tests with a release build rather than
release+assert when uploading r261260. This patch skips the
CheckArray node in the ArrayMode clobbersTop() logic before
Fixup. And also marks a GetArrayLength in the TypedArray
intrsinics as ExitOK.

This patch also relands r261260.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicGetter):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

10:58 AM Changeset in webkit [261312] by Alan Coon

• 7 edits in branches/safari-609-branch

Apply patch. rdar://problem/62977667

10:58 AM Changeset in webkit [261311] by Alan Coon

• 2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r260474. rdar://problem/62977672

PiP buttons shows up in element fullscreen when PiP is disabled in WKWebViewConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=210813

Reviewed by Eric Carlson.

Not currently testable; entering fullscreen never completes in the iOS TestWebKitAPI app
because that process is not a UI Application.

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController videoControlsManagerDidChange]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:58 AM Changeset in webkit [261310] by Alan Coon

• 5 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r260480. rdar://problem/62977665

Cherry-pick r260301. rdar://problem/62083309

[WebGL] Confirm there are no errors when setting up framebuffers
​https://bugs.webkit.org/show_bug.cgi?id=210632
<rdar://problem/61916680>

Reviewed by Simon Fraser.

We're seeing crashes on macOS inside GraphicsContextGL::reshape().
Specifically when we submit work at the end of the function via
glFlush.

At the moment the cause is a mystery, because we should bail out
before then if the multisample renderbuffer was not complete. In
the hope that it helps somewhat, add a call to glGetError to double
check that there isn't anything horribly wrong before we talk to
the GPU.

• html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::WebGL2RenderingContext): If the underlying GCGL context was marked as "LOST" during initialization, skip the rest of our initialization.
• html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::WebGLRenderingContext):
• html/canvas/WebGLRenderingContextBase.cpp: Ditto. (WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Check for a GL error during setup and, if there is one, skip directly into a LOST state. (WebCore::GraphicsContext3D::reshape):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@260301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-609.2.9.1-branch@260480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:58 AM Changeset in webkit [261309] by Alan Coon

• 8 edits in branches/safari-609-branch/Source/WebKit

Apply patch. rdar://problem/62977657

10:58 AM Changeset in webkit [261308] by Alan Coon

• 6 edits in branches/safari-609-branch/Source/WebKit

Apply patch. rdar://problem/62977647

10:58 AM Changeset in webkit [261307] by Alan Coon

• 2 edits in branches/safari-609-branch/Source/WebKit

Apply patch. rdar://problem/62272254

10:45 AM Changeset in webkit [261306] by Simon Fraser

• 2 edits in trunk/Source/WebCore

REGRESSION (r261056): [ Mac WK1 ] inspector/console/console-api.html is flaky crashing
​https://bugs.webkit.org/show_bug.cgi?id=211386

Reviewed by Darin Adler.

Address additional review feedback.

• platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::unregisterScrollbar):

10:37 AM Changeset in webkit [261305] by Chris Dumez

• 6 edits in trunk/Source/WebKit

Drop dead platformPrepareToSuspend / platformProcessDidResume in NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=211579

Reviewed by Geoffrey Garen.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::resume):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformPrepareToSuspend): Deleted.
(WebKit::NetworkProcess::platformProcessDidResume): Deleted.

• NetworkProcess/curl/NetworkProcessCurl.cpp:

(WebKit::NetworkProcess::platformPrepareToSuspend): Deleted.
(WebKit::NetworkProcess::platformProcessDidResume): Deleted.

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformPrepareToSuspend): Deleted.
(WebKit::NetworkProcess::platformProcessDidResume): Deleted.

10:21 AM Changeset in webkit [261304] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, mark imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/scroll-restoration-order.html as flaky on iOS.

This test has been flaky on iOS since its import.

• platform/ios-wk2/TestExpectations:

10:17 AM Changeset in webkit [261303] by Megan Gardner

• 6 edits in trunk/Source/WebKit

ContextMenu: entire webpage pops and disappears to generate preview of embedded image
​https://bugs.webkit.org/show_bug.cgi?id=211272
<rdar://problem/62482013>

Reviewed by Tim Horton.

The ActionSheetAssistant is always around, so using the presence of one
to determine if we need to remove the _contextMenuHintContainerView is incorrect
and causes it to be around on the next invocation of the context menu, and
causing the failure of the creation of a new preview, which then will default to
popping the whole page. We need to ask the ActionSheetAssistant if it is actively showing
anything, and then correctly clean up the _contextMenuHintContainerView after the
end of the interactions for FileUploadMenu and ActionSheetAssistant are done with their
interactions.

• UIProcess/ios/WKActionSheetAssistant.h:
• UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant removeContextMenuInteraction]):
(-[WKActionSheetAssistant hasContextMenuInteraction]):

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView removeContextMenuViewIfPossibleForActionSheetAssistant:]):
(-[WKContentView _canRemoveContextMenuView]):
(-[WKContentView _removeContextMenuViewIfPossible]):
(-[WKContentView contextMenuInteraction:willEndForConfiguration:animator:]):

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel removeContextMenuInteraction]):

10:14 AM Changeset in webkit [261302] by Alan Bujtas

• 4 edits
  2 adds in trunk

[LFC[TFC] Adjust the table wrapper box style
​https://bugs.webkit.org/show_bug.cgi?id=211574

Reviewed by Antti Koivisto.

Source/WebCore:

The computed values of properties 'position', 'float', 'margin-*', 'top', 'right', 'bottom', and 'left'
on the table element are used on the table wrapper box and not the table box; all other values of non-inheritable
properties are used on the table box and not the table wrapper box.

​https://www.w3.org/TR/CSS22/tables.html#model

Test: fast/layoutformattingcontext/table-simple-with-border.html

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isBlockContainerBox const):

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::TreeBuilder::buildTableStructure):

LayoutTests:

• fast/layoutformattingcontext/table-simple-with-border-expected.txt: Added.
• fast/layoutformattingcontext/table-simple-with-border.html: Added.

10:05 AM Changeset in webkit [261301] by Alan Coon

• 8 edits in branches/safari-609-branch/Source

Versioning.

9:51 AM Changeset in webkit [261300] by Andres Gonzalez

• 6 edits in trunk/Source/WebCore

Make debug build run in accessibility isolated tree mode = 1.
​https://bugs.webkit.org/show_bug.cgi?id=211567

Reviewed by Chris Fleizach.

• Removed several unnecessary ASSERTs that prevent debug builds to run

in isolated tree mode = 1, i.e., isolated tree mode on main thread.

• AXIsolatedObject::children and updateBackingStore need to be executed

on both threads.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::detachRemoteParts):
(WebCore::AXIsolatedObject::children): Need to update the children
regardless of the thread in which it is invoked. Pending, must add a
lock to prevent thread collision.

(WebCore::AXIsolatedObject::updateBackingStore): Need to update the
backing store regardless of the thread in whhich it is invoked.

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::generateSubtree):
(WebCore::AXIsolatedTree::setRootNodeID):

• accessibility/mac/WebAccessibilityObjectWrapperBase.mm: Enable

isolated tree mode = 1.
(-[WebAccessibilityObjectWrapperBase detach]):
(-[WebAccessibilityObjectWrapperBase axBackingObject]):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Use makeString

instead of String concatenation as pointed out by Darin Adler in bug 210914.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

9:50 AM Changeset in webkit [261299] by Chris Dumez

• 20 edits in trunk/Source/WebKit

Simplify several IPC sending call sites in the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=211575

Reviewed by Alex Christensen.

Simplify several IPC sending call sites in the UIProcess by leveraging the fact
that WebPageProxy subclasses IPC::MessageSender.

• UIProcess/Cocoa/TextCheckingController.mm:

(WebKit::TextCheckingController::replaceRelativeToSelection):
(WebKit::TextCheckingController::removeAnnotationRelativeToSelection):

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection):
(WebKit::WebPageProxy::insertDictatedTextAsync):
(WebKit::WebPageProxy::speakingErrorOccurred):
(WebKit::WebPageProxy::boundaryEventOccurred):
(WebKit::WebPageProxy::voicesDidChange):

• UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):

• UIProcess/Inspector/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::setDiagnosticLoggingAvailable):

• UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::setDiagnosticLoggingAvailable):

• UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp:

(WebKit::remoteFileReplaceContentsCallback):

• UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:

(WebKit::fileReplaceContentsCallback):

• UIProcess/Inspector/mac/RemoteWebInspectorProxyMac.mm:

(WebKit::RemoteWebInspectorProxy::platformSave):
(WebKit::RemoteWebInspectorProxy::platformAppend):

• UIProcess/Inspector/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformSave):
(WebKit::WebInspectorProxy::platformAppend):

• UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::createRequest):

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::captureDevicesChanged):
(WebKit::UserMediaPermissionRequestManagerProxy::denyRequest):

• UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::collapseSelection):

• UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::willEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::didEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::willExitFullScreen):
(WebKit::WebFullScreenManagerProxy::didExitFullScreen):
(WebKit::WebFullScreenManagerProxy::setAnimatingFullScreen):
(WebKit::WebFullScreenManagerProxy::requestExitFullScreen):
(WebKit::WebFullScreenManagerProxy::saveScrollPosition):
(WebKit::WebFullScreenManagerProxy::restoreScrollPosition):
(WebKit::WebFullScreenManagerProxy::setFullscreenInsets):
(WebKit::WebFullScreenManagerProxy::setFullscreenAutoHideDuration):
(WebKit::WebFullScreenManagerProxy::setFullscreenControlsHidden):

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::getCenterForZoomGesture):

• UIProcess/ios/SmartMagnificationController.mm:

(WebKit::SmartMagnificationController::handleSmartMagnificationGesture):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView ensurePositionInformationIsUpToDate:]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::handleTwoFingerTapAtPoint):
(WebKit::WebPageProxy::handleStylusSingleTapAtPoint):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::willStartUserTriggeredZooming):
(WebKit::WebPageProxy::potentialTapAtPosition):
(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::cancelPotentialTap):
(WebKit::WebPageProxy::tapHighlightAtPosition):
(WebKit::WebPageProxy::handleTap):
(WebKit::WebPageProxy::didRecognizeLongPress):
(WebKit::WebPageProxy::handleDoubleTapForDoubleClickAtPoint):
(WebKit::WebPageProxy::inspectorNodeSearchMovedToPosition):
(WebKit::WebPageProxy::inspectorNodeSearchEndedAtPosition):
(WebKit::WebPageProxy::blurFocusedElement):
(WebKit::WebPageProxy::setIsShowingInputViewForFocusedElement):
(WebKit::WebPageProxy::setFocusedElementValue):
(WebKit::WebPageProxy::setFocusedElementValueAsNumber):
(WebKit::WebPageProxy::setFocusedElementSelectedIndex):
(WebKit::WebPageProxy::computePagesForPrintingAndDrawToPDF):
(WebKit::WebPageProxy::contentSizeCategoryDidChange):
(WebKit::WebPageProxy::generateSyntheticEditingCommand):

• UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::handleMagnificationGestureEvent):
(WebKit::ViewGestureController::handleSmartMagnificationGesture):

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::setMainFrameIsScrollable):
(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):
(WebKit::WebPageProxy::fontAtSelection):
(WebKit::WebPageProxy::stringSelectionForPasteboard):
(WebKit::WebPageProxy::dataSelectionForPasteboard):
(WebKit::WebPageProxy::readSelectionFromPasteboard):
(WebKit::WebPageProxy::replaceSelectionWithPasteboardData):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
(WebKit::WebPageProxy::acceptsFirstMouse):

9:39 AM Changeset in webkit [261298] by Alan Bujtas

• 5 edits
  2 adds in trunk

[LFC][TFC] Set section [top, left] used position.
​https://bugs.webkit.org/show_bug.cgi?id=211546

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-with-padding.html

• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):

• layout/tableformatting/TableFormattingContext.h:

LayoutTests:

• fast/layoutformattingcontext/table-simple-with-padding-expected.txt: Added.
• fast/layoutformattingcontext/table-simple-with-padding.html: Added.

9:38 AM Changeset in webkit [261297] by Antti Koivisto

• 5 edits
  2 adds in trunk

[Wheel event region] Include listeners on Document
​https://bugs.webkit.org/show_bug.cgi?id=211571

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/scrolling/mac/wheel-event-listener-region-document.html

• style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::computeEventListenerRegionTypes):
(WebCore::Style::computeEventListenerRegionTypes): Deleted.

Make public and take Node instead of Element.

• style/StyleAdjuster.h:
• style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

Gather event region bits from Document too.

LayoutTests:

• fast/scrolling/mac/wheel-event-listener-region-document-expected.txt: Added.
• fast/scrolling/mac/wheel-event-listener-region-document.html: Added.

9:29 AM Changeset in webkit [261296] by commit-queue@webkit.org

• 13 edits
  1 add in trunk

Unreviewed, reverting r260769.
​https://bugs.webkit.org/show_bug.cgi?id=211578

Introduced regressions related to sharing (Requested by
perarne on #webkit).

Reverted changeset:

"[Cocoa] After r258891, r255119 can be reverted"
​https://bugs.webkit.org/show_bug.cgi?id=211083
​https://trac.webkit.org/changeset/260769

9:23 AM Changeset in webkit [261295] by Ryan Haddad

• 1 edit
  2 deletes in trunk/LayoutTests

Unreviewed, reverting r261251.

Test is failing on iOS

Reverted changeset:

"Add a test for `REGRESSION (r260753): Frequent crashes under
TextIndicator's estimatedTextColorsForRange`"
​https://bugs.webkit.org/show_bug.cgi?id=211532
​https://trac.webkit.org/changeset/261251

9:21 AM Changeset in webkit [261294] by Lauro Moura

• 2 edits in trunk/Tools

[Flatpak SDK] Fix string.format invocation

Reviewed by Philippe Normand.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

9:19 AM Changeset in webkit [261293] by Ryan Haddad

• 4 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r261260.

Caused 26 JSC test failures

Reverted changeset:

"DFG ByVal nodes with ArrayModes should clobberTop until Fixup
phase runs."
​https://bugs.webkit.org/show_bug.cgi?id=211531
​https://trac.webkit.org/changeset/261260

9:14 AM Changeset in webkit [261292] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, mark html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source.html as flaky.

This test has been flaky since import from WPT.

• TestExpectations:

9:00 AM Changeset in webkit [261291] by Darin Adler

• 3 edits in trunk/Source/WebCore

Fix assertions seen when trying to draw an absurdly large shadow
​https://bugs.webkit.org/show_bug.cgi?id=211541
rdar://62843377

Reviewed by Geoffrey Garen.

• platform/graphics/IntSize.h:

(WebCore::IntSize::unclampedArea const): Return uint64_t instead of
size_t. Two 32-bit positive integers multiplied fit in a 64-bit integer,
but there's no guarantee they fit in a "pointer sized" integer.

• platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::drawRectShadow): When comparing an IntSize area with
a FloatSize area, avoid checked overflow by using IntSize::unclampedArea,
which returns something we can compare with a float. Using IntSize::area
meant we'd intentionally crash the process if the area number doesn't fit
in a 32-bit int, which is not important or helpful.
(WebCore::ShadowBlur::drawRectShadowWithTiling): Make sure
ScratchBuffer::scheduleScratchBufferPurge is always called after
ScratchBuffer::getScratchBuffer, even it returns nullptr. An alternative
would have been to change the logic inside getScratchBuffer, but this
seems easier to get right, and no need to optimize the failure case.
(WebCore::ShadowBlur::drawInsetShadowWithTiling): Ditto.

8:37 AM Changeset in webkit [261290] by youenn@apple.com

• 3 edits in trunk/Source/WebCore

Fix potential threading issue in AudioMediaStreamTrackRendererCocoa::render
​https://bugs.webkit.org/show_bug.cgi?id=211560

Reviewed by Eric Carlson.

When the audio description is updated, the audio renderer is creating a new AudioSampleDataSource.
The refing of the source in the render method is not sufficient to protect agains the change.
For that purpose, we keep a separate reference to the source that is only used in the render method/render thread.
We add a boolean that tells the render method whether to update its source reference.
As long as the source reference is not updated, no new source will be created n the method processing the pushed samples.

• platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:

(WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples):
(WebCore::AudioMediaStreamTrackRendererCocoa::render):

• platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.h:

8:32 AM Changeset in webkit [261289] by Diego Pino Garcia

• 3 edits
  1 delete in trunk/LayoutTests

[GTK][WPE] Gardening, update test expectations
​https://bugs.webkit.org/show_bug.cgi?id=211573

Review of several test failures that could be closed. Updated test
expectations accordingly.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:
• platform/wpe/imported/w3c/web-platform-tests/css/css-transitions/properties-value-auto-001-expected.txt: Removed.

8:01 AM Changeset in webkit [261288] by Chris Dumez

• 17 edits in trunk/Source/WebKit

[iOS] AuxiliaryProcessProxy::sendWithAsyncReply() should prevent auxiliary process suspension while processing the IPC
​https://bugs.webkit.org/show_bug.cgi?id=209928

Reviewed by Youenn Fablet.

AuxiliaryProcessProxy::sendWithAsyncReply() should prevent auxiliary process suspension
on iOS while processing the IPC. If the process is suspended either before or during
the IPC, this could result in hangs. This is a speculative fix for the flaky timeouts
we see on many tests on iOS only. We know that missing activities with
sendWithAsyncReply has caused test timeouts in the past (Bug 211421).

• UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::sendMessage):

• UIProcess/AuxiliaryProcessProxy.h:

(WebKit::AuxiliaryProcessProxy::sendWithAsyncReply):

• UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::getGPUProcessConnection):

• UIProcess/GPU/GPUProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
(WebKit::NetworkProcessProxy::setUseITPDatabase):
(WebKit::NetworkProcessProxy::resetCacheMaxAgeCapForPrevalentResources):
(WebKit::NetworkProcessProxy::resetParametersToDefaultValues):
(WebKit::NetworkProcessProxy::scheduleClearInMemoryAndPersistent):
(WebKit::NetworkProcessProxy::resetCrossSiteLoadsWithLinkDecorationForTesting):
(WebKit::NetworkProcessProxy::setAppBoundDomainsForResourceLoadStatistics):
(WebKit::NetworkProcessProxy::setShouldDowngradeReferrerForTesting):
(WebKit::NetworkProcessProxy::setThirdPartyCookieBlockingMode):
(WebKit::NetworkProcessProxy::setShouldEnbleSameSiteStrictEnforcementForTesting):
(WebKit::NetworkProcessProxy::setFirstPartyWebsiteDataRemovalModeForTesting):
(WebKit::NetworkProcessProxy::sendPrepareToSuspend):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::PluginProcessProxy):

• UIProcess/Plugins/PluginProcessProxy.h:
• UIProcess/ProcessThrottler.h:

(WebKit::ProcessThrottler::Activity::Activity):
(WebKit::ProcessThrottler::Activity::isQuietActivity const):
(WebKit::ProcessThrottler::Activity::invalidate):

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):

• UIProcess/WebBackForwardCacheEntry.cpp:

(WebKit::WebBackForwardCacheEntry::~WebBackForwardCacheEntry):

• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookie):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::setCookies):
(WebKit::WebCookieManagerProxy::getAllCookies):
(WebKit::WebCookieManagerProxy::getCookies):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getProcessDisplayName):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::setThirdPartyCookieBlockingMode):
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::WebProcessProxy::sendPrepareToSuspend):
(WebKit::WebProcessProxy::activePagesDomainsForTesting):
(WebKit::WebProcessProxy::establishServiceWorkerContext):

• UIProcess/WebProcessProxy.h:
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::insertTextPlaceholder):
(WebKit::WebPageProxy::removeTextPlaceholder):
(WebKit::WebPageProxy::requestAutocorrectionData):
(WebKit::WebPageProxy::requestEvasionRectsAboveSelection):
(WebKit::WebPageProxy::updateSelectionWithDelta):
(WebKit::WebPageProxy::requestDocumentEditingContext):
(WebKit::WebPageProxy::insertDroppedImagePlaceholders):

7:47 AM Changeset in webkit [261287] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak SDK] Doesn't generate crash logs on the bots
​https://bugs.webkit.org/show_bug.cgi?id=211568

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-05-07
Reviewed by Carlos Alberto Lopez Perez.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): Bind-mount the
WEBKIT_CORE_DUMPS_DIRECTORY so that the crash-log generator is
able to write crash log reports there.

7:37 AM Changeset in webkit [261286] by Truitt Savell

• 2 edits in trunk/Tools

Unskip the test since it should now be passing

Unreviewed test gardening.

• TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

7:29 AM Changeset in webkit [261285] by Andres Gonzalez

• 2 edits in trunk/Source/WebCore

Fix for crash in AXIsolatedObject::identifierAttribute.
​https://bugs.webkit.org/show_bug.cgi?id=211565

Reviewed by Chris Fleizach.

Covered by existing tests.

When adding the identifierAttribute property to the AXIsolatedObject's
properties map, must make an isolatedCopy of it in order to retrieve it
on the secondary thread.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):

7:26 AM Changeset in webkit [261284] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[GTK] REGRESSION(r260996): Pressing <Tab> in an HTTP authentication dialog makes the dialog lose focus
​https://bugs.webkit.org/show_bug.cgi?id=211555

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-05-07
Reviewed by Philippe Normand.

Bring back webkitWebViewBaseFocus to GTK3. I made it GTK4 only by mistake in r260996.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseFocus):
(webkit_web_view_base_class_init):

7:16 AM Changeset in webkit [261283] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK][WPE] Gardening, update test expectations after r261251
​https://bugs.webkit.org/show_bug.cgi?id=211570

Unreviewed gardening.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

6:42 AM Changeset in webkit [261282] by Philippe Normand

• 4 edits in trunk

[GTK] Test failures after Flatpak upgrade
​https://bugs.webkit.org/show_bug.cgi?id=211497

Reviewed by Adrian Perez de Castro.

Tools:

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): Don't set WEBKIT_TOP_LEVEL. I'm
not sure why it's needed at all. If it needs to be set it should
be /app/webkit/ anyway. Setting it to /app triggers test failures
due to invalid computed paths by internals' pathToLocalResource().

LayoutTests:

• platform/gtk/TestExpectations: Unflag fixed tests. The webgl

failures seem more related to bug #211338 actually.

6:12 AM Changeset in webkit [261281] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK] Gardening, update baselines after r261248
​https://bugs.webkit.org/show_bug.cgi?id=211562

Unreviewed gardening.

• accessibility/gtk/object-attributes-expected.txt:
• platform/gtk/accessibility/lists-expected.txt:

5:41 AM Changeset in webkit [261280] by Carlos Garcia Campos

• 3 edits in trunk/Tools

Unreviewed. Fix GTK4 build with current GTK

GtkWindow and GtkOverlay aren't a GtkContainer anymore.

• MiniBrowser/gtk/BrowserTab.c:

(browserTabConstructed):

• MiniBrowser/gtk/BrowserWindow.c:

(browser_window_init):

4:16 AM Changeset in webkit [261279] by Antti Koivisto

• 13 edits
  2 adds in trunk

Add basic support for generating accurate wheel event listener region
​https://bugs.webkit.org/show_bug.cgi?id=211512

Reviewed by Simon Fraser.

Source/WebCore:

Add fake properties for wheel event listeners to RenderStyle and use them to
generate regions in EventRegion. There is a separate region for non-passive
wheel event listeners (that will require synchronous handling).

The generated regions are not used for anything in this patch.
Style is not yet invalided on event listener additions and removals.

Test: fast/scrolling/mac/wheel-event-listener-region-basic.html

• dom/Node.h:
• rendering/EventRegion.cpp:

(WebCore::EventRegion::unite):
(WebCore::EventRegion::uniteEventListeners):
(WebCore::EventRegion::dump const):

• rendering/EventRegion.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateEventRegion):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::eventListenerRegionTypes const):
(WebCore::RenderStyle::setEventListenerRegionTypes):

• rendering/style/RenderStyleConstants.h:
• rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

• rendering/style/StyleRareInheritedData.h:
• style/StyleAdjuster.cpp:

(WebCore::Style::computeEventListenerRegionTypes):
(WebCore::Style::Adjuster::adjust const):

LayoutTests:

• fast/scrolling/mac/wheel-event-listener-region-basic-expected.txt: Added.
• fast/scrolling/mac/wheel-event-listener-region-basic.html: Added.

2:36 AM Changeset in webkit [261278] by Philippe Normand

• 4 edits in trunk/Source/WebKit

[GTK] Build warning fixes

Rubber-stamped by Žan Doberšek.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseGrabFocus):

• UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::getGPUProcessConnection):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getNetworkProcessConnection):

2:23 AM Changeset in webkit [261277] by youenn@apple.com

• 13 edits in trunk/Source

Sending WebRTC network packets should not go through the main thread
​https://bugs.webkit.org/show_bug.cgi?id=211291

Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing tests.

• Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::filterSDP const):
Fix a case where the SDP would be badly formatted if we do not have yet a MDNS name for the corresponding IP address.
Small refactoring to use early returns.

• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::getStaticFactoryAndThreads):

• platform/mediastream/libwebrtc/LibWebRTCProvider.h:

Add the ability for WebKit LibWebRTCProvider to do some processing on creation of the RTC threads.

Source/WebKit:

Following on receiving RTC packets from a background thread, we also send RTC packets from a background thread.
Creation of the sockets also happens in a background thread.
LibWebRTCNetwork is getting the connection whenever a new connection to network process is created.
It will then hop to the RTC network thread to set the IPC connection to the libwebrtc socket factory.

At creation of the socket, we get the IPC connection to the network process and keep a ref in the RTC socket.
In case network process crashed and the IPC connection of the RTC network is null, we hop to the main thread to create a new IPC connection.
This will fail the creation of the socket (as well as new ones as well) as long as the IPC connection to network process is not valid again.

Covered by existing tests.

• WebProcess/Network/webrtc/LibWebRTCNetwork.cpp:

(WebKit::LibWebRTCNetwork::setAsActive):
(WebKit::LibWebRTCNetwork::setConnection):
(WebKit::LibWebRTCNetwork::dispatchToThread):

• WebProcess/Network/webrtc/LibWebRTCNetwork.h:

(WebKit::LibWebRTCNetwork::connection):
(WebKit::LibWebRTCNetwork::isActive const):

• WebProcess/Network/webrtc/LibWebRTCProvider.cpp:

(WebKit::LibWebRTCProvider::startedNetworkThread):

• WebProcess/Network/webrtc/LibWebRTCProvider.h:
• WebProcess/Network/webrtc/LibWebRTCSocket.cpp:

(WebKit::LibWebRTCSocket::SendTo):
(WebKit::LibWebRTCSocket::Close):
(WebKit::LibWebRTCSocket::SetOption):
(WebKit::LibWebRTCSocket::suspend):

• WebProcess/Network/webrtc/LibWebRTCSocket.h:
• WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:

(WebKit::LibWebRTCSocketFactory::setConnection):
(WebKit::LibWebRTCSocketFactory::connection):
(WebKit::LibWebRTCSocketFactory::createServerTcpSocket):
(WebKit::LibWebRTCSocketFactory::createUdpSocket):
(WebKit::LibWebRTCSocketFactory::createClientTcpSocket):
(WebKit::LibWebRTCSocketFactory::createNewConnectionSocket):
(WebKit::LibWebRTCSocketFactory::addSocket):
(WebKit::LibWebRTCSocketFactory::removeSocket):
(WebKit::LibWebRTCSocketFactory::forSocketInGroup):

• WebProcess/Network/webrtc/LibWebRTCSocketFactory.h:

2:05 AM Changeset in webkit [261276] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[GTK4] Stop using the GtkWidget.destroy vfunc
​https://bugs.webkit.org/show_bug.cgi?id=211553

Reviewed by Carlos Garcia Campos.

No new tests needed.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDestroy): Removed.
(webkitWebViewBaseDispose): Bring in the code from the removed function, adapt
to use g_clear_pointer() to destroy the nested dialog.
(webkit_web_view_base_class_init): Do not set the GtkWidget.destroy vfunc.

1:40 AM Changeset in webkit [261275] by commit-queue@webkit.org

• 4 edits in trunk

[WPE][Qt] Enable by default
​https://bugs.webkit.org/show_bug.cgi?id=211517

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-05-07
Reviewed by Adrian Perez de Castro.

.:

• Source/cmake/OptionsWPE.cmake: Now that the EWS and bots use the

Flatpak SDK, Qt5 libs are available so we can enable the module
and have bots run its tests.

Source/WebKit:

• PlatformWPE.cmake: Fix WPEQt build.

1:33 AM Changeset in webkit [261274] by Philippe Normand

• 4 edits
  158 adds in trunk

[Flatpak SDK] Import build definitions
​https://bugs.webkit.org/show_bug.cgi?id=211448

Reviewed by Carlos Alberto Lopez Perez.

To build the SDK, run Tools/Scripts/webkit-flatpak-sdk --build,
this can take hours and use gigabytes of your hard-drive. To build
a single recipe, use something like:

Tools/Scripts/bst-wrapper build sdk/gtk.bst

To enter the Buildstream SDK shell and debug stuff when hacking on
a specific dependency, Tools/Scripts/bst-wrapper shell sdk/gtk.bst.

To test your changes in WebKit:
`shell
$ Tools/Scripts/webkit-flatpak -u --repo=Tools/buildstream/repo
$ Tools/Scripts/run-minibrowser --gtk --flatpak-repo=Tools/buildstream/repo <url>
...
`

bst-wrapper has the same options as bst itself, documented on
​https://docs.buildstream.build/1.4.2/index.html.

Internally the bst-wrapper will install Buildstream and a few
other python dependencies in a local virtualenv managed by pipenv.
This is all abstracted though, in theory direct access to the
pipenv environment shouldn't be needed.

• Scripts/bst-wrapper: Added.
• Scripts/webkit-flatpak-sdk: Added.
• buildstream/Makefile: Added.
• buildstream/Pipfile: Added.
• buildstream/Pipfile.lock: Added.
• buildstream/elements/filtered-openh264.bst: Added.
• buildstream/elements/filtered.bst: Added.
• buildstream/elements/flatpak-platform-extensions.bst: Added.
• buildstream/elements/flatpak-runtimes.bst: Added.
• buildstream/elements/flatpak/platform-arch-libs-debug.bst: Added.
• buildstream/elements/flatpak/platform-arch-libs.bst: Added.
• buildstream/elements/flatpak/platform-image.bst: Added.
• buildstream/elements/flatpak/platform-locale.bst: Added.
• buildstream/elements/flatpak/platform.bst: Added.
• buildstream/elements/flatpak/sdk-arch-libs-debug.bst: Added.
• buildstream/elements/flatpak/sdk-arch-libs.bst: Added.
• buildstream/elements/flatpak/sdk-debug.bst: Added.
• buildstream/elements/flatpak/sdk-docs.bst: Added.
• buildstream/elements/flatpak/sdk-image.bst: Added.
• buildstream/elements/flatpak/sdk-locale.bst: Added.
• buildstream/elements/flatpak/sdk.bst: Added.
• buildstream/elements/freedesktop-sdk.bst: Added.
• buildstream/elements/manifests/platform-manifest.bst: Added.
• buildstream/elements/manifests/sdk-manifest.bst: Added.
• buildstream/elements/qt5.bst: Added.
• buildstream/elements/qt5/qtbase.bst: Added.
• buildstream/elements/qt5/qtdeclarative.bst: Added.
• buildstream/elements/qt5/qtquickcontrols.bst: Added.
• buildstream/elements/qt5/qtquickcontrols2.bst: Added.
• buildstream/elements/qt5/qtwayland.bst: Added.
• buildstream/elements/qt5/qtx11extras.bst: Added.
• buildstream/elements/sdk-build-depends/libusb.bst: Added.
• buildstream/elements/sdk-build-depends/sassc.bst: Added.
• buildstream/elements/sdk-build-depends/utf8proc.bst: Added.
• buildstream/elements/sdk-depends/libsass.bst: Added.
• buildstream/elements/sdk-platform.bst: Added.
• buildstream/elements/sdk.bst: Added.
• buildstream/elements/sdk/adwaita-icon-theme.bst: Added.
• buildstream/elements/sdk/at-spi2-atk.bst: Added.
• buildstream/elements/sdk/at-spi2-core.bst: Added.
• buildstream/elements/sdk/atk.bst: Added.
• buildstream/elements/sdk/brotli.bst: Added.
• buildstream/elements/sdk/capnp.bst: Added.
• buildstream/elements/sdk/enchant-2.bst: Added.
• buildstream/elements/sdk/glib-networking.bst: Added.
• buildstream/elements/sdk/glib.bst: Added.
• buildstream/elements/sdk/gobject-introspection.bst: Added.
• buildstream/elements/sdk/graphene.bst: Added.
• buildstream/elements/sdk/graphviz.bst: Added.
• buildstream/elements/sdk/gst-libav.bst: Added.
• buildstream/elements/sdk/gst-plugins-bad.bst: Added.
• buildstream/elements/sdk/gst-plugins-base.bst: Added.
• buildstream/elements/sdk/gst-plugins-good.bst: Added.
• buildstream/elements/sdk/gst-plugins-ugly.bst: Added.
• buildstream/elements/sdk/gstreamer.bst: Added.
• buildstream/elements/sdk/gtk+-3.bst: Added.
• buildstream/elements/sdk/gtk.bst: Added.
• buildstream/elements/sdk/icecc.bst: Added.
• buildstream/elements/sdk/intltool.bst: Added.
• buildstream/elements/sdk/krb5.bst: Added.
• buildstream/elements/sdk/libcap-ng.bst: Added.
• buildstream/elements/sdk/libevent.bst: Added.
• buildstream/elements/sdk/libgcrypt.bst: Added.
• buildstream/elements/sdk/libmanette.bst: Added.
• buildstream/elements/sdk/libnotify.bst: Added.
• buildstream/elements/sdk/libopenh264.bst: Added.
• buildstream/elements/sdk/libsecret.bst: Added.
• buildstream/elements/sdk/libsoup.bst: Added.
• buildstream/elements/sdk/libsrtp2.bst: Added.
• buildstream/elements/sdk/libusrsctp.bst: Added.
• buildstream/elements/sdk/libwpe.bst: Added.
• buildstream/elements/sdk/libzstd.bst: Added.
• buildstream/elements/sdk/lzo2.bst: Added.
• buildstream/elements/sdk/openjpeg.bst: Added.
• buildstream/elements/sdk/openxr.bst: Added.
• buildstream/elements/sdk/os-release.bst: Added.
• buildstream/elements/sdk/patchelf.bst: Added.
• buildstream/elements/sdk/psmisc.bst: Added.
• buildstream/elements/sdk/pycairo.bst: Added.
• buildstream/elements/sdk/pygobject.bst: Added.
• buildstream/elements/sdk/python2-pycairo.bst: Added.
• buildstream/elements/sdk/python2-pygobject.bst: Added.
• buildstream/elements/sdk/python2-six.bst: Added.
• buildstream/elements/sdk/python2-subprocess32.bst: Added.
• buildstream/elements/sdk/python2.bst: Added.
• buildstream/elements/sdk/rr.bst: Added.
• buildstream/elements/sdk/sccache.bst: Added.
• buildstream/elements/sdk/shared-mime-info.bst: Added.
• buildstream/elements/sdk/subversion.bst: Added.
• buildstream/elements/sdk/v4lutils.bst: Added.
• buildstream/elements/sdk/woff2.bst: Added.
• buildstream/elements/sdk/wpebackend-fdo.bst: Added.
• buildstream/elements/sdk/x264.bst: Added.
• buildstream/elements/sdk/xorg-server.bst: Added.
• buildstream/elements/test-infra.bst: Added.
• buildstream/elements/test-infra/apr-util.bst: Added.
• buildstream/elements/test-infra/apr.bst: Added.
• buildstream/elements/test-infra/httpd.bst: Added.
• buildstream/elements/test-infra/perl-cgi-pm.bst: Added.
• buildstream/elements/test-infra/perl-http-date-pm.bst: Added.
• buildstream/elements/test-infra/php.bst: Added.
• buildstream/elements/test-infra/webkitgtk-test-dicts.bst: Added.
• buildstream/elements/test-infra/webkitgtk-test-fonts.bst: Added.
• buildstream/files/krb5/krb5.conf: Added.
• buildstream/files/os-release/issue.in: Added.
• buildstream/files/os-release/issue.net.in: Added.
• buildstream/files/os-release/org.webkit.Platform.appdata.xml.in: Added.
• buildstream/files/os-release/org.webkit.Sdk.appdata.xml.in: Added.
• buildstream/files/os-release/os-release.in: Added.
• buildstream/patches/fdo-0001-Update-gcc-to-9.3.0.patch: Added.
• buildstream/patches/fdo/0001-Add-Jack.patch: Added.
• buildstream/patches/fdo/0001-components-xdg-desktop-portal.bst-Update-to-1.6.0.patch: Added.
• buildstream/patches/fdo/0001-ffmpeg-Add-MS-MPEG-DivX-variants.patch: Added.
• buildstream/patches/fdo/0002-Update-PipeWire-to-0.3.1.patch: Added.
• buildstream/patches/fdo/0002-ffmpeg-Add-VP6-and-Sorenson-Spark-video-codecs.patch: Added.
• buildstream/patches/fdo/0003-Add-Bluez.patch: Added.
• buildstream/patches/fdo/0003-ffmpeg-Add-Intel-Indeo-and-Cinepak-video-support.patch: Added.
• buildstream/patches/fdo/0004-ffmpeg-Add-MPEG-2-video-decoder.patch: Added.
• buildstream/patches/fdo/0005-ffmpeg-Add-msmpeg4v3-support.patch: Added.
• buildstream/patches/gst-libav-stop-caching-codecs.patch: Added.
• buildstream/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
• buildstream/patches/gst-plugins-base-0001-glupload-Fix-fallback-from-direct-dmabuf-to-dmabuf-u.patch: Added.
• buildstream/patches/gst-plugins-base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Added.
• buildstream/patches/gst-plugins-base-0002-glupload-fix-segfault.patch: Added.
• buildstream/patches/gst-plugins-good-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Added.
• buildstream/patches/gtk-meson-Bump-to-latest-version-of-the-3.24-branch.patch: Added.
• buildstream/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
• buildstream/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Added.
• buildstream/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
• buildstream/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added.
• buildstream/patches/libsecret-b53e9876f4611525b7a8f69a3110fbec51dcede0.patch: Added.
• buildstream/patches/nettle-no-debug.diff: Added.
• buildstream/patches/qtbase-avoid-hardcoding-kernel-version.patch: Added.
• buildstream/patches/qtbase-revert-correct-handling-for-xdg-runtime-dir.patch: Added.
• buildstream/patches/qtbase-use-wayland-on-gnome.patch: Added.
• buildstream/patches/qtdeclarative-use-python3.patch: Added.
• buildstream/patches/qtwayland-use-gnome-platform-theme-on-gnome-based-desktops.patch: Added.
• buildstream/patches/sccache-no-selenium.patch: Added.
• buildstream/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
• buildstream/project.conf: Added.
• buildstream/utils/generate-version: Added.
• gtk/install-dependencies:
• wpe/install-dependencies:

12:49 AM Changeset in webkit [261273] by svillar@igalia.com

• 6 edits in trunk/Source/WebCore

[WebXR] Implement simulateUserActivation()
​https://bugs.webkit.org/show_bug.cgi?id=211516

Reviewed by Youenn Fablet.

simulateUserActivation() is the method used by the WebXR Test API to
mock a user activation and thus let WebXR API think that the user is
behind the request that is going to be made in the function passed as
argument.

No new tests added as the imported WebXR web-platform-tests already make
use of this API.

• testing/WebXRTest.cpp:

(WebCore::WebXRTest::simulateUserActivation): Implemented.

• testing/WebXRTest.h: Added Document parameter.
• testing/WebXRTest.idl: Call with Document.
• testing/XRSimulateUserActivationFunction.h: Removed function params.
• testing/XRSimulateUserActivationFunction.idl: Ditto.

12:34 AM Changeset in webkit [261272] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK][WPE] Gardening, update test expectations after r259705
​https://bugs.webkit.org/show_bug.cgi?id=211552

Unreviewed gardening.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

12:00 AM Changeset in webkit [261271] by mark.lam@apple.com

• 8 edits in trunk

Fix broken exceptionFuzz tests.
​https://bugs.webkit.org/show_bug.cgi?id=211550

Reviewed by Yusuke Suzuki.

JSTests:

The tests should not be relying on setting a JSC Option at runtime because the
options are already frozen by then. Instead, we set the needed
--useExceptionFuzz=true option from the command line.

• exceptionFuzz/3d-cube.js:
• exceptionFuzz/date-format-xparb.js:
• exceptionFuzz/earley-boyer.js:

Source/JavaScriptCore:

Remove the bad and now unused utility function to set Options::useExceptionFuzz().

• tools/JSDollarVM.cpp:

(JSC::JSDollarVM::finishCreation):
(JSC::functionEnableExceptionFuzz): Deleted.

Tools:

Pass the --useExceptionFuzz=true option from the command line for runExceptionFuzz.

• Scripts/run-jsc-stress-tests: