Timeline

May 25, 2020:

9:48 PM Changeset in webkit [262136] by Wenson Hsieh

• 2 edits in trunk/Tools

[iOS] ActionSheetTests.DataDetectorsLinkIsNotPresentedAsALink is failing consistently
​https://bugs.webkit.org/show_bug.cgi?id=212363
<rdar://problem/63508866>

Reviewed by Tim Horton.

This test began to consistently throw an exception after <​https://trac.webkit.org/r261157>, due to how
UserInterfaceSwizzler always instantiates the shared UIApplication. This apparently causes -[WKContentView
resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets:] to return nil instead of a replica view. As a
result, we crash under createFallbackTargetedPreview as we're attempting to assemble a targeted preview for
the context menu interaction.

Since this seems to only affect this particular API test, work around it by swizzling out
-resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets: in this API test to return a non-null UIView.

• TestWebKitAPI/Tests/ios/ActionSheetTests.mm:

(TestWebKitAPI::swizzledResizableSnapshotViewFromRect):
(TestWebKitAPI::TEST):

8:44 PM Changeset in webkit [262135] by Diego Pino Garcia

• 11 edits in trunk/LayoutTests

[WPE] Gardening, update baselines after r262127
​https://bugs.webkit.org/show_bug.cgi?id=212365

Unreviewed gardening.

• platform/wpe/fast/html/details-no-summary4-expected.txt:
• platform/wpe/fast/html/details-open-javascript-expected.txt:
• platform/wpe/fast/html/details-open2-expected.txt:
• platform/wpe/fast/html/details-open4-expected.txt:
• platform/wpe/fast/html/details-replace-summary-child-expected.txt:
• platform/wpe/fast/html/details-replace-text-expected.txt:
• platform/wpe/fast/html/details-writing-mode-expected.txt:
• platform/wpe/fast/html/details-writing-mode-mixed-expected.txt:
• platform/wpe/fast/writing-mode/fieldsets-expected.txt:
• platform/wpe/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:

8:30 PM Changeset in webkit [262134] by Diego Pino Garcia

• 70 edits in trunk/LayoutTests

[GTK] Gardening, update baselines after r262127
​https://bugs.webkit.org/show_bug.cgi?id=212364

Unreviewed gardening.

• platform/glib/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
• platform/glib/css3/flexbox/flexbox-baseline-expected.txt:
• platform/glib/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
• platform/glib/fast/css-generated-content/details-summary-before-after-expected.txt:
• platform/glib/fast/html/details-add-child-1-expected.txt:
• platform/glib/fast/html/details-add-child-2-expected.txt:
• platform/glib/fast/html/details-add-details-child-1-expected.txt:
• platform/glib/fast/html/details-add-details-child-2-expected.txt:
• platform/glib/fast/html/details-add-summary-1-and-click-expected.txt:
• platform/glib/fast/html/details-add-summary-1-expected.txt:
• platform/glib/fast/html/details-add-summary-10-and-click-expected.txt:
• platform/glib/fast/html/details-add-summary-10-expected.txt:
• platform/glib/fast/html/details-add-summary-2-and-click-expected.txt:
• platform/glib/fast/html/details-add-summary-2-expected.txt:
• platform/glib/fast/html/details-add-summary-3-and-click-expected.txt:
• platform/glib/fast/html/details-add-summary-3-expected.txt:
• platform/glib/fast/html/details-add-summary-4-and-click-expected.txt:
• platform/glib/fast/html/details-add-summary-4-expected.txt:
• platform/glib/fast/html/details-add-summary-5-and-click-expected.txt:
• platform/glib/fast/html/details-add-summary-5-expected.txt:
• platform/glib/fast/html/details-add-summary-6-and-click-expected.txt:
• platform/glib/fast/html/details-add-summary-6-expected.txt:
• platform/glib/fast/html/details-add-summary-7-and-click-expected.txt:
• platform/glib/fast/html/details-add-summary-7-expected.txt:
• platform/glib/fast/html/details-add-summary-8-and-click-expected.txt:
• platform/glib/fast/html/details-add-summary-8-expected.txt:
• platform/glib/fast/html/details-add-summary-9-and-click-expected.txt:
• platform/glib/fast/html/details-add-summary-9-expected.txt:
• platform/glib/fast/html/details-add-summary-child-1-expected.txt:
• platform/glib/fast/html/details-add-summary-child-2-expected.txt:
• platform/glib/fast/html/details-marker-style-expected.txt:
• platform/glib/fast/html/details-nested-1-expected.txt:
• platform/glib/fast/html/details-nested-2-expected.txt:
• platform/glib/fast/html/details-no-summary1-expected.txt:
• platform/glib/fast/html/details-no-summary2-expected.txt:
• platform/glib/fast/html/details-no-summary3-expected.txt:
• platform/glib/fast/html/details-open1-expected.txt:
• platform/glib/fast/html/details-open3-expected.txt:
• platform/glib/fast/html/details-open5-expected.txt:
• platform/glib/fast/html/details-open6-expected.txt:
• platform/glib/fast/html/details-position-expected.txt:
• platform/glib/fast/html/details-remove-child-1-expected.txt:
• platform/glib/fast/html/details-remove-child-2-expected.txt:
• platform/glib/fast/html/details-remove-summary-1-and-click-expected.txt:
• platform/glib/fast/html/details-remove-summary-1-expected.txt:
• platform/glib/fast/html/details-remove-summary-2-and-click-expected.txt:
• platform/glib/fast/html/details-remove-summary-2-expected.txt:
• platform/glib/fast/html/details-remove-summary-3-and-click-expected.txt:
• platform/glib/fast/html/details-remove-summary-3-expected.txt:
• platform/glib/fast/html/details-remove-summary-4-and-click-expected.txt:
• platform/glib/fast/html/details-remove-summary-4-expected.txt:
• platform/glib/fast/html/details-remove-summary-5-and-click-expected.txt:
• platform/glib/fast/html/details-remove-summary-5-expected.txt:
• platform/glib/fast/html/details-remove-summary-6-and-click-expected.txt:
• platform/glib/fast/html/details-remove-summary-6-expected.txt:
• platform/glib/fast/html/details-remove-summary-child-1-expected.txt:
• platform/glib/fast/html/details-remove-summary-child-2-expected.txt:
• platform/glib/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
• platform/glib/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
• platform/gtk/fast/html/details-no-summary4-expected.txt:
• platform/gtk/fast/html/details-open-javascript-expected.txt:
• platform/gtk/fast/html/details-open2-expected.txt:
• platform/gtk/fast/html/details-open4-expected.txt:
• platform/gtk/fast/html/details-replace-summary-child-expected.txt:
• platform/gtk/fast/html/details-replace-text-expected.txt:
• platform/gtk/fast/html/details-writing-mode-expected.txt:
• platform/gtk/fast/html/details-writing-mode-mixed-expected.txt:
• platform/gtk/fast/writing-mode/fieldsets-expected.txt:
• platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:

5:27 PM Changeset in webkit [262133] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Use an Optional<> for LayerFragment::boundingBox
​https://bugs.webkit.org/show_bug.cgi?id=212358

Reviewed by Zalan Bujtas.

Replace a bool + LayoutRect with Optional<LayoutRect>.

• rendering/LayerFragment.h:

(WebCore::LayerFragment::setRects):
(WebCore::LayerFragment::moveBy):
(WebCore::LayerFragment::intersect):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayer.h:

5:26 PM Changeset in webkit [262132] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Make isTableRow() an inline function
​https://bugs.webkit.org/show_bug.cgi?id=212360

Reviewed by Darin Adler.

isTableCell() is a virtual function that's called in some hot code paths, like RenderLayer::localBoundingBox(),
so make it inline by using a spare bit on RenderObject.

• rendering/RenderObject.h:

(WebCore::RenderObject::isTableCaption const):
(WebCore::RenderObject::isTableRow const):
(WebCore::RenderObject::setIsTableRow):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):

• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::RenderTableRow):

• rendering/RenderTableRow.h:

5:03 PM Changeset in webkit [262131] by commit-queue@webkit.org

• 7 edits in trunk/Source

Expose more network metrics to WebCoreNSURLSession
​https://bugs.webkit.org/show_bug.cgi?id=212359
<rdar://problem/62909440>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-05-25
Reviewed by Darin Adler.

Source/WebCore:

• platform/network/NetworkLoadMetrics.h:

(WebCore::NetworkLoadMetrics::isolatedCopy const):
(WebCore::NetworkLoadMetrics::operator== const):
(WebCore::NetworkLoadMetrics::encode const):
(WebCore::NetworkLoadMetrics::decode):

• platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionTaskTransactionMetrics networkProtocolName]):
(-[WebCoreNSURLSessionTaskTransactionMetrics isReusedConnection]):
(-[WebCoreNSURLSessionTaskTransactionMetrics cellular]):
(-[WebCoreNSURLSessionTaskTransactionMetrics expensive]):
(-[WebCoreNSURLSessionTaskTransactionMetrics constrained]):
(-[WebCoreNSURLSessionTaskTransactionMetrics multipath]):

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

Source/WTF:

• wtf/PlatformHave.h:

1:51 PM WPTExportProcess edited by clopez@igalia.com

(diff)

1:39 PM Changeset in webkit [262130] by Oriol Brufau

• 10 edits in trunk

[css-grid] Prevent grid-template-rows from serializing adjacent <line-names>
​https://bugs.webkit.org/show_bug.cgi?id=212345

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Update test expectations.

• web-platform-tests/css/css-grid/parsing/grid-shorthand-expected.txt:
• web-platform-tests/css/css-grid/parsing/grid-shorthand-valid-expected.txt:
• web-platform-tests/css/css-grid/parsing/grid-template-shorthand-expected.txt:
• web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt:

Source/WebCore:

The parser for the grid-template shorthand has this code:

Persists between loop iterations so we can use the same value for
consecutive <line-names> values
RefPtr<CSSGridLineNamesValue> lineNames;

However, this wasn't working because of a lineNames.releaseNonNull() at
the end of the loop. So each iteration started with a null lineNames, and
consecutive <line-names> values were not merged together.

Tests: fast/css-grid-layout/grid-template-shorthand-get-set.html

imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand-valid.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid.html

• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeGridTemplateRowsAndAreasAndColumns):

LayoutTests:

Update test expectations.

• fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt:
• fast/css-grid-layout/grid-template-shorthand-get-set.html:

1:35 PM WPTExportProcess created by clopez@igalia.com

12:25 PM Changeset in webkit [262129] by weinig@apple.com

• 3 edits in trunk/Source/WebCore

Extended Color Cleanup: Assert !isExtended() in Color::asSimpleColor()...finally
​https://bugs.webkit.org/show_bug.cgi?id=212357

Reviewed by Simon Fraser.

Reap the reward of the cleanup, and add the ASSERT(!isExtended()) to Color::asSimpleColor()
as was the original goal of this effort. Only tree non-checked places remained and were
trivial to add isExtended() checks for.

• platform/graphics/Color.cpp:

(WebCore::Color::nameForRenderTreeAsText const):
Use ExtenedColor::cssText() for the RenderTree representation. It is stable
and as good as any, no need to re-invent the wheel here.

(WebCore::Color::light const):
(WebCore::Color::dark const):
Add isExtended() checks before doing white/black checks,

• platform/graphics/Color.h:

(WebCore::Color::asSimpleColor const):
Add ASSERT.

11:30 AM Changeset in webkit [262128] by weinig@apple.com

• 34 edits in trunk

Extended Color Cleanup: Use the name SimpleColor consistently
​https://bugs.webkit.org/show_bug.cgi?id=212337

Reviewed by Anders Carlsson.
Source/WebCore:

• Removes RGBA32 type alias, updating all remaining users of it.
• Renames functions that take/return SimpleColor to use the name SimpleColor rather than RGB (e.g. makeRGBA -> makeSimpleColor)
• Moves hex color parsing from Color to SimpleColor, as that is the type it returns. Also took the opportunity to make it return an Optional<SimpleColor> instead of using a bool/out parameter.
• Move Color::compositionFill to editing/CompositionHighlight.h It makes no real sense to keep it in Color.h
• Replaces rgb() function in Color with asSimpleColor() for symmetry with asExtended().
• Replaced std::max(a, std::min(value, b)) with std::clamp(value, a, b) for clarity.

• css/parser/CSSParserFastPaths.cpp:

(WebCore::fastParseColorInternal):
(WebCore::CSSParserFastPaths::parseColor):

• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
(WebCore::CSSPropertyParserHelpers::parseHexColor):

• editing/CompositionHighlight.h:
• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):

• html/ColorInputType.cpp:

(WebCore::parseSimpleColorValue):

• html/HTMLElement.cpp:

(WebCore::parseColorStringWithCrazyLegacyRules):

• platform/adwaita/ScrollbarThemeAdwaita.cpp:
• platform/adwaita/ThemeAdwaita.cpp:

(WebCore::ThemeAdwaita::activeSelectionForegroundColor const):
(WebCore::ThemeAdwaita::activeSelectionBackgroundColor const):
(WebCore::ThemeAdwaita::inactiveSelectionForegroundColor const):

• platform/graphics/Color.cpp:

(WebCore::differenceSquared):
(WebCore::Color::Color):
(WebCore::Color::operator=):
(WebCore::Color::serialized const):
(WebCore::Color::cssText const):
(WebCore::Color::nameForRenderTreeAsText const):
(WebCore::Color::light const):
(WebCore::Color::dark const):
(WebCore::Color::blend const):
(WebCore::Color::blendWithWhite const):
(WebCore::Color::colorWithAlpha const):
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const):
(WebCore::Color::invertedColorWithAlpha const):
(WebCore::Color::colorSpaceAndComponents const):
(WebCore::Color::toSRGBASimpleColorLossy const):
(WebCore::blend):
(WebCore::Color::tagAsValid):
(WebCore::parseHexColorInternal): Deleted.
(WebCore::Color::parseHexColor): Deleted.
(WebCore::Color::asExtended const): Deleted.

• platform/graphics/Color.h:

(WebCore::Color::Color):
(WebCore::Color::isHashTableDeletedValue const):
(WebCore::Color::isValid const):
(WebCore::Color::isOpaque const):
(WebCore::Color::isVisible const):
(WebCore::Color::alpha const):
(WebCore::Color::alphaAsFloat const):
(WebCore::Color::isSemantic const):
(WebCore::Color::isExtended const):
(WebCore::Color::setIsSemantic):
(WebCore::operator==):
(WebCore::equalIgnoringSemanticColor):
(WebCore::Color::hash const):
(WebCore::Color::asExtended const):
(WebCore::Color::asSimpleColor const):
(WebCore::Color::setSimpleColor):
(WebCore::Color::isBlackColor):
(WebCore::Color::isWhiteColor):
(WebCore::Color::encode const):
(WebCore::Color::decode):
(WebCore::Color::setRGB): Deleted.
(WebCore::Color::rgb const): Deleted.

• platform/graphics/ColorUtilities.h:

(WebCore::clampedColorComponent):

• platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::blendPixel):
(WebCore::ImageBackingStore::pixelValue const):

• platform/graphics/SimpleColor.cpp:

(WebCore::makePremultipliedSimpleColor):
(WebCore::makeUnpremultipliedSimpleColor):
(WebCore::makeSimpleColorFromFloats):
(WebCore::makeSimpleColorFromHSLA):
(WebCore::makeSimpleColorFromCMYKA):
(WebCore::parseHexColorInternal):
(WebCore::SimpleColor::parseHexColor):
(WebCore::makePremultipliedRGBA): Deleted.
(WebCore::makeUnPremultipliedRGBA): Deleted.
(WebCore::makeRGBA32FromFloats): Deleted.
(WebCore::makeRGBAFromHSLA): Deleted.
(WebCore::makeRGBAFromCMYKA): Deleted.

• platform/graphics/SimpleColor.h:

(WebCore::roundAndClampColorChannel):
(WebCore::colorFloatToSimpleColorByte):
(WebCore::makeSimpleColor):
(WebCore::colorFloatToRGBAByte): Deleted.
(WebCore::makeRGB): Deleted.
(WebCore::makeRGBA): Deleted.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::makeSimpleColorFromARGBCFArray):
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes):
(WebCore::makeRGBA32FromARGBCFArray): Deleted.

• platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp:

(WebCore::ImageBufferCairoImageSurfaceBackend::platformTransformColorSpace):

• platform/graphics/cairo/NativeImageCairo.cpp:

(WebCore::nativeImageSinglePixelSolidColor):

• platform/graphics/cg/ColorCG.cpp:

(WebCore::makeSimpleColorFromCGColor):
(WebCore::Color::Color):
(WebCore::cachedCGColor):
(WebCore::makeRGBAFromCGColor): Deleted.

• platform/graphics/gtk/ColorGtk.cpp:

(WebCore::Color::Color):

• platform/graphics/mac/ColorMac.mm:

(WebCore::makeSimpleColorFromNSColor):
(WebCore::colorFromNSColor):
(WebCore::semanticColorFromNSColor):
(WebCore::makeRGBAFromNSColor): Deleted.

• platform/graphics/win/ColorDirect2D.cpp:

(WebCore::Color::Color):

• platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawDotsForDocumentMarker):

• platform/graphics/win/PlatformContextDirect2D.cpp:

(WebCore::PlatformContextDirect2D::brushWithColor):

• platform/ios/ColorIOS.mm:

(WebCore::colorFromUIColor):

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionBackground):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintResizer):

• rendering/RenderLayerBacking.cpp:

(WebCore::patternForTouchAction):
(WebCore::patternForEventListenerRegionType):

• rendering/RenderThemeAdwaita.cpp:
• rendering/RenderThemeMac.mm:

(WebCore::menuBackgroundColor):

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm:

(compositionHighlights):
Update for new name of CompositionHighlight::defaultCompositionFillColor.

Tools:

• TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):
Update test for rename of makeRGBAFromHSLA to makeSimpleColorFromHSLA.

9:41 AM Changeset in webkit [262127] by Alan Bujtas

• 230 edits
  1 copy
  3 adds in trunk

[Subpixel layout] Bad scrolling on mercurynews.com article
​https://bugs.webkit.org/show_bug.cgi?id=201038
<rdar://problem/28489812>

Reviewed by Dean Jackson.

Source/WebCore:

The scrolling is caused by the mismatching subpixel handling between block and inline content.
Inline content (and in this particular case ascent/descent handling) is still integral based while block content supports fractional pixel values.
When the (inline)line height relies on the (block)inline-block height, we need to make sure that the computed line height encloses the inline-block.
This patch changes the rounding behavior of computed the line height from floor to round.

Test: fast/inline/hidpi-inline-block-is-subpixel-while-line-is-not.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::baselinePosition const):

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox const):

LayoutTests:

• fast/inline/hidpi-inline-block-is-subpixel-while-line-is-not-expected.html: Added.
• fast/inline/hidpi-inline-block-is-subpixel-while-line-is-not.html: Added.
• platform/ios/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
• platform/ios/css3/flexbox/flexbox-baseline-expected.txt:
• platform/ios/editing/selection/select-across-readonly-input-1-expected.txt: Added.
• platform/ios/editing/selection/select-across-readonly-input-2-expected.txt: Added.
• platform/ios/editing/selection/select-across-readonly-input-3-expected.txt: Added.
• platform/ios/editing/selection/select-across-readonly-input-4-expected.txt: Added.
• platform/ios/editing/selection/select-across-readonly-input-5-expected.txt: Added.
• platform/ios/fast/borders/fieldsetBorderRadius-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/fieldsetBorderRadius-expected.txt.
• platform/ios/fast/forms/select-item-background-clip-expected.txt:
• platform/ios/fast/gradients/list-item-gradient-expected.txt:
• platform/ios/fast/html/details-add-child-1-expected.txt:
• platform/ios/fast/html/details-add-child-2-expected.txt:
• platform/ios/fast/html/details-add-details-child-1-expected.txt:
• platform/ios/fast/html/details-add-details-child-2-expected.txt:
• platform/ios/fast/html/details-add-summary-1-and-click-expected.txt:
• platform/ios/fast/html/details-add-summary-1-expected.txt:
• platform/ios/fast/html/details-add-summary-10-and-click-expected.txt:
• platform/ios/fast/html/details-add-summary-10-expected.txt:
• platform/ios/fast/html/details-add-summary-2-and-click-expected.txt:
• platform/ios/fast/html/details-add-summary-2-expected.txt:
• platform/ios/fast/html/details-add-summary-3-and-click-expected.txt:
• platform/ios/fast/html/details-add-summary-3-expected.txt:
• platform/ios/fast/html/details-add-summary-4-and-click-expected.txt:
• platform/ios/fast/html/details-add-summary-4-expected.txt:
• platform/ios/fast/html/details-add-summary-5-and-click-expected.txt:
• platform/ios/fast/html/details-add-summary-5-expected.txt:
• platform/ios/fast/html/details-add-summary-6-and-click-expected.txt:
• platform/ios/fast/html/details-add-summary-6-expected.txt:
• platform/ios/fast/html/details-add-summary-7-and-click-expected.txt:
• platform/ios/fast/html/details-add-summary-7-expected.txt:
• platform/ios/fast/html/details-add-summary-8-and-click-expected.txt:
• platform/ios/fast/html/details-add-summary-8-expected.txt:
• platform/ios/fast/html/details-add-summary-9-and-click-expected.txt:
• platform/ios/fast/html/details-add-summary-9-expected.txt:
• platform/ios/fast/html/details-add-summary-child-1-expected.txt:
• platform/ios/fast/html/details-add-summary-child-2-expected.txt:
• platform/ios/fast/html/details-marker-style-expected.txt:
• platform/ios/fast/html/details-marker-style-mixed-expected.txt:
• platform/ios/fast/html/details-nested-1-expected.txt:
• platform/ios/fast/html/details-nested-2-expected.txt:
• platform/ios/fast/html/details-no-summary1-expected.txt:
• platform/ios/fast/html/details-no-summary2-expected.txt:
• platform/ios/fast/html/details-no-summary3-expected.txt:
• platform/ios/fast/html/details-no-summary4-expected.txt:
• platform/ios/fast/html/details-open-javascript-expected.txt:
• platform/ios/fast/html/details-open1-expected.txt:
• platform/ios/fast/html/details-open2-expected.txt:
• platform/ios/fast/html/details-open3-expected.txt:
• platform/ios/fast/html/details-open4-expected.txt:
• platform/ios/fast/html/details-open5-expected.txt:
• platform/ios/fast/html/details-open6-expected.txt:
• platform/ios/fast/html/details-position-expected.txt:
• platform/ios/fast/html/details-remove-child-1-expected.txt:
• platform/ios/fast/html/details-remove-child-2-expected.txt:
• platform/ios/fast/html/details-remove-summary-1-and-click-expected.txt:
• platform/ios/fast/html/details-remove-summary-1-expected.txt:
• platform/ios/fast/html/details-remove-summary-2-and-click-expected.txt:
• platform/ios/fast/html/details-remove-summary-2-expected.txt:
• platform/ios/fast/html/details-remove-summary-3-and-click-expected.txt:
• platform/ios/fast/html/details-remove-summary-3-expected.txt:
• platform/ios/fast/html/details-remove-summary-4-and-click-expected.txt:
• platform/ios/fast/html/details-remove-summary-4-expected.txt:
• platform/ios/fast/html/details-remove-summary-5-and-click-expected.txt:
• platform/ios/fast/html/details-remove-summary-5-expected.txt:
• platform/ios/fast/html/details-remove-summary-6-and-click-expected.txt:
• platform/ios/fast/html/details-remove-summary-6-expected.txt:
• platform/ios/fast/html/details-remove-summary-child-1-expected.txt:
• platform/ios/fast/html/details-remove-summary-child-2-expected.txt:
• platform/ios/fast/html/details-replace-summary-child-expected.txt:
• platform/ios/fast/html/details-replace-text-expected.txt:
• platform/ios/fast/html/details-writing-mode-expected.txt:
• platform/ios/fast/html/details-writing-mode-mixed-expected.txt:
• platform/ios/fast/writing-mode/fieldsets-expected.txt:
• platform/ios/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
• platform/ios/mathml/presentation/mo-stretch-expected.txt:
• platform/ios/mathml/presentation/roots-expected.txt:
• platform/mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
• platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
• platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
• platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt:
• platform/mac/fast/forms/basic-buttons-expected.txt:
• platform/mac/fast/html/details-add-child-1-expected.txt:
• platform/mac/fast/html/details-add-child-2-expected.txt:
• platform/mac/fast/html/details-add-details-child-1-expected.txt:
• platform/mac/fast/html/details-add-details-child-2-expected.txt:
• platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
• platform/mac/fast/html/details-add-summary-1-expected.txt:
• platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
• platform/mac/fast/html/details-add-summary-10-expected.txt:
• platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
• platform/mac/fast/html/details-add-summary-2-expected.txt:
• platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
• platform/mac/fast/html/details-add-summary-3-expected.txt:
• platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
• platform/mac/fast/html/details-add-summary-4-expected.txt:
• platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
• platform/mac/fast/html/details-add-summary-5-expected.txt:
• platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
• platform/mac/fast/html/details-add-summary-6-expected.txt:
• platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
• platform/mac/fast/html/details-add-summary-7-expected.txt:
• platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
• platform/mac/fast/html/details-add-summary-8-expected.txt:
• platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
• platform/mac/fast/html/details-add-summary-9-expected.txt:
• platform/mac/fast/html/details-add-summary-child-1-expected.txt:
• platform/mac/fast/html/details-add-summary-child-2-expected.txt:
• platform/mac/fast/html/details-marker-style-expected.txt:
• platform/mac/fast/html/details-nested-1-expected.txt:
• platform/mac/fast/html/details-nested-2-expected.txt:
• platform/mac/fast/html/details-no-summary1-expected.txt:
• platform/mac/fast/html/details-no-summary2-expected.txt:
• platform/mac/fast/html/details-no-summary3-expected.txt:
• platform/mac/fast/html/details-no-summary4-expected.txt:
• platform/mac/fast/html/details-open-javascript-expected.txt:
• platform/mac/fast/html/details-open1-expected.txt:
• platform/mac/fast/html/details-open2-expected.txt:
• platform/mac/fast/html/details-open3-expected.txt:
• platform/mac/fast/html/details-open4-expected.txt:
• platform/mac/fast/html/details-open5-expected.txt:
• platform/mac/fast/html/details-open6-expected.txt:
• platform/mac/fast/html/details-position-expected.txt:
• platform/mac/fast/html/details-remove-child-1-expected.txt:
• platform/mac/fast/html/details-remove-child-2-expected.txt:
• platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
• platform/mac/fast/html/details-remove-summary-1-expected.txt:
• platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
• platform/mac/fast/html/details-remove-summary-2-expected.txt:
• platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
• platform/mac/fast/html/details-remove-summary-3-expected.txt:
• platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
• platform/mac/fast/html/details-remove-summary-4-expected.txt:
• platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
• platform/mac/fast/html/details-remove-summary-5-expected.txt:
• platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
• platform/mac/fast/html/details-remove-summary-6-expected.txt:
• platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
• platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
• platform/mac/fast/html/details-replace-summary-child-expected.txt:
• platform/mac/fast/html/details-replace-text-expected.txt:
• platform/mac/fast/html/details-writing-mode-expected.txt:
• platform/mac/fast/writing-mode/fieldsets-expected.txt:
• platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
• platform/mac/mathml/presentation/mo-stretch-expected.txt:
• platform/mac/mathml/presentation/roots-expected.txt:
• platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
• platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
• platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
• platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
• platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:

9:03 AM Changeset in webkit [262126] by Diego Pino Garcia

• 5 edits
  1 move
  1 delete in trunk/LayoutTests

[WPE] Gardening, update test expectations after r262120
​https://bugs.webkit.org/show_bug.cgi?id=212353

Unreviewed gardening.

• platform/glib/TestExpectations:
• platform/glib/fast/canvas/webgl/webgl-compressed-texture-astc-expected.txt: Renamed from LayoutTests/platform/gtk/fast/canvas/webgl/webgl-compressed-texture-astc-expected.txt.
• platform/gtk/TestExpectations:
• platform/gtk/fast/canvas/webgl/readPixels-float-expected.txt: Removed.
• platform/wpe/TestExpectations:
• platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt: Emit baseline after r260075.

7:47 AM Changeset in webkit [262125] by commit-queue@webkit.org

• 4 edits in trunk

Use child text content when determining whether to bail early in running a script
​https://bugs.webkit.org/show_bug.cgi?id=182695

Patch by Rob Buis <​rbuis@igalia.com> on 2020-05-25
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update improved test results.

• web-platform-tests/html/semantics/scripting-1/the-script-element/emptyish-script-elements-expected.txt:

Source/WebCore:

Check that the text content is not empty instead of just checking
for the first child [1].

Behavior matches Chrome and Firefox.

[1] ​https://html.spec.whatwg.org/#prepare-a-script step 5 and 6

Test: web-platform-tests/html/semantics/scripting-1/the-script-element/emptyish-script-elements.html

• dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

7:18 AM Changeset in webkit [262124] by svillar@igalia.com

• 7 edits in trunk

[css-flex] Allow indefinite size flex items to be definite wrt resolving percentages inside them
​https://bugs.webkit.org/show_bug.cgi?id=212264

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-flexbox/percentage-heights-003-expected.txt: There were 3 subtests

marked as failures. All of them work fine now.

Source/WebCore:

Implement ​https://github.com/w3c/csswg-drafts/commit/5b5db39d21f3658ae2f4d7992daaf822aca178d8 which modified
the way percentages were resolved in flexible items with indefinite sizes. From now on we can pretend that
they're really definite.

This allows us to mark 3 tests which were testing percentages in flex items as correct.

Based on Blink's crrev.com/1247184 by <​cbiesinger@chromium.org>

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution): Do only check flex container main size
definiteness when computing the main size for percentage resolution, no need to check flex basis at all.

LayoutTests:

• css3/flexbox/definite-main-size-expected.txt: Updated expectation.
• css3/flexbox/definite-main-size.html: Updated comment.

6:58 AM Changeset in webkit [262123] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK] Gardening, update test expectations after r262060
​https://bugs.webkit.org/show_bug.cgi?id=212346

Unreviewed gardening.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

6:34 AM Changeset in webkit [262122] by youenn@apple.com

• 3 edits in trunk/Source/WebCore

AVVideoCaptureSource should notify of video samples in a background thread
​https://bugs.webkit.org/show_bug.cgi?id=212072

Reviewed by Eric Carlson.

Do not hop to the main thread to send samples.
Instead, directly call the observer callback.
Manually tested.

• platform/mediastream/mac/AVVideoCaptureSource.h:
• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):

4:58 AM Changeset in webkit [262121] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak][GStreamer] compilation fails when GST_BUILD_PATH is defined
​https://bugs.webkit.org/show_bug.cgi?id=212343

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2020-05-25
Reviewed by Philippe Normand.

Flatpak's command has to be expressed before gst-env declaration.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

4:31 AM Changeset in webkit [262120] by Adrian Perez de Castro

• 3 edits in trunk/Source/WebCore

Non-unified build fixes, late May 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=212342

Unreviewed build fix.

No new tests needed.

• loader/ImageLoader.h: Add missing inclusion of Element.h and remove forward declaration.
• page/PageConfiguration.h: Add missing inclusion of ShouldRelaxThirdPartyCookieBlocking.h

3:10 AM Changeset in webkit [262119] by Adrian Perez de Castro

• 4 edits in trunk

[WPE][WKTR] Fix typo in EventSenderProxyWPE
​https://bugs.webkit.org/show_bug.cgi?id=212340

Reviewed by Carlos Garcia Campos.

Tools:

• WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:

(WTR::wpeKeySymForKeyRef): Fix typo rightArror -> rightArrow.

LayoutTests:

• platform/wpe/TestExpectations: fast/events/keydown-numpad-keys.html is now passing.

1:37 AM Changeset in webkit [262118] by Diego Pino Garcia

• 2 edits
  4 adds in trunk/LayoutTests

[GTK][WPE] Gardening, emit baselines for update-the-source-set.html after r261929.
​https://bugs.webkit.org/show_bug.cgi?id=212216

Unreviewed gardening.

• platform/glib/TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt: Added.
• platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt: Added.

1:33 AM Changeset in webkit [262117] by commit-queue@webkit.org

• 3 edits in trunk/Tools

REGRESSION(r262057): [Flatpak SDK] sccache-dist server no longer starting
​https://bugs.webkit.org/show_bug.cgi?id=212326

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-05-25
Reviewed by Žan Doberšek.

A few mount points were missing in the sandbox created by
flatpak run preventing the sccache-dist server to start and keep running.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

• flatpak/webkit-bwrap:

1:31 AM Changeset in webkit [262116] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak SDK] Fixup icecc support
​https://bugs.webkit.org/show_bug.cgi?id=212301

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-05-25
Reviewed by Žan Doberšek.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): Allow homedir access from the
sandbox, this is needed because the icecc toolchains paths refer
to the host environment, not the sandbox.
(WebkitFlatpak.pack_toolchain): Fix byte-string formatting issue, happening in Python3.

1:16 AM Changeset in webkit [262115] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK4] SDK contains too old GTK4
​https://bugs.webkit.org/show_bug.cgi?id=212334

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-05-25
Reviewed by Adrian Perez de Castro.

• buildstream/elements/sdk/gtk.bst: Update GTK4 to 3.98.4.

12:52 AM Changeset in webkit [262114] by youenn@apple.com

• 5 edits in trunk/Source/WebCore

MediaPlayerPrivateMediaStreamAVFObjC::m_activeVideoTrack should be a VideoTrackPrivateMediaStream
​https://bugs.webkit.org/show_bug.cgi?id=212129

Reviewed by Eric Carlson.

Instead of looking in the map when wanting to get the VideoTrackPrivateMediaStream corresponding to the active video track,
store directly the VideoTrackPrivateMediaStream as the active video track and use streamTrack() to get the corresponding MediaStreamTrack.
Small refactoring to use more Ref<>.
Covered by existing tests.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::videoSampleAvailable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::sampleBufferDisplayLayerStatusDidChange):
(WebCore::updateTracksOfType):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::checkSelectedVideoTrack):

• platform/mediastream/AudioTrackPrivateMediaStream.h:
• platform/mediastream/VideoTrackPrivateMediaStream.h:

May 24, 2020:

11:28 PM Changeset in webkit [262113] by youenn@apple.com

• 3 edits in trunk/Source/WebCore

Do not allocate a WebAudioBufferList in the AudioContext rendering thread
​https://bugs.webkit.org/show_bug.cgi?id=212132

Reviewed by Eric Carlson.

Instead of allocating the buffer in the rendering thread, we do that in the audio sample producer thread.
Also, we do it only once versus one for each rendering call previously.
Covered by existing tests.

• platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h:
• platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):
(WebCore::WebAudioSourceProviderAVFObjC::unprepare):

11:25 PM Changeset in webkit [262112] by commit-queue@webkit.org

• 1 edit
  1 delete in trunk/Source/WebKit

Remove NetworkProcess/FileAPI
​https://bugs.webkit.org/show_bug.cgi?id=212335

Patch by Rob Buis <​rbuis@igalia.com> on 2020-05-24
Reviewed by Sam Weinig.

Remove NetworkProcess/FileAPI, the only file it contains is unused.
It seems this could have been removed in r248593.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: Removed.

12:29 PM Changeset in webkit [262111] by Wenson Hsieh

• 3 edits in trunk/Source/WebCore

Add some missing includes due to unified sources
​https://bugs.webkit.org/show_bug.cgi?id=212306

Reviewed by Anders Carlsson.

• Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp: Include EnterPictureInPictureEvent.h.

• platform/PictureInPictureObserver.h: Include WeakPtr and forward declare the IntSize class.

12:13 PM Changeset in webkit [262110] by weinig@apple.com

• 6 edits
  2 adds in trunk/Source/WebCore

Extended Color Cleanup: Move SimpleColor into its own files
​https://bugs.webkit.org/show_bug.cgi?id=212309

Reviewed by Simon Fraser.

Move SimpleColor into its own files. It's about time.

• Headers.cmake:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/Color.cpp:

(WebCore::premultipliedChannel): Deleted.
(WebCore::unpremultipliedChannel): Deleted.
(WebCore::makePremultipliedRGBA): Deleted.
(WebCore::makeUnPremultipliedRGBA): Deleted.
(WebCore::colorFloatToRGBAByte): Deleted.
(WebCore::makeRGBA32FromFloats): Deleted.
(WebCore::makeRGBAFromHSLA): Deleted.
(WebCore::makeRGBAFromCMYKA): Deleted.
(WebCore::SimpleColor::serializationForHTML const): Deleted.
(WebCore::decimalDigit): Deleted.
(WebCore::fractionDigitsForFractionalAlphaValue): Deleted.
(WebCore::SimpleColor::serializationForCSS const): Deleted.
(WebCore::RGBA32::serializationForRenderTreeAsText const): Deleted.

• platform/graphics/Color.h:

(WebCore::SimpleColor::SimpleColor): Deleted.
(WebCore::SimpleColor::value const): Deleted.
(WebCore::SimpleColor::redComponent const): Deleted.
(WebCore::SimpleColor::greenComponent const): Deleted.
(WebCore::SimpleColor::blueComponent const): Deleted.
(WebCore::SimpleColor::alphaComponent const): Deleted.
(WebCore::SimpleColor::alphaComponentAsFloat const): Deleted.
(WebCore::SimpleColor::isOpaque const): Deleted.
(WebCore::SimpleColor::isVisible const): Deleted.
(WebCore::SimpleColor::colorWithAlpha const): Deleted.
(WebCore::SimpleColor::get const): Deleted.
(WebCore::roundAndClampColorChannel): Deleted.
(WebCore::fastMultiplyBy255): Deleted.
(WebCore::fastDivideBy255): Deleted.
(WebCore::makeRGB): Deleted.
(WebCore::makeRGBA): Deleted.

• platform/graphics/SimpleColor.cpp: Copied from platform/graphics/Color.cpp.

(WebCore::SimpleColor::serializationForRenderTreeAsText const):
(): Deleted.
(WebCore::colorFloatToRGBAByte): Deleted.
(WebCore::parseHexColorInternal): Deleted.
(WebCore::Color::parseHexColor): Deleted.
(WebCore::differenceSquared): Deleted.
(WebCore::findNamedColor): Deleted.
(WebCore::Color::Color): Deleted.
(WebCore::Color::operator=): Deleted.
(WebCore::Color::serialized const): Deleted.
(WebCore::Color::cssText const): Deleted.
(WebCore::RGBA32::serializationForRenderTreeAsText const): Deleted.
(WebCore::Color::nameForRenderTreeAsText const): Deleted.
(WebCore::Color::light const): Deleted.
(WebCore::Color::dark const): Deleted.
(WebCore::Color::isDark const): Deleted.
(WebCore::Color::lightness const): Deleted.
(WebCore::blendComponent): Deleted.
(WebCore::Color::blend const): Deleted.
(WebCore::Color::blendWithWhite const): Deleted.
(WebCore::Color::colorWithAlphaMultipliedBy const): Deleted.
(WebCore::Color::colorWithAlphaMultipliedByUsingAlternativeRounding const): Deleted.
(WebCore::Color::colorWithAlpha const): Deleted.
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const): Deleted.
(WebCore::Color::colorSpaceAndComponents const): Deleted.
(WebCore::Color::toSRGBASimpleColorLossy const): Deleted.
(WebCore::Color::toSRGBAComponentsLossy const): Deleted.
(WebCore::extendedColorsEqual): Deleted.
(WebCore::blend): Deleted.
(WebCore::blendWithoutPremultiply): Deleted.
(WebCore::Color::tagAsValid): Deleted.
(WebCore::Color::asExtended const): Deleted.
(WebCore::operator<<): Deleted.

• platform/graphics/SimpleColor.h: Copied from platform/graphics/Color.h.

(WebCore::SimpleColor::alphaComponentAsFloat const):
(WebCore::SimpleColor::colorWithAlpha const):
(WebCore::SimpleColor::get const):
(WebCore::colorFloatToRGBAByte):
(WebCore::Color::Color): Deleted.
(WebCore::Color::isHashTableDeletedValue const): Deleted.
(WebCore::Color::~Color): Deleted.
(WebCore::Color::isValid const): Deleted.
(WebCore::Color::isOpaque const): Deleted.
(WebCore::Color::isVisible const): Deleted.
(WebCore::Color::red const): Deleted.
(WebCore::Color::green const): Deleted.
(WebCore::Color::blue const): Deleted.
(WebCore::Color::alpha const): Deleted.
(WebCore::Color::alphaAsFloat const): Deleted.
(WebCore::Color::opaqueColor const): Deleted.
(WebCore::Color::isSemantic const): Deleted.
(WebCore::Color::isExtended const): Deleted.
(WebCore::Color::setRGB): Deleted.
(WebCore::Color::setIsSemantic): Deleted.
(WebCore::equalIgnoringSemanticColor): Deleted.
(WebCore::Color::hash const): Deleted.
(WebCore::Color::colorWithAlphaMultipliedByUsingAlternativeRounding const): Deleted.
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const): Deleted.
(WebCore::Color::rgb const): Deleted.
(WebCore::Color::isBlackColor): Deleted.
(WebCore::Color::isWhiteColor): Deleted.
(WebCore::Color::encode const): Deleted.
(WebCore::Color::decode): Deleted.

10:25 AM WebKitEmacsTips edited by Philippe Normand

(diff)

10:15 AM Changeset in webkit [262109] by Alan Bujtas

• 4 edits
  2 adds in trunk

[LFC][TFC] Ignore section borders even when border collapse is off.
​https://bugs.webkit.org/show_bug.cgi?id=212336

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-thead-border-ignore.html

• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):

LayoutTests:

• fast/layoutformattingcontext/table-simple-thead-border-ignore-expected.html: Added.
• fast/layoutformattingcontext/table-simple-thead-border-ignore.html: Added.

8:53 AM Changeset in webkit [262108] by weinig@apple.com

• 28 edits in trunk

Extended Color Cleanup: Stop allowing direct access to the underlying SimpleColor (it is almost always incorrect with respect to extended colors)
​https://bugs.webkit.org/show_bug.cgi?id=212184

Reviewed by Dean Jackson.

Source/WebCore:

• Makes Color::rgb() private, removing a class of extended color bugs from users of the Color class. To get the equivilent functionality, users of the class must now use toSRGBASimpleColorLossy() which does actually does the conversion to sRGB if necessary and makes it clear to the caller that precision is being lost.
• Removes Color::red()/green()/blue() entirely. They were just calling down to Color::rgb(), and going forward, it won't make sense to think about rgb components of Colors in general, since some extended color spaces don't deal in them (e.g. Lab) Color::alpha() was kept (and fixed to work even with ExtendedColor) since all ExtendedColors do need to have alpha.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::colorValue const):
Use toSRGBASimpleColorLossy() to get access to color components.

• accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getAttributeSetForAccessibilityObject):
Use toSRGBASimpleColorLossy() to get access to color components.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::colorValue const):
Use toSRGBASimpleColorLossy() to get access to color components.

• css/DeprecatedCSSOMRGBColor.h:

Use toSRGBASimpleColorLossy() to get access to color components.

• page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionsWindowCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionsBackgroundCSS const):
(WebCore::CaptionUserPreferencesMediaAF::captionsTextColor const):
User Color::colorWithAlpha() to avoid the need to muck with components directly.

• platform/graphics/Color.cpp:

(WebCore::differenceSquared):
Use rgb() directly, which is ok, since this is explicitly checking isExtended().
This code is still wrong (there is a FIXME) as it assumes the two colors are in
the same color space.

(WebCore::Color::Color):
Add constructor which takes an ExtendedColor to allow functions like
Color::invertedColorWithAlpha to delegate their functionality to ExtendedColor.

(WebCore::Color::light const):
Use new SimpleColor::colorWithAlpha() to avoid hardcoding constants here.

(WebCore::Color::blend const):
(WebCore::Color::blendWithWhite const):
Use toSRGBASimpleColorLossy() to get access to color components. These
are still not ideal implementations, as they don't preserve extended colors
as well as they could, but now they don't return bogus values for extended
colors. Minor cleanup bringing constants and lambda inside the function they
are used in.

(WebCore::Color::colorWithAlpha const):
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const):
Minor cleanups to use a more consistent style and make use of the new
SimpleColor::colorWithAlpha.

(WebCore::Color::invertedColorWithAlpha const):
Added. Used to avoid direct component usage in line box code.

(WebCore::Color::semanticColor const):
Added. Hopefully temporary. Used by RenderThemeIOS.mm to convert
a Color from a map into a Color with the semantic bit set. This
should not be necessary as every color in the map should already
have it set, but to avoid uncessary possible behavior changes this
preserves that functionality until it can be researched further.
Fixing coders to preserve the semantic bit may be required to
elliminate the need.

(WebCore::Color::colorSpaceAndComponents const):
Use rgb() rather than the individual components which have been removed.

• platform/graphics/Color.h:

(WebCore::SimpleColor::alphaComponentAsFloat const):
Added. Needed by DeprecatedCSSOMRGBColor and useful to Color.

(WebCore::SimpleColor::colorWithAlpha const):
Useful to simplify Color::colorWithAlpha implementations and
in Color::dark().

(WebCore::SimpleColor::get const):
Added tuple interface to SimpleColor to support structure bindings.
NOTE: Unlike the storage of SimpleColor (ARGB), this produces the
bindings in the more familiar [r,g,b,a] to match FloatComponents.

(WebCore::Color::alpha const):
Made work with ExtendedColor as well.

(WebCore::Color::red const): Deleted.
(WebCore::Color::green const): Deleted.
(WebCore::Color::blue const): Deleted.
Removed.

(CGColorRef cachedCGColor):
(int differenceSquared):
Made friends so they could use Color::rgb().

(WebCore::Color::rgb const):
Made private.

• platform/graphics/ExtendedColor.cpp:

(WebCore::ExtendedColor::invertedColorWithAlpha const):

• platform/graphics/ExtendedColor.h:

Added invertedColorWithAlpha to allow inversion to be encapsulated.
When future color spaces are added, we may need to choose per-colorspace
algorithms for this instead of the trivial one used today.

• platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:

(WebCore::PlatformCAAnimationCocoa::setFromValue):
(WebCore::PlatformCAAnimationCocoa::setToValue):
(WebCore::PlatformCAAnimationCocoa::setValues):
Use toSRGBASimpleColorLossy() to get access to color components.

• platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(PlatformCAAnimationWin::setFromValue):
(PlatformCAAnimationWin::setToValue):
(PlatformCAAnimationWin::setValues):
Use toSRGBASimpleColorLossy() to get access to color components.

• platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawFocusRing):
Use Color::colorWithAlpha() to avoid needing access to components.

• platform/graphics/cpu/arm/filters/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):
Use toSRGBASimpleColorLossy() to get access to color components.

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::clearColor):
Use toSRGBASimpleColorLossy() to get access to color components.

• platform/graphics/win/Direct2DOperations.cpp:

(WebCore::Direct2D::drawGlyphs):
Use colorWithAlphaMultipliedBy() to avoid needing access to components.

• platform/graphics/win/FontCGWin.cpp:

(WebCore::FontCascade::drawGlyphs):
Use colorWithAlphaMultipliedBy() to avoid needing access to components.

• platform/graphics/win/FontCascadeDirect2D.cpp:

(WebCore::FontCascade::drawGlyphs):
Use colorWithAlphaMultipliedBy() to avoid needing access to components.

• rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paintSelection):
Use invertedColorWithAlpha() to avoid needing access to components.

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::resolveStyleForMarkedText):
Use invertedColorWithAlpha() to avoid needing access to components.

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):
Use opaqueColor() to avoid needing access to components.

• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::systemColor const):
Use opaqueColor() to avoid needing access to components.

• svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:

(WebCore::SVGAnimationColorFunction::animate):
Use toSRGBASimpleColorLossy() to get access to color components.

Source/WebKit:

• WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::animationValueFromKeyframeValue):
Use toSRGBASimpleColorLossy() to get access to color components.

Tools:

• TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):
Use toSRGBASimpleColorLossy() to get access to color components.

8:34 AM Changeset in webkit [262107] by Alan Bujtas

• 6 edits
  2 adds in trunk

[LFC][TFC] Take sections into account when computing collapsed border.
​https://bugs.webkit.org/show_bug.cgi?id=212311

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-collapsed-tbody-border.html

• layout/Verification.cpp:

(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree):

• layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::computeBorderAndPaddingForTableBox):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):

• layout/tableformatting/TableGrid.cpp:

(WebCore::Layout::TableGrid::Section::Section):
(WebCore::Layout::TableGrid::appendCell):

• layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::Section::box const):
(WebCore::Layout::TableGrid::sections const):
(WebCore::Layout::TableGrid::sections):

LayoutTests:

• fast/layoutformattingcontext/table-simple-collapsed-tbody-border-expected.html: Added.
• fast/layoutformattingcontext/table-simple-collapsed-tbody-border.html: Added.

8:23 AM Changeset in webkit [262106] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][TFC] Take collapsed in-between row border into account when computing cell height
​https://bugs.webkit.org/show_bug.cgi?id=212307

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-simple-collapsed-row-border2.html

• layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::computedCellBorder const):

LayoutTests:

• fast/layoutformattingcontext/table-simple-collapsed-row-border2-expected.html: Added.
• fast/layoutformattingcontext/table-simple-collapsed-row-border2.html: Added.

8:07 AM Changeset in webkit [262105] by Carlos Garcia Campos

• 2 edits
  1 delete in trunk/Source/WebKit

Unreviewed. Remove unused file since r261570

I forgot to remove DragAndDropHandler.h.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/gtk/DragAndDropHandler.h: Removed.