Context Navigation

← Previous Period
Next Period →

Timeline

Jun 7, 2020:

5:34 PM Changeset in webkit [262703] by Lauro Moura

6 edits in trunk/Source/WebKit

[WebDriver] Allow platform-dependent modifier keys conversion to WebEvent::Modifier
https://bugs.webkit.org/show_bug.cgi?id=212848

Reviewed by Brian Burg.

WebEvent::Modifier flags does not map directly to the platform flags,
so we can't directly convert the modifier flags to the OptionSet.

Covered by existing WebDriver tests.

UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::simulateMouseInteraction): Use
platform-specific method to convert the modifiers.

UIProcess/Automation/WebAutomationSession.h:
UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp: Added

conversion from GDK modifier mask to WebEvent::Modifier.
(WebKit::WebAutomationSession::platformWebModifiersFromRaw):

UIProcess/Automation/mac/WebAutomationSessionMac.mm: Added

conversion from NSModifierFlag to WebEvent::Modifier.
(WebKit::WebAutomationSession::platformWebModifiersFromRaw):

UIProcess/Automation/wpe/WebAutomationSessionWPE.cpp: Added

conversion from wpe_input_keyboard_modifier to WebEvent::Modifier.
(WebKit::WebAutomationSession::platformWebModifiersFromRaw):

5:16 PM Changeset in webkit [262702] by Lauro Moura

2 edits in trunk/Source/WebKit

[WPE] Behave like GDK_CURRENT_TIME when the timestamp is zero
https://bugs.webkit.org/show_bug.cgi?id=212797

WebDriver tests come with zero timestamp. So behave like
GDK_CURRENT_TIME and assume zero timestamp == WallTime::now().

Reviewed by Carlos Garcia Campos.

Covered by existing tests.

Shared/libwpe/WebEventFactory.cpp:

(WebKit::wallTimeForEventTime):

2:07 PM Changeset in webkit [262701] by commit-queue@webkit.org

12 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE - iOS] fast/canvas/webgl/uninitialized-test.html is still failing
https://bugs.webkit.org/show_bug.cgi?id=212249

Patch by James Darpinian <James Darpinian> on 2020-06-07
Reviewed by Dean Jackson.

copyTexImage2D is broken in some way on iOS. Work around it by reimplementing
it with ANGLE's BlitGL class.

include/platform/FeaturesGL.h:
src/libANGLE/renderer/gl/BlitGL.cpp:

(rx::BlitGL::blitColorBufferWithShader):

src/libANGLE/renderer/gl/BlitGL.h:
src/libANGLE/renderer/gl/TextureGL.cpp:

(rx::TextureGL::copyImage):
(rx::TextureGL::copySubImage):

src/libANGLE/renderer/gl/renderergl_utils.cpp:

(rx::nativegl_gl::InitializeFeatures):

src/tests/gl_tests/CopyTexImageTest.cpp:
src/tests/gl_tests/TextureTest.cpp:
src/tests/test_utils/angle_test_configs.cpp:

(angle::operator<<):

src/tests/test_utils/angle_test_configs.h:

(angle::WithEmulateCopyTexImage2DFromRenderbuffers):

util/EGLPlatformParameters.h:

(EGLPlatformParameters::tie const):

util/EGLWindow.cpp:

(EGLWindow::initializeDisplay):

9:56 AM Changeset in webkit [262700] by aestes@apple.com

4 edits in trunk

[Apple Pay] HAVE(PAYMENT_METHOD_BILLING_ADDRESS) should be true on iOS
https://bugs.webkit.org/show_bug.cgi?id=212877
<rdar://problem/64080998>

Reviewed by Sam Weinig.

Source/WTF:

wtf/PlatformHave.h:

LayoutTests:

platform/ios-wk2/TestExpectations: Unskipped

http/tests/ssl/applepay/ApplePayBillingAddress.html on iOS.

8:56 AM Changeset in webkit [262699] by Alan Bujtas

3 edits
2 adds in trunk

[LFC][Height percentage] Skip anonymous wrappers when searching for fixed height
https://bugs.webkit.org/show_bug.cgi?id=212881

Reviewed by Antti Koivisto.

Source/WebCore:

When the block level box is a direct child of an inline level box (<span><div></div></span>) and we wrap it into a continuation,
the containing block (anonymous wrapper) is not the box we need to check for fixed height.

Test: fast/layoutformattingcontext/height-precentage-with-anonymous-wrapper.html

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue const):

LayoutTests:

fast/layoutformattingcontext/height-precentage-with-anonymous-wrapper-expected.html: Added.
fast/layoutformattingcontext/height-precentage-with-anonymous-wrapper.html: Added.

8:00 AM Changeset in webkit [262698] by Alan Bujtas

4 edits
2 adds in trunk

[LFC][BFC] Intrinsic width computation should take min/max-width into account.
https://bugs.webkit.org/show_bug.cgi?id=212876

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/min-max-content-width-simple2.html

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedWidthValue): Address Sam's post-landing comment.

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraints):

LayoutTests:

fast/layoutformattingcontext/min-max-content-width-simple2-expected.html: Added.
fast/layoutformattingcontext/min-max-content-width-simple2.html: Added.

7:56 AM Changeset in webkit [262697] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC] Pass in the element attributes to Layout::ReplacedBox
https://bugs.webkit.org/show_bug.cgi?id=212879

Reviewed by Antti Koivisto.

The information whether the replace box is an image box is required to see if the box has intrinsic ratio (used for sizing inflow replaced content).

layout/layouttree/LayoutReplacedBox.cpp:

(WebCore::Layout::ReplacedBox::ReplacedBox):
(): Deleted.

layout/layouttree/LayoutReplacedBox.h:
layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createReplacedBox):
(WebCore::Layout::TreeBuilder::createLayoutBox):

layout/layouttree/LayoutTreeBuilder.h:

7:35 AM Changeset in webkit [262696] by Caio Lima

2 edits in trunk/Tools

Allow run-jsc-stress-tests still run if some of the remote hosts are not available
https://bugs.webkit.org/show_bug.cgi?id=201426

Reviewed by Saam Barati.

This patch allows run-jsc-stress-tests to keep on running if some of
the remote hosts are not available. To do this, we created a new
function checkAndPrepareRemoteHosts that is responsible to check the
connection and read/write permissions of given remote hosts list. It
filters out every unavailable remote host.
These checks and filter happen in the beginning of the script and is
excuted only once, in the beggining of the script. It means that if
some remote device becomes unavailable after the check and preparation
is done, the script execution will be interupted.

Scripts/run-jsc-stress-tests:

2:55 AM Changeset in webkit [262695] by Philippe Normand

271 edits in trunk

Remove ENABLE_VIDEO_TRACK ifdef guards
https://bugs.webkit.org/show_bug.cgi?id=212568

Reviewed by Youenn Fablet.

VIDEO_TRACK has been enabled by default on all ports for a long time. As the spec is stable,
the feature can unconditionally be enabled and is now guarded under ENABLE(VIDEO).

Source/cmake/OptionsFTW.cmake:
Source/cmake/OptionsMac.cmake:
Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: Remove ENABLE_VIDEO_TRACK, which is now enabled by

default under the ENABLE_VIDEO guard.

Source/WebCore:

CMakeLists.txt:
Configurations/FeatureDefines.xcconfig:
Modules/mediacontrols/MediaControlsHost.cpp:
Modules/mediasource/AudioTrackMediaSource.h:
Modules/mediasource/AudioTrackMediaSource.idl:
Modules/mediasource/SourceBuffer.h:
Modules/mediasource/SourceBuffer.idl:
Modules/mediasource/TextTrackMediaSource.h:
Modules/mediasource/TextTrackMediaSource.idl:
Modules/mediasource/VideoTrackMediaSource.h:
Modules/mediasource/VideoTrackMediaSource.idl:
Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp:

(WebCore::HTMLVideoElementPictureInPicture::requestPictureInPicture):

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSAudioTrackCustom.cpp:
bindings/js/JSAudioTrackListCustom.cpp:
bindings/js/JSTextTrackCueCustom.cpp:
bindings/js/JSTextTrackCustom.cpp:
bindings/js/JSTextTrackListCustom.cpp:
bindings/js/JSTrackCustom.cpp:
bindings/js/JSTrackCustom.h:
bindings/js/JSVideoTrackCustom.cpp:
bindings/js/JSVideoTrackListCustom.cpp:
css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::selectorText const):

css/CSSSelector.h:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):

css/SelectorCheckerTestFunctions.h:

(WebCore::matchesLangPseudoClass):

css/SelectorPseudoClassAndCompatibilityElementMap.in:
css/SelectorPseudoElementTypeMap.in:
css/parser/CSSParserSelector.h:

(WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):
(WebCore::CSSParserSelector::isPseudoElementCueFunction const):

css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumePseudo):

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

dom/Document.cpp:
dom/Document.h:
dom/EventNames.in:
dom/EventTargetFactory.in:
dom/Node.h:
history/BackForwardCache.cpp:
history/BackForwardCache.h:
history/CachedPage.cpp:

(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):

history/CachedPage.h:
html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::as const):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::finishParsingChildren):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::canTransitionFromAutoplayToPlay const):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::configureTextTracks):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::syncTextTrackBounds):
(WebCore::HTMLMediaElement::setVideoFullscreenStandby):
(WebCore::HTMLMediaElement::setVideoFullscreenLayer):
(WebCore::HTMLMediaElement::hasClosedCaptions const):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::bufferingPolicy const):

html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:
html/HTMLTagNames.in:
html/HTMLTrackElement.cpp:
html/HTMLTrackElement.h:
html/HTMLTrackElement.idl:
html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::texImageSourceHelper):
(WebCore::WebGLRenderingContextBase::validateTexFuncParameters):

html/shadow/MediaControlTextTrackContainerElement.cpp:
html/shadow/MediaControlTextTrackContainerElement.h:
html/track/AudioTrack.cpp:
html/track/AudioTrack.h:
html/track/AudioTrack.idl:
html/track/AudioTrackList.cpp:
html/track/AudioTrackList.h:
html/track/AudioTrackList.idl:
html/track/DataCue.cpp:
html/track/DataCue.h:
html/track/DataCue.idl:
html/track/InbandDataTextTrack.cpp:
html/track/InbandDataTextTrack.h:
html/track/InbandGenericTextTrack.cpp:
html/track/InbandGenericTextTrack.h:
html/track/InbandTextTrack.cpp:
html/track/InbandTextTrack.h:
html/track/InbandWebVTTTextTrack.cpp:
html/track/InbandWebVTTTextTrack.h:
html/track/LoadableTextTrack.cpp:
html/track/LoadableTextTrack.h:
html/track/TextTrack.cpp:
html/track/TextTrack.h:
html/track/TextTrack.idl:
html/track/TextTrackCue.cpp:
html/track/TextTrackCue.h:
html/track/TextTrackCue.idl:
html/track/TextTrackCueGeneric.cpp:
html/track/TextTrackCueGeneric.h:
html/track/TextTrackCueGeneric.idl:
html/track/TextTrackCueList.cpp:
html/track/TextTrackCueList.h:
html/track/TextTrackCueList.idl:
html/track/TextTrackList.cpp:
html/track/TextTrackList.h:
html/track/TextTrackList.idl:
html/track/TrackBase.cpp:
html/track/TrackBase.h:
html/track/TrackEvent.cpp:
html/track/TrackEvent.h:
html/track/TrackEvent.idl:
html/track/TrackListBase.cpp:
html/track/TrackListBase.h:
html/track/VTTCue.cpp:
html/track/VTTCue.h:
html/track/VTTCue.idl:
html/track/VTTRegion.cpp:
html/track/VTTRegion.h:
html/track/VTTRegion.idl:
html/track/VTTRegionList.cpp:
html/track/VTTRegionList.h:
html/track/VTTRegionList.idl:
html/track/VideoTrack.cpp:
html/track/VideoTrack.h:
html/track/VideoTrack.idl:
html/track/VideoTrackList.cpp:
html/track/VideoTrackList.h:
html/track/VideoTrackList.idl:
html/track/WebVTTElement.cpp:
html/track/WebVTTElement.h:
html/track/WebVTTParser.cpp:
html/track/WebVTTParser.h:
html/track/WebVTTToken.h:
html/track/WebVTTTokenizer.cpp:
html/track/WebVTTTokenizer.h:
loader/LinkLoader.cpp:

(WebCore::LinkLoader::resourceTypeFromAsAttribute):
(WebCore::createLinkPreloadResourceClient):
(WebCore::LinkLoader::isSupportedType):

loader/ResourceLoadInfo.cpp:

(WebCore::ContentExtensions::toResourceType):

loader/SubresourceLoader.cpp:

(WebCore::logResourceLoaded):

loader/TextTrackLoader.cpp:
loader/TextTrackLoader.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::defaultPriorityForResourceType):

loader/cache/CachedResource.h:
loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::contentTypeFromResourceType):
(WebCore::CachedResourceLoader::checkInsecureContent const):
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):
(WebCore::destinationForType):

loader/cache/CachedResourceLoader.h:
loader/cache/CachedTextTrack.cpp:
loader/cache/CachedTextTrack.h:
page/CaptionUserPreferences.cpp:
page/CaptionUserPreferences.h:
page/CaptionUserPreferencesMediaAF.cpp:
page/CaptionUserPreferencesMediaAF.h:
page/Page.cpp:

(WebCore::Page::setPageScaleFactor):
(WebCore::Page::setUserInterfaceLayoutDirection):
(WebCore::Page::doAfterUpdateRendering):
(WebCore::Page::forEachMediaElement):

page/Page.h:
page/PageGroup.cpp:
page/PageGroup.h:
page/Settings.yaml:
platform/LocalizedStrings.cpp:
platform/LocalizedStrings.h:
platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageVideoOrSVGMIMEType):

platform/SerializedPlatformDataCue.cpp:
platform/graphics/AudioTrackPrivate.h:
platform/graphics/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):
(WebCore::ImageDecoder::supportsMediaType):

platform/graphics/InbandGenericCue.cpp:
platform/graphics/InbandGenericCue.h:
platform/graphics/InbandTextTrackPrivate.h:
platform/graphics/InbandTextTrackPrivateClient.h:
platform/graphics/MediaPlayer.cpp:

(WebCore::buildMediaEnginesVector):

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::textTrackRepresentationBoundsChanged):

platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::tracksChanged):

platform/graphics/TextTrackRepresentation.cpp:
platform/graphics/TextTrackRepresentation.h:
platform/graphics/TrackPrivateBase.cpp:
platform/graphics/TrackPrivateBase.h:
platform/graphics/VideoTrackPrivate.h:
platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h:
platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
platform/graphics/avfoundation/AudioTrackPrivateAVF.h:
platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
platform/graphics/avfoundation/VideoTrackPrivateAVF.h:
platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.cpp:
platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:
platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm:
platform/graphics/cocoa/TextTrackRepresentationCocoa.h:
platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer):

platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
platform/graphics/gstreamer/ImageDecoderGStreamer.h:
platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::updateTracks):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidTextTracks):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
platform/graphics/gstreamer/TextCombinerGStreamer.h:
platform/graphics/gstreamer/TextSinkGStreamer.cpp:
platform/graphics/gstreamer/TextSinkGStreamer.h:
platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
platform/mac/SerializedPlatformDataCueMac.h:
platform/mac/SerializedPlatformDataCueMac.mm:
platform/mediastream/AudioMediaStreamTrackRenderer.cpp:
platform/mediastream/AudioMediaStreamTrackRenderer.h:
platform/mediastream/AudioTrackPrivateMediaStream.cpp:
platform/mediastream/AudioTrackPrivateMediaStream.h:
platform/mediastream/VideoTrackPrivateMediaStream.h:
platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:
platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.h:
rendering/RenderVTTCue.cpp:
rendering/RenderVTTCue.h:
style/ElementRuleCollector.cpp:

(WebCore::Style::ElementRuleCollector::collectMatchingShadowPseudoElementRules):

style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::addMatch):

style/RuleData.cpp:

(WebCore::Style::determinePropertyWhitelistType):

style/RuleData.h:
style/RuleSet.cpp:

(WebCore::Style::RuleSet::addRule):
(WebCore::Style::RuleSet::traverseRuleDatas):
(WebCore::Style::RuleSet::hasShadowPseudoElementRules const):
(WebCore::Style::RuleSet::shrinkToFit):

style/RuleSet.h:
style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShouldDisplayTrackKind):
(WebCore::InternalSettings::shouldDisplayTrackKind):

testing/InternalSettings.h:
testing/InternalSettings.idl:
testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::Internals):
(WebCore::Internals::userPreferredAudioCharacteristics const):
(WebCore::Internals::setUserPreferredAudioCharacteristic):
(WebCore::Internals::captionsStyleSheetOverride):
(WebCore::Internals::setCaptionsStyleSheetOverride):
(WebCore::Internals::setPrimaryAudioTrackLanguageOverride):
(WebCore::Internals::setCaptionDisplayMode):
(WebCore::Internals::textTrackBCP47Language):
(WebCore::Internals::getCurrentMediaControlsStatusForElement):

testing/Internals.h:
testing/Internals.idl:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:
GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::dispatchMessage):

GPUProcess/GPUConnectionToWebProcess.h:
GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::textTrackSetMode):
(WebKit::RemoteMediaPlayerProxy::notifyTrackModeChanged):

GPUProcess/media/RemoteMediaPlayerProxy.h:
GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp:
GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h:
GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.messages.in:
GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in:
GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in:
Shared/WebPreferences.yaml:
WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::dispatchMessage):

WebProcess/GPU/GPUProcessConnection.h:
WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::tracksChanged):

WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::RemoteMediaPlayerManager::updatePreferences):

WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:
WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h:
WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:
WebProcess/GPU/webrtc/SampleBufferDisplayLayer.messages.in:
WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.cpp:
WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::maximumBufferingTime):

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

WebPreferences.cpp:

(WebPreferences::shouldDisplaySubtitles):
(WebPreferences::setShouldDisplaySubtitles):
(WebPreferences::shouldDisplayCaptions):
(WebPreferences::setShouldDisplayCaptions):
(WebPreferences::shouldDisplayTextDescriptions):
(WebPreferences::setShouldDisplayTextDescriptions):

WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WTF:

wtf/PlatformEnable.h: Remove ENABLE_VIDEO_TRACK, which is now enabled by

default under the ENABLE_VIDEO guard.

wtf/PlatformEnableCocoa.h: Ditto.

Tools:

Scripts/webkitperl/FeatureList.pm:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

12:35 AM Changeset in webkit [262694] by ysuzuki@apple.com

3 edits in trunk/Source/JavaScriptCore

[JSC] Checksum for generated files should be emitted at the end of the files
https://bugs.webkit.org/show_bug.cgi?id=212875

Reviewed by Mark Lam.

If the offlineasm file generation is interrupted in the middle of the generation, it already emitted checksum.
So next file generation can accept this broken file as a result of offlineasm and skip file generation.
We should emit checksum at the end of files. For now, this patch takes a quick way: just iterating lines, getting
a last line and use it for checksum comparison.

generator/GeneratedFile.rb:
offlineasm/asm.rb:

Jun 6, 2020:

7:54 PM Changeset in webkit [262693] by ysuzuki@apple.com

5 edits
2 adds in trunk

Crash when running web-apis data collection
https://bugs.webkit.org/show_bug.cgi?id=212458

Reviewed by Mark Lam.

Source/WebCore:

Test: js/dom/dom-attribute-getter-setter.html

For properties using DOMAttribute property attribute in the table, code generator must use DOMAttributeGetterSetter instead of CustomGetterSetter.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::finishCreation):

LayoutTests:

js/dom/dom-attribute-getter-setter-expected.txt: Added.
js/dom/dom-attribute-getter-setter.html: Added.

7:52 PM Changeset in webkit [262692] by aestes@apple.com

2 edits in branches/safari-609-branch/LayoutTests

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

5:15 PM Changeset in webkit [262691] by aestes@apple.com

2 edits in branches/safari-609-branch/Source/WebCore

Unreviewed build fix for platforms where APPLE_PAY_INSTALLMENTS is disabled.

testing/MockPaymentCoordinator.idl: Moved installmentConfiguration to a partial interface.

11:02 AM Changeset in webkit [262690] by Alan Bujtas

8 edits
2 adds in trunk

[LFC] Add support for width: min/max-content
https://bugs.webkit.org/show_bug.cgi?id=212869

Reviewed by Antti Koivisto.

Source/WebCore:

Use the existing intrinsic width logic to compute min/max-content width.

Test: fast/layoutformattingcontext/min-max-content-width-simple.html

layout/FormattingContext.h:
layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedWidthValue):
(WebCore::Layout::FormattingContext::Geometry::computedWidth):
(WebCore::Layout::FormattingContext::Geometry::fixedValue const):
(WebCore::Layout::FormattingContext::Geometry::computedMinWidth):
(WebCore::Layout::FormattingContext::Geometry::computedMaxWidth):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedWidth const): Deleted.
(WebCore::Layout::FormattingContext::Geometry::computedMinWidth const): Deleted.
(WebCore::Layout::FormattingContext::Geometry::computedMaxWidth const): Deleted.
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry const): Deleted.
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin const): Deleted.
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin const): Deleted.

layout/blockformatting/BlockFormattingContext.h:
layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin const): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin const): Deleted.

layout/tableformatting/TableFormattingContext.h:
layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::computedColumnWidth):
(WebCore::Layout::TableFormattingContext::Geometry::computedColumnWidth const): Deleted.

LayoutTests:

fast/layoutformattingcontext/min-max-content-width-simple-expected.html: Added.
fast/layoutformattingcontext/min-max-content-width-simple.html: Added.

10:49 AM Changeset in webkit [262689] by cturner@igalia.com

29 edits
2 moves
15 adds
6 deletes in trunk/LayoutTests

[GTK][WPE][EME] Update WPT and rebaseline
https://bugs.webkit.org/show_bug.cgi?id=212574

Reviewed by Xabier Rodriguez-Calvar.

LayoutTests/imported/w3c:

Updated the encrypted-media directory like so,

Tools/Scripts/import-w3c-tests -s ~/igalia/sources/wpt/ -d imported/w3c/web-platform-tests/ encrypted-media

resources/import-expectations.json:
web-platform-tests/encrypted-media/META.yml: Added.
web-platform-tests/encrypted-media/OWNERS: Removed.
web-platform-tests/encrypted-media/clearkey-check-encryption-scheme.https-expected.txt: Added.
web-platform-tests/encrypted-media/clearkey-check-encryption-scheme.https.html: Added.
web-platform-tests/encrypted-media/clearkey-check-status-for-hdcp.https.html: Added.
web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https-expected.txt:
web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted-segmented.https.html: Added.
web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.https-expected.txt: Renamed from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.https-expected.txt.
web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys.https-expected.txt: Renamed from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys.https-expected.txt.
web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.https-expected.txt: Added.
web-platform-tests/encrypted-media/content/w3c-import.log:
web-platform-tests/encrypted-media/drm-check-encryption-scheme.https.html: Added.
web-platform-tests/encrypted-media/drm-check-status-for-hdcp.https.html: Added.
web-platform-tests/encrypted-media/encrypted-media-supported-by-feature-policy.tentative.html: Added.
web-platform-tests/encrypted-media/idlharness.https.html:
web-platform-tests/encrypted-media/polyfill/w3c-import.log:
web-platform-tests/encrypted-media/resources/w3c-import.log:
web-platform-tests/encrypted-media/scripts/check-encryption-scheme.js: Added.

(checkEncryptionScheme):
(runTest):

web-platform-tests/encrypted-media/scripts/check-status-for-hdcp.js: Added.

(checkStatusForMinHdcpVersionPolicy):
(runTest):

web-platform-tests/encrypted-media/scripts/clearkey-update-non-ascii-input.js:

(runTest):

web-platform-tests/encrypted-media/scripts/generate-request-disallowed-input.js:

(runTest):

web-platform-tests/encrypted-media/scripts/invalid-license.js:

(runTest.):
(runTest):

web-platform-tests/encrypted-media/scripts/playback-temporary-encrypted-clear-segmented-sources.js: Added.

(runTest):

web-platform-tests/encrypted-media/scripts/playback-temporary-expired.js:

(runTest):

web-platform-tests/encrypted-media/scripts/requestmediakeysystemaccess.js:

(expect_error):

web-platform-tests/encrypted-media/scripts/setmediakeys.js:

(runTest):

web-platform-tests/encrypted-media/scripts/syntax-mediakeysession.js:

(runTest.func):

web-platform-tests/encrypted-media/scripts/temporary-license-type.js:

(runTest):

web-platform-tests/encrypted-media/scripts/update-disallowed-input.js:

(runTest.):
(runTest):

web-platform-tests/encrypted-media/scripts/w3c-import.log:
web-platform-tests/encrypted-media/scripts/waiting-for-a-key.js:
web-platform-tests/encrypted-media/util/utils.js:
web-platform-tests/encrypted-media/util/w3c-import.log:
web-platform-tests/encrypted-media/w3c-import.log:

LayoutTests:

Update the WPT tests and adjust GTK and WPE test expectations. I
have noticed some crashes locally on occasion, but they are rare
here and I have not at the opportunity to dissect one of them to
figure it out.

platform/glib/TestExpectations:
platform/glib/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.https-expected.txt:
platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/encrypted-media/clearkey-check-status-for-hdcp.https-expected.txt: Added.
platform/gtk/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.https-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess.https-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys.https-expected.txt: Removed.
platform/gtk/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.https-expected.txt: Removed.
platform/wpe/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-check-status-for-hdcp.https-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess.https-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.https-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.https-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/encrypted-media/encrypted-media-default-feature-policy.https.sub-expected.txt: Removed.
tests-options.json:

10:39 AM Changeset in webkit [262688] by Devin Rousso

5 edits in trunk

[ macOS wk2 ] inspector/page/setBootstrapScript-sub-frame.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207053
<rdar://problem/59064908>

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/page/setBootstrapScript-sub-frame.html

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
Ensure the InspectorPageAgent sends the new Page.Frame payload to the frontend before
the PageRuntimeAgent so that a WI.Frame exists before adding any WI.ExecutionContext.

LayoutTests:

inspector/page/setBootstrapScript-sub-frame.html:

platform/mac/TestExpectations:

10:37 AM Changeset in webkit [262687] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r262364): Disney Plus crashes playing videos
https://bugs.webkit.org/show_bug.cgi?id=212862
<rdar://problem/64044841>

Reviewed by Eric Carlson.

In r262364, we specified an incorrect number size for CFNumberGetValue, which nevertheless
worked fine in debug builds, but overwrote stack data in release builds, leading to a crash when
the returned pointer was ref()d. The correct size for a FourCharCode is a
kCFNumberSInt32Type, not a kCFNumberLongType.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

10:35 AM Changeset in webkit [262686] by Simon Fraser

4 edits in trunk/LayoutTests

fast/scrolling/latching/iframe-latch-small-deltas.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=210348
<rdar://problem/61594742>

Reviewed by Anders Carlsson.

This test needs to use ' eventSender.monitorWheelEvents({ resetLatching: false });' so that it
waits for the events from the last non-momentum scroll without resetting latching.

fast/scrolling/latching/iframe-latch-small-deltas-expected.txt:
fast/scrolling/latching/iframe-latch-small-deltas.html:
platform/mac-wk2/TestExpectations:

10:31 AM Changeset in webkit [262685] by Simon Fraser

7 edits in trunk

Clear WebPageProxy event state between tests
https://bugs.webkit.org/show_bug.cgi?id=212864

Reviewed by Anders Carlsson.

Make sure that event state doesn't leak between tests via events queued in WebPageProxy.

Source/WebKit:

UIProcess/API/C/WKPage.cpp:

(WKPageClearEventState):

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::clearEventState):

UIProcess/WebPageProxy.h:

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

9:36 AM Changeset in webkit [262684] by ddkilzer@apple.com

6 edits in trunk/Source/WebCore

[IPC] Adopt enum class for GradientSpreadMethod
<https://webkit.org/b/212868>
<rdar://problem/64069035>

Reviewed by Anders Carlsson.

Summary:

Convert GradientSpreadMethod to an enum class.
Add WTF::EnumTraits<AutocapitalizeType> for IPC.
Remove use of decodeEnum() and encodeEnum().

platform/graphics/Gradient.h:

(WebCore::Gradient::encode const):
(WebCore::Gradient::decode):

platform/graphics/GraphicsTypes.h:
platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::createPlatformGradient):

platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::paint):

rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

9:20 AM Changeset in webkit [262683] by commit-queue@webkit.org

47 edits in trunk/Source

Source/WebCore:
Reduce includes for CustomHeaderFields
https://bugs.webkit.org/show_bug.cgi?id=212691

Patch by Rob Buis <rbuis@igalia.com> on 2020-06-06
Reviewed by Joseph Pecoraro.

Reduce includes for CustomHeaderFields, I guess these were needed
at some point but not anymore.

Modules/applepay/ApplePaySession.cpp:
Modules/applepay/PaymentSession.cpp:
bindings/js/ScriptController.cpp:
contentextensions/ContentExtensionsBackend.cpp:
dom/Document.cpp:
editing/cocoa/EditorCocoa.mm:
editing/cocoa/HTMLConverter.mm:
editing/cocoa/WebContentReaderCocoa.mm:
editing/markup.cpp:
history/CachedFrame.cpp:
html/HTMLDocument.cpp:
html/HTMLHtmlElement.cpp:
html/HTMLMediaElement.cpp:
html/ImageDocument.cpp:
html/MediaDocument.cpp:
html/PluginDocument.cpp:
html/parser/HTMLDocumentParser.cpp:
html/parser/XSSAuditor.cpp:
inspector/InspectorInstrumentation.cpp:
inspector/agents/InspectorApplicationCacheAgent.cpp:
inspector/agents/InspectorNetworkAgent.cpp:
inspector/agents/InspectorPageAgent.cpp:
inspector/agents/page/PageNetworkAgent.cpp:
loader/ApplicationManifestLoader.cpp:
loader/FrameLoader.cpp:
loader/LoadTiming.cpp:
loader/NetscapePlugInStreamLoader.cpp:
loader/ResourceLoader.cpp:
loader/SubresourceLoader.cpp:
loader/appcache/ApplicationCacheHost.cpp:
loader/archive/cf/LegacyWebArchive.cpp:
loader/icon/IconLoader.cpp:
page/ContextMenuController.cpp:
page/FrameView.cpp:
page/Page.cpp:
page/Performance.cpp:
page/PerformanceNavigation.cpp:
page/Quirks.cpp:
page/UserContentProvider.cpp:
page/csp/ContentSecurityPolicy.cpp:
page/mac/PageMac.mm:
platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
svg/graphics/SVGImage.cpp:
testing/Internals.cpp:

Source/WebKit:
Move URL scheme check to NetworkLoadChecker
https://bugs.webkit.org/show_bug.cgi?id=191924

Patch by Rob Buis <rbuis@igalia.com> on 2020-06-06
Reviewed by Joseph Pecoraro.

Reduce includes for CustomHeaderFields, I guess these were needed
at some point but not anymore.

Shared/WebsitePoliciesData.cpp:

9:13 AM Changeset in webkit [262682] by aestes@apple.com

25 edits
6 copies
2 adds in trunk

[Apple Pay] Add testing and logging for ApplePaySetup
https://bugs.webkit.org/show_bug.cgi?id=211972
<rdar://problem/63291965>

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/ssl/applepay/ApplePaySetup.https.html

DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/applepay/ApplePaySetup.cpp:

(WebCore::ApplePaySetup::getSetupFeatures):
(WebCore::ApplePaySetup::begin):
(WebCore::ApplePaySetup::ApplePaySetup):
(WebCore::ApplePaySetup::stop):

Modules/applepay/ApplePaySetup.idl:
Modules/applepay/ApplePaySetupConfiguration.h: Copied from Source/WebCore/Modules/applepay/ApplePaySetupFeatureType.idl.
Modules/applepay/ApplePaySetupConfiguration.idl: Copied from Source/WebCore/Modules/applepay/ApplePaySetupFeatureType.idl.
Modules/applepay/ApplePaySetupFeature.idl:
Modules/applepay/ApplePaySetupFeature.mm:

(WebCore::ApplePaySetupFeature::state const):

Modules/applepay/ApplePaySetupFeatureState.h: Copied from Source/WebCore/Modules/applepay/ApplePaySetupFeatureType.idl.
Modules/applepay/ApplePaySetupFeatureState.idl: Copied from Source/WebCore/Modules/applepay/ApplePaySetupFeatureType.idl.
Modules/applepay/ApplePaySetupFeatureType.idl:
Modules/applepay/ApplePaySetupFeatureWebCore.h:
Modules/applepay/ApplePaySetupWebCore.h:

(WebCore::ApplePaySetup::create):

Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::setApplePayIsActiveIfAllowed const):
(WebCore::PaymentCoordinator::getSetupFeatures):
(WebCore::PaymentCoordinator::beginApplePaySetup):
(WebCore::PaymentCoordinator::endApplePaySetup):

Modules/applepay/PaymentCoordinator.h:
Modules/applepay/PaymentCoordinatorClient.h:

(WebCore::PaymentCoordinatorClient::getSetupFeatures):
(WebCore::PaymentCoordinatorClient::beginApplePaySetup):

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
testing/MockApplePaySetupFeature.cpp: Copied from Source/WebCore/Modules/applepay/ApplePaySetupFeatureWebCore.h.

(WebCore::MockApplePaySetupFeature::create):
(WebCore::MockApplePaySetupFeature::MockApplePaySetupFeature):

testing/MockApplePaySetupFeature.h: Copied from Source/WebCore/Modules/applepay/ApplePaySetupFeatureWebCore.h.
testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::addSetupFeature):
(WebCore::MockPaymentCoordinator::getSetupFeatures):
(WebCore::MockPaymentCoordinator::beginApplePaySetup):

testing/MockPaymentCoordinator.h:
testing/MockPaymentCoordinator.idl:

LayoutTests:

http/tests/ssl/applepay/ApplePaySetup.https-expected.txt: Added.
http/tests/ssl/applepay/ApplePaySetup.https.html: Added.
platform/mac-wk2/TestExpectations:

9:12 AM Changeset in webkit [262681] by ddkilzer@apple.com

4 edits in trunk/Source

Follow-up: Use OptionSet<DragOperation> for mask values
<https://webkit.org/b/212605>
<rdar://problem/64069091>

Source/WebCore:

dom/DataTransfer.cpp:

(WebCore::DataTransfer::destinationOperationMask const):

Don't compare to anyDragOperation(). Darin suggested this change during patch review, but this use was missed.

Source/WebKitLegacy/win:

WebCoreSupport/WebDragClient.cpp:

(draggingSourceOperationMaskToDragCursors):

Don't compare to anyDragOperation(). It's redundant since the code following it will do the same thing.

8:17 AM Changeset in webkit [262680] by ddkilzer@apple.com

54 edits in trunk/Source

Use OptionSet<DragOperation> for mask values
<https://webkit.org/b/212605>

Reviewed by Darin Adler.

Source/WebCore:

In broad strokes:

Replace use of DragOperation with OptionSet<DragOperation> or Optional<DragOperation>.
Rename function parameters and local variables to denote use of mask values.
Remove DragOperationNone enum value.
Replace DragOperationEvery enum value with anyDragOperation().

dom/DataTransfer.cpp:

(WebCore::DataTransfer::createForDrop):
(WebCore::DataTransfer::createForUpdatingDropTarget):
(WebCore::dragOpFromIEOp):
(WebCore::IEOpFromDragOp):
(WebCore::DataTransfer::sourceOperation const): Rename.
(WebCore::DataTransfer::sourceOperationMask const):
(WebCore::DataTransfer::destinationOperation const): Rename.
(WebCore::DataTransfer::destinationOperationMask const):
(WebCore::DataTransfer::setSourceOperation): Rename.
(WebCore::DataTransfer::setSourceOperationMask):
(WebCore::DataTransfer::setDestinationOperation): Rename.
(WebCore::DataTransfer::setDestinationOperationMask):

dom/DataTransfer.h:

(WebCore::DataTransfer::createForDrop):
(WebCore::DataTransfer::createForUpdatingDropTarget):
(WebCore::DataTransfer::sourceOperation const): Rename.
(WebCore::DataTransfer::sourceOperationMask const):
(WebCore::DataTransfer::destinationOperation const): Rename.
(WebCore::DataTransfer::destinationOperationMask const):
(WebCore::DataTransfer::setSourceOperation): Rename.
(WebCore::DataTransfer::setSourceOperationMask):
(WebCore::DataTransfer::setDestinationOperation): Rename.
(WebCore::DataTransfer::setDestinationOperationMask):

page/DragActions.h:

(WebCore::anyDragOperation): Add.
(WTF::EnumTraits<WebCore::DragOperation>): Add.
(WTF::OptionSet<WebCore::DragOperation>): Add.

page/DragController.cpp:

(WebCore::DragController::dragEntered):
(WebCore::DragController::dragUpdated):
(WebCore::DragController::performDragOperation):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::operationForLoad):
(WebCore::defaultOperationForDrag):
(WebCore::DragController::tryDHTMLDrag):

Change logic to call defaultOperationForDrag() to convert targetResponse.operationMask to a single operation when targetResponse.operationMask but doesn't contain with any bit values set in sourceOperationMask.

(WebCore::DragController::startDrag):

page/DragController.h:

(WebCore::DragController::dragEntered):
(WebCore::DragController::dragUpdated):
(WebCore::DragController::sourceDragOperation const): Rename.
(WebCore::DragController::sourceDragOperationMask const):
(WebCore::DragController::startDrag):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::operationForLoad):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::tryDHTMLDrag):
(WebCore::DragController::dragOperation):

page/EventHandler.cpp:

(WebCore::convertDropZoneOperationToDragOperation):
(WebCore::convertDragOperationToDropZoneOperation):
(WebCore::findDropZone):
(WebCore::EventHandler::dispatchDragEnterOrDragOverEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::handleDrag):

page/EventHandler.h:

(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::dispatchDragEnterOrDragOverEvent):

page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::dragOperation):

page/mac/DragControllerMac.mm:

(WebCore::DragController::dragOperation):

page/win/DragControllerWin.cpp:

(WebCore::DragController::dragOperation):

Clean up comment.
platform/DragData.cpp:

(WebCore::DragData::DragData):

platform/DragData.h:

(WebCore::DragData::DragData):
(WebCore::DragData::draggingSourceOperationMask const):

platform/cocoa/DragDataCocoa.mm:

(WebCore::DragData::DragData):

platform/gtk/GtkUtilities.cpp:

(WebCore::gdkDragActionToDragOperation):
(WebCore::dragOperationToGdkDragActions):
(WebCore::dragOperationToSingleGdkDragAction):

platform/gtk/GtkUtilities.h:

(WebCore::gdkDragActionToDragOperation):
(WebCore::dragOperationToGdkDragActions):
(WebCore::dragOperationToSingleGdkDragAction):

platform/win/DragDataWin.cpp:

(WebCore::DragData::DragData):

Source/WebKit:

In broad strokes:

Replace use of DragOperation with OptionSet<DragOperation> or Optional<DragOperation>.
Rename function parameters and local variables to denote use of mask values.
Remove DragOperationNone enum value.
Replace DragOperationEvery enum value with anyDragOperation().

Platform/spi/ios/UIKitSPI.h:

(UIDragOperation):

Remove unused (and misnamed) UIDragOperation enum typedef.
Scripts/webkit/messages.py:

(types_that_cannot_be_forward_declared):
(headers_for_type):

Add support for WebCore::DragOperation enum.
Shared/API/Cocoa/_WKDragActionsInternal.h:

(WebKit::coreDragOperationMask): Add conversion function.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<DragData>::encode):
(IPC::ArgumentCoder<DragData>::decode):

Update to encode/decode OptionSet<DragOperation>.

UIProcess/API/gtk/DragSource.h:

(WebKit::DragSource::begin):

UIProcess/API/gtk/DragSourceGtk3.cpp:

(WebKit::DragSource::begin):

UIProcess/API/gtk/DragSourceGtk4.cpp:

(WebKit::DragSource::begin):

UIProcess/API/gtk/DropTarget.h:
UIProcess/API/gtk/DropTargetGtk3.cpp:

(WebKit::DropTarget::didPerformAction):
(WebKit::DropTarget::leaveTimerFired):

UIProcess/API/gtk/DropTargetGtk4.cpp:

(WebKit::DropTarget::DropTarget):
(WebKit::DropTarget::didPerformAction):

UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::startDrag):

UIProcess/API/gtk/PageClientImpl.h:

(WebKit::PageClientImpl::startDrag):

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseStartDrag):

UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

(webkitWebViewBaseStartDrag):

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::sendDragEndToPage):
(WebKit::WebViewImpl::draggingEntered):
(WebKit::kit): Add conversion function.
(WebKit::WebViewImpl::draggingUpdated):
(WebKit::WebViewImpl::draggingExited):
(WebKit::WebViewImpl::performDragOperation):

Make use of coreDragOperationMask() conversion function.
UIProcess/PageClient.h:

(WebKit::WebViewImpl::startDrag):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didPerformDragControllerAction):

Remove MESSAGE_CHECK now that we're using the actual type.

(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::dragEnded):
(WebKit::WebPageProxy::resetCurrentDragInformation):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::didPerformDragControllerAction):
(WebKit::WebPageProxy::dragEnded):
(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::currentDragOperation const):

UIProcess/WebPageProxy.messages.in:

(WebPageProxy::DidPerformDragControllerAction):
(WebPageProxy::StartDrag):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _didHandleDragStartRequest:]):
(dropOperationForWebCoreDragOperation):
(coreDragOperationForUIDropOperation): Add conversion function.

Note that this was not being converted from UIDropOperation to WebCore::DragOperation previously, and UIDropOperationMove (0x3) was not being properly converted to DragOperationMove (0x16).

(-[WKContentView dragDataForDropSession:dragDestinationAction:]):
(-[WKContentView _didPerformDragOperation:]):
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
(-[WKContentView dragInteraction:session:didEndWithOperation:]):
(-[WKContentView dropInteraction:sessionDidEnd:]):

WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

(WebKit::WebDragClient::startDrag):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::dragEnded):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::dragEnded):

WebProcess/WebPage/WebPage.messages.in:

(WebPage::PerformDragControllerAction):
(WebPage::DragEnded):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestAdditionalItemsForDragSession):

Source/WebKitLegacy/mac:

In broad strokes:

Replace use of DragOperation with OptionSet<DragOperation> or Optional<DragOperation>.
Rename function parameters and local variables to denote use of mask values.
Remove DragOperationNone enum value.
Replace DragOperationEvery enum value with anyDragOperation().

WebView/WebFrame.mm:

(-[WebFrame _dragSourceEndedAt:operation:]):

WebView/WebHTMLView.mm:

(kit): Add conversion function.
(-[WebHTMLView draggingSourceOperationMaskForLocal:]):
(-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):

WebView/WebView.mm:

(coreDragOperationMask): Add conversion function.
(kit): Ditto.

Map WebCore::DragOperationGeneric to _UIDragOperationMove based on logic in WebCore. All other WebCore::DragOperation enum values map to _UIDragOperationNone.

(-[WebView dragDataForSession:client:global:operation:]):
(-[WebView _enteredDataInteraction:client:global:operation:]):
(-[WebView _updatedDataInteraction:client:global:operation:]):
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):

WebView/WebViewInternal.h:

(CocoaDragOperation):

Add typedef so coreDragOperationMask() may be shared across platforms.

(coreDragOperationMask): Add declaration.
(coreOptions):

Remove redundant parameter name.

Source/WebKitLegacy/win:

In broad strokes:

Replace use of DragOperation with OptionSet<DragOperation> or Optional<DragOperation>.
Rename function parameters and local variables to denote use of mask values.
Remove DragOperationNone enum value.
Replace DragOperationEvery enum value with anyDragOperation().

WebCoreSupport/WebDragClient.cpp:

(draggingSourceOperationMaskToDragCursors):
(WebDragClient::startDrag):

WebView.cpp:

(dragOperationToDragCursor):
(WebView::keyStateToDragOperation const):
(WebView::DragLeave):

WebView.h:

(WebView::keyStateToDragOperation const):

Source/WTF:

wtf/OptionSet.h:

(WTF::OptionSet::OptionSet):

Add constructor for OptionSet(Optional).

8:02 AM Changeset in webkit [262679] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC] FormattingContext::Geometry::computedValue should not try to resolve values when layout is required
https://bugs.webkit.org/show_bug.cgi?id=212867

Reviewed by Antti Koivisto.

This is in preparation for adding min/max/fit-content support.

layout/FormattingContext.h:
layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedWidth const):
(WebCore::Layout::FormattingContext::Geometry::computedValue const):
(WebCore::Layout::FormattingContext::Geometry::computedMinWidth const):
(WebCore::Layout::FormattingContext::Geometry::computedMaxWidth const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset const):
(WebCore::Layout::FormattingContext::Geometry::computedHorizontalMargin const):
(WebCore::Layout::FormattingContext::Geometry::computedVerticalMargin const):
(WebCore::Layout::FormattingContext::Geometry::computedValueIfNotAuto const): Deleted.

layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):

7:57 AM Changeset in webkit [262678] by Andres Gonzalez

2 edits in trunk/LayoutTests

[Win EWS] REGRESSION (r262500): accessibility/svg-text.html always fails
https://bugs.webkit.org/show_bug.cgi?id=212845

Unreviewed test gardening.

platform/win/TestExpectations:

7:11 AM Changeset in webkit [262677] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Make CodeBlockHash robust against unreasonably long source code.
https://bugs.webkit.org/show_bug.cgi?id=212847
<rdar://problem/64024279>

Reviewed by Saam Barati.

This patch adds a heuristic to avoid trying to compute the CodeBlockHash on
unreasonably long source code strings. This is done by first applying a length
check and, if needed, computing the hash with an alternate method.

This is OK to do because:

CodeBlockHash is not a critical hash.
In practice, reasonable source code are not that long.
And if they are that long, then we are still diversifying the hash on their length. But if they do collide, it's OK.

The only invariant here is that we should always produce the same hash for the
same source string. Since the algorithm is deterministic, this invariant is not
violated.

bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::CodeBlockHash):

6:53 AM Changeset in webkit [262676] by Jonathan Bedard

3 edits in trunk/Source/WebKitLegacy/mac

WebKitLegacy: Link to framework stubs for watchOS and tvOS
https://bugs.webkit.org/show_bug.cgi?id=212855
<rdar://problem/64049486>

Reviewed by Tim Horton.

Configurations/Base.xcconfig: Define tvOS and watchOS major version macros.
Configurations/WebKitLegacy.xcconfig: Link to framework stubs for watchOS and tvOS.

6:02 AM Changeset in webkit [262675] by Devin Rousso

4 edits in trunk/LayoutTests

(r261103) [ Mac WK2 ] inspector/page/overrideSetting-ITPDebugModeEnabled.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=211791
<rdar://problem/63147694>

Reviewed by Timothy Hatcher.

inspector/page/overrideSetting-ITPDebugModeEnabled.html:
inspector/page/overrideSetting-ITPDebugModeEnabled-expected.txt:

Wait for three console messages instead of one, as we know there should be at least three.

platform/mac-wk2/TestExpectations:

5:51 AM Changeset in webkit [262674] by Devin Rousso

4 edits in trunk/LayoutTests

[ macOS ] inspector/debugger/break-in-constructor-before-super.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=210062
<rdar://problem/61351481>

Reviewed by Timothy Hatcher.

inspector/debugger/break-in-constructor-before-super.html:
inspector/debugger/debugger-statement.html:
platform/mac/TestExpectations:

5:47 AM Changeset in webkit [262673] by Devin Rousso

38 edits in trunk/Source

Web Inspector: unify the naming scheme for agents used by instrumentation
https://bugs.webkit.org/show_bug.cgi?id=212859

Reviewed by Timothy Hatcher.

Inspector agents fall into one of three categories:

"persistent" when Web Inspector is connected
"enabled" when that agent is enabled, such as if the corresponding tab is visible
"tracking" when that agent is part of a timeline recording.

The only exception to this is the Console agent, as that exists regardless of whether Web
Inspector is connected as it needs to preserve messages logged before Web Inspector connects.

Also remove the "Inspector" prefix from getter/setter methods as it adds confusion if that
agent also has subclasses (e.g. InspectorRuntimeAgent and PageRuntimeAgent).

Source/JavaScriptCore:

inspector/JSGlobalObjectConsoleClient.h:
inspector/JSGlobalObjectInspectorController.cpp:
inspector/agents/InspectorConsoleAgent.h:

Source/WebCore:

inspector/InstrumentingAgents.h:
inspector/InstrumentingAgents.cpp:

Use macros to simplify the process of adding an agent.

inspector/CommandLineAPIHost.cpp:
inspector/InspectorController.h:
inspector/InspectorController.cpp:
inspector/InspectorInstrumentation.cpp:
inspector/agents/InspectorAnimationAgent.cpp:
inspector/agents/InspectorApplicationCacheAgent.cpp:
inspector/agents/InspectorCPUProfilerAgent.cpp:
inspector/agents/InspectorCSSAgent.cpp:
inspector/agents/InspectorCanvasAgent.cpp:
inspector/agents/InspectorDOMAgent.cpp:
inspector/agents/InspectorDOMDebuggerAgent.cpp:
inspector/agents/InspectorDOMStorageAgent.cpp:
inspector/agents/InspectorDatabaseAgent.cpp:
inspector/agents/InspectorLayerTreeAgent.cpp:
inspector/agents/InspectorMemoryAgent.cpp:
inspector/agents/InspectorNetworkAgent.cpp:
inspector/agents/InspectorPageAgent.cpp:
inspector/agents/InspectorTimelineAgent.cpp:
inspector/agents/InspectorWorkerAgent.cpp:
inspector/agents/WebDebuggerAgent.cpp:
inspector/agents/WebHeapAgent.cpp:
inspector/agents/page/PageConsoleAgent.cpp:
inspector/agents/page/PageDOMDebuggerAgent.cpp:
inspector/agents/page/PageDebuggerAgent.cpp:
inspector/agents/page/PageHeapAgent.cpp:
inspector/agents/page/PageNetworkAgent.cpp:
inspector/agents/page/PageRuntimeAgent.cpp:

Simple naming changes elided to avoid a long ChangeLog.

Source/WebKit:

UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp:
UIProcess/Inspector/WebInspectorProxy.cpp:
UIProcess/Inspector/WebPageInspectorController.h:

Simple naming changes elided to avoid a long ChangeLog.

12:17 AM Changeset in webkit [262672] by Peng Liu

2 edits in trunk/Tools

REGRESSION (r262456): [iOS Debug] TestWebKitAPI.WKWebViewCloseAllMediaPresentations.PictureInPicture is frequently timing out
https://bugs.webkit.org/show_bug.cgi?id=212777

Unreviewed test gardening.

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:

Disable the PictureInPicture test for old iOS devices.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed