Timeline

Jun 8, 2020:

11:54 PM Changeset in webkit [262778] by sihui_liu@apple.com

• 5 edits in trunk

TextManipulation should only convert text from Node's text content to tokens
​https://bugs.webkit.org/show_bug.cgi?id=212928

Reviewed by Wenson Hsieh.

Source/WebCore:

TextIterator may emit text like line breaks between nodes. This kind of text is generated based on the range of
TextIterator and style of node. We need this text for splitting tokens or splitting paragraphs, but we should
not convert it to normal tokens. This is because tokens should be created from content of node and text
manipulation fails if content does not match. The change of this kind of text does not indicate change in
content and we may still be able to finish text manipulation.

Test: TextManipulation.CompleteTextManipulationReplaceTwoSimpleParagraphs

• editing/TextManipulationController.cpp:

(WebCore::isInPrivateUseArea):
(WebCore::isTokenDelimiter):
(WebCore::ParagraphContentIterator::currentContent):
(WebCore::ParagraphContentIterator::appendToText):
(WebCore::ParagraphContentIterator::advanceIteratorNodeAndUpdateText):
(WebCore::TextManipulationController::createUnit):
(WebCore::TextManipulationController::parse):
(WebCore::TextManipulationController::observeParagraphs):
(WebCore::TextManipulationController::replace):

• editing/TextManipulationController.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

11:50 PM Changeset in webkit [262777] by Diego Pino Garcia

• 4 edits in trunk/LayoutTests

[WPE] Gardening, update test expectations after r262763
​https://bugs.webkit.org/show_bug.cgi?id=212961

Unreviewed gardening.

• platform/glib/TestExpectations: Moved several bugs that were also hapenning in WPE from GTK to GLIB.
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations: Removed test passing and filed a few new bugs.

11:44 PM Changeset in webkit [262776] by commit-queue@webkit.org

• 6 edits
  2 deletes in trunk

XMLHTTPRequest.send should not send Content-Type headers when Blob has no type
​https://bugs.webkit.org/show_bug.cgi?id=211999

Patch by Rob Buis <​rbuis@igalia.com> on 2020-06-08
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Update improved test expectation.

• web-platform-tests/xhr/send-blob-with-no-mime-type-expected.txt:

Source/WebCore:

XMLHTTPRequest.send should not send Content-Type headers when Blob has no type [1, 2].
This behavior overrides the behavior of the File API spec [3].

Behavior matches Firefox and Chrome.

Test: imported/w3c/web-platform-tests/xhr/send-blob-with-no-mime-type.html

[1] ​https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send
[2] ​https://fetch.spec.whatwg.org/#concept-bodyinit-extract
[3] ​http://dev.w3.org/2006/webapi/FileAPI/#dfn-type

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

LayoutTests:

Remove unneeded expectations.

• platform/ios/imported/w3c/web-platform-tests/xhr/send-blob-with-no-mime-type-expected.txt: Removed.
• platform/mac/imported/w3c/web-platform-tests/xhr/send-blob-with-no-mime-type-expected.txt: Removed.

10:37 PM Changeset in webkit [262775] by Diego Pino Garcia

• 3 edits in trunk/Tools

[webkitpy] Check 'bug-search' returns a non null result before parsing
​https://bugs.webkit.org/show_bug.cgi?id=212906

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(BugzillaQueries._parse_result_count): Check quick-search query
response is non-null and a non-empty text.

10:29 PM Changeset in webkit [262774] by Simon Fraser

• 4 edits
  3 adds in trunk

Horizontally scrolling elements are broken when revealed by toggling visibility
​https://bugs.webkit.org/show_bug.cgi?id=212439
<rdar://problem/63739559>

Reviewed by Zalan Bujtas.

Source/WebCore:

When revealing an overflow:scroll by toggling the visibility property, make sure that
we use composited scrolling.

computeScrollDimensions() is only updated on layout, so we need to recompute m_hasCompositedScrollableOverflow
on style change as well.

Test: compositing/scrolling/async-overflow-scrolling/toggle-visibility-on-scroller.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::computeHasCompositedScrollableOverflow):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayer.h:

LayoutTests:

• compositing/scrolling/async-overflow-scrolling/toggle-visibility-on-scroller-expected.txt: Added.
• compositing/scrolling/async-overflow-scrolling/toggle-visibility-on-scroller.html: Added.
• platform/ios-wk2/compositing/scrolling/async-overflow-scrolling/toggle-visibility-on-scroller-expected.txt: Added.

10:21 PM Changeset in webkit [262773] by Russell Epstein

• 8 edits in branches/safari-610.1.15.52-branch/Source

Versioning.

10:19 PM Changeset in webkit [262772] by Russell Epstein

• 8 edits in branches/safari-610.1.15.51-branch/Source

Versioning.

10:18 PM Changeset in webkit [262771] by Russell Epstein

• 8 edits in branches/safari-610.1.15.50-branch/Source

Versioning.

10:10 PM Changeset in webkit [262770] by Russell Epstein

• 1 copy in branches/safari-610.1.15.52-branch

New branch.

10:10 PM Changeset in webkit [262769] by Russell Epstein

• 1 copy in branches/safari-610.1.15.51-branch

New branch.

10:09 PM Changeset in webkit [262768] by Russell Epstein

• 1 copy in branches/safari-610.1.15.50-branch

New branch.

9:58 PM Changeset in webkit [262767] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK] Gardening, update test expectations after r262763
​https://bugs.webkit.org/show_bug.cgi?id=212957

Unreviewed gardening.

• platform/glib/TestExpectations: Mark one test as flaky.
• platform/gtk/TestExpectations: Remove two tests passing after r262740.

9:48 PM Changeset in webkit [262766] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WebDriver][WPE] Gardening most of the remaining WPE failures.

Unreviewed test gardening.

• TestExpectations.json:

9:34 PM Changeset in webkit [262765] by Chris Fleizach

• 2 edits in trunk/Source/WTF

HAVE(ACCESSIBILITY_BUNDLES_PATH) is defined in terms of PLATFORM(IOS_FAMILY) but only checks the version of IPHONE_OS_VERSION_MIN_REQUIRED
​https://bugs.webkit.org/show_bug.cgi?id=212704
<rdar://problem/63931340>

Reviewed by Darin Adler.

Ensure that this works for all iOS familes.

• wtf/PlatformHave.h:

8:24 PM Changeset in webkit [262764] by Jonathan Bedard

• 2 edits in trunk/Source/WebKitLegacy/mac

WebKitLegacy: Exclude NSURLConnectionSPI.h from watchOS
​https://bugs.webkit.org/show_bug.cgi?id=212942
<rdar://problem/64141877>

Reviewed by Alexey Proskuryakov.

• Misc/WebDownload.h: Exclude NSURLConnectionSPI.h from watchOS, replace

CFNSURLConnection.h with NSURLConnectionSPI.h.

7:19 PM Changeset in webkit [262763] by Ross Kirsling

• 8 edits in trunk/JSTests

[Intl] Update tests to support ICU 67
​https://bugs.webkit.org/show_bug.cgi?id=212943

Reviewed by Yusuke Suzuki.

Our tests have been assuming ICU 60-64 results but WinCairo and PlayStation are now on ICU 67,
which includes fixes for variant alphabetization and non-explicit "-true" values in locale strings.

• stress/intl-collator.js:

(explicitTrueBeforeICU67):
(shouldBe.testCollator.Intl.Collator):

• stress/intl-datetimeformat.js:
• stress/intl-locale.js:
• stress/intl-numberformat.js:
• stress/intl-object.js:
• stress/intl-pluralrules.js:
• stress/intl-relativetimeformat.js:

6:26 PM Changeset in webkit [262762] by ddkilzer@apple.com

• 5 edits in trunk/Source/WebKit

[IPC] Adopt enum class for IPC::CFType
<​https://webkit.org/b/212921>
<rdar://problem/64134506>

Reviewed by Darin Adler.

Summary:

• Convert IPC::CFType to enum class.
• Rule for new enum names is to remove "Ref" suffix from the actual type name.
• Special enum CFType::Null renamed to CFType::Nullptr to differentiate from CFType::CFNull objects.

• Shared/cf/ArgumentCodersCF.cpp:

(IPC::tokenNullTypeRef): Delete.
(IPC::tokenNullptrTypeRef): Add.

• Rename tokenNullTypeRef() to tokenNullptrTypeRef().

(IPC::CFType):

• Convert to enum class.

(IPC::typeFromCFTypeRef):
(IPC::encode):

• Switch from encodeEnum() to operator<<().

(IPC::decode):

• Switch from decodeEnum() to decode().

(WTF::EnumTraits<IPC::CFType>): Add.

• Shared/cf/ArgumentCodersCF.h:

(IPC::tokenNullTypeRef): Delete.
(IPC::tokenNullptrTypeRef): Add.

• Rename tokenNullTypeRef() to tokenNullptrTypeRef().
• Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<WebCore::ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::ResourceRequest>::decodePlatformData):

• Switch to use tokenNullptrTypeRef().
• mac/WebKit2.order:
• Update symbol name after renaming tokenNullTypeRef().

6:11 PM Changeset in webkit [262761] by Russell Epstein

• 2 edits in branches/safari-610.1.15.5.0-branch/Source/WebKit

Cherry-pick r262644. rdar://problem/64127898

[iOS] Remove message filtering telemetry for expected case
​https://bugs.webkit.org/show_bug.cgi?id=212841
<rdar://problem/63893460>

Reviewed by Per Arne Vollan.

Remove unintentional telemetry being captured for expected behavior.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:11 PM Changeset in webkit [262760] by Russell Epstein

• 2 edits in branches/safari-610.1.15.5.0-branch/Source/WebKit

Cherry-pick r262636. rdar://problem/64136089

[iOS] Fix message filter sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=212837
<rdar://problem/63830368>

Reviewed by Darin Adler.

Add required message to message filter in the iOS WebContent sandbox.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:08 PM Changeset in webkit [262759] by Russell Epstein

• 8 edits in branches/safari-610.1.15.5.0-branch/Source

Versioning.

5:59 PM Changeset in webkit [262758] by Russell Epstein

• 2 edits in branches/safari-610.1.15.5.2-branch/Source/WebKit

Cherry-pick r262636. rdar://problem/64127485

[iOS] Fix message filter sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=212837
<rdar://problem/63830368>

Reviewed by Darin Adler.

Add required message to message filter in the iOS WebContent sandbox.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:49 PM Changeset in webkit [262757] by Russell Epstein

• 8 edits in branches/safari-610.1.15.5.2-branch/Source

Versioning.

5:35 PM Changeset in webkit [262756] by Jonathan Bedard

• 2 edits in trunk/Source/WebCore/PAL

WebCore: Guard _preconnect declaration with ENABLE(SERVER_PRECONNECT)
​https://bugs.webkit.org/show_bug.cgi?id=212935
<rdar://problem/64139060>

Reviewed by Alexey Proskuryakov.

• pal/spi/cf/CFNetworkSPI.h:

5:22 PM Changeset in webkit [262755] by Alan Coon

• 1 copy in tags/Safari-610.1.16.2

Tag Safari-610.1.16.2.

5:16 PM Changeset in webkit [262754] by Alan Coon

• 8 edits in branches/safari-610.1.16-branch/Source

Versioning.

5:10 PM Changeset in webkit [262753] by weinig@apple.com

• 8 edits in trunk

Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()
​https://bugs.webkit.org/show_bug.cgi?id=212917

Reviewed by Darin Adler.

Addresses feedback from Darin.

Source/WebCore:

• platform/graphics/Color.cpp:

(WebCore::Color::lightened const):
(WebCore::Color::darkened const):
(WebCore::Color::lighten const): Deleted.
(WebCore::Color::darken const): Deleted.

• platform/graphics/Color.h:
• rendering/RenderObject.cpp:

(WebCore::RenderObject::calculateBorderStyleColor):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::disabledTextColor const):

• rendering/TextPaintStyle.cpp:

(WebCore::adjustColorForVisibilityOnBackground):

Tools:

• TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):

4:47 PM Changeset in webkit [262752] by Kate Cheney

• 2 edits in trunk/Source/WebKit

ResourceLoadStatisticsDatabaseStore::domainIDFromString failed, error message: bad parameter or other API misuse
​https://bugs.webkit.org/show_bug.cgi?id=212916
<rdar://problem/64127238>

Reviewed by Sihui Liu.

Make sure m_domainIDFromStringStatement is accessed in a separate
scope in ensureResourceStatisticsForRegistrableDomain() so it will be
reset before being used again.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::domainID const):
Add debug assert to ensure that tests catch this case.

(WebKit::ResourceLoadStatisticsDatabaseStore::ensureResourceStatisticsForRegistrableDomain const):

4:22 PM Changeset in webkit [262751] by Devin Rousso

• 2 edits in trunk/Source/WebCore

Remove unnecessary variable in WindowProxy::createJSWindowProxy
​https://bugs.webkit.org/show_bug.cgi?id=212929

Reviewed by Darin Adler.

• bindings/js/WindowProxy.cpp:

(WebCore::WindowProxy::createJSWindowProxy):

4:03 PM Changeset in webkit [262750] by Alan Coon

• 1 copy in branches/safari-610.1.15.5.2-branch

New branch.

4:03 PM Changeset in webkit [262749] by Alan Coon

• 1 copy in branches/safari-610.1.15.5.1-branch

New branch.

4:02 PM Changeset in webkit [262748] by Alan Coon

• 1 copy in branches/safari-610.1.15.5.0-branch

New branch.

3:48 PM Changeset in webkit [262747] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Turn some WebPageProxy logging into error logging
​https://bugs.webkit.org/show_bug.cgi?id=212922
<rdar://problem/63894722>

Reviewed by Geoffrey Garen.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::processDidTerminate):
(WebKit::WebPageProxy::dispatchProcessDidTerminate):
(WebKit::WebPageProxy::tryReloadAfterProcessTermination):
(WebKit::WebPageProxy::didExceedInactiveMemoryLimitWhileActive):
(WebKit::WebPageProxy::didExceedBackgroundCPULimitWhileInForeground):

3:46 PM Changeset in webkit [262746] by keith_miller@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Removed unneeded POINTER_WIDTH macro from b3
​https://bugs.webkit.org/show_bug.cgi?id=212927

Reviewed by Yusuke Suzuki.

C++20 has real constexpr functions so we don't need the
POINTER_WIDTH macro anymore.

• b3/B3Width.h:

(JSC::B3::pointerWidth):

• b3/air/opcode_generator.rb:

3:38 PM Changeset in webkit [262745] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

Gardening, remove tests passing after r262716
​https://bugs.webkit.org/show_bug.cgi?id=212923

Unreviewed gardening.

Several css-grid tests marked as failure are passing in all platforms after r262716.

• TestExpectations:

3:29 PM Changeset in webkit [262744] by Alan Coon

• 1 copy in tags/Safari-610.1.15.5

Tag Safari-610.1.15.5.

3:14 PM Changeset in webkit [262743] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=212714

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-06-08
Reviewed by Geoffrey Garen.

Widget removal in the middle of building a Render Tree causes side effects, leading to Release Assert. Moved the scope for suspension of widgets
update to RenderTreeBuilder instead of having it in RenderTreeUpdater.

Test would be added later.

• rendering/updating/RenderTreeBuilder.h:
• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::tearDownRenderers):

3:03 PM Changeset in webkit [262742] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Gardening, update expectations after 262724
​https://bugs.webkit.org/show_bug.cgi?id=212926

Unreviewed gardening.

Add failure to test expectationd and remove failing test that is
passing since r262466.

• platform/gtk/TestExpectations:

2:44 PM Changeset in webkit [262741] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK][WPE] Remove test failures passing after r262707
​https://bugs.webkit.org/show_bug.cgi?id=212924

Unreviewed gardening.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

2:34 PM Changeset in webkit [262740] by weinig@apple.com

• 2 edits in trunk/Tools

Fix test results after r262733.

• TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):

2:07 PM Changeset in webkit [262739] by ysuzuki@apple.com

• 4 edits in trunk/Source/WebCore

Use usual promise in readableStreamTee
​https://bugs.webkit.org/show_bug.cgi?id=212715

Reviewed by Mark Lam.

The spec[1] is organized to be OK to use usual promises here. This patch uses usual promises instead of internal ones.

[1]: ​https://streams.spec.whatwg.org/#readable-stream-tee

• Modules/streams/ReadableStreamInternals.js:

(readableStreamTee):

1:43 PM Changeset in webkit [262738] by keith_miller@apple.com

• 9 edits in trunk/JSTests

Fix tests that time out on Series 4 Watch
​https://bugs.webkit.org/show_bug.cgi?id=212911

Reviewed by Saam Barati.

Simplify some logic about when to skip microbenchmarks to $jitTests.
Also reduce iteration count for
dont-range-based-iterate-vector-that-is-mutated.js

Also, mark wasm tests as not run on watch.

• microbenchmarks/bit-test-constant.js:
• microbenchmarks/bit-test-nonconstant.js:
• microbenchmarks/interpreter-wasm.js:
• microbenchmarks/memcpy-typed-loop-large.js:
• microbenchmarks/memcpy-typed-loop-small.js:
• microbenchmarks/mul-immediate-sub.js:
• stress/dont-range-based-iterate-vector-that-is-mutated.js:
• stress/sampling-profiler-richards.js:

1:36 PM Changeset in webkit [262737] by achristensen@apple.com

• 2 edits in branches/safari-609-branch/Tools

Fix branch build after r262552

• TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:

(TestWebKitAPI::TEST):
The branch WTF::URL has an operator NSURL * and an operator NSString *, so we need to specify which to use.

1:30 PM Changeset in webkit [262736] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WebDriver][GTK][WPE] Fix overwritten expectations.

WPE's set_window_rect/set.py expectations were in a block after the
existing ones from other ports, overwriting them. This commit now
merges them to be in a single block.

Unreviewed test gardening.

• TestExpectations.json:

1:07 PM Changeset in webkit [262735] by ddkilzer@apple.com

• 22 edits in trunk

[IPC] Adopt enum class for DragOperation
<​https://webkit.org/b/212870>
<rdar://problem/64069940>

Reviewed by Darin Adler.

Source/WebCore:

• dom/DataTransfer.cpp:

(WebCore::dragOpFromIEOp):
(WebCore::IEOpFromDragOp):
(WebCore::DataTransfer::sourceOperationMask const):
(WebCore::DataTransfer::destinationOperationMask const):
(WebCore::DataTransfer::setSourceOperationMask):
(WebCore::DataTransfer::setDestinationOperationMask):
(WebCore::DataTransfer::setEffectAllowed):

• page/DragActions.h:

(WebCore::DragOperation):

• Convert to enum class.

(WebCore::anyDragOperation):

• page/DragController.cpp:

(WebCore::DragController::platformGenericDragOperation):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag):
(WebCore::defaultOperationForDrag):
(WebCore::DragController::startDrag):

• page/EventHandler.cpp:

(WebCore::convertDropZoneOperationToDragOperation):
(WebCore::convertDragOperationToDropZoneOperation):

• page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::dragOperation):

• page/mac/DragControllerMac.mm:

(WebCore::DragController::dragOperation):
(WebCore::DragController::platformGenericDragOperation):

• page/win/DragControllerWin.cpp:

(WebCore::DragController::dragOperation):

• platform/gtk/GtkUtilities.cpp:

(WebCore::gdkDragActionToDragOperation):
(WebCore::dragOperationToGdkDragActions):
(WebCore::dragOperationToSingleGdkDragAction):

Source/WebKit:

• Scripts/webkit/messages.py:
• Remove FIXME now that it's not needed.
• Shared/API/Cocoa/_WKDragActionsInternal.h:

(WebKit::coreDragOperationMask):

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::kit):

• UIProcess/ios/WKContentViewInteraction.mm:

(dropOperationForWebCoreDragOperation):
(coreDragOperationForUIDropOperation):
(-[WKContentView dragDataForDropSession:dragDestinationAction:]):

Source/WebKitLegacy/mac:

• WebView/WebHTMLView.mm:

(kit):

• WebView/WebView.mm:

(coreDragOperationMask):
(kit):

Source/WebKitLegacy/win:

• WebCoreSupport/WebDragClient.cpp:

(draggingSourceOperationMaskToDragCursors):
(WebDragClient::startDrag):

• WebView.cpp:

(dragOperationToDragCursor):
(WebView::keyStateToDragOperation const):

Tools:

• Scripts/do-webcore-rename:
• Do DragOperation renames.

1:04 PM Changeset in webkit [262734] by commit-queue@webkit.org

• 7 edits in trunk

Unreviewed, reverting r262685.
​https://bugs.webkit.org/show_bug.cgi?id=212914

caused flakey crashes in an iOS test

Reverted changeset:

"Clear WebPageProxy event state between tests"
​https://bugs.webkit.org/show_bug.cgi?id=212864
​https://trac.webkit.org/changeset/262685

12:37 PM Changeset in webkit [262733] by weinig@apple.com

• 27 edits in trunk

Extended Color: Unify rounding / clamping conversions between 0-1 float components and 0-255 byte components
​https://bugs.webkit.org/show_bug.cgi?id=212871

Reviewed by Simon Fraser.
Source/WebCore:

Unify all conversions of 0.0f - 1.0f float based color components to 0-255 int based color components
to use the new convertToComponentByte() function which scales, rounds (using lroundf) and clamps the
value. For consistency, a convertToComponentFloat() function, which just scales down an int based value
to a float based value, is also added.

• Removes *UsingAlternativeRounding variants (actually, we now only have this variant) for color functions which allowed callers to pick from truncation vs. rounding when overriding alpha.
• Replaces all uses of scaleRoundAndClampColorChannel() with convertToComponentByte() (really just a rename).
• Replaces uses of nextafter(256, 0) based conversions with convertToComponentByte().

Also:

• Moves roundAndClampColorChannel() functions to SVGAnimationAdditiveValueFunctionImpl.h, which was the only places they were used.
• Removes areEssentiallyEqual() overload taking ColorComponents<float>. It was ununsed.
• Removes makeSimpleColorFromHSLA(...) and just inlines makeSimpleColor(hslToSRGB(...)) which now does the same thing.

• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::clampRGBComponent):
Use convertPrescaledToComponentByte() to round and clamp the components.

(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
Use uint8_t more consistently now that helpers ensure that is the return type
of conversion functions.

(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
Switch to using makeSimpleColor(hslToSRGB(...)) directly.

• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):
Switch to using makeSimpleColor(hslToSRGB(...)) directly.

• html/HTMLElement.cpp:

(WebCore::parseLegacyColorValue):
Use uint8_t since that is what toASCIIHexValue() returns.

• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::setStrokeStyle):
(WebCore::CanvasRenderingContext2DBase::setFillStyle):
(WebCore::CanvasRenderingContext2DBase::setShadow):

• html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::createFromStringWithOverrideAlpha):
Replaces uses of colorWithAlphaUsingAlternativeRounding() with colorWithAlpha().

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::parseColor):
Use convertToComponentByte() rather than a simple truncating cast.

• platform/graphics/Color.cpp:

(WebCore::Color::light const):
(WebCore::Color::dark const):
Use makeSimpleColorFromFloats() rather than nextafterf(256.0f, 0.0f) conversion.

(WebCore::Color::colorWithAlpha const):
(WebCore::Color::invertedColorWithAlpha const):
Use convertToComponentByte() for alpha conversion.

(WebCore::Color::toSRGBASimpleColorLossy const):
Call asExtended().toSRGBAComponentsLossy() directly to avoid unnecessary branch.

(WebCore::Color::colorWithAlphaMultipliedBy const): Deleted.
(WebCore::Color::colorWithAlphaMultipliedByUsingAlternativeRounding const): Deleted.
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const): Deleted.
Remove UsingAlternativeRounding variants.

• platform/graphics/Color.h:

(WebCore::Color::alpha const):
Use convertToComponentByte() for alpha conversion.

(WebCore::Color::invertedColorWithAlpha const):
Add an overload taking an Optional<float> for consistency.

(WebCore::Color::colorWithAlphaMultipliedBy const):
(WebCore::Color::colorWithAlpha const):
Simplify by inlining all variants except the main colorWithAlpha().

• platform/graphics/ColorUtilities.cpp:

(WebCore::areEssentiallyEqual): Deleted.
Remove unused function.

• platform/graphics/ColorUtilities.h:

(WebCore::convertPrescaledToComponentByte):
Added. Useful for callers who already have prescaled values but need rounding/clamping.

(WebCore::convertToComponentByte):
Added. Bottleneck for float to byte based color component conversions.
(WebCore::convertToComponentFloat):
Added. Bottleneck for byte to float based color component conversions.

• platform/graphics/SimpleColor.cpp:

(WebCore::makeSimpleColorFromCMYKA):
Use makeSimpleColorFromFloats() rather than nextafterf(256.0f, 0.0f) conversion. Eventually,
when we probably want this to go away and store CMYKA colors as ExtendedColors with their own
color space.

(WebCore::makeSimpleColorFromFloats):
Moved to header.

• platform/graphics/SimpleColor.h:

(WebCore::SimpleColor::alphaComponentAsFloat const):
Use convertToComponentFloat().

(WebCore::SimpleColor::asSRGBFloatComponents const):
Use convertToComponentFloat().

(WebCore::makeSimpleColor):
Avoid unncessary clamping of the alpha component by calling constructor directly.

(WebCore::makeSimpleColorFromFloats):
Inlined. Calls convertToComponentByte now rather than the older (identical) scaleRoundAndClampColorChannel().

• platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::prepareCairoContextSource):
Replaces use of colorWithAlphaMultipliedByUsingAlternativeRounding with colorWithAlphaMultipliedBy().

• platform/graphics/cg/ColorCG.cpp:

(WebCore::makeSimpleColorFromCGColor):
Use makeSimpleColorFromFloats() rather than nextafter(256.0, 0.0) conversion.

• platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::platformApplySoftware):
Replaces use of colorWithAlphaMultipliedByUsingAlternativeRounding with colorWithAlphaMultipliedBy().

• platform/graphics/mac/ColorMac.mm:

(WebCore::makeSimpleColorFromNSColor):
Use makeSimpleColorFromFloats() rather than nextafter(256.0, 0.0) conversion.

• platform/ios/ColorIOS.mm:

(WebCore::colorFromUIColor):
Use makeSimpleColorFromFloats() rather than nextafter(256.0, 0.0) conversion.

• svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::stopColorIncludingOpacity const):
Replaces use of colorWithAlphaMultipliedByUsingAlternativeRounding with colorWithAlphaMultipliedBy().

• svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:

(WebCore::SVGAnimationColorFunction::roundAndClampColorChannel):
Moved from ColorUtilities.h as this was the only use.

Source/WebKit:

• UIProcess/API/ios/WKWebViewIOS.mm:

(scrollViewBackgroundColor):
Replaces uses of colorWithAlphaUsingAlternativeRounding() with colorWithAlpha().

Tools:

• TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):
Switch to using makeSimpleColor(hslToSRGB(...)) directly.

LayoutTests:

• fast/css/ios/system-color-for-css-value-expected.txt:
• fast/css/ios/system-color-for-css-value.html:

Update test to account for slightly differnt rounding (alpha goes from 0.298 to 0.3).

12:09 PM Changeset in webkit [262732] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit

Links in NSAttributedString passed to -[WKWebView _showSafeBrowsingWarningWithURL:title:warning:details:completionHandler:] are ignored
​https://bugs.webkit.org/show_bug.cgi?id=212801
<rdar://problem/63027631>

Patch by Richard Houle <​rhoule@apple.com> on 2020-06-08
Reviewed by Alex Christensen.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _showSafeBrowsingWarningWithTitle:warning:details:completionHandler:]): Call the new detailsWithLinks
implementation, asserting if an URL is non nil.
(-[WKWebView _showSafeBrowsingWarningWithURL:title:warning:details:completionHandler:]): Ditto.
(-[WKWebView _showSafeBrowsingWarningWithURL:title:warning:detailsWithLinks:completionHandler:]): Pass the URL to
the completion handler when appropriate.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

11:54 AM Changeset in webkit [262731] by Russell Epstein

• 8 edits in branches/safari-610.1.15-branch/Source

Versioning.

11:44 AM Changeset in webkit [262730] by pvollan@apple.com

• 4 edits in trunk/Source

[Cocoa] Adopt read-only mode for preferences in the WebContent process
​https://bugs.webkit.org/show_bug.cgi?id=212411

Reviewed by Darin Adler.

Change name of HAVE define to match SPI name.

Source/WebKit:

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceMain):

Source/WTF:

• wtf/PlatformHave.h:

11:38 AM Changeset in webkit [262729] by weinig@apple.com

• 9 edits in trunk

Extended Color: Replace uses of differenceSquared() with luminance based computations
​https://bugs.webkit.org/show_bug.cgi?id=212872

Reviewed by Darin Adler.

Source/WebCore:

Replace all uses of differenceSquared() with luminance based comparisons. This is
possible because all of the uses of differenceSquared() were about identifying a
distance from black or white to determine relative brightness. It is more accurate
to do this in terms of luminance, and has the added benefit of being something that
is expressible in all colorspaces (since luminance is defined as the Y-component
of the XYZ colorspace which all colorspaces are convertable to).

• platform/graphics/Color.cpp:

(WebCore::Color::lighten const):
Renamed Color::light() to Color::lighten(), which makes more sense. The algorithm
used should be updated at some point to also use luminance, but is unchanged for
now.

(WebCore::Color::darken const):
Renamed Color::dark() to Color::darken(), which makes more sense. The algorithm
used should be updated at some point to also use luminance, but is unchanged for
now.

(WebCore::Color::luminance const):
Added. Converts to sRGB for now, but can be updated to work with other color spaces
when needed.

• platform/graphics/Color.h:

Removed differenceSquared.

• platform/graphics/ColorUtilities.cpp:

(WebCore::luminance):
Updated to use the standard conversion to linear-sRGB. While there are certainly
some places that specify a 0.03928 cutoff, the much more accepted value (and value
specified by the IEC) is 0.04045, which we use for all other gamma correction.
(See ​https://entropymine.com/imageworsener/srgbformula/ or ​https://en.wikipedia.org/wiki/SRGB#The_forward_transformation_(CIE_XYZ_to_sRGB)
for more information on this).

Also added a FIXME about how in the future we can avoid hardcoding the specific values
multiple times by extracting them from the linear-sRGB to XYZ matrix.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::calculateBorderStyleColor):
Use luminance, rather than distance as a better comparison for whether the color
is too dark or too light for modification.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::disabledTextColor const):
Use luminance, rather than distance as a better comparison for whether the color
is too dark or too light for modification. Also us the contrastRatio utility
function to determine illegibility issues due to contrast, picking a new minimum
that roughly matches the old one based fast/forms/input-disabled-color.html

• rendering/TextPaintStyle.cpp:

(WebCore::adjustColorForVisibilityOnBackground):
Use luminance, rather than distance as a better comparison for whether the color
is too dark or too light for modification.

Tools:

• TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):
Add basic tests for Color::luminance(), ensuring white == 1, black == 0, and
darken() and lighten() creat colors with less than / greater than luminance.

11:14 AM Changeset in webkit [262728] by youenn@apple.com

• 7 edits in trunk

Missing WebRTC Metrics in iOS Safari
​https://bugs.webkit.org/show_bug.cgi?id=212668
<rdar://problem/63902458>

Reviewed by Eric Carlson.

Source/WebCore:

Expose more transports related stats.
Covered by updated test.

• Modules/mediastream/RTCStatsReport.h:
• Modules/mediastream/RTCStatsReport.idl:
• Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:

(WebCore::fillRTCTransportStats):

LayoutTests:

• webrtc/video-stats-expected.txt:
• webrtc/video-stats.html:

11:11 AM Changeset in webkit [262727] by Alexey Shvayka

• 4 edits
  1 add in trunk

JSON.stringify should throw stack overflow error
​https://bugs.webkit.org/show_bug.cgi?id=143511

Reviewed by Ross Kirsling and Mark Lam.

JSTests:

• stress/json-stringify-stack-overflow.js: Added.
• stress/json-stringify-string-builder-overflow.js:

Source/JavaScriptCore:

This change adds m_holderStack.size() check, reusing the limit of JSON.parse,
and throws StackOverflowError if exceeded, aligning JSC with V8 and SpiderMonkey.
Even with all the cyclic structure checks in place, excess is possible due to
very deeply nested object, user-provided "toJSON" method or functional replacer.

While Stringifier::appendStringifiedValue() and Holder::appendNextProperty()
mutually call each other, recursion is avoided by !holderStackWasEmpty check and
do/while loop at the end of appendStringifiedValue(), as well as cyclic structure
check as per spec [1].

[1]: ​https://tc39.es/ecma262/#sec-serializejsonobject (step 1)

• runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):

11:10 AM Changeset in webkit [262726] by youenn@apple.com

• 10 edits in trunk

Add missed WebRTC media-source and remote-inbound-rtp stats
​https://bugs.webkit.org/show_bug.cgi?id=206645
<rdar://problem/58833958>

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

• Configurations/libwebrtc.iOS.exp:
• Configurations/libwebrtc.iOSsim.exp:
• Configurations/libwebrtc.mac.exp:

Source/WebCore:

Update stats according latest spec and webrtc backend.
We still expose obsolete trackId for consistency with existing WPT tests.
Covered by existing and updated tests.

• Modules/mediastream/RTCStatsReport.h:

(WebCore::RTCStatsReport::InboundRtpStreamStats::InboundRtpStreamStats):
(WebCore::RTCStatsReport::RemoteInboundRtpStreamStats::RemoteInboundRtpStreamStats):
(WebCore::RTCStatsReport::OutboundRtpStreamStats::OutboundRtpStreamStats):
(WebCore::RTCStatsReport::InboundRTPStreamStats::InboundRTPStreamStats): Deleted.
(WebCore::RTCStatsReport::OutboundRTPStreamStats::OutboundRTPStreamStats): Deleted.

• Modules/mediastream/RTCStatsReport.idl:
• Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:

(WebCore::fillRtpStreamStats):
(WebCore::fillReceivedRtpStreamStats):
(WebCore::fillInboundRtpStreamStats):
(WebCore::fillRemoteInboundRtpStreamStats):
(WebCore::fillSentRtpStreamStats):
(WebCore::fillOutboundRtpStreamStats):
(WebCore::initializeRTCStatsReportBackingMap):
(WebCore::fillRTCRTPStreamStats): Deleted.
(WebCore::fillInboundRTPStreamStats): Deleted.
(WebCore::fillOutboundRTPStreamStats): Deleted.

LayoutTests:

• webrtc/video-stats.html:

qpSum is no longer guaranteed to be there.
Also, we loop over stats to ensure we get all of them.

10:52 AM Changeset in webkit [262725] by Jonathan Bedard

• 5 edits
  1 add in trunk/Source/WebCore

WebCore: Add tvOS and watchOS SPI headers
​https://bugs.webkit.org/show_bug.cgi?id=212853
<rdar://problem/64048485>

Reviewed by Andy Estes.

Source/WebCore:

No new tests, no behavior changed.

• platform/ios/WebCoreMotionManager.h: Forward-declare CMMotionManager.
• platform/ios/WebCoreMotionManager.mm: Include CoreMotionSPI.h.

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj: Add CoreMotionSPI.h.
• pal/spi/cf/CFNetworkSPI.h: CFNetwork SPI should be available on watchOS and tvOS.
• pal/spi/cocoa/CoreMotionSPI.h: Added.

10:40 AM Changeset in webkit [262724] by pvollan@apple.com

• 5 edits in trunk

[Cocoa] CFPrefs synchronization does not always work for global preference changes
​https://bugs.webkit.org/show_bug.cgi?id=212783

Reviewed by Tim Horton.

Source/WebKit:

In CFPrefs direct mode, synchronization of global preference changes from the UI process to the WebContent process does not always work.
This is caused by the KVO notification being sent to all or some of the NSUserDefault objects, which leads us to believe a non-global
preference was changed. Since a global preference change always leads to some NSUserDefaults object receiving the notification, we can
work around this by checking if the preference being changed really belongs to the domain of the NSUserDefaults object, or if it is a
global preference. Also, stop creating NSUserDefaults object for the global domain, since this is an error according to the docs.

API test: WebKit.GlobalPreferenceChangesUsingDefaultsWrite

• UIProcess/Cocoa/PreferenceObserver.mm:

(-[WKUserDefaults _notifyObserversOfChangeFromValuesForKeys:toValuesForKeys:]):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::notifyPreferencesChanged):

Tools:

Add API test, and add some synchronization to avoid flakiness.

• TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:

(-[WKTestPreferenceObserver preferenceDidChange:key:encodedValue:]):
(TEST):
(sharedInstanceMethodOverride):

10:08 AM Changeset in webkit [262723] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WebDriver][GTK] Update test expectations after modifier fix

Unreviewed test gardening.

• TestExpectations.json:

9:55 AM Changeset in webkit [262722] by Alan Bujtas

• 4 edits
  2 adds in trunk

[LFC][IFC] Add support for min/max-width/height
​https://bugs.webkit.org/show_bug.cgi?id=212904

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/inline-max-width-height-simple.html

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedWidthValue): Adjust assert to check inline, non-replaced boxes only (inline-block is an
inline level element but not an inline element)

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin):

LayoutTests:

• fast/layoutformattingcontext/inline-max-width-height-simple-expected.html: Added.
• fast/layoutformattingcontext/inline-max-width-height-simple.html: Added.

9:47 AM Changeset in webkit [262721] by Wenson Hsieh

• 7 edits
  1 add in trunk

[iOS] Hit-testing on icloud.com is offset after closing a tab
​https://bugs.webkit.org/show_bug.cgi?id=212890
<rdar://problem/58775297>

Reviewed by Simon Fraser.

Source/WebKit:

After tapping to create a new tab on the icloud.com settings page (with no other tabs open) and then closing the
new tab, all hit-testing on the page is offset by -33px until the page is reloaded. This bug appears to be a
corner case triggered by a combination of the following three changes:

• <​https://trac.webkit.org/r170463>
• <​https://trac.webkit.org/r245006>
• <rdar://problem/53660458> (which is an iOS-specific Safari change)

We start on icloud.com's settings page. When closing the newly created tab, Safari hides the tab bar, causing
both the top content inset and top obscured inset to decrease by 33 points. When applying the top content inset
change, Safari (after <rdar://problem/53660458>) temporarily sets _automaticContentOffsetAdjustmentEnabled on
WKScrollView to NO, which means that the scroll view doesn't automatically adjust its content offset to -70;
instead, it remains at -103 (the content offset when the tab bar is shown).

Because of this, during the next remote layer tree commit where the content size changes,
-_setContentSizePreservingContentOffsetDuringRubberband: will believe that we're currently rubber-banding by
33px, and therefore try to adjust the content offset of the scroll view to be -103 instead of allowing it to be
adjusted back to -70 (see r170463 and -_restoreContentOffsetWithRubberbandAmount:).

This results in the scroll position on the page (document.scrollingElement.scrollTop) reporting -33, even
though the top of the page is flush with the bottom of Safari's browser chrome. Finally, because WKScrollView
is made unscrollable due to overflow: hidden; (r245006), we end up permanently stuck in this state until the
next page load, rather than the next remote layer tree commit that causes any scrolling.

To fix this, add an additional restriction on the rubberbanding offset restoration code in
-_setContentSizePreservingContentOffsetDuringRubberband:, such that we only try to preserve the current
rubberbanded offset if we're actually rubberbanding (that is, dragging or bouncing against the edge of the
scroll view). Note that when rubberbanding against the top of the scroll view on iPad using a trackpad, the
-isDragging property is also true, which matches behavior when panning via touch.

Test: ScrollViewInsetTests.ChangeInsetWithoutAutomaticAdjustmentWhileWebProcessIsUnresponsive

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/WKScrollView.mm:

(-[WKScrollView _setContentSizePreservingContentOffsetDuringRubberband:]):

Also, split out the CGSizeEqualToSize(currentContentSize, contentSize) case into a separate early return that
skips the call to -setContentSize: altogether.

Tools:

Add a new API test to verify that the scroll position doesn't get stuck at -30px after shifting both the top
content inset and top obscured inset by 30px. See WebKit ChangeLog for more details.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/overflow-hidden.html: Added.
• TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:

(-[ScrollViewDelegate scrollViewDidScroll:]):
(TestWebKitAPI::TEST):

• TestWebKitAPI/ios/UIKitSPI.h:

9:17 AM Changeset in webkit [262720] by svillar@igalia.com

• 11 edits
  2 copies
  3 adds in trunk

[WebXR] Add missing interfaces from the AR module
​https://bugs.webkit.org/show_bug.cgi?id=212826

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Added expectations.

• web-platform-tests/webxr/ar-module/idlharness.https.window-expected.txt: Added.
• web-platform-tests/webxr/ar-module/xrDevice_isSessionSupported_immersive-ar.https-expected.txt: Added.
• web-platform-tests/webxr/ar-module/xrDevice_requestSession_immersive-ar.https-expected.txt: Added.

Source/WebCore:

Added the XRInteractionMode partial interface from the WebXR AR module spec. This spec
​https://immersive-web.github.io/webxr-ar-module/ expands the WebXR Device API with
functionality available in AR hardware.

Some WebXR wpt tests are now passing.

• CMakeLists.txt: Added new files.
• DerivedSources.make: Ditto.
• Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::interactionMode const): Added.

• Modules/webxr/WebXRSession.h: Added interactionMode attribute and getter;
• Modules/webxr/WebXRSession.idl: Added interactionMode attribute;
• Modules/webxr/XRInteractionMode.h: Added.
• Modules/webxr/XRInteractionMode.idl: Added.
• Sources.txt: Added new files.
• WebCore.xcodeproj/project.pbxproj: Ditto.

LayoutTests:

• platform/wpe/TestExpectations: Unskipped 3 tests which are passing now.

9:11 AM Changeset in webkit [262719] by Jonathan Bedard

• 2 edits in trunk/Source/JavaScriptCore

JavaScriptCore: Fix PLATFORM(TVOS) macro
​https://bugs.webkit.org/show_bug.cgi?id=212900
<rdar://problem/64118879>

Unreviewed build fix.

• tools/JSDollarVM.cpp:

(JSC::functionIsMemoryLimited): PLATFORM(TVOS) should be PLATFORM(APPLETV).

8:59 AM Changeset in webkit [262718] by svillar@igalia.com

• 5 edits in trunk/Source/WebCore

[WebXR] Pass an unsigned long to cancelAnimationCallback() as handle
​https://bugs.webkit.org/show_bug.cgi?id=212529

Reviewed by Youenn Fablet.

The type of the handle returned by XRSession::requestAnimationFrame() was recently changed
to unsigned long from long as there was no point in using signed integers for that. However
we forgot to update the cancelAnimationFrame() in the specs as well as it receives the handle
returned by requestAnimationFrame().

We landed ​https://github.com/immersive-web/webxr/pull/1069 in the WebXR specs so we can now
safely also replace signed by unsigned integers in our implementation.

No new tests as there is no change in functionality.

• Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::cancelAnimationFrame): Use unsigned ids.

• Modules/webxr/WebXRSession.h: Ditto.
• Modules/webxr/WebXRSession.idl: Ditto.

8:56 AM Changeset in webkit [262717] by commit-queue@webkit.org

• 1 edit
  1 add in trunk/Tools

[Flatpak SDK] Add flatpak-run-nightly
​https://bugs.webkit.org/show_bug.cgi?id=212882

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-06-08
Reviewed by Carlos Alberto Lopez Perez.

This new script is able to download WPE and GTK builds from the Igalia servers and run the
corresponding binaries (like MiniBrowser, jsc) within the Flatpak SDK.

Unzipped builds will be saved in /tmp and can be reused in further runs (by providing the
path with the -p argument).

Example:
$ webkit-flatpak-run-nightly --wpe MiniBrowser ​https://webkit.org
<SDK installs to ~/.cache/wk-nightly>
Downloading build release_r262699_b33885.zip from ​https://wpewebkit-release.igalia.com/built-products/
Extracting build to /tmp/wpewebkit-release-b33885
<MiniBrowser starts>

$ webkit-flatpak-run-nightly --wpe -p /tmp/wpewebkit-release-b33885 jsc
Looking for updates…
Nothing to do.

2+2

4

• Scripts/webkit-flatpak-run-nightly: Added.

8:52 AM Changeset in webkit [262716] by svillar@igalia.com

• 9 edits
  6 deletes in trunk

[css-flexbox] align-content should apply even when there's just a single line
​https://bugs.webkit.org/show_bug.cgi?id=209871

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Mark as PASSing 15 subtests that are now working as expected.

• web-platform-tests/css/css-flexbox/align-content-wrap-001-expected.txt: Remove FAIL results.
• web-platform-tests/css/css-flexbox/align-content-wrap-002-expected.txt: Ditto.
• web-platform-tests/css/css-flexbox/align-content-wrap-003-expected.txt: Ditto.

Source/WebCore:

The 'align-content' property should have no effect on single line flex containers according to
the specs ​https://drafts.csswg.org/css-flexbox/#propdef-align-content. The current code was not
differentiating between single-line containers and multi-line containers with just 1 line.

Also in order not to introduce regressions and properly support replaced elements as flex items
we replaced the computation of child's width for 'flex-direction:column' by a direct call to
computeLogicalWidthForFragment() which already properly handles all the cases. It used to be
just the shrink-to-fit computation but that was not enough for replaced elements for example or
elements with min/max-size restrictions.

Several align-content-wrap-* subtests are working now. Updated expectations.

• rendering/RenderFlexibleBox.cpp:

(WebCore::initialAlignContentOffset): Removed check for #lines <= 1, as it is incorrect because it
is true for multi-line containers with just 1 line.
(WebCore::RenderFlexibleBox::alignFlexLines): Use isMultiline() instead of "#lines == 1".
(WebCore::RenderFlexibleBox::childIntrinsicLogicalWidth const): Replace shrink-to-fit computation
by a call computeLogicalWidthForFragment().
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Use the whole crossAxisExtent
for single line containers. Moved from alignFlexLines() as it fits much better here.

LayoutTests:

• TestExpectations:
• css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line-expected.txt: Removed.
• css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html: Replaced by

WPT's align-content-wrap-001.html.

• css3/flexbox/flexbox-wordwrap-expected.txt: Removed.
• css3/flexbox/flexbox-wordwrap.html: Replaced by WPT's align-content-wrap-002.html.
• css3/flexbox/multiline-align-content-expected.txt: Removed.
• css3/flexbox/multiline-align-content.html: Replaced by WPT's align-content-wrap-003.html.
• platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:

Updated expectations.

8:34 AM Changeset in webkit [262715] by aestes@apple.com

• 4 edits in trunk/Source

[Apple Pay] Remove -respondsToSelector: check before calling -[PKPaymentRequest setBoundInterfaceIdentifier:]
​https://bugs.webkit.org/show_bug.cgi?id=212884
<rdar://problem/64090963>

Reviewed by Youenn Fablet.

Source/WebKit:

• Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest): Relied on the definition of
HAVE_PASSKIT_BOUND_INTERFACE_IDENTIFIER to ensure that PKPaymentRequest will respond to
-setBoundInterfaceIdentifier:.

Source/WTF:

• wtf/PlatformHave.h: On macOS, HAVE_PASSKIT_BOUND_INTERFACE_IDENTIFIER should be defined

starting in Catalina.

8:32 AM Changeset in webkit [262714] by aestes@apple.com

• 37 edits in trunk/Source

[Apple Pay] Remove ENABLE_APPLE_PAY_SETUP, ENABLE_APPLE_PAY_SESSION_V7, and HAVE_PASSKIT_PAYMENT_SETUP
​https://bugs.webkit.org/show_bug.cgi?id=212883
<rdar://problem/64090763>

Reviewed by Youenn Fablet.

These macros evaluate to true whenever ENABLE(APPLE_PAY) is true on platforms supported by
trunk WebKit, so we can either remove them or replace them with ENABLE(APPLE_PAY).

Source/WebCore:

• Modules/applepay/ApplePaySetup.cpp:
• Modules/applepay/ApplePaySetup.idl:
• Modules/applepay/ApplePaySetupConfiguration.h:
• Modules/applepay/ApplePaySetupConfiguration.idl:
• Modules/applepay/ApplePaySetupFeature.idl:
• Modules/applepay/ApplePaySetupFeature.mm:
• Modules/applepay/ApplePaySetupFeatureState.h:
• Modules/applepay/ApplePaySetupFeatureState.idl:
• Modules/applepay/ApplePaySetupFeatureType.idl:
• Modules/applepay/ApplePaySetupFeatureTypeWebCore.h:
• Modules/applepay/ApplePaySetupFeatureWebCore.h:
• Modules/applepay/ApplePaySetupWebCore.h:
• Modules/applepay/PaymentCoordinator.cpp:
• Modules/applepay/PaymentCoordinator.h:
• Modules/applepay/PaymentCoordinatorClient.cpp:

(WebCore::PaymentCoordinatorClient::supportsVersion):

• Modules/applepay/PaymentCoordinatorClient.h:

(WebCore::PaymentCoordinatorClient::endApplePaySetup):

• testing/MockApplePaySetupFeature.cpp:
• testing/MockApplePaySetupFeature.h:
• testing/MockPaymentCoordinator.cpp:
• testing/MockPaymentCoordinator.h:
• testing/MockPaymentCoordinator.idl:

Source/WebCore/PAL:

• pal/spi/cocoa/PassKitSPI.h:

Source/WebKit:

• Shared/ApplePay/ApplePayPaymentSetupFeatures.mm:
• Shared/ApplePay/ApplePayPaymentSetupFeaturesWebKit.h:
• Shared/ApplePay/PaymentSetupConfiguration.mm:
• Shared/ApplePay/PaymentSetupConfigurationWebKit.h:
• Shared/ApplePay/WebPaymentCoordinatorProxy.h:
• Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in:
• Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
• WebProcess/ApplePay/WebPaymentCoordinator.cpp:
• WebProcess/ApplePay/WebPaymentCoordinator.h:

Source/WTF:

• wtf/PlatformEnableCocoa.h:
• wtf/PlatformHave.h:

7:52 AM Changeset in webkit [262713] by Diego Pino Garcia

• 2 edits
  1 copy
  2 deletes in trunk/LayoutTests

[WPE] Gardening, update test expectations after r262708
​https://bugs.webkit.org/show_bug.cgi?id=212901

Unreviewed gardening.

• Moved common baseline to glib.
• Removed redudant WPE baseline.
• Added flaky failure to test expectations.

• platform/glib/imported/w3c/web-platform-tests/encoding/single-byte-decoder-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/encoding/single-byte-decoder-expected.txt.
• platform/wpe/TestExpectations:
• platform/wpe/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt: Removed.

7:40 AM Changeset in webkit [262712] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

(r261056) [ Mac WK2 ] fast/scrolling/mac/scrollbars/overlay-scrollbar-reveal.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=212042

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

7:24 AM Changeset in webkit [262711] by Antti Koivisto

• 3 edits
  2 adds in trunk

Pseudo-elements (::after) in shadow roots don't animate
​https://bugs.webkit.org/show_bug.cgi?id=173027
<rdar://problem/42842994>

Reviewed by Antoine Quint.

Source/WebCore:

Test: animations/keyframe-pseudo-shadow.html

• animation/AnimationTimeline.cpp:

(WebCore::shouldConsiderAnimation):

We should use the actual element instead of the PseudoElement when calling Style::Scope::forOrdinal.
The keyframe code that computes the style already does this correctly.

LayoutTests:

• animations/keyframe-pseudo-shadow-expected.html: Added.
• animations/keyframe-pseudo-shadow.html: Added.

7:00 AM Changeset in webkit [262710] by youenn@apple.com

• 10 edits
  1 copy
  3 adds in trunk

Source/WebCore:
Use one audio unit for all tracks of a given process
​https://bugs.webkit.org/show_bug.cgi?id=212406

Reviewed by Eric Carlson.

Before the patch, we were creating one audio unit per track to render.
This is potentially inefficient as this requires to IPC on iOS each audio data.
Instead, we could have one single remote unit that will receive the mixed content of all tracks.
For that purpose, introduce AudioMediaStreamTrackRendererUnit as a singleton.

AudioMediaStreamTrackRendererCocoa will just register/unregister sources to AudioMediaStreamTrackRendererUnit.
AudioMediaStreamTrackRendererUnit will then start/stop as needed and do the mixing.

This requires a change in AudioSampleDataSource to support mixing in case track volumes are different.
If we have to mix and with different volumes, we first pull the samples in a scratch buffer, apply volume and then mix it with the other tracks.

In the future, we might also do the audio rendering with the CoreAudioSharedUnit directly so as to improve as much as possible echo cancellation.

Interruption is handled by the fact that all tracks should stop playing, thus stop their renderer, thus unregister themselves from the renderer unit.
it might be more future proof to add the unit as an interruption observer as a follow-up.

Manually tested plus LayoutTests/webrtc/multi-audio.html

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/audio/mac/AudioSampleBufferList.cpp:

(WebCore::mixBuffers):
(WebCore::AudioSampleBufferList::mixFrom):

• platform/audio/mac/AudioSampleBufferList.h:
• platform/audio/mac/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::pullSamplesInternal):

• platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:

(WebCore::AudioMediaStreamTrackRendererCocoa::start):
(WebCore::AudioMediaStreamTrackRendererCocoa::stop):
(WebCore::AudioMediaStreamTrackRendererCocoa::clear):
(WebCore::AudioMediaStreamTrackRendererCocoa::setVolume):
(WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples):
(WebCore::AudioMediaStreamTrackRendererCocoa::createAudioUnit): Deleted.
(WebCore::AudioMediaStreamTrackRendererCocoa::render): Deleted.
(WebCore::AudioMediaStreamTrackRendererCocoa::inputProc): Deleted.

• platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.h:

(): Deleted.

• platform/mediastream/mac/AudioMediaStreamTrackRendererUnit.cpp: Added.

(WebCore::AudioMediaStreamTrackRendererUnit::singleton):
(WebCore::AudioMediaStreamTrackRendererUnit::~AudioMediaStreamTrackRendererUnit):
(WebCore::AudioMediaStreamTrackRendererUnit::addSource):
(WebCore::AudioMediaStreamTrackRendererUnit::removeSource):
(WebCore::AudioMediaStreamTrackRendererUnit::createAudioUnitIfNeeded):
(WebCore::AudioMediaStreamTrackRendererUnit::start):
(WebCore::AudioMediaStreamTrackRendererUnit::stop):
(WebCore::AudioMediaStreamTrackRendererUnit::formatDescription):
(WebCore::AudioMediaStreamTrackRendererUnit::createAudioUnit):
(WebCore::AudioMediaStreamTrackRendererUnit::render):
(WebCore::AudioMediaStreamTrackRendererUnit::inputProc):

• platform/mediastream/mac/AudioMediaStreamTrackRendererUnit.h: Copied from Source/WebCore/platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.h.

LayoutTests:
Use one audio unit for all MediaStreamTracks of a given process
​https://bugs.webkit.org/show_bug.cgi?id=212406

Reviewed by Eric Carlson.

• webrtc/multi-audio-expected.txt: Added.
• webrtc/multi-audio.html: Added.

5:58 AM Changeset in webkit [262709] by Diego Pino Garcia

• 3 edits in trunk/Tools

[webkitpy] Make 'webkit-path rebaseline' to not update expectations file by default
​https://bugs.webkit.org/show_bug.cgi?id=212835

Reviewed by Carlos Alberto Lopez Perez.

webkit-patch rebaseline let us add or update a test baseline
from a test bot. By default, the command also updates the
corresponding expectations file. This update is actually a brand-new
generation of an expectations file based on the results of the bot,
which in most cases messes up the current contents of the file.

This patch makes the default to not update the expectations file and
adds a new option '--update-expectations' to explicitly request an
update.

• Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand):
(RebaselineTest.init):
(RebaselineTest._rebaseline_tests):
(RebaselineTest.execute):
(AbstractParallelRebaselineCommand._rebaseline_commands):
(RebaselineExpectations.init):
(RebaselineExpectations.execute):
(Rebaseline.init):
(RebaselineTest._rebaseline_test_and_update_expectations): Deleted.

• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.setUp):

4:49 AM Changeset in webkit [262708] by youenn@apple.com

• 33 edits
  1 copy
  7 adds in trunk

[Cocoa] Use AVAssetWriterDelegate to implement MediaRecorder
​https://bugs.webkit.org/show_bug.cgi?id=206582
Source/WebCore:

<rdar://problem/58985368>

Reviewed by Eric Carlson.

AVAssetWriterDelegate allows to grab recorded data whenever wanted.
This delegate requires passing compressed samples to AVAssetWriter.
Implement video encoding and audio encoding in dedicated classes and use these classes before adding buffers to AVAssetWriter.
These classes are AudioSampleBufferCompressor and VideoSampleBufferCompressor.
They support AAC and H264 so far and should be further improved to support more encoding options.

Instantiate real writer only for platforms supporting AVAssetWriterDelegate, since it is not supported everywhere.
The writer, doing the pacakging, is receiving compressed buffer from the audio/video compressors.
It then sends data when being request to flush to its delegate, which will send data to the MediaRecorderPrivateWriter.
The MediaRecorderPrivateWriter stores the data in a SharedBuffer until MediaRecorder asks for data.

Note that, whenever we request data, we flush the writer and insert an end of video sample to make sure video data gets flushed.
Therefore data should not be requested too fast to get adequate video compression.

Covered by existing tests.

• Modules/mediarecorder/MediaRecorderProvider.cpp:

(WebCore::MediaRecorderProvider::createMediaRecorderPrivate):

• WebCore.xcodeproj/project.pbxproj:
• platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

(WebCore::MediaRecorderPrivateAVFImpl::create):

• platform/mediarecorder/MediaRecorderPrivateAVFImpl.h:
• platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h: Added.
• platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm: Added.

(WebCore::AudioSampleBufferCompressor::create):
(WebCore::AudioSampleBufferCompressor::AudioSampleBufferCompressor):
(WebCore::AudioSampleBufferCompressor::~AudioSampleBufferCompressor):
(WebCore::AudioSampleBufferCompressor::initialize):
(WebCore::AudioSampleBufferCompressor::finish):
(WebCore::AudioSampleBufferCompressor::initAudioConverterForSourceFormatDescription):
(WebCore::AudioSampleBufferCompressor::computeBufferSizeForAudioFormat):
(WebCore::AudioSampleBufferCompressor::attachPrimingTrimsIfNeeded):
(WebCore::AudioSampleBufferCompressor::gradualDecoderRefreshCount):
(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):
(WebCore::AudioSampleBufferCompressor::audioConverterComplexInputDataProc):
(WebCore::AudioSampleBufferCompressor::provideSourceDataNumOutputPackets):
(WebCore::AudioSampleBufferCompressor::processSampleBuffersUntilLowWaterTime):
(WebCore::AudioSampleBufferCompressor::processSampleBuffer):
(WebCore::AudioSampleBufferCompressor::addSampleBuffer):
(WebCore::AudioSampleBufferCompressor::getOutputSampleBuffer):
(WebCore::AudioSampleBufferCompressor::takeOutputSampleBuffer):

• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(-[WebAVAssetWriterDelegate initWithWriter:]):
(-[WebAVAssetWriterDelegate assetWriter:didProduceFragmentedHeaderData:]):
(-[WebAVAssetWriterDelegate assetWriter:didProduceFragmentedMediaData:fragmentedMediaDataReport:]):
(-[WebAVAssetWriterDelegate close]):
(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::compressedVideoOutputBufferCallback):
(WebCore::MediaRecorderPrivateWriter::compressedAudioOutputBufferCallback):
(WebCore::MediaRecorderPrivateWriter::MediaRecorderPrivateWriter):
(WebCore::MediaRecorderPrivateWriter::~MediaRecorderPrivateWriter):
(WebCore::MediaRecorderPrivateWriter::initialize):
(WebCore::MediaRecorderPrivateWriter::processNewCompressedVideoSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::processNewCompressedAudioSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::startAssetWriter):
(WebCore::MediaRecorderPrivateWriter::appendCompressedAudioSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendCompressedSampleBuffers):
(WebCore::appendEndsPreviousSampleDurationMarker):
(WebCore::MediaRecorderPrivateWriter::appendEndOfVideoSampleDurationIfNeeded):
(WebCore::MediaRecorderPrivateWriter::flushCompressedSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::clear):
(WebCore::copySampleBufferWithCurrentTimeStamp):
(WebCore::MediaRecorderPrivateWriter::appendVideoSampleBuffer):
(WebCore::createAudioFormatDescription):
(WebCore::createAudioSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendAudioSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::stopRecording):
(WebCore::MediaRecorderPrivateWriter::appendData):

• platform/mediarecorder/cocoa/VideoSampleBufferCompressor.h: Copied from Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.h.
• platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm: Added.

(WebCore::VideoSampleBufferCompressor::create):
(WebCore::VideoSampleBufferCompressor::VideoSampleBufferCompressor):
(WebCore::VideoSampleBufferCompressor::~VideoSampleBufferCompressor):
(WebCore::VideoSampleBufferCompressor::initialize):
(WebCore::VideoSampleBufferCompressor::finish):
(WebCore::VideoSampleBufferCompressor::videoCompressionCallback):
(WebCore::VideoSampleBufferCompressor::initCompressionSession):
(WebCore::VideoSampleBufferCompressor::processSampleBuffer):
(WebCore::VideoSampleBufferCompressor::addSampleBuffer):
(WebCore::VideoSampleBufferCompressor::getOutputSampleBuffer):
(WebCore::VideoSampleBufferCompressor::takeOutputSampleBuffer):

Source/WebCore/PAL:

<rdar://problem/58985368>

Reviewed by Eric Carlson.

Add soft link macros for VideoToolbox and AudioToolbox.

• PAL.xcodeproj/project.pbxproj:
• pal/cf/AudioToolboxSoftLink.cpp: Added.
• pal/cf/AudioToolboxSoftLink.h: Added.
• pal/cf/CoreMediaSoftLink.cpp:
• pal/cf/CoreMediaSoftLink.h:
• pal/cf/VideoToolboxSoftLink.cpp: Added.
• pal/cf/VideoToolboxSoftLink.h: Added.

Source/WebKit:

<rdar://problem/58985368>

Reviewed by Eric Carlson.

Enable RemoteMediaRecorder only for systems supporting AVAssetWriterDelegate.

• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::didReceiveMessage):

• GPUProcess/GPUConnectionToWebProcess.h:
• GPUProcess/webrtc/RemoteMediaRecorder.cpp:
• GPUProcess/webrtc/RemoteMediaRecorder.h:
• GPUProcess/webrtc/RemoteMediaRecorder.messages.in:
• GPUProcess/webrtc/RemoteMediaRecorderManager.cpp:
• GPUProcess/webrtc/RemoteMediaRecorderManager.h:
• GPUProcess/webrtc/RemoteMediaRecorderManager.messages.in:
• GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
• WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
• WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
• WebProcess/GPU/webrtc/MediaRecorderProvider.cpp:

(WebKit::MediaRecorderProvider::createMediaRecorderPrivate):

Source/WTF:

Reviewed by Eric Carlson.

• wtf/PlatformHave.h:

LayoutTests:

Reviewed by Eric Carlson.

Disable tests on all platforms except the ones supporting AVAssetWriterDelegate.

• TestExpectations:
• http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuprocess.html:

Remove web audio generation since there seems to be some unstability in web audio -> stream -> media recorder.
which should be fixed as follow-up specific patches.

• platform/mac/TestExpectations:

Enable running tests.

4:33 AM Changeset in webkit [262707] by youenn@apple.com

• 5 edits
  1 add in trunk

File URLs with hostnames are misleading
​https://bugs.webkit.org/show_bug.cgi?id=212739
<rdar://problem/63754917>

Reviewed by Alex Christensen.

Source/WebCore:

Showing a file URL like ​file://example.org/test is misleading to users.
To prevent this, we just do a redirection to the same file URL with an empty host.
Remove the port at the same time.
Covered by added API test.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/open-window-with-file-url-with-host.html: Added.
• TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:

(TEST):

4:10 AM Changeset in webkit [262706] by Diego Pino Garcia

• 1 edit
  1 move
  2 deletes in trunk/LayoutTests

[WPE] Gardening, remove redundant baselines
​https://bugs.webkit.org/show_bug.cgi?id=212896

Unreviewed gardening.

• platform/glib/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.https-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.https-expected.txt.
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted.https-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.https-expected.txt: Removed.

2:19 AM Changeset in webkit [262705] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Gardening, update test expectations after r262703
​https://bugs.webkit.org/show_bug.cgi?id=212895

Unreviewed gardening.

Garden several flaky failures.

• platform/gtk/TestExpectations:

2:04 AM Changeset in webkit [262704] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

Simplify fallback content handling in FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=212880

Patch by Rob Buis <​rbuis@igalia.com> on 2020-06-08
Reviewed by Youenn Fablet.

Simplify fallback content handling in FrameLoader, this can be inlined
and some HTMLObjectElement checks can be combined.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedMainResourceError):
(WebCore::FrameLoader::handleFallbackContent): Deleted.
(WebCore::FrameLoader::isHostedByObjectElement const): Deleted.

• loader/FrameLoader.h:
• loader/HistoryController.cpp:

(WebCore::FrameLoader::HistoryController::createItemTree):

Jun 7, 2020:

5:34 PM Changeset in webkit [262703] by Lauro Moura

• 6 edits in trunk/Source/WebKit

[WebDriver] Allow platform-dependent modifier keys conversion to WebEvent::Modifier
​https://bugs.webkit.org/show_bug.cgi?id=212848

Reviewed by Brian Burg.

WebEvent::Modifier flags does not map directly to the platform flags,
so we can't directly convert the modifier flags to the OptionSet.

Covered by existing WebDriver tests.

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::simulateMouseInteraction): Use
platform-specific method to convert the modifiers.

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp: Added

conversion from GDK modifier mask to WebEvent::Modifier.
(WebKit::WebAutomationSession::platformWebModifiersFromRaw):

• UIProcess/Automation/mac/WebAutomationSessionMac.mm: Added

conversion from NSModifierFlag to WebEvent::Modifier.
(WebKit::WebAutomationSession::platformWebModifiersFromRaw):

• UIProcess/Automation/wpe/WebAutomationSessionWPE.cpp: Added

conversion from wpe_input_keyboard_modifier to WebEvent::Modifier.
(WebKit::WebAutomationSession::platformWebModifiersFromRaw):

5:16 PM Changeset in webkit [262702] by Lauro Moura

• 2 edits in trunk/Source/WebKit

[WPE] Behave like GDK_CURRENT_TIME when the timestamp is zero
​https://bugs.webkit.org/show_bug.cgi?id=212797

WebDriver tests come with zero timestamp. So behave like
GDK_CURRENT_TIME and assume zero timestamp == WallTime::now().

Reviewed by Carlos Garcia Campos.

Covered by existing tests.

• Shared/libwpe/WebEventFactory.cpp:

(WebKit::wallTimeForEventTime):

2:07 PM Changeset in webkit [262701] by commit-queue@webkit.org

• 12 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE - iOS] fast/canvas/webgl/uninitialized-test.html is still failing
​https://bugs.webkit.org/show_bug.cgi?id=212249

Patch by James Darpinian <James Darpinian> on 2020-06-07
Reviewed by Dean Jackson.

copyTexImage2D is broken in some way on iOS. Work around it by reimplementing
it with ANGLE's BlitGL class.

• include/platform/FeaturesGL.h:
• src/libANGLE/renderer/gl/BlitGL.cpp:

(rx::BlitGL::blitColorBufferWithShader):

• src/libANGLE/renderer/gl/BlitGL.h:
• src/libANGLE/renderer/gl/TextureGL.cpp:

(rx::TextureGL::copyImage):
(rx::TextureGL::copySubImage):

• src/libANGLE/renderer/gl/renderergl_utils.cpp:

(rx::nativegl_gl::InitializeFeatures):

• src/tests/gl_tests/CopyTexImageTest.cpp:
• src/tests/gl_tests/TextureTest.cpp:
• src/tests/test_utils/angle_test_configs.cpp:

(angle::operator<<):

• src/tests/test_utils/angle_test_configs.h:

(angle::WithEmulateCopyTexImage2DFromRenderbuffers):

• util/EGLPlatformParameters.h:

(EGLPlatformParameters::tie const):

• util/EGLWindow.cpp:

(EGLWindow::initializeDisplay):

9:56 AM Changeset in webkit [262700] by aestes@apple.com

• 4 edits in trunk

[Apple Pay] HAVE(PAYMENT_METHOD_BILLING_ADDRESS) should be true on iOS
​https://bugs.webkit.org/show_bug.cgi?id=212877
<rdar://problem/64080998>

Reviewed by Sam Weinig.

Source/WTF:

• wtf/PlatformHave.h:

LayoutTests:

• platform/ios-wk2/TestExpectations: Unskipped

http/tests/ssl/applepay/ApplePayBillingAddress.html on iOS.

8:56 AM Changeset in webkit [262699] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][Height percentage] Skip anonymous wrappers when searching for fixed height
​https://bugs.webkit.org/show_bug.cgi?id=212881

Reviewed by Antti Koivisto.

Source/WebCore:

When the block level box is a direct child of an inline level box (<span><div></div></span>) and we wrap it into a continuation,
the containing block (anonymous wrapper) is not the box we need to check for fixed height.

Test: fast/layoutformattingcontext/height-precentage-with-anonymous-wrapper.html

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue const):

LayoutTests:

• fast/layoutformattingcontext/height-precentage-with-anonymous-wrapper-expected.html: Added.
• fast/layoutformattingcontext/height-precentage-with-anonymous-wrapper.html: Added.

8:00 AM Changeset in webkit [262698] by Alan Bujtas

• 4 edits
  2 adds in trunk

[LFC][BFC] Intrinsic width computation should take min/max-width into account.
​https://bugs.webkit.org/show_bug.cgi?id=212876

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/min-max-content-width-simple2.html

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedWidthValue): Address Sam's post-landing comment.

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraints):

LayoutTests:

• fast/layoutformattingcontext/min-max-content-width-simple2-expected.html: Added.
• fast/layoutformattingcontext/min-max-content-width-simple2.html: Added.

7:56 AM Changeset in webkit [262697] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC] Pass in the element attributes to Layout::ReplacedBox
​https://bugs.webkit.org/show_bug.cgi?id=212879

Reviewed by Antti Koivisto.

The information whether the replace box is an image box is required to see if the box has intrinsic ratio (used for sizing inflow replaced content).

• layout/layouttree/LayoutReplacedBox.cpp:

(WebCore::Layout::ReplacedBox::ReplacedBox):
(): Deleted.

• layout/layouttree/LayoutReplacedBox.h:
• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createReplacedBox):
(WebCore::Layout::TreeBuilder::createLayoutBox):

• layout/layouttree/LayoutTreeBuilder.h:

7:35 AM Changeset in webkit [262696] by Caio Lima

• 2 edits in trunk/Tools

Allow run-jsc-stress-tests still run if some of the remote hosts are not available
​https://bugs.webkit.org/show_bug.cgi?id=201426

Reviewed by Saam Barati.

This patch allows run-jsc-stress-tests to keep on running if some of
the remote hosts are not available. To do this, we created a new
function checkAndPrepareRemoteHosts that is responsible to check the
connection and read/write permissions of given remote hosts list. It
filters out every unavailable remote host.
These checks and filter happen in the beginning of the script and is
excuted only once, in the beggining of the script. It means that if
some remote device becomes unavailable after the check and preparation
is done, the script execution will be interupted.

• Scripts/run-jsc-stress-tests:

2:55 AM Changeset in webkit [262695] by Philippe Normand

• 271 edits in trunk

Remove ENABLE_VIDEO_TRACK ifdef guards
​https://bugs.webkit.org/show_bug.cgi?id=212568

Reviewed by Youenn Fablet.

.:

VIDEO_TRACK has been enabled by default on all ports for a long time. As the spec is stable,
the feature can unconditionally be enabled and is now guarded under ENABLE(VIDEO).

• Source/cmake/OptionsFTW.cmake:
• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig: Remove ENABLE_VIDEO_TRACK, which is now enabled by

default under the ENABLE_VIDEO guard.

Source/WebCore:

• CMakeLists.txt:
• Configurations/FeatureDefines.xcconfig:
• Modules/mediacontrols/MediaControlsHost.cpp:
• Modules/mediasource/AudioTrackMediaSource.h:
• Modules/mediasource/AudioTrackMediaSource.idl:
• Modules/mediasource/SourceBuffer.h:
• Modules/mediasource/SourceBuffer.idl:
• Modules/mediasource/TextTrackMediaSource.h:
• Modules/mediasource/TextTrackMediaSource.idl:
• Modules/mediasource/VideoTrackMediaSource.h:
• Modules/mediasource/VideoTrackMediaSource.idl:
• Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp:

(WebCore::HTMLVideoElementPictureInPicture::requestPictureInPicture):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSAudioTrackCustom.cpp:
• bindings/js/JSAudioTrackListCustom.cpp:
• bindings/js/JSTextTrackCueCustom.cpp:
• bindings/js/JSTextTrackCustom.cpp:
• bindings/js/JSTextTrackListCustom.cpp:
• bindings/js/JSTrackCustom.cpp:
• bindings/js/JSTrackCustom.h:
• bindings/js/JSVideoTrackCustom.cpp:
• bindings/js/JSVideoTrackListCustom.cpp:
• css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::selectorText const):

• css/CSSSelector.h:
• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):

• css/SelectorCheckerTestFunctions.h:

(WebCore::matchesLangPseudoClass):

• css/SelectorPseudoClassAndCompatibilityElementMap.in:
• css/SelectorPseudoElementTypeMap.in:
• css/parser/CSSParserSelector.h:

(WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):
(WebCore::CSSParserSelector::isPseudoElementCueFunction const):

• css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumePseudo):

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

• dom/Document.cpp:
• dom/Document.h:
• dom/EventNames.in:
• dom/EventTargetFactory.in:
• dom/Node.h:
• history/BackForwardCache.cpp:
• history/BackForwardCache.h:
• history/CachedPage.cpp:

(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):

• history/CachedPage.h:
• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::as const):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::finishParsingChildren):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::canTransitionFromAutoplayToPlay const):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::configureTextTracks):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::syncTextTrackBounds):
(WebCore::HTMLMediaElement::setVideoFullscreenStandby):
(WebCore::HTMLMediaElement::setVideoFullscreenLayer):
(WebCore::HTMLMediaElement::hasClosedCaptions const):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::bufferingPolicy const):

• html/HTMLMediaElement.h:
• html/HTMLMediaElement.idl:
• html/HTMLTagNames.in:
• html/HTMLTrackElement.cpp:
• html/HTMLTrackElement.h:
• html/HTMLTrackElement.idl:
• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::texImageSourceHelper):
(WebCore::WebGLRenderingContextBase::validateTexFuncParameters):

• html/shadow/MediaControlTextTrackContainerElement.cpp:
• html/shadow/MediaControlTextTrackContainerElement.h:
• html/track/AudioTrack.cpp:
• html/track/AudioTrack.h:
• html/track/AudioTrack.idl:
• html/track/AudioTrackList.cpp:
• html/track/AudioTrackList.h:
• html/track/AudioTrackList.idl:
• html/track/DataCue.cpp:
• html/track/DataCue.h:
• html/track/DataCue.idl:
• html/track/InbandDataTextTrack.cpp:
• html/track/InbandDataTextTrack.h:
• html/track/InbandGenericTextTrack.cpp:
• html/track/InbandGenericTextTrack.h:
• html/track/InbandTextTrack.cpp:
• html/track/InbandTextTrack.h:
• html/track/InbandWebVTTTextTrack.cpp:
• html/track/InbandWebVTTTextTrack.h:
• html/track/LoadableTextTrack.cpp:
• html/track/LoadableTextTrack.h:
• html/track/TextTrack.cpp:
• html/track/TextTrack.h:
• html/track/TextTrack.idl:
• html/track/TextTrackCue.cpp:
• html/track/TextTrackCue.h:
• html/track/TextTrackCue.idl:
• html/track/TextTrackCueGeneric.cpp:
• html/track/TextTrackCueGeneric.h:
• html/track/TextTrackCueGeneric.idl:
• html/track/TextTrackCueList.cpp:
• html/track/TextTrackCueList.h:
• html/track/TextTrackCueList.idl:
• html/track/TextTrackList.cpp:
• html/track/TextTrackList.h:
• html/track/TextTrackList.idl:
• html/track/TrackBase.cpp:
• html/track/TrackBase.h:
• html/track/TrackEvent.cpp:
• html/track/TrackEvent.h:
• html/track/TrackEvent.idl:
• html/track/TrackListBase.cpp:
• html/track/TrackListBase.h:
• html/track/VTTCue.cpp:
• html/track/VTTCue.h:
• html/track/VTTCue.idl:
• html/track/VTTRegion.cpp:
• html/track/VTTRegion.h:
• html/track/VTTRegion.idl:
• html/track/VTTRegionList.cpp:
• html/track/VTTRegionList.h:
• html/track/VTTRegionList.idl:
• html/track/VideoTrack.cpp:
• html/track/VideoTrack.h:
• html/track/VideoTrack.idl:
• html/track/VideoTrackList.cpp:
• html/track/VideoTrackList.h:
• html/track/VideoTrackList.idl:
• html/track/WebVTTElement.cpp:
• html/track/WebVTTElement.h:
• html/track/WebVTTParser.cpp:
• html/track/WebVTTParser.h:
• html/track/WebVTTToken.h:
• html/track/WebVTTTokenizer.cpp:
• html/track/WebVTTTokenizer.h:
• loader/LinkLoader.cpp:

(WebCore::LinkLoader::resourceTypeFromAsAttribute):
(WebCore::createLinkPreloadResourceClient):
(WebCore::LinkLoader::isSupportedType):

• loader/ResourceLoadInfo.cpp:

(WebCore::ContentExtensions::toResourceType):

• loader/SubresourceLoader.cpp:

(WebCore::logResourceLoaded):

• loader/TextTrackLoader.cpp:
• loader/TextTrackLoader.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::defaultPriorityForResourceType):

• loader/cache/CachedResource.h:
• loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::contentTypeFromResourceType):
(WebCore::CachedResourceLoader::checkInsecureContent const):
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):
(WebCore::destinationForType):

• loader/cache/CachedResourceLoader.h:
• loader/cache/CachedTextTrack.cpp:
• loader/cache/CachedTextTrack.h:
• page/CaptionUserPreferences.cpp:
• page/CaptionUserPreferences.h:
• page/CaptionUserPreferencesMediaAF.cpp:
• page/CaptionUserPreferencesMediaAF.h:
• page/Page.cpp:

(WebCore::Page::setPageScaleFactor):
(WebCore::Page::setUserInterfaceLayoutDirection):
(WebCore::Page::doAfterUpdateRendering):
(WebCore::Page::forEachMediaElement):

• page/Page.h:
• page/PageGroup.cpp:
• page/PageGroup.h:
• page/Settings.yaml:
• platform/LocalizedStrings.cpp:
• platform/LocalizedStrings.h:
• platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageVideoOrSVGMIMEType):

• platform/SerializedPlatformDataCue.cpp:
• platform/graphics/AudioTrackPrivate.h:
• platform/graphics/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):
(WebCore::ImageDecoder::supportsMediaType):

• platform/graphics/InbandGenericCue.cpp:
• platform/graphics/InbandGenericCue.h:
• platform/graphics/InbandTextTrackPrivate.h:
• platform/graphics/InbandTextTrackPrivateClient.h:
• platform/graphics/MediaPlayer.cpp:

(WebCore::buildMediaEnginesVector):

• platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::textTrackRepresentationBoundsChanged):

• platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::tracksChanged):

• platform/graphics/TextTrackRepresentation.cpp:
• platform/graphics/TextTrackRepresentation.h:
• platform/graphics/TrackPrivateBase.cpp:
• platform/graphics/TrackPrivateBase.h:
• platform/graphics/VideoTrackPrivate.h:
• platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h:
• platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
• platform/graphics/avfoundation/AudioTrackPrivateAVF.h:
• platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
• platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
• platform/graphics/avfoundation/VideoTrackPrivateAVF.h:
• platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
• platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.cpp:
• platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
• platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:
• platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm:
• platform/graphics/cocoa/TextTrackRepresentationCocoa.h:
• platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
• platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
• platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
• platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer):

• platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
• platform/graphics/gstreamer/ImageDecoderGStreamer.h:
• platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
• platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
• platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::updateTracks):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::purgeInvalidTextTracks):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
• platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
• platform/graphics/gstreamer/TextCombinerGStreamer.h:
• platform/graphics/gstreamer/TextSinkGStreamer.cpp:
• platform/graphics/gstreamer/TextSinkGStreamer.h:
• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
• platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
• platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
• platform/mac/SerializedPlatformDataCueMac.h:
• platform/mac/SerializedPlatformDataCueMac.mm:
• platform/mediastream/AudioMediaStreamTrackRenderer.cpp:
• platform/mediastream/AudioMediaStreamTrackRenderer.h:
• platform/mediastream/AudioTrackPrivateMediaStream.cpp:
• platform/mediastream/AudioTrackPrivateMediaStream.h:
• platform/mediastream/VideoTrackPrivateMediaStream.h:
• platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:
• platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.h:
• rendering/RenderVTTCue.cpp:
• rendering/RenderVTTCue.h:
• style/ElementRuleCollector.cpp:

(WebCore::Style::ElementRuleCollector::collectMatchingShadowPseudoElementRules):

• style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::addMatch):

• style/RuleData.cpp:

(WebCore::Style::determinePropertyWhitelistType):

• style/RuleData.h:
• style/RuleSet.cpp:

(WebCore::Style::RuleSet::addRule):
(WebCore::Style::RuleSet::traverseRuleDatas):
(WebCore::Style::RuleSet::hasShadowPseudoElementRules const):
(WebCore::Style::RuleSet::shrinkToFit):

• style/RuleSet.h:
• style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShouldDisplayTrackKind):
(WebCore::InternalSettings::shouldDisplayTrackKind):

• testing/InternalSettings.h:
• testing/InternalSettings.idl:
• testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::Internals):
(WebCore::Internals::userPreferredAudioCharacteristics const):
(WebCore::Internals::setUserPreferredAudioCharacteristic):
(WebCore::Internals::captionsStyleSheetOverride):
(WebCore::Internals::setCaptionsStyleSheetOverride):
(WebCore::Internals::setPrimaryAudioTrackLanguageOverride):
(WebCore::Internals::setCaptionDisplayMode):
(WebCore::Internals::textTrackBCP47Language):
(WebCore::Internals::getCurrentMediaControlsStatusForElement):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::dispatchMessage):

• GPUProcess/GPUConnectionToWebProcess.h:
• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::textTrackSetMode):
(WebKit::RemoteMediaPlayerProxy::notifyTrackModeChanged):

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.messages.in:
• GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
• GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
• GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in:
• GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
• GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
• GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in:
• Shared/WebPreferences.yaml:
• WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::dispatchMessage):

• WebProcess/GPU/GPUProcessConnection.h:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::tracksChanged):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::RemoteMediaPlayerManager::updatePreferences):

• WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:
• WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h:
• WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
• WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:
• WebProcess/GPU/webrtc/SampleBufferDisplayLayer.messages.in:
• WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.cpp:
• WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::maximumBufferingTime):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

• WebPreferences.cpp:

(WebPreferences::shouldDisplaySubtitles):
(WebPreferences::setShouldDisplaySubtitles):
(WebPreferences::shouldDisplayCaptions):
(WebPreferences::setShouldDisplayCaptions):
(WebPreferences::shouldDisplayTextDescriptions):
(WebPreferences::setShouldDisplayTextDescriptions):

• WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WTF:

• wtf/PlatformEnable.h: Remove ENABLE_VIDEO_TRACK, which is now enabled by

default under the ENABLE_VIDEO guard.

• wtf/PlatformEnableCocoa.h: Ditto.

Tools:

• Scripts/webkitperl/FeatureList.pm:
• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

12:35 AM Changeset in webkit [262694] by ysuzuki@apple.com

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Checksum for generated files should be emitted at the end of the files
​https://bugs.webkit.org/show_bug.cgi?id=212875

Reviewed by Mark Lam.

If the offlineasm file generation is interrupted in the middle of the generation, it already emitted checksum.
So next file generation can accept this broken file as a result of offlineasm and skip file generation.
We should emit checksum at the end of files. For now, this patch takes a quick way: just iterating lines, getting
a last line and use it for checksum comparison.

• generator/GeneratedFile.rb:
• offlineasm/asm.rb: