Timeline

Jun 10, 2020:

11:31 PM Changeset in webkit [262895] by commit-queue@webkit.org

• 7 edits in trunk

[macOS]: The File Picker of the <input> file element should show the selection filter
​https://bugs.webkit.org/show_bug.cgi?id=212485

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-06-10
Reviewed by Darin Adler.

Source/WebCore/PAL:

Expose an SPI from CoreServcies to get all the UTIs known by the system.

• pal/spi/cocoa/CoreServicesSPI.h:

Source/WebKit:

Add two private helpers to WKOpenPanelParameters.

• UIProcess/API/Cocoa/WKOpenPanelParameters.mm:

(-[WKOpenPanelParameters _allowedFileExtensions]):
Returns an array of strings representing the allowed extensions.

(-[WKOpenPanelParameters _allowedFileExtensionsDescription]):
Returns a string representing a description for the allowed extensions.

• UIProcess/API/Cocoa/WKOpenPanelParametersPrivate.h:

Tools:

Create a view with an NSPopupButton for the file extensions filter. Set
this view as the AccessoryView of the OpenPanel. Create a customized target
for the NSPopupButton to respond to changing its selection.

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[FileExtensionsPopupTarget initWithOpenPanel:allowedFileExtensions:]):
(-[FileExtensionsPopupTarget popupAction:]):
(-[FileExtensionsPopupTarget dealloc]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController createFilterView:popupTarget:]):
(-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):

9:23 PM Changeset in webkit [262894] by Beth Dakin

• 12 edits in trunk/Source

Replace instances of blacklist in WebCore with blocklist
​https://bugs.webkit.org/show_bug.cgi?id=213064

Reviewed by Tim Horton.

Source/WebCore:

• dom/ExtensionStyleSheets.cpp:

(WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache const):

• page/Frame.cpp:

(WebCore::Frame::injectUserScriptImmediately):

• page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matchesPatterns):

• page/UserContentURLPattern.h:
• page/UserScript.h:

(WebCore::UserScript::UserScript):
(WebCore::UserScript::blocklist const):
(WebCore::UserScript::encode const):
(WebCore::UserScript::decode):
(WebCore::UserScript::blacklist const): Deleted.

• page/UserStyleSheet.h:

(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::blocklist const):
(WebCore::UserStyleSheet::blacklist const): Deleted.

• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::checkGPUStatus):

• platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):

• platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlocklistedCodecs):
(WebCore::extendTextCodecMaps):
(WebCore::pruneBlacklistedCodecs): Deleted.

Source/WebKit:

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<UserStyleSheet>::encode):
(IPC::ArgumentCoder<UserStyleSheet>::decode):

8:27 PM Changeset in webkit [262893] by commit-queue@webkit.org

• 10 edits
  12 adds in trunk

Multiple SVG Filters Unexpectedly lightens image using linearRGB
​https://bugs.webkit.org/show_bug.cgi?id=212649

Patch by Frank Yang <​guowei_yang@apple.com> on 2020-06-10
Reviewed by Myles C. Maxfield, Simon Fraser, Darin Adler

Source/WebCore:

Added color space conversion of input FilterEffect ImageBuffer and ImageData
for filters that directly manipulates pixel values. The conversion
is missing only on CG platforms because on CG platforms,
FilterEffect::transformResultColorSpace doesn't perform any operations
Its author assumed all filters are using CG ImageBuffers, and that
CG will handle the conversion which is not the case. The following filters
operates on the raw pixels inside an ImageBuffer, and this requires an explicit
color space conversion of the pixel values when the ImageData are retrieved
by calling FilterEffect::copy{Pre/Un}multipliedData().

The filters affected are feComponentTransfer, feComposite, feConvolveMatrix
feGaussianBlur, FELighting, feMorphology. The conversion is done
by CG, by drawing the input ImageBuffer to a new ImageBuffer that
has the correct color space tag. The ImageData is then pulled from
this new ImageBuffer and used in platformApplySoftware()

Tests: svg/filters/feComponentTransfer-clipped-expected.svg

svg/filters/feComponentTransfer-clipped.svg
svg/filters/feComposite-clipped-expected.svg
svg/filters/feComposite-clipped.svg
svg/filters/feConvolveMatrix-clipped-expected.svg
svg/filters/feConvolveMatrix-clipped.svg
svg/filters/feGaussianBlur-clipped-expected.svg
svg/filters/feGaussianBlur-clipped.svg
svg/filters/feLighting-clipped-expected.svg
svg/filters/feLighting-clipped.svg
svg/filters/feMorphology-clipped-expected.svg
svg/filters/feMorphology-clipped.svg

• platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware): Modified function call to

FilterEffect::premultipliedResult, color space conversion is required on CG
platforms, so operatingColorSpace is passed in and input will be converted to
that color space

• platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware): Similarly, color space conversion

Required on CG color space conversion is required on CG
platforms, so operatingColorSpace is passed in and input will be converted to
that color space

• platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware): converting to operating space

• platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplySoftware): converting to operating space

• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware): converting to operating space

• platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyDegenerate): converting to operating space
(WebCore::FEMorphology::platformApplySoftware): converting to operating space

• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::unmultipliedResult): modified function signature so that

The Optional ColorSpace enum could be passed in to copyUnmultipliedResult()

(WebCore::FilterEffect::premultipliedResult): modified function signature so that

The Optional ColorSpace enum could be passed in to copyUnmultipliedResult()

(WebCore::FilterEffect::convertImageDataToColorSpace): helper function that takes an ImageData ptr

as input, put it into an ImageBuffer, and calls convertImageBufferToColorSpace to
perform color conversion, and returns the converted ImageData

(WebCore::FilterEffect::convertImageBufferToColorSpace): helper function that takes an ImageBuffer ptr

as input, create a new ImageBuffer with target color space, write input ImageBuffer to this new buffer
(CG backend handles the conversion) and returns the ImageData in the buffer.

(WebCore::FilterEffect::copyConvertedImageBufferToDestination): helper function that copies data from ImageBuffer

whose data is converted to the correct color space, to the destination array

(WebCore::FilterEffect::copyConvertedImageDataToDestination): helper function that copies data from ImageData

whose data is converted to the correct color space, to the destination array

(WebCore::FilterEffect::copyUnmultipliedResult): added an optional argument, colorSpace, which will be passed

into requiresAdditionalColorSpaceConversion, in order to determine if color space conversion is required
when obtaining the unmultiplied result. Then, added code to convert color space before writing to the
destination array

(WebCore::FilterEffect::copyPremultipliedResult): added an optional argument, colorSpace, which will be passed

into requiresAdditionalColorSpaceConversion, in order to determine if color space conversion is required
when obtaining the premultiplied result. Then, added code to convert color space before writing to the
destination array.

(WebCore::FilterEffect::requiresImageDataColorSpaceConversion): unction that only returns true

when 1) destination color space is non-null and is different than current color space AND

2) the code is running on CG platforms

This function will only be called inside copy{Un, Pre}multipliedResult, to address the issue
where color space is needed for filters that modifies raw pixels.

• platform/graphics/filters/FilterEffect.h: Added function declarations

LayoutTests:

Added new tests that checks SVG render results for
feComponentTransfer, feComposite, feConvolveMatrix
feGaussianBlur, feMorphology and lighting

• svg/filters/feComponentTransfer-clipped-expected.svg: Added.
• svg/filters/feComponentTransfer-clipped.svg: Added.
• svg/filters/feComposite-clipped-expected.svg: Added.
• svg/filters/feComposite-clipped.svg: Added.
• svg/filters/feConvolveMatrix-clipped-expected.svg: Added.
• svg/filters/feConvolveMatrix-clipped.svg: Added.
• svg/filters/feGaussianBlur-clipped-expected.svg: Added.
• svg/filters/feGaussianBlur-clipped.svg: Added.
• svg/filters/feLighting-clipped-expected.svg: Added.
• svg/filters/feLighting-clipped.svg: Added.
• svg/filters/feMorphology-clipped-expected.svg: Added.
• svg/filters/feMorphology-clipped.svg: Added.

8:01 PM Changeset in webkit [262892] by Alan Bujtas

• 4 edits
  2 adds in trunk

[Line clamp] Do not apply the special anchor handling when the anchor content is visible after clamping
​https://bugs.webkit.org/show_bug.cgi?id=213052
<rdar://problem/59739131>

Reviewed by Simon Fraser.

Source/WebCore:

Line clamping tries to preserve the anchor text if it is at the bottom of the paragraph to support cases like "... Read more", where the "read more" is an actual link.
This patch makes sure that we only apply the special case handling if the anchor text get clamped.

Test: fast/flexbox/line-clamp-with-anchor-content-only.html

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

LayoutTests:

• fast/flexbox/line-clamp-with-anchor-content-only-expected.html: Added.
• fast/flexbox/line-clamp-with-anchor-content-only.html: Added.

7:40 PM Changeset in webkit [262891] by Wenson Hsieh

• 3 edits in trunk/Source/WebKit

[iOS] editing/pasteboard/dom-paste tests consistently time out
​https://bugs.webkit.org/show_bug.cgi?id=213061
<rdar://problem/64211161>

Reviewed by Darin Adler.

On recent versions of iOS, system changes have moved the timing of the call to
-requestAutocorrectionContextWithCompletionHandler: when focusing an editable element. This results in a
consistently reproducible deadlock between the UI process and web process if a page tries to request
programmatic clipboard access during the click event (importantly, in the same runloop as element focus).

What ends up happening is that the autocorrection context is requested by the UI process shortly after the
(unbounded) sync IPC message for the DOM paste arrives, so we end up waiting forever for the sync-IPC-blocked
web process to respond. Normally this just results in a 1 second hang, and the DOM paste proceeds as normal.
However these layout tests purposefully opt out of sync IPC timeouts (precisely so that we can catch bugs like
this). See below for more details.

• UIProcess/ios/WKContentViewInteraction.h:

Keep track of the most recent autocorrection context that arrived in the UI process.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanUpInteraction]):

Clear out the autocorrection context, in case the web process crashes.

(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):

If the autocorrection context is requested while handling a DOM paste, we know that the latest autocorrection
context must be up to date, since the autocorrection context is computed and sent immediately before a DOM paste
request. Use this to immediately invoke the completion handler, without any sync IPC back to the web process.

(-[WKContentView _handleAutocorrectionContext:]):

7:20 PM Changeset in webkit [262890] by Ross Kirsling

• 3 edits
  1 add in trunk

REGRESSION(r260697): [Intl] "missing script" locales like zh-TW are no longer mapped
​https://bugs.webkit.org/show_bug.cgi?id=213007

Reviewed by Darin Adler.

JSTests:

• stress/intl-missing-script-locales.js: Added.

Source/JavaScriptCore:

addMissingScriptLocales was removed from IntlObject when changing our locale resolution to depend more directly
on ICU, but apparently even latest ICU won't perform this legacy "region implies script" mapping for us.

ICU 65+ does have uloc_openAvailableByType which will do the trick, so perhaps we should use this in the future,
but it still doesn't seem to help us with Collator, which has its own separate set of "available locales".

The exact set of locales which should be mapped is currently under discussion here:
​https://github.com/tc39/ecma402/issues/159
But the crux seems to be that we should ensure we have an xx-ZZ alias for all available xx-Yyyy-ZZ locales.

• runtime/IntlObject.cpp:

(JSC::addScriptlessLocaleIfNeeded):
(JSC::intlAvailableLocales):
(JSC::intlCollatorAvailableLocales):

7:20 PM Changeset in webkit [262889] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

[iOS] Option + Forward Delete should delete next word
​https://bugs.webkit.org/show_bug.cgi?id=213062
rdar://64225458

Patch by Hiro (mzp) Mizuno <​mzp@apple.com> on 2020-06-10
Reviewed by Daniel Bates.

Source/WebKit:

Implement support for pressing Option + Forward Delete to delete the next word. This makes text editing
in WebKit more closely match the platform conventions.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformAction:withSender:]): Handle _deleteForwardByWord.
(-[WKContentView _deleteForwardByWord]): Added.

LayoutTests:

Add tests to ensure that Option + Forward Delete delete to the next word.
Skip the tests for now until we have the UIKit fix <rdar://problem/63253983>.

• fast/events/ios/key-command-delete-next-word-expected.txt: Added.
• fast/events/ios/key-command-delete-next-word.html: Added.
• platform/ios/TestExpectations: Skip tests for now

6:05 PM Changeset in webkit [262888] by Alan Coon

• 8 edits in branches/safari-610.1.15.51-branch/Source

Versioning.

6:05 PM Changeset in webkit [262887] by Alan Coon

• 6 edits
  1 copy
  1 add in branches/safari-609-branch

Cherry-pick r262870. rdar://problem/64232759

Improve CSP compliance under PSON
​https://bugs.webkit.org/show_bug.cgi?id=212995
<rdar://problem/62996186>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebaseline an existing test, since CSP is now checked before any navigations performed by a form action.

• web-platform-tests/content-security-policy/form-action/form-action-src-blocked.sub-expected.txt:

Source/WebCore:

Tests: http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked.html

The form submission logic was only considering CSP if the form
action was a JavaScript URL. This is incorrect, as CSP might
apply to any URL.

This is also covered by the existing form-action CSP tests.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): All URLs should be evaluted for compliance with CSP.

LayoutTests:

Add a new test to confirm that CSP rules are honored for form-action operations during process swap.
This also rebaselines an existing test, since CSP is now checked before any navigations performed by
a form action.

• http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt: Rebaselined.
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt.
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:46 PM Changeset in webkit [262886] by Alan Coon

• 1 copy in tags/Safari-610.1.15.51.1

Tag Safari-610.1.15.51.1.

5:46 PM Changeset in webkit [262885] by Jonathan Bedard

• 3 edits in trunk/WebKitLibraries

Catalyst WebKit apps continue to play audio after quitting (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=212981
<rdar://problem/57089471>

Unreviewed build fix.

• WebKitPrivateFrameworkStubs/appletvos/13/RunningBoardServices.framework/RunningBoardServices.tbd:
• WebKitPrivateFrameworkStubs/watchos/6/RunningBoardServices.framework/RunningBoardServices.tbd:

5:41 PM Changeset in webkit [262884] by Jonathan Bedard

• 2 edits
  1 delete in trunk/Tools

Generalize configure-xcode-for-ios-development (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=207043
<rdar://problem/63946933>

Reviewed by Darin Adler.

• EWSTools/start-queue-mac.sh: Use configure-xcode-for-embedded-development over configure-xcode-for-ios-development.
• Scripts/configure-xcode-for-ios-development: Removed.

5:36 PM Changeset in webkit [262883] by Alan Coon

• 2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r262850. rdar://problem/64226899

[iOS] Add entitlement for PAC exceptions
​https://bugs.webkit.org/show_bug.cgi?id=213027
<rdar://problem/63985737>

Reviewed by Brent Fulgham.

On iOS, add entitlement for PAC exceptions.

• Scripts/process-entitlements.sh:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:36 PM Changeset in webkit [262882] by Alan Coon

• 7 edits
  2 adds in branches/safari-609-branch

Cherry-pick r262841. rdar://problem/64226920

REGRESSION(r262798): fast/mediastream/media-stream-track-interrupted.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=213011

Reviewed by Eric Carlson.

Source/WebCore:

Before the patch, a source that is muted and for which its observers get ended will not be ended.
This is a potential issue as the source can get unmuted, in which case, the audio shared unit might be asked to restart.
This is crashing in debug as we would not have the AudioSession correct category for audio capture.

Test: fast/mediastream/track-ended-while-muted.html
Also covered by fast/mediastream/media-stream-track-interrupted.html no longer flakily crashing in debug.

• platform/mediastream/RealtimeMediaSource.cpp: (WebCore::RealtimeMediaSource::requestToEnd): End the source even if muted.
• platform/mediastream/RealtimeMediaSource.h:
• testing/Internals.cpp: (WebCore::Internals::isMediaStreamSourceEnded const):
• testing/Internals.h:
• testing/Internals.idl: Add necessary test infrastructure.

LayoutTests:

• fast/mediastream/track-ended-while-muted-expected.txt: Added.
• fast/mediastream/track-ended-while-muted.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:35 PM Changeset in webkit [262881] by Alan Coon

• 14 edits in branches/safari-609-branch

Apply patch. rdar://problem/64226920

5:33 PM Changeset in webkit [262880] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

[Cocoa] CRASH: imported/w3c/web-platform-tests/remote-playback/watch-availability-initial-callback.html is flaky crashing
​https://bugs.webkit.org/show_bug.cgi?id=213044
<rdar://problem/62317723>

Reviewed by Eric Carlson.

Add null-checks around previously non-null-checked derefs of WeakPtr<HTMLMediaElement>.

• Modules/remoteplayback/RemotePlayback.cpp:

(WebCore::RemotePlayback::watchAvailability):
(WebCore::RemotePlayback::shouldPlayToRemoteTargetChanged):
(WebCore::RemotePlayback::playbackTargetPickerWasDismissed):

5:28 PM Changeset in webkit [262879] by sihui_liu@apple.com

• 4 edits in trunk

Text manipulation does not observe inserted elements that are invisible
​https://bugs.webkit.org/show_bug.cgi?id=213057
<rdar://problem/63768253>

Reviewed by Wenson Hsieh.

Source/WebCore:

TextManipulationController gets notification when renderer of an element is created and starts observing the
element. It currently sets the observing range to be the visible start position and visible end position of the
element. When the invisible content becomes visible later, TextManipulationController does not get notification
and will miss the content. Therefore, TextManipulationController should use the actual start and end positions
of the element for range.

Test: TextManipulation.StartTextManipulationFindsInsertedClippedText

• editing/TextManipulationController.cpp:

(WebCore::makeHashablePositionRange):
(WebCore::TextManipulationController::scheduleObservationUpdate):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

5:15 PM Changeset in webkit [262878] by ggaren@apple.com

• 45 edits in trunk

Some style improvements to main thread code
​https://bugs.webkit.org/show_bug.cgi?id=213051

Reviewed by Darin Adler.

Source/WebCore:

Updated for rename.

• WebCore.order:
• platform/ios/wak/WebCoreThread.mm:

(StartWebThread):

Source/WebDriver:

Updated for rename.

• WebDriverService.cpp:

(WebDriver::WebDriverService::run):

Source/WebKit:

Updated for rename.

• Shared/Cocoa/WebKit2InitializeCocoa.mm:

(WebKit::runInitializationCode):
(WebKit::InitializeWebKit2):

• Shared/WebKit2Initialize.cpp:

(WebKit::InitializeWebKit2):

Source/WebKitLegacy/mac:

Updated for rename.

• History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]):

• History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]):

• Misc/WebCache.mm:

(+[WebCache initialize]):

• Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]):

• Misc/WebIconDatabase.mm:
• Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

• Plugins/WebBaseNetscapePluginView.mm:
• Plugins/WebBasePluginPackage.mm:

(+[WebBasePluginPackage initialize]):

• Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):

• WebCoreSupport/WebEditorClient.mm:

(+[WebUndoStep initialize]):

• WebCoreSupport/WebFrameLoaderClient.mm:

(+[WebFramePolicyListener initialize]):

• WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]):

• WebView/WebDataSource.mm:

(+[WebDataSource initialize]):

• WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):

• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

• WebView/WebResource.mm:

(+[WebResourcePrivate initialize]):

• WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]):

• WebView/WebView.mm:

(+[WebView initialize]):

• WebView/WebViewData.mm:

(+[WebViewPrivate initialize]):

Source/WebKitLegacy/win:

Updated for rename.

• WebView.cpp:

(WebView::WebView):

Source/WTF:

• wtf/RunLoop.cpp:

(WTF::RunLoop::initializeMain): Renamed initializeMainRunLoop => initializeMain
to match the getter's name.
(WTF::RunLoop::initializeWeb): Samesies.
(WTF::RunLoop::webIfExists): Added an IfExists accessor for use in
scheduleDispatchFunctionsOnMainThread().
(WTF::RunLoop::initializeMainRunLoop): Deleted.
(WTF::RunLoop::initializeWebRunLoop): Deleted.

• wtf/RunLoop.h:

• wtf/cocoa/MainThreadCocoa.mm:

(WTF::scheduleDispatchFunctionsOnMainThread): Use RunLoop::webIfExists()
to check for the web thread run loop, since that's more explicit than
checking a pthread variable.

(WTF::isWebThread): Renamed mainThreadPthread => webThreadPthread because
it's the web thread. Changed style on globals to "s_" for consistency.
Removed mainThreadNSThread because it was unused.
(WTF::initializeApplicationUIThread):
(WTF::initializeWebThread):
(WTF::canCurrentThreadAccessThreadLocalData):

Tools:

Updated for rename.

• TestWebKitAPI/Tests/WTF/RefPtr.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/RunLoop.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:

(ApplicationManifestParserTest::SetUp):

• TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:

(TestWebKitAPI::ComplexTextControllerTest::SetUp):

• TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::ContentExtensionTest::SetUp):

• TestWebKitAPI/Tests/WebCore/DNS.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:

(TestWebKitAPI::TEST_F):

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(initializeInAppBrowserPrivacyTestSettings):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

5:10 PM Changeset in webkit [262877] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=212714

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-06-10
Reviewed by Geoffrey Garen.

Replaced call to WTFMove(widgetNewParentMap()) with std::exchange(widgetNewParentMap(), { }) in the
WidgetHierarchyUpdatesSuspensionScope::moveWidgets(), thereby making it explicit to set the source map empty.

Test would be added later.

• rendering/RenderWidget.cpp:

(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):

5:07 PM Changeset in webkit [262876] by Jonathan Bedard

• 3 edits
  1 copy in trunk/Tools

results.webkit.org: Health check should access redis and Cassandra
​https://bugs.webkit.org/show_bug.cgi?id=212899
<rdar://problem/64118077>

Reviewed by Stephanie Lewis.

• resultsdbpy/resultsdbpy/example/main.py:

(health): Check the health status of the model.

• resultsdbpy/resultsdbpy/model/model.py:

(Model.HealthTable):
(Model.init): Construct a Cassandra table used to check the health of our Cassandra connection.
(Model.healthy): Make both a read and write connection to our two database dependencies so that if
our connection to those databases fails, an instance will be forced to restart.

• resultsdbpy/resultsdbpy/model/model_unittest.py: Added.

(ModelTest):
(ModelTest.init_database):
(ModelTest.test_health):

5:00 PM Changeset in webkit [262875] by Jonathan Bedard

• 3 edits in trunk/Source/WebKit

WebKit:Add PepperUICoreSPI.h (Follow-up fix 2)
​https://bugs.webkit.org/show_bug.cgi?id=212996
<rdar://problem/64182627>

Unreviewed build fix.

• UIProcess/ios/forms/WKNumberPadViewController.mm:

(-[WKNumberPadViewController addContentViewAnimations:]): Correct APPLE_INTERNAL_SDK macro.

• UIProcess/ios/forms/WKQuickboardListViewController.mm:

(-[WKQuickboardListViewController initWithDelegate:]): Ditto.

4:58 PM Changeset in webkit [262874] by Fujii Hironori

• 3 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

• platform/wincairo/TestExpectations:
• platform/wincairo/fast/text/justify-ideograph-leading-expansion-expected.txt:

4:38 PM Changeset in webkit [262873] by Alan Coon

• 1 copy in tags/Safari-610.1.15.50.3

Tag Safari-610.1.15.50.3.

4:15 PM Changeset in webkit [262872] by ysuzuki@apple.com

• 3 edits
  2 adds in trunk

[JSC] JSCallbackObject::deleteProperty should redirect to Parent::deletePropertyByIndex if propertyName is index
​https://bugs.webkit.org/show_bug.cgi?id=213041
<rdar://problem/64204300>

Reviewed by Darin Adler.

Source/JavaScriptCore:

We have an infinite recursion here.

-> JSCallbackObject::deletePropertyByIndex

-> JSCell::deleteProperty

-> JSCallbackObject::deleteProperty

-> JSObject::deleteProperty

-> JSCallbackObject::deletePropertyByIndex

When propertyName in JSCallbackObject::deleteProperty is an index, we should go to JSObject::deletePropertyByIndex instead of JSObject::deleteProperty.

• API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::deleteProperty):

LayoutTests:

• js/dom/callbackobject-delete-should-not-infinite-recursion-expected.txt: Added.
• js/dom/callbackobject-delete-should-not-infinite-recursion.html: Added.

4:14 PM Changeset in webkit [262871] by Alan Bujtas

• 2 edits in trunk/LayoutTests

[ Mac ] mathml/scripts-removeChild.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=208574
<rdar://problem/60041327>

Unreviewed test gardening.

Can't reproduce flakiness anymore.

• platform/mac/TestExpectations:

4:11 PM Changeset in webkit [262870] by Brent Fulgham

• 6 edits
  1 copy
  1 add in trunk

Improve CSP compliance under PSON
​https://bugs.webkit.org/show_bug.cgi?id=212995
<rdar://problem/62996186>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebaseline an existing test, since CSP is now checked before any navigations performed by a form action.

• web-platform-tests/content-security-policy/form-action/form-action-src-blocked.sub-expected.txt:

Source/WebCore:

Tests: http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked.html

The form submission logic was only considering CSP if the form
action was a JavaScript URL. This is incorrect, as CSP might
apply to any URL.

This is also covered by the existing form-action CSP tests.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm): All URLs should be evaluted for
compliance with CSP.

LayoutTests:

Add a new test to confirm that CSP rules are honored for form-action operations during process swap.
This also rebaselines an existing test, since CSP is now checked before any navigations performed by
a form action.

• http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt: Rebaselined.
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt.
• http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked.html: Added.

4:11 PM Changeset in webkit [262869] by Russell Epstein

• 2 edits in branches/safari-610.1.15.51-branch/Source/WebKit

Cherry-pick r262864. rdar://problem/64223970

Crash growing a CFData with incremental PDF loading.
<rdar://problem/63670403> and ​https://bugs.webkit.org/show_bug.cgi?id=213035

Reviewed by Alex Christensen.

No test - No reliable way to trigger.

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::ensureDataBufferLength): When you call CFDataCreateMutable with a size other than 0, your data object can never grow beyond that size. And, in fact, CFData will crash on purpose when this is attempted. So always create our mutable CFDatas with size 0 even if we immediately plan to grow them.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:05 PM Changeset in webkit [262868] by Jonathan Bedard

• 2 edits in trunk/Source/WebKit

WebKit:Add PepperUICoreSPI.h (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=212996
<rdar://problem/64182627>

Unreviewed build fix.

• Platform/spi/watchos/PepperUICoreSPI.h: Add PUICPickerView headers.

4:04 PM Changeset in webkit [262867] by Alan Coon

• 1 edit in branches/safari-609-branch/Source/WebKit/UIProcess/WebProcessProxy.h

Unreviewed build fix. rdar://problem/63902456

Undeclared identifier 'm_unexpectedActivityTimer'.

3:37 PM Changeset in webkit [262866] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r262858): Fix macOS build when building EndowmentStateTracker.mm

• UIProcess/EndowmentStateTracker.mm:
• Move #if PLATFORM(IOS_FAMILY) to fix macOS build.

3:34 PM Changeset in webkit [262865] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[Cocoa] Return early from preference change notification handler if there is no observer
​https://bugs.webkit.org/show_bug.cgi?id=213050

Reviewed by Darin Adler.

Currently, the observer member is checked inside the loop iterating over all the keys,
but this check should be moved outside of the loop.

No new tests, since this is not a change in behavior.

• UIProcess/Cocoa/PreferenceObserver.mm:

(-[WKUserDefaults _notifyObserversOfChangeFromValuesForKeys:toValuesForKeys:]):

3:23 PM Changeset in webkit [262864] by beidson@apple.com

• 2 edits in trunk/Source/WebKit

Crash growing a CFData with incremental PDF loading.
<rdar://problem/63670403> and ​https://bugs.webkit.org/show_bug.cgi?id=213035

Reviewed by Alex Christensen.

No test - No reliable way to trigger.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::ensureDataBufferLength): When you call CFDataCreateMutable with a size other than 0,

your data object can never grow beyond that size.
And, in fact, CFData will crash on purpose when this is attempted.
So always create our mutable CFDatas with size 0 even if we immediately plan to grow them.

3:03 PM Changeset in webkit [262863] by ggaren@apple.com

• 4 edits in trunk/Source/WTF

[Cocoa] Build callOnMainThread on WTF::RunLoop rather than on NSObject methods
​https://bugs.webkit.org/show_bug.cgi?id=213043

Reviewed by Simon Fraser.

Original patch by Sihui Liu.

From ​https://bugs.webkit.org/show_bug.cgi?id=202874, this is the subset
of Sihui's patch that unifies some of RunLoop and callOnMainThread.

My goal is to simplify the code, and shrink the diff when testing
CFRunLoopSource1 in the future.

• wtf/RunLoop.cpp:

(WTF::RunLoop::initializeWebRunLoop):
(WTF::RunLoop::web):

• wtf/RunLoop.h:
• wtf/cocoa/MainThreadCocoa.mm:

(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::initializeWebThread):
(-[JSWTFMainThreadCaller call]): Deleted.

2:47 PM Changeset in webkit [262862] by Jonathan Bedard

• 3 edits
  1 add in trunk/Source/WebKit

WebKit: Add ClockKitSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=212994
<rdar://problem/64181092>

Reviewed by Wenson Hsieh.

No new tests, behavior unchanged.

• Platform/spi/watchos: Added.
• Platform/spi/watchos/ClockKitSPI.h: Added.
• UIProcess/ios/forms/WKTimePickerViewController.mm: Import ClockKitSPI.h and UIKitSPI.h.
• WebKit.xcodeproj/project.pbxproj: Include ClockKitSPI.

2:44 PM Changeset in webkit [262861] by BJ Burg

• 6 edits in trunk/Source

WebDriver on non-iOS ports cannot perform ActionChain which has scrolling down to the element and click it
​https://bugs.webkit.org/show_bug.cgi?id=208232
<rdar://problem/59859491>

Reviewed by Devin Rousso.

Source/WebCore:

• platform/ScrollView.h:
• platform/ScrollView.cpp:

(WebCore::ScrollView::rootViewToContents const):
Create a version of this function that works with FloatPoint.

Source/WebKit:

• UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
The provided coordinates are in LayoutViewport coordinate system, which does
not take topContentInset into account. Add back in the topContentInset
when translating to flipped window coordinates.

• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout):
The calculations of element bounds and IVCP have an incorrect handling of
root coordinates as contents/absolute coordinates. Add the missing conversion.

2:26 PM Changeset in webkit [262860] by Brent Fulgham

• 4 edits in trunk/Source/WebKit

[iOS] Update sandbox rules for correct sanitizer paths in current OS releases
​https://bugs.webkit.org/show_bug.cgi?id=213040
<rdar://problem/64187043>

Reviewed by Per Arne Vollan.

Update the sandbox rules on iOS platforms to allow access to the
new system locations for Asan libraries.

• Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

2:17 PM Changeset in webkit [262859] by keith_miller@apple.com

• 2 edits in trunk/Tools

run-jsc-stress-tests should skip tests marked as slow in quick mode.
​https://bugs.webkit.org/show_bug.cgi?id=213042

Reviewed by Yusuke Suzuki.

• Scripts/run-jsc-stress-tests:

1:49 PM Changeset in webkit [262858] by jer.noble@apple.com

• 13 edits
  2 adds in trunk

Catalyst WebKit apps continue to play audio after quitting
​https://bugs.webkit.org/show_bug.cgi?id=212981
<rdar://problem/57089471>

Reviewed by Chris Dumez.

Source/WebKit:

RunningBoard will track whether a process (and it's associated child processes) are "user-visible" by
granting those processes an "endowment", similar to the existing endowment for application visibility.
Track changes to these endowments using a RBSProcessMonitor, and for Catalyst apps, react to losing the
"user-visible" endowment by suspending all media playback.

Move all the endowment-related code into a new class, EndowmentStateTracker, which is a singleton object
that can have mulitple WebPageProxy clients. Update references to the previously global static
isApplicationForeground() function to refer to EndowmentStateTracker instead.

Drive-by fix: move some iOS-only functions in WebPageProxy.cpp into WebPageProxyIOS.mm.

• UIProcess/ApplicationStateTracker.h:
• UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):
(WebKit::isApplicationForeground): Deleted.

• UIProcess/EndowmentStateTracker.h: Added.

(WebKit::EndowmentStateTracker::isVisible const):
(WebKit::EndowmentStateTracker::isUserFacing const):

• UIProcess/EndowmentStateTracker.mm: Added.

(WebKit::handleForPID):
(WebKit::EndowmentStateTracker::isApplicationForeground):
(WebKit::EndowmentStateTracker::isApplicationUserFacing):
(WebKit::EndowmentStateTracker::singleton):
(WebKit::EndowmentStateTracker::EndowmentStateTracker):
(WebKit::EndowmentStateTracker::addClient):
(WebKit::EndowmentStateTracker::removeClient):
(WebKit::EndowmentStateTracker::setIsUserFacing):
(WebKit::EndowmentStateTracker::setIsVisible):

• UIProcess/WebPageProxy.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::processWillBecomeSuspended): Deleted.
(WebKit::WebPageProxy::processWillBecomeForeground): Deleted.

• UIProcess/WebPageProxy.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isApplicationVisible):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::processWillBecomeSuspended):
(WebKit::WebPageProxy::processWillBecomeForeground):
(WebKit::WebPageProxy::isUserFacingChanged):
(WebKit::WebPageProxy::isVisibleChanged):

• WebKit.xcodeproj/project.pbxproj:

Source/WTF:

Add the ability to call copyToVector() on a WeakHashSet. This requires two changes:

• A template specialization that returns a Vector<WeakPtr<T>> from copyToVector()
• A template specialization that calls calculateSize() rather than size() on the object being iterated upon.

• wtf/WeakHashSet.h:

(WTF::copyToVector):

WebKitLibraries:

• WebKitPrivateFrameworkStubs/iOS/13/RunningBoardServices.framework/RunningBoardServices.tbd:

1:49 PM Changeset in webkit [262857] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

Unreviewed, reverting r262718.
​https://bugs.webkit.org/show_bug.cgi?id=213047

Broke WPE Debug too

Reverted changeset:

"[WebXR] Pass an unsigned long to cancelAnimationCallback() as
handle"
​https://bugs.webkit.org/show_bug.cgi?id=212529
​https://trac.webkit.org/changeset/262718

1:37 PM Changeset in webkit [262856] by graouts@webkit.org

• 6 edits in trunk

Subframes should not autosize independently
​https://bugs.webkit.org/show_bug.cgi?id=212984
<rdar://problem/64175493>

Reviewed by Simon Fraser.

Source/WebCore:

• page/FrameView.cpp:

(WebCore::FrameView::enableAutoSizeMode):

Source/WebKit:

Ensure we only call FrameView::enableSizeToContentAutoSizeMode() for the main frame.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:

(TEST): Added test for <object>.

1:36 PM Changeset in webkit [262855] by Philippe Normand

• 2 edits in trunk/Source/WebCore

Unreviewed, WPE Debug build fix attempt after r262838.

Second attempt. :) Still broken because of r262718 though...

• platform/xr/openxr/PlatformXROpenXR.cpp:

1:34 PM Changeset in webkit [262854] by Jonathan Bedard

• 13 edits
  2 adds in trunk/Source/WebKit

WebKit:Add PepperUICoreSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=212996
<rdar://problem/64182627>

Reviewed by Tim Horton.

No new tests, behavior unchanged.

• Platform/spi/watchos: Added.
• Platform/spi/watchos/PepperUICoreSPI.h: Added.
• UIProcess/Cocoa/WKSafeBrowsingWarning.mm: Include PepperUICoreSPI header.
• UIProcess/ios/WKScrollView.mm: Ditto.
• UIProcess/ios/forms/WKDatePickerViewController.mm: Remove headers duplicated in PepperUICoreSPI.h.
• UIProcess/ios/forms/WKFocusedFormControlView.mm: Ditto.
• UIProcess/ios/forms/WKNumberPadView.mm: Include PepperUICoreSPI header.
• UIProcess/ios/forms/WKNumberPadViewController.h: Remove headers duplicated in PepperUICoreSPI.h.
• UIProcess/ios/forms/WKNumberPadViewController.mm: Ditto.

(-[WKNumberPadViewController addContentViewAnimations:]): Limit addAnimation to Internal builds.

• UIProcess/ios/forms/WKQuickboardListViewController.h: Include PepperUICoreSPI header.
• UIProcess/ios/forms/WKQuickboardListViewController.mm: Remove headers duplicated in PepperUICoreSPI.h.

(-[WKQuickboardListViewController initWithDelegate:]):

• UIProcess/ios/forms/WKSelectMenuListViewController.mm: Remove headers duplicated in PepperUICoreSPI.h.
• UIProcess/ios/forms/WKTextInputListViewController.mm: Ditto.
• WebKit.xcodeproj/project.pbxproj: Add PepperUICoreSPI.h.

1:31 PM Changeset in webkit [262853] by Philippe Normand

• 2 edits in trunk/Source/WebCore

Unreviewed, WPE Debug build fix attempt after r262838.

Still broken because of r262718 though...

• platform/xr/openxr/PlatformXROpenXR.cpp:

1:19 PM Changeset in webkit [262852] by Ryan Haddad

• 2 edits in trunk/LayoutTests/imported/w3c

REGRESSION(r262809): [ macOS iOS ] imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-minimum-height-orthogonal-001.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=213026

Unreviewed test gardening.

• web-platform-tests/css/css-grid/grid-items/grid-items-minimum-height-orthogonal-001-expected.txt:

Check in a new baseline that accounts for the failing subtests to get the bots to green.

1:19 PM Changeset in webkit [262851] by Ryan Haddad

• 2 edits in trunk/Tools

[Mojave] Flaky API Test: TestWebKitAPI.WebKitLegacy.CrossPartitionFileSchemeAccess
​https://bugs.webkit.org/show_bug.cgi?id=206956

Unreviewed test gardening.

• TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Disable this test for Mojave.

12:31 PM Changeset in webkit [262850] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] Add entitlement for PAC exceptions
​https://bugs.webkit.org/show_bug.cgi?id=213027
<rdar://problem/63985737>

Reviewed by Brent Fulgham.

On iOS, add entitlement for PAC exceptions.

• Scripts/process-entitlements.sh:

12:26 PM Changeset in webkit [262849] by James Savage

• 6 edits in trunk/Source/WebKit

Swift Overlay API refinements
​https://bugs.webkit.org/show_bug.cgi?id=212939
<rdar://problem/64140013>

Reviewed by Darin Adler.

This patch cleans up some inconsistencies in the various Swift projections,
and modifies JavaScript evaluation callbacks to be optional to account for
scripts which may not evaluate to a useful result (such as ones that simply
modify the DOM without reporting a status). It also standardizes on using
completionHandler as an argument label to match the rest of WebKit API, and
the majority of the Swift API refinements.

It also fixes a module issue where the WebKit.h umbrella was missing an
import of WKScriptReplyWithMessageHandler.h, making the type unusable from
Swift source files/

• Shared/API/Cocoa/WebKit.h: Add missing header.
• UIProcess/API/Cocoa/WebKitSwiftOverlay.swift:

(callAsyncJavaScript(_:arguments:in:completionHandler:)): Rename completion

argument, and make optional. Note: Optional closures are implicitly
@escaping, making the annotation redundant and incompatible, so it must
be removed. In Swift, Optional.map()'s closure is invoked iff the Optional
contains some value, and the result of that transform is returned, else
nil is propagated. This allows us to apply the closure transform if the
client value is non-nil, without using intermediary variables or if/let.

(evaluateJavaScript(_:in:completionHandler:)): Ditto.

• SwiftOverlay/Tests/WebKitTests.swift:

(WebKitTests.testAPI): Update names to reflect changes.

• SwiftOverlay/WebKitSwiftOverlay.xcodeproj/xcshareddata/xcschemes/Everything (Catalyst).xcscheme:

Ensure that the unit test files get built as part of Build & Run, so that
any changes to names get flagged without even running the tests.

• SwiftOverlay/WebKitSwiftOverlay.xcodeproj/xcshareddata/xcschemes/Everything.xcscheme:

Ditto.

12:20 PM Changeset in webkit [262848] by Devin Rousso

• 8 edits in trunk/Source/WebInspectorUI

Web Inspector: text inputs should not spellcheck
​https://bugs.webkit.org/show_bug.cgi?id=213032
<rdar://problem/64195429>

Reviewed by Brian Burg.

• UserInterface/Base/Main.js:

(WI._handleDeviceSettingsTabBarButtonClicked.showUserAgentInput):

• UserInterface/Views/BoxShadowEditor.js:

(WI.BoxShadowEditor):

• UserInterface/Views/CookiePopover.js:

(WI.CookiePopover.prototype.show.createInputRow):

• UserInterface/Views/EditableDataGridNode.js:

(WI.EditableDataGridNode.prototype.createCellContent):

• UserInterface/Views/InputPopover.js:

(WI.InputPopover.prototype.show):

• UserInterface/Views/ProbeSetDetailsSection.js:

(WI.ProbeSetDetailsSection.prototype._addProbeButtonClicked):

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createConsoleSettingsView):

12:08 PM Changeset in webkit [262847] by caitp@igalia.com

• 1 edit
  1 add in trunk/JSTests

[JSC] add stress test for op_get_private_name
​https://bugs.webkit.org/show_bug.cgi?id=213024

Reviewed by Mark Lam.

• stress/get-private-name.js: Added.

12:04 PM Changeset in webkit [262846] by Kate Cheney

• 2 edits in trunk/Source/WebKit

ASSERTION FAILED: suspendedState == State::Running in WebKit::WebResourceLoadStatisticsStore::suspend
​https://bugs.webkit.org/show_bug.cgi?id=213031
<rdar://problem/64131092>

Reviewed by Chris Dumez.

There is a race condition if two calls are made to
WebResourceLoadStatisticsStore::suspend() simultanously.
WebResourceLoadStatisticsStore::resume() notifies the background
thread to continue and releases a lock, then sometimes the second call
to suspend obtains the lock and updates the suspendedState variable
before the background thread resumes and checks the result. This patch allows the
suspendedState to be either State::Running or State::WillSuspend to
account for this.

No new tests, this should fix http/wpt/service-workers/service-worker-spinning-fetch.https.html.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
(WebKit::WebResourceLoadStatisticsStore::suspend):

10:59 AM Changeset in webkit [262845] by achristensen@apple.com

• 4 edits in trunk

Revert r259770
​https://bugs.webkit.org/show_bug.cgi?id=210097
<rdar://problem/64175992>

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(TEST):

10:42 AM Changeset in webkit [262844] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Add some null checks in PDFPlugin::updatePageAndDeviceScaleFactors
​https://bugs.webkit.org/show_bug.cgi?id=213009
<rdar://problem/63756100>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-06-10
Reviewed by Chris Dumez.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors):

9:51 AM Changeset in webkit [262843] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

BaseAudioSharedUnit does not need to restart its audio unit at resume time.
​https://bugs.webkit.org/show_bug.cgi?id=213021

Reviewed by Eric Carlson.

Removing a case that should not happen, and was guarded by ASSERT.
Keeping ASSERT to make sure we do not break this assumption.

• platform/mediastream/mac/BaseAudioSharedUnit.cpp:

(WebCore::BaseAudioSharedUnit::resume):
(WebCore::BaseAudioSharedUnit::suspend):

9:20 AM Changeset in webkit [262842] by Devin Rousso

• 3 edits
  2 adds in trunk

Web Inspector: XHR request with same URL as main resource will hide the main resource request
​https://bugs.webkit.org/show_bug.cgi?id=212850
<rdar://problem/33072149>

Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype._addNewResourceToFrameOrTarget):
When creating a new resource, don't re-use the frame's main resource if the URL matches.

LayoutTests:

• inspector/network/request-main-url.html: Added.
• inspector/network/request-main-url-expected.txt: Added.

9:02 AM Changeset in webkit [262841] by youenn@apple.com

• 7 edits
  2 adds in trunk

REGRESSION(r262798): fast/mediastream/media-stream-track-interrupted.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=213011

Reviewed by Eric Carlson.

Source/WebCore:

Before the patch, a source that is muted and for which its observers get ended will not be ended.
This is a potential issue as the source can get unmuted, in which case, the audio shared unit might be asked to restart.
This is crashing in debug as we would not have the AudioSession correct category for audio capture.

Test: fast/mediastream/track-ended-while-muted.html
Also covered by fast/mediastream/media-stream-track-interrupted.html no longer flakily crashing in debug.

• platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::requestToEnd):
End the source even if muted.

• platform/mediastream/RealtimeMediaSource.h:
• testing/Internals.cpp:

(WebCore::Internals::isMediaStreamSourceEnded const):

• testing/Internals.h:
• testing/Internals.idl:

Add necessary test infrastructure.

LayoutTests:

• fast/mediastream/track-ended-while-muted-expected.txt: Added.
• fast/mediastream/track-ended-while-muted.html: Added.

8:35 AM Changeset in webkit [262840] by clopez@igalia.com

• 28 edits
  8 adds
  12 deletes in trunk/LayoutTests

Layout tests outside of the WPT import should not use resources from it
​https://bugs.webkit.org/show_bug.cgi?id=212661

Reviewed by Youenn Fablet.

Some layout tests were using resource files from the imported WPT tests.
This is an issue because updating the WPT tests may break this tests in the future.

To fix this the used resource files are copied inside the main folder of each test
and the tests modified to use them.

On top of that, some tests are de-duplicates (in favor of the WPT versions, which are the same).
This is the list of tests de-duplicated:
canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html -> imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.emptysrc.html
canvas/philip/tests/2d.drawImage.incomplete.nosrc.html -> imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.nosrc.html
canvas/philip/tests/2d.drawImage.incomplete.removedsrc.html -> imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.removedsrc.html
canvas/philip/tests/2d.pattern.image.incomplete.emptysrc.html -> imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.emptysrc.html
canvas/philip/tests/2d.pattern.image.incomplete.removedsrc.html -> imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.removedsrc.html
fast/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees.html -> imported/w3c/web-platform-tests/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees.html

• canvas/philip/tests/2d.drawImage.incomplete.emptysrc-expected.txt: Removed.
• canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html: Removed.
• canvas/philip/tests/2d.drawImage.incomplete.nosrc-expected.txt: Removed.
• canvas/philip/tests/2d.drawImage.incomplete.nosrc.html: Removed.
• canvas/philip/tests/2d.drawImage.incomplete.removedsrc-expected.txt: Removed.
• canvas/philip/tests/2d.drawImage.incomplete.removedsrc.html: Removed.
• canvas/philip/tests/2d.pattern.image.incomplete.emptysrc-expected.txt: Removed.
• canvas/philip/tests/2d.pattern.image.incomplete.emptysrc.html: Removed.
• canvas/philip/tests/2d.pattern.image.incomplete.removedsrc-expected.txt: Removed.
• canvas/philip/tests/2d.pattern.image.incomplete.removedsrc.html: Removed.
• fast/css/resources/shadow-helper.js: Added.

(getElementByShadowIds):
(ceClass.):
(installCustomElement):

• fast/css/shadow-parts/exportparts-syntax.html:
• fast/css/shadow-parts/invalidation-class-before-after.html:
• fast/css/shadow-parts/invalidation-class-descendant-combinator-export.html:
• fast/css/shadow-parts/invalidation-class-descendant-combinator.html:
• fast/css/shadow-parts/invalidation-class-sibling-combinator-export.html:
• fast/css/shadow-parts/invalidation-class-sibling-combinator.html:
• fast/custom-elements/DOMImplementation-createDocument.html:
• fast/custom-elements/adopting-from-frameless-document.html:
• fast/custom-elements/disconnected-callback-in-detached-iframe.html:
• fast/custom-elements/document-createElementNS.html:
• fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html:
• fast/custom-elements/perform-microtask-checkpoint-before-construction.html:
• fast/custom-elements/reactions-for-webkit-extensions.html:
• fast/custom-elements/resources/custom-elements-helpers.js: Added.

(create_window_in_test):
(test_with_window):
(prototype.attributeChangedCallback):
(prototype.connectedCallback):
(prototype.disconnectedCallback):
(prototype.adoptedCallback):
(return.takeLog):
(create_constructor_log):
(assert_constructor_log_entry):
(create_connected_callback_log):
(assert_connected_log_entry):
(create_disconnected_callback_log):
(assert_disconnected_log_entry):
(assert_adopted_log_entry):
(create_adopted_callback_log):
(create_attribute_changed_callback_log):
(assert_attribute_log_entry):
(define_new_custom_element.CustomElement):
(define_new_custom_element.CustomElement.prototype.attributeChangedCallback):
(define_new_custom_element.CustomElement.prototype.connectedCallback):
(define_new_custom_element.CustomElement.prototype.disconnectedCallback):
(define_new_custom_element.CustomElement.prototype.adoptedCallback):
(define_new_custom_element.return.takeLog):
(CustomElement):
(CustomElement.prototype.attributeChangedCallback):
(CustomElement.prototype.connectedCallback):
(CustomElement.prototype.disconnectedCallback):
(CustomElement.prototype.adoptedCallback):

• fast/custom-elements/resources/reactions.js: Added.

(testNodeConnector):
(testNodeDisconnector):
(testInsertingMarkup):
(testParsingMarkup):
(prototype.test):
(testReflectBooleanAttribute):
(testAttributeAdder):

• fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html:
• fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html:
• fast/images/resources/green-256x256.png: Added.
• fast/images/sizes-dynamic-001-expected.html:
• fast/images/sizes-dynamic-001.html:
• fast/images/sizes-dynamic-002-expected.html:
• fast/images/sizes-dynamic-002.html:
• fast/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees-expected.txt: Removed.
• fast/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees.html: Removed.
• mathml/non-core/frac-linethickness-001-expected.html:
• mathml/non-core/frac-linethickness-001.html:
• mathml/non-core/frac-linethickness-002-expected.html:
• mathml/non-core/frac-linethickness-002.html:
• mathml/non-core/lengths-1.html:
• mathml/non-core/lengths-2.html:
• mathml/non-core/lengths-3.html:
• mathml/presentation/radical-bar-visibility.html:
• mathml/resources/fraction-rulethickness10000.woff: Added.
• mathml/resources/radical-degreebottomraisepercent25-rulethickness1000.woff: Added.
• mathml/resources/xheight500.woff: Added.

7:30 AM Changeset in webkit [262839] by Wenson Hsieh

• 2 edits in trunk/LayoutTests

[iPadOS] editing/selection/ios/toggle-callout-bar-after-tap-in-selected-non-editable-text.html times out
​https://bugs.webkit.org/show_bug.cgi?id=213010
<rdar://problem/64182061>

Reviewed by Tim Horton.

This test times out because the second tap (which is intended to toggle callout bar visibility by tapping on the
text selection) misses completely, due to the fact that the midpoint of the selected paragraph element is
somewhere in the middle of the page.

Fix this by simply making the selection target inline-block, such that the element width doesn't expand to
the width of the page.

• editing/selection/ios/toggle-callout-bar-after-tap-in-selected-non-editable-text.html:

6:20 AM WPTExportProcess edited by clopez@igalia.com

(diff)

6:17 AM Changeset in webkit [262838] by svillar@igalia.com

• 5 edits
  2 adds
  2 deletes in trunk/Source/WebCore

[WebXR] Refactor OpenXR platform code
​https://bugs.webkit.org/show_bug.cgi?id=212470

Reviewed by Youenn Fablet.

Refactored a bit the platform code because we want to extend the PlatformXR::Device for the OpenXR
library. Also we're removing all the device id code because there is no need to expose it.

The idea from now on is to only define interfaces in PlatformXR.h and then add all the OpenXR specifics
in the newly renamed PlatformXROpenXR.[ch] files. We're also renaming PlatformXR.cpp to
PlatformXROpenXR.cpp to clearly state that it's the OpenXR implementation and to differentiate it from
the implementation agnostic PlatformXR.h file.

No new tests as there is no change in functionality.

• Sources.txt: Added renamed files. Removed PlatformXR.cpp.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• platform/xr/PlatformXR.cpp: Removed.
• platform/xr/PlatformXR.h:

(PlatformXR::Device::id const): Deleted.
(PlatformXR::Device::operator== const): Deleted.

• platform/xr/openxr/PlatformXROpenXR.cpp: Renamed from Source/WebCore/platform/xr/openxr/PlatformXR.cpp.

(PlatformXR::Instance::Impl::~Impl): Call xrDestroyInstance() on m_instance.
(PlatformXR::Instance::Impl::collectSupportedSessionModes): Do not pass XrSystemId as argument
as it's stored in the OpenXRDevice object.
(PlatformXR::Instance::enumerateImmersiveXRDevices): Create an OpenXRDevice instead of a Device.

• platform/xr/openxr/PlatformXROpenXR.h: Added.

4:18 AM Changeset in webkit [262837] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Unreviewed, reverting r262807.
​https://bugs.webkit.org/show_bug.cgi?id=213019

It is breaking JSC queues (Requested by caiolima on #webkit).

Reverted changeset:

"Add a timeout monitor for JSC stress test"
​https://bugs.webkit.org/show_bug.cgi?id=211978
​https://trac.webkit.org/changeset/262807

12:34 AM Changeset in webkit [262836] by Diego Pino Garcia

• 4 edits in trunk/LayoutTests

[GTK][WPE] Gardening, update expectations after r262834
​https://bugs.webkit.org/show_bug.cgi?id=213014

Unreviewed gardening.

Garden latest failures from bots and adjust the actual result of
several flaky failures.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

Jun 9, 2020:

9:16 PM Changeset in webkit [262835] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=212714

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-06-09
Reviewed by Geoffrey Garen.

Made change in the WidgetHierarchyUpdatesSuspensionScope::moveWidgets() to handle all widgets scheduled to move,
including new widgets scheduled during moveWidgets().

Test would be added later.

• rendering/RenderWidget.cpp:

(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):

9:10 PM Changeset in webkit [262834] by Fujii Hironori

• 17 edits in trunk

Unreviewed, reverting r262791.

WinCairo WebKit1 is crashing.

Reverted changeset:

"[Curl] Implement functions to use ResourceLoadStatistics."
​https://bugs.webkit.org/show_bug.cgi?id=207692
​https://trac.webkit.org/changeset/262791

8:44 PM Changeset in webkit [262833] by Simon Fraser

• 6 edits in trunk

Minor overflow layers cleanup
​https://bugs.webkit.org/show_bug.cgi?id=213002

Reviewed by Zalan Bujtas.

Source/WebCore:

Now that we parent scrollbar and scroll corner layers into the overflowControlsContainer
layer, we no need to parent these layers in RenderLayerCompositor::updateBackingAndHierarchy().

Also rename overflowControlsHostLayerBox to overflowControlsHostLayerRect to avoid
ambiguity with RenderBox.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDebugIndicators):
(WebCore::overflowControlsHostLayerRect):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::overflowControlsHostLayerBox): Deleted.

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):

LayoutTests:

New results now now that the scrollbar layers aren't reparented.

• compositing/overflow/overflow-scrollbar-layer-positions-expected.txt:

7:16 PM Changeset in webkit [262832] by timothy_horton@apple.com

• 4 edits in trunk/Source

Stop using the wrong LaunchServices SPI for getting an app's localized name
​https://bugs.webkit.org/show_bug.cgi?id=213003
<rdar://problem/64169000>

Reviewed by Sam Weinig.

Source/WebCore/PAL:

• pal/spi/cocoa/LaunchServicesSPI.h:

Source/WebKit:

• UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant _appendAppLinkOpenActionsForURL:actions:elementInfo:]):

7:04 PM Changeset in webkit [262831] by timothy_horton@apple.com

• 3 edits
  1 add in trunk/Source/WTF

Use os_log instead of asl_log
​https://bugs.webkit.org/show_bug.cgi?id=213001

Reviewed by Saam Barati.

• WTF.xcodeproj/project.pbxproj:
• wtf/Assertions.cpp:

7:04 PM Changeset in webkit [262830] by mark.lam@apple.com

• 3 edits
  1 add in trunk

Stringifier::appendStringifiedValue() should not assume it is always safe to recurse.
​https://bugs.webkit.org/show_bug.cgi?id=213006
<rdar://problem/64154840>

Reviewed by Keith Miller.

JSTests:

• stress/json-stringify-executing-in-reserved-zone.js: Added.

Source/JavaScriptCore:

In r262727, I suggested that Alexey Shvayka add an assertion in
Stringifier::appendStringifiedValue() to assert that it is safe to recurse because
we don't expect it to recurse into itself. Turns out this is a bad idea because
a client may be doing the recursing before calling Stringifier::appendStringifiedValue().
As a result, Stringifier::appendStringifiedValue() ends up being executed with
the stack pointer already in the reserved zone. This is legal, and is what the
reserved zone is intended for as long as we don't recurse from here. However,
this also means that asserting vm.isSafeToRecurseSoft() here will surely fail
because we are already in the reserved zone area. The fix is simply to remove
this faulty assertion.

• runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):

6:57 PM Changeset in webkit [262829] by Russell Epstein

• 8 edits in branches/safari-610.1.15.50-branch/Source

Versioning.

6:44 PM Changeset in webkit [262828] by jfernandez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=212997

Unreviewed test gardening

• platform/gtk/TestExpectations:

5:21 PM Changeset in webkit [262827] by mark.lam@apple.com

• 64 edits
  1 add in trunk

Disambiguate the OverridesGetPropertyNames structure flag
​https://bugs.webkit.org/show_bug.cgi?id=212909
<rdar://problem/63823557>

Reviewed by Saam Barati.

JSTests:

• stress/unexpected-stack-overflow-below-JSObject-getPropertyNames.js: Added.

Source/JavaScriptCore:

Previously, the OverridesGetPropertyNames structure flag could mean 2 different
things:

1. the getPropertyNames() method is overridden, or
2. any of the forms of getPropertyName() is overridden: getPropertyName, getOwnPropertyNames, getOwnNonIndexPropertyNames

Some parts of the code expects one definition while other parts expect the other.
This patch disambiguates between the 2 by introducing OverridesAnyFormOfGetPropertyNames
for definition (2). OverridesGetPropertyNames now only means definition (1).

Note: we could have implemented overridesGetPropertyNames() by doing a comparison
of the getPropertyNames pointer in the MethodTable. This is a little slower than
checking a TypeInfo flag, but probably doesn't matter a lot in the code paths
where overridesGetPropertyNames() is called. However, we have bits in TypeInfo
left. So, we'll might as well use it.

This ambiguity resulted in JSObject::getPropertyNames() recursing infinitely
when it didn't think it could recurse. This is demonstrated in
JSTests/stress/unexpected-stack-overflow-below-JSObject-getPropertyNames.js as
follows:

1. The test case invokes JSObject::getPropertyNames on a JSArray.

2. In the while loop at the bottom of JSObject::getPropertynames(), we check if (prototype->structure(vm)->typeInfo().overridesGetPropertyNames()) {.

3. The test overrides proto as follows: arg0.__proto__ = arr1 where both arg0 and arr1 are JArrays.

4. In the old code, JSArray sets OverridesGetPropertyNames but does not override getPropertyNames(). It actually meant to set OverridesAnyFormOfGetPropertyNames (after we disambiguated it) because JSArray overrides getOwnNonIndexPropertyNames().

5. When we get to the check at (2), we ask if the prototype overridesGetPropertyNames(). Since JSArray sets OverridesGetPropertyNames, the answer is yes / true.

JSObject::getPropertynames() then proceeds to invoke
prototype->methodTable(vm)->getPropertyNames(prototype, globalObject, propertyNames, mode);

But because JSArray does not actually overrides getPropertyNames(), we're
actually invoking JSObject::getPropertyNames() here. Viola! Infinite loop.

With this patch, JSArray is disambiguated to set OverridesAnyFormOfGetPropertyNames
instead of OverridesGetPropertyNames, and this infinite loop no longer exists.

This patch also made the following changes:

1. Templatized TypeInfo::isSetOnFlags1() and TypeInfo::isSetOnFlags2() so that we can used static_asserts instead of a debug ASSERT to verify the integrity of the flag we're checking against.

2. Added a Structure::validateFlags() called from the Structure constructor. validateFlags() will verify the following:
   1. OverridesGetOwnPropertySlot must be set in the flags if getOwnPropertySlot is overridden in the MethodTable.
   2. InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero must be set in the flags if getOwnPropertySlotByIndex is overridden in the MethodTable.
   3. HasPutPropertySecurityCheck must be set in the flags if doPutPropertySecurityCheck is overridden in the MethodTable.
   4. OverridesGetPropertyNames must be set in the flags if getPropertyNames is overridden in the MethodTable.
   5. OverridesAnyFormOfGetPropertyNames must be set in the flags if any of getPropertyNames, getOwnPropertyNames, or getOwnNonIndexPropertyNames are overridden in the MethodTable.

An alternate solution would be to automatically set these flags if we detect
their corresponding methods are overridden. However, this alternate solution
requires this laundry list to be checked every time a structure is constructed.
The current implementation of having the required flags already pre-determined
as a constant is more efficient in terms of performance and code space.

Also, it only takes one instantiation of the structure to verify that the flags
are valid. Since we only write JSCell / JSObject classes when we need them
and we always write tests to exercise new code (especially such classes), we're
guaranteed the flags validation will be exercised.

3. Made JSObject::getOwnPropertySlot() and JSObject::doPutPropertySecurityCheck() not inlined when ASSERT_ENABLED. This is needed in order for Structure::validateFlags() to do its checks using function pointer comparisons. Otherwise, the inline functions can result in multiple instantiations of these functions. For example, WebCore can get its own copy of JSObject::getOwnPropertySlot() and the comparisons will think the function is overridden even when it's not.

4. Structure::validateFlags() found the following problems which are now fixed:

GetterSetter was not using its StructureFlags. As a result, it was missing the
OverridesGetOwnPropertySlot flag.

JSDataView did not define its StructureFlags. It was missing the
OverridesGetOwnPropertySlot and OverridesAnyFormOfGetPropertyNames flags.

5. Changed a TypeInfo constructor to not have a default argument for the flags value. Also grepped for all uses of this constructor to make sure that it is passed the StructureFlags field. This exercise found the following issue:

JSAPIValueWrapper was not using its StructureFlags when creating its structure.
Previously, it was just ignoring the StructureIsImmortal flag in StructureFlags.

6. Hardened the assertions for hasReadOnlyOrGetterSetterPropertiesExcludingProto() and hasGetterSetterProperties() in the Structure constructor.

Previously, if the flag is set, it verifies that the ClassInfo has the
appropriate data expected by the flag. However, it does not assert the reverse
i.e. that if the ClassInfo data exists, then the flag must also be set.
The new assertions now checks both.

Moved the overridesGetCallData() assertion into Structure::validateFlags()
because it concerns the OverridesGetCallData flag. This assertion has also
ben hardened.

• API/JSAPIValueWrapper.h:
• API/JSCallbackObject.h:
• debugger/DebuggerScope.h:
• inspector/JSInjectedScriptHostPrototype.h:
• inspector/JSJavaScriptCallFramePrototype.h:
• runtime/ClonedArguments.h:
• runtime/ErrorInstance.h:
• runtime/GenericArguments.h:
• runtime/GetterSetter.h:
• runtime/JSArray.h:
• runtime/JSDataView.h:
• runtime/JSFunction.h:
• runtime/JSGenericTypedArrayView.h:
• runtime/JSGlobalObject.h:
• runtime/JSLexicalEnvironment.h:
• runtime/JSModuleEnvironment.h:
• runtime/JSModuleNamespaceObject.h:
• runtime/JSObject.cpp:

(JSC::JSObject::doPutPropertySecurityCheck):
(JSC::JSObject::getOwnPropertySlot):

• runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlotImpl):
(JSC::JSObject::getOwnPropertySlot):

• runtime/JSProxy.h:
• runtime/JSString.h:
• runtime/JSSymbolTableObject.h:
• runtime/JSTypeInfo.h:

(JSC::TypeInfo::TypeInfo):
(JSC::TypeInfo::masqueradesAsUndefined const):
(JSC::TypeInfo::implementsHasInstance const):
(JSC::TypeInfo::implementsDefaultHasInstance const):
(JSC::TypeInfo::overridesGetCallData const):
(JSC::TypeInfo::overridesToThis const):
(JSC::TypeInfo::structureIsImmortal const):
(JSC::TypeInfo::overridesGetPropertyNames const):
(JSC::TypeInfo::overridesAnyFormOfGetPropertyNames const):
(JSC::TypeInfo::prohibitsPropertyCaching const):
(JSC::TypeInfo::getOwnPropertySlotIsImpure const):
(JSC::TypeInfo::getOwnPropertySlotIsImpureForPropertyAbsence const):
(JSC::TypeInfo::hasPutPropertySecurityCheck const):
(JSC::TypeInfo::newImpurePropertyFiresWatchpoints const):
(JSC::TypeInfo::isImmutablePrototypeExoticObject const):
(JSC::TypeInfo::interceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero const):
(JSC::TypeInfo::isSetOnFlags1 const):
(JSC::TypeInfo::isSetOnFlags2 const):

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorAssign):

• runtime/ProxyObject.h:
• runtime/RegExpObject.h:
• runtime/StringObject.h:
• runtime/Structure.cpp:

(JSC::Structure::validateFlags):
(JSC::Structure::Structure):

• runtime/Structure.h:
• runtime/StructureInlines.h:

(JSC::Structure::canCacheOwnKeys const):

• tools/JSDollarVM.cpp:

Source/WebCore:

1. JSDOMWindowProperties was not defining its Base. As a result, its StructureFlags was inheriting from JSDOMObject's Base instead of from JSDOMObject as one would expect. This turns out to be harmless because JSDOMObject did not define any StructureFlags. Regardless, this is not fixed so that if JSDOMObject adds any StructureFlags, it will be inherited properly by JSDOMWindowProperties.

2. Updated CodeGeneratorJS.pm and rebased the binding test results.

• bindings/js/JSDOMWindowProperties.h:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

• bindings/scripts/test/JS/JSTestEventTarget.h:
• bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h:
• bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h:
• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h:
• bindings/scripts/test/JS/JSTestNamedGetterCallWith.h:
• bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h:
• bindings/scripts/test/JS/JSTestObj.h:
• bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
• bridge/runtime_array.h:
• bridge/runtime_object.h:

Source/WebKit:

• WebProcess/Plugins/Netscape/JSNPObject.h:

5:05 PM Changeset in webkit [262826] by dino@apple.com

• 9 edits
  6 moves in trunk/Source

Stop using discriminatory names for WebGL and Plugin blocking
​https://bugs.webkit.org/show_bug.cgi?id=213000

Reviewed by Simon Fraser.

Source/WebCore:

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/mac/BlocklistUpdater.h: Renamed from Source/WebCore/platform/mac/BlacklistUpdater.h.

(WebCore::BlocklistUpdater::pluginBlocklist):
(WebCore::BlocklistUpdater::webGLBlocklist):

• platform/mac/BlocklistUpdater.mm: Renamed from Source/WebCore/platform/mac/BlacklistUpdater.mm.

(WebCore::BlocklistUpdater::readBlocklistData):
(WebCore::BlocklistUpdater::reloadIfNecessary):
(WebCore::BlocklistUpdater::initializeQueue):

• platform/mac/PluginBlocklist.h: Renamed from Source/WebCore/platform/mac/PluginBlacklist.h.
• platform/mac/PluginBlocklist.mm: Renamed from Source/WebCore/platform/mac/PluginBlacklist.mm.

(WebCore::PluginBlocklist::loadPolicyForPluginVersion):
(WebCore::PluginBlocklist::isPluginUpdateAvailable):
(WebCore::PluginBlocklist::create):
(WebCore::PluginBlocklist::~PluginBlocklist):
(WebCore::PluginBlocklist::splitOSVersion):
(WebCore::PluginBlocklist::loadPolicyForPlugin const):
(WebCore::PluginBlocklist::isUpdateAvailable const):
(WebCore::PluginBlocklist::PluginBlocklist):

• platform/mac/WebGLBlocklist.h: Renamed from Source/WebCore/platform/mac/WebGLBlacklist.h.
• platform/mac/WebGLBlocklist.mm: Renamed from Source/WebCore/platform/mac/WebGLBlacklist.mm.

(WebCore::buildInfoFromOSBuildString):
(WebCore::WebGLBlocklist::shouldBlockWebGL):
(WebCore::WebGLBlocklist::shouldSuggestBlockingWebGL):
(WebCore::matchesBuildInfo):
(WebCore::WebGLBlocklist::create):
(WebCore::WebGLBlocklist::shouldBlock const):
(WebCore::WebGLBlocklist::shouldSuggestBlocking const):
(WebCore::WebGLBlocklist::WebGLBlocklist):
(WebCore::WebGLBlocklist::~WebGLBlocklist):

Source/WebKit:

• Shared/Plugins/Netscape/mac/PluginInformationMac.mm:

(WebKit::getPlatformPluginModuleInformation):

• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextIsPlugInUpdateAvailable):
(WKContextShouldBlockWebGL):
(WKContextShouldSuggestBlockWebGL):

• UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebFrameLoaderClient.mm:

(shouldBlockPlugin):
(shouldBlockWebGL):

4:32 PM Changeset in webkit [262825] by Simon Fraser

• 3 edits in trunk/Source/WebCore

Logging and tree dumping crash fix
​https://bugs.webkit.org/show_bug.cgi?id=212988

Reviewed by Zalan Bujtas.

Add scrolling logging to RenderLayer::requestScrollPositionUpdate().

Null-check the scrollerImp in ScrollbarThemeMac::isLayoutDirectionRTL, because this is
called from renderTreeAsText() which can be invoked from the debugger, and should not crash.

• platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::isLayoutDirectionRTL):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::requestScrollPositionUpdate):

4:27 PM Changeset in webkit [262824] by aestes@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed change for post-commit feedback after r262682.

• DerivedSources.make: Replaced tabs with spaces.

4:16 PM Changeset in webkit [262823] by Russell Epstein

• 1 copy in tags/Safari-610.1.15.50.2

Tag Safari-610.1.15.50.2.

4:11 PM Changeset in webkit [262822] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Gardening, update results of flaky timeout failures
​https://bugs.webkit.org/show_bug.cgi?id=212993

Unreviewed gardening.

For those flaky timeout failures, update expected results to the actual results obtained in the
last 4000 revisions for each test.

• platform/gtk/TestExpectations:

4:10 PM Changeset in webkit [262821] by Russell Epstein

• 8 edits in branches/safari-610.1.15.50-branch/Source

Versioning.

3:36 PM Changeset in webkit [262820] by Alan Coon

• 1 copy in tags/Safari-610.1.16.3

Tag Safari-610.1.16.3.

3:33 PM Changeset in webkit [262819] by Alan Coon

• 2 edits in branches/safari-610.1.16-branch/Source/WebCore

Cherry-pick r262687. rdar://problem/64044841

REGRESSION (r262364): Disney Plus crashes playing videos
​https://bugs.webkit.org/show_bug.cgi?id=212862
<rdar://problem/64044841>

Reviewed by Eric Carlson.

In r262364, we specified an incorrect number size for CFNumberGetValue, which nevertheless
worked fine in debug builds, but overwrote stack data in release builds, leading to a crash when
the returned pointer was ref()d. The correct size for a FourCharCode is a
kCFNumberSInt32Type, not a kCFNumberLongType.

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:31 PM Changeset in webkit [262818] by Alan Coon

• 8 edits in branches/safari-610.1.16-branch/Source

Versioning.

3:26 PM Changeset in webkit [262817] by Russell Epstein

• 1 copy in tags/Safari-610.1.15.52.1

Tag Safari-610.1.15.52.1.

3:25 PM Changeset in webkit [262816] by Russell Epstein

• 1 copy in tags/Safari-610.1.15.50.1

Tag Safari-610.1.15.50.1.

3:06 PM Changeset in webkit [262815] by BJ Burg

• 2 edits in trunk/Source/WebKit

[Cocoa] Element Send Keys can hang when an automation window becomes unfocused
​https://bugs.webkit.org/show_bug.cgi?id=212985
<rdar://problem/56354471>

Reviewed by Devin Rousso.

• UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::sendSynthesizedEventsToPage):
Make sure to focus the window and set first responder so sending keys doesn't hang.

3:04 PM Changeset in webkit [262814] by Chris Dumez

• 2 edits in trunk/Source/WTF

Use bridge cast in String(NSString *) constructor
​https://bugs.webkit.org/show_bug.cgi?id=212989

Reviewed by Darin Adler.

Use bridge cast in String(NSString *) constructor instead of a reinterpret_cast as this
is the preferred way of converting a NS Type to a CF one.

• wtf/text/cocoa/StringCocoa.mm:

(WTF::String::String):

2:47 PM Changeset in webkit [262813] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

WebKit Crashes when SVG Filter Logging is Turned On
​https://bugs.webkit.org/show_bug.cgi?id=212415

Patch by Frank Yang <​guowei_yang@apple.com> on 2020-06-09
Reviewed by Darin Adler.

No new tests are required because this is just
fixing a simple pointer access inside logging code

• html/ImageData.cpp:

(WebCore::operator<<): Overloaded << operator to print the

address of pixel data it stores

• html/ImageData.h: Declare overloaded << operator
• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::imageBufferResult): Modified logging code

so that it does a null check by calling ValueOrNull on
m_premultipliedImageResult and m_unmultipliedImageResult

(WebCore::FilterEffect::copyUnmultipliedResult): Modified logging code

so that it does a null check by calling ValueOrNull on
m_premultipliedImageResult and m_unmultipliedImageResult

(WebCore::FilterEffect::copyPremultipliedResult): Modified logging code

so that it does a null check by calling ValueOrNull on
m_premultipliedImageResult and m_unmultipliedImageResult

2:43 PM Changeset in webkit [262812] by Jonathan Bedard

• 2 edits in trunk/Source/WebKit

WebKit: Import NSURLConnectionSPI.h instead of CFNSURLConnection.h
​https://bugs.webkit.org/show_bug.cgi?id=212980
<rdar://problem/64172694>

Unreviewed build fix.

No new tests, behavior unchanged.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

2:19 PM Changeset in webkit [262811] by dino@apple.com

• 6 edits in trunk/Source

REGRESSION: [Safari Mojave for High Sierra] Accessing some of the featured pages on apple.com causes the webpage to crash
​https://bugs.webkit.org/show_bug.cgi?id=212940
Source/WebCore:

rdar://63839405

Reviewed by Tim Horton.

The code to use the singleton for a SwitchingGPUClient was assuming it
has always been set, which was not the case when
ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) was not true.

• platform/graphics/opengl/GraphicsContextGLOpenGLManager.cpp: Check the state of the

singleton before calling it.
(WebCore::GraphicsContextGLOpenGLManager::updateHighPerformanceState):
(WebCore::GraphicsContextGLOpenGLManager::disableHighPerformanceGPUTimerFired):

• platform/graphics/mac/SwitchingGPUClient.h: Return a pointer to the singleton which

will allow the code to check for its existence.
(WebCore::SwitchingGPUClient::singletonIfExists):

Source/WebKit:

Reviewed by Tim Horton.

The code to use the singleton for a SwitchingGPUClient was assuming it
has always been set, which was not the case when
ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) was not true.

• WebProcess/cocoa/WebProcessCocoa.mm: Set the singleton unconditionally.

(WebKit::WebProcess::platformInitializeProcess):

2:05 PM Changeset in webkit [262810] by weinig@apple.com

• 7 edits in trunk/Source/WebCore

Extended Color: Streamline SimpleColor premulitply/unpremultiply code
​https://bugs.webkit.org/show_bug.cgi?id=212945

Reviewed by Darin Adler.

Simplify / streamline the premulitply/unpremultiply code by:

• Removing the overloads that didn't take individual components, keeping only the ones taking a SimpleColor.
• Replacing the "ceiling" bool in makePremultipliedSimpleColor and converting it into two functions.
• Simplifying the names from makePremultipliedSimpleColor/makeUnpremultipliedSimpleColor to premultiplyFlooring/premultiplyCeiling/unpremultiply.
• Where component order is important, use valueAsARGB() explicitly to show what the resulting value's format will be.

• platform/graphics/Color.cpp:

(WebCore::blend):
Update to call premultiplyCeiling/unpremultiply.

• platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::blendPixel):
(WebCore::ImageBackingStore::pixelValue const):
Update to call premultiplyFlooring/unpremultiply and valueAsARGB().

• platform/graphics/SimpleColor.h:
• platform/graphics/SimpleColor.cpp:

(WebCore::premultiplyFlooring):
(WebCore::premultiplyCeiling):
(WebCore::unpremultiplyChannel):
(WebCore::unpremultiply):
(WebCore::premultipliedChannel): Deleted.
(WebCore::unpremultipliedChannel): Deleted.
(WebCore::makePremultipliedSimpleColor): Deleted.
(WebCore::makeUnpremultipliedSimpleColor): Deleted.
Simplify premulitply/unpremultiply interfaces. Use structured bindings to make
the code a bit easier to follow as well.

• platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp:

(WebCore::ImageBufferCairoImageSurfaceBackend::platformTransformColorSpace):
Update to call premultiplyFlooring/unpremultiply and valueAsARGB().

• platform/graphics/cairo/NativeImageCairo.cpp:

(WebCore::nativeImageSinglePixelSolidColor):
Update to call premultiplyFlooring/unpremultiply and valueAsARGB(). Also removes
reinterpret cast to SimpleColor, instead following the model in ImageBufferCairoImageSurfaceBackend
and casting to unsigned, and building the SimpleColor from that. This will allow
SimpleColor to change its underlying representation in the future without breaking things.

2:04 PM Changeset in webkit [262809] by commit-queue@webkit.org

• 18 edits
  50 deletes in trunk

Unreviewed, reverting r261841.
​https://bugs.webkit.org/show_bug.cgi?id=212991

Caused spotify pages to scroll to the top
(<​http://webkit.org/b/212983|webkit.org/b/212983>)

Reverted changeset:

"[css-grid] Clear the override width for computing percent
margins"
​https://bugs.webkit.org/show_bug.cgi?id=209461
​https://trac.webkit.org/changeset/261841

1:59 PM Changeset in webkit [262808] by Jonathan Bedard

• 3 edits in trunk/Source/JavaScriptCore

JavaScriptCore: Support tvOS and watchOS builds with the public SDK
​https://bugs.webkit.org/show_bug.cgi?id=212788
<rdar://problem/64000087>

Reviewed by Tim Horton.

• Configurations/Base.xcconfig: Link to tvOS and watchOS framework stubs.
• Configurations/JavaScriptCore.xcconfig: Use iOS flags for all embedded platforms.

1:52 PM Changeset in webkit [262807] by zhifei_fang@apple.com

• 2 edits in trunk/Tools

Add a timeout monitor for JSC stress test
​https://bugs.webkit.org/show_bug.cgi?id=211978

Reviewed by Jonathan Bedard.

• Scripts/webkitruby/jsc-stress-test-writer-default.rb: Add timeout monitor inside the jsc stress test runner, it will kill the process in case of jsc timeout handler not working

1:44 PM Changeset in webkit [262806] by Devin Rousso

• 20 edits in trunk

Web Inspector: allow multiple resources for a given URL
​https://bugs.webkit.org/show_bug.cgi?id=212852

Reviewed by Brian Burg.

Source/WebInspectorUI:

Previously, when a new resource is added with a URL that matches an existing resource, any
resourceForURL call with that URL will return the new resource instead of the old one. Now
that there is a Multimap of URL to resource, it is possible to pick which resource is used
instead of always using the newest one.

• UserInterface/Models/ResourceCollection.js:

(WI.ResourceCollection):
(WI.ResourceCollection.prototype.resourcesForURL): Added.
(WI.ResourceCollection.prototype._associateWithResource):
(WI.ResourceCollection.prototype._disassociateWithResource):
(WI.ResourceCollection.prototype._resourceURLDidChange):
(WI.ResourceCollection.prototype.resourceForURL): Deleted.

• UserInterface/Models/Frame.js:

(WI.Frame.prototype.resourcesForURL): Added.
(WI.Frame.prototype.resourceForURL): Deleted.

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.resourcesForURL): Added.
(WI.NetworkManager.prototype.resourceRequestDidReceiveResponse):
(WI.NetworkManager.prototype._initiatorSourceCodeLocationFromPayload):
(WI.NetworkManager.prototype.resourceForURL): Deleted.

• UserInterface/Models/Script.js:

(WI.Script.prototype._resolveResource):
(WI.Script.prototype._resolveResource.isScriptResource): Added.

• UserInterface/Controllers/CSSManager.js:

(WI.CSSManager.prototype._updateResourceContent.fetchedStyleSheetContent):

• UserInterface/Base/Utilities.js:

(Set.prototype.find): Added.
Add utility for finding an item in a Set to avoid having to Array.from.

• UserInterface/Base/Main.js:

(WI.openURL):
(WI.sourceCodeForURL):

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._processRecord):

• UserInterface/Models/CallFrame.js:

(WI.CallFrame.fromPayload):

• UserInterface/Models/ConsoleMessage.js:

(WI.ConsoleMessage.prototype.get sourceCodeLocation):

• UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles.prototype.createSourceCodeLocation):

• UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeFromPayload):

• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForURL):

• UserInterface/Views/DOMDetailsSidebarPanel.js:

(WI.DOMDetailsSidebarPanel.prototype._mouseWasClicked):

• UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype.performSearch):
Use the firstValue instead of the implicit lastValue to match existing nearby usage of
WI.DebuggerManager.prototype.scriptsForURL, which explicitly chooses the first script.

LayoutTests:

• inspector/unit-tests/set-utilities.html:
• inspector/unit-tests/set-utilities-expected.txt:

Add test for Set.prototype.find.

• http/tests/websocket/tests/hybi/inspector/resolveWebSocket.html:

Update usage of resourceForURL to resourcesForURL with Set.prototype.firstValue.

12:57 PM Changeset in webkit [262805] by pvollan@apple.com

• 2 edits in trunk/Source/WTF

All platforms should enable CFPrefs read only mode in the WebContent process
​https://bugs.webkit.org/show_bug.cgi?id=212910

Reviewed by Tim Horton.

In ​https://bugs.webkit.org/show_bug.cgi?id=212411, CFPrefs read only mode was adopted, but not all platforms were included.

• wtf/PlatformHave.h:

12:53 PM Changeset in webkit [262804] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

[Win] ComplexTextControllerUniscribe: Retry ScriptShape with SCRIPT_UNDEFINED if it failed as USP_E_SCRIPT_NOT_IN_FONT
​https://bugs.webkit.org/show_bug.cgi?id=212947

Reviewed by Don Olmstead.

If the given font doesn't support the givin text, ScriptShape API
fails as USP_E_SCRIPT_NOT_IN_FONT. In the case, the complex run
was simply ignored and nothing was drawn for the text.

According to Uniscribe document, We should retry ScriptShape with
SCRIPT_UNDEFINED to get missing glyphs.
<​https://docs.microsoft.com/en-us/windows/win32/intl/displaying-text-with-uniscribe>

• platform/graphics/win/ComplexTextControllerUniscribe.cpp:

(WebCore::shapeByUniscribe):

12:39 PM Changeset in webkit [262803] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

ComplexTextController: Use std::sort to calculate m_runIndices
​https://bugs.webkit.org/show_bug.cgi?id=212944

Reviewed by Myles C. Maxfield.

ComplexTextController was using O(n²) sort to lazily calculate
m_runIndices. And, exact matching stringBegin and stringEnd can
cause infinite loop (Bug 212670 and Bug 108877).

Use std::sort instead.

• platform/graphics/ComplexTextController.cpp:

(WebCore::ComplexTextController::finishConstruction):
(WebCore::ComplexTextController::indexOfCurrentRun):

12:08 PM Changeset in webkit [262802] by Wenson Hsieh

• 5 edits in trunk/Source

REGRESSION (r260820): [macCatalyst] Web process crashes when uploading a file
​https://bugs.webkit.org/show_bug.cgi?id=212976
<rdar://problem/64033186>

Reviewed by Tim Horton.

Source/WebKit:

On Mac Catalyst, we attempt to take a sandbox extension for com.apple.frontboard.systemappservices when
uploading a file; this service does not exist in Catalyst, and we consequently encounter a release assertion
under WebPage::didChooseFilesForOpenPanelWithDisplayStringAndIcon.

Fix this by introducing HAVE(FRONTBOARD_SYSTEM_APP_SERVICES), and using it to guard codepaths that attempt to
grab a mach extension to this service. (As a followup, we should consider adopting this in other places that
currently reference com.apple.frontboard.systemappservices).

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChooseFilesForOpenPanelWithDisplayStringAndIcon):

Source/WTF:

Add HAVE(FRONTBOARD_SYSTEM_APP_SERVICES).

• wtf/PlatformHave.h:

11:53 AM Changeset in webkit [262801] by Jonathan Bedard

• 7 edits in trunk/Source/WebKit

WebKit: Support watchOS and tvOS in xcconfigs
​https://bugs.webkit.org/show_bug.cgi?id=212977
<rdar://problem/64170532>

Reviewed by Tim Horton.

No new tests, behavior unchanged.

• Configurations/Base.xcconfig: Add tvOS and watchOS major version macros.
• Configurations/BaseTarget.xcconfig: Include tvOS and watchOS framework stubs.
• Configurations/BaseXPCService.xcconfig: Generalize excluded files for all embedded platforms.
• Configurations/GPUService.xcconfig: Generalize INFOPLIST for embedded platforms.
• Configurations/NetworkService.xcconfig: Ditto.
• Configurations/WebContentService.xcconfig: Ditto.

11:46 AM Changeset in webkit [262800] by timothy_horton@apple.com

• 5 edits in trunk/Tools

WebKit.ShrinkToFit is failing on some bots
​https://bugs.webkit.org/show_bug.cgi?id=212932
<rdar://problem/60972407>

Reviewed by Simon Fraser.

TestWebKitAPI was failing to stabilize the overlay scrollbar preference,
because the only stabilization attempt was in the injected bundle
initialization code, and most tests (including ShrinkToFit) do not have
an injected bundle.

Because this preference is manually propagated to the Web Content process,
we can set the default in the volatile domain in the UI process at startup.

We can't move other preferences yet, because they are not manually propagated,
and WebKit's NSUserDefault synchronization mechanism ignores defaults in the
volatile domain (and the initial preference load reads from disk, not
from the UI process, so it wouldn't find them anyway).

• TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:

(TEST):
Explain why the final value of the test is different than the starting value.

• TestWebKitAPI/mac/InjectedBundleControllerMac.mm:

(TestWebKitAPI::InjectedBundleController::platformInitialize):
Leave a FIXME for future generations.

• TestWebKitAPI/mac/mainMac.mm:

(main):
Override overlay scrollbar preferences in the UI process, so it affects all tests.

• TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:

This test is also affected by using non-overlay scrollbars; we now have less space, so take up more pages.

11:38 AM Changeset in webkit [262799] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit

Expose PDF file URL in shouldAllowPDFToOpenFromFrame SPI
​https://bugs.webkit.org/show_bug.cgi?id=212974

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-06-09
Reviewed by Tim Horton.

• UIProcess/API/APIUIClient.h:

(API::UIClient::confirmPDFOpening):

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::confirmPDFOpening):

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication):
(WebKit::WebPageProxy::openPDFFromTemporaryFolderWithNativeApplication):

11:16 AM Changeset in webkit [262798] by youenn@apple.com

• 14 edits in trunk

BaseAudioSharedUnit should unmute its clients in case of suspension even if not having any audio unit
​https://bugs.webkit.org/show_bug.cgi?id=212970

Reviewed by Eric Carlson.

Source/WebCore:

CoreAudioCaptureSource(s), when muted, are now calling stopProducingData.
This will, in turn, make the BaseAudioSharedUnit stop and no longer have any audio unit.
In that case, when resume is called on the BaseAudioSharedUnit, it will exit early as the audio unit is null.
This will prevent to unmute the CoreAudioCaptureSource(s).

Fix this by removing the audio unit check in BaseAudioSharedUnit::resume.
Add infrastructure testing to be able to write a test.

Covered by added test.

• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/mac/BaseAudioSharedUnit.cpp:

(WebCore::BaseAudioSharedUnit::resume):

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::setInterruptedForTesting):

• platform/mediastream/mac/CoreAudioCaptureSource.h:
• testing/Internals.cpp:

(WebCore::Internals::isMediaStreamSourceInterrupted const):

• testing/Internals.h:
• testing/Internals.idl:

Tools:

Add an option to capture in UI process so that the same test can run on both MacOS and iOS.
This eases the testing infra to be able to get audio capture unit state in WebProcess as is the case in iOS.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

• fast/mediastream/media-stream-track-interrupted-expected.txt:
• fast/mediastream/media-stream-track-interrupted.html:

11:15 AM Changeset in webkit [262797] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Gardening, remove flaky timeout failures after r262789
​https://bugs.webkit.org/show_bug.cgi?id=212979

Unreviewed gardening.

Removed flaky timeout failures that have been constantly passing in the last 4000 revisions.

• platform/gtk/TestExpectations:

10:15 AM Changeset in webkit [262796] by mmaxfield@apple.com

• 26 edits
  2 adds in trunk

lang=zh needs to defer to system preferences to know whether it should be simplified or traditional
​https://bugs.webkit.org/show_bug.cgi?id=212626
<rdar://problem/60227623>

Reviewed by Darin Adler.

Source/WebCore:

If the content says lang="zh" font-family: sans-serif, we have no signal for whether
the content should be traditional or simplified. In this case, we should pick based
on system preferences to make it more likely that we get the right answer.

This is actually what some Cocoa platform text functions were doing, but not all of them.
We need to do it at our level in WebKit to make sure that all our calls to the platform
have consistent behavior. Also, we can cache the result at our level, which is more
performant than if the platform cached it at each platform entry point.

We already started consulting with system preferences to make this decision in r189038.
This patch extends that and fixes it to throughout WebKit.

This doesn't expose any new fingerprinting data, because this information was already
exposed (e.g. by drawing fallback fonts to the canvas and then reading back the pixels).

Tests: fast/text/locale-getComputedStyle.html

fast/text/international/generic-font-family-language-traditional.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

• css/CSSFontSelector.cpp:

(WebCore::resolveGenericFamily):

• css/CSSProperties.json:
• layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::LineBreaker::wordBreakBehavior const):
(WebCore::Layout::LineBreaker::tryBreakingTextRun const):

• platform/graphics/Font.cpp:

(WebCore::Font::systemFallbackFontForCharacter const):

• platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::FontDescriptionKey):

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::widthForSimpleText const):

• platform/graphics/FontCascadeDescription.cpp:
• platform/graphics/FontCascadeDescription.h:

(WebCore::FontCascadeDescription::initialSpecifiedLocale):
(WebCore::FontCascadeDescription::initialLocale): Deleted.

• platform/graphics/FontDescription.cpp:

(WebCore::computeSpecializedChineseLocale):
(WebCore::cachedSpecializedChineseLocale):
(WebCore::fontDescriptionLanguageChanged):
(WebCore::specializedChineseLocale):
(WebCore::FontDescription::setSpecifiedLocale):
(WebCore::FontDescription::setLocale): Deleted.

• platform/graphics/FontDescription.h:

(WebCore::FontDescription::computedLocale const):
(WebCore::FontDescription::specifiedLocale const):
(WebCore::FontDescription::operator== const):
(WebCore::FontDescription::encode const):
(WebCore::FontDescription::decode):
(WebCore::FontDescription::locale const): Deleted.

• platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::applyFontTransforms):

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

• platform/graphics/cocoa/FontDescriptionCocoa.cpp:

(WebCore::FontDescription::platformResolveGenericFamily):
(WebCore::computeSpecializedChineseLocale): Deleted.
(WebCore::cachedSpecializedChineseLocale): Deleted.
(WebCore::languageChanged): Deleted.

• platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:

(WebCore::SystemFontDatabaseCoreText::systemFontParameters):

• platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::computeText const):

• rendering/RenderText.cpp:

(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::applyTextTransform):

• rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::paintApplePayButton):

• rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragmentIterator):

• rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleText):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::computedLocale const):
(WebCore::RenderStyle::specifiedLocale const):
(WebCore::RenderStyle::locale const): Deleted.

• style/StyleBuilderCustom.h:

(WebCore::Style::BuilderCustom::applyValueWebkitLocale):

• style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

LayoutTests:

Make sure the new locale isn't exposed.

• fast/text/locale-getComputedStyle-expected.txt: Added.
• fast/text/locale-getComputedStyle.html: Added.

8:59 AM Changeset in webkit [262795] by Alan Bujtas

• 5 edits
  2 adds in trunk

[LFC][TFC] Add support for empty table
​https://bugs.webkit.org/show_bug.cgi?id=212971

Reviewed by Antti Koivisto.

Source/WebCore:

No need to run formatting context layout when the table box has no descendant.

Test: fast/layoutformattingcontext/empty-table-box.html

• layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::layoutTableBox):
(WebCore::Layout::TableWrapperBlockFormattingContext::computeBorderAndPaddingForTableBox):
(WebCore::Layout::TableWrapperBlockFormattingContext::computeWidthAndMarginForTableBox):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::ensureTableGrid):

• layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::isEmpty const):

LayoutTests:

• fast/layoutformattingcontext/empty-table-box-expected.html: Added.
• fast/layoutformattingcontext/empty-table-box.html: Added.

8:45 AM Changeset in webkit [262794] by youenn@apple.com

• 3 edits in trunk/Source/WebCore

Forward declare MediaKeys/MediaKeySession in Internals.h
​https://bugs.webkit.org/show_bug.cgi?id=212965

Reviewed by Xabier Rodriguez-Calvar.

No change of behavior.

• testing/Internals.cpp:
• testing/Internals.h:

8:35 AM Changeset in webkit [262793] by youenn@apple.com

• 10 edits in trunk

Fix two MediaStream tests
​https://bugs.webkit.org/show_bug.cgi?id=208926
<rdar://problem/60329008>

Reviewed by Eric Carlson.

Source/WebCore:

Previously, the mock capture sample rate was the one of the mock audio shared unit, which is the sample rate of the audio session by default.
This sample rate may change according the bots.
For that reason, explicitly set the mock shared unit sample rate to the default sample rate of the device, just before creating the source.
MediaConstraints may still apply after this step.

Fix an issue where we would use the real core audio unit in CoreAudioCaptureSource constructor.
We now pass the unit override if any in constructor.

Covered by unflaked tests.

• platform/mediastream/mac/BaseAudioSharedUnit.cpp:

(WebCore::BaseAudioSharedUnit::BaseAudioSharedUnit):

• platform/mediastream/mac/BaseAudioSharedUnit.h:
• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::initializeCoreAudioCaptureSource):
(WebCore::CoreAudioSharedUnit::CoreAudioSharedUnit):
(WebCore::CoreAudioCaptureSource::create):
(WebCore::CoreAudioCaptureSource::createForTesting):
(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):

• platform/mediastream/mac/CoreAudioCaptureSource.h:
• platform/mediastream/mac/MockAudioSharedUnit.mm:

(WebCore::MockRealtimeAudioSource::create):
(WebCore::MockAudioSharedUnit::MockAudioSharedUnit):
Do not disable echo cancellation to mimick what the real unit is doing.

LayoutTests:

• fast/mediastream/MediaStreamTrack-getSettings-expected.txt:
• fast/mediastream/MediaStreamTrack-getSettings.html:
• platform/mac-wk2/TestExpectations:

Unskip tests.

8:17 AM Changeset in webkit [262792] by Alan Bujtas

• 6 edits
  2 adds in trunk

[LFC][Table][Floats] Multi-pass table layout needs clean floating state
​https://bugs.webkit.org/show_bug.cgi?id=212889

Reviewed by Antti Koivisto.

Source/WebCore:

When laying out the cell content multiple times to accommodate flex table layout,
the float state needs be cleared to avoid having redundant float content.

Test: fast/layoutformattingcontext/float-inside-table-cell-simple.html

• layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::append):

• layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::FloatItem::floatBox const):

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createLayoutBox):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutCell):

LayoutTests:

• fast/layoutformattingcontext/float-inside-table-cell-simple-expected.html: Added.
• fast/layoutformattingcontext/float-inside-table-cell-simple.html: Added.

7:50 AM Changeset in webkit [262791] by commit-queue@webkit.org

• 17 edits in trunk

[Curl] Implement functions to use ResourceLoadStatistics.
​https://bugs.webkit.org/show_bug.cgi?id=207692

Source/WebCore:

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2020-06-09
Reviewed by Don Olmstead.

Implement functions which are required to implement ResourceLoadStatistics for Curl port.

Tests: http/tests/resourceLoadStatistics/

• CMakeLists.txt:
• platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::openDatabase):
(WebCore::CookieJarDB::setCookie):
(WebCore::CookieJarDB::allDomains):
(WebCore::CookieJarDB::deleteCookiesForHostname):

• platform/network/curl/CookieJarDB.h:
• platform/network/curl/NetworkStorageSessionCurl.cpp:

(WebCore::NetworkStorageSession::setCookiesFromDOM const):
(WebCore::NetworkStorageSession::setCookies):
(WebCore::NetworkStorageSession::deleteCookiesForHostnames):
(WebCore::NetworkStorageSession::getHostnamesWithCookies):

Source/WebKit:

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2020-06-09
Reviewed by Don Olmstead.

Implement functions which are required to implement ResourceLoadStatistics for Curl port.

In NetworkDataTaskCurl.cpp we check if we should block cookies and block if needed.

Tests: http/tests/resourceLoadStatistics/

• NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::create):

• NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::NetworkDataTaskCurl):
(WebKit::NetworkDataTaskCurl::createCurlRequest):
(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection):
(WebKit::NetworkDataTaskCurl::blockCookies):
(WebKit::NetworkDataTaskCurl::unblockCookies):
(WebKit::NetworkDataTaskCurl::shouldBlockCookies):
(WebKit::NetworkDataTaskCurl::isThirdPartyRequest):

• NetworkProcess/curl/NetworkDataTaskCurl.h:
• NetworkProcess/curl/NetworkSessionCurl.cpp:

(WebKit::NetworkSessionCurl::NetworkSessionCurl):

• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreGetAllStorageAccessEntries):

• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::parameters):

Tools:

Implement functions which are required to implement ResourceLoadStatistics for Curl port.

Tests: http/tests/resourceLoadStatistics/

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2020-06-09
Reviewed by Don Olmstead.

• WebKitTestRunner/TestController.cpp:

(WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext):
(WTR::getAllStorageAccessEntriesCallback):
(WTR::TestController::getAllStorageAccessEntries):

LayoutTests:

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2020-06-09
Reviewed by Don Olmstead.

Implement functions which are required to implement ResourceLoadStatistics for Curl port.

Tests: http/tests/resourceLoadStatistics/

• platform/wincairo/TestExpectations:

7:13 AM Changeset in webkit [262790] by weinig@apple.com

• 5 edits in trunk/Source/WebCore

Extended Color: Switch ColorMac.mm's nsColor() function over to using TinyLRUCache
​https://bugs.webkit.org/show_bug.cgi?id=212918

Reviewed by Darin Adler.

• platform/graphics/Color.h:

(WebCore::Color::isExtended const):
Make asSimple() public, so nsColor() can use it. This also allows us to unfriend cachedCGColor().

• platform/graphics/mac/ColorMac.mm:

(WTF::RetainPtr<NSColor>>::createValueForKey):
(WebCore::nsColor):
Mimic the structure of cachedCGColor() by switching over simpleColor values for common
colors and using a 32 value TinyLRUCache for the rest.

5:57 AM Changeset in webkit [262789] by Antti Koivisto

• 3 edits in trunk/LayoutTests

scrollingcoordinator/ios/scroll-position-after-reattach.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=212967
<rdar://problem/52961406>

Reviewed by Antoine Quint.

• platform/ios-wk2/TestExpectations:
• scrollingcoordinator/ios/scroll-position-after-reattach.html:

Ensure the element is re-added before test finishes.

5:11 AM Changeset in webkit [262788] by jfernandez@igalia.com

• 5 edits
  12 adds in trunk/LayoutTests

[css-grid] Import some grid tests from WPT
​https://bugs.webkit.org/show_bug.cgi?id=212920

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Imported some grid related tests from WPT to check how baseline
alignment affects the grid's intrinsic size computation.

• resources/import-expectations.json:
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-001-expected.txt: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-001.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-002-expected.txt: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-002.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-003-expected.txt: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-003.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-004-expected.txt: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-004.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-005-expected.txt: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-005.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-006-expected.txt: Added.
• web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-006.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:

LayoutTests:

The imported tests fail only for WebKitGtk+ platform.

• platform/gtk/TestExpectations: Added Failure entries,

4:54 AM Changeset in webkit [262787] by Diego Pino Garcia

• 4 edits in trunk/LayoutTests

[GLIB] Gardening, clean up failures filed under bug 186638
​https://bugs.webkit.org/show_bug.cgi?id=212968

Unreviewed gardening.

Most of the the failures were flaky but many tests have been
consistently passing, so they were removed from expectations. Adjust
other failure entries to their corresponding state inferred from the
latest test bot results.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

2:20 AM Changeset in webkit [262786] by ysuzuki@apple.com

• 9 edits in trunk/Source/JavaScriptCore

[JSC] Shrink DATA,(data,bss,common) more
​https://bugs.webkit.org/show_bug.cgi?id=212863

Reviewed by Sam Weinig.

1. Use unsigned instead of size_t in GC size-class array. We know that this number never exceeds largeCutoff, which must be much maller than UINT32_MAX.
2. Add missing const to various variables to put them DATA,const instead of DATA,data etc.

• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::initializeSizeClassForStepSize):

• heap/MarkedSpace.h:
• heap/VisitRaceKey.cpp:
• heap/VisitRaceKey.h:
• inspector/agents/InspectorDebuggerAgent.cpp:
• inspector/agents/InspectorDebuggerAgent.h:
• runtime/PropertyDescriptor.cpp:
• runtime/PropertyDescriptor.h:

2:13 AM Changeset in webkit [262785] by Diego Pino Garcia

• 4 edits in trunk/LayoutTests

[WPE] Gardening, update test expectations after r262775
​https://bugs.webkit.org/show_bug.cgi?id=212966

Unreviewed gardening.

Gardened several WPT flaky failures that were already gardening in
GTK. Moved common failures to GLIB.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

1:51 AM Changeset in webkit [262784] by Diego Pino Garcia

• 3 edits
  1 copy
  3 adds in trunk/LayoutTests

[GTK][WPE] Gardening, update baselines for mediaElementAudioSourceToScriptProcessorTest.html
​https://bugs.webkit.org/show_bug.cgi?id=184777

Unreviewed gardening.

The expected result for GTK and WPE is the same as the general baseline, it only changes an expected value.
ios-wk2 also has its own baseline for the same reason.

• platform/gtk/TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt: Added.
• platform/wpe/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt:

1:50 AM Changeset in webkit [262783] by dino@apple.com

• 5 edits in branches/safari-609-branch/Source

REGRESSION: [Safari Mojave for High Sierra] Accessing some of the featured pages on apple.com causes the webpage to crash
​https://bugs.webkit.org/show_bug.cgi?id=212940

Reviewed by Tim Horton.

The code to use the singleton for a SwitchingGPUClient was assuming it
has always been set, which was not the case when
ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) was not true.

Source/WebCore:

• platform/graphics/GraphicsContext3DManager.cpp: Check the state of the

singleton before calling it.
(WebCore::GraphicsContext3DManager::updateHighPerformanceState):
(WebCore::GraphicsContext3DManager::disableHighPerformanceGPUTimerFired):

• platform/graphics/mac/SwitchingGPUClient.h: Add a method to check if the

singleton has been set.
(WebCore::SwitchingGPUClient::hasSingleton):

Source/WebKit:

• WebProcess/cocoa/WebProcessCocoa.mm: Set the singleton unconditionally.

(WebKit::WebProcess::platformInitializeProcess):

1:33 AM Changeset in webkit [262782] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak][GStreamer] enhance GST_ environment variable passing
​https://bugs.webkit.org/show_bug.cgi?id=212905

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2020-06-09
Reviewed by Philippe Normand.

Handle the passing of several GST environment variables,
particularly GST_DEBUG, which, when using * symbol, python adds
quotes, but they break the parsing in GStreamer.

Also the variables are handled by gst-env.py when using
GST_BUILD_PATH, so they are filtered out when it's exported,
avoiding duplication. But it GST_BUILD_PATH is not defined, the
variables are passed to flatpak.

• flatpak/flatpakutils.py:

(WebkitFlatpak.setup_gstbuild):
(WebkitFlatpak.run_in_sandbox):

1:23 AM Changeset in webkit [262781] by calvaris@igalia.com

• 13 edits
  2 adds in trunk

[EME] CDMProxyInstance should not keep CDMInstanceSessions hard referenced
​https://bugs.webkit.org/show_bug.cgi?id=212689

Reviewed by Youenn Fablet.

Source/WebCore:

Sessions are now tracked as WeakPtr inside the CDMInstanceProxy
instead of RefPtr because this creates referencing issues as the
internal objects should be released when the backing JS object is
garbage collected.

Test: media/encrypted-media/clearKey/clearKey-session-life-cycle.html

• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/MediaKeys.h:
• Modules/encryptedmedia/MediaKeys.idl:
• platform/encryptedmedia/CDMProxy.cpp:

(WebCore::CDMInstanceProxy::trackSession):

• platform/encryptedmedia/CDMProxy.h:

(WebCore::CDMInstanceProxy::trackSession):

• platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::CDMInstanceClearKey::createSession):

• platform/encryptedmedia/clearkey/CDMClearKey.h:
• testing/Internals.cpp:

(WebCore::Internals::mediaKeysInternalInstanceObjectRefCount const):
(WebCore::Internals::mediaKeySessionInternalInstanceSessionObjectRefCount const):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• media/encrypted-media/clearKey/clearKey-session-life-cycle-expected.txt: Added.
• media/encrypted-media/clearKey/clearKey-session-life-cycle.html: Added.

12:11 AM Changeset in webkit [262780] by sihui_liu@apple.com

• 4 edits in trunk

TextManipulationController range of paragraph may be wrong after r262601
​https://bugs.webkit.org/show_bug.cgi?id=212874

Reviewed by Wenson Hsieh.

Source/WebCore:

Start and end position of item are not properly set in r262601.

Test: TextManipulation.CompleteTextManipulationSuccedsWhenContentOutOfParagraphIsAdded

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::addItemIfPossible):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

12:06 AM Changeset in webkit [262779] by Lauro Moura

• 2 edits in trunk/Source/WebKit

[WebDriver][WPE] Follow up WPE fix after r262703
​https://bugs.webkit.org/show_bug.cgi?id=212948

Reviewed by Carlos Garcia Campos.

Covered by existing tests.

• UIProcess/Automation/wpe/WebAutomationSessionWPE.cpp:

(WebKit::WebAutomationSession::platformWebModifiersFromRaw):