Timeline

Jun 17, 2020:

10:54 PM Changeset in webkit [263200] by Diego Pino Garcia

• 3 edits
  2 adds in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update test expectations after r263197.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/http/tests/plugins/plugin-javascript-access-allow-all-plugins-expected.txt: Added.
• platform/wpe/TestExpectations:

9:16 PM Changeset in webkit [263199] by Chris Dumez

• 7 edits in trunk

Added missing orientation attributes to PannerNode
​https://bugs.webkit.org/show_bug.cgi?id=213301

Patch by Clark Wang <​clark_wang@apple.com> on 2020-06-17
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Re-baselined previous tests that now have passing test cases.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/pannernode-basic-expected.txt:

Source/WebCore:

Implemented orientation attributes in PannerNode interface, as per spec: ​https://www.w3.org/TR/webaudio/#pannernode.
Added FIXME comments for removing velocity later.

Re-baselined previous tests that now have passing test cases.

• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::orientation const):
(WebCore::PannerNode::setOrientation):
(WebCore::PannerNode::distanceConeGain):

• Modules/webaudio/PannerNode.h:
• Modules/webaudio/PannerNode.idl:

9:14 PM Changeset in webkit [263198] by Chris Dumez

• 99 edits
  16 copies in trunk

Add experimental feature flag for modern & unprefixed WebAudio API
​https://bugs.webkit.org/show_bug.cgi?id=213268

Reviewed by Jer Noble.

LayoutTests/imported/w3c:

Rebaseline a few web-platform-tests now that they are passing or failing at a later stage.
This is due to our WebAudio getting properly unprefixed in the context of layout tests.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-detached-execution-context.tentative-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-method-chaining-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/offlineaudiocontext-detached-execution-context.tentative-expected.txt:

Source/WebCore:

Add experimental feature flag for modern & unprefixed WebAudio API,
off by default.

This patch split the AudioContext, OfflineAudioContext and PannerNode
IDL interfaces into their prefixed and unprefixed versions. The
unprefixed versions are behind the new experimental feature flag that
is currently off by default but automatically gets turned on in the
context of layout tests.

This will give us more flexibility when working on the modern and
unprefixed WebAudio API as we will not have to worry about backward
compatibility. This also allows us to easily turn it on or off via
the experimental features menu in Safari.

No new tests, rebaselined existing tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::AnalyserNode):

• Modules/webaudio/AnalyserNode.h:
• Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):

• Modules/webaudio/AudioBasicInspectorNode.h:
• Modules/webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):

• Modules/webaudio/AudioBasicProcessorNode.h:
• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::create):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::setBuffer):
(WebCore::AudioBufferSourceNode::setPannerNode):

• Modules/webaudio/AudioBufferSourceNode.h:
• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContextBase::AudioContextBase):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContextBase::document const):
(WebCore::AudioContextBase::scriptExecutionContext const):

• Modules/webaudio/AudioContext.h:

(WebCore::AudioContextBase::AutoLocker::AutoLocker):
(WebCore::AudioContextBase::AutoLocker::~AutoLocker):
(WebCore::AudioContext::maxNumberOfChannels):
(isType):

• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioContextState.h: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
• Modules/webaudio/AudioContextState.idl: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
• Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):

• Modules/webaudio/AudioDestinationNode.h:
• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::enableOutputsIfNecessary):
(WebCore::AudioNode::deref):
(WebCore::AudioNode::contextForBindings const):

• Modules/webaudio/AudioNode.h:

(WebCore::AudioNode::context):
(WebCore::AudioNode::context const):

• Modules/webaudio/AudioNode.idl:
• Modules/webaudio/AudioNodeOutput.h:

(WebCore::AudioNodeOutput::context):

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::AudioParam):

• Modules/webaudio/AudioParam.h:
• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):

• Modules/webaudio/AudioParamTimeline.h:
• Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):

• Modules/webaudio/AudioScheduledSourceNode.h:
• Modules/webaudio/AudioSummingJunction.cpp:

(WebCore::AudioSummingJunction::AudioSummingJunction):

• Modules/webaudio/AudioSummingJunction.h:

(WebCore::AudioSummingJunction::context):

• Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::BiquadFilterNode):

• Modules/webaudio/BiquadFilterNode.h:
• Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

• Modules/webaudio/BiquadProcessor.h:
• Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::create):
(WebCore::ChannelMergerNode::ChannelMergerNode):

• Modules/webaudio/ChannelMergerNode.h:
• Modules/webaudio/ChannelSplitterNode.cpp:

(WebCore::ChannelSplitterNode::create):
(WebCore::ChannelSplitterNode::ChannelSplitterNode):

• Modules/webaudio/ChannelSplitterNode.h:
• Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode):

• Modules/webaudio/ConvolverNode.h:
• Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):

• Modules/webaudio/DefaultAudioDestinationNode.h:
• Modules/webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):
(WebCore::DelayNode::create):

• Modules/webaudio/DelayNode.h:
• Modules/webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

• Modules/webaudio/DelayProcessor.h:
• Modules/webaudio/DistanceModelType.h: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
• Modules/webaudio/DistanceModelType.idl: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
• Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

• Modules/webaudio/DynamicsCompressorNode.h:
• Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::GainNode):

• Modules/webaudio/GainNode.h:
• Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::create):
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::setFormat):

• Modules/webaudio/MediaElementAudioSourceNode.h:
• Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::create):
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

• Modules/webaudio/MediaStreamAudioDestinationNode.h:
• Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):

• Modules/webaudio/MediaStreamAudioSourceNode.h:
• Modules/webaudio/OfflineAudioContext.idl:
• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):

• Modules/webaudio/OfflineAudioDestinationNode.h:
• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::create):
(WebCore::OscillatorNode::OscillatorNode):

• Modules/webaudio/OscillatorNode.h:
• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNodeBase::PannerNodeBase):
(WebCore::PannerNode::PannerNode):

• Modules/webaudio/PannerNode.h:
• Modules/webaudio/PannerNode.idl:
• Modules/webaudio/PanningModelType.h: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
• Modules/webaudio/PanningModelType.idl: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
• Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::create):
(WebCore::ScriptProcessorNode::ScriptProcessorNode):

• Modules/webaudio/ScriptProcessorNode.h:
• Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::WaveShaperNode):

• Modules/webaudio/WaveShaperNode.h:
• Modules/webaudio/WebKitAudioContext.cpp: Copied from Source/WebCore/Modules/webaudio/AudioContext.cpp.

(WebCore::WebKitAudioContext::isSampleRateRangeGood):
(WebCore::WebKitAudioContext::create):
(WebCore::WebKitAudioContext::WebKitAudioContext):
(WebCore::WebKitAudioContext::constructCommon):
(WebCore::WebKitAudioContext::~WebKitAudioContext):
(WebCore::WebKitAudioContext::lazyInitialize):
(WebCore::WebKitAudioContext::clear):
(WebCore::WebKitAudioContext::uninitialize):
(WebCore::WebKitAudioContext::isInitialized const):
(WebCore::WebKitAudioContext::addReaction):
(WebCore::WebKitAudioContext::setState):
(WebCore::WebKitAudioContext::stop):
(WebCore::WebKitAudioContext::suspend):
(WebCore::WebKitAudioContext::resume):
(WebCore::WebKitAudioContext::activeDOMObjectName const):
(WebCore::WebKitAudioContext::hostingDocumentIdentifier const):
(WebCore::WebKitAudioContext::isSuspended const):
(WebCore::WebKitAudioContext::visibilityStateChanged):
(WebCore::WebKitAudioContext::wouldTaintOrigin const):
(WebCore::WebKitAudioContext::createBuffer):
(WebCore::WebKitAudioContext::decodeAudioData):
(WebCore::WebKitAudioContext::createBufferSource):
(WebCore::WebKitAudioContext::createMediaElementSource):
(WebCore::WebKitAudioContext::createMediaStreamSource):
(WebCore::WebKitAudioContext::createMediaStreamDestination):
(WebCore::WebKitAudioContext::createScriptProcessor):
(WebCore::WebKitAudioContext::createBiquadFilter):
(WebCore::WebKitAudioContext::createWaveShaper):
(WebCore::WebKitAudioContext::createPanner):
(WebCore::WebKitAudioContext::createConvolver):
(WebCore::WebKitAudioContext::createDynamicsCompressor):
(WebCore::WebKitAudioContext::createAnalyser):
(WebCore::WebKitAudioContext::createGain):
(WebCore::WebKitAudioContext::createDelay):
(WebCore::WebKitAudioContext::createChannelSplitter):
(WebCore::WebKitAudioContext::createChannelMerger):
(WebCore::WebKitAudioContext::createOscillator):
(WebCore::WebKitAudioContext::createPeriodicWave):
(WebCore::WebKitAudioContext::notifyNodeFinishedProcessing):
(WebCore::WebKitAudioContext::derefFinishedSourceNodes):
(WebCore::WebKitAudioContext::refNode):
(WebCore::WebKitAudioContext::derefNode):
(WebCore::WebKitAudioContext::derefUnfinishedSourceNodes):
(WebCore::WebKitAudioContext::lock):
(WebCore::WebKitAudioContext::tryLock):
(WebCore::WebKitAudioContext::unlock):
(WebCore::WebKitAudioContext::isAudioThread const):
(WebCore::WebKitAudioContext::isGraphOwner const):
(WebCore::WebKitAudioContext::addDeferredFinishDeref):
(WebCore::WebKitAudioContext::handlePreRenderTasks):
(WebCore::WebKitAudioContext::handlePostRenderTasks):
(WebCore::WebKitAudioContext::handleDeferredFinishDerefs):
(WebCore::WebKitAudioContext::markForDeletion):
(WebCore::WebKitAudioContext::scheduleNodeDeletion):
(WebCore::WebKitAudioContext::deleteMarkedNodes):
(WebCore::WebKitAudioContext::markSummingJunctionDirty):
(WebCore::WebKitAudioContext::removeMarkedSummingJunction):
(WebCore::WebKitAudioContext::markAudioNodeOutputDirty):
(WebCore::WebKitAudioContext::handleDirtyAudioSummingJunctions):
(WebCore::WebKitAudioContext::handleDirtyAudioNodeOutputs):
(WebCore::WebKitAudioContext::addAutomaticPullNode):
(WebCore::WebKitAudioContext::removeAutomaticPullNode):
(WebCore::WebKitAudioContext::updateAutomaticPullNodes):
(WebCore::WebKitAudioContext::processAutomaticPullNodes):
(WebCore::WebKitAudioContext::nodeWillBeginPlayback):
(WebCore::shouldDocumentAllowWebAudioToAutoPlay):
(WebCore::WebKitAudioContext::willBeginPlayback):
(WebCore::WebKitAudioContext::willPausePlayback):
(WebCore::WebKitAudioContext::startRendering):
(WebCore::WebKitAudioContext::mediaCanStart):
(WebCore::WebKitAudioContext::mediaState const):
(WebCore::WebKitAudioContext::pageMutedStateDidChange):
(WebCore::WebKitAudioContext::isPlayingAudioDidChange):
(WebCore::WebKitAudioContext::finishedRendering):
(WebCore::WebKitAudioContext::dispatchEvent):
(WebCore::WebKitAudioContext::incrementActiveSourceCount):
(WebCore::WebKitAudioContext::decrementActiveSourceCount):
(WebCore::WebKitAudioContext::suspendRendering):
(WebCore::WebKitAudioContext::resumeRendering):
(WebCore::WebKitAudioContext::close):
(WebCore::WebKitAudioContext::suspendPlayback):
(WebCore::WebKitAudioContext::mayResumePlayback):
(WebCore::WebKitAudioContext::postTask):
(WebCore::WebKitAudioContext::origin const):
(WebCore::WebKitAudioContext::addConsoleMessage):
(WebCore::WebKitAudioContext::clearPendingActivity):
(WebCore::WebKitAudioContext::makePendingActivity):
(WebCore::WebKitAudioContext::logChannel const):

• Modules/webaudio/WebKitAudioContext.h: Copied from Source/WebCore/Modules/webaudio/AudioContext.h.

(WebCore::WebKitAudioContext::destination):
(WebCore::WebKitAudioContext::activeSourceCount const):
(WebCore::WebKitAudioContext::listener):
(WebCore::WebKitAudioContext::isClosed const):
(WebCore::WebKitAudioContext::connectionCount const):
(WebCore::WebKitAudioContext::audioThread const):
(WebCore::WebKitAudioContext::maxNumberOfChannels):
(WebCore::WebKitAudioContext::userGestureRequiredForAudioStart const):
(WebCore::WebKitAudioContext::pageConsentRequiredForAudioStart const):
(WebCore::WebKitAudioContext::state const):
(isType):

• Modules/webaudio/WebKitAudioContext.idl: Copied from Source/WebCore/Modules/webaudio/AudioContext.idl.
• Modules/webaudio/WebKitAudioPannerNode.cpp: Copied from Source/WebCore/Modules/webaudio/PannerNode.cpp.

(WebCore::fixNANs):
(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
(WebCore::WebKitAudioPannerNode::~WebKitAudioPannerNode):
(WebCore::WebKitAudioPannerNode::pullInputs):
(WebCore::WebKitAudioPannerNode::process):
(WebCore::WebKitAudioPannerNode::reset):
(WebCore::WebKitAudioPannerNode::initialize):
(WebCore::WebKitAudioPannerNode::uninitialize):
(WebCore::WebKitAudioPannerNode::listener):
(WebCore::WebKitAudioPannerNode::setPanningModel):
(WebCore::WebKitAudioPannerNode::distanceModel const):
(WebCore::WebKitAudioPannerNode::setDistanceModel):
(WebCore::WebKitAudioPannerNode::getAzimuthElevation):
(WebCore::WebKitAudioPannerNode::dopplerRate):
(WebCore::WebKitAudioPannerNode::distanceConeGain):
(WebCore::WebKitAudioPannerNode::notifyAudioSourcesConnectedToNode):

• Modules/webaudio/WebKitAudioPannerNode.h: Copied from Source/WebCore/Modules/webaudio/PannerNode.h.
• Modules/webaudio/WebKitAudioPannerNode.idl: Copied from Source/WebCore/Modules/webaudio/PannerNode.idl.
• Modules/webaudio/WebKitOfflineAudioContext.cpp: Copied from Source/WebCore/Modules/webaudio/DelayNode.cpp.

(WebCore::WebKitOfflineAudioContext::WebKitOfflineAudioContext):
(WebCore::WebKitOfflineAudioContext::create):

• Modules/webaudio/WebKitOfflineAudioContext.h: Copied from Source/WebCore/Modules/webaudio/DelayNode.h.
• Modules/webaudio/WebKitOfflineAudioContext.idl: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• dom/EventTargetFactory.in:
• page/Settings.yaml:
• testing/Internals.cpp:

(WebCore::Internals::setAudioContextRestrictions):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

Add experimental feature flag for modern & unprefixed WebAudio API,
off by default.

• Shared/WebPreferences.yaml:

8:23 PM Changeset in webkit [263197] by Fujii Hironori

• 3 edits in trunk/Tools

RebaselineServer: "Rebaseline queue" button is placed behind the footer
​https://bugs.webkit.org/show_bug.cgi?id=213258

Reviewed by Zalan Bujtas.

• Scripts/webkitpy/tool/servers/data/rebaselineserver/index.html: Moved 'log' and 'queue' elements after 'footer' element.
• Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:

(#queue): Changed 'bottom' property from 3em to 4em.

7:26 PM Changeset in webkit [263196] by Wenson Hsieh

• 10 edits in trunk

[macOS] Shift-tab in a bullet list in Mail Compose jumps back to Subject field
​https://bugs.webkit.org/show_bug.cgi?id=213320
<rdar://problem/63831962>

Reviewed by Tim Horton.

Source/WebCore:

After the changes in r262051, pressing shift-tab in a bulleted list in Mail compose on macOS no longer triggers
an outdent command. This is because the default behavior of the "keydown" event will now relinquish focus to the
embedding client (i.e. the "chrome"). In this case, Mail makes the Subject field above the compose web view the
first responder.

This is necessary on iOS, where Mail does not attempt to intercept shift+tab and move focus to the subject line.
However, Mail on macOS intercepts the keypress event, and either triggers outdent (if the selection is inside a
list or blockquote) or focuses the Subject line. Since focus is relinquished during "keydown", this logic no
longer runs, and hitting shift+tab in a list always relinquishes focus.

To address this, refactor the changes made in r262051 so that we treat the default behavior of the "keypress"
event (rather than "keydown") as relinquishing focus. See WebKit/ChangeLog for more details.

Test: WebKit.ShiftTabDoesNotTakeFocusFromEditableWebViewWhenPreventingKeyPress

• page/EventHandler.cpp:

(WebCore::EventHandler::defaultTabEventHandler):

Remove a call to relinquish focus when handling tab.

• page/FocusController.h:

Source/WebKit:

See WebCore/ChangeLog for more detail.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::handleKeyEventByRelinquishingFocusToChrome):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleEditingKeyboardEvent):

Hoist logic for relinquishing focus as a result of shift+tab from EventHandler to WebPage, so that it is the
default behavior when processing a "keypress" event that corresponds to shift+tab in an editable web view on
Cocoa platforms. If we do end up relinquishing focus, then we consider the keypress event to be handled.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::handleEditingKeyboardEvent):

Tools:

Add a new API test to verify that preventing the "keypress" event for shift+tab in an SPI-editable web view
causes us to avoid relinquishing focus.

• TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

6:55 PM Changeset in webkit [263195] by mark.lam@apple.com

• 13 edits in trunk/Source

Replace JSC::FreeList linked list with a Bitmap.
​https://bugs.webkit.org/show_bug.cgi?id=213071

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Implement an alternative to the linked list FreeList. This alternative uses
a Bitmap to record which atom in the block is available for allocation.

The intuition here is that allocation using the Bitmap implementation will do:

2 loads - m_currentRowBitmap, m_currentMarkedBlockRowAddress
1 store - m_currentRowBitmap

whereas the linked list implementation will do:

3 loads - m_scrambledHead, m_secret, result->scrambledNext
1 store - m_scrambledHead

and result->scrambledNext is from a different region of code and therefore not
in the same cache line.

The downside of the Bitmap implementation is that it uses more instructions.

This change is currently only enabled for x86_64, which shows about a 0.8%
progression on Speedometer 2.

It appears to be about a 1% regression on ARM64E. Hence, for now, we keep the
linked list implementation for ARM64 builds.

This is how the Bitmap FreeList works:

1. The Bitmap implementation only replaces the linked list implementation. It does not replace the bump allocator.

2. The Bitmap allocator keeps a m_bitmap that is initialized in MarkedBlock::Handle::specializedSweep() to have a bit set for each atom location that is available for allocation (i.e. is free). Note that a cell is usually allocated using more than 1 atom. Only the bit corresponding to the first atom (in that cell length range of free atoms) will be set.

This is consistent with how bits in MarkedBlock::Footer::m_marks and
MarkedBlock::Footer::m_newlyAllocated are set i.e. only the bit for the first
atom in the cell can be set.

3. The allocation algorithm thinks of the MarkedBlock as consisting of rows of atoms, where the number of atoms in a row equals the number of bits in a AtomsBitmap::Word. On 64-bit CPUs, this would be 64.

We will start allocating from the last (highest numbered) row down to the
first (row 0). As we allocate, we will only update m_currentRowIndex and
m_currentRowBitmap. m_bitmap will not be updated. This is so in order to
reduce the number of instructions executed during an allocation.

When m_currentRowIndex points to N, the AtomsBitmap::Word for row N in
m_bitmap will have been copied into m_currentRowBitmap. This is the row
that we will be allocating from until the row is exhausted.

This is how we know whether an atom is available for allocation or not:

1. Atoms in any rows above m_currentRowIndex are guaranteed to be allocated already (because we allocate downwards), and hence, are not available.

1. For row m_currentRowIndex, m_currentRowBitmap is the source of truth

on which atoms in the row are available for allocation.

1. For rows below m_currentRowIndex, m_bitmap is the source of truth on

which atoms are available for allocation.

When m_currentRowIndex reaches 0, the info in m_bitmap is completely
obsoleted, and m_currentRowBitmap holds the availability info for row 0.
When both m_currentRowIndex and m_currentRowBitmap are 0, then we have
completely exhausted the block and no more atoms are available for
allocation.

4. Allocation happens in 3 paths: fast, middle, slow.

The fast path checks m_currentRowBitmap. If it's not 0, then we compute the
bit number of the lowest set bit in it. That bit number will be used together
with m_currentMarkedBlockRowAddress to compute the address of the atom
location available for allocation. m_currentRowBitmap will be updated to clear
the bit for the atom that has just ben allocated.

If m_currentRowBitmap is 0, then we'll go to the middle path.

The middle path checks m_currentRowIndex to see if we have more rows to allocate
from. For each m_currentRowIndex, we check its corresponding AtomsBitmap::Word
in m_bitmap. If the word is non-zero, we copy it to m_currentRowBitmap and
jump to the fast path to do the allocation. The middle path will update
m_currentRowIndex to point to the current row we're allocating from.

If we have decremented m_currentRowIndex down to 0 but still can't find a
non-zero AtomsBitmap::Word in m_bitmap, then the block has been exhausted, and
we'll go to the slow path.

The slow path is analogous to the old slow path i.e. we try to refill the
LocalAllocator with a new MarkedBlock.

5. On the layout of fields in FreeList (see changes in FreeList.h), we try to preserve the positions of the bump allocator fields. The only change we made there is n the location of m_cellSize. It is now moved up next to m_remaining, and m_originalSize is moved down. This is because m_originalSize is only accessed in the slow path, and m_cellSize is accessed in the bump allocation path.

Next, we try to put Bitmap allocation fields where the linked list fields
would have been. The one bit of trickiness is that we'll put
m_currentMarkedBlockRowAddress in a union with m_payloadEnd. This is because
m_payloadEnd is only used in the bump allocation path. If m_remaining is 0,
then we can reuse this location for m_currentMarkedBlockRowAddress.

With this, we would have 4 bytes of padding after m_currentRowIndex. For
compactness, we put m_originalSize there in that space. For builds that use
the linked list implementation, m_originalSize will be located below after
m_cellSize.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell):

• heap/FreeList.cpp:

(JSC::FreeList::clear):
(JSC::FreeList::initializeAtomsBitmap):
(JSC::FreeList::initializeBump):
(JSC::FreeList::contains const):
(JSC::FreeList::dump const):

• heap/FreeList.h:

(JSC::FreeList::bitmapIsEmpty const):
(JSC::FreeList::allocationWillFail const):
(JSC::FreeList::offsetOfCurrentRowBitmap):
(JSC::FreeList::offsetOfBitmapRows):
(JSC::FreeList::offsetOfCurrentRowIndex):
(JSC::FreeList::offsetOfCurrentMarkedBlockRowAddress):
(JSC::FreeList::offsetOfRemaining):
(JSC::FreeList::atomsBitmap):
(JSC::FreeList::bitmapRows const):
(JSC::FreeList::offsetOfOriginalSize): Deleted.

• heap/FreeListInlines.h:

(JSC::FreeList::allocate):
(JSC::FreeList::forEach const):

• heap/LocalAllocator.cpp:

(JSC::LocalAllocator::isFreeListedCell const):

• heap/MarkedBlock.h:

(JSC::MarkedBlock::Handle::atomAt const):

• heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::Handle::specializedSweep):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):

Source/WTF:

1. Use countOfBits<> template to compute the number of bits.
2. Introduce log2() and log2Constexpr() utility functions.
3. Make Bitmap<>::forEachSetBit() a little bit more efficient: we don't need to keep iterating if the bitmap word is already empty of bits.

• wtf/Bitmap.h:

(WTF::WordType>::forEachSetBit const):

• wtf/MathExtras.h:

(WTF::clzConstexpr):
(WTF::clz):
(WTF::ctzConstexpr):
(WTF::ctz):
(WTF::getMSBSet):
(WTF::getMSBSetConstexpr):
(WTF::log2):
(WTF::log2Constexpr):

6:45 PM Changeset in webkit [263194] by aestes@apple.com

• 2 edits in trunk/Tools

REGRESSION (r258092): fast/forms/ios/file-upload-panel.html fails when HAVE(UICONTEXTMENU_LOCATION)
​https://bugs.webkit.org/show_bug.cgi?id=213314
<rdar://problem/60339129>

Reviewed by Maciej Stachowiak.

fast/forms/ios/file-upload-panel.html sets the shouldHandleRunOpenPanel and
shouldPresentPopovers test options to false so that WKTR will (a) not register a
runOpenPanel UI delegate callback, causing WebKit to create a WKFileUploadPanel instead, and
(b) swizzle two UIKit view controller presentation methods to prevent the document picker
menu from being presented. The test merely wants the WKFileUploadPanel instance to exist in
order to query its available actions, not for it to show UI.

In r258092, WKFileUploadPanel now sometimes uses a UIContextMenuInteraction instance to
present the document picker menu, but -[UIContextMenuInteraction _presentMenuAtLocation:]
fails due to WKTR's above-mentioned swizzling. When this failure occurs,
UIContextMenuInteraction calls -contextMenuInteraction:willEndForConfiguration:animator: on
its delegate (the WKFileUploadPanel), which dismisses the open panel before the test has had
a chance to query the available actions.

Fixed this by swizzling -[UIContextMenuInteraction _presentMenuAtLocation:] when the
shouldPresentPopovers test option is false.

• WebKitTestRunner/ios/TestControllerIOS.mm:

(overridePresentMenuOrPopoverOrViewController): Renamed from
overridePresentViewControllerOrPopover.
(WTR::TestController::platformResetStateToConsistentValues): Swizzled
-[UIContextMenuInteraction _presentMenuAtLocation:] with
overridePresentMenuOrPopoverOrViewController when the shouldPresentPopovers test option is
false.
(overridePresentViewControllerOrPopover): Renamed to
overridePresentMenuOrPopoverOrViewController.

6:37 PM Changeset in webkit [263193] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

StructureIDTable::validate() doesn't work when compiled with GCC.
​https://bugs.webkit.org/show_bug.cgi?id=213302
<rdar://problem/64452172>

Reviewed by Yusuke Suzuki.

I was previously using ensureStillAliveHere() to force the validation load to
not be elided. However, this is not how ensureStillAliveHere() works. The proper
way to force the load is to use a volatile pointer instead, which is applied in
this patch.

With Clang, the ensureStillAliveHere() happened to do what I expected, but with
GCC it did not. The compiler is at liberty to elide the load because there is
no memory clobbering operation between the load and the call to
ensureStillAliveHere(). Switching to using the volatile pointer solution.

• runtime/StructureIDTable.h:

(JSC::StructureIDTable::validate):

4:57 PM Changeset in webkit [263192] by Beth Dakin

• 4 edits in trunk/Source/WebKit

Remove references to blacklist/whitelist in the old C API
​https://bugs.webkit.org/show_bug.cgi?id=213322

Reviewed by Tim Horton.

• UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupAddUserStyleSheet):
(WKPageGroupAddUserScript):

• UIProcess/API/C/WKPageGroup.h:
• WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

4:53 PM Changeset in webkit [263191] by sbarati@apple.com

• 2 edits in trunk/JSTests

Skip JSTests/stress/check-is-constant-non-cell-should-not-array-profile-during-osr-exit.js on memory limited devices
​https://bugs.webkit.org/show_bug.cgi?id=213321

Reviewed by Mark Lam.

It uses ~1GB of memory and jetsams on iOS devices.

• stress/check-is-constant-non-cell-should-not-array-profile-during-osr-exit.js:

4:03 PM Changeset in webkit [263190] by Alan Coon

• 1 copy in branches/safari-609.3.5.3-branch

New branch.

4:03 PM Changeset in webkit [263189] by Alan Coon

• 1 copy in branches/safari-609.3.5.2-branch

New branch.

4:03 PM Changeset in webkit [263188] by Alan Coon

• 1 copy in branches/safari-609.3.5.1-branch

New branch.

4:03 PM Changeset in webkit [263187] by Alan Coon

• 1 copy in branches/safari-609.3.5.0-branch

New branch.

3:46 PM Changeset in webkit [263186] by sihui_liu@apple.com

• 2 edits in trunk/Tools

REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=213311
<rdar://problem/64456413>

Reviewed by Wenson Hsieh.

TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem does not wait long
enough to make sure TextManipulationController gets notified about the insertion and starts observing.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

3:45 PM Changeset in webkit [263185] by Alan Coon

• 8 edits in trunk/Source

Versioning.

WebKit-610.1.18

3:31 PM Changeset in webkit [263184] by Alan Coon

• 8 edits in branches/safari-609-branch/Source

Versioning.

WebKit-609.3.6

3:30 PM Changeset in webkit [263183] by Alan Coon

• 1 copy in tags/Safari-609.3.5

Tag Safari-609.3.5.

3:23 PM Changeset in webkit [263182] by Alan Coon

• 1 copy in branches/safari-610.1.17-branch

Tag Safari-610.1.17.

2:29 PM Changeset in webkit [263181] by aakash_jain@apple.com

• 11 edits
  3 deletes in trunk/Tools

Delete code for old ews bindings queue
​https://bugs.webkit.org/show_bug.cgi?id=213315

Rubber-stamped by Alexey Proskuryakov.

• Scripts/webkitpy/common/config/ews.json:
• Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.run_bindings_tests_command): Deleted.
(WinPort.run_bindings_tests_command): Deleted.

• Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.run_bindings_tests_command): Deleted.

• Scripts/webkitpy/common/net/generictestresults.py: Removed.
• Scripts/webkitpy/common/net/generictestresults_unittest.py: Removed.
• Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Removed.
• Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTask._retry_bindings_tests): Deleted.

• Scripts/webkitpy/tool/bot/retrylogic_unittest.py:

(MockBindingsEarlyWarningSystem): Deleted.
(MockBindingsEarlyWarningSystem.init): Deleted.
(MockBindingsEarlyWarningSystem.test_results): Deleted.
(BindingsEarlyWarningSystemTest): Deleted.
(BindingsEarlyWarningSystemTest._results_indicate_all_passed): Deleted.
(BindingsEarlyWarningSystemTest._create_task): Deleted.
(BindingsEarlyWarningSystemTest.test_success_case): Deleted.
(BindingsEarlyWarningSystemTest.test_test_failure): Deleted.
(BindingsEarlyWarningSystemTest.test_fix): Deleted.
(BindingsEarlyWarningSystemTest.test_ineffective_patch): Deleted.
(BindingsEarlyWarningSystemTest.test_partially_effective_patch): Deleted.
(BindingsEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Deleted.

• Scripts/webkitpy/tool/commands/earlywarningsystem.py:
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(TestBindingsEWS): Deleted.
(AbstractEarlyWarningSystemTest.test_failing_bindings_tests_message): Deleted.

• Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
• Scripts/webkitpy/tool/steps/runtests.py:

(RunTests._run_bindings_tests): Deleted.

• Scripts/webkitpy/tool/steps/steps_unittest.py:

(test_patch_relevant_bindings): Deleted.
(test_runtests_api): Deleted.

1:23 PM Changeset in webkit [263180] by ysuzuki@apple.com

• 3 edits
  1 add in trunk

[JSC] Freeze JSBigInt when setting it as a constant in AI
​https://bugs.webkit.org/show_bug.cgi?id=213310
<rdar://problem/64450410>

Reviewed by Mark Lam.

JSTests:

• stress/bigint-constant-fold-to-numeric.js: Added.

(foo):

Source/JavaScriptCore:

JSCells should be explicitly frozen via DFG::Graph::freeze or DFG::Graph::freezeStrong. And heap JSBigInt is JSCell.
We should freeze it before setting it as a parameter of setConstant in AI. We use DFG::Graph::freeze since we know
that this is coming from somewhere in DFG graph: this ToNumeric node itself is not newly producing this JSBigInt.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

1:09 PM Changeset in webkit [263179] by graouts@webkit.org

• 3 edits
  8 adds in trunk

quikr.com: unable to select item from dropdown
​https://bugs.webkit.org/show_bug.cgi?id=213260
<rdar://problem/58106011>

Reviewed by Zalan Bujtas.

Source/WebCore:

Only account for box-shadow when computing the background rect if the clipping element itself has non-zero used width and height.

Tests: fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-height-clipping-container.html

fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-width-clipping-container.html
fast/box-shadow/hit-test-box-shadow-on-zero-height-clipping-container.html
fast/box-shadow/hit-test-box-shadow-on-zero-width-clipping-container.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::addVisualEffectOverflow):

LayoutTests:

Add two new tests that check that we correctly do not consider content within a clipping container that
has 0-width or 0-height and box-shadow, with or without empty margins.

• fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-height-clipping-container-expected.txt: Added.
• fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-height-clipping-container.html: Added.
• fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-width-clipping-container-expected.txt: Added.
• fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-width-clipping-container.html: Added.
• fast/box-shadow/hit-test-box-shadow-on-zero-height-clipping-container-expected.txt: Added.
• fast/box-shadow/hit-test-box-shadow-on-zero-height-clipping-container.html: Added.
• fast/box-shadow/hit-test-box-shadow-on-zero-width-clipping-container-expected.txt: Added.
• fast/box-shadow/hit-test-box-shadow-on-zero-width-clipping-container.html: Added.

12:52 PM Changeset in webkit [263178] by ddkilzer@apple.com

• 4 edits in trunk/Source

Replace OptionSetTraits/OptionSetValues with EnumTraits/EnumValues
<​https://webkit.org/b/213264>

Reviewed by Brent Fulgham.

Source/WebCore:

• page/DragActions.h:

(EnumTraits<WebCore::DragDestinationAction>):

• Rename from OptionSetTraits<WebCore::DragDestinationAction>.

(OptionSetTraits<WebCore::DragOperation>):
(OptionSetTraits<WebCore::DragSourceAction>):

• Remove since EnumTraits<> already exist for both.

Source/WTF:

• wtf/OptionSet.h:

(WTF::isValidOptionSetEnum):
(WTF::maskRawValue):

• Replace OptionSetTraits<>/OptionSetValues<> with EnumTraits<>/EnumValues<>.

12:44 PM Changeset in webkit [263177] by Alexey Shvayka

• 28 edits
  17 copies
  66 adds
  10 deletes in trunk/JSTests

Update test262 to commit 8d3dd2d1a0a5
​https://bugs.webkit.org/show_bug.cgi?id=213312

Reviewed by Yusuke Suzuki.

• test262/expectations.yaml:
• test262/latest-changes-summary.txt:
• test262/test/*: Updated.
• test262/test262-Revision.txt:

12:07 PM Changeset in webkit [263176] by dino@apple.com

• 1 edit in trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj

Another build fix for iOS.

This time for the new build system, which
wasn't running a custom rule for exported header files.

• ANGLE.xcodeproj/project.pbxproj:

11:55 AM Changeset in webkit [263175] by ggaren@apple.com

• 3 edits in trunk/Source/WebCore

media/remoteplayback-target-availability.html was a flaky failure after r262904
​https://bugs.webkit.org/show_bug.cgi?id=213294

Reviewed by Sam Weinig.

AirPlay availability is a global that depends on a timer (and/or an
external piece of hardware). Therefore, the first value RemotePlayback
sees for AirPlay availability, while usually 'unavailable', is sometimes
'available'. Flaky!

In this case, media/remoteplayback-prompt.html triggered an AirPlay
availability check, and then media/remoteplayback-target-availability.html,
if run in the same process, sometimes saw 'available' as its initial
availability state.

Make RemotePlayback's initial availability state deterministic by
recording availability state at the time we enqueue our task, rather
than at the time we dequeue our task. (By specification and
implementation, RemotePlayback's initial availability state is always
'unavailable', regardless of AirPlay state.) This is OK to do because,
if the state ever changes after we enqueue our task, we'll get an update
notification and enqueue a new task.

• Modules/remoteplayback/RemotePlayback.cpp:

(WebCore::RemotePlayback::watchAvailability): Copy the availability
state when we enqueue our task, and do not update it when we dequeue our
task. This is the heart of the bug fix.

Make sure to manually update availability state when we first register
to monitor availability, since we never got an update notification for
the current state.

(WebCore::RemotePlayback::prompt): For consistency with
watchAvailability, do not update availability state when we dequeue our
task. (This means that prompting before watching availability is always
an error, which is fine, and consistent with the spec, which says, "If
the user agent stops monitoring the list of available remote playback
devices... It SHOULD also set the availability value for all media
elements to false.")

Make sure to manually update availability state when we first register
to monitor availability, since we never got an update notification for
the current state.

(WebCore::RemotePlayback::availabilityChanged): For consistency with
watchAvailability, do not update availability state when we dequeue our
task.

(WebCore::RemotePlayback::updateAvailability): Deleted. We never
synchronously update our state anymore. All state changes are queued and
processed in order.

• Modules/remoteplayback/RemotePlayback.h:

11:40 AM Changeset in webkit [263174] by keith_miller@apple.com

• 3 edits
  2 adds in trunk

$vm.haveABadTime/isHavingABadTime should work with non-globalObject parameters
​https://bugs.webkit.org/show_bug.cgi?id=213304

Reviewed by Mark Lam.

JSTests:

• stress/dollarVM-have-a-bad-time-no-params.js: Added.
• stress/dollarVM-have-a-bad-time-works-for-non-global-object-params.js: Added.

Source/JavaScriptCore:

Previously, $vm.haveABadTime would crash if passed a
non-globalObject object as the first parameter because it was
missing a return in front the error handling case. This patch
resolves that issue but also extends the semantics of
haveABadTime/isHavingABadTime to either use the global object of
the first parameter even if it's not a JSGlobalObject. If no
argument is passed, haveABadTime/isHavingABadTime instead use the
global object of the callee.

• tools/JSDollarVM.cpp:

(JSC::functionHaveABadTime):
(JSC::functionIsHavingABadTime):

11:38 AM Changeset in webkit [263173] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Gardening: move some unused data inside ENABLE(JIT) to unbreak the CLoop build.
​https://bugs.webkit.org/show_bug.cgi?id=213255

Not reviewed.

• assembler/testmasm.cpp:

11:29 AM Changeset in webkit [263172] by dino@apple.com

• 1 edit in trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/ContextCGL.cpp

Fix iOS build.

• src/libANGLE/renderer/gl/cgl/ContextCGL.cpp:

11:25 AM Changeset in webkit [263171] by Kate Cheney

• 2 edits in trunk/LayoutTests

http/tests/in-app-browser-privacy/non-app-bound-domain-does-not-get-app-bound-session.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=213272
<rdar://problem/64427778>

Reviewed by David Kilzer.

Before a navigation occurs, an app-bound network session is created
by default. If any non-app bound navigations occur, a new session is
created. Since this test only checks for the existance of an app-bound
session, it should clear the app-bound session after the initial load
to properly test functionality.

• http/tests/in-app-browser-privacy/non-app-bound-domain-does-not-get-app-bound-session.html:

11:23 AM Changeset in webkit [263170] by Russell Epstein

• 1 copy in tags/Safari-610.1.15.51.4

Tag Safari-610.1.15.51.4.

11:16 AM Changeset in webkit [263169] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Null check plugin.m_data before using it in PDFPlugin::ByteRangeRequest::completeUnconditionally
​https://bugs.webkit.org/show_bug.cgi?id=213305
<rdar://problem/60349279>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-06-17
Reviewed by Brady Eidson.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::ByteRangeRequest::completeUnconditionally):

11:07 AM Changeset in webkit [263168] by aakash_jain@apple.com

• 3 edits
  1 delete in trunk/Tools

Delete code for old ews style queue
​https://bugs.webkit.org/show_bug.cgi?id=213297

Rubber-stamped by Alexey Proskuryakov.

• Scripts/webkitpy/tool/bot/stylequeuetask.py: Removed.
• Scripts/webkitpy/tool/commands/queues.py:

(StyleQueue): Deleted.
(StyleQueue.init): Deleted.
(StyleQueue.review_patch): Deleted.
(StyleQueue.run_command): Deleted.
(StyleQueue.expected_failures): Deleted.
(StyleQueue.refetch_patch): Deleted.

• Scripts/webkitpy/tool/commands/queues_unittest.py:

(TestReviewQueue): Deleted.

10:56 AM Changeset in webkit [263167] by commit-queue@webkit.org

• 11 edits
  4 adds
  1 delete in trunk

Image referrerpolicy mutations should be considered "relevant mutations"
​https://bugs.webkit.org/show_bug.cgi?id=209970

Patch by Rob Buis <​rbuis@igalia.com> on 2020-06-17
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Import latest version of relevant-mutations.html.
Because original-referrer-policy-applied.sub.html is older and assumes referrerpolicy is not a relevant
mutation, remove it and replace it by imported image-loading-lazy-referrerpolicy-change.sub.html.

• web-platform-tests/html/semantics/embedded-content/resources/common.js: Added.

(ElementLoadPromise):
(ElementLoadPromise.prototype.element):
(is_image_fully_loaded):

• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub-expected.txt: Added.
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub.html: Removed.
• web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations-expected.txt: Added.
• web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html:

Source/WebCore:

Make referrerpolicy state changes a relevant mutation [1]. In order to indicate
that we are dealing with a relevant mutation add an enum to updateFromElement, in
order to run "update the image data" algorithm [2] in case it is a relevant mutation.

Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html

imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html

[1] ​https://html.spec.whatwg.org/#reacting-to-dom-mutations:attr-img-referrerpolicy
[2] ​https://html.spec.whatwg.org/#when-to-obtain-images

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::attributeChanged):

• html/HTMLImageElement.h:
• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::updateFromElementIgnoringPreviousError):
(WebCore::ImageLoader::loadDeferredImage):

• loader/ImageLoader.h:

LayoutTests:

Unskip relevant-mutations.html.

• TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/win/TestExpectations:

10:47 AM Changeset in webkit [263166] by aakash_jain@apple.com

• 9 edits
  1 delete in trunk/Tools

Delete code for old ews webkitpy queue
​https://bugs.webkit.org/show_bug.cgi?id=213299

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/common/config/ews.json:
• Scripts/webkitpy/common/net/generictestresults.py:

(WebkitpyTestResults): Deleted.

• Scripts/webkitpy/tool/bot/patchanalysistask.py:
• Scripts/webkitpy/tool/bot/webkitpytestresultsreader.py: Removed.
• Scripts/webkitpy/tool/commands/earlywarningsystem.py:
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(TestWebkitpyEWS): Deleted.
(AbstractEarlyWarningSystemTest.test_failing_webkitpy_tests_message): Deleted.

• Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
• Scripts/webkitpy/tool/steps/runtests.py:

(RunTests._run_webkitpy_tests): Deleted.

• Scripts/webkitpy/tool/steps/steps_unittest.py:

(test_runtests_webkitpy): Deleted.
(test_patch_not_relevant_bindings): Deleted.
(test_runtests_api_debug): Deleted.

10:31 AM Changeset in webkit [263165] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, avoid node access in link-task
​https://bugs.webkit.org/show_bug.cgi?id=213266
<rdar://problem/64453001>

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCheckJSCast):

10:28 AM Changeset in webkit [263164] by keith_miller@apple.com

• 3 edits
  2 adds in trunk

WebKitTestRunner should not crash on alert with invalid utf16 strings
​https://bugs.webkit.org/show_bug.cgi?id=213269

Reviewed by Simon Fraser.

Tools:

• WebKitTestRunner/StringFunctions.h:

(WTR::toWTFString):

LayoutTests:

• fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash-expected.txt: Added.
• fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html: Added.

10:23 AM Changeset in webkit [263163] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix internal macOS build after r263157.

• rendering/RenderThemeMac.mm:

10:10 AM Changeset in webkit [263162] by Ryan Haddad

• 2 edits in trunk/LayoutTests

REGRESSION (r263098): [Win10] http/tests/security/cross-origin-clean-css-resource-timing.html and http/tests/security/cross-origin-css-resource-timing.html are failing
​https://bugs.webkit.org/show_bug.cgi?id=213303

Unreviewed test gardening.

• platform/win/TestExpectations: Mark tests as failing.

10:06 AM Changeset in webkit [263161] by Alan Coon

• 3 edits in branches/safari-609-branch/Source/ThirdParty/libwebrtc

Cherry-pick r263154. rdar://problem/64452498

Improve SCTP cookie generation
​https://bugs.webkit.org/show_bug.cgi?id=213284
<rdar://problem/64438133>

Reviewed by Eric Carlson.

• Source/webrtc/media/sctp/sctp_transport.cc:
• Source/webrtc/media/sctp/sctp_transport.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@263154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:56 AM Changeset in webkit [263160] by weinig@apple.com

• 172 edits in trunk/Source/WebCore

Use constructor operations in WebIDL
​https://bugs.webkit.org/show_bug.cgi?id=201397

Reviewed by Eric Carlson.

Add support for constructor syntax in WebIDL (​https://heycam.github.io/webidl/#idl-constructors)

• [Constructor(...)] extended attributes become constructor(...) operations
• [JSBuiltinConstructor] becomes [JSBuiltin] constructor(...)
• [CustomConstructor] becomes [Custom] constructor(...)
• [ConstructorMayThrowException] becomes [MayThrowException] constructor(...) and can now be unique per-overload
• [ConstructorCallWith=Foo] becomes [CallWith=Foo] constructor(...) and can now also be unique per-overload

This change leaves NamedConstructor as is, but a subsequent change will replace it with the
specified LegacyFactoryFunction extended attribute.

• Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl:
• Modules/applepay/ApplePayError.idl:
• Modules/applepay/ApplePaySession.idl:
• Modules/applepay/ApplePaySetup.idl:
• Modules/async-clipboard/ClipboardItem.idl:
• Modules/encryptedmedia/MediaKeyMessageEvent.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeys.idl:
• Modules/fetch/FetchHeaders.idl:
• Modules/fetch/FetchRequest.idl:
• Modules/fetch/FetchResponse.idl:
• Modules/gamepad/GamepadEvent.idl:
• Modules/highlight/HighlightMap.idl:
• Modules/highlight/HighlightRangeGroup.idl:
• Modules/indexeddb/IDBVersionChangeEvent.idl:
• Modules/mediarecorder/BlobEvent.idl:
• Modules/mediarecorder/MediaRecorder.idl:
• Modules/mediarecorder/MediaRecorderErrorEvent.idl:
• Modules/mediasession/MediaRemoteControls.idl:
• Modules/mediasession/MediaSession.idl:
• Modules/mediasource/MediaSource.idl:
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/MediaStreamTrackEvent.idl:
• Modules/mediastream/OverconstrainedError.idl:
• Modules/mediastream/OverconstrainedErrorEvent.idl:
• Modules/mediastream/RTCDTMFToneChangeEvent.idl:
• Modules/mediastream/RTCDataChannelEvent.idl:
• Modules/mediastream/RTCIceCandidate.idl:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCPeerConnectionIceEvent.idl:
• Modules/mediastream/RTCSessionDescription.idl:
• Modules/mediastream/RTCTrackEvent.idl:
• Modules/notifications/Notification.idl:
• Modules/paymentrequest/MerchantValidationEvent.idl:
• Modules/paymentrequest/PaymentMethodChangeEvent.idl:
• Modules/paymentrequest/PaymentRequest.idl:
• Modules/paymentrequest/PaymentRequestUpdateEvent.idl:
• Modules/pictureinpicture/EnterPictureInPictureEvent.idl:
• Modules/speech/SpeechSynthesisUtterance.idl:
• Modules/streams/ByteLengthQueuingStrategy.idl:
• Modules/streams/CountQueuingStrategy.idl:
• Modules/streams/ReadableByteStreamController.idl:
• Modules/streams/ReadableStream.idl:
• Modules/streams/ReadableStreamBYOBReader.idl:
• Modules/streams/ReadableStreamBYOBRequest.idl:
• Modules/streams/ReadableStreamDefaultController.idl:
• Modules/streams/ReadableStreamDefaultReader.idl:
• Modules/streams/WritableStream.idl:
• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/OfflineAudioContext.idl:
• Modules/webgpu/GPUOutOfMemoryError.idl:
• Modules/webgpu/GPUUncapturedErrorEvent.idl:
• Modules/webgpu/GPUValidationError.idl:
• Modules/websockets/CloseEvent.idl:
• Modules/websockets/WebSocket.idl:
• Modules/webxr/WebXRRigidTransform.idl:
• Modules/webxr/WebXRWebGLLayer.idl:
• Modules/webxr/XRInputSourceEvent.idl:
• Modules/webxr/XRInputSourcesChangeEvent.idl:
• Modules/webxr/XRReferenceSpaceEvent.idl:
• Modules/webxr/XRSessionEvent.idl:
• animation/AnimationPlaybackEvent.idl:
• animation/DocumentTimeline.idl:
• animation/KeyframeEffect.idl:
• animation/WebAnimation.idl:
• bindings/scripts/CodeGeneratorJS.pm:

(ShouldGenerateToJSDeclaration):
(GetFullyQualifiedImplementationCallName):
(GenerateParametersCheck):
(GetConstructorTemplateClassName):
(GenerateConstructorDefinition):
(GenerateConstructorHelperMethods):
(HasCustomConstructor):
(IsConstructable):
(HasJSBuiltinConstructor):
(AddJSBuiltinIncludesIfNeeded):
(IsJSBuiltinConstructor): Deleted.

• bindings/scripts/IDLAttributes.json:
• bindings/scripts/IDLParser.pm:

(assertExtendedAttributesValidForContext):
(copyExtendedAttributes):
(cloneOperation):
(applyTypedefs):
(parseInterfaceMember):
(parseConstructor):
(parseExtendedAttributeRest):
(applyMemberList):
(applyExtendedAttributeList):

• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::initializeProperties):
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
(WebCore::JSTestNamedConstructorNamedConstructor::initializeProperties):

• bindings/scripts/test/TestClassWithJSBuiltinConstructor.idl:
• bindings/scripts/test/TestEventConstructor.idl:
• bindings/scripts/test/TestInterface.idl:
• bindings/scripts/test/TestJSBuiltinConstructor.idl:
• bindings/scripts/test/TestNamedConstructor.idl:
• bindings/scripts/test/TestNode.idl:
• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/TestOverloadedConstructors.idl:
• bindings/scripts/test/TestOverloadedConstructorsWithSequence.idl:
• bindings/scripts/test/TestPromiseRejectionEvent.idl:
• bindings/scripts/test/TestTypedefs.idl:
• css/DOMMatrix.idl:
• css/DOMMatrixReadOnly.idl:
• css/FontFace.idl:
• css/FontFaceSet.idl:
• css/MediaQueryListEvent.idl:
• css/WebKitCSSMatrix.idl:
• css/typedom/TypedOMCSSUnitValue.idl:
• css/typedom/TypedOMCSSUnparsedValue.idl:
• dom/AbortController.idl:
• dom/AnimationEvent.idl:
• dom/BeforeLoadEvent.idl:
• dom/ClipboardEvent.idl:
• dom/Comment.idl:
• dom/CompositionEvent.idl:
• dom/CustomEvent.idl:
• dom/DOMException.idl:
• dom/DOMPoint.idl:
• dom/DOMPointReadOnly.idl:
• dom/DOMQuad.idl:
• dom/DOMRect.idl:
• dom/DOMRectReadOnly.idl:
• dom/Document.idl:
• dom/DocumentFragment.idl:
• dom/DragEvent.idl:
• dom/ErrorEvent.idl:
• dom/Event.idl:
• dom/EventTarget.idl:
• dom/FocusEvent.idl:
• dom/HashChangeEvent.idl:
• dom/InputEvent.idl:
• dom/KeyboardEvent.idl:
• dom/MessageChannel.idl:
• dom/MessageEvent.idl:
• dom/MouseEvent.idl:
• dom/MutationObserver.idl:
• dom/OverflowEvent.idl:
• dom/PageTransitionEvent.idl:
• dom/PointerEvent.idl:
• dom/PopStateEvent.idl:
• dom/ProgressEvent.idl:
• dom/PromiseRejectionEvent.idl:
• dom/Range.idl:
• dom/SecurityPolicyViolationEvent.idl:
• dom/StaticRange.idl:
• dom/Text.idl:
• dom/TextDecoder.idl:
• dom/TextEncoder.idl:
• dom/TransitionEvent.idl:
• dom/UIEvent.idl:
• dom/WebKitAnimationEvent.idl:
• dom/WebKitTransitionEvent.idl:
• dom/WheelEvent.idl:
• fileapi/Blob.idl:
• fileapi/File.idl:
• fileapi/FileReader.idl:
• fileapi/FileReaderSync.idl:
• html/DOMFormData.idl:
• html/DOMURL.idl:
• html/HTMLElement.idl:
• html/HTMLOptionElement.idl:
• html/ImageData.idl:
• html/MediaController.idl:
• html/MediaEncryptedEvent.idl:
• html/OffscreenCanvas.idl:
• html/URLSearchParams.idl:
• html/canvas/Path2D.idl:
• html/canvas/WebGLContextEvent.idl:
• html/track/DataCue.idl:
• html/track/TextTrackCue.idl:
• html/track/TrackEvent.idl:
• html/track/VTTCue.idl:
• html/track/VTTRegion.idl:
• page/EventSource.idl:
• page/IntersectionObserver.idl:
• page/IntersectionObserverEntry.idl:
• page/PerformanceObserver.idl:
• page/ResizeObserver.idl:
• page/UndoItem.idl:
• page/WebKitPoint.idl:
• storage/StorageEvent.idl:
• workers/Worker.idl:
• workers/service/ExtendableEvent.idl:
• workers/service/ExtendableMessageEvent.idl:
• workers/service/FetchEvent.idl:
• xml/DOMParser.idl:
• xml/XMLHttpRequest.idl:
• xml/XMLSerializer.idl:
• xml/XPathEvaluator.idl:
• xml/XSLTProcessor.idl:

9:55 AM Changeset in webkit [263159] by Alan Bujtas

• 2 edits in trunk/LayoutTests

[Win] Unreviewed test gardening.

• platform/win/TestExpectations:

9:54 AM Changeset in webkit [263158] by aestes@apple.com

• 2 edits in trunk/Source/WebCore/PAL

Another unreviewed build fix after r263150

• pal/spi/cocoa/PassKitSPI.h:

9:51 AM Changeset in webkit [263157] by commit-queue@webkit.org

• 42 edits
  2 copies
  1 add in trunk

IndexedDB: Support IDBFactory databases method
​https://bugs.webkit.org/show_bug.cgi?id=211043

Patch by Darryl Pogue <​darryl@dpogue.ca> on 2020-06-17
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Adjust test expectations for IDBFactory.prototype.databases().

• web-platform-tests/IndexedDB/get-databases.any-expected.txt:
• web-platform-tests/IndexedDB/get-databases.any.worker-expected.txt:
• web-platform-tests/IndexedDB/idbfactory-databases-opaque-origin-expected.txt:
• web-platform-tests/IndexedDB/idbfactory-origin-isolation-expected.txt:
• web-platform-tests/IndexedDB/idlharness.any-expected.txt:
• web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt:

Source/WebCore:

Add support for fetching the list of IDB database names and versions
from the IDBServer, and expose the functionality as
IDBFactory.prototype.databases().

Spec: ​https://w3c.github.io/IndexedDB/#dom-idbfactory-databases

• Headers.cmake:
• Modules/indexeddb/IDBActiveDOMObject.h:

(WebCore::IDBActiveDOMObject::performCallbackOnOriginThread):

• Modules/indexeddb/IDBDatabaseNameAndVersionRequest.cpp: Added.

(WebCore::IDBDatabaseNameAndVersionRequest::create):
(WebCore::IDBDatabaseNameAndVersionRequest::IDBDatabaseNameAndVersionRequest):
(WebCore::IDBDatabaseNameAndVersionRequest::~IDBDatabaseNameAndVersionRequest):
(WebCore::IDBDatabaseNameAndVersionRequest::complete):
(WebCore::IDBDatabaseNameAndVersionRequest::activeDOMObjectName const):
(WebCore::IDBDatabaseNameAndVersionRequest::virtualHasPendingActivity const):
(WebCore::IDBDatabaseNameAndVersionRequest::stop):

• Modules/indexeddb/IDBDatabaseNameAndVersionRequest.h: Added.
• Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::databases):
(WebCore::IDBFactory::getAllDatabaseNames):

• Modules/indexeddb/IDBFactory.h:
• Modules/indexeddb/IDBFactory.idl:
• Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::connectionToServerLost):
(WebCore::IDBClient::IDBConnectionProxy::getAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionProxy::didGetAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionProxy::forgetActivityForCurrentThread):
(WebCore::IDBClient::IDBConnectionProxy::getAllDatabaseNames): Deleted.

• Modules/indexeddb/client/IDBConnectionProxy.h:
• Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::getAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionToServer::didGetAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionToServer::getAllDatabaseNames): Deleted.
(WebCore::IDBClient::IDBConnectionToServer::didGetAllDatabaseNames): Deleted.

• Modules/indexeddb/client/IDBConnectionToServer.h:
• Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
• Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::didGetAllDatabaseNamesAndVersions):
(WebCore::IDBServer::IDBConnectionToClient::didGetAllDatabaseNames): Deleted.

• Modules/indexeddb/server/IDBConnectionToClient.h:
• Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::getAllDatabaseNamesAndVersions):
(WebCore::IDBServer::IDBServer::getAllDatabaseNames): Deleted.

• Modules/indexeddb/server/IDBServer.h:
• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameAndVersionFromFile):
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromFile): Deleted.

• Modules/indexeddb/server/SQLiteIDBBackingStore.h:
• Modules/indexeddb/shared/IDBDatabaseNameAndVersion.h: Added.

(WebCore::IDBDatabaseNameAndVersion::encode const):
(WebCore::IDBDatabaseNameAndVersion::decode):
(WebCore::IDBDatabaseNameAndVersion::isolatedCopy const):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• inspector/agents/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):

• loader/EmptyClients.cpp:

Source/WebKit:

Plumbing for returning a list of IDB databases and versions.

• NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::didGetAllDatabaseNamesAndVersions):
(WebKit::WebIDBConnectionToClient::didGetAllDatabaseNames): Deleted.

• NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
• NetworkProcess/IndexedDB/WebIDBServer.cpp:

(WebKit::WebIDBServer::getAllDatabaseNamesAndVersions):
(WebKit::WebIDBServer::getAllDatabaseNames): Deleted.

• NetworkProcess/IndexedDB/WebIDBServer.h:
• NetworkProcess/IndexedDB/WebIDBServer.messages.in:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::getAllDatabaseNamesAndVersions):
(WebKit::WebIDBConnectionToServer::didGetAllDatabaseNamesAndVersions):
(WebKit::WebIDBConnectionToServer::getAllDatabaseNames): Deleted.
(WebKit::WebIDBConnectionToServer::didGetAllDatabaseNames): Deleted.

• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:

Source/WebKitLegacy:

Plumbing for returning a list of IDB databases and versions.

• Storage/InProcessIDBServer.cpp:

(InProcessIDBServer::getAllDatabaseNamesAndVersions):
(InProcessIDBServer::didGetAllDatabaseNamesAndVersions):
(InProcessIDBServer::getAllDatabaseNames): Deleted.
(InProcessIDBServer::didGetAllDatabaseNames): Deleted.

• Storage/InProcessIDBServer.h:

9:42 AM Changeset in webkit [263156] by weinig@apple.com

• 8 edits in trunk

[WPT] infrastructure/assumptions/html-elements.html fails due to changes in style when all: initial is used
​https://bugs.webkit.org/show_bug.cgi?id=213171

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• web-platform-tests/infrastructure/assumptions/html-elements-expected.txt:

Update test results.

Source/WebCore:

Update existing test results that now pass.

• css/CSSProperties.json:

Use initialStrokeColor (the default) rather than hardcoding the incorrect currentColor. The spec (and initialStrokeColor)
say this should be transparent.

• style/StyleBuilderCustom.h:

(WebCore::Style::ApplyPropertyBorderImageModifier::applyInitialValue):
Match the mask image NinePieceImage constructor, and set fill to true for mask image slices.

LayoutTests:

• platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

Update test results.

9:24 AM Changeset in webkit [263155] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][Float] Move float avoiders' final position compute next to when the static position is computed
​https://bugs.webkit.org/show_bug.cgi?id=213250

Reviewed by Antti Koivisto.

Now that the float avoider's final position has no dependecy on the computed height, we can
move it all the way up, next to where we computed the static position.

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForAncestors): Deleted.

• layout/blockformatting/BlockFormattingContext.h:

9:24 AM Changeset in webkit [263154] by youenn@apple.com

• 3 edits in trunk/Source/ThirdParty/libwebrtc

Improve SCTP cookie generation
​https://bugs.webkit.org/show_bug.cgi?id=213284
<rdar://problem/64438133>

Reviewed by Eric Carlson.

• Source/webrtc/media/sctp/sctp_transport.cc:
• Source/webrtc/media/sctp/sctp_transport.h:

9:23 AM Changeset in webkit [263153] by graouts@webkit.org

• 5 edits
  2 adds in trunk

[Modern Media Controls] CSS "cursor" property shoud be respected in media controls shadow root
​https://bugs.webkit.org/show_bug.cgi?id=213295
<rdar://problem/61911638>

Reviewed by Timothy Hatcher.

Source/WebCore:

Allow the "cursor" property to be inherited in the media controls shadow root, but still overriden
for interactive objects in the media controls as well as placard text.

Test: media/modern-media-controls/css/cursor.html

• Modules/modern-media-controls/controls/controls-bar.css:

(.controls-bar):

• Modules/modern-media-controls/controls/media-controls.css:

(.media-controls-container):
(.media-controls):

• Modules/modern-media-controls/controls/placard.css:

(.placard .title,):

LayoutTests:

Add a test that checks that setting the "cursor" property on a <video> element also applies to the
media controls in the element's shadow root.

• media/modern-media-controls/css/cursor-expected.txt: Added.
• media/modern-media-controls/css/cursor.html: Added.

9:17 AM Changeset in webkit [263152] by aestes@apple.com

• 2 edits in trunk/Source/WebCore/PAL

Unreviewed build fix after r263150

• pal/spi/cocoa/PassKitSPI.h:

8:59 AM Changeset in webkit [263151] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Add a shiftAndAdd() emitter in AssemblyHelpers.
​https://bugs.webkit.org/show_bug.cgi?id=213255

Reviewed by Michael Saboff.

void shiftAndAdd(RegisterID base, RegisterID index, uint8_t shift, RegisterID dest, Optional<RegisterID> = { });

Emits code to compute: dest = base + index << shift.

• assembler/testmasm.cpp:

(doubleOperands):
(floatOperands):
(int32Operands):
(int64Operands):
(JSC::testShiftAndAdd):
(JSC::run):
(JSC::doubleOperands): Deleted.
(JSC::floatOperands): Deleted.
(JSC::int32Operands): Deleted.
(JSC::int64Operands): Deleted.

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::shiftAndAdd):

8:55 AM Changeset in webkit [263150] by aestes@apple.com

• 30 edits
  2 copies
  1 add in trunk

[Apple Pay] Enable layout tests on more platforms
​https://bugs.webkit.org/show_bug.cgi?id=212955
<rdar://problem/64174156>

Reviewed by Alex Christensen.

Source/WebCore:

Added runtime checks to determine the Apple Pay API version when installments are enabled.

Enabled tests in http/tests/ssl/applepay on iOS.

• Modules/applepay/ApplePayInstallmentConfiguration.idl:
• Modules/applepay/ApplePayInstallmentConfigurationWebCore.h:
• Modules/applepay/ApplePayInstallmentItem.h:
• Modules/applepay/ApplePayInstallmentItem.idl:
• Modules/applepay/ApplePayInstallmentItemType.h:
• Modules/applepay/ApplePayInstallmentItemType.idl:
• Modules/applepay/ApplePayInstallmentRetailChannel.h:
• Modules/applepay/ApplePayInstallmentRetailChannel.idl: Removed uses of

APPLE_PAY_INSTALLMENT_IDENTIFIERS and APPLE_PAY_INSTALLMENT_ITEMS (or replaced with
APPLE_PAY_INSTALLMENTS).

• Modules/applepay/PaymentAPIVersion.h:
• Modules/applepay/cocoa/PaymentAPIVersionCocoa.mm:

(WebCore::PaymentAPIVersion::current): Moved the computation of current API version from
PaymentCoordinatorClient::supportsVersion to here. Added runtime checks to determine the
level of PassKit installments support since we don't have enough information to tell at
compile time.

• Modules/applepay/PaymentCoordinatorClient.cpp:

(WebCore::PaymentCoordinatorClient::supportsVersion): Changed to call
PaymentAPIVersion::current.

• Modules/applepay/PaymentInstallmentConfiguration.mm:

(WebCore::makeNSArrayElement):
(WebCore::createPlatformConfiguration):
(WebCore::PaymentInstallmentConfiguration::create):
(WebCore::PaymentInstallmentConfiguration::applePayInstallmentConfiguration const): Removed
uses of HAVE_PASSKIT_INSTALLMENT_ITEMS and HAVE_PASSKIT_INSTALLMENT_IDENTIFIERS. Used
runtime checks to determine support for PKPaymentInstallmentConfiguration and
PKPaymentInstallmentItem.

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj: Added source files for PaymentAPIVersion.

Source/WebCore/PAL:

PassKit added SPIs for Apple Pay installments over a series of iOS 13 and macOS Catalina
minor updates. WebKit trunk is still built across a range of iOS 13 and macOS Catalina minor
update SDKs that contain none, some, or all of the installment SPIs. It's not possible to
reliably detect the SDK minor version at compile-time, so instead we now use our own SPI
declarations unless we know all minor versions of the major SDK version contain all of the
installments definitions.

• PAL.xcodeproj/project.pbxproj: Added PassKitInstallmentsSPI.h.

• pal/cocoa/PassKitSoftLink.h:
• pal/cocoa/PassKitSoftLink.mm: Used SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL_WITH_EXPORT on both

Mac and iOS to soft-link PKPaymentInstallmentConfiguration and PKPaymentInstallmentItem.

• pal/spi/cocoa/PassKitInstallmentSPI.h: Added. When building against an SDK that is known

to declare the PassKit installments SPIs, this file includes the SPI headers. Otherwise, it
declares the SPIs.

• pal/spi/cocoa/PassKitSPI.h: Moved PassKit installments SPI declarations to

PassKitInstallmentSPI.h.

Source/WTF:

• wtf/PlatformEnableCocoa.h: Removed ENABLE_APPLE_PAY_INSTALLMENT_IDENTIFIERS,

ENABLE_APPLE_PAY_INSTALLMENT_ITEMS, ENABLE_APPLE_PAY_SESSION_V8,
ENABLE_APPLE_PAY_SESSION_V9, and ENABLE_APPLE_PAY_SESSION_V10.

• wtf/PlatformHave.h: Removed HAVE_PASSKIT_INSTALLMENT_IDENTIFIERS and corrected iOS version

checks for HAVE_PASSKIT_INSTALLMENTS.

LayoutTests:

• http/tests/ssl/applepay/ApplePayInstallmentItems.https.html: Changed to fail instead of

time out when API version 9 isn't supported.

• http/tests/ssl/applepay/ApplePayError.html:
• http/tests/ssl/applepay/ApplePaySession.html:
• http/tests/ssl/applepay/ApplePaySessionV3.html:
• http/tests/ssl/applepay/ApplePaySessionV4.html:
• http/tests/ssl/applepay/ApplePaySessionV5.html: Removed a custom element-clicking function

and used UIHelper.activateElement instead.

• platform/ios-wk2/TestExpectations: Un-skipped http/tests/ssl/applepay.

Marked PaymentRequest.https.html as Slow. Marked ApplePayInstallmentItems.https.html as
Failure.

• platform/mac-wk2/TestExpectations: Removed a trailing '/'. Skipped

ApplePayInstallmentItems.https.html on Mojave and marked it as Failure on Catalina.

8:47 AM Changeset in webkit [263149] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][Floats] Remove redundant mapping functions
​https://bugs.webkit.org/show_bug.cgi?id=213249

Reviewed by Antti Koivisto.

It's incorrect to map the entire display box when the height is no even computed yet.

• layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
(WebCore::Layout::FloatingContext::append):
(WebCore::Layout::FloatingContext::absoluteDisplayBoxCoordinates const):
(WebCore::Layout::FloatingContext::mapTopLeftToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapToFloatingStateRoot const): Deleted.
(WebCore::Layout::FloatingContext::mapTopToFloatingStateRoot const): Deleted.

• layout/floats/FloatingContext.h:

8:34 AM Changeset in webkit [263148] by Truitt Savell

• 2 edits in trunk/LayoutTests

[ Catalina WK2 Release ] http/tests/IndexedDB/storage-limit-1.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=213292

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

7:55 AM Changeset in webkit [263147] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

[LFC]Floats] Cleanup FloatAvoider interface
​https://bugs.webkit.org/show_bug.cgi?id=213195

Reviewed by Antti Koivisto.

Remove redundant functions/parameters.

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats):

• layout/floats/FloatAvoider.cpp:

(WebCore::Layout::FloatAvoider::FloatAvoider):
(WebCore::Layout::FloatAvoider::topLeftInContainingBlock const): Deleted.

• layout/floats/FloatAvoider.h:
• layout/floats/FloatingContext.cpp:

(WebCore::Layout::findAvailablePosition):
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
(WebCore::Layout::FloatingContext::positionForFormattingContextRoot const): Deleted.
(WebCore::Layout::FloatingContext::findPositionForFloatBox const): Deleted.

• layout/floats/FloatingContext.h:

7:41 AM Changeset in webkit [263146] by msaboff@apple.com

• 3 edits in trunk/Source/JavaScriptCore

[Wasm] Reduce the amount of memory used by the Air register coloring allocator
​https://bugs.webkit.org/show_bug.cgi?id=212106

Reviewed by Yusuke Suzuki.

Changed InterferenceEdge to be a templated class so we can instantiate an unsigned
short version to cut memory in half for code that has less than 2^{16 temps.
Through instrumentation, my testing showed that almost all compilations use the
16bit implementation. Although this change is for all B3/Air compilations at O2,
Wasm compilations are usally larger and therefore get the greatest benefit.}

This allowed increasing the default value for the option webAssemblyBBQFallbackSize,
with a small increase in memory usage.

• b3/air/AirAllocateRegistersByGraphColoring.cpp:
• runtime/OptionsList.h:

7:25 AM Changeset in webkit [263145] by Diego Pino Garcia

• 10 edits
  1 delete in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update baselines and test expectations after r263143.

• platform/glib/svg/custom/svg-fonts-in-text-controls-expected.txt:
• platform/gtk/TestExpectations:
• platform/gtk/accessibility/form-control-value-settable-expected.txt:
• platform/gtk/accessibility/roles-exposed-expected.txt:
• platform/gtk/fast/css/line-height-expected.txt:
• platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/gtk/fast/forms/searchfield-heights-expected.txt:
• platform/gtk/http/tests/plugins/plugin-javascript-access-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/css/css-color/animation/opacity-interpolation-expected.txt:
• platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:

7:05 AM Changeset in webkit [263144] by Alan Bujtas

• 7 edits
  2 deletes in trunk/Source/WebCore

[LFC][Floats] Remove FloatBox class
​https://bugs.webkit.org/show_bug.cgi?id=213184

Reviewed by Antti Koivisto.

Apparently the only difference between a non-floating float avoider (regular formatting context root)
and a float box is that while float boxes intersect their margin box, simple float avoiders use their border box.
We can do that without subclassing FloatAvoider.

This patch is also in preparation for moving "computeFloatPosition" next to the static position computation when
the height value is not computed yet. So instead of passing in the display box, let's just pass in top/left and width.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• layout/floats/FloatAvoider.cpp:

(WebCore::Layout::FloatAvoider::FloatAvoider):
(WebCore::Layout::FloatAvoider::setHorizontalPosition):
(WebCore::Layout::FloatAvoider::setVerticalPosition):
(WebCore::Layout::FloatAvoider::initialHorizontalPosition const):
(WebCore::Layout::FloatAvoider::overflowsContainingBlock const):
(WebCore::Layout::FloatAvoider::topLeftInContainingBlock const):
(WebCore::Layout::FloatAvoider::setHorizontalConstraints): Deleted.
(WebCore::Layout::FloatAvoider::setVerticalConstraint): Deleted.
(WebCore::Layout::FloatAvoider::horizontalPositionCandidate): Deleted.
(WebCore::Layout::FloatAvoider::verticalPositionCandidate): Deleted.
(WebCore::Layout::FloatAvoider::rectInContainingBlock const): Deleted.

• layout/floats/FloatAvoider.h:

(WebCore::Layout::FloatAvoider::resetHorizontalPosition):
(WebCore::Layout::FloatAvoider::isLeftAligned const):
(WebCore::Layout::FloatAvoider::borderBoxWidth const):
(WebCore::Layout::FloatAvoider::marginBefore const):
(WebCore::Layout::FloatAvoider::marginAfter const):
(WebCore::Layout::FloatAvoider::marginStart const):
(WebCore::Layout::FloatAvoider::marginEnd const):
(WebCore::Layout::FloatAvoider::marginBoxWidth const):
(WebCore::Layout::FloatAvoider::isFloatingBox const):
(WebCore::Layout::FloatAvoider::layoutBox const):
(WebCore::Layout::FloatAvoider::top const):
(WebCore::Layout::FloatAvoider::left const):
(WebCore::Layout::FloatAvoider::right const):
(WebCore::Layout::FloatAvoider::rect const): Deleted.
(WebCore::Layout::FloatAvoider::displayBox const): Deleted.
(WebCore::Layout::FloatAvoider::displayBox): Deleted.

• layout/floats/FloatBox.cpp: Removed.
• layout/floats/FloatBox.h: Removed.
• layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForFormattingContextRoot const):
(WebCore::Layout::findAvailablePosition):
(WebCore::Layout::FloatingContext::findPositionForFloatBox const):
(WebCore::Layout::FloatingContext::findPositionForFormattingContextRoot const):
(WebCore::Layout::FloatPair::intersects const):
(WebCore::Layout::FloatPair::horizontalConstraints const):

• layout/floats/FloatingContext.h:

4:34 AM Changeset in webkit [263143] by aakash_jain@apple.com

• 7 edits in trunk/Tools

Delete old ews client side code - part 2
​https://bugs.webkit.org/show_bug.cgi?id=213262

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/common/net/bugzilla/attachment.py:
• Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTaskDelegate.command_passed): Deleted.
(PatchAnalysisTaskDelegate.command_failed): Deleted.

• Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.command_passed): Deleted.
(AbstractEarlyWarningSystem.command_failed): Deleted.

• Scripts/webkitpy/tool/commands/perfalizer.py:

(PerfalizerTask.command_passed): Deleted.
(PerfalizerTask.command_failed): Deleted.

• Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
• Scripts/webkitpy/tool/commands/queues.py:

(AbstractPatchQueue._next_patch): Deleted.
(AbstractPatchQueue._did_error): Deleted.
(AbstractPatchQueue._did_skip): Deleted.
(AbstractPatchQueue._unlock_patch): Deleted.
(StyleQueue.command_passed): Deleted.
(StyleQueue.command_failed): Deleted.

2:34 AM Changeset in webkit [263142] by Paulo Matos

• 2 edits in trunk/Tools

Add new Igalia EWS workers for ARM/MIPS
​https://bugs.webkit.org/show_bug.cgi?id=212803

Reviewed by Aakash Jain.

• BuildSlaveSupport/ews-build/config.json:

1:55 AM Changeset in webkit [263141] by youenn@apple.com

• 9 edits in trunk

Make ReadableStream robust against user code
​https://bugs.webkit.org/show_bug.cgi?id=212915
<rdar://problem/64133221>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

We now get pull/cancel only once from the source.

• web-platform-tests/streams/readable-streams/bad-underlying-sources-expected.txt:
• web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker-expected.txt:
• web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:

Source/WebCore:

Create tee source with private slots instead of public ones.
When source has one of this private slot, we directly go to the creation of a ReadableStream.
Covered by existing tests.

• Modules/streams/ReadableStream.js:

(initializeReadableStream):

• Modules/streams/ReadableStreamInternals.js:

(setupReadableStreamDefaultController):
(readableStreamTee):
(readableStreamDefaultControllerCallPullIfNeeded):
(readableStreamDefaultControllerCancel):

• Modules/streams/StreamInternals.js:

(promiseInvokeOrNoopMethodNoCatch):
(promiseInvokeOrNoopNoCatch):
(promiseInvokeOrNoopMethod):
(promiseInvokeOrNoop):

• bindings/js/WebCoreBuiltinNames.h:

1:52 AM Changeset in webkit [263140] by Antti Koivisto

• 6 edits in trunk/Source/WebCore

Fix spelling of evaluteDynamicMediaQueryRules
​https://bugs.webkit.org/show_bug.cgi?id=213287

Unreviewed.

• style/RuleSet.cpp:

(WebCore::Style::RuleSet::addRulesFromSheet):
(WebCore::Style::RuleSet::evaluateDynamicMediaQueryRules):
(WebCore::Style::RuleSet::evaluteDynamicMediaQueryRules): Deleted.

• style/RuleSet.h:
• style/StyleResolver.cpp:

(WebCore::Style::Resolver::evaluateDynamicMediaQueries):

• style/StyleScopeRuleSets.cpp:

(WebCore::Style::ScopeRuleSets::evaluateDynamicMediaQueryRules):
(WebCore::Style::ScopeRuleSets::evaluteDynamicMediaQueryRules): Deleted.

• style/StyleScopeRuleSets.h:

1:17 AM Changeset in webkit [263139] by Diego Pino Garcia

• 2 edits in trunk/Source/WebCore

REGRESSION(r262994): [GTK] More than 100 tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=213173

Unreviewed gardening.

Add default initialization for WebCore::PluginInfo::clientLoadPolicy and
WebCore::PluginInfo::isApplicationPlugin.

• plugins/PluginData.h:

12:29 AM Changeset in webkit [263138] by commit-queue@webkit.org

• 2 edits in trunk

REGRESSION(r260760): ENABLE_GRAPHICS_CONTEXT_GL should be ON, not TRUE
​https://bugs.webkit.org/show_bug.cgi?id=212057

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-06-17
Reviewed by Carlos Garcia Campos.

This is already set by feature policy. Don't clobber it.

• Source/cmake/OptionsGTK.cmake:

Jun 16, 2020:

11:48 PM Changeset in webkit [263137] by Simon Fraser

• 7 edits
  2 adds in trunk

REGRESSION (r255037): Broken position while comparing watch bands on www.apple.com/shop/studio/apple-watch
​https://bugs.webkit.org/show_bug.cgi?id=213282
Source/WebCore:

Reviewed by Antti Koivisto.

Test: fast/scrolling/ios/user-then-programmatic-scroll.html

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::applyLayerPositionsAfterCommit):

• page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::setNeedsApplyLayerPositionsAfterCommit):
(WebCore::ScrollingTree::didScrollByDelegatedScrolling): Deleted.

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::wasScrolledByDelegatedScrolling):

Source/WebKit:

<rdar://problem/63862940>

Reviewed by Antti Koivisto.

If a scrolling tree commit has a requested scroll position update for a node, we need
to call applyLayerPositons() to set the UIScrollView's contentOffset.

Often the layer tree commit will contain a boundsOrigin change for the layer in question
(which is equivalent to setting the UIScrollView's contentOffset), but some combinations of
user and programmatic scrolling result in no boundsOrigin change, revealing the bug.

• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateAfterChildren):

LayoutTests:

<rdar://problem/63862940>

Reviewed by Antti Koivisto.

• fast/scrolling/ios/user-then-programmatic-scroll-expected.html: Added.
• fast/scrolling/ios/user-then-programmatic-scroll.html: Added.

9:11 PM Changeset in webkit [263136] by Alan Bujtas

• 3 edits
  2 adds in trunk

[Subpixel] Replaced content bleeds over content box when border radius is set
​https://bugs.webkit.org/show_bug.cgi?id=213275
<rdar://problem/64320995>

Reviewed by Simon Fraser.

Source/WebCore:

Snap the border to device pixels on the replaced box when border radius is set.

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

LayoutTests:

• fast/images/hidpi-image-position-on-device-pixels-with-border-radius-expected.html: Added.
• fast/images/hidpi-image-position-on-device-pixels-with-border-radius.html: Added.

8:09 PM Changeset in webkit [263135] by mmaxfield@apple.com

• 6 edits in trunk/LayoutTests

Make fast/ruby/ruby-expansion tests more robust
<rdar://problem/59688895>

Unreviewed test gardening.

Update the tests to no longer be sensitive to arbitrary fallback font metrics.

• fast/ruby/ruby-expansion-cjk-2.html:
• fast/ruby/ruby-expansion-cjk-3.html:
• fast/ruby/ruby-expansion-cjk-4.html:
• fast/ruby/ruby-expansion-cjk.html:
• platform/mac-wk1/TestExpectations:

7:30 PM Changeset in webkit [263134] by ysuzuki@apple.com

• 34 edits
  2 adds in trunk

[JSC] Check NullSetterFunction under strict-mode context since structure / PropertyCondition are unaware of this
​https://bugs.webkit.org/show_bug.cgi?id=213266

Reviewed by Mark Lam.

JSTests:

• stress/null-setter-frame.js: Added.

(shouldBe):
(realm.runString.test):
(object.get value):
(i.catch):

• stress/setter-throw-in-strict.js: Added.

(foo):

Source/JavaScriptCore:

Our PropertyCondition is tracking the shape of Structure. This is enough for IC except for one case: throwing an error when invoking null setters in strict code.

"use strict";
var object = { get value() { return 42; } }
object.value = 42;

In the above case, we need to throw an error. Let's consider the following scenario.

1. Object has valid setter.
2. IC is buffering OPC which includes (1)'s object in Prototype hit.
3. IC commits buffered AccessCase with OPC. And PropertyCondition says Object + setter-offset => Presence.
4. Object deletes its setter.
5. Just after (4), DFG concurrently reads buffered committed OPCs.
6. DFG see that PropertyCondition is valid even after (4) since accessor property does exist.
7. Set up DFG sequence GetSetter, Call.
8. DFG calls null-setter under strict code, which is not assumed to be called.

In this patch, we insert NullSetterFunction check before setter invocation under strict mode. In IC, if we see NullSetterFunction,
we replace the calling target with special function which throws an error. In DFG / FTL, we emit CheckNotJSCast DFG node which
ensures that this setter is not null setter.

In IC code, we already have null-setter checking code before. So this change does not have any impact in terms of performance.
In DFG / FTL code, we only insert this check when we do not inline this setter. This is because inlining emits CheckCell anyway so
we can know that this is not NullSetterFunction. And this means that DFG Call opcode exists after CheckNotJSCast. Since Call opcode
loads the fields of call target anyway, this also does not affect on performance.

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

• bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

• bytecode/PolymorphicAccess.h:

(JSC::AccessGenerationState::AccessGenerationState):

• bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::addAccessCase):

• bytecode/StructureStubInfo.h:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handlePutById):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasClassInfo const):

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCheckJSCast):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGStructureAbstractValue.cpp:

(JSC::DFG::StructureAbstractValue::isNotSubClassOf const):

• dfg/DFGStructureAbstractValue.h:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckJSCast):

• jit/Repatch.cpp:

(JSC::tryCacheGetBy):
(JSC::tryCacheArrayGetByVal):
(JSC::tryCachePutByID):
(JSC::tryCacheDeleteBy):
(JSC::tryCacheInByID):
(JSC::tryCacheInstanceOf):

• jit/ThunkGenerators.cpp:

(JSC::virtualThunkFor):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):

• runtime/JSCast.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::nullSetterStrictFunction const):

• runtime/JSType.cpp:

(WTF::printInternal):

• runtime/JSType.h:
• runtime/NullSetterFunction.cpp:

(JSC::NullSetterFunctionInternal::callThrowError):
(JSC::NullSetterFunction::NullSetterFunction):

• runtime/NullSetterFunction.h:

7:15 PM Changeset in webkit [263133] by mark.lam@apple.com

• 2 edits in trunk/Tools

TestWebKitAPI.WebCore.WildcardStringMatching needs to initialize Options before accessing them.
​https://bugs.webkit.org/show_bug.cgi?id=213270
<rdar://problem/64427499>

Reviewed by Yusuke Suzuki.

• TestWebKitAPI/Tests/WebCore/StringUtilities.mm:

(TestWebKitAPI::TEST):

6:34 PM Changeset in webkit [263132] by Wenson Hsieh

• 4 edits in trunk

Text manipulation should not re-extract elements whose children have been manipulated
​https://bugs.webkit.org/show_bug.cgi?id=213276
<rdar://problem/64193446>

Reviewed by Tim Horton.

Source/WebCore:

After an element has undergone text manipulation, we have a mechanism for not extracting that element again,
if the element is later hidden and shown, or relocated in the DOM. This works by adding the inserted text
manipulation node to a weak element map (m_manipulatedElements) if the inserted node is an element. However,
this mechanism is bypassed in the case where text nodes are inserted, since these child nodes are not elements.
This means that if the element containing this manipulated text is hidden and later shown, we'll attempt to re-
extract its contents, which is problematic for text manipulation clients.

To mitigate this, when inserting content during text manipulation, if a new parent of the inserted content
contains _only_ manipulated child nodes, then avoid trying to manipulate it in the future by adding it to
m_manipulatedElements.

Test: TextManipulation.CompleteTextManipulationAvoidExtractingManipulatedTextAfterManipulation

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::updateInsertions):

Drive-by style fix: add a space after the assignment operator.

(WebCore::TextManipulationController::replace):

If the parent node that we're inserting a text manipulation node underneath has only 1 child (i.e. the node that
we've just inserted), then flag it as having only manipulated children. This parent may be un-flagged later when
applying NodeInsertions, if the NodeInsertion's child has not been manipulated.

Tools:

Add a new API test where we start and complete text manipulation, and then hide and show the manipulated
element. This test verifies that the new item callbacks are *not* called after element is shown again.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

6:17 PM Changeset in webkit [263131] by dino@apple.com

• 6 edits
  2 adds
  1 delete in trunk

Add a dynamic library target for ANGLE
​https://bugs.webkit.org/show_bug.cgi?id=207591

Reviewed by Tim Horton.

In preparation for moving to a dynamic library, start
by compiling and linking it. It isn't used anywhere
but getting it into the build will help Apple's
build system remain happy as we migrate, as well
as have the system know it exists for building
the shared system cache.

.:

• WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

Source/ThirdParty/ANGLE:

• ANGLE.xcodeproj/project.pbxproj:
• Configurations/ANGLE-dynamic.xcconfig: Added.
• Configurations/ANGLE-static.xcconfig: Added.
• Configurations/ANGLE.xcconfig: Removed.
• Configurations/Base.xcconfig:
• Configurations/DebugRelease.xcconfig:

5:59 PM Changeset in webkit [263130] by Russell Epstein

• 5 edits
  2 moves in branches/safari-609-branch/Source/WebCore

Cherry-pick r263129. rdar://problem/64428805

FileListCreator should only be used for resolving directories
​https://bugs.webkit.org/show_bug.cgi?id=213259
<rdar://problem/64375709>

Reviewed by David Kilzer.

Depending on whether directories should be resolved, FileListCreator::create would either
synchronously execute its completion handler then return nullptr or asynchronously dispatch
its completion handler then return a non-null RefPtr. Interfaces with sometimes-synchronous
callbacks can be hard to use correctly; e.g., r262962 fixes a problem where
FileInputType::m_fileListCreator was being modified in an unexpected order.

This patch makes the interface between FileInputType and FileListCreator less error-prone
and more explicit by renaming FileListCreator to DirectoryFileListCreator, making its job
solely to create directory FileLists on a background queue, and giving it an explicit start
member function. For non-directories, FileInputType::filesChosen now bypasses
DirectoryFileListCreator and directly converts from Vector<FileChooserFileInfo> to FileList.

Covered by existing tests.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

• html/DirectoryFileListCreator.cpp: Renamed from html/FileListCreator.cpp. (WebCore::createFileList): Removed the template and ShouldResolveDirectories parameter. (WebCore::DirectoryFileListCreator::DirectoryFileListCreator): Moved the work queue dispatching to DirectoryFileListCreator::start. (WebCore::DirectoryFileListCreator::start): Added; moved the work queue dispatching here from the ctor.

• html/DirectoryFileListCreator.h: Renamed from html/FileListCreator.h. (WebCore::DirectoryFileListCreator::create): Stopped performing non-directory creation and changed the return value back to Ref<>.

• html/FileInputType.cpp: (WebCore::FileInputType::filesChosen): Moved most of the work done in the FileListCreator completion handler to didCreateFileList. When !FileInputType::allowsDirectories, used Vector::map to convert paths to a Vector<Ref<File>>, used that to create a FileList, then called didCreateFileList. Otherwise, created and started a DirectoryFileListCreator that calls didCreateFileList in its completion handler. (WebCore::FileInputType::didCreateFileList): Added; sets the new file list and icon and clears m_directoryFileListCreator.

• html/FileInputType.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@263129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:47 PM Changeset in webkit [263129] by aestes@apple.com

• 5 edits
  2 moves in trunk/Source/WebCore

FileListCreator should only be used for resolving directories
​https://bugs.webkit.org/show_bug.cgi?id=213259
<rdar://problem/64375709>

Reviewed by David Kilzer.

Depending on whether directories should be resolved, FileListCreator::create would either
synchronously execute its completion handler then return nullptr or asynchronously dispatch
its completion handler then return a non-null RefPtr. Interfaces with sometimes-synchronous
callbacks can be hard to use correctly; e.g., r262962 fixes a problem where
FileInputType::m_fileListCreator was being modified in an unexpected order.

This patch makes the interface between FileInputType and FileListCreator less error-prone
and more explicit by renaming FileListCreator to DirectoryFileListCreator, making its job
solely to create directory FileLists on a background queue, and giving it an explicit start
member function. For non-directories, FileInputType::filesChosen now bypasses
DirectoryFileListCreator and directly converts from Vector<FileChooserFileInfo> to FileList.

Covered by existing tests.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

• html/DirectoryFileListCreator.cpp: Renamed from html/FileListCreator.cpp.

(WebCore::createFileList): Removed the template and ShouldResolveDirectories parameter.
(WebCore::DirectoryFileListCreator::DirectoryFileListCreator): Moved the work queue
dispatching to DirectoryFileListCreator::start.
(WebCore::DirectoryFileListCreator::start): Added; moved the work queue dispatching here
from the ctor.

• html/DirectoryFileListCreator.h: Renamed from html/FileListCreator.h.

(WebCore::DirectoryFileListCreator::create): Stopped performing non-directory creation and
changed the return value back to Ref<>.

• html/FileInputType.cpp:

(WebCore::FileInputType::filesChosen): Moved most of the work done in the FileListCreator
completion handler to didCreateFileList. When !FileInputType::allowsDirectories, used
Vector::map to convert paths to a Vector<Ref<File>>, used that to create a FileList, then
called didCreateFileList. Otherwise, created and started a DirectoryFileListCreator that
calls didCreateFileList in its completion handler.
(WebCore::FileInputType::didCreateFileList): Added; sets the new file list and icon and
clears m_directoryFileListCreator.

• html/FileInputType.h:

5:44 PM Changeset in webkit [263128] by dino@apple.com

• 5 edits
  2 adds in trunk

REGRESSION (r262643): DumpRenderTree at com.apple.WebCore: WebCore::Document::prepareCanvasesForDisplayIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=213221
rdar://64260400

Reviewed by Simon Fraser.

Source/WebCore:

A Document could still be holding a pointer to an HTMLCanvasElement after the
canvas had been deleted because the CanvasObserver protocol was disconnected
too early. The fix is to explicitly clear the canvas from the Document as it
stops observing.

Test: webgl/preparation-removed-from-document.html

• dom/Document.cpp:

(WebCore::Document::prepareCanvasesForDisplayIfNeeded): Copy the HashSet to a Vector
just in case something weird happens to the set during iteration.
(WebCore::Document::clearCanvasPreparation): Remove the canvas from the list of
of elements that need preparation.

• dom/Document.h: Add the new clearCanvasPreparation method.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::~HTMLCanvasElement): Clear the document.
(WebCore::HTMLCanvasElement::didMoveToNewDocument): Ditto.
(WebCore::HTMLCanvasElement::removedFromAncestor): Ditto.

LayoutTests:

Test that triggers a rendering on a canvas, then rips it out of
the document before drawing.

• webgl/preparation-removed-from-document-expected.txt: Added.
• webgl/preparation-removed-from-document.html: Added.

5:44 PM Changeset in webkit [263127] by dino@apple.com

• 7 edits in trunk/Source/WebCore

[WebGL] Lose the context if IOSurface allocation fails
​https://bugs.webkit.org/show_bug.cgi?id=213265
<rdar://problem/64424742>

Reviewed by Simon Fraser.

If we are unable to allocate the backing store for the WebGL
content, we should immediately lose the context.

• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::reshapeFBOs): Lose the context if the
call to allocateIOSurfaceBackingStore didn't work.

• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::allocateIOSurfaceBackingStore):

• platform/graphics/cocoa/WebGLLayer.h:
• platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer allocateIOSurfaceBackingStoreWithSize:usingAlpha:]): Return a boolean
so that we can detect if the allocation failed.

• platform/graphics/opengl/GraphicsContextGLOpenGL.h:
• platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:

(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):

5:03 PM Changeset in webkit [263126] by Peng Liu

• 3 edits in trunk/LayoutTests

REGRESSION: [iOS wk2] media/modern-media-controls/media-controller/ios/media-controller-stop-updates-in-fullscreen.html is failing consistently
​https://bugs.webkit.org/show_bug.cgi?id=213267

Reviewed by Eric Carlson.

Enable the mock video presentation mode for layout tests and use shouldBecomeEqual() to check
the value of media.webkitDisplayingFullscreen.

• media/modern-media-controls/media-controller/ios/media-controller-stop-updates-in-fullscreen-expected.txt:
• media/modern-media-controls/media-controller/ios/media-controller-stop-updates-in-fullscreen.html:

4:31 PM Changeset in webkit [263125] by mmaxfield@apple.com

• 11 edits in trunk/LayoutTests

Update fast/text/international/system-language/navigator-language tests
<rdar://problem/64047392>

Unreviewed.

Update to new behavior of +[NSLocale minimizedLanguagesFromLanguages:].

• fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt:
• fast/text/international/system-language/navigator-language/navigator-language-en-US.html:
• fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt:
• fast/text/international/system-language/navigator-language/navigator-language-es-ES.html:
• fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt:
• fast/text/international/system-language/navigator-language/navigator-language-es-MX.html:
• fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt:
• fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html:
• fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-expected.txt:
• fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html:

4:29 PM Changeset in webkit [263124] by sbarati@apple.com

• 2 edits in trunk/Tools

Fix two typos "signifcant" and "signficance". Should be "significant" and "significance"

• Scripts/compare-results:

(displayStr):
(computeMultipleHypothesesSignificance):
(dumpBreakdowns):
(writeCSV):
(computeMultipleHypothesesSignficance): Deleted.

4:22 PM Changeset in webkit [263123] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

Fix build with !HAVE(MACHINE_CONTEXT)
​https://bugs.webkit.org/show_bug.cgi?id=213223
<rdar://problem/64390209>

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-06-16
Reviewed by Yusuke Suzuki.

In r263074, I messed up and broke the build with !HAVE(MACHINE_CONTEXT). Even though the
sole purpose of that commit was to fix !HAVE(MACHINE_CONTEXT), I must have somehow messed up
when testing my change.

Anyway, we can just create an empty PlatformRegisters object when HAVE(MACHINE_CONTEXT) is
false. At first, I was worried that passing an empty PlatformRegisters could be open to
misuse, but it's actually hard to misuse it because the only sensible thing you can do with
it is pass it to MachineContext, and you can't use MachineContext outside
HAVE(MACHINE_CONTEXT), so we should be good.

• wtf/threads/Signals.cpp:

(WTF::jscSignalHandler):

3:57 PM Changeset in webkit [263122] by Kate Cheney

• 7 edits in trunk/Source/WebKit

Check for inAppBrowserPrivacyEnabled flag in WebsiteDataStore::initializeAppBoundDomains is expensive and calls a non-static function WebsiteDataStore::parameters().
​https://bugs.webkit.org/show_bug.cgi?id=213261
<rdar://problem/64317084>

Reviewed by Brent Fulgham.

There are two bugs here. First, WebsiteDataStore::parameters()
does a lot of work aside from returning the parameters, making this an
expensive call just to check the value of one flag. Second,
appBoundDomains() is a static hashset, and initializing the hashset
should not rely on non-static functions.

• NetworkProcess/NetworkSessionCreationParameters.cpp:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

• NetworkProcess/NetworkSessionCreationParameters.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
Remove flag, it is no longer used here.

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::platformSetNetworkParameters):
Save the flag value in a member variable so we can use that later
when checking app-bound domains. Rename to something more descriptive.

(WebKit::WebsiteDataStore::initializeAppBoundDomains):
Remove the check for the non-static runtime flag.

(WebKit::WebsiteDataStore::ensureAppBoundDomains const):
Enable test mode quirks. We must do it in two places in case the
initialization hasn't happened by the time we call
ensureAppBoundDomains.

• UIProcess/WebsiteData/WebsiteDataStore.h:

3:41 PM Changeset in webkit [263121] by eric.carlson@apple.com

• 7 edits
  2 adds in trunk

Don't claim to support fullscreen mode unless fullScreenEnabled setting is enabled
​https://bugs.webkit.org/show_bug.cgi?id=213142
<rdar://63753327>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/video-supports-fullscreen.html

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::supportsFullscreen const): Check settings.fullScreenEnabled.

LayoutTests:

• media/video-supports-fullscreen-expected.txt: Added.
• media/video-supports-fullscreen.html: Added.
• media/video-fullscreen-only-playback.html: Don't set fullScreenEnabled to false.

• TestExpectations: Skip the test, it is WK2-only.
• platform/wk2/TestExpectations: Expect the test to pass.

3:36 PM Changeset in webkit [263120] by Andres Gonzalez

• 8 edits in trunk

Fix for accessibility/textarea-selected-text-range.html in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=213257

Reviewed by Chris Fleizach.

Source/WebCore:

accessibility/textarea-selected-text-range.html.

Implementation of AXIsolatedObject::selectedTextRange.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::selectedTextRange const):

• accessibility/isolatedtree/AXIsolatedObject.h:

Tools:

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::setAttributeValue):
(WTR::AccessibilityUIElement::selectedTextRange): Dispatch call into
WebAccessibilityWrapper onto AX secondary thread to simulate isolated
tree mode.

LayoutTests:

• Re-write this test so that it can pass in both isolated tree mode on

and off.

• Replaced shouldBecomeEqual with setTimeout follow by debug because

shouldBecomeEqual causes a thread lock on isolated tree mode.

• accessibility/textarea-selected-text-range-expected.txt:
• accessibility/textarea-selected-text-range.html:

3:23 PM Changeset in webkit [263119] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

Web Inspector: replace completion handler with a function in interception.
​https://bugs.webkit.org/show_bug.cgi?id=213252

Patch by Pavel Feldman <​pavel.feldman@gmail.com> on 2020-06-16
Reviewed by Devin Rousso.

Don't use a CompletionHandler as it asserts that it's been called when it's destroyed.
Both Network.interceptRequestWithResponse and Network.interceptRequestWithError essentially
"skip" the network pipeline, so the CompletionHandler is not invoked for those commands.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::interceptRequestImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::interceptRequest):

• inspector/InspectorInstrumentationWebKit.cpp:

(WebCore::InspectorInstrumentationWebKit::interceptRequestInternal):

• inspector/InspectorInstrumentationWebKit.h:

(WebCore::InspectorInstrumentationWebKit::interceptRequest):

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::interceptRequest):
(WebCore::InspectorNetworkAgent::interceptRequestWithResponse):
(WebCore::InspectorNetworkAgent::interceptRequestWithError):

• inspector/agents/InspectorNetworkAgent.h:

(WebCore::InspectorNetworkAgent::PendingInterceptRequest::PendingInterceptRequest):
(WebCore::InspectorNetworkAgent::PendingInterceptRequest::continueAsHandled):

2:54 PM Changeset in webkit [263118] by commit-queue@webkit.org

• 15 edits in trunk

Added missing position attributes to PannerNode
​https://bugs.webkit.org/show_bug.cgi?id=213151

Patch by Clark Wang <​clark_wang@apple.com> on 2020-06-16
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Re-baselined previous tests that either now pass, or fail at a further stage than before.

• web-platform-tests/webaudio/historical-expected.txt:
• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/ctor-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/pannernode-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/test-pannernode-automation-expected.txt:

Source/WebCore:

Implemented position attributes in PannerNode interface, as per spec:
​https://www.w3.org/TR/webaudio/#pannernode.

Re-baselined tests previous tests that either now pass, or fail at a further stage than before.

• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::position const):
(WebCore::PannerNode::setPosition):
(WebCore::PannerNode::getAzimuthElevation):
(WebCore::PannerNode::dopplerRate):
(WebCore::PannerNode::distanceConeGain):

• Modules/webaudio/PannerNode.h:
• Modules/webaudio/PannerNode.idl:

LayoutTests:

Added change to unprefix PannerNode in web-platform-tests.

• resources/testharnessreport.js:

2:30 PM Changeset in webkit [263117] by mark.lam@apple.com

• 32 edits in trunk/Source

Make Options::useJIT() be the canonical source of truth on whether we should use the JIT.
​https://bugs.webkit.org/show_bug.cgi?id=212556
<rdar://problem/63780436>

Reviewed by Saam Barati.

Source/JavaScriptCore:

After r263055, Options::useJIT() always equals VM::canUseJIT() after canUseJIT()
has been computed. This patch removes VM::canUseJIT(), and replaces all calls to
it with calls to Options::useJIT().

In the old code, VM::canUseJIT() would assert s_canUseJITIsSet to ensure that
its clients will not access s_canUseJIT before it is initialized. We not have an
equivalent mechanism with Options. This is how it works:

1. There are 2 new Options flags in the g_jscConfig:

g_jscConfig.options.isFinalized
g_jscConfig.options.allowUnfinalizedAccess

g_jscConfig.options.isFinalized means that all Options values are finalized
i.e. initialization is complete and ready to be frozen in the Config.

g_jscConfig.options.isFinalized is set by initializeThreading() by calling
Options::finalize() once options initialization is complete.

g_jscConfig.options.allowUnfinalizedAccess is an allowance for clients to
access Options values before they are finalized. This is only needed in
options initialization code where Options values are read and written to.

g_jscConfig.options.allowUnfinalizedAccess is set and cleared using the
Options::AllowUnfinalizedAccessScope RAII object. The few pieces of code that
do options initialization will instantiate this scope object.

2. All Options accessors (e.g. Option::useJIT()) will now assert that either g_jscConfig.options.allowUnfinalizedAccess or g_jscConfig.options.isFinalized is set.

3. Since r263055, Options::recomputeDependentOptions() ensures that if useJIT() is false, all other JIT options (e.g. useBaselineJIT(), useDFTJIT(), useFTLJIT(), etc.) are also false. This patch also adds useBBQJIT() and useOMGJIT() to that list.

With this, checks for useJIT() are now redundant if there's also another JIT
option check, e.g. useRegExpJIT() or useDFGJIT(). When redundant, this patch
elides the useJIT() check (which used to be a VM::canUseJIT() check).

Ideally, we should also introduce a separate abstraction for requested option
values before finalization than the finalized option values that will be adopted
by the system. We'll do this as a separate exercise in a later patch.

• API/tests/ExecutionTimeLimitTest.cpp:

(testExecutionTimeLimit):

• API/tests/FunctionOverridesTest.cpp:

(testFunctionOverrides):

• API/tests/PingPongStackOverflowTest.cpp:

(testPingPongStackOverflow):

• Removed redundant calls to Options::initialize().

• API/tests/testapi.c:

(main):

• move the call to testExecutionTimeLimit() to after finalizeMultithreadedMultiVMExecutionTest() returns. This is because testExecutionTimeLimit() modifies JIT options at runtime as part of its testing. This can wreak havoc on the rest of the system that expects the options to be frozen. Ideally, we'll find a way for testExecutionTimeLimit() to do its work without changing JIT options, but that is not easy to do. For now, we'll just run it at the end as a workaround.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setNumParameters):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfArgumentValueProfiles):
(JSC::CodeBlock::valueProfileForArgument):

• dfg/DFGCapabilities.cpp:

(JSC::DFG::isSupported):

• heap/Heap.cpp:

(JSC::Heap::completeAllJITPlans):
(JSC::Heap::iterateExecutingAndCompilingCodeBlocks):
(JSC::Heap::gatherScratchBufferRoots):
(JSC::Heap::removeDeadCompilerWorklistEntries):
(JSC::Heap::stopThePeriphery):
(JSC::Heap::suspendCompilerThreads):
(JSC::Heap::resumeCompilerThreads):
(JSC::Heap::addCoreConstraints):

• interpreter/AbstractPC.cpp:

(JSC::AbstractPC::AbstractPC):

• jit/JITThunks.cpp:

(JSC::JITThunks::ctiNativeCall):
(JSC::JITThunks::ctiNativeConstruct):
(JSC::JITThunks::ctiNativeTailCall):
(JSC::JITThunks::ctiNativeTailCallWithoutSavedTags):
(JSC::JITThunks::ctiInternalFunctionCall):
(JSC::JITThunks::ctiInternalFunctionConstruct):
(JSC::JITThunks::hostFunctionStub):

• jsc.cpp:

(CommandLine::parseArguments):
(jscmain):

• llint/LLIntEntrypoint.cpp:

(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):
(JSC::LLInt::setModuleProgramEntrypoint):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::shouldJIT):
(JSC::LLInt::jitCompileAndSetHeuristics):

• runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

• runtime/JSCConfig.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::numberToStringWatchpointSet):

• runtime/Options.cpp:

(JSC::jitEnabledByDefault):
(JSC::disableAllJITOptions):

(JSC::Options::initialize):

• Move the calls to dumpOptionsIfNeeded() and ensureOptionsAreCoherent() to the end after all the options have been initialized because this where they belong.

(JSC::Options::finalize):
(JSC::Options::setOptions):
(JSC::Options::setOption):
(JSC::Options::dumpAllOptions):
(JSC::Options::ensureOptionsAreCoherent):

• runtime/Options.h:

(JSC::Options::AllowUnfinalizedAccessScope::AllowUnfinalizedAccessScope):
(JSC::Options::AllowUnfinalizedAccessScope::~AllowUnfinalizedAccessScope):

• runtime/OptionsList.h:
• runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):

• runtime/SymbolTable.h:

(JSC::SymbolTableEntry::isWatchable const):

• runtime/VM.cpp:

(JSC::VM::computeCanUseJIT):
(JSC::VM::VM):
(JSC::VM::getHostFunction):
(JSC::VM::getCTIInternalFunctionTrampolineFor):

• runtime/VM.h:

(JSC::VM::isInMiniMode):
(JSC::VM::canUseJIT): Deleted.

• wasm/WasmCapabilities.h:

(JSC::Wasm::isSupported):

• wasm/WasmOperations.cpp:

(JSC::Wasm::shouldJIT):

• wasm/WasmSlowPaths.cpp:

(JSC::LLInt::shouldJIT):

Source/WebCore:

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::compileSelector):

Source/WebKit:

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::isJITEnabled):

2:17 PM Changeset in webkit [263116] by rmorisset@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Optimize Air::TmpWidth analysis in IRC
​https://bugs.webkit.org/show_bug.cgi?id=152478

Reviewed by Filip Pizlo.

AirTmpWidth currently uses a HashMap to map tmps to their width.
Since tmps have consecutive indices, we can instead use vectors (one for GP and one for FP tmps).
As a bonus, we can just compute the width of the tmps of the bank the register allocator is currently looking at.
This cuts the time spent in the register allocator in JetStream2 by about 100ms out of 3.4s
(or sometimes 80ms out of 2.4, the bimodality of the time spent is due to a huge function in tagcloud-SP which usually but not always reach the FTL, I'll check later if it can be fixed by tweaking the inliner).

• b3/air/AirAllocateRegistersByGraphColoring.cpp:

(JSC::B3::Air::allocateRegistersByGraphColoring):

• b3/air/AirTmpWidth.cpp:

(JSC::B3::Air::TmpWidth::TmpWidth):
(JSC::B3::Air::TmpWidth::recompute):

• b3/air/AirTmpWidth.h:

(JSC::B3::Air::TmpWidth::width const):
(JSC::B3::Air::TmpWidth::requiredWidth):
(JSC::B3::Air::TmpWidth::defWidth const):
(JSC::B3::Air::TmpWidth::useWidth const):
(JSC::B3::Air::TmpWidth::Widths::Widths):
(JSC::B3::Air::TmpWidth::widths):
(JSC::B3::Air::TmpWidth::widths const):
(JSC::B3::Air::TmpWidth::addWidths):
(JSC::B3::Air::TmpWidth::widthsVector):

2:11 PM Changeset in webkit [263115] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Sources: objects in Scope Chain panel flicker when resizing details sidebar
​https://bugs.webkit.org/show_bug.cgi?id=213234
<rdar://problem/64391213>

Reviewed by David Kilzer.

• UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WI.ScopeChainDetailsSidebarPanel.prototype.layout):
Don't regenerate the DOM in layout unless the reason is WI.View.LayoutReason.Dirty, such
as if the current call frame changes or a watch expression is added/updated/removed.

2:09 PM Changeset in webkit [263114] by sbarati@apple.com

• 2 edits in trunk/Tools

Multiple hypothesis testing should use False Discovery Rate instead of Bonferroni
​https://bugs.webkit.org/show_bug.cgi?id=213219

Reviewed by Mark Lam.

My previous patch here used Bonferroni to do multiple hypotheses correction.
Bonferroni does a good job at reducing false positive rate (type I error,
saying something is significant when it's not, e.g, rejecting the null
hypothesis when we shouldn't), but at the expense of also having a high
false negative rate (type II error, saying something is not significant when
it is, e.g, not rejecting the null hypothesis when we should).

After doing a bit more reading, it seems like using a technique called False
Discovery Rate (FDR) is better. It still does a good job at controlling type
I error rate, but without sacrificing a high type II error rate. FDR is based
on a technique for "estimating the proportion of wrongly rejected null hypotheses" [2].

This patch uses Benjamini and Hochberg estimation of FDR, which relies
on hypotheses being independent. We know subtests in a benchmark aren't
fully independent variables, but it's a good enough approximation.

You can read more about FDR:

1. ​https://www.stat.berkeley.edu/~mgoldman/Section0402.pdf
2. ​https://besjournals.onlinelibrary.wiley.com/doi/10.1111/j.2041-210X.2010.00061.x
3. ​https://en.wikipedia.org/wiki/False_discovery_rate

• Scripts/compare-results:

(displayStr):
(computeMultipleHypothesesSignficance):
(dumpBreakdowns):
(writeCSV):

2:03 PM Changeset in webkit [263113] by weinig@apple.com

• 14 edits in trunk

[WPT] form.action does not return document.url when unset (part of ​https://wpt.live/html/dom/reflection-forms.html)
​https://bugs.webkit.org/show_bug.cgi?id=213205

Reviewed by David Kilzer.

LayoutTests/imported/w3c:

• web-platform-tests/html/dom/reflection-forms-expected.txt:
• web-platform-tests/html/semantics/forms/the-form-element/form-action-reflection-expected.txt:
• web-platform-tests/html/semantics/forms/the-form-element/form-action-reflection-with-base-url-expected.txt:

Update test results.

Source/WebCore:

Update existing test results that now pass.

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::formAction const):
Call document.completeURL() directly rather than getURLAttribute() as that
will cause the attribute to have to be looked up again.

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::action const):
Match HTMLFormControlElement::formAction (and the spec) and return the document's
url if the attribute value is missing.

• html/HTMLFormElement.idl:

Remove Reflect/URL extended attributes, as we need custom handling for the empty
case.

LayoutTests:

• platform/gtk/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
• platform/mac/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:

Update test results.

1:42 PM Changeset in webkit [263112] by ddkilzer@apple.com

• 10 edits
  1 add in trunk

REGRESSION (r262994): Web Inspector is killed when context-clicking anywhere
<​https://webkit.org/b/213224>
<rdar://problem/64383320>

Reviewed by Darin Adler.

Source/WebCore:

Test: TestWebKitAPI.WebCore.ContextMenuAction_IsValidEnum

The issue is that using WTF::isValidEnum() with
WTF::EnumTraits<WebCore::ContextMenuAction> didn't explicitly
list all 1000 custom tags, or any application tags (besides the
base), so the unlisted tags were marked as invalid during enum
validation.

The fix is to define a custom validation function for
WebCore::ContextMenuAction enum values.

• platform/ContextMenuItem.h:

(WTF::isValidEnum):

• platform/ContextMenuItem.cpp:

(WebCore::isValidContextMenuAction): Add.

• Validates CustomTag and ApplicationTag ranges.
• platform/ContextMenuItem.h:

(WebCore::isValidContextMenuAction): Add declaration.
(WTF::EnumTraits<WebCore::ContextMenuAction>): Delete.
(WTF::HasCustomIsValidEnum<WebCore::ContextMenuAction>): Add.
(WTF::isValidEnum): Add.

• Call WebCore::isValidContextMenuAction() to validate all enum values.

Source/WebKit:

• Platform/IPC/Decoder.h:
• Platform/IPC/Encoder.h:
• Include <WebCore/ContextMenuItem.h> since the definition of the custom WTF::isValidEnum<WebCore::ContextMenuAction> function is needed.
• Scripts/webkit/messages.py:

(generate_message_names_header):

• Change the third typename in the template for WTF::isValidEnum<IPC::MessageName>() to avoid partial template specialization errors from other implementations like WTF::isValidEnum<WebCore::ContextMenuAction>().
• Also replace hard-coded "IPC::MessageName" names with template values.

Tools:

• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• Add ContextMenuAction.cpp to build systems.
• TestWebKitAPI/Tests/WebCore/ContextMenuAction.cpp: Add.

(TestWebKitAPI::TEST):

• Add TestWebKitAPI.WebCore.ContextMenuAction_IsValidEnum.

1:37 PM Changeset in webkit [263111] by Fujii Hironori

• 19 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening after r263073

• platform/wincairo/editing/inserting/before-after-input-element-expected.txt:
• platform/wincairo/editing/selection/3690703-2-expected.txt:
• platform/wincairo/editing/selection/3690703-expected.txt:
• platform/wincairo/editing/selection/3690719-expected.txt:
• platform/wincairo/editing/selection/4895428-3-expected.txt:
• platform/wincairo/editing/selection/4975120-expected.txt:
• platform/wincairo/editing/selection/drag-select-1-expected.txt:
• platform/wincairo/editing/selection/select-from-textfield-outwards-expected.txt:
• platform/wincairo/fast/css/focus-ring-exists-for-search-field-expected.txt:
• platform/wincairo/fast/css/input-search-padding-expected.txt:
• platform/wincairo/fast/css/line-height-expected.txt:
• platform/wincairo/fast/css/text-overflow-input-expected.txt:
• platform/wincairo/fast/events/context-no-deselect-expected.txt:
• platform/wincairo/fast/html/details-no-summary4-expected.txt:
• platform/wincairo/fast/html/details-open-javascript-expected.txt:
• platform/wincairo/fast/html/details-open2-expected.txt:
• platform/wincairo/fast/html/details-open4-expected.txt:
• platform/wincairo/fast/text/textIteratorNilRenderer-expected.txt:

12:49 PM Changeset in webkit [263110] by Fujii Hironori

• 3 edits in trunk/Tools

[Win] Mouse dragging tests are failing because WebKitTestRunner dispatches WM_MOUSELEAVE to the hidden WebView
​https://bugs.webkit.org/show_bug.cgi?id=213239

Reviewed by Don Olmstead.

There are two problems:

1. Windows EventSenderProxy::mouseMoveTo doesn't set WPARAM of WM_MOUSEMOVE
2. Unexpected WM_MOUSELEAVE discontinues the mouse dragging events

WPARAM of WM_MOUSEMOVE should represent pressed mouse buttons while dragging.

WM_MOUSELEAVE is unexpectedly dispatched because the mouse cursor
is always out of the hidden WebView. The unexpected WM_MOUSELEAVE
discontinues dragging events. WM_MOUSELEAVE shouldn't be
dispatched in WebKitTestRunner. Ignore it.

• WebKitTestRunner/win/EventSenderProxyWin.cpp:

(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo): Set MK_LBUTTON to WPARAM of
WM_MOUSEMOVE while dragging.

• WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::runRunLoopUntil): Ignore WM_MOUSELEAVE.

12:48 PM Changeset in webkit [263109] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

[CMake][Visual Studio] CSSPropertyNames.h is generated twice in WebCore.vcxproj and WebCore_CopyPrivateHeaders.vcxproj
​https://bugs.webkit.org/show_bug.cgi?id=213226

Reviewed by Don Olmstead.

WebCore_CopyPrivateHeaders needs to have a direct or indirect
dependency of WebCore target for CMake Visual Studio generator to
eliminate duplicated custom commands.

• CMakeLists.txt: Added add_dependencies(WebCore_CopyPrivateHeaders WebCore).

12:46 PM Changeset in webkit [263108] by Fujii Hironori

• 2 edits in trunk/Source/JavaScriptCore

[CMake][Visual Studio] CombinedDomains.json is generated twice in JavaScriptCore.vcxproj and InspectorBackendCommands.vcxproj
​https://bugs.webkit.org/show_bug.cgi?id=213225

Reviewed by Don Olmstead.

Since r262203 (Bug 210014) added a new target
InspectorBackendCommands, CombinedDomains.json is generated twice
in JavaScriptCore.vcxproj and InspectorBackendCommands.vcxproj.
This caused unnecessary incremental builds.

The fundamental issue of this issue was fixed in CMake side.
<​https://gitlab.kitware.com/cmake/cmake/issues/16767>
However, JavaScriptCore target needs to have a direct or indirect
dependency of InspectorBackendCommands target for CMake Visual
Studio generator to eliminate duplicated custom commands.

• CMakeLists.txt: Added add_dependencies(JavaScriptCore InspectorBackendCommands).

11:47 AM Changeset in webkit [263107] by Russell Epstein

• 4 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r262739. rdar://problem/64413138

Use usual promise in readableStreamTee
​https://bugs.webkit.org/show_bug.cgi?id=212715

Reviewed by Mark Lam.

The spec[1] is organized to be OK to use usual promises here. This patch uses usual promises instead of internal ones.

[1]: ​https://streams.spec.whatwg.org/#readable-stream-tee

• Modules/streams/ReadableStreamInternals.js: (readableStreamTee):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:46 AM Changeset in webkit [263106] by Russell Epstein

• 3 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r263092. rdar://problem/64412673

O(n^{2) behavior in media query resolution
​https://bugs.webkit.org/show_bug.cgi?id=213243}

Reviewed by Anders Carlsson.

We were traversing all rules in a RuleSet inside a loop over all media queries that change value.
This becomes problematic when you have thousands of media queries.

• style/RuleSet.cpp: (WebCore::Style::RuleSet::evaluteDynamicMediaQueryRules):

Instead collect the rule positions that need flipping into a map and then traverse only once
to do the actual flipping.

Longer term we should maintain a data stucture that can map directly from a position to RuleDatas.
This will require some data structure rethink so this patch takes a simpler approach.

(WebCore::Style::RuleSet::MediaQueryCollector::pop):

• style/RuleSet.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@263092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:46 AM Changeset in webkit [263105] by Russell Epstein

• 2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r262594. rdar://problem/64413274

HTMLAppletElement::updateWidget should check for renderer after the overlapping test.
​https://bugs.webkit.org/show_bug.cgi?id=212789
<rdar://problem/61854614>

Reviewed by Simon Fraser.

createJavaAppletWidget needs to check if the plugin(replacement) is obscured.
Since the overlapping test requires up-to-date geometry, it initiates a top level style recalc/layout.
We need to check if the apple element still has a renderer after the style recalc.

• html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::updateWidget):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:46 AM Changeset in webkit [263104] by Russell Epstein

• 2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r262540. rdar://problem/64413268

Reset fragment line info when the relatively positioned inline box becomes static with block child.
​https://bugs.webkit.org/show_bug.cgi?id=212724
<rdar://problem/62847534>

Reviewed by Simon Fraser.

adjustFragmentedFlowStateOnContainingBlockChangeIfNeeded was missing the case when the
block container was inside an inline box. It happens when the inline box is relatively positioned while the
child block box is absolutely positioned.
RenderFragmentedFlow keeps track of the associated root lineboxes in m_lineToFragmentMap.
In adjustFragmentedFlowStateOnContainingBlockChangeIfNeeded, when the block is no longer part of the fragment
we remove these cached lineboxes from the m_lineToFragmentMap.
This patch fixes the case when the cached lineboxes are generated by a child block box.

• rendering/RenderElement.cpp: (WebCore::RenderElement::adjustFragmentedFlowStateOnContainingBlockChangeIfNeeded):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:30 AM Changeset in webkit [263103] by Diego Pino Garcia

• 108 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update baselines after r263073.

• platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt:
• platform/gtk/editing/inserting/before-after-input-element-expected.txt:
• platform/gtk/editing/pasteboard/4806874-expected.txt:
• platform/gtk/editing/pasteboard/input-field-1-expected.txt:
• platform/gtk/editing/selection/3690703-2-expected.txt:
• platform/gtk/editing/selection/3690703-expected.txt:
• platform/gtk/editing/selection/3690719-expected.txt:
• platform/gtk/editing/selection/4895428-3-expected.txt:
• platform/gtk/editing/selection/4975120-expected.txt:
• platform/gtk/editing/selection/drag-select-1-expected.txt:
• platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
• platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt:
• platform/gtk/fast/css/input-search-padding-expected.txt:
• platform/gtk/fast/css/text-overflow-input-expected.txt:
• platform/gtk/fast/events/context-no-deselect-expected.txt:
• platform/gtk/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt:
• platform/gtk/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:
• platform/gtk/fast/forms/basic-inputs-expected.txt:
• platform/gtk/fast/forms/box-shadow-override-expected.txt:
• platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
• platform/gtk/fast/forms/datalist/datalist-searchinput-appearance-expected.txt:
• platform/gtk/fast/forms/datalist/datalist-textinput-appearance-expected.txt:
• platform/gtk/fast/forms/encoding-test-expected.txt:
• platform/gtk/fast/forms/fieldset-align-expected.txt:
• platform/gtk/fast/forms/fieldset/fieldset-elements-htmlcollection-expected.txt:
• platform/gtk/fast/forms/form-element-geometry-expected.txt:
• platform/gtk/fast/forms/input-align-expected.txt:
• platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
• platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
• platform/gtk/fast/forms/input-appearance-focus-expected.txt:
• platform/gtk/fast/forms/input-appearance-height-expected.txt:
• platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
• platform/gtk/fast/forms/input-appearance-selection-expected.txt:
• platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
• platform/gtk/fast/forms/input-appearance-width-expected.txt:
• platform/gtk/fast/forms/input-baseline-expected.txt:
• platform/gtk/fast/forms/input-disabled-color-expected.txt:
• platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
• platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
• platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
• platform/gtk/fast/forms/input-spaces-expected.txt:
• platform/gtk/fast/forms/input-table-expected.txt:
• platform/gtk/fast/forms/input-text-click-inside-expected.txt:
• platform/gtk/fast/forms/input-text-click-outside-expected.txt:
• platform/gtk/fast/forms/input-text-double-click-expected.txt:
• platform/gtk/fast/forms/input-text-drag-down-expected.txt:
• platform/gtk/fast/forms/input-text-option-delete-expected.txt:
• platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
• platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
• platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
• platform/gtk/fast/forms/input-value-expected.txt:
• platform/gtk/fast/forms/input-width-expected.txt:
• platform/gtk/fast/forms/placeholder-position-expected.txt:
• platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
• platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
• platform/gtk/fast/forms/search-input-rtl-expected.txt:
• platform/gtk/fast/forms/search-styled-expected.txt:
• platform/gtk/fast/forms/search/search-size-with-decorations-expected.txt:
• platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
• platform/gtk/fast/forms/text-control-intrinsic-widths-expected.txt:
• platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
• platform/gtk/fast/forms/textfield-outline-expected.txt:
• platform/gtk/fast/forms/textfield-overflow-expected.txt:
• platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
• platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
• platform/gtk/fast/html/details-no-summary4-expected.txt:
• platform/gtk/fast/html/details-open-javascript-expected.txt:
• platform/gtk/fast/html/details-open2-expected.txt:
• platform/gtk/fast/html/details-open4-expected.txt:
• platform/gtk/fast/lists/dynamic-marker-crash-expected.txt:
• platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
• platform/gtk/fast/repaint/search-field-cancel-expected.txt:
• platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
• platform/gtk/fast/replaced/replaced-breaking-expected.txt:
• platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
• platform/gtk/fast/table/colspanMinWidth-expected.txt:
• platform/gtk/fast/table/spanOverlapRepaint-expected.txt:
• platform/gtk/fast/table/text-field-baseline-expected.txt:
• platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
• platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
• platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
• platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
• platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
• platform/gtk/svg/hixie/mixed/003-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug59354-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
• platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
• platform/gtk/tables/mozilla/other/move_row-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
• platform/gtk/transforms/3d/general/perspective-non-layer-expected.txt:

11:21 AM Changeset in webkit [263102] by Russell Epstein

• 8 edits in branches/safari-609-branch/Source

Versioning.

WebKit-609.3.5

11:11 AM Changeset in webkit [263101] by Wenson Hsieh

• 4 edits in trunk

Text manipulation should handle nested item boundary elements
​https://bugs.webkit.org/show_bug.cgi?id=213251
<rdar://problem/63371514>

Reviewed by Sihui Liu.

Source/WebCore:

In the case where there are nested item boundary elements (e.g. block-level list items or links), text
manipulation will currently only observe that we've crossed the top-level item boundary, and proceed to extract
text from the nested boundary elements as tokens in the same item.

Address this by maintaining a stack of boundary elements rather than just a single item. Additionally, create
and add an item when crossing into a new item boundary, rather than only when we exit a boundary; this handles
the case where we descend from one boundary element into another boundary element that is a child.

Test: TextManipulation.StartTextManipulationTreatsNestedInlineBlockListItemsAndLinksAsParagraphs

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::observeParagraphs):

Tools:

Add a new API test to exercise this scenario.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

11:10 AM Changeset in webkit [263100] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Stop calling userPreferredLanguages() in the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=213214
<rdar://problem/64317593>

Reviewed by Darin Adler.

Follow-up to r263094 to address post-landing feedback from Darin.
Use makeVector() functionality in WTF to convert the NSArray into a Vector instead
of doing it by hand. Also mark the NeverDestroyed variable as static const to
avoid leaking.

• UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::platformOverrideLanguages const):

10:57 AM Changeset in webkit [263099] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit

Provide alternatively-named WKBrowsingContextGroup SPI
​https://bugs.webkit.org/show_bug.cgi?id=213229

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-06-16
Reviewed by Tim Horton.

This is unfortunately still used. In order to try to convince the user to make the smallest change possible, make newly named SPI that behaves identically.
Doubly-deprecate the old SPI and implement it in terms of the new during the transition period.

• UIProcess/API/Cocoa/WKBrowsingContextGroup.h:
• UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]):
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:includeMatchPatternStrings:excludeMatchPatternStrings:mainFrameOnly:]):
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]):
(-[WKBrowsingContextGroup addUserScript:baseURL:includeMatchPatternStrings:excludeMatchPatternStrings:injectionTime:mainFrameOnly:]):

10:18 AM Changeset in webkit [263098] by youenn@apple.com

• 5 edits
  5 adds in trunk

Loads triggered by an opaque stylesheet should not be visible to service workers
​https://bugs.webkit.org/show_bug.cgi?id=213246

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/wpt/service-workers/no-cors-css-with-subresources.https.html

• loader/ResourceLoaderOptions.h:

Move it to boolean

Source/WebKit:

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
In case the load is triggered from an opaque response, set service worker mode to none.

LayoutTests:

• http/wpt/service-workers/no-cors-css-with-subresources.https-expected.txt: Added.
• http/wpt/service-workers/no-cors-css-with-subresources.https.html: Added.
• http/wpt/service-workers/no-cors-css-worker.js: Added.

(async doTest):
(async doFetch):

• http/wpt/service-workers/resources/loading-subresources.css: Added.
• http/wpt/service-workers/resources/subresource.css: Added.

(div#resource_link_css):

10:06 AM Changeset in webkit [263097] by youenn@apple.com

• 2 edits in trunk/LayoutTests

Increase pixel check tolerance for http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html
​https://bugs.webkit.org/show_bug.cgi?id=213237

Reviewed by Eric Carlson.

• http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html:

Increase pixel tolerance as we encode/decode video which might create some artefacts.

9:35 AM Changeset in webkit [263096] by Chris Fleizach

• 8 edits in trunk

AX: <address> element should no longer map to ARIA contentinfo role
​https://bugs.webkit.org/show_bug.cgi?id=212617
<rdar://problem/63848604>

Reviewed by Joanmarie Diggs.

Source/WebCore:

Change the mapping of <address> to be a basic group. Update tests.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

• accessibility/mac/landmark-not-ignored-expected.txt:
• accessibility/mac/landmark-not-ignored.html:
• platform/mac-wk2/accessibility/roles-exposed-expected.txt:
• platform/mac/accessibility/roles-exposed-expected.txt:
• platform/win/accessibility/roles-exposed-expected.txt:

9:24 AM Changeset in webkit [263095] by cturner@igalia.com

• 23 edits
  4 adds in trunk

[GTK] Disable video autoplay
​https://bugs.webkit.org/show_bug.cgi?id=184845

Reviewed by Carlos Garcia Campos.

Source/WebKit:

• PlatformGTK.cmake: Add new source files to the build.
• PlatformWPE.cmake: Ditto.
• SourcesGTK.txt: Ditto.
• SourcesWPE.txt: Ditto.
• UIProcess/API/glib/WebKitPolicyDecision.cpp:

(webkit_policy_decision_use_with_policies): : Add an API to
respond to navigation decisions with policies.

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView): Plumb in the default
website policies that are associated with the web view.

• UIProcess/API/glib/WebKitWebContextPrivate.h:
• UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewConstructed):
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkit_web_view_get_website_policies):

• UIProcess/API/glib/WebKitWebsitePolicies.cpp: Added.

(_WebKitWebsitePoliciesPrivate::_WebKitWebsitePoliciesPrivate):
(webkitWebsitePoliciesGetWebsitePolicies):
(webkitWebsitePoliciesGetPoliciesData):
(webkitWebsitePoliciesGetProperty):
(webkitWebsitePoliciesSetAutoplayPolicy):
(webkitWebsitePoliciesSetProperty):
(webkit_website_policies_class_init):
(webkit_website_policies_new):
(webkit_website_policies_new_with_policies):
(webkit_website_policies_get_autoplay_policy):

• UIProcess/API/glib/WebKitWebsitePoliciesPrivate.h: Added.
• UIProcess/API/gtk/WebKitPolicyDecision.h:
• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/WebKitWebViewGtk.cpp:

(webkit_web_view_new_with_related_view):

• UIProcess/API/gtk/WebKitWebsitePolicies.h: Added.
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
• UIProcess/API/wpe/WebKitPolicyDecision.h:
• UIProcess/API/wpe/WebKitWebView.h:
• UIProcess/API/wpe/WebKitWebsitePolicies.h: Added.
• UIProcess/API/wpe/docs/wpe-1.0-sections.txt:

Tools:

Update the various callsites for constructing a view to take into
account the default policies. I chose the default as autoplay
allow without sound, which is in keeping with WebCore's choice.

• MiniBrowser/gtk/BrowserWindow.c:

(webViewDecidePolicy):
(newTabCallback):
(openPrivateWindow):
(browser_window_get_or_create_web_view_for_automation):
(browser_window_create_web_view_in_new_tab_for_automation):

• MiniBrowser/gtk/main.c:

(createBrowserTab):
(main):

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Add

autoplay policy tests, and use modern class initializers.
(testAutoplayPolicy):
(beforeAll):

8:30 AM Changeset in webkit [263094] by Chris Dumez

• 12 edits in trunk/Source

Stop calling userPreferredLanguages() in the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=213214
<rdar://problem/64317593>

Reviewed by Per Arne Vollan.

Source/WebKit:

Stop calling userPreferredLanguages() in the UIProcess since this can be slow and may keep
the main thread busy. Nowadays, the WebProcess is able to call it by itself anyway. The
sandbox is allowing it.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::languageChanged):
(WebKit::WebProcessPool::initializeNewWebProcess):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::userPreferredLanguagesChanged const):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

Source/WTF:

Export WTF::languageDidChange() so we can call it from WebKit2.

• wtf/Language.h:

8:19 AM Changeset in webkit [263093] by Truitt Savell

• 41 edits
  3 deletes in trunk

Unreviewed, reverting r263079.

Broke Internal builds.

Reverted changeset:

"IndexedDB: Support IDBFactory databases method"
​https://bugs.webkit.org/show_bug.cgi?id=211043
​https://trac.webkit.org/changeset/263079

8:12 AM Changeset in webkit [263092] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

O(n^{2) behavior in media query resolution
​https://bugs.webkit.org/show_bug.cgi?id=213243}

Reviewed by Anders Carlsson.

We were traversing all rules in a RuleSet inside a loop over all media queries that change value.
This becomes problematic when you have thousands of media queries.

• style/RuleSet.cpp:

(WebCore::Style::RuleSet::evaluteDynamicMediaQueryRules):

Instead collect the rule positions that need flipping into a map and then traverse only once
to do the actual flipping.

Longer term we should maintain a data stucture that can map directly from a position to RuleDatas.
This will require some data structure rethink so this patch takes a simpler approach.

(WebCore::Style::RuleSet::MediaQueryCollector::pop):

• style/RuleSet.h:

8:06 AM Changeset in webkit [263091] by Jason_Lawrence

• 2 edits in trunk/LayoutTests

[iOS wk2] http/tests/security/cookies/third-party-cookie-blocking-main-frame.html is flaky timing out.
​https://bugs.webkit.org/show_bug.cgi?id=206946

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

8:00 AM Changeset in webkit [263090] by pvollan@apple.com

• 4 edits in trunk/Source/WebCore

[iOS] Collecting screen properties in the UI process introduced a Safari launch time regression.
​https://bugs.webkit.org/show_bug.cgi?id=213217
<rdar://problem/64374461>

Reviewed by Brent Fulgham.

Calling collectScreenProperties() in WebProcessPool::platformInitializeWebProcess() introduced a Safari launch time regression on iOS.
It turns out that calling screenIsMonochrome on iOS is expensive, but this call can still be done in the WebContent process, since there
are no sandbox restrictions making that call fail in the WebContent process. Call this function in the WebContent process instead of in
the UI process.

No new tests, since this change should not introduce a change in behavior. It goes back to calling the screenIsMonochrome function in the
WebContent process.

• platform/ScreenProperties.h:

(WebCore::ScreenData::encode const):
(WebCore::ScreenData::decode):

• platform/ios/PlatformScreenIOS.mm:

(WebCore::screenIsMonochrome):
(WebCore::collectScreenProperties):

• platform/mac/PlatformScreenMac.mm:

(WebCore::collectScreenProperties):

7:58 AM Changeset in webkit [263089] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak SDK] Subversion perl bindings unusable
​https://bugs.webkit.org/show_bug.cgi?id=213241

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-06-16
Reviewed by Sergio Villar Senin.

• buildstream/elements/sdk/subversion.bst: The svn swig perl library wasn't correctly

installed, leading to undefined symbols when importing it from the bindings. A new
integration command now tests this.

7:58 AM Changeset in webkit [263088] by commit-queue@webkit.org

• 8 edits
  1 add
  1 delete in trunk/Tools

[Flatpak SDK] Update to Qt 5.15
​https://bugs.webkit.org/show_bug.cgi?id=213192

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-06-16
Reviewed by Sergio Villar Senin.

The new patch comes from the upstream KDE SDK: ​https://github.com/KDE/flatpak-kde-runtime/tree/qt5.15lts/patch

• buildstream/elements/qt5/qtbase.bst:
• buildstream/elements/qt5/qtdeclarative.bst:
• buildstream/elements/qt5/qtquickcontrols.bst:
• buildstream/elements/qt5/qtquickcontrols2.bst:
• buildstream/elements/qt5/qtwayland.bst:
• buildstream/elements/qt5/qtx11extras.bst:
• buildstream/patches/qtbase-make-sure-to-correctly-construct-base-platform-theme.patch: Added.
• buildstream/patches/qtwayland-use-gnome-platform-theme-on-gnome-based-desktops.patch: Removed.
• buildstream/project.conf:

7:57 AM Changeset in webkit [263087] by calvaris@igalia.com

• 9 edits in trunk/Source/WebCore

[EME] Create CDMProxyFactory
​https://bugs.webkit.org/show_bug.cgi?id=212695

Reviewed by Youenn Fablet.

Currently in the GStreamer port we have the CDMProxy cabled in the
player private and set to the instance. Setting this too late can
create key sync issues that are worked around. This does not seem
to be needed because it can be created in the constructor from a
CDMProxyFactory if we just use the key system that we already
have.

This patch declares a CDMProxyFactory that is used in the
CDMInstanceProxy to instantiate the proper CDMProxy in its
constructor.

CDMProxyFactoryClearKey is created and added to the GStreamer
platform CDMProxyFactories.

Initializing too fast creates flakyness in several ClearKey tests
because of asking for protected memory so we need to initialize it
in a lazy way.

No new tests, just a rework.

• platform/encryptedmedia/CDMProxy.cpp:

(WebCore::CDMProxyFactory::registerFactory):
(WebCore::CDMProxyFactory::unregisterFactory):
(WebCore::CDMProxyFactory::createCDMProxyForKeySystem):
(WebCore::CDMProxyFactory::platformRegisterFactories):

• platform/encryptedmedia/CDMProxy.h:

(WebCore::CDMProxyFactory::~CDMProxyFactory):
(WebCore::CDMInstanceProxy::CDMInstanceProxy):

• platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::CDMInstanceClearKey::CDMInstanceClearKey):
(WebCore::CDMInstanceClearKey::keySystem const):

• platform/encryptedmedia/clearkey/CDMClearKey.h:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::cdmInstanceAttached):

• platform/graphics/gstreamer/eme/CDMFactoryGStreamer.cpp:

(WebCore::CDMProxyFactory::platformRegisterFactories):

• platform/graphics/gstreamer/eme/CDMProxyClearKey.cpp:

(WebCore::CDMProxyFactoryClearKey::singleton):
(WebCore::CDMProxyFactoryClearKey::createCDMProxy):
(WebCore::CDMProxyFactoryClearKey::supportsKeySystem):

• platform/graphics/gstreamer/eme/CDMProxyClearKey.h:

7:57 AM Changeset in webkit [263086] by Truitt Savell

• 2 edits in trunk/LayoutTests

Rebase tables/mozilla_expected_failures/bugs/bug2479-5.html after the changes in ​https://trac.webkit.org/changeset/263073/webkit
​https://bugs.webkit.org/show_bug.cgi?id=212856

Unreviewed test gardening.

• platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

2:31 AM Changeset in webkit [263085] by Carlos Garcia Campos

• 18 edits in trunk

[GTK][WPE] Add API to configure and enable resource load statistics
​https://bugs.webkit.org/show_bug.cgi?id=177943

Reviewed by Michael Catanzaro.

Source/WebKit:

• UIProcess/API/glib/WebKitWebsiteData.cpp:

(recordContainsSupportedDataTypes):
(toWebKitWebsiteDataTypes):

• UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(webkitWebsiteDataManagerGetProperty):
(webkitWebsiteDataManagerSetProperty):
(webkitWebsiteDataManagerConstructed):
(webkit_website_data_manager_class_init):
(webkitWebsiteDataManagerGetDataStore):
(webkit_website_data_manager_get_itp_directory):
(webkit_website_data_manager_set_itp_enabled):
(webkit_website_data_manager_get_itp_enabled):
(toWebsiteDataTypes):

• UIProcess/API/gtk/WebKitWebsiteData.h:
• UIProcess/API/gtk/WebKitWebsiteDataManager.h:
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
• UIProcess/API/wpe/WebKitWebsiteData.h:
• UIProcess/API/wpe/WebKitWebsiteDataManager.h:
• UIProcess/API/wpe/docs/wpe-1.0-sections.txt:
• UIProcess/glib/WebsiteDataStoreGLib.cpp:

(WebKit::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):

Tools:

Add --enable-itp command line version to MiniBrowser and unit tests to check the new API.

• MiniBrowser/gtk/main.c:

(gotWebsiteDataCallback):
(activate):

• MiniBrowser/wpe/main.cpp:

(main):

• TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:

(serverCallback):
(testWebsiteDataConfiguration):
(testWebsiteDataEphemeral):
(testWebsiteDataITP):
(beforeAll):

• TestWebKitAPI/glib/TestExpectations.json:
• TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::Test):

• TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(directoryChangedCallback):
(WebViewTest::waitUntilFileChanged):

• TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:

2:18 AM Changeset in webkit [263084] by youenn@apple.com

• 3 edits
  2 adds in trunk

Make sure MediaRecorder.requestData returns data with the new writer backend
​https://bugs.webkit.org/show_bug.cgi?id=206929

Reviewed by Darin Adler.

Source/WebCore:

Test: http/wpt/mediarecorder/MediaRecorder-requestData.html

• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::fetchData):
Flush data whenever calling fetchData.

LayoutTests:

• http/wpt/mediarecorder/MediaRecorder-requestData-expected.txt: Added.
• http/wpt/mediarecorder/MediaRecorder-requestData.html: Added.

1:56 AM Changeset in webkit [263083] by commit-queue@webkit.org

• 2 edits in trunk/Tools

REGRESSION(r263029): [Flatpak SDK] Broke initial SDK installation

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-06-16
Rubber-stamped by Žan Doberšek.

• flatpak/flatpakutils.py:

(FlatpakObject.version): Gracefully return an empty version when the flatpak info command
fails. This usually means the app has not been installed yet.

1:32 AM Changeset in webkit [263082] by mark.lam@apple.com

• 6 edits in trunk

Add SIGABRT handler for non OS(DARWIN) builds to the jsc shell with the -s option.
​https://bugs.webkit.org/show_bug.cgi?id=213200

Reviewed by Michael Catanzaro.

JSTests:

• stress/ensure-crash.js:
• unskip this test since expected crashes should now be handled on non-darwin builds.

Source/JavaScriptCore:

This is needed because non OS(DARWIN) builds uses abort as their "CRASH"ing
mechanism.

• jsc.cpp:

(CommandLine::parseArguments):

Source/WTF:

• wtf/threads/Signals.h:

(WTF::toSystemSignal):
(WTF::fromSystemSignal):

12:29 AM Changeset in webkit [263081] by Devin Rousso

• 4 edits in trunk/LayoutTests

REGRESSION: [ Mac ] inspector/page/setBootstrapScript-sub-frame.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=213087
<rdar://problem/64262900>

Reviewed by Maciej Stachowiak.

• inspector/page/setBootstrapScript-sub-frame.html:
• inspector/page/resources/bootstrap-iframe.html:

• platform/mac/TestExpectations:

12:28 AM Changeset in webkit [263080] by youenn@apple.com

• 2 edits in trunk/LayoutTests

LayoutTest imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=169572

Unreviewed.

• platform/mac/TestExpectations:

Remove no longer needed expectation.

12:27 AM Changeset in webkit [263079] by commit-queue@webkit.org

• 41 edits
  2 copies
  1 add in trunk

IndexedDB: Support IDBFactory databases method
​https://bugs.webkit.org/show_bug.cgi?id=211043

Patch by Darryl Pogue <​darryl@dpogue.ca> on 2020-06-16
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Adjust test expectations for IDBFactory.prototype.databases().

• web-platform-tests/IndexedDB/get-databases.any-expected.txt:
• web-platform-tests/IndexedDB/get-databases.any.worker-expected.txt:
• web-platform-tests/IndexedDB/idbfactory-databases-opaque-origin-expected.txt:
• web-platform-tests/IndexedDB/idbfactory-origin-isolation-expected.txt:
• web-platform-tests/IndexedDB/idlharness.any-expected.txt:
• web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt:

Source/WebCore:

Add support for fetching the list of IDB database names and versions
from the IDBServer, and expose the functionality as
IDBFactory.prototype.databases().

Spec: ​https://w3c.github.io/IndexedDB/#dom-idbfactory-databases

• Headers.cmake:
• Modules/indexeddb/IDBActiveDOMObject.h:

(WebCore::IDBActiveDOMObject::performCallbackOnOriginThread):

• Modules/indexeddb/IDBDatabaseNameAndVersionRequest.cpp: Added.

(WebCore::IDBDatabaseNameAndVersionRequest::create):
(WebCore::IDBDatabaseNameAndVersionRequest::IDBDatabaseNameAndVersionRequest):
(WebCore::IDBDatabaseNameAndVersionRequest::~IDBDatabaseNameAndVersionRequest):
(WebCore::IDBDatabaseNameAndVersionRequest::complete):
(WebCore::IDBDatabaseNameAndVersionRequest::activeDOMObjectName const):
(WebCore::IDBDatabaseNameAndVersionRequest::virtualHasPendingActivity const):
(WebCore::IDBDatabaseNameAndVersionRequest::stop):

• Modules/indexeddb/IDBDatabaseNameAndVersionRequest.h: Added.
• Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::databases):
(WebCore::IDBFactory::getAllDatabaseNames):

• Modules/indexeddb/IDBFactory.h:
• Modules/indexeddb/IDBFactory.idl:
• Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::connectionToServerLost):
(WebCore::IDBClient::IDBConnectionProxy::getAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionProxy::didGetAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionProxy::forgetActivityForCurrentThread):
(WebCore::IDBClient::IDBConnectionProxy::getAllDatabaseNames): Deleted.

• Modules/indexeddb/client/IDBConnectionProxy.h:
• Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::getAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionToServer::didGetAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionToServer::getAllDatabaseNames): Deleted.
(WebCore::IDBClient::IDBConnectionToServer::didGetAllDatabaseNames): Deleted.

• Modules/indexeddb/client/IDBConnectionToServer.h:
• Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
• Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::didGetAllDatabaseNamesAndVersions):
(WebCore::IDBServer::IDBConnectionToClient::didGetAllDatabaseNames): Deleted.

• Modules/indexeddb/server/IDBConnectionToClient.h:
• Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::getAllDatabaseNamesAndVersions):
(WebCore::IDBServer::IDBServer::getAllDatabaseNames): Deleted.

• Modules/indexeddb/server/IDBServer.h:
• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameAndVersionFromFile):
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromFile): Deleted.

• Modules/indexeddb/server/SQLiteIDBBackingStore.h:
• Modules/indexeddb/shared/IDBDatabaseNameAndVersion.h: Added.

(WebCore::IDBDatabaseNameAndVersion::encode const):
(WebCore::IDBDatabaseNameAndVersion::decode):
(WebCore::IDBDatabaseNameAndVersion::isolatedCopy const):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• inspector/agents/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):

• loader/EmptyClients.cpp:

Source/WebKit:

Plumbing for returning a list of IDB databases and versions.

• NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::didGetAllDatabaseNamesAndVersions):
(WebKit::WebIDBConnectionToClient::didGetAllDatabaseNames): Deleted.

• NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
• NetworkProcess/IndexedDB/WebIDBServer.cpp:

(WebKit::WebIDBServer::getAllDatabaseNamesAndVersions):
(WebKit::WebIDBServer::getAllDatabaseNames): Deleted.

• NetworkProcess/IndexedDB/WebIDBServer.h:
• NetworkProcess/IndexedDB/WebIDBServer.messages.in:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::getAllDatabaseNamesAndVersions):
(WebKit::WebIDBConnectionToServer::didGetAllDatabaseNamesAndVersions):
(WebKit::WebIDBConnectionToServer::getAllDatabaseNames): Deleted.
(WebKit::WebIDBConnectionToServer::didGetAllDatabaseNames): Deleted.

• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:

Source/WebKitLegacy:

Plumbing for returning a list of IDB databases and versions.

• Storage/InProcessIDBServer.cpp:

(InProcessIDBServer::getAllDatabaseNamesAndVersions):
(InProcessIDBServer::didGetAllDatabaseNamesAndVersions):
(InProcessIDBServer::getAllDatabaseNames): Deleted.
(InProcessIDBServer::didGetAllDatabaseNames): Deleted.

• Storage/InProcessIDBServer.h:

12:18 AM Changeset in webkit [263078] by Devin Rousso

• 5 edits in trunk/LayoutTests

[ Mac wk2 ] http/tests/inspector/network/har/har-page.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=207954
<rdar://problem/59599895>

Reviewed by Maciej Stachowiak.

• http/tests/inspector/network/har/har-page.html:
• http/tests/inspector/network/har/har-page-aggressive-gc.html:
• http/tests/inspector/network/har/har-page-aggressive-gc-expected.txt:

Explicitly disable resource caching as the test reloads the page and expects resource load
metrics to be populated/valid.

• platform/mac-wk2/TestExpectations:

12:15 AM Changeset in webkit [263077] by Diego Pino Garcia

• 44 edits in trunk/LayoutTests

[WPE] Unreviewed test gardening. Update baselines after r263073.

• platform/wpe/fast/css/focus-ring-exists-for-search-field-expected.txt:
• platform/wpe/fast/css/line-height-expected.txt:
• platform/wpe/fast/css/text-overflow-input-expected.txt:
• platform/wpe/fast/events/context-no-deselect-expected.txt:
• platform/wpe/fast/frames/take-focus-from-iframe-expected.txt:
• platform/wpe/fast/html/details-no-summary4-expected.txt:
• platform/wpe/fast/html/details-open-javascript-expected.txt:
• platform/wpe/fast/html/details-open2-expected.txt:
• platform/wpe/fast/html/details-open4-expected.txt:
• platform/wpe/fast/lists/dynamic-marker-crash-expected.txt:
• platform/wpe/fast/replaced/replaced-breaking-expected.txt:
• platform/wpe/fast/replaced/replaced-breaking-mixture-expected.txt:
• platform/wpe/fast/table/colspanMinWidth-expected.txt:
• platform/wpe/fast/table/spanOverlapRepaint-expected.txt:
• platform/wpe/fast/table/text-field-baseline-expected.txt:
• platform/wpe/fast/text/textIteratorNilRenderer-expected.txt:
• platform/wpe/fast/transforms/transformed-focused-text-input-expected.txt:
• platform/wpe/http/tests/navigation/javascriptlink-frames-expected.txt:
• platform/wpe/svg/custom/inline-svg-in-xhtml-expected.txt:
• platform/wpe/svg/hixie/mixed/003-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug1188-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug12384-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug18359-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug24200-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug2479-2-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug2479-3-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug2479-4-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug28928-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug4382-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug4527-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug46368-1-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug46368-2-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug51037-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug55545-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug59354-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug7342-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug96334-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug99948-expected.txt:
• platform/wpe/tables/mozilla/dom/tableDom-expected.txt:
• platform/wpe/tables/mozilla/other/move_row-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
• platform/wpe/transforms/3d/general/perspective-non-layer-expected.txt: