Context Navigation

← Previous Period
Next Period →

Timeline

Jul 3, 2020:

11:42 PM Changeset in webkit [263930] by ysuzuki@apple.com

3 edits
1 add in trunk

[JSC] Promise should check whether a user-provided function is set by using @isUndefinedOrNull
https://bugs.webkit.org/show_bug.cgi?id=213951

Reviewed by Ross Kirsling.

JSTests:

stress/masquerader-as-function-in-promise.js: Added.

Source/JavaScriptCore:

If a user-provided function is masquerade-as-undefined value, if (!xxx.@onRejected) returns wrong
value since this function object is considered as undefined in this context. We should use @isUndefinedOrNull
here instead since this if-branch is checking whether this property is null/undefined actually.
And if (@isUndefinedOrNull(...)) is efficient since we have jundefined_or_null / jnundefined_or_null bytecodes.

builtins/PromiseOperations.js:

(globalPrivate.promiseReactionJob):

11:38 PM Changeset in webkit [263929] by Wenson Hsieh

2 edits in trunk/Tools

[macOS] Tests that show system menu popups may fail when run concurrently
https://bugs.webkit.org/show_bug.cgi?id=213950
<rdar://problem/64551566>

Reviewed by Darin Adler.

Make it possible to run tests that present system modal popups simultaneously, without the possibility of these
tests interfering with each other. Examples include context menus, select menus, and the DOM paste popup. To do
this, we swizzle out codepaths for showing and dimissing popups, and instead dispatch notifications and the
appropriate NSMenuDelegate methods ourselves.

This change has the side effect of fixing several layout tests that are currently timing out only on arm64e
macOS, due to reasons detailed in <rdar://problem/65084503>.

WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::setSwizzledPopUpMenu):
(WTR::swizzledPopUpContextMenu):
(WTR::swizzledPopUpMenu):
(WTR::swizzledCancelTracking):
(WTR::TestController::platformInitialize):

10:15 PM Changeset in webkit [263928] by youenn@apple.com

25 edits
3 copies
23 adds in trunk

MediaRecorder should support peer connection remote video tracks
https://bugs.webkit.org/show_bug.cgi?id=213924

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Resync to WPT ToT.

resources/resource-files.json:
web-platform-tests/mediacapture-record/BlobEvent-constructor.html:
web-platform-tests/mediacapture-record/MediaRecorder-bitrate.https-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-bitrate.https.html: Added.
web-platform-tests/mediacapture-record/MediaRecorder-creation.https-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-creation.https.html: Added.
web-platform-tests/mediacapture-record/MediaRecorder-detached-context-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-detached-context.html: Added.
web-platform-tests/mediacapture-record/MediaRecorder-disabled-tracks.https-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-disabled-tracks.https.html: Added.
web-platform-tests/mediacapture-record/MediaRecorder-error.html:
web-platform-tests/mediacapture-record/MediaRecorder-events-and-exceptions-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-events-and-exceptions.html: Added.
web-platform-tests/mediacapture-record/MediaRecorder-mimetype-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-mimetype.html: Added.
web-platform-tests/mediacapture-record/MediaRecorder-no-sink.https-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-no-sink.https.html: Added.
web-platform-tests/mediacapture-record/MediaRecorder-pause-resume-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-pause-resume.html: Added.
web-platform-tests/mediacapture-record/MediaRecorder-peerconnection.https-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-peerconnection.https.html: Added.
web-platform-tests/mediacapture-record/MediaRecorder-stop-expected.txt:
web-platform-tests/mediacapture-record/MediaRecorder-stop.html:
web-platform-tests/mediacapture-record/idlharness.window-expected.txt:
web-platform-tests/mediacapture-record/idlharness.window.js:
web-platform-tests/mediacapture-record/passthrough/MediaRecorder-passthrough.https-expected.txt: Added.
web-platform-tests/mediacapture-record/passthrough/MediaRecorder-passthrough.https.html: Added.
web-platform-tests/mediacapture-record/passthrough/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/w3c-import.log.
web-platform-tests/mediacapture-record/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/w3c-import.log.
web-platform-tests/mediacapture-record/utils/peerconnection.js: Added.

(async exchangeOfferAnswer):
(setTransceiverCodecPreference):
(async startConnection):
(async waitForReceivedFrames):
(async waitForReceivedCodec):

web-platform-tests/mediacapture-record/utils/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/w3c-import.log.
web-platform-tests/mediacapture-record/w3c-import.log:

Source/WebCore:

Previsouly we were checking whether width and height are given for a video track.
This is not always available, for instance for remote tracks.
And this can change over time.
Instead, pass a simple boolean (whether there is a video track or not).
Minor simplifications to stop storing unneeded members.

Tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-bitrate.https.html

imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-creation.https.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-detached-context.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-disabled-tracks.https.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-events-and-exceptions.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-mimetype.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-no-sink.https.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-pause-resume.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-peerconnection.https.html
imported/w3c/web-platform-tests/mediacapture-record/passthrough/MediaRecorder-passthrough.https.html

platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

(WebCore::MediaRecorderPrivateAVFImpl::create):
(WebCore::MediaRecorderPrivateAVFImpl::MediaRecorderPrivateAVFImpl):

platform/mediarecorder/MediaRecorderPrivateAVFImpl.h:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::create):

Source/WebKit:

Pass a boolean instead of width/height for the video track.

GPUProcess/webrtc/RemoteMediaRecorder.cpp:

(WebKit::RemoteMediaRecorder::create):

GPUProcess/webrtc/RemoteMediaRecorder.h:
GPUProcess/webrtc/RemoteMediaRecorderManager.cpp:

(WebKit::RemoteMediaRecorderManager::createRecorder):

GPUProcess/webrtc/RemoteMediaRecorderManager.h:
GPUProcess/webrtc/RemoteMediaRecorderManager.messages.in:
WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:

(WebKit::MediaRecorderPrivate::startRecording):

WebProcess/GPU/webrtc/MediaRecorderPrivate.h:

LayoutTests:

TestExpectations:
tests-options.json:

9:56 PM Changeset in webkit [263927] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore/PAL

Fix a build error by forward declaring _NSHTTPAlternativeServicesStorage
https://bugs.webkit.org/show_bug.cgi?id=213911

Patch by Saagar Jha <saagar@saagarjha.com> on 2020-07-03
Reviewed by Darin Adler.

The public 10.16 SDK does not define _NSHTTPAlternativeServicesStorage, and the interface
declaration comes after it is used. Forward declare it to fix the error.

pal/spi/cf/CFNetworkSPI.h: Forward declare _NSHTTPAlternativeServicesStorage.

7:33 PM Changeset in webkit [263926] by Darin Adler

3 edits in trunk/Source/WebCore

WebCore/Sources.txt: Remove all remaining #if (ENABLE_WEBGL and ENABLE_WEBXR)
https://bugs.webkit.org/show_bug.cgi?id=213946

Reviewed by Sam Weinig.

CMakeLists.txt: Move IDL-related ENABLE_WEBGL and ENABLE_WEBXR items out of if blocks.

Longer term, I think our direction should be to remove most feature conditionals from
CMakeLists.txt too, just like I am doing for Sources.txt. But for now, doing just enough
of this to keep the build working. Someone can tidy this later as desired.

Sources.txt: Remove all remaining #if, and sort files, getting rid of paragraphing

per directory to just turn this into three sorted lists of filenames (separate ones for
derived sources and generated bindings at the end). The source files themselves have the
appropriate conditionals and soon we will not need to support #if in Sources.txt files.

7:07 PM Changeset in webkit [263925] by Lauro Moura

2 edits in trunk/LayoutTests

[GStreamer] Garden media/vp9.html failure

Unreviewed test gardening.

platform/glib/TestExpectations:

6:51 PM Changeset in webkit [263924] by Lauro Moura

4 edits in trunk/LayoutTests

[GTK][WPE] Rebaseline imported dom/idlharness tests after r263903

Unreviewed test gardening.

platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

5:42 PM Changeset in webkit [263923] by Fujii Hironori

2 edits in trunk/Source/WebCore

[Win] Unreviewed stack-overflow crash fix for r263890
https://bugs.webkit.org/show_bug.cgi?id=213912
<rdar://problem/65069686>

Renamed mimeTypeForExtension to mimeTypeForExtensionFromRegistry.

platform/win/MIMETypeRegistryWin.cpp:

(WebCore::mimeTypeForExtensionFromRegistry):
(WebCore::MIMETypeRegistry::mimeTypeForExtension):
(WebCore::mimeTypeForExtension): Deleted.

5:30 PM Changeset in webkit [263922] by Fujii Hironori

2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix for r263913
https://bugs.webkit.org/show_bug.cgi?id=213939
<rdar://problem/65084185>

CMakeLists.txt: Process encrypted media IDL files even if ENABLE_ENCRYPTED_MEDIA is off.

5:16 PM Changeset in webkit [263921] by Kocsen Chung

1 copy in tags/Safari-610.1.20.3

Tag Safari-610.1.20.3.

5:12 PM Changeset in webkit [263920] by Kocsen Chung

2 edits in branches/safari-610.1.20-branch/Source/WebKit

Revert r263781. rdar://problem/65085169

5:12 PM Changeset in webkit [263919] by Kocsen Chung

3 edits in branches/safari-610.1.20-branch/Source/WebKit

Revert r263793. rdar://problem/65085169

4:56 PM Changeset in webkit [263918] by Darin Adler

4 edits in trunk/Source/WebCore

WebCore/Sources.txt: Remove #if ENABLE_WIRELESS_PLAYBACK_TARGET
https://bugs.webkit.org/show_bug.cgi?id=213945

Reviewed by Sam Weinig.

CMakeLists.txt: Moved items from the pictureinpicture and remoteplayback module here

from PlatformMac.cmake. Even if these are currently only implemented on Mac, they are
not intrinsically Mac-specific, so they belong here.

PlatformMac.cmake: Ditto.

Sources.txt: Remove #if ENABLE_WIRELESS_PLAYBACK_TARGET and sort files in with the others.

The source files themselves have conditionals, we don't need conditionals in Sources.txt,
and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.

4:51 PM Changeset in webkit [263917] by Kocsen Chung

8 edits in branches/safari-610.1.20-branch/Source

Versioning.

WebKit-610.1.20.3

4:43 PM Changeset in webkit [263916] by weinig@apple.com

32 edits
2 deletes in trunk

Remove support for ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE
https://bugs.webkit.org/show_bug.cgi?id=213932

Reviewed by Darin Adler.

Removes support for non-standard <input type="datetime">, currently being
guarded by the macro ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE. This macro, was
added back in 2013 as a temporary measure to support some engines who shipped
support for <input type="datetime">. It is currently not enabled for any
ports so now seems like as good a time as any to remove it.

Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
css/html.css:

(#endif):

html/DateTimeInputType.cpp: Removed.
html/DateTimeInputType.h: Removed.
html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeEnabled): Deleted.

platform/DateComponents.cpp:

(WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal):
(WebCore::DateComponents::millisecondsSinceEpoch const):
(WebCore::DateComponents::toString const):
(WebCore::DateComponents::fromParsingDateTime): Deleted.
(WebCore::DateComponents::parseDateTime): Deleted.
(WebCore::DateComponents::fromMillisecondsSinceEpochForDateTime): Deleted.
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): Deleted.

platform/DateComponents.h:
platform/text/PlatformLocale.cpp:

(WebCore::Locale::formatDateTime):

platform/text/ios/LocalizedDateCache.mm:

(WebCore::LocalizedDateCache::createFormatterForType):

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/PlatformEnable.h:

Tools:

Scripts/webkitperl/FeatureList.pm:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

4:25 PM Changeset in webkit [263915] by Darin Adler

3 edits in trunk/Source/WebCore

WebCore/Sources.txt: Remove #if ENABLE_USER_MESSAGE_HANDLERS
https://bugs.webkit.org/show_bug.cgi?id=213944

Reviewed by Sam Weinig.

CMakeLists.txt: Move IDL-related ENABLE_USER_MESSAGE_HANDLERS items out of if blocks.

Sources.txt: Remove #if ENABLE_USER_MESSAGE_HANDLERS and sort files in with the others.

The source files themselves have conditionals, we don't need conditionals in Sources.txt,
and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.

4:23 PM Changeset in webkit [263914] by Darin Adler

2 edits in trunk/Source/WebCore

WebCore/SourcesCocoa.txt: Remove #if ENABLE_APPLE_PAY
https://bugs.webkit.org/show_bug.cgi?id=213943

Reviewed by Sam Weinig.

SourcesCocoa.txt: Remove #if ENABLE_APPLE_PAY and sort files in with the others.

The source files themselves have conditionals, we don't need conditionals in Sources.txt,
and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.
Also, sort the files and remove the separate per-directory paragraphs, making this closer
to just a sorted list of filenames with less "editorial" content. Also added comments
about the USE_INTERNAL_SDK part of the file.

3:17 PM Changeset in webkit [263913] by Darin Adler

2 edits in trunk/Source/WebCore

WebCore/Sources.txt: Remove #if ENABLE_ENCRYPTED_MEDIA
https://bugs.webkit.org/show_bug.cgi?id=213939

Reviewed by Sam Weinig.

CMakeLists.txt: Move IDL-related ENABLE_ENCRYPTED_MEDIA items out of if blocks.

Sources.txt: Remove #if ENABLE_LEGACY_ENCRYPTED_MEDIA and sort files in with the others.

The IDL files themselves have conditionals, we don't need conditionals in Sources.txt,
and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.

2:50 PM Changeset in webkit [263912] by Darin Adler

3 edits in trunk/Source/WebCore

WebCore/Sources.txt: Remove #if ENABLE_LEGACY_ENCRYPTED_MEDIA
https://bugs.webkit.org/show_bug.cgi?id=213937

Reviewed by Sam Weinig.

CMakeLists.txt: Move IDL-related ENABLE_LEGACY_ENCRYPTED_MEDIA items out of if blocks.

Sources.txt: Remove #if ENABLE_LEGACY_ENCRYPTED_MEDIA and sort files in with the others.

The IDL files themselves have conditionals, we don't need conditionals in Sources.txt,
and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.

2:45 PM Changeset in webkit [263911] by Darin Adler

3 edits in trunk/Source/WebCore

WebCore/Sources.txt: Remove #if ENABLE_QUOTA
https://bugs.webkit.org/show_bug.cgi?id=213941

Reviewed by Sam Weinig.

CMakeLists.txt: Move IDL-related ENABLE_QUOTA items out of "if (ENABLE_QUOTA)".

Sources.txt: Remove #if ENABLE_QUOTA and sort files in with the others.

The source files themselves have conditionals, we don't need conditionals in Sources.txt,
and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.

2:43 PM Changeset in webkit [263910] by Darin Adler

3 edits in trunk/Source/WebCore

WebCore/Sources.txt: Remove #if ENABLE_GAMEPAD
https://bugs.webkit.org/show_bug.cgi?id=213936

Reviewed by Sam Weinig.

CMakeLists.txt: Move IDL-related ENABLE_GAMEPAD items out of "if (ENABLE_GAMEPAD)".

Sources.txt: Remove #if ENABLE_GAMEPAD and sort files in with the others.

The IDL files themselves have conditionals, we don't need conditionals in Sources.txt,
and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.

2:40 PM Changeset in webkit [263909] by Darin Adler

2 edits in trunk/Source/WebCore

WebCore/Sources.txt: Remove #if ENABLE_MEDIA_SOURCE
https://bugs.webkit.org/show_bug.cgi?id=213940

Reviewed by Sam Weinig.

Sources.txt: Remove #if ENABLE_MEDIA_SOURCE and sort files in with the others.

The IDL files themselves have conditionals, we don't need conditionals in Sources.txt,
and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.

2:27 PM Changeset in webkit [263908] by Lauro Moura

2 edits in trunk/Source/WebCore

[WPE] Fix build with clang after r263898
https://bugs.webkit.org/show_bug.cgi?id=213942

Unreviewed build fix.

loader/appcache/ApplicationCacheManifestParser.cpp:

2:16 PM Changeset in webkit [263907] by Darin Adler

2 edits in trunk/Source/WebCore

WebCore/Sources.txt: Remove #if ENABLE_APPLICATION_MANIFEST
https://bugs.webkit.org/show_bug.cgi?id=213935

Reviewed by Sam Weinig.

Sources.txt: Remove #if ENABLE_APPLICATION_MANIFEST and sort files in with the others.

The source files themselves have conditionals, we don't need conditionals in Sources.txt,
and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.

1:30 PM Changeset in webkit [263906] by weinig@apple.com

17 edits in trunk/Source

Add "-Wliteral-conversion" warning to Xcode based builds and fix the issues it finds
https://bugs.webkit.org/show_bug.cgi?id=213931

Reviewed by Darin Adler.

Configurations/Base.xcconfig:

Add -Wliteral-conversion.
Source/WebCore:

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::draw):
Fix error due to passing a double when a uint8_t was expected. This probably means
that the debug borders looked wrong for a little bit, but should now be back to
their transparent splendor.

1:06 PM Changeset in webkit [263905] by ysuzuki@apple.com

7 edits
1 add in trunk

[JSC] Add exception checks before and after viewWithUnderlyingString
https://bugs.webkit.org/show_bug.cgi?id=213923
<rdar://problem/65068473>

Reviewed by Sam Weinig.

JSTests:

stress/exception-checks-before-and-after-viewwithunderlyingstring.js: Added.

(shouldThrow):

Source/JavaScriptCore:

This patch inserts missing exception checks before and after viewWithUnderlyingString.

jsc.cpp:

(printInternal):
(functionDebug):

runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncParseFloat):

runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

runtime/StringPrototype.cpp:

(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):

12:59 PM Changeset in webkit [263904] by commit-queue@webkit.org

24 edits in trunk/Source

Unreviewed, reverting r263882.
https://bugs.webkit.org/show_bug.cgi?id=213933

Broke the build

Reverted changeset:

"Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to
replace _WKProcessPoolConfiguration.hstsStorageDirectory"
https://bugs.webkit.org/show_bug.cgi?id=213048
https://trac.webkit.org/changeset/263882

11:54 AM Changeset in webkit [263903] by Chris Dumez

48 edits
5 copies
3 moves
29 adds
9 deletes in trunk/LayoutTests

Resync web-platform-tests/html/dom & web-platform-tests/html/infrastructure from upstream
https://bugs.webkit.org/show_bug.cgi?id=213908

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Resync web-platform-tests/html/dom & web-platform-tests/html/infrastructure from upstream 145839c323ba1ec8b.

resources/import-expectations.json:
resources/resource-files.json:
web-platform-tests/html/dom/*: Updated.
web-platform-tests/html/infrastructure/*: Updated.

LayoutTests:

platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

11:32 AM Changeset in webkit [263902] by Alan Bujtas

10 edits
3 adds in trunk

[LFC][TFC][Quirk] Inflow child box quirk vertical margins should collapse with table cell.
https://bugs.webkit.org/show_bug.cgi?id=213926

Reviewed by Antti Koivisto.

Source/WebCore:

The BFC rootd (table cell box in this case) nornally do not collapse their margins with the first/last inflow child.
However in quirks mode, cell boxes collapse their (non-existing)margins with inflow quirk margins.

<table><tr><td><p>text content</td></tr></table> <- <p> box's top position is at 0px in quirks mode, while at 16px (1em) in strict mode.

This patch ensures that we collapse the quirk margins and take them into account when computing the cell's content height.

Test: fast/layoutformattingcontext/table-quirk-vertical-margin-simple.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):

layout/blockformatting/BlockFormattingContext.h:
layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::shouldCollapseMarginBeforeWithParentMarginBefore const):
(WebCore::Layout::BlockFormattingContext::Quirks::shouldCollapseMarginAfterWithParentMarginAfter const):

layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginBefore const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginAfter const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedVerticalValues):

layout/tableformatting/TableFormattingContext.h:

(WebCore::Layout::TableFormattingContext::Quirks::Quirks):

layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::cellHeigh const):

layout/tableformatting/TableFormattingContextQuirks.cpp: Added.

(WebCore::Layout::TableFormattingContext::Quirks::shouldIgnoreChildContentVerticalMargin const):

LayoutTests:

fast/layoutformattingcontext/table-quirk-vertical-margin-simple-expected.html: Added.
fast/layoutformattingcontext/table-quirk-vertical-margin-simple.html: Added.

9:55 AM Changeset in webkit [263901] by weinig@apple.com

22 edits
2 copies in trunk

Split color conversion functions out of ColorUtilities.h/cpp into their own file.
https://bugs.webkit.org/show_bug.cgi?id=213803

Reviewed by Simon Fraser.

Source/WebCore:

Moves color conversion functions (both between color spaces like toDisplayP3(const SRGBA&)
and between different representations like toHSLA(const SRGBA&)) to their own files.

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

Add new files.

css/parser/CSSPropertyParserHelpers.cpp:
editing/cocoa/DataDetection.mm:
html/canvas/CanvasRenderingContext2DBase.cpp:
html/canvas/CanvasStyle.cpp:

Add include of ColorConversion.h

platform/graphics/ColorConversion.cpp: Added.
platform/graphics/ColorConversion.h: Added.
platform/graphics/ColorUtilities.cpp:
platform/graphics/ColorUtilities.h:

Move functions to the new files.

platform/graphics/ExtendedColor.cpp:
platform/graphics/cairo/ImageBufferCairoBackend.cpp:
platform/graphics/filters/FELighting.cpp:

Add include of ColorConversion.h, remove unncessary include of ColorUtilities.h

platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp:
platform/graphics/filters/FEDisplacementMap.cpp:
platform/graphics/filters/FEMorphology.cpp:
platform/graphics/filters/FilterOperations.cpp:

Remove unncessary include of ColorUtilities.h

platform/graphics/filters/FilterOperation.cpp:

Add include of ColorConversion.h and ColorTypes.h, remove unncessary include of ColorUtilities.h.

platform/graphics/gtk/ColorGtk.cpp:
platform/graphics/win/ColorDirect2D.cpp:

Remove unncessary include of ColorUtilities.h. Update to use standard float -> SimpleColor idiom
using SRGBA<float>.

Tools:

TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

Update to include ColorConversion.h and ColorTypes.h rather than ColorUtilities.h

9:45 AM Changeset in webkit [263900] by weinig@apple.com

21 edits in trunk/Source/WebCore

Convert DateComponents parsing code to use Optional based return values rather than out-parameters
https://bugs.webkit.org/show_bug.cgi?id=213440

Reviewed by Darin Adler.

Rework DateComponents and Date/Time related InputTypes to use Optional based programming
for parsing results. Also take the opportunity to remove unicode upconversion from
DateComponent parsing and instead separate UChar and LChar variants via templates.

html/BaseDateAndTimeInputType.cpp:
html/BaseDateAndTimeInputType.h:
html/DateInputType.cpp:
html/DateInputType.h:
html/DateTimeInputType.cpp:
html/DateTimeInputType.h:
html/DateTimeLocalInputType.cpp:
html/DateTimeLocalInputType.h:
html/HTMLInputElement.cpp:
html/HTMLInputElement.h:
html/InputType.cpp:
html/InputType.h:
html/MonthInputType.cpp:
html/MonthInputType.h:
html/TimeInputType.cpp:
html/TimeInputType.h:
html/WeekInputType.cpp:
html/WeekInputType.h:
- Removes parseToDateComponentsInternal. No need it and parseToDateComponents.
- Makes parseToDateComponents pure virtual. The old code had a default implementations down in InputType, but it had no callers.
- Remove iOS vs. non-iOS difference for dateType(). It is now available on InputType on all platforms.
- Make setMillisecondToDateComponents and parseToDateComponents return an Optional.

platform/DateComponents.cpp:
platform/DateComponents.h:
- Replace member function based interfaces for parsing/setting explicit time offsets with new factory functions that return Optional<DateComponents>.
- These factories are implemented using the existing member functions, which are now private.
- Make max/min constants constexpr.
- Make parse* member functions templates to allow factory parse functions to call them without upconverting.
- Replace header guard with #pragma once.

8:19 AM WebKitGTK/2.28.x edited by Michael Catanzaro

(diff)

8:09 AM Changeset in webkit [263899] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[WPE][GTK] Bubblewrap sandbox should not attempt to bind empty paths
https://bugs.webkit.org/show_bug.cgi?id=202880

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-07-03
Reviewed by Carlos Garcia Campos.

If an empty path is set in LD_LIBRARY_PATH (e.g. /foo::/bar), we wind up passing
--ro-bind-try --ro-bind-try to bwrap, where the second --ro-bind-try is treated as the
source path to mount, and the next flag we pass gets treated as the destination path. The
web process crashes with this confusing error:

bwrap: Can't create file at /.flatpak-info: Read-only file system

UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bindIfExists):

8:01 AM Changeset in webkit [263898] by weinig@apple.com

3 edits in trunk/Source/WebCore

Cleanup ApplicationCacheManifestParser.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=213844

Reviewed by Alex Christensen.

Address some post review comments.

loader/appcache/ApplicationCacheManifestParser.cpp:

(WebCore::parseApplicationCacheManifest):
Fix typos: manfest -> manifest.

loader/appcache/ApplicationCacheManifestParser.h:

Stop including ApplicationCache.h, and only include / declare what's needed.

8:00 AM Changeset in webkit [263897] by clopez@igalia.com

2 edits in trunk/Tools

[WPE][webkitpy] Use headless driver instead of wayland driver
https://bugs.webkit.org/show_bug.cgi?id=213914

Reviewed by Philippe Normand.

WPE now supports running tests completely headless, but we are
still using the webkitpy WaylandDriver to run the tests.
This causes an error if the environment doesn't have defined the
WAYLAND_DISPLAY or WAYLAND_SOCKET environment variables.
Switch the driver to HeadlessDriver.

Scripts/webkitpy/port/wpe.py:

(WPEPort._driver_class):

7:55 AM Changeset in webkit [263896] by youenn@apple.com

7 edits in trunk

Support MediaRecorder.onstart
https://bugs.webkit.org/show_bug.cgi?id=213720

Reviewed by Darin Adler.

Source/WebCore:

Fire start event if MediaRecorder.start is successful.
Do some WebIDL clean-up, in particular change timeSlice from long to unsigned long, as per spec.
Covered by added test.

Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::startRecording):

Modules/mediarecorder/MediaRecorder.h:
Modules/mediarecorder/MediaRecorder.idl:

LayoutTests:

http/wpt/mediarecorder/MediaRecorder-start-timeSlice-expected.txt:
http/wpt/mediarecorder/MediaRecorder-start-timeSlice.html:

7:31 AM Changeset in webkit [263895] by Carlos Garcia Campos

4 edits in trunk

REGRESSION(r261779): [GTK][WPE] http/tests/resourceLoadStatistics/third-party-cookie-blocking-ephemeral.html is failing
https://bugs.webkit.org/show_bug.cgi?id=212017

Reviewed by Michael Catanzaro.

Tools:

Use the ephemeral data store when useEphemeralSession option is enabled.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::platformInitializeDataStore):

LayoutTests:

Remove expectations for tests that are now passing.

platform/gtk/TestExpectations:

7:21 AM Changeset in webkit [263894] by youenn@apple.com

20 edits
1 copy
4 adds in trunk

Allow registering VP9 as a VT decoder
https://bugs.webkit.org/show_bug.cgi?id=213837
<rdar://problem/64984881>

Reviewed by Jer Noble.

Source/ThirdParty/libwebrtc:

Implement a method that registers VP9 as a VT decoder.
Implement the binding code between VP9DecoderImpl and VT pluggable codec API.
Restrict this to internal SDK for now.

Configurations/libwebrtc.iOS.exp:
Configurations/libwebrtc.iOSsim.exp:
Configurations/libwebrtc.mac.exp:
Source/webrtc/sdk/WebKit/WebKitUtilities.h:
Source/webrtc/sdk/WebKit/WebKitUtilities.mm:

(webrtc::createPixelBufferPool):

Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp: Added.

(webrtc::registerWebKitVP9Decoder):
(webrtc::createWebKitVP9Decoder):
(webrtc::invalidateVP9Decoder):
(webrtc::finalizeVP9Decoder):
(webrtc::copyVP9DecoderDebugDescription):
(webrtc::webKitVP9DecoderFromVTDecoder):
(webrtc::startVP9DecoderSession):
(webrtc::decodeVP9DecoderFrameFromContiguousBlock):
(webrtc::decodeVP9DecoderFrame):
(webrtc::WebKitVP9DecoderReceiver::WebKitVP9DecoderReceiver):
(webrtc::WebKitVP9DecoderReceiver::~WebKitVP9DecoderReceiver):
(webrtc::WebKitVP9DecoderReceiver::decoderFailed):
(webrtc::WebKitVP9DecoderReceiver::Decoded):

Source/webrtc/sdk/WebKit/WebKitVP9Decoder.h: Added.
libwebrtc.xcodeproj/project.pbxproj:

Source/WebKit:

Add a runtime flag to enable registration of VP9 as a VT decoder.
Register conditionally this decoder on creation of page based on this flag.

Test: media/vp9.html

Scripts/GeneratePreferences.rb:
Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
Shared/WebPreferences.yaml:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::enableVP9Decoder):

WebProcess/WebProcess.h:

LayoutTests:

media/content/bipbop-vp9.mp4: Added.
media/vp9-expected.txt: Added.
media/vp9.html: Added.

6:12 AM Changeset in webkit [263893] by Lauro Moura

81 edits
1 copy
3 adds
5 deletes in trunk/WebDriverTests

[WebDriver][WPE] Update imported selenium to a version that enables WPE WebDriver tests
https://bugs.webkit.org/show_bug.cgi?id=213916

Reviewed by Carlos Garcia Campos.

Also updated the importer.json file with more paths to be skipped.

imported/selenium/common/.classpath: Removed.
imported/selenium/common/src/web/css/ui-lightness/images/ui-bg_diagonals-thick_18_b81900_40x40.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-bg_diagonals-thick_20_666666_40x40.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-bg_glass_100_f6f6f6_1x400.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-bg_glass_100_fdf5ce_1x400.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-bg_glass_65_ffffff_1x400.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-bg_gloss-wave_35_f6a828_500x100.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-bg_highlight-soft_100_eeeeee_1x100.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-bg_highlight-soft_75_ffe45c_1x100.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-icons_222222_256x240.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-icons_228ef1_256x240.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-icons_ef8c08_256x240.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-icons_ffd27a_256x240.png:
imported/selenium/common/src/web/css/ui-lightness/images/ui-icons_ffffff_256x240.png:
imported/selenium/common/src/web/css/ui-lightness/jquery-ui-1.12.1.min.css: Added.
imported/selenium/common/src/web/css/ui-lightness/jquery-ui-1.8.10.custom.css: Removed.
imported/selenium/common/src/web/draggableLists.html:
imported/selenium/common/src/web/droppableItems.html:
imported/selenium/common/src/web/jquery-1.3.2.js: Removed.
imported/selenium/common/src/web/js/jquery-1.4.4.min.js: Removed.
imported/selenium/common/src/web/js/jquery-3.5.1.min.js: Added.
imported/selenium/common/src/web/js/jquery-ui-1.12.1.min.js: Added.
imported/selenium/common/src/web/js/jquery-ui-1.8.10.custom.min.js: Removed.
imported/selenium/common/src/web/mousePositionTracker.html:
imported/selenium/common/src/web/selectableItems.html:
imported/selenium/importer.json:
imported/selenium/py/conftest.py:
imported/selenium/py/selenium/init.py:
imported/selenium/py/selenium/webdriver/init.py:
imported/selenium/py/selenium/webdriver/common/action_chains.py:
imported/selenium/py/selenium/webdriver/common/actions/action_builder.py:
imported/selenium/py/selenium/webdriver/common/actions/pointer_actions.py:
imported/selenium/py/selenium/webdriver/common/actions/pointer_input.py:
imported/selenium/py/selenium/webdriver/common/desired_capabilities.py:
imported/selenium/py/selenium/webdriver/common/html5/application_cache.py:
imported/selenium/py/selenium/webdriver/common/keys.py:
imported/selenium/py/selenium/webdriver/common/options.py:
imported/selenium/py/selenium/webdriver/common/service.py:
imported/selenium/py/selenium/webdriver/common/timeouts.py:
imported/selenium/py/selenium/webdriver/common/window.py:
imported/selenium/py/selenium/webdriver/remote/file_detector.py:
imported/selenium/py/selenium/webdriver/remote/remote_connection.py:
imported/selenium/py/selenium/webdriver/remote/switch_to.py:
imported/selenium/py/selenium/webdriver/remote/webdriver.py:
imported/selenium/py/selenium/webdriver/remote/webelement.py:
imported/selenium/py/selenium/webdriver/support/color.py:
imported/selenium/py/selenium/webdriver/support/event_firing_webdriver.py:
imported/selenium/py/selenium/webdriver/support/expected_conditions.py:
imported/selenium/py/selenium/webdriver/support/relative_locator.py:
imported/selenium/py/selenium/webdriver/support/select.py:
imported/selenium/py/selenium/webdriver/support/wait.py:
imported/selenium/py/selenium/webdriver/wpewebkit/options.py:
imported/selenium/py/test/selenium/webdriver/common/alerts_tests.py:
imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py:
imported/selenium/py/test/selenium/webdriver/common/appcache_tests.py:
imported/selenium/py/test/selenium/webdriver/common/children_finding_tests.py:
imported/selenium/py/test/selenium/webdriver/common/clear_tests.py:
imported/selenium/py/test/selenium/webdriver/common/click_scrolling_tests.py:
imported/selenium/py/test/selenium/webdriver/common/cookie_tests.py:
imported/selenium/py/test/selenium/webdriver/common/correct_event_firing_tests.py:
imported/selenium/py/test/selenium/webdriver/common/driver_element_finding_tests.py:
imported/selenium/py/test/selenium/webdriver/common/element_attribute_tests.py:
imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py:
imported/selenium/py/test/selenium/webdriver/common/executing_javascript_tests.py:
imported/selenium/py/test/selenium/webdriver/common/form_handling_tests.py:
imported/selenium/py/test/selenium/webdriver/common/frame_switching_tests.py:
imported/selenium/py/test/selenium/webdriver/common/google_one_box.py:
imported/selenium/py/test/selenium/webdriver/common/implicit_waits_tests.py:
imported/selenium/py/test/selenium/webdriver/common/interactions_tests.py:
imported/selenium/py/test/selenium/webdriver/common/page_load_timeout_tests.py:
imported/selenium/py/test/selenium/webdriver/common/page_loading_tests.py:
imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py:
imported/selenium/py/test/selenium/webdriver/common/repr_tests.py:
imported/selenium/py/test/selenium/webdriver/common/results_page.py:
imported/selenium/py/test/selenium/webdriver/common/select_class_tests.py:
imported/selenium/py/test/selenium/webdriver/common/stale_reference_tests.py:
imported/selenium/py/test/selenium/webdriver/common/takes_screenshots_tests.py:
imported/selenium/py/test/selenium/webdriver/common/text_handling_tests.py:
imported/selenium/py/test/selenium/webdriver/common/timeout_tests.py:
imported/selenium/py/test/selenium/webdriver/common/typing_tests.py:
imported/selenium/py/test/selenium/webdriver/common/visibility_tests.py:
imported/selenium/py/test/selenium/webdriver/common/w3c_interaction_tests.py:
imported/selenium/py/test/selenium/webdriver/common/webdriverwait_tests.py:
imported/selenium/py/test/selenium/webdriver/common/window_switching_tests.py:
imported/selenium/py/test/selenium/webdriver/common/window_tests.py:
imported/selenium/py/test/selenium/webdriver/remote/remote_hub_connection.py: Copied from WebDriverTests/imported/selenium/py/selenium/webdriver/common/window.py.
imported/selenium/py/test/selenium/webdriver/safari/launcher_tests.py:
imported/selenium/py/test/selenium/webdriver/support/event_firing_webdriver_tests.py:
imported/selenium/py/test/selenium/webdriver/support/relative_by_tests.py:

5:58 AM Changeset in webkit [263892] by youenn@apple.com

4 edits
2 adds in trunk

MediaRecorder.start() Method is Ignoring the "timeslice" Parameter
https://bugs.webkit.org/show_bug.cgi?id=202233
<rdar://problem/55720555>

Reviewed by Eric Carlson.

Source/WebCore:

Use a timer to implement timeSlice parameter.
Schedule timer either when start is called or as part of requestData callback.
This should ensure that, if requestData is called by the application, the timer will be rescheduled appropriately.

Test: http/wpt/mediarecorder/MediaRecorder-start-timeSlice.html

Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::startRecording):
(WebCore::MediaRecorder::requestData):

Modules/mediarecorder/MediaRecorder.h:

LayoutTests:

http/wpt/mediarecorder/MediaRecorder-start-timeSlice-expected.txt: Added.
http/wpt/mediarecorder/MediaRecorder-start-timeSlice.html: Added.

5:01 AM Changeset in webkit [263891] by youenn@apple.com

16 edits
2 adds in trunk

MediaRecorder stopRecorder() returns empty Blob after first use
https://bugs.webkit.org/show_bug.cgi?id=212274
<rdar://problem/63601298>

Reviewed by Eric Carlson.

Source/WebCore:

Refactor code to create/destroy MediaRecorderPrivate on MediaRecorder start/stop.
This allows reusing a MediaRecorder after a stop and restarting with a clean state.

We introduce MediaRecorderPrivate::startRecording to do the initialization,
which allows to fix a potential ref cycle as part of the error callback handling.

Make some improvements to the platform implementation, in particular add default initialization to all fields.
Align the code using AudioConverterRef to what is done in AudioSampleDataSource.
Also call VTCompressionSessionInvalidate when destroying the VideoSampleBufferCompressor.

Test: http/wpt/mediarecorder/MediaRecorder-multiple-start-stop.html

Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::create):
(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::startRecording):
(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::requestData):

Modules/mediarecorder/MediaRecorder.h:
platform/mediarecorder/MediaRecorderPrivateMock.cpp:

(WebCore::MediaRecorderPrivateMock::fetchData):

platform/mediarecorder/MediaRecorderPrivate.h:

(WebCore::MediaRecorderPrivate::startRecording):

platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:

(WebCore::AudioSampleBufferCompressor::~AudioSampleBufferCompressor):
(WebCore::AudioSampleBufferCompressor::initAudioConverterForSourceFormatDescription):
(WebCore::AudioSampleBufferCompressor::attachPrimingTrimsIfNeeded):
(WebCore::AudioSampleBufferCompressor::gradualDecoderRefreshCount):
(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):
(WebCore::AudioSampleBufferCompressor::processSampleBuffersUntilLowWaterTime):

platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::stopRecording):

platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:

(WebCore::VideoSampleBufferCompressor::~VideoSampleBufferCompressor):

Source/WebKit:

Update implementation to do initialization as part of startRecording.

GPUProcess/webrtc/RemoteMediaRecorderManager.cpp:

(WebKit::RemoteMediaRecorderManager::releaseRecorder):
Remove ASSERT as recorder creation in WebProcess is always ok while creation in GPUProcess may fail and m_recorders may not be populated.

WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:

(WebKit::MediaRecorderPrivate::MediaRecorderPrivate):
(WebKit::MediaRecorderPrivate::startRecording):

WebProcess/GPU/webrtc/MediaRecorderPrivate.h:

LayoutTests:

http/wpt/mediarecorder/MediaRecorder-multiple-start-stop-expected.txt: Added.
http/wpt/mediarecorder/MediaRecorder-multiple-start-stop.html: Added.

2:35 AM Changeset in webkit [263890] by commit-queue@webkit.org

28 edits in trunk/Source

Change the names of MIMETypeRegistry methods to comply with webkit naming style
https://bugs.webkit.org/show_bug.cgi?id=213912

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-07-03
Reviewed by Youenn Fablet.

Source/WebCore:

Remove the verb 'get' from the name of some of the methods of MIMETypeRegistry.

editing/cocoa/WebArchiveResourceFromNSAttributedString.mm:

(WebCore::if):

fileapi/File.cpp:

(WebCore::File::computeNameAndContentType):

html/HTMLPlugInElement.cpp:

(WebCore::pluginReplacementForType):

loader/mac/LoaderNSURLExtras.mm:

(suggestedFilenameWithMIMEType):

platform/MIMETypeRegistry.cpp:

(WebCore::commonMimeTypesMap):
(WebCore::MIMETypeRegistry::mediaMIMETypeForExtension):
(WebCore::MIMETypeRegistry::mimeTypeForPath):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::normalizedMIMEType):
(WebCore::MIMETypeRegistry::appendFileExtensionIfNecessary):
(WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Deleted.
(WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): Deleted.
Delete this function since it is not used.

(WebCore::MIMETypeRegistry::getMIMETypeForPath): Deleted.
(WebCore::MIMETypeRegistry::getNormalizedMIMEType): Deleted.

platform/MIMETypeRegistry.h:
platform/cocoa/MIMETypeRegistryCocoa.mm:

(WebCore::MIMETypeRegistry::mimeTypeForExtension):
(WebCore::MIMETypeRegistry::extensionsForMIMEType):
(WebCore::MIMETypeRegistry::preferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::getMIMETypeForExtension): Deleted.
(WebCore::MIMETypeRegistry::getExtensionsForMIMEType): Deleted.
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): Deleted.

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::load):

platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::filenameExtension const):

platform/graphics/gstreamer/ImageDecoderGStreamer.h:
platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::invokeDidReceiveResponseForFile):

platform/playstation/MIMETypeRegistryPlayStation.cpp:

(WebCore::MIMETypeRegistry::mimeTypeForExtension):
(WebCore::MIMETypeRegistry::preferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::extensionsForMIMEType):
(WebCore::MIMETypeRegistry::getMIMETypeForExtension): Deleted.
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): Deleted.
(WebCore::MIMETypeRegistry::getExtensionsForMIMEType): Deleted.

platform/win/MIMETypeRegistryWin.cpp:

(WebCore::MIMETypeRegistry::preferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::mimeTypeForExtension):
(WebCore::MIMETypeRegistry::extensionsForMIMEType):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): Deleted.
(WebCore::MIMETypeRegistry::getMIMETypeForExtension): Deleted.
(WebCore::MIMETypeRegistry::getExtensionsForMIMEType): Deleted.

platform/xdg/MIMETypeRegistryXdg.cpp:

Source/WebKit:

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::didSendRequest):

UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::mimeTypeInferredFromFileExtension):
(API::Attachment::setFileWrapperAndUpdateContentType):

UIProcess/API/Cocoa/WKOpenPanelParameters.mm:

(-[WKOpenPanelParameters _allowedFileExtensions]):

UIProcess/API/glib/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback):

UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::fileCanBeAcceptedForUpload):

UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::findPlugin):

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel presentWithParameters:resultListener:]):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::objectContentType):

Source/WebKitLegacy/ios:

WebCoreSupport/WebMIMETypeRegistry.mm:

(+[WebMIMETypeRegistry mimeTypeForExtension:]):
(+[WebMIMETypeRegistry preferredExtensionForMIMEType:]):

Source/WebKitLegacy/win:

WebView.cpp:

(WebView::MIMETypeForExtension):

2:18 AM Changeset in webkit [263889] by ysuzuki@apple.com

4 edits
1 add in trunk

[JSC] Add exception checks in JSStringBuilder and Array#join
https://bugs.webkit.org/show_bug.cgi?id=213915
<rdar://problem/64878225>

Reviewed by Saam Barati and Mark Lam.

JSTests:

stress/out-of-memory-handle-in-join.js: Added.

(shouldThrow):

Source/JavaScriptCore:

This patch adds missing exception checks into Array#join's certain place and JSStringBuilder.

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

runtime/JSStringJoiner.h:

(JSC::JSStringJoiner::append):

2:06 AM Changeset in webkit [263888] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK4] Enable threaded rendering by default
https://bugs.webkit.org/show_bug.cgi?id=213883

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-07-03
Reviewed by Adrian Perez de Castro.

When building with GTK4 we no longer use the cairo context to render directly, so we can always enable the
threaded rendering. In WPE port threaded rendering is only enabled when env var WEBKIT_NICOSIA_PAINTING_THREADS
is present. This patch changes a bit the meaning of the env var, so that when 0 is passed the feature is
disabled too, instead of setting the number of threads to 4.

platform/graphics/nicosia/NicosiaPaintingEngine.cpp:

(Nicosia::PaintingEngine::create):

1:37 AM Changeset in webkit [263887] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit

[GTK4] Support kinetic scrolling
https://bugs.webkit.org/show_bug.cgi?id=213791

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2020-07-03
Reviewed by Carlos Garcia Campos.

GtkEventControllerScroll skips the last event and exposes it in a separate signal.
Normally one would add the KINETIC flag and listen to decelerate signal, but since
WebKit already has code for calculating the velocity for GTK3, just use the same
code path as scroll signal handler.

Shared/gtk/NativeWebWheelEventGtk.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

Shared/gtk/WebEventFactory.h:
UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseScrollEnd):
(webkitWebViewBaseConstructed):

12:42 AM Changeset in webkit [263886] by Diego Pino Garcia

25 edits
6 adds
4 deletes in trunk/LayoutTests

Unreviewed test gardening. Update test expectations and baselines after r263858.

Baselines need to be updated after r263856. Some PNG images moved to
GLIB as their text output was on GLIB as well.

Filed a test crashing after r263858.

platform/glib/TestExpectations:
platform/glib/fast/css/percentage-non-integer-expected.png: Added.
platform/glib/fast/css/percentage-non-integer-expected.txt:
platform/glib/tables/mozilla/bugs/bug100334-expected.png: Added.
platform/glib/tables/mozilla/bugs/bug100334-expected.txt:
platform/glib/tables/mozilla/bugs/bug3037-1-expected.png: Added.
platform/glib/tables/mozilla/bugs/bug3037-1-expected.txt:
platform/glib/tables/mozilla_expected_failures/other/empty_cells-expected.png: Added.
platform/glib/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
platform/gtk/TestExpectations:
platform/gtk/fast/css/percentage-non-integer-expected.png: Removed.
platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
platform/gtk/fast/repaint/table-cell-move-expected.png:
platform/gtk/fast/repaint/table-cell-move-expected.txt:
platform/gtk/fast/table/cell-absolute-child-expected.png:
platform/gtk/fast/table/cell-absolute-child-expected.txt:
platform/gtk/fast/table/empty-cells-expected.png:
platform/gtk/fast/table/empty-cells-expected.txt:
platform/gtk/fast/table/prepend-in-anonymous-table-expected.png:
platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
platform/gtk/tables/mozilla/bugs/bug100334-expected.png: Removed.
platform/gtk/tables/mozilla/bugs/bug10633-expected.png:
platform/gtk/tables/mozilla/bugs/bug10633-expected.txt:
platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
platform/gtk/tables/mozilla/bugs/bug1302-expected.png:
platform/gtk/tables/mozilla/bugs/bug1302-expected.txt:
platform/gtk/tables/mozilla/bugs/bug16012-expected.png:
platform/gtk/tables/mozilla/bugs/bug16012-expected.txt:
platform/gtk/tables/mozilla/bugs/bug222336-expected.png: Added.
platform/gtk/tables/mozilla/bugs/bug222336-expected.txt: Added.
platform/gtk/tables/mozilla/bugs/bug3037-1-expected.png: Removed.
platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.png: Removed.

12:21 AM Changeset in webkit [263885] by Fujii Hironori

3 edits in trunk/Source/JavaScriptCore

Builtin internal wrapper implementation files wrap static global initialization code with incorrect guards
https://bugs.webkit.org/show_bug.cgi?id=213792

Reviewed by Youenn Fablet.

Streams API hadn't worked since r263700 for AppleWin and WinCairo
ports. r263700 removed the unused ENABLE_STREAMS_API.

Before r263700, the static global initialization code was wrapped

by "ENABLE(WEB_RTC)

ENABLE(STREAMS_API)". After r263700, it was

wrapped by "ENABLE(WEB_RTC)". AppleWin and WinCairo doesn't turn
on ENABLE_WEB_RTC. So, builtins for Streams API weren't properly
initialized for them.

Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result: Rebaselined.
Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py:

(BuiltinsInternalsWrapperImplementationGenerator.generate_initialize_method):
Removed calling wrap_with_guard for the value of _generate_initialize_static_globals().

12:15 AM Changeset in webkit [263884] by Fujii Hironori

7 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

platform/wincairo/fast/css/acid2-expected.txt:
platform/wincairo/fast/css/acid2-pixel-expected.txt:
platform/wincairo/fast/css/percentage-non-integer-expected.txt:
platform/wincairo/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
platform/wincairo/http/tests/misc/acid2-expected.txt:
platform/wincairo/http/tests/misc/acid2-pixel-expected.txt:

Jul 2, 2020:

10:51 PM Changeset in webkit [263883] by mark.lam@apple.com

7 edits in trunk/Source/WebCore

ReadableStream::create() should handle any exceptions that may be thrown during construction.
https://bugs.webkit.org/show_bug.cgi?id=213819

Reviewed by Youenn Fablet and Yusuke Suzuki.

Win EWS detected that ReadableStream::create() can throw exceptions, and we were
failing to handle it. This patch fixes that.

Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::put):

Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::readableStream):
(WebCore::FetchBodyOwner::createReadableStream):

Modules/fetch/FetchBodyOwner.h:
Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::clone):

bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::create):

bindings/js/ReadableStream.h:

9:17 PM Changeset in webkit [263882] by commit-queue@webkit.org

24 edits in trunk/Source

Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory
https://bugs.webkit.org/show_bug.cgi?id=213048

Patch by Alex Christensen <achristensen@webkit.org> on 2020-07-02
Reviewed by Youenn Fablet.

Source/WebCore/PAL:

pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

This uses CFNetwork SPI introduced in rdar://problem/50109631 to allow HSTS storage per NSURLSession.
To be complete, I also deprecated our UI process HSTS state removal attempt SPIs, WKContextResetHSTSHosts and
WKContextResetHSTSHostsAddedAfterDate, which had their last use removed in rdar://problem/64220838.

I manually verified that this new SPI puts HSTS data in the specified location, and I also verified that HSTS
state querying and removal works with the new CFNetwork SPI as it did with the old one.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkSessionCreationParameters.cpp:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

NetworkProcess/NetworkSessionCreationParameters.h:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::hostNamesWithHSTSCache const):
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
(WebKit::NetworkProcess::clearHSTSCache):
(WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted.

NetworkProcess/cocoa/NetworkSessionCocoa.h:
NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::hstsStorage const):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

NetworkProcess/soup/NetworkProcessSoup.cpp:

UIProcess/API/C/mac/WKContextPrivateMac.h:
UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextResetHSTSHosts):
(WKContextResetHSTSHostsAddedAfterDate):

UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:

(-[_WKWebsiteDataStoreConfiguration hstsStorageDirectory]):
(-[_WKWebsiteDataStoreConfiguration setHSTSStorageDirectory:]):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::privateBrowsingSession): Deleted.
(WebKit::WebProcessPool::resetHSTSHosts): Deleted.
(WebKit::WebProcessPool::resetHSTSHostsAddedAfterDate): Deleted.

UIProcess/WebProcessPool.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::parameters):

UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::resolvedHSTSStorageDirectory const):

UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:

(WebKit::WebsiteDataStoreConfiguration::copy const):

UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:

Source/WTF:

wtf/PlatformHave.h:

8:40 PM Changeset in webkit [263881] by achristensen@apple.com

13 edits in trunk

Update Mac CMake build

Source/cmake/OptionsMac.cmake:

Source/JavaScriptCore:

PlatformMac.cmake:

Source/WebCore:

PlatformMac.cmake:

Source/WebKit:

PlatformMac.cmake:

Source/WebKitLegacy:

PlatformMac.cmake:

Tools:

DumpRenderTree/PlatformMac.cmake:
WebKitTestRunner/PlatformMac.cmake:

8:19 PM Changeset in webkit [263880] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

MIMETypeRegistry::getExtensionsForMIMEType() needs to handle wildcard MIME types
https://bugs.webkit.org/show_bug.cgi?id=213826

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-07-02
Reviewed by Darin Adler.

Addressing post commit review comments for r263832.

platform/cocoa/MIMETypeRegistryCocoa.mm:

(WebCore::extensionsForMIMETypeMap):

7:01 PM Changeset in webkit [263879] by commit-queue@webkit.org

8 edits in trunk

Add testing infrastructure and SPI declaration for HTTP/2 ping
https://bugs.webkit.org/show_bug.cgi?id=213913

Patch by Alex Christensen <achristensen@webkit.org> on 2020-07-02
Reviewed by Jer Noble.

Source/WebCore/PAL:

pal/spi/cf/CFNetworkSPI.h:

Source/WTF:

This is work towards rdar://problem/64495827

wtf/PlatformHave.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm:

(-[SessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(TestWebKitAPI::pingPong):
(TestWebKitAPI::TEST):

TestWebKitAPI/cocoa/HTTPServer.h:

(TestWebKitAPI::H2::Frame::Frame):
(TestWebKitAPI::H2::Frame::type const):
(TestWebKitAPI::H2::Frame::flags const):
(TestWebKitAPI::H2::Frame::streamID const):
(TestWebKitAPI::H2::Frame::payload const):
(TestWebKitAPI::H2::Connection::create):
(TestWebKitAPI::H2::Connection::Connection):

TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::listenerParameters):
(TestWebKitAPI::dataFromVector):
(TestWebKitAPI::vectorFromData):
(TestWebKitAPI::HTTPServer::request const):
(TestWebKitAPI::Connection::receiveBytes const):
(TestWebKitAPI::Connection::receiveHTTPRequest const):
(TestWebKitAPI::Connection::send const):
(TestWebKitAPI::H2::Connection::send const):
(TestWebKitAPI::H2::Connection::receive const):

6:05 PM Changeset in webkit [263878] by beidson@apple.com

3 edits
3 adds in trunk/Source/WebCore

GameController.framework soft linking refactoring
https://bugs.webkit.org/show_bug.cgi?id=213909

Reviewed by Tim Horton.

No new tests (No behavior changes)

WebCore.xcodeproj/project.pbxproj:
platform/gamepad/cocoa/GameControllerGamepadProvider.mm:

(WebCore::GameControllerGamepadProvider::startMonitoringGamepads):

platform/gamepad/cocoa/GameControllerSPI.h: Added.
platform/gamepad/cocoa/GameControllerSoftLink.h: Added.
platform/gamepad/cocoa/GameControllerSoftLink.mm: Added.

5:22 PM Changeset in webkit [263877] by Kocsen Chung

1 copy in tags/Safari-610.1.20.2

Tag Safari-610.1.20.2.

5:17 PM Changeset in webkit [263876] by Kocsen Chung

16 edits
2 deletes in branches/safari-610.1.20-branch

Cherry-pick r263854. rdar://problem/65048370

Unreviewed, reverting r263633, r263651, and r263671.

Still seeing MediaRecorder test crashes after re-landing
r263633

Reverted changesets:

"MediaRecorder stopRecorder() returns empty Blob after first
use"
https://bugs.webkit.org/show_bug.cgi?id=212274
https://trac.webkit.org/changeset/263633

"MediaRecorder.start() Method is Ignoring the "timeslice"
Parameter"
https://bugs.webkit.org/show_bug.cgi?id=202233
https://trac.webkit.org/changeset/263651

"Support MediaRecorder.onstart"
https://bugs.webkit.org/show_bug.cgi?id=213720
https://trac.webkit.org/changeset/263671

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:08 PM Changeset in webkit [263875] by Kocsen Chung

8 edits in branches/safari-610.1.20-branch/Source

Versioning.

WebKit-610.1.20.2

4:15 PM Changeset in webkit [263874] by Kate Cheney

8 edits in trunk

Custom URL schemes should be treated as app-bound
https://bugs.webkit.org/show_bug.cgi?id=213889
<rdar://problem/64804671>

Reviewed by Brent Fulgham.

Source/WebKit:

For applications which opt-in to App-Bound Domains, allow
specification of app-bound custom URL schemes. All content loaded
using an app-bound scheme will have access to otherwise restricted
APIs. A custom scheme is specified by a colon at the end of a string
in the WKAppBoundDomains list. Custom schemes are included in the
count of 10 app-bound domains.

UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _appBoundSchemes:]):

UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

SPI for testing.

UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::appBoundSchemes):
(WebKit::WebsiteDataStore::initializeAppBoundDomains):
Change variable name from appBoundDomains to appBoundData now that
more than domains can be specified in the Info.plist.

(WebKit::WebsiteDataStore::ensureAppBoundDomains const):
Return both domains and schemes to avoid code duplication, at the expense
of occasionally returning an unused parameter if only domains or only
schemes are needed.

(WebKit::WebsiteDataStore::beginAppBoundDomainCheck):
(WebKit::WebsiteDataStore::getAppBoundDomains const):
(WebKit::WebsiteDataStore::getAppBoundSchemes const):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

Added custom schemes to TestWebKitAPI's Info.plist for testing
duplicate values and the max of 10 domains/schemes. Added
two API tests to check that schemes are properly read from the
Info.plist and that content loaded using a specified app-bound scheme
has restricted API use.

TestWebKitAPI/Info.plist:
TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(TEST):

3:50 PM Changeset in webkit [263873] by Alan Coon

1 copy in tags/Safari-610.1.20.1

Tag Safari-610.1.20.1.

3:49 PM Changeset in webkit [263872] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Allow selecting text of Response (DOM Tree)
https://bugs.webkit.org/show_bug.cgi?id=213617

Reviewed by Joseph Pecoraro.

UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom.non-selectable):

3:49 PM Changeset in webkit [263871] by Alan Coon

3 edits in branches/safari-610.1.20-branch/Source/ThirdParty/libwebrtc

Apply patch. rdar://problem/64901603

3:44 PM Changeset in webkit [263870] by Alan Coon

1 delete in tags/Safari-610.1.20.1

Delete tag.

3:43 PM Changeset in webkit [263869] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Crash in +[UIViewController _viewControllerForFullScreenPresentationFromView:] when WKContentView is deallocated
https://bugs.webkit.org/show_bug.cgi?id=213867

Patch by Austin Blackwood <ablackwoood@apple.com> on 2020-07-02
Reviewed by Darin Adler.

+[UIViewController _viewControllerForFullScreenPresentationFromView:]
asserts that the view parameter is non-nil. WKFileUploadPanel
passes its view (a weak pointer to the WKContentView), which may
have already been nil'd out when the content view tries to dismiss
the panel in its own dealloc.

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel dismiss]):
Check for nil.

3:42 PM Changeset in webkit [263868] by Alan Coon

3 edits in branches/safari-610.1.20-branch/Source/ThirdParty/libwebrtc

Revert r263828. rdar://problem/64901603

3:37 PM Changeset in webkit [263867] by Alan Coon

1 copy in tags/Safari-610.1.20.1

Tag Safari-610.1.20.1.

3:36 PM Changeset in webkit [263866] by Alan Coon

3 edits in branches/safari-610.1.20-branch/Source/ThirdParty/libwebrtc

Cherry-pick r263828. rdar://problem/64901603

Fix the arm64 iOS simulator build
https://bugs.webkit.org/show_bug.cgi?id=213868
<rdar://problem/64901603>

Configurations/libvpx.xcconfig:
Configurations/libwebrtc.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:31 PM Changeset in webkit [263865] by Alan Coon

8 edits in branches/safari-610.1.20-branch/Source

Versioning.

WebKit-610.1.20.1

3:31 PM Changeset in webkit [263864] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[ macOS wk1 ] imported/w3c/web-platform-tests/css/css-flexbox/overflow-auto-008.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=213896

Unreviewed test gardening.

Added prefix with bug

Patch by Karl Rackler <Karl Rackler> on 2020-07-02

platform/mac-wk1/TestExpectations:

3:30 PM Changeset in webkit [263863] by Alan Coon

16 edits
2 adds in branches/safari-610.1.20-branch

Revert r263854. rdar://problem/65048370

2:38 PM Changeset in webkit [263862] by Alan Coon

1 copy in tags/Safari-610.1.20

Tag Safari-610.1.20.

2:11 PM Changeset in webkit [263861] by Alan Coon

16 edits
2 deletes in branches/safari-610.1.20-branch

Cherry-pick r263854. rdar://problem/65048370

Unreviewed, reverting r263633, r263651, and r263671.

Still seeing MediaRecorder test crashes after re-landing
r263633

Reverted changesets:

"MediaRecorder stopRecorder() returns empty Blob after first
use"
https://bugs.webkit.org/show_bug.cgi?id=212274
https://trac.webkit.org/changeset/263633

"MediaRecorder.start() Method is Ignoring the "timeslice"
Parameter"
https://bugs.webkit.org/show_bug.cgi?id=202233
https://trac.webkit.org/changeset/263651

"Support MediaRecorder.onstart"
https://bugs.webkit.org/show_bug.cgi?id=213720
https://trac.webkit.org/changeset/263671

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [263860] by Simon Fraser

3 edits
2 adds in trunk

REGRESSION(r260276): menu items in footer of https://salo.ai are invisible until you hover or resize
https://bugs.webkit.org/show_bug.cgi?id=213712
<rdar://problem/64893190>

Reviewed by Zalan Bujtas.

Source/WebCore:

A negative z-index child triggers a foreground layer inside overflow scroll. This foreground layer
gets the PaintingOverflowContents flag but not the PaintingCompositingScrollingPhase flag, but we still need
to avoid the clip check that happens in RenderBlock::paint(), so change RenderLayer::paintLayerContents()
to just check for isPaintingOverflowContents.

Test: compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase-expected.html: Added.
compositing/scrolling/async-overflow-scrolling/foreground-layer-paint-phase.html: Added.

1:35 PM Changeset in webkit [263859] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[ macOS wk1 ] imported/w3c/web-platform-tests/css/css-flexbox/overflow-auto-008.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=213896

Unreviewed test gardening.

Patch by Karl Rackler <Karl Rackler> on 2020-07-02

platform/mac-wk1/TestExpectations:

1:35 PM Changeset in webkit [263858] by graouts@webkit.org

3 edits
2 adds in trunk

visualViewport.addEventListener("scroll"* fires permanently after zoom or orientation change
https://bugs.webkit.org/show_bug.cgi?id=211522
<rdar://problem/62939371>

Reviewed by Simon Fraser.

Source/WebCore:

Correctly set the flag indicating that a scroll event has been dispatched on the visual viewport.

Test: fast/visual-viewport/scroll-event-fired-during-scroll-alone.html

dom/Document.cpp:

(WebCore::Document::runScrollSteps):

LayoutTests:

Add a test that checks that after a call to scrollTo() no further "scroll" events are dispatched on window.visualViewport.

fast/visual-viewport/scroll-event-fired-during-scroll-alone-expected.txt: Added.
fast/visual-viewport/scroll-event-fired-during-scroll-alone.html: Added.

1:26 PM Changeset in webkit [263857] by Chris Dumez

3 edits in trunk/Source/WebKit

FloatingPointEnvironment::saveMainThreadEnvironment() is not called for macOS Catalyst apps on Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=213897
<rdar://problem/64607098>

Reviewed by Darin Adler.

FloatingPointEnvironment::saveMainThreadEnvironment() is not called for macOS Catalyst apps on Apple Silicon
This causes crashes because FloatingPointEnvironment::propagateMainThreadEnvironment() is called for worker
threads for such apps on this platform.

Shared/ios/AuxiliaryProcessIOS.mm:

(WebKit::AuxiliaryProcess::initializeSandbox):
Drop some dead code for PLATFORM(MACCATALYST) since the whole file is protected with !PLATFORM(MACCATALYST).
Mac Catalyst uses AuxiliaryProcessMac.mm instead.

Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::AuxiliaryProcess::platformInitialize):
Call FloatingPointEnvironment::saveMainThreadEnvironment() on AuxiliaryProcessMac.mm since this
platformInitialize() is used for Mac Catalyst and Catalyst apps may now run on Apple Silicon / ARM.
Note that FloatingPointEnvironment::saveMainThreadEnvironment() is a no-op on platforms where it is
not needed.

12:54 PM Changeset in webkit [263856] by Chris Dumez

54 edits
2 copies
43 adds in trunk/LayoutTests

Resync web-platform-tests/html/browsers from upstream
https://bugs.webkit.org/show_bug.cgi?id=213892

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Resync web-platform-tests/html/browsers from upstream 145839c323ba1ec8b9737.

resources/import-expectations.json:
resources/resource-files.json:
web-platform-tests/html/browsers/*: Updated.

LayoutTests:

tests-options.json:

12:45 PM Changeset in webkit [263855] by Alan Bujtas

58 edits in trunk

Overlapping content on earny.co
https://bugs.webkit.org/show_bug.cgi?id=213864
<rdar://problem/61011802>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/css-writing-modes/orthogonal-parent-shrink-to-fit-001-expected.txt:
web-platform-tests/css/css-writing-modes/orthogonal-parent-shrink-to-fit-001q-expected.txt:
web-platform-tests/css/css-writing-modes/orthogonal-parent-shrink-to-fit-001r-expected.txt:
web-platform-tests/css/css-writing-modes/orthogonal-parent-shrink-to-fit-001u-expected.txt:
web-platform-tests/css/css-writing-modes/orthogonal-parent-shrink-to-fit-001v-expected.txt:

Source/WebCore:

Do not use a 1px value for initial min/max content width.

rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout): I found 2 places where we rely on the initial 1px value for min/max width. This might cause some "regression".

LayoutTests:

Progressions. Some of them are visually observable and they match Chrome/FF.

css2.1/20110323/abspos-containing-block-initial-004e-expected.txt:
css2.1/20110323/abspos-containing-block-initial-004f-expected.txt:
fast/table/auto-100-percent-width-expected.txt:
fast/table/large-shrink-wrapped-width.html:
fast/table/table-section-split-with-after-content-expected.txt:
platform/mac/fast/css/acid2-expected.txt:
platform/mac/fast/css/acid2-pixel-expected.txt:
platform/mac/fast/css/percentage-non-integer-expected.txt:
platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
platform/mac/fast/repaint/table-cell-move-expected.txt:
platform/mac/fast/table/cell-absolute-child-expected.txt:
platform/mac/fast/table/empty-cells-expected.txt:
platform/mac/fast/table/prepend-in-anonymous-table-expected.txt:
platform/mac/fast/table/table-cell-split-expected.txt:
platform/mac/fast/table/table-insert-before-non-anonymous-block-expected.txt:
platform/mac/http/tests/misc/acid2-expected.txt:
platform/mac/http/tests/misc/acid2-pixel-expected.txt:
platform/mac/http/tests/misc/acid3-expected.txt:
platform/mac/tables/mozilla/bugs/bug100334-expected.txt:
platform/mac/tables/mozilla/bugs/bug10633-expected.txt:
platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
platform/mac/tables/mozilla/bugs/bug1302-expected.txt:
platform/mac/tables/mozilla/bugs/bug16012-expected.txt:
platform/mac/tables/mozilla/bugs/bug222336-expected.txt:
platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:
platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.txt:

12:34 PM Changeset in webkit [263854] by Ryan Haddad

17 edits
4 deletes in trunk

Unreviewed, reverting r263633, r263651, and r263671.

Still seeing MediaRecorder test crashes after re-landing
r263633

Reverted changesets:

"MediaRecorder stopRecorder() returns empty Blob after first
use"
https://bugs.webkit.org/show_bug.cgi?id=212274
https://trac.webkit.org/changeset/263633

"MediaRecorder.start() Method is Ignoring the "timeslice"
Parameter"
https://bugs.webkit.org/show_bug.cgi?id=202233
https://trac.webkit.org/changeset/263651

"Support MediaRecorder.onstart"
https://bugs.webkit.org/show_bug.cgi?id=213720
https://trac.webkit.org/changeset/263671

12:26 PM adenilson_webkit_contributors_2019.pdf attached to zliboptimizationsforARM by cavalcantii@gmail.com

11:56 AM Changeset in webkit [263853] by Antti Koivisto

3 edits
2 adds in trunk

REGRESSION: Comments section at dpreview has overlapping names with comment on phone
https://bugs.webkit.org/show_bug.cgi?id=213890
Source/WebCore:

<rdar://problem/64693599>

Reviewed by Simon Fraser.

Test: fast/text-autosizing/ios/float-miscomputed-line-height.html

rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

Negative value is used to indicate unset line-height. We shouldn't make adjustments in this case.
This matches Style::BuilderCustom code.

LayoutTests:

Reviewed by Simon Fraser.

fast/text-autosizing/ios/float-miscomputed-line-height-expected.html: Added.
fast/text-autosizing/ios/float-miscomputed-line-height.html: Added.

11:45 AM Changeset in webkit [263852] by Chris Dumez

2 edits in trunk/Source/WebKit

Crash under WebKit::NetworkProcessProxy::updateProcessAssertion()
https://bugs.webkit.org/show_bug.cgi?id=213891
<rdar://problem/65017909>

Reviewed by Alex Christensen.

The crash was due to NetworkProcessProxy::updateProcessAssertion() re-entering while
in the middle of the m_activityFromWebProcesses = nullptr; assignment. Calling
the ProcessThrottler::BackgroundActivity destructor, could cause updateProcessAssertion()
to get called again, in which case we may dereference m_activityFromWebProcesses and
crash. To address the issue, use std::exchange(m_activityFromWebProcesses, nullptr);
instead, so that m_activityFromWebProcesses becomes null BEFORE the BackgroundActivity
destructor gets called. updateProcessAssertion() will still re-enter but
m_activityFromWebProcesses will be nullptr and updateProcessAssertion() will do the
right thing.

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::updateProcessAssertion):

10:56 AM Changeset in webkit [263851] by Chris Dumez

1 edit
8 deletes in trunk/LayoutTests/imported/w3c

Unreviewed, drop some outdated tests in WebCrypto API.

Those tests failed to get removed during the recent re-sync from upstream in r263598.
They are actually still present but under different names so we have duplicate
copies right now.

web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf-expected.txt: Removed.
web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2-expected.txt: Removed.
web-platform-tests/WebCryptoAPI/getRandomValues.js: Removed.
web-platform-tests/WebCryptoAPI/getRandomValues.worker-expected.txt: Removed.
web-platform-tests/WebCryptoAPI/getRandomValues.worker.html: Removed.
web-platform-tests/WebCryptoAPI/getRandomValues.worker.js: Removed.
web-platform-tests/WebCryptoAPI/test_getRandomValues-expected.txt: Removed.
web-platform-tests/WebCryptoAPI/test_getRandomValues.html: Removed.

10:30 AM Changeset in webkit [263850] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Remove expectation for fast/canvas/canvas-radial-gradient-spreadMethod.html as it is passing. Added back imported/w3c/canvas/2d.gradient.radial.cone.bottom.html as it is failing.
https://bugs.webkit.org/show_bug.cgi?id=213840

Unreviewed test gardening.

Patch by Karl Rackler <Karl Rackler> on 2020-07-02

platform/ios/TestExpectations:

10:17 AM Changeset in webkit [263849] by ysuzuki@apple.com

2 edits in trunk/JSTests

Unreviewed, mark JSTests/test262/test/intl402/NumberFormat/prototype/format/numbering-systems.js fail since it requires ICU 66
https://bugs.webkit.org/show_bug.cgi?id=213872

This test in test262 requires ICU 66 while Catalina bot is using ICU 64.

test262/config.yaml:

9:31 AM Changeset in webkit [263848] by commit-queue@webkit.org

2 edits in trunk/Tools

REGRESSION(r263625): run-minibrowser fails on mac
https://bugs.webkit.org/show_bug.cgi?id=213876

Patch by Philippe Normand <pnormand@igalia.com> on 2020-07-02
Reviewed by Darin Adler.

Scripts/webkitpy/port/base.py:

(Port.run_minibrowser): _run_script() expects a string as first argument. Command-line args
are passed through a keyword.

9:17 AM Changeset in webkit [263847] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, unskip most webaudio WPT tests in Debug.

TestExpectations:

7:52 AM Changeset in webkit [263846] by Alan Bujtas

3 edits
2 adds in trunk

[LFC][BFC] Remove redundant margin-border-padding when computing the intrinsic width
https://bugs.webkit.org/show_bug.cgi?id=213882

Reviewed by Antti Koivisto.

Source/WebCore:

The child intrinsic width already includes the margin-border-padding values.

Test: fast/layoutformattingcontext/table-with-margin-content-simple.html

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraints):

LayoutTests:

fast/layoutformattingcontext/table-with-margin-content-simple-expected.html: Added.
fast/layoutformattingcontext/table-with-margin-content-simple.html: Added.

7:52 AM Changeset in webkit [263845] by Alan Bujtas

3 edits
2 adds in trunk

[LFC][IFC] Use <tr> computed height as minimum height for the row
https://bugs.webkit.org/show_bug.cgi?id=213880

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/table-fixed-row-height-simple.html

layout/tableformatting/TableLayout.cpp:

(WebCore::Layout::TableFormattingContext::TableLayout::distributedVerticalSpace):

LayoutTests:

fast/layoutformattingcontext/table-fixed-row-height-simple-expected.html: Added.
fast/layoutformattingcontext/table-fixed-row-height-simple.html: Added.

7:05 AM Changeset in webkit [263844] by youenn@apple.com

11 edits
2 adds in trunk

getUserMedia returns OverConstrained on Jitsi
https://bugs.webkit.org/show_bug.cgi?id=210932
<rdar://problem/64403675>

Reviewed by Philippe Normand.

Source/WebCore:

We compute the max width, max height and max frame rate across all presets.
In case a preset for the max resolution is different from the preset for the max frame rate,
we were selecting capture parameters that no preset can match.

To fix the issue, in case the frame rate constraint is not mandatory, and we do not find a preset
when starting to capture, we remove the frame rate constraint, pick the preset and choose the max frame rate from that preset.

Update mock sources to have a high resolution preset with low frame rate to enable writing a test.

Test: fast/mediastream/get-user-media-ideal-constraints.html

platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::supportsSizeAndFrameRate):

platform/mediastream/RealtimeVideoCaptureSource.cpp:

(WebCore::RealtimeVideoCaptureSource::bestSupportedSizeAndFrameRate):
(WebCore::RealtimeVideoCaptureSource::setSizeAndFrameRate):

platform/mediastream/VideoPreset.h:

(WebCore::VideoPreset::maxFrameRate const):

platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::defaultDevices):

LayoutTests:

We bumped the max width/height for mock sources and have to update existing tests according to that.

fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt:
fast/mediastream/apply-constraints-advanced-expected.txt:
fast/mediastream/apply-constraints-advanced.html:
fast/mediastream/apply-constraints-video-expected.txt:
fast/mediastream/apply-constraints-video.html:
fast/mediastream/get-user-media-ideal-constraints-expected.txt: Added.
fast/mediastream/get-user-media-ideal-constraints.html: Added.

5:41 AM Changeset in webkit [263843] by Carlos Garcia Campos

8 edits in trunk

Unreviewed. Fix GTK4 build

Source/WebCore:

platform/gtk/GtkVersioning.h:

(gtk_scrolled_window_new):

Source/WebKit:

UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:

(webkitScriptDialogImplConstructed):

UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:

(WebKit::WebDataListSuggestionsDropdownGtk::WebDataListSuggestionsDropdownGtk):

UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::createPopupMenu):

Tools:

MiniBrowser/gtk/BrowserSettingsDialog.c:

(browser_settings_dialog_init):

5:40 AM Changeset in webkit [263842] by commit-queue@webkit.org

6 edits in trunk/LayoutTests

Remove expectation for fast/events/input-events-forecolor-data.html and fast/events/input-events-ime-composition.html and fast/events/input-events-selection-forecolor-data.html and fast/events/input-events-spell-checking-datatransfer.html and fast/events/offsetX-offsetY.html and fast/events/scale-and-scroll-iframe-body.html and fast/events/scale-and-scroll-iframe-window.html and fast/events/scroll-to-anchor-vertical-lr-writing-mode.html and fast/events/scroll-to-anchor-vertical-writing-mode.html and fast/forms/range/slider-transformed.html and fast/forms/range/slider-zoomed.html and fast/frames/content-opacity-1.html and fast/frames/content-opacity-2.html and fast/frames/iframe-text-contents.html and fast/frames/onlyCommentInIFrame.html and fast/frames/paint-iframe-background.html and fast/frames/sandboxed-iframe-close-top-noclose.html and fast/hidpi/image-srcset-invalid-descriptor.html and fast/hidpi/image-srcset-png-canvas.html and fast/html/listing.html as they are passing.
https://bugs.webkit.org/show_bug.cgi?id=213863

Unreviewed test gardening.

Patch by Karl Rackler <Karl Rackler> on 2020-07-02

platform/ios-simulator-wk1/TestExpectations:
platform/ios-simulator-wk2/TestExpectations:
platform/ios-simulator/TestExpectations:
platform/ios-wk2/TestExpectations:
platform/ios/TestExpectations:

5:38 AM Changeset in webkit [263841] by commit-queue@webkit.org

9 edits
2 adds
3 deletes in trunk

Fragment navigation involving fragment identifiers does not match specification
https://bugs.webkit.org/show_bug.cgi?id=83930

Patch by Rob Buis <rbuis@igalia.com> on 2020-07-02
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved test results and import scroll-frag-non-utf8-encoded-document.html.

web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/fragment-and-encoding-2-expected.txt:
web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/fragment-and-encoding-expected.txt:
web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-non-utf8-encoded-document-expected.txt: Added.
web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-non-utf8-encoded-document.html: Added.
web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-anchor-name-expected.txt:

Source/WebCore:

Implement step 5 and 6 of [1] to allow fragment identifier lookup
using percent-decoding, after normal lookup failed.

Behavior matches Chrome and Firefox.

[1] https://html.spec.whatwg.org/multipage/browsing-the-web.html#the-indicated-part-of-the-document

Tests: imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-anchor-name.html

imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/fragment-and-encoding-2.html
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/fragment-and-encoding.html
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-non-utf8-encoded-document.html

page/FrameView.cpp:

(WebCore::FrameView::scrollToFragmentInternal):

LayoutTests:

Replace anchor-frames-gbk.html by scroll-frag-non-utf8-encoded-document.html.

http/tests/navigation/anchor-frames-gbk-expected.txt: Removed.
http/tests/navigation/anchor-frames-gbk.html: Removed.
http/tests/navigation/resources/frame-with-anchor-gbk.html: Removed.
platform/ios-wk1/TestExpectations:
platform/ios-wk2/TestExpectations:

3:40 AM Changeset in webkit [263840] by eocanha@igalia.com

2 edits in trunk/LayoutTests

Unreviewed GTK multimedia gardening
https://bugs.webkit.org/show_bug.cgi?id=213877

Crashes in media/context-menu-actions.html are flaky instead of always reproducible.

platform/gtk/TestExpectations:

2:26 AM Changeset in webkit [263839] by commit-queue@webkit.org

3 edits
1 add in trunk/Tools

[Flatpak SDK] Add perl-term-readkey
https://bugs.webkit.org/show_bug.cgi?id=213787

Patch by Philippe Normand <pnormand@igalia.com> on 2020-07-02
Reviewed by Adrian Perez de Castro.

This is yet another git-svn runtime dependency.

buildstream/elements/sdk-platform.bst:
buildstream/elements/sdk/perl-term-readkey.bst: Added.

2:19 AM Changeset in webkit [263838] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[GTK] Kinetic scrolling is still triggered if you wait before lifting fingers
https://bugs.webkit.org/show_bug.cgi?id=213789

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2020-07-02
Reviewed by Carlos Garcia Campos.

The intended behavior for kinetic scrolling is that it's possible to not trigger it by
stopping moving fingers before lifting them, as opposed to doing a fling/swipe. However,
right now it's broken and trying to do this triggers kinetic scrolling as well.

Currently, the last scroll event with (0, 0) deltas isn't added to the scroll history for
kinetic scrolling. However, this is wrong, because the last event, or rather the timespan
between it and the previous scroll event, actually determines the kinetic scrolling velocity:
if this event follows the previous one quickly, the velocity is large, but if there was a long
pause, the velocity would be close to 0.

See https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1902 and
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1903 for the equivalent GTK fixes.

page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent):

page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent):

platform/generic/ScrollAnimatorGeneric.cpp:

(WebCore::ScrollAnimatorGeneric::handleWheelEvent):

1:47 AM Changeset in webkit [263837] by ysuzuki@apple.com

4 edits
1 add in trunk

[JSC] Configure option-offered numberingSystem in Intl.NumberFormat through locale
https://bugs.webkit.org/show_bug.cgi?id=213872

Reviewed by Ross Kirsling.

JSTests:

stress/intl-numberformat-nu.js: Added.

(shouldBe):

test262/expectations.yaml:

Source/JavaScriptCore:

We need to pass numberingSystem option to ICU through locale when constructing UNumberFormat.
We are passing it when we get "en-US-u-nu-hanidec" locale, but we are not passing it when
we are getting new Intl.NumberFormat("en-US", { numberingSystem: "hanidec" }).

runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):

1:20 AM Changeset in webkit [263836] by Philippe Normand

4 edits in trunk/Source/WebCore

[GStreamer] Rewrite mediastreamsrc element
https://bugs.webkit.org/show_bug.cgi?id=213777

Reviewed by Xabier Rodriguez-Calvar.

The underlying functionality remains the same, design-wise. This is mostly a refactoring
switching to smart pointers as much as possible and trying to comply with WebKit code style
guidelines.

The previous version of this element was leaking pad templates and sticky stream-start
events (in webkitMediaStreamSrcTrackEnded).

The LIBWEBRTC ifdef guards were removed as well, because there's no actual libwebrtc
dependency involved in this code.

No new tests, existing webrtc and fast/mediastream tests cover this patch.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

(mediaStreamTrackPrivateGetTags):
(webkitMediaStreamNew):
(WebKitMediaStreamTrackObserver::WebKitMediaStreamTrackObserver):
(WebKitMediaStreamObserver::WebKitMediaStreamObserver):
(InternalSource::InternalSource):
(InternalSource::~InternalSource):
(InternalSource::src const):
(InternalSource::pushSample):
(webkitMediaStreamSrcUriGetType):
(webkitMediaStreamSrcUriGetProtocols):
(webkitMediaStreamSrcUriGetUri):
(webkitMediaStreamSrcUriSetUri):
(webkitMediaStreamSrcUriHandlerInit):
(webkitMediaStreamSrcSetProperty):
(webkitMediaStreamSrcGetProperty):
(webkitMediaStreamSrcConstructed):
(stopObservingTracks):
(webkitMediaStreamSrcFinalize):
(webkitMediaStreamSrcChangeState):
(webkit_media_stream_src_class_init):
(webkitMediaStreamSrcChain):
(webkitMediaStreamSrcAddPad):
(ProbeData::ProbeData):
(webkitMediaStreamSrcPadProbeCb):
(webkitMediaStreamSrcSetupSrc):
(webkitMediaStreamSrcPostStreamCollection):
(webkitMediaStreamSrcAddTrack):
(webkitMediaStreamSrcRemoveTrackByType):
(webkitMediaStreamSrcSetStream):
(webkitMediaStreamSrcPushVideoSample):
(webkitMediaStreamSrcPushAudioSample):
(webkitMediaStreamSrcTrackEnded):
(webkitMediaStreamSrcNew):

platform/mediastream/gstreamer/GStreamerMediaStreamSource.h:

1:14 AM Changeset in webkit [263835] by eocanha@igalia.com

5 edits in trunk/LayoutTests

[GTK] Layout test media/context-menu-actions.html is failing
https://bugs.webkit.org/show_bug.cgi?id=183611

Reviewed by Xabier Rodriguez-Calvar.

Changing to fullscreen is an async operation, so we now use testExpectedEventually() to wait for
the final value.
Simply setting an event handler on video.onwebkitfullscreenchange wouldn't have been enough, since the
event is triggered before the fullscreen operation has been completed and checking for
video.webkitDisplayingFullscreen == true would still fail by then.
Using the 'webkitbeginfullscreen' event isn't possible either, because it's never triggered when
FULLSCREEN_API is enabled.

media/context-menu-actions.html: Use asynchronous testing.
media/video-test.js:

(testExpectedEventually): Add an optional "timeout" parameter to avoid a test timeout (all the output
would be lost) in case we wait forever for the comparison to evaluate to the expected value.
(reportExpected): Add an optional "explanation" parameter for extra reporting.

platform/gtk-wayland/TestExpectations: Unskipped the test.
platform/gtk/TestExpectations: Ditto.

12:20 AM Changeset in webkit [263834] by Diego Pino Garcia

2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Skip AX tests added in r263823 as they're timing out.

platform/glib/TestExpectations:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed