⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 16, 2020:

11:39 PM Changeset in webkit [264501] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Make DocumentParser.ParserState an enum class
​https://bugs.webkit.org/show_bug.cgi?id=214416

Patch by Rob Buis <​rbuis@igalia.com> on 2020-07-16
Reviewed by Darin Adler.

Make DocumentParser.ParserState an enum class since it is more readable.

  • dom/DocumentParser.cpp:

(WebCore::DocumentParser::DocumentParser):
(WebCore::DocumentParser::startParsing):
(WebCore::DocumentParser::prepareToStopParsing):
(WebCore::DocumentParser::stopParsing):
(WebCore::DocumentParser::detach):

  • dom/DocumentParser.h:

(WebCore::DocumentParser::isParsing const):
(WebCore::DocumentParser::isStopping const):
(WebCore::DocumentParser::isStopped const):
(WebCore::DocumentParser::isDetached const):
(): Deleted.

11:07 PM Changeset in webkit [264500] by ysuzuki@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

[JSC] Clean up Intl option parsing code by introducing intlOption<>
​https://bugs.webkit.org/show_bug.cgi?id=214437

Reviewed by Ross Kirsling.

This patch introduces intlOption<>(...) function and remove redundant string comparisons.
This makes option handling efficient, and it makes code clean.

  • runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):

  • runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat):

  • runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):

  • runtime/IntlObject.cpp:

(JSC::resolveLocale):
(JSC::supportedLocales):

  • runtime/IntlObject.h:
  • runtime/IntlObjectInlines.h:

(JSC::intlOption):

  • runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::initializePluralRules):

  • runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::initializeRelativeTimeFormat):

10:18 PM Changeset in webkit [264499] by calvaris@igalia.com
  • 6 edits in trunk

Rename createBoxPtr into adoptBoxPtr
​https://bugs.webkit.org/show_bug.cgi?id=214171

Reviewed by Darin Adler.

Source/WebCore:

No new tests, just a rename.

  • platform/graphics/gstreamer/eme/CDMProxyThunder.cpp:

(WebCore::CDMProxyThunder::getDecryptionSession const): Used the
renamed function.

Source/WTF:

  • wtf/BoxPtr.h:

(WTF::adoptInBoxPtr):

Tools:

  • TestWebKitAPI/Tests/WTF/BoxPtr.cpp:

(TestWebKitAPI::TEST): Used the renamed function.

9:41 PM Changeset in webkit [264498] by Jonathan Bedard
  • 1 edit
    21 adds in trunk/WebKitLibraries

Add WebKitPrivateFrameworkStubs for iOS 14
​https://bugs.webkit.org/show_bug.cgi?id=214432
<rdar://problem/65695714>

Reviewed by Tim Horton.

  • WebKitPrivateFrameworkStubs/iOS/14: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/AppSupport.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/AppSupport.framework/AppSupport.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/AssertionServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/AssertionServices.framework/AssertionServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/AuthKit.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/AuthKit.framework/AuthKit.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/CorePrediction.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/CorePrediction.framework/CorePrediction.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/DeviceIdentity.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/DeviceIdentity.framework/DeviceIdentity.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/GraphicsServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/GraphicsServices.framework/GraphicsServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/IOSurfaceAccelerator.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/IOSurfaceAccelerator.framework/IOSurfaceAccelerator.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/RunningBoardServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/RunningBoardServices.framework/RunningBoardServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/SafariSafeBrowsing.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/SafariSafeBrowsing.framework/SafariSafeBrowsing.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/URLFormatting.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/14/URLFormatting.framework/URLFormatting.tbd: Added.
9:04 PM Changeset in webkit [264497] by Lauro Moura
  • 2 edits
    2 adds in trunk/LayoutTests

[GTK][WPE] Garden two resource timing failures after WPT update

Unreviewed test gardening.

  • platform/glib/TestExpectations:
  • platform/glib/imported/w3c/web-platform-tests/resource-timing/resource_connection_reuse_mixed_content_redirect-expected.txt: Added.
8:36 PM Changeset in webkit [264496] by jer.noble@apple.com
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Unreviewed build fix after r264492; previously dead code in RTCNativeI420Buffer.mm was
revivified after a project file fix which stopped setting NDEBUG for debug builds in
libwebrc. Delete this undead code, which would have always caused build errors if it was
ever compiled.

  • Source/webrtc/sdk/objc/api/video_frame_buffer/RTCNativeI420Buffer.mm:

(-[RTCI420Buffer debugQuickLookObject]): Deleted.

8:36 PM Changeset in webkit [264495] by jer.noble@apple.com
  • 1 edit in trunk/Tools/ChangeLog

Unreviwed test gardening; disable the SleepDisabler.NavigateBack
test, as it is flaky on the bots.

  • TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:

(TEST_F):

8:24 PM Changeset in webkit [264494] by Lauro Moura
  • 3 edits in trunk/LayoutTests

[GTK] Garden some debug crashes

Unreviewed test gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
6:37 PM Changeset in webkit [264493] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore/PAL

Use AVRoutePickerView when available for choosing AirPlay devices
​https://bugs.webkit.org/show_bug.cgi?id=213497
<rdar://problem/58610662>

Unreviewed build fix.

  • pal/spi/cocoa/AVKitSPI.h:
6:10 PM Changeset in webkit [264492] by jer.noble@apple.com
  • 7 edits
    905 adds in trunk/Source/ThirdParty/libwebrtc

Integrate libwebm into the libwebrtc project.
​https://bugs.webkit.org/show_bug.cgi?id=214410

Reviewed by Eric Carlson.

Add the libwebm and resulting static library target to libwebrtc.

Drive-by fix: update the DebugRelease.xcconfig to set the correct DEBUG_DEFINES and GCC_OPTIMIZATION_LEVEL
when building the Debug configuration.

  • Configurations/DebugRelease.xcconfig:
  • Configurations/libwebm.xcconfig: Added.
  • Configurations/libwebrtc.xcconfig:
  • Configurations/libwebrtc.iOS.exp:
  • Configurations/libwebrtc.iOSsim.exp:
  • Configurations/libwebrtc.mac.exp:
  • Source/third_party/libwebm/AUTHORS.TXT: Added.
  • Source/third_party/libwebm/Android.mk: Added.
  • Source/third_party/libwebm/CMakeLists.txt: Added.
  • Source/third_party/libwebm/LICENSE.TXT: Added.
  • Source/third_party/libwebm/Makefile.unix: Added.
  • Source/third_party/libwebm/PATENTS.TXT: Added.
  • Source/third_party/libwebm/README.libwebm: Added.
  • Source/third_party/libwebm/codereview.settings: Added.
  • Source/third_party/libwebm/common/common.sh: Added.
  • Source/third_party/libwebm/common/file_util.cc: Added.
  • Source/third_party/libwebm/common/file_util.h: Added.

(libwebm::TempFileDeleter::TempFileDeleter):
(libwebm::TempFileDeleter::name const):

  • Source/third_party/libwebm/common/hdr_util.cc: Added.
  • Source/third_party/libwebm/common/hdr_util.h: Added.

(libwebm::Vp9CodecFeatures::Vp9CodecFeatures):
(libwebm::Vp9CodecFeatures::~Vp9CodecFeatures):

  • Source/third_party/libwebm/common/indent.cc: Added.
  • Source/third_party/libwebm/common/indent.h: Added.

(libwebm::Indent::indent_str const):

  • Source/third_party/libwebm/common/libwebm_util.cc: Added.
  • Source/third_party/libwebm/common/libwebm_util.h: Added.

(libwebm::FILEDeleter::operator()):
(libwebm::Range::Range):

  • Source/third_party/libwebm/common/video_frame.cc: Added.
  • Source/third_party/libwebm/common/video_frame.h: Added.

(libwebm::VideoFrame::VideoFrame):
(libwebm::VideoFrame::buffer const):
(libwebm::VideoFrame::keyframe const):
(libwebm::VideoFrame::nanosecond_pts const):
(libwebm::VideoFrame::codec const):
(libwebm::VideoFrame::set_nanosecond_pts):

  • Source/third_party/libwebm/common/vp9_header_parser.cc: Added.
  • Source/third_party/libwebm/common/vp9_header_parser.h: Added.

(vp9_parser::Vp9HeaderParser::Vp9HeaderParser):
(vp9_parser::Vp9HeaderParser::frame_size const):
(vp9_parser::Vp9HeaderParser::profile const):
(vp9_parser::Vp9HeaderParser::key const):
(vp9_parser::Vp9HeaderParser::altref const):
(vp9_parser::Vp9HeaderParser::error_resilient_mode const):
(vp9_parser::Vp9HeaderParser::bit_depth const):
(vp9_parser::Vp9HeaderParser::color_space const):
(vp9_parser::Vp9HeaderParser::width const):
(vp9_parser::Vp9HeaderParser::height const):
(vp9_parser::Vp9HeaderParser::refresh_frame_flags const):
(vp9_parser::Vp9HeaderParser::row_tiles const):
(vp9_parser::Vp9HeaderParser::column_tiles const):
(vp9_parser::Vp9HeaderParser::frame_parallel_mode const):

  • Source/third_party/libwebm/common/vp9_header_parser_tests.cc: Added.
  • Source/third_party/libwebm/common/vp9_level_stats.cc: Added.
  • Source/third_party/libwebm/common/vp9_level_stats.h: Added.

(vp9_parser::Vp9LevelStats::Vp9LevelStats):
(vp9_parser::Vp9LevelStats::set_duration):
(vp9_parser::Vp9LevelStats::max_luma_sample_rate_grace_percent const):
(vp9_parser::Vp9LevelStats::set_max_luma_sample_rate_grace_percent):
(vp9_parser::Vp9LevelStats::estimate_last_frame_duration const):
(vp9_parser::Vp9LevelStats::set_estimate_last_frame_duration):

  • Source/third_party/libwebm/common/vp9_level_stats_tests.cc: Added.
  • Source/third_party/libwebm/common/webm_constants.h: Added.
  • Source/third_party/libwebm/common/webm_endian.cc: Added.
  • Source/third_party/libwebm/common/webm_endian.h: Added.
  • Source/third_party/libwebm/common/webmids.h: Added.
  • Source/third_party/libwebm/dumpvtt.cc: Added.
  • Source/third_party/libwebm/hdr_util.hpp: Added.
  • Source/third_party/libwebm/iosbuild.sh: Added.
  • Source/third_party/libwebm/m2ts/tests/webm2pes_tests.cc: Added.
  • Source/third_party/libwebm/m2ts/vpxpes2ts.cc: Added.
  • Source/third_party/libwebm/m2ts/vpxpes2ts.h: Added.

(libwebm::VpxPes2Ts::VpxPes2Ts):

  • Source/third_party/libwebm/m2ts/vpxpes2ts_main.cc: Added.
  • Source/third_party/libwebm/m2ts/vpxpes_parser.cc: Added.
  • Source/third_party/libwebm/m2ts/vpxpes_parser.h: Added.

(libwebm::VpxPesParser::BcmvHeader::size):
(libwebm::VpxPesParser::pes_file_size const):
(libwebm::VpxPesParser::pes_file_data const):

  • Source/third_party/libwebm/m2ts/webm2pes.cc: Added.
  • Source/third_party/libwebm/m2ts/webm2pes.h: Added.

(libwebm::PesHeaderField::PesHeaderField):
(libwebm::PesHeaderField::Check const):
(libwebm::PesOptionalHeader::size_in_bytes):
(libwebm::BCMVHeader::BCMVHeader):
(libwebm::BCMVHeader::size):
(libwebm::PesHeader::size const):
(libwebm::PacketReceiverInterface::~PacketReceiverInterface):
(libwebm::Webm2Pes::Webm2Pes):
(libwebm::Webm2Pes::bytes_written const):

  • Source/third_party/libwebm/m2ts/webm2pes_main.cc: Added.
  • Source/third_party/libwebm/mkvmuxer.hpp: Added.
  • Source/third_party/libwebm/mkvmuxer/mkvmuxer.cc: Added.
  • Source/third_party/libwebm/mkvmuxer/mkvmuxer.h: Added.

(mkvmuxer::Frame::add_id const):
(mkvmuxer::Frame::additional const):
(mkvmuxer::Frame::additional_length const):
(mkvmuxer::Frame::duration const):
(mkvmuxer::Frame::duration_set const):
(mkvmuxer::Frame::frame const):
(mkvmuxer::Frame::set_is_key):
(mkvmuxer::Frame::is_key const):
(mkvmuxer::Frame::length const):
(mkvmuxer::Frame::set_track_number):
(mkvmuxer::Frame::track_number const):
(mkvmuxer::Frame::set_timestamp):
(mkvmuxer::Frame::timestamp const):
(mkvmuxer::Frame::set_discard_padding):
(mkvmuxer::Frame::discard_padding const):
(mkvmuxer::Frame::reference_block_timestamp const):
(mkvmuxer::Frame::reference_block_timestamp_set const):
(mkvmuxer::CuePoint::set_time):
(mkvmuxer::CuePoint::time const):
(mkvmuxer::CuePoint::set_track):
(mkvmuxer::CuePoint::track const):
(mkvmuxer::CuePoint::set_cluster_pos):
(mkvmuxer::CuePoint::cluster_pos const):
(mkvmuxer::CuePoint::set_block_number):
(mkvmuxer::CuePoint::block_number const):
(mkvmuxer::CuePoint::set_output_block_number):
(mkvmuxer::CuePoint::output_block_number const):
(mkvmuxer::Cues::cue_entries_size const):
(mkvmuxer::Cues::set_output_block_number):
(mkvmuxer::Cues::output_block_number const):
(mkvmuxer::ContentEncAESSettings::~ContentEncAESSettings):
(mkvmuxer::ContentEncAESSettings::cipher_mode const):
(mkvmuxer::ContentEncoding::enc_algo const):
(mkvmuxer::ContentEncoding::encoding_order const):
(mkvmuxer::ContentEncoding::encoding_scope const):
(mkvmuxer::ContentEncoding::encoding_type const):
(mkvmuxer::ContentEncoding::enc_aes_settings):
(mkvmuxer::PrimaryChromaticity::PrimaryChromaticity):
(mkvmuxer::PrimaryChromaticity::~PrimaryChromaticity):
(mkvmuxer::PrimaryChromaticity::x const):
(mkvmuxer::PrimaryChromaticity::set_x):
(mkvmuxer::PrimaryChromaticity::y const):
(mkvmuxer::PrimaryChromaticity::set_y):
(mkvmuxer::MasteringMetadata::MasteringMetadata):
(mkvmuxer::MasteringMetadata::~MasteringMetadata):
(mkvmuxer::MasteringMetadata::r const):
(mkvmuxer::MasteringMetadata::g const):
(mkvmuxer::MasteringMetadata::b const):
(mkvmuxer::MasteringMetadata::white_point const):
(mkvmuxer::MasteringMetadata::luminance_max const):
(mkvmuxer::MasteringMetadata::set_luminance_max):
(mkvmuxer::MasteringMetadata::luminance_min const):
(mkvmuxer::MasteringMetadata::set_luminance_min):
(mkvmuxer::Colour::Colour):
(mkvmuxer::Colour::~Colour):
(mkvmuxer::Colour::mastering_metadata const):
(mkvmuxer::Colour::matrix_coefficients const):
(mkvmuxer::Colour::set_matrix_coefficients):
(mkvmuxer::Colour::bits_per_channel const):
(mkvmuxer::Colour::set_bits_per_channel):
(mkvmuxer::Colour::chroma_subsampling_horz const):
(mkvmuxer::Colour::set_chroma_subsampling_horz):
(mkvmuxer::Colour::chroma_subsampling_vert const):
(mkvmuxer::Colour::set_chroma_subsampling_vert):
(mkvmuxer::Colour::cb_subsampling_horz const):
(mkvmuxer::Colour::set_cb_subsampling_horz):
(mkvmuxer::Colour::cb_subsampling_vert const):
(mkvmuxer::Colour::set_cb_subsampling_vert):
(mkvmuxer::Colour::chroma_siting_horz const):
(mkvmuxer::Colour::set_chroma_siting_horz):
(mkvmuxer::Colour::chroma_siting_vert const):
(mkvmuxer::Colour::set_chroma_siting_vert):
(mkvmuxer::Colour::range const):
(mkvmuxer::Colour::set_range):
(mkvmuxer::Colour::transfer_characteristics const):
(mkvmuxer::Colour::set_transfer_characteristics):
(mkvmuxer::Colour::primaries const):
(mkvmuxer::Colour::set_primaries):
(mkvmuxer::Colour::max_cll const):
(mkvmuxer::Colour::set_max_cll):
(mkvmuxer::Colour::max_fall const):
(mkvmuxer::Colour::set_max_fall):
(mkvmuxer::Projection::Projection):
(mkvmuxer::Projection::~Projection):
(mkvmuxer::Projection::type const):
(mkvmuxer::Projection::set_type):
(mkvmuxer::Projection::pose_yaw const):
(mkvmuxer::Projection::set_pose_yaw):
(mkvmuxer::Projection::pose_pitch const):
(mkvmuxer::Projection::set_pose_pitch):
(mkvmuxer::Projection::pose_roll const):
(mkvmuxer::Projection::set_pose_roll):
(mkvmuxer::Projection::private_data const):
(mkvmuxer::Projection::private_data_length const):
(mkvmuxer::Track::codec_id const):
(mkvmuxer::Track::codec_private const):
(mkvmuxer::Track::language const):
(mkvmuxer::Track::set_max_block_additional_id):
(mkvmuxer::Track::max_block_additional_id const):
(mkvmuxer::Track::name const):
(mkvmuxer::Track::set_number):
(mkvmuxer::Track::number const):
(mkvmuxer::Track::set_type):
(mkvmuxer::Track::type const):
(mkvmuxer::Track::set_uid):
(mkvmuxer::Track::uid const):
(mkvmuxer::Track::set_codec_delay):
(mkvmuxer::Track::codec_delay const):
(mkvmuxer::Track::set_seek_pre_roll):
(mkvmuxer::Track::seek_pre_roll const):
(mkvmuxer::Track::set_default_duration):
(mkvmuxer::Track::default_duration const):
(mkvmuxer::Track::codec_private_length const):
(mkvmuxer::Track::content_encoding_entries_size const):
(mkvmuxer::VideoTrack::set_display_height):
(mkvmuxer::VideoTrack::display_height const):
(mkvmuxer::VideoTrack::set_display_width):
(mkvmuxer::VideoTrack::display_width const):
(mkvmuxer::VideoTrack::set_pixel_height):
(mkvmuxer::VideoTrack::pixel_height const):
(mkvmuxer::VideoTrack::set_pixel_width):
(mkvmuxer::VideoTrack::pixel_width const):
(mkvmuxer::VideoTrack::set_crop_left):
(mkvmuxer::VideoTrack::crop_left const):
(mkvmuxer::VideoTrack::set_crop_right):
(mkvmuxer::VideoTrack::crop_right const):
(mkvmuxer::VideoTrack::set_crop_top):
(mkvmuxer::VideoTrack::crop_top const):
(mkvmuxer::VideoTrack::set_crop_bottom):
(mkvmuxer::VideoTrack::crop_bottom const):
(mkvmuxer::VideoTrack::set_frame_rate):
(mkvmuxer::VideoTrack::frame_rate const):
(mkvmuxer::VideoTrack::set_height):
(mkvmuxer::VideoTrack::height const):
(mkvmuxer::VideoTrack::stereo_mode):
(mkvmuxer::VideoTrack::alpha_mode):
(mkvmuxer::VideoTrack::set_width):
(mkvmuxer::VideoTrack::width const):
(mkvmuxer::VideoTrack::colour_space const):
(mkvmuxer::VideoTrack::colour):
(mkvmuxer::VideoTrack::projection):
(mkvmuxer::AudioTrack::set_bit_depth):
(mkvmuxer::AudioTrack::bit_depth const):
(mkvmuxer::AudioTrack::set_channels):
(mkvmuxer::AudioTrack::channels const):
(mkvmuxer::AudioTrack::set_sample_rate):
(mkvmuxer::AudioTrack::sample_rate const):
(mkvmuxer::Tracks::track_entries_size const):
(mkvmuxer::Chapter::set_uid):
(mkvmuxer::Cluster::size_position const):
(mkvmuxer::Cluster::blocks_added const):
(mkvmuxer::Cluster::payload_size const):
(mkvmuxer::Cluster::position_for_cues const):
(mkvmuxer::Cluster::timecode const):
(mkvmuxer::Cluster::timecode_scale const):
(mkvmuxer::Cluster::set_write_last_frame_with_duration):
(mkvmuxer::Cluster::write_last_frame_with_duration const):
(mkvmuxer::SegmentInfo::set_duration):
(mkvmuxer::SegmentInfo::duration const):
(mkvmuxer::SegmentInfo::muxing_app const):
(mkvmuxer::SegmentInfo::set_timecode_scale):
(mkvmuxer::SegmentInfo::timecode_scale const):
(mkvmuxer::SegmentInfo::writing_app const):
(mkvmuxer::SegmentInfo::set_date_utc):
(mkvmuxer::SegmentInfo::date_utc const):
(mkvmuxer::Segment::GetCues):
(mkvmuxer::Segment::GetSegmentInfo const):
(mkvmuxer::Segment::GetSegmentInfo):
(mkvmuxer::Segment::chunking const):
(mkvmuxer::Segment::cues_track const):
(mkvmuxer::Segment::set_max_cluster_duration):
(mkvmuxer::Segment::max_cluster_duration const):
(mkvmuxer::Segment::set_max_cluster_size):
(mkvmuxer::Segment::max_cluster_size const):
(mkvmuxer::Segment::set_mode):
(mkvmuxer::Segment::mode const):
(mkvmuxer::Segment::cues_position const):
(mkvmuxer::Segment::output_cues const):
(mkvmuxer::Segment::set_estimate_file_duration):
(mkvmuxer::Segment::estimate_file_duration const):
(mkvmuxer::Segment::segment_info const):
(mkvmuxer::Segment::set_duration):
(mkvmuxer::Segment::duration const):

  • Source/third_party/libwebm/mkvmuxer/mkvmuxertypes.h: Added.
  • Source/third_party/libwebm/mkvmuxer/mkvmuxerutil.cc: Added.
  • Source/third_party/libwebm/mkvmuxer/mkvmuxerutil.h: Added.
  • Source/third_party/libwebm/mkvmuxer/mkvwriter.cc: Added.
  • Source/third_party/libwebm/mkvmuxer/mkvwriter.h: Added.
  • Source/third_party/libwebm/mkvmuxer_sample.cc: Added.
  • Source/third_party/libwebm/mkvmuxertypes.hpp: Added.
  • Source/third_party/libwebm/mkvmuxerutil.hpp: Added.
  • Source/third_party/libwebm/mkvparser.hpp: Added.
  • Source/third_party/libwebm/mkvparser/mkvparser.cc: Added.
  • Source/third_party/libwebm/mkvparser/mkvparser.h: Added.

(mkvparser::IMkvReader::~IMkvReader):
(mkvparser::BlockEntry::EOS const):
(mkvparser::ContentEncoding::ContentEncAESSettings::ContentEncAESSettings):
(mkvparser::ContentEncoding::ContentEncAESSettings::~ContentEncAESSettings):
(mkvparser::ContentEncoding::encoding_order const):
(mkvparser::ContentEncoding::encoding_scope const):
(mkvparser::ContentEncoding::encoding_type const):
(mkvparser::PrimaryChromaticity::PrimaryChromaticity):
(mkvparser::PrimaryChromaticity::~PrimaryChromaticity):
(mkvparser::MasteringMetadata::MasteringMetadata):
(mkvparser::MasteringMetadata::~MasteringMetadata):
(mkvparser::Colour::Colour):
(mkvparser::Colour::~Colour):
(mkvparser::Projection::Projection):
(mkvparser::Projection::~Projection):
(mkvparser::VideoTrack::GetColourSpace const):
(mkvparser::Segment::LoadCluster):

  • Source/third_party/libwebm/mkvparser/mkvreader.cc: Added.
  • Source/third_party/libwebm/mkvparser/mkvreader.h: Added.
  • Source/third_party/libwebm/mkvparser_sample.cc: Added.
  • Source/third_party/libwebm/mkvreader.hpp: Added.
  • Source/third_party/libwebm/mkvwriter.hpp: Added.
  • Source/third_party/libwebm/sample_muxer_metadata.cc: Added.
  • Source/third_party/libwebm/sample_muxer_metadata.h: Added.

(SampleMuxerMetadata::SortableCue::operator> const):
(SampleMuxerMetadata::SortableCue::operator< const):

(webm::BufferReader::size const):

  • Source/third_party/libwebm/webm_parser/include/webm/callback.h: Added.
  • Source/third_party/libwebm/webm_parser/include/webm/dom_types.h: Added.

(webm::FrameMetadata::operator== const):
(webm::BlockMore::operator== const):
(webm::BlockAdditions::operator== const):
(webm::TimeSlice::operator== const):
(webm::Slices::operator== const):
(webm::VirtualBlock::operator== const):
(webm::Block::operator== const):
(webm::SimpleBlock::operator== const):
(webm::BlockGroup::operator== const):
(webm::Cluster::operator== const):
(webm::Ebml::operator== const):
(webm::Info::operator== const):
(webm::Seek::operator== const):
(webm::Audio::operator== const):
(webm::MasteringMetadata::operator== const):
(webm::Colour::operator== const):
(webm::Projection::operator== const):
(webm::Video::operator== const):
(webm::ContentEncAesSettings::operator== const):
(webm::ContentEncryption::operator== const):
(webm::ContentEncoding::operator== const):
(webm::ContentEncodings::operator== const):
(webm::TrackEntry::operator== const):
(webm::CueTrackPositions::operator== const):
(webm::CuePoint::operator== const):
(webm::ChapterDisplay::operator== const):
(webm::ChapterAtom::operator== const):
(webm::EditionEntry::operator== const):
(webm::SimpleTag::operator== const):
(webm::Targets::operator== const):
(webm::Tag::operator== const):

  • Source/third_party/libwebm/webm_parser/include/webm/element.h: Added.

(webm::Element::Element):
(webm::Element::Set):
(webm::Element::value const):
(webm::Element::mutable_value):
(webm::Element::is_present const):
(webm::Element::operator== const):
(webm::ElementMetadata::operator== const):

  • Source/third_party/libwebm/webm_parser/include/webm/file_reader.h: Added.

(webm::FileReader::FileCloseFunctor::operator() const):

  • Source/third_party/libwebm/webm_parser/include/webm/id.h: Added.
  • Source/third_party/libwebm/webm_parser/include/webm/istream_reader.h: Added.

(webm::IstreamReader::IstreamReader):
(webm::IstreamReader::Emplace):

  • Source/third_party/libwebm/webm_parser/include/webm/reader.h: Added.
  • Source/third_party/libwebm/webm_parser/include/webm/status.h: Added.

(webm::Status::Status):
(webm::Status::ok const):
(webm::Status::completed_ok const):
(webm::Status::is_parsing_error const):

  • Source/third_party/libwebm/webm_parser/include/webm/webm_parser.h: Added.
  • Source/third_party/libwebm/webm_parser/src/ancestory.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/ancestory.h: Added.

(webm::Ancestory::next const):
(webm::Ancestory::id const):
(webm::Ancestory::empty const):
(webm::Ancestory::Ancestory):

  • Source/third_party/libwebm/webm_parser/src/audio_parser.h: Added.

(webm::AudioParser::AudioParser):
(webm::AudioParser::FixMissingOutputFrequency):

  • Source/third_party/libwebm/webm_parser/src/bit_utils.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/bit_utils.h: Added.
  • Source/third_party/libwebm/webm_parser/src/block_additions_parser.h: Added.

(webm::BlockAdditionsParser::BlockAdditionsParser):

  • Source/third_party/libwebm/webm_parser/src/block_group_parser.h: Added.

(webm::BlockGroupParser::BlockGroupParser):

  • Source/third_party/libwebm/webm_parser/src/block_header_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/block_header_parser.h: Added.

(webm::BlockHeader::operator== const):
(webm::BlockHeaderParser::value const):

  • Source/third_party/libwebm/webm_parser/src/block_more_parser.h: Added.

(webm::BlockMoreParser::BlockMoreParser):

  • Source/third_party/libwebm/webm_parser/src/block_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/block_parser.h: Added.

(webm::BasicBlockParser::value const):
(webm::BasicBlockParser::mutable_value):

  • Source/third_party/libwebm/webm_parser/src/bool_parser.h: Added.

(webm::BoolParser::BoolParser):
(webm::BoolParser::value const):
(webm::BoolParser::mutable_value):

  • Source/third_party/libwebm/webm_parser/src/buffer_reader.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/byte_parser.h: Added.

(webm::ByteParser::ByteParser):
(webm::ByteParser::value const):
(webm::ByteParser::mutable_value):

  • Source/third_party/libwebm/webm_parser/src/callback.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/chapter_atom_parser.h: Added.

(webm::ChapterAtomParser::ChapterAtomParser):

  • Source/third_party/libwebm/webm_parser/src/chapter_display_parser.h: Added.

(webm::ChapterDisplayParser::ChapterDisplayParser):

  • Source/third_party/libwebm/webm_parser/src/chapters_parser.h: Added.

(webm::ChaptersParser::ChaptersParser):

  • Source/third_party/libwebm/webm_parser/src/cluster_parser.h: Added.

(webm::ClusterParser::ClusterParser):

  • Source/third_party/libwebm/webm_parser/src/colour_parser.h: Added.

(webm::ColourParser::ColourParser):

  • Source/third_party/libwebm/webm_parser/src/content_enc_aes_settings_parser.h: Added.

(webm::ContentEncAesSettingsParser::ContentEncAesSettingsParser):

  • Source/third_party/libwebm/webm_parser/src/content_encoding_parser.h: Added.

(webm::ContentEncodingParser::ContentEncodingParser):

  • Source/third_party/libwebm/webm_parser/src/content_encodings_parser.h: Added.

(webm::ContentEncodingsParser::ContentEncodingsParser):

  • Source/third_party/libwebm/webm_parser/src/content_encryption_parser.h: Added.

(webm::ContentEncryptionParser::ContentEncryptionParser):

  • Source/third_party/libwebm/webm_parser/src/cue_point_parser.h: Added.

(webm::CuePointParser::CuePointParser):

  • Source/third_party/libwebm/webm_parser/src/cue_track_positions_parser.h: Added.

(webm::CueTrackPositionsParser::CueTrackPositionsParser):

  • Source/third_party/libwebm/webm_parser/src/cues_parser.h: Added.

(webm::CuesParser::CuesParser):

  • Source/third_party/libwebm/webm_parser/src/date_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/date_parser.h: Added.

(webm::DateParser::value const):
(webm::DateParser::mutable_value):

  • Source/third_party/libwebm/webm_parser/src/ebml_parser.h: Added.

(webm::EbmlParser::EbmlParser):

  • Source/third_party/libwebm/webm_parser/src/edition_entry_parser.h: Added.

(webm::EditionEntryParser::EditionEntryParser):

  • Source/third_party/libwebm/webm_parser/src/element_parser.h: Added.

(webm::ElementParser::InitAfterSeek):
(webm::ElementParser::GetCachedMetadata):
(webm::ElementParser::WasSkipped const):

  • Source/third_party/libwebm/webm_parser/src/file_reader.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/float_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/float_parser.h: Added.

(webm::FloatParser::value const):
(webm::FloatParser::mutable_value):

  • Source/third_party/libwebm/webm_parser/src/id_element_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/id_element_parser.h: Added.

(webm::IdElementParser::value const):
(webm::IdElementParser::mutable_value):

  • Source/third_party/libwebm/webm_parser/src/id_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/id_parser.h: Added.
  • Source/third_party/libwebm/webm_parser/src/info_parser.h: Added.

(webm::InfoParser::InfoParser):

  • Source/third_party/libwebm/webm_parser/src/int_parser.h: Added.

(webm::IntParser::IntParser):
(webm::IntParser::value const):
(webm::IntParser::mutable_value):

  • Source/third_party/libwebm/webm_parser/src/istream_reader.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/master_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/master_parser.h: Added.

(webm::MasterParser::MasterParser):
(webm::MasterParser::header_size const):
(webm::MasterParser::size const):
(webm::MasterParser::position const):
(webm::MasterParser::child_metadata const):
(webm::MasterParser::MakeChild):
(webm::MasterParser::IdHash::operator() const):
(webm::MasterParser::InsertParser):

  • Source/third_party/libwebm/webm_parser/src/master_value_parser.h: Added.

(webm::MasterValueParser::value const):
(webm::MasterValueParser::mutable_value):
(webm::MasterValueParser::SingleChildFactory::SingleChildFactory):
(webm::MasterValueParser::SingleChildFactory::BuildParser):
(webm::MasterValueParser::SingleChildFactory:: const):
(webm::MasterValueParser::RepeatedChildFactory::RepeatedChildFactory):
(webm::MasterValueParser::RepeatedChildFactory::BuildParser):
(webm::MasterValueParser::RepeatedChildFactory:: const):
(webm::MasterValueParser::RecursiveChildFactory::RecursiveChildFactory):
(webm::MasterValueParser::RecursiveChildFactory::BuildParser):
(webm::MasterValueParser::RecursiveChildFactory:: const):
(webm::MasterValueParser::MasterValueParser):
(webm::MasterValueParser::MakeChild):
(webm::MasterValueParser::metadata const):
(webm::MasterValueParser::OnParseStarted):
(webm::MasterValueParser::OnParseCompleted):
(webm::MasterValueParser::parse_started_event_completed const):
(webm::MasterValueParser::set_parse_started_event_completed_with_action):
(webm::MasterValueParser::OnChildParsed):
(webm::MasterValueParser::child_metadata const):
(webm::MasterValueParser::ChildParser::ChildParser):
(webm::MasterValueParser::ChildParser::Prepare):
(webm::MasterValueParser::ChildParser::has_tag):
(webm::MasterValueParser::MakeChildParser):
(webm::MasterValueParser::PreInit):

  • Source/third_party/libwebm/webm_parser/src/mastering_metadata_parser.h: Added.

(webm::MasteringMetadataParser::MasteringMetadataParser):

  • Source/third_party/libwebm/webm_parser/src/parser.h: Added.
  • Source/third_party/libwebm/webm_parser/src/parser_utils.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/parser_utils.h: Added.

(webm::AccumulateIntegerBytes):

  • Source/third_party/libwebm/webm_parser/src/projection_parser.h: Added.

(webm::ProjectionParser::ProjectionParser):

  • Source/third_party/libwebm/webm_parser/src/recursive_parser.h: Added.

(webm::RecursiveParser::RecursiveParser):
(webm::RecursiveParser::value const):
(webm::RecursiveParser::mutable_value):

  • Source/third_party/libwebm/webm_parser/src/seek_head_parser.h: Added.

(webm::SeekHeadParser::SeekHeadParser):

  • Source/third_party/libwebm/webm_parser/src/seek_parser.h: Added.

(webm::SeekParser::SeekParser):

  • Source/third_party/libwebm/webm_parser/src/segment_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/segment_parser.h: Added.
  • Source/third_party/libwebm/webm_parser/src/simple_tag_parser.h: Added.

(webm::SimpleTagParser::SimpleTagParser):

  • Source/third_party/libwebm/webm_parser/src/size_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/size_parser.h: Added.
  • Source/third_party/libwebm/webm_parser/src/skip_callback.h: Added.
  • Source/third_party/libwebm/webm_parser/src/skip_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/skip_parser.h: Added.
  • Source/third_party/libwebm/webm_parser/src/slices_parser.h: Added.

(webm::SlicesParser::SlicesParser):

  • Source/third_party/libwebm/webm_parser/src/tag_parser.h: Added.

(webm::TagParser::TagParser):

  • Source/third_party/libwebm/webm_parser/src/tags_parser.h: Added.

(webm::TagsParser::TagsParser):

  • Source/third_party/libwebm/webm_parser/src/targets_parser.h: Added.

(webm::TargetsParser::TargetsParser):

  • Source/third_party/libwebm/webm_parser/src/time_slice_parser.h: Added.

(webm::TimeSliceParser::TimeSliceParser):

  • Source/third_party/libwebm/webm_parser/src/track_entry_parser.h: Added.

(webm::TrackEntryParser::TrackEntryParser):

  • Source/third_party/libwebm/webm_parser/src/tracks_parser.h: Added.

(webm::TracksParser::TracksParser):

  • Source/third_party/libwebm/webm_parser/src/unknown_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/unknown_parser.h: Added.
  • Source/third_party/libwebm/webm_parser/src/var_int_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/var_int_parser.h: Added.

(webm::VarIntParser::value const):
(webm::VarIntParser::encoded_length const):

  • Source/third_party/libwebm/webm_parser/src/video_parser.h: Added.

(webm::VideoParser::VideoParser):
(webm::VideoParser::FixMissingDisplaySize):

  • Source/third_party/libwebm/webm_parser/src/virtual_block_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/virtual_block_parser.h: Added.

(webm::VirtualBlockParser::value const):
(webm::VirtualBlockParser::mutable_value):

  • Source/third_party/libwebm/webm_parser/src/void_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/src/void_parser.h: Added.
  • Source/third_party/libwebm/webm_parser/src/webm_parser.cc: Added.
  • Source/third_party/libwebm/webm_parser/test_utils/element_parser_test.h: Added.

(webm::static_cast<Id>):

  • Source/third_party/libwebm/webm_parser/test_utils/limited_reader.cc: Added.
  • Source/third_party/libwebm/webm_parser/test_utils/limited_reader.h: Added.
  • Source/third_party/libwebm/webm_parser/test_utils/mock_callback.h: Added.

(webm::MockCallback::MockCallback):
(webm::MockCallback::OnElementBeginConcrete):
(webm::MockCallback::OnUnknownElementConcrete):
(webm::MockCallback::OnEbmlConcrete):
(webm::MockCallback::OnVoidConcrete):
(webm::MockCallback::OnSegmentBeginConcrete):
(webm::MockCallback::OnSeekConcrete):
(webm::MockCallback::OnInfoConcrete):
(webm::MockCallback::OnClusterBeginConcrete):
(webm::MockCallback::OnSimpleBlockBeginConcrete):
(webm::MockCallback::OnSimpleBlockEndConcrete):
(webm::MockCallback::OnBlockGroupBeginConcrete):
(webm::MockCallback::OnBlockBeginConcrete):
(webm::MockCallback::OnBlockEndConcrete):
(webm::MockCallback::OnBlockGroupEndConcrete):
(webm::MockCallback::OnFrameConcrete):
(webm::MockCallback::OnClusterEndConcrete):
(webm::MockCallback::OnTrackEntryConcrete):
(webm::MockCallback::OnCuePointConcrete):
(webm::MockCallback::OnEditionEntryConcrete):
(webm::MockCallback::OnTagConcrete):
(webm::MockCallback::OnSegmentEndConcrete):

  • Source/third_party/libwebm/webm_parser/test_utils/parser_test.h: Added.

(webm::ParserTest::SetReaderData):
(webm::ParserTest::ResetParser):
(webm::ParserTest::ParseAndVerify):
(webm::ParserTest::IncrementalParseAndVerify):
(webm::ParserTest::ParseAndExpectResult):

  • Source/third_party/libwebm/webm_parser/tests/audio_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/bit_utils_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/block_additions_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/block_group_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/block_header_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/block_more_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/block_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/bool_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/buffer_reader_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/byte_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/callback_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/chapter_atom_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/chapter_display_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/chapters_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/cluster_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/colour_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/content_enc_aes_settings_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/content_encoding_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/content_encodings_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/content_encryption_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/cue_point_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/cue_track_positions_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/cues_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/date_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/ebml_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/edition_entry_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/element_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/float_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/id_element_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/id_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/info_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/int_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/istream_reader_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/limited_reader_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/master_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/master_value_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/mastering_metadata_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/parser_utils_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/projection_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/recursive_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/seek_head_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/seek_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/segment_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/simple_tag_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/size_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/skip_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/slices_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/tag_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/tags_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/targets_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/time_slice_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/track_entry_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/tracks_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/unknown_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/var_int_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/video_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/virtual_block_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/void_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/webm_parser_test.cc: Added.
  • Source/third_party/libwebm/webm_parser/tests/webm_parser_tests.cc: Added.
  • Source/third_party/libwebm/webmids.hpp: Added.
  • Source/third_party/libwebm/webvtt/vttreader.cc: Added.
  • Source/third_party/libwebm/webvtt/vttreader.h: Added.
  • Source/third_party/libwebm/webvtt/webvttparser.cc: Added.
  • Source/third_party/libwebm/webvtt/webvttparser.h: Added.
  • Source/third_party/libwebm/webvttparser.h: Added.
  • libwebrtc.xcodeproj/project.pbxproj:
6:08 PM Changeset in webkit [264491] by Jonathan Bedard
  • 2 edits in trunk/Tools

[configure-xcode-for-embedded-development] Support TBD version 4
​https://bugs.webkit.org/show_bug.cgi?id=214431
<rdar://problem/65695728>

Reviewed by Alexey Proskuryakov.

  • Scripts/configure-xcode-for-embedded-development: Match both archs and targets.
6:07 PM Changeset in webkit [264490] by jiewen_tan@apple.com
  • 32 edits in trunk

[WebAuthn] Add a console message: "User gesture is required to use the platform authenticator."
​https://bugs.webkit.org/show_bug.cgi?id=214380
<rdar://problem/65300587>

Reviewed by Devin Rousso.

Source/WebKit:

Covered by existing tests.

  • WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:

(WebKit::WebAuthenticatorCoordinator::makeCredential):
(WebKit::WebAuthenticatorCoordinator::getAssertion):

LayoutTests:

  • http/wpt/credential-management/credentialscontainer-store-basics.https-expected.txt:
  • http/wpt/webauthn/ctap-hid-failure.https-expected.txt:
  • http/wpt/webauthn/ctap-hid-success.https-expected.txt:
  • http/wpt/webauthn/ctap-nfc-failure.https-expected.txt:
  • http/wpt/webauthn/idl.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure-hid.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure-local-silent.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure-local.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure-u2f.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-success-local.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-success-u2f.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-failure-hid.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-failure-local-silent.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-failure-local.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-failure-nfc.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-failure-u2f-silent.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-failure-u2f.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-failure.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-success-hid.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-success-local.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-success-nfc.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-get-success-u2f.https-expected.txt:
6:00 PM Changeset in webkit [264489] by pvollan@apple.com
  • 4 edits in trunk/Source

XPC connection should be suspended before setting target queue
​https://bugs.webkit.org/show_bug.cgi?id=214427

Reviewed by Darin Adler.

Source/WebKit:

According to system logs, an active XPC connection should be suspended before setting a new target queue.

No new tests, since there should be no behavior change introduced by this patch.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::handleXPCEndpointMessages const):

Source/WTF:

Declare function to suspend XPC connection.

  • wtf/spi/darwin/XPCSPI.h:
5:33 PM Changeset in webkit [264488] by Fujii Hironori
  • 161 edits in trunk

[WTF] Remove the unnecessary inner class DefaultHash<T>::Hash
​https://bugs.webkit.org/show_bug.cgi?id=214389

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • assembler/MacroAssemblerCodeRef.h:
  • b3/B3CheckSpecial.h:
  • b3/B3Kind.h:
  • b3/B3ValueKey.h:
  • b3/air/AirAllocateRegistersByGraphColoring.cpp:
  • b3/air/AirArg.h:
  • b3/air/AirTmp.h:
  • bytecode/BytecodeIndex.h:
  • bytecode/CallVariant.h:
  • bytecode/CodeOrigin.h:
  • bytecode/DFGExitProfile.h:
  • bytecode/LazyOperandValueProfile.h:
  • bytecode/ObjectPropertyCondition.h:
  • bytecode/PropertyCondition.h:
  • dfg/DFGAbstractHeap.h:
  • dfg/DFGArgumentsEliminationPhase.cpp:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGCompilationKey.h:
  • dfg/DFGDesiredGlobalProperty.h:
  • dfg/DFGHeapLocation.h:
  • dfg/DFGLivenessAnalysisPhase.cpp:
  • dfg/DFGMinifiedID.h:
  • dfg/DFGNodeFlowProjection.h:
  • dfg/DFGPromotedHeapLocation.h:
  • dfg/DFGPropertyTypeKey.h:
  • dfg/DFGPureValue.h:
  • ftl/FTLLocation.h:
  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):

  • ftl/FTLSlowPathCallKey.h:
  • heap/MarkedBlock.h:
  • heap/VisitRaceKey.h:
  • inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
  • inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
  • inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
  • inspector/scripts/tests/expected/enum-values.json-result:
  • inspector/scripts/tests/expected/type-declaration-array-type.json-result:
  • inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
  • inspector/scripts/tests/expected/type-declaration-object-type.json-result:
  • inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
  • jit/ICStats.h:
  • jit/JITThunks.h:
  • jit/Reg.h:
  • jit/RegisterSet.h:
  • parser/VariableEnvironment.h:
  • profiler/ProfilerOrigin.h:
  • profiler/ProfilerOriginStack.h:
  • profiler/ProfilerUID.h:
  • runtime/CachedTypes.cpp:
  • runtime/ControlFlowProfiler.h:
  • runtime/NativeFunction.h:
  • runtime/PrototypeKey.h:
  • runtime/RegExpKey.h:
  • runtime/TemplateObjectDescriptor.h:
  • runtime/TypeProfiler.h:
  • runtime/VarOffset.h:
  • runtime/WeakGCMap.h:
  • wasm/WasmBBQPlan.h:
  • wasm/WasmCodeBlock.h:
  • wasm/WasmEntryPlan.h:
  • wasm/WasmLLIntPlan.h:
  • wasm/WasmSignature.h:

Source/WebCore:

  • Modules/indexeddb/IDBDatabaseIdentifier.h:
  • Modules/indexeddb/shared/IDBResourceIdentifier.h:
  • Modules/webgpu/WHLSL/AST/WHLSLUnnamedTypeHash.h:
  • Modules/webgpu/WHLSL/WHLSLSemanticMatcher.cpp:

(WebCore::WHLSL::matchResources):
(WebCore::WHLSL::matchVertexAttributes):
(WebCore::WHLSL::matchColorAttachments):

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityObject.h:
  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeActions):

  • contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::TriggerHash::hash):

  • contentextensions/ContentExtensionStyleSheet.h:
  • contentextensions/DFA.cpp:

(WebCore::ContentExtensions::printTransitions):

  • contentextensions/DFABytecodeInterpreter.h:
  • contentextensions/DFACombiner.cpp:

(WebCore::ContentExtensions::DFAMerger::getOrCreateCombinedNode):

  • contentextensions/DFANode.cpp:

(WebCore::ContentExtensions::DFANode::bestFallbackTarget const):

  • contentextensions/ImmutableNFANodeBuilder.h:
  • contentextensions/NFA.cpp:

(WebCore::ContentExtensions::NFA::debugPrintDot const):

  • contentextensions/NFANode.h:
  • contentextensions/NFAToDFA.cpp:

(WebCore::ContentExtensions::NodeIdSetToUniqueNodeIdSetSource::NodeIdSetToUniqueNodeIdSetSource):
(WebCore::ContentExtensions::NodeIdSetToUniqueNodeIdSetTranslator::translate):

  • css/makeprop.pl:
  • css/parser/CSSParserContext.h:
  • dom/GCReachableRef.h:
  • dom/MessagePortIdentifier.h:
  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::NodeListCacheMapEntryHash::hash):
(WebCore::NodeListsNodeData::NodeListCacheMapEntryHash::equal):

  • dom/QualifiedName.h:
  • history/BackForwardItemIdentifier.h:
  • html/canvas/WebGLRenderingContextBase.h:
  • layout/LayoutUnits.h:
  • loader/AdClickAttribution.h:
  • loader/ResourceCryptographicDigest.h:

(WTF::DefaultHash<WebCore::ResourceCryptographicDigest>::hash):
(WTF::DefaultHash<WebCore::ResourceCryptographicDigest>::equal):
(WTF::DefaultHash<WebCore::ResourceCryptographicDigest>::Hash::hash): Deleted.
(WTF::DefaultHash<WebCore::ResourceCryptographicDigest>::Hash::equal): Deleted.

  • page/ClientOrigin.h:
  • page/GlobalWindowIdentifier.h:
  • page/SecurityOriginData.h:
  • page/SecurityOriginHash.h:
  • platform/Cookie.h:
  • platform/RegistrableDomain.h:
  • platform/graphics/ColorHash.h:
  • platform/graphics/FloatSizeHash.h:

(WTF::FloatHash<WebCore::FloatSize>::hash):

  • platform/graphics/FontGenericFamilies.h:
  • platform/graphics/IntPointHash.h:
  • platform/graphics/IntRectHash.h:

(WTF::IntHash<WebCore::IntRect>::hash):
(WTF::IntHash<WebCore::IntRect>::equal):

  • platform/graphics/IntSizeHash.h:
  • platform/graphics/WidthCache.h:
  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FallbackFontDescriptionKey::computeHash const):

  • platform/network/HTTPParsers.h:
  • platform/network/ProtectionSpaceHash.h:
  • platform/win/COMPtr.h:
  • platform/win/WindowsKeyNames.h:
  • rendering/CSSValueKey.h:
  • rendering/GridBaselineAlignment.h:
  • rendering/GridTrackSizingAlgorithm.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid const):

  • rendering/RenderTheme.h:
  • style/RuleSet.cpp:

(WebCore::Style::RuleSet::evaluateDynamicMediaQueryRules):

  • svg/SVGElement.h:

(WebCore::SVGAttributeHashTranslator::hash):

  • workers/service/ServiceWorkerClientIdentifier.h:
  • workers/service/ServiceWorkerRegistrationKey.h:

Source/WebCore/PAL:

  • pal/SessionID.h:

Source/WebKit:

  • NetworkProcess/Downloads/DownloadID.h:
  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheKey.h:
  • Platform/IPC/MessageReceiverMap.h:
  • Platform/IPC/StringReference.h:
  • Shared/CallbackID.h:
  • UIProcess/API/cpp/WKRetainPtr.h:

Source/WebKitLegacy/win:

  • COMPropertyBag.h:

Source/WTF:

DefaultHash<T> doesn't need to have a inner struct Hash. This can
be a problem for forward declarations (Bug 214320 Comment 5).

  • wtf/BitVector.h:
  • wtf/Forward.h:
  • wtf/HashFunctions.h:

(WTF::PairHash::hash):
(WTF::PairHash::equal):
(WTF::TupleHash::hash):
(WTF::TupleHash::equal):

  • wtf/ListHashSet.h:
  • wtf/LoggingHashMap.h:
  • wtf/LoggingHashSet.h:
  • wtf/MetaAllocatorPtr.h:
  • wtf/ObjectIdentifier.h:
  • wtf/OptionSetHash.h:

(WTF::DefaultHash<OptionSet<T>>::hash):
(WTF::DefaultHash<OptionSet<T>>::equal):
(WTF::DefaultHash<OptionSet<T>>::Hash::hash): Deleted.
(WTF::DefaultHash<OptionSet<T>>::Hash::equal): Deleted.

  • wtf/Packed.h:
  • wtf/RetainPtr.h:
  • wtf/StackShot.h:
  • wtf/URLHash.h:
  • wtf/VectorHash.h:

(WTF::VectorHash::hash):

  • wtf/text/AtomString.h:
  • wtf/text/AtomStringHash.h:
  • wtf/text/CString.h:
  • wtf/text/StringHash.h:
  • wtf/text/StringImpl.h:
  • wtf/text/SymbolRegistry.h:

(WTF::DefaultHash<SymbolRegistryKey>::hash):
(WTF::DefaultHash<SymbolRegistryKey>::equal):
(WTF::DefaultHash<SymbolRegistryKey>::Hash::hash): Deleted.
(WTF::DefaultHash<SymbolRegistryKey>::Hash::equal): Deleted.

  • wtf/text/WTFString.h:

Tools:

  • TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h:

(WTF::DefaultHash<DeletedAddressOfOperator>::hash):
(WTF::DefaultHash<DeletedAddressOfOperator>::equal):
(WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash): Deleted.
(WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal): Deleted.

  • TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:

(TestWebKitAPI::bucketForKey):

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::bucketForKey):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::testInitialCapacity):

  • TestWebKitAPI/Tests/WTF/MoveOnly.h:

(WTF::DefaultHash<MoveOnly>::hash):
(WTF::DefaultHash<MoveOnly>::equal):
(WTF::DefaultHash<MoveOnly>::Hash::hash): Deleted.
(WTF::DefaultHash<MoveOnly>::Hash::equal): Deleted.

4:59 PM Changeset in webkit [264487] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[ macOS iOS ] imported/mozilla/svg/linearGradient-basic-03.svg is passing and expectations need to be removed
​https://bugs.webkit.org/show_bug.cgi?id=214430

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-07-16

4:56 PM Changeset in webkit [264486] by commit-queue@webkit.org
  • 15 edits
    3 adds in trunk

IDB serialization of some DOM object types crashes the Networking process due to incorrect global object type (WPT IndexedDB/structured-clone.any tests fail)
​https://bugs.webkit.org/show_bug.cgi?id=210735
<rdar://problem/62045703>

Patch by Sihui Liu <​sihui_liu@appe.com> on 2020-07-16
Reviewed by Yusuke Suzuki.

Source/WebCore:

In r239746, IDB went back to use JSGlobalObject for serialization and deserialization. However, in our current
implementation, there is a strong assumption that DOM JS objects are tied to JSDOMGlobalObject, which is
derived from JSGlobalObject. For example, in SerializedScriptValue.cpp, we cast the global object to
JSDOMGlobalObject in many places.

We recently notice this issue when we enable some wpt test, which has been disabled since it was imported as
some types were not supported. The test fails as DOMMatrix object requires its global object to be
JSDOMGlobalObject. To fix this, introduce a new Class JSIDBSerializationGlobalObject, derived from
JSDOMGlobalObject, and use it for IDB serialization.

Tests: LayoutTests/storage/indexeddb/structured-clone.html

LayoutTests/storage/indexeddb/structured-clone-private.html

  • Modules/indexeddb/server/IDBSerializationContext.cpp:

(WebCore::IDBServer::IDBSerializationContext::initializeVM):

  • Modules/indexeddb/server/IDBSerializationContext.h:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::scriptExecutionContext const):

  • bindings/js/JSIDBSerializationGlobalObject.cpp: Added.

(WebCore::JSIDBSerializationGlobalObject::JSIDBSerializationGlobalObject):
(WebCore::JSIDBSerializationGlobalObject::create):
(WebCore::JSIDBSerializationGlobalObject::finishCreation):
(WebCore::JSIDBSerializationGlobalObject::subspaceForImpl):
(WebCore::JSIDBSerializationGlobalObject::destroy):

  • bindings/js/JSIDBSerializationGlobalObject.h: Added.
  • bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::JSVMClientData):

  • bindings/js/WebCoreJSClientData.h:

(WebCore::JSVMClientData::idbSerializationSpace):

  • dom/EmptyScriptExecutionContext.h: Added.
  • worklets/WorkletScriptController.h:

LayoutTests:

  • platform/ios/TestExpectations:
  • platform/wk2/TestExpectations:
  • storage/indexeddb/resources/structured-clone.js:

(testPrimitiveValue):
(testBoolean):
(testBooleanObject):
(testString):
(testStringObject):
(testNumber):
(testNumberObject):
(testBigInt):
(testBigIntObject.testOneBigIntObject):
(testBigIntObject):
(testDateObject):
(testTypedArray.testTypedArrayValue):
(testArrays):
(testGeometryTypes.testOneGeometryType):
(testRTCCertificate.promise.then):
(testRTCCertificate):
(testCryptoKey.promise.then):
(testBadTypes): Deleted.

  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone-private-expected.txt:
4:35 PM Changeset in webkit [264485] by Takashi.Komori@sony.com
  • 2 edits in trunk/Source/WebKit

[WinCairo][CURL] NetworkProcess consumes CPU resource greedily
​https://bugs.webkit.org/show_bug.cgi?id=214383

Reviewed by Fujii Hironori.

Add PolicyAction::Ignore handling routine in NetworkDataTaskCurl::invokeDidReceiveResponse()
If we don't cancel the ignored requests the worker thread for curl scheduler goes busy-looping because the fds of the requests continue to be monitored.

No tests needed as existing tests cover this change.

  • NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse):

4:33 PM Changeset in webkit [264484] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebKit

iPad cursor is sometimes slow to change to I-beam (e.g. on reddit.com)
​https://bugs.webkit.org/show_bug.cgi?id=214424
<rdar://problem/59503572>

Reviewed by Wenson Hsieh.

No new tests, just an optimization.

  • Shared/ios/InteractionInformationRequest.h:
  • Shared/ios/InteractionInformationRequest.cpp:

(WebKit::InteractionInformationRequest::encode const):
(WebKit::InteractionInformationRequest::decode):
(WebKit::InteractionInformationRequest::isValidForRequest):
(WebKit::InteractionInformationRequest::isApproximatelyValidForRequest):
'const'-ify these getters

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::positionInformation):
Make it possible to disable computation of the 'nodeAtPositionHasDoubleClickHandler' property,
because it can be quite expensive for some web content. We will still compute it by default,
but high-rate interaction information requests (like those for the cursor) can optionally disable it.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanUpInteraction]):
(-[WKContentView requestAsynchronousPositionInformationUpdate:]):
(-[WKContentView _hasValidOutstandingPositionInformationRequest:]):
(-[WKContentView _positionInformationDidChange:]):
When position information updates come in, only clear the outstanding request
if the reply is valid for that request; otherwise, the outstanding request is
definitely still outstanding, and we've probably just sent multiple requests.
A more formal mechanism that actually keeps track of all requests might be
more appropriate here in the future, but this helps us avoid re-requesting
position information for the same point repeatedly, just because old (stale)
updates are coming in.

(-[WKContentView _cursorInteraction:regionForLocation:defaultRegion:completion:]):
Instead of requesting an interaction information update for every cursor update,
and then dropping them on the floor when they return, if a new request was sent,
simply coalesce all requests that come in while we have an outstanding one.
This avoids a great deal of unnecessary (and ignored) work when the Web Content
process is responding to requests at a slower rate than the cursor interaction
is trying to retrieve new regions.

4:25 PM Changeset in webkit [264483] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[ macOS iOS ] imported/mozilla/svg/blend-saturation.svg is passing and need expectations removed
​https://bugs.webkit.org/show_bug.cgi?id=214428

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-07-16

3:25 PM Changeset in webkit [264482] by eric.carlson@apple.com
  • 5 edits in trunk/Source

Use AVRoutePickerView when available for choosing AirPlay devices
​https://bugs.webkit.org/show_bug.cgi?id=213497
<rdar://problem/58610662>

Unreviewed build fix.

Source/WebCore:

  • platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm:
  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::routePicker): Use HAVE_AVROUTEPICKERVIEW.

Source/WTF:

  • wtf/PlatformHave.h: Define HAVE_AVROUTEPICKERVIEW.
2:59 PM Changeset in webkit [264481] by Megan Gardner
  • 4 edits
    2 adds in trunk

Selection is not always clearing when tapping.
​https://bugs.webkit.org/show_bug.cgi?id=214326
Source/WebKit:

<rdar://problem/65069201>

Reviewed by Wenson Hsieh.

In r262280 we stopped the UIWKGestureOneFingerTap gesture from starting if the tap was not inside
the current selection. That caused the selection to not always be cleared, especially when tapping
on an element that could create an overlay in which the selection was supposed to be obscured. We
short circuited this gesture because it used to cause a sync IPC message to be sent to the web process,
but that code has subsequently changed, so allowing the gesture to start and clear the selection in all
cases is no longer a performance concern, so changing the behavior back to allowing the gesture to always
start, even if the touch is not inside the selection rect.

Test: editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):

LayoutTests:

Reviewed by Wenson Hsieh.

  • editing/selection/ios/hide-selection-after-tap-on-prevent-default-element-expected.txt: Added.
  • editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html: Added.
  • resources/ui-helper.js:

(window.UIHelper.tapElement):

2:54 PM Changeset in webkit [264480] by Jonathan Bedard
  • 2 edits in trunk/Tools

[configure-xcode-for-embedded-development] Support Xcode 12
​https://bugs.webkit.org/show_bug.cgi?id=214420
<rdar://problem/65687153>

Reviewed by Alexey Proskuryakov.

  • Scripts/configure-xcode-for-embedded-development: Mac xcspec files are in a different

spot in Xcode 12.

2:26 PM Changeset in webkit [264479] by Truitt Savell
  • 2 edits in trunk/LayoutTests

(r264469) [ Mac ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=214422

Unreviewed test gardening.

  • platform/mac/TestExpectations:
2:18 PM Changeset in webkit [264478] by Chris Dumez
  • 30 edits
    2 moves
    13 adds
    2 deletes in trunk/LayoutTests

Resync web-platform-tests/interfaces from upstream
​https://bugs.webkit.org/show_bug.cgi?id=214413

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Resync web-platform-tests/interfaces from upstream 81de986322a0de90f2.

  • web-platform-tests/interfaces/CSS-Parser-API.idl: Removed.
  • web-platform-tests/interfaces/ambient-light.idl:
  • web-platform-tests/interfaces/appmanifest.idl:
  • web-platform-tests/interfaces/background-sync.idl: Renamed from LayoutTests/imported/w3c/web-platform-tests/interfaces/BackgroundSync.idl.
  • web-platform-tests/interfaces/compression.idl: Added.
  • web-platform-tests/interfaces/content-index.idl: Added.
  • web-platform-tests/interfaces/cookie-store.idl:
  • web-platform-tests/interfaces/css-properties-values-api.idl:
  • web-platform-tests/interfaces/custom-state-pseudo-class.idl: Added.
  • web-platform-tests/interfaces/deprecation-reporting.idl: Added.
  • web-platform-tests/interfaces/fetch.idl:
  • web-platform-tests/interfaces/get-installed-related-apps.idl: Added.
  • web-platform-tests/interfaces/html.idl:
  • web-platform-tests/interfaces/image-capture.idl:
  • web-platform-tests/interfaces/input-device-capabilities.idl: Renamed from LayoutTests/imported/w3c/web-platform-tests/interfaces/InputDeviceCapabilities.idl.
  • web-platform-tests/interfaces/intervention-reporting.idl: Added.
  • web-platform-tests/interfaces/is-input-pending.idl: Added.
  • web-platform-tests/interfaces/media-capabilities.idl:
  • web-platform-tests/interfaces/native-file-system.idl:
  • web-platform-tests/interfaces/payment-handler.idl:
  • web-platform-tests/interfaces/picture-in-picture.idl:
  • web-platform-tests/interfaces/pointerevents.idl:
  • web-platform-tests/interfaces/savedata.idl: Added.
  • web-platform-tests/interfaces/scroll-animations.idl:
  • web-platform-tests/interfaces/storage-access-api.tentative.idl: Removed.
  • web-platform-tests/interfaces/storage-access.idl: Added.
  • web-platform-tests/interfaces/streams.idl: Added.
  • web-platform-tests/interfaces/ua-client-hints.idl: Added.
  • web-platform-tests/interfaces/w3c-import.log:
  • web-platform-tests/interfaces/wai-aria.idl:
  • web-platform-tests/interfaces/web-otp.idl: Added.
  • web-platform-tests/interfaces/webauthn.idl:
  • web-platform-tests/interfaces/webdriver.idl:
  • web-platform-tests/interfaces/webhid.idl: Added.
  • web-platform-tests/interfaces/webxr-ar-module.idl:
  • web-platform-tests/interfaces/webxr.idl:
  • web-platform-tests/interfaces/xhr.idl:
  • web-platform-tests/xhr/idlharness.any-expected.txt:
  • web-platform-tests/xhr/idlharness.any.worker-expected.txt:

LayoutTests:

  • platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
1:52 PM Changeset in webkit [264477] by eric.carlson@apple.com
  • 27 edits
    4 copies
    1 add in trunk

Use AVRoutePickerView when available for choosing AirPlay devices
​https://bugs.webkit.org/show_bug.cgi?id=213497
<rdar://problem/58610662>

Reviewed by Jer Noble.

Source/WebCore:

Use an AVRoutePickerView, the replacement for AVOutputDeviceMenuController, when
it is available to allow a user to pick an AirPlay device. To do this, create an
AVPlaybackTargetPicker abstract base and create a concrete class from the
AVOutputDeviceMenuController-specific code from MediaPlaybackTargetPickerMac, and
create a new concrete class using AVRoutePickerView.

Tested manually because these changes require an AirPlay device.

  • Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::showPlaybackTargetPicker): Pass the view to the
target picker.

  • Modules/mediasession/WebMediaSessionManagerClient.h:
  • Modules/remoteplayback/RemotePlayback.cpp:

(WebCore::RemotePlayback::playbackTargetPickerWasDismissed): Drive-by fix: return
early if there are no pending promises.

  • SourcesCocoa.txt: Add new files.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/MediaPlaybackTargetPicker.cpp:

(WebCore::MediaPlaybackTargetPicker::showPlaybackTargetPicker): Add new parameter.

  • platform/graphics/MediaPlaybackTargetPicker.h:
  • platform/graphics/avfoundation/objc/AVOutputDeviceMenuControllerTargetPicker.h: Copied from Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h.
  • platform/graphics/avfoundation/objc/AVOutputDeviceMenuControllerTargetPicker.mm: Copied from Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm.

(WebCore::AVOutputDeviceMenuControllerTargetPicker::AVOutputDeviceMenuControllerTargetPicker):
(WebCore::AVOutputDeviceMenuControllerTargetPicker::~AVOutputDeviceMenuControllerTargetPicker):
(WebCore::AVOutputDeviceMenuControllerTargetPicker::devicePicker):
(WebCore::AVOutputDeviceMenuControllerTargetPicker::availableDevicesDidChange):
(WebCore::AVOutputDeviceMenuControllerTargetPicker::currentDeviceDidChange):
(WebCore::AVOutputDeviceMenuControllerTargetPicker::showPlaybackTargetPicker):
(WebCore::AVOutputDeviceMenuControllerTargetPicker::startingMonitoringPlaybackTargets):
(WebCore::AVOutputDeviceMenuControllerTargetPicker::stopMonitoringPlaybackTargets):
(WebCore::AVOutputDeviceMenuControllerTargetPicker::invalidatePlaybackTargets):
(WebCore::AVOutputDeviceMenuControllerTargetPicker::externalOutputDeviceAvailable):
(WebCore::AVOutputDeviceMenuControllerTargetPicker::outputContext):
(-[WebAVOutputDeviceMenuControllerHelper initWithCallback:]):
(-[WebAVOutputDeviceMenuControllerHelper clearCallback]):
(-[WebAVOutputDeviceMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]):

  • platform/graphics/avfoundation/objc/AVPlaybackTargetPicker.h: Added.

(WebCore::AVPlaybackTargetPicker::AVPlaybackTargetPicker):
(WebCore::AVPlaybackTargetPicker::client const):

  • platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.h: Added.
  • platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm: Added.

(WebCore::AVRoutePickerViewTargetPicker::isAvailable):
(WebCore::AVRoutePickerViewTargetPicker::AVRoutePickerViewTargetPicker):
(WebCore::AVRoutePickerViewTargetPicker::~AVRoutePickerViewTargetPicker):
(WebCore::AVRoutePickerViewTargetPicker::outputContextInternal):
(WebCore::AVRoutePickerViewTargetPicker::devicePicker):
(WebCore::AVRoutePickerViewTargetPicker::routeDetector):
(WebCore::AVRoutePickerViewTargetPicker::showPlaybackTargetPicker):
(WebCore::AVRoutePickerViewTargetPicker::startingMonitoringPlaybackTargets):
(WebCore::AVRoutePickerViewTargetPicker::stopMonitoringPlaybackTargets):
(WebCore::AVRoutePickerViewTargetPicker::externalOutputDeviceAvailable):
(WebCore::AVRoutePickerViewTargetPicker::outputContext):
(WebCore::AVRoutePickerViewTargetPicker::invalidatePlaybackTargets):
(WebCore::AVRoutePickerViewTargetPicker::availableDevicesDidChange):
(WebCore::AVRoutePickerViewTargetPicker::currentDeviceDidChange):
(WebCore::AVRoutePickerViewTargetPicker::devicePickerWasDismissed):
(-[WebAVRoutePickerViewHelper initWithCallback:]):
(-[WebAVRoutePickerViewHelper dealloc]):
(-[WebAVRoutePickerViewHelper clearCallback]):
(-[WebAVRoutePickerViewHelper routePickerViewDidEndPresentingRoutes:]):
(-[WebAVRoutePickerViewHelper notificationHandler:]):

  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::MediaPlaybackTargetPickerMac):
(WebCore::MediaPlaybackTargetPickerMac::~MediaPlaybackTargetPickerMac):
(WebCore::MediaPlaybackTargetPickerMac::externalOutputDeviceAvailable):
(WebCore::MediaPlaybackTargetPickerMac::playbackTarget):
(WebCore::MediaPlaybackTargetPickerMac::routePicker):
(WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker):
(WebCore::MediaPlaybackTargetPickerMac::startingMonitoringPlaybackTargets):
(WebCore::MediaPlaybackTargetPickerMac::stopMonitoringPlaybackTargets):
(WebCore::MediaPlaybackTargetPickerMac::invalidatePlaybackTargets):
(WebCore::MediaPlaybackTargetPickerMac::pickerWasDismissed):
(WebCore::MediaPlaybackTargetPickerMac::availableDevicesChanged):
(WebCore::MediaPlaybackTargetPickerMac::currentDeviceChanged):
(WebCore::MediaPlaybackTargetPickerMac::devicePicker): Deleted.
(-[WebAVOutputDeviceMenuControllerHelper initWithCallback:]): Deleted.
(-[WebAVOutputDeviceMenuControllerHelper clearCallback]): Deleted.
(-[WebAVOutputDeviceMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]): Deleted.

  • platform/mock/MediaPlaybackTargetPickerMock.cpp:

(WebCore::MediaPlaybackTargetPickerMock::showPlaybackTargetPicker):

  • platform/mock/MediaPlaybackTargetPickerMock.h:

Source/WebCore/PAL:

  • pal/cocoa/AVFoundationSoftLink.h:
  • pal/cocoa/AVFoundationSoftLink.mm: Soft link AVRoutePickerView.
  • pal/spi/cocoa/AVKitSPI.h: Declare AVRoutePickerView.

Source/WebKit:

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformView const): Add new override.

Source/WebKitLegacy/mac:

  • WebView/WebMediaPlaybackTargetPicker.h:

(WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker): Deleted.

  • WebView/WebMediaPlaybackTargetPicker.mm:

(WebMediaPlaybackTargetPicker::create):
(WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker):
(WebMediaPlaybackTargetPicker::invalidate):
(WebMediaPlaybackTargetPicker::platformView const): New override.

  • WebView/WebView.mm:

(-[WebView _devicePicker]): Pass view to WebMediaPlaybackTargetPicker factory.

Tools:

  • TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:

(TestWebKitAPI::TEST): Test AVOutputContextOutputDevicesDidChangeNotification.
Don't check AVRouteDetectorMultipleRoutesDetectedDidChangeNotification on watchOS,
we don't use it there.

1:49 PM Changeset in webkit [264476] by jer.noble@apple.com
  • 29 edits
    3 copies
    3 adds in trunk

[Cocoa] Add MediaCapabilities support for SW VP9 decoder.
​https://bugs.webkit.org/show_bug.cgi?id=214316

Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/mac/media/mediacapabilities/vp9-decodingInfo-sw.html

Add some foundational support for SW VP9, which due to policy decisions will need information
both on the system battery status and the power adapter status, and these need to be shipped
into the WebContent process from the UIProcess.

Add some Internal override settings to allow the policies to be effectively tested through
LayouTests. This includes overrides for system battery and AC state, as well as overrides for
screen size and resolution.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformScreen.cpp:

(WebCore::getScreenProperties):

  • platform/PlatformScreen.h:
  • platform/ScreenProperties.h:

(WebCore::ScreenData::encode const):
(WebCore::ScreenData::decode):

  • platform/cocoa/PowerSourceNotifier.h:
  • platform/cocoa/PowerSourceNotifier.mm:

(WebCore::PowerSourceNotifier::PowerSourceNotifier):
(WebCore::PowerSourceNotifier::~PowerSourceNotifier):
(WebCore::PowerSourceNotifier::notifyPowerSourceChanged):

  • platform/cocoa/SystemBattery.h:
  • platform/cocoa/SystemBattery.mm:

(WebCore::systemHasBattery):
(WebCore::resetSystemHasAC):
(WebCore::setSystemHasAC):
(WebCore::systemHasAC):
(WebCore::setOverrideSystemHasBatteryForTesting):
(WebCore::setOverrideSystemHasACForTesting):

  • platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:

(WebCore::videoCodecTypeFromRFC4281Type):
(WebCore::createMediaPlayerDecodingConfigurationCocoa):

  • platform/graphics/cocoa/VP9UtilitiesCocoa.h: Copied from Source/WebCore/PAL/pal/spi/cocoa/IOPSLibSPI.h.
  • platform/graphics/cocoa/VP9UtilitiesCocoa.mm: Added.

(WebCore::setOverrideVP9HardwareDecoderDisabledForTesting):
(WebCore::setOverrideVP9ScreenSizeAndScaleForTesting):
(WebCore::resetOverrideVP9ScreenSizeAndScaleForTesting):
(WebCore::validateVPParameters):

  • platform/ios/PlatformScreenIOS.mm:

(WebCore::collectScreenProperties):

  • platform/mac/PlatformScreenMac.mm:

(WebCore::collectScreenProperties):

  • testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::setSystemHasBattery):
(WebCore::Internals::setSystemHasAC):
(WebCore::Internals::setHardwareVP9DecoderDisabledForTesting):
(WebCore::Internals::setVP9ScreenSizeAndScale):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebCore/PAL:

  • pal/spi/cocoa/IOPSLibSPI.h:

Source/WebKit:

Pass the system AC state to the WebContent process at creation time, and also create
a power state listener so the WebProcess can be updated dynamically.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::registerNotificationObservers):

  • UIProcess/WebProcessPool.cpp:
  • UIProcess/WebProcessPool.h:
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::powerSourceDidChange):

LayoutTests:

  • platform/mac/media/mediacapabilities/vp9-decodingInfo-sw-expected.txt: Added.
  • platform/mac/media/mediacapabilities/vp9-decodingInfo-sw.html: Added.
1:33 PM Changeset in webkit [264475] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Remove (entirely unused) hat switch dpad support in HIDGamepad.
​https://bugs.webkit.org/show_bug.cgi?id=214419

Reviewed by Andy Estes.

Turns out these devices simply don't exist in the wild.

  • platform/gamepad/mac/HIDGamepad.cpp:

(WebCore::HIDGamepad::initElements):
(WebCore::HIDGamepad::initElementsFromArray):
(WebCore::HIDGamepad::valueChanged):
(WebCore::HIDGamepad::maybeAddDPad): Deleted.
(WebCore::fillInButtonValues): Deleted.

  • platform/gamepad/mac/HIDGamepad.h:

(WebCore::HIDGamepadElement::isAxis const):
(WebCore::HIDGamepadElement::isDPad const): Deleted.
(WebCore::HIDGamepadDPad::HIDGamepadDPad): Deleted.
(WebCore::HIDGamepadDPad::normalizedValue): Deleted.

12:48 PM Changeset in webkit [264474] by Jonathan Bedard
  • 4 edits in trunk/Source

[Big Sur] De-duplicate SPI
​https://bugs.webkit.org/show_bug.cgi?id=214415
<rdar://problem/65678060>

Reviewed by Darin Adler.

Source/WebCore/PAL:

  • pal/spi/mac/NSImageSPI.h:

Source/WTF:

  • wtf/PlatformHave.h:
12:42 PM Changeset in webkit [264473] by ysuzuki@apple.com
  • 4 edits
    1 add in trunk

[JSC] Use unvalidatedGet instead of get to access UnlinkedCodeBlock from CodeBlock destructor
​https://bugs.webkit.org/show_bug.cgi?id=214403
<rdar://problem/65527229>

Reviewed by Mark Lam.

JSTests:

  • stress/codeblock-destructor-access-unlinkedcodeblock.js: Added.

(foo):

Source/JavaScriptCore:

WriteBarrier<>::get has a check whether this is not executed when sweeping cells. This is good assertion since
destruction order of cells are not defined in general, so member cell access from a destructor is almost always wrong.
But in CodeBlock case, this is OK because (1) CodeBlock destructor accesses UnlinkedCodeBlock and (2) GC ensures that
CodeBlock gets destroyed before UnlinkedCodeBlock gets destroyed. So this assertion is hit incorrectly.
In this patch, we use WriteBarrier<>::unvalidatedGet in CodeBlock destructor to bypass the above assertion explicitly.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):

  • heap/Heap.cpp:

(JSC::Heap::deleteUnmarkedCompiledCode):

12:04 PM Changeset in webkit [264472] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Regression tests cannot load video over HTTPS with self-signed certificate
​https://bugs.webkit.org/show_bug.cgi?id=155132

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-07-16

10:59 AM Changeset in webkit [264471] by Peng Liu
  • 2 edits in trunk/Source/WebCore

Double tapping to zoom out a fullscreen video will zoom in slightly before zooming out
​https://bugs.webkit.org/show_bug.cgi?id=214400

Reviewed by Jer Noble.

When changing the video gravity of a fullscreen video from AVLayerVideoGravityResizeAspectFill
to AVLayerVideoGravityResizeAspect, the implicit animation of the AVPlayerLayer in the web process
will conflict with the implicit animation of the _videoSublayer in the WebAVPlayerLayer in the
UI process. To avoid the implicit animation in the web process because of the video gravity change,
we have to let the remote hosting layer and the corresponding AVPlayerLayer in the web process
to include the whole video, even when the video gravity is AVLayerVideoGravityResizeAspectFill
and the video will be clipped by the superlayer. When the AVPlayerLayer has the whole video,
changing the video gravity from AVLayerVideoGravityResizeAspectFill to AVLayerVideoGravityResizeAspect
will not generate an implicit animation in the web process.

This patch also adds an instance variable _previousVideoGravity to make sure the transform is
correctly calculated when video gravity is changing.

  • platform/ios/VideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerLayer init]):
(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer resolveBounds]):
(-[WebAVPlayerLayer setVideoGravity:]):

10:43 AM Changeset in webkit [264470] by Andres Gonzalez
  • 3 edits in trunk/Source/WebCore

Crash caused by clients that don't support isolated tree mode calling on the secondary thread.
​https://bugs.webkit.org/show_bug.cgi?id=214409

Reviewed by Chris Fleizach.

In isolated tree mode, isIsolatedTreeEnabled should return true whenever
is called off of the main thread, even if the client doesn’t support
isolated tree mode.
Once the secondary AX thread is initialized due to a call from a client
that supports isolated tree mode like VoiceOver, all calls into the
accessibility API will happen on the secondary thread, including calls
from clients that don't support isolated tree mode. At this point, we
need to handle those clients as if they supported isolated tree mode.
In other words, one client that supports isolated tree mode makes all
other clients to be treated as such.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::isIsolatedTreeEnabled):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper lineTextMarkerRangeForTextMarker:forUnit:]): Minor cleanup, the cache is already
in a local varriable.

10:39 AM Changeset in webkit [264469] by Chris Dumez
  • 11 edits
    12 adds in trunk/LayoutTests/imported/w3c

Resync web-platform-tests/webaudio from upstream
​https://bugs.webkit.org/show_bug.cgi?id=214411

Reviewed by Geoffrey Garen.

Resync web-platform-tests/webaudio from upstream 81de986322a0de90f2.

  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/processing-after-resume.https-expected.txt: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/processing-after-resume.https.html: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct-expected.txt: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct.html: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/w3c-import.log:
  • web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-process-frozen-array.https-expected.txt: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-process-frozen-array.https.html: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-process-zero-outputs.https-expected.txt: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-process-zero-outputs.https.html: Added.
  • web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/processors/array-check-processor.js: Added.

(ArrayFrozenProcessor):
(ArrayFrozenProcessor.prototype.process):
(ArrayTransferProcessor):
(ArrayTransferProcessor.prototype.process):

  • web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/processors/port-processor.js:

(PortProcessor):
(PortProcessor.prototype.handleMessage):
(PortProcessor.prototype.process):

  • web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/processors/w3c-import.log:
  • web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/processors/zero-outputs-check-processor.js: Added.

(IsAllZero):
(ZeroOutputsCheckProcessor):
(ZeroOutputsCheckProcessor.prototype.process):

  • web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/suspended-context-messageport.https.html:
  • web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/w3c-import.log:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan.html:
  • web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering.html:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt: Added.
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform.html: Added.
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/w3c-import.log:
10:25 AM Changeset in webkit [264468] by Russell Epstein
  • 8 edits in branches/safari-610.1.21.0-branch/Source

Versioning.

WebKit-610.1.21.0.7

10:19 AM Changeset in webkit [264467] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

[webkitpy] Remove unused imports from benchmark_runner
​https://bugs.webkit.org/show_bug.cgi?id=214395

Patch by W.D. Xiong <​w_xiong@apple.com> on 2020-07-16
Reviewed by Jonathan Bedard.

Removed a bunch of unused import statements in webkitpy.benchmark_runner

  • Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
  • Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
  • Scripts/webkitpy/benchmark_runner/generic_factory.py:
  • Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
  • Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
  • Scripts/webkitpy/benchmark_runner/run_benchmark.py:
9:59 AM Changeset in webkit [264466] by Russell Epstein
  • 1 copy in tags/Safari-610.1.21.0.6

Tag Safari-610.1.21.0.6.

9:59 AM Changeset in webkit [264465] by Oriol Brufau
  • 6 edits in trunk

[css-grid] Fix line name positions after implicit tracks
​https://bugs.webkit.org/show_bug.cgi?id=214315

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Expect the tests to pass.

  • web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-implicit-track-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-implicit-track-expected.txt:

Source/WebCore:

When serializing grid-template-rows/columns of a grid container, we get
the list of used track sizes, and then insert line names at the
corresponding indices.

Before this patch, these indices were simply taken from the computed
value. However, leading implicit tracks appear in the used value but not
in the computed one. Therefore, we have to offset the indices so that
the line names appear at the proper positions.

This patch is a port of ​https://crrev.com/777829

Tests: imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-implicit-track.html

imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-implicit-track.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::populateGridTrackList):
(WebCore::valueForGridTrackList):

  • rendering/RenderGrid.h:
9:47 AM Changeset in webkit [264464] by Russell Epstein
  • 2 edits in branches/safari-610.1.21.0-branch/Source/WebKit

Cherry-pick r264457. rdar://problem/65638758

[macOS] Add syscall to WebContent sandbox
​https://bugs.webkit.org/show_bug.cgi?id=214394
<rdar://problem/65638758>

Reviewed by Darin Adler.

Add required syscall to WebContent process on macOS.

  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@264457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:38 AM Changeset in webkit [264463] by clopez@igalia.com
  • 3 edits
    13 adds in trunk/LayoutTests

Update WPT tests for css-writing-modes (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=214278

Unreviewed follow-up to r264337.

LayoutTests/imported/w3c:

Add missing binary files from r264337. The files were recorded on the
import log but I messed it up by not passing --binary when generating
the patch.

  • web-platform-tests/css/css-writing-modes/support/blue-200x100.png: Added.
  • web-platform-tests/css/css-writing-modes/support/mn+arabic.png: Added.
  • web-platform-tests/css/css-writing-modes/support/mn+latin.png: Added.
  • web-platform-tests/css/css-writing-modes/support/mn-orientation.png: Added.
  • web-platform-tests/css/css-writing-modes/support/mn_ar_wrap.png: Added.
  • web-platform-tests/css/css-writing-modes/support/mn_en_wrap.png: Added.
  • web-platform-tests/css/css-writing-modes/support/wm-propagation-body-035-exp-res.png: Added.
  • web-platform-tests/css/css-writing-modes/support/world.png: Added.
  • web-platform-tests/css/css-writing-modes/support/zh+arabic.png: Added.
  • web-platform-tests/css/css-writing-modes/support/zh+latin.png: Added.
  • web-platform-tests/css/css-writing-modes/support/zh-orientation.png: Added.
  • web-platform-tests/css/css-writing-modes/support/zh_ar_wrap.png: Added.
  • web-platform-tests/css/css-writing-modes/support/zh_en_wrap.png: Added.

LayoutTests:

9:29 AM Changeset in webkit [264462] by Jonathan Bedard
  • 2 edits in trunk/Source/WebCore/PAL

[Big Sur] Build on Seed 1 (Follow-up Fix)
​https://bugs.webkit.org/show_bug.cgi?id=214396
<rdar://problem/65644762>

Unreviewed follow-up fix.

  • pal/spi/cg/CoreGraphicsSPI.h:
9:28 AM Changeset in webkit [264461] by Andres Gonzalez
  • 2 edits in trunk/Source/WebCore

[webAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange]needs to autorelease the return value from the main thread.
​https://bugs.webkit.org/show_bug.cgi?id=214404
<rdar://problem/65627156>

Reviewed by Chris Fleizach.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
Call retrieveAutoreleasedValueFromMainthread instead of retrieveValueFromMainThread.
The autorelease call inside the lambda doesn't do the job.

9:28 AM Changeset in webkit [264460] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ] REGRESSION(r263485): fast/scrolling/mac/scroll-snapping-in-progress.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=213804

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-07-16

  • platform/mac-wk2/TestExpectations:
9:26 AM Changeset in webkit [264459] by Chris Dumez
  • 7 edits
    2 copies
    11 adds in trunk/LayoutTests/imported/w3c

Resync web-platform-tests/imagebitmap-renderingcontext from upstream
​https://bugs.webkit.org/show_bug.cgi?id=214376

Reviewed by Carlos Alberto Lopez Perez.

Resync web-platform-tests/imagebitmap-renderingcontext from upstream b2a666d93581a71e9338b2.

  • web-platform-tests/imagebitmap-renderingcontext/META.yml: Added.
  • web-platform-tests/imagebitmap-renderingcontext/context-creation-offscreen-expected.txt: Added.
  • web-platform-tests/imagebitmap-renderingcontext/context-creation-offscreen-with-alpha-expected.txt: Added.
  • web-platform-tests/imagebitmap-renderingcontext/context-creation-offscreen-with-alpha.html: Copied from LayoutTests/imported/w3c/web-platform-tests/imagebitmap-renderingcontext/context-creation-with-alpha.html.
  • web-platform-tests/imagebitmap-renderingcontext/context-creation-offscreen.html: Added.
  • web-platform-tests/imagebitmap-renderingcontext/context-creation-with-alpha-expected.txt:
  • web-platform-tests/imagebitmap-renderingcontext/context-creation-with-alpha.html:
  • web-platform-tests/imagebitmap-renderingcontext/context-preserves-canvas.html:
  • web-platform-tests/imagebitmap-renderingcontext/toBlob-origin-clean-offscreen.sub-expected.txt: Added.
  • web-platform-tests/imagebitmap-renderingcontext/toBlob-origin-clean-offscreen.sub.html: Added.
  • web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-ToBlob-offscreen-expected.txt: Added.
  • web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-ToBlob-offscreen.html: Added.
  • web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-TransferToImageBitmap-offscreen-expected.txt: Added.
  • web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-TransferToImageBitmap-offscreen.html: Added.
  • web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-null-offscreen-expected.txt: Added.
  • web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-null-offscreen.html: Copied from LayoutTests/imported/w3c/web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-null.html.
  • web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-null.html:
  • web-platform-tests/imagebitmap-renderingcontext/transferFromImageBitmap-detached.html:
  • web-platform-tests/imagebitmap-renderingcontext/w3c-import.log:
9:15 AM Changeset in webkit [264458] by Chris Dumez
  • 33 edits
    2 copies
    4 moves
    75 adds in trunk/LayoutTests

Resync web-platform-tests/resource-timing from upstream
​https://bugs.webkit.org/show_bug.cgi?id=214377

Reviewed by Carlos Alberto Lopez Perez.

LayoutTests/imported/w3c:

Resync web-platform-tests/resource-timing from upstream b2a666d93581a71e9338b2.

  • web-platform-tests/resource-timing/*: Updated.

LayoutTests:

  • TestExpectations:
  • platform/mac-wk1/imported/w3c/web-platform-tests/resource-timing/crossorigin-sandwich-no-TAO.sub-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/resource-timing/nextHopProtocol-tao-protected.https-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/resource-timing/redirects.sub-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/resource-timing/resource-reload-TAO.sub-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/resource-timing/workerStart-tao-protected.https-expected.txt: Added.
  • tests-options.json:
9:11 AM Changeset in webkit [264457] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[macOS] Add syscall to WebContent sandbox
​https://bugs.webkit.org/show_bug.cgi?id=214394
<rdar://problem/65638758>

Reviewed by Darin Adler.

Add required syscall to WebContent process on macOS.

  • WebProcess/com.apple.WebProcess.sb.in:
9:06 AM Changeset in webkit [264456] by clopez@igalia.com
  • 217 edits
    51 adds in trunk/LayoutTests

Update WPT css/support directory
​https://bugs.webkit.org/show_bug.cgi?id=214350

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

This updates the WPT import of css/support to e3698c7bb3.

  • web-platform-tests/css/css-animations/parsing/animation-computed-expected.txt:
  • web-platform-tests/css/css-animations/parsing/animation-delay-computed-expected.txt:
  • web-platform-tests/css/css-animations/parsing/animation-direction-computed-expected.txt:
  • web-platform-tests/css/css-animations/parsing/animation-duration-computed-expected.txt:
  • web-platform-tests/css/css-animations/parsing/animation-fill-mode-computed-expected.txt:
  • web-platform-tests/css/css-animations/parsing/animation-iteration-count-computed-expected.txt:
  • web-platform-tests/css/css-animations/parsing/animation-name-computed-expected.txt:
  • web-platform-tests/css/css-animations/parsing/animation-play-state-computed-expected.txt:
  • web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-attachment-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-clip-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-color-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-origin-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-position-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-position-x-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-position-y-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-repeat-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/background-size-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/border-color-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/border-image-outset-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/border-image-repeat-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/border-image-slice-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/border-image-source-computed.sub-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/border-image-width-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/border-radius-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/border-style-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/border-width-computed-expected.txt:
  • web-platform-tests/css/css-backgrounds/parsing/box-shadow-computed-expected.txt:
  • web-platform-tests/css/css-box/parsing/clear-computed-expected.txt:
  • web-platform-tests/css/css-box/parsing/float-computed-expected.txt:
  • web-platform-tests/css/css-box/parsing/margin-computed-expected.txt:
  • web-platform-tests/css/css-box/parsing/padding-computed-expected.txt:
  • web-platform-tests/css/css-box/parsing/visibility-computed-expected.txt:
  • web-platform-tests/css/css-color/parsing/color-computed-expected.txt:
  • web-platform-tests/css/css-color/parsing/opacity-computed-expected.txt:
  • web-platform-tests/css/css-display/parsing/display-computed-expected.txt:
  • web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt:
  • web-platform-tests/css/css-flexbox/parsing/flex-basis-computed-expected.txt:
  • web-platform-tests/css/css-flexbox/parsing/flex-computed-expected.txt:
  • web-platform-tests/css/css-flexbox/parsing/flex-direction-computed-expected.txt:
  • web-platform-tests/css/css-flexbox/parsing/flex-flow-computed-expected.txt:
  • web-platform-tests/css/css-flexbox/parsing/flex-grow-computed-expected.txt:
  • web-platform-tests/css/css-flexbox/parsing/flex-shrink-computed-expected.txt:
  • web-platform-tests/css/css-flexbox/parsing/flex-wrap-computed-expected.txt:
  • web-platform-tests/css/css-flexbox/parsing/order-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-family-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-feature-settings-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-kerning-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-language-override-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-optical-sizing-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-size-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-stretch-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-style-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-synthesis-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-variant-caps-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-variant-east-asian-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-variant-ligatures-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-variant-numeric-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-variant-position-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-variation-settings-computed-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-weight-computed-expected.txt:
  • web-platform-tests/css/css-fonts/variations/at-font-face-font-matching-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-items/grid-item-dynamic-min-contribution-001-expected.txt:
  • web-platform-tests/css/css-grid/grid-model/grid-button-001-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-area-computed-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-auto-columns-computed-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-auto-flow-computed-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-auto-rows-computed-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-areas-computed-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-nogrid-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-withcontent-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-repeat-auto-computed-withcontent-001-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-repeat-auto-computed-withcontent-002-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-nogrid-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-withcontent-expected.txt:
  • web-platform-tests/css/css-images/parsing/image-orientation-computed-expected.txt:
  • web-platform-tests/css/css-images/parsing/image-rendering-computed-expected.txt:
  • web-platform-tests/css/css-images/parsing/object-fit-computed-expected.txt:
  • web-platform-tests/css/css-images/parsing/object-position-computed-expected.txt:
  • web-platform-tests/css/css-inline/parsing/line-height-computed-expected.txt:
  • web-platform-tests/css/css-lists/parsing/list-style-type-computed-expected.txt:
  • web-platform-tests/css/css-logical/animation-003.tentative-expected.txt:
  • web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt:
  • web-platform-tests/css/css-multicol/parsing/column-count-computed-expected.txt:
  • web-platform-tests/css/css-multicol/parsing/column-fill-computed-expected.txt:
  • web-platform-tests/css/css-multicol/parsing/column-rule-color-computed-expected.txt:
  • web-platform-tests/css/css-multicol/parsing/column-rule-computed-expected.txt:
  • web-platform-tests/css/css-multicol/parsing/column-rule-style-computed-expected.txt:
  • web-platform-tests/css/css-multicol/parsing/column-rule-width-computed-expected.txt:
  • web-platform-tests/css/css-multicol/parsing/column-span-computed-expected.txt:
  • web-platform-tests/css/css-multicol/parsing/column-width-computed-expected.txt:
  • web-platform-tests/css/css-overflow/parsing/overflow-computed-expected.txt:
  • web-platform-tests/css/css-overflow/parsing/text-overflow-computed-expected.txt:
  • web-platform-tests/css/css-position/parsing/bottom-computed-expected.txt:
  • web-platform-tests/css/css-position/parsing/inset-after-computed-expected.txt:
  • web-platform-tests/css/css-position/parsing/inset-before-computed-expected.txt:
  • web-platform-tests/css/css-position/parsing/inset-end-computed-expected.txt:
  • web-platform-tests/css/css-position/parsing/inset-start-computed-expected.txt:
  • web-platform-tests/css/css-position/parsing/left-computed-expected.txt:
  • web-platform-tests/css/css-position/parsing/position-computed-expected.txt:
  • web-platform-tests/css/css-position/parsing/right-computed-expected.txt:
  • web-platform-tests/css/css-position/parsing/top-computed-expected.txt:
  • web-platform-tests/css/css-position/parsing/z-index-computed-expected.txt:
  • web-platform-tests/css/css-pseudo/first-letter-property-whitelist-expected.txt:
  • web-platform-tests/css/css-scoping/keyframes-001-expected.txt:
  • web-platform-tests/css/css-shapes/parsing/shape-image-threshold-computed-expected.txt:
  • web-platform-tests/css/css-shapes/parsing/shape-margin-computed-expected.txt:
  • web-platform-tests/css/css-shapes/parsing/shape-outside-computed-expected.txt:
  • web-platform-tests/css/css-sizing/aspect-ratio-affects-container-width-when-height-changes-expected.txt:
  • web-platform-tests/css/css-sizing/parsing/box-sizing-computed-expected.txt:
  • web-platform-tests/css/css-sizing/parsing/max-height-computed-expected.txt:
  • web-platform-tests/css/css-sizing/parsing/max-width-computed-expected.txt:
  • web-platform-tests/css/css-sizing/parsing/min-height-computed-expected.txt:
  • web-platform-tests/css/css-sizing/parsing/min-width-computed-expected.txt:
  • web-platform-tests/css/css-sizing/percentage-height-replaced-content-in-auto-cb-expected.txt:
  • web-platform-tests/css/css-text-decor/parsing/text-decoration-color-computed-expected.txt:
  • web-platform-tests/css/css-text-decor/parsing/text-decoration-computed-expected.txt:
  • web-platform-tests/css/css-text-decor/parsing/text-decoration-line-computed-expected.txt:
  • web-platform-tests/css/css-text-decor/parsing/text-decoration-skip-ink-computed-expected.txt:
  • web-platform-tests/css/css-text-decor/parsing/text-decoration-style-computed-expected.txt:
  • web-platform-tests/css/css-text-decor/parsing/text-shadow-computed-expected.txt:
  • web-platform-tests/css/css-text-decor/parsing/text-underline-position-computed-expected.txt:
  • web-platform-tests/css/css-text-decor/text-decoration-thickness-computed-expected.txt:
  • web-platform-tests/css/css-text-decor/text-underline-offset-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/hyphens-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/letter-spacing-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/line-break-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/overflow-wrap-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/tab-size-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/text-align-last-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/text-indent-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/text-justify-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/text-transform-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/white-space-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/word-boundary-detection-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/word-boundary-expansion-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/word-break-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/word-spacing-computed-expected.txt:
  • web-platform-tests/css/css-text/parsing/word-wrap-computed-expected.txt:
  • web-platform-tests/css/css-transitions/parsing/transition-computed-expected.txt:
  • web-platform-tests/css/css-transitions/parsing/transition-delay-computed-expected.txt:
  • web-platform-tests/css/css-transitions/parsing/transition-duration-computed-expected.txt:
  • web-platform-tests/css/css-transitions/parsing/transition-property-computed-expected.txt:
  • web-platform-tests/css/css-transitions/parsing/transition-timing-function-computed-expected.txt:
  • web-platform-tests/css/css-ui/parsing/box-sizing-computed-expected.txt:
  • web-platform-tests/css/css-ui/parsing/caret-color-computed-expected.txt:
  • web-platform-tests/css/css-ui/parsing/cursor-computed-expected.txt:
  • web-platform-tests/css/css-ui/parsing/outline-color-computed-expected.txt:
  • web-platform-tests/css/css-ui/parsing/outline-offset-computed-expected.txt:
  • web-platform-tests/css/css-ui/parsing/outline-style-computed-expected.txt:
  • web-platform-tests/css/css-ui/parsing/outline-width-computed-expected.txt:
  • web-platform-tests/css/css-ui/parsing/resize-computed-expected.txt:
  • web-platform-tests/css/css-ui/parsing/text-overflow-computed-expected.txt:
  • web-platform-tests/css/css-ui/parsing/user-select-computed-expected.txt:
  • web-platform-tests/css/css-values/clamp-length-computed-expected.txt:
  • web-platform-tests/css/css-values/minmax-angle-computed-expected.txt:
  • web-platform-tests/css/css-values/minmax-integer-computed-expected.txt:
  • web-platform-tests/css/css-values/minmax-length-computed-expected.txt:
  • web-platform-tests/css/css-values/minmax-length-percent-computed-expected.txt:
  • web-platform-tests/css/css-values/minmax-number-computed-expected.txt:
  • web-platform-tests/css/css-values/minmax-percentage-computed-expected.txt:
  • web-platform-tests/css/css-values/minmax-time-computed-expected.txt:
  • web-platform-tests/css/css-writing-modes/parsing/direction-computed-expected.txt:
  • web-platform-tests/css/css-writing-modes/parsing/text-combine-upright-computed-expected.txt:
  • web-platform-tests/css/css-writing-modes/parsing/text-orientation-computed-expected.txt:
  • web-platform-tests/css/css-writing-modes/parsing/unicode-bidi-computed-expected.txt:
  • web-platform-tests/css/css-writing-modes/parsing/writing-mode-computed-expected.txt:
  • web-platform-tests/css/cssom-view/parsing/scroll-behavior-computed-expected.txt:
  • web-platform-tests/css/support/META.yml:
  • web-platform-tests/css/support/computed-testcommon.js:

(test_computed_value):

  • web-platform-tests/css/support/height-keyword-classes.css: Added.

(.min-content):
(.max-content):
(.fit-content):
(.max-height-min-content):
(.max-height-max-content):
(.max-height-fit-content):
(.min-height-min-content):
(.min-height-max-content):
(.min-height-fit-content):

  • web-platform-tests/css/support/numeric-testcommon.js: Added.

(test_math_used):

  • web-platform-tests/css/support/parsing-testcommon.js:
  • web-platform-tests/css/support/serialize-testcommon.js: Added.

(test_specified_serialization):

  • web-platform-tests/css/support/w3c-import.log:
  • web-platform-tests/css/support/width-keyword-classes.css:

(.min-content):
(.max-content):
(.fit-content):
(.max-width-min-content):
(.max-width-max-content):
(.max-width-fit-content):
(.min-width-min-content):
(.min-width-max-content):
(.min-width-fit-content):

  • web-platform-tests/pointerevents/parsing/touch-action-computed-expected.txt:
  • web-platform-tests/svg/geometry/parsing/cx-computed-expected.txt:
  • web-platform-tests/svg/geometry/parsing/cy-computed-expected.txt:
  • web-platform-tests/svg/geometry/parsing/r-computed-expected.txt:
  • web-platform-tests/svg/geometry/parsing/rx-computed-expected.txt:
  • web-platform-tests/svg/geometry/parsing/ry-computed-expected.txt:
  • web-platform-tests/svg/geometry/parsing/sizing-properties-computed-expected.txt:
  • web-platform-tests/svg/geometry/parsing/x-computed-expected.txt:
  • web-platform-tests/svg/geometry/parsing/y-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/color-interpolation-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/fill-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/fill-opacity-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/fill-rule-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/image-rendering-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/marker-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/marker-end-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/marker-mid-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/marker-start-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/paint-order-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/shape-rendering-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/stroke-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/stroke-dasharray-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/stroke-dashoffset-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/stroke-linecap-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/stroke-linejoin-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/stroke-miterlimit-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/stroke-opacity-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/stroke-width-computed-expected.txt:
  • web-platform-tests/svg/painting/parsing/text-rendering-computed-expected.txt:
  • web-platform-tests/svg/pservers/parsing/stop-color-computed-expected.txt:
  • web-platform-tests/svg/pservers/parsing/stop-opacity-computed-expected.txt:
  • web-platform-tests/svg/text/parsing/text-anchor-computed-expected.txt:

LayoutTests:

Update expectations.

  • platform/gtk/imported/w3c/web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-template-columns-computed-withcontent-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-template-computed-nogrid-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom.tentative-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-values/minmax-angle-computed-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-values/minmax-length-computed-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-values/minmax-length-percent-computed-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/interact/parsing/pointer-events-computed-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-width-computed-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/css-values/minmax-length-computed-actual.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/css-values/minmax-length-percent-computed-actual.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-dashoffset-computed-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linecap-computed-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linejoin-computed-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-dashoffset-computed-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linecap-computed-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linejoin-computed-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-miterlimit-computed-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-opacity-computed-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-grid/masonry.tentative/masonry-grid-template-columns-computed-withcontent-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-template-computed-nogrid-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom.tentative-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-values/minmax-angle-computed-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-values/minmax-length-computed-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-values/minmax-length-percent-computed-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/interact/parsing/pointer-events-computed-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.txt:
9:06 AM Changeset in webkit [264455] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Improve handling of invalid ChangeLog by webkit-patch
​https://bugs.webkit.org/show_bug.cgi?id=214365

Reviewed by Jonathan Bedard.

  • Scripts/webkitpy/tool/steps/preparechangelog.py:

(PrepareChangeLog._ensure_bug_url):

8:32 AM Changeset in webkit [264454] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix logging added in r264414 that was incorrectly marked as "error" logging.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

6:30 AM Changeset in webkit [264453] by Jonathan Bedard
  • 5 edits in trunk/Source

[Big Sur] Build on Seed 1
​https://bugs.webkit.org/show_bug.cgi?id=214396
<rdar://problem/65644762>

Reviewed by Tim Horton.

Source/WebCore/PAL:

  • pal/spi/cg/CoreGraphicsSPI.h: Add CoreGraphics SPI for PDFKIT_PLUGIN.
  • pal/spi/mac/NSImageSPI.h:

Source/WTF:

  • wtf/PlatformHave.h: Add HAVE(LARGE_CONTROL_SIZE).
6:09 AM Changeset in webkit [264452] by Jonathan Bedard
  • 2 edits in trunk/Tools

[webkitcorepy] Correct url in setup.py
​https://bugs.webkit.org/show_bug.cgi?id=214399

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitcorepy/setup.py:
2:23 AM Changeset in webkit [264451] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run-minibrowser --debug runs the release build on macOS
​https://bugs.webkit.org/show_bug.cgi?id=214397

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-07-16
Reviewed by Žan Doberšek.

Pass-through port configuration and platform options to old-run-minibrowser. GTK and WPE
ports are not affected by this because they build the path to MiniBrowser for the given
configuration already.

Also set ignore_errors to True when invoking the Executive, to prevent useless and confusing
tracebacks raised when old-run-minibrowser exits with a positive exit code, eg, when it's
being called with the --help argument.

  • Scripts/webkitpy/port/base.py:

(Port.run_minibrowser):

2:11 AM Changeset in webkit [264450] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

ASAN builds of WebKit should not freeze when an EXC_RESOURCE is delivered
​https://bugs.webkit.org/show_bug.cgi?id=214346

Patch by Tuomas Karkkainen <​tuomas.webkit@apple.com> on 2020-07-16
Reviewed by Mark Lam.

When the WebContent process allocates 1000 MB of memory or starts 32
threads, it receives an EXC_RESOURCE. This requires iterating all the
mappings of the process. For the case of a process instrumented with
AddressSanitizer, the mappings total 20 terabytes, and cause the
process to "freeze" for several minutes.

Setting the sysctl debug.toggle_address_reuse to 1 causes the
EXC_RESOURCE mechanism to skip iteration of all the mappings.

With this patch, setting the environment variable
DISABLE_FREEZING_ON_EXC_RESOURCE will set the sysctl mentioned above
for WebContent and Networking processes.

  • Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
1:21 AM Changeset in webkit [264449] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

REGRESSION(r264280) [GTK][WPE] fast/gradients/conic-gradient-alpha.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=214259

Reviewed by Darin Adler.

  • platform/graphics/ColorBlending.cpp:

(WebCore::blendWithoutPremultiply): Use 'to' instead of 'from' when converting to SRGBA.

  • platform/graphics/cairo/GradientCairo.cpp:

(WebCore::createConic): Use blendWithoutPremultiply() instead of blend() for the color stops interpolation.

1:19 AM Changeset in webkit [264448] by Carlos Garcia Campos
  • 6 edits in trunk

REGRESSION(r264272) [GTK][WPE] css3/color/composited-solid-backgrounds.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=214260

Reviewed by Darin Adler.

Source/WebCore:

The problem is that clampToComponentFloat is returning a uint8_t instead of a float, so we always end up
returning 0.

  • platform/graphics/ColorUtilities.h:

(WebCore::clampToComponentFloat):

Tools:

Add a test case.

  • TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:

(TestWebKitAPI::TEST):

LayoutTests:

Remove expectations of css3/color/composited-solid-backgrounds.html.

  • platform/glib/TestExpectations:

Jul 15, 2020:

11:32 PM Changeset in webkit [264447] by ysuzuki@apple.com
  • 4 edits
    2 adds in trunk

Should clear exception after microtask draining
​https://bugs.webkit.org/show_bug.cgi?id=214391
<rdar://problem/65536227>

Reviewed by Mark Lam.

Source/WebCore:

Test: js/dom/microtask-drain-should-clear-exceptions.html

Since microtask draining involves JS calls, potentially it can cause exception.
We should clear exceptions after microtask draining since we do not handle it and suppress exception-check validation.
And we also should not create ThrowScope in canAccessDocument when parameter says it never throws an error.
Both cases are handled in the attached test.

  • bindings/js/JSDOMBindingSecurity.cpp:

(WebCore::canAccessDocument):

  • bindings/js/JSExecState.h:

(WebCore::JSExecState::~JSExecState):

LayoutTests:

  • js/dom/microtask-drain-should-clear-exceptions-expected.txt: Added.
  • js/dom/microtask-drain-should-clear-exceptions.html: Added.
9:05 PM Changeset in webkit [264446] by Ryan Haddad
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed test gardening, add iOS baseliens for tests re-synced in r264427 and r264432.

  • platform/ios/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt: Added.
  • platform/ios/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt: Added.
8:55 PM Changeset in webkit [264445] by Simon Fraser
  • 3 edits in trunk/LayoutTests

[ iOS WK2 Release ] fast/scrolling/ios/non-invertible-transformed-scroller-ancestor.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=214133

Unreviewed test fixing.

Test needs to wait for the visible content rect update to trigger scroll updates in the web process.

  • fast/scrolling/ios/non-invertible-transformed-scroller-ancestor.html:
  • platform/ios-wk2/TestExpectations:
8:13 PM Changeset in webkit [264444] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Speculative fix for flaky fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html.
​https://bugs.webkit.org/show_bug.cgi?id=214386

Unreviewed gardening.

  • fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js:
7:21 PM Changeset in webkit [264443] by dino@apple.com
  • 2 edits in trunk/Tools/MiniBrowser/mac

Unreviewed fix for Catalina.

Use a #if rather than @available so we don't have to
forward declare the Big Sur things.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController windowDidLoad]):

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController updateTitle:]):

7:16 PM Changeset in webkit [264442] by Ryan Haddad
  • 1 edit
    1 copy
    2 adds
    1 delete in trunk/LayoutTests

Unreviewed test gardening, move the Mojave baseline to the correct folder since I really messed up in r264373.

  • platform/mac-mojave/imported/w3c/web-platform-tests/css/css-fonts/generic-family-keywords-001-expected.txt: Renamed from LayoutTests/platform/mac-mojave/imported/w3c/web-platform-tests/css-fonts/generic-family-keywords-001-expected.txt.
6:39 PM Changeset in webkit [264441] by dino@apple.com
  • 4 edits in trunk/Tools

MiniBrowser toolbar is ugly with default macOS Big Sur style
​https://bugs.webkit.org/show_bug.cgi?id=214390
rdar://65637420

Reviewed by Tim Horton.

Rather than using the Big Sur default "unified" style, explicitly
ask for the "expanded" style.

While here, use symbols for the toolbar buttons, and move the
progress indicator to the end of the toolbar. I hope this
change to the xib file won't break the Catalina version.

  • MiniBrowser/mac/BrowserWindow.xib:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController windowDidLoad]):

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController updateTitle:]):

5:55 PM Changeset in webkit [264440] by clopez@igalia.com
  • 4 edits
    37 copies
    70 moves
    91 adds in trunk/LayoutTests

[GTK][WPE] Gardening after r264424 and r264427

Unreviewed gardening.

Merge common expectations for svg/ when they are the same.

LayoutTests/imported/w3c:

  • web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt.
  • web-platform-tests/svg/geometry/reftests/circle-001-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt.
  • web-platform-tests/svg/geometry/reftests/circle-002-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt.
  • web-platform-tests/svg/geometry/reftests/circle-003-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt.
  • web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt.
  • web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt.
  • web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt.
  • web-platform-tests/svg/geometry/reftests/rect-001-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt.
  • web-platform-tests/svg/geometry/reftests/rect-002-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt.
  • web-platform-tests/svg/geometry/reftests/rect-003-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt.
  • web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt.
  • web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt.
  • web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt.
  • web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt.
  • web-platform-tests/svg/painting/marker-009-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt.
  • web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt.
  • web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt.
  • web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt.
  • web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt.
  • web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt.
  • web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt.
  • web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt.
  • web-platform-tests/svg/painting/reftests/mask-print-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt.
  • web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt.
  • web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt.
  • web-platform-tests/svg/path/distance/pathlength-rect-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt.
  • web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt.
  • web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt.
  • web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt.
  • web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt.
  • web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt.
  • web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt.
  • web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt.
  • web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt.
  • web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt.

LayoutTests:

  • platform/gtk/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/animations/seeking-events-4-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/use-descendant-combinator-001-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/use-descendant-combinator-002-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/use-hidden-attr-change-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/use-nested-symbol-001-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/use-symbol-rendered-001-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/marker-orient-001-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-002-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-021-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-022-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-023-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/shapes/scripted/stroke-dashes-hit-at-high-scale-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/text/reftests/tspan-opacity-mixed-direction-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.isPointInStroke-02-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-keep-all-001-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.pattern.paint.repeat.coord1-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/baseline-alignment-and-overflow.tentative-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/flex-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-list-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/wrap-enumerated-ascii-case-insensitive-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_getCoalescedEvents_when_pointerlocked-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_movementxy_with_pointerlock-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_after_pointercapture-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_in_pointerlock-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/resize-observer/svg-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/use-descendant-combinator-001-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/use-descendant-combinator-002-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/use-hidden-attr-change-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/use-nested-symbol-001-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/use-symbol-rendered-001-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/marker-orient-001-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-002-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-021-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-022-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-023-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-expected.txt: Copied from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/shapes/scripted/stroke-dashes-hit-at-high-scale-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt: Renamed from LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/text/reftests/tspan-opacity-mixed-direction-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.isPointInStroke-02-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/touch-events/historical-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/touch-events/idlharness.window-expected.txt: Added.
5:36 PM Changeset in webkit [264439] by Devin Rousso
  • 2 edits in trunk/Source/WebCore

Unreviewed followup, use objectReplacementCharacter instead of 0xFFFC
<​https://webkit.org/b/214331> <rdar://problem/64779558>

  • editing/TextIterator.cpp:

(WebCore::TextIterator::representNodeOffsetZero):

5:35 PM Changeset in webkit [264438] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

[macOS WK1 EWS] compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=214388

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations: Mark test as flaky to speed up EWS and reduce false positives.
5:26 PM Changeset in webkit [264437] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

[macOS iOS] imported/w3c/web-platform-tests/svg/animations/seeking-events-4.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=214387

Unreviewed test gardening.

5:13 PM Changeset in webkit [264436] by Ryan Haddad
  • 1 edit
    1 copy
    1 delete in trunk/LayoutTests

Unreviewed test gardening, move a test baseline to the correct subdirectory.

  • platform/mac/imported/w3c/web-platform-tests/css/css-fonts/generic-family-keywords-001-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/css-fonts/generic-family-keywords-001-expected.txt.
4:53 PM Changeset in webkit [264435] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[ iOS ] canvas/philip/tests/2d.pattern.animated.gif.html is passing and needs expectations removed
​https://bugs.webkit.org/show_bug.cgi?id=214384

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-07-15

  • platform/ios/TestExpectations:
4:29 PM Changeset in webkit [264434] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[ iOS Release ] imported/w3c/web-platform-tests/websockets/remove-own-iframe-during-onerror.window.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=214382

Unreviewed test gardening.

Patch by Hector Lopez <Hector Lopez> on 2020-07-15

  • platform/ios-wk2/TestExpectations:
3:58 PM Changeset in webkit [264433] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[ iOS ] http/tests/security/stylesheet-href-redirect.html is flaky timing out
​https://bugs.webkit.org/show_bug.cgi?id=209352

Unreviewed test gardening

Patch by Hector Lopez <Hector Lopez> on 2020-07-15

  • platform/ios-wk2/TestExpectations:
3:51 PM Changeset in webkit [264432] by Chris Dumez
  • 16 edits
    7 adds in trunk/LayoutTests

Resync web-platform-tests/resize-observer from upstream
​https://bugs.webkit.org/show_bug.cgi?id=214375

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Resync web-platform-tests/resize-observer from upstream b2a666d93581a71e9338b2.

  • resources/import-expectations.json:
  • web-platform-tests/resize-observer/META.yml:
  • web-platform-tests/resize-observer/change-layout-in-error-expected.txt: Added.
  • web-platform-tests/resize-observer/change-layout-in-error.html: Added.
  • web-platform-tests/resize-observer/devicepixel-expected.html: Added.
  • web-platform-tests/resize-observer/devicepixel.html: Added.
  • web-platform-tests/resize-observer/eventloop.html:
  • web-platform-tests/resize-observer/idlharness.window-expected.txt:
  • web-platform-tests/resize-observer/idlharness.window.html:
  • web-platform-tests/resize-observer/idlharness.window.js:
  • web-platform-tests/resize-observer/observe-expected.txt:
  • web-platform-tests/resize-observer/observe.html:
  • web-platform-tests/resize-observer/resources/image.png: Added.
  • web-platform-tests/resize-observer/resources/resizeTestHelper.js:

(ResizeTestHelper.prototype._handleNotification):
(ResizeTestHelper.prototype._handleTimeout):
(ResizeTestHelper.prototype.start):
(ResizeTestHelper.prototype.get test):
(createAndAppendElement):

  • web-platform-tests/resize-observer/resources/w3c-import.log:
  • web-platform-tests/resize-observer/svg-expected.txt:
  • web-platform-tests/resize-observer/svg.html:
  • web-platform-tests/resize-observer/w3c-import.log:

LayoutTests:

3:28 PM Changeset in webkit [264431] by Chris Dumez
  • 1 edit
    2 deletes in trunk/LayoutTests/imported/w3c

Unreviewed, drop WPT test which no longer exists upstream and should have been dropped during resync in r263928.

  • web-platform-tests/mediacapture-record/MediaRecorder-constructor-expected.txt: Removed.
  • web-platform-tests/mediacapture-record/MediaRecorder-constructor.html: Removed.
3:25 PM Changeset in webkit [264430] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[ macOS wk1 ] http/tests/media/reload-after-dialog.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=212828

Unreviewed test gardening

Patch by Hector Lopez <Hector Lopez> on 2020-07-15

  • platform/mac-wk1/TestExpectations:
3:24 PM Changeset in webkit [264429] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed, revert part of r264385.

The change set r264385 speculatively added two messages to the mach-kernel-endpoint filter on iOS.
These messages are not needed, and should be removed.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
3:14 PM Changeset in webkit [264428] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Add some missing boilerplate to help fix build on macOS Big Sur
​https://bugs.webkit.org/show_bug.cgi?id=214338

Patch by Saagar Jha <​saagar@saagarjha.com> on 2020-07-15
Reviewed by Darin Adler.

Source/WebCore/PAL:

  • pal/spi/mac/NSAppearanceSPI.h: Add -[NSAppearance _usesMetricsAppearance] to the SPI header.
  • pal/spi/mac/NSImageSPI.h: Add +[NSImage _imageWithSystemSymbolName:] to the SPI header.

Source/WTF:

  • wtf/PlatformHave.h: Add HAVE_LARGE_CONTROL_SIZE and enable it on Big Sur.
2:59 PM Changeset in webkit [264427] by Chris Dumez
  • 9 edits in trunk/LayoutTests/imported/w3c

Resync web-platform-tests/mediacapture-streams from upstream
​https://bugs.webkit.org/show_bug.cgi?id=214374

Reviewed by Geoffrey Garen.

Resync web-platform-tests/mediacapture-streams from upstream b2a666d93581a71e9338b2.

  • web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices.https-expected.txt:
  • web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices.https.html:
  • web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html:
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-getSettings.https-expected.txt:
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-getSettings.https.html:
  • web-platform-tests/mediacapture-streams/MediaStreamTrackEvent-constructor.https.html:
  • web-platform-tests/mediacapture-streams/historical.https.html:
  • web-platform-tests/mediacapture-streams/idlharness.https.window.js:
2:48 PM Changeset in webkit [264426] by Simon Fraser
  • 2 edits
    1 add in trunk/LayoutTests

[ iOS ] fast/scrolling/ios/programm atic-scroll-while-zoomed.ht ml and fast/scrolling/ios/autoscro ll-input-when-very-zoomed.h tml are failing on iPad
​https://bugs.webkit.org/show_bug.cgi?id=214358
<rdar://problem/65609413>

Unreviewed test gardening. These tests need iPad results.

  • platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt:
  • platform/ipad/fast/scrolling/ios/programmatic-scroll-while-zoomed-expected.txt: Added.
2:39 PM Changeset in webkit [264425] by Jonathan Bedard
  • 29 edits
    1 copy
    1 move
    9 adds in trunk/Tools

[webkitcorepy] Spin off general webkitpy tools into a pip module
​https://bugs.webkit.org/show_bug.cgi?id=214309

Reviewed by Dewei Zhu.

  • Scripts/libraries: Added.
  • Scripts/libraries/webkitcorepy: Added.
  • Scripts/libraries/webkitcorepy/MANIFEST.in: Added.
  • Scripts/libraries/webkitcorepy/README.md: Added.
  • Scripts/libraries/webkitcorepy/setup.py: Added.

(readme):

  • Scripts/libraries/webkitcorepy/webkitcorepy: Added.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Added.
  • Scripts/libraries/webkitcorepy/webkitcorepy/tests: Added.
  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/init.py: Added.
  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/version_unittest.py: Moved from

webkitpy/common/version_unittest.py.

  • Scripts/libraries/webkitcorepy/webkitcorepy/version.py: Added.

(Version): Moved from webkitpy/common/version.py.

  • Scripts/webkitpy/init.py: Include webkitcorepy on import path.
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Use Version from webkitcorepy.
  • Scripts/webkitpy/common/checkout/scm/svn.py: Ditto.
  • Scripts/webkitpy/common/system/platforminfo.py: Ditto.
  • Scripts/webkitpy/common/system/platforminfo_mock.py: Ditto.
  • Scripts/webkitpy/common/version.py: Ditto.

(Version): Moved to webkitcorepy.

  • Scripts/webkitpy/common/version_name_map.py: Use Version from webkitcorepy.
  • Scripts/webkitpy/common/version_name_map_unittest.py: Ditto.
  • Scripts/webkitpy/common/version_unittest.py: Moved to webkitcorepy.
  • Scripts/webkitpy/port/factory_unittest.py: Use Version from webkitcorepy.
  • Scripts/webkitpy/port/ios.py: Use Version from webkitcorepy, remove unneeded imports.
  • Scripts/webkitpy/port/ios_device.py: se Version from webkitcorepy.
  • Scripts/webkitpy/port/ios_device_unittest.py: Ditto.
  • Scripts/webkitpy/port/ios_simulator.py: Ditto.
  • Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
  • Scripts/webkitpy/port/ios_testcase.py: Ditto.
  • Scripts/webkitpy/port/mac.py: Ditto.
  • Scripts/webkitpy/port/mac_unittest.py: Ditto.
  • Scripts/webkitpy/port/watch.py: Use Version from webkitcorepy, remove unneeded imports.
  • Scripts/webkitpy/port/watch_device.py: Use Version from webkitcorepy.
  • Scripts/webkitpy/port/watch_simulator.py: Ditto.
  • Scripts/webkitpy/port/watch_simulator_unittest.py: Ditto.
  • Scripts/webkitpy/port/watch_testcase.py: Ditto.
  • Scripts/webkitpy/port/win.py: Use Version from webkitcorepy, remove unneeded imports.
  • Scripts/webkitpy/port/win_unittest.py: Use Version from webkitcorepy.
  • Scripts/webkitpy/test/main.py:

(main): Include webkitcorepy tests.

  • Scripts/webkitpy/xcode/device_type_unittest.py: Use Version from webkitcorepy.
  • Scripts/webkitpy/xcode/simulated_device.py: Ditto.
  • Scripts/webkitpy/xcode/simulated_device_unittest.py: Use Version from webkitcorepy, fix style for imports.
2:35 PM Changeset in webkit [264424] by Chris Dumez
  • 110 edits
    8 copies
    8 moves
    329 adds
    12 deletes in trunk/LayoutTests

Resync web-platform-tests/svg from upstream
​https://bugs.webkit.org/show_bug.cgi?id=214323

Reviewed by Alex Christensen.

Resync web-platform-tests/svg from upstream b2a666d93581a71e9338b2.

LayoutTests/imported/w3c:

  • resources/resource-files.json:
  • web-platform-tests/svg/*: Updated.

LayoutTests:

  • platform/mac/imported/w3c/web-platform-tests/svg/*: Updated.
2:33 PM Changeset in webkit [264423] by Darin Adler
  • 8 edits in trunk/Source

Remove a few more uses of the terms black/white list
​https://bugs.webkit.org/show_bug.cgi?id=214371

Reviewed by Alex Christensen.

Source/WebKit:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Reworded a comment.

Source/WebKitLegacy/mac:

  • WebView/WebViewPrivate.h: Corrected a mistake in a comment.

Source/WTF:

  • wtf/URLHelpers.cpp:

(WTF::URLHelpers::loadIDNAllowedScriptList): Renamed.
(WTF::URLHelpers::isLookalikeCharacter): Renamed.
(WTF::URLHelpers::addScriptToIDNAllowedScriptList): Renamed.
(WTF::URLHelpers::initializeDefaultIDNAllowedScriptList): Renamed.
(WTF::URLHelpers::allCharactersInAllowedIDNScriptList): Renamed.
(WTF::URLHelpers::mapHostName): Updated for name changes.

  • wtf/URLHelpers.h: Renamed things.
  • wtf/cocoa/NSURLExtras.mm:

(WTF::readIDNAllowedScriptListFile): Renamed.
(WTF::URLHelpers::loadIDNAllowedScriptList): Renamed. Also use a modern for
loop to simplify the code.

2:31 PM Changeset in webkit [264422] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Flip the sense of the return value for processWheelEventForScrollSnap()
​https://bugs.webkit.org/show_bug.cgi?id=214328

Reviewed by Wenson Hsieh.

All the other functions return "true" to mean "handled". Make this one the same.

  • platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::handleWheelEvent):
(WebCore::ScrollController::processWheelEventForScrollSnap):

2:18 PM Changeset in webkit [264421] by aakash_jain@apple.com
  • 5 edits in trunk/Tools

[ews] clicking submit for EWS analysis button for patches on closed bug should display error
​https://bugs.webkit.org/show_bug.cgi?id=214372

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-app/ews/common/bugzilla.py:

(Bugzilla._get_bug_json): Method to get bug json.
(Bugzilla.is_bug_closed): Method to check if bug is closed.

  • BuildSlaveSupport/ews-app/ews/config.py:
  • BuildSlaveSupport/ews-app/ews/fetcher.py:

(BugzillaPatchFetcher.send_patches_to_buildbot):

  • BuildSlaveSupport/ews-app/ews/views/submittoews.py:

(SubmitToEWS.post): Display error message on submit for EWS analysis button click for closed bugs.

2:15 PM Changeset in webkit [264420] by Devin Rousso
  • 8 edits in trunk

should represent TextPlaceholderElement as an NSTextAttachmentCharacter instead of a \n
​https://bugs.webkit.org/show_bug.cgi?id=214331
<rdar://problem/64779558>

Reviewed by Wenson Hsieh.

Source/WebCore:

  • editing/TextIterator.cpp:

(WebCore::shouldEmitReplacementInsteadOfNode): Added.
(WebCore::shouldEmitNewlinesBeforeAndAfterNode):
(WebCore::TextIterator::representNodeOffsetZero):
Placeholders should eventually be removed, so stringifying them as a newline doesn't make
sense as they should be treated as a "slot" in the existing flow of the surrounding content
without changing the characteristics of the content (e.g. a sentence with a placeholder
should remain as a sentence, not suddenly become two paragraphs separated by a placeholder).

Source/WebKit:

  • Platform/spi/ios/UIKitSPI.h:

Add missing SPI declarations.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView removeTextPlaceholder:willInsertText:completionHandler:]):
Drive-by: ensure that the completionHandler is always called.

Tools:

  • TestWebKitAPI/ios/UIKitSPI.h:

Add missing SPI declarations.

  • TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:

(-[TestWKWebView synchronouslyInsertTextPlaceholderWithSize:]): Added.
(-[TestWKWebView synchronouslyRemoveTextPlaceholder:willInsertText:]): Added.
(TEST.DocumentEditingContext.RequestBeforeInlinePlaceholder): Added.
(TEST.DocumentEditingContext.RequestAfterInlinePlaceholder): Added.
(TEST.DocumentEditingContext.RequestBeforeBlockPlaceholder): Added.
(TEST.DocumentEditingContext.RequestAfterBlockPlaceholder): Added.

2:15 PM Changeset in webkit [264419] by stephan.szabo@sony.com
  • 2 edits in trunk/Source/WebCore

[PlayStation] Build fix after r264213
​https://bugs.webkit.org/show_bug.cgi?id=214373

Unreviewed build fix

No new tests, build fix only

  • PlatformPlayStation.cmake: Stop compiling UserAgentQuirks
1:28 PM Changeset in webkit [264418] by dbates@webkit.org
  • 4 edits
    6 adds in trunk

[iOS] Caret should be before text placeholder instead of after it
​https://bugs.webkit.org/show_bug.cgi?id=214319
<rdar://problem/65295523>

Source/WebCore:

Reviewed by Wenson Hsieh.

Move the caret to before the text placeholder to match UIKit.

Tests: editing/text-placeholder/caret-before-zero-width-placeholder-in-content-editable-end-of-word.html

editing/text-placeholder/caret-before-zero-width-placeholder-in-content-editable-start-of-word.html
editing/text-placeholder/insert-into-content-editable-and-remove-via-mutation-event.html

  • editing/Editor.cpp:

(WebCore::Editor::insertTextPlaceholder): Compute the position before the placeholder in its parent.
This computation can only be done if the placeholder still has a parent. It may not after insertion
because arbitrary JavaScript code can run. If this happens then bail out and return nullptr. Otherwise,
set the new selection.

LayoutTests:

Reviewed by Wenson Hsieh and Simon Fraser (1).

Add some tests.

[1] Simon only reviewed editing/text-placeholder/insert-into-content-editable-and-remove-via-mutation-event.html.

  • editing/text-placeholder/caret-before-zero-width-placeholder-in-content-editable-end-of-word-expected.txt: Added.
  • editing/text-placeholder/caret-before-zero-width-placeholder-in-content-editable-end-of-word.html: Added.
  • editing/text-placeholder/caret-before-zero-width-placeholder-in-content-editable-start-of-word-expected.txt: Added.
  • editing/text-placeholder/caret-before-zero-width-placeholder-in-content-editable-start-of-word.html: Added.
  • editing/text-placeholder/insert-into-content-editable-and-remove-via-mutation-event-expected.txt: Added.
  • editing/text-placeholder/insert-into-content-editable-and-remove-via-mutation-event.html: Added.
  • resources/js-test.js:

(shouldBeLessThanOrEqual): Added. Just like shouldBeGreaterThanOrEqual, but for <=.

1:18 PM Changeset in webkit [264417] by Fujii Hironori
  • 4 edits in trunk/Source

[CMake][WebDriver] Generating WebDriverAtoms.cpp is rarely failing as "ImportError: No module named jsmin"
​https://bugs.webkit.org/show_bug.cgi?id=214339

Reviewed by Don Olmstead.

Source/JavaScriptCore:

  • CMakeLists.txt: Renamed stageSharedScripts to JavaScriptCoreSharedScripts.

Source/WebDriver:

There are a race condition between copying jsmin.py in
JavaScriptCore and using it in WebDriver. WebDriver target should
have a dependency to it.

  • CMakeLists.txt: Added add_dependencies for WebDriver.
1:03 PM Changeset in webkit [264416] by Jonathan Bedard
  • 2 edits in trunk/Tools

[run-javascriptcore-tests] nativeArchitecture should never be arm64e
​https://bugs.webkit.org/show_bug.cgi?id=214369
<rdar://problem/65364995>

Reviewed by Tim Horton.

  • Scripts/webkitdirs.pm:

(determineNativeArchitecture):
(determineArchitecture):

1:01 PM Changeset in webkit [264415] by Simon Fraser
  • 9 edits
    4 adds in trunk

itsnicethat.com page is sometimes non-scrollable
​https://bugs.webkit.org/show_bug.cgi?id=214362
<rdar://problem/65431127>

Reviewed by Tim Horton.

Source/WebCore:

This page uses 'clip-path: inset(1px); on a 1px x 1px element to hit descendants from
hit-testing and compositing code turns this into a layer mask using a CAShapeLayer.
Our layer/view hit-testing code failed to check for masking; if a layer has a mask,
it needs to be handled like -masksToBounds, in that points outside the mask should
never hit descendant layers.

Make a -_web_maskContainsPoint: to test whether the point is inside the mask layer,
and _web_maskMayIntersectRect: which does approximate testing using path bounds
intersection (this is used for editable regions).

Also convert some hard-coded winding rule strings to use the CA constants.

Tests: fast/scrolling/ios/clip-path-hit-test.html

fast/scrolling/mac/clip-path-hit-test.html

  • page/scrolling/mac/ScrollingTreeMac.mm:

(collectDescendantLayersAtPoint):

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::shapeWindRule const):
(WebCore::PlatformCALayerCocoa::setShapeWindRule):

  • platform/graphics/cocoa/WebCoreCALayerExtras.h:
  • platform/graphics/cocoa/WebCoreCALayerExtras.mm:

(-[CALayer _web_maskContainsPoint:]):
(-[CALayer _web_maskMayIntersectRect:]):

Source/WebKit:

This page uses 'clip-path: inset(1px); on a 1px x 1px element to hit descendants from
hit-testing and compositing code turns this into a layer mask using a CAShapeLayer.
Our layer/view hit-testing code failed to check for masking; if a layer has a mask,
it needs to be handled like -masksToBounds, in that points outside the mask should
never hit descendant layers.

Make a -_web_maskContainsPoint: to test whether the point is inside the mask layer,
and _web_maskMayIntersectRect: which does approximate testing using path bounds
intersection (this is used for editable regions).

Also convert some hard-coded winding rule strings to use the CA constants.

  • Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):

  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:

(WebKit::collectDescendantViewsAtPoint):
(WebKit::collectDescendantViewsInRect):

LayoutTests:

  • fast/scrolling/ios/clip-path-hit-test-expected.txt: Added.
  • fast/scrolling/ios/clip-path-hit-test.html: Added.
  • fast/scrolling/mac/clip-path-hit-test-expected.txt: Added.
  • fast/scrolling/mac/clip-path-hit-test.html: Added.
12:38 PM Changeset in webkit [264414] by Chris Dumez
  • 4 edits in trunk/Source/WebKit

Improve navigation policy decision release logging to help better diagnose issues
​https://bugs.webkit.org/show_bug.cgi?id=214368

Reviewed by Alex Christensen.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceivePolicyDecision):

12:20 PM Changeset in webkit [264413] by mark.lam@apple.com
  • 17 edits
    4 adds in trunk

Add handling of out of memory handling while adding a worklet module.
​https://bugs.webkit.org/show_bug.cgi?id=214354
<rdar://problem/65271931>

Reviewed by Yusuke Suzuki and Keith Miller.

Source/JavaScriptCore:

Add VM::tryCreate() that can fail if we encounter an out of memory issue.
As always, we're taking a best effort approach to handling out of memory errors.
Hence, we will not attempt to exhaustively handle every OOME scenario. This patch
only checks for failure to allocate a BigInt due to Gigacage exhaustion. While it
doesn't handle other allocation errors, it does enable us to add handling of other
cases in the future as needed.

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::tryCreate):

  • runtime/VM.h:

Source/WebCore:

Test: fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html

  • bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::createDOMException):

  • dom/ExceptionCode.h:
  • worklets/PaintWorkletGlobalScope.cpp:

(WebCore::PaintWorkletGlobalScope::tryCreate):
(WebCore::PaintWorkletGlobalScope::PaintWorkletGlobalScope):
(WebCore::PaintWorkletGlobalScope::create): Deleted.

  • worklets/PaintWorkletGlobalScope.h:
  • worklets/Worklet.cpp:

(WebCore::Worklet::addModule):

  • worklets/Worklet.h:
  • worklets/Worklet.idl:
  • worklets/WorkletGlobalScope.cpp:

(WebCore::WorkletGlobalScope::WorkletGlobalScope):

  • worklets/WorkletGlobalScope.h:
  • worklets/WorkletScriptController.cpp:

(WebCore::WorkletScriptController::WorkletScriptController):

  • worklets/WorkletScriptController.h:

LayoutTests:

We're skipping the new test on Debug builds because it will always run too slow.
The Release build is sufficient to test this OOME handling.

  • TestExpectations:
  • fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt: Added.
  • fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html: Added.
  • fast/css-custom-paint/script-tests: Added.
  • fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js: Added.

(useAllMemory.try.get Object):
(useAllMemory.try.foo):
(useAllMemory):
(catch):

12:05 PM Changeset in webkit [264412] by Alan Coon
  • 2 edits in branches/safari-610.1.22.2-branch/Source/WebKit

Cherry-pick r264385. rdar://problem/65617478

[iOS] Add missing messages to message filter in WebContent sandbox
​https://bugs.webkit.org/show_bug.cgi?id=214334
<rdar://problem/65529952>

Reviewed by Brent Fulgham.

Allow some messages which are required in the message filter in the WebContent process on iOS.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@264385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:04 PM Changeset in webkit [264411] by Alan Coon
  • 8 edits in branches/safari-610.1.22.2-branch/Source

Versioning.

WebKit-610.1.22.2.1

12:04 PM Changeset in webkit [264410] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Tab bar colors of undocked Inspector should match Safari in Big Sur
​https://bugs.webkit.org/show_bug.cgi?id=214163
<rdar://problem/65293335>

Reviewed by Brian Burg.

  • UserInterface/Views/Main.css:

(#undocked-title-area):
(body.big-sur #undocked-title-area):
(body:not(.big-sur) #undocked-title-area):
(body.window-inactive #undocked-title-area):
(@media (prefers-color-scheme: dark) body.big-sur #undocked-title-area):
(@media (prefers-color-scheme: dark) body:not(.big-sur) #undocked-title-area):
(@media (prefers-color-scheme: dark) body.big-sur.window-inactive #undocked-title-area):
(@media (prefers-color-scheme: dark) body:not(.big-sur).window-inactive #undocked-title-area):

  • UserInterface/Views/TabBar.css:

(.tab-bar):
(body.big-sur .tab-bar):
(body:not(.docked) .tab-bar):
(body.big-sur:not(.docked) .tab-bar):
(body:not(.big-sur):not(.docked) .tab-bar):
(body.big-sur:not(.docked).window-inactive .tab-bar,):
(.tab-bar > .border):
(.tab-bar > .tabs > .item):
(body:not(.docked) .tab-bar > .tabs > .item):
(body.big-sur:not(.docked) .tab-bar > .tabs > .item):
(body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item):
(body.big-sur:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected):
(body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected):
(body.big-sur:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover):
(body:not(.big-sur):not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover):
(body:not(.docked).window-inactive .tab-bar > .tabs > .item):
(body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item,):
(body:not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected):
(.tab-bar > .tabs.animating.inserting-tab > .item.being-inserted):
(.tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected):
(@media (prefers-color-scheme: dark) body.big-sur .tab-bar,):
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar):
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar):
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item):
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected):
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected):
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover):
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover):
(@media (prefers-color-scheme: dark) body:not(.docked).window-inactive .tab-bar):
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar,):
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item):
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked).window-inactive .tab-bar > .tabs > .item):
(@media (prefers-color-scheme: dark) body.big-sur:not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected):
(@media (prefers-color-scheme: dark) body:not(.big-sur):not(.docked).window-inactive .tab-bar > .tabs > .item:not(.disabled).selected):

11:39 AM Changeset in webkit [264409] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[ iOS Debug ] fast/text-indicator/text-indicator-empty-link.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=214363

Unreview test gardening

Patch by Hector Lopez <Hector Lopez> on 2020-07-15

  • platform/ios-wk2/TestExpectations:
11:23 AM Changeset in webkit [264408] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

[WK2] Make establishing a connection between the WebProcess and the Network process more robust
​https://bugs.webkit.org/show_bug.cgi?id=214307
<rdar://problem/64592340>

Reviewed by Alex Christensen.

Make establishing a connection between the WebProcess and the Network process more robust.
When the network process is crashy, it is not uncommon for the WebProcess to fail to establish
a connection to the network process. Previously, we would try twice and then give up by calling
CRASH(). I have tweaked the logic so that we now try 10 times and wait 100 ms between each
attempt to make a best effort at establishing the connection. I also updated the logic to exit
cleanly instead of crashing if the IPC connection to the UIProcess becomes invalid (i.e. the
UIProcess has severed the connection because this WebProcess is no longer needed).

  • WebProcess/WebProcess.cpp:

(WebKit::getNetworkProcessConnection):
(WebKit::WebProcess::ensureNetworkProcessConnection):

11:17 AM Changeset in webkit [264407] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Building AccessibilitySupportSPI with the macOS Big Sur public SDK fails
​https://bugs.webkit.org/show_bug.cgi?id=214237

Patch by Rob Buis <​rbuis@igalia.com> on 2020-07-15
Reviewed by Alex Christensen.

Source/WebCore/PAL:

We need to include CoreFoundation.h header here to use CF_ENUM, since
we can't rely on the call site that includes AccessibilitySupportSPI.h
doing it for us.
We also need to declare _AXSetClientIdentificationOverride since it
it is used by AccessibilityController.cpp.

  • pal/spi/cocoa/AccessibilitySupportSPI.h:
  • pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

Need to include HIServicesSPI.h for _AXUIElementRequestServicedBySecondaryAXThread.

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
11:03 AM Changeset in webkit [264406] by Ryan Haddad
  • 2 edits in trunk/Tools

Flaky API Test: TestWebKitAPI.SleepDisabler.NavigateBack
​https://bugs.webkit.org/show_bug.cgi?id=213513#c9

Unreviewed test gardening.

  • TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:

(TEST_F): Disable the test to speed up EWS.

10:59 AM Changeset in webkit [264405] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

Update a WKPreferences API comment.
​https://bugs.webkit.org/show_bug.cgi?id=214360

Rubberstamped by Tim Horton

  • UIProcess/API/Cocoa/WKPreferences.h:
10:34 AM Changeset in webkit [264404] by clopez@igalia.com
  • 2 edits in trunk/Tools

build-webkit script tries to execute command xcodebuild on Linux
​https://bugs.webkit.org/show_bug.cgi?id=214353

Reviewed by Jonathan Bedard.

Recently, when running the script build-webkit on Linux the following warning is printed:
Can't exec "xcodebuild": No such file or directory at Tools/Scripts/webkitdirs.pm line 602

To fix this, change the code to only call the function determineXcodeSDK() when
building for an Apple/Cocoa platform.

  • Scripts/webkitdirs.pm:

(determineArchitecture):

10:26 AM Changeset in webkit [264403] by Oriol Brufau
  • 5 edits in trunk/Source/WebCore

[css-grid] Rename SmallestTrackStart to ExplicitGridStart
​https://bugs.webkit.org/show_bug.cgi?id=214347

Reviewed by Manuel Rego Casasnovas.

The SmallestTrackStart method used to return a signed int which was
never positive, representing the smallest untranslated start among all
grid items, clamped by 0 as a maximum.

In practice, though, what we usually want is the index of the first
explicit track/line among all tracks/lines, or equivalently, the number
of leading implicit tracks/lines.

That number is precisely minus the return value of SmallestTrackStart.
Thus, in grid layout there were various std::abs() to invert the value.

But it's a bit confusing to have an API which returns a non-positive
integer, which then needs to be made non-negative. Therefore, this patch
renames SmallestTrackStart to ExplicitGridStart, and makes it return
the unsigned which is usually desired.

This patch should have no effect in practice.

This patch is a port of ​https://crrev.com/777768

  • rendering/Grid.cpp:

(WebCore::Grid::setExplicitGridStart):
(WebCore::Grid::explicitGridStart const):
(WebCore::Grid::setNeedsItemsPlacement):

  • rendering/Grid.h:
  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::rawGridTrackSize const):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeEmptyTracksForAutoRepeat const):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator const):
(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):

10:09 AM Changeset in webkit [264402] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore/PAL

Fix some build configurations after r264389
​https://bugs.webkit.org/show_bug.cgi?id=214245

Unreviewed.

  • pal/spi/mac/IOKitSPIMac.h: Forward declare newly used stuff.
9:34 AM Changeset in webkit [264401] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed atttempt to fix build after r264389.

  • platform/gamepad/mac/HIDGamepadProvider.mm:

(WebCore::HIDGamepadProvider::deviceRemoved):

9:32 AM Changeset in webkit [264400] by commit-queue@webkit.org
  • 6 edits in trunk

[WTF] Fix PackedAlignedPtr for X86_64 canonical addresses
​https://bugs.webkit.org/show_bug.cgi?id=214142

Patch by Jim Mason <​jmason@ibinx.com> on 2020-07-15
Reviewed by Mark Lam

Source/JavaScriptCore:

Fixed pointer test to use unsigned in place of signed.

  • wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

Source/WTF:

  • wtf/Packed.h:

(WTF::PackedAlignedPtr::get const):
(WTF::PackedAlignedPtr::set):

Tools:

Revised test cases in TEST(WTF_Packed, AssignAndGet)

  • TestWebKitAPI/Tests/WTF/Packed.cpp:
9:24 AM Changeset in webkit [264399] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-app] Add timeout to network requests
​https://bugs.webkit.org/show_bug.cgi?id=214355

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-app/ews/common/util.py:

(fetch_data_from_url): Add tiemout as recommended in ​https://requests.readthedocs.io/en/master/user/quickstart/#timeouts

7:51 AM Changeset in webkit [264398] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Make ews django app robust against network issues
​https://bugs.webkit.org/show_bug.cgi?id=214351

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-app/ews/common/buildbot.py:

(Buildbot.fetch_pending_and_inprogress_builds): Re-fetch builder_name_to_id_mapping if required.

7:47 AM Changeset in webkit [264397] by Alexey Shvayka
  • 5 edits
    1 add in trunk

Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers
​https://bugs.webkit.org/show_bug.cgi?id=214325

Reviewed by Darin Adler and Saam Barati.

JSTests:

  • microbenchmarks/has-own-property-for-in-loop-reflect-name.js: Added.
  • stress/reflect-has.js:
  • stress/reflect.js:

Source/JavaScriptCore:

Currently, HasOwnPropertyFunctionCallDotNode is emitted for all ResolveNodes
except ones with "Reflect" identifier. This exception doesn't seem necessary
as ReflectObject inherits ordinary Object.prototype.hasOwnProperty method.

This patch removes the exception, advancing provided "Reflect" microbenchmark
by 20%. No behavior change.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::makeFunctionCallNode):

7:00 AM Changeset in webkit [264396] by Jonathan Bedard
  • 3 edits in trunk/Tools

[webkitpy] Support Rosetta testing
​https://bugs.webkit.org/show_bug.cgi?id=214016
<rdar://problem/65153804>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess.init): Emulate architecture if native and specified architectures do not match.

  • Scripts/webkitpy/port/server_process_unittest.py:

(TrivialMockPort.architecture):

6:58 AM Changeset in webkit [264395] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][IFC] Remove Display::LineBox::isConsideredEmpty
​https://bugs.webkit.org/show_bug.cgi?id=214335

Reviewed by Antti Koivisto.

Display classes should not have layout related bits.

  • layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough const):

  • layout/displaytree/DisplayLineBox.h:

(WebCore::Display::LineBox::baselineOffset const):
(WebCore::Display::LineBox::LineBox):
(WebCore::Display::LineBox::isConsideredEmpty const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

6:48 AM Changeset in webkit [264394] by Lauro Moura
  • 8 edits
    1 add in trunk

[SOUP] Artificial delay to WebSocket connection to mitigate port scanning attacks
​https://bugs.webkit.org/show_bug.cgi?id=214293

Reviewed by Carlos Garcia Campos.

Source/WebKit:

r264306 added an artificial delay when NetworkSocketStream closed due
to closed ports but Soup-based ports use another code path and were
still returning immediately.

SOUP WebSocket errors do not distinguish closed ports separately, so
this commit checks for connections that finished with NOT_WEBSOCKET
errors.

Covered by existing tests.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::randomClosedPortDelay): Move the delay
calculation here to be shared between the different code paths.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkSocketStream.cpp:

(WebKit::NetworkSocketStream::didFailSocketStream): Use the shared
delay.
(WebKit::randomDelay): Deleted.

  • NetworkProcess/soup/WebSocketTaskSoup.cpp:

(WebKit::WebSocketTask::WebSocketTask): Add a oneShot timer with
random duration when failing to connect to something that is not a
WebSocket.
(WebKit::WebSocketTask::delayFailTimerFired):

LayoutTests:

Add glib-specific baseline due to SOUP messages.

  • platform/glib/TestExpectations:
  • platform/glib/http/tests/websocket/tests/hybi/closed-port-delay-expected.txt: Added.
6:05 AM Changeset in webkit [264393] by aboya@igalia.com
  • 2 edits in trunk/LayoutTests

[MSE][GStreamer] Unreviewed micro gardening: imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html
​https://bugs.webkit.org/show_bug.cgi?id=214349

New test
imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html
crashes on an assertion.

This is not surprising since changetype is not implemented in our port and we
already had a similar crash with that feature. Marking it as [ Failure Crash ].

  • platform/gtk/TestExpectations:
5:56 AM Changeset in webkit [264392] by aboya@igalia.com
  • 6 edits in trunk/Source/WebCore

[MSE][GStreamer] Break circular reference between SourceBufferPrivateGStreamer and AppendPipeline
​https://bugs.webkit.org/show_bug.cgi?id=214345

Reviewed by Xabier Rodriguez-Calvar.

SourceBufferPrivate is ref counted.

AppendPipeline is owned exclusively by SourceBufferPrivateGStreamer:
it's born and destroyed with it, managed by a never-moved unique_ptr.

AppendPipeline needs a reference to SourceBufferPrivateGStreamer to
notify it of essential events like samples having been parsed. This
used to be a Ref<>, thus creating a circular reference leak:

AppendPipeline is only destroyed in SourceBufferPrivateGStreamer
destructor. AppendPipeline holds ref counted reference to
SourceBufferPrivateGStreamer, therefore neither are destroyed.

This patch breaks the cycle by replacing the Ref<> in AppendPipeline
with a plain old reference. This is safe because
SourceBufferPrivateGStreamer owns, and therefore is alive at least
just as long as AppendPipeline.

As a consequence of not using Ref<>, the SourceBufferPrivateGStreamer
constructor does no longer need to relax the adoption requirements and
unique_ptr<AppendPipeline> can be replaced by a UniqueRef<>.

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::handleErrorConditionFromStreamingThread):
(WebCore::AppendPipeline::handleStateChangeMessage):
(WebCore::AppendPipeline::handleEndOfAppend):
(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::AppendPipeline::didReceiveInitializationSegment):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink):

  • platform/graphics/gstreamer/mse/AppendPipeline.h:

(WebCore::AppendPipeline::sourceBufferPrivate):

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):

  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::SourceBufferPrivateGStreamer):

  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
3:18 AM Changeset in webkit [264391] by ysuzuki@apple.com
  • 7 edits in trunk

[JSC] Introduce JSCTEST_hardTimeout
​https://bugs.webkit.org/show_bug.cgi?id=214343

Reviewed by Mark Lam.

Source/JavaScriptCore:

JSC Debug tests are failing consistently these days, ​https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/.
My guess is that some tests get stuck inside JSC even if timeout occurs. Let's consider the following case.

  1. The test is having JSC_useConcurrentJIT=0.
  2. The test is building super heavy FTL code in the main thread.
  3. The timeout thread notifies the VM about the timeout.
  4. But VM does not stop since it is running super heavy FTL compilation.
  5. After 1200 seconds, buildbot terminates the entire test.

In the above case, JSC gets stuck, and eventually buildbot terminates.
In this patch, we introduce JSCTEST_hardTimeout. After soft-timeout (usual timeout) happens, we wait another JSCTEST_hardTimeout seconds.
And if the JSC shell is not finished, we forcefully terminates the JSC shell via exit(EXIT_FAILURE), to avoid entire JSC test termination
in buildbot.

We pick 300 seconds. This means, after soft-timeout occurs, we wait for 5 mins, and if the JSC shell is still active, kill it. 5 mins sounds
reasonable amount of time. And this should fit within buildbot's hard timeout (1200 seconds).

  • jsc.cpp:

(startTimeoutTimer):

Tools:

  • Scripts/run-javascriptcore-tests:
  • Scripts/run-jsc-stress-tests:
  • Scripts/webkitruby/jsc-stress-test-writer-default.rb:
  • Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
1:52 AM Changeset in webkit [264390] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] API test /webkit/WebKitWebInspectorServer/test-page-list is flaky
​https://bugs.webkit.org/show_bug.cgi?id=188115

Reviewed by Michael Catanzaro.

Stop using DBus to connect to the remote inspector and reload the page until we see the inspectable target.

  • TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:

(connectToInspectorServer):

  • TestWebKitAPI/glib/TestExpectations.json:
1:00 AM Changeset in webkit [264389] by beidson@apple.com
  • 7 edits in trunk/Source

Resolve race between IOHIDManager and GameController framework.
<rdar://problem/65554490> and ​https://bugs.webkit.org/show_bug.cgi?id=214245

Reviewed by Tim Horton.

Source/WebCore:

No automated testing available.

IOHIDDevices and IOHIDServices are two separate things.

An IOHIDDevice and IOHIDService often have a 1-to-1 correlation, but the IOHIDDevice might be
published to the application before the IOHIDService is.

WebKit's HID gamepad manager uses IOHIDDevice.
GameController.framework uses IOHIDServices.

When we added the ability for WebKit to switch between HID and GCF, the following happens:

  • Sometimes the IOHIDServiceClient will get published first. Then when the IOHIDDevice is published, and WebKit was deciding which gamepad manager to use, the device's services are available, and we get the right answer.
  • Sometimes, the IOHIDDevice is published first. Then when WebKit is deciding which gamepad manager to use, it can't check the IOHIDServiceClient against GameController framework. So we have the HID manager handle the device... but then GCF comes along a split second later and ALSO handles it.

The "device before service" scenario results in the same gamepad showing up twice.

To resolve this, we do the following:

1 - If an IOHIDDevice attaches and its services aren't available yet, we delay managing it.
2 - When we delay managing a device, we start listening for IOHIDServiceClient additions.
3 - Each time a GamePad service is published, we once again try to determine if GCF will handle

the device.

4 - As long as the answer is "Maybe" - instead of "Yes" or "No" - we refuse to manage the device.
5 - After a brief delay (currently 1 second), we will give up waiting for published services

and manage the device with the HID gamepad provider.

In my testing, when the service publishes after the devices, it's always within 50ms,
(and usually just a spin or two of the runloop) so the 1s delay seems sufficient.

NOTE: The above all holds true with the "MultiGamepadProvider" on Catalina.
On Big Sur, there's brand new GameController framework API that makes this much easier. 👍

  • platform/gamepad/mac/HIDGamepadProvider.h:
  • platform/gamepad/mac/HIDGamepadProvider.mm:

(WebCore::deviceAddedCallback):
(WebCore::gameControllerFrameworkWillHandleHIDDevice):
(WebCore::HIDGamepadProvider::waitForManagementDecisionForDevice):
(WebCore::HIDGamepadProvider::removeDeviceWaitingForManagementDecision):
(WebCore::HIDGamepadProvider::newGamePadServicePublished):
(WebCore::HIDGamepadProvider::deviceAdded):
(WebCore::HIDGamepadProvider::deviceRemoved):

Source/WebCore/PAL:

  • pal/spi/mac/IOKitSPIMac.h:

Source/WTF:

  • wtf/PlatformHave.h:
Note: See TracTimeline for information about the timeline view.