Timeline

Jul 29, 2020:

11:58 PM Changeset in webkit [265077] by Fujii Hironori

• 6 edits in trunk/Tools

Replace '​http://svn.webkit.org' with '​https://svn.webkit.org' in webkitpy scripts
​https://bugs.webkit.org/show_bug.cgi?id=214957

Reviewed by Daniel Bates.

SVNRepository.has_authorization_for_realm failed to find the realm
string.

• Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry): Removed a unused variable 'svn_id_regexp'.

• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
• Scripts/webkitpy/common/config/urls.py:
• Scripts/webkitpy/tool/commands/suggestnominations.py:

(AbstractCommitLogCommand): Changed _revision_regexp to use 'https?' to accept 'https'.

• Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:

10:43 PM Changeset in webkit [265076] by ysuzuki@apple.com

• 2 edits in trunk/JSTests

Unreviewed, use requireOptions
​https://bugs.webkit.org/show_bug.cgi?id=214956

• wasm/stress/bottom-tuple.js:

10:43 PM Changeset in webkit [265075] by jh718.park@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Remove the build warning below since r265062.
warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

No new tests, no new behaviors.

• Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::copyFromChannel):
(WebCore::AudioBuffer::copyToChannel):

9:42 PM Changeset in webkit [265074] by ysuzuki@apple.com

• 17 edits
  2 copies
  1 add in trunk

[JSC] Add B3::BottomTupleValue node
​https://bugs.webkit.org/show_bug.cgi?id=214956
<rdar://problem/65192877>

Reviewed by Keith Miller.

JSTests:

• wasm/stress/bottom-tuple.js: Added.

(try.main):
(catch):

Source/JavaScriptCore:

In B3 strength reduction, we convert B3 values to bottom value based on type after Oops kind, and then they are *typically* removed later.
While we support bottom values for usual types, we do not have a bottom value for tuple type. So when replaceWithBottom is called, we
fail to replace Patchpoints producing tuples with bottom values.

This patch newly adds B3 BottomTupleValue, which is just a BottomValue for tuple. We can extend it to generate arbitrary constant
tuple values, but for now, we just support bottom tuple values. We add a new node instead of generating patchpoint which generates bottom
values since BottomTupleValues implementation is simpler: BottomTupleValue just emits bunch of zero clear for Air tmps and Air does everything
automatically. On the other hand, implementing a patchpoint needs to add code which clears things with zero while checking the ValueRep. And
since we have Const32, Const64, etc. values, having this kind of value for tuple too is natural. Plus, this design allows us to remove bunch
of unnecessary instructions after lowering this to Air since Air knows what instructions will be emitted by this BottomTupleValue, and Air
can remove a lot of zero clear instructions if they are not read later by Extract.

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• b3/B3BottomTupleValue.cpp: Copied from Source/JavaScriptCore/b3/B3InsertionSet.cpp.

(JSC::B3::BottomTupleValue::dumpMeta const):

• b3/B3BottomTupleValue.h: Copied from Source/JavaScriptCore/b3/B3InsertionSet.cpp.
• b3/B3InsertionSet.cpp:

(JSC::B3::InsertionSet::insertBottom):

• b3/B3LowerToAir.cpp:
• b3/B3Opcode.cpp:

(WTF::printInternal):

• b3/B3Opcode.h:
• b3/B3Procedure.cpp:

(JSC::B3::Procedure::addBottom):

• b3/B3TypeMap.h:

(JSC::B3::TypeMap::TypeMap): Deleted.

• b3/B3Validate.cpp:
• b3/B3Value.cpp:

(JSC::B3::Value::effects const):
(JSC::B3::Value::key const):

• b3/B3Value.h:
• b3/B3ValueInlines.h:
• b3/B3ValueKey.cpp:

(JSC::B3::ValueKey::materialize const):

• b3/testb3_7.cpp:

(testBottomTupleValue):
(addTupleTests):

6:01 PM Changeset in webkit [265073] by jer.noble@apple.com

• 10 edits in trunk/Source

Support HDR decode in SW VP9
​https://bugs.webkit.org/show_bug.cgi?id=214928
Source/ThirdParty/libwebrtc:

Reviewed by Eric Carlson.

Support converting I010 buffers (full-planar, 10-bit data packed into the LSB of a 16-bit int)
into CVPixelBuffers (bi-planar, 10-bit data packed into the MSB of a 16-bit int). This requires
using functions from libyuv to merge and scale 16-bit planar data, optimized for AVX2. To know
that incoming buffers are 10-bit, and whether they're full-range, parse the 'vpcC' atom attached
to the CMFormatDescription.

• Source/webrtc/sdk/WebKit/WebKitUtilities.mm:

(webrtc::MergeUVPlane_16):
(webrtc::CopyPlane_16):
(webrtc::CopyVideoFrameToPixelBuffer):
(webrtc::pixelBufferFromFrame):

• Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:

(webrtc::createWebKitVP9Decoder):
(webrtc::startVP9DecoderSession):
(webrtc::WebKitVP9DecoderReceiver::createPixelBufferPoolForFormatDescription):
(webrtc::WebKitVP9DecoderReceiver::Decoded):

Source/WebCore:

Reviewed by Eric Carlson.

Convert the incoming properties parsed from the VP9 header into extensions to our
CMFormatDescription attached to each incoming video fram.

Drive-by fix: Files in the wild will have incorrect values for whether a given
frame is a keyframe or not. Trust the VP9 header parser rather than the container
in this situations.

• platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::convertToCMColorPrimaries):
(WebCore::convertToCMTransferFunction):
(WebCore::convertToCMYCbCRMatrix):
(WebCore::createFormatDescriptionFromVP9HeaderParser):
(WebCore::SourceBufferParserWebM::OnFrame):

Source/WebCore/PAL:

<rdar://problem/66284848>

Reviewed by Eric Carlson.

• pal/cf/CoreMediaSoftLink.cpp:
• pal/cf/CoreMediaSoftLink.h:

6:00 PM Changeset in webkit [265072] by Megan Gardner

• 2 edits in trunk/Source/WebKit

Highlight color does not switch after being set it system preferences.
​https://bugs.webkit.org/show_bug.cgi?id=214938
<rdar://problem/65270586>

Reviewed by Tim Horton.

After the changes to the sandbox and how defaults are being transferred to the web process
(​https://trac.webkit.org/changeset/258064/webkit), the highlight color was not being updated
immediately. We need to send the proper notification after setting the defaults so that the
color cache is invalidated after it is actually set and we do not end up with a stale value.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::userHighlightColorPreferenceKey):
(WebKit::dispatchSimulatedNotificationsForPreferenceChange):

5:14 PM Changeset in webkit [265071] by ysuzuki@apple.com

• 10 edits
  3 deletes in trunk/JSTests

[JSC] Upgrade test262
​https://bugs.webkit.org/show_bug.cgi?id=214949

Reviewed by Ross Kirsling.

related-year-zh.js tests are updated and passing.

• test262/config.yaml:
• test262/latest-changes-summary.txt:
• test262/test/intl402/DateTimeFormat/prototype/format/related-year-zh.js:
• test262/test/intl402/DateTimeFormat/prototype/formatToParts/related-year-zh.js:

(actual.forEach):
(verifyFormatParts): Deleted.
(verifyFormatParts.df.formatToParts): Deleted.

• test262/test/intl402/Segmenter/prototype/segment/segment-grapheme-iterable.js:

(const.v.of.seg.segment):

• test262/test/intl402/Segmenter/prototype/segment/segment-grapheme.js: Removed.
• test262/test/intl402/Segmenter/prototype/segment/segment-sentence-iterable.js:

(const.v.of.seg.segment):

• test262/test/intl402/Segmenter/prototype/segment/segment-sentence.js: Removed.
• test262/test/intl402/Segmenter/prototype/segment/segment-tostring.js:
• test262/test/intl402/Segmenter/prototype/segment/segment-word-iterable.js:

(const.v.of.seg.segment):

• test262/test/intl402/Segmenter/prototype/segment/segment-word.js: Removed.
• test262/test262-Revision.txt:

4:57 PM Changeset in webkit [265070] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/ANGLE

[GTK] 2.29.4 fails to link on armv7hl
​https://bugs.webkit.org/show_bug.cgi?id=214934

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-07-29
Reviewed by Carlos Alberto Lopez Perez.

Link ANGLE to with -ldl

• CMakeLists.txt:

4:50 PM Changeset in webkit [265069] by ysuzuki@apple.com

• 5 edits in trunk/JSTests

[JSC] Skip too heavy tests for Debug build
​https://bugs.webkit.org/show_bug.cgi?id=214939

Reviewed by Mark Lam.

They are taking too much time in Debug build and cause timeout. We should skip them.

• ChakraCore.yaml:
• stress/codeblock-destructor-access-unlinkedcodeblock.js:
• stress/dfg-to-string-on-string-object-does-not-gc.js:
• stress/rest-parameter-many-arguments.js:

4:40 PM Changeset in webkit [265068] by Darin Adler

• 1 edit
  1 add in trunk/Tools

Add script to help us count uses of non-inclusive terms
​https://bugs.webkit.org/show_bug.cgi?id=214942

Reviewed by Beth Dakin.

• Scripts/report-non-inclusive-language: Added.

4:34 PM Changeset in webkit [265067] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

[iPadOS] Custom dropdown menu dismisses immediately on account.nhl.com
​https://bugs.webkit.org/show_bug.cgi?id=214944
<rdar://problem/66248506>

Reviewed by Jer Noble.

Exempt account.nhl.com from site-specific "simulated mouse events" behavior, since it is incompatible with some
custom dropdown menus that appear on this website.

• page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

4:29 PM Changeset in webkit [265066] by Chris Dumez

• 29 edits
  4 adds in trunk

Added constructor methods to ChannelMergerNode, ChannelSplitterNode
​https://bugs.webkit.org/show_bug.cgi?id=214851
<rdar://problem/66233763>

Patch by Clark Wang <​clark_wang@apple.com> on 2020-07-29
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Re-baselined existing tests that now pass, or fail due to a different interface.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/simple-input-output.https-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/active-processing.https-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/ctor-channelmerger-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelsplitternode-interface/audiochannelsplitter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelsplitternode-interface/ctor-channelsplitter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:

Source/WebCore:

Added constructors for ChannelMergerNode, ChannelSplitterNode according to spec:
​https://www.w3.org/TR/webaudio/#ChannelMergerNode-constructors. Added new files
for ChannelMergerOptions and ChannelSplitterOptions. This patch also ensures that
BaseAudioContext::create*() and *Node::create() methods behave the same.

Re-baselined existing tests that now pass, or fail further along.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/webaudio/AudioNode.h:
• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createChannelSplitter):
(WebCore::BaseAudioContext::createChannelMerger):

• Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::create):
(WebCore::ChannelMergerNode::setChannelCount):
(WebCore::ChannelMergerNode::setChannelCountMode):

• Modules/webaudio/ChannelMergerNode.h:
• Modules/webaudio/ChannelMergerNode.idl:
• Modules/webaudio/ChannelMergerOptions.h: Added.
• Modules/webaudio/ChannelMergerOptions.idl: Added.
• Modules/webaudio/ChannelSplitterNode.cpp:

(WebCore::ChannelSplitterNode::create):
(WebCore::ChannelSplitterNode::setChannelCount):
(WebCore::ChannelSplitterNode::setChannelCountMode):
(WebCore::ChannelSplitterNode::setChannelInterpretation):

• Modules/webaudio/ChannelSplitterNode.h:
• Modules/webaudio/ChannelSplitterNode.idl:
• Modules/webaudio/ChannelSplitterOptions.h: Added.
• Modules/webaudio/ChannelSplitterOptions.idl: Added.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

4:15 PM Changeset in webkit [265065] by Tadeu Zagallo

• 3 edits
  1 add in trunk

WebAssembly validation for call_indirect is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=214901
<rdar://problem/65189677>

Reviewed by Saam Barati.

JSTests:

• wasm/stress/validate-call_indirect.js: Added.

(try.main):
(catch):

Source/JavaScriptCore:

There was an incorrect condition when validating call_indirect's arguments, which often resulted in skipping this validation.

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):

3:47 PM Changeset in webkit [265064] by commit-queue@webkit.org

• 666 edits
  5 copies
  4 moves
  73 adds
  32 deletes in trunk/Source/ThirdParty/ANGLE

Roll ANGLE to 2020-07-28
​https://bugs.webkit.org/show_bug.cgi?id=214897

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-07-29
Reviewed by Alex Christensen.

Roll to current ANGLE revision. Large ChangeLog below has been
truncated except for a few significant files.

Add dependency on zlib wrapper in third_party/zlib/google for both
Xcode and CMake builds. Small change to this wrapper for the
WinCairo build's system zlib, which doesn't define z_const.

• .gitignore:
• ANGLE.plist:
• ANGLE.xcodeproj/project.pbxproj:
• CMakeLists.txt:
• Configurations/ANGLE-dynamic.xcconfig:
• Configurations/ANGLE-static.xcconfig:
• GLESv2.cmake:
• PlatformWin.cmake:
• third_party/zlib/google/compression_utils_portable.cc: Added.
• third_party/zlib/google/compression_utils_portable.h: Added.

3:24 PM Changeset in webkit [265063] by Kate Cheney

• 13 edits
  2 adds in trunk

Migrate App-Bound Domains code from WebKit Additions
​https://bugs.webkit.org/show_bug.cgi?id=214889
<rdar://problem/66075857>

Reviewed by Brent Fulgham.

Source/WebKit:

No new tests, this is just code migration and will be tested
by existing App-Bound Domains tests.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::activateSessionCleanup):
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):

• Shared/Cocoa/DefaultWebBrowserChecks.h: Added.
• Shared/Cocoa/DefaultWebBrowserChecks.mm: Added.

Holds all functions related to full browser checks and
App-Bound Domains.

(WebKit::shouldBeTreatedAsFullBrowser):
(WebKit::getAppBoundDomainsTesting):
These functions allow us to treat our test runners as full browsers
while triggering non-browser mode for testing other App-Bound Domains
functionality.

(WebKit::isInWebKitChildProcess):
(WebKit::hasRequestedCrossWebsiteTrackingPermission):
(WebKit::determineITPStateInternal):
(WebKit::determineITPState):
(WebKit::doesAppHaveITPEnabled):
(WebKit::doesParentProcessHaveITPEnabled):
(WebKit::hasProhibitedUsageStrings):
(WebKit::isParentProcessAFullWebBrowser):
(WebKit::isFullWebBrowser):

• UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::filterAppBoundCookies):

• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::PageConfiguration):
(): Deleted.

• UIProcess/WebPageProxy.cpp:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::createNewWebProcess):

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::addTestDomains const):
(WebKit::WebsiteDataStore::ensureAppBoundDomains const):

• UIProcess/WebsiteData/WebsiteDataStore.h:
• WebKit.xcodeproj/project.pbxproj:

Tools:

Replace WebKit Additions macros with code to set a different bundle
identifier indicating that we want to run an App-Bound Domains test.

Remove #if USE(APPLE_INTERNAL_SDK) check so we run these tests on EWS.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(cleanUpInAppBrowserPrivacyTestSettings):
(initializeInAppBrowserPrivacyTestSettings):

LayoutTests:

• platform/ios-wk2/TestExpectations:

These tests are now expected to pass.

3:07 PM Changeset in webkit [265062] by commit-queue@webkit.org

• 9 edits in trunk

Added copyFromChannel, copyToChannel to AudioBuffer
​https://bugs.webkit.org/show_bug.cgi?id=214926

Patch by Clark Wang <​clark_wang@apple.com> on 2020-07-29
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Re-baselined existing tests. Fails on catching sharedBuffer being passed in, but currently

WebKit does not support sharedBuffer implementation.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-limits-expected.txt:

Source/WebCore:

Added copyFromChannel, copyToChannel methods according to spec:
​https://www.w3.org/TR/webaudio/#dom-audiobuffer-copyfromchannel-destination.
Used Chromium implementation for reference:
​https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/modules/webaudio/audio_buffer.cc.

Re-baselined existing tests. Fails on catching sharedBuffer being passed in, but currently
WebKit does not support sharedBuffer implementation.

• Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::getChannelData):
(WebCore::AudioBuffer::copyFromChannel):
(WebCore::AudioBuffer::copyToChannel):

• Modules/webaudio/AudioBuffer.h:
• Modules/webaudio/AudioBuffer.idl:

3:00 PM Changeset in webkit [265061] by Simon Fraser

• 6 edits in trunk/Tools

Make the lock icon update correctly in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=214933

Reviewed by Alex Christensen.

Various fixes to the MiniBrowser lock icon. Set the initial state to unlocked in the XIB.
Dim the icon when there is no certificate to display. Dim it and show unlocked for WK1 windows.

• MiniBrowser/mac/BrowserWindow.xib:
• MiniBrowser/mac/BrowserWindowController.h:
• MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController showCertificate:]):

• MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController validateUserInterfaceItem:]):

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController validateUserInterfaceItem:]):

2:55 PM Changeset in webkit [265060] by Jonathan Bedard

• 2 edits in trunk/Tools

[webkitcorepy] Add an auto-installer (Unreviewed follow-up fix 2)
​https://bugs.webkit.org/show_bug.cgi?id=214606

Unreviewed infrastructure fix.

webkit-patch just ignores svn:ignore, and lands the patch with only a changelog.

• Scripts/libraries: Added property svn:ignore.

2:50 PM Changeset in webkit [265059] by Wenson Hsieh

• 8 edits
  1 add in trunk

[macOS] Inspector bar in Mail compose shows incorrect text alignment style for ranged selections
​https://bugs.webkit.org/show_bug.cgi?id=214930
<rdar://problem/66185224>

Reviewed by Tim Horton.

Source/WebCore:

When a range of text is selected, AppKit consults -attributedSubstringForProposedRange:completionHandler: (or
just -attributedSubstringFromRange: in WebKitLegacy) to update the inspector bar with new style information.
Among this information is the paragraph style (an NSParagraphStyle corresponding to the attribute key
NSParagraphStyleAttributeName), which AppKit uses to select either the left, center or right text alignment
segmented control.

However, in both WebKitLegacy and modern WebKit, we don't include this information at all in HTMLConverter,
so AppKit just defaults to using -[NSParagraphStyle defaultParagraphStyle], with a default text alignment of
NSTextAlignmentNatural.

To fix this, include a new paragraph style object in the case where the text alignment is not equal to natural
(in other words, either a direction has been explicitly specified, or the text alignment style is not equal to
"start"). This paragraph style matches the default paragraph style, except for the alignment property which
is set to the corresponding NSTextAlignment value.

Tests: AttributedSubstringForProposedRange.TextAlignmentParagraphStyles

FontAttributes.FontAttributesAfterChangingSelection

• editing/Editor.cpp:

(WebCore::Editor::fontAttributesAtSelectionStart const):

Also fixes an existing bug in Editor::fontAttributesAtSelectionStart, where NSTextAlignmentNatural is
currently always used for text-align: start;, even if the direction is specified as RTL. Instead, change this
so that we only fall back to "natural" if no direction is specified; otherwise, go with the explicit "left" or
"right" values.

• editing/cocoa/HTMLConverter.mm:

(WebCore::editingAttributedString):

Tools:

Add a new API test and adjust an existing test to verify the codechange.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
• TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
• TestWebKitAPI/Tests/mac/AttributedSubstringForProposedRange.mm: Added.

(TEST):

2:50 PM Changeset in webkit [265058] by Jonathan Bedard

• 1 edit in trunk/Tools/ChangeLog

[webkitcorepy] Add an auto-installer (Unreviewed follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=214606

Unreviewed infrastructure fix.

svn:ignore was not correctly set when the patch was landed.

• Scripts/libraries: Added property svn:ignore.

2:41 PM Changeset in webkit [265057] by Fujii Hironori

• 2 edits in trunk/Source/WTF

[Win Debug] Unreviewed build fix

JavaScriptCore/runtime/JSArrayBufferView.cpp(51): error C2660: 'Gigacage::isEnabled': function does not take 0 arguments

• wtf/Gigacage.h:

(Gigacage::isEnabled): Added isEnabled taking no argument which was adeed to bmalloc in r249556 (Bug 201521).

2:22 PM Changeset in webkit [265056] by jer.noble@apple.com

• 8 edits in trunk/Source

REGRESSION(r264476): Calling systemHasAC() regresses launch time performance
​https://bugs.webkit.org/show_bug.cgi?id=214907
<rdar://problem/66191430>

Reviewed by Eric Carlson.

Source/WebCore:

Because calling into IOPS can block, delay queries about AC state during WebProcessPool creation until
the next run-loop.

Simultaneously, we don't need to check HDR state in the UI process for IOS, so send a default value
there as well.

• platform/cocoa/PowerSourceNotifier.h:
• platform/cocoa/PowerSourceNotifier.mm:

(WebCore::PowerSourceNotifier::PowerSourceNotifier):

• platform/cocoa/SystemBattery.h:
• platform/cocoa/SystemBattery.mm:

(WebCore::cachedSystemHasAC):

• platform/ios/PlatformScreenIOS.mm:

(WebCore::collectScreenProperties):

Source/WebKit:

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

2:21 PM Changeset in webkit [265055] by don.olmstead@sony.com

• 7 edits in trunk/Source

Remove USE(ZLIB)
​https://bugs.webkit.org/show_bug.cgi?id=214929

Reviewed by Darin Adler.

Source/WebCore:

Remove USE(ZLIB) guards in WebSocket code. Since WebSocketDeflateFramer::canDeflate
is always true remove it and the callsite checking it in WebSocketChannel.

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):

• Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::canDeflate const): Deleted.

• Modules/websockets/WebSocketDeflateFramer.h:
• Modules/websockets/WebSocketDeflater.cpp:

Source/WTF:

Remove setting a default value of USE_ZLIB.

• wtf/PlatformUse.h:

2:02 PM Changeset in webkit [265054] by Ryan Haddad

• 1 edit
  2 copies
  1 move
  6 adds
  1 delete in trunk/LayoutTests

Unreviewed iOS test gardening.

• platform/ios-13/imported/w3c/web-platform-tests/css/css-flexbox/inline-flex-editing-with-updating-text-crash-expected.txt: Copied from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-flexbox/inline-flex-editing-with-updating-text-crash-expected.txt.
• platform/ios-13/imported/w3c/web-platform-tests/fetch/redirect-navigate/preserve-fragment-expected.txt: Added.
• platform/ios-13/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt.
• platform/ios/imported/w3c/web-platform-tests/css/css-flexbox/inline-flex-editing-with-updating-text-crash-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-flexbox/inline-flex-editing-with-updating-text-crash-expected.txt.
• platform/ios/imported/w3c/web-platform-tests/fetch/redirect-navigate/preserve-fragment-expected.txt: Added.

2:02 PM Changeset in webkit [265053] by Jonathan Bedard

• 5 edits in trunk/Tools

[ews.webkit.org] Skip build upload for embedded iOS builds
​https://bugs.webkit.org/show_bug.cgi?id=214923

Reviewed by Aakash Jain.

• BuildSlaveSupport/ews-build/config.json: Skip upload for iOS Embedded builds.
• BuildSlaveSupport/ews-build/factories.py:

(iOSEmbeddedBuildFactory): Skip building and uploading product archive.

1:24 PM Changeset in webkit [265052] by Chris Dumez

• 6 edits in trunk/Source/WebCore

Calling AudioNode constructors should have identical behavior to using create*() function on BaseAudioContext
​https://bugs.webkit.org/show_bug.cgi?id=214931

Reviewed by Eric Carlson.

Calling AudioNode constructors should have identical behavior to using create*() function on BaseAudioContext.
Otherwise, this leads to assertion hits on the bots like we saw for Bug 214851.

We need to make sure that the AudioContext gets initialized when an AudioNode constructor gets called. We also
need to make sure refNode() gets called if necessary.

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createPanner):
(WebCore::BaseAudioContext::createOscillator):
(WebCore::BaseAudioContext::createPeriodicWave):

• Modules/webaudio/BaseAudioContext.h:
• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::create):

• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::create):

• Modules/webaudio/PeriodicWave.cpp:

(WebCore::PeriodicWave::create):

1:00 PM Changeset in webkit [265051] by Simon Fraser

• 5 edits in trunk

REGRESSION: ASSERTION FAILED: !needsLayout() on tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html flakily
​https://bugs.webkit.org/show_bug.cgi?id=214651
Source/WebCore:

<rdar://problem/65952371>

Reviewed by Zalan Bujtas.

Page::doAfterUpdateRendering() is expected to only call functions that can't trigger layout. However,
it could cause the firing of the "monitorWheelEvent" callback which can run arbitrary JS, so move that
earlier in the rendering update, before we do the final layout.

Also assert that the main frame doesn't need layout at the end of Page::doAfterUpdateRendering();
we were only checking subframes.

Tested by lots of existing tests.

• page/Page.cpp:

(WebCore::Page::updateRendering):
(WebCore::Page::doAfterUpdateRendering):

LayoutTests:

Reviewed by Zalan Bujtas.

De-flake this test.

• fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered-expected.txt:
• fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered.html:

12:12 PM Changeset in webkit [265050] by Chris Dumez

• 6 edits in trunk

Make sure playback state constants remain on OscillatorNode for backward compatibility
​https://bugs.webkit.org/show_bug.cgi?id=214925

Reviewed by Eric Carlson.

Source/WebCore:

Make sure playback state constants remain on OscillatorNode for backward compatibility,
while we keep supporting the prefixed Web Audio API.

No new tests, updated existing test.

• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/WebKitOscillatorNode.idl:

LayoutTests:

Improve layout test coverage.

• webaudio/oscillatornode-legacy-api-expected.txt:
• webaudio/oscillatornode-legacy-api.html:

11:43 AM Changeset in webkit [265049] by Jonathan Bedard

• 5 edits
  2 adds in trunk/Tools

[webkitcorepy] Add an auto-installer
​https://bugs.webkit.org/show_bug.cgi?id=214606

Reviewed by Darin Adler.

Add an autoinstaller to webkitcorepy. This is eventually intended to replace the
autoinstaller in webkitpy.

• Scripts/libraries: Added property svn:ignore.
• Scripts/libraries/webkitcorepy/README.md:
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py:
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py: Added.

(Package): Class representing a single Python module.
(Package.Archive): Class representing a zip file containing a package.
(Package.Archive.init): Construct representation with a name, version and
downloadable link.
(Package.Archive.repr): Archives are named based on their package name
and version.
(Package.Archive.path): The location of a downloaded archive on disk.
(Package.Archive.download): Download archive and write contents to disk.
(Package.Archive.unpack): Unpack archive on disk into package.
(Package.init): Packages are constructed with a name, version and name on
PyPi, which is assumed to be the package name unless specified.
(Package.location): Location of the package on disk.
(Package.do_post_install): Some packages have post-install actions, execute
those.
(Package.archives): Return a list of archives which match the specified
package parameters.
(Package.is_cached): Check the AutoInstall manifest to see if a package has
already been installed.
(Package.install): If needed, find a compatible archive for the specified
package, download and install it.
(AutoInstall): Namespace for auto-install functionality.
(AutoInstall._request): Make a request to the package index specified.
(AutoInstall.enable): Enable the auto-installer.
(AutoInstall.disable): Disable the auto-installer.
(AutoInstall.set_directory): Set the directory to save auto-installed libraries to.
(AutoInstall.set_index): Use a different package index.
(AutoInstall.set_timeout): Set the default timeout.
(AutoInstall.register): Add a package to the list of packages to be installed
when encountered.
(AutoInstall.install): Given a package, register and install that package.
(AutoInstall.install_everything): Install all registered packages if they are not
already.
(AutoInstall.find_module): Check and see if a requested module has been registered,
if it has, install that module if needed.

• Scripts/libraries/webkitcorepy/webkitcorepy/cacert.pem: Added.
• Scripts/libraries/webkitcorepy/webkitcorepy/rootcerts.p7b: Added.
• Scripts/webkitpy/init.py: Add logger, autoinstalled requests and certifi.
• Scripts/webkitpy/test/main.py:

(Tester._run_tests): Include webkitcorepy.AutoInstall when installing everything.

11:30 AM Changeset in webkit [265048] by Chris Dumez

• 4 edits in trunk

http/tests/cookies/document-cookie-multiple-cookies.html is failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=214880

Reviewed by Darin Adler.

Source/WebCore:

Fix same bug as in r264943 but on Windows.

No new tests, covered by http/tests/cookies/document-cookie-multiple-cookies.html.

• platform/network/cf/NetworkStorageSessionCFNetWin.cpp:

(WebCore::parseDOMCookie):
(WebCore::NetworkStorageSession::setCookiesFromDOM const):

LayoutTests:

Unskip test that is no longer failing on Windows.

• platform/win/TestExpectations:

11:11 AM Changeset in webkit [265047] by youenn@apple.com

• 5 edits in trunk

scaleResolutionDownBy has no effect on RTCRtpSender
​https://bugs.webkit.org/show_bug.cgi?id=214783
<rdar://problem/66108346>

Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

• Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:

(WebCore::updateRTCRtpSendParameters):
Allow to change scaleResolutionDownBy.

LayoutTests:

• webrtc/video-expected.txt:
• webrtc/video.html:

10:45 AM Changeset in webkit [265046] by mark.lam@apple.com

• 23 edits in trunk/Source/WebCore

CodeGeneratorJS should release the throwScope before doing a void call at end of a function.
​https://bugs.webkit.org/show_bug.cgi?id=214924

Reviewed by Chris Dumez.

It is necessary to release the throwScope because the void call at the end of the
function may throw an exception. Releasing the throwScope here says that this
function is releasing the responsibility to handle the exception, and will allow
the potential exception from the trailing void call to propagate to its caller.
The responsibility to handle the exception is passed to this function's caller (or
some earlier caller in the stack). It is ok to release the throwScope here
because the trailing void call will effectively be the last thing that this
function does before returning.

Covered by existing tests.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementationFunctionCall):

• bindings/scripts/test/JS/JSMapLike.cpp:

(WebCore::jsMapLikePrototypeFunctionClearBody):

• bindings/scripts/test/JS/JSSetLike.cpp:

(WebCore::jsSetLikePrototypeFunctionClearBody):

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunctionBody):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessageBody):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionOverloadedMethod1Body):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionOverloadedMethod2Body):

• bindings/scripts/test/JS/JSTestCEReactions.cpp:

(WebCore::jsTestCEReactionsPrototypeFunctionMethodWithCEReactionsBody):
(WebCore::jsTestCEReactionsPrototypeFunctionMethodWithCEReactionsNotNeededBody):

• bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::jsTestCallTracerPrototypeFunctionTestOperationInterfaceBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationSpecifiedBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithArgumentsBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgumentBody):

• bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::jsTestEnabledBySettingPrototypeFunctionEnabledBySettingOperationBody):

• bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::jsTestGlobalObjectInstanceFunctionRegularOperationBody):
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperation1Body):
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperation2Body):
(WebCore::jsTestGlobalObjectConstructorFunctionEnabledAtRuntimeOperationStaticBody):
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldBody):
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabledBody):
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeaturesEnabledBody):
(WebCore::jsTestGlobalObjectInstanceFunctionTestPrivateFunctionBody):
(WebCore::jsTestGlobalObjectInstanceFunctionCalculateSecretResultBody):

• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:

(WebCore::jsTestIndexedSetterWithIdentifierPrototypeFunctionIndexedSetterBody):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1Body):
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4Body):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod1Body):
(WebCore::jsTestInterfaceConstructorFunctionSupplementalMethod4Body):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:

(WebCore::jsTestNamedAndIndexedSetterWithIdentifierPrototypeFunctionNamedSetterBody):
(WebCore::jsTestNamedAndIndexedSetterWithIdentifierPrototypeFunctionIndexedSetterBody):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:

(WebCore::jsTestNamedDeleterWithIdentifierPrototypeFunctionNamedDeleterBody):

• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:

(WebCore::jsTestNamedSetterWithIdentifierPrototypeFunctionNamedSetterBody):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:

(WebCore::jsTestNamedSetterWithIndexedGetterPrototypeFunctionNamedSetterBody):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:

(WebCore::jsTestNamedSetterWithIndexedGetterAndSetterPrototypeFunctionNamedSetterBody):
(WebCore::jsTestNamedSetterWithIndexedGetterAndSetterPrototypeFunctionIndexedSetter1Body):

• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:

(WebCore::jsTestNamedSetterWithUnforgablePropertiesInstanceFunctionUnforgeableOperationBody):

• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:

(WebCore::jsTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltinsInstanceFunctionUnforgeableOperationBody):

• bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::jsTestNodePrototypeFunctionTestWorkerPromiseBody):
(WebCore::jsTestNodePrototypeFunctionCalculateSecretResultBody):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::callJSTestObj1):
(WebCore::callJSTestObj3):
(WebCore::jsTestObjPrototypeFunctionEnabledAtRuntimeOperation1Body):
(WebCore::jsTestObjPrototypeFunctionEnabledAtRuntimeOperation2Body):
(WebCore::jsTestObjConstructorFunctionEnabledAtRuntimeOperationStaticBody):
(WebCore::jsTestObjPrototypeFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabledBody):
(WebCore::jsTestObjPrototypeFunctionWorldSpecificMethodBody):
(WebCore::jsTestObjPrototypeFunctionCalculateSecretResultBody):
(WebCore::jsTestObjPrototypeFunctionVoidMethodBody):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgsBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithArgTreatingNullAsEmptyStringBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithXPathNSResolverParameterBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithStandaloneEnumArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalEnumArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalEnumArgAndDefaultValueBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithUSVStringArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithNullableUSVStringArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithUSVStringArgTreatingNullAsEmptyStringBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithByteStringArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithNullableByteStringArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithByteStringArgTreatingNullAsEmptyStringBody):
(WebCore::jsTestObjPrototypeFunctionSerializedValueBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithRecordBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithExceptionBody):
(WebCore::jsTestObjPrototypeFunctionAddEventListenerBody):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListenerBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateBody):
(WebCore::jsTestObjPrototypeFunctionWithDocumentArgumentBody):
(WebCore::jsTestObjPrototypeFunctionWithCallerDocumentArgumentBody):
(WebCore::jsTestObjPrototypeFunctionWithCallerWindowArgumentBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArgAndDefaultValueBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgsBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUSVStringBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomStringBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringAndDefaultValueBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomStringAndDefaultValueBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefinedBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomStringIsNullBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsEmptyStringBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUSVStringIsEmptyStringBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomStringIsEmptyStringBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalDoubleIsNaNBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalFloatIsNaNBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalLongLongBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalLongLongIsZeroBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUnsignedLongLongBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUnsignedLongLongIsZeroBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequenceBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequenceIsEmptyBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalBooleanBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalBooleanIsFalseBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAnyBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalObjectBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalNullableWrapperBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalNullableWrapperIsNullBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalXPathNSResolverBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalRecordBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalPromiseBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackFunctionArgBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionAndOptionalArgBody):
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackAndOptionalArgBody):
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackArgBody):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2Body):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod11Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod12Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod13Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter1Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter2Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithDistinguishingUnion1Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithDistinguishingUnion2Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWith2DistinguishingUnions1Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWith2DistinguishingUnions2Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithNonDistinguishingUnion1Body):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithNonDistinguishingUnion2Body):
(WebCore::jsTestObjPrototypeFunctionOverloadWithNullableUnion1Body):
(WebCore::jsTestObjPrototypeFunctionOverloadWithNullableUnion2Body):
(WebCore::jsTestObjPrototypeFunctionOverloadWithOptionalUnion1Body):
(WebCore::jsTestObjPrototypeFunctionOverloadWithOptionalUnion2Body):
(WebCore::jsTestObjPrototypeFunctionOverloadWithNullableNonDistinguishingParameter1Body):
(WebCore::jsTestObjPrototypeFunctionOverloadWithNullableNonDistinguishingParameter2Body):
(WebCore::jsTestObjConstructorFunctionClassMethodBody):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11Body):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12Body):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClampBody):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClampOnOptionalBody):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithEnforceRangeBody):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithEnforceRangeOnOptionalBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequenceBody):
(WebCore::jsTestObjPrototypeFunctionOperationWithOptionalUnionParameterBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequenceBody):
(WebCore::jsTestObjPrototypeFunctionConvert1Body):
(WebCore::jsTestObjPrototypeFunctionConvert2Body):
(WebCore::jsTestObjPrototypeFunctionConvert3Body):
(WebCore::jsTestObjPrototypeFunctionConvert4Body):
(WebCore::jsTestObjPrototypeFunctionOrangeBody):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethodBody):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethodBody):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethodBody):
(WebCore::jsTestObjPrototypeFunctionVariadicUnionMethodBody):
(WebCore::jsTestObjPrototypeFunctionAnyBody):
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionBody):
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithFloatArgumentBody):
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithExceptionBody):
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithOptionalIntArgumentBody):
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction1Body):
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction2Body):
(WebCore::jsTestObjConstructorFunctionTestStaticPromiseFunctionBody):
(WebCore::jsTestObjConstructorFunctionTestStaticPromiseFunctionWithExceptionBody):
(WebCore::jsTestObjPrototypeFunctionConditionalOverload1Body):
(WebCore::jsTestObjPrototypeFunctionConditionalOverload2Body):
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload1Body):
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload2Body):
(WebCore::jsTestObjPrototypeFunctionAttachShadowRootBody):
(WebCore::jsTestObjPrototypeFunctionOperationWithExternalDictionaryParameterBody):
(WebCore::jsTestObjPrototypeFunctionBufferSourceParameterBody):
(WebCore::jsTestObjPrototypeFunctionLegacyCallerNamedBody):
(WebCore::jsTestObjPrototypeFunctionTestReturnValueOptimizationBody):
(WebCore::jsTestObjPrototypeFunctionTestReturnValueOptimizationWithExceptionBody):
(WebCore::jsTestObjPrototypeFunctionConditionallyExposedToWindowFunctionBody):
(WebCore::jsTestObjPrototypeFunctionConditionallyExposedToWorkerFunctionBody):
(WebCore::jsTestObjPrototypeFunctionConditionallyExposedToWindowAndWorkerFunctionBody):

• bindings/scripts/test/JS/JSTestOperationConditional.cpp:

(WebCore::jsTestOperationConditionalPrototypeFunctionNonConditionalOperationBody):
(WebCore::jsTestOperationConditionalPrototypeFunctionConditionalOperationBody):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionFunctionBody):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionFuncBody):
(WebCore::jsTestTypedefsPrototypeFunctionSetShadowBody):
(WebCore::jsTestTypedefsPrototypeFunctionNullableSequenceArgBody):
(WebCore::jsTestTypedefsPrototypeFunctionSequenceOfNullablesArgBody):
(WebCore::jsTestTypedefsPrototypeFunctionNullableSequenceOfNullablesArgBody):
(WebCore::jsTestTypedefsPrototypeFunctionNullableSequenceOfUnionsArgBody):
(WebCore::jsTestTypedefsPrototypeFunctionUnionArgBody):
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClampBody):
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClampInTypedefBody):
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithExceptionBody):

9:54 AM Changeset in webkit [265045] by mark.lam@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Update some JSArrayBufferView comments and add some assertions.
​https://bugs.webkit.org/show_bug.cgi?id=214914

Reviewed by Darin Adler.

• runtime/ArrayBuffer.cpp:

(JSC::ArrayBuffer::createAdopted):

• runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):
(JSC::JSArrayBufferView::finalize):

• runtime/JSArrayBufferView.h:

9:36 AM Changeset in webkit [265044] by Darin Adler

• 55 edits in trunk/Source

Improve range idioms and other changes to prepare the way for more reduction in live range use
​https://bugs.webkit.org/show_bug.cgi?id=214882

Reviewed by Sam Weinig.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::AccessibilityReplacedText::AccessibilityReplacedText): Call the
VisiblePosition versions of start and end instead of converting to Position
and then back to VisiblePosition.
(WebCore::AXObjectCache::rangeMatchesTextNearRange): Simplify with makeSimpleRange.
(WebCore::AXObjectCache::characterOffsetForPoint): Ditto.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions const):
Update idiom for creating VisiblePositionRange since it's just a struct now
without explicit constructors.
(WebCore::AccessibilityObject::positionOfLeftWord const): Ditto.
(WebCore::AccessibilityObject::positionOfRightWord const): Ditto.
(WebCore::AccessibilityObject::leftLineVisiblePositionRange const): Ditto.
(WebCore::AccessibilityObject::rightLineVisiblePositionRange const): Ditto.
(WebCore::AccessibilityObject::sentenceForPosition const): Ditto.
(WebCore::AccessibilityObject::paragraphForPosition const): Ditto.
(WebCore::AccessibilityObject::styleRangeForPosition const): Ditto.
(WebCore::AccessibilityObject::visiblePositionRangeForRange const): Ditto.
(WebCore::AccessibilityObject::lineRangeForPosition const): Ditto.
(WebCore::AccessibilityObject::stringForVisiblePositionRange): Ditto.
(WebCore::AccessibilityObject::lengthForVisiblePositionRange const): Ditto.
(WebCore::AccessibilityObject::nextSentenceEndPosition const): Ditto.
(WebCore::AccessibilityObject::previousSentenceStartPosition const): Ditto.

• accessibility/AccessibilityObjectInterface.h: Moved VisiblePositionRange

to VisiblePosition.h for wider use. Also removed constructors.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement const): Simplify with
makeSimpleRange.
(WebCore::AccessibilityRenderObject::linkClickPoint): Ditto.
(WebCore::AccessibilityRenderObject::clickPoint): Ditto.
(WebCore::AccessibilityRenderObject::visiblePositionRange const): Updated
for removal of VisiblePositionRange constructor.
(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine const):
Remove unnecessary explicit conversion to VisiblePositionRange.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(visiblePositionRangeForTextMarkerRange): Added, replacing separate functions
for start and end.
(-[WebAccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
Simplify using visiblePositionRangeForTextMarkerRange.

• dom/Document.cpp: Added include of "Range.h", may not be needed right now,

but highly likely to be needed after future live range work.

• dom/Node.cpp: Removed include of "Range.h".

• dom/Position.h: Added PositionRange. This will be a more efficient

alternative to SimpleRange that can avoid computing node offets for positions
before and after anchor nodes in some cases. Not used yet.

• dom/RadioButtonGroups.cpp: Removed include of "Range.h".

• dom/Range.h: Export makeSimpleRange overload now used outside WebCore.

• dom/SimpleRange.cpp:

(WebCore::makeSimpleRange): Added overloads for ranges that consist of just
a single boundary point, so the argument does not have to be passed twice.
(WebCore::commonInclusiveAncestor): Added overload so caller can just pass
a simple range rather than passing two boundary point container nodes.

• dom/SimpleRange.h: Added makeSimpleRange overloads that take one or more

argument that can be passed to makeBoundaryPoint or actual boundary points.

• dom/StaticRange.cpp: Removed include of "Range.h".

• editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
Simplify with makeSimpleRange.
(WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
Ditto.

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle): Ditto.

• editing/CompositeEditCommand.cpp:

(WebCore::stringForVisiblePositionIndexRange): Updated for removal of
VisiblePositionRange constructor; also use move to reduce reference count
churn a tiny bit.
(WebCore::CompositeEditCommand::moveParagraphs): Simplify with makeSimpleRange.

• editing/DeleteSelectionCommand.cpp: Added include of "Range.h", may not be needed now,

but highly likely to be needed after future live range work.

• editing/Editing.cpp:

(WebCore::indexForVisiblePosition): Simplify using makeSimpleRange and
makeBoundaryPointBeforeNodeContents.

• editing/Editor.cpp:

(WebCore::Editor::selectedText const): Simplify using VisibleSelection::firstRange.
(WebCore::extendSelection): Simplify using makeSimpleRange.
(WebCore::Editor::contextRangeForCandidateRequest const): Ditto.
(WebCore::Editor::adjustedSelectionRange): Simplify with the new overload
of commonInclusiveAncestor.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::wordOffsetInRange const): Deleted. Moved the code
into the iOS-specific part of WebKitLegacy WebFrame.
(WebCore::FrameSelection::spaceFollowsWordInRange const): Deleted. Moved the
code into the iOS-specific part of WebKitLegacy WebFrame.
(WebCore::FrameSelection::selectionAtSentenceStart const): Merged in with
actualSelectionAtSentenceStart.
(WebCore::FrameSelection::actualSelectionAtSentenceStart const): Deleted.

• editing/FrameSelection.h: Updated for the above deletion.

• editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::offsetTo const): Simplify with makeSimpleRange.

• editing/TextManipulationController.cpp:

(WebCore::ParagraphContentIterator::ParagraphContentIterator): Simplify with
makeSimpleRange.

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::postTextStateChangeNotificationForDeletion): Pass
visibleStart/End instead of converting to Position and back to VisiblePosition.

• editing/VisiblePosition.cpp:

(WebCore::makeSimpleRange): Added. Converts a VisiblePositionRange into
a SimpleRange.

• editing/VisiblePosition.h: Moved VisiblePositionRange here.

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::firstRange const): Simplify using makeSimpleRange.
(WebCore::VisibleSelection::toNormalizedRange const): Ditto.
(WebCore::makeSearchRange): Deleted. This was confusingly named given that
it was only used in appendTrailingWhitespace.
(WebCore::VisibleSelection::appendTrailingWhitespace): Merged makeSearchRange
in here and simplified using makeSimpleRange.

• editing/VisibleSelection.h: Added conversion to VisiblePositionRange.

Previously this was implemented as a constructor for VisiblePositionRange,
but that was a layering inversion since this is built on top of VisiblePosition.

• editing/VisibleUnits.cpp:

(WebCore::distanceBetweenPositions): Simplified using makeSimpleRange.
(WebCore::charactersAroundPosition): Ditto.
(WebCore::wordRangeFromPosition): Removed an unhelpful comment.
(WebCore::closestWordBoundaryForPosition): Ditto.

• editing/cocoa/DataDetection.mm:

(WebCore::detectItem): Simplify using makeSimpleRange.
(WebCore::searchForLinkRemovingExistingDDLinks): Removed out argument
about modifying the DOM. This was used to work around a problem caused by
using live ranges. The problem no longer exists because the code does not
use live ranges any more.
(WebCore::DataDetection::detectContentInRange): Removed the workaround.

• editing/cocoa/DictionaryLookup.mm:

(WebCore::DictionaryLookup::rangeForSelection): Simplify using makeSimpleRange.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Ditto.

• editing/cocoa/WebContentReaderCocoa.mm: Added include of "Range.h", may

not be needed now, but highly likely to be needed after future live range work.

• editing/ios/DictationCommandIOS.cpp: Removed include of "Range.h".

• editing/mac/DictionaryLookupLegacy.mm:

(WebCore::DictionaryLookup::rangeForSelection): Simplify using makeSimpleRange.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Ditto.

• editing/mac/EditorMac.mm: Removed include of "Range.h".

• editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::renderedTextRespectingRange): Simplify
using makeSimpleRange.

• editing/win/EditorWin.cpp: Added include of "Range.h", may not be needed now,

but highly likely to be needed after future live range work.

• html/shadow/mac/ImageControlsButtonElementMac.cpp: Removed include of "Range.h".

• page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange): Call setSelection instead of moveTo.
No need to have two functions that do the same thing.

• page/EventHandler.cpp:

(WebCore::textDistance): Simplify using makeSimpleRange.

• page/Frame.cpp:

(WebCore::Frame::rangeForPoint): Simplify using makeSimpleRange.

• page/TextIndicator.cpp:

(WebCore::estimatedBackgroundColorForRange): Simplify using the
commonInclusiveAncestor overload that takes a range.
(WebCore::initializeIndicator): Ditto.

Source/WebKit:

• WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleGetRenderRect): Emptied out this unused function and added
ASSERT_NOT_REACHED. Later, we can delete this once we deal with any link-time
dependencies. I believe Safari may link with this but never calls it.
(WKBundleNodeHandleCopyVisibleRange): Ditto.
(WKBundleNodeHandleSetHTMLInputElementSpellcheckEnabled): Ditto.
(WKBundleNodeHandleGetHTMLInputElementAutoFilled): Ditto.
(WKBundleNodeHandleGetHTMLInputElementAutoFillButtonEnabled): Ditto.
(WKBundleNodeHandleGetHTMLInputElementAutoFillAvailable): Ditto.
(WKBundleNodeHandleGetHTMLInputElementAutoFillButtonBounds): Ditto.
(WKBundleNodeHandleCopyHTMLTableCellElementCellAbove): Ditto.
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame): Ditto.
(WKBundleNodeHandleGetHTMLInputElementAutofilled): Ditto.
(WKBundleNodeHandleSetHTMLInputElementAutofilled): Ditto.
(WKBundleNodeHandleSetHTMLInputElementAutoFillButtonEnabled): Ditto.

• WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):
Simplify with makeSimpleRange.

• WebProcess/WebPage/glib/WebPageGLib.cpp: Added include of "Range.h",

may not be needed right now, but highly likely to be needed after
future live range work.

• WebProcess/WebPage/ios/WebPageIOS.mm: Ditto.

(WebKit::WebPage::selectWithGesture): Simplify with makeSimpleRange.
(WebKit::WebPage::requestDocumentEditingContext): Ditto.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::attributedSubstringForCharacterRangeAsync):
Use auto for range to prepare for possible change of type from live
range to SimpleRange.

Source/WebKitLegacy:

• WebKitLegacy.xcodeproj/project.pbxproj: Removed singly-building

DOMUIKitExtensions.mm, which also is built in a unified source file.
We don't need to build it twice.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.mm:

(insertionPointFromCurrentSelection): Simplify with makeSimpleRange.
(WebEditorClient::requestCandidatesForSelection): Ditto.

• WebView/WebFrame.mm:

(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]): Get rid of
unnecessary construction of a range just to get an end point.
(-[WebFrame wordOffsetInRange:]): Moved logic here from VisibleSelection.
(-[WebFrame spaceFollowsWordInRange:]): Ditto.

9:02 AM Changeset in webkit [265043] by Noam Rosenthal

• 2 edits in trunk/Source/WebKit

Enable paint timing by default
​https://bugs.webkit.org/show_bug.cgi?id=211736

Reviewed by Simon Fraser.

• Shared/WebPreferences.yaml:

PaintTimingEnabled default to true.

8:33 AM Changeset in webkit [265042] by Adrian Perez de Castro

• 1 copy in releases/WPE WebKit/webkit-2.29.2

WPE WebKit 2.29.2

8:33 AM Changeset in webkit [265041] by Adrian Perez de Castro

• 4 edits in trunk

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.29.2 release

.:

• Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

• wpe/NEWS: Add release notes for 2.29.2.

7:51 AM Changeset in webkit [265040] by Jonathan Bedard

• 2 edits in trunk/Tools

[build.webkit.org] Add Big Sur builder (Follow-up Fix)
​https://bugs.webkit.org/show_bug.cgi?id=214879
<rdar://problem/66221071>

Reviewed by Aakash Jain.

• BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build): Add Big Sur.

6:38 AM Changeset in webkit [265039] by Adrian Perez de Castro

• 9 edits in trunk/Source/WebCore

Non-unified build fixes, late July 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=214918

Unreviewed build fix.

No new tests needed.

• Modules/webaudio/WebKitOscillatorNode.h: Add missing WebKitAudioContext.h header to make

the constructor of WebKitOscillatorNode that WebKitAudioContext inherits from the base
context, otherwise the compiler does not know which base class constructor to invoke.

• bindings/js/JSDOMConvertDate.h: Add missing JSGlobalObject.h header.
• bindings/js/ReadableStreamDefaultController.cpp: Sprinkle missing JSC:: namespace

prefixes where needed.
(WebCore::invokeReadableStreamDefaultControllerFunction):
(WebCore::ReadableStreamDefaultController::close):
(WebCore::ReadableStreamDefaultController::error):
(WebCore::ReadableStreamDefaultController::enqueue):

• editing/SpellChecker.cpp: Add missing inclusion of TextIterator.h.
• editing/SpellChecker.h: Add missing inclusion of SimpleRange.h.
• editing/TextCheckingHelper.h: Forward declare Frame and VisibleSelection.
• editing/TextIterator.cpp: Add missing inclusion of Range.h.
• workers/WorkerScriptLoader.h: Add missing inclusion of CertificateInfo.h.

5:35 AM Changeset in webkit [265038] by commit-queue@webkit.org

• 29 edits
  4 deletes in trunk

Unreviewed, reverting r265002.
​https://bugs.webkit.org/show_bug.cgi?id=214919

Broke imported/w3c/web-platform-tests/webaudio/the-audio-api
/the-scriptprocessornode-interface/simple-input-output.html

Reverted changeset:

"Added constructor methods to ChannelMergerNode,
ChannelSplitterNode"
​https://bugs.webkit.org/show_bug.cgi?id=214851
​https://trac.webkit.org/changeset/265002

4:55 AM Changeset in webkit [265037] by commit-queue@webkit.org

• 13 edits
  2 deletes in trunk

Unreviewed, reverting r265018.
​https://bugs.webkit.org/show_bug.cgi?id=214917

Broke various ios-wk2 tests.

Reverted changeset:

"Migrate App-Bound Domains code from WebKit Additions"
​https://bugs.webkit.org/show_bug.cgi?id=214889
​https://trac.webkit.org/changeset/265018

3:32 AM Changeset in webkit [265036] by Paulo Matos

• 15 edits in trunk

for..of intrinsics implementation for 32bits
​https://bugs.webkit.org/show_bug.cgi?id=214737

Reviewed by Yusuke Suzuki.

Joint work with Caio Lima <Caio Lima>.
JSTests:

Unskip tests previously skipped due to missing for..of intrinsics.

• stress/for-of-array-different-globals.js:
• stress/for-of-iterator-open-osr-at-inlined-return-non-object.js:
• stress/for-of-iterator-open-osr-at-iterator-set-local.js:
• stress/for-of-iterator-open-return-non-object.js:

Source/JavaScriptCore:

Implements for..of intrinsics for 32bits.
Adds or8 instruction to ARMv7 and MIPS Macro Assembler.
Adds intrinsic operations to LLInt and Baseline for 32bits.
Fixes DFG OSR Exit bug, where checkpoint temporary value is
incorrectly recreated for Baseline.
Refactors code in DFG OSR Exit to be easier to modify and
maintain by separating the switch cases for 32 and 64bits.

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::or8): Adds or8(TrustedImm, AbsoluteAddress)
(JSC::MacroAssemblerARMv7::or32):
(JSC::MacroAssemblerARMv7::store8):

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::or8): Adds or8(TrustedImm, AbsoluteAddress)
(JSC::MacroAssemblerMIPS::store8):

• assembler/testmasm.cpp:

(JSC::testOrImmMem): Tests or8

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEnumeration):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit): Fixes DFG OSR Exit bug, where checkpoint temporary value is
incorrectly recreated for Baseline. Refactors code in DFG OSR Exit to be easier to modify and
maintain by separating the switch cases for 32 and 64bits.

• jit/JIT.h:
• jit/JITCall32_64.cpp:

(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileSetupFrame):
(JSC::JIT::compileOpCall):
(JSC::JIT::emit_op_iterator_open):
(JSC::JIT::emitSlow_op_iterator_open):
(JSC::JIT::emit_op_iterator_next):
(JSC::JIT::emitSlow_op_iterator_next):

• jit/JITInlines.h:

(JSC::JIT::emitJumpSlowCaseIfNotJSCell):

• llint/LowLevelInterpreter32_64.asm:

1:45 AM Changeset in webkit [265035] by youenn@apple.com

• 4 edits in trunk

TestWebKitAPI.WebKit.QuotaDelegate flaky times out
​https://bugs.webkit.org/show_bug.cgi?id=214842

Reviewed by Geoffrey Garen.

Source/WebKit:

Add some release logging.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::requestStorageSpace):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:

In case the page is not visible, quota increase delegate will be denied.
Delay the cache storage hence the quota increase until the page is visible.

1:32 AM Changeset in webkit [265034] by ysuzuki@apple.com

• 5 edits in trunk

[JSC] Reflect object should have toStringTag with "Reflect"
​https://bugs.webkit.org/show_bug.cgi?id=214909

Reviewed by Mark Lam.

JSTests:

• stress/reflect.js:
• test262/expectations.yaml:

Source/JavaScriptCore:

We call JSC_TO_STRING_TAG_WITHOUT_TRANSITION in ReflectObject to set "Reflect" @@toStringTag, which fixes one test262 failure.

• runtime/ReflectObject.cpp:

(JSC::ReflectObject::finishCreation):

1:16 AM Changeset in webkit [265033] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.29.4

WebKitGTK 2.29.4

1:15 AM Changeset in webkit [265032] by Carlos Garcia Campos

• 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.4 release

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.29.4.

Jul 28, 2020:

11:47 PM Changeset in webkit [265031] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

[WinCairo] REGRESSION(r264986) Unreviewed crash fix
​https://bugs.webkit.org/show_bug.cgi?id=201507

• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::createWindowContext): Initialize a variable 'surface' as EGL_NO_SURFACE for WinCairo.

11:18 PM Changeset in webkit [265030] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Add hasCustomGetterSetterProperties to canAccessPropertiesQuicklyForEnumeration
​https://bugs.webkit.org/show_bug.cgi?id=214908
<rdar://problem/65883816>

Reviewed by Mark Lam.

canAccessPropertiesQuicklyForEnumeration should filter out hasCustomGetterSetterProperties too.

• runtime/Structure.cpp:

(JSC::Structure::canAccessPropertiesQuicklyForEnumeration const):

10:37 PM Changeset in webkit [265029] by Ryan Haddad

• 2 edits in trunk/LayoutTests

REGRESSION (r264930): [ iOS debug wk2 ] webrtc/video.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=214888

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations: Remove test expectation

since the change that caused the failure was reverted.

10:18 PM Changeset in webkit [265028] by Chris Dumez

• 15 edits
  2 copies
  2 adds in trunk

Source/WebCore:
Move non standard OscillatorNode API to new webKitOscillatorNode interface
​https://bugs.webkit.org/show_bug.cgi?id=214902

Reviewed by Darin Adler.

Move non standard OscillatorNode API to new webKitOscillatorNode interface:
​https://webaudio.github.io/web-audio-api/#oscillatornode

Namely, the playbackState attribute and its associated constants are now exposed
on the prefixed webKitOscillatorNode interface instead of the unprefixed
OscillatorNode. This way, this API is still available to apps using the prefixed
API but we do not support this legacy API if the app is using the modern unprefixed
API.

Test: webaudio/oscillatornode-legacy-api.html

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::create):
(WebCore::OscillatorNode::setType):
(WebCore::OscillatorNode::setPeriodicWave):

• Modules/webaudio/OscillatorNode.h:
• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/WebKitAudioContext.cpp:

(WebCore::WebKitAudioContext::createWebKitOscillator):

• Modules/webaudio/WebKitAudioContext.h:
• Modules/webaudio/WebKitAudioContext.idl:
• Modules/webaudio/WebKitOscillatorNode.h: Copied from Source/WebCore/Modules/webaudio/OscillatorNode.idl.

(WebCore::WebKitOscillatorNode::create):
(WebCore::WebKitOscillatorNode::setWebKitPeriodicWave):
(WebCore::WebKitOscillatorNode::WebKitOscillatorNode):

• Modules/webaudio/WebKitOscillatorNode.idl: Copied from Source/WebCore/Modules/webaudio/OscillatorNode.idl.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:

LayoutTests:
Move non standard OscillatorNode API to new WebKitOscillatorNode interface
​https://bugs.webkit.org/show_bug.cgi?id=214902

Reviewed by Darin Adler.

Add layout test coverage.

• webaudio/oscillatornode-legacy-api-expected.txt: Added.
• webaudio/oscillatornode-legacy-api.html: Added.

9:31 PM Changeset in webkit [265027] by BJ Burg

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r255396): Audit: button to exit edit mode in main content area is missing border
​https://bugs.webkit.org/show_bug.cgi?id=214898
<rdar://problem/66238391>

Reviewed by Devin Rousso.

• UserInterface/Base/Main.js: codify that this function only accepts ButtonNavigationItems.

Future developers, you'll need to adjust the CSS for non-button navigation items to work out.

• UserInterface/Views/Main.css:

(.navigation-item-help > .navigation-bar > .item.button):
(.navigation-item-help > .navigation-bar > .item.button:not(.text-only)):
(.navigation-item-help > .navigation-bar > .item.button.text-only):
(.navigation-item-help > .navigation-bar > .item): Deleted.
(.navigation-item-help > .navigation-bar > .item:not(.text-only)): Deleted.
(.navigation-item-help > .navigation-bar > .item.text-only): Deleted.
Split out the rules for text-only buttons. The regressing change added more specificity
for the text + image case which made the border transparent and removed extra padding.
Also add .button since we only expect buttons to be used in this context.

6:58 PM Changeset in webkit [265026] by Karl Rackler

• 5 edits in trunk

Unreviewed, reverting r264930.

Reverting Pre-Submission Testing

Reverted changeset:

"scaleResolutionDownBy has no effect on RTCRtpSender"
​https://bugs.webkit.org/show_bug.cgi?id=214783
​https://trac.webkit.org/changeset/264930

6:30 PM Changeset in webkit [265025] by dino@apple.com

• 3 edits in trunk/Tools

run-minibrowser doesn't respect webkit configuration
​https://bugs.webkit.org/show_bug.cgi?id=214857
<rdar://problem/66187636>

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/minibrowser/run_webkit_app.py:

(main): Don't force a Release configuration if none was given.

• Scripts/webkitpy/port/config.py:

(Config.flag_for_configuration): Look at the default configuration if we didn't
pass one in.

4:59 PM Changeset in webkit [265024] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Unreviewed test gardening, remove duplicate TestExpectations entry.

• platform/win/TestExpectations:

4:56 PM Changeset in webkit [265023] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/ANGLE

Pause during ANGLE roll script after rebasing and before deleting temporary Git repo
​https://bugs.webkit.org/show_bug.cgi?id=212717

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-07-28
Reviewed by Dean Jackson.

Give the user the opportunity to manually examine the changes
relative to upstream ANGLE, and to undo any accidental or
undesired ones, before finishing the roll.

• update-angle.sh:

4:49 PM Changeset in webkit [265022] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[ Win10 ] http/tests/cookies/document-cookie-multiple-cookies.html is failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=214880

Unreviewed test gardening.

• platform/win/TestExpectations:

4:41 PM Changeset in webkit [265021] by Karl Rackler

• 2 edits in trunk/LayoutTests

[ Win10 ] http/tests/cookies/document-cookie-multiple-cookies.html is failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=214880

Unreviewed test gardening.

• platform/win/TestExpectations:

4:41 PM Changeset in webkit [265020] by Oriol Brufau

• 4 edits
  4 adds in trunk

[css-grid] Fix 'align-content' in grid containers with small content area
​https://bugs.webkit.org/show_bug.cgi?id=214370

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Create a WPT test and import another one.

• web-platform-tests/css/css-grid/alignment/grid-place-content-001-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-place-content-001.html: Added.
• web-platform-tests/css/css-sizing/available-height-for-replaced-content-001-expected.txt: Added.
• web-platform-tests/css/css-sizing/available-height-for-replaced-content-001.html: Added.
• web-platform-tests/css/css-sizing/w3c-import.log:

Source/WebCore:

In order to properly obey 'align-content', grid containers need to know
the available grid space for the block axis. But there was a bug when
the sum of border and padding sizes in the block axis were bigger than
the content area. Then the available space was considered to be that sum.

This patch fixes it so that the available grid space is the size of its
content box when that is definite.

Tests: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-place-content-001.html

imported/w3c/web-platform-tests/css/css-sizing/available-height-for-replaced-content-001.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalHeight const):

4:21 PM Changeset in webkit [265019] by Peng Liu

• 4 edits in trunk/Source/WebCore

Clean up PlaybackSessionInterface[Mac|AVKit]
​https://bugs.webkit.org/show_bug.cgi?id=214895

Reviewed by Eric Carlson.

No new tests, no functional change.

• platform/ios/PlaybackSessionInterfaceAVKit.h:
• platform/ios/PlaybackSessionInterfaceAVKit.mm:

(WebCore::PlaybackSessionInterfaceAVKit::PlaybackSessionInterfaceAVKit):
(WebCore::PlaybackSessionInterfaceAVKit::playbackSessionModel const):
Remove unnecessary WEBCORE_EXPORT.
Include the correct header for Ref.
Replace "protected" with "private".
Use WeakPtr of PlaybackSessionModel instead of a raw pointer.

• platform/mac/PlaybackSessionInterfaceMac.h:

Add "final" to ensureControlsManager().
Some small cleanup.

4:14 PM Changeset in webkit [265018] by Kate Cheney

• 13 edits
  2 adds in trunk

Migrate App-Bound Domains code from WebKit Additions
​https://bugs.webkit.org/show_bug.cgi?id=214889
<rdar://problem/66075857>

Reviewed by Brent Fulgham.

Source/WebKit:

No new tests, this is just code migration and will be tested
by existing App-Bound Domains tests.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::activateSessionCleanup):
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):

• Shared/Cocoa/DefaultWebBrowserChecks.h: Added.
• Shared/Cocoa/DefaultWebBrowserChecks.mm: Added.

Holds all functions related to full browser checks and
App-Bound Domains.

(WebKit::shouldBeTreatedAsFullBrowser):
(WebKit::getAppBoundDomainsTesting):
These functions allow us to treat our test runners as full browsers
while triggering non-browser mode for testing other App-Bound Domains
functionality.

(WebKit::isInWebKitChildProcess):
(WebKit::hasRequestedCrossWebsiteTrackingPermission):
(WebKit::determineITPStateInternal):
(WebKit::determineITPState):
(WebKit::doesAppHaveITPEnabled):
(WebKit::doesParentProcessHaveITPEnabled):
(WebKit::hasProhibitedUsageStrings):
(WebKit::isParentProcessAFullWebBrowser):
(WebKit::isFullWebBrowser):

• UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::filterAppBoundCookies):

• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::PageConfiguration):
(): Deleted.

• UIProcess/WebPageProxy.cpp:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::createNewWebProcess):

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::addTestDomains const):
(WebKit::WebsiteDataStore::ensureAppBoundDomains const):

• UIProcess/WebsiteData/WebsiteDataStore.h:
• WebKit.xcodeproj/project.pbxproj:

Tools:

Replace WebKit Additions macros with code to set a different bundle
identifier indicating that we want to run an App-Bound Domains test.

Remove #if USE(APPLE_INTERNAL_SDK) check so we run these tests on EWS.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(cleanUpInAppBrowserPrivacyTestSettings):
(initializeInAppBrowserPrivacyTestSettings):

LayoutTests:

• platform/ios-wk2/TestExpectations:

These tests are now expected to pass.

4:04 PM Changeset in webkit [265017] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews] Add macOS Big Sur support in PrintConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=214903

Reviewed by Darin Adler.

• BuildSlaveSupport/ews-build/steps.py:

(PrintConfiguration.convert_build_to_os_name):

3:48 PM Changeset in webkit [265016] by Jonathan Bedard

• 4 edits in trunk/Tools

[build.webkit.org] Add Big Sur builder
​https://bugs.webkit.org/show_bug.cgi?id=214879
<rdar://problem/66221071>

Reviewed by Aakash Jain.

• BuildSlaveSupport/build.webkit.org-config/config.json: Add Big Sur release builder.
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): Add new builder to bot watcher's dashboard.

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add BigSur.

3:43 PM Changeset in webkit [265015] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION (r264522): [ macOS wk1 ] imported/w3c/web-platform-tests/css/cssom/stylesheet-same-origin.sub.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=214682

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

3:24 PM Changeset in webkit [265014] by Chris Dumez

• 7 edits in trunk

[EventSource] WebKit fails to UTF-8 encode the Last-Event-ID HTTP header value
​https://bugs.webkit.org/show_bug.cgi?id=214860

Reviewed by Alex Christensen and Darin Adler.

LayoutTests/imported/w3c:

Rebaseline a couple of web-platform-tests that are now passing.

• web-platform-tests/eventsource/format-field-id-2-expected.txt:
• web-platform-tests/eventsource/format-field-id-expected.txt:

Source/WebCore:

WebKit fails to UTF-8 encode the Last-Event-ID HTTP header value for EventSource.

The specification is here:
​https://html.spec.whatwg.org/multipage/server-sent-events.html#reestablish-the-connection (step 5.3.)

This is causing us to fail a couple of EventSource web-platform-tests which are passing in both Chrome & Firefox.

No new tests, rebaselined existing tests.

• platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):

• platform/network/cf/ResourceRequestCFNet.h:

(WebCore::httpHeaderValueUsingSuitableEncoding):

• platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

3:09 PM Changeset in webkit [265013] by Jonathan Bedard

• 3 edits
  2 adds in trunk/Tools

[Big Sur] Add Seed 3 to bot watcher's dashboard\nhttps://bugs.webkit.org/show_bug.cgi?id=214863\n<rdar://problem/66198642>\n\nReviewed by Darin Adler.\n\n* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/BigSur.png: Added.\n* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​BigSur@2x.png: Added.\n* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Add Big Sur.\n* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Ditto.\n

3:07 PM Changeset in webkit [265012] by Alan Coon

• 1 copy in tags/Safari-610.1.23.1.3

Tag Safari-610.1.23.1.3.

3:06 PM Changeset in webkit [265011] by Alan Coon

• 1 copy in tags/Safari-610.1.23.0.2

Tag Safari-610.1.23.0.2.

2:43 PM Changeset in webkit [265010] by Jonathan Bedard

• 2 edits in trunk/Source/WebCore/PAL

[Big Sur] Wrap SPI in feature guards (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=214844
<rdar://problem/66178527>

Unreviewed build fix.

• pal/spi/mac/NSImageSPI.h: Guard SPI with NS_ASSUME_NONNULL.

2:38 PM Changeset in webkit [265009] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Web Share API Level 2: Can only perform one share action per share sheet invocation
​https://bugs.webkit.org/show_bug.cgi?id=214894

Reviewed by Wenson Hsieh.

No new tests; our WKShareSheet testing mechanism intentionally bypasses
actually presenting the share sheet, which is the only way to test this.

WKShareSheet assumes that UIActivityViewController's completionWithItemsHandler
is only called once, when the share sheet is dismissed, and uses it to
clean up the temporary file written to disk, and send the success state
to the API.

However, it is actually called per share action, of which an arbitrary number
can be performed per UIActivityViewController invocation.

Defer cleanup until the share sheet is actually dismissed (which we observe
using UIAdaptivePresentationControllerDelegate's -presentationControllerDidDismiss: callback),
and respond to the Web Share API with success if *any* attempted share action
succeeded.

• UIProcess/Cocoa/WKShareSheet.mm:

(-[WKShareSheet presentWithParameters:inRect:completionHandler:]):
(-[WKShareSheet presentWithShareDataArray:inRect:]):
(-[WKShareSheet sharingServicePicker:didChooseSharingService:]):
(-[WKShareSheet sharingService:didFailToShareItems:error:]):
(-[WKShareSheet sharingService:didShareItems:]):
(-[WKShareSheet presentationControllerDidDismiss:]):
(-[WKShareSheet dismiss]):
Fold dispatchDidDismiss and _didCompleteWithSuccess into -dismiss,
so we only have one "dismiss if needed and also do the requisite cleanup"
path. -dismiss should only be called when it is no longer possible to do
additional sharing actions for the current share sheet invocation.

(-[WKShareSheet _didCompleteWithSuccess:]): Deleted.
(-[WKShareSheet dispatchDidDismiss]): Deleted.

2:34 PM Changeset in webkit [265008] by BJ Burg

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r262716) Web Inspector: start button is misaligned in Audit content view
​https://bugs.webkit.org/show_bug.cgi?id=214891

Reviewed by Devin Rousso.

In r262716, a rendering defect related to flexbox was fixed. Web Inspector
layout inadvertently relied on the defect. Now that it's fixed, a CSS rule is
pushing the outline for navigation help buttons out of vertical alignment
with surrounding textt.

• UserInterface/Views/Main.css:

(.navigation-item-help): Remove line-height. It was previously ignored
due to a layout bug, and now its presence messes up vertical alignment.

2:20 PM Changeset in webkit [265007] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[ Mac ] webgl/2.0.0/ tests failing after r264997
​https://bugs.webkit.org/show_bug.cgi?id=214893

Unreviewed test gardening.

Mark webgl/2.0.0/conformance/uniforms/gl-uniform-arrays.html slow
in Debug mode.

Incorporate upstream fix to
webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer.html
from ​https://github.com/KhronosGroup/WebGL/pull/3132 .

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-07-28

• TestExpectations:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/clear-srgb-color-buffer.html:

2:07 PM Changeset in webkit [265006] by Alan Bujtas

• 5 edits
  1 add
  1 delete in trunk/LayoutTests

Regression (r264960): [mac-wk1] fast/dynamic/size-to-content-autosize-with-percent-document-height.html is consistently failing
​https://bugs.webkit.org/show_bug.cgi?id=214885
<rdar://problem/66218218>

Unreviewed.

Make the autosizing test case work with WK1.

• fast/dynamic/size-to-content-autosize-with-percent-document-height-expected.html: Removed.
• fast/dynamic/size-to-content-autosize-with-percent-document-height-expected.txt: Added.
• fast/dynamic/size-to-content-autosize-with-percent-document-height.html:
• platform/glib/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac-wk1/TestExpectations:

2:04 PM Changeset in webkit [265005] by youenn@apple.com

• 2 edits
  4 adds in trunk/LayoutTests

Add WebRTC tests exercising H264 with various resolutions and bitrates.
​https://bugs.webkit.org/show_bug.cgi?id=214867

Reviewed by Eric Carlson.

Add additional tests to better cover underlying H264 codecs.

• TestExpectations: Mark tests as slow.
• webrtc/h264-baseline-expected.txt: Added.
• webrtc/h264-baseline.html: Added.
• webrtc/h264-high-expected.txt: Added.
• webrtc/h264-high.html: Added.

1:29 PM Changeset in webkit [265004] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[WebGL2] Enable more multiple render target layout tests
​https://bugs.webkit.org/show_bug.cgi?id=214780

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-07-28
Reviewed by Dean Jackson.

Re-enable two WebGL 2.0 layout tests that are now passing after
the fix for Bug 211156.

• TestExpectations:
• webgl/2.0.0/conformance2/rendering/clear-func-buffer-type-match-expected.txt:

1:22 PM Changeset in webkit [265003] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

[WinCairo] ANGLE D3D renderer can crash when PlatformDisplayWin is destructed in IPC thread
​https://bugs.webkit.org/show_bug.cgi?id=214241

Reviewed by Don Olmstead.

Web process calls _exit() in IPC thread when the IPC connection is
closed. PlatformDisplay::sharedDisplay has a static variable of
std::unique_ptr<PlatformDisplay> to ensure it will be destructed
on the process termination. This rarely causes crashes in ANGLE
because ANGLE D3D renderer isn't thread-safe at the moment.

• platform/graphics/PlatformDisplay.cpp:

(WebCore::PlatformDisplay::sharedDisplay): Don't destruct
PlatformDisplay for PLATFORM(WIN). Use unique_ptr::release to leak it.

1:14 PM Changeset in webkit [265002] by commit-queue@webkit.org

• 29 edits
  4 adds in trunk

Added constructor methods to ChannelMergerNode, ChannelSplitterNode
​https://bugs.webkit.org/show_bug.cgi?id=214851

Patch by Clark Wang <​clark_wang@apple.com> on 2020-07-28
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Re-baselined existing tests that now pass, or fail further along.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/simple-input-output.https-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/active-processing.https-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/ctor-channelmerger-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelsplitternode-interface/audiochannelsplitter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelsplitternode-interface/ctor-channelsplitter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:

Source/WebCore:

Added constructors for ChannelMergerNode, ChannelSplitterNode according to spec:
​https://www.w3.org/TR/webaudio/#ChannelMergerNode-constructors. Added new files
for ChannelMergerOptions and ChannelSplitterOptions.

Re-baselined existing tests that now pass, or fail due to a different interface.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/webaudio/AudioNode.h:
• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createChannelSplitter):
(WebCore::BaseAudioContext::createChannelMerger):

• Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::create):
(WebCore::ChannelMergerNode::setChannelCount):
(WebCore::ChannelMergerNode::setChannelCountMode):

• Modules/webaudio/ChannelMergerNode.h:
• Modules/webaudio/ChannelMergerNode.idl:
• Modules/webaudio/ChannelMergerOptions.h: Added.
• Modules/webaudio/ChannelMergerOptions.idl: Added.
• Modules/webaudio/ChannelSplitterNode.cpp:

(WebCore::ChannelSplitterNode::create):
(WebCore::ChannelSplitterNode::setChannelCount):
(WebCore::ChannelSplitterNode::setChannelCountMode):
(WebCore::ChannelSplitterNode::setChannelInterpretation):

• Modules/webaudio/ChannelSplitterNode.h:
• Modules/webaudio/ChannelSplitterNode.idl:
• Modules/webaudio/ChannelSplitterOptions.h: Added.
• Modules/webaudio/ChannelSplitterOptions.idl: Added.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

1:03 PM Changeset in webkit [265001] by commit-queue@webkit.org

• 14 edits
  6 adds in trunk

PerformanceObserver should work with 'type' and not just entryTypes
​https://bugs.webkit.org/show_bug.cgi?id=209216

Patch by Rob Buis <​rbuis@igalia.com> on 2020-07-28
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Add po-observe-type.any.html and po-observe-type.any.worker.html tests and
update improved test expectations.

• web-platform-tests/performance-timeline/performanceobservers.js: Added.

(findMatch):
(checkEntries):
(wait):
(checkSorted):

• web-platform-tests/performance-timeline/po-observe-type.any-expected.txt: Added.
• web-platform-tests/performance-timeline/po-observe-type.any.html: Added.
• web-platform-tests/performance-timeline/po-observe-type.any.js: Added.

(test):
(async_test):

• web-platform-tests/performance-timeline/po-observe-type.any.worker-expected.txt: Added.
• web-platform-tests/performance-timeline/po-observe-type.any.worker.html: Added.
• web-platform-tests/resource-timing/buffered-flag.any-expected.txt:
• web-platform-tests/resource-timing/buffered-flag.any.worker-expected.txt:
• web-platform-tests/resource-timing/object-not-found-adds-entry-expected.txt:
• web-platform-tests/user-timing/buffered-flag.any-expected.txt:
• web-platform-tests/user-timing/buffered-flag.any.worker-expected.txt:

Source/WebCore:

Add support for 'type' attribute as specified here [1].

Tests: imported/w3c/web-platform-tests/performance-timeline/po-observe-type.any.html

imported/w3c/web-platform-tests/performance-timeline/po-observe-type.any.worker.html

[1] ​https://w3c.github.io/performance-timeline/#dom-performanceobserverinit

• page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::observe):

• page/PerformanceObserver.h:
• page/PerformanceObserver.idl:

LayoutTests:

Adjust test to be aligned with the specification and skip
tests that time out.

• TestExpectations:
• performance-api/performance-observer-api-expected.txt:
• performance-api/resources/observer-api.js:

12:28 PM Changeset in webkit [265000] by caitp@igalia.com

• 19 edits
  1 add in trunk

[JSC] add IC support for op_get_private_name
​https://bugs.webkit.org/show_bug.cgi?id=213545

Reviewed by Saam Barati.

JSTests:

Add a crashtest for a crash in an earlier edition of the GPN IC patch.

• stress/get-private-name-cache-failure.js: Added.

Source/JavaScriptCore:

The baseline JIT now supports a fast path for op_private_name,
using a variant of GetByVal IC.

The generated AccessCase has the following qualities:

• Always "direct", relying only on the current structure for cachebility
• Never impure (DOM properties are not supported at this time, ProxyObjects are treated as JSObjects)

Based on the microbenchmark reviewed on ​https://bugs.webkit.org/show_bug.cgi?id=213544, this sees
an improvement of roughly 50% on average.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

• bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::reset):

• bytecode/StructureStubInfo.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

• jit/ICStats.h:
• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

• jit/JIT.h:
• jit/JITInlineCacheGenerator.cpp:

(JSC::JITGetByValGenerator::JITGetByValGenerator):

• jit/JITInlineCacheGenerator.h:
• jit/JITOperations.cpp:

(JSC::getPrivateName):

• jit/JITOperations.h:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_get_private_name):
(JSC::JIT::emitSlow_op_get_private_name):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_get_private_name):
(JSC::JIT::emitSlow_op_get_private_name):

• jit/Repatch.cpp:

(JSC::appropriateOptimizingGetByFunction):
(JSC::appropriateGetByFunction):
(JSC::tryCacheGetBy):

• jit/Repatch.h:

12:21 PM Changeset in webkit [264999] by timothy@apple.com

• 3 edits in trunk/Source/WebKit

Web Inspector: Don't allow docking to a hidden web view
​https://bugs.webkit.org/show_bug.cgi?id=214886

Reviewed by Devin Rousso.

• UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::attach): Call platformCanAttach() since it can do a live check.
(WebKit::WebInspectorProxy::detach): Return early if already attached, otherwise asserts later.

• UIProcess/Inspector/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCanAttach): Return flase when the web view is hidden.

12:15 PM Changeset in webkit [264998] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION (r264930): [ iOS debug wk2 ] webrtc/video.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=214888

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

11:03 AM Changeset in webkit [264997] by commit-queue@webkit.org

• 189 edits
  45 adds in trunk/LayoutTests

[WebGL2] Update WebGL 2.0.0 conformance suite snapshot
​https://bugs.webkit.org/show_bug.cgi?id=214792

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-07-28
Reviewed by Dean Jackson.

WebKit's snapshot of the WebGL 2.0.0 conformance suite was taken
in 2018, before the suite was finalized. Since then many bug fixes
were made to the tests. This new snapshot was taken by running the
conformance suite importing script:

python generate-webgl-tests.py -w \

~/[...]/WebGL/conformance-suites/2.0.0 -o 2.0.0

This update changes the expectations for a few tests. These are
all progressions except for one test,
conformance2/glsl3/tricky-loop-conditions.html, which contains a
few new sub-tests which will have to be fixed.

• TestExpectations:
• webgl/2.0.0/conformance/context/constants-and-properties-expected.txt:
• webgl/2.0.0/conformance/context/context-lost-restored-expected.txt:
• webgl/2.0.0/conformance/extensions/ext-sRGB-expected.txt:
• webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt:
• webgl/2.0.0/conformance2/context/constants-and-properties-2-expected.txt:
• webgl/2.0.0/conformance2/glsl3/tricky-loop-conditions-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/copy-texture-image-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-image-with-bad-args-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-srgb-mipmap-expected.txt:
• webgl/2.0.0/conformance2/textures/misc/tex-storage-and-subimage-3d-expected.txt:
• webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object-expected.txt:
• webgl/2.0.0/resources/webgl_test_files/README.md:
• webgl/2.0.0/resources/webgl_test_files/conformance/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/attribs/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/attribs/gl-bindAttribLocation-aliasing.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/attribs/gl-vertex-attrib-zero-issues.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/attribs/gl-vertexattribpointer.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/buffers/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/canvas/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/canvas/canvas-test.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/context/constants-and-properties.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/context/context-attributes-alpha-depth-stencil-antialias.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/context/context-lost-restored.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/angle-instanced-arrays.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/ext-disjoint-timer-query.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/ext-sRGB.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/oes-texture-float.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/oes-texture-half-float.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/oes-vertex-array-object.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-etc.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-pvrtc.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-size-limit.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/webgl-depth-texture.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/extensions/webgl-draw-buffers.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/angle-ambiguous-function-call.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/compare-loop-index-to-uniform.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/constant-precision-qualifier.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/floored-division-accuracy.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/logic-inside-block-without-braces.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/modulo-arithmetic-accuracy.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/multiplication-assignment.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/sampler-struct-function-arg.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/sequence-operator-evaluation-order.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/bugs/struct-constructor-highp-bug.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/misc/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/misc/global-variable-init.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/glsl/misc/shaders-with-invariance.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/misc/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/misc/webgl-specific.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/more/functions/vertexAttribPointerBadArgs.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/ogles/GL/struct/nestedstructcomb_various_frag.frag:
• webgl/2.0.0/resources/webgl_test_files/conformance/ogles/GL/struct/nestedstructcomb_various_vert.vert:
• webgl/2.0.0/resources/webgl_test_files/conformance/reading/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/renderbuffers/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/rendering/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/rendering/polygon-offset.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/state/gl-enable-enum-test.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/canvas/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/canvas_sub_rectangle/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/image/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/image_bitmap_from_blob/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/image_bitmap_from_canvas/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/image_bitmap_from_image/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/image_bitmap_from_image_bitmap/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/image_bitmap_from_image_data/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/image_bitmap_from_video/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/image_data/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/misc/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/misc/texture-size-limit.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/misc/texture-size.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/svg_image/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/video/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/textures/webgl_canvas/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html:
• webgl/2.0.0/resources/webgl_test_files/conformance/uniforms/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/attribs/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/attribs/gl-vertexattribipointer-offsets.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/attribs/gl-vertexattribipointer.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/buffers/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/buffers/one-large-uniform-buffer.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/buffers/uniform-buffers.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/context/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/context/constants-and-properties-2.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/extensions/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/extensions/ext-color-buffer-float.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/glsl3/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/glsl3/array-assign-constructor.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/glsl3/array-in-complex-expression.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/glsl3/compare-structs-containing-arrays.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/glsl3/short-circuiting-in-loop-condition.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/glsl3/tricky-loop-conditions.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/glsl3/vector-dynamic-indexing.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/programs/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/renderbuffers/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/renderbuffers/framebuffer-object-attachment.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/renderbuffers/multisampled-renderbuffer-initialization.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/renderbuffers/readbuffer.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-filter-outofbounds.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-filter-srgb.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-multisampled-readbuffer.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-outside-readbuffer.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-scissor-enabled.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-size-overflow.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-srgb-and-linear-drawbuffers.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-stencil-only.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/blitframebuffer-test.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/clear-srgb-color-buffer.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/draw-buffers.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/element-index-uint.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/framebuffer-completeness-unaffected.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/instanced-arrays.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/uniform-block-buffer-size.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/samplers/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/sync/sync-webgl-specific.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/canvas/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/canvas_sub_rectangle/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/image/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/image_bitmap_from_blob/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/image_bitmap_from_canvas/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/image_bitmap_from_image/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/image_bitmap_from_image_bitmap/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/image_bitmap_from_image_data/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/image_bitmap_from_video/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/image_data/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/copy-texture-image-luma-format.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/copy-texture-image.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/tex-image-with-bad-args-from-dom-elements.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/tex-image-with-bad-args.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/tex-image-with-different-data-source.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/tex-mipmap-levels.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/tex-srgb-mipmap.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/tex-storage-2d.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/tex-storage-and-subimage-3d.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/misc/texel-fetch-undefined.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/svg_image/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/video/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/textures/webgl_canvas/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/transform_feedback/00_test_list.txt:
• webgl/2.0.0/resources/webgl_test_files/conformance2/transform_feedback/transform_feedback.html:
• webgl/2.0.0/resources/webgl_test_files/conformance2/vertex_arrays/vertex-array-object.html:
• webgl/2.0.0/resources/webgl_test_files/deqp/framework/common/tcuFloat.js:

(goog.scope.tcuFloat.deFloat):
(goog.scope.tcuFloat.deFloat.prototype.deFloatBuffer):
(goog.scope.tcuFloat.deFloat.prototype.deFloatParametersNumber):
(goog.scope.tcuFloat.deFloat.prototype.deFloatParameters):
(goog.scope.tcuFloat.deFloat.prototype.getBitRange):
(goog.scope.tcuFloat.newFloat10):
(goog.scope.tcuFloat.newFloat64):
(goog.scope):
(goog.scope.tcuFloat.deFloat.prototype.array32): Deleted.
(goog.scope.tcuFloat.deFloat.prototype.deFloatNumber64): Deleted.

• webgl/2.0.0/resources/webgl_test_files/deqp/framework/common/tcuFuzzyImageCompare.js:

(goog.scope.tcuFuzzyImageCompare.bilinearSample):

• webgl/2.0.0/resources/webgl_test_files/deqp/framework/common/tcuSkipList.js:
• webgl/2.0.0/resources/webgl_test_files/deqp/framework/common/tcuTestCase.js:

(goog.scope.tcuTestCase.getQueryVal):
(goog.scope.tcuTestCase.Runner.prototype.terminate):
(goog.scope.tcuTestCase.getFilter): Deleted.

• webgl/2.0.0/resources/webgl_test_files/deqp/framework/delibs/debase/deMath.js:

(goog.scope.deMath.arrayToNumber):
(goog.scope.deMath.numberToArray):
(goog.scope.deMath.getBitRange):
(goog.scope.DE_ASSERT): Deleted.
(goog.scope.deMath.getArray32BitRange): Deleted.

• webgl/2.0.0/resources/webgl_test_files/deqp/functional/gles3/es3fFboColorbufferTests.js:

(goog.scope.es3fFboColorbufferTests.FboColorMultiTex2DCase.prototype.render):
(goog.scope.es3fFboColorbufferTests.FboColorTexCubeCase.prototype.render):
(goog.scope.es3fFboColorbufferTests.FboColorTex2DArrayCase.prototype.render):
(goog.scope.es3fFboColorbufferTests.FboColorTex3DCase.prototype.render):
(goog.scope.es3fFboColorbufferTests.FboBlendCase.prototype.render):
(goog.scope.es3fFboColorbufferTests.FboColorbufferTests.prototype.init):
(goog.scope.es3fFboColorbufferTests.run):
(goog.scope):

• webgl/2.0.0/resources/webgl_test_files/deqp/functional/gles3/es3fLifetimeTests.js:

(goog.scope.es3fLifetimeTests.ScaleProgram.prototype.setPos):

• webgl/2.0.0/resources/webgl_test_files/deqp/functional/gles3/es3fMultisampleTests.js:

(goog.scope.es3fMultisampleTests.MultisampleCase.prototype.init):
(goog.scope.es3fMultisampleTests.NumSamplesCase.prototype.iterate):

• webgl/2.0.0/resources/webgl_test_files/deqp/functional/gles3/es3fNegativeVertexArrayApiTests.js:

(goog.scope.es3fNegativeVertexArrayApiTests.init):

• webgl/2.0.0/resources/webgl_test_files/deqp/functional/gles3/es3fPixelBufferObjectTest.js:

(goog.scope.es3fPixelBufferObjectTest.ReadPixelsTest.prototype.iterate):

• webgl/2.0.0/resources/webgl_test_files/deqp/functional/gles3/es3fShaderOperatorTests.js:

(goog.scope.es3fShaderOperatorTests.run):
(goog.scope):

• webgl/2.0.0/resources/webgl_test_files/deqp/functional/gles3/es3fShaderPrecisionTests.js:

(goog.scope.es3fShaderPrecisionTests.add):
(goog.scope.es3fShaderPrecisionTests.sub):
(goog.scope.es3fShaderPrecisionTests.mul):
(goog.scope.es3fShaderPrecisionTests.mul32):
(goog.scope.es3fShaderPrecisionTests.div):
(goog.scope.es3fShaderPrecisionTests.createFloatPrecisionEvalProgram):
(goog.scope.es3fShaderPrecisionTests.createIntUintPrecisionEvalProgram):
(goog.scope.es3fShaderPrecisionTests.ShaderFloatPrecisionCase):
(goog.scope.es3fShaderPrecisionTests.ShaderFloatPrecisionCase.prototype.init):
(goog.scope.es3fShaderPrecisionTests.ShaderFloatPrecisionCase.prototype.deinit):
(goog.scope.es3fShaderPrecisionTests.ShaderFloatPrecisionCase.prototype.compare):
(goog.scope.es3fShaderPrecisionTests.ShaderFloatPrecisionCase.prototype.iterate):
(goog.scope.es3fShaderPrecisionTests.ShaderIntPrecisionCase):
(goog.scope.es3fShaderPrecisionTests.ShaderIntPrecisionCase.prototype.init):
(goog.scope.es3fShaderPrecisionTests.ShaderIntPrecisionCase.prototype.deinit):
(goog.scope.es3fShaderPrecisionTests.extendTo32Bit):
(goog.scope.es3fShaderPrecisionTests.ShaderIntPrecisionCase.prototype.iterate):
(goog.scope.es3fShaderPrecisionTests.ShaderUintPrecisionCase):
(goog.scope.es3fShaderPrecisionTests.ShaderUintPrecisionCase.prototype.init):
(goog.scope.es3fShaderPrecisionTests.ShaderUintPrecisionCase.prototype.deinit):
(goog.scope.es3fShaderPrecisionTests.ShaderUintPrecisionCase.prototype.iterate):
(goog.scope.FloatCase):
(goog.scope.IntCase):
(goog.scope.UintCase):
(goog.scope.es3fShaderPrecisionTests.ShaderPrecisionTests.prototype.init):

• webgl/2.0.0/resources/webgl_test_files/deqp/functional/gles3/es3fShaderTextureFunctionTests.js:

(goog.scope.es3fShaderTextureFunctionTests.TextureSizeCase.prototype.testTextureSize):
(goog.scope.es3fShaderTextureFunctionTests.run):
(goog.scope):

• webgl/2.0.0/resources/webgl_test_files/deqp/functional/gles3/es3fTextureFilteringTests.js:

(goog.scope.es3fTextureFilteringTests.run):
(goog.scope):

• webgl/2.0.0/resources/webgl_test_files/deqp/temp_externs/html5.js:
• webgl/2.0.0/resources/webgl_test_files/extra/50x50pixel-black-with-red-triangle.png: Added.
• webgl/2.0.0/resources/webgl_test_files/extra/canvas-compositing-test.png: Added.
• webgl/2.0.0/resources/webgl_test_files/extra/sample-100.png: Added.
• webgl/2.0.0/resources/webgl_test_files/extra/sample-200.png: Added.
• webgl/2.0.0/resources/webgl_test_files/extra/sample-400.png: Added.
• webgl/2.0.0/resources/webgl_test_files/extra/webgl-translate-shader.html:
• webgl/2.0.0/resources/webgl_test_files/js/js-test-pre.js:

(nonKhronosFrameworkNotifyDone):

• webgl/2.0.0/resources/webgl_test_files/js/tests/iterable-test.js:

(doNextTest):
(run):
(IterableTest):
(createPreserveDrawingBufferLeakTest): Deleted.

• webgl/2.0.0/resources/webgl_test_files/js/tests/out-of-bounds-test.js:

(runDrawArraysTest):
(runDrawElementsTest):
(runInstancedTest):

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-2d-with-canvas-sub-rectangle.js:

(init):
(runTestOnBindingTarget):
(generateTest):

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-2d-with-canvas.js:

(init):
(setCanvasToRedGreen):
(checkSourceCanvasImageData):
(runOneIteration):
(runTest.runTexImageTest.):
(runTest.runTexImageTest):
(runTest):
(generateTest):
(replicateRedChannel): Deleted.
(zapColorChannels): Deleted.
(setAlphaChannelTo1): Deleted.
(replicateAllRedChannels): Deleted.
(setAllAlphaChannelsTo1): Deleted.
(repeatCountForTextureFormat): Deleted.
(setCanvasToSemiTransparentRedGreen): Deleted.
(setCanvasTo257x257SemiTransparent): Deleted.
(setCanvasToMinSemiTransparent): Deleted.

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-2d-with-image-data.js:

(init):

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-2d-with-image.js:

(init):

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-2d-with-svg-image.js:

(init):

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-2d-with-video.js:

(init):
(runOneIteration):

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-2d-with-webgl-canvas.js:

(init):
(runOneIteration):
(runTest.runTexImageTest.):
(runTest.runTexImageTest):
(runTest):
(generateTest):
(shouldRepeatTestForTextureFormat): Deleted.
(): Deleted.

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-3d-with-canvas.js:

(runTest.runTexImageTest.):
(runTest.runTexImageTest):
(runTest):
(generateTest):

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-3d-with-video.js:

(runOneIteration):

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-3d-with-webgl-canvas.js:

(runOneIteration):
(runTest.runTexImageTest.):
(runTest.runTexImageTest):
(runTest):
(generateTest):

• webgl/2.0.0/resources/webgl_test_files/js/tests/tex-image-and-sub-image-with-image-bitmap-utils.js:

(runOneIterationImageBitmapTest):
(runOneIterationImageBitmapTestSubSource):

• webgl/2.0.0/resources/webgl_test_files/js/webgl-test-utils.js:

(glEnumToString):
(setupTransformFeedbackProgram):
(setupUnitQuad):
(setupUnitQuadWithTexCoords):
(setupTexturedQuad):
(setupColorQuad):
(setupTexturedQuadWithTexCoords):
(setupTexturedQuadWithCubeMap):
(glTypeToTypedArrayType):
(getBytesPerComponent):
(fillTexture):
(checkCanvasRectColor):
(checkCanvasRect):
(shouldThrowOrGenerateGLError):
(loadShader):
(getRequestVidFrameCallback):
(setZeroTimeout):
(maybeCallCallback):
(playingListener):
(timeupdateListener):
(startPlayingAndWaitForVideo):
(linearChannelToSRGB):
(WebGLTestUtils):
(setupQuadWithTexCoords): Deleted.
(dummySetProgramAndDrawNothing): Deleted.
(comparePixels): Deleted.
(displayImageDiff): Deleted.
(createImageFromPixel): Deleted.

• webgl/2.0.0/resources/webgl_test_files/py/lint/README.md:
• webgl/2.0.0/resources/webgl_test_files/py/lint/lint.allowlist: Added.
• webgl/2.0.0/resources/webgl_test_files/py/lint/lint.py:

(parse_allowlist_file):
(parse_allowlist_file.inner):
(allowlist_errors):
(main.run_lint):
(parse_whitelist_file): Deleted.
(parse_whitelist_file.inner): Deleted.
(whitelist_errors): Deleted.

• webgl/2.0.0/resources/webgl_test_files/py/tex_image_test_generator.py:
• webgl/2.0.0/resources/webgl_test_files/resources/1-channel.jpg: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/3x3.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/blue-1x1.jpg: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/bug-32888-texture.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/gray-1024x1024.jpg: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/gray-ramp-256-with-128-alpha.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/gray-ramp-256.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/gray-ramp-default-gamma.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/gray-ramp-gamma0.1.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/gray-ramp-gamma1.0.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/gray-ramp-gamma2.0.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/gray-ramp-gamma4.0.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/gray-ramp-gamma9.0.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/gray-ramp.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/green-2x2-16bit.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/npot-video.mp4: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/npot-video.theora.ogv: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/npot-video.webmvp8.webm: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/opengl_logo.jpg: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/red-green-blue-cyan-4x4.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/red-green-blue-cyan-4x4.psd: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/red-green-semi-transparent.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/red-green.bt601.vp9.webm: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/red-green.mp4: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/red-green.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/red-green.theora.ogv: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/red-green.webmvp8.webm: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/red-indexed.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/small-square-with-cie-rgb-profile.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/small-square-with-colormatch-profile.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/small-square-with-colorspin-profile.jpg: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/small-square-with-colorspin-profile.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/small-square-with-e-srgb-profile.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/small-square-with-smpte-c-profile.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/small-square-with-srgb-iec61966-2.1-profile.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/thunderbird-logo-64x64.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/transparent-on-left-indexed.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/webgl-logo.png: Added.
• webgl/2.0.0/resources/webgl_test_files/resources/zero-alpha.png: Added.
• webgl/2.0.0/resources/webgl_test_files/test-guidelines.md:
• webgl/2.0.0/resources/webgl_test_files/webgl-conformance-tests.html:

10:50 AM Changeset in webkit [264996] by Ryan Haddad

• 2 edits in trunk/LayoutTests

REGRESSION: (r264950): [ iOS wk2 ] broke 4 xmlhttprequest tests
​https://bugs.webkit.org/show_bug.cgi?id=214873

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations: Remove flaky

expectation since I rebaselined these tests with r264989.

10:34 AM Changeset in webkit [264995] by ysuzuki@apple.com

• 6 edits
  1 add in trunk

[JSC][wasm] Truncating slightly less than INT32_MIN is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=214834

Reviewed by Darin Adler.

JSTests:

• wasm/spec-tests/conversions.wast.js:
• wasm/stress/trunc-int-min-minus-one.js: Added.

Source/JavaScriptCore:

Wasm trunc_f64_s should handle (INT32_MIN - 1.0, INT32_MIN) range too.

• llint/WebAssembly.asm:
• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::addOp<OpType::I32TruncSF64>):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addOp<OpType::I32TruncSF64>):

10:14 AM Changeset in webkit [264994] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Test landed broken(?): [ macOS wk1 ] fast/dynamic/size-to-content-autosize-with-percent-document-height.html is a constant image failure
​https://bugs.webkit.org/show_bug.cgi?id=214876

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations: Mark the test as failing while the cause is investigated.

10:03 AM Changeset in webkit [264993] by Karl Rackler

• 4 edits in trunk/Source

Unreviewed, reverting r264955.

Reverting because this commit may have caused issues with
tests.

Reverted changeset:

"WebCoreResourceHandleAsOperationQueueDelegate can use
RunLoop::dispatch"
​https://bugs.webkit.org/show_bug.cgi?id=214771
​https://trac.webkit.org/changeset/264955

9:52 AM Changeset in webkit [264992] by sbarati@apple.com

• 4 edits
  3 adds in trunk

JSPromise::reject might throw more than an unterminated exception
​https://bugs.webkit.org/show_bug.cgi?id=214854
<rdar://problem/66152648>

Reviewed by Yusuke Suzuki.

Source/WebCore:

Before, we were assuming the only exception that could be thrown
was an early termination exception. However, it's tenuous to assume
the types of exceptions that can be thrown. This particular test was
throwing a stack overflow exception. It's better form to just propagate
the exception upwards instead of attempting to enumerate the list of
valid exceptions.

Test: js/dom/promise-rejection-might-stack-overflow.html

• bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::reject):

LayoutTests:

• js/dom/promise-rejection-might-stack-overflow-expected.txt: Added.
• js/dom/promise-rejection-might-stack-overflow.html: Added.
• js/dom/script-tests/promise-rejection-might-stack-overflow.js: Added.

(foo):

9:38 AM Changeset in webkit [264991] by mark.lam@apple.com

• 3 edits
  1 add in trunk

ASSERTION FAILED: isSymbol() in Source/JavaScriptCore/runtime/JSCell.cpp(188)
​https://bugs.webkit.org/show_bug.cgi?id=214837

Reviewed by Darin Adler.

JSTests:

• stress/jsc-shell-test-properties-should-not-be-enumerable.js: Added.

Source/JavaScriptCore:

The issue found by this bug was that jsc shell test properties were enumerable.
These properties are only meant for test development use. They will never be
present in a productized JavaScript environment.

This patch helps reduce the change of users of the jsc shell tripping up on these
test properties when enumerating the global object.

• jsc.cpp:

9:34 AM WebKitGTK/2.28.x edited by Michael Catanzaro

(diff)

9:30 AM Changeset in webkit [264990] by commit-queue@webkit.org

• 4 edits in trunk/Source

Add null checks in ResourceLoader
​https://bugs.webkit.org/show_bug.cgi?id=214786
<rdar://problem/61106685>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-07-28
Reviewed by Youenn Fablet.

Source/WebCore:

We had added some iOS-only checks based on crash tracer data.
It turns out these code paths are indeed reachable. Let's make ResourceLoader less platform-dependent.

The original patch for this has a test that would reach this code, but it never finishes loading.
Rather than add a test that always times out or not committing the fix, I commit the fix without the test.

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):
(WebCore::ResourceLoader::cancel):

Source/WebKit:

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::getResourceBytesAtPosition):

9:25 AM Changeset in webkit [264989] by Ryan Haddad

• 1 edit
  8 adds in trunk/LayoutTests

Add test expectations and baselines for iOS 14
​https://bugs.webkit.org/show_bug.cgi?id=214709

Unreviewed test gardening.

Add a few missing baselines for failures that weren't caught by EWS
due to pre-existing flaky expectations.

• platform/ios-13/http/tests/xmlhttprequest/methods-async-expected.txt: Added.
• platform/ios-13/http/tests/xmlhttprequest/methods-expected.txt: Added.
• platform/ios-13/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
• platform/ios-13/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.

9:15 AM Changeset in webkit [264988] by ysuzuki@apple.com

• 19 edits
  2 adds in trunk

IndexedDB binding utilities miss exception checks
​https://bugs.webkit.org/show_bug.cgi?id=214820
<rdar://problem/66152374>

Reviewed by Mark Lam.

Source/JavaScriptCore:

jsStringWithCache does not need to take JSGlobalObject*.

• runtime/JSString.h:

(JSC::jsStringWithCache):

Source/WebCore:

Test: js/dom/indexed-db-operations-exception-checks.html

This patch appropriately inserts exception checking code into IndexedDB binding utilities.

• Modules/indexeddb/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):
(WebCore::IDBKeyRange::includes):

• bindings/js/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):
(WebCore::toJS):
(WebCore::createIDBKeyFromValue):
(WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::maybeCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::canInjectIDBKeyIntoScriptValue):
(WebCore::scriptValueToIDBKey):

• bindings/js/IDBBindingUtilities.h:
• bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

• bindings/js/JSDOMConvertDate.cpp:

(WebCore::valueToDate):

• bindings/js/JSDOMConvertDate.h:

(WebCore::Converter<IDLDate>::convert):

• bindings/js/JSDOMConvertStrings.h:

(WebCore::JSConverter<IDLDOMString>::convert):
(WebCore::JSConverter<IDLByteString>::convert):
(WebCore::JSConverter<IDLUSVString>::convert):

• bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

• bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction const):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateEnumerationImplementationContent):

• bindings/scripts/test/JS/JSTestCallbackInterface.cpp:

(WebCore::convertEnumerationToJS):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::convertEnumerationToJS):

• bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:

(WebCore::convertEnumerationToJS):

• bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp:

(WebCore::convertEnumerationToJS):

• bridge/c/c_utility.cpp:

(JSC::Bindings::convertNPVariantToValue):

LayoutTests:

• js/dom/indexed-db-operations-exception-checks-expected.txt: Added.
• js/dom/indexed-db-operations-exception-checks.html: Added.

9:02 AM Changeset in webkit [264987] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION (r262539): [ iOS wk2 ] imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-drawImage.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=214877

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

8:31 AM Changeset in webkit [264986] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebCore

[GTK] Crash in Nicosia::GC3DLayer::makeContextCurrent due to failure in EGL display creation
​https://bugs.webkit.org/show_bug.cgi?id=201507

Reviewed by Carlos Garcia Campos.

Ensure that EGL context and display creation failures are always
logged using RELEASE_LOG_INFO(), even for intermediate failures for
which a fallback will be tried next, in order to ease diagnosis of
related issues. Failure to create contexts at the end of the public
methods ::createContext() and ::createSharingContext() is still
logged with WTFLogAlways() to write a notice to standard error, and
let users/developers know that something failed and checking the
complete logs (e.g. with "journalctl" on Linux) may reveal more
information.

This also replaces the chains of "if" statements with a single
"switch" on the PlatformDisplay::Type enum, which makes the code
easier to follow and should be more robust as well.

No new tests needed.

• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::getEGLConfig):
(WebCore::GLContextEGL::createWindowContext):
(WebCore::GLContextEGL::createSurfacelessContext):
(WebCore::GLContextEGL::createContext):
(WebCore::GLContextEGL::createSharingContext):

8:27 AM Changeset in webkit [264985] by calvaris@igalia.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Use GST_PLUGIN_FEATURE_RANK env var to have Thunder ranked higher in runtime instead of current custom one
​https://bugs.webkit.org/show_bug.cgi?id=214826

• platform/graphics/gstreamer/GStreamerCommon.cpp: Unreviewed,

added comment about delaying because of the dependency on
GStreamer 1.16.

8:17 AM Changeset in webkit [264984] by Adrian Perez de Castro

• 1 copy in releases/WPE WebKit/webkit-2.28.4

WPE WebKit 2.28.4

8:17 AM Changeset in webkit [264983] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.28

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.28.4 release

.:

• Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

• wpe/NEWS: Add release notes for 2.28.4.

7:15 AM Changeset in webkit [264982] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION: (r264950): [ iOS wk2 ] broke 4 xmlhttprequest tests
​https://bugs.webkit.org/show_bug.cgi?id=214873

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

7:00 AM Changeset in webkit [264981] by Jonathan Bedard

• 2 edits
  1 delete in trunk/Tools

[webkitcorepy] Add string_utils (Part 3)
​https://bugs.webkit.org/show_bug.cgi?id=214405

Reviewed by Aakash Jain.

• Scripts/webkit-patch:

(ForgivingUTF8Writer.write): Replace unicode_compatibility with string_utils.

• Scripts/webkitpy/common/unicode_compatibility.py: Removed.

6:32 AM Changeset in webkit [264980] by Caio Lima

• 3 edits in trunk/JSTests

[32-bits] Skipping some failing tests on ARMv7 and MIPS
​https://bugs.webkit.org/show_bug.cgi?id=214872

Unreviewed Gardening.

• stress/ftl-reflect-get-prototype-of.js:
• stress/intl-suppored-locales-of.js:

6:26 AM Changeset in webkit [264979] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION: (r264492) Broke 4 WebRTC tests and 1 webrtc tests
​https://bugs.webkit.org/show_bug.cgi?id=214730

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

5:49 AM Changeset in webkit [264978] by Carlos Garcia Campos

• 3 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaseline tests after r264968

• platform/gtk/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt:
• platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:

5:39 AM Changeset in webkit [264977] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.28.4

WebKitGTK 2.28.4

5:38 AM Changeset in webkit [264976] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.28

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.28.4 release

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.28.4.

5:18 AM Changeset in webkit [264975] by calvaris@igalia.com

• 7 edits in trunk

[GStreamer] media/vp9.html failing since check-in in r263894
​https://bugs.webkit.org/show_bug.cgi?id=213947

Reviewed by Philippe Normand.

Source/WebCore:

Test: media/vp9.html.

• testing/Internals.cpp:

(WebCore::Internals::usingGStreamer const): Added.

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• media/vp9.html: Used usingGStreamer() to adjust expectation of

the first test and to enable the second. Both are passing now for
GStreamer ports.

• platform/glib/TestExpectations: Removed media/vp9.html failure

from expectations.

3:46 AM Changeset in webkit [264974] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update test expectations after r264967.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

3:34 AM Changeset in webkit [264973] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore

Merge r259525 - Protect contentFrame in SubframeLoader::loadOrRedirectSubframe with RefPtr.
​https://bugs.webkit.org/show_bug.cgi?id=127096
<rdar://problem/61221941>

Reviewed by Alex Christensen.

ContentFrame is used throughout loadOrRedirectSubframe so it needs to be protected with RefPtr.
And if loader changes frame in SubframeLoader::loadSubframe, return nullptr to notify the caller.

No new tests, covered by existing test.

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadOrRedirectSubframe):
(WebCore::SubframeLoader::loadSubframe):

• loader/SubframeLoader.h:

3:34 AM Changeset in webkit [264972] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.28/Source/WebCore

Merge r261208 - Crash in match_constness<WebCore::CSSValue, WebCore::CSSPrimitiveValue>::type& WTF::downcast<WebCore::CSSPrimitiveValue, WebCore::CSSValue> -- ASAN
​https://bugs.webkit.org/show_bug.cgi?id=211479

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-05-05
Reviewed by Geoffrey Garen.

Added check to downcast CSSValue to CSSPrimitiveValue, only if valid CSSPrimitveValue is associated with the property.

New test would be added to Internal repository.

• css/StyleProperties.cpp:

(WebCore::StyleProperties::pageBreakPropertyValue const):

3:34 AM Changeset in webkit [264971] by Carlos Garcia Campos

• 7 edits in releases/WebKitGTK/webkit-2.28

Merge r263302 - Crash in WebCore::Range::borderAndTextRects
​https://bugs.webkit.org/show_bug.cgi?id=209379

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-06-19
Reviewed by Darin Adler.

When a parentless node is moved to a new document, then all ranges associated with this node and its children also should
be updated with new document information.

Test woould be submitted later.

• dom/Document.cpp:

(WebCore::Document::parentlessNodeMoveToNewDocument):

• dom/Document.h:
• dom/Node.cpp:

(WebCore::Node::moveNodeToNewDocument):

• dom/Range.cpp:

(WebCore::Range::parentlessNodeMoveToNewDocumentAffectsRange):
(WebCore::Range::updateRangeForParentlessNodeMoveToNewDocument):

• dom/Range.h:

3:34 AM Changeset in webkit [264970] by Carlos Garcia Campos

• 5 edits
  2 adds in releases/WebKitGTK/webkit-2.28

Merge r264364 - When invalidating the clients of an SVG resource we should not go beyond the RenderSVGRoot
​https://bugs.webkit.org/show_bug.cgi?id=211804
<rdar://problem/60308199>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-07-14
Reviewed by Zalan Bujtas.

Source/WebCore:

ComplexLineLayout::layoutLineBoxes() walks through the renderers of a line.
The order of this walk may include a node and its children. For example
the layout of a RenderInline may be run first, then it is followed by the
layout for a RenderSVGRoot which happens to be a child of the RenderInline.

If the RenderSVGRoot has a dirty RenderSVGResource, e.g. RenderSVGResourceClipper,
this resource will call RenderSVGResource::markForLayoutAndParentResourceInvalidation()
which will invalidate its ancestors including RenderSVGRoot and RenderInline
by setting the normalChildNeedsLayoutBit() for each of them.

The layout of SVG is hierarchical which means RenderSVGRoot will finish
its layout after finishing the layout of all its descendants including
this RenderSVGResource. So dirtying the RenderSVGRoot is this scenario
is okay since RenderSVGRoot will do another SVGRenderSupport::layoutChildren()
and will clear its needsLayout bits before it returns.

The problem happens because we set normalChildNeedsLayoutBit for the containing
RenderInline and this leaves the render tree dirty. Later Document::resolveStyle()
may called to invalidate an SVG element e.g. RenderSVGPath. So setNeedsLayout()
is called for this object. Because the normalChildNeedsLayoutBit() is set
for the RenderInline, RenderObject::markContainingBlocksForLayout() stops
in the middle and do not mark the containing RenderBlock. So we end up
with a render tree like this:

+ RenderView
+ HTML RenderBlock
+ BODY RenderBody

• RenderBlock + ANY-ELEMENT RenderInline + svg RenderSVGRoot
• clipPath RenderSVGResourceClipper + polygon RenderSVGPath

where the '+' means needsLayout() is true and '-' means needsLayout() is
false.

So the layout will not run for RenderBlock with '-' sign. And we end up
with dirty RenderSVGPath or even worse RenderSVGPath with uninitialized
m_path. So a null pointer deref may happen.

The fix is to prevent mutating the render tree while running the layout
of the SVG resource. This can be done by making the RenderSVGResource not
dirtying any renderer beyond the RenderSVGRoot when it finishes its layout.
The SVG resource layout should not affect the intrinsic size of the SVG
if it is embedded in an HTML document.

In RenderObject::markContainingBlocksForLayout(), we do something similar
when we break if the ancestor is objectIsRelayoutBoundary().

Test: svg/in-html/inline-svg-resource-dynamic-update.html

• rendering/svg/RenderSVGResource.cpp:

(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

• rendering/svg/RenderSVGRoot.h:

LayoutTests:

• svg/in-html/inline-svg-resource-dynamic-update-expected.txt: Added.
• svg/in-html/inline-svg-resource-dynamic-update.html: Added.

2:55 AM Changeset in webkit [264969] by Carlos Garcia Campos

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Mark compositing/clipping/border-radius-stacking-context-clip.html as failure

• platform/gtk/TestExpectations:

2:03 AM Changeset in webkit [264968] by Carlos Garcia Campos

• 15 edits
  13 adds in trunk

[GTK][WPE] Support for backdrop-filter
​https://bugs.webkit.org/show_bug.cgi?id=169988

Reviewed by Adrian Perez de Castro.

.:

Enable FILTERS_LEVEL_2 by default for WPE and GTK.

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

Source/WebCore:

Add initial support for backdrop filters to coordinated graphics.

• platform/graphics/nicosia/NicosiaPlatformLayer.h:

(Nicosia::CompositionLayer::flushState): Update the backdrop layer.

• platform/graphics/texmap/TextureMapper.h:
• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeTransformsRecursive): Call it on backdrop layer too.
(WebCore::TextureMapperLayer::paintSelfAndChildren): Paint the backdrop layer before current layer to apply
backdrop filters on previous contents, then the layer is painted on top.
(WebCore::TextureMapperLayer::paintIntoSurface): In case of backdrop layer paint the root layer up to the target
layer into the intermediate surface.
(WebCore::TextureMapperLayer::setBackdropLayer): Set the bakdrop layer and mark it as such.
(WebCore::TextureMapperLayer::applyAnimationsRecursively): Also call syncAnimations on backdrop layer to get the
filters updated.

• platform/graphics/texmap/TextureMapperLayer.h:
• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::didChangeBackdropFilters):
(WebCore::CoordinatedGraphicsLayer::didChangeBackdropFiltersRect):
(WebCore::CoordinatedGraphicsLayer::setShouldUpdateVisibleRect): Also call it for backdrop layer.
(WebCore::CoordinatedGraphicsLayer::setContentsVisible): Ditto.
(WebCore::CoordinatedGraphicsLayer::setBackdropFilters):
(WebCore::CoordinatedGraphicsLayer::setBackdropFiltersRect):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState): Also call it for backdrop layer.
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly): Handle the changes in backdrop
filters and the rect, creating the backdrop layer or updating it.
(WebCore::CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers): Also call it for backdrop layer.
(WebCore::CoordinatedGraphicsLayer::addAnimation): Handle AnimatedPropertyWebkitBackdropFilter property.
(WebCore::dumpInnerLayer): Dump internal layer info.
(WebCore::CoordinatedGraphicsLayer::dumpAdditionalProperties const): Dump backdrop layer.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

Set the backdrop layer if changed when updating the scene state.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::updateSceneState):

LayoutTests:

Update test expectations.

• platform/glib/TestExpectations:
• platform/glib/css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute-expected.txt: Added.
• platform/glib/css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding-expected.txt: Added.
• platform/glib/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.txt: Added.
• platform/glib/css3/filters/backdrop/backdrop-filter-with-cliprect-expected.txt: Added.
• platform/glib/css3/filters/backdrop/backdrop-filter-with-mask-expected.txt: Added.
• platform/glib/css3/filters/backdrop/backdrop-with-visibility-hidden-changing-expected.txt: Added.
• platform/glib/css3/filters/backdrop/backdrop-with-visibility-hidden-expected.txt: Added.
• platform/glib/css3/filters/backdrop/resource-use-add-more-layers-expected.txt: Added.
• platform/glib/css3/filters/backdrop/resource-use-excessive-expected.txt: Added.
• platform/glib/css3/filters/backdrop/resource-use-ok-expected.txt: Added.
• platform/glib/css3/filters/backdrop/resource-use-remove-some-layers-expected.txt: Added.
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

1:01 AM Changeset in webkit [264967] by youenn@apple.com

• 4 edits
  3 adds in trunk

ReadableStreamDefaultController should use private JS built-in methods
​https://bugs.webkit.org/show_bug.cgi?id=214819

Reviewed by Darin Adler.

Source/WebCore:

Call directly private buitl-in methods instead of getting close/error/enqueue methods from the controller.
Test: http/wpt/fetch/readableStreamDefaultController-overwriting.html

• bindings/js/ReadableStreamDefaultController.cpp:

(WebCore::invokeReadableStreamDefaultControllerFunction):
(WebCore::ReadableStreamDefaultController::close):
(WebCore::ReadableStreamDefaultController::error):
(WebCore::ReadableStreamDefaultController::enqueue):

• bindings/js/ReadableStreamDefaultController.h:

(WebCore::ReadableStreamDefaultController::enqueue):
(WebCore::ReadableStreamDefaultController::error):

LayoutTests:

• http/wpt/fetch/readableStreamDefaultController-overwriting-expected.txt: Added.
• http/wpt/fetch/readableStreamDefaultController-overwriting.html: Added.
• http/wpt/fetch/resources/lengthy-pass.py: Added.

1:01 AM Changeset in webkit [264966] by youenn@apple.com

• 6 edits in trunk/Source

Disable low latency code path for H264 constrained baseline
​https://bugs.webkit.org/show_bug.cgi?id=214830

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

In case of baseline profile, use straight VTB encoder.
In case of high profile, use low latency code path if enabled.
In case of MacOS software code path, enable low latency code path as straight VTB encoder buffers frames.

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

(-[RTCVideoEncoderH264 initWithCodecInfo:]):
(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):

Source/WebKit:

Enable low latency code path on iOS.
Manually tested.

• Shared/WebPreferences.yaml:
• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultWebRTCH264LowLatencyEncoderEnabled):

• Shared/WebPreferencesDefaultValues.h: