⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 2, 2020:

11:41 PM Changeset in webkit [265191] by Simon Fraser
  • 6 edits in trunk/Tools

Improve the check-for-duplicated-platform-test-results script
​https://bugs.webkit.org/show_bug.cgi?id=215072

Reviewed by Darin Adler.

check-for-duplicated-platform-test-results had some problems.

First, it defaulted to -wk1 results directories, and didn't check -wk2 directories, so
run the logic twice, with options.webkit_test_runner True and False.
Second, it only looked for results in the most specific fallback directory, so
with a fallback path like 'mac-mojave-wk1 -> mac-mojave -> mac-wk1 -> mac -> generic'
it would only remove results in mac-mojave-wk1, not in 'mac-mojave'.
Also add some logging to the script.

  • Scripts/check-for-duplicated-platform-test-results:

(remove_layout_test_path_prefix):
(check_duplicate.sha1):
(check_duplicate):
(platform_list):
(find_duplicates_in_path):
(find_duplicates_in_path.find_duplicates):
(check_platform):
(main):

  • Scripts/webkitpy/port/base.py:

(Port.supports_layout_tests): Some ports (iOS and watch device ports) don't support
testing with no associated device. Need to fix errors thrown from default_baseline_search_path().

  • Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.supports_layout_tests):

  • Scripts/webkitpy/port/watch_device.py:

(WatchDevicePort.supports_layout_tests):

  • Scripts/webkitpy/port/win.py: self._os_version is None when run on another platform.

(WinPort.default_baseline_search_path):
(WinCairoPort._search_paths):

5:47 PM Changeset in webkit [265190] by Darin Adler
  • 59 edits in trunk/Source

Remove some member functions of Range and many calls to createLiveRange
​https://bugs.webkit.org/show_bug.cgi?id=215070

Reviewed by Sam Weinig.

Source/WebCore:

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::nextBoundary): Remove createLiveRange.
(WebCore::AXObjectCache::previousBoundary): Ditto.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Take SimpleRange.
(-[WebAccessibilityObjectWrapper positionForTextMarker:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textRectsFromMarkers:withText:]): Ditto.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Take SimpleRange.
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]): Ditto.

  • dom/DocumentMarkerController.cpp:

(WebCore::updateRenderedRectsForMarker): Renamed range to makeSimpleRange.
(WebCore::makeSimpleRange): Ditto.

  • dom/DocumentMarkerController.h: Update for the above.
  • dom/Range.cpp:

(WebCore::Range::text const): Use makeSimpleRange.
(WebCore::Range::shadowRoot const): Deleted.
(WebCore::intervalsSufficientlyOverlap): Deleted.
(WebCore::adjustLineHeightOfSelectionRects): Deleted.
(WebCore::coalesceSelectionRects): Deleted.
(WebCore::Range::collectSelectionRectsWithoutUnionInteriorLines const): Deleted.
(WebCore::Range::collectSelectionRects const): Deleted.

  • dom/Range.h: Update for the above. Also make pastLastNode private since it is

only used inside the Range class's implementation.

  • dom/SimpleRange.cpp:

(WebCore::SimpleRange::SimpleRange): Removed overload that takes a Range.

  • dom/SimpleRange.h: Update for the above. Removed both constructor overloads

that take a Range.

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::timerFired): Remove createLiveRange.
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord): Use
makeSimpleRange.
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
Remove createLiveRange.

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::styleAtSelectionStart): Remove createLiveRange.

  • editing/Editor.cpp:

(WebCore::Editor::performCutOrCopy): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
(WebCore::Editor::replaceRangeForSpellChecking): Ditto.
(WebCore::correctSpellcheckingPreservingTextCheckingParagraph): Ditto.
(WebCore::Editor::changeBackToReplacedString): Ditto.
(WebCore::Editor::countMatchesForText): Ditto.

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply): Ditto.
(WebCore::InsertListCommand::doApplyForSingleParagraph): Change out
argument type to SimpleRange.

  • editing/InsertListCommand.h: Update for above.
  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::isCheckable const): Rewrite questionable logic
to use intersectingNodes instead of firstNode.

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findUngrammaticalPhrases const): Remove createLiveRange.

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed): Ditto.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

  • editing/markup.cpp:

(WebCore::createFragmentFromText): Ditto.

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAsChildOfElement): Use makeRangeSelectingNodeContents.

  • editing/win/EditorWin.cpp:

(WebCore::Editor::pasteWithPasteboard): Remove createLiveRange.

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange): Use makeSimpleRange.
(WebCore::DOMSelection::deleteFromDocument): Remove createLiveRange.

  • page/DragController.cpp:

(WebCore::documentFragmentFromDragData): Take SimpleRange.
(WebCore::DragController::concludeEditDrag): Remove createLiveRange.
(WebCore::DragController::startDrag): Ditto.

  • page/TextIndicator.cpp:

(WebCore::selectionRects): Deleted.
(WebCore::initializeIndicator): Call collectSelectionRects directly here,
avoiding createLiveRange and using map to convert from Vector<SelectionRect>
to Vector<FloatRect>.

  • page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot const): Use makeSimpleRange.

  • platform/DragImage.cpp:

(WebCore::createDragImageForRange): Take SimpleRange.

  • platform/DragImage.h: Update createDragImageForRange to take SimpleRange.
  • platform/Pasteboard.h: Updated Windows-only layering-violating functions

to take SimpleRange.

  • platform/ios/DragImageIOS.mm:

(WebCore::createDragImageForRange): Take SimpleRange.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeRangeToDataObject): Take SimpleRange.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.

  • rendering/RenderObject.cpp:

(WebCore::intervalsSufficientlyOverlap): Added. Moved from Range. Mostly unchanged
but uses SimpleRange now instead of a live range, and intersectingNodes instead of
a loop using firstNode and pastLastNode.
(WebCore::adjustLineHeightOfSelectionRects): Ditto.
(WebCore::coalesceSelectionRects): Ditto.
(WebCore::RenderObject::collectSelectionRectsWithoutUnionInteriorLines): Ditto.
(WebCore::RenderObject::collectSelectionRectsInternal): Ditto.
(WebCore::RenderObject::collectSelectionRects): Ditto.

  • rendering/RenderObject.h: Update for above.
  • testing/Internals.cpp:

(WebCore::Internals::markerRangeForNode): Use makeSimplRange.
(WebCore::Internals::locationFromRange): Ditto.
(WebCore::Internals::lengthFromRange): Ditto.
(WebCore::Internals::rangeAsTextUsingBackwardsTextIterator): Ditto.
(WebCore::Internals::subrange): Ditto.
(WebCore::Internals::rangeOfStringNearLocation): Ditto.
(WebCore::Internals::textIndicatorForRange): Ditto.

Source/WebKit:

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:

(-[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]): Use makeSimpleRange.

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(API::PageOverlayClientImpl::actionContextForResultAtPoint): Ditto.

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange textRects]): Ditto.

  • WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:

(-[WKDOMTextIterator initWithRange:]): Ditto.

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage): Ditto.

  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Remove createLiveRange.
(WebKit::WebPage::performDictionaryLookupForSelection): Ditto.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll): Ditto.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPlatformEditorState const): Ditto.
(WebKit::WebPage::computeAndSendEditDragSnapshot): Ditto.
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Ditto.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Ditto.
(WebKit::WebPage::requestAutocorrectionData): Ditto.

Source/WebKitLegacy/ios:

  • WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame selectionRectsForCoreRange:]): Remove createLiveRange.
(-[WebFrame selectionRectsForRange:]): Use makeSimpleRange.

  • WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Ditto.
(-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
(+[DOMRange rangeForFirstPosition:second:]): Rename firstVP/secondVP
to firstPosition/secondPosition.

Source/WebKitLegacy/mac:

  • DOM/DOM.mm:

(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
Use makeSimpleRange.
(-[DOMRange textRects]): Ditto.

  • DOM/DOMDocument.mm: Update includes.
  • DOM/DOMRange.mm: Ditto.
  • DOM/DOMRangeInternal.h: Ditto.
  • DOM/DOMUIKitExtensions.mm: Ditto.
  • DOM/DOMUtility.mm: Ditto.
  • DOM/WebDOMOperations.mm:

(-[DOMRange webArchive]): Use makeSimpleRange.
(-[DOMRange markupString]): Ditto.

  • WebView/WebFrame.mm:

(-[WebFrame _stringForRange:]): Use makeSimpleRange.
(-[WebFrame _convertToDOMRange:]): Return a SimpleRange.
(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]): Ditto.
(-[WebFrame _convertNSRangeToDOMRange:]): Update for above.
(-[WebFrame _convertDOMRangeToNSRange:]): Use makeSimpleRange.
(-[WebFrame _selectNSRange:]): Update for above.
(-[WebFrame selectWithoutClosingTypingNSRange:]): Ditto.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use makeSimpleRange.
(-[WebFrame dictationResultMetadataForRange:]): Ditto.

  • WebView/WebFrameInternal.h: Update for above.
  • WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
Use makeSimpleRange.
(-[WebHTMLView attributedSubstringFromRange:]): Use auto.
(-[WebHTMLView _attributedStringFromDOMRange:]): Deleted.
(-[WebHTMLView attributedString]): Rewrote to use SimpleRange consistently.
(-[WebHTMLView selectedAttributedString]): Ditto.

  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _animationControllerForDataDetectedText]):
Use makeSimpleRange.

  • WebView/WebTextIterator.mm:

(-[WebTextIterator initWithRange:]): Ditto.

  • WebView/WebView.mm:

(-[WebView _didConcludeEditDrag]): Remove createLiveRange.

4:05 PM Changeset in webkit [265189] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix CLoop build
​https://bugs.webkit.org/show_bug.cgi?id=215010

  • tools/SigillCrashAnalyzer.cpp:
1:49 PM Changeset in webkit [265188] by Wenson Hsieh
  • 4 edits in trunk

Table data is incorrectly translated in some articles on en.wikipedia.org
​https://bugs.webkit.org/show_bug.cgi?id=215071
<rdar://problem/66354013>

Reviewed by Darin Adler.

Source/WebCore:

Text in table cells sometimes end up in adjacent cells after translation, since adjacent cells are currently
extracted as different tokens in a single item; mitigate this by splitting text in table cells into different
text manipulation items instead.

Test: TextManipulation.StartTextManipulationExtractsTableCellsAsSeparateItems

  • editing/TextManipulationController.cpp:

(WebCore::isEnclosingItemBoundaryElement):

Tools:

Add a new API test to exercise the change.

  • TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

8:12 AM Changeset in webkit [265187] by Darin Adler
  • 9 edits
    1 add
    52 deletes in trunk

Write a script to find duplicate files and delete some duplicate tests in LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=215073

Reviewed by Anders Carlsson.

Tools:

  • Scripts/find-duplicate-files: Added. Basic script that uses MD5 digests

to find duplicate files.

  • Scripts/report-non-inclusive-language: Tweaked a tiny bit; use a variable.

LayoutTests:

  • css2.1/20110323/abspos-containing-block-initial-004d.htm.1: Removed.

The above was just a stray copy of a test with the wrong extension, so ignored.

  • css3/font-variant-petite-caps-synthesis-coverage-expected.html: Removed.
  • css3/font-variant-petite-caps-synthesis-coverage.html: Removed.
  • css3/font-variant-small-caps-synthesis-coverage-expected.html: Removed.
  • css3/font-variant-small-caps-synthesis-coverage.html: Removed.

These are duplicates of the same tests without the suffix "coverage".

  • fast/dom/Document/document-close-iframe-load-expected.txt: Removed.
  • fast/dom/Document/document-close-iframe-load.html: Removed.
  • fast/dom/Document/document-close-nested-iframe-load-expected.txt: Removed.
  • fast/dom/Document/document-close-nested-iframe-load.html: Removed.

These tests are also in the directory "fast/parser". Chose to delete this copy.

  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Removed.
  • fast/forms/label/labels-set-htmlFor-attribute.html: Removed.

This test also exists under the name "labels-change-...".

  • fast/loader/unload-form-about-blank-expected.txt: Removed.
  • fast/loader/unload-form-about-blank.html: Removed.

This test also exists under the name "unload-form-post-about-blank...".

  • fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
  • fast/ruby/before-table-doesnt-crash.html: Removed.

This is just a copy of the test "before-block-...", not a separate test.

  • http/tests/misc/submit-post-in-utf16be.html:

Used the iconv tool to turn this into a UTF-16BE input file so it tests
what it is intended to test. Before this was a UTF-16LE file.

  • imported/blink/001-a-expected.html: Removed.
  • imported/blink/001-a.html: Removed.
  • imported/blink/001-q-expected.html: Removed.
  • imported/blink/001-q.html: Removed.
  • imported/blink/001-s-expected.html: Removed.
  • imported/blink/001-s.html: Removed.

These are identical duplicates of tests that are in WPT.

  • imported/blink/animations/animation-events-prefixed-04-expected.txt: Removed.
  • imported/blink/animations/animation-events-prefixed-04.html: Removed.
  • imported/blink/animations/animation-events-unprefixed-04-expected.txt: Removed.
  • imported/blink/animations/animation-events-unprefixed-04.html: Removed.

These are duplicates of tests in the directory imported/blink/virtual/stable/animations-unprefixed.

  • imported/blink/css3/flexbox/relpos-with-scrollable-with-abspos-crash-expected.txt: Removed.
  • imported/blink/css3/flexbox/relpos-with-scrollable-with-abspos-crash.html: Removed.
  • imported/blink/fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt: Removed.
  • imported/blink/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html: Removed.
  • imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes-expected.html: Removed.
  • imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes.html: Removed.
  • imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran-expected.txt: Removed.
  • imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran.html: Removed.
  • imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started-expected.txt: Removed.
  • imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started.html: Removed.
  • imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase-expected.txt: Removed.
  • imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase.html: Removed.
  • imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-expected.txt: Removed.
  • imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive.html: Removed.
  • imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase-expected.txt: Removed.
  • imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase.html: Removed.
  • imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-expected.txt: Removed.
  • imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code.html: Removed.

These are identical duplicates of tests in the same named directories outside "imported/blink".
Maybe imported by Blink from WebKit and then back?

  • imported/blink/img_border_percent-expected.xhtml: Removed.
  • imported/blink/img_border_percent.xhtml: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-default-expected.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-default.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-zero-expected.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-zero.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-default-expected.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-default.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-zero-expected.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-zero.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/figure-expected.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/figure.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-layout-expected.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-layout.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-width-150percent-expected.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-width-150percent.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/replaced-elements/images/space-expected.html: Removed.
  • imported/blink/imported/web-platform-tests/html/rendering/replaced-elements/images/space.html: Removed.
  • imported/blink/object_border_perc-expected.xhtml: Removed.
  • imported/blink/object_border_perc.xhtml: Removed.
  • imported/blink/object_border_pixel-expected.xhtml: Removed.
  • imported/blink/object_border_pixel.xhtml: Removed.

These are identical duplicates of tests that are in WPT.

  • platform/gtk/TestExpectations: Removed expectations for removed tests.
  • platform/ios/TestExpectations: Ditto.
  • platform/win/TestExpectations: Ditto.
  • platform/wpe/TestExpectations: Ditto.
  • svg/dom/SVGLengthList-removeItem-expected.txt: Removed.
  • svg/dom/SVGLengthList-removeItem.xhtml: Removed.

This was a duplicate of the SVGLengthList-addItem test.

1:22 AM Changeset in webkit [265186] by commit-queue@webkit.org
  • 16 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r265151.
​https://bugs.webkit.org/show_bug.cgi?id=215074

Broke ARM64E JSC tests

Reverted changeset:

"validate untagArrayPtr"
​https://bugs.webkit.org/show_bug.cgi?id=214953
​https://trac.webkit.org/changeset/265151

Aug 1, 2020:

11:21 PM Changeset in webkit [265185] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove superfluous ResourceTiming constructor overload
​https://bugs.webkit.org/show_bug.cgi?id=215063

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-01
Reviewed by Sam Weinig.

Remove superfluous ResourceTiming constructor overload, we
can just call another overload from ResourceTiming::fromLoad.

  • loader/ResourceTiming.cpp:

(WebCore::ResourceTiming::fromLoad):

  • loader/ResourceTiming.h:
8:19 PM Changeset in webkit [265184] by Darin Adler
  • 2 edits in trunk/LayoutTests

Remove test expectation for a WPT test that was removed
​https://bugs.webkit.org/show_bug.cgi?id=215066
rdar://42904780

Reviewed by Sam Weinig.

  • platform/mac-wk1/TestExpectations: Removed failure expectation for

a WPT WebCryptoAPI test that no longer exists.

7:53 PM Changeset in webkit [265183] by beidson@apple.com
  • 11 edits
    1 copy
    3 adds in trunk

Special HID mapping for the Logitech F310/F710 controllers.
​https://bugs.webkit.org/show_bug.cgi?id=215050

Reviewed by Tim Horton.

Source/WebCore:

Covered by API test.

These two controllers match the standard mapping perfectly. Easy to support.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/gamepad/KnownGamepads.h:
  • platform/gamepad/mac/GamepadConstantsMac.h:
  • platform/gamepad/mac/HIDGamepad.cpp:

(WebCore::HIDGamepad::create):

  • platform/gamepad/mac/HIDGamepadElement.cpp:

(WebCore::HIDGamepadElement::HIDGamepadElement):

  • platform/gamepad/mac/HIDGamepadElement.h:

(WebCore::HIDGamepadElement::isAxis const):

  • platform/gamepad/mac/LogitechGamepad.cpp: Added.

(WebCore::LogitechGamepadHatswitch::gamepadValueChanged):
(WebCore::LogitechGamepad::LogitechGamepad):

  • platform/gamepad/mac/LogitechGamepad.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/HIDGamepads.mm:
  • TestWebKitAPI/mac/GamepadMappings/LogitechF310.mm: Added.

(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::logitechF310Mapping):

  • TestWebKitAPI/mac/GamepadMappings/LogitechF710.mm: Added.

(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::logitechF710Mapping):

  • TestWebKitAPI/mac/VirtualGamepad.h:
6:50 PM Changeset in webkit [265182] by jh718.park@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Remove the build warnings below since r265150.
warning: unused parameter ‘foo’ [-Wunused-parameter]

No new tests, no new behaviors.

  • workers/service/server/SWServerJobQueue.cpp:

(WebCore::doCertificatesMatch):

6:18 PM Changeset in webkit [265181] by Darin Adler
  • 3 edits in trunk/Source/WebKit

Fix and further refine makefile rule for WebKit messages generated files
​https://bugs.webkit.org/show_bug.cgi?id=215064

Reviewed by Sam Weinig.

  • DerivedSources-output.xcfilelist: Updated for a file that was omitted

because of a typo in the makefile.

  • DerivedSources.make: Fix "addsufix" typo and reorganized things a bit.
3:55 PM Changeset in webkit [265180] by beidson@apple.com
  • 13 edits
    1 copy
    2 adds in trunk

Special HID mapping for the Google Stadia controller
​https://bugs.webkit.org/show_bug.cgi?id=215061

Reviewed by Tim Horton.

Source/WebCore:

New API test coverage.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/gamepad/GamepadConstants.h:
  • platform/gamepad/KnownGamepads.h:
  • platform/gamepad/mac/GamepadConstantsMac.h:
  • platform/gamepad/mac/HIDGamepad.cpp:

(WebCore::HIDGamepad::create):

  • platform/gamepad/mac/HIDGamepadElement.cpp:

(WebCore::HIDGamepadElement::HIDGamepadElement):
(WebCore::HIDGamepadHatswitch::gamepadValueChanged):
(WebCore::HIDGamepadHatswitch::normalizedValue):

  • platform/gamepad/mac/HIDGamepadElement.h:

(WebCore::HIDGamepadElement::isAxis const):
(WebCore::HIDGamepadHatswitch::HIDGamepadHatswitch):

  • platform/gamepad/mac/StadiaHIDGamepad.cpp: Added.

(WebCore::StadiaHIDGamepad::StadiaHIDGamepad):

  • platform/gamepad/mac/StadiaHIDGamepad.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/HIDGamepads.mm:
  • TestWebKitAPI/mac/GamepadMappings/GoogleStadia.mm: Added.

(TestWebKitAPI::publishReportCallback):

(TestWebKitAPI::VirtualGamepad::googleStadiaMapping):

  • TestWebKitAPI/mac/VirtualGamepad.h:
2:48 PM Changeset in webkit [265179] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Unreviewed, reverting r265097, r265113, and r265122.
​https://bugs.webkit.org/show_bug.cgi?id=215065

Broke AppleSilicon Big Sur

Reverted changesets:

"Strip pointers instead of authing for byteOffset to not allow
for a possible way to guess data pac"
​https://bugs.webkit.org/show_bug.cgi?id=214952
​https://trac.webkit.org/changeset/265097

"Compute number of PAC bits from what the OS says its address
space is"
​https://bugs.webkit.org/show_bug.cgi?id=214986
​https://trac.webkit.org/changeset/265113

"Remove UB from nonPACBitsMask computation"
​https://bugs.webkit.org/show_bug.cgi?id=214996
​https://trac.webkit.org/changeset/265122

10:54 AM Changeset in webkit [265178] by Keith Rollin
  • 2 edits in trunk/Source/WebKit

Prevent multiple invocations of generate-message-receiver.py
​https://bugs.webkit.org/show_bug.cgi?id=215054

Reviewed by Darin Adler.

WebKit/DerivedSources.make is written such that
generate-message-receiver.py can be invoked N times, where N is the
value passed to -j. This results in the N invocations of
generate-message-receiver.py trying trying to generate the same set of
files at the same time, possibly leading to their being corrupted. We
have reports of generated files starting with a 4K block of NULs, and
this contention may be causing it. Address this by using a "pattern
rule" in the makefile, which is documented in GNU make's documentation
as the approach to take when there is one build rule that creates
multiple outputs, as is the case here.

See also <​https://bugs.webkit.org/show_bug.cgi?id=166814> and
<​http://trac.webkit.org/changeset/210507>.

No new tests -- no new or changed functionality.

  • DerivedSources.make:
10:51 AM Changeset in webkit [265177] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Convert LinkHeader to use StringParsingBuffer
​https://bugs.webkit.org/show_bug.cgi?id=215017

Reviewed by Darin Adler.

Update LinkHeader parsing to use StringParsingBuffer and do some light cleanup.

  • loader/LinkHeader.cpp:

(WebCore::isSpaceOrTab):
(WebCore::isNotURLTerminatingChar):
(WebCore::isValidParameterNameChar):
(WebCore::isParameterValueEnd):
(WebCore::isParameterValueChar):
(WebCore::findURLBoundaries):
(WebCore::invalidParameterDelimiter):
(WebCore::validFieldEnd):
(WebCore::parseParameterDelimiter):
(WebCore::paramterNameFromString):
(WebCore::parseParameterName):
(WebCore::skipQuotesIfNeeded):
(WebCore::parseParameterValue):
(WebCore::findNextHeader):
(WebCore::LinkHeader::LinkHeader):
(WebCore::LinkHeaderSet::LinkHeaderSet):
(WebCore::LinkHeaderSet::init): Deleted.

  • loader/LinkHeader.h:
8:50 AM Changeset in webkit [265176] by Darin Adler
  • 64 edits in trunk/Source

Remove Range::create and many more uses of live ranges
​https://bugs.webkit.org/show_bug.cgi?id=215004

Reviewed by Sam Weinig.

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange const):
Use makeSimpleRange.

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Use SimpleRange.

  • accessibility/atk/WebKitAccessibleHyperlink.cpp:

(rangeLengthForObject): Take SimpleRange.
(webkitAccessibleHyperlinkGetStartIndex): Use makeSimpleRange.
(webkitAccessibleHyperlinkGetEndIndex): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject): Ditto.

  • accessibility/atk/WebKitAccessibleUtil.cpp:

(objectFocusedAndCaretOffsetUnignored): Ditto.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(+[WebAccessibilityTextMarker startOrEndTextMarkerForRange:isStart:cache:]):
Take SimpleRange.
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
Use makeSimpleRange.
(-[WebAccessibilityObjectWrapper _convertToDOMRange:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textMarkerRange]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textMarkerForPosition:]): Use auto.
(-[WebAccessibilityObjectWrapper misspellingTextMarkerRange:forward:]):
Remove createLiveRange.
(-[WebAccessibilityObjectWrapper rangeFromMarkers:withText:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textRectsFromMarkers:withText:]): Add createLiveRange.
(-[WebAccessibilityObjectWrapper rangeForTextMarkers:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForTextMarkers:isStart:]):
Use auto.
(-[WebAccessibilityObjectWrapper textMarkerRangeForMarkers:]): Get rid of local.
(-[WebAccessibilityObjectWrapper textMarkersForRange:]): Take SimpleRange.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilityTextOperationForParameterizedAttribute): Remove makeSimpleRange.
(accessibilityMisspellingSearchCriteriaForParameterizedAttribute): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textMarkerRangeFromRange:]): Take SimpleRange.
(textMarkerRangeFromRange): Ditto.
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForRange:isStart:]): Ditto.
(startOrEndTextmarkerForRange): Return SimpleRange.
(-[WebAccessibilityObjectWrapper rangeForTextMarkerRange:]): Ditto.
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
Use auto.
(-[WebAccessibilityObjectWrapper doAXAttributedStringForRange:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textMarkerRangeAtTextMarker:forUnit:]): Ditto.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): Ditto.

  • dom/DocumentMarkerController.cpp:

(WebCore::updateRenderedRectsForMarker): Use document marker range function.
(WebCore::range): Added.

  • dom/DocumentMarkerController.h: Update for above.
  • dom/Position.cpp: Removed unneeded Range.h include.
  • dom/Range.cpp:

(WebCore::Range::Range): Removed unused overload that takes start/end.
(WebCore::Range::create): Removed overloads that take start/end.
(WebCore::Range::setStart): Removed overload that takes Position.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::cloneRange const): Rewrote to use setStart/End since
that's what the constructor used to do.
(WebCore::Range::contains const): Use SimpleRange/createLiveRange
instead of makeRange. Soon this function will be deleted.
(WebCore::rangeOfContents): Deleted.
(WebCore::createLiveRange): Rewrote to use setStart/End since that's
what the constructor used to do.

  • dom/Range.h: Update for above removals.
  • dom/SimpleRange.h: Export commonInclusiveAncestor for use outside WebCore.
  • dom/StaticRange.cpp:

(WebCore::StaticRange::create): Added overload that copies the SimpleRange.

  • dom/StaticRange.h: Update for above.
  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord): Use document
marker range function.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Use makeSimpleRange.

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs): Ditto.
(WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
Ditto.

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::textDirectionForSelection): Use makeSimpleRange and
intersectingNodes.

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment): Use makeRangeSelectingNodeContents.
(WebCore::Editor::updateMarkersForWordsAffectedByEditing): Use makeSimpleRange.
(WebCore::Editor::transpose): Ditto.
(WebCore::Editor::rangeOfString): Use makeRangeSelectingNodeContents.
(WebCore::Editor::handleAcceptedCandidate): Update since rangeForTextCheckingResult
now returns an Optional<SimpleRange>.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectRangeOnElement): Use SimpleRange.

  • editing/ReplaceRangeWithTextCommand.cpp:

(WebCore::ReplaceRangeWithTextCommand::ReplaceRangeWithTextCommand): Take
SimpleRange.
(WebCore::ReplaceRangeWithTextCommand::willApplyCommand): Update since
m_rangeToBeReplaced is a SimpleRange.
(WebCore::ReplaceRangeWithTextCommand::doApply): Ditto.
(WebCore::ReplaceRangeWithTextCommand::targetRanges const): Ditto.

  • editing/ReplaceRangeWithTextCommand.h: Update for above.
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::insertedContentRange const):
Return a SimpleRange.

  • editing/ReplaceSelectionCommand.h: Update for above.
  • editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand):
Take a SimpleRange.
(WebCore::SpellingCorrectionCommand::create): Moved here from header.

  • editing/SpellingCorrectionCommand.h: Update for above.
  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstMisspelledWordOrUngrammaticalPhrase const):
Use makeSimpleRange.

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::markMisspellingsAfterTyping): Use makeSimpleRange.
(WebCore::TypingCommand::willAddTypingToOpenCommand): Take SimpleRange.
(WebCore::TypingCommand::deleteKeyPressed): Remove createLiveRange.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

  • editing/TypingCommand.h: Update for above.
  • editing/VisiblePosition.cpp:

(WebCore::makeRange): Deleted.
(WebCore::startVisiblePosition): Deleted.
(WebCore::endVisiblePosition): Deleted.
(WebCore::setStart): Deleted.
(WebCore::setEnd): Deleted.

  • editing/VisiblePosition.h: Update for above. Also export makeSimpleRange

for use outside WebCore.

  • editing/VisibleUnits.cpp:

(WebCore::suffixLengthForRange): Take SimpleRange.
(WebCore::prefixLengthForRange): Ditto.
(WebCore::previousBoundary): Use makeSimpleRange.
(WebCore::nextBoundary): Ditto.

  • editing/VisibleUnits.h: Update for above.
  • editing/cocoa/DataDetection.mm:

(WebCore::buildQuery): Remove unused local variable.

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setDictationPhrasesAsChildOfElement): Use makeRangeSelectingNodeContents.

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::getRangeAt): Use createLiveRange.

  • page/DragController.cpp:

(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret): Remove makeSimpleRange.

  • page/Frame.cpp:

(WebCore::Frame::rangeForPoint): Return SimpleRange.

  • page/Frame.h: Update for above.
  • page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot const): Use makeRangeSelectingNodeContents,
intersectingNodes, and makeSimpleRange.

  • testing/Internals.cpp:

(WebCore::Internals::markerRangeForNode): Use createLiveRange and the document
marker range function.

Source/WebKit:

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(API::PageOverlayClientImpl::actionContextForResultAtPoint): Return a
structure that includes a SimpleRange.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::visibleRange): Use makeSimpleRange.

  • WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h: Use SimpleRange.
  • WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

(WebKit::TextCheckingControllerProxy::rangeAndOffsetRelativeToSelection): Use SimpleRange.
(WebKit::TextCheckingControllerProxy::replaceRelativeToSelection): Ditto.
(WebKit::TextCheckingControllerProxy::removeAnnotationRelativeToSelection): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::characterIndexForPointAsync): Remove makeSimpleRange.
(WebKit::WebPage::deleteSurrounding): Use makeSimpleRange.

  • WebProcess/WebPage/WebPageOverlay.cpp:

(WebKit::WebPageOverlay::actionContextForResultAtPoint): Use return value instead of out argument.

  • WebProcess/WebPage/WebPageOverlay.h: Update for above.
  • WebProcess/WebPage/glib/WebPageGLib.cpp:

(WebKit::WebPage::getPlatformEditorState const): Use makeSimpleRange.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::computeEditableRootHasContentAndPlainText): Use makeSimpleRange.
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Removed unneeded null checks that
are already done by makeSimpleRange.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Use makeSimpleRange.
(WebKit::WebPage::requestDictationContext): Ditto.
(WebKit::WebPage::autocorrectionContext): Ditto.
(WebKit::linkIndicatorPositionInformation): Use makeRangeSelectingNodeContents.
(WebKit::dataDetectorLinkPositionInformation): Ditto.
(WebKit::WebPage::requestDocumentEditingContext): Use makeSimpleRange.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performImmediateActionHitTestAtLocation): Update for change to the
actionContextForResultAtPoint return value.

Source/WebKitLegacy/ios:

  • WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame wordAtPoint:]): Use makeSimpleRange.

  • WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Use document
marker range function.
(-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
(+[DOMRange rangeForFirstPosition:second:]): Use makeSimpleRange.

Source/WebKitLegacy/mac:

  • DOM/DOMUIKitExtensions.mm:

(-[DOMNode rangeOfContainingParagraph]): Use makeSimpleRange.

  • WebView/WebFrame.mm:

(-[WebFrame _characterRangeAtPoint:]): Update since rangeAtPoint takes a SimpleRange.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use document marker range function.

  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _defaultAnimationController]): Use makeRangeSelectingNodeContents.
(-[WebImmediateActionController _animationControllerForDataDetectedLink]): Ditto.

Source/WebKitLegacy/win:

  • AccessibleTextImpl.cpp:

(AccessibleText::scrollSubstringTo): Use makeSimpleRange.

6:40 AM Changeset in webkit [265175] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit

Unreviewed, reverting r265171.
​https://bugs.webkit.org/show_bug.cgi?id=215060

broke 2 mac api tests

Reverted changeset:

"[Mac] Add Experimental Feature preference for SW VP9"
​https://bugs.webkit.org/show_bug.cgi?id=215043
​https://trac.webkit.org/changeset/265171

1:02 AM Changeset in webkit [265174] by Megan Gardner
  • 2 edits in trunk/Source/WebKit

Unable to select multiple lines of vertical text correctly
​https://bugs.webkit.org/show_bug.cgi?id=213671
<rdar://problem/53753636>

Reviewed by Darin Adler.

In order to make for a better text selection experience, we pulled the selection position
down to be on the last line selectable, rather than snap the selection to a single position.
This made for a better selection experience on small text, but we failed to take
vertical text into account, and a user is locked into only selecting vertical text that ends below the
other anchor point of the selection. We should have the same behavior for vertical text, but correctly
calculated for X instead of Y.
This does not fix all cases, but it fixes the most glaring cases.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeForPointInRootViewCoordinates):

Note: See TracTimeline for information about the timeline view.