⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 18, 2020:

9:03 PM Changeset in webkit [265848] by Lauro Moura
  • 4 edits in trunk/LayoutTests

[GTK][WPE] Gardening

Unreviewed test gardening.

  • platform/glib/TestExpectations:
  • platform/wpe/TestExpectations:
  • platform/wpe/webgl/1.0.3/conformance/context/methods-expected.txt:

Rebaselined after r265711.

8:15 PM Changeset in webkit [265847] by Hector Lopez
  • 6 edits in trunk/LayoutTests

[ macOS iOS ] fast/text/emoji-gender* text expectations change
​https://bugs.webkit.org/show_bug.cgi?id=215636

Unreviewed test gardening.

  • TestExpectations:
  • platform/glib/TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
7:34 PM Changeset in webkit [265846] by Jonathan Bedard
  • 5 edits
    1 add in trunk

[run-webkit-tests] Rosetta specific test expectations
​https://bugs.webkit.org/show_bug.cgi?id=215633
<rdar://problem/67353771>

Reviewed by Darin Adler.

Tools:

  • Scripts/webkitpy/port/mac.py:

(MacPort.expectations_dict): Add special case for Rosetta expectations.

  • Scripts/webkitpy/port/mac_unittest.py:

(MacTest.test_rosetta_expectations):

LayoutTests:

  • platform/mac/TestExpectations: Move Rosetta expectations.
  • platform/mac/TestExpectationsRosetta: Added.
7:24 PM Changeset in webkit [265845] by Chris Dumez
  • 5 edits in trunk

AudioBuffer.duration should use double precision
​https://bugs.webkit.org/show_bug.cgi?id=215632

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-expected.txt:

Source/WebCore:

AudioBuffer.duration should use double precision:

No new tests, rebaselined existing test.

  • Modules/webaudio/AudioBuffer.h:

(WebCore::AudioBuffer::duration const):

  • Modules/webaudio/AudioBuffer.idl:
6:28 PM Changeset in webkit [265844] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Rename replaceAllChildren to replaceAllChildrenWithNewText
​https://bugs.webkit.org/show_bug.cgi?id=215634

Reviewed by Darin Adler.

Renamed ContainerNode::replaceAllChildren to replaceAllChildrenWithNewText and changed
the type of Argument from Ref<Node>&& to const String&.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAllChildrenWithNewText):

  • dom/ContainerNode.h:
  • dom/Node.cpp:

(WebCore::Node::setTextContent):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):

5:59 PM Changeset in webkit [265843] by Alan Coon
  • 1 copy in tags/Safari-610.1.28

Tag Safari-610.1.28.

5:54 PM Changeset in webkit [265842] by Andres Gonzalez
  • 12 edits in trunk

Fix for accessibility/mac/aria-expanded-notifications.html in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=215613

Reviewed by Darin Adler.

Source/WebCore:

Test: accessibility/mac/aria-expanded-notifications.html.

Refactored AXObjectCache::handleAriaExpandedChange so that it doesn't
call into AccessibilityObject to handle the notification, to then call
into AXObjectCache again. The new implementation is cleaner and more
straightforward.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::updateIsolatedTree): Updates the isolated tree
on the row expanded/collapsed-related notifications.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsRowCountChange const): Added.

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityObjectInterface.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
Deleted, not needed any longer since it is handled in AXObjectCache where
it should.

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData): Caches the
supportsRowCountChange property.
(WebCore::AXIsolatedObject::handleAriaExpandedChanged): Deleted, not
needed any longer.

  • accessibility/isolatedtree/AXIsolatedObject.h:

LayoutTests:

  • accessibility/mac/aria-expanded-notifications-expected.txt:
  • accessibility/mac/aria-expanded-notifications.html: Removed unnecessary

call to accessibilityController.focusedElement. Some code cleanup.

4:49 PM Changeset in webkit [265841] by commit-queue@webkit.org
  • 33 edits in trunk

[WebGL2] Various parameters should be non-nullable in IDL
​https://bugs.webkit.org/show_bug.cgi?id=215616

Patch by James Darpinian <James Darpinian> on 2020-08-18
Reviewed by Kenneth Russell.

Source/WebCore:

Fixes 5 conformance tests:
conformance/misc/error-reporting.html
conformance/misc/null-object-behaviour.html
conformance/misc/bad-arguments-test.html
conformance/textures/misc/tex-sub-image-2d-bad-args.html
conformance/programs/get-active-test.html

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::attachShader):
(WebCore::WebGLRenderingContextBase::bindAttribLocation):
(WebCore::WebGLRenderingContextBase::compileShader):
(WebCore::WebGLRenderingContextBase::detachShader):
(WebCore::WebGLRenderingContextBase::getActiveAttrib):
(WebCore::WebGLRenderingContextBase::getActiveUniform):
(WebCore::WebGLRenderingContextBase::getAttachedShaders):
(WebCore::WebGLRenderingContextBase::getAttribLocation):
(WebCore::WebGLRenderingContextBase::getProgramParameter):
(WebCore::WebGLRenderingContextBase::getProgramInfoLog):
(WebCore::WebGLRenderingContextBase::getShaderParameter):
(WebCore::WebGLRenderingContextBase::getShaderInfoLog):
(WebCore::WebGLRenderingContextBase::getShaderSource):
(WebCore::WebGLRenderingContextBase::getUniform):
(WebCore::WebGLRenderingContextBase::getUniformLocation):
(WebCore::WebGLRenderingContextBase::linkProgram):
(WebCore::WebGLRenderingContextBase::shaderSource):
(WebCore::WebGLRenderingContextBase::validateProgram):

  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGLRenderingContextBase.idl:
  • inspector/InspectorShaderProgram.cpp:

(WebCore::InspectorShaderProgram::updateShader):

LayoutTests:

  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost.html:
  • fast/canvas/webgl/error-reporting-expected.txt:
  • fast/canvas/webgl/error-reporting.html:
  • fast/canvas/webgl/get-active-test-expected.txt:
  • fast/canvas/webgl/get-active-test.html:
  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html:
  • fast/canvas/webgl/null-object-behaviour-expected.txt:
  • fast/canvas/webgl/null-object-behaviour.html:
  • inspector/canvas/recording-webgl-frameCount.html:
  • inspector/canvas/recording-webgl-full-expected.txt:
  • inspector/canvas/recording-webgl-full.html:
  • inspector/canvas/recording-webgl-memoryLimit.html:
  • inspector/canvas/recording-webgl-snapshots.html:
  • inspector/canvas/recording-webgl2-frameCount.html:
  • inspector/canvas/recording-webgl2-full.html:
  • inspector/canvas/recording-webgl2-memoryLimit.html:
  • inspector/canvas/recording-webgl2-snapshots.html:
  • inspector/canvas/resources/recording-webgl.js:

(load):

  • webgl/2.0.0/conformance/misc/bad-arguments-test-expected.txt:
  • webgl/2.0.0/conformance/misc/error-reporting-expected.txt:
  • webgl/2.0.0/conformance/misc/null-object-behaviour-expected.txt:
  • webgl/2.0.0/conformance/programs/get-active-test-expected.txt:
  • webgl/2.0.0/conformance/state/gl-object-get-calls-expected.txt:
  • webgl/2.0.0/conformance/textures/misc/tex-sub-image-2d-bad-args-expected.txt:
  • webgl/2.0.0/conformance2/state/gl-object-get-calls-expected.txt:
4:44 PM Changeset in webkit [265840] by ysuzuki@apple.com
  • 2 edits in trunk/Tools

Unreviewed, contributors.json is broken

  • Scripts/webkitpy/common/config/contributors.json:
4:22 PM Changeset in webkit [265839] by dino@apple.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Adding some Google folks to contributors.

  • Scripts/webkitpy/common/config/contributors.json:
4:15 PM Changeset in webkit [265838] by Chris Dumez
  • 5 edits in trunk

PannerNode's rolloffFactor should be clamped to [0, 1] internally when distanceModel is "linear"
​https://bugs.webkit.org/show_bug.cgi?id=215625

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:

Source/WebCore:

PannerNode's rolloffFactor should be clamped to [0, 1] internally when distanceModel is "linear":

No new tests, rebaselined existing test.

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::setRolloffFactor):

  • platform/audio/Distance.cpp:

(WebCore::DistanceEffect::linearGain):

4:01 PM Changeset in webkit [265837] by Darin Adler
  • 2 edits in trunk/Websites/webkit.org
  • languages.md: Fixed "Movaje" typo.
3:51 PM Changeset in webkit [265836] by Chris Dumez
  • 4 edits in trunk

ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext
​https://bugs.webkit.org/show_bug.cgi?id=215624

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

  • web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:

Source/WebCore:

ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext.
If the context is an OfflineAudioContext, then it should pause processing until the script has finished
execution. This aligns our behavior with Blink and helps us pass more WPT tests.

No new tests, rebaselined existing test.

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):

3:18 PM Changeset in webkit [265835] by commit-queue@webkit.org
  • 4 edits in trunk

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
​https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(TestWebKitAPI::TEST):

2:44 PM Changeset in webkit [265834] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[Catalyst] Video should pause automatically when switching desktops
​https://bugs.webkit.org/show_bug.cgi?id=215620

Reviewed by Jer Noble.

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm: Don't override resetRestrictions

on Catalyst so we don't pause video in the background.

2:24 PM Changeset in webkit [265833] by commit-queue@webkit.org
  • 11 edits
    1 copy
    4 adds in trunk

[WebGL2] Pass user-defined-properties-on-context.html layout test
​https://bugs.webkit.org/show_bug.cgi?id=215433

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-08-18
Reviewed by Yusuke Suzuki.

Source/WebCore:

Keep the canvas' rendering context alive from the canvas itself by
adding a custom mark function for HTMLCanvasElement, and adding a
new GenerateIsReachable=ImplCanvasBase extended IDL attribute,
used from all rendering context types (2D, WebGL, and WebGPU).

This patch does not touch OffscreenCanvas since the implementation
there seems to be incomplete and there are no associated tests of
GC behavior.

Tests: fast/canvas/2d.context.expando.html

webgpu/expando-properties.html

  • Modules/webgpu/GPUCanvasContext.idl:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: Copied from Source/WebCore/html/canvas/WebGLRenderingContext.idl.

(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.json:
  • html/HTMLCanvasElement.idl:
  • html/canvas/WebGL2RenderingContext.idl:
  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

Rebaseline user-defined-properties-on-context.html, which is now
fully passing.

Add tests of expando properties on 2D and WebGPU contexts. Add a
FIXME to the WebGPU test, as that specification no longer defines
a canvas rendering context.

  • fast/canvas/2d.context.expando-expected.txt: Added.
  • fast/canvas/2d.context.expando.html: Added.
  • webgl/2.0.0/conformance/context/user-defined-properties-on-context-expected.txt:
  • webgpu/expando-properties-expected.txt: Added.
  • webgpu/expando-properties.html: Added.
2:13 PM Changeset in webkit [265832] by Chris Dumez
  • 4 edits in trunk

WaveShaperNode.curve setter should create a copy of the input array
​https://bugs.webkit.org/show_bug.cgi?id=215615

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that all checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

Source/WebCore:

WaveShaperNode.curve setter should create a copy of the input array, so that follow-up modifications
of the array by the JS do not impact audio processing:

No new tests, rebaselined existing test.

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::setCurve):

1:58 PM Changeset in webkit [265831] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r262381): replaceChildren should not use DeferChildrenChanged::No
​https://bugs.webkit.org/show_bug.cgi?id=215600

Reviewed by Antti Koivisto.

It's not correct to use DeferChildrenChanged::No when the new node may have an old parent.
Use DeferChildrenChanged::Yes instead.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAllChildren): Added a release assertion to make sure
people don't start using this function incorrectly in the future.
(WebCore::ContainerNode::replaceChildren): Fixed the bug.

1:46 PM Changeset in webkit [265830] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Update byte offsets in JSString.h comment
​https://bugs.webkit.org/show_bug.cgi?id=215621

Reviewed by Yusuke Suzuki.

  • runtime/JSString.h:
1:22 PM Changeset in webkit [265829] by Karl Rackler
  • 2 edits in trunk/LayoutTests

Disable plug-in tests on Apple Silicon
Updating test expectation in include Rosetta

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:12 PM Changeset in webkit [265828] by Karl Rackler
  • 2 edits in trunk/LayoutTests

rdar://66861801 ([ Layout Tests] REGRESSION (r265487): svg/W3C-I18N/tspan-direction-rtl.svg is a constant failure)
Updating expectations in include Rosetta.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
1:07 PM Changeset in webkit [265827] by Darin Adler
  • 1 edit
    1 add in trunk/Websites/webkit.org

Document versions of C++ and Python
​https://bugs.webkit.org/show_bug.cgi?id=215191

Reviewed by Jonathan Bedard.

  • languages.md: Added.
10:53 AM Changeset in webkit [265826] by Hector Lopez
  • 2 edits in trunk/LayoutTests

REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215614

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:08 AM Changeset in webkit [265825] by Karl Rackler
  • 2 edits in trunk/LayoutTests

rdar://67289434 ([ Rosetta Layout Tests ] REGRESSION (r265701): [ BigSur ] 3 webaudio/the-audio-api/the-audioparam-interface tests are a constant failure)
Should skip this only on Rosetta, not all Intel Big Sur Macs

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:00 AM Changeset in webkit [265824] by Chris Dumez
  • 11 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline webaudio WPT tests that are marked as flaky.

  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:
9:59 AM Changeset in webkit [265823] by Simon Fraser
  • 9 edits in trunk

Turn off wheel event regions until we need them
​https://bugs.webkit.org/show_bug.cgi?id=215586

Reviewed by Darin Adler.
Source/WebCore:

Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.

  • page/scrolling/ScrollingTree.cpp:
  • page/scrolling/ScrollingTree.h:
  • page/scrolling/mac/ScrollingTreeMac.h:
  • page/scrolling/mac/ScrollingTreeMac.mm:

Source/WTF:

Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.

  • wtf/PlatformEnableCocoa.h:

LayoutTests:

Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.

  • platform/mac-wk2/TestExpectations:
9:56 AM Changeset in webkit [265822] by youenn@apple.com
  • 8 edits in trunk

Update platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html to account for low latency code path
​https://bugs.webkit.org/show_bug.cgi?id=215601

Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing/updated test.

  • testing/Internals.cpp:

(WebCore::Internals::supportsVCPEncoder):
In case low latency code path is enabled, supportsVCPEncoder should return true.

LayoutTests:

Update test to check software encoder for both baseline and high profiles.
Move baseline/high profile selection routines to routines.js.

  • platform/mac/webrtc/captureCanvas-webrtc-software-encoder-expected.txt:
  • platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:
  • webrtc/h264-baseline.html:
  • webrtc/h264-high.html:
  • webrtc/routines.js:
9:49 AM Changeset in webkit [265821] by Karl Rackler
  • 2 edits in trunk/LayoutTests

rdar://67281310 REGRESSION (r265639): [ BigSur ] 11 canvas layout tests are a constant failure)
Should skip this only on Rosetta, not all Intel Big Sur Macs
Clean up arm64 only gardening.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
9:36 AM Changeset in webkit [265820] by Simon Fraser
  • 16 edits
    1 copy
    1 add in trunk

REGRESSION (Async overflow scrolling): No rubberbanding in overflow:scroll in the wheel event region
​https://bugs.webkit.org/show_bug.cgi?id=215598
<rdar://problem/64895442>

Reviewed by Darin Adler.
Source/WebCore:

Scrolling in overflow:scroll inside the non-fast event region (e.g. inside an ancestor with a wheel event
handler) happens via ScrollAnimatorMac::handleWheelEvent() which calls ScrollableArea::setScrollOffsetFromAnimation()
which bounces to the scrolling thread via RenderLayer::requestScrollPositionUpdate(). We were clamping the
scroll offset here, thus disallowing the overscrolled offsets required for rubberbanding.

Fix is to allow clamping for user scrolls. Also add more logging.

Test: fast/scrolling/mac/rubberband-overflow-in-wheel-region.html

  • dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleWheelEvent):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

LayoutTests:

Remove an unneeded var successfullyParsed = true in existing tests.

New test that detect rubberbanding.

  • fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html:
  • fast/scrolling/mac/async-scroll-overflow-rtl.html:
  • fast/scrolling/mac/async-scroll-overflow-top-inset.html:
  • fast/scrolling/mac/async-scroll-overflow.html:
  • fast/scrolling/mac/hit-test-overflow-tiled-layer.html:
  • fast/scrolling/mac/move-node-in-overflow-scroll.html:
  • fast/scrolling/mac/overflow-scrolled-document.html:
  • fast/scrolling/mac/overflow-zoomed-document.html:
  • fast/scrolling/mac/overlapped-overflow-scroll.html:
  • fast/scrolling/mac/rubberband-overflow-in-wheel-region-expected.txt: Added.
  • fast/scrolling/mac/rubberband-overflow-in-wheel-region.html: Copied from LayoutTests/fast/scrolling/mac/overflow-scrolled-document.html.
9:31 AM Changeset in webkit [265819] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, null-deref fix after r265797.

MockAudioDestinationCocoa::tick() is calling AudioDestinationCocoa::inputProc()
with a null AudioTimeStamp struct so we need to deal with this.

  • platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestinationCocoa::render):

9:20 AM Changeset in webkit [265818] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS Mojave wk2 Debug ] fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215611

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:04 AM Changeset in webkit [265817] by aakash_jain@apple.com
  • 3 edits
    2 adds in trunk/Tools

Develop a mechanism to unsubscribe from ews emails
​https://bugs.webkit.org/show_bug.cgi?id=215585

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/emails.json: Added.
  • BuildSlaveSupport/ews-build/send_email.py:

(get_email_ids):
(send_email_to_patch_author): Do not email patch authors whose email is in unsubscribe list.
(send_email_to_bot_watchers):

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_new_build_failure):
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures):

  • BuildSlaveSupport/ews-build/email_unittest.py: Added unit-tests.

(EmailsDotJSONTest.test_valid_emails_json):
(EmailsDotJSONTest.test_emails_json_required_categories_present):

9:01 AM Changeset in webkit [265816] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit

[Mac] Unhandled keyDown: events cause a system beep in full screen mode
​https://bugs.webkit.org/show_bug.cgi?id=215596
<rdar://problem/65823962>

Reviewed by Darin Adler.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController noResponderFor:]):

8:39 AM Changeset in webkit [265815] by Hector Lopez
  • 3 edits in trunk/LayoutTests

[ macOS wk1 iOS ] imported/w3c/web-platform-tests/IndexedDB/transaction_bubble-and-capture.htm is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215608

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac-wk1/TestExpectations:
8:16 AM Changeset in webkit [265814] by youenn@apple.com
  • 3 edits in trunk/Source/WebKit

NetworkSocketChannel should delay sending back error message as done by NetworkSocketStream
​https://bugs.webkit.org/show_bug.cgi?id=215563

Reviewed by Alex Christensen.

Apply same policy as NetworkSocketStream in case of WebSocket connection error.
Covered by http/tests/websocket/tests/hybi/closed-port-delay.html with NSURLSession WebSocket code path.

  • NetworkProcess/NetworkSocketChannel.cpp:

(WebKit::NetworkSocketChannel::NetworkSocketChannel):
(WebKit::NetworkSocketChannel::didClose):
(WebKit::NetworkSocketChannel::didReceiveMessageError):
(WebKit::NetworkSocketChannel::sendDelayedError):

  • NetworkProcess/NetworkSocketChannel.h:
8:09 AM Changeset in webkit [265813] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS wk2 ] webgpu/whlsl/do-while-loop-break.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215606

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
7:45 AM Changeset in webkit [265812] by Antti Koivisto
  • 4 edits in trunk

The CSS specificity of :host() pseudo-classes is wrong
​https://bugs.webkit.org/show_bug.cgi?id=202494
<rdar://problem/66292568>

Reviewed by Anders Carlsson.

Source/WebCore:

​https://drafts.csswg.org/css-scoping/#host-selector

“The specificity of :host() is that of a pseudo-class, plus the specificity of its argument.”

  • css/CSSSelector.cpp:

(WebCore::simpleSelectorSpecificityInternal):

LayoutTests:

2:54 AM Changeset in webkit [265811] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update test baseline after r265749.

  • platform/gtk/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
1:45 AM Changeset in webkit [265810] by youenn@apple.com
  • 5 edits in trunk/Source/WebCore

Add a JS built-in routine to mark a promise as handled
​https://bugs.webkit.org/show_bug.cgi?id=215558

Reviewed by Darin Adler.

Wrap long line of code inside a method to ease code readability.
No change of behavior.

  • Modules/streams/ReadableStream.js:

(pipeThrough):

  • Modules/streams/ReadableStreamInternals.js:

(readableStreamError):
(readableStreamReaderGenericRelease):

  • Modules/streams/StreamInternals.js:

(markPromiseAsHandled):
(shieldingPromiseResolve):

  • Modules/streams/WritableStreamInternals.js:

(setUpWritableStreamDefaultWriter):
(writableStreamRejectCloseAndClosedPromiseIfNeeded):
(writableStreamDefaultWriterEnsureClosedPromiseRejected):
(writableStreamDefaultWriterEnsureReadyPromiseRejected):

1:03 AM Changeset in webkit [265809] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GLib gardening. Skip more tests using plugins after r265753

  • platform/glib/TestExpectations:

Aug 17, 2020:

7:48 PM Changeset in webkit [265808] by Karl Rackler
  • 2 edits in trunk/LayoutTests

REGRESSION (r265701): [ BigSur ] 3 webaudio/the-audio-api/the-audioparam-interface tests are a constant failure)
rdar://67289434

Unreviewed test gardening.

  • platform/mac/TestExpectations:
7:37 PM Changeset in webkit [265807] by Hector Lopez
  • 2 edits in trunk/LayoutTests

ASSERTION FAILURE: WebKit::AuthenticationManager::initializeConnection(IPC::Connection *)_block_invoke
​https://bugs.webkit.org/show_bug.cgi?id=215025

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
7:31 PM Changeset in webkit [265806] by Lauro Moura
  • 3 edits in trunk/LayoutTests

[GTK][WPE] Update some expectations after closed bugs

Unreviewed test gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
7:22 PM Changeset in webkit [265805] by Russell Epstein
  • 73 edits
    3 adds in branches/safari-610.1-branch

Cherry-pick r265749. rdar://problem/67284454

JSDOMConstructorNotConstructable should be a constructor
​https://bugs.webkit.org/show_bug.cgi?id=215554
<rdar://problem/65770688>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/FileAPI/file/send-file-form-expected.txt:
  • web-platform-tests/FileAPI/file/send-file-form-iso-2022-jp.tentative-expected.txt:
  • web-platform-tests/FileAPI/file/send-file-form-utf-8-expected.txt:
  • web-platform-tests/FileAPI/file/send-file-form-windows-1252.tentative-expected.txt:
  • web-platform-tests/FileAPI/file/send-file-form-x-user-defined.tentative-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-constructable-baseURL.tentative-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-constructable-disabled-regular-sheet-insertion-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-constructable-disallow-import.tentative-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-constructable-duplicate-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-constructable-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-modify-after-removal-expected.txt:
  • web-platform-tests/custom-elements/Document-createElement-expected.txt:
  • web-platform-tests/custom-elements/Document-createElementNS-expected.txt:
  • web-platform-tests/custom-elements/HTMLElement-attachInternals-expected.txt:
  • web-platform-tests/custom-elements/HTMLElement-constructor-expected.txt:
  • web-platform-tests/custom-elements/builtin-coverage-expected.txt:
  • web-platform-tests/custom-elements/customized-built-in-constructor-exceptions-expected.txt:
  • web-platform-tests/custom-elements/htmlconstructor/newtarget-expected.txt:
  • web-platform-tests/custom-elements/parser/serializing-html-fragments-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLAreaElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLBaseElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLButtonElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLCanvasElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLDataElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLDetailsElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLEmbedElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLFieldSetElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLImageElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLLIElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLLabelElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLMapElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLMediaElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLMetaElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLMeterElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLModElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLOListElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLOptGroupElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLParamElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLProgressElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLQuoteElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLSlotElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLStyleElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLTableCellElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLTableColElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLTimeElement-expected.txt:
  • web-platform-tests/custom-elements/upgrading/Document-importNode-expected.txt:
  • web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt:
  • web-platform-tests/dom/nodes/Node-appendChild-cereactions-vs-script.window-expected.txt:
  • web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:
  • web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:
  • web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub-expected.txt:
  • web-platform-tests/service-workers/service-worker/data-transfer-files.https-expected.txt:
  • web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt:
  • web-platform-tests/user-timing/mark-entry-constructor.any-expected.txt:
  • web-platform-tests/user-timing/mark-entry-constructor.any.worker-expected.txt:
  • web-platform-tests/user-timing/structured-serialize-detail.any-expected.txt:
  • web-platform-tests/user-timing/structured-serialize-detail.any.worker-expected.txt:
  • web-platform-tests/webrtc/RTCIceTransport-extension.https-expected.txt:

Source/WebCore:

Test: js/dom/window-is-constructor.html

While JSDOMConstructorNotConstructable throws an error, still it should be a constructor, which means,
IsConstructor(JSDOMConstructorNotConstructable) should be true. To fix it, we add getConstructData
which configures a function throwing an error.

  • bindings/js/JSDOMConstructorNotConstructable.h:

LayoutTests:

  • editing/async-clipboard/clipboard-interfaces-expected.txt:
  • editing/undo-manager/undo-manager-interfaces-expected.txt:
  • fast/dom/MutationObserver/mutation-record-constructor-expected.txt:
  • http/wpt/html/browsers/the-window-object/window-is-constructor-expected.txt: Added.
  • http/wpt/html/browsers/the-window-object/window-is-constructor.html: Added.
  • js/interface-objects-expected.txt:
  • performance-api/paint-timing/paint-timing-apis-expected.txt:
  • performance-api/performance-observer-api-expected.txt:
  • performance-api/performance-timeline-api-expected.txt:
  • performance-api/resource-timing-apis-expected.txt:
  • performance-api/user-timing-apis-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLInputElement-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:22 PM Changeset in webkit [265804] by Russell Epstein
  • 2 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265774. rdar://problem/67284328

[Cocoa] Avoid waiting for Launch Services on every load
​https://bugs.webkit.org/show_bug.cgi?id=215569

Reviewed by Darin Adler.

Currently, we are waiting for the Launch Services database to be present on every load in the WebContent process.
It should be sufficient to wait only on the first load. Since we now are waiting only once per WebContent process,
increase the maximum wait time from 1s to 5s.

No new tests, covered by existing tests.

  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::platformDidReceiveLoadParameters):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:22 PM Changeset in webkit [265803] by Russell Epstein
  • 6 edits in branches/safari-610.1-branch/Source

Cherry-pick r265743. rdar://problem/67284428

Scrolling sync changes in r261985 regressed CPU usage by ~2 ms/s
​https://bugs.webkit.org/show_bug.cgi?id=215529
<rdar://problem/66866163>

Reviewed by Geoff Garen.
Source/WebCore:

r261985 added two code paths that wake up the scrolling thread on every
rendering update (triggered by displayDidRefresh()). One is a ping from
the EventDispatcher thread, the other is a wake-and-block from the main
thread. If the scrolling thread isn't active (no wheel events received recently),
we can avoid both of these to reduce the number of CPU core wakeups.

  • page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::isRecentlyActive): (WebCore::ScrollingTree::setRecentlyActive):
  • page/scrolling/ScrollingTree.h:
  • page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::willStartRenderingUpdate): (WebCore::ThreadedScrollingTree::displayDidRefresh):

Source/WebKit:

r261985 added two code paths that wake up the scrolling thread on every
rendering update (triggered by displayDidRefresh()). One is a ping from
the EventDispatcher thread, the other is a wake-and-block from the main
thread. If the scrolling thread isn't active (no wheel events received recently),
we can avoid both of these to reduce the number of CPU core wakeups.

  • WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::wheelEvent):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:21 PM Changeset in webkit [265802] by Russell Epstein
  • 4 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265727. rdar://problem/67284319

Revert r263551
​https://bugs.webkit.org/show_bug.cgi?id=215530
<rdar://problem/66961066>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-14
Reviewed by Geoffrey Garen.

I was hoping to fix many developers' bugs, but it caused hangs and more hangs, so back to the status quo.
​https://bugs.webkit.org/show_bug.cgi?id=203547 will fix this the right way in the hopefully-not-too-distant future.

  • UIProcess/API/APIHTTPCookieStore.cpp: (API::HTTPCookieStore::setCookies): (API::HTTPCookieStore::registerForNewProcessPoolNotifications): (API::HTTPCookieStore::flushDefaultUIProcessCookieStore):
  • UIProcess/API/APIHTTPCookieStore.h:
  • UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm: (API::HTTPCookieStore::flushDefaultUIProcessCookieStore):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:21 PM Changeset in webkit [265801] by Russell Epstein
  • 2 edits in branches/safari-610.1-branch/Source/WebCore

Cherry-pick r265723. rdar://problem/67284292

Crash inside FrameLoader::defaultRequestCachingPolicy (null DocumentLoader)
<rdar://problem/42167093> and ​https://bugs.webkit.org/show_bug.cgi?id=215527

Reviewed by Darin Adler.

We have CrashTracer data, but despite my best efforts no way of reproducing.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultRequestCachingPolicy): If a PingLoader is sending a CSP violation report sometime after part of the Document's lifecycle, the FrameLoader as a null DocumentLoader here. Like everywhere else in FrameLoader, null check it.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:21 PM Changeset in webkit [265800] by Russell Epstein
  • 2 edits in branches/safari-610.1-branch/Source/WebCore

Cherry-pick r265722. rdar://problem/67284309

RenderTextControlSingleLine::scroll* functions should not call Element::scroll* on the inner text content
​https://bugs.webkit.org/show_bug.cgi?id=215516
<rdar://problem/64739768>

Reviewed by Simon Fraser.

Normally the RenderBox::content*, border*, padding* and scroll* functions grab the geometry information from the renderer itself.
The clients of these functions expect the geometry data to be consistent with the rest of the rendering context
(e.g coordinates are in the coordinate system of the containing block, paint time operations are not applied etc).
Also these functions are supposed to be const. They should not mutate the geometry or the render tree itself.
Forwarding ::scroll* calls to Element::scroll* can't guarantee neither of these above.

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::scrollWidth const): (WebCore::RenderTextControlSingleLine::scrollHeight const): (WebCore::RenderTextControlSingleLine::scrollLeft const): (WebCore::RenderTextControlSingleLine::scrollTop const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:21 PM Changeset in webkit [265799] by Russell Epstein
  • 5 edits in branches/safari-610.1-branch

Cherry-pick r265645. rdar://problem/67285376

VoiceOver not able to invoke play button on some web sites.
​https://bugs.webkit.org/show_bug.cgi?id=215484
<rdar://problem/62729643>

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/ios-simulator/has-touch-event-listener.html.

We were checking for the presence of listeners for touchstart and touchend
events only. Now we check for the presence of any touch-related event listener.

  • accessibility/ios/AccessibilityObjectIOS.mm: (WebCore::AccessibilityObject::hasTouchEventListener const):

LayoutTests:

Expanded this test to check for all touch-related event listeners.

  • accessibility/ios-simulator/has-touch-event-listener-expected.txt:
  • accessibility/ios-simulator/has-touch-event-listener.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:21 PM Changeset in webkit [265798] by Russell Epstein
  • 3 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265427. rdar://problem/67284328

Add required entitlement for Catalyst
​https://bugs.webkit.org/show_bug.cgi?id=215244

Reviewed by Darin Adler.

The entitlement 'com.apple.private.webkit.use-xpc-endpoint' should be added to the WebContent process on Catalyst as well,
since it is needed on all Apple platforms. This entitlement is needed to support direct XPC communication between WebKit
processes, which is used to send the Launch Services database to the WebContent process from the Networking process. Also,
add some more logging related to this, to detect if it takes a long time for the WebContent process to receive the database.

  • Scripts/process-entitlements.sh:
  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::platformDidReceiveLoadParameters):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:16 PM Changeset in webkit [265797] by Chris Dumez
  • 28 edits
    2 copies in trunk

AudioContext.getOutputTimestamp() is missing
​https://bugs.webkit.org/show_bug.cgi?id=215591

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-getoutputtimestamp-expected.txt:

Source/WebCore:

AudioContext.getOutputTimestamp() is missing:

No new tests, rebaselined existing tests.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::getOutputTimestamp):

  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::render):

  • Modules/webaudio/AudioDestinationNode.h:
  • Modules/webaudio/AudioTimestamp.h: Copied from Source/WebCore/Modules/webaudio/AudioContext.h.
  • Modules/webaudio/AudioTimestamp.idl: Copied from Source/WebCore/Modules/webaudio/AudioContext.h.
  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::handlePreRenderTasks):
(WebCore::BaseAudioContext::outputPosition):

  • Modules/webaudio/BaseAudioContext.h:
  • Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::offlineRender):

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/AudioIOCallback.h:

(WebCore::AudioIOPosition::encode const):
(WebCore::AudioIOPosition::decode):

  • platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::machAbsoluteTimeToMonotonicTime):
(WebCore::AudioDestinationCocoa::render):
(WebCore::AudioDestinationCocoa::inputProc):

  • platform/audio/cocoa/AudioDestinationCocoa.h:

Source/WebKit:

  • GPUProcess/media/RemoteAudioDestinationManager.cpp:
  • WebProcess/GPU/media/RemoteAudioBusData.h:

(WebKit::RemoteAudioBusData::encode const):
(WebKit::RemoteAudioBusData::decode):

  • WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:

(WebKit::RemoteAudioDestinationProxy::renderBuffer):

7:12 PM Changeset in webkit [265796] by Lauro Moura
  • 2 edits in trunk/WebDriverTests

[WPE][WebDriver] Gardening some failures

Unreviewed test gardening.

7:07 PM Changeset in webkit [265795] by Hector Lopez
  • 3 edits in trunk/LayoutTests

WeakPtr threading assertion on editing/undo-manager/undo-manager-delete-stale-undo-items.html
​https://bugs.webkit.org/show_bug.cgi?id=215221

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations: expectation removal
  • platform/mac-wk2/TestExpectations: expectation removal
6:24 PM Changeset in webkit [265794] by Chris Dumez
  • 6 edits
    2 deletes in trunk

Improve channel mixing support in AudioBus
​https://bugs.webkit.org/show_bug.cgi?id=215597

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that all checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-channel-rules-expected.txt:

Source/WebCore:

Improve channel mixing support in AudioBus to match the specification:

Our implementation also matches Blink's:

No new tests, rebaselined existing test.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):
(WebCore::AudioBus::speakersSumFromByUpMixing):
(WebCore::AudioBus::speakersSumFromByDownMixing):

  • platform/audio/AudioBus.h:

LayoutTests:

Remove outdated test. A newer version of this test is present in web-platform-tests.

  • webaudio/audionode-channel-rules-expected.txt: Removed.
  • webaudio/audionode-channel-rules.html: Removed.
5:53 PM Changeset in webkit [265793] by Karl Rackler
  • 2 edits in trunk/LayoutTests

Removing added entry in error.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:49 PM Changeset in webkit [265792] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

Assert failure after r265715
​https://bugs.webkit.org/show_bug.cgi?id=215592

Reviewed by Darin Adler.

The change set r265715 introduced an assert failure in AuthenticationManager::initializeConnection. This
happens because after r265715 the new XPC event handler set in AuthenticationManager::initializeConnection,
will no longer be called on the main thread. This patch addresses this issue by dispatching this work on
the main thread.

No new tests, covered by existing tests.

  • Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:

(WebKit::AuthenticationManager::initializeConnection):

5:43 PM Changeset in webkit [265791] by Karl Rackler
  • 2 edits in trunk/LayoutTests

Adding BigSur to existing test expectations

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:53 PM Changeset in webkit [265790] by Russell Epstein
  • 24 edits in branches/safari-610.1-branch

Cherry-pick r265289. rdar://problem/66944320

Update event regions only once per frame
​https://bugs.webkit.org/show_bug.cgi?id=215132
<rdar://problem/66533779>

Reviewed by Darin Adler.

Source/WebCore:

Event regions (for touch-action, editable areas etc) were updated as part of
compositing updates, but we only need their output once per rendering update, so
move their computation out of RenderLayerCompositor::updateBackingAndHierarchy()
and into a new RenderLayer tree walk that is called from Page::doAfterUpdateRendering().

RenderLayerBacking stores a dirty bit to track when regions need to be updated.

Reduces the amount of time spent in rendering updates when scrolling on facebook.com
on iPad, which has lots of discontiguous touch-action regions.

  • dom/Document.cpp: (WebCore::Document::updateEventRegions):
  • dom/Document.h:
  • page/Frame.cpp: (WebCore::Frame::layerTreeAsText const):
  • page/Page.cpp: (WebCore::Page::doAfterUpdateRendering):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const): (WebCore::RenderLayerBacking::updateEventRegion):
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateEventRegions): (WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
  • rendering/RenderLayerCompositor.h:

LayoutTests:

Tests that dispatch mouseWheel events in a way that tests event regions need to wait
now for a rendering update. await UIHelper.animationFrame() is not enough, because
the function resumes inside a microtask at the end of the requestAnimationFrame callback,
which is before we've completed the rest of the rendering update, and thus before
the event regions have been updated.

In addition, await UIHelper.animationFrame() followed by eventSender calls to issue
wheel events actually trigger Page::updateRendering() re-entrancy, via the
WKBundlePageForceRepaint() in EventSendingController::mouseScrollByWithWheelAndMomentumPhases().

To fix this, add and use UIHelper.renderingUpdate(), which waits for a rAF and uses a setTimeout()
to get past the end of the current rendering update.

  • fast/scrolling/mac/absolute-in-overflow-scroll-dynamic-expected.html:
  • fast/scrolling/mac/absolute-in-overflow-scroll-dynamic.html:
  • fast/scrolling/mac/absolute-in-overflow-scroll.html:
  • fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html:
  • fast/scrolling/mac/async-scroll-overflow-rtl-zoomed.html:
  • fast/scrolling/mac/async-scroll-overflow-top-inset.html:
  • fast/scrolling/mac/async-scroll-overflow.html:
  • fast/scrolling/mac/clip-path-hit-test.html:
  • fast/scrolling/mac/move-node-in-overflow-scroll.html:
  • fast/scrolling/mac/overflow-scrolled-document.html:
  • fast/scrolling/mac/overflow-zoomed-document.html:
  • fast/scrolling/mac/overlapped-overflow-scroll.html:
  • resources/ui-helper.js: (window.UIHelper.async renderingUpdate):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:53 PM Changeset in webkit [265789] by Russell Epstein
  • 6 edits in branches/safari-610.1-branch/Source/WebCore

Cherry-pick r265232. rdar://problem/66944320

Add an EventRegions log channel
​https://bugs.webkit.org/show_bug.cgi?id=215092

Reviewed by Daniel Bates.

Add a log channel for EventRegions, add logging in some interesting places.

  • platform/Logging.h:
  • rendering/EventRegion.cpp: (WebCore::EventRegion::unite): (WebCore::EventRegion::uniteTouchActions): (WebCore::EventRegion::uniteEventListeners):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateEventRegion):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [265788] by Russell Epstein
  • 27 edits in branches/safari-610.1-branch/Source

Cherry-pick r265562. rdar://problem/66944332

Add the support to return to element fullscreen from picture-in-picture
​https://bugs.webkit.org/show_bug.cgi?id=215305

Reviewed by Jer Noble.

Source/WebCore:

When a container element enters fullscreen (with the fullscreen API), a descendant
video element will enter the video fullscreen standby state so that it can enter
picture-in-picture on application suspend (r226217). But we cannot restore
to that state from the picture-in-picture mode when we click the "restore" button
on the top-right corner of the PiP window. Instead, the video element will return
to the inline mode.

However, when a video element enters video fullscreen first and then enters
picture-in-picture, we can let the video restore to fullscreen by clicking the
"restore" button on the top-right corner of the picture-in-picture window.

The inconsistent behaviors may confuse users who are not aware of the difference
between the fullscreen API (or element fullscreen) and video fullscreen.

This patch enables the support to restore to element fullscreen from picture-in-picture
mode so that users can have a consistent experience on element fullscreen and
video fullscreen.

  • dom/FullscreenManager.h: Export requestFullscreenForElement() so that we can use it in WebKit code.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): (WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby):
  • html/HTMLMediaElement.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::prepareForVideoFullscreen): Add the interface to request a video element to be prepared for the video fullscreen standby state.
  • platform/cocoa/VideoFullscreenChangeObserver.h: Add prepareToExitFullscreen() and fullscreenWillReturnToInline().
  • platform/cocoa/VideoFullscreenModel.h: (WebCore::VideoFullscreenModelClient::hasVideoChanged): (WebCore::VideoFullscreenModelClient::videoDimensionsChanged): (WebCore::VideoFullscreenModelClient::prepareToExitPictureInPicture): Some minor clean-ups and add function prepareToExitPictureInPicture().
  • platform/ios/VideoFullscreenInterfaceAVKit.h:
  • platform/ios/VideoFullscreenInterfaceAVKit.mm: (VideoFullscreenInterfaceAVKit::cleanupFullscreen): (VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStop): (VideoFullscreenInterfaceAVKit::didStartPictureInPicture): (VideoFullscreenInterfaceAVKit::willStopPictureInPicture): (VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStopWithCompletionHandler): (VideoFullscreenInterfaceAVKit::setReadyToStopPictureInPicture): (VideoFullscreenInterfaceAVKit::willEnterStandbyFromPictureInPicture): (VideoFullscreenInterfaceAVKit::setWillEnterStandbyFromPictureInPicture): (VideoFullscreenInterfaceAVKit::fullscreenMayReturnToInline): Deleted. When we enter picture-in-picture, we need to save the state and be prepared to restore to element fullscreen if needed.

Before we exit picture-in-picture, if the "restore" button is clicked, we need
to notify the client to prepare for the picture-in-picture stop, and call
VideoFullscreenInterfaceAVKit::setReadyToStopPictureInPicture(true) when the client
is ready.

Based on those changes, a client (e.g., WKFullScreenWindowControllerVideoFullscreenModelClient)
can coordinate with WKFullScreenWindowController to implement the "restore to
element fullscreen" feature.

  • platform/ios/WebVideoFullscreenControllerAVKit.mm: (VideoFullscreenControllerContext::fullscreenWillReturnToInline): (VideoFullscreenControllerContext::fullscreenMayReturnToInline): Deleted.

Source/WebKit:

This patch replaces WKFullScreenViewControllerVideoFullscreenModelClient
with WKFullScreenWindowControllerVideoFullscreenModelClient. We need to do
that because the instance of WKFullScreenViewControllerVideoFullscreenModelClient
will be destroyed after the container element exits fullscreen while the video
element enters picture-in-picture.

The instance of WKFullScreenWindowControllerVideoFullscreenModelClient
will always exist when the WKFullScreenWindowController instance is alive,
so that it can receive callbacks from the VideoFullscreenInterfaceAVKit instance
to implement the "return to element fullscreen from picture-in-picture" feature.

This patch supports the following transitions:
element fullscreen -> picture-in-picture (through user gestures)
element fullscreen -> picture-in-picture (through the PiP button)
picture-in-picture -> element fullscreen (when the tab is visible)
picture-in-picture -> element fullscreen (when the tab is invisible)
picture-in-picture -> element fullscreen (when the browser is in background)
picture-in-picture -> inline (when the browser is in foreground)
exit picture-in-picture when the browser is in background

  • UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: (WebKit::VideoFullscreenModelContext::fullscreenWillReturnToInline): (WebKit::VideoFullscreenModelContext::prepareToExitFullscreen): Notify clients to prepare for the stop of fullscreen/picture-in-picture. (WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID): Fix issues that increase the client count unnecessarily. (WebKit::VideoFullscreenManagerProxy::preparedToReturnToInline): Call m_page->fullscreenMayReturnToInline() earlier. (WebKit::VideoFullscreenManagerProxy::fullscreenMayReturnToInline): Ditto. (WebKit::VideoFullscreenManagerProxy::fullscreenWillReturnToInline): Notify VideoFullscreenManager to prepare for exiting picture-in-picture or video fullscreen and report the destination rectangle of the exit picture-in-picture or video fullscreen animations.
  • UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::requestEnterFullScreen):
  • UIProcess/WebFullScreenManagerProxy.h: Add a function requestEnterFullScreen() so that we can request an element to enter fullscreen from the UI process side.
  • UIProcess/ios/fullscreen/WKFullScreenViewController.h:
  • UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController initWithWebView:]): (-[WKFullScreenViewController dealloc]): (-[WKFullScreenViewController videoControlsManagerDidChange]): (-[WKFullScreenViewController setAnimatingViewAlpha:]): (-[WKFullScreenViewController _cancelAction:]): (WKFullScreenViewControllerVideoFullscreenModelClient::setParent): Deleted. (WKFullScreenViewControllerVideoFullscreenModelClient::setInterface): Deleted. (WKFullScreenViewControllerVideoFullscreenModelClient::interface const): Deleted. (-[WKFullScreenViewController willEnterPictureInPicture]): Deleted. (-[WKFullScreenViewController didEnterPictureInPicture]): Deleted. (-[WKFullScreenViewController failedToEnterPictureInPicture]): Deleted. Minor clean-ups and remove code related to WKFullScreenViewControllerVideoFullscreenModelClient.
  • UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h:
  • UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (WKFullScreenWindowControllerVideoFullscreenModelClient::setParent): (WKFullScreenWindowControllerVideoFullscreenModelClient::setInterface): (WKFullScreenWindowControllerVideoFullscreenModelClient::interface const): (-[WKFullScreenWindowController initWithWebView:]): (-[WKFullScreenWindowController dealloc]): (-[WKFullScreenWindowController enterFullScreen]): (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): (-[WKFullScreenWindowController requestEnterFullScreen]): (-[WKFullScreenWindowController requestExitFullScreen]): (-[WKFullScreenWindowController _completedExitFullScreen]): (-[WKFullScreenWindowController videoControlsManagerDidChange]): (-[WKFullScreenWindowController willEnterPictureInPicture]): (-[WKFullScreenWindowController didEnterPictureInPicture]): (-[WKFullScreenWindowController failedToEnterPictureInPicture]): (-[WKFullScreenWindowController prepareToExitPictureInPicture]): (-[WKFullScreenWindowController didExitPictureInPicture]): Add WKFullScreenWindowControllerVideoFullscreenModelClient and implement the support to "restore fullscreen from picture-in-picture".
  • WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::enterFullScreenForElement): (WebKit::WebFullScreenManager::requestEnterFullScreen):
  • WebProcess/FullScreen/WebFullScreenManager.h:
  • WebProcess/FullScreen/WebFullScreenManager.messages.in: Add the interface requestEnterFullScreen() and the corresponding IPC message.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::prepareForVideoFullscreen):
  • WebProcess/WebCoreSupport/WebChromeClient.h: Add the interface to prepare for video fullscreen standby. The web process can use this interface to create a VideoFullscreenManager instance to avoid the scenario that an IPC message comes from the VideoFullscreenManagerProxy but the VideoFullscreenManager instance is not constructed yet.
  • WebProcess/cocoa/VideoFullscreenManager.h:
  • WebProcess/cocoa/VideoFullscreenManager.messages.in:
  • WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::fullscreenWillReturnToInline): (WebKit::VideoFullscreenManager::fullscreenMayReturnToInline): Deleted. Rename fullscreenMayReturnToInline() to fullscreenWillReturnToInline(). In the UI process side, fullscreenMayReturnToInline() is used by VideoFullscreenManagerProxy to notify applications regarding UI changes (e.g., switch browser tabs).

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [265787] by Russell Epstein
  • 2 edits in branches/safari-610.1-branch/Source/ThirdParty/libwebrtc

Cherry-pick r265500. rdar://problem/66944395

Cherry-pick usrsctp 264ce452885bfed73348ba6b6f63693bc2f52a6e commit
​https://bugs.webkit.org/show_bug.cgi?id=215378
<rdar://problem/66788144>

Reviewed by Eric Carlson.

  • Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c: (sctp_handle_asconf):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [265786] by Russell Epstein
  • 2 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265270. rdar://problem/66944311

Unreviewed build fix after r265263
​https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [265785] by Russell Epstein
  • 2 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265263. rdar://problem/66944311

Limit 'com.apple.webkit.microphone' use to macOS and MacCatalyst
​https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>

Reviewed by Eric Carlson.

We only need the 'com.apple.webkit.microphone' Sandbox Extension at startup on
macOS and MacCatalyst (and even on those platforms, only until <rdar://problem/29448368>
is fixed).

We should not issue this extension on the iOS family of targets.

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [265784] by Russell Epstein
  • 14 edits
    2 adds in branches/safari-610.1-branch

Cherry-pick r265259. rdar://problem/66944362

AX: VoiceOver needs access to font styling at insertion point
​https://bugs.webkit.org/show_bug.cgi?id=215129
Source/WebCore:

<rdar://problem/65114972>

Reviewed by Darin Adler.

Give access to relevant font styling properties at the insertion point so that VoiceOver can speak them
when text commands alter styling.

Test: accessibility/mac/resolved-text-editing.html

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::resolvedEditingStyles const):
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityObjectInterface.h:
  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper _accessibilityResolvedEditingStyles]):
  • accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::resolvedEditingStyles const):
  • accessibility/isolatedtree/AXIsolatedObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (-[WebAccessibilityObjectWrapperBase baseAccessibilityResolvedEditingStyles]):
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools:

Reviewed by Darin Adler.

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::attributeValueAsync):

LayoutTests:

Reviewed by Darin Adler.

  • accessibility/mac/resolved-text-editing-expected.txt: Added.
  • accessibility/mac/resolved-text-editing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:24 PM Changeset in webkit [265783] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS wk1 ] webaudio/oscillator-square.html is a flaky failure
Nhttps://bugs.webkit.org/show_bug.cgi?id=215593

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
4:19 PM Changeset in webkit [265782] by Karl Rackler
  • 6 edits
    3 deletes in trunk

Unreviewed, reverting r265603.

Reverting per commiter because commit caused consisent crash
with test.

Reverted changeset:

"Font loads quickly followed by navigations may fail
indefinitely"
​https://bugs.webkit.org/show_bug.cgi?id=215435
​https://trac.webkit.org/changeset/265603

4:13 PM Changeset in webkit [265781] by Chris Dumez
  • 10 edits in trunk

AudioNode.disconnect() does not match the specification
​https://bugs.webkit.org/show_bug.cgi?id=215578

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-expected.txt:

Source/WebCore:

AudioNode.disconnect() did not match the specification. There were a lot of overloads in
the specification that we did not support:

No new tests, rebaselined existing tests.

  • Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::connect): Deleted.
(WebCore::AudioBasicInspectorNode::disconnect): Deleted.

  • Modules/webaudio/AudioBasicInspectorNode.h:
  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):

  • Modules/webaudio/AudioNode.h:

(WebCore::AudioNode::updatePullStatus):

  • Modules/webaudio/AudioNode.idl:
  • Modules/webaudio/AudioNodeOutput.h:

(WebCore::AudioNodeOutput::isConnectedTo const):

4:12 PM Changeset in webkit [265780] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[ macOS iOS ] svg/animations/smil-leak-element-instances-noBaseValRef.svg is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215353

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-08-17
Reviewed by Jon Lee.

GCController.collect() is flaky. Calling this function from JS does not
guarantee the memory of all the deallocated objects is garbage-collected.
Multiple calls to GCController.collect() may be invoked to overcome this
problem. Putting idle time before requesting the numberOfLiveNodes()
might be needed as well.

The test adds 100 <use> elements. Each of them references a <rect> element
and adds an <animate> element to animate the 'x' property. This is a big
number of objects to be allocated, deallocated and garbage collected. To
overcome the flakiness of GCController.collect(), three <use> elements
can be added instead. This number of objects should be enough to test the
SVG animated properties do not leak. And at the same time the test won't
exercise the flakiness of GCController.collect().

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • svg/animations/smil-leak-element-instances-noBaseValRef.svg:
4:01 PM Changeset in webkit [265779] by Russell Epstein
  • 8 edits in branches/safari-610.1-branch/Source

Versioning.

WebKit-7610.1.28

3:44 PM Changeset in webkit [265778] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Stop webkitpy from warning about not having a 64-bit git on Apple silicon
​https://bugs.webkit.org/show_bug.cgi?id=214718

Patch by Saagar Jha <​saagar@saagarjha.com> on 2020-08-17
Reviewed by Jonathan Bedard.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git._executable_is_64bit): Loosen 64-bit check to succeed on systems that aren't x86_64.

3:26 PM Changeset in webkit [265777] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS ] media/modern-media-controls/volume-down-support/volume-down-support.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215587

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:21 PM Changeset in webkit [265776] by Alan Coon
  • 1 copy in tags/Safari-610.1.27

Tag Safari-610.1.27.

3:10 PM Changeset in webkit [265775] by sbarati@apple.com
  • 17 edits
    5 adds in trunk

Have an OOB+SaneChain Array::Speculation
​https://bugs.webkit.org/show_bug.cgi?id=215487

Reviewed by Yusuke Suzuki.

JSTests:

  • microbenchmarks/oob-sane-chain-contiguous.js: Added.
  • microbenchmarks/oob-sane-chain-double-read-undefined.js: Added.
  • microbenchmarks/oob-sane-chain-double.js: Added.
  • microbenchmarks/oob-sane-chain-int32.js: Added.
  • stress/oob-sane-chain-negative-index.js: Added.

Source/JavaScriptCore:

This patch adds a new ArrayMode speculation in the DFG/FTL called OutOfBoundsSaneChain.
It allows us to do fast things when we go OOB, like simply return undefined.
This is because we install watchpoints on the prototype chain to ensure they
have no indexed properties. This patch implements OutOfBoundsSaneChain on
GetByVal over Int32/Double/Contiguous original JS arrays. We can extend it in
the future to non original JS arrays if we prove their prototype is Array.prototype.
To implement this properly, we also need to ensure that the index isn't negative,
as Array.prototype/Object.prototype may have negative indexed accessors. We
do this via speculation, and if we ever recompile, and see an exit because of
this, we will stop speculating OutOfBoundsSaneChain.

This is about 20% faster on crypto-md5-SP. And ~3-4x faster on the
microbenchmarks I created.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine const):
(JSC::DFG::arraySpeculationToString):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::isInBoundsSaneChain const):
(JSC::DFG::ArrayMode::isOutOfBoundsSaneChain const):
(JSC::DFG::ArrayMode::isOutOfBounds const):
(JSC::DFG::ArrayMode::isEffectfulOutOfBounds const):
(JSC::DFG::ArrayMode::isInBounds const):
(JSC::DFG::ArrayMode::isSaneChain const): Deleted.

  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::setSaneChainIfPossible):
(JSC::DFG::FixupPhase::convertToHasIndexedProperty):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileHasIndexedProperty):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:
  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):

2:54 PM Changeset in webkit [265774] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[Cocoa] Avoid waiting for Launch Services on every load
​https://bugs.webkit.org/show_bug.cgi?id=215569

Reviewed by Darin Adler.

Currently, we are waiting for the Launch Services database to be present on every load in the WebContent process.
It should be sufficient to wait only on the first load. Since we now are waiting only once per WebContent process,
increase the maximum wait time from 1s to 5s.

No new tests, covered by existing tests.

  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::platformDidReceiveLoadParameters):

2:35 PM Changeset in webkit [265773] by Fujii Hironori
  • 5 edits in trunk

[WTF] HashTable<Ref<K>, V>::HashTable(const HashTable& other) can't compile
​https://bugs.webkit.org/show_bug.cgi?id=215550

Reviewed by Darin Adler.

Source/WTF:

Even though the copy constructor takes a const HashTable
reference, RefHashTraits::assignToEmpty takes non-const Ref<P>. It
seems that RefHashTraits::assignToEmpty and
Ref::assignToHashTableEmptyValue are unnecessary. Just remove them.

  • wtf/HashTraits.h:

(WTF::RefHashTraits::assignToEmpty): Deleted.

  • wtf/Ref.h:

(WTF::Ref::assignToHashTableEmptyValue): Deleted.

Tools:

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):

2:16 PM Changeset in webkit [265772] by Hector Lopez
  • 3 edits in trunk/LayoutTests

[ macOS iOS ] media/track/track-in-band-style.html is a flaky timeout and failure
​https://bugs.webkit.org/show_bug.cgi?id=215583

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac/TestExpectations:
1:53 PM Changeset in webkit [265771] by Jonathan Bedard
  • 5 edits in trunk/Tools

[resultsdbpy]: Depend on webkitcorepy
​https://bugs.webkit.org/show_bug.cgi?id=215573
<rdar://problem/67250272>

Reviewed by Dewei Zhu.

  • Scripts/libraries/resultsdbpy/resultsdbpy/init.py:

(_maybe_add_webkitcorepy_path): Attempt to add. webkitcorepy to the. Python path.

  • Scripts/libraries/resultsdbpy/setup.py: Add webkitcorepy, remove webkitcorepy's dependencies.
  • Scripts/libraries/webkitcorepy/setup.py: Add six as a dependency.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Include. package name, bump version.
1:34 PM Changeset in webkit [265770] by Hector Lopez
  • 3 edits in trunk/LayoutTests

[ macOS iOS wk2 ] imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getStats.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215581

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
1:20 PM Changeset in webkit [265769] by Jonathan Bedard
  • 3 edits
    2 adds in trunk/Tools

[webkitcorepy] Add OutputCapture to webkitcorepy
​https://bugs.webkit.org/show_bug.cgi?id=215380
<rdar://problem/66846384>

Reviewed by Dewei Zhu.

Although webkitpy has an OutputCapture class, that class does not separate logging from
stdout and stderr, which makes the API less useful. This version of the OutputCapture class
is inspired by the one in webkitpy, but with a cleaner interface.

  • Scripts/libraries/webkitcorepy/README.md: Document usage of OutputCapture.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Export LoggerCapture, OutputCapture and

OutputDuplicate as API, bump version.

  • Scripts/libraries/webkitcorepy/webkitcorepy/output_capture.py: Added.

(LoggerCapture): Capture logs at some level for the duration of the interface.
(OutputCapture): Capture stdout, stderr and all logging channels for the duration of the interface.
(OutputCapture.ReplaceSysStream): Replace sys.stdout or sys.stderr for a block.
(OutputDuplicate): Context which can duplicate all output for a block of code. This is useful to both print and
capture logs.
(OutputDuplicate.Stream): File-like object that routes output to multiple file-like objects.

  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/output_capture_unittest.py: Added.

(LoggerCaptureTest):
(OutputCaptureTest):
(OutputOutputDuplicateTest):

12:54 PM Changeset in webkit [265768] by Fujii Hironori
  • 3 edits in trunk/Tools

[TestWebKitAPI] Some WTF_HashMap tests are failing if TestWTF is executed directly
​https://bugs.webkit.org/show_bug.cgi?id=215556

Reviewed by Darin Adler.

Some tests using RefLogger were failing if TestWTF is executed
directly without run-api-tests test driver script. Subsequent
tests were failing due to extra "deref(a) " which is a leftover of
the previous tests. Because run-api-tests is spawning a TestWTF
process for each test, it hides this issue.

  • TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):
Added blocks or calling clear() method to destroy local variables and added more
EXPECT_STREQ("deref(a) ", takeLogStr().c_str()).

12:29 PM Changeset in webkit [265767] by Lauro Moura
  • 2 edits in trunk/Tools

[WPE] Fix file url in WPEQt api test
​https://bugs.webkit.org/show_bug.cgi?id=215577

Reviewed by Philippe Normand.

The test expects the load to fail, so avoid ​file://foo.html resolving
to ​file:///.

  • TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp:

(TestLoadRequest::main):

12:29 PM Changeset in webkit [265766] by Jonathan Bedard
  • 3 edits in trunk/Tools

[webkitcorepy] Autoinstaller is very slow in git-svn checkouts
​https://bugs.webkit.org/show_bug.cgi?id=215534
<rdar://problem/67120623>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.install): Download packages to a temporary directory so that setup.py runs faster.

12:14 PM Changeset in webkit [265765] by Chris Dumez
  • 6 edits in trunk

WaveShaperNode should not output silence when it has no input or when input is silence
​https://bugs.webkit.org/show_bug.cgi?id=215574

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline existing test now that all checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/silent-inputs-expected.txt:

Source/WebCore:

WaveShaperNode should not output silence when it has no input or when input is silence.
It should still apply its curve to the silent input.

No new tests, rebaselined existing test.

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::disableOutputsIfNecessary):
Do not disable the WaveShaperNode's output when its has no input. The WaveShaperNode
may still provide non-silent output when it has no input.

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::propagatesSilence const):

  • Modules/webaudio/WaveShaperNode.h:

Override propagatesSilence() to return false when the WaveShaperNode has a curve to apply,
so that we ask the node to process the input even when it is silence.

12:08 PM Changeset in webkit [265764] by Russell Epstein
  • 6 edits
    3 deletes in branches/safari-610.1-branch

Revert "Cherry-pick r265603. rdar://problem/67084483"

This reverts commit r265700.

12:00 PM Changeset in webkit [265763] by Russell Epstein
  • 31 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265725. rdar://problem/67260862

Convert remaining SharedMemory::Handle to SharedMemory::IPCHandle
​https://bugs.webkit.org/show_bug.cgi?id=215471
<rdar://problem/67024177>

Reviewed by David Kilzer.

Use the new struct for sending SharedMemory::Handle objects via IPC, so
we can include the exact size of data (SharedMemory::Handle::size()
rounds up to the nearest page), and verify these sizes match when decoding.

In many cases, the size is not sent as a separate argument via IPC, so
we can initialize the IPCHandle object with SharedMemory::Handle::size().

We can remove the additional size parameter when it exists, because
we are now passing IPCHandle which should include the size value.

  • GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp: (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged):
  • GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
  • GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
  • GPUProcess/webrtc/RemoteMediaRecorder.cpp: (WebKit::RemoteMediaRecorder::audioSamplesStorageChanged):
  • GPUProcess/webrtc/RemoteMediaRecorder.h:
  • GPUProcess/webrtc/RemoteMediaRecorder.messages.in: Send SharedMemory::IPCHandle object instead of SharedMemory::Handle over IPC.
  • NetworkProcess/ServiceWorker/WebSWOriginStore.cpp: (WebKit::WebSWOriginStore::sendStoreHandle): Since no additional size parameter is being sent in this function, we can use handle.size() as the IPCHandle::dataSize parameter.
  • Platform/SharedMemory.h: Remove encode/decode functions in SharedMemory::Handle.
  • Platform/cocoa/SharedMemoryCocoa.cpp: (WebKit::SharedMemory::Handle::encode const): Deleted. (WebKit::SharedMemory::Handle::decode): Deleted.
  • Platform/unix/SharedMemoryUnix.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode):
  • Platform/win/SharedMemoryWin.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode): (WebKit::SharedMemory::Handle::encode const): Deleted. (WebKit::SharedMemory::Handle::decode): Deleted. Remove SharedMemory::Handle encode/decode functions so we will not ever send a SharedMemory::Handle object over IPC accidentally in the future.
  • Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::Handle::encode const): (WebKit::ShareableBitmap::Handle::decode): Keep m_size here because it is an IntSize object and is useful to check width/height parameters in the SharableBitmap object.
  • Shared/ShareableResource.cpp: (WebKit::ShareableResource::Handle::encode const): (WebKit::ShareableResource::Handle::decode):
  • Shared/WebCompiledContentRuleListData.cpp: (WebKit::WebCompiledContentRuleListData::encode const): (WebKit::WebCompiledContentRuleListData::decode):
  • Shared/WebCoreArgumentCoders.cpp: (IPC::encodeSharedBuffer): (IPC::decodeSharedBuffer):
  • Shared/WebHitTestResultData.cpp: (WebKit::WebHitTestResultData::encode const): (WebKit::WebHitTestResultData::decode): More cases of converting between SharedMemory::Handle and SharedMemory::IPCHandle when encoding/decoding.
  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
  • UIProcess/VisitedLinkStore.cpp: (WebKit::VisitedLinkStore::sendStoreHandleToProcess):
  • WebProcess/GPU/media/RemoteAudioBusData.h: (WebKit::RemoteAudioBusData::encode const): (WebKit::RemoteAudioBusData::decode): Since no additional size parameter is being sent in this function, we can use handle.size() as the IPCHandle::dataSize parameter.
  • WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp: (WebKit::AudioMediaStreamTrackRenderer::storageChanged):
  • WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp: (WebKit::MediaRecorderPrivate::storageChanged):
  • WebProcess/Storage/WebSWClientConnection.cpp: (WebKit::WebSWClientConnection::setSWOriginTableSharedMemory):
  • WebProcess/Storage/WebSWClientConnection.h:
  • WebProcess/Storage/WebSWClientConnection.messages.in:
  • WebProcess/WebPage/VisitedLinkTableController.cpp: (WebKit::VisitedLinkTableController::setVisitedLinkTable):
  • WebProcess/WebPage/VisitedLinkTableController.h:
  • WebProcess/WebPage/VisitedLinkTableController.messages.in:
  • WebProcess/cocoa/RemoteCaptureSampleManager.cpp: (WebKit::RemoteCaptureSampleManager::audioStorageChanged):
  • WebProcess/cocoa/RemoteCaptureSampleManager.h:
  • WebProcess/cocoa/RemoteCaptureSampleManager.messages.in: More cases of converting between SharedMemory::Handle and SharedMemory::IPCHandle when encoding/decoding.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:00 PM Changeset in webkit [265762] by Russell Epstein
  • 5 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265638. rdar://problem/67260815

Create SharedMemory::IPCHandle object to validate the size of SharedMemory::Handle objects sent over IPC
​https://bugs.webkit.org/show_bug.cgi?id=215288
<rdar://problem/60870795>

Reviewed by David Kilzer.

Part 1 of a multi-patch plan to convert all SharedMemory::Handle
objects being sent over IPC to use SharedMemory::IPCHandle objects instead.

  • Platform/SharedMemory.h: (WebKit::SharedMemory::IPCHandle::IPCHandle):
  • Platform/cocoa/SharedMemoryCocoa.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode): Validate the size of the data sent in the IPCHandle::decode() function.
  • Platform/unix/SharedMemoryUnix.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode):
  • Platform/win/SharedMemoryWin.cpp: Implement IPCHandle encode and decode for all platforms for when we remove SharedMemory::Handle encode/decode functions.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:51 AM Changeset in webkit [265761] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit

[Mac] Add Experimental Feature preference for SW VP9
​https://bugs.webkit.org/show_bug.cgi?id=215043
<rdar://problem/66400034>

Reviewed by Darin Adler.

Follow up fix: during a rebase, a line deletion was dropped which causes the SW decoder to
always be registered regardless of the new setting.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::enableVP9Decoder):
(WebKit::WebProcess::enableVP9SWDecoder):

10:35 AM Changeset in webkit [265760] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS ] media/modern-media-controls/volume-up-support/volume-up-support.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215576

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:26 AM Changeset in webkit [265759] by youenn@apple.com
  • 2 edits in trunk/Source/WTF

Bump HAVE_NSURLSESSION_WEBSOCKET requirement to BigSur for MacOS
​https://bugs.webkit.org/show_bug.cgi?id=215517

Reviewed by Alex Christensen.

Catalina NSURLSession WebSocket is missing some features we need.
Bump it to Big Sur.

  • wtf/PlatformHave.h:
10:07 AM Changeset in webkit [265758] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

Remove message check in WebSocketTask::readNextMessage
​https://bugs.webkit.org/show_bug.cgi?id=215561

Reviewed by Alex Christensen.

This if check was added as a workaround to cases where both error and message were null.
This is no longer the case as per running existing tests with NSURLSession WebSocket code path on BigSur.

  • NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::readNextMessage):

10:03 AM Changeset in webkit [265757] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

Remove Cocoa WebSocketTask::send workaround
​https://bugs.webkit.org/show_bug.cgi?id=215564

Reviewed by Alex Christensen.

Covered by existing tests run in Debug.

  • NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::sendString):
(WebKit::WebSocketTask::sendData):

9:33 AM Changeset in webkit [265756] by ddkilzer@apple.com
  • 10 edits in trunk/Source

Clean up DragApplicationFlags after switch to OptionSet<>
<​https://webkit.org/b/215349>

Reviewed by Darin Adler.

Change WebCore::DragApplicationFlags to an enum class.

Source/WebCore:

No new tests since no change in behavior.

  • page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::isCopyKeyDown):

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):

  • platform/DragData.h:

Source/WebKit:

  • UIProcess/API/gtk/DropTargetGtk3.cpp:

(WebKit::DropTarget::drop):

  • Switch to use OptionSet<WebCore::DragApplicationFlags>.
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::applicationFlagsForDrag):

  • WebProcess/WebPage/WebPage.h:
  • Update forward declaration.

Source/WebKitLegacy/mac:

  • WebView/WebView.mm:

(-[WebView applicationFlags:]): Deleted.
(-[WebView _applicationFlagsForDrag:]):

  • Rename -applicationFlags: to -_applicationFlagsForDrag: since it's only used internally.
  • Switch to return OptionSet<WebCore::DragApplicationFlags>.

(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):

  • Switch to calling -_applicationFlagsForDrag:.
7:06 AM Changeset in webkit [265755] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore/platform/gtk/po

Merge r265754 - [GTK][l10n] Updated Polish translation of WebKitGTK for 2.30
​https://bugs.webkit.org/show_bug.cgi?id=215547

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2020-08-17
Rubber-stamped by Carlos Garcia Campos.

  • pl.po:
7:05 AM Changeset in webkit [265754] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK][l10n] Updated Polish translation of WebKitGTK for 2.30
​https://bugs.webkit.org/show_bug.cgi?id=215547

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2020-08-17
Rubber-stamped by Carlos Garcia Campos.

  • pl.po:
5:41 AM Changeset in webkit [265753] by Carlos Garcia Campos
  • 41 edits
    12 deletes in trunk

[GTK][WPE] Remove support for NPAPI plugins
​https://bugs.webkit.org/show_bug.cgi?id=215503

Reviewed by Darin Adler.

.:

  • Source/cmake/OptionsGTK.cmake:

Source/WebKit:

  • PlatformGTK.cmake:
  • PluginProcess/unix/PluginControllerProxyUnix.cpp: Removed.
  • PluginProcess/unix/PluginProcessMainUnix.cpp: Removed.
  • PluginProcess/unix/PluginProcessUnix.cpp: Removed.
  • Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp: Removed.
  • Shared/Plugins/unix/PluginSearchPath.cpp: Removed.
  • Shared/Plugins/unix/PluginSearchPath.h: Removed.
  • SourcesGTK.txt:
  • SourcesWPE.txt:
  • UIProcess/API/glib/WebKitMimeInfo.cpp:

(webkit_mime_info_ref):
(webkit_mime_info_unref):
(webkit_mime_info_get_mime_type):
(webkit_mime_info_get_description):
(webkit_mime_info_get_extensions):

  • UIProcess/API/glib/WebKitMimeInfoPrivate.h: Removed.
  • UIProcess/API/glib/WebKitPlugin.cpp:

(webkit_plugin_get_name):
(webkit_plugin_get_description):
(webkit_plugin_get_path):
(webkit_plugin_get_mime_info_list):

  • UIProcess/API/glib/WebKitPluginPrivate.h: Removed.
  • UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_plugins):
(webkit_settings_set_enable_plugins):

  • UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_set_additional_plugins_directory):
(webkit_web_context_get_plugins):
(webkit_web_context_get_plugins_finish):

  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewLoadFail):

  • UIProcess/API/glib/WebKitWebsiteData.cpp:

(recordContainsSupportedDataTypes):
(toWebKitWebsiteDataTypes):

  • UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(toWebsiteDataTypes):

  • UIProcess/API/gtk/WebKitError.h:
  • UIProcess/API/gtk/WebKitMimeInfo.h:
  • UIProcess/API/gtk/WebKitPlugin.h:
  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/WebKitWebsiteData.h:
  • UIProcess/API/wpe/WebKitError.h:
  • UIProcess/API/wpe/WebKitMimeInfo.h:
  • UIProcess/API/wpe/WebKitPlugin.h:
  • UIProcess/API/wpe/WebKitSettings.h:
  • UIProcess/API/wpe/WebKitWebContext.h:
  • UIProcess/API/wpe/WebKitWebsiteData.h:
  • UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bubblewrapSpawn):

  • UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Plugins/gtk/PluginInfoCache.cpp: Removed.
  • UIProcess/Plugins/gtk/PluginInfoCache.h: Removed.
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: Removed.
  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp: Removed.
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/gtk/WebPageProxyGtk.cpp:
  • WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp: Removed.
  • WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h: Removed.
  • WebProcess/Plugins/Netscape/unix/PluginProxyUnix.cpp: Removed.
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Removed.
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h: Removed.
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/Plugins/PluginView.h:

Tools:

  • PlatformGTK.cmake:
  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(beforeAll):

LayoutTests:

Skip tests using plugins and remove expectations.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/plugin-expected.txt: Removed.
  • platform/gtk/http/tests/plugins/plugin-javascript-access-allow-all-plugins-expected.txt: Removed.
  • platform/gtk/plugins/document-open-expected.txt: Removed.
  • platform/gtk/plugins/embed-attributes-style-expected.png: Removed.
  • platform/gtk/plugins/embed-attributes-style-expected.txt: Removed.
  • platform/gtk/plugins/iframe-plugin-bgcolor-expected.png: Removed.
  • platform/gtk/plugins/invalidate-rect-with-null-npp-argument-expected.txt: Removed.
  • platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html: Removed.
  • platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
  • platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
  • platform/gtk/plugins/nested-plugin-objects-expected.txt: Removed.
  • platform/gtk/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
  • platform/gtk/plugins/netscape-dom-access-expected.png: Removed.
  • platform/gtk/plugins/netscape-dom-access-expected.txt: Removed.
  • platform/gtk/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Removed.
  • platform/gtk/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Removed.
  • platform/gtk/plugins/plugin-clip-subframe-expected.txt: Removed.
  • platform/gtk/plugins/plugin-initiate-popup-window-expected.txt: Removed.
  • platform/gtk/plugins/plugin-javascript-access-expected.txt: Removed.
  • platform/gtk/plugins/resize-from-plugin-expected.txt: Removed.
  • platform/wpe/TestExpectations:
5:21 AM Changeset in webkit [265752] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

Set Sec-WebSocket-Protocol for WebSocket NSURLSession code path
​https://bugs.webkit.org/show_bug.cgi?id=215456
<rdar://problem/66996369>

Reviewed by Alex Christensen.

Covered by existing protocol tests with NSURLSession code path enabled.
http/tests/websocket/tests/hybi/set-protocol.html, http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html
Code change originating from Jiten Mehta.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::createWebSocketTask):
Set Sec-WebSocket-Protocol to support WebSocket protocol negotiation.

4:04 AM Changeset in webkit [265751] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

REGRESSION(r265725) [GTK][WPE] Several http/tests timeout/failures
​https://bugs.webkit.org/show_bug.cgi?id=215542

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-08-17
Reviewed by Sergio Villar Senin.

The problem is that ShareableResource is now using the dataSize member of IPCHandle to encode/decode the
resource size, but SharedMemoryUnix is not encoding/decoding dataSize.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::IPCHandle::encode const):
(WebKit::SharedMemory::IPCHandle::decode):

12:38 AM Changeset in webkit [265750] by youenn@apple.com
  • 2 edits in trunk/Tools

Update W3C test exporter to use Authorisation header instead of query parameter to validate GitHub account
​https://bugs.webkit.org/show_bug.cgi?id=215548

Reviewed by Darin Adler.

  • Scripts/webkitpy/w3c/test_exporter.py:

(WebPlatformTestExporter._validate_and_save_token):
access_token query parameter is dbeing deprecated in favor of Authorization header.
Update script accordingly.

12:37 AM Changeset in webkit [265749] by ysuzuki@apple.com
  • 74 edits
    2 adds in trunk

JSDOMConstructorNotConstructable should be a constructor
​https://bugs.webkit.org/show_bug.cgi?id=215554
<rdar://problem/65770688>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/FileAPI/file/send-file-form-expected.txt:
  • web-platform-tests/FileAPI/file/send-file-form-iso-2022-jp.tentative-expected.txt:
  • web-platform-tests/FileAPI/file/send-file-form-utf-8-expected.txt:
  • web-platform-tests/FileAPI/file/send-file-form-windows-1252.tentative-expected.txt:
  • web-platform-tests/FileAPI/file/send-file-form-x-user-defined.tentative-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-constructable-baseURL.tentative-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-constructable-disabled-regular-sheet-insertion-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-constructable-disallow-import.tentative-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-constructable-duplicate-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-constructable-expected.txt:
  • web-platform-tests/css/cssom/CSSStyleSheet-modify-after-removal-expected.txt:
  • web-platform-tests/custom-elements/Document-createElement-expected.txt:
  • web-platform-tests/custom-elements/Document-createElementNS-expected.txt:
  • web-platform-tests/custom-elements/HTMLElement-attachInternals-expected.txt:
  • web-platform-tests/custom-elements/HTMLElement-constructor-expected.txt:
  • web-platform-tests/custom-elements/builtin-coverage-expected.txt:
  • web-platform-tests/custom-elements/customized-built-in-constructor-exceptions-expected.txt:
  • web-platform-tests/custom-elements/htmlconstructor/newtarget-expected.txt:
  • web-platform-tests/custom-elements/parser/serializing-html-fragments-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLAreaElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLBaseElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLButtonElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLCanvasElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLDataElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLDetailsElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLEmbedElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLFieldSetElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLImageElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLLIElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLLabelElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLMapElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLMediaElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLMetaElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLMeterElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLModElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLOListElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLOptGroupElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLParamElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLProgressElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLQuoteElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLSlotElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLStyleElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLTableCellElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLTableColElement-expected.txt:
  • web-platform-tests/custom-elements/reactions/HTMLTimeElement-expected.txt:
  • web-platform-tests/custom-elements/upgrading/Document-importNode-expected.txt:
  • web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt:
  • web-platform-tests/dom/nodes/Node-appendChild-cereactions-vs-script.window-expected.txt:
  • web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:
  • web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:
  • web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub-expected.txt:
  • web-platform-tests/service-workers/service-worker/data-transfer-files.https-expected.txt:
  • web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt:
  • web-platform-tests/user-timing/mark-entry-constructor.any-expected.txt:
  • web-platform-tests/user-timing/mark-entry-constructor.any.worker-expected.txt:
  • web-platform-tests/user-timing/structured-serialize-detail.any-expected.txt:
  • web-platform-tests/user-timing/structured-serialize-detail.any.worker-expected.txt:
  • web-platform-tests/webrtc/RTCIceTransport-extension.https-expected.txt:

Source/WebCore:

Test: js/dom/window-is-constructor.html

While JSDOMConstructorNotConstructable throws an error, still it should be a constructor, which means,
IsConstructor(JSDOMConstructorNotConstructable) should be true. To fix it, we add getConstructData
which configures a function throwing an error.

  • bindings/js/JSDOMConstructorNotConstructable.h:

LayoutTests:

  • editing/async-clipboard/clipboard-interfaces-expected.txt:
  • editing/undo-manager/undo-manager-interfaces-expected.txt:
  • fast/dom/MutationObserver/mutation-record-constructor-expected.txt:
  • http/wpt/html/browsers/the-window-object/window-is-constructor-expected.txt: Added.
  • http/wpt/html/browsers/the-window-object/window-is-constructor.html: Added.
  • js/interface-objects-expected.txt:
  • performance-api/paint-timing/paint-timing-apis-expected.txt:
  • performance-api/performance-observer-api-expected.txt:
  • performance-api/performance-timeline-api-expected.txt:
  • performance-api/resource-timing-apis-expected.txt:
  • performance-api/user-timing-apis-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLInputElement-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
12:31 AM Changeset in webkit [265748] by youenn@apple.com
  • 5 edits in trunk

Make sure writableStreamDefaultWriterEnsureClosedPromiseRejected overwrite the closedPromise if needed
​https://bugs.webkit.org/show_bug.cgi?id=215540

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/streams/writable-streams/aborting.any-expected.txt:
  • web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt:

Source/WebCore:

Covered by rebased tests.

  • Modules/streams/WritableStreamInternals.js:

(writableStreamDefaultWriterEnsureClosedPromiseRejected):
As per spec, if promise is already settled, we overwrite it to reject it.

12:26 AM Changeset in webkit [265747] by youenn@apple.com
  • 6 edits in trunk

Check WritableStream underlyingSink methods
​https://bugs.webkit.org/show_bug.cgi?id=215539

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt:
  • web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.js:

(test):

  • web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt:

Source/WebCore:

Covered by updated tests.

  • Modules/streams/WritableStream.js:

(initializeWritableStream):

Note: See TracTimeline for information about the timeline view.