Timeline

Aug 26, 2020:

11:46 PM Changeset in webkit [266225] by BJ Burg

• 4 edits in trunk/Source

Web Inspector: button for Inspector^{2 doesn't work without setting default for DeveloperExtrasEnabled
​https://bugs.webkit.org/show_bug.cgi?id=215828}

Reviewed by Devin Rousso.

Source/WebCore:

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::inspectInspector):
Explicitly set DeveloperExtrasEnabled for the Inspector
web view so that the Inspect context menu appears and
so the [2] button works as expected.

Source/WebInspectorUI:

Drive-by: because the Inspector^{2 button is text-only and has no
.name element, the '2' button does not become dimmed when the
window is inactive, unlike every other item in the tab bar.
Fix this by coloring the text-only button similar to tab labels.}

• UserInterface/Debug/Bootstrap.css:

(body.window-inactive .tab-bar > .navigation-bar .item.button.text-only):
(.tab-bar > .navigation-bar .item.button.text-only):
(.tab-bar > .navigation-bar .item.button.text-only:not(.selected):hover):
(.tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected):
(body.window-inactive .tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected >):

10:43 PM Changeset in webkit [266224] by Jonathan Bedard

• 7 edits
  1 delete in trunk/Tools

[webkitcorepy] Move Timeout to webkitcorepy (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=215584
<rdar://problem/67270713>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py:

(Timeout.enter): Forward patch flag to disable context.
(Timeout.exit): Ditto.

• Scripts/webkitpy/common/timeout_context.py: Replace with webkitcorepy's Timeout object.

(Timeout): Deleted.

• Scripts/webkitpy/common/timeout_context_unittest.py: Removed.
• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess._start): Opt-out of patching time.sleep().

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.launch_app): Opt-out of patching time.sleep().

• glib/api_test_runner.py:

(TestRunner._run_google_test): Use specific Timeout exception.

10:27 PM Changeset in webkit [266223] by Alexey Shvayka

• 8 edits in trunk/Source

Use jsTypeofIsObject() in DFG AI and operationTypeOfIsObject()
​https://bugs.webkit.org/show_bug.cgi?id=144457

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch refactors jsTypeofIsObject(), leveraging fast path of isCallable(),
moves it to the header, and utilizes it in operationTypeOfIsObject() & DFG AI
(minding concurrency) to eliminate code duplication.

Also, removes orphaned slow_path_is_object declaration.

No behavior change, typeof microbenchmarks are neutral.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGOperations.cpp:
• runtime/CommonSlowPaths.h:
• runtime/Operations.cpp:

(JSC::jsTypeofIsObject): Deleted.

• runtime/Operations.h:

(JSC::jsTypeofIsObjectWithConcurrency):
(JSC::jsTypeofIsObject):

Source/WTF:

• wtf/TriState.h:

(WTF::invert):

9:36 PM Changeset in webkit [266222] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC][IFC] LineBuilder should not align the runs
​https://bugs.webkit.org/show_bug.cgi?id=215016

Reviewed by Antti Koivisto.

This is in preparation for moving alignment logic over to the LineBox.
LineBuilder is responsible for adding content to the line, but the final alignment will be done by the LineBox.
This works well with preferred width computation, where we use the LineBuilder to compute line width but we
don't really need to construct a LineBox (and no alignment is needed).

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::HangingContent::width const):
(WebCore::Layout::HangingContent::isConditional const):
(WebCore::Layout::HangingContent::setIsConditional):
(WebCore::Layout::HangingContent::expand):
(WebCore::Layout::HangingContent::reset):
(WebCore::Layout::LineContentAligner::formattingContext const):
(WebCore::Layout::LineContentAligner::layoutState const):
(WebCore::Layout::LineContentAligner::LineContentAligner):
(WebCore::Layout::LineContentAligner::alignHorizontally):
(WebCore::Layout::LineContentAligner::alignVertically):
(WebCore::Layout::LineContentAligner::justifyRuns):
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight):
(WebCore::Layout::LineContentAligner::collectHangingContent const):
(WebCore::Layout::LineContentAligner::runContentHeight const):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::removeTrailingTrimmableContent):
(WebCore::Layout::LineBuilder::isVisuallyNonEmpty const):
(WebCore::Layout::HangingContent::width const): Deleted.
(WebCore::Layout::HangingContent::isConditional const): Deleted.
(WebCore::Layout::HangingContent::setIsConditional): Deleted.
(WebCore::Layout::HangingContent::expand): Deleted.
(): Deleted.
(WebCore::Layout::HangingContent::reset): Deleted.
(WebCore::Layout::LineContentAligner::formattingContext const): Deleted.
(WebCore::Layout::LineContentAligner::layoutState const): Deleted.
(WebCore::Layout::LineContentAligner::LineContentAligner): Deleted.
(WebCore::Layout::LineContentAligner::alignHorizontally): Deleted.
(WebCore::Layout::LineContentAligner::alignVertically): Deleted.
(WebCore::Layout::LineContentAligner::justifyRuns): Deleted.
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineContentAligner::collectHangingContent const): Deleted.
(WebCore::Layout::LineContentAligner::runContentHeight const): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::lineBox):
(WebCore::Layout::LineBuilder::runs):

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::close):

• layout/inlineformatting/LineLayoutContext.h:

9:28 PM Changeset in webkit [266221] by Chris Dumez

• 19 edits in trunk

Add support for sub-sample accurate start for AudioBufferSourceNode
​https://bugs.webkit.org/show_bug.cgi?id=215868

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-playbackrate-zero-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-scheduling-expected.txt:

Source/WebCore:

Implement sub-sample accurate start for AudioBufferSourceNode.
Previously, if the start time was between sample boundaries, we would
start the output at the frame before the start time. This is actually
incorrect because we haven't actually started yet. We should start
the output at the next boundary, and interpolating the value based on
the true start time and the sample boundary.

This is based on the following Chromium changes:

• ​https://chromium-review.googlesource.com/c/chromium/src/+/1212270
• ​https://chromium-review.googlesource.com/c/chromium/src/+/1446869

No new tests, rebaselined existing test.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

• Modules/webaudio/AudioBufferSourceNode.h:
• Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):

• Modules/webaudio/AudioScheduledSourceNode.h:
• Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::process):

• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::process):

• platform/audio/AudioUtilities.cpp:

(WebCore::AudioUtilities::timeToSampleFrame):

• platform/audio/AudioUtilities.h:

LayoutTests:

Update existing layout tests to reflect behavior change.

• platform/mac/webaudio/audiobuffersource-playbackrate-expected.wav:
• webaudio/gain-expected.wav:
• webaudio/resources/distance-model-testing.js:
• webaudio/resources/panner-model-testing.js:

8:57 PM Changeset in webkit [266220] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GLIB] Gardening some accessibility debug crashes

Unreviewed test gardening.

• platform/glib/TestExpectations:

8:43 PM Changeset in webkit [266219] by Chris Dumez

• 4 edits in trunk

Update DynamicsCompressorNode::process() to use AudioParam::finalValue()
​https://bugs.webkit.org/show_bug.cgi?id=215874

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:

Source/WebCore:

Update DynamicsCompressorNode::process() to use AudioParam::finalValue(). All of DynamicsCompressorNode
use k-rate (in fixed mode) so we should be using AudioParam::finalValue() unconditionally.

No new tests, rebaselined existing test.

• Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::process):

8:35 PM Changeset in webkit [266218] by Devin Rousso

• 3 edits in trunk/Source/WebCore

REGRESSION: touchbar controls don't reflect video state in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=215873
<rdar://problem/66723354>

Reviewed by Eric Carlson.

• platform/mac/WebPlaybackControlsManager.h:
• platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager setPlaying:]):
(-[WebPlaybackControlsManager isPlaying]):
Create an actual ivar _playing for holding the play/pause state. This is needed because
AVTouchBarScrubber uses KVO to update the state of the play/pause button whenever the
related video controller (in this case AVTouchBarPlaybackControlsControlling) changes
using an NSValueBinding. KVO needs an actual ivar in order to function properly.

8:21 PM Changeset in webkit [266217] by Ryan Haddad

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, reverting r266200.

Broke test for macOS

Reverted changeset:

"Unreviewed, rebaseline constant css-cascade test failure"
​https://trac.webkit.org/changeset/266200

6:58 PM Changeset in webkit [266216] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS] Stop logging sandbox violations of com.apple.CoreDisplay.Notification
​https://bugs.webkit.org/show_bug.cgi?id=215869

Reviewed by Darin Adler.

On macOS, stop logging mach-lookup sandbox violations of com.apple.CoreDisplay.Notification for performance reasons.

No new tests, since there is no change in behavior. The service was already being denied in the sandbox.

• WebProcess/com.apple.WebProcess.sb.in:

6:55 PM Changeset in webkit [266215] by Alexey Shvayka

• 3 edits
  2 adds in trunk

Merge putLength() into setLength()
​https://bugs.webkit.org/show_bug.cgi?id=211279

Reviewed by Darin Adler and Saam Barati.

JSTests:

• microbenchmarks/array-shift-unshift-empty.js: Added.
• stress/array-setLength-on-proxy-error.js: Added.

Source/JavaScriptCore:

This patch:

1. Replaces all putLength() call sites with setLength(), saving two JSValue instantiations in arrayProtoFuncPop() and two in arrayProtoFuncShift().

2. Merges putLength() into setLength(), removing superfluous put() call for JSArray. Also, performs put() in strict mode to preserve the original error messages, like ones in ProxyObject::performPut().

3. Inlines performPop(), which avoided an extra index check and Identifier creation, as it was on the slow path anyway (note JSArray::pop() call).

This change advances provided setLength()-heavy microbenchmark by ~40%,
while existing Array tests are neutral.

• runtime/ArrayPrototype.cpp:

(JSC::setLength):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncUnShift):
(JSC::putLength): Deleted.

6:52 PM Changeset in webkit [266214] by Kate Cheney

• 19 edits in trunk/Source

Resource Load Statistics data summary does not report data which is held up in the web content process.
​https://bugs.webkit.org/show_bug.cgi?id=215822
<rdar://problem/66682044>

Reviewed by Chris Dumez.

Source/WebCore:

Send empty lambda when calling updateCentralStatisticsStore() because
in these cases we don't care about timing.

• loader/ResourceLoadObserver.h:

(WebCore::ResourceLoadObserver::updateCentralStatisticsStore):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::close):

• testing/Internals.cpp:

(WebCore::Internals::notifyResourceLoadObserver):

Source/WebKit:

No new tests, this fixes a timing bug that is flaky to reproduce, so I
was unable to write a test case. Non-regressed behavior is confirmed
with existing API testing.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
Most of the time, the completion handler will be an empty function,
but we should handle it in the network process so we fix the
case where we wait to send the full data summary until the update has
finished.

(WebKit::WebResourceLoadStatisticsStore::aggregatedThirdPartyData):
Delete extra space.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::resourceLoadStatisticsUpdated):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::sendResourceLoadStatisticsDataImmediately):

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):
Don't ask the network process for data until any lingering data
in the web content process has been sent first.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleResourceLoadStatisticsNotifyObserver):

• WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:

(WebKit::WebResourceLoadObserver::WebResourceLoadObserver):
(WebKit::WebResourceLoadObserver::~WebResourceLoadObserver):
(WebKit::WebResourceLoadObserver::updateCentralStatisticsStore):

• WebProcess/WebCoreSupport/WebResourceLoadObserver.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::flushResourceLoadStatistics):
(WebKit::WebProcess::sendResourceLoadStatisticsDataImmediately):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

6:47 PM Changeset in webkit [266213] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Make isIndex use MAX_ARRAY_INDEX
​https://bugs.webkit.org/show_bug.cgi?id=215872

Reviewed by Darin Adler.

It's already written in such a way where it relies on what MAX_ARRAY_INDEX
is defined as. But instead of MAX_ARRAY_INDEX, the function was hardcoding
MAX_ARRAY_INDEX + 1.

• runtime/Identifier.h:

(JSC::isIndex):

6:26 PM Changeset in webkit [266212] by rniwa@webkit.org

• 12 edits in trunk/Source/WebCore

Make it possible to create a WeakPtr to Node and use it store assigned nodes in SlotAssignment
​https://bugs.webkit.org/show_bug.cgi?id=215673
<rdar://problem/67440818>

Reviewed by Darin Adler.

This patch makes Node inherit from CanMakeWeakPtr<Node> and uses it in SlotAssignment's assignedNodes
and related member variables and functions.

No new tests since there should be no behavioral difference.

• dom/ComposedTreeIterator.cpp:

(WebCore::ComposedTreeIterator::traverseNextInShadowTree):
(WebCore::ComposedTreeIterator::advanceInSlot):

• dom/ComposedTreeIterator.h:

(WebCore::firstChildInComposedTreeIgnoringUserAgentShadow):
(WebCore::nextSiblingInComposedTreeIgnoringUserAgentShadow):

• dom/ContainerNode.h:
• dom/Node.h:
• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::assignedNodesForSlot):

• dom/ShadowRoot.h:
• dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::assignedNodesForSlot):
(WebCore::SlotAssignment::assignToSlot):

• dom/SlotAssignment.h:
• html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::assignedNodes const):
(WebCore::flattenAssignedNodes):
(WebCore:: const): Deleted.

• html/HTMLSlotElement.h:
• page/FocusController.cpp:

(WebCore::FocusNavigationScope::firstNodeInScope const):
(WebCore::FocusNavigationScope::lastNodeInScope const):

6:02 PM Changeset in webkit [266211] by Hector Lopez

• 2 edits in trunk/LayoutTests

REGRESSION: ASSERT NOT REACHED: WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree
​https://bugs.webkit.org/show_bug.cgi?id=215875

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

6:00 PM Changeset in webkit [266210] by Alexey Shvayka

• 7 edits in trunk/Source/JavaScriptCore

Use unsigned type for length of JSFunction
​https://bugs.webkit.org/show_bug.cgi?id=215870

Reviewed by Darin Adler.

Since the length value of a built-in function is its arity,
we can communicate it's always non-negative via method signatures.

No behavior change: length values redefined by user code are unaffected.

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::createFunctionThatMasqueradesAsUndefined):

• runtime/InternalFunction.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):

• runtime/JSFunction.h:
• runtime/JSNativeStdFunction.cpp:

(JSC::JSNativeStdFunction::finishCreation):
(JSC::JSNativeStdFunction::create):

• runtime/JSNativeStdFunction.h:

5:43 PM Changeset in webkit [266209] by Russell Epstein

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.2.3

5:10 PM Changeset in webkit [266208] by clopez@igalia.com

• 6 edits in trunk/Tools

[GTK][WPE] Add bots for generating nightly bundle packages
​https://bugs.webkit.org/show_bug.cgi?id=215623

Reviewed by Aakash Jain.

This adds a new type of bots for GTK and WPE that runs nightly (once per day).
The goal of this bots its to build WebKit for a specific distribution (Ubuntu LTS and LTS-1)
and generate a bundle with the result of the build. The bundles are then uploaded to a
server for consumption on other CIs like WPT.

The MiniBrowser bundle targets a specific distribution, so each one of this new bots has to
run the generate-minibrowser-bundle step. However, the JSC bundle is distro-agnostic because
for JSC is possible to bundle all the system libraries (similar to a static build).
That means that we only need to run the step generate-jsc-bundle in one of the bots.
This step for generating the JSC bundle was previously executed in the bot
'GTK Linux 64-bit Release (Build)'. This patch moves it to one of this new added bots.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/factories.py:

(BuildFactory):
(BuildFactory.init):
(TestFactory):
(TestFactory.init):
(BuildAndGenerateMiniBrowserBundleFactory):
(BuildAndGenerateMiniBrowserJSCBundleFactory):

• BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
• BuildSlaveSupport/build.webkit.org-config/steps.py:

(GenerateJSCBundle):
(GenerateMiniBrowserBundle):

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

5:08 PM Changeset in webkit [266207] by Andres Gonzalez

• 8 edits in trunk

Buttons with aria-haspopup attribute are not exposed to accessibility clients as form controls.
​https://bugs.webkit.org/show_bug.cgi?id=215866

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/mac/search-predicate-element-count.html.

Buttons with aria-haspopup were not included in the search results for
client queries for form controls. Added buttons with aria-haspopup which
have role PopUpButton, to the list of roles returned as form controls.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isARIAInput): Re-wrote using a switch statement for clarity and maintainability.
(WebCore::AccessibilityObject::isARIAControl): Ditto.

• accessibility/AccessibilityObject.h:

Source/WebKit:

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick): isARIAControl false implies

isARIAInput false, thus removed the

isARIAInput call.

LayoutTests:

Expanded this test to include the case of buttons with aria-haspopup and
several other elements with ARIA roles that need to be retrieved when
clients search for input fields or form controls.

• accessibility/mac/search-predicate-element-count-expected.txt:
• accessibility/mac/search-predicate-element-count.html:

5:06 PM Changeset in webkit [266206] by commit-queue@webkit.org

• 7 edits
  4 adds in trunk

Leading white spaces should be ignored when parsing an SVG list property
​https://bugs.webkit.org/show_bug.cgi?id=215602

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-08-26
Reviewed by Sam Weinig.

Source/WebCore:

The SVG2.0 specs state that the CSS value definition syntax must be used
to define the syntax of the SVG attributes. The CSS syntax states that
leading and trailing spaces should be ignored when parsing the primitive
data types of all the SVG lists.

This has been inconsistency between WebKit and other browsers and within
WebKit itself. Parsing the attribute string of an SVGTransformList skips
the leading white spaces while the rest of the lists do not do that.

All the parsing methods should skip the leading white spaces before looping
to parse individual items. The last step of the loop is to skip the trailing
spaces and the delimiter which we do already.

Tests: svg/custom/feColorMatrix-values-leading-spaces.html

svg/dom/svg-list-properties-parser-leading-trailing-spaces.html

• svg/SVGLengthList.cpp:

(WebCore::SVGLengthList::parse):

• svg/SVGNumberList.cpp:

(WebCore::SVGNumberList::parse):

• svg/SVGStringList.cpp:

(WebCore::SVGStringList::parse):

• svg/SVGTransformList.cpp:

(WebCore::SVGTransformList::parseGeneric):

LayoutTests:

• svg/custom/feColorMatrix-values-leading-spaces-expected.html: Added.
• svg/custom/feColorMatrix-values-leading-spaces.html: Added.
• svg/dom/length-list-parser-expected.txt:
• svg/dom/svg-list-properties-parser-leading-trailing-spaces-expected.txt: Added.
• svg/dom/svg-list-properties-parser-leading-trailing-spaces.html: Added.

4:58 PM Changeset in webkit [266205] by Alan Coon

• 1 copy in tags/Safari-610.2.2.3

Tag Safari-610.2.2.3.

4:38 PM Changeset in webkit [266204] by Alan Coon

• 54 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266168. rdar://problem/67836301

REGRESSION (r265908): Crash under Blob::arrayBuffer() / Blob::text() in stress GC
​https://bugs.webkit.org/show_bug.cgi?id=215832
<rdar://problem/67741677>

Reviewed by Ryosuke Niwa.

Source/WebCore:

r265908 added support for Blob::arrayBuffer() / Blob::text() which are asynchronous operations
returning promises. The crash is due to the fact that the Blob's JS wrapper may get garbage
collected before the promise is settled.

To address the issue, this patch makes Blob an ActiveDOMObject and creates an
ActiveDOMObject::pendingActivity whenever there is a pending promise so that the JS wrapper
does not get garbage collected too early.

Test: fast/files/blob-text-gc.html

• Modules/async-clipboard/Clipboard.cpp: (WebCore::Clipboard::getType):
• Modules/async-clipboard/ClipboardImageReader.h: (WebCore::ClipboardImageReader::ClipboardImageReader):
• Modules/async-clipboard/ClipboardItem.cpp: (WebCore::ClipboardItem::blobFromString):
• Modules/async-clipboard/ClipboardItem.h:
• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp: (WebCore::ClipboardItemBindingsDataSource::getType):
• Modules/async-clipboard/ios/ClipboardImageReaderIOS.mm: (WebCore::ClipboardImageReader::readBuffer):
• Modules/async-clipboard/mac/ClipboardImageReaderMac.mm: (WebCore::ClipboardImageReader::readBuffer):
• Modules/entriesapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::getFile):
• Modules/entriesapi/DOMFileSystem.h:
• Modules/entriesapi/FileSystemFileEntry.cpp: (WebCore::FileSystemFileEntry::file):
• Modules/entriesapi/FileSystemFileEntry.h:
• Modules/entriesapi/FileSystemFileEntry.idl:
• Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::fromFormData):
• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp: (WebCore::blobFromData): (WebCore::packageFormData): (WebCore::resolveWithTypeAndData): (WebCore::FetchBodyConsumer::resolve): (WebCore::FetchBodyConsumer::takeAsBlob):
• Modules/fetch/FetchBodyConsumer.h:
• Modules/fetch/FetchBodyOwner.cpp: (WebCore::FetchBodyOwner::blob):
• Modules/mediarecorder/MediaRecorder.cpp: (WebCore::MediaRecorder::stopRecording): (WebCore::MediaRecorder::requestData):
• Modules/mediastream/RTCDataChannel.cpp: (WebCore::RTCDataChannel::didReceiveRawData):
• Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::didReceiveBinaryData):
• Modules/websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
• bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal):
• dom/DataTransfer.cpp: (WebCore::DataTransfer::updateFileList): (WebCore::DataTransfer::items): (WebCore::DataTransfer::filesFromPasteboardAndItemList const): (WebCore::DataTransfer::files const):
• dom/DataTransfer.h:
• dom/DataTransfer.idl:
• dom/DataTransferItemList.cpp: (WebCore::DataTransferItemList::DataTransferItemList): (WebCore::DataTransferItemList::remove): (WebCore::DataTransferItemList::clear): (WebCore::DataTransferItemList::ensureItems const): (WebCore::DataTransferItemList::document const):
• dom/DataTransferItemList.h:
• dom/DataTransferItemList.idl:
• editing/WebCorePasteboardFileReader.cpp: (WebCore::WebCorePasteboardFileReader::readFilename): (WebCore::WebCorePasteboardFileReader::readBuffer):
• editing/WebCorePasteboardFileReader.h:
• editing/cocoa/WebContentReaderCocoa.mm: (WebCore::createFragmentForImageAttachment): (WebCore::replaceRichContentWithAttachments): (WebCore::createFragmentAndAddResources): (WebCore::sanitizeMarkupWithArchive): (WebCore::WebContentReader::readImage): (WebCore::attachmentForFilePath): (WebCore::attachmentForData):
• editing/markup.cpp: (WebCore::restoreAttachmentElementsInFragment):
• fileapi/Blob.cpp: (WebCore::Blob::Blob): (WebCore::Blob::loadBlob): (WebCore::Blob::activeDOMObjectName const):
• fileapi/Blob.h: (WebCore::Blob::create): (WebCore::Blob::deserialize): (WebCore::Blob::slice const):
• fileapi/Blob.idl:
• fileapi/File.cpp: (WebCore::File::createWithRelativePath): (WebCore::File::create): (WebCore::File::File): (WebCore::File::activeDOMObjectName const):
• fileapi/File.h:
• fileapi/File.idl:
• html/DOMFormData.cpp: (WebCore::DOMFormData::createFileEntry):
• html/DirectoryFileListCreator.cpp: (WebCore::FileInformation::isolatedCopy const): (WebCore::appendDirectoryFiles): (WebCore::gatherFileInformation): (WebCore::toFileList): (WebCore::DirectoryFileListCreator::start):
• html/DirectoryFileListCreator.h:
• html/FileInputType.cpp: (WebCore::FileInputType::appendFormData const): (WebCore::FileInputType::filesChosen):
• html/HTMLAttachmentElement.cpp: (WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):
• html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toBlob):
• testing/Internals.cpp: (WebCore::Internals::createFile):
• testing/ServiceWorkerInternals.cpp: (WebCore::ServiceWorkerInternals::createOpaqueWithBlobBodyResponse):
• workers/service/context/ServiceWorkerFetch.cpp: (WebCore::ServiceWorkerFetch::dispatchFetchEvent):
• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createResponseBlob):

Source/WebKit:

• WebProcess/Automation/WebAutomationSessionProxy.cpp: (WebKit::WebAutomationSessionProxy::setFilesForInputFileUpload):

LayoutTests:

Add better test coverage.

• fast/files/blob-text-gc-expected.txt: Added.
• fast/files/blob-text-gc.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:38 PM Changeset in webkit [266203] by Alan Coon

• 34 edits in branches/safari-610-branch

Cherry-pick r266087. rdar://problem/67836301

Implement Request/Response consuming as FormData
​https://bugs.webkit.org/show_bug.cgi?id=215671

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/abort/general.any-expected.txt:
• web-platform-tests/fetch/api/abort/general.any.worker-expected.txt:
• web-platform-tests/fetch/api/request/request-consume-empty-expected.txt: This remaining failing test now fails similarly in all browsers.
• web-platform-tests/fetch/api/request/request-consume-expected.txt:
• web-platform-tests/fetch/api/request/request-init-002-expected.txt:
• web-platform-tests/fetch/api/response/response-consume-empty-expected.txt: This remaining failing test now fails similarly in all browsers.
• web-platform-tests/fetch/api/response/response-consume-expected.txt:
• web-platform-tests/fetch/api/response/response-error-from-stream-expected.txt: This change makes the formData failures in this file look like all the other failures in this file, which should be fixed together in a separate patch.
• web-platform-tests/fetch/api/response/response-init-002-expected.txt:
• web-platform-tests/url/urlencoded-parser.any-expected.txt:
• web-platform-tests/url/urlencoded-parser.any.worker-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https-expected.txt:

Source/WebCore:

Covered by many newly passing WPT tests, for most of which Safari was the only failing browser.

• Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::formData): (WebCore::FetchBody::consume): (WebCore::FetchBody::consumeFormData):
• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp: (WebCore::formDataFromData): (WebCore::resolveWithTypeAndData): (WebCore::FetchBodyConsumer::resolve):
• Modules/fetch/FetchBodyConsumer.h:

Source/WebKit:

• WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: (WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinish): Add a fast path that allows non-blob FormData responses from service workers to not hang. This part is covered by this layout test: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https.html

Source/WTF:

In order to be compatible with other browsers, we need a verson of String::fromUTF8 that
uses U8_NEXT_OR_FFFD instead of U8_NEXT, but changing that across the board will break other things.
Leave everything else as it is, use templates and constexpr to not add any branches, but add
String::fromUTF8ReplacingInvalidSequences to allow me to make our FormData consuming compatible with other browsers.

• wtf/text/WTFString.cpp: (WTF::fromUTF8Helper): (WTF::String::fromUTF8): (WTF::String::fromUTF8ReplacingInvalidSequences):
• wtf/text/WTFString.h:
• wtf/unicode/UTF8Conversion.cpp: (WTF::Unicode::convertUTF8ToUTF16Impl): (WTF::Unicode::convertUTF8ToUTF16): (WTF::Unicode::convertUTF8ToUTF16ReplacingInvalidSequences):
• wtf/unicode/UTF8Conversion.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:38 PM Changeset in webkit [266202] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266176. rdar://problem/67836292

[Mac,EME] Netflix.com shows HDCP error for all streams
​https://bugs.webkit.org/show_bug.cgi?id=215825

Reviewed by Eric Carlson.

New API added to AVContentKeySession hits a sandbox restriction when run in the WebContent process, and the default
behavior when an error checking HDCP status is to report that the output is restricted, regardless of the displays
actual capabilities. To work around this behavior for now, pass in an empty displayID array, rather than the actual
displayID. This causes AVFoundation to do a "lowest common level of support" rather than a specific display check.
The upside is that this call no longer requires a connection to the WindowServer. The downside is that the
AVContentKeyRequest will report that its output is restricted if any non-HDCP compliant display is attached.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateProtectionStatusForDisplayID):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:21 PM Changeset in webkit [266201] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure)
Rebaseline test, remove test expectation.

Unreviewed test gardening.

• platform/ios-13/TestExpectations:

4:12 PM Changeset in webkit [266200] by Karl Rackler

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline constant css-cascade test failure

• web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

3:39 PM Changeset in webkit [266199] by Alan Coon

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.2.3

3:34 PM Changeset in webkit [266198] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Avoid unnecessarily copying a Vector in WebCore::transformsForValue
​https://bugs.webkit.org/show_bug.cgi?id=215858

Reviewed by Tim Horton.

Avoid copying the Vector of TransformOperations in this helper function by directly appending newly created
transform operations to the given TransformOperations. This does, however, mean that we need to clear these
items in the case where conversion fails and we return false.

• css/TransformFunctions.cpp:

(WebCore::transformsForValue):

3:27 PM Changeset in webkit [266197] by Alan Coon

• 1 copy in tags/Safari-610.1.28.0.4

Tag Safari-610.1.28.0.4.

3:15 PM Changeset in webkit [266196] by Lauro Moura

• 3 edits
  2 copies
  1 add
  2 deletes in trunk/LayoutTests

[WPE][GTK] Gardening and rebaseline

Unreviewed test gardening.

Moving some GTK-specific baselines to GLIB and removing some uneeded
baselines (failure should be expected)

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Copied from LayoutTests/platform/glib/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt.
• platform/gtk/streams/pipe-to-expected.txt: Removed.
• platform/wpe/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Renamed from LayoutTests/platform/glib/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt.

3:14 PM Changeset in webkit [266195] by Alan Coon

• 1 copy in tags/Safari-610.2.2.2

Tag Safari-610.2.2.2.

3:03 PM Changeset in webkit [266194] by Aditya Keerthi

• 4 edits
  2 adds in trunk

[iOS] Disabled options in the multi-select picker should not be selectable
​https://bugs.webkit.org/show_bug.cgi?id=201458
<rdar://problem/55018179>

Reviewed by Wenson Hsieh.

Source/WebKit:

WKMultipleSelectPicker is displayed when a <select multiple> or a
<select> with an <optgroup> is activated. Due to <rdar://problem/18745253>,
group rows and disabled rows were selectable in the picker. r175266 added a
workaround for this issue, preventing group rows from being selectable.
However, the workaround did not account for disabled rows, which means that
it is possible to select disabled options in the multi-select picker.

To fix this behavior, the same fix that was applied to group rows is now
applied to disabled rows. pickerView:row:column:checked: resets the style
for the associated view if item.disabled is true.

Test: fast/forms/ios/disabled-options-in-multi-select-picker.html

• UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKMultipleSelectPicker pickerView:row:column:checked:]):

LayoutTests:

Added a test to verify that disabled options cannot be selected when the
multi-select picker is presented.

• fast/forms/ios/disabled-options-in-multi-select-picker-expected.txt: Added.
• fast/forms/ios/disabled-options-in-multi-select-picker.html: Added.
• platform/ipad/TestExpectations:

2:32 PM Changeset in webkit [266193] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r266074): cannot edit JavaScript breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=215860

Reviewed by Brian Burg.

• UserInterface/Models/JavaScriptBreakpoint.js:

(WI.JavaScriptBreakpoint.prototype.get editable):

2:05 PM Changeset in webkit [266192] by Chris Dumez

• 10 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky webaudio WPT tests.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

2:04 PM Changeset in webkit [266191] by Hector Lopez

• 2 edits in trunk/LayoutTests

rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure)

Unreviewed test gardening.

• platform/ios-13/TestExpectations:

2:01 PM Changeset in webkit [266190] by Jonathan Bedard

• 4 edits
  3 adds in trunk/Tools

[webkitcorepy] Standard Popen mocking API

​https://bugs.webkit.org/show_bug.cgi?id=215712
<rdar://problem/67501911>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/README.md: Add mocks.Subprocess documentation.
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/init.py: Export Subprocess, ProcessCompletion.
• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/popen.py: Added.

(Popen): Mock Popen object (for both Python 2 and 3). This object extracts a ProcessCompletion object from the
mocked Subprocess stack and behaives according to the content of that object.

• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py: Added.

(PopenBase): Base class to share code between Python 2 and 3 constructor.
(Popen): Mock Popen object (for both Python 2 and 3). This object extracts a ProcessCompletion object from the
mocked Subprocess stack and behaives according to the content of that object.

• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py: Added.

(ProcessCompletion): Class which captures the result of a mock Popen call.
(Subprocess):
(Subprocess.CommandRoute): Object which routes a set of subprocess arguments to a specific ProcessCompletion or callback which
generates a ProcessCompletion.
(Subprocess.completion_generator_for): Given a file, search through the mocked Subprocess stack to find the
first completion for the provided file.
(Subprocess.completion_for): Extract file name from arguments, find the completion generator, and call
it with the provieded arguments, working directory and stdin.
(Subprocess.init):

• Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/subprocess_unittest.py: Added.

(MockSubprocess):
(MockCheckOutput):
(MockCheckCall):
(MockRun):

1:42 PM Changeset in webkit [266189] by dino@apple.com

• 3 edits
  2 adds in trunk

Flickering on sedona.dev
​https://bugs.webkit.org/show_bug.cgi?id=215141

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/webgl/compositing-without-drawing.html

Our logic to determine if a canvas needs to be "repainted"
was over-zealous for WebGL. We were marking any context
that called draw commands as dirty, but they could in fact
be rendering to an offscreen texture/framebuffer. Then, when
it came time to composite, we'd happily swap buffers and
show something that had never been rendered to.

The fix is simply to ignore any of the dirtying notifications
when we are not bound to the default (canvas) framebuffer.

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Only
mark if we're rendering to the default framebuffer.

LayoutTests:

Test that serves an animation frame that touches
WebGL, but not in a way that requires a recomposite.

• fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
• fast/canvas/webgl/compositing-without-drawing.html: Added.

1:32 PM Changeset in webkit [266188] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.4

Tag Safari-610.1.28.1.4.

1:18 PM Changeset in webkit [266187] by commit-queue@webkit.org

• 19 edits in trunk

Implement DataTransfer constructor and multipart form filename encoding as other browsers do
​https://bugs.webkit.org/show_bug.cgi?id=215837

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-26
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/FileAPI/file/send-file-form-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-iso-2022-jp.tentative-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-utf-8-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-windows-1252.tentative-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-x-user-defined.tentative-expected.txt:
• web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:
• web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:

This test still fails because of bindings issues. DataTransfer.types should apparently return
a cached JSValue that is updated whenever the contents change, which I don't think our bindings
generator can handle right now, so these tests are now failing in a different way.
I think that's fine because I think most uses of DataTransfer.types will just be checking the contents,
not whether its === to a stored reference like these tests do. We should fix this later.

• web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub-expected.txt:
• web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub.html:

Updated to successfully submit the form to a listening server in our test infrastructure,
so that we see PASS like we do now on wpt.live

• web-platform-tests/service-workers/service-worker/data-transfer-files.https-expected.txt:

Source/WebCore:

Covered by newly passing WPT tests that Chrome and Firefox both pass.

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::create):

• dom/DataTransfer.h:
• dom/DataTransfer.idl:
• platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::addFilenameToMultiPartHeader):

LayoutTests:

• fast/dom/dom-constructors-expected.txt:
• fast/dom/dom-constructors.html:

1:09 PM Changeset in webkit [266186] by Chris Dumez

• 22 edits
  11 adds in trunk

IIRFilterNode interface is not supported
​https://bugs.webkit.org/show_bug.cgi?id=215810

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-getFrequencyResponse-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/test-iirfilternode-expected.txt:

Source/WebCore:

Add support for IIRFilterNode interface:

• ​https://www.w3.org/TR/webaudio/#iirfilternode

The implementation is based on Chromium's.

No new tests, rebaselined existing tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/webaudio/AudioNode.cpp:

(WebCore::convertEnumerationToString):
(WebCore::AudioNode::disableOutputsIfNecessary):

• Modules/webaudio/AudioNode.h:
• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createIIRFilter):

• Modules/webaudio/BaseAudioContext.h:
• Modules/webaudio/BaseAudioContext.idl:
• Modules/webaudio/IIRDSPKernel.cpp: Added.

(WebCore::IIRDSPKernel::IIRDSPKernel):
(WebCore::IIRDSPKernel::getFrequencyResponse):
(WebCore::IIRDSPKernel::process):
(WebCore::IIRDSPKernel::reset):

• Modules/webaudio/IIRDSPKernel.h: Added.
• Modules/webaudio/IIRFilterNode.cpp: Added.

(WebCore::isFilterStable):
(WebCore::IIRFilterNode::create):
(WebCore::IIRFilterNode::IIRFilterNode):
(WebCore::IIRFilterNode::getFrequencyResponse):

• Modules/webaudio/IIRFilterNode.h: Added.
• Modules/webaudio/IIRFilterNode.idl: Added.
• Modules/webaudio/IIRFilterOptions.h: Added.
• Modules/webaudio/IIRFilterOptions.idl: Added.
• Modules/webaudio/IIRProcessor.cpp: Added.

(WebCore::IIRProcessor::IIRProcessor):
(WebCore::IIRProcessor::~IIRProcessor):
(WebCore::IIRProcessor::createKernel):
(WebCore::IIRProcessor::process):
(WebCore::IIRProcessor::getFrequencyResponse):

• Modules/webaudio/IIRProcessor.h: Added.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• platform/audio/IIRFilter.cpp: Added.

(WebCore::evaluatePolynomial):
(WebCore::IIRFilter::IIRFilter):
(WebCore::IIRFilter::reset):
(WebCore::IIRFilter::process):
(WebCore::IIRFilter::getFrequencyResponse):
(WebCore::IIRFilter::tailTime):

• platform/audio/IIRFilter.h: Added.
• platform/graphics/ImageUtilities.h:

1:04 PM Changeset in webkit [266185] by Alan Coon

• 6 edits
  1 add in branches/safari-610.1.28.1-branch

Cherry-pick r265996. rdar://problem/67707045

[macOS] Web pages are not responding correctly to changes in "Reduce motion" setting
​https://bugs.webkit.org/show_bug.cgi?id=215664

Reviewed by Darin Adler.

Source/WebCore/PAL:

Declare "Reduce motion" preference key, as well as notification sent when the "Reduce motion" setting is changed.

• pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

This happens because there is a race between the preference change and notification being received in the WebContent
process. This race is usually won by the notification, which then reads the wrong preference value when being handled.
This bug was introduced when access to the preference daemon was closed in the WebContent process, and preferences
were updated from the UI process. This patch addresses this issue by re-posting the notification when the preference
value is updated in the WebContent process.

API test: WebKit.AccessibilityReduceMotion

• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::reduceMotionPreferenceKey): (WebKit::dispatchSimulatedNotificationsForPreferenceChange):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm: Added. (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 PM Changeset in webkit [266184] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r265985. rdar://problem/67707039

REGRESSION (r263729): Carousel freezes on "fourth page"/fourth click on right arrow on netflix.com
​https://bugs.webkit.org/show_bug.cgi?id=215655
<rdar://problem/65845979>

Reviewed by Dean Jackson.

Source/WebCore:

On netflix.com, when clicking on the left and right arrows in each movie or TV show carousel, the page attempts
to animate to the next page of the carousel using a CSS transform transition. The logic applies transform and
transition CSS properties to a container div, and adds a transitionend event listener which the page
expects to be invoked when the animation is complete. While waiting for this transitionend event, the script
also sets a boolean flag that prevents the carousel from being advanced to any other page. However, after the
changes in r263729, the carousel gets into a state where transition and transform styles are set, but the
animation never begins, and thus, no subsequent transitionend event is observed. This causes the page to
believe that the carousel is indefinitely animating, so it never unsets the boolean flag, which results in the
carousel being permanently stuck.

This occurs because we now have logic in AnimationTimeline::updateCSSTransitionsForElementAndProperty that
moves the CSSTransition from the element's map of running transitions to the map of completed transitions in
the case where the corresponding WebAnimation is already in Finished state. However, consider the case where
there is no matching backing animation (i.e. matchingBackingAnimation is nullptr); for instance, this can
happen if the transition CSS property is set to none in the middle of the transitionend event, as demonstrated
in the new layout test. Before the change, we would've removed the CSSTransition from the map of running
transitions and canceled it, but now, we instead move it to the map of completed transitions, where it remains
until the next CSS transition update is triggered (which would potentially be indefinitely long!).

On netflix.com, this next CSS transition update happens the page attempts to advance the carousel. Since the old
CSSTransition is still in the "completed" transitions map, we end up returning true when checking
propertyInStyleMatchesValueForTransitionInMap, and consequently never attempt to create a new CSSTransition
and add it to the map of running transitions in step 1 of the algorithm. As described above, this causes the
carousel to get stuck in a bad state.

To fix this, we simply revert to pre-r263729 behavior in the case where the matching backing animation was
already removed, and allow step 3 of the algorithm to cancel the running animation and remove it altogether
instead of moving it into the element's completed transitions map.

Test: animations/animation-followed-by-two-transitions.html

• animation/AnimationTimeline.cpp: (WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):

LayoutTests:

Adds a layout test inspired by animation logic used in the broken carousel UI on netflix.com. This test can be
manually run by opening the test in a browser and verifying that the green square quickly slides across the
screen twice, and two transitionend events are observed in the process.

• animations/animation-followed-by-two-transitions-expected.txt: Added.
• animations/animation-followed-by-two-transitions.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:57 PM Changeset in webkit [266183] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.4

12:54 PM Changeset in webkit [266182] by eric.carlson@apple.com

• 2 edits in trunk/Tools

TestWebKitAPI.AudioRoutingArbitration.Deletion is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=215856
<rdar://problem/66950074>

Reviewed by Jer Noble.

This test deletes a video element by removing it from the DOM, and verifies that
arbitration status changes appropriately. Arbitration status isn't changed until
the element's destructor runs, and that doesn't happen until it is garbage collected
so force GC while waiting for the status to change.

• TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm:

(AudioRoutingArbitration::statusShouldBecomeEqualTo): Add optional parameter to force
GC while waiting for status to change.
(TEST_F):

12:44 PM Changeset in webkit [266181] by commit-queue@webkit.org

• 4 edits in trunk

Use endings from FilePropertyBag when constructing Blob data from the File
​https://bugs.webkit.org/show_bug.cgi?id=215857

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-26
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/FileAPI/file/File-constructor-endings-expected.txt:

Source/WebCore:

We had an unnecessary conversion function that converted one of the two properties of BlobPropertyBag (endings was missing).
Since FilePropertyBag inherits from BlobPropertyBag, just use the original FilePropertyBag to get both properties.

Covered by newly-passing WPT tests that Chrome and Firefox both pass.

• fileapi/File.cpp:

(WebCore::File::File):
(WebCore::convertPropertyBag): Deleted.

12:36 PM Changeset in webkit [266180] by ysuzuki@apple.com

• 6 edits in trunk

[JSC] Enable Intl.Segmenter
​https://bugs.webkit.org/show_bug.cgi?id=215854

Reviewed by Ross Kirsling.

JSTests:

• stress/intl-segmenter.js:
• test262/config.yaml:

Source/JavaScriptCore:

This is already stage-3 and all the features are implemented. Let's just enable it.

• runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

• runtime/OptionsList.h:

11:49 AM Changeset in webkit [266179] by Russell Epstein

• 5 edits
  4 adds in branches/safari-610.1.28.0-branch

Apply patch. rdar://problem/67812567

11:41 AM Changeset in webkit [266178] by ysuzuki@apple.com

• 8 edits
  1 add in trunk

[JSC] Add ASCII comparison fast path for IntlCollator
​https://bugs.webkit.org/show_bug.cgi?id=215798

Reviewed by Darin Adler, Ross Kirsling, and Saam Barati.

JSTests:

• stress/string-locale-compare-uca-ducet.js: Added.

(shouldBe):

• stress/string-localeCompare.js:

(data.sort):

Source/JavaScriptCore:

The idea behind this change is the following: ICU Collator's comparison is too slow. We should have fast path for ASCII strings when we know this equals to ICU Collator's result.
The problem is that even for ASCII strings, collation is super complicated!

1. Unicode defines Unicode Collation Algorithm (UCA). To perform collation, it uses collation element tables which defines weights on various levels per code point. UCA also offers the Default Unicode Collation Element Table (DUCET). This UCA with DUCET is used when using ICU Root Collator.
2. UCA collation consists of rules, which defines how collation works. And ICU locales define customized collations by adding special rules to that.
3. UCA behaves differently by using different options.

Based on that, our observation is that some of major locales are not defining additional rules in (2). This means that they behaves the same to UCA with DUCET.
This patch implements a simplified version of comparison which generates the same results for ASCII strings (excluding control characters) to UCA with DUCET. This fast path can be usable only when the following conditions are met.

1. The collator does not have additional rules to ICU Root Colator.
2. The collator is using default options.

These checks are very important since there are a lot of edge-case locales. For example,

1. th (Thai language) ignores punctuations (even including ASCII punctuations) by default. This is defined as ignore-punctuations option is enabled by default, so without (2)'s check, th comparison becomes wrong.
2. There are contraction concept (multiple letters behave as a single letter). "ch" letters are ordered interestingly in Czech language. So even in ASCII, Czech shows very interesting collation behavior.

So we cannot safely take this fast path without carefully querying the information to ICU.

This shows 37% improvement in JetStream2/cdjs in en-US environment.

• runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):
(JSC::IntlCollator::compareStrings const):
(JSC::canDoASCIIUCADUCETComparisonWithUCollator):
(JSC::IntlCollator::updateCanDoASCIIUCADUCETComparison const):
(JSC::IntlCollator::checkICULocaleInvariants):

• runtime/IntlCollator.h:
• runtime/IntlObject.cpp:

(JSC::intlCollatorAvailableLocales):

• runtime/IntlObject.h:
• runtime/IntlObjectInlines.h:

(JSC::canUseASCIIUCADUCETComparison):
(JSC::compareASCIIWithUCADUCET):

11:07 AM Changeset in webkit [266177] by youenn@apple.com

• 16 edits
  2 copies in trunk

Abort pipeTo based on AbortSignal
​https://bugs.webkit.org/show_bug.cgi?id=215448

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/streams/piping/abort.any-expected.txt:
• web-platform-tests/streams/piping/abort.any.worker-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/flow-control.any-expected.txt:
• web-platform-tests/streams/piping/flow-control.any.worker-expected.txt:

Source/WebCore:

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/streams/ReadableStreamInternals.js:

(readableStreamPipeToWritableStream):
(pipeToFinalize):

• Modules/streams/WritableStream.js:

(initializeWritableStream):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::makeDOMExceptionForBuiltins):
(WebCore::whenSignalAborted):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

• bindings/js/WebCoreBuiltinNames.h:
• dom/AbortAlgorithm.h: Copied from Source/WebCore/dom/AbortSignal.idl.
• dom/AbortAlgorithm.idl: Copied from Source/WebCore/dom/AbortSignal.idl.
• dom/AbortSignal.cpp:

(WebCore::AbortSignal::whenSignalAborted):

• dom/AbortSignal.h:
• dom/AbortSignal.idl:

10:57 AM Changeset in webkit [266176] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

[Mac,EME] Netflix.com shows HDCP error for all streams
​https://bugs.webkit.org/show_bug.cgi?id=215825

Reviewed by Eric Carlson.

New API added to AVContentKeySession hits a sandbox restriction when run in the WebContent process, and the default
behavior when an error checking HDCP status is to report that the output is restricted, regardless of the displays
actual capabilities. To work around this behavior for now, pass in an empty displayID array, rather than the actual
displayID. This causes AVFoundation to do a "lowest common level of support" rather than a specific display check.
The upside is that this call no longer requires a connection to the WindowServer. The downside is that the
AVContentKeyRequest will report that its output is restricted if any non-HDCP compliant display is attached.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateProtectionStatusForDisplayID):

10:53 AM Changeset in webkit [266175] by Russell Epstein

• 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.4

10:43 AM Changeset in webkit [266174] by Russell Epstein

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.2.2

10:40 AM Changeset in webkit [266173] by Oriol Brufau

• 4 edits
  2 adds in trunk

[css-grid] Set available column space before grid items prelayout
​https://bugs.webkit.org/show_bug.cgi?id=199648

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Import WPT test.

• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-008-expected.html: Added.
• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-008.html: Added.
• web-platform-tests/css/css-grid/alignment/self-baseline/w3c-import.log:

Source/WebCore:

Before running the grid track sizing algorithm, there is a prelayout
step which takes care of the baseline alignment of the items.
In order to do that, we estimate the size of the grid area, since we
have not calculated the final size yet.

The problem was that, when calculating this estimate, the available
column space had not been set yet. So if a column had a percentage track
sizing function, it would be treated as auto and the estimated size
would be wrong.

This patch sets the available column space so that we can resolve
percentage track sizing functions and get a more correct estimate.

Test: imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-008.html

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

10:34 AM Changeset in webkit [266172] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Enable WritableStream by default
​https://bugs.webkit.org/show_bug.cgi?id=149842

Reviewed by Alex Christensen.

Implementation is now ready and is up to date with the latest specification.

• Shared/WebPreferences.yaml:

10:24 AM Changeset in webkit [266171] by Andres Gonzalez

• 4 edits in trunk/Source/WebCore

Code cleanup and consistent naming in AXIsolatedTree classes, no change in behavior.
​https://bugs.webkit.org/show_bug.cgi?id=215850

Reviewed by Chris Fleizach.

• Renamed AXIsolatedObject::m_attributeMap to m_propertyMap for naming

conssistency.

• typedef -> using
• Removed AXPropertyName::None, not used.
• Replaced AccessibilityIsolatedTreeMathMultiscriptPair alias with its

definition, shorter, clearer, and can be used for other property of the
same type.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::setMathscripts):
(WebCore::AXIsolatedObject::setProperty):
(WebCore::AXIsolatedObject::insertMathPairs):
(WebCore::AXIsolatedObject::mathPrescripts):
(WebCore::AXIsolatedObject::mathPostscripts):
(WebCore::AXIsolatedObject::intPointAttributeValue const):
(WebCore::AXIsolatedObject::objectAttributeValue const):
(WebCore::AXIsolatedObject::rectAttributeValue const):
(WebCore::AXIsolatedObject::vectorAttributeValue const):
(WebCore::AXIsolatedObject::optionSetAttributeValue const):
(WebCore::AXIsolatedObject::pairAttributeValue const):
(WebCore::AXIsolatedObject::uint64AttributeValue const):
(WebCore::AXIsolatedObject::urlAttributeValue const):
(WebCore::AXIsolatedObject::pathAttributeValue const):
(WebCore::AXIsolatedObject::colorAttributeValue const):
(WebCore::AXIsolatedObject::floatAttributeValue const):
(WebCore::AXIsolatedObject::doubleAttributeValue const):
(WebCore::AXIsolatedObject::unsignedAttributeValue const):
(WebCore::AXIsolatedObject::boolAttributeValue const):
(WebCore::AXIsolatedObject::stringAttributeValue const):
(WebCore::AXIsolatedObject::intAttributeValue const):

• accessibility/isolatedtree/AXIsolatedObject.h:
• accessibility/isolatedtree/AXIsolatedTree.h:

9:48 AM Changeset in webkit [266170] by ysuzuki@apple.com

• 9 edits in trunk

[JSC] Implement Intl.DateTimeFormat fractionalSecondDigits
​https://bugs.webkit.org/show_bug.cgi?id=215840

Reviewed by Ross Kirsling.

JSTests:

Test262 is showing wrong ordering of option property accesses compared to the latest PR.
Later, we should update Test262.

• stress/intl-datetimeformat.js:

(const.options.get second):
(const.options.get fractionalSecondDigits):
(const.options.get localeMatcher):
(const.options.get timeZoneName):
(const.options.get formatMatcher):

• test262/config.yaml:
• test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements fractionalSecondDigits option for Intl.DateTimeFormat. If it is
specified, milliseconds in N digits are represented in the formatted output.
This extension is about to be merged into the spec[1]. SpiderMonkey and V8 support it,
and V8 shipped it without flags.

[1]: ​https://github.com/tc39/ecma402/pull/347

• builtins/DatePrototype.js:

(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):

• runtime/CommonIdentifiers.h:
• runtime/IntlDateTimeFormat.cpp:

(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::setFormatsFromPattern):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::resolvedOptions const):
(JSC::partTypeString):

• runtime/IntlDateTimeFormat.h:

9:46 AM Changeset in webkit [266169] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Move inline run alignment logic to a dedicated class
​https://bugs.webkit.org/show_bug.cgi?id=214527
<rdar://problem/66115796>

Reviewed by Antti Koivisto.

This is in preparation for moving line alignment logic to LineBox (LineBuilder will not going to be responsible for aligning runs on the line).

• layout/FormattingContext.h:
• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineContentAligner::formattingContext const):
(WebCore::Layout::LineContentAligner::layoutState const):
(WebCore::Layout::LineContentAligner::LineContentAligner):
(WebCore::Layout::LineContentAligner::alignHorizontally):
(WebCore::Layout::LineContentAligner::alignVertically):
(WebCore::Layout::LineContentAligner::justifyRuns):
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight):
(WebCore::Layout::LineContentAligner::collectHangingContent const):
(WebCore::Layout::LineContentAligner::runContentHeight const):
(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::~LineBuilder):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::clear):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::alignContentVertically): Deleted.
(WebCore::Layout::LineBuilder::justifyRuns): Deleted.
(WebCore::Layout::LineBuilder::alignHorizontally): Deleted.
(WebCore::Layout::LineBuilder::collectHangingContent): Deleted.
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineBuilder::runContentHeight const): Deleted.
(WebCore::Layout::LineBuilder::layoutState const): Deleted.
(WebCore::Layout::LineBuilder::root const): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::availableWidth const):
(WebCore::Layout::LineBuilder::contentLogicalRight const):
(WebCore::Layout::LineBuilder::logicalTop const): Deleted.
(WebCore::Layout::LineBuilder::logicalBottom const): Deleted.
(WebCore::Layout::LineBuilder::logicalLeft const): Deleted.
(WebCore::Layout::LineBuilder::logicalRight const): Deleted.
(WebCore::Layout::LineBuilder::logicalWidth const): Deleted.
(WebCore::Layout::LineBuilder::logicalHeight const): Deleted.
(WebCore::Layout::LineBuilder::baseline const): Deleted.

9:18 AM Changeset in webkit [266168] by Chris Dumez

• 54 edits
  2 adds in trunk

REGRESSION (r265908): Crash under Blob::arrayBuffer() / Blob::text() in stress GC
​https://bugs.webkit.org/show_bug.cgi?id=215832
<rdar://problem/67741677>

Reviewed by Ryosuke Niwa.

Source/WebCore:

r265908 added support for Blob::arrayBuffer() / Blob::text() which are asynchronous operations
returning promises. The crash is due to the fact that the Blob's JS wrapper may get garbage
collected before the promise is settled.

To address the issue, this patch makes Blob an ActiveDOMObject and creates an
ActiveDOMObject::pendingActivity whenever there is a pending promise so that the JS wrapper
does not get garbage collected too early.

Test: fast/files/blob-text-gc.html

• Modules/async-clipboard/Clipboard.cpp:

(WebCore::Clipboard::getType):

• Modules/async-clipboard/ClipboardImageReader.h:

(WebCore::ClipboardImageReader::ClipboardImageReader):

• Modules/async-clipboard/ClipboardItem.cpp:

(WebCore::ClipboardItem::blobFromString):

• Modules/async-clipboard/ClipboardItem.h:
• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:

(WebCore::ClipboardItemBindingsDataSource::getType):

• Modules/async-clipboard/ios/ClipboardImageReaderIOS.mm:

(WebCore::ClipboardImageReader::readBuffer):

• Modules/async-clipboard/mac/ClipboardImageReaderMac.mm:

(WebCore::ClipboardImageReader::readBuffer):

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::getFile):

• Modules/entriesapi/DOMFileSystem.h:
• Modules/entriesapi/FileSystemFileEntry.cpp:

(WebCore::FileSystemFileEntry::file):

• Modules/entriesapi/FileSystemFileEntry.h:
• Modules/entriesapi/FileSystemFileEntry.idl:
• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::fromFormData):

• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::blobFromData):
(WebCore::packageFormData):
(WebCore::resolveWithTypeAndData):
(WebCore::FetchBodyConsumer::resolve):
(WebCore::FetchBodyConsumer::takeAsBlob):

• Modules/fetch/FetchBodyConsumer.h:
• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::blob):

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::requestData):

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::didReceiveRawData):

• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):

• Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readTerminal):

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::updateFileList):
(WebCore::DataTransfer::items):
(WebCore::DataTransfer::filesFromPasteboardAndItemList const):
(WebCore::DataTransfer::files const):

• dom/DataTransfer.h:
• dom/DataTransfer.idl:
• dom/DataTransferItemList.cpp:

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::remove):
(WebCore::DataTransferItemList::clear):
(WebCore::DataTransferItemList::ensureItems const):
(WebCore::DataTransferItemList::document const):

• dom/DataTransferItemList.h:
• dom/DataTransferItemList.idl:
• editing/WebCorePasteboardFileReader.cpp:

(WebCore::WebCorePasteboardFileReader::readFilename):
(WebCore::WebCorePasteboardFileReader::readBuffer):

• editing/WebCorePasteboardFileReader.h:
• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::createFragmentForImageAttachment):
(WebCore::replaceRichContentWithAttachments):
(WebCore::createFragmentAndAddResources):
(WebCore::sanitizeMarkupWithArchive):
(WebCore::WebContentReader::readImage):
(WebCore::attachmentForFilePath):
(WebCore::attachmentForData):

• editing/markup.cpp:

(WebCore::restoreAttachmentElementsInFragment):

• fileapi/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::loadBlob):
(WebCore::Blob::activeDOMObjectName const):

• fileapi/Blob.h:

(WebCore::Blob::create):
(WebCore::Blob::deserialize):
(WebCore::Blob::slice const):

• fileapi/Blob.idl:
• fileapi/File.cpp:

(WebCore::File::createWithRelativePath):
(WebCore::File::create):
(WebCore::File::File):
(WebCore::File::activeDOMObjectName const):

• fileapi/File.h:
• fileapi/File.idl:
• html/DOMFormData.cpp:

(WebCore::DOMFormData::createFileEntry):

• html/DirectoryFileListCreator.cpp:

(WebCore::FileInformation::isolatedCopy const):
(WebCore::appendDirectoryFiles):
(WebCore::gatherFileInformation):
(WebCore::toFileList):
(WebCore::DirectoryFileListCreator::start):

• html/DirectoryFileListCreator.h:
• html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData const):
(WebCore::FileInputType::filesChosen):

• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toBlob):

• testing/Internals.cpp:

(WebCore::Internals::createFile):

• testing/ServiceWorkerInternals.cpp:

(WebCore::ServiceWorkerInternals::createOpaqueWithBlobBodyResponse):

• workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::dispatchFetchEvent):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createResponseBlob):

Source/WebKit:

• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::setFilesForInputFileUpload):

LayoutTests:

Add better test coverage.

• fast/files/blob-text-gc-expected.txt: Added.
• fast/files/blob-text-gc.html: Added.

5:08 AM Changeset in webkit [266167] by Andres Gonzalez

• 3 edits in trunk/Source/WebCore

When caching the AccessibilityText property in AXIsolatedObject, the Strings need to be isolatedCopied.
​https://bugs.webkit.org/show_bug.cgi?id=215834

Reviewed by Chris Fleizach.

The initialization of the AccessibilityText property in AXIsolatedObject::initializeAttributeData
wasn't isolatedCopying the Strings contained in the AccessibilityText structure.
Instead it was copying the String into a different structure. This patch
straightlines the caching of the AccessibilityText property by isolatedCopying
the original Strings. This simplifies the retrieval of this property
since there is no conversion to make in the AXIsolatedObject::accessibilityText
method.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData): isolatedCopies the
String in AccessibilityText.
(WebCore::AXIsolatedObject::accessibilityText const): No conversion
needed to retrieve the property.

• accessibility/isolatedtree/AXIsolatedTree.h:

Removed the AccessibilityIsolatedTreeText structure since it is not needed.

4:16 AM Changeset in webkit [266166] by youenn@apple.com

• 44 edits
  2 adds in trunk

enumerateDevices should expose audiooutput devices that are tied to an audio input device
​https://bugs.webkit.org/show_bug.cgi?id=215806

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/mediacapture-streams/MediaStreamTrack-getSettings.https-expected.txt:
• web-platform-tests/mediacapture-streams/MediaStreamTrack-getSettings.https.html:

Source/WebCore:

Add support for a speaker selection feature policy, as per ​https://w3c.github.io/mediacapture-output/#permissions-policy-integration.
Add support for speaker mock devices and for listing speakers on MacOS in CoreAudioCaptureDeviceManager.
Add support for groupId to group microphones and speakers for both mock audio manager and CoreAudioCaptureDeviceManager.
For mock speakers, we add two audiooutput devices that are related to a microphone and one audiooutput that is not related to any microphone.

Test: fast/mediastream/enumerate-speaker.html

• Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::MediaDevices):
(WebCore::checkSpeakerAccess):
(WebCore::toMediaDeviceInfoKind):
(WebCore::MediaDevices::refreshDevices):

• Modules/mediastream/MediaDevices.h:
• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::sourceCaptureState):
(WebCore::MediaStreamTrack::updateToPageMutedState):

• html/FeaturePolicy.cpp:

(WebCore::policyTypeName):
(WebCore::FeaturePolicy::parse):
(WebCore::FeaturePolicy::allows const):

• html/FeaturePolicy.h:
• page/Settings.yaml:
• platform/mediastream/CaptureDevice.h:

(WebCore::CaptureDevice::label const):
(WebCore::CaptureDevice::setGroupId):

• platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::getMediaStreamDevices):

• platform/mediastream/RealtimeMediaSourceFactory.h:
• platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:

(WebCore::GStreamerAudioCaptureSourceFactory::speakerDevices const):

• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:
• platform/mediastream/mac/CoreAudioCaptureDevice.cpp:

(WebCore::CoreAudioCaptureDevice::create):
(WebCore::CoreAudioCaptureDevice::CoreAudioCaptureDevice):
(WebCore::CoreAudioCaptureDevice::relatedAudioDeviceIDs):

• platform/mediastream/mac/CoreAudioCaptureDevice.h:
• platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:

(WebCore::CoreAudioCaptureDeviceManager::captureDevices):
(WebCore::deviceHasOutputStreams):
(WebCore::getDefaultCaptureInputDevice):
(WebCore::hasDevice):
(WebCore::CoreAudioCaptureDeviceManager::refreshAudioCaptureDevices):

• platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:
• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSourceFactory::speakerDevices const):

• platform/mediastream/mac/CoreAudioCaptureSource.h:
• platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:

(WebCore::DisplayCaptureManagerCocoa::captureDeviceWithPersistentID):

• platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::create):

• platform/mock/MockMediaDevice.h:

(WebCore::MockSpeakerProperties::encode const):
(WebCore::MockSpeakerProperties::decode):
(WebCore::MockMediaDevice::isSpeaker const):
(WebCore::MockMediaDevice::captureDevice const):
(WebCore::MockMediaDevice::type const):
(WebCore::MockMediaDevice::speakerProperties const):
(WebCore::MockMediaDevice::encode const):
(WebCore::MockMediaDevice::decode):

• platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::defaultDevices):
(WebCore::deviceListForDevice):
(WebCore::toCaptureDevice):
(WebCore::createMockDevice):
(WebCore::MockRealtimeMediaSourceCenter::setDevices):
(WebCore::MockRealtimeMediaSourceCenter::addDevice):
(WebCore::MockRealtimeMediaSourceCenter::captureDeviceWithPersistentID):
(WebCore::MockRealtimeMediaSourceCenter::microphoneDevices):
(WebCore::MockRealtimeMediaSourceCenter::speakerDevices):
(WebCore::MockRealtimeMediaSourceCenter::videoDevices):

• platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit:

Introduce an experimental flag (off by default) to cover speaker selection, including exposing speaker devices to web pages.
Update UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList to only expose speakers that are tied to a microphone that is exposed.
This aligns with ​https://w3c.github.io/mediacapture-output/#privacy-obtaining-consent.

• GPUProcess/GPUConnectionToWebProcess.cpp:
• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKMockMediaDevice.cpp:

(WKAddMockMediaDevice):

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetExposeSpeakersEnabled):
(WKPreferencesGetExposeSpeakersEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::isMicrophoneDevice):
(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):

• WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:

(WebKit::sourceTypeFromDeviceType):
(WebKit::RemoteRealtimeMediaSource::RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::~RemoteRealtimeMediaSource):

• WebProcess/cocoa/UserMediaCaptureManager.h:

Tools:

Enable experimental flag.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

• fast/mediastream/enumerate-speaker-expected.txt: Added.
• fast/mediastream/enumerate-speaker.html: Added.
• fast/mediastream/get-user-media-device-id.html:
• http/tests/media/media-stream/enumerate-devices-source-id.html:
• http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt:
• http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html:

Rewrite test to use testharness and ensure order of the iframe tests so that console messages are ordered.

• http/tests/media/media-stream/resources/enumerate-devices-iframe.html:

2:08 AM Changeset in webkit [266165] by Diego Pino Garcia

• 3 edits in trunk/Tools

[ews] Split JSC ARMv7 queue into separate builder and tester queue
​https://bugs.webkit.org/show_bug.cgi?id=215728

Reviewed by Aakash Jain.

This new bubble runs jscore-tests for JSC ARMv7 32-bit. The former
'jsc-armv7' bubble now reports about successful binary builds for the
same architecture.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble):

• BuildSlaveSupport/ews-build/config.json:

12:53 AM Changeset in webkit [266164] by Paulo Matos

• 2 edits in trunk/JSTests

Skip stress/array-species-create-should-handle-masquerader.js on MIPS

Unreviewed Gardening.

• stress/array-species-create-should-handle-masquerader.js:

12:51 AM Changeset in webkit [266163] by Diego Pino Garcia

• 2 edits
  2 adds in trunk/LayoutTests

[GTK] Unreviewed test gardening. Emit baseline after r266129.

Also mark two tests as time out flaky after r266118.

• platform/glib/TestExpectations:
• platform/gtk/streams/pipe-to-expected.txt: Added.

12:22 AM Changeset in webkit [266162] by youenn@apple.com

• 5 edits in trunk

pipeThrough should check for readableStream type
​https://bugs.webkit.org/show_bug.cgi?id=215497

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/streams/piping/pipe-through.any-expected.txt:
• web-platform-tests/streams/piping/pipe-through.any.worker-expected.txt:

Source/WebCore:

Covered by rebased tests.

• Modules/streams/ReadableStream.js:

(pipeThrough):

Aug 25, 2020:

11:26 PM Changeset in webkit [266161] by Diego Pino Garcia

• 17 edits in trunk/LayoutTests

[GTK] Update test expectations. Update baselines after r266118.

• platform/glib/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt:
• platform/gtk/css1/font_properties/font-expected.txt:
• platform/gtk/fast/css/font-face-multiple-faces-expected.txt:
• platform/gtk/fast/css/font-face-synthetic-bold-italic-expected.txt:
• platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
• platform/gtk/fast/invalid/junk-data-expected.txt:
• platform/gtk/fast/invalid/missing-end-tag-expected.txt:
• platform/gtk/fast/parser/xhtml-alternate-entities-expected.txt:
• platform/gtk/fast/xsl/xslt-extra-content-at-end-expected.txt:
• platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
• platform/gtk/svg/custom/bug45331-expected.txt:
• platform/gtk/svg/custom/junk-data-expected.txt:
• platform/gtk/svg/custom/missing-xlink-expected.txt:
• platform/gtk/svg/custom/path-bad-data-expected.txt:
• platform/gtk/svg/custom/use-font-face-crash-expected.txt:
• platform/gtk/svg/hixie/error/012-expected.txt:

11:15 PM Changeset in webkit [266160] by Fujii Hironori

• 4 edits in trunk/Source/WebCore

Move FreeType port's Font::platformWidthForGlyph and Font::platformBoundsForGlyph for Cairo port (WinCairo port)
​https://bugs.webkit.org/show_bug.cgi?id=215838

Reviewed by Carlos Garcia Campos.

WinCairo was using GDI API to implement
Font::platformWidthForGlyph and Font::platformBoundsForGlyph. This
is a problem for Cairo DirectWrite font backend (Bug 215259).
FreeType port has platform independent implementations which are
using Cairo API. Use them for WinCairo.

• platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::platformBoundsForGlyph const): Moved from SimpleFontDataFreeType.cpp.
(WebCore::Font::platformWidthForGlyph const): Ditto.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformBoundsForGlyph const): Moved to FontCairo.cpp.
(WebCore::Font::platformWidthForGlyph const): Ditto.

• platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::Font::platformBoundsForGlyph const): Deleted.
(WebCore::Font::platformWidthForGlyph const): Deleted.

10:17 PM Changeset in webkit [266159] by ysuzuki@apple.com

• 5 edits
  1 add in trunk

[JSC] FTL should use m_origin instead of m_node->origin since m_node can be nullptr
​https://bugs.webkit.org/show_bug.cgi?id=215833

Reviewed by Mark Lam.

JSTests:

• stress/ftl-entry-osr-exit-has-nullptr-node.js: Added.

(foo):

Source/JavaScriptCore:

While we are using m_node->origin, m_node can be nullptr (at the entry of the FTL function).
m_origin is always pointing appropriate origin. We should use it instead.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileToObjectOrCallObjectConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileToThis):
(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMul):
(JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileStrCat):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToB3::compileArithClz32):
(JSC::FTL::DFG::LowerDFGToB3::compileValueDiv):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMod):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAbs):
(JSC::FTL::DFG::LowerDFGToB3::compileArithUnary):
(JSC::FTL::DFG::LowerDFGToB3::compileValuePow):
(JSC::FTL::DFG::LowerDFGToB3::compileArithRandom):
(JSC::FTL::DFG::LowerDFGToB3::compileArithRound):
(JSC::FTL::DFG::LowerDFGToB3::compileArithFloor):
(JSC::FTL::DFG::LowerDFGToB3::compileArithCeil):
(JSC::FTL::DFG::LowerDFGToB3::compileArithTrunc):
(JSC::FTL::DFG::LowerDFGToB3::compileArithSqrt):
(JSC::FTL::DFG::LowerDFGToB3::compileArithFRound):
(JSC::FTL::DFG::LowerDFGToB3::compileIncOrDec):
(JSC::FTL::DFG::LowerDFGToB3::compileValueNegate):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitAnd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitOr):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitXor):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitRShift):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitLShift):
(JSC::FTL::DFG::LowerDFGToB3::compileGetById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsIsLockFree):
(JSC::FTL::DFG::LowerDFGToB3::compileDefineDataProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileDefineAccessorProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileGetIndexedPropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPrototypeOf):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutGetterSetterById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteById):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPush):
(JSC::FTL::DFG::LowerDFGToB3::compileArraySlice):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPop):
(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateScopedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateArgumentsButterfly):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateRest):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectKeysOrObjectGetOwnPropertyNames):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectCreate):
(JSC::FTL::DFG::LowerDFGToB3::compileNewSymbol):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArray):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateThis):
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumeric):
(JSC::FTL::DFG::LowerDFGToB3::compileCallNumberConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf):
(JSC::FTL::DFG::LowerDFGToB3::compileToPrimitive):
(JSC::FTL::DFG::LowerDFGToB3::compileToPropertyKey):
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToB3::compileStringFromCharCode):
(JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset):
(JSC::FTL::DFG::LowerDFGToB3::compileGetGlobalThis):
(JSC::FTL::DFG::LowerDFGToB3::compileGetArgument):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compileSameValue):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
(JSC::FTL::DFG::LowerDFGToB3::compileVarargsLength):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileSwitch):
(JSC::FTL::DFG::LowerDFGToB3::compileThrow):
(JSC::FTL::DFG::LowerDFGToB3::compileThrowStaticError):
(JSC::FTL::DFG::LowerDFGToB3::mapHashString):
(JSC::FTL::DFG::LowerDFGToB3::compileMapHash):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket):
(JSC::FTL::DFG::LowerDFGToB3::compileSetAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileMapSet):
(JSC::FTL::DFG::LowerDFGToB3::compileTypeOfIsObject):
(JSC::FTL::DFG::LowerDFGToB3::compileIsCallable):
(JSC::FTL::DFG::LowerDFGToB3::compileIsConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileInByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileHasOwnProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileParseInt):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOfCustom):
(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileHasGenericProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileHasStructurePropertyImpl):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDirectPname):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPropertyEnumerator):
(JSC::FTL::DFG::LowerDFGToB3::compileToIndexString):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckTraps):
(JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp):
(JSC::FTL::DFG::LowerDFGToB3::compileSetFunctionName):
(JSC::FTL::DFG::LowerDFGToB3::compileStringReplace):
(JSC::FTL::DFG::LowerDFGToB3::compileLogShadowChickenTail):
(JSC::FTL::DFG::LowerDFGToB3::getArgumentsLength):
(JSC::FTL::DFG::LowerDFGToB3::getCurrentCallee):
(JSC::FTL::DFG::LowerDFGToB3::getArgumentsStart):
(JSC::FTL::DFG::LowerDFGToB3::compare):
(JSC::FTL::DFG::LowerDFGToB3::compileStringSlice):
(JSC::FTL::DFG::LowerDFGToB3::compileToLowerCase):
(JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithRadix):
(JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithValidRadixConstant):
(JSC::FTL::DFG::LowerDFGToB3::compileResolveScopeForHoistingFuncDeclInEval):
(JSC::FTL::DFG::LowerDFGToB3::compileResolveScope):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compilePutDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOM):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter):
(JSC::FTL::DFG::LowerDFGToB3::compileLoopHint):
(JSC::FTL::DFG::LowerDFGToB3::genericJSValueCompare):
(JSC::FTL::DFG::LowerDFGToB3::stringsEqual):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::boolify):
(JSC::FTL::DFG::LowerDFGToB3::equalNullOrUndefined):
(JSC::FTL::DFG::LowerDFGToB3::contiguousPutByValOutOfBounds):
(JSC::FTL::DFG::LowerDFGToB3::switchStringSlow):
(JSC::FTL::DFG::LowerDFGToB3::buildTypeOf):
(JSC::FTL::DFG::LowerDFGToB3::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToB3::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::FTL::DFG::LowerDFGToB3::codeOriginDescriptionOfCallSite const):
(JSC::FTL::DFG::LowerDFGToB3::callCheck):
(JSC::FTL::DFG::LowerDFGToB3::appendOSRExit):

• jsc.cpp:

(runJSC):

• runtime/OptionsList.h:

10:09 PM Changeset in webkit [266158] by timothy_horton@apple.com

• 5 edits
  4 adds in trunk

Web Share API Level 2 functions even when its experimental feature flag is disabled
​https://bugs.webkit.org/show_bug.cgi?id=215831
<rdar://problem/67760687>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/web-share/canShare-with-files-feature-disabled.html

fast/web-share/share-with-files-feature-disabled.html

We had a feature flag for Web Share API Level 2, but it isn't actually
consulted anywhere in the implementation.

• page/Navigator.cpp:

(WebCore::Navigator::canShare):
Rewrite canShare to be a bit more readable, and also to consult the Level 2 feature flag.

(WebCore::Navigator::share):
Since canShare (per the spec) will return true if we have files and other content,
even if files are not shareable, check the feature flag again before loading the files.

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showShareSheet):
If the Web Content process sends us files, but the Level 2 feature flag is disabled,
something fishy is happening, so fire a MESSAGE_CHECK.

LayoutTests:

• fast/web-share/canShare-with-files-feature-disabled-expected.txt: Added.
• fast/web-share/canShare-with-files-feature-disabled.html: Added.
• fast/web-share/share-with-files-feature-disabled-expected.txt: Added.
• fast/web-share/share-with-files-feature-disabled.html: Added.

Add some tests that ensure that disabling the feature actually works.

7:25 PM Changeset in webkit [266157] by rniwa@webkit.org

• 24 edits in trunk

HashMap<Ref<T>>::take should return RefPtr<T>
​https://bugs.webkit.org/show_bug.cgi?id=215830

Reviewed by Darin Adler.

Source/WebCore:

• Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::didGetAllDatabaseNamesAndVersions):

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::removeTreeForPageID):

• crypto/SubtleCrypto.cpp:

(WebCore::getPromise):

• dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::addElementDefinition):

• dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::notifyFinished):

• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didRemoveDOMNode):

• page/PageOverlayController.cpp:

(WebCore::PageOverlayController::uninstallPageOverlay):

• workers/service/ServiceWorkerClients.cpp:

(WebCore::ServiceWorkerClients::claim):

• workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::ServiceWorkerThreadProxy::cancelFetch):

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::workerContextTerminated):

Source/WebKit:

• GPUProcess/media/RemoteAudioDestinationManager.cpp:

(WebKit::RemoteAudioDestinationManager::deleteAudioDestination):

• NetworkProcess/NetworkResourceLoadMap.cpp:

(WebKit::NetworkResourceLoadMap::take):

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::willClosePage):

• UIProcess/WebURLSchemeHandler.cpp:

(WebKit::WebURLSchemeHandler::taskCompleted):

• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted):
(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasDenied):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::didCheckSucceed):

Source/WTF:

Updated the hash traits for Ref<T> to make HashMap<Ref<T>> and HashSet<Ref<T>>
return RefPtr<T> instad of Optional<Ref<T>>.

• wtf/HashTraits.h:

(WTF::RefHashTraits::take):

Tools:

• TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):

7:22 PM Changeset in webkit [266156] by Alan Bujtas

• 3 edits
  2 adds in trunk

Facebook post with lots of comments has cut off scrollbar, and can't scroll fully to the bottom (sticky)
​https://bugs.webkit.org/show_bug.cgi?id=215719
<rdar://problem/66411757>

Reviewed by Simon Fraser.

Source/WebCore:

While computing the scrollable overflow for inflow positioned (or transformed) renderers, we need to take their paint geometry into
account so that scrolling matches their final positions.
e.g.

<div style="width: 100px; height: 100px;"></div>
<div style="position: relative; top: -20; width: 50px; height: 50px;"></div>

While the inflow positioned block box is placed right below the previous sibling div, visually they overlap each other.
If these boxes happen to be in a scrollable container, the scrolling should be driven by the overlapping state (paint geometry) and not
by the layout geometry (where the 2 boxes are placed vertically after each other).

While stickily positioned boxes are also considered inflow positioned, their initial inflow layout positions contribute to the scrollable overflow
as they are not stationary boxes.

Test: fast/css/scrollable-overflow-with-sticky-positioning.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::layoutOverflowRectForPropagation const):

LayoutTests:

• fast/css/scrollable-overflow-with-sticky-positioning-expected.html: Added.
• fast/css/scrollable-overflow-with-sticky-positioning.html: Added.

6:31 PM Changeset in webkit [266155] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC][IFC] Do not move the runs out of the LineBuilder while closing the line
​https://bugs.webkit.org/show_bug.cgi?id=214790

Reviewed by Antti Koivisto.

Closing the line should not mean that the LineBuilder does not have the line runs anymore.
This is in preparation for moving alignment code from LineBuilder to LineBox.
(This patch also refactors InlineFormattingContext::lineLayout to make it less verbose.)

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::append):

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::runs const):

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::layoutInlineContent):
(WebCore::Layout::LineLayoutContext::close):
(WebCore::Layout::LineLayoutContext::nextContentForLine):
(WebCore::Layout::LineLayoutContext::commitFloats):
(WebCore::Layout::LineLayoutContext::layoutLine): Deleted.

• layout/inlineformatting/LineLayoutContext.h:

(WebCore::Layout::LineLayoutContext::InlineItemRange::isEmpty const):
(WebCore::Layout::LineLayoutContext::InlineItemRange::size const):

5:28 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

5:08 PM Changeset in webkit [266154] by clopez@igalia.com

• 2 edits in trunk/Tools

[GTK][WPE] Add a script for generating MiniBrowser bundles (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=215266

Unreviewed follow-up fix.

Ensure the install-dependencies script of the bundle calls apt-get update
before trying to install the system packages when --autoinstall is passed.

• Scripts/generate-bundle:

4:55 PM Changeset in webkit [266153] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67764580 REGRESSION: [ BigSur ] 20 fast/ and tables/ tests are a constant failure

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:33 PM Changeset in webkit [266152] by Alan Coon

• 1 copy in tags/Safari-610.1.28.0.3

Tag Safari-610.1.28.0.3.

3:46 PM Changeset in webkit [266151] by timothy_horton@apple.com

• 8 edits
  2 adds in trunk

Web Share API can share non-HTTP(S) URLs
​https://bugs.webkit.org/show_bug.cgi?id=215823
<rdar://problem/62083130>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/web-share/share-disallows-file-urls.html

• page/Navigator.cpp:

(WebCore::shareableURLForShareData):
(WebCore::Navigator::canShare):
(WebCore::Navigator::share):
Factor out the code to complete and check the scheme of the URL.
Make canShare() return NO and share() fail for non-HTTP(S) or data: URLs.

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showShareSheet):
Ensure that only HTTP family or data: URLs are shared.

LayoutTests:

• fast/web-share/share-disallows-file-urls-expected.txt: Added.
• fast/web-share/share-disallows-file-urls.html: Added.
• fast/web-share/share-transient-activation-expired.html:
• fast/web-share/share-transient-activation.html:
• fast/web-share/share.html:

Add a test that ensures that sharing a non-HTTP-family URL fails,
and fix the existing tests to share HTTP-family URLs.

3:26 PM Changeset in webkit [266150] by commit-queue@webkit.org

• 18 edits in trunk/Tools

Remove unneeded HAVE(NETWORK_FRAMEWORK) macro
​https://bugs.webkit.org/show_bug.cgi?id=215824

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-25
Reviewed by Darin Adler.

This used to be needed for High Sierra support, which was before Network.framework was introduced.
Now, we can assume it is available on all Cocoa platforms.

• TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
• TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
• TestWebKitAPI/cocoa/HTTPServer.h:
• TestWebKitAPI/cocoa/HTTPServer.mm:
• TestWebKitAPI/config.h:

3:20 PM Changeset in webkit [266149] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

[Win] The layout test animations/steps-transform-rendering-updates.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=215827

Unreviewed test gardening.

• platform/win/TestExpectations:

3:08 PM Changeset in webkit [266148] by beidson@apple.com

• 5 edits
  3 adds in trunk

Font loads quickly followed by navigations may fail indefinitely
<rdar://problem/65560550> and ​https://bugs.webkit.org/show_bug.cgi?id=215435

Reviewed by Myles C. Maxfield.

Source/WebCore:

Second take at this.

Myles took the first swipe at this, but a conflict with SuspendableTimer caused issues
in the form of layout test asserts with
http/tests/security/navigate-when-restoring-cached-page.html

His original ChangeLog entry:

Font loads are coalesced using a zero-delay timer. However, that zero-delay timer
can fire while the page is in the middle of a navigation, which will cause the font
loads to fail. Then, the second page can request those same fonts, which are marked
as failed, and as such will never actually load/use the desired web font.

This patch just stops the zero-delay timer during navigations, and resumes it
when resuming the document. This means:

1. The second page in the above story will not see that the font has failed, or

even started, and will then re-request the font and load it successfully

2. If the user goes "back" to the previous page, the zero-delay timer is restarted,

the CachedFont realizes it's already succeeded, and the previous page is rendered
as expected.

Test: fast/loader/font-load-timer.html

---

Now the explanation of the failure it caused:
The font loading timer was a SuspendableTimer, which is an ActiveDOMObject.

An ActiveDOMObject was used to make sure the delayed font loads play well with the
page cache, which is still necessary.

But we also still need to suspend the timer manually when "stopLoading()" is called,
which doesn't play well with ActiveDOMObject's automatic suspend/resume.

My solution:

• Make the timer "just a normal timer"
• Make CSSFontSelector itself the ActiveDOMObject
• Let DocumentLoader explicitly pause the font load timer
• Rely on ActiveDOMObject to resume the timer

These keep the bug fixed and resolve the layout test ASSERT seen with
http/tests/security/navigate-when-restoring-cached-page.html

• css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::clearDocument):
(WebCore::CSSFontSelector::beginLoadingFontSoon):
(WebCore::CSSFontSelector::suspendFontLoadingTimer):
(WebCore::CSSFontSelector::fontLoadingTimerFired):
(WebCore::CSSFontSelector::stop):
(WebCore::CSSFontSelector::suspend):
(WebCore::CSSFontSelector::resume):
(WebCore::CSSFontSelector::beginLoadTimerFired): Deleted.

• css/CSSFontSelector.h:
• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading):

LayoutTests:

1) The page has some content that has “font-family: WebFont” but there are no @font-face blocks on the page
2) In script, after the page has loaded, add an @font-face rule to the page with “font-family: WebFont” and some valid font URL
3) Synchronously, within the same turn of the run loop, trigger a synchronous layout of the element (using offsetWidth or something). This will add the font to the 0-delay time work list.
4) Synchronously, within the same turn of the run loop, navigate to a second page that doesn’t use the web font.
5) The second page waits some small-but-positive amount of time. This will cause the 0-delay timer to fire, but because the page is in the middle of navigating, the font load should fail.
6) The second page adds the same @font-face rule to itself using script. This should pull the same (failed) CachedResource object out of the memory cache.
7) Use the CSS Font Loading API to wait for the font load to complete
8) Make sure that the font is used on the second page (as a reference test). Today, the second page’s font load will fail because it pulled the failed font out of the memory cache. The test makes sure the second page’s font load succeeds.

• fast/loader/font-load-timer-expected.html: Added.
• fast/loader/font-load-timer.html: Added.
• fast/loader/resources/font-load-timer-navigation-destination.html: Added.

3:00 PM Changeset in webkit [266147] by Alan Coon

• 1 copy in tags/Safari-610.2.2.1

Tag Safari-610.2.2.1.

2:57 PM Changeset in webkit [266146] by Alan Coon

• 19 edits
  2 deletes in branches/safari-610.2.2-branch

Revert r265115. rdar://problem/67759082

2:51 PM Changeset in webkit [266145] by pvollan@apple.com

• 3 edits in trunk/Source/WTF

[Win] Assert failure under RunLoop::RunLoop
​https://bugs.webkit.org/show_bug.cgi?id=215812

Reviewed by Brent Fulgham.

The assert 'ASSERT(::IsWindow(m_runLoopMessageWindow))' under RunLoop::RunLoop will fail if the JSC API JSGlobalContextCreate*()
is being called by a client before WTF::initializeMainThread() has been called. The assertion fails because the method
RunLoop::registerRunLoopMessageWindowClass() has not been called yet, since it is only called when initializing the main thread.
This patch addresses this issue by making sure the window class has been registered before being referenced in RunLoop::RunLoopl
The method call is also removed from the main thread initialization, since the window class is only used in RunLoop::RunLoop,
making it sufficient to only be registered there. Also change the debug assert to a release assert, so we can catch similar
issues in release builds.

• wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

• wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::registerRunLoopMessageWindowClass):
(WTF::RunLoop::RunLoop):

2:43 PM Changeset in webkit [266144] by Peng Liu

• 2 edits in trunk/Source/WebCore

When using airplay with Youtube, the Youtube tab becomes completely empty and is unresponsive for an extended period of time if we switch the tab
​https://bugs.webkit.org/show_bug.cgi?id=215821

Reviewed by Eric Carlson.

We should ignore the request to paint the current video frame when we are using airplay.
It is not necessary to do so, and -[AVAssetImageGenerator copyCGImageAtTime:actualTime:error:]
will block the web process for a long time if the video is airplaying.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):

2:34 PM Changeset in webkit [266143] by Megan Gardner

• 4 edits in trunk/Source

Trying to lookup when WebView is in a popover causes process to hang. Fix for Legacy WebView.
​https://bugs.webkit.org/show_bug.cgi?id=215792

Reviewed by Tim Horton.

Source/WebKit:

Update code based on Darin's suggestion for mirror fix in legacy webkit.

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

Source/WebKitLegacy/mac:

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=214773 also needed in legacy WebView.
The Lookup framework does not populate the menus that it vends with the option to 'lookup'
words that are selected in popovers. WebKit should follow the pattern and not put the
item in the menu as Lookup is not able to handle this situation. Also if Lookup is disabled
via defaults, we should not show it in the menu.

• WebView/WebHTMLView.mm:

(customMenuFromDefaultItems):

2:22 PM Changeset in webkit [266142] by rniwa@webkit.org

• 8 edits in trunk

Resolve with the class used to define the Custom Element
​https://bugs.webkit.org/show_bug.cgi?id=215562

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync'ed the test with that in ​https://github.com/web-platform-tests/wpt/pull/25033.

• web-platform-tests/custom-elements/CustomElementRegistry-expected.txt:
• web-platform-tests/custom-elements/CustomElementRegistry.html:

Source/WebCore:

Implemented the new behavior to resolve customElements.whenDefined(~)
with the custom element's constructor when it's defined.

Test: imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):
(WebCore::whenDefinedPromise):

• bindings/js/JSDOMPromiseDeferred.h:

(WebCore::DeferredPromise::resolveWithJSValue): Added.

• dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::addElementDefinition): Made this return DeferredPromise.

• dom/CustomElementRegistry.h:

1:20 PM Changeset in webkit [266141] by clopez@igalia.com

• 4 edits in trunk

[WPE][Qt] Fix qt-wpe-minibrowser on Debian10
​https://bugs.webkit.org/show_bug.cgi?id=215730

Reviewed by Philippe Normand.

Source/WebKit:

QWheelEvent position is not available on Qt < 5.14. Use posF instead in that case.
Tested with Qt 5.11

No new tests, is a build fix.

• UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:

(WPEQtViewBackend::dispatchWheelEvent):

Tools:

When not running in flatpak the path to the qml directory is different.

• Scripts/run-qt-wpe-minibrowser:

12:09 PM Changeset in webkit [266140] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Fix read-after-free introduced in r266087
​https://bugs.webkit.org/show_bug.cgi?id=215671

• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::packageFormData):
Keep the CString in scope while we are using it.

12:04 PM Changeset in webkit [266139] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Mojave wk1 ] fast/layers/hidpi-transform-on-child-content-is-mispositioned.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215819

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

11:49 AM Changeset in webkit [266138] by Devin Rousso

• 3 edits
  3 adds in trunk

Web Inspector: breakpoint condition should be evaluated before the ignore count
​https://bugs.webkit.org/show_bug.cgi?id=215364
<rdar://problem/67310703>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Previously, when pausing, JSC::Breakpoint would check that it's ignoreCount before it
would even attempt to evaluate it's condition. This meant that a JSC::Breakpoint with
a condition of foo === 42 and an ignoreCount of 3 would ignore the first three
pauses and then only pause if foo === 42. This is likely contrary to the expectation of
most users (especially since the condition input is before the ignoreCount input in
the Web Inspector frontend UI) in that they would probably expect to ignore the first
three pauses if foo === 42.

• debugger/Breakpoint.cpp:

(JSC::Breakpoint::shouldPause):

LayoutTests:

• inspector/debugger/resources/condition-ignoreCount.js: Added.

(trigger): Added.

• inspector/debugger/setBreakpoint-condition-ignoreCount.html: Added.
• inspector/debugger/setBreakpoint-condition-ignoreCount-expected.txt: Added.

11:47 AM Changeset in webkit [266137] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Release ] webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb32f-rgb-float.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215817

Unreviewed test gardening.

• platform/mac/TestExpectations:

11:46 AM Changeset in webkit [266136] by Andres Gonzalez

• 6 edits in trunk/Source/WebCore

Crash in WebCore::AccessibilityRenderObject::textUnderElement in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=215790

Reviewed by Darin Adler.

This crash is happening in isolated tree mode because AXIsolatedObject::initializeAttributeData
is caching all properties of the object on a checked state changed notification.
In some cases like the web page in the bug report, not all properties
can be computed in the notification handler. In particular AccessibilityRenderObject::textUnderElement
does the following checks:

Renders referenced by accessibility objects could get destroyed, if TextIterator ends up triggering
style update/layout here. See also AXObjectCache::deferTextChangedIfNeeded().
ASSERT_WITH_SECURITY_IMPLICATION(!nodeDocument->childNeedsStyleRecalc());
ASSERT_WITH_SECURITY_IMPLICATION(!nodeDocument->view()->layoutContext().isInRenderTreeLayout());

This patch addresses this problem by only updating the checked state
property of the isolated object, instead of all properties, in the
checked state change notification.
This is also a performance enhancement since only the property that
changed is re-calculated. The same approach will be used for other properties.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::updateIsolatedTree): Checked state changed notifications
trigger an update of the corresponding isolated object's chekced state
instead of the creation of a new object and re-calculation of all cached properties.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::setProperty): Removed ASSERT since it is now
called in applyPendingChanges on the secondary thread.

• accessibility/isolatedtree/AXIsolatedObject.h: Moved the AXPropertyName

enumeration, the AttributeValueVariant and attribute map declarations
out of this header into AXIsolatedTree.h in order to be able to use them
in both classes.

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::updateNode): Removed unnecessary scope operator.
(WebCore::AXIsolatedTree::updateNodeCheckedState): Added.
(WebCore::AXIsolatedTree::applyPendingChanges): Added updating the pending
properties on the secondary thread.

• accessibility/isolatedtree/AXIsolatedTree.h: Moved to this header the declarations

that are now shared by AXIsolatedObject and AXIsolatedTree.

11:37 AM Changeset in webkit [266135] by Devin Rousso

• 2 edits in trunk/Tools

REGRESSION(r265601): invalid blame URL copied when include_revision is false
​https://bugs.webkit.org/show_bug.cgi?id=215796

Reviewed by Daniel Bates.

• CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py:

(CopyWebKitPermalinkCommand.permalink_for_path):
Always add ? to the URL before the revision and/or blame and have each have their own &.

11:07 AM Changeset in webkit [266134] by jer.noble@apple.com

• 4 edits
  1 add in trunk

[Mac] REGRESSION(r262322): Focusable elements are focused when exiting from video fullscreen mode.
​https://bugs.webkit.org/show_bug.cgi?id=215660
<rdar://problem/65263150>

Reviewed by Darin Adler.

Source/WebKit:

API Test: Fullscreen.Focus.

The default behavior of NSWindow is to change its -keyViewSelectionDirection to NSSelectingNext when activating
and changing the firstResponder. This causes WKWebView to change it's focus in response to becoming first responder.
The cheap fix is to ensure WKWebView is already the firstResponder when the window is activated. Then NSWindow won't
try to change the firstResponder in response to activation.

• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/FullscreenFocus.mm: Added.

(-[FullscreenFocusUIDelegate _webViewDidEnterFullscreen:]):
(-[FullscreenFocusUIDelegate _webViewDidExitFullscreen:]):
(TestWebKitAPI::TEST):

11:06 AM Changeset in webkit [266133] by commit-queue@webkit.org

• 10 edits in trunk/Source

Clean up deprecated and unused SPI to set HSTS storage on ProcessPoolConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=215788

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-25
Reviewed by Chris Dumez.

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

After rdar://problem/65047971 this is no longer needed because the replacement on WebsiteDataStoreConfiguration has been adopted.
The selector on _WKProcessPoolConfiguration had already been deprecated, and is left for now to allow easier debugging with OSes that use it still.

• NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

• UIProcess/API/APIProcessPoolConfiguration.h:
• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration setHSTSStorageDirectory:]):
(-[_WKProcessPoolConfiguration hstsStorageDirectory]):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

10:45 AM Changeset in webkit [266132] by Alan Coon

• 2 edits in branches/safari-610.2.2-branch/Source/WebKit

Cherry-pick r266099. rdar://problem/67742560

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar
<rdar://problem/67473335> and ​https://bugs.webkit.org/show_bug.cgi?id=215787

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called, instead of when deciding to dispatch to the main thread. (WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread. (WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when (WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is safe to do after destroy(), up until the very end when we get into pluginView() derefencing. So it seems prudent to add another check here. (WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument, so for added coverage it seems like a prudent place to add the check.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:45 AM Changeset in webkit [266131] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.2.2-branch

Cherry-pick r265881. rdar://problem/67742375

REGRESSION(r265092): delegatesFocus causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

• page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:41 AM Changeset in webkit [266130] by Alan Coon

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.2.1

10:36 AM Changeset in webkit [266129] by youenn@apple.com

• 48 edits
  15 deletes in trunk

Refresh ReadableStream.pipeTo implementation up to spec
​https://bugs.webkit.org/show_bug.cgi?id=215415

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/response/response-stream-disturbed-by-pipe.any-expected.txt:
• web-platform-tests/fetch/api/response/response-stream-disturbed-by-pipe.any.worker-expected.txt:
• web-platform-tests/streams/idlharness.any-expected.txt:
• web-platform-tests/streams/idlharness.any.worker-expected.txt:
• web-platform-tests/streams/piping/abort.any-expected.txt:
• web-platform-tests/streams/piping/abort.any.worker-expected.txt:
• web-platform-tests/streams/piping/close-propagation-backward-expected.txt: Removed.
• web-platform-tests/streams/piping/close-propagation-backward.any-expected.txt:
• web-platform-tests/streams/piping/close-propagation-backward.any.worker-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward-expected.txt: Removed.
• web-platform-tests/streams/piping/close-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/error-propagation-backward-expected.txt: Removed.
• web-platform-tests/streams/piping/error-propagation-backward.any-expected.txt:
• web-platform-tests/streams/piping/error-propagation-backward.any.worker-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward-expected.txt: Removed.
• web-platform-tests/streams/piping/error-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/flow-control-expected.txt: Removed.
• web-platform-tests/streams/piping/flow-control.any-expected.txt:
• web-platform-tests/streams/piping/flow-control.any.worker-expected.txt:
• web-platform-tests/streams/piping/general-expected.txt: Removed.
• web-platform-tests/streams/piping/general.any-expected.txt:
• web-platform-tests/streams/piping/general.any.worker-expected.txt:
• web-platform-tests/streams/piping/multiple-propagation-expected.txt: Removed.
• web-platform-tests/streams/piping/multiple-propagation.any-expected.txt:
• web-platform-tests/streams/piping/multiple-propagation.any.worker-expected.txt:
• web-platform-tests/streams/piping/pipe-through-expected.txt: Removed.
• web-platform-tests/streams/piping/pipe-through.any-expected.txt:
• web-platform-tests/streams/piping/pipe-through.any.worker-expected.txt:
• web-platform-tests/streams/piping/then-interception.any-expected.txt:
• web-platform-tests/streams/piping/then-interception.any.worker-expected.txt:
• web-platform-tests/streams/piping/throwing-options.any-expected.txt:
• web-platform-tests/streams/piping/throwing-options.any.worker-expected.txt:
• web-platform-tests/streams/piping/transform-streams-expected.txt: Removed.
• web-platform-tests/streams/readable-streams/patched-global.any-expected.txt:
• web-platform-tests/streams/readable-streams/patched-global.any.worker-expected.txt:
• web-platform-tests/streams/readable-streams/reentrant-strategies.any-expected.txt:
• web-platform-tests/streams/readable-streams/reentrant-strategies.any.worker-expected.txt:

Source/WebCore:

Update pipeTo implementation as per specification.
Keep the old implementation if WritableStream is not enabled.

Covered by existing tests.

• Modules/streams/ReadableStream.js:

(pipeThrough):

• Modules/streams/ReadableStreamInternals.js:

(acquireReadableStreamDefaultReader):
(readableStreamPipeToWritableStream):
(pipeToLoop):
(pipeToErrorsMustBePropagatedForward):
(pipeToErrorsMustBePropagatedBackward):
(pipeToClosingMustBePropagatedForward):
(pipeToClosingMustBePropagatedBackward):
(pipeToShutdownWithAction):
(pipeToShutdown):

• Modules/streams/WritableStream.js:

(initializeWritableStream):

• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::isWritableStreamAPIEnabled):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

• bindings/js/WebCoreBuiltinNames.h:
• dom/AbortSignal.idl:

Tools:

Put console log in stderr as this makes some tests flaky otherwise.

• DumpRenderTree/TestOptions.cpp:

(shouldDumpJSConsoleLogInStdErr):

• WebKitTestRunner/TestOptions.cpp:

(WTR::shouldDumpJSConsoleLogInStdErr):

LayoutTests:

Re-enable piping tests.
Remove obsolete tests.

• TestExpectations:
• streams/readable-stream-pipeThrough-expected.txt:
• streams/readable-stream-pipeThrough.html:

Update according new API.

• streams/reference-implementation/pipe-to-expected.txt: Removed.
• streams/reference-implementation/pipe-to.html: Removed.
• streams/reference-implementation/pipe-through-expected.txt: Removed.
• streams/reference-implementation/pipe-through.html: Removed.
• streams/reference-implementation/pipe-to-options-expected.txt: Removed.
• streams/reference-implementation/pipe-to-options.html: Removed.
• streams/reference-implementation/readable-stream-templated-expected:

9:59 AM Changeset in webkit [266128] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Debug ] inspector/console/queryInstances.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215814

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:44 AM Changeset in webkit [266127] by commit-queue@webkit.org

• 4 edits in trunk

Add setting for lazy iframe loading
​https://bugs.webkit.org/show_bug.cgi?id=215566

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-25
Reviewed by Youenn Fablet.

Source/WebCore:

Add setting for lazy iframe loading, disabling it until
this feature is implemented.

• page/Settings.yaml:

LayoutTests:

Enable the lazy iframe loading setting in testharnessreport.js for the iframe lazy
loading WPT tests in html/semantics/embedded-content/the-iframe-element.

• resources/testharnessreport.js:

9:43 AM Changeset in webkit [266126] by Hector Lopez

• 2 edits in trunk/LayoutTests

macOS Debug ] webaudio/webaudio-gc.html is a flaky crash.

<rdar://problem/65571152>

Unreviewed test gardening.

• platform/mac/TestExpectations: correction

9:39 AM Changeset in webkit [266125] by Alan Bujtas

• 8 edits in trunk/Source/WebCore

[LFC][IFC] The initial alignment baseline is always set by the strut
​https://bugs.webkit.org/show_bug.cgi?id=214785

Reviewed by Antti Koivisto.

Let's just use the strut ascent as the initial alignment baseline.

• layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::root const):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::constraintsForLine):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::initialLineHeight const):
(WebCore::Layout::InlineFormattingContext::Quirks::lineHeightConstraints const): Deleted.

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::LineBox):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::root const):

• layout/inlineformatting/InlineLineBuilder.h:

9:36 AM Changeset in webkit [266124] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] http/tests/websocket/construct-in-detached-frame.html is a flaky crash
<rdar://problem/61278051>

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations: corrected to skip

9:32 AM Changeset in webkit [266123] by Darin Adler

• 12 edits in trunk

REGRESSION (r266028): platform/ios/ios/fast/coordinates/range-client-rects.html
​https://bugs.webkit.org/show_bug.cgi?id=215772

Reviewed by Anders Carlsson.

Source/WebCore:

• dom/Range.cpp:

(WebCore::Range::getClientRects const): Call updateLayout since it's not safe
to start working with the render tree without updating it first. Not required
to fix this bug, but an obvious omission. Ideally should make a test to show
this is needed.
(WebCore::Range::getBoundingClientRect const): Ditto.

• dom/SimpleRange.cpp:

(WebCore::order): Added.
(WebCore::documentOrder): Removed bogus special case. Test case proving this is
wrong is coming in the next documentOrder-related patch. Not needed to fix this
bug, but seems dangerous to leave this in the tree the way it was.
(WebCore::firstIntersectingNodeWithDeprecatedZeroOffsetStartQuirk): Added.
(WebCore::IntersectingNodeIterator::IntersectingNodeIterator): Added.

• dom/SimpleRange.h: Added intersectingNodesWithDeprecatedZeroOffsetStartQuirk.

• rendering/RenderObject.cpp:

(WebCore::borderAndTextRects): Use intersectingNodesWithDeprecatedZeroOffsetStartQuirk
because this needs to get the set of nodes in a way that works for our incorrectly
formed selection ranges and includes the first element even when the range technically
starts inside that element. We need to fix those, but that's a big project that affects
a lot of editing code. For now, restoring the old quirk is expedient.
(WebCore::RenderObject::collectSelectionRectsInternal): Ditto.

LayoutTests:

• platform/ios-wk2/TestExpectations: Removed failure expectation.

• platform/ios/ios/fast/coordinates/element-client-rects-expected.txt:
• platform/ios/ios/fast/coordinates/element-client-rects.html:
• platform/ios/ios/fast/coordinates/range-client-rects-expected.txt:
• platform/ios/ios/fast/coordinates/range-client-rects.html:

Changed tests so it's easier to read their results by putting rectangles and
rectangle lists into strings instead of comparing one value per line.

• platform/ios/ios/fast/coordinates/resources/helpers.js:

(rectString): Added.
(rectStrings): Added.
(setExpectedClientRectValues): Deleted.
(verifyClientRect): Deleted.

9:30 AM Changeset in webkit [266122] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] http/tests/websocket/construct-in-detached-frame.html is a flaky crash
<rdar://problem/61278051>

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

9:15 AM Changeset in webkit [266121] by eric.carlson@apple.com

• 17 edits in trunk

[macOS] Update audio arbitration manager when audio transport changes
​https://bugs.webkit.org/show_bug.cgi?id=215781
<rdar://problem/65920613>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated AudioRoutingArbitration API test.

• platform/audio/AudioSession.cpp:

(WebCore::AudioSession::audioOutputDeviceChanged): Add empty method.
(WebCore::setIsPlayingToBluetoothOverride): Ditto.

• platform/audio/AudioSession.h:

• platform/audio/cocoa/MediaSessionManagerCocoa.h:
• platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::audioOutputDeviceChanged): Call AudioSession::audioOutputDeviceChanged.

• platform/audio/mac/AudioSessionMac.mm:

(WebCore::defaultDeviceTransportIsBluetooth): New.
(WebCore::AudioSession::audioOutputDeviceChanged): Clear m_private->playingToBluetooth
if bluetooth transport has changed since the last arbitration update.
(WebCore::AudioSession::setIsPlayingToBluetoothOverride): Allow override of bluetooth
transport for testing.
(WebCore::AudioSession::setCategory): Update routing arbitration if audio session category
or bluetooth transport changes.

• testing/Internals.cpp:

(WebCore::Internals::setIsPlayingToBluetoothOverride):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
• UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _audioRoutingArbitrationUpdateTime]):

• UIProcess/Media/AudioSessionRoutingArbitratorProxy.h:

(WebKit::AudioSessionRoutingArbitratorProxy::arbitrationUpdateTime const):

• UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm:

(WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm:

(AudioRoutingArbitration::statusShouldBecomeEqualTo): Add message string to help
debugging when the test fails.

• TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:

9:08 AM Changeset in webkit [266120] by youenn@apple.com

• 4 edits
  7 adds in trunk

Generated bindings for derived dictionaries are not regenerated when the base dictionary changes
​https://bugs.webkit.org/show_bug.cgi?id=181714

Reviewed by Darin Adler.

Source/WebCore:

Add dictionary file dependencies to SupplementalDependencies.dep.
We add the base dictionary IDL file as a dependency to the JS cpp file of the derived dictionary.
We do so if we detect that a dictionary is deriving from another and both dictionaries are in their own IDL file.

Covered by updated binding tests.

• bindings/scripts/preprocess-idls.pl:

(updateDictionaryDependencies):

• bindings/scripts/test/SupplementalDependencies.dep: Added.
• bindings/scripts/test/TestDerivedDictionary2.idl: Added.
• bindings/scripts/test/TestInheritedDictionary2.idl: Added.
• bindings/scripts/test/JS/JSTestDerivedDictionary2.cpp: Added.

(WebCore::convertDictionary<TestDerivedDictionary2>):
(WebCore::convertDictionaryToJS):
(WebCore::convertDictionary<TestDerivedDictionary2::Dictionary>):

• bindings/scripts/test/JS/JSTestDerivedDictionary2.h: Added.
• bindings/scripts/test/JS/JSTestInheritedDictionary2.cpp: Added.

(WebCore::convertDictionary<TestInheritedDictionary2>):
(WebCore::convertDictionaryToJS):

• bindings/scripts/test/JS/JSTestInheritedDictionary2.h: Added.

Tools:

Add regression testing coverage for the generation of the makefile dependency file.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):
(BindingsTests):
(BindingsTests.detect_file_changes):
(BindingsTests.main):

9:06 AM Changeset in webkit [266119] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Debug ] webaudio/webaudio-gc.html is a flaky crash.
<rdar://problem/65571152>

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:03 AM Changeset in webkit [266118] by mmaxfield@apple.com

• 5 edits
  6 adds in trunk

Fonts lie about being monospaced
​https://bugs.webkit.org/show_bug.cgi?id=162546
<rdar://problem/28494654>

Reviewed by Darin Adler.

Source/WebCore:

When a font reports itself to be monospace, we use this as a
signal that we can perform width computations by assuming all
characters have the same width as the space character. However,
some fonts erroneously claim to be monospaced. We can't know
this ahead of time without measuring a bunch of characters at
font load time, which would be too slow, so even though the
optimization would be nice there is no practical way to do it
correctly. Firefox and Chrome both do not use this signal, so
therefore they both correctly render these fonts. We should
ignore this bit in the font as well. Also, CJK fonts generally
do not have this bit set (because they usually have at least
one character which is not fullwidth) so this isn't a concern
there.

Our Page Load Test shows this is not a performance regression.

Tests: fast/text/font-erroneous-monospace.html

fast/text/font-monospaced-lie.html

• rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache const):

LayoutTests:

Add two tests for fonts which claim to be monospaced but actually aren't.

• fast/text/font-erroneous-monospace-expected.html: Added.
• fast/text/font-erroneous-monospace.html: Added.
• fast/text/font-monospaced-lie-expected.txt: Added.
• fast/text/font-monospaced-lie.html: Added.
• fast/text/line-break-after-question-mark-expected.txt:
• fast/text/line-break-after-question-mark.html:
• fast/text/resources/Ahem-fixed-pitch.ttf: Added.
• fast/text/resources/AhemErroneousMonospace.ttf: Added.

8:58 AM Changeset in webkit [266117] by Alexey Shvayka

• 8 edits in trunk

Invalid early error for object literal method named "proto"
​https://bugs.webkit.org/show_bug.cgi?id=215760

Reviewed by Ross Kirsling.

JSTests:

• test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

According to Annex B [1], { __proto__: null, __proto__() {} } is a valid object literal as the second
__proto__ wasn't obtained from PropertyDefinition : PropertyName : AssignmentExpression production.
Currently, JSC throws an early SyntaxError, unlike V8 and SpiderMonkey.

Since a method needs super binding, the most straightforward fix would be adding SuperBinding field
to SyntaxChecker::Property and exposing it via an accessor. However, given that Property is a very
common structure, this approach would noticeably increase memory pressure during parsing.

Instead, this patch reworks SyntaxChecker::Property to accept isUnderscoreProtoSetter parameter,
removing optional name field, its accessor, and shouldCheckPropertyForUnderscoreProtoDuplicate(),
which reduces sizeof(SyntaxChecker::Property) by a factor of 8: from 16 to 2 bytes.
Also, this change avoids two extra makeNumericIdentifier() calls, speeding up numeric keys parsing.

This approach is feasible because "proto" is the only identifier-based early error for object
literals [2], with no such errors being added in upcoming stage 2-4 proposals.

Additionally, this patch removes strict / complete bool parameter from {parse,create}Property()
signatures as a) it was always true, b) is now unused, and c) strict mode can be checked via scope.

[1]: ​https://tc39.es/ecma262/#sec-__proto__-property-names-in-object-initializers
[2]: ​https://tc39.es/ecma262/#sec-object-initializer-static-semantics-early-errors

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::isUnderscoreProtoSetter const):
(JSC::ASTBuilder::getName const): Deleted.

• parser/Nodes.h:
• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseGetterSetter):
(JSC::Parser<LexerType>::parseObjectLiteral):
(JSC::Parser<LexerType>::shouldCheckPropertyForUnderscoreProtoDuplicate): Deleted.

• parser/Parser.h:
• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::SyntaxChecker):
(JSC::SyntaxChecker::Property::Property):
(JSC::SyntaxChecker::Property::operator!):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::operatorStackPop):

8:48 AM Changeset in webkit [266116] by youenn@apple.com

• 28 edits
  5 adds in trunk

Add support for MediaRecorder bitrate options
​https://bugs.webkit.org/show_bug.cgi?id=214973

Reviewed by Eric Carlson.

Source/WebCore:

Pipe options to MediaRecorderPrivate constructor.
For the actual implementation, pass it down to VideoSampleBufferCompressor and AudioSampleBufferCompressor.
For AudioSampleBufferCompressor, we do not handle well some bit rates, so for now, we limit to specific values.

Tests: http/wpt/mediarecorder/MediaRecorder-audio-bitrate.html

http/wpt/mediarecorder/MediaRecorder-video-bitrate.html

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::create):
(WebCore::MediaRecorder::createMediaRecorderPrivate):
(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::startRecording):

• Modules/mediarecorder/MediaRecorder.h:
• Modules/mediarecorder/MediaRecorderProvider.cpp:

(WebCore::MediaRecorderProvider::createMediaRecorderPrivate):

• Modules/mediarecorder/MediaRecorderProvider.h:
• WebCore.xcodeproj/project.pbxproj:
• loader/EmptyClients.cpp:
• platform/mediarecorder/MediaRecorderPrivate.h:
• platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

(WebCore::MediaRecorderPrivateAVFImpl::create):

• platform/mediarecorder/MediaRecorderPrivateAVFImpl.h:
• platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
• platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:

(WebCore::AudioSampleBufferCompressor::setBitsPerSecond):
(WebCore::AudioSampleBufferCompressor::outputBitRate const):
(WebCore::AudioSampleBufferCompressor::initAudioConverterForSourceFormatDescription):
Do not exit when not able to set bitrate as we still want to set m_maxOutputPacketSize.
In case of error in setting up the converter, clean it up so that we do not use a partially set up converter.

• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::setOptions):

• platform/mediarecorder/cocoa/VideoSampleBufferCompressor.h:
• platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:

(WebCore::VideoSampleBufferCompressor::setBitsPerSecond):
(WebCore::setCompressionSessionProperty):
(WebCore::VideoSampleBufferCompressor::initCompressionSession):

• testing/Internals.cpp:

(WebCore::createRecorderMockSource):

Source/WebKit:

Serialize options when creating remote media recorder.

• GPUProcess/webrtc/RemoteMediaRecorder.cpp:

(WebKit::RemoteMediaRecorder::create):

• GPUProcess/webrtc/RemoteMediaRecorder.h:
• GPUProcess/webrtc/RemoteMediaRecorderManager.cpp:

(WebKit::RemoteMediaRecorderManager::createRecorder):

• GPUProcess/webrtc/RemoteMediaRecorderManager.h:
• GPUProcess/webrtc/RemoteMediaRecorderManager.messages.in:
• WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:

(WebKit::MediaRecorderPrivate::MediaRecorderPrivate):
(WebKit::MediaRecorderPrivate::startRecording):

• WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
• WebProcess/GPU/webrtc/MediaRecorderProvider.cpp:

(WebKit::MediaRecorderProvider::createMediaRecorderPrivate):

• WebProcess/GPU/webrtc/MediaRecorderProvider.h:

LayoutTests:

• http/wpt/mediarecorder/MediaRecorder-audio-bitrate-expected.txt: Added.
• http/wpt/mediarecorder/MediaRecorder-audio-bitrate.html: Added.
• http/wpt/mediarecorder/MediaRecorder-video-bitrate-expected.txt: Added.
• http/wpt/mediarecorder/MediaRecorder-video-bitrate.html: Added.

8:46 AM Changeset in webkit [266115] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] media/W3C/video/events/event_order_canplay_canplaythrough.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215809

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

8:29 AM Changeset in webkit [266114] by commit-queue@webkit.org

• 25 edits in trunk/Source/WebCore

Use more enum classes in DateComponents
​https://bugs.webkit.org/show_bug.cgi?id=215544

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-25
Reviewed by Sam Weinig.

Make Type and SecondFormat enum classes since this is more readable
and allows us to have less includes in header files.

• html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::serializeWithComponents const):

• html/DateInputType.cpp:

(WebCore::DateInputType::dateType const):

• html/DateInputType.h:
• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::dateType const):

• html/DateTimeLocalInputType.h:
• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::dateType const):

• html/HTMLInputElement.h:
• html/InputType.cpp:

(WebCore::InputType::dateType const):

• html/InputType.h:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::dateType const):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::dateType const):

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::dateType const):

• html/WeekInputType.h:
• platform/DateComponents.cpp:

(WebCore::DateComponents::parseMonth):
(WebCore::DateComponents::parseDate):
(WebCore::DateComponents::parseWeek):
(WebCore::DateComponents::parseTime):
(WebCore::DateComponents::parseDateTimeLocal):
(WebCore::DateComponents::setMillisecondsSinceEpochForDate):
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal):
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth):
(WebCore::DateComponents::setMillisecondsSinceMidnight):
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
(WebCore::DateComponents::millisecondsSinceEpochForTime const):
(WebCore::DateComponents::millisecondsSinceEpoch const):
(WebCore::DateComponents::monthsSinceEpoch const):
(WebCore::DateComponents::toStringForTime const):
(WebCore::DateComponents::toString const):

• platform/DateComponents.h:

(WebCore::DateComponents::DateComponents):
(WebCore::DateComponents::type const):

• platform/text/PlatformLocale.cpp:

(WebCore::Locale::formatDateTime):

• platform/text/PlatformLocale.h:
• platform/text/cocoa/LocaleCocoa.mm:

(WebCore::LocaleCocoa::formatDateTime):

• platform/text/ios/LocalizedDateCache.h:
• platform/text/ios/LocalizedDateCache.mm:

(WebCore::LocalizedDateCache::formatterForDateType):
(WebCore::LocalizedDateCache::maximumWidthForDateType):
(WebCore::LocalizedDateCache::createFormatterForType):
(WebCore::LocalizedDateCache::calculateMaximumWidth):

8:29 AM Changeset in webkit [266113] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] media/controls/forced-tracks-only.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215808

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

8:07 AM Changeset in webkit [266112] by commit-queue@webkit.org

• 8 edits in trunk/Source

[SOUP] Initialize HSTS storage directory from network session initialization
​https://bugs.webkit.org/show_bug.cgi?id=215802

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-08-25
Reviewed by Alex Christensen.

Source/WebCore:

Stop handling HSTS persistent storage as a global setting. SoupNetworkSession::setHSTSPersistentStorage() is no
longer static and it does what setupHSTSEnforcer() did but simplified. The session is now always created with a
memory enforcer that is only replaced by a persistent one when setHSTSPersistentStorage() is called on
non-ephemeral sessions.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setHSTSPersistentStorage):
(WebCore::SoupNetworkSession::getHostNamesWithHSTSCache):
(WebCore::SoupNetworkSession::deleteHSTSCacheForHostNames):
(WebCore::SoupNetworkSession::clearHSTSCache):
(WebCore::hstsStorageDirectory): Deleted.
(WebCore::SoupNetworkSession::setupHSTSEnforcer): Deleted.

• platform/network/soup/SoupNetworkSession.h:

Source/WebKit:

Instead of network process initialization, since it's not actually a global setting.

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Remove code to initialize HSTS storage.

• NetworkProcess/soup/NetworkSessionSoup.cpp:

(WebKit::NetworkSessionSoup::NetworkSessionSoup): Call SoupNetworkSession::setHSTSPersistentStorage() if the
path is not mpety.

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextConstructed): Remove the ode to set the HSTS storage directory as process pool configuration.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess): Initialize hstsStorageDirectory in default network session parameters.

7:35 AM Changeset in webkit [266111] by Philippe Normand

• 2 edits in trunk/Source/WebCore

Unreviewed, follow-up to r266109

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcAllocateBuffersAndRenderAudio): The element clock can be null so we need
to check it before attempting to use it.

1:46 AM Changeset in webkit [266110] by Paulo Matos

• 3 edits in trunk/JSTests

Skip failing tests on MIPS for later investigation

Unreviewed Gardening.

• stress/intl-segmenter.js:
• stress/typedarray-functions-with-neutered.js:

1:13 AM Changeset in webkit [266109] by Philippe Normand

• 4 edits in trunk/Source/WebCore

[GStreamer][WebAudio] Fill in output timestamps
​https://bugs.webkit.org/show_bug.cgi?id=215703

Reviewed by Xabier Rodriguez-Calvar.

Set the output timestamp as the buffer PTS. The monotonic timestamp is retrieved using the
corresponding GLib API, offset'ed by the pipeline clock time (which always starts at 0).

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcAllocateBuffersAndRenderAudio):

• platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF::refGPtr<GstClock>):
(WTF::derefGPtr<GstClock>):

• platform/graphics/gstreamer/GRefPtrGStreamer.h:

1:11 AM Changeset in webkit [266108] by Diego Pino Garcia

• 3 edits
  1 copy
  5 deletes in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Updated hybi baselines after r266057.

• platform/glib/http/tests/websocket/tests/hybi/close-and-server-script-exception-expected.txt: Renamed from LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-expected.txt.
• platform/glib/http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/extensions-expected.txt:
• platform/gtk/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Removed.
• platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Removed.
• platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Removed.
• platform/gtk/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-unload-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Removed.

1:06 AM Changeset in webkit [266107] by ysuzuki@apple.com

• 13 edits
  1 add in trunk/Source/JavaScriptCore

[JSC] Add concurrency-aware version of isCallable / isConstructor to make it usable in DFG compiler
​https://bugs.webkit.org/show_bug.cgi?id=215746

Reviewed by Saam Barati.

This patch adds isCallableWithConcurrency and isConstructorWithConcurrency to JSCell, JSValue etc.
This can work even if it is called from concurrent compiler threads. We also add jsTypeStringForValueWithConcurrency
and jsTypeofIsFunctionWithConcurrency which are using the above WithConcurrency functionalities.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• runtime/Concurrency.h: Added.

(WTF::printInternal):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::getCallData):
(JSC::InternalFunction::getConstructData):

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::isCallableWithConcurrency const):
(JSC::JSValue::isConstructorWithConcurrency const):

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::isCallableWithConcurrency):
(JSC::JSCell::isConstructorWithConcurrency):
(JSC::JSCell::isCallable):
(JSC::JSCell::isConstructor):

• runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getConstructData):

• runtime/NumberPrototype.cpp:

(JSC::throwVMToThisNumberError):

• runtime/Operations.cpp:

(JSC::jsTypeStringForValueWithConcurrency):
(JSC::jsTypeStringForValue): Deleted.

• runtime/Operations.h:

(JSC::jsTypeofIsFunctionWithConcurrency):
(JSC::jsTypeStringForValue):
(JSC::jsTypeofIsFunction):

12:45 AM Changeset in webkit [266106] by Alexey Shvayka

• 13 edits
  1 add in trunk

Implementation of the class "extends" clause incorrectly uses proto for setting prototypes
​https://bugs.webkit.org/show_bug.cgi?id=205848

Reviewed by Keith Miller.

JSTests:

• microbenchmarks/class-derived-creation.js: Added.
• test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

To prevent class extends from breaking if Object.prototype.proto is overridden
or removed, this patch replaces OpPutById bytecodes in ClassExprNode::emitBytecode()
with JSObject::setPrototypeDirect() invocations via OpCall.

Since the spec sets Prototype values directly [1], we are safe to skip method
table lookups and cycle checks.

Although this approach adds 4 mov ops to emitted bytecode for class extends creation,
increasing instruction count to 35, I prefer it over introducing a slow path only op.
To avoid emitting 2 extra mov ops, globalFuncSetPrototypeDirect() uses thisRegister().

Aligns JSC with V8 and SpiderMonkey. Derived class creation microbenchmark is neutral.

[1]: ​https://tc39.es/ecma262/#sec-createbuiltinfunction (step 7)

• builtins/BuiltinNames.h:
• bytecode/BytecodeDumper.cpp:

(JSC::CodeBlockBytecodeDumper<Block>::dumpConstants): Fix typo.

• bytecode/LinkTimeConstant.h:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitSetPrototypeOf):

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

• parser/Nodes.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

12:42 AM Changeset in webkit [266105] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK/WPE build after r266103

• inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):

12:01 AM Changeset in webkit [266104] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Reintroduce several WPT css-content failing tests removed in r266094.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations: