Context Navigation

← Previous Period
Next Period →

Timeline

Aug 29, 2020:

6:47 PM Changeset in webkit [266330] by achristensen@apple.com

64 edits
2 adds in trunk

Remove NFC normalization when submitting forms and encoding URL queries and fix EUC-JP encoding
https://bugs.webkit.org/show_bug.cgi?id=215970

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-cseucpkdfmtjapanese-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-x-euc-jp-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-href-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-href-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-href-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-csshiftjis-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-ms932-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-ms_kanji-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-shift-jis-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-sjis-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-windows-31j-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-x-sjis-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-cseuckr-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-csksc56011987-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-iso-ir-149-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-korean-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-ks_c_5601-1987-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-ks_c_5601-1989-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-ksc5601-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-ksc_5601-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-windows-949-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-expected.txt:
web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-big5-hkscs-expected.txt:
web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-cn-big5-expected.txt:
web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-csbig5-expected.txt:
web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-expected.txt:
web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-x-x-big5-expected.txt:
web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-expected.txt:

Source/WebCore:

This fixes 3 things that were common between Chrome and Firefox but different in WebKit.
The first two are omitting NFC normalization when submitting forms and encoding URL queries
in documents with non-UTF-8 encodings. The third is a problem with our use of ICU's EUC-JP encoding,
which uses the euc-jp-2007 table. Chrome and Firefox use a slightly different table from
https://encoding.spec.whatwg.org/index-jis0208.txt which is not in ICU. To be compatible and pass many
web platform tests, I include the table here, which adds about 30kb to WebKit's binary size.
I intend to do the same with Big5, ISO-2022-JP, Shift_JIS, and EUC-KR.

I opened https://github.com/whatwg/encoding/issues/225 to resolve an ambiguity in the standard related to this.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
platform/network/FormData.cpp:

(WebCore::normalizeStringData):

platform/text/EncodingTables.cpp: Added.
platform/text/EncodingTables.h: Added.
platform/text/TextCodecICU.cpp:

(WebCore::eucJPEncode):
(WebCore::uncheckedAppendDecimal):
(WebCore::urlEncodedEntityUnencodableHandler):
(WebCore::entityUnencodableHandler):
(WebCore::questionMarkUnencodableHandler):
(WebCore::Function<void):
(WebCore::TextCodecICU::encode):

platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode const):

platform/text/TextEncoding.h:

LayoutTests:

fast/forms/form-data-encoding-2.html:
fast/forms/form-data-encoding.html:

5:19 PM Changeset in webkit [266329] by aestes@apple.com

2 edits in trunk/Source/WebCore

[Cocoa] MediaSample JSON strings are created for logging to disabled channels
https://bugs.webkit.org/show_bug.cgi?id=215980
<rdar://problem/68004132>

Reviewed by Simon Fraser.

On platforms that USE(OS_LOG), DEBUG_LOG() evaluates its arguments even in production
builds. In SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackID(), one DEBUG_LOG() call
involved creating a non-trivial JSON object describing a MediaSample then converting that to
a JSON string. This string was created even when debug logging was disabled at runtime.
Profiles showed this cost half a millisecond per second of video playback on netflix.com in
Safari on a MacBook Pro.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackID): Rather than calling
MediaSample::toJSONString() directly, let the LogArgument<MediaSample> specialization call
toJSONString() iff the log channel is enabled.

5:05 PM Changeset in webkit [266328] by weinig@apple.com

5 edits in trunk/Source/WebCore

Move PerformanceMonitor related DeprecatedGlobalSettings to Settings
https://bugs.webkit.org/show_bug.cgi?id=215963

Reviewed by Anders Carlsson.

The PerformanceMonitor related uses of DeprecatedGlobalSettings can easily be moved to Settings, as PerformanceMonitor
has a Page reference.

page/DeprecatedGlobalSettings.h:

(WebCore::DeprecatedGlobalSettings::isPostLoadCPUUsageMeasurementEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::isPostBackgroundingCPUUsageMeasurementEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::isPerActivityStateCPUUsageMeasurementEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::isPostLoadMemoryUsageMeasurementEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::isPostBackgroundingMemoryUsageMeasurementEnabled): Deleted.

page/Settings.yaml:
page/SettingsDefaultValues.h:

Moved settings from DeprecatedGlobalSettings.h to Settings.yaml. Default values encoded in SettingsDefaultValues.h

page/PerformanceMonitor.cpp:

(WebCore::PerformanceMonitor::PerformanceMonitor):
(WebCore::PerformanceMonitor::didFinishLoad):
(WebCore::PerformanceMonitor::activityStateChanged):
Access the settings via m_page.settings(). Update constants to use constexpr.

1:44 PM Changeset in webkit [266327] by ysuzuki@apple.com

4 edits
1 add in trunk

[JSC] let [ sequence cannot appear in ExpressionStatement context
https://bugs.webkit.org/show_bug.cgi?id=215977

Reviewed by Ross Kirsling.

JSTests:

stress/let-and-open-bracket.js: Added.

(testSyntax):
(testSyntaxError):

test262/expectations.yaml:

Source/JavaScriptCore:

Because of ambiguity between destructuring assignment and member access (let IDENTIFIER), ECMA262 does not allow let [ sequence in ExpressionStatement context[1].
We should throw SyntaxError when we see something like this.

if (false)

let [ok] = [42];

[1]: https://tc39.es/ecma262/#sec-expression-statement

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseStatement):

12:06 PM Changeset in webkit [266326] by ysuzuki@apple.com

4 edits in trunk

[JSC] for-of uses AssignmentExpression while for-in uses Expression
https://bugs.webkit.org/show_bug.cgi?id=215975

Reviewed by Ross Kirsling.

JSTests:

test262/expectations.yaml:

Source/JavaScriptCore:

While for-in uses Expression, for-of and for-await-of use AssignmentExpression which does not accept comma-expression.
We should align our implementation to that.

for (LeftHandSideExpression in Expression) Statement
for (LeftHandSideExpression of AssignmentExpression) Statement
for await(LeftHandSideExpression of AssignmentExpression) Statement

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseForStatement):

10:19 AM Changeset in webkit [266325] by Lauro Moura

4 edits in trunk/LayoutTests

[GLIB] Rebaseline webaudio tests after k-rate changes in r266319

Unreviewed test gardening.

platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:

1:38 AM Changeset in webkit [266324] by ysuzuki@apple.com

9 edits
1 add in trunk

[JSC] for-of / for-in left-hand-side target should be simple-assignment-target
https://bugs.webkit.org/show_bug.cgi?id=215969

Reviewed by Ross Kirsling.

JSTests:

stress/for-of-in-non-reference.js: Added.

(testSyntax):
(testSyntaxError):
(testSyntaxError.t):
(testSyntaxError.async t):
(testSyntax.async t):

test262/expectations.yaml:

Source/JavaScriptCore:

Left-hand-side of for-in, for-of, and for-await-of should be simple assignment target[1]
if the target is not declaration and not destructuring pattern.

[1]: https://tc39.es/ecma262/#sec-for-in-and-for-of-statements-static-semantics-early-errors

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseForStatement):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createCommaExpr): Should return CommaExpr to align it to ASTBuilder.
(JSC::SyntaxChecker::appendToCommaExpr):
(JSC::SyntaxChecker::appendStatement):
(JSC::SyntaxChecker::combineCommaNodes): Deleted since it is not used.

LayoutTests:

Fix for-in / for-of parser behavior.

js/basic-strict-mode-expected.txt:
js/parser-syntax-check-expected.txt:
js/script-tests/parser-syntax-check.js:

1:32 AM Changeset in webkit [266323] by ysuzuki@apple.com

10 edits
1 add in trunk

[JSC] Implement Intl.DateTimeFormat dayPeriod
https://bugs.webkit.org/show_bug.cgi?id=215839

Reviewed by Ross Kirsling.

JSTests:

stress/intl-datetimeformat-day-period.js: Added.

(shouldBe):
(throw.new.Error):

test262/config.yaml:

Source/JavaScriptCore:

This patch implements Intl.DateTimeFormat dayPeriod option[1]. We can use "narrow", "short", or "long" for dayPeriod,
and it determines how "AM" etc. is represented.

[1]: https://github.com/tc39/ecma402/pull/346

builtins/DatePrototype.js:

(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):

bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

bytecode/BytecodeIntrinsicRegistry.h:
runtime/CommonIdentifiers.h:
runtime/IntlDateTimeFormat.cpp:

(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::setFormatsFromPattern):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::dayPeriodString):
(JSC::IntlDateTimeFormat::resolvedOptions const):

runtime/IntlDateTimeFormat.h:
runtime/OptionsList.h:

12:11 AM Changeset in webkit [266322] by ysuzuki@apple.com

6 edits
1 add in trunk

[JSC] super property with new should be accepted
https://bugs.webkit.org/show_bug.cgi?id=215966

Reviewed by Ross Kirsling.

JSTests:

stress/super-and-new.js: Added.

(testSyntaxError):
(shouldBe):
(test.A):
(test.A.prototype.get hey):
(test.A.prototype.get hey2):
(test.A.prototype.super):
(test.B.get super):

Source/JavaScriptCore:

While we should reject new super / new super(), we should accept new super.property.
https://tc39.es/ecma262/#prod-SuperProperty is a child production of https://tc39.es/ecma262/#prod-MemberExpression,
unlike https://tc39.es/ecma262/#prod-SuperCall. So new should accept SuperProperty (e.g. super.xxx).

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

LayoutTests:

js/class-syntax-super-expected.txt:
js/script-tests/class-syntax-super.js:

Aug 28, 2020:

11:57 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

10:13 PM Changeset in webkit [266321] by Ryan Haddad

24 edits in branches/safari-610.1.28.0-branch/LayoutTests/imported/w3c/web-platform-tests/webaudio

Cherry-pick r266315. rdar://problem/67367072

Rebaseline WebAudio test results
<rdar://problem/67367072>

r265824 changed what error message is. (This is unavoidable since the kind of thrown error is changed (JS side error v.s. JS error thrown from C++), and this needs to be done to fix the reported webpage’s issue).
This error is recorded as expect files in various WebAudio WPT test if the tested WebAudio constructors are not implemented.
After that branch cut, a lot of WebAudio constructors are newly implemented, which removes this error messages from expect files.
r265824 is landed after these WebAudio patches. So it does not include rebaseline for these WebAudio WPT tests (since it is no longer including that error messages).
But in that branch, these WebAudio patches are not cherry-picked. This means that error message is still recorded in WPT expect files.
So, we just need to update these expect files, or cherry-pick these WebAudio patches. And I think updating expect files is the way to go.

git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-610.1.28.1-branch@266315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:30 PM Changeset in webkit [266320] by Lauro Moura

2 edits
4 adds
1 delete in trunk/LayoutTests

[WPE] Gardening and rebaselining

Unreviewed test gardening.

platform/wpe/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:

Added with specific failure due to DRAG_SUPPORT not enabled.

platform/wpe/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw-manual.https-expected.txt: Removed.

7:32 PM Changeset in webkit [266319] by Chris Dumez

26 edits in trunk

Update PannerNode to support k-rate automation of its AudioParams
https://bugs.webkit.org/show_bug.cgi?id=215901

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-equalpower-stereo-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-stereo-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/test-pannernode-automation-expected.txt:

Source/WebCore:

Update PannerNode to support k-rate automation of its AudioParams.

This patch is based on Chromium's implementation and the following
change in particular:

https://chromium-review.googlesource.com/c/chromium/src/+/2096786

No new tests, rebaselined existing tests.

Modules/webaudio/AudioListener.cpp:

(WebCore::AudioListener::AudioListener):
(WebCore::AudioListener::hasSampleAccurateValues const):
(WebCore::AudioListener::shouldUseARate const):
(WebCore::AudioListener::updateValuesIfNeeded):
(WebCore::AudioListener::positionXValues):
(WebCore::AudioListener::positionYValues):
(WebCore::AudioListener::positionZValues):
(WebCore::AudioListener::forwardXValues):
(WebCore::AudioListener::forwardYValues):
(WebCore::AudioListener::forwardZValues):
(WebCore::AudioListener::upXValues):
(WebCore::AudioListener::upYValues):
(WebCore::AudioListener::upZValues):
Add functions to retrieve sample accurate values from the AudioListener's
AudioParams. Those values are cached for performance.

(WebCore::AudioListener::setPosition):
Call AudioParam::setValueAtTime(value, now) instead of
AudioParam::setValue(), as per:

https://www.w3.org/TR/webaudio/#dom-audiolistener-setposition

(WebCore::AudioListener::setOrientation):
Call AudioParam::setValueAtTime(value, now) instead of
AudioParam::setValue(), as per:

https://www.w3.org/TR/webaudio/#dom-audiolistener-setorientation

Modules/webaudio/AudioListener.h:
Modules/webaudio/AudioListener.idl:

Update IDL to indicate that setPosition() / setOrientation() may now
throw exceptions.

Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateFinalValues):
If we're not sample accurate, make sure we duplicate the first element of
|values| to other elements. Some WPT tests kept failing without this change.

Modules/webaudio/AudioParam.h:
Modules/webaudio/AudioParamTimeline.h:

(WebCore::AudioParamTimeline::hasValues const):
Add more constness.

Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::process):
(WebCore::PannerNode::processSampleAccurateValues):
Add support for k-rate automation of PannerNode's AudioParams.

(WebCore::PannerNode::hasSampleAccurateValues const):
(WebCore::PannerNode::shouldUseARate const):
(WebCore::PannerNode::setPanningModel):

(WebCore::PannerNode::setPosition):
Call AudioParam::setValueAtTime(value, now) instead of
AudioParam::setValue(), as per:

https://www.w3.org/TR/webaudio/#dom-pannernode-setposition

(WebCore::PannerNode::setOrientation):
Call AudioParam::setValueAtTime(value, now) instead of
AudioParam::setValue(), as per:

https://www.w3.org/TR/webaudio/#dom-pannernode-setorientation

(WebCore::PannerNode::setDistanceModel):
(WebCore::PannerNode::setRefDistance):
(WebCore::PannerNode::setMaxDistance):
(WebCore::PannerNode::setRolloffFactor):
(WebCore::PannerNode::setConeOuterGain):
(WebCore::PannerNode::setConeOuterAngle):
(WebCore::PannerNode::setConeInnerAngle):
(WebCore::PannerNode::setChannelCount):
(WebCore::PannerNode::setChannelCountMode):
(WebCore::PannerNode::calculateAzimuthElevation):
(WebCore::PannerNode::azimuthElevation):
(WebCore::PannerNode::calculateDistanceConeGain):
(WebCore::PannerNode::distanceConeGain):

Modules/webaudio/PannerNode.h:
Modules/webaudio/PannerNode.idl:
platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::calculateDesiredGain):
(WebCore::EqualPowerPanner::panWithSampleAccurateValues):

platform/audio/EqualPowerPanner.h:
platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::panWithSampleAccurateValues):

platform/audio/HRTFPanner.h:
platform/audio/Panner.h:

LayoutTests:

Unskip a few tests that should no longer be flaky since they are now passing.

TestExpectations:

7:26 PM Changeset in webkit [266318] by ysuzuki@apple.com

6 edits in trunk

[JSC] new import.meta() is acceptable
https://bugs.webkit.org/show_bug.cgi?id=215915

Reviewed by Ross Kirsling.

JSTests:

stress/modules-syntax-error.js:
stress/modules-syntax.js:
test262/expectations.yaml:

Source/JavaScriptCore:

new import.meta() is valid in terms of syntax while it throws runtime error.
We should accept this code, while new import() is not correct syntax.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

6:39 PM Changeset in webkit [266317] by Devin Rousso

40 edits
2 adds in trunk

Web Inspector: Audit: should be able to create/edit imported audits
https://bugs.webkit.org/show_bug.cgi?id=215555
<rdar://problem/67255483>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Extend the existing audit edit mode (which previously only let audits be disabled/deleted)
to also allow other JSON properties of audits to be added/edited/removed, meaning that
audits can now be completely created/configured from within the Web Inspector UI. \(o.o)/

UserInterface/Models/AuditTestBase.js:

(WI.AuditTestBase):
(WI.AuditTestBase.prototype.set name): Added.
(WI.AuditTestBase.prototype.set description): Added.
(WI.AuditTestBase.prototype.get supports): Added.
(WI.AuditTestBase.prototype.set supports): Added.
(WI.AuditTestBase.prototype.get setup): Added.
(WI.AuditTestBase.prototype.set setup): Added.
(WI.AuditTestBase.prototype.set disabled):
(WI.AuditTestBase.prototype.get editable): Added.
(WI.AuditTestBase.prototype.get default): Added.
(WI.AuditTestBase.prototype.markAsDefault): Added.
(WI.AuditTestBase.prototype.get topLevelTest): Added.
(WI.AuditTestBase.prototype.async runSetup): Added.
(WI.AuditTestBase.prototype.async start()):
(WI.AuditTestBase.prototype.stop()):
(WI.AuditTestBase.prototype.async clone): Added.
(WI.AuditTestBase.remove): Added.
(WI.AuditTestBase.saveIdentityToCookie):
(WI.AuditTestBase.toJSON):
(WI.AuditTestBase.prototype.determineIfSupported): Added.
(WI.AuditTestBase.prototype.updateSupported): Added.
(WI.AuditTestBase.prototype.updateResult): Added.
(WI.AuditTestBase.prototype.set supported): Deleted.
(WI.AuditTestBase.async setup): Deleted.
(WI.AuditTestBase.prototype.async setup): Deleted.

UserInterface/Models/AuditTestGroup.js:

(WI.AuditTestGroup):
(WI.AuditTestGroup.prototype.addTest): Added.
(WI.AuditTestGroup.prototype.removeTest): Added.
(WI.AuditTestGroup.prototype.clearResult):
(WI.AuditTestGroup.prototype.async run):
(WI.AuditTestGroup.prototype.determineIfSupported): Added.
(WI.AuditTestGroup.prototype.updateSupported): Added.
(WI.AuditTestGroup.prototype.updateResult): Added.
(WI.AuditTestGroup.prototype._checkDisabled): Added.
(WI.AuditTestGroup.prototype._handleTestCompleted):
(WI.AuditTestGroup.prototype._handleTestDisabledChanged):
(WI.AuditTestGroup.prototype._handleTestSupportedChanged): Added.
(WI.AuditTestGroup.prototype._handleTestChanged): Added.
(WI.AuditTestGroup.prototype.get supported): Deleted.
(WI.AuditTestGroup.prototype.set supported): Deleted.
(WI.AuditTestGroup.prototype.get disabled): Deleted.
(WI.AuditTestGroup.prototype.set disabled): Deleted.
(WI.AuditTestGroup.prototype._updateResult): Deleted.
(WI.AuditTestGroup.prototype._updateResult): Deleted.

UserInterface/Models/AuditTestCase.js:

(WI.AuditTestCase):
(WI.AuditTestCase.stringifyFunction): Added.
(WI.AuditTestCase.prototype.set test): Added.
(WI.AuditTestCase.prototype.async run):
Allow additional JSON keys to be changed in the UI:

name
description
supports (ensure that changes recalculate whether the audit is actually supported)
setup
(groups) tests (via separate add and remove functions)
(test cases) the actual test function

These properties are expected to only change in edit mode.

UserInterface/Models/AuditTestResultBase.js:

(WI.AuditTestResultBase.prototype.get disabled): Added.
(WI.AuditTestResultBase.prototype.get editable): Added.
Audit results are never disabled and not editable.

UserInterface/Controllers/AuditManager.js:

(WI.AuditManager):
(WI.AuditManager.prototype.set editing):
(WI.AuditManager.async start):
(WI.AuditManager.prototype.async start):
(WI.AuditManager.prototype.stop):
(WI.AuditManager.prototype.async processJSON):
(WI.AuditManager.prototype.loadStoredTests):
(WI.AuditManager.prototype.async addTest): Added.
(WI.AuditManager.prototype.removeTest):
(WI.AuditManager.prototype._addDefaultTests):
(WI.AuditManager.prototype._addDefaultTests.removeWhitespace):
(WI.AuditManager.prototype._addTest): Deleted.
(WI.AuditManager.prototype._topLevelTestForTest): Deleted.
Add helper functions and events for when the audit manager running mode changes to update UI.
Also add another default test that demonstrates the supports JSON key.

UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype.showDefaultContentView):
(WI.AuditNavigationSidebarPanel.prototype.willDismissPopover): Added.
(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
(WI.AuditNavigationSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
(WI.AuditNavigationSidebarPanel.prototype._addTest):
(WI.AuditNavigationSidebarPanel.prototype._addResult):
(WI.AuditNavigationSidebarPanel.prototype._updateControlNavigationItems): Added.
(WI.AuditNavigationSidebarPanel.prototype._updateEditNavigationItems): Added.
(WI.AuditNavigationSidebarPanel.prototype._handleAuditManagerEditingChanged):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditManagerRunningStateChanged): Added.
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestAdded):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestCompleted):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestScheduled):
(WI.AuditNavigationSidebarPanel.prototype._treeSelectionDidChange):
(WI.AuditNavigationSidebarPanel.prototype._handleStartStopButtonNavigationItemClicked):
(WI.AuditNavigationSidebarPanel.prototype._handleCreateButtonNavigationItemClicked): Added.
(WI.AuditNavigationSidebarPanel.prototype._updateStartStopButtonNavigationItemState): Deleted.
(WI.AuditNavigationSidebarPanel.prototype._updateEditButtonNavigationItemState): Deleted.

UserInterface/Views/AuditNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.audit .edit-audits:not(.disabled):active): Added.
(.sidebar > .panel.navigation.audit .edit-audits:not(.disabled).activated): Added.
(.sidebar > .panel.navigation.audit .edit-audits:not(.disabled).activated:active): Added.
(.sidebar > .panel.navigation.audit .edit-audits.disabled): Added.
(.content-view.audit .message-text-view .navigation-item-help:is(.start-editing-audits, .stop-editing-audits) .navigation-bar): Added.
(.content-view.tab.audit .content-view > .audit-version): Added.
(.content-view.tab.audit .content-view .reference-page-link-container): Added.
(body[dir=ltr] .content-view.tab.audit .content-view .reference-page-link-container): Added.
(body[dir=rtl] .content-view.tab.audit .content-view .reference-page-link-container): Added.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled):active): Deleted.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled).activated): Deleted.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled).activated:active): Deleted.
(.sidebar > .panel.navigation.audit > .content .edit-audits.disabled): Deleted.
(.finish-editing-audits-placeholder.message-text-view .navigation-item-help .navigation-bar): Deleted.
(.audit-version): Deleted.
Move the "Edit" toggle to be next to the filter bar so that it's always visible. Replace the
"[|>] Start" button with a "[+] Create" button when in edit mode, which adds a new audit at
the top-level.

UserInterface/Views/AuditTestContentView.js:

(WI.AuditTestContentView):
(WI.AuditTestContentView.get navigationItems):
(WI.AuditTestContentView.get supportsSave):
(WI.AuditTestContentView.prototype.createNameElement): Added.
(WI.AuditTestContentView.prototype.createDescriptionElement): Added.
(WI.AuditTestContentView.prototype.createControlsTableElement): Added.
(WI.AuditTestContentView.prototype.layout):
(WI.AuditTestContentView.prototype.shown):
(WI.AuditTestContentView.prototype.hidden):
(WI.AuditTestContentView.prototype.handleResultChanged):
(WI.AuditTestContentView.prototype.showStoppingPlaceholder):
(WI.AuditTestContentView.prototype.showNoResultPlaceholder):
(WI.AuditTestContentView.prototype.showNoResultDataPlaceholder):
(WI.AuditTestContentView.prototype.showFilteredPlaceholder):
(WI.AuditTestContentView.prototype._updateExportNavigationItems): Added.
(WI.AuditTestContentView.prototype._updateSupportsInputState): Added.
(WI.AuditTestContentView.prototype._createSetupEditor): Added.
(WI.AuditTestContentView.prototype._handleEditorKeydown): Added.
(WI.AuditTestContentView.prototype._handleExportTestButtonNavigationItemClicked): Added.
(WI.AuditTestContentView.prototype._handleExportResultButtonNavigationItemClicked): Added.
(WI.AuditTestContentView.prototype._handleTestDisabledChanged): Added.
(WI.AuditTestContentView.prototype._handleTestSupportedChanged): Added.
(WI.AuditTestContentView.prototype._handleEditingChanged): Added.
(WI.AuditTestContentView.prototype._updateExportButtonNavigationItemState): Deleted.
(WI.AuditTestContentView.prototype._handleExportButtonNavigationItemClicked): Deleted.

UserInterface/Views/AuditTestContentView.css:

(.content-view.audit-test:is(.unsupported, .disabled):not(.manager-editing)): Added.
(.content-view.audit-test.manager-editing .editor:not(:empty)): Added.
(.content-view.audit-test.manager-editing :is(.content-view.audit-test, header) .editor:not(:empty)): Added.
(.content-view.audit-test .CodeMirror): Added.
(.content-view.audit-test > header :is(.name, .description):not([contenteditable])): Added.
(.content-view.audit-test.manager-editing > header :is(.name, .description)[contenteditable]): Added.
(.content-view.audit-test.manager-editing > header .name[contenteditable]:empty): Added.
(.content-view.audit-test.manager-editing > header .name[contenteditable]:empty:before): Added.
(.content-view.audit-test.manager-editing > header .description[contenteditable]:empty:before): Added.
(.content-view.audit-test:not(.manager-editing) > header .description:empty): Added.
(.content-view.audit-test:not(.manager-editing) > header .description:empty, .content-view.audit-test:not(.manager-editing) > header table.controls): Added.
(.content-view.audit-test > header table.controls, .content-view.audit-test > header table.controls > tr > td): Added.
(.content-view.audit-test > header table.controls > tr > th): Added.
(.content-view.audit-test > header table.controls > tr.supports input[type="number"]): Added.
(.content-view.audit-test > header table.controls > tr.supports .warning): Added.
(.content-view.audit-test > header table.controls > tr.supports .warning:not(:empty)::before ): Added.
(.content-view.audit-test > header table.controls > tr.setup .editor): Added.
(.content-view.audit-test > section > .message-text-view > :is(progress, .indeterminate-progress-spinner)): Added.
(@media (prefers-color-scheme: dark) .content-view.audit-test > header table.controls > tr > th): Added.
Create helper functions for subclasses that simplify creating the editing UI. When in edit
mode, add contenteditable to the name/description and inputs for supports/setup.

UserInterface/Views/AuditTestGroupContentView.js:

(WI.AuditTestGroupContentView):
(WI.AuditTestGroupContentView.prototype.willDismissPopover): Added.
(WI.AuditTestGroupContentView.prototype.createControlsTableElement): Added.
(WI.AuditTestGroupContentView.prototype.initialLayout):
(WI.AuditTestGroupContentView.prototype.layout):
(WI.AuditTestGroupContentView.prototype.shown):
(WI.AuditTestGroupContentView.prototype.hidden):
(WI.AuditTestGroupContentView.prototype.showRunningPlaceholder):
(WI.AuditTestGroupContentView.prototype._updateClassList): Added.
(WI.AuditTestGroupContentView.prototype._updateLevelScopeBar):
(WI.AuditTestGroupContentView.prototype._addTest): Added.
(WI.AuditTestGroupContentView.prototype._handleTestGroupTestAdded): Added.
(WI.AuditTestGroupContentView.prototype._handleTestGroupTestRemoved): Added.

UserInterface/Views/AuditTestGroupContentView.css:

(.content-view.audit-test-group > section > .audit-test-group > header): Added.
(.content-view.audit-test-group.contains-test-case > header):
(.content-view.audit-test-group > section > .audit-test-group.contains-test-case > header): Added.
(.content-view.audit-test-group.contains-test-case + .audit-test-group.contains-test-case, .content-view.audit-test-group + .content-view.audit-test-case): Added.
(.content-view.audit-test-group.contains-test-case + .audit-test-group.contains-test-case): Deleted.
When in edit mode, add buttons for removing the audit and adding a new sub-audit (using the
new WI.CreateAuditPopover popover).

UserInterface/Views/AuditTestCaseContentView.js:

(WI.AuditTestCaseContentView):
(WI.AuditTestCaseContentView.prototype.initialLayout):
(WI.AuditTestCaseContentView.prototype.layout):
(WI.AuditTestCaseContentView.prototype.showRunningPlaceholder):

UserInterface/Views/AuditTestCaseContentView.css:

(.content-view-container > .content-view.audit-test-case): Added.
(.content-view-container > .content-view.audit-test-case > header):
(.content-view-container > .content-view.audit-test-case.manager-editing > header h1 > img): Added.
(.content-view-container > .content-view.audit-test-case > section > :not(.message-text-view, .editor):first-child): Added.
(.content-view-container > .content-view.audit-test-case > section): Added.
(.content-view-container > .content-view.audit-test-case > section, .content-view-container > .content-view.audit-test-case > section :is(.editor, .CodeMirror)): Added.
(.content-view.audit-test-case.manager-editing.disabled:not(.editable) > header h1 > img): Added.
(.content-view.audit-test-case > section > :not(.message-text-view, .editor)): Added.
(.content-view.audit-test-case > section > :not(.message-text-view, .editor):last-child): Added.
(.content-view.audit-test-case > section > :not(.message-text-view, .editor) + :not(.message-text-view, .editor)): Added.
(@media (prefers-color-scheme: dark) .content-view.audit-test-case.manager-editing > header h1 > img): Added.
(.content-view-container > .content-view.audit-test-case > section > :not(.message-text-view):first-child): Deleted.
(.content-view.audit-test-case > section > :not(.message-text-view)): Deleted.
(.content-view.audit-test-case > section > :not(.message-text-view):last-child): Deleted.
(.content-view.audit-test-case > section > :not(.message-text-view) + :not(.message-text-view)): Deleted.
(.content-view.audit-test-case > section .CodeMirror): Deleted.
When in edit mode, replace the icon with a (X) to remove the audit and show a CodeMirror
instance to allow editing the content.

UserInterface/Views/AuditTreeElement.js:

(WI.AuditTreeElement):
(WI.AuditTreeElement.expandedSettingKey): Added.
(WI.AuditTreeElement.prototype.onattach):
(WI.AuditTreeElement.prototype.ondelete):
(WI.AuditTreeElement.prototype.canSelectOnMouseDown): Added.
(WI.AuditTreeElement.prototype.populateContextMenu):
(WI.AuditTreeElement.prototype._handleTestNameChanged): Added.
(WI.AuditTreeElement.prototype._handleTestSupportedChanged): Added.
(WI.AuditTreeElement.prototype._handleTestGroupTestAdded): Added.

UserInterface/Views/AuditTreeElement.css:

(.tree-outline .item.audit:matches(.test-case, .test-group):not(.unsupported, .manager-active):hover > .status > img): Added.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.audit:matches(.test-case, .test-group):not(.unsupported, .manager-active).selected:hover > .status > img, body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.audit.test-case.selected > .status > .indeterminate-progress-spinner, body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.audit.test-group.selected > .status > progress): Added.
(.tree-outline .item.audit:not(:hover) > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.unsupported, .editing-audits):not(:hover) > .status): Added.
(.tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.editing-audits):hover > .status > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status, .tree-outline .item.audit.unsupported + .children .item.audit.unsupported > .status > img): Added.
(@media (prefers-color-scheme: dark) .tree-outline .item.audit:matches(.test-case, .test-group):not(.unsupported, .manager-active):hover > .status > img): Added.
(.tree-outline .item.audit:matches(.test-case, .test-group):not(.unsupported, .manager-active) > .status:hover > img): Deleted.
(.tree-outline .item.audit > .status:not(:hover) > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.unsupported, .editing-audits) > .status:not(:hover)): Deleted.
(.tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.editing-audits) > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status, .tree-outline .item.audit.unsupported + .children .item.audit.unsupported > .status > img): Deleted.
Add context menu items for duplicating/deleting tests when in edit mode. Adjust the label
and disabled state of existing context menu items for clarity.

UserInterface/Views/CreateAuditPopover.js: Added.

(WI.CreateAuditPopover):
(WI.CreateAuditPopover.prototype.get audit):
(WI.CreateAuditPopover.prototype.show):
(WI.CreateAuditPopover.prototype.dismiss.const.testFunction):
(WI.CreateAuditPopover.prototype.dismiss):
(WI.CreateAuditPopover.prototype._presentOverTargetElement):

UserInterface/Views/CreateAuditPopover.css: Added.

(.popover .create-audit-content):
(.popover .create-audit-content > .editor-wrapper):
(.popover .create-audit-content > .editor-wrapper > .reference-page-link):
New popover for creating an audit:

[<select> of group or test case] [<input> for name] (?)

UserInterface/Views/Main.css:

(.navigation-item-help > .navigation-bar):
(.message-text-view > .navigation-item-help + .navigation-item-help): Added.
Add styles for when multiple navigation help items are used in the same message text view.

UserInterface/Views/Variables.css:

(:root):
(@media (prefers-color-scheme: dark) :root):
Add --filter-invert to light mode too.

UserInterface/Base/Utilities.js:

(HTMLInputElement.prototype.autosize):

UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize):
(WI.CanvasOverviewContentView.get recordingAutoCaptureInputMargin): Deleted.

UserInterface/Views/CanvasOverviewContentView.css:

(.navigation-bar > .item.canvas-recording-auto-capture > label > input):
(.navigation-bar > .item.canvas-recording-auto-capture > label > input::-webkit-inner-spin-button): Deleted.
Create a helper function for autosizing an <input>.

UserInterface/Views/AuditTabContentView.js:

(WI.AuditTabContentView):
(WI.AuditTabContentView.prototype.initialLayout):
Remove the back/foward arrows as they can get into an inconsistent state when editing.
Drive-by: update the drop zone text for clarity.

UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype.showDefaultContentView):
Drive-by: add period to help text.

UserInterface/Main.html:
Localizations/en.lproj/localizedStrings.js:

LayoutTests:

inspector/model/auditTestGroup.html:
inspector/model/auditTestGroup-expected.txt:

Add tests that check how disabled and supported (via supports) is propagated in groups.

inspector/audit/run.html:
inspector/audit/run-expected.txt:

Add tests for WebInspectorAudit before Audit.setup is called.

inspector/audit/manager-start-setup.html:

Renaming function call.

inspector/audit/basic-async.html:
inspector/audit/basic-boolean.html:
inspector/audit/basic-debugger.html:
inspector/audit/basic-error.html:
inspector/audit/basic-object.html:
inspector/audit/basic-promise.html:
inspector/audit/basic-string.html:
inspector/audit/basic-timeout.html:
inspector/audit/run-resources.html:

Drive-by: remove InspectorTest.debug().

6:36 PM Changeset in webkit [266316] by ysuzuki@apple.com

2 edits in branches/safari-610.1.28.1-branch/LayoutTests/platform

Remove WebAudio Failure entries from TestExpectations
<rdar://problem/67367072>

Unreviewed, rebaselined after r266315.

6:31 PM Changeset in webkit [266315] by ysuzuki@apple.com

24 edits in branches/safari-610.1.28.1-branch/LayoutTests/imported/w3c/web-platform-tests/webaudio

Rebaseline WebAudio test results
<rdar://problem/67367072>

r265824 changed what error message is. (This is unavoidable since the kind of thrown error is changed (JS side error v.s. JS error thrown from C++), and this needs to be done to fix the reported webpage’s issue).
This error is recorded as expect files in various WebAudio WPT test if the tested WebAudio constructors are not implemented.
After that branch cut, a lot of WebAudio constructors are newly implemented, which removes this error messages from expect files.
r265824 is landed after these WebAudio patches. So it does not include rebaseline for these WebAudio WPT tests (since it is no longer including that error messages).
But in that branch, these WebAudio patches are not cherry-picked. This means that error message is still recorded in WPT expect files.
So, we just need to update these expect files, or cherry-pick these WebAudio patches. And I think updating expect files is the way to go.

5:27 PM Changeset in webkit [266314] by timothy_horton@apple.com

4 edits in trunk

Sites built with flambe.js don't work with trackpad on iPad
https://bugs.webkit.org/show_bug.cgi?id=215954

Reviewed by Wenson Hsieh.

Source/WebKit:

New API Test: iOSMouseSupport.MouseTimestampTimebase

UIProcess/ios/WKMouseGestureRecognizer.mm:

(-[WKMouseGestureRecognizer createMouseEventWithType:]):
Use the timestamp property on UITouch instead of GSCurrentEventTimestamp().
This property is in the same units as mach_absolute_time/MonotonicTime.
Previously, treating a monotonic time as wall time resulted in it getting clamped to 0,
breaking sites that depend on it.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:

(-[WKTestingHoverEvent locationInView:]):
(-[WKTestingTouch timestamp]):
(TEST):

5:21 PM Changeset in webkit [266313] by Simon Fraser

2 edits in trunk/Source/WebCore

Debug event regions should paint the interactive region
https://bugs.webkit.org/show_bug.cgi?id=215955

Reviewed by Tim Horton.

Interactive regions (EventRegion's region()) were not ever shown on macOS, even though
we use them for async-scrolling hit-testing. Fix RenderLayerBacking::paintDebugOverlays()
to always paint them if wheel event handler, or touch-action regions are enabled.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintDebugOverlays):

4:21 PM Changeset in webkit [266312] by eric.carlson@apple.com

3 edits in trunk/Source/WebCore

[macOS] AirPlay device name is wrong when playing to multiple devices
https://bugs.webkit.org/show_bug.cgi?id=215952
<rdar://problem/66930799>

Reviewed by Jer Noble.

Tested manually because this requires a specific hardware setup.

platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm:

(WebCore::MediaPlaybackTargetCocoa::deviceName const): If the AVOutputContext
supports multiple output devices, create the device name by concatenating the names
of all of the active output devices.

4:04 PM Changeset in webkit [266311] by weinig@apple.com

333 edits in trunk

[WebIDL] 'void' type is changing to 'undefined'
https://bugs.webkit.org/show_bug.cgi?id=215514
<rdar://problem/67566201>

Reviewed by Darin Adler.

Update IDLs and IDL parsing / code generation for the switch from 'void' to 'undefined'.
Source/WebCore:

Also updates the parser to better match current WebIDL grammar, removing the special
'ReturnType' construction and just using 'Type' instead.

Modules/applepay/ApplePaySession.idl:
Modules/async-clipboard/Clipboard.idl:
Modules/cache/DOMCache.idl:
Modules/credentialmanagement/CredentialsContainer.idl:
Modules/encryptedmedia/MediaKeySession.h:
Modules/encryptedmedia/MediaKeySession.idl:
Modules/encryptedmedia/legacy/WebKitMediaKeySession.idl:
Modules/entriesapi/ErrorCallback.idl:
Modules/entriesapi/FileCallback.idl:
Modules/entriesapi/FileSystemDirectoryEntry.idl:
Modules/entriesapi/FileSystemDirectoryReader.idl:
Modules/entriesapi/FileSystemEntriesCallback.idl:
Modules/entriesapi/FileSystemEntry.idl:
Modules/entriesapi/FileSystemEntryCallback.idl:
Modules/entriesapi/FileSystemFileEntry.idl:
Modules/fetch/FetchHeaders.idl:
Modules/geolocation/Geolocation.idl:
Modules/geolocation/PositionCallback.idl:
Modules/geolocation/PositionErrorCallback.idl:
Modules/indexeddb/IDBCursor.idl:
Modules/indexeddb/IDBDatabase.idl:
Modules/indexeddb/IDBObjectStore.idl:
Modules/indexeddb/IDBTransaction.idl:
Modules/mediacontrols/MediaControlsHost.idl:
Modules/mediarecorder/MediaRecorder.idl:
Modules/mediasession/MediaSession.idl:
Modules/mediasource/MediaSource.idl:
Modules/mediasource/SourceBuffer.idl:
Modules/mediastream/CanvasCaptureMediaStreamTrack.idl:
Modules/mediastream/MediaStream.idl:
Modules/mediastream/MediaStreamTrack.idl:
Modules/mediastream/NavigatorMediaDevices.idl:
Modules/mediastream/RTCDTMFSender.idl:
Modules/mediastream/RTCDataChannel.idl:
Modules/mediastream/RTCPeerConnection.idl:
Modules/mediastream/RTCRtpSender.idl:
Modules/mediastream/RTCRtpTransceiver.idl:
Modules/notifications/Notification.idl:
Modules/notifications/NotificationPermissionCallback.idl:
Modules/paymentrequest/MerchantValidationEvent.idl:
Modules/paymentrequest/PaymentRequest.idl:
Modules/paymentrequest/PaymentRequestUpdateEvent.idl:
Modules/paymentrequest/PaymentResponse.idl:
Modules/pictureinpicture/DocumentPictureInPicture.idl:
Modules/plugins/QuickTimePluginReplacement.idl:
Modules/quota/StorageErrorCallback.idl:
Modules/quota/StorageInfo.idl:
Modules/quota/StorageQuota.idl:
Modules/quota/StorageQuotaCallback.idl:
Modules/quota/StorageUsageCallback.idl:
Modules/remoteplayback/RemotePlayback.idl:
Modules/speech/SpeechSynthesis.idl:
Modules/streams/ReadableByteStreamController.idl:
Modules/streams/ReadableStreamBYOBReader.idl:
Modules/streams/ReadableStreamBYOBRequest.idl:
Modules/streams/ReadableStreamDefaultController.idl:
Modules/streams/ReadableStreamDefaultReader.idl:
Modules/streams/ReadableStreamSink.idl:
Modules/streams/ReadableStreamSource.idl:
Modules/streams/TransformStreamDefaultController.idl:
Modules/streams/WritableStreamDefaultController.idl:
Modules/streams/WritableStreamDefaultWriter.idl:
Modules/webaudio/AnalyserNode.idl:
Modules/webaudio/AudioBuffer.idl:
Modules/webaudio/AudioBufferCallback.idl:
Modules/webaudio/AudioBufferSourceNode.idl:
Modules/webaudio/AudioContext.idl:
Modules/webaudio/AudioListener.idl:
Modules/webaudio/AudioNode.idl:
Modules/webaudio/AudioScheduledSourceNode.idl:
Modules/webaudio/BiquadFilterNode.idl:
Modules/webaudio/IIRFilterNode.idl:
Modules/webaudio/OfflineAudioContext.idl:
Modules/webaudio/OscillatorNode.idl:
Modules/webaudio/PannerNode.idl:
Modules/webaudio/WebKitAudioBufferSourceNode.idl:
Modules/webaudio/WebKitAudioContext.idl:
Modules/webaudio/WebKitAudioListener.idl:
Modules/webaudio/WebKitAudioPannerNode.idl:
Modules/webaudio/WebKitOscillatorNode.idl:
Modules/webdatabase/Database.idl:
Modules/webdatabase/DatabaseCallback.idl:
Modules/webdatabase/SQLStatementCallback.idl:
Modules/webdatabase/SQLTransaction.idl:
Modules/webdatabase/SQLTransactionCallback.idl:
Modules/webdatabase/SQLTransactionErrorCallback.idl:
Modules/webgpu/WebGPUBuffer.idl:
Modules/webgpu/WebGPUCommandEncoder.idl:
Modules/webgpu/WebGPUComputePassEncoder.idl:
Modules/webgpu/WebGPUDeviceErrorScopes.idl:
Modules/webgpu/WebGPUProgrammablePassEncoder.idl:
Modules/webgpu/WebGPUQueue.idl:
Modules/webgpu/WebGPURenderPassEncoder.idl:
Modules/webgpu/WebGPUTexture.idl:
Modules/websockets/WebSocket.idl:
Modules/webxr/WebXRSession.idl:
Modules/webxr/WebXRSystem.idl:
Modules/webxr/XRFrameRequestCallback.idl:
Scripts/SettingsTemplates/InternalSettingsGenerated.idl.erb:
animation/AnimationEffect.idl:
animation/KeyframeEffect.idl:
animation/WebAnimation.idl:
bindings/IDLTypes.h:
bindings/js/DOMPromiseProxy.h:
bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:

(NeedsExplicitPropagateExceptionCall):
(GenerateCallbackImplementationContent):
(GenerateImplementationFunctionCall):
(GetBaseIDLType):

bindings/scripts/IDLParser.pm:

(parseCallbackRest):
(parseAttributeOrOperationForStringifierOrStatic):
(parseOperation):
(parseSpecialOperation):
(parseMapLikeProperties):
(parseSetLikeProperties):
(parseSingleType):
(parseUnionMemberType):
(parseDistinguishableType):
(parseConstType):
(parsePrimitiveType):
(parseNonAnyType): Deleted.
(parseReturnType): Deleted.

bindings/scripts/test/JS/JSTestCallbackFunctionWithThisObject.cpp:

(WebCore::JSTestCallbackFunctionWithThisObject::handleEvent):

bindings/scripts/test/JS/JSTestCallbackFunctionWithThisObject.h:
bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.cpp:

(WebCore::JSTestCallbackFunctionWithTypedefs::handleEvent):

bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.h:
bindings/scripts/test/JS/JSTestCallbackInterface.cpp:

(WebCore::JSTestCallbackInterface::callbackWithNoParam):
(WebCore::JSTestCallbackInterface::callbackWithArrayParam):
(WebCore::JSTestCallbackInterface::callbackWithSerializedScriptValueParam):
(WebCore::JSTestCallbackInterface::callbackWithStringList):
(WebCore::JSTestCallbackInterface::callbackWithBoolean):
(WebCore::JSTestCallbackInterface::callbackRequiresThisToPass):

bindings/scripts/test/JS/JSTestCallbackInterface.h:
bindings/scripts/test/JS/JSTestIterable.cpp:
bindings/scripts/test/JS/JSTestNode.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):
(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::jsTestObjTestReadOnlyVoidPromiseAttributeGetter):
(WebCore::jsTestObjPrototypeFunctionUndefinedMethodBody):
(WebCore::jsTestObjPrototypeFunctionUndefinedMethod):
(WebCore::jsTestObjPrototypeFunctionUndefinedMethodWithArgsBody):
(WebCore::jsTestObjPrototypeFunctionUndefinedMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalPromiseBody):
(WebCore::jsTestObjPrototypeFunctionTestReturnsOwnPromiseAndPromiseProxyFunctionBody):
(WebCore::jsTestObjPrototypeFunctionVoidMethodBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionVoidMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgsBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): Deleted.

bindings/scripts/test/JS/JSTestVoidCallbackFunction.cpp:

(WebCore::JSTestVoidCallbackFunction::handleEvent):

bindings/scripts/test/JS/JSTestVoidCallbackFunction.h:
bindings/scripts/test/TestCEReactions.idl:
bindings/scripts/test/TestCallTracer.idl:
bindings/scripts/test/TestCallbackFunctionWithThisObject.idl:
bindings/scripts/test/TestCallbackFunctionWithTypedefs.idl:
bindings/scripts/test/TestCallbackInterface.idl:
bindings/scripts/test/TestDomainSecurity.idl:
bindings/scripts/test/TestEnabledBySetting.idl:
bindings/scripts/test/TestGlobalObject.idl:
bindings/scripts/test/TestImplements.idl:
bindings/scripts/test/TestIndexedSetterNoIdentifier.idl:
bindings/scripts/test/TestIndexedSetterThrowingException.idl:
bindings/scripts/test/TestIndexedSetterWithIdentifier.idl:
bindings/scripts/test/TestJSBuiltinConstructor.idl:
bindings/scripts/test/TestNamedAndIndexedSetterNoIdentifier.idl:
bindings/scripts/test/TestNamedAndIndexedSetterThrowingException.idl:
bindings/scripts/test/TestNamedAndIndexedSetterWithIdentifier.idl:
bindings/scripts/test/TestNamedDeleterNoIdentifier.idl:
bindings/scripts/test/TestNamedDeleterThrowingException.idl:
bindings/scripts/test/TestNamedDeleterWithIdentifier.idl:
bindings/scripts/test/TestNamedDeleterWithIndexedGetter.idl:
bindings/scripts/test/TestNamedSetterNoIdentifier.idl:
bindings/scripts/test/TestNamedSetterThrowingException.idl:
bindings/scripts/test/TestNamedSetterWithIdentifier.idl:
bindings/scripts/test/TestNamedSetterWithIndexedGetter.idl:
bindings/scripts/test/TestNamedSetterWithIndexedGetterAndSetter.idl:
bindings/scripts/test/TestNamedSetterWithOverrideBuiltins.idl:
bindings/scripts/test/TestNamedSetterWithUnforgableProperties.idl:
bindings/scripts/test/TestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.idl:
bindings/scripts/test/TestNode.idl:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestOperationBase.idl:
bindings/scripts/test/TestSerializedScriptValueInterface.idl:
bindings/scripts/test/TestSupplemental.idl:
bindings/scripts/test/TestTypedefs.idl:
bindings/scripts/test/TestVoidCallbackFunction.idl:
css/CSSKeyframesRule.idl:
css/CSSMediaRule.idl:
css/CSSPaintCallback.idl:
css/CSSStyleDeclaration.idl:
css/CSSStyleSheet.idl:
css/CSSSupportsRule.idl:
css/DOMCSSRegisterCustomProperty.idl:
css/DeprecatedCSSOMPrimitiveValue.idl:
css/FontFaceSet.idl:
css/MediaList.idl:
css/MediaQueryList.idl:
css/WebKitCSSMatrix.idl:
dom/AbortAlgorithm.idl:
dom/AbortController.idl:
dom/AbortSignal.idl:
dom/CharacterData.idl:
dom/ChildNode.idl:
dom/CompositionEvent.idl:
dom/CustomElementRegistry.idl:
dom/CustomEvent.idl:
dom/DOMStringMap.idl:
dom/DataTransfer.idl:
dom/DataTransferItem.idl:
dom/DataTransferItemList.idl:
dom/DeviceMotionEvent.idl:
dom/DeviceOrientationEvent.idl:
dom/Document.idl:
dom/DocumentFullscreen.idl:
dom/DocumentStorageAccess.idl:
dom/Element.idl:
dom/Event.idl:
dom/EventListener.idl:
dom/EventTarget.idl:
dom/HashChangeEvent.idl:
dom/IdleRequestCallback.idl:
dom/KeyboardEvent.idl:
dom/MessageEvent.idl:
dom/MessagePort.idl:
dom/MouseEvent.idl:
dom/MutationCallback.idl:
dom/MutationEvent.idl:
dom/MutationObserver.idl:
dom/Node.idl:
dom/NodeIterator.idl:
dom/ParentNode.idl:
dom/Range.idl:
dom/RequestAnimationFrameCallback.idl:
dom/StringCallback.idl:
dom/TextEvent.idl:
dom/TouchEvent.idl:
dom/UIEvent.idl:
dom/WheelEvent.idl:
fileapi/BlobCallback.idl:
fileapi/FileReader.idl:
html/DOMFormData.idl:
html/DOMTokenList.idl:
html/DOMURL.idl:
html/HTMLButtonElement.idl:
html/HTMLCanvasElement.idl:
html/HTMLDialogElement.idl:
html/HTMLElement.idl:
html/HTMLFieldSetElement.idl:
html/HTMLFormElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLKeygenElement.idl:
html/HTMLMarqueeElement.idl:
html/HTMLMediaElement.idl:
html/HTMLObjectElement.idl:
html/HTMLOptionsCollection.idl:
html/HTMLOrForeignElement.idl:
html/HTMLOutputElement.idl:
html/HTMLSelectElement.idl:
html/HTMLTableElement.idl:
html/HTMLTableRowElement.idl:
html/HTMLTableSectionElement.idl:
html/HTMLTextAreaElement.idl:
html/HTMLVideoElement.idl:
html/ImageBitmap.idl:
html/MediaController.idl:
html/URLSearchParams.idl:
html/VoidCallback.idl:
html/canvas/ANGLEInstancedArrays.idl:
html/canvas/CanvasDrawImage.idl:
html/canvas/CanvasDrawPath.idl:
html/canvas/CanvasGradient.idl:
html/canvas/CanvasImageData.idl:
html/canvas/CanvasPath.idl:
html/canvas/CanvasPathDrawingStyles.idl:
html/canvas/CanvasPattern.idl:
html/canvas/CanvasRect.idl:
html/canvas/CanvasRenderingContext2D.idl:
html/canvas/CanvasState.idl:
html/canvas/CanvasText.idl:
html/canvas/CanvasTransform.idl:
html/canvas/CanvasUserInterface.idl:
html/canvas/ImageBitmapRenderingContext.idl:
html/canvas/OESVertexArrayObject.idl:
html/canvas/OffscreenCanvasRenderingContext2D.idl:
html/canvas/Path2D.idl:
html/canvas/WebGL2RenderingContext.idl:
html/canvas/WebGLDrawBuffers.idl:
html/canvas/WebGLLoseContext.idl:
html/canvas/WebGLRenderingContextBase.idl:
html/track/TextTrack.idl:
inspector/CommandLineAPIHost.idl:
inspector/InspectorFrontendHost.idl:
loader/appcache/DOMApplicationCache.idl:
page/DOMSelection.idl:
page/DOMWindow.idl:
page/EventSource.idl:
page/History.idl:
page/IntersectionObserver.idl:
page/IntersectionObserverCallback.idl:
page/Location.idl:
page/Navigator.idl:
page/NavigatorIsLoggedIn.idl:
page/NavigatorShare.idl:
page/Performance.idl:
page/PerformanceObserver.idl:
page/PerformanceObserverCallback.idl:
page/RemoteDOMWindow.idl:
page/ResizeObserver.idl:
page/ResizeObserverCallback.idl:
page/UndoManager.idl:
page/WindowOrWorkerGlobalScope.idl:
plugins/DOMPluginArray.idl:
storage/Storage.idl:
storage/StorageEvent.idl:
svg/SVGAngle.idl:
svg/SVGAnimationElement.idl:
svg/SVGFEDropShadowElement.idl:
svg/SVGFEGaussianBlurElement.idl:
svg/SVGFEMorphologyElement.idl:
svg/SVGLength.idl:
svg/SVGLengthList.idl:
svg/SVGMarkerElement.idl:
svg/SVGNumberList.idl:
svg/SVGPathSegList.idl:
svg/SVGPointList.idl:
svg/SVGSVGElement.idl:
svg/SVGStringList.idl:
svg/SVGTextContentElement.idl:
svg/SVGTransform.idl:
svg/SVGTransformList.idl:
testing/InternalSettings.idl:
testing/Internals.idl:
testing/MockCDMFactory.idl:
testing/MockPageOverlay.idl:
testing/MockPaymentCoordinator.idl:
testing/ServiceWorkerInternals.idl:
testing/TypeConversions.idl:
testing/WebFakeXRDevice.idl:
testing/WebFakeXRInputController.idl:
testing/WebXRTest.idl:
testing/XRSimulateUserActivationFunction.idl:
workers/DedicatedWorkerGlobalScope.idl:
workers/Worker.idl:
workers/WorkerGlobalScope.idl:
workers/service/ExtendableEvent.idl:
workers/service/FetchEvent.idl:
workers/service/ServiceWorker.idl:
workers/service/ServiceWorkerClient.idl:
workers/service/ServiceWorkerClients.idl:
workers/service/ServiceWorkerContainer.idl:
workers/service/ServiceWorkerGlobalScope.idl:
workers/service/ServiceWorkerRegistration.idl:
worklets/PaintWorkletGlobalScope.idl:
worklets/Worklet.idl:
xml/XMLHttpRequest.idl:
xml/XSLTProcessor.idl:

Tools:

DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:

(_generateImplementationFile):
(_returnExpression):

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(_generateImplementationFile):
(_returnExpression):

WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:

4:03 PM Changeset in webkit [266310] by Russell Epstein

1 copy in tags/Safari-609.4.1

Tag Safari-609.4.1.

4:02 PM Changeset in webkit [266309] by Alan Coon

1 copy in tags/Safari-610.1.28.1.5

Tag Safari-610.1.28.1.5.

3:58 PM Changeset in webkit [266308] by Alan Coon

8 edits in branches/safari-610.1.28.1-branch/Source

Revert "Versioning."

This reverts revision 266299.

3:58 PM Changeset in webkit [266307] by Alan Coon

16 edits
2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266292. rdar://problem/67963517

Vertical scrolling gets stuck when a horizontal scroller is under the mouse (google search results)
https://bugs.webkit.org/show_bug.cgi?id=215641
<rdar://problem/67430532>

Reviewed by Tim Horton.
Source/WebCore:

There are two parts to this fix. First, findEnclosingScrollableContainer() needs
to use the same vertical-biasing delta fixup that we use in other places, to bias towards
vertical scrolling.

Second, when we've determined that the main frame should perform the scroll and dispatch
the wheel event to the scrolling thread, we used to hit-test from scratch on the scrolling
thread and and try to send the event to a scroller which we already know should not handle
it. So pass along a target ScrollingNodeID, and start the scrolling thread handling from
that node.

Test: fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html

page/FrameView.cpp: (WebCore::FrameView::wheelEvent):
page/mac/EventHandlerMac.mm: (WebCore::findEnclosingScrollableContainer):
page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::handleWheelEvent):
page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::handleWheelEvent): (WebCore::ScrollingTree::handleWheelEventWithNode):
page/scrolling/ScrollingTree.h:
page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):
page/scrolling/ThreadedScrollingTree.h:
page/scrolling/mac/ScrollingCoordinatorMac.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm: (WebCore::ScrollingCoordinatorMac::handleWheelEvent):
page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp: (WebCore::ScrollingCoordinatorNicosia::handleWheelEvent):
page/scrolling/nicosia/ScrollingCoordinatorNicosia.h:

LayoutTests:

After this change iframe-latch-small-deltas.html would time-out because WheelEventTestMonitor
would get stuck with a "content scrolling" defer region, due to begin/end wheel
events not getting both sent to the iframe. But the test was actually broken; logging shows
that it reset latching state anyway, and it's not testing the shipping configuration of
async iframe scrolling. So fix the test to use async iframe scrolling, and to avoid
rubber-banding, so that latching is not cleared due to elapsed time.

fast/scrolling/latching/iframe-latch-small-deltas-expected.txt:
fast/scrolling/latching/iframe-latch-small-deltas.html:
fast/scrolling/mac/horizontal-overflow-trapping-small-deltas-expected.txt: Added.
fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:58 PM Changeset in webkit [266306] by Alan Coon

4 edits
2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266262. rdar://problem/67963578

Scrolling on select element doesn't work after scrolling the page
https://bugs.webkit.org/show_bug.cgi?id=215900
Source/WebCore:

<rdar://problem/67766032>

Reviewed by Tim Horton.

The scrolling thread could use a node that was latched some time ago; we need to
check the freshness of the latched node before using it.

Test: fast/scrolling/latching/latching-stuck-to-main-page.html

page/scrolling/ScrollingTreeLatchingController.cpp: (WebCore::ScrollingTreeLatchingController::receivedWheelEvent): (WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const): (WebCore::ScrollingTreeLatchingController::latchedNodeIsRelevant const):
page/scrolling/ScrollingTreeLatchingController.h:

LayoutTests:

Reviewed by Tim Horton.

fast/scrolling/latching/latching-stuck-to-main-page-expected.txt: Added.
fast/scrolling/latching/latching-stuck-to-main-page.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:58 PM Changeset in webkit [266305] by Alan Coon

7 edits
2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266248. rdar://problem/67963534

Occasional crashes when restoring replaced text under Editor::changeBackToReplacedString
https://bugs.webkit.org/show_bug.cgi?id=215892
<rdar://problem/67731156>

Reviewed by Tim Horton.

Source/WebCore:

While reverting the replaced string in Editor::changeBackToReplacedString, it's possible for text replacement
(Editor::replaceSelectionWithText) to cause the text checking paragraph range to become orphaned (if for no
reason other than the fact that arbitrary script can run in between). If this happens, then our attempts to
expand the checking range to paragraph boundaries underneath TextCheckingParagraph::paragraphRange will result
in a null dereference, since the boundary points computed underneath the expandToParagraphBoundary helper will
be nullopt.

Mitigate this (and any other potentially similar crashes) by making expandToParagraphBoundary robust in the
case where expanding to the start and end fails, and just fall back to returning the original text checking
range instead.

Test: editing/mac/input/change-back-to-replaced-string.html

editing/Editor.h:
editing/TextCheckingHelper.cpp: (WebCore::expandToParagraphBoundary):

See above for more details.

testing/Internals.cpp: (WebCore::Internals::changeBackToReplacedString):
testing/Internals.h:
testing/Internals.idl:

Add a simple internal testing hook to change the currently selected text back to the given replaced string.

LayoutTests:

Add a layout test to exercise the crash.

editing/mac/input/change-back-to-replaced-string-expected.txt: Added.
editing/mac/input/change-back-to-replaced-string.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:57 PM Changeset in webkit [266304] by Alan Coon

5 edits
2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266241. rdar://problem/67963565

REGRESSION (r263506): timing of CSS Animation on https://animate.style is incorrect
https://bugs.webkit.org/show_bug.cgi?id=215807
<rdar://problem/66770136>

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/accelerated-css-animation-with-easing.html

In r263506, we added a way for accelerated animations to adhere to both a timing function set on the
animation, affecting the timing of the entire animation, as well as a timing function set on individual
keyframes, affecting the timing of the animation in a given interval. Alas, this change broke handling
of timing functions with implicit animation-timing-function on keyframes.

That code change assumed that the Animation object ultimately passed to GraphicsLayerCA::setupAnimation()
would return the animation-wide timing function through Animation::timingFunction(). This was correct for
JS-originated animations, but not for CSS Animations, since that value was set based on the computed CSS
property animation-timing-function for the target element. However, that CSS property does not specify
the animation-wide timing function, but rather the default timing function to use for keyframes should
they fail to specify an explicit timing function.

To fix this, first, we ensure that the animation-wide timing function is set on the Animation object,
changing KeyframeEffect::backingAnimationForCompositedRenderer() to always generate an Animation object
based on the effect, divorcing itself from the Animation object created through CSS.

Then, we add a new member to Animation to specify the default timing function for keyframes, allowing
GraphicsLayerCA to use it to determine the timing function when building keyframes.

animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const): Always generate an Animation object based on the effect's properties, also setting the new defaultTimingFunctionForKeyframes in the case of a CSS Animation object.
platform/animation/Animation.h: (WebCore::Animation::defaultTimingFunctionForKeyframes const): (WebCore::Animation::setDefaultTimingFunctionForKeyframes):
platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animationHasStepsTimingFunction): Use the optional defaultTimingFunctionForKeyframes to determine whether a keyframe uses a steps timing function. (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue): Use the optional defaultTimingFunctionForKeyframes to determine the timing function for a keyframe.

LayoutTests:

Add a new test that checks that a CSS Animation with implicit and explicit animation-timing-function
values behave the same when running accelerated.

webanimations/accelerated-css-animation-with-easing-expected.html: Added.
webanimations/accelerated-css-animation-with-easing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:57 PM Changeset in webkit [266303] by Alan Coon

2 edits in branches/safari-610.1.28.1-branch/Source/WebKit

Cherry-pick r266240. rdar://problem/67963545

REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests
https://bugs.webkit.org/show_bug.cgi?id=215861

Reviewed by Eric Carlson.

Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialized, which in the case of
AVPlayer does a bunch of work which shows up on power-use tests. Because the API being checked for will always exist
in macOS 11, and that code is already protected by a HAVE(AVPLAYER_VIDEORANGEOVERRIDE) pragma, just return early
here without running the +instancesRespondToSelector: check.

WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::updatePageScreenProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:57 PM Changeset in webkit [266302] by Alan Coon

3 edits
3 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266239. rdar://problem/67963554

REGRESSION (r258215): Title preview movie isn't displayed at www.thismmalife.com
https://bugs.webkit.org/show_bug.cgi?id=215774
<rdar://problem/67707957>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-as-img-output-pts.html

Use CMSampleBufferGetOutputPresentationTimeStamp() for sample PTS.

platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm: (WebCore::ImageDecoderAVFObjC::storeSampleBuffer):

LayoutTests:

media/content/video-as-img.mp4: Added.
media/video-as-img-output-pts-expected.txt: Added.
media/video-as-img-output-pts.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:57 PM Changeset in webkit [266301] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Fix iokit-get-properties sandbox violations
https://bugs.webkit.org/show_bug.cgi?id=215925

Reviewed by Brent Fulgham.

Add iokit-property to WebContent sandbox that should have been a part of r266282.

WebProcess/com.apple.WebProcess.sb.in:

3:53 PM Changeset in webkit [266300] by Hector Lopez

2 edits in trunk/LayoutTests

[ macOS ] Tests expectations changed as test passing but expected to fail
https://bugs.webkit.org/show_bug.cgi?id=215786

Unreviewed test gardening.

platform/mac/TestExpectations: corrections for BigSur+

3:37 PM Changeset in webkit [266299] by Russell Epstein

8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.6

3:17 PM Changeset in webkit [266298] by Hector Lopez

2 edits in trunk/LayoutTests

[ BigSur+ ] fast/images/image-controls-basic.html
<rdar://64947666>

Unreviewed test gardening.

platform/mac/TestExpectations:

3:15 PM WebKitGTK/2.30.x edited by Adrian Perez de Castro

(diff)

3:09 PM Changeset in webkit [266297] by Adrian Perez de Castro

4 edits in trunk

[WPE] Enable Notifications support
https://bugs.webkit.org/show_bug.cgi?id=215924

Reviewed by Philippe Normand.

Enable web notifications support for the WPE port. The code is shared with the GTK
port, but as we do not try to find and enable libnotify the default implementation
is a stub: embedders can customize how to display notifications by connecting to
the WebKitWebView:show-notification signal. This way we do not add any additional
build dependencies.

Source/cmake/OptionsWPE.cmake: Flip ENABLE_NOTIFICATIONS to ON.

LayoutTests:

platform/wpe/TestExpectations: Update test expectations.

2:40 PM Changeset in webkit [266296] by Lauro Moura

3 edits in trunk/LayoutTests

[GTK][WPE] Gardening some failures.

Unreviewed test gardening.

platform/glib/TestExpectations:
platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:

2:37 PM Changeset in webkit [266295] by Darin Adler

49 edits in trunk

Remove almost all the remaining uses of live ranges
https://bugs.webkit.org/show_bug.cgi?id=215755

Reviewed by Sam Weinig.

Source/WebCore:

accessibility/AXObjectCache.cpp:

(WebCore::characterOffsetsInOrder): Use documentOrder.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::misspellingRange const): Ditto.
(WebCore::rangeClosestToRange): Use characterCount. Also removed unnnecessary assertions
and special cases.
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const): Use documentOrder.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::documentBasedSelectedTextRange const): Use intersects.
Also use firstRange instead of toNormalizedRange.

dom/Element.h: Export attachShadow so it can be used in unit tests.

dom/Node.cpp:

(WebCore::depthInComposedTree): Renamed and changed to use parentInComposedTree
instead of parentOrShadowHostNode to handle cases involving assigned slots correctly.
(WebCore::commonInclusiveAncestorAndChildren): Ditto.
(WebCore::isSiblingSubsequent): Added assertions.
(WebCore::documentOrder): Add logic so shadow roots are ordered before the
other children of their hosts in cases that don't involve assigned slots.
Without this the results would be inconsistent based on the order of the
arguments passed to documentOrder.

dom/Node.h: Added is_neq, is_lteq, and is_gteq for use with PartialOrdering,

matching the names and behavior from C++20.

dom/Range.cpp: Removed unused CoordinateSpace.

(WebCore::Range::Range): Updated since RangeBoundaryPoint now uses references.
(WebCore::Range::updateDocument): Renamed from setDocument and changed so that
it maintains the invariants without requiring the caller pass any arguments.
Also updated for RangeBoundaryPoint anme changes.
(WebCore::Range::compareBoundaryPoints): Deleted.
(WebCore::checkForDifferentRootContainer): Deleted.
(WebCore::Range::setStart): Updated for checkNodeOffsetPair name change.
Removed too-complex code for moving between documents. Use documentOrder
instead of checkForDifferentRootContainer to check for start/end that have
incorrect order or no common ancestor. Use updateDocument.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::isPointInRange): Use isPointInRange that takes a SimpleRange.
Also updated for checkNodeOffsetPair name change.
(WebCore::Range::comparePoint const): Use documentOrder. Ditto.
(WebCore::Range::compareNode const): Use documentOrder.
(WebCore::top): Deleted.
(WebCore::Range::compareBoundaryPoints const): Deleted more overloads.
Kept only the one needed for bindings, and renamed it from
compareBoundaryPointsForBindings. Also fixed the implementatin to be simpler,
use documentOrder, and match the DOM specification more closely (without a
behavior change).
(WebCore::Range::boundaryPointsValid const): Deleted.
(WebCore::Range::intersectsNode const): Use intersects from SimpleRange.
Also don't raise exceptions.
(WebCore::lengthOfContentsInNode): Deleted. This gives the same result as
Node::length, but less efficiently.
(WebCore::Range::processContents): Updated since RangeBoundaryPoint now
uses references.
(WebCore::processContentsBetweenOffsets): Removed obsolete comment.
(WebCore::Range::toString const): Use intersectingNodes and
characterDataOffsetRange.
(WebCore::Range::text const): Deleted.
(WebCore::Range::detach): Moved to the header.
(WebCore::Range::checkNodeOffsetPair const): Rneamed from checkNodeWOffset.
(WebCore::Range::cloneRange): Use m_ownerDocument.
(WebCore::Range::setStartAfter): Tweaked coding style.
(WebCore::Range::setEndBefore): Ditto.
(WebCore::Range::setEndAfter): Ditto.
(WebCore::Range::selectNode): Ditto. Also removed unnecessary code to
call setDocument, since setStart takes care of that.
(WebCore::Range::selectNodeContents): Ditto.
(WebCore::Range::setStartBefore): Ditto.
(WebCore::Range::firstNode const): Deleted.
(WebCore::Range::pastLastNode const): Deleted.
(WebCore::Range::contains const): Deleted.
(WebCore::areRangesEqual): Deleted.
(WebCore::rangesOverlap): Deleted.
(WebCore::boundaryNodeChildrenChanged): Tweaked coding style and updated
since RangeBoundaryPoint uses a reference.
(WebCore::Range::nodeChildrenChanged): Use m_ownerDocument.
(WebCore::boundaryNodeChildrenWillBeRemoved): Removed unneeded code
to handle case where one of the children is the childBefore but the
node is not inside the container -- that case doesn't exist. Use
Node::contains.
(WebCore::Range::nodeChildrenWillBeRemoved): Use m_ownerDocument.
(WebCore::boundaryNodeWillBeRemoved): Simplify logic using
Range::contains.
(WebCore::Range::nodeWillBeRemoved): Use m_ownerDocument.
(WebCore::Range::parentlessNodeMovedToNewDocumentAffectsRange):
Updated since RangeBoundaryPoint uses a reference.
(WebCore::boundaryTextInserted): Ditto.
(WebCore::boundaryTextRemoved): Ditto.
(WebCore::boundaryTextNodesMerged): Ditto.
(WebCore::boundaryTextNodesSplit): Ditto.
(showTree): Removed call to boundaryPointsValid. That's checking something
the class already treats as an invariant, so it's obsolete code left from
long ago when we didn't have that implemented correctly.

dom/Range.h: Reorganized the header to match the IDL file.

Removed ownerDocument, compareBoundaryPoints overloads other than the one
used from bindings, firstNode, pastLastNode, text, contains, areRangesEqual,
and rangesOverlap. Also updated since RangeBoundaryPoint::container is now
a reference. Moved detach function here to the header as an empty inline.

dom/Range.idl: Changed start/endOffset to unsigned. Stopped using the

name compareBoundaryPointersForBindings. Updated intersectsNode to not
throw exceptions as called for in the DOM specification. Tweaked comments.

dom/RangeBoundaryPoint.h: Changed constructor argument to a reference.

Renamed setToBeforeChild, setToAfterChild, setToStartOfNode, and setToEndOfNode
to setToBeforeNode, setToAfterNode, setToBeforeContents, setToAfterContents.
Merged ensureOffsetIsValid into the offset function. Changed m_containerNode
into a Ref<> and renamed it m_container. Removed clear.

dom/SimpleRange.cpp:

(WebCore::isOffsetBeforeChild): Add logic so shadow roots are ordered after offset
0 but before offset 1 in their hosts in cases that don't involve assigned slots.
This is an arbitrary choice, but is consistent with how we order shadow roots before
other child nodes.
(WebCore::documentOrder): Use parentInComposedTree instead of parentOrShadowHostNode
to handle cases involving assigned slots correctly.
(WebCore::isPointInRange): Added.
(WebCore::documentOrder): Added.
(WebCore::contains): Added.
(WebCore::intersects): Added.
(WebCore::unionRange): Added.

dom/SimpleRange.h: Updated for above.

editing/Editing.cpp:

(WebCore::comparePositions): Use documentOrder.
(WebCore::isNodeVisiblyContainedWithin): Use contains.

editing/Editor.cpp:

(WebCore::isFrameInRange): Use intersects.
(WebCore::Editor::scanSelectionForTelephoneNumbers): Use intersects.

editing/EditorCommand.cpp:

(WebCore::unionRanges): Moved to SimpleRange.cpp, where it's now
implemented using documentOrder.
(WebCore::executeDeleteToMark): Updated name to unionRange.
(WebCore::executeSelectToMark): Ditto.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::respondToNodeModification): Use intersects.

editing/mac/DictionaryLookupLegacy.mm:

(WebCore::selectionContainsPosition): Use isPointInRange.

page/DOMSelection.cpp:

(WebCore::DOMSelection::extend): Use makeRefPtr and Node::length
to streamline the implementation.
(WebCore::DOMSelection::getRangeAt): Use makeBoundaryPointBeforeNode
and remove unneeded null check that's already covered above.
(WebCore::DOMSelection::addRange): Use intersects and unionRange.
(WebCore::DOMSelection::containsNode const): Use intersects and contains.
(WebCore::DOMSelection::isValidForPosition const): Use boolean logic.

page/DragController.cpp:

(WebCore::DragController::draggableElement const): Use contains.
(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret): Use intersects.

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent): Use contains.

page/Page.cpp:

(WebCore::Page::findTextMatches): Use documentOrder.

page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight):
Use contains.

testing/Internals.cpp:

(WebCore::Internals::rangeAsText): Use plainText.
(WebCore::join): Added.
(WebCore::Internals::rangeAsTextUsingBackwardsTextIterator): Use a vector
that we reverse and join rather than inserting at the start of a string.
(WebCore::Internals::subrange): Added a call to updateLayout since text iterator
functions depend on the state of the render tree. Realized this was theoretically
needed because of Internals::rangeAsText.
(WebCore::Internals::rangeOfStringNearLocation): Ditto.

Source/WebKit:

WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMRange.cpp:

(webkit_dom_range_compare_boundary_points): Update for rename of
compareBoundaryPointsForBindings.
(webkit_dom_range_intersects_node): Removed exception handling.
(webkit_dom_range_get_text): Use plainText.

WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange initWithDocument:]): Tightened up into a one-liner.
(-[WKDOMRange text]): Use plainText.
(-[WKDOMRange textRects]): Stopped using Range::ownerDocument.

WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::document): Stopped using
Range::ownerDocument.
(WebKit::InjectedBundleRangeHandle::boundingRectInWindowCoordinates const):
Ditto.
(WebKit::InjectedBundleRangeHandle::renderedImage): Ditto.
(WebKit::InjectedBundleRangeHandle::text const): Use plainText.

WebProcess/WebPage/glib/WebPageGLib.cpp:

(WebKit::WebPage::getPlatformEditorState const): Use contains.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestDocumentEditingContext): Use intersects.

Source/WebKitLegacy/mac:

DOM/DOMRange.mm:

(-[DOMRange text]): Use plainText.
(-[DOMRange compareBoundaryPoints:sourceRange:]): Update for rename of
compareBoundaryPointsForBindings.
(-[DOMRange intersectsNode:]): Removed raiseOnDOMError.

DOM/DOMUIKitExtensions.mm:

(firstNodeAfter): Moved Range::firstNode here since it's the only remaining caller;
might need to keep legacy behavior depending on how this is used by UIKit.
(-[DOMRange firstNode]): Call firstNodeAfter.

DOM/WebDOMOperations.mm:

(-[DOMRange markupString]): Stop using Range::ownerDocument.

Tools:

TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp:

(TestWebKitAPI::TEST): Added test cases for node ordering involving non-user-agent
shadow tree. Added test case that showed the old "use node order if offsets are equal"
rule for boundary point ordering was wrong. Added tests for isPointInRange,
intersects, and contains functions.

2:35 PM Changeset in webkit [266294] by Hector Lopez

2 edits in trunk/LayoutTests

[ BigSur+ ] fast/forms/hidpi-textfield-background-bleeding.html
<rdar://66295552>

Unreviewed test gardening.

platform/mac/TestExpectations:

2:27 PM Changeset in webkit [266293] by Chris Dumez

9 edits in trunk

AudioParam.value setter should call setValueAtTime(value, now)
https://bugs.webkit.org/show_bug.cgi?id=215946

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:

Source/WebCore:

AudioParam.value setter should call setValueAtTime(value, now), as per:

https://www.w3.org/TR/webaudio/#dom-audioparam-value

No new tests, rebaselined existing tests.

Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::valueForBindings const):
(WebCore::AudioParam::setValueForBindings):

Modules/webaudio/AudioParam.h:
Modules/webaudio/AudioParam.idl:

2:09 PM Changeset in webkit [266292] by Simon Fraser

16 edits
2 adds in trunk

Vertical scrolling gets stuck when a horizontal scroller is under the mouse (google search results)
https://bugs.webkit.org/show_bug.cgi?id=215641
<rdar://problem/67430532>

Reviewed by Tim Horton.
Source/WebCore:

There are two parts to this fix. First, findEnclosingScrollableContainer() needs
to use the same vertical-biasing delta fixup that we use in other places, to bias towards
vertical scrolling.

Second, when we've determined that the main frame should perform the scroll and dispatch
the wheel event to the scrolling thread, we used to hit-test from scratch on the scrolling
thread and and try to send the event to a scroller which we already know should not handle
it. So pass along a target ScrollingNodeID, and start the scrolling thread handling from
that node.

Test: fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html

page/FrameView.cpp:

(WebCore::FrameView::wheelEvent):

page/mac/EventHandlerMac.mm:

(WebCore::findEnclosingScrollableContainer):

page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::handleWheelEvent):

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::handleWheelEventWithNode):

page/scrolling/ScrollingTree.h:
page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):

page/scrolling/ThreadedScrollingTree.h:
page/scrolling/mac/ScrollingCoordinatorMac.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp:

(WebCore::ScrollingCoordinatorNicosia::handleWheelEvent):

page/scrolling/nicosia/ScrollingCoordinatorNicosia.h:

LayoutTests:

After this change iframe-latch-small-deltas.html would time-out because WheelEventTestMonitor
would get stuck with a "content scrolling" defer region, due to begin/end wheel
events not getting both sent to the iframe. But the test was actually broken; logging shows
that it reset latching state anyway, and it's not testing the shipping configuration of
async iframe scrolling. So fix the test to use async iframe scrolling, and to avoid
rubber-banding, so that latching is not cleared due to elapsed time.

fast/scrolling/latching/iframe-latch-small-deltas-expected.txt:
fast/scrolling/latching/iframe-latch-small-deltas.html:
fast/scrolling/mac/horizontal-overflow-trapping-small-deltas-expected.txt: Added.
fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html: Added.

1:21 PM Changeset in webkit [266291] by Alan Bujtas

6 edits in trunk/Source/WebCore

No need to run full can-use-for (fast inline layout codepath) check on every style change.
https://bugs.webkit.org/show_bug.cgi?id=215937
<rdar://problem/67951360>

Reviewed by Antti Koivisto.

Let's use the StyleDifference to figure out how extensive the can-use-for check should be.
We can certainly skip some relatively expensive content checks when we know that the style change only triggers repaint or positioned-movement-only changes.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::canUseForAfterStyleChange):

layout/integration/LayoutIntegrationLineLayout.h:
rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::styleDidChange):

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForAfterStyleChange):

rendering/SimpleLineLayout.h:

1:21 PM Changeset in webkit [266290] by mmaxfield@apple.com

5 edits
2 adds in trunk

[iOS] Vertical text's logical width calculation is stale from the previous height of the WKWebView
https://bugs.webkit.org/show_bug.cgi?id=215910

Reviewed by Simon Fraser.

Source/WebCore:

When there is vertical text (really: orthogonal flows) in the content, the available width of the vertical
text is the height of its containing block. However, the height of the containing block (indeed: all ancestors)
may be "auto", in which case the CSS spec says the available width of the element should be "the initial
containing block's size."[1]

Previously, we were using the FrameView's visibleHeight as this metric. However, the visibleHeight is calculated
asynchronously, after layout, after a round-trip from the Web Process to the UI Process and back to the Web
Process. Therefore, if content changes the WKWebView's size and the web view immediatey re-lays-out, this
visibleHeight metric is stale from whatever the previous height of the WKWebView was. In addition, the
visibleHeight metric isn't even supposed to be used inside layout; it's instead only supposed to be used for
things like position: fixed elements.

Instead, we should use FrameView::layoutSize(), which is set before layout to the size of the WKWebView. The
name even indicates that it should be used for layout purposes.

[1] https://drafts.csswg.org/css-writing-modes-4/#orthogonal-auto

Test: WebKit.OrthogonalFlowAvailableSize

rendering/RenderBox.cpp:

(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const):

rendering/RenderView.cpp:

(WebCore::RenderView::availableLogicalHeight const):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit/OrthogonalFlowAvailableSize.mm: Added.

(TEST):

TestWebKitAPI/Tests/WebKit/orthogonal-flow-available-size.html: Added.

11:52 AM Changeset in webkit [266289] by Chris Dumez

16 edits
1 copy
7 adds in trunk/LayoutTests/imported/w3c

Resync web-platform-tests/webaudio from upstream
https://bugs.webkit.org/show_bug.cgi?id=215935

Reviewed by Sam Weinig.

Resync web-platform-tests/webaudio from upstream 37c7777f647d4383943.

web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/constructor-allowed-to-start-expected.txt: Added.
web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-overflow-expected.txt: Added.
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-periodicwave-interface/periodicWave-expected.txt: Added.
web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:

11:37 AM Changeset in webkit [266288] by commit-queue@webkit.org

4 edits in trunk

Fix text-transform inheritance to ::marker
https://bugs.webkit.org/show_bug.cgi?id=214359

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-08-28
Reviewed by Darin Adler.

Per https://github.com/w3c/csswg-drafts/issues/4206, default ::marker
pseudoelement style to text-transform: none in the UA stylesheet to
avoid surprising effects from inheritance.

No tests added -- change is tested by existing WPTs.

css/html.css:

(::marker):

11:33 AM Changeset in webkit [266287] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

REGRESSION(r266187): ARGUMENT BAD: WebIconUtilities.mm(138) : RetainPtr<UIImage> WebKit::iconForFile(NSURL *) file, [file isFileURL]
https://bugs.webkit.org/show_bug.cgi?id=215931

Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-28
Reviewed by Wenson Hsieh.

It's possible for JavaScript to make a filename that doesn't convert to a file URL, such as the empty string.
When this happens, we would've returned null for the icon later anyways, but adding a null check prevents an assertion.
Covered by 7 existing tests which would have hit that assertion.

WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::createIconForFiles):

11:02 AM Changeset in webkit [266286] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove the system tracing from DisplayList::Replayer::replay()
https://bugs.webkit.org/show_bug.cgi?id=215933

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-08-28
Reviewed by Simon Fraser.

Remove this expensive tracing point since it can affect the tracing of
the MotionMark Design test.

platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::replay):

11:02 AM Changeset in webkit [266285] by Russell Epstein

3 edits
1 add in branches/safari-610-branch

Cherry-pick r266254. rdar://problem/67949890

GetByVal constant folding over a Double OutOfBoundsSaneChain array with no BytecodeUsesAsOther should constant fold to PNaN, not undefined
https://bugs.webkit.org/show_bug.cgi?id=215894
<rdar://problem/67669696>

Reviewed by Michael Saboff and Keith Miller.

JSTests:

stress/oob-sane-chain-double-constant-fold-to-PNaN.js: Added.

Source/JavaScriptCore:

GetByVals of the form { OutOfBoundsSaneChain, Double } where there are no
BytecodeUsesAsOther return PNaN for holes and OOB accesses, not jsUndefined().
The constant folding for this though was folding to jsUndefined(). I forgot
to update that code to constant fold to PNaN when I wrote the OutOfBoundsSaneChain
implementation.

dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:31 AM Changeset in webkit [266284] by youenn@apple.com

2 edits in trunk/Source/WebKit

Enable TransformStream by default
https://bugs.webkit.org/show_bug.cgi?id=215891

Reviewed by Darin Adler.

Shared/WebPreferences.yaml:

10:24 AM Changeset in webkit [266283] by youenn@apple.com

13 edits in trunk

initializeReadableStream should check for highWaterMark be undefined
https://bugs.webkit.org/show_bug.cgi?id=215890

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

web-platform-tests/streams/transform-streams/backpressure.any-expected.txt:
web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt:
web-platform-tests/streams/transform-streams/errors.any-expected.txt:
web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt:
web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt:
web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt:
web-platform-tests/streams/transform-streams/strategies.any-expected.txt:
web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt:
web-platform-tests/streams/transform-streams/terminate.any-expected.txt:
web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt:

Source/WebCore:

Covered by updated tests.

Modules/streams/ReadableStream.js:

(initializeReadableStream):

10:14 AM Changeset in webkit [266282] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Fix iokit-get-properties sandbox violations
https://bugs.webkit.org/show_bug.cgi?id=215925

Reviewed by Darin Adler.

A few iokit properties needs to be added to the WebContent process' sandbox after observing these being in use.

WebProcess/com.apple.WebProcess.sb.in:

10:00 AM Changeset in webkit [266281] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Remove adopted node from TextManipulationController
https://bugs.webkit.org/show_bug.cgi?id=215914

Reviewed by Wenson Hsieh.

Remove Node from TextManipulationController when it gets adopted to a new document.

dom/Node.cpp:

(WebCore::Node::moveNodeToNewDocument):

9:47 AM Changeset in webkit [266280] by graouts@webkit.org

5 edits
2 adds in trunk

REGRESSION (r263506): scale transform transitions won't overshoot
https://bugs.webkit.org/show_bug.cgi?id=215826
<rdar://problem/67759310>

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/accelerated-css-transition-with-easing-y-axis-above-1.html

In r263506 we made a change where accelerated animations would set their animation-wide
timing functions using PlatformCAAnimation::setTimingFunction() instead of setting it
on individual keyframes. This change was required to support the unique ability of
JS-originated animations to specify both an animation-wide timing function as well as
per-keyframe timing functions.

In the case of CSS Transitions, this meant that instead of setting a per-keyframe timing
function, this change would set the animation-wide timing function since CSS Transitions
should map the transition-timing-function property to the "easing" property of the Animation
object exposed by the Web Animations API, not as the timing function of the single keyframe
interval.

However, this change surfaced a bug in Core Animation on macOS and iOS where a cubic-bezier()
timing function with y values above 1 get clipped when applied to a CAKeyframeAnimation using
the timingFunction property (singular) instead of the timingFunctions property (plural).

To work around this issue, we set Animation::property() on the generated Animation object passed
to GraphicsLayerCA to make it possible to detect when we're dealing with a CSS Transition and
set the timing function on the keyframe interval rather than on the animation itself.

Alas, this does not fix the case where a JS-originated animation will specify an animation-wide
timing function with a cubic-bezier() timing function with y values above 1. There is no known
workaround at this time for this case and this is covered by bug 215918.

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

LayoutTests:

Add a new test that checks that a CSS Transition using a cubic-bezier() timing function with
a y value beyond 1 does not get clipped.

platform/win/TestExpectations:
webanimations/accelerated-css-transition-with-easing-y-axis-above-1-expected.html: Added.
webanimations/accelerated-css-transition-with-easing-y-axis-above-1.html: Added.

9:08 AM Changeset in webkit [266279] by Hector Lopez

2 edits in trunk/LayoutTests

[ macOS iOS ] compositing/video/poster.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215929

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

8:23 AM Changeset in webkit [266278] by Hector Lopez

2 edits in trunk/LayoutTests

[ macOS wk1 ] svg/custom/object-sizing.xhtml is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215926

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

8:21 AM Changeset in webkit [266277] by Jonathan Bedard

5 edits
1 delete in trunk/Tools

[webkitcorepy] Move Timeout to webkitcorepy (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=215584
<rdar://problem/67270713>

Reviewed by Darin Adler.

Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Use webkitcorepy's Timeout object.
Scripts/webkitpy/common/timeout_context.py: Removed.
Scripts/webkitpy/port/simulator_process.py: Use webkitcorepy's Timeout object.
Scripts/webkitpy/webdriver_plt/liveplt.py: Ditto.
Scripts/webkitpy/xcode/simulated_device.py: Ditto.

6:37 AM Changeset in webkit [266276] by Alan Bujtas

10 edits
1 add in trunk/Source/WebCore

[LFC][IFC] Move inline alignment code to LineBox
https://bugs.webkit.org/show_bug.cgi?id=215117

Reviewed by Antti Koivisto.

LineBox is responsible for aligning the runs both vertically and horizontally (LineContentAligner -> LineBox).
(Note that LineBox::m_runRectList is transitional and will eventually be converted to inline boxes.)

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):
(WebCore::Layout::HangingContent::width const): Deleted.
(WebCore::Layout::HangingContent::isConditional const): Deleted.
(WebCore::Layout::HangingContent::setIsConditional): Deleted.
(WebCore::Layout::HangingContent::expand): Deleted.
(): Deleted.
(WebCore::Layout::HangingContent::reset): Deleted.
(WebCore::Layout::LineContentAligner::inlineRectList const): Deleted.
(WebCore::Layout::LineContentAligner::formattingContext const): Deleted.
(WebCore::Layout::LineContentAligner::layoutState const): Deleted.
(WebCore::Layout::LineContentAligner::LineContentAligner): Deleted.
(WebCore::Layout::LineContentAligner::alignHorizontally): Deleted.
(WebCore::Layout::LineContentAligner::alignVertically): Deleted.
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineContentAligner::collectHangingContent const): Deleted.

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::inlineRectList const):
(WebCore::Layout::LineBox::logicalBottom const):
(WebCore::Layout::LineBox::logicalRect const):
(WebCore::Layout::LineBox::scrollableOverflow const):
(WebCore::Layout::LineBox::formattingContext const):
(WebCore::Layout::LineBox::layoutState const):
(WebCore::Layout::LineBox::setLogicalHeight): Deleted.
(WebCore::Layout::LineBox::setLogicalWidth): Deleted.
(WebCore::Layout::LineBox::moveHorizontally): Deleted.
(WebCore::Layout::LineBox::expandHorizontally): Deleted.
(WebCore::Layout::LineBox::shrinkHorizontally): Deleted.
(WebCore::Layout::LineBox::expandVertically): Deleted.
(WebCore::Layout::LineBox::shrinkVertically): Deleted.
(WebCore::Layout::LineBox::isConsideredEmpty const): Deleted.
(WebCore::Layout::LineBox::setIsConsideredEmpty): Deleted.
(WebCore::Layout::LineBox::setIsConsideredNonEmpty): Deleted.
(WebCore::Layout::LineBox::LineBox): Deleted.
(WebCore::Layout::LineBox::resetAlignmentBaseline): Deleted.

layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::lineLogicalWidth const):
(WebCore::Layout::LineBuilder::availableWidth const):

layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::close):

layout/inlineformatting/LineLayoutContext.h:

1:46 AM Changeset in webkit [266275] by Chris Lord

21 edits in trunk

Add WebGL(2) context support to OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=209809

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Rebaseline OffscreenCanvas tests after enabling WebGL contexts.

web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext-expected.txt:
web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext.worker-expected.txt:

Source/WebCore:

Enable WebGL contexts with OffscreenCanvas by making sure the required
settings are marshalled to workers and that any functionality that
doesn't require an HTMLCanvasElement uses CanvasBase instead.

No new tests, rebaselined existing test.

html/CanvasBase.h:
html/CustomPaintCanvas.cpp:

(WebCore::CustomPaintCanvas::clearCopiedImage const):

html/CustomPaintCanvas.h:
html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::clearCopiedImage const):

html/HTMLCanvasElement.h:
html/OffscreenCanvas.cpp:

(WebCore::requiresAcceleratedCompositingForWebGL):
(WebCore::shouldEnableWebGL):
(WebCore::OffscreenCanvas::createContextWebGL):
(WebCore::OffscreenCanvas::getContext):

html/OffscreenCanvas.h:
html/OffscreenCanvas.idl:
html/canvas/WebGL2RenderingContext.idl:
html/canvas/WebGLRenderingContext.idl:
html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::markContextChanged):
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToCanvas):

workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::acceleratedCompositingEnabled const):
(WebCore::WorkerGlobalScope::webGLEnabled const):

workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

workers/WorkerThread.cpp:

(WebCore::WorkerParameters::isolatedCopy const):

workers/WorkerThread.h:
workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::ServiceWorkerThread):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed