Timeline

Aug 31, 2020:

11:56 PM Changeset in webkit [266387] by mmaxfield@apple.com

• 6 edits
  2 adds in trunk

Ahom text is still busted
​https://bugs.webkit.org/show_bug.cgi?id=216024
<rdar://problem/60571257>

Reviewed by Zalan Bujtas.

Source/WebCore:

r259533 didn't actually solve the problem becasue I made a typo.
Luckily, iOS 14 and macOS Big Sur include a font with which this patch can be tested!
So this patch actually fixes it for real.

Test: fast/text/ahom.html

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::characterRangeCodePath):

LayoutTests:

• fast/text/ahom-expected-mismatch.html: Added.
• fast/text/ahom.html: Added.
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• platform/ios-13/TestExpectations:

10:19 PM Changeset in webkit [266386] by commit-queue@webkit.org

• 19 edits
  1 delete in trunk/LayoutTests

Unreviewed, reverting r266378 and r266381.
​https://bugs.webkit.org/show_bug.cgi?id=216029

rebaselined tests for new OS without leaving old baselines
behind

Reverted changesets:

"[ BigSur+ ] media/media-source/media-source-webm.html"
​https://trac.webkit.org/changeset/266378

"[ BigSur+ ] platform/mac/media/media-source/is-type-
supported-vp9-codec-check.html"
​https://trac.webkit.org/changeset/266381

9:08 PM Changeset in webkit [266385] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WPE][WebDriver] Gardening a few more failures

Unreviewed test gardening.

• TestExpectations.json:

8:59 PM Changeset in webkit [266384] by sihui_liu@apple.com

• 6 edits in trunk/Source/WebKit

Webpages flash when switching between windows
​https://bugs.webkit.org/show_bug.cgi?id=216012

Reviewed by Darin Adler.

Based on patches from Tim Horton. To avoid flash, we need to make sure view to be selected updates its content
before UI process commits its transaction. We did this by making UI process block until receiving a reply
DidUpdateActivityState from web process. However, web process did not make sure the reply would be sent after
normal rendering update and corresponding transasction commit. Instead, it flushed transactions in progress and
replied. To fix this, now we make web process reply in transaction commit handler after rendering update.

In the switching case, view to be unselected will detach from root layer in its web process, which makes its
content empty. This change is independent from the UI process commit, so we want this to happen after UI process
commits (which submits the view hierachy change). Otherwise, empty content(white flash) on the unselected view
will be displayed. To fix this, we let UI process send the activity state update message in transaction commit
handler.

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::scheduleActivityStateUpdate):

• UIProcess/WebPageProxy.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):
(WebKit::WebPageProxy::setSuppressVisibilityUpdates):
(WebKit::WebPageProxy::activityStateDidChange):
(WebKit::WebPageProxy::dispatchActivityStateChange):

• UIProcess/WebPageProxy.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::handleActivityStateChangeCallbacksIfNeeded):
(WebKit::TiledCoreAnimationDrawingArea::updateRendering):
(WebKit::TiledCoreAnimationDrawingArea::activityStateDidChange):
(WebKit::TiledCoreAnimationDrawingArea::didUpdateActivityStateTimerFired): Deleted.

7:45 PM Changeset in webkit [266383] by mark.lam@apple.com

• 3 edits
  2 adds in trunk

Missing exception check while handling the onbeforeunload event.
​https://bugs.webkit.org/show_bug.cgi?id=216015
<rdar://problem/66324934>

Reviewed by Saam Barati.

Source/WebCore:

Test: js/dom/missing-exception-check-while-handling-onbeforeunload.html

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

LayoutTests:

• js/dom/missing-exception-check-while-handling-onbeforeunload-expected.txt: Added.
• js/dom/missing-exception-check-while-handling-onbeforeunload.html: Added.

6:18 PM Changeset in webkit [266382] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] platform/mac/media/mediacapabilities/vp9-decodingInfo-sw.html
rdar://65188503

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

6:10 PM Changeset in webkit [266381] by Karl Rackler

• 1 edit
  2 adds in trunk/LayoutTests

Rebaseline after macOS build progression.
Add for Big-Sur

Unreviewed test gardening.

• platform/mac/fast/forms/date/date-input-rendering-basic-expected.txt: Added.

5:48 PM Changeset in webkit [266380] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] platform/mac/media/media-source/is-type-supported-vp9-codec-check.html
rdar://65188503

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

5:04 PM Changeset in webkit [266379] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] media/media-source/media-source-webm.html is a constant failure
rdar://problem/66487888

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

5:01 PM Changeset in webkit [266378] by Karl Rackler

• 19 edits in trunk/LayoutTests

Rebaseline after macOS build progression.
Add for Big-Sur

Unreviewed test gardening.

• platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt:
• platform/mac/fast/css/continuationCrash-expected.txt:
• platform/mac/fast/css/text-overflow-input-expected.txt:
• platform/mac/fast/forms/button-positioned-expected.txt:
• platform/mac/fast/forms/button-sizes-expected.txt:
• platform/mac/fast/forms/input-button-sizes-expected.txt:
• platform/mac/fast/forms/input-disabled-color-expected.txt:
• platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac/fast/forms/input-text-word-wrap-expected.txt:
• platform/mac/fast/forms/listbox-bidi-align-expected.txt:
• platform/mac/fast/forms/plaintext-mode-2-expected.txt:
• platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac/fast/forms/select-selected-expected.txt:
• platform/mac/fast/forms/select/optgroup-rendering-expected.txt:
• platform/mac/fast/parser/document-write-option-expected.txt:
• platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
• platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
• platform/mac/tables/mozilla/bugs/bug33855-expected.txt:

4:36 PM Changeset in webkit [266377] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.6

4:36 PM Changeset in webkit [266376] by Hector Lopez

• 2 edits in trunk/LayoutTests

Unreviewed, reverting r266374.

Revision set up incorrect expectation

Reverted changeset:

"[ BigSur+ ] media/media-source/media-source-webm.html"
​https://trac.webkit.org/changeset/266374

4:34 PM Changeset in webkit [266375] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Avoid computing metadata for idempotent text autosizing on macOS
​https://bugs.webkit.org/show_bug.cgi?id=216011

Reviewed by Darin Adler.

Avoids an unnecessary call to adjustForTextAutosizing during style resolution on macOS, where idempotent text
autosizing is disabled. This function call populates the AutosizeStatus fields on RenderStyle that are used
by the idempotent text autosizing heuristic. This function call appears consistently in traces taken while
running the Multiply subtest of MotionMark, if only for a relatively small number of samples. While
AutosizeStatus::computeStatus is designed to be very cheap, it ends up being called around 1.6 million times
over the course of the subtest.

• style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):

4:24 PM Changeset in webkit [266374] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] media/media-source/media-source-webm.html
rdar://66487888

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:19 PM Changeset in webkit [266373] by jh718.park@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Remove the unused variable build warning since r238538.

No new tests, no new behaviors.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::copyNonAttributePropertiesFromElement):

4:16 PM Changeset in webkit [266372] by Jonathan Bedard

• 5 edits in trunk/Tools

[webkitcorepy] Register another package in the WebKit repository
​https://bugs.webkit.org/show_bug.cgi?id=216013
<rdar://problem/68097461>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall.register): If a package is also checked into the webkit repository,
we prefer the checked in version to the auto-installed version.

• Scripts/webkitpy/init.py: Add webkitscmpy dependency.
• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path): Handle case where the autoinstalled
directory is no the first in the Python path.

3:16 PM Changeset in webkit [266371] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS ] Tests expectations changed as test passing but expected to fail
​https://bugs.webkit.org/show_bug.cgi?id=215786

Unreviewed test gardening.

• platform/mac/TestExpectations: correction

3:04 PM Changeset in webkit [266370] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ Mac wk2 ] platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html
rdar://problem/66492801

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

2:18 PM Changeset in webkit [266369] by jeffm@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix after ​http://trac.webkit.org/changeset/266364/webkit.

• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:

Regenerated these files.

2:14 PM Changeset in webkit [266368] by Lauro Moura

• 5 edits in trunk/LayoutTests

[GLIB] Gardening some failures and flakies

Unreviewed test gardening.

• platform/glib/TestExpectations:
• platform/gtk-wayland/TestExpectations:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

1:25 PM Changeset in webkit [266367] by youenn@apple.com

• 4 edits in trunk/LayoutTests

Update imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https.html so that it no longer times out if first test fails
​https://bugs.webkit.org/show_bug.cgi?id=216009

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https.html:

Wrap internal asserts in first test in its own test wrapper.
Migrate all promise tests to simple synchronous tests.

LayoutTests:

• TestExpectations:

12:54 PM Changeset in webkit [266366] by Chris Dumez

• 4 edits in trunk/LayoutTests

Unreviewed, address flakiness of imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum.html

LayoutTests/imported/w3c:

• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt:

LayoutTests:

• TestExpectations:

12:37 PM Changeset in webkit [266365] by Karl Rackler

• 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=215909
Removed test expectations

Unreviewed test gardening.

• platform/wincairo/TestExpectations:

11:59 AM Changeset in webkit [266364] by commit-queue@webkit.org

• 13 edits
  3 adds in trunk/Source

Implement WEBGL_compressed_texture_s3tc_srgb extension
​https://bugs.webkit.org/show_bug.cgi?id=215973

Patch by James Darpinian <James Darpinian> on 2020-08-31
Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

• src/libANGLE/renderer/gl/formatutilsgl.cpp:

(rx::nativegl::ExtAndVersionOrExt):
(rx::nativegl::BuildInternalFormatInfoMap):

Source/WebCore:

Tested by webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html

• CMakeLists.txt:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

• html/canvas/WebGLCompressedTextureS3TCsRGB.cpp: Added.

(WebCore::WebGLCompressedTextureS3TCsRGB::WebGLCompressedTextureS3TCsRGB):
(WebCore::WebGLCompressedTextureS3TCsRGB::getName const):
(WebCore::WebGLCompressedTextureS3TCsRGB::supported):

• html/canvas/WebGLCompressedTextureS3TCsRGB.h: Added.
• html/canvas/WebGLCompressedTextureS3TCsRGB.idl: Added.
• html/canvas/WebGLExtension.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContextBase::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContextBase::validateCompressedTexSubDimensions):

• html/canvas/WebGLRenderingContextBase.h:
• platform/graphics/ExtensionsGL.h:

11:51 AM Changeset in webkit [266363] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

Wheel event region code is not fully disabled
​https://bugs.webkit.org/show_bug.cgi?id=216008
<rdar://problem/68086333>

Reviewed by Simon Fraser.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::maintainsEventRegion const):

Use the relevant ENABLE flag rather than !PLATFORM_IOS to compile out the code.

11:28 AM Changeset in webkit [266362] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

WebGL goes in a bad state where glContext.createProgram() returns null
​https://bugs.webkit.org/show_bug.cgi?id=215844

Patch by James Darpinian <James Darpinian> on 2020-08-31
Reviewed by Kenneth Russell.

Added test webgl/2.0.0/conformance/canvas/render-after-resize-test.html

• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::reshape):

11:23 AM Changeset in webkit [266361] by timothy_horton@apple.com

• 5 edits in trunk/Source/WebKit

Upstream support for image picker confirmation and downscaling
​https://bugs.webkit.org/show_bug.cgi?id=215997

Reviewed by Anders Carlsson.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showRunOpenPanel:frameInfo:resultListener:]):

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
(-[WKFileUploadPanel _configureImagePicker:]): Deleted.

11:16 AM Changeset in webkit [266360] by weinig@apple.com

• 103 edits in trunk/Source

Many settings in RuntimeEnabledSettings should autogenerated Settings: Part 1
​https://bugs.webkit.org/show_bug.cgi?id=215981

Reviewed by Darin Adler.

This moves an initial chunk of RuntimeEnabledSettings settings to Settings.yaml, focusing
on settings that don't require substantial refactoring or new features to work in Settings.yaml.
Source/WebCore:

The one "substantial" change to Settings generation was to switch the conditional key, to require
the complete conditional form (e.g. require ENABLE(FOO) rather than FOO), which matches
WebPreferences.yaml in WebKit, and is more versitile allowing non-ENABLE based conditionals.

• Modules/credentialmanagement/BasicCredential.idl:
• Modules/credentialmanagement/CredentialsContainer.idl:
• Modules/credentialmanagement/NavigatorCredentials.idl:
• Modules/encryptedmedia/MediaKeyMessageEvent.idl:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/MediaKeyStatusMap.idl:
• Modules/encryptedmedia/MediaKeySystemAccess.idl:
• Modules/encryptedmedia/MediaKeys.idl:
• Modules/encryptedmedia/NavigatorEME.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeySession.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeys.idl:
• Modules/gamepad/Gamepad.idl:
• Modules/gamepad/GamepadButton.idl:
• Modules/gamepad/GamepadEvent.idl:
• Modules/gamepad/NavigatorGamepad.idl:
• Modules/mediarecorder/BlobEvent.idl:
• Modules/mediarecorder/MediaRecorder.idl:
• Modules/mediarecorder/MediaRecorderErrorEvent.idl:
• Modules/mediastream/MediaDevices.idl:
• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::updateCaptureAccordingToMutedState):

• Modules/mediastream/NavigatorMediaDevices.idl:
• Modules/webauthn/AuthenticatorAssertionResponse.idl:
• Modules/webauthn/AuthenticatorAttestationResponse.idl:
• Modules/webauthn/AuthenticatorResponse.idl:
• Modules/webauthn/PublicKeyCredential.cpp:

(WebCore::PublicKeyCredential::isUserVerifyingPlatformAuthenticatorAvailable):

• Modules/webauthn/PublicKeyCredential.idl:
• Scripts/SettingsTemplates/InternalSettingsGenerated.cpp.erb:
• Scripts/SettingsTemplates/InternalSettingsGenerated.h.erb:
• Scripts/SettingsTemplates/Settings.cpp.erb:
• Scripts/SettingsTemplates/Settings.h.erb:
• WebCore.xcodeproj/project.pbxproj:
• css/DOMCSSCustomPropertyDescriptor.idl:
• css/DOMCSSRegisterCustomProperty.idl:
• dom/BeforeLoadEvent.idl:
• dom/CustomElementRegistry.idl:
• dom/DataTransfer.idl:
• dom/DataTransferItem.idl:
• dom/DataTransferItemList.idl:
• dom/Document.cpp:

(WebCore::createUpgradeCandidateElement):

• dom/Document.idl:
• dom/Element.idl:
• dom/InputEvent.idl:
• dom/Node.cpp:

(WebCore::Node::dispatchBeforeLoadEvent):

• dom/StaticRange.idl:
• editing/Editor.cpp:

(WebCore::Editor::registerCustomUndoStep):

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isSystemPreviewLink):
(WebCore::HTMLAnchorElement::parseAdClickAttribution const):
(WebCore::HTMLAnchorElement::handleClick):
(WebCore::HTMLAnchorElement::referrerPolicy const):

• html/HTMLAnchorElement.idl:
• html/HTMLAreaElement.idl:
• html/HTMLButtonElement.idl:
• html/HTMLFieldSetElement.idl:
• html/HTMLFormElement.idl:
• html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::referrerPolicy const):

• html/HTMLIFrameElement.idl:
• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::attributeChanged):
(WebCore::HTMLImageElement::isSystemPreviewImage const):
(WebCore::HTMLImageElement::referrerPolicy const):

• html/HTMLImageElement.idl:
• html/HTMLInputElement.idl:
• html/HTMLKeygenElement.idl:
• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::as const):
(WebCore::HTMLLinkElement::referrerPolicy const):

• html/HTMLLinkElement.idl:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateShouldContinueAfterNeedKey):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
(WebCore::HTMLMediaElement::webkitSetMediaKeys):
(WebCore::HTMLMediaElement::keyAdded):
(WebCore::HTMLMediaElement::mediaPlayerInitializationDataEncountered):

• html/HTMLMediaElement.idl:
• html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

• html/HTMLObjectElement.idl:
• html/HTMLOutputElement.idl:
• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::isSystemPreviewImage):

• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::referrerPolicy const):

• html/HTMLScriptElement.idl:
• html/HTMLSelectElement.idl:
• html/HTMLTextAreaElement.idl:
• html/LinkRelAttribute.cpp:

(WebCore::LinkRelAttribute::LinkRelAttribute):
(WebCore::LinkRelAttribute::isSupported):

• html/MediaEncryptedEvent.idl:
• html/WebKitMediaKeyError.idl:
• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::resourceType const):
(WebCore::TokenPreloadScanner::scan):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::resourceTypeFromAsAttribute):
(WebCore::createLinkPreloadResourceClient):
(WebCore::LinkLoader::isSupportedType):
(WebCore::LinkLoader::preloadIfNeeded):
(WebCore::LinkLoader::prefetchIfNeeded):

• loader/LinkLoader.h:
• page/DOMWindow.idl:
• page/IntersectionObserver.idl:
• page/IntersectionObserverEntry.idl:
• page/Navigator.cpp:

(WebCore::Navigator::canShare):
(WebCore::Navigator::share):

• page/Navigator.h:
• page/NavigatorShare.idl:
• page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::touchEventsEnabled const): Deleted.

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
(WebCore::RuntimeEnabledFeatures::setBlankAnchorTargetImpliesNoOpenerEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::blankAnchorTargetImpliesNoOpenerEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLinkPreloadEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::linkPreloadEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLinkPrefetchEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::linkPrefetchEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaPreloadingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaPreloadingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setInputEventsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::inputEventsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setInteractiveFormValidationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::interactiveFormValidationEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setCustomElementsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::customElementsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebShareEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webShareEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebAuthenticationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAuthenticationEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebAuthenticationLocalAuthenticatorEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAuthenticationLocalAuthenticatorEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setDisabledAdaptationsMetaTagEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::disabledAdaptationsMetaTagEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setCSSCustomPropertiesAndValuesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssCustomPropertiesAndValuesEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setSyntheticEditingCommandsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::syntheticEditingCommandsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaRecorderEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaRecorderEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaDevicesEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaDevicesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaStreamEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::screenCaptureEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setScreenCaptureEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::gamepadsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setDownloadAttributeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::downloadAttributeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setIntersectionObserverEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::intersectionObserverEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setUndoManagerAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::undoManagerAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setEncryptedMediaAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::encryptedMediaAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLegacyEncryptedMediaAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::legacyEncryptedMediaAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setSystemPreviewEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::systemPreviewEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLegacyBeforeLoadEventEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::legacyBeforeLoadEventEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::adClickAttributionEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setAdClickAttributionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setTouchEventsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::referrerPolicyAttributeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setReferrerPolicyAttributeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::interruptAudioOnPageVisibilityChangeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setInterruptAudioOnPageVisibilityChangeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::linkPreloadResponsiveImagesEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLinkPreloadResponsiveImagesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setLazyImageLoadingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::lazyImageLoadingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setIsInAppBrowserPrivacyEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::isInAppBrowserPrivacyEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setNeedsInAppBrowserPrivacyQuirks): Deleted.
(WebCore::RuntimeEnabledFeatures::needsInAppBrowserPrivacyQuirks const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebShareFileAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webShareFileAPIEnabled const): Deleted.

• page/Settings.yaml:
• page/UndoItem.idl:
• page/UndoManager.idl:
• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setScreenCaptureEnabled): Deleted.

• testing/InternalSettings.h:
• testing/InternalSettings.idl:
• testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setShouldInterruptAudioOnPageVisibilityChange):
(WebCore::Internals::addPrefetchLoadEventListener):

Source/WebKit:

In WebKit, this means mostly removing now unnecessary use of the webcoreBinding key in
WebPreferences.yaml and removing now superfluous cases in InjectedBundle::overrideBoolPreferenceForTestRunner.

• Shared/WebPreferences.yaml:

Removing now unnecessary use of the webcoreBinding key and fix indentation of a few cases.

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Remove now superfluous cases, as each boolean Settings based setting gets handled automatically.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Remove explicit setting of setInteractiveFormValidationEnabled now that we don't have the
RuntimeEnabledSettings variant being set by the generator.

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Update changed settings to use Settings rather than RuntimeEnabledSettings.

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::notifyPreferencesChanged):
Update changed settings to use Settings rather than RuntimeEnabledSettings.

10:43 AM Changeset in webkit [266359] by ysuzuki@apple.com

• 21 edits in trunk/Source/JavaScriptCore

[JSC] StructureStubInfo / CallLinkInfo / ByValInfo should set CodeOrigin or BytecodeIndex at construction
​https://bugs.webkit.org/show_bug.cgi?id=215987
<rdar://problem/66370323>

Reviewed by Mark Lam.

We had race condition during construction of StructureStubInfo and CodeOrigin field setting.

1. The thread creates StructureStubInfo by calling CodeBlock::addStubInfo. This is guarded by the lock. But at this point we are not setting StructureStubInfo::codeOrigin.
2. Then (1)'s thread attempts to set StructureStubInfo::codeOrigin. But at this point, it is not guarded by the lock.
3. Before (2) is executed, DFG ByteCodeParser calls CodeBlock::getICStatusMap. It creates HashMap<CodeOrigin, StructureStubInfo*>.
4. Since StructureStubInfo*'s codeOrigin is not configured yet, (3) sees invalid CodeOrigin. And storing invalid CodeOrigin as a HashMap key is not correct.

We should configure CodeOrigin at construction of StructureStubInfo, which is guarded by the lock. We have the same problem for CallLinkInfo and ByValInfo. This patch fixes them.
To reproduce this, we need to execute a script 2~ days repeatedly. So it is difficult to add a test.

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

• bytecode/ByValInfo.h:

(JSC::ByValInfo::ByValInfo):
(JSC::ByValInfo::setUp):

• bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::CallLinkInfo):

• bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::setUpCall):
(JSC::CallLinkInfo::setCodeOrigin): Deleted.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::addStubInfo):
(JSC::CodeBlock::addByValInfo):
(JSC::CodeBlock::addCallLinkInfo):

• bytecode/CodeBlock.h:
• bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::StructureStubInfo):

• bytecode/StructureStubInfo.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileDirectCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):

• jit/JIT.cpp:

(JSC::JIT::link):

• jit/JITCall.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):

• jit/JITInlineCacheGenerator.cpp:

(JSC::garbageStubInfo):
(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_has_indexed_property):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_has_indexed_property):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):

• wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

10:22 AM Changeset in webkit [266358] by Hector Lopez

• 56 edits in trunk

Unreviewed, reverting r266350.

Revision is causing a constant crash on both macOS and iOS

Reverted changeset:

"Convert runtime flag to setting for lazy image loading"
​https://bugs.webkit.org/show_bug.cgi?id=215610
​https://trac.webkit.org/changeset/266350

9:56 AM Changeset in webkit [266357] by stephan.szabo@sony.com

• 2 edits in trunk

[PlayStation] Build fix for intermittent copy errors
​https://bugs.webkit.org/show_bug.cgi?id=215951

Reviewed by Ross Kirsling.

• Source/cmake/OptionsPlayStation.cmake:

When copying platform specific files into the binary
directory post build on executable targets, we'd
intermittently get copy errors in parallel builds.

9:47 AM Changeset in webkit [266356] by jh718.park@samsung.com

• 3 edits
  80 copies
  22 adds
  1 delete in trunk/LayoutTests

Import css-conditional tests.
​https://bugs.webkit.org/show_bug.cgi?id=216000

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/css/conditional/LICENSE: Renamed from LayoutTests/css3/conditional/w3c/LICENSE.
• web-platform-tests/css/conditional/META.yml: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-001-expected.html: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-001.html: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-002-expected.html: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-002.html: Added.
• web-platform-tests/css/conditional/at-supports-001-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-001.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-001.html.
• web-platform-tests/css/conditional/at-supports-002-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-002.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-002.html.
• web-platform-tests/css/conditional/at-supports-003-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-003.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-003.html.
• web-platform-tests/css/conditional/at-supports-004-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-004.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-004.html.
• web-platform-tests/css/conditional/at-supports-005-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-005.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-005.html.
• web-platform-tests/css/conditional/at-supports-006-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-006.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-006.html.
• web-platform-tests/css/conditional/at-supports-007-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-007.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-007.html.
• web-platform-tests/css/conditional/at-supports-008-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-008.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-008.html.
• web-platform-tests/css/conditional/at-supports-009-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-009.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-009.html.
• web-platform-tests/css/conditional/at-supports-010-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-010.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-010.html.
• web-platform-tests/css/conditional/at-supports-011-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-011.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-011.html.
• web-platform-tests/css/conditional/at-supports-012-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-012.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-012.html.
• web-platform-tests/css/conditional/at-supports-013-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-013.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-013.html.
• web-platform-tests/css/conditional/at-supports-014-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-014.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-014.html.
• web-platform-tests/css/conditional/at-supports-015-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-015.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-015.html.
• web-platform-tests/css/conditional/at-supports-016-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-016.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-016.html.
• web-platform-tests/css/conditional/at-supports-017-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-017.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-017.html.
• web-platform-tests/css/conditional/at-supports-018-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-018.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-018.html.
• web-platform-tests/css/conditional/at-supports-019-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-019.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-019.html.
• web-platform-tests/css/conditional/at-supports-020-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-020.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-020.html.
• web-platform-tests/css/conditional/at-supports-021-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-021.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-021.html.
• web-platform-tests/css/conditional/at-supports-022-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-022.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-022.html.
• web-platform-tests/css/conditional/at-supports-023-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-023.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-023.html.
• web-platform-tests/css/conditional/at-supports-024-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-024.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-024.html.
• web-platform-tests/css/conditional/at-supports-025-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-025.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-025.html.
• web-platform-tests/css/conditional/at-supports-026-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-026.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-026.html.
• web-platform-tests/css/conditional/at-supports-027-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-027.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-027.html.
• web-platform-tests/css/conditional/at-supports-028-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-028.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-028.html.
• web-platform-tests/css/conditional/at-supports-029-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-029.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-029.html.
• web-platform-tests/css/conditional/at-supports-030-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-030.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-030.html.
• web-platform-tests/css/conditional/at-supports-031-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-031.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-031.html.
• web-platform-tests/css/conditional/at-supports-032-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-032.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-032.html.
• web-platform-tests/css/conditional/at-supports-033-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-033.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-033.html.
• web-platform-tests/css/conditional/at-supports-034-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-034.html: Added.
• web-platform-tests/css/conditional/at-supports-035-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-035.html: Added.
• web-platform-tests/css/conditional/at-supports-036-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-036.html: Added.
• web-platform-tests/css/conditional/at-supports-037-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-037.html: Added.
• web-platform-tests/css/conditional/at-supports-038-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-038.html: Added.
• web-platform-tests/css/conditional/at-supports-039-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-039.html: Added.
• web-platform-tests/css/conditional/at-supports-040-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-040.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-040.html.
• web-platform-tests/css/conditional/at-supports-041-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-041.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-041.html.
• web-platform-tests/css/conditional/at-supports-042-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-042.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-042.html.
• web-platform-tests/css/conditional/at-supports-043-expected.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-043.html: Added.
• web-platform-tests/css/conditional/idlharness-expected.txt: Added.
• web-platform-tests/css/conditional/idlharness.html: Added.
• web-platform-tests/css/conditional/js/001-expected.txt: Added.
• web-platform-tests/css/conditional/js/001.html: Added.
• web-platform-tests/css/conditional/reference/background-lime.html: Added.
• web-platform-tests/css/conditional/test_group_insertRule-expected.txt: Added.
• web-platform-tests/css/conditional/test_group_insertRule.html: Added.

LayoutTests:

• TestExpectations:
• css3/conditional/w3c/at-supports-001-expected.html: Removed.
• css3/conditional/w3c/at-supports-002-expected.html: Removed.
• css3/conditional/w3c/at-supports-003-expected.html: Removed.
• css3/conditional/w3c/at-supports-004-expected.html: Removed.
• css3/conditional/w3c/at-supports-005-expected.html: Removed.
• css3/conditional/w3c/at-supports-006-expected.html: Removed.
• css3/conditional/w3c/at-supports-007-expected.html: Removed.
• css3/conditional/w3c/at-supports-008-expected.html: Removed.
• css3/conditional/w3c/at-supports-009-expected.html: Removed.
• css3/conditional/w3c/at-supports-010-expected.html: Removed.
• css3/conditional/w3c/at-supports-011-expected.html: Removed.
• css3/conditional/w3c/at-supports-012-expected.html: Removed.
• css3/conditional/w3c/at-supports-013-expected.html: Removed.
• css3/conditional/w3c/at-supports-014-expected.html: Removed.
• css3/conditional/w3c/at-supports-015-expected.html: Removed.
• css3/conditional/w3c/at-supports-016-expected.html: Removed.
• css3/conditional/w3c/at-supports-017-expected.html: Removed.
• css3/conditional/w3c/at-supports-018-expected.html: Removed.
• css3/conditional/w3c/at-supports-019-expected.html: Removed.
• css3/conditional/w3c/at-supports-020-expected.html: Removed.
• css3/conditional/w3c/at-supports-021-expected.html: Removed.
• css3/conditional/w3c/at-supports-022-expected.html: Removed.
• css3/conditional/w3c/at-supports-023-expected.html: Removed.
• css3/conditional/w3c/at-supports-024-expected.html: Removed.
• css3/conditional/w3c/at-supports-025-expected.html: Removed.
• css3/conditional/w3c/at-supports-026-expected.html: Removed.
• css3/conditional/w3c/at-supports-027-expected.html: Removed.
• css3/conditional/w3c/at-supports-028-expected.html: Removed.
• css3/conditional/w3c/at-supports-029-expected.html: Removed.
• css3/conditional/w3c/at-supports-030-expected.html: Removed.
• css3/conditional/w3c/at-supports-031-expected.html: Removed.
• css3/conditional/w3c/at-supports-032-expected.html: Removed.
• css3/conditional/w3c/at-supports-033-expected.html: Removed.
• css3/conditional/w3c/at-supports-040-expected.html: Removed.
• css3/conditional/w3c/at-supports-042-expected.html: Removed.

9:13 AM Changeset in webkit [266355] by weinig@apple.com

• 4 edits in trunk/Source/WebCore

DeprecatedGlobalSettings::globalConstRedeclarationShouldThrow() is not actually a setting, so should not be in DeprecatedGlobalSettings
​https://bugs.webkit.org/show_bug.cgi?id=215978

Reviewed by Darin Adler.

Move behavior quirk defined by DeprecatedGlobalSettings::globalConstRedeclarationShouldThrow() to its
only call site in CommonVM.cpp

• bindings/js/CommonVM.cpp:

(WebCore::globalConstRedeclarationShouldThrow):
(WebCore::commonVMSlow):

• page/DeprecatedGlobalSettings.cpp:

(WebCore::DeprecatedGlobalSettings::globalConstRedeclarationShouldThrow): Deleted.

• page/DeprecatedGlobalSettings.h:

8:51 AM Changeset in webkit [266354] by achristensen@apple.com

• 20 edits
  1 add in trunk

Make Big5 encoder conform to the specification and behavior of Chrome and Firefox
​https://bugs.webkit.org/show_bug.cgi?id=215983

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/big5-encoder-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-cn-big5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-csbig5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-pua-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-x-x-big5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-expected.txt:

Source/WebCore:

Covered by web platform tests.

• platform/text/EncodingTables.cpp:
• platform/text/EncodingTables.h:
• platform/text/TextCodecICU.cpp:

(WebCore::eucJPEncode):
(WebCore::big5Encode):
(WebCore::uncheckedAppendDecimal):
(WebCore::urlEncodedEntityUnencodableHandler):
(WebCore::entityUnencodableHandler):
(WebCore::questionMarkUnencodableHandler):
(WebCore::Function<void):
(WebCore::TextCodecICU::encode):

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/URLParser.cpp:

(WTF::CodePointIterator::CodePointIterator): Deleted.
(WTF::CodePointIterator::operator== const): Deleted.
(WTF::CodePointIterator::operator!= const): Deleted.
(WTF::CodePointIterator::atEnd const): Deleted.
(WTF::CodePointIterator::codeUnitsSince const): Deleted.
(WTF::CodePointIterator<LChar>::operator const): Deleted.
(WTF::CodePointIterator<LChar>::operator): Deleted.
(WTF::CodePointIterator<UChar>::operator const): Deleted.
(WTF::CodePointIterator<UChar>::operator): Deleted.

• wtf/text/CodePointIterator.h: Added.

(WTF::CodePointIterator::CodePointIterator):
(WTF::CodePointIterator::operator== const):
(WTF::CodePointIterator::operator!= const):
(WTF::CodePointIterator::atEnd const):
(WTF::CodePointIterator::codeUnitsSince const):
(WTF::CodePointIterator<LChar>::operator const):
(WTF::CodePointIterator<LChar>::operator):
(WTF::CodePointIterator<UChar>::operator const):
(WTF::CodePointIterator<UChar>::operator):

8:14 AM Changeset in webkit [266353] by Wenson Hsieh

• 4 edits in trunk/Source/WebCore

Optimize the implementation of TransformationMatrix::rotate(double)
​https://bugs.webkit.org/show_bug.cgi?id=215994

Reviewed by Tim Horton.

TransformationMatrix::rotate(angle) currently just calls TransformationMatrix::rotate3d(0, 0, 1, angle), which
has a fast path for the case where we're rotating about the z-axis. However, we can make this *slightly* faster
by omitting the hypotenuse computation, several floating point comparisons, and several assignments in this case
because we already know that we're just rotating about the z-axis.

This is a small (but measurable) improvement on the Multiply subtest of MotionMark, which applies a little over
3 million rotation transformations over the course of 30 seconds.

• platform/graphics/transforms/RotateTransformOperation.h:

Instead of calling rotate3d, just have rotate directly call multiply with the following
TransformationMatrix:
`
[[ cos(z) sin(z) 0 0 ]

[ -sin(z) cos(z) 0 0 ]
[ 0 0 1 0 ]
[ 0 0 0 1 ]]

`
...where z is the angle of rotation, in radians.

• platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::rotate):

• platform/graphics/transforms/TransformationMatrix.h:

(WebCore::TransformationMatrix::rotate): Deleted.

8:12 AM Changeset in webkit [266352] by Karl Rackler

• 1 edit
  4 adds in trunk/LayoutTests

Windows baselines after r266228 and r266273.
Add wincairo

Unreviewed test gardening.

• platform/wincairo/streams/reference-implementation/transform-stream-errors-expected.txt: Added.
• platform/wincairo/streams/reference-implementation/transform-stream-expected.txt: Added.

7:25 AM Changeset in webkit [266351] by Aditya Keerthi

• 20 edits
  14 adds in trunk

[macOS] Date inputs should contain editable components
​https://bugs.webkit.org/show_bug.cgi?id=215155

Reviewed by Devin Rousso.

Source/WebCore:

Currently, users are unable to edit the values in date and time input types.
To match system date controls, users should be able to select and edit
individual components of the input. For example, <input type="date"> should
contain an editable year, month, and day control.

Note that this functionality was present in WebKit, up until it was removed
in r150876. Previously known as "INPUT_MULTIPLE_FIELDS_UI", the feature was
removed as it was only used by Chromium port. However, much of the removed
logic remains useful and is resurfaced in this patch. Modifications were made
to update the code to follow current WebKit practices.

DateTimeEditElement is a wrapper element that contains individual fields.
The fields are all DateTimeFieldElements. Note that DateTimeFieldElements
are further specialized into DateTimeNumericFieldElement (for integral
values) and DateTimeSymbolicFieldElement (for symbolic values such as A.M
and P.M). DateTimeEditElement builds the control using the visitor pattern
and existing parsing logic contained in DateTimeFormat.

In order to reduce the patch size, this patch only sets up the rendering
and layout of multiple fields for <input type="date">. Upcoming patches will
add rendering for other date/time input types and introduce editability.

Test: fast/forms/date/date-pseudo-elements.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/html.css:

(input::-webkit-datetime-edit):
(input::-webkit-datetime-edit-fields-wrapper):
(input::-webkit-datetime-edit-year-field,):
(input::-webkit-datetime-edit-year-field:focus,):
(input::-webkit-datetime-edit-text):

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::DateTimeFormatValidator::visitField):
(WebCore::DateTimeFormatValidator::validateFormat):
(WebCore::BaseChooserOnlyDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseChooserOnlyDateAndTimeInputType::destroyShadowSubtree):
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
(WebCore::BaseChooserOnlyDateAndTimeInputType::valueForEditControl const):
(WebCore::BaseChooserOnlyDateAndTimeInputType::localeIdentifier const):

• html/BaseChooserOnlyDateAndTimeInputType.h:
• html/BaseDateAndTimeInputType.h:
• html/DateInputType.cpp:

(WebCore::DateInputType::isValidFormat const):
(WebCore::DateInputType::setupLayoutParameters const):

• html/DateInputType.h:
• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::isValidFormat const):
(WebCore::DateTimeLocalInputType::setupLayoutParameters const):

• html/DateTimeLocalInputType.h:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::isValidFormat const):
(WebCore::MonthInputType::setupLayoutParameters const):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::isValidFormat const):
(WebCore::TimeInputType::setupLayoutParameters const):

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::isValidFormat const):
(WebCore::WeekInputType::setupLayoutParameters const):

• html/WeekInputType.h:
• html/shadow/DateTimeEditElement.cpp: Added.

(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::build):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):
(WebCore::DateTimeEditElement::fieldsWrapperElement const):
(WebCore::DateTimeEditElement::addField):
(WebCore::DateTimeEditElement::create):
(WebCore::DateTimeEditElement::layout):
(WebCore::DateTimeEditElement::localeIdentifier const):
(WebCore::DateTimeEditElement::resetFields):
(WebCore::DateTimeEditElement::setValueAsDate):
(WebCore::DateTimeEditElement::setEmptyValue):
(WebCore::DateTimeEditElement::value const):

• html/shadow/DateTimeEditElement.h: Added.
• html/shadow/DateTimeFieldElement.cpp: Added.

(WebCore::DateTimeFieldElement::DateTimeFieldElement):
(WebCore::DateTimeFieldElement::initialize):
(WebCore::DateTimeFieldElement::localeForOwner const):
(WebCore::DateTimeFieldElement::localeIdentifier const):
(WebCore::DateTimeFieldElement::updateVisibleValue):
(WebCore::DateTimeFieldElement::supportsFocus const):

• html/shadow/DateTimeFieldElement.h: Added.
• html/shadow/DateTimeFieldElements.cpp: Added.

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeDayFieldElement::setValueAsDate):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeMonthFieldElement::setValueAsDate):
(WebCore::DateTimeSymbolicMonthFieldElement::DateTimeSymbolicMonthFieldElement):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::setValueAsDate):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
(WebCore::DateTimeYearFieldElement::create):
(WebCore::DateTimeYearFieldElement::setValueAsDate):

• html/shadow/DateTimeFieldElements.h: Added.
• html/shadow/DateTimeNumericFieldElement.cpp: Added.

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue const):
(WebCore::DateTimeNumericFieldElement::hasValue const):
(WebCore::DateTimeNumericFieldElement::initialize):
(WebCore::DateTimeNumericFieldElement::setEmptyValue):
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::value const):
(WebCore::DateTimeNumericFieldElement::valueAsInteger const):
(WebCore::DateTimeNumericFieldElement::visibleValue const):

• html/shadow/DateTimeNumericFieldElement.h: Added.
• html/shadow/DateTimeSymbolicFieldElement.cpp: Added.

(WebCore::makeVisibleEmptyValue):
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
(WebCore::DateTimeSymbolicFieldElement::hasValue const):
(WebCore::DateTimeSymbolicFieldElement::initialize):
(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
(WebCore::DateTimeSymbolicFieldElement::setValueAsInteger):
(WebCore::DateTimeSymbolicFieldElement::value const):
(WebCore::DateTimeSymbolicFieldElement::valueAsInteger const):
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue const):
(WebCore::DateTimeSymbolicFieldElement::visibleValue const):

• html/shadow/DateTimeSymbolicFieldElement.h: Added.

(WebCore::DateTimeSymbolicFieldElement::symbolsSize const):

LayoutTests:

Added a test to verify styling of pseudo elements within date inputs.
Rebaselined existing tests to match new appearance.

• fast/forms/date/date-pseudo-elements-expected.txt: Added.
• fast/forms/date/date-pseudo-elements.html: Added.
• platform/mac-wk2/fast/forms/date/date-input-rendering-basic-expected.txt:
• platform/mac-wk2/fast/forms/date/date-pseudo-elements-expected.txt: Added.
• platform/mac-wk2/fast/forms/time/time-appearance-basic-expected.txt: Added.
• platform/mac-wk2/fast/forms/time/time-input-rendering-basic-expected.txt:

4:51 AM Changeset in webkit [266350] by commit-queue@webkit.org

• 56 edits in trunk

Convert runtime flag to setting for lazy image loading
​https://bugs.webkit.org/show_bug.cgi?id=215610

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-31
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Remove changes done to the lazy image loading tests as we enable the setting in testharnessreport.js.
The new expected results are improvements.

• web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html:

Source/WebCore:

Convert runtime flag to setting for lazy image loading.

• html/HTMLImageElement.idl:
• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setLazyImageLoadingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::lazyImageLoadingEnabled const): Deleted.

• page/Settings.yaml:

Source/WebKit:

Remove lazy image loading runtime flag.

• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLazyImageLoadingEnabled): Deleted.
(WKPreferencesGetLazyImageLoadingEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Remove lazy image loading runtime flag.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Enable lazy image loading setting in resources/testharnessreport.js. Update test expectations
and adjust the tests in http/tests/lazyload/ to enable the setting. Fow WK1 list more tests
that should be skipped.

• TestExpectations:
• http/tests/lazyload/attribute.html:
• http/tests/lazyload/js-image.html:
• http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html:
• http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html:
• http/tests/lazyload/lazy.html:
• platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk1/TestExpectations:
• platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• resources/testharnessreport.js:

2:45 AM Changeset in webkit [266349] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak] SDK branch upgrade path is broken
​https://bugs.webkit.org/show_bug.cgi?id=215927

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-08-31
Reviewed by Adrian Perez de Castro.

The development environment (flatpak install) needs to be performed before attempting to
rebuild toolchain archives. In most cases this wasn't an issue, but when the SDK needs to be
upgraded to a new ABI/branch, the previous version needs to be removed, that triggers a new
flatpak install and toolchain archives update, which need then to be done in the right
order.

• flatpak/flatpakutils.py:

(WebkitFlatpak.main):

2:01 AM Changeset in webkit [266348] by youenn@apple.com

• 35 edits
  5 adds in trunk

Add support for TextDecoderStream
​https://bugs.webkit.org/show_bug.cgi?id=215919

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/streams/backpressure.any-expected.txt:
• web-platform-tests/encoding/streams/backpressure.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-attributes.any-expected.txt:
• web-platform-tests/encoding/streams/decode-attributes.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-bad-chunks.any-expected.txt:
• web-platform-tests/encoding/streams/decode-bad-chunks.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-ignore-bom.any-expected.txt:
• web-platform-tests/encoding/streams/decode-ignore-bom.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-incomplete-input.any-expected.txt:
• web-platform-tests/encoding/streams/decode-incomplete-input.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-non-utf8.any-expected.txt:
• web-platform-tests/encoding/streams/decode-non-utf8.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-split-character.any-expected.txt:
• web-platform-tests/encoding/streams/decode-split-character.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-utf8.any-expected.txt:
• web-platform-tests/encoding/streams/decode-utf8.any.worker-expected.txt:
• web-platform-tests/encoding/streams/encode-bad-chunks.any-expected.txt:
• web-platform-tests/encoding/streams/encode-bad-chunks.any.worker-expected.txt:
• web-platform-tests/encoding/streams/readable-writable-properties.any-expected.txt:
• web-platform-tests/encoding/streams/readable-writable-properties.any.worker-expected.txt:
• web-platform-tests/encoding/streams/realms.window-expected.txt:

Source/WebCore:

Implement TextEncoderStream as a JS built-in.
It is enabled by transform stream runtime flag.

TextDecoderStream takes a TransformStream and TextDecoderStreamEncoder as private slots.
Add TextDecoderStreamEncoder to implement the actual UTF-8 encoding steps, as a wrapper around TextDecoder.

Covered by rebased tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• dom/TextDecoderStream.idl: Added.
• dom/TextDecoderStream.js: Added.

(initializeTextDecoderStream):
(getter.encoding):
(getter.fatal):
(getter.ignoreBOM):
(getter.readable):
(getter.writable):

• dom/TextDecoderStreamDecoder.cpp: Added.

(WebCore::TextDecoderStreamDecoder::create):
(WebCore::TextDecoderStreamDecoder::TextDecoderStreamDecoder):
(WebCore::TextDecoderStreamDecoder::decode):
(WebCore::TextDecoderStreamDecoder::flush):

• dom/TextDecoderStreamDecoder.h: Added.

(WebCore::TextDecoderStreamDecoder::encoding const):

• dom/TextDecoderStreamDecoder.idl: Added.

LayoutTests:

• TestExpectations:

Unskipping encoding tests except legacy-* tests which are big and slow.

1:58 AM Changeset in webkit [266347] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

[Cocoa] Disable sniffing for WebSocket handshakes
​https://bugs.webkit.org/show_bug.cgi?id=215932

Reviewed by Darin Adler.

Covered by http/tests/websocket/tests/hybi/handshake-error.html no longer timing out with NSURLSession WebSocket code path.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::createWebSocketTask):

12:23 AM Changeset in webkit [266346] by ysuzuki@apple.com

• 5 edits in trunk

[JSC] @defaultPromiseThen fast path should check species constructor
​https://bugs.webkit.org/show_bug.cgi?id=215996

Reviewed by Ross Kirsling.

JSTests:

• test262/expectations.yaml:

Source/JavaScriptCore:

When executing @defaultPromiseThen fast path, we assumed that this execution is not observable.
This is wrong only for species constructor part: this @@species access & derived constructor calls
can be observable. In this patch,

1. We extract part of Promise#then as @performPromiseThen, which corresponds to the spec's PerformPromiseThen.
2. In promise fast path, we check @speciesConstructor is @Promise or @InternalPromise. If it is not, then we go to the slow path.

This fixes Promise#finally failures in test262.

• builtins/PromiseOperations.js:

(globalPrivate.promiseResolveThenableJobFast):
(globalPrivate.promiseResolveThenableJobWithoutPromiseFast):
(globalPrivate.promiseResolveThenableJobWithDerivedPromise):
(onFulfilled):
(onRejected):
(globalPrivate.performPromiseThen):

• builtins/PromisePrototype.js:

(then):
(onFulfilled): Deleted.
(onRejected): Deleted.

Aug 30, 2020:

10:18 PM Changeset in webkit [266345] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKitLegacy/mac

Remove an unused addition point

• WebCoreSupport/WebFrameLoaderClient.mm:

9:51 PM Changeset in webkit [266344] by Wenson Hsieh

• 9 edits in trunk/Source/WebCore

Make StyleRareNonInheritedData::mask and StyleBackgroundData::background DataRefs
​https://bugs.webkit.org/show_bug.cgi?id=215942

Reviewed by Darin Adler.

A significant amount of time in MotionMark's Multiply subtest is spent underneath the copy constructor
StyleRareNonInheritedData, and a significant amount of time underneath this copy constructor is spent copying
the rare non-inherited data's mask (a FillLayer).

This FillLayer is currently inline data in StyleRareNonInheritedData; to reduce the cost of copying rare
non-inherited data, we can instead make this a DataRef<FillLayer>, such that copying rare data will only copy
the reference to the FillLayer rather than the FillLayer itself.

Upon mutating the FillLayer, we now use DataRef::access() to ensure that these FillLayers are copied
before writing. See below for more details.

• css/makeprop.pl:

(generateFillLayerPropertyInheritValueSetter):
(generateFillLayerPropertyValueSetter):

• rendering/style/FillLayer.cpp:

(WebCore::FillLayer::create):
(WebCore::FillLayer::FillLayer):

Deeply copy the FillLayer's linked list of FillLayers. This preserves existing behavior, which currently
uses std::unique_ptr to store the pointer to the next FillLayer (and therefore, requires a deep copy of the
linked list when copying FillLayer).

In a future patch, we could probably further optimize this as well to behave in a copy-on-write way, by turning
the RefPtr<FillLayer> m_next; into an Optional<DataRef<FillLayer>> instead (and then use access() to copy
the next FillLayer prior to writing).

(WebCore::FillLayer::~FillLayer):
(WebCore::FillLayer::operator=):

• rendering/style/FillLayer.h:

Make FillLayer ref-counted, and introduce new create methods for constructing FillLayers. Use these
methods in several places where we currently call the constructors directly, via makeUnique.

(WebCore::FillLayer::copy const):
(WebCore::FillLayer::setNext):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::hasBackgroundImage const):
(WebCore::RenderStyle::hasFixedBackgroundImage const):
(WebCore::RenderStyle::backgroundRepeatX const):
(WebCore::RenderStyle::backgroundRepeatY const):
(WebCore::RenderStyle::backgroundComposite const):
(WebCore::RenderStyle::backgroundAttachment const):
(WebCore::RenderStyle::backgroundClip const):
(WebCore::RenderStyle::backgroundOrigin const):
(WebCore::RenderStyle::backgroundXPosition const):
(WebCore::RenderStyle::backgroundYPosition const):
(WebCore::RenderStyle::backgroundSizeType const):
(WebCore::RenderStyle::backgroundSizeLength const):
(WebCore::RenderStyle::ensureBackgroundLayers):
(WebCore::RenderStyle::maskImage const):
(WebCore::RenderStyle::maskRepeatX const):
(WebCore::RenderStyle::maskRepeatY const):
(WebCore::RenderStyle::maskComposite const):
(WebCore::RenderStyle::maskClip const):
(WebCore::RenderStyle::maskOrigin const):
(WebCore::RenderStyle::maskXPosition const):
(WebCore::RenderStyle::maskYPosition const):
(WebCore::RenderStyle::maskSizeType const):
(WebCore::RenderStyle::maskSizeLength const):
(WebCore::RenderStyle::ensureMaskLayers):
(WebCore::RenderStyle::hasMask const):
(WebCore::RenderStyle::setBackgroundXPosition):
(WebCore::RenderStyle::setBackgroundYPosition):
(WebCore::RenderStyle::setBackgroundSize):
(WebCore::RenderStyle::setBackgroundSizeLength):
(WebCore::RenderStyle::clearBackgroundLayers):
(WebCore::RenderStyle::inheritBackgroundLayers):
(WebCore::RenderStyle::clearMaskLayers):
(WebCore::RenderStyle::inheritMaskLayers):
(WebCore::RenderStyle::setMaskImage):
(WebCore::RenderStyle::setMaskXPosition):
(WebCore::RenderStyle::setMaskYPosition):
(WebCore::RenderStyle::setMaskSize):

• rendering/style/StyleBackgroundData.cpp:

(WebCore::StyleBackgroundData::StyleBackgroundData):
(WebCore::StyleBackgroundData::dump const):

• rendering/style/StyleBackgroundData.h:

Since FillLayer is now ref-counted, StyleBackgroundData::background needs to be a DataRef as well.

• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

• rendering/style/StyleRareNonInheritedData.h:

9:37 PM Changeset in webkit [266343] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WPE] Gardening some webdriver failures

Unreviewed test gardening.

• TestExpectations.json:

8:26 PM Changeset in webkit [266342] by timothy_horton@apple.com

• 85 edits
  17 deletes in trunk

Remove unused editable image code
​https://bugs.webkit.org/show_bug.cgi?id=215991

Reviewed by Simon Fraser.

Source/WebCore:

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• editing/EditAction.cpp:

(WebCore::undoRedoLabel):

• editing/EditAction.h:
• editing/Editor.cpp:

(WebCore::Editor::insertEditableImage): Deleted.

• editing/Editor.h:
• editing/EditorCommand.cpp:

(WebCore::createCommandMap):
(WebCore::executeInsertEditableImage): Deleted.
(WebCore::enabledInRichlyEditableTextWithEditableImagesEnabled): Deleted.

• editing/InsertEditableImageCommand.cpp: Removed.
• editing/InsertEditableImageCommand.h: Removed.
• en.lproj/Localizable.strings:
• html/HTMLAttributeNames.in:
• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::insertedIntoAncestor):
(WebCore::HTMLImageElement::removedFromAncestor):
(WebCore::HTMLImageElement::copyNonAttributePropertiesFromElement):
(WebCore::HTMLImageElement::supportsFocus const): Deleted.
(WebCore::HTMLImageElement::isFocusable const): Deleted.
(WebCore::HTMLImageElement::didFinishInsertingNode): Deleted.
(WebCore::HTMLImageElement::hasEditableImageAttribute const): Deleted.
(WebCore::HTMLImageElement::editableImageViewID const): Deleted.
(WebCore::HTMLImageElement::updateEditableImage): Deleted.
(WebCore::HTMLImageElement::defaultEventHandler): Deleted.

• html/HTMLImageElement.h:
• page/ChromeClient.h:

(WebCore::ChromeClient::associateEditableImageWithAttachment): Deleted.
(WebCore::ChromeClient::didCreateEditableImage): Deleted.
(WebCore::ChromeClient::didDestroyEditableImage): Deleted.

• page/EditableImageReference.cpp: Removed.
• page/EditableImageReference.h: Removed.
• page/Settings.yaml:
• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::nextEmbeddedViewID): Deleted.

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setContentsToSolidColor):
(WebCore::GraphicsLayer::setContentsToEmbeddedView): Deleted.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createPlatformCALayerForEmbeddedView): Deleted.
(WebCore::GraphicsLayerCA::setContentsToEmbeddedView): Deleted.

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::operator<<):

• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::embeddedViewID const): Deleted.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::isEditableImage const): Deleted.
(WebCore::RenderImage::requiresLayer const): Deleted.

• rendering/RenderImage.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly const):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::requiresCompositingForEditableImage const): Deleted.

• rendering/RenderLayerCompositor.h:

Source/WebKit:

• DerivedSources.make:
• Platform/spi/ios/PencilKitSPI.h: Removed.
• Shared/FocusedElementInformation.cpp:

(WebKit::FocusedElementInformation::encode const):
(WebKit::FocusedElementInformation::decode):

• Shared/FocusedElementInformation.h:
• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):

• Shared/WebPreferences.yaml:
• SourcesCocoa.txt:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setupPageConfiguration:]):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setEditableImagesEnabled:]): Deleted.
(-[WKWebViewConfiguration _editableImagesEnabled]): Deleted.

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
• UIProcess/API/ios/WKWebViewIOS.h:
• UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _setupScrollAndContentViews]):
(-[WKWebView _stylusTapGestureShouldCreateEditableImage]): Deleted.

• UIProcess/PageClient.h:

(WebKit::PageClient::createDrawingView): Deleted.

• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::clearLayers):
(WebKit::RemoteLayerTreeHost::makeNode):

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::makeNode):
(WebKit::RemoteLayerTreeHost::createEmbeddedView): Deleted.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:

(-[WKEmbeddedView initWithEmbeddedViewID:]): Deleted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didAttachToRunningProcess):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::willUpdateAttachmentAttributes):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::editableImageController): Deleted.

• UIProcess/ios/EditableImageController.h: Removed.
• UIProcess/ios/EditableImageController.messages.in: Removed.
• UIProcess/ios/EditableImageController.mm: Removed.
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::createDrawingView): Deleted.

• UIProcess/ios/PencilKitSoftLink.h: Removed.
• UIProcess/ios/PencilKitSoftLink.mm: Removed.
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
(-[WKContentView _elementDidBlur]):
(-[WKContentView _stylusSingleTapRecognized:]): Deleted.
(-[WKContentView _drawingCoordinator]): Deleted.

• UIProcess/ios/WKDrawingCoordinator.h: Removed.
• UIProcess/ios/WKDrawingCoordinator.mm: Removed.
• UIProcess/ios/WKDrawingView.h: Removed.
• UIProcess/ios/WKDrawingView.mm: Removed.
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::handleStylusSingleTapAtPoint): Deleted.

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::associateEditableImageWithAttachment): Deleted.
(WebKit::WebChromeClient::didCreateEditableImage): Deleted.
(WebKit::WebChromeClient::didDestroyEditableImage): Deleted.

• WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:

(WebKit::GraphicsLayerCARemote::createPlatformCALayerForEmbeddedView): Deleted.

• WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::createForEmbeddedView): Deleted.
(WebKit::PlatformCALayerRemote::embeddedViewID const): Deleted.

• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::layerDidEnterContext):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::isAssistableElement):
(WebKit::WebPage::getFocusedElementInformation):
(WebKit::WebPage::handleStylusSingleTapAtPoint): Deleted.

Tools:

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::drawSquareInEditableImage): Deleted.
(WTR::UIScriptController::numberOfStrokesInEditableImage): Deleted.

• TestRunnerShared/spi/PencilKitTestSPI.h: Removed.
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(webViewForTestingAttachments):
(TestWebKitAPI::forEachViewInHierarchy): Deleted.
(TestWebKitAPI::findEditableImageCanvas): Deleted.
(TestWebKitAPI::drawSquareInEditableImage): Deleted.

• TestWebKitAPI/ios/PencilKitTestSPI.h: Removed.
• WebKitTestRunner/TestController.cpp:

(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):

• WebKitTestRunner/ios/UIScriptControllerIOS.h:
• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::findEditableImageCanvas const): Deleted.
(WTR::UIScriptControllerIOS::drawSquareInEditableImage): Deleted.
(WTR::UIScriptControllerIOS::numberOfStrokesInEditableImage): Deleted.

LayoutTests:

• editing/images/basic-editable-image-expected.txt: Removed.
• editing/images/basic-editable-image-from-execCommand-expected.txt: Removed.
• editing/images/basic-editable-image-from-execCommand.html: Removed.
• editing/images/basic-editable-image-with-gesture-expected.txt: Removed.
• editing/images/basic-editable-image-with-gesture.html: Removed.
• editing/images/basic-editable-image.html: Removed.
• editing/images/editable-image-creates-attachment-expected.txt: Removed.
• editing/images/editable-image-creates-attachment.html: Removed.
• editing/images/paste-editable-image-expected.txt: Removed.
• editing/images/paste-editable-image.html: Removed.
• editing/images/redo-insert-editable-image-maintains-strokes-expected.txt: Removed.
• editing/images/redo-insert-editable-image-maintains-strokes.html: Removed.
• editing/images/reparent-editable-image-maintains-strokes-expected.txt: Removed.
• editing/images/reparent-editable-image-maintains-strokes.html: Removed.
• editing/images/undo-insert-editable-image-expected.txt: Removed.
• editing/images/undo-insert-editable-image.html: Removed.
• resources/ui-helper.js:

(window.UIHelper.drawSquareInEditableImage): Deleted.
(window.UIHelper.numberOfStrokesInEditableImage): Deleted.

6:29 PM Changeset in webkit [266341] by ysuzuki@apple.com

• 4 edits in trunk

[JSC] Use -2 for grouping options in IntlRelativeTimeFormat
​https://bugs.webkit.org/show_bug.cgi?id=215984

Reviewed by Ross Kirsling.

JSTests:

• stress/intl-relativetimeformat.js:

Source/JavaScriptCore:

Several test262 tests are failing after ICU 67. This is because Intl.RelativeTimeFormat is not using locale-sensitive grouping option.
There are hidden option -2 for UNumberFormat. It is supported so long, but it is not explicitly documented. After ICU 68, it is exposed as a constant,
we should pass -2 to UNumberFormat's grouping options to use locale-sensitive grouping option here.

• runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::initializeRelativeTimeFormat):

6:26 PM Changeset in webkit [266340] by ysuzuki@apple.com

• 5 edits
  1 add in trunk

[JSC] async function cannot appear in single-statement context
​https://bugs.webkit.org/show_bug.cgi?id=215993

Reviewed by Darin Adler.

JSTests:

• stress/async-function-lookahead.js: Added.

(testSyntax):
(testSyntaxError):
(testSyntax.false.async t):
(testSyntaxError.false.async t):

• test262/expectations.yaml:

Source/JavaScriptCore:

The following code is syntax error[1] because ExpressionStatement has async [no LineTerminator here] function lookahead.

if (false)

async function t() { }

[1]: ​https://tc39.es/ecma262/#sec-expression-statement

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::maybeParseAsyncFunctionDeclarationStatement): Deleted.

• parser/Parser.h:

6:20 PM Changeset in webkit [266339] by weinig@apple.com

• 6 edits
  1 copy
  2 adds in trunk/Source/WebCore

EnabledBySetting extended attributes on a partial interface do not get merged with EnabledBySetting extended attributes on properties of that partial interface
​https://bugs.webkit.org/show_bug.cgi?id=215992

Reviewed by Darin Adler.

Add support for merging extended attributes that support conjunctions (like EnabledBySetting) when
they are used in both a partial wide context and on a member. This allows a case like:

[

EnabledBySettings=FirstSetting

] partial interface Foo {

[EnabledBySettings=SecondSetting] attribute DOMString bar;

};

to be identical to:

partial interface Foo {

[EnabledBySettings=FirstSetting&SecondSetting] attribute DOMString bar;

};

• bindings/scripts/CodeGenerator.pm:

(MergeExtendedAttributesFromSupplemental):
Factor out and rework merging logic. Only allow adding extended attributes that are allowed for the context
they are being merge into to be merged, and only allow extended attributes declared in IDLAttributes.json as
supporting conjunctions to be merged.

(ProcessSupplementalDependencies):
Call MergeExtendedAttributesFromSupplemental for each type of member.

(ExtendedAttributeContains):
Fix variable name, since this is used for all extended attributes, not just callWith.

• bindings/scripts/IDLAttributes.json:

Add supportsConjunction keys for extended attributes that support the conjunction (&) syntax and semantics.

• bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::JSTestEnabledBySettingPrototype::finishCreation):
(WebCore::jsTestEnabledBySettingEnabledByTwoSettingsAttributeGetter):
(WebCore::jsTestEnabledBySettingEnabledByTwoSettingsAttribute):
(WebCore::setJSTestEnabledBySettingEnabledByTwoSettingsAttributeSetter):
(WebCore::setJSTestEnabledBySettingEnabledByTwoSettingsAttribute):
(WebCore::jsTestEnabledBySettingSupplementalAttributeGetter):
(WebCore::jsTestEnabledBySettingSupplementalAttribute):
(WebCore::setJSTestEnabledBySettingSupplementalAttributeSetter):
(WebCore::setJSTestEnabledBySettingSupplementalAttribute):

• bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.cpp: Added.
• bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.h: Added.
• bindings/scripts/test/SupplementalDependencies.dep:
• bindings/scripts/test/TestEnabledBySetting.idl:
• bindings/scripts/test/TestEnabledBySettingSupplemental.idl: Added.

Add/update tests.

4:16 PM Changeset in webkit [266338] by Simon Fraser

• 2 edits in trunk/Source/WebCore

REGRESSION (r266333): Mousewheel scrolling no longer works on WinCairo
​https://bugs.webkit.org/show_bug.cgi?id=215990

Reviewed by Tim Horton.

Make sure we call processWheelEventForScrolling() when ENABLE(WHEEL_EVENT_LATCHING) is not
defined.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

3:25 PM Changeset in webkit [266337] by Simon Fraser

• 3 edits
  2 adds in trunk

Rubberbanding in an overflow:scroll can trigger page jiggles
​https://bugs.webkit.org/show_bug.cgi?id=215629
<rdar://problem/67295797>

Reviewed by Tim Horton.

Source/WebCore:

When a scroller starts to rubberband, and is receiving momentum scroll events, it gets
into a state where events are ignored (to stop endless stretching). When in that
state, ScrollController::handleWheelEvent() needs to report that it handled the event,
to avoid the event bouncing to the scrolling thread and triggering page scrolls.

Test: fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle.html

• platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::handleWheelEvent):

LayoutTests:

• fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle-expected.txt: Added.
• fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle.html: Added.

3:09 PM Changeset in webkit [266336] by Simon Fraser

• 3 edits
  2 adds in trunk

REGRESSION (r266262): Scroll latching fails when scrolling into a preventDefault() region
​https://bugs.webkit.org/show_bug.cgi?id=215988
<rdar://problem/68034716>

Reviewed by Tim Horton.
Source/WebCore:

In r266262 ScrollingTreeLatchingController started to consult the "last handled wheel event"
time when deciding whether to use the latched node, but we didn't update this timestamp when
handling an event on the latched node, on the scrolling thread. So fix that.

Test: fast/scrolling/latching/latched-scroll-into-nonfast-region.html

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent):

LayoutTests:

• fast/scrolling/latching/latched-scroll-into-nonfast-region-expected.txt: Added.
• fast/scrolling/latching/latched-scroll-into-nonfast-region.html: Added.

1:24 PM Changeset in webkit [266335] by Fujii Hironori

• 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

• platform/wincairo/TestExpectations:

12:45 PM Changeset in webkit [266334] by Simon Fraser

• 1 edit
  1 add in trunk/LayoutTests

Add missing test result from r266333.

• fast/scrolling/latching/latched-scroll-remove-iframe-expected.txt: Added.

10:25 AM Changeset in webkit [266333] by Simon Fraser

• 16 edits
  3 adds
  2 deletes in trunk

Rewrite main thread scroll latching logic
​https://bugs.webkit.org/show_bug.cgi?id=215979

Reviewed by Tim Horton.
Source/WebCore:

The existing main thread wheel event handling and latching logic had a number of issues,
some of which were indicated via the FIXME comments added in r266016:

• It tracked scrollable containers as ContainerNodes rather than ScrollableAreas
• It fetched and used latched state from a different frame, causing an EventHandler to end up scrolling some unrelated frame.
• Overflow scrolling ignored latched state.
• The latching stack's purpose was unclear.

This patch fixes those issues. The design is as follow:

• Latching logic is moved into ScrollLatchingController, which is owned by Page.
• ScrollLatchingController owns a stack of FrameState.
• When receiving a wheel event, determineWheelEventTarget() identifies the target ScrollableArea, if any, for that frame only.
• As hit-testing descends into subframes, state is pushed onto ScrollLatchingController's state stack. Frames with potential scrollers have a non-null ScrollableArea in their state.
• The latched ScrollableArea is the top non-null ScrollableArea in this stack.
• EventHandler consults ScrollLatchingController for select, overflow and frame scrolling.

This change fixes an issue where scrolling over an overflow:scroll in the non-fast scrollable
region would rubber-band the overflow, rather than the main page (tested by the adjusted
fast/scrolling/mac/rubberband-overflow-in-wheel-region.html).

Tests: fast/scrolling/latching/latched-scroll-remove-iframe.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• dom/Element.cpp:

(WebCore::Element::removedFromAncestor):

• page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::determineWheelEventTarget):
(WebCore::EventHandler::processWheelEventForScrolling):
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):
(WebCore::EventHandler::processWheelEventForScrollSnap):
(WebCore::EventHandler::completeWidgetWheelEvent):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::clearLatchedState):
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::clearLatchedStateTimerFired): Deleted.
(WebCore::EventHandler::clearOrScheduleClearingLatchedStateIfNeeded): Deleted.

• page/EventHandler.h:
• page/Page.cpp:

(WebCore::Page::startMonitoringWheelEvents):
(WebCore::Page::scrollLatchingController):
(WebCore::Page::scrollLatchingControllerIfExists):
(WebCore::Page::latchingState): Deleted.
(WebCore::Page::pushNewLatchingState): Deleted.
(WebCore::Page::resetLatchingState): Deleted.
(WebCore::Page::popLatchingState): Deleted.
(WebCore::Page::removeLatchingStateForTarget): Deleted.

• page/Page.h:

(WebCore::Page::latchingStateStack const): Deleted.

• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::determineWheelEventTarget):
(WebCore::EventHandler::processWheelEventForScrolling):
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):
(WebCore::EventHandler::processWheelEventForScrollSnap):
(WebCore::deltaIsPredominantlyVertical): Deleted.
(WebCore::scrolledToEdgeInDominantDirection): Deleted.
(WebCore::latchingIsLockedToPlatformFrame): Deleted.
(WebCore::latchingIsLockedToAncestorOfThisFrame): Deleted.
(WebCore::latchedToFrameOrBody): Deleted.
(WebCore::EventHandler::clearOrScheduleClearingLatchedStateIfNeeded): Deleted.
(WebCore::frameViewForLatchingState): Deleted.

• page/scrolling/ScrollLatchingController.cpp: Added.

(WebCore::ScrollLatchingController::ScrollLatchingController):
(WebCore::ScrollLatchingController::clear):
(WebCore::ScrollLatchingController::clearOrScheduleClearIfNeeded):
(WebCore::ScrollLatchingController::clearTimerFired):
(WebCore::ScrollLatchingController::receivedWheelEvent):
(WebCore::ScrollLatchingController::latchingAllowsScrollingInFrame const):
(WebCore::ScrollLatchingController::updateLatchingStateForFrame):
(WebCore::ScrollLatchingController::getLatchingStateForFrame const):
(WebCore::ScrollLatchingController::removeLatchingStateForTarget):
(WebCore::ScrollLatchingController::removeLatchingStateForFrame):
(WebCore::deltaIsPredominantlyVertical):
(WebCore::ScrollLatchingController::shouldLatchToScrollableArea const):
(WebCore::ScrollLatchingController::hasStateForFrame const):
(WebCore::ScrollLatchingController::stateForFrame):
(WebCore::ScrollLatchingController::stateForFrame const):
(WebCore::ScrollLatchingController::dump const):
(WebCore::operator<<):

• page/scrolling/ScrollLatchingController.h: Added.

(WebCore::ScrollLatchingController::cumulativeEventDelta const):

• page/scrolling/ScrollLatchingState.cpp: Removed.
• page/scrolling/ScrollLatchingState.h: Removed.
• page/scrolling/ScrollingTreeLatchingController.cpp:

(WebCore::ScrollingTreeLatchingController::receivedWheelEvent):
(WebCore::ScrollingTreeLatchingController::nodeDidHandleEvent):

• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):

• page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalStretching const):
(WebCore::newGestureIsStarting): Deleted.

• platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::isGestureStart const):
(WebCore::PlatformWheelEvent::isGestureContinuation const):
(WebCore::PlatformWheelEvent::shouldResetLatching const):
(WebCore::PlatformWheelEvent::isNonGestureEvent const):
(WebCore::PlatformWheelEvent::shouldConsiderLatching const): Deleted. Renamed to isGestureStart(). This class
should not prescribe latching behaviors.

LayoutTests:

Add a test for iframe unparenting in the middle of a latched scroll.

• fast/scrolling/latching/latched-scroll-remove-iframe.html: Added.
• fast/scrolling/latching/scroll-nested-iframe.html: 1000ms -> 0ms
• fast/scrolling/mac/rubberband-overflow-in-wheel-region.html: Test needs to latch the overflow by scrolling down then up.

2:53 AM Changeset in webkit [266332] by youenn@apple.com

• 26 edits
  5 adds in trunk

Add support for TextEncoderStream
​https://bugs.webkit.org/show_bug.cgi?id=215916

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/idlharness.any-expected.txt:
• web-platform-tests/encoding/idlharness.any.worker-expected.txt:
• web-platform-tests/encoding/streams/backpressure.any-expected.txt:
• web-platform-tests/encoding/streams/backpressure.any.worker-expected.txt:
• web-platform-tests/encoding/streams/encode-bad-chunks.any-expected.txt:
• web-platform-tests/encoding/streams/encode-bad-chunks.any.worker-expected.txt:
• web-platform-tests/encoding/streams/encode-utf8.any-expected.txt:
• web-platform-tests/encoding/streams/encode-utf8.any.worker-expected.txt:
• web-platform-tests/encoding/streams/readable-writable-properties.any-expected.txt:
• web-platform-tests/encoding/streams/readable-writable-properties.any.worker-expected.txt:
• web-platform-tests/encoding/streams/realms.window-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:

Source/WebCore:

Implement TextEncoderStream as a JS built-in.
It is controlled by transform stream runtime flag.

TextEncoderStream takes a TransformStream and TextEncoderStreamEncoder as private slots.
Add TextEncoderStreamEncoder to implement the actual UTF-8 encoding steps.
Covered by rebased tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/streams/TransformStream.idl:
• Modules/streams/TransformStream.js:

(initializeTransformStream):

• Modules/streams/TransformStreamInternals.js:

(createTransformStream):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• dom/TextEncoderStream.idl: Added.
• dom/TextEncoderStream.js: Added.

(initializeTextEncoderStream):
(getter.encoding):
(getter.readable):
(getter.writable):

• dom/TextEncoderStreamEncoder.cpp: Added.

(WebCore::TextEncoderStreamEncoder::encode):
(WebCore::TextEncoderStreamEncoder::flush):

• dom/TextEncoderStreamEncoder.h: Added.

(WebCore::TextEncoderStreamEncoder::create):

• dom/TextEncoderStreamEncoder.idl: Added.

LayoutTests:

• TestExpectations:

2:40 AM Changeset in webkit [266331] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[GTK] REGRESSION(r150392) insufficient space allocation results in heap corruption
​https://bugs.webkit.org/show_bug.cgi?id=215976

Patch by Jim Mason <​jmason@ibinx.com> on 2020-08-30
Reviewed by Carlos Garcia Campos.

• wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::TimerBase::TimerBase):